Build failed in Jenkins: plasma-framework_master_qt5 #710
See http://build.kde.org/job/plasma-framework_master_qt5/710/ -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace http://build.kde.org/job/plasma-framework_master_qt5/ws/ Running Prebuild steps [plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson8562171019780716667.sh + /home/jenkins/scripts/setup-env.sh From git://anongit.kde.org/plasma-framework 6c27cc0..33dae6b master - origin/master * [new branch] plasmaview - origin/plasmaview * [new branch] terietor/plasmaview - origin/terietor/plasmaview Branch jenkins set up to track remote branch master from origin. Success build forhudson.tasks.Shell@57a1760b Checkout:plasma-framework_master_qt5 / http://build.kde.org/job/plasma-framework_master_qt5/ws/ - hudson.remoting.Channel@2d43b0fe:LinuxSlave - 3 Using strategy: Default Last Built Revision: Revision 33dae6b18c5760ebf69a974604dce1c0ec779380 (refs/heads/jenkins) Fetching changes from 1 remote Git repository Fetching upstream changes from origin Commencing build of Revision 33dae6b18c5760ebf69a974604dce1c0ec779380 (refs/heads/jenkins) Checking out Revision 33dae6b18c5760ebf69a974604dce1c0ec779380 (refs/heads/jenkins) [plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson7650020467385908033.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: plasma-framework - Branch master == Build Dependencies: attica - Branch master strigiclient - Branch master qt5 - Branch dev strigiutils - Branch master libstreams - Branch master libstreamanalyzer - Branch master strigidaemon - Branch master extra-cmake-modules - Branch master kdelibs - Branch frameworks == Cleaning Source Tree HEAD is now at 33dae6b support for setting a wallpaper trough drag and drop Removing build/ == Applying Patches === No patches to apply == Syncing Dependencies from Master Server Write failed: Broken pipe rsync: connection unexpectedly closed (212683 bytes received so far) [receiver] rsync error: error in rsync protocol data stream (code 12) at io.c(605) [receiver=3.0.9] rsync: connection unexpectedly closed (212 bytes received so far) [generator] rsync error: unexplained error (code 255) at io.c(605) [generator=3.0.9] Syncing dependencies from master server for project plasma-framework failed. Build step 'Execute shell' marked build as failure [WARNINGS] Skipping publisher since build result is FAILURE Skipping Cobertura coverage report as build was not UNSTABLE or better ... Recording test results ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112660: KPluginInfo rework for KPluginTrader
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112660/#review39793 --- staging/kservice/src/services/kplugininfo.cpp http://git.reviewboard.kde.org/r/112660/#comment29340 I think that two variables (hidden and _hidden) so similar are confusing. staging/kservice/src/services/kplugininfo.cpp http://git.reviewboard.kde.org/r/112660/#comment29339 In kdelibs I don't usually see private members in the _variable form, but m_variable. Nevertheless, members of a private class don't usually have any underscore or m_, because when accessing them as d-name makes it clear that they are private. Probably you have a reason, though :-) . - David Gil Oliva On Sept. 10, 2013, 11:32 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112660/ --- (Updated Sept. 10, 2013, 11:32 p.m.) Review request for KDE Frameworks and David Faure. Description --- This patch prepares KPluginInfo for usage with KPluginTrader (to be submitted in a separate patch). It basically makes KPluginInfo's API a little bit more like KService by adding a property(QString) accessor to the plugin info. This allows us on the one hand Part of this patch, and much of its churn, is the internal change from independent QStrings and QStringLists to a QVariantMap. This is how the metadata comes in from KPlugin*, and it allows us to make properties accessible by name. There's also a fair bit of moving from QLatin1String to QStringLiteral in there, most of these lines needed changes anyway. Additionally, the keys of properties are now shared in the d-pointer. This change is source compatible to the old version. Diffs - staging/kservice/src/services/kplugininfo.cpp 21e0882 Diff: http://git.reviewboard.kde.org/r/112660/diff/ Testing --- All tests still pass, no regressions encountered otherwise. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112633: Modify KTextWidgets CMakeLists.txt for splitting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112633/#review39797 --- This review has been submitted with commit a26460734f838d498b63b3b4f78e880160e9d3f4 by Martin Klapetek to branch frameworks. - Commit Hook On Sept. 10, 2013, 9:35 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112633/ --- (Updated Sept. 10, 2013, 9:35 a.m.) Review request for KDE Frameworks. Description --- Adds dependencies to installed cmake file and splits qt version to separate variable Diffs - staging/ktextwidgets/CMakeLists.txt 0819c2d staging/ktextwidgets/KTextWidgetsConfig.cmake.in 9f46933 Diff: http://git.reviewboard.kde.org/r/112633/diff/ Testing --- Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112633: Modify KTextWidgets CMakeLists.txt for splitting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112633/ --- (Updated Sept. 11, 2013, 7:27 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Description --- Adds dependencies to installed cmake file and splits qt version to separate variable Diffs - staging/ktextwidgets/CMakeLists.txt 0819c2d staging/ktextwidgets/KTextWidgetsConfig.cmake.in 9f46933 Diff: http://git.reviewboard.kde.org/r/112633/diff/ Testing --- Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 #711
See http://build.kde.org/job/plasma-framework_master_qt5/711/changes Changes: [scripty] SVN_SILENT made messages (.desktop file) [mgraesslin] QQuick item for live updating window thumbnails -- [...truncated 444 lines...] Generating moc_qmenuitem.cpp Generating moc_qrangemodel.cpp Generating moc_units.cpp [ 11%] Built target plasmacomponentsplugin_automoc Generating sourcesOnRequest.moc Generating moc_sourcesOnRequest.cpp Generating simpleEngine.moc Generating moc_simpleEngine.cpp [ 11%] [ 11%] Built target plasma_dataengine_example_simpleEngine_automoc Built target plasma_dataengine_example_sourcesOnRequest_automoc Generating moc_columnproxymodel.cpp Generating moc_mouseeventlistener.cpp Generating moc_qiconitem.cpp Generating moc_qimageitem.cpp Generating moc_qpixmapitem.cpp Generating moc_qtextracomponentsplugin.cpp [ 11%] Built target qtextracomponentsplugin_automoc Generating moc_dialogshadows_p.cpp Generating framesvgitem.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/framesvgitem.cpp:0: Note: No relevant classes found. No output generated. Generating customDataContainersEngine.moc Generating httpContainer.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/examples/dataengines/customDataContainers/httpContainer.cpp:0: Note: No relevant classes found. No output generated. Scanning dependencies of target dirmodelplugin Scanning dependencies of target platformcomponentsplugin Scanning dependencies of target fullmodelaccesstest [ 12%] [ 13%] Building CXX object src/declarativeimports/dirmodel/CMakeFiles/dirmodelplugin.dir/dirmodel.cpp.o Building CXX object src/declarativeimports/platformcomponents/CMakeFiles/platformcomponentsplugin.dir/platformextensionplugin.cpp.o Scanning dependencies of target draganddropplugin [ 14%] Generating iconitem.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/iconitem.cpp:0: Note: No relevant classes found. No output generated. Building CXX object src/declarativeimports/qtextracomponents/tests/CMakeFiles/fullmodelaccesstest.dir/columnproxymodeltest.cpp.o cc1plus: error: unrecognized command line option ‘-std=c++11’ make[2]: *** [src/declarativeimports/platformcomponents/CMakeFiles/platformcomponentsplugin.dir/platformextensionplugin.cpp.o] Error 1 make[1]: *** [src/declarativeimports/platformcomponents/CMakeFiles/platformcomponentsplugin.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs [ 14%] [ 14%] Building CXX object src/declarativeimports/qtextracomponents/tests/CMakeFiles/fullmodelaccesstest.dir/__/columnproxymodel.cpp.o Building CXX object src/declarativeimports/draganddrop/CMakeFiles/draganddropplugin.dir/draganddropplugin.cpp.o Generating moc_customDataContainersEngine.cpp Generating moc_httpContainer.cpp [ 14%] Built target plasma_dataengine_example_customDataContainers_automoc [ 15%] Building CXX object src/declarativeimports/qtextracomponents/tests/CMakeFiles/fullmodelaccesstest.dir/__/__/core/tests/modeltest.cpp.o Generating runnermodel.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/runnermodel.cpp:0: Note: No relevant classes found. No output generated. Generating serviceoperationstatus.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/serviceoperationstatus.cpp:0: Note: No relevant classes found. No output generated. Generating svgitem.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/svgitem.cpp:0: Note: No relevant classes found. No output generated. Generating moc_appletinterface.cpp Generating moc_containmentinterface.cpp Generating declarativeappletscript.moc Generating moc_wallpaperinterface.cpp Generating moc_declarativeappletscript.cpp [ 15%] Built target plasma_appletscript_declarative_automoc [ 15%] Building CXX object src/declarativeimports/qtextracomponents/tests/CMakeFiles/fullmodelaccesstest.dir/fullmodelaccesstest_automoc.cpp.o Generating moc_configview.cpp Generating moc_containmentconfigview.cpp Generating moc_currentcontainmentactionsmodel.cpp Generating moc_panelconfigview.cpp Generating moc_panelshadows_p.cpp Generating moc_panelview.cpp Generating appinterface.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/shell/scripting/appinterface.cpp:0: Note: No relevant classes found. No output generated. http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/qtextracomponents/columnproxymodel.cpp:162:6: warning: unused parameter ‘source’ [-Wunused-parameter] Generating applet.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/shell/scripting/applet.cpp:0: Note: No relevant classes found. No output generated. Generating configgroup.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/shell/scripting/configgroup.cpp:0: Note: No relevant classes found. No output generated. Generating containment.moc
Build failed in Jenkins: plasma-framework_master_qt5 #712
See http://build.kde.org/job/plasma-framework_master_qt5/712/changes Changes: [notmart] specify thumbnails in the name -- [...truncated 442 lines...] Scanning dependencies of target plasma_dataengine_example_customDataContainers_automoc [ 11%] Automoc for target plasma_dataengine_example_customDataContainers Generating moc_qmenu.cpp Generating moc_qmenuitem.cpp Generating moc_qrangemodel.cpp Generating moc_units.cpp [ 11%] Built target plasmacomponentsplugin_automoc Generating simpleEngine.moc Generating moc_simpleEngine.cpp [ 11%] Built target plasma_dataengine_example_simpleEngine_automoc Generating iconitem.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/iconitem.cpp:0: Note: No relevant classes found. No output generated. Scanning dependencies of target dirmodelplugin Generating sourcesOnRequest.moc Generating moc_sourcesOnRequest.cpp [ 11%] [ 12%] Built target plasma_dataengine_example_sourcesOnRequest_automoc Building CXX object src/declarativeimports/dirmodel/CMakeFiles/dirmodelplugin.dir/dirmodel.cpp.o Generating runnermodel.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/runnermodel.cpp:0: Note: No relevant classes found. No output generated. Generating customDataContainersEngine.moc Generating httpContainer.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/examples/dataengines/customDataContainers/httpContainer.cpp:0: Note: No relevant classes found. No output generated. Scanning dependencies of target draganddropplugin [ 12%] Building CXX object src/declarativeimports/draganddrop/CMakeFiles/draganddropplugin.dir/draganddropplugin.cpp.o Generating serviceoperationstatus.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/serviceoperationstatus.cpp:0: Note: No relevant classes found. No output generated. Scanning dependencies of target fullmodelaccesstest [ 13%] Building CXX object src/declarativeimports/qtextracomponents/tests/CMakeFiles/fullmodelaccesstest.dir/columnproxymodeltest.cpp.o Generating moc_columnproxymodel.cpp Generating moc_mouseeventlistener.cpp Generating moc_qiconitem.cpp Generating moc_qimageitem.cpp Generating moc_qpixmapitem.cpp Generating moc_qtextracomponentsplugin.cpp [ 13%] Generating moc_customDataContainersEngine.cpp Generating moc_httpContainer.cpp Built target qtextracomponentsplugin_automoc [ 13%] [ 13%] Building CXX object src/declarativeimports/qtextracomponents/tests/CMakeFiles/fullmodelaccesstest.dir/__/columnproxymodel.cpp.o Built target plasma_dataengine_example_customDataContainers_automoc [ 14%] Building CXX object src/declarativeimports/draganddrop/CMakeFiles/draganddropplugin.dir/DeclarativeDragArea.cpp.o Generating svgitem.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/svgitem.cpp:0: Note: No relevant classes found. No output generated. Generating moc_appletinterface.cpp Generating moc_containmentinterface.cpp Generating declarativeappletscript.moc Generating moc_wallpaperinterface.cpp Generating moc_declarativeappletscript.cpp [ 14%] Built target plasma_appletscript_declarative_automoc [ 14%] Building CXX object src/declarativeimports/dirmodel/CMakeFiles/dirmodelplugin.dir/dirmodelplugin.cpp.o Generating moc_configview.cpp Generating moc_containmentconfigview.cpp Generating moc_currentcontainmentactionsmodel.cpp Generating moc_panelconfigview.cpp Generating moc_panelshadows_p.cpp Generating moc_panelview.cpp Generating appinterface.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/shell/scripting/appinterface.cpp:0: Note: No relevant classes found. No output generated. Generating applet.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/shell/scripting/applet.cpp:0: Note: No relevant classes found. No output generated. Generating configgroup.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/shell/scripting/configgroup.cpp:0: Note: No relevant classes found. No output generated. Generating containment.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/shell/scripting/containment.cpp:0: Note: No relevant classes found. No output generated. Generating desktopscriptengine.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/shell/scripting/desktopscriptengine.cpp:0: Note: No relevant classes found. No output generated. http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/qtextracomponents/columnproxymodel.cpp:162:6: warning: unused parameter ‘source’ [-Wunused-parameter] In file included from /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/KMimeType:1:0, from http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/dirmodel/dirmodel.cpp:29: /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/../kmimetype.h:54:42: warning: ‘KMimeType’ is deprecated
Dependency specifications
Hi, Currently, the specification for Qt dependencies is not always consistent between tier1 frameworks. In particular, I notice dependencies being specified twice (eg. QtTest in both project root and in autotests), and test dependencies split (eg. QtTest in project root only, and QtXml in autotests only). What is the intended behaviour? All dependencies specified in the project root? Common dependencies specified in the project root, and specific dependencies in directories that require them? Something else? Best regards, Michael ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 #713
See http://build.kde.org/job/plasma-framework_master_qt5/713/changes Changes: [notmart] shell/containmentconfigview.cpp - plasmaview/containmentconfigview.cpp [notmart] make use of the plasmaview [notmart] add the plasmaview subdir [notmart] add plasmaview/CMakeLists.txt [notmart] add plasmaview/PlasmaViewConfig.cmake.in [notmart] add plasmaview/includes/ [notmart] use d pointer in view [notmart] don't install currentcontainmentactionsmodel.h [notmart] use d pointer in containmentconfigview [notmart] currentcontainmentactionsmodel.cpp - currentcontainmentactionsmodel_p.cpp [notmart] shell/configview.cpp - plasmaview/configview.cpp [notmart] use d_ptr in configview [notmart] remove configview.cpp [notmart] include the right header [notmart] make it protected again [notmart] add apidocs for the View [notmart] remove unneeded code [notmart] Revert use d pointer in containmentconfigview [notmart] don't install containmentconfigview.h [notmart] add some apidocs [notmart] src/plasmaview/containmentconfigview.cpp - src/plasmaview/containmentconfigview_p.cpp [notmart] shell/shellpluginloader.cpp - plasmaview/shellpluginloader.cpp [notmart] shell/shellpackage.cpp - plasmaview/shellpackage_p.cpp [notmart] build the shellpackage again [notmart] use d_ptr in shellpluginloader [notmart] add apidocs for the shellpluginloader [notmart] add some more apidocs in the configview [notmart] add includes/PlasmaView/ShellPluginLoader [notmart] don't include the file, we don't need it [notmart] use variable names instead of KF5:: [notmart] KF5::plasmaview - KF5::PlasmaView [notmart] don't export ConfigCategory [notmart] add the missing include [notmart] move shellpluginloader back to shell [notmart] KF5::plasmaview - KF5::PlasmaView [notmart] fix build [terietor] remove the TODOs, they are done [terietor] we don't have these headers anymore so don't install their FooBar -- [...truncated 571 lines...] [ 11%] Building CXX object src/declarativeimports/draganddrop/CMakeFiles/draganddropplugin.dir/DeclarativeDragDropEvent.cpp.o [ 12%] Building CXX object src/declarativeimports/draganddrop/CMakeFiles/draganddropplugin.dir/DeclarativeDropArea.cpp.o In file included from http://build.kde.org/job/plasma-framework_master_qt5/ws/src/plasma/pluginloader.cpp:27:0: /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kglobal.h: In function ‘T KGlobal::findDirectChild(const QObject*)’: /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kglobal.h:514:31: warning: ‘QObject* KGlobal::findDirectChild_helper(const QObject*, const QMetaObject)’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kglobal.h:504) [-Wdeprecated-declarations] http://build.kde.org/job/plasma-framework_master_qt5/ws/src/plasma/pluginloader.cpp: In member function ‘Plasma::DataEngine* Plasma::PluginLoader::loadDataEngine(const QString)’: http://build.kde.org/job/plasma-framework_master_qt5/ws/src/plasma/pluginloader.cpp:257:63: warning: ‘KPluginInfo::KPluginInfo(KService::Ptr)’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kplugininfo.h:114) [-Wdeprecated-declarations] [ 12%] Building CXX object src/plasma/CMakeFiles/plasma.dir/version.cpp.o [ 12%] Building CXX object src/declarativeimports/draganddrop/CMakeFiles/draganddropplugin.dir/DeclarativeMimeData.cpp.o Generating moc_shellcorona.cpp Generating moc_widgetexplorer.cpp Generating moc_appinterface.cpp Generating moc_applet.cpp Generating moc_configgroup.cpp Generating moc_containment.cpp Generating moc_desktopscriptengine.cpp Generating moc_layouttemplatepackagestructure.cpp Generating moc_panel.cpp Generating moc_scriptengine.cpp Generating moc_widget.cpp Generating moc_shellmanager.cpp Generating moc_kcategorizeditemsviewmodels_p.cpp Generating moc_plasmaappletitemmodel_p.cpp Generating moc_widgetexplorerview.cpp [ 12%] Built target plasma-shell_automoc [ 12%] Building CXX object src/declarativeimports/dirmodel/CMakeFiles/dirmodelplugin.dir/dirmodelplugin_automoc.cpp.o [ 13%] Building CXX object src/declarativeimports/draganddrop/CMakeFiles/draganddropplugin.dir/draganddropplugin_automoc.cpp.o Linking CXX shared library ../../../lib/libdirmodelplugin.so Scanning dependencies of target fullmodelaccesstest [ 14%] Building CXX object src/declarativeimports/qtextracomponents/tests/CMakeFiles/fullmodelaccesstest.dir/columnproxymodeltest.cpp.o [ 15%] Building CXX object src/plasma/CMakeFiles/plasma.dir/private/componentinstaller.cpp.o [ 15%] Built target dirmodelplugin [ 15%] Building CXX object src/declarativeimports/qtextracomponents/tests/CMakeFiles/fullmodelaccesstest.dir/__/columnproxymodel.cpp.o [ 15%] Building CXX object src/plasma/CMakeFiles/plasma.dir/abstractrunner.cpp.o Linking CXX shared library ../../../lib/libdraganddropplugin.so
Jenkins build became unstable: kdelibs_frameworks_qt5 #1177
See http://build.kde.org/job/kdelibs_frameworks_qt5/1177/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 #714
See http://build.kde.org/job/plasma-framework_master_qt5/714/changes Changes: [notmart] libplasmaview - libplsmaquick -- [...truncated 547 lines...] http://build.kde.org/job/plasma-framework_master_qt5/ws/examples/dataengines/customDataContainers/httpContainer.cpp:0: Note: No relevant classes found. No output generated. Building CXX object src/declarativeimports/draganddrop/CMakeFiles/draganddropplugin.dir/draganddropplugin.cpp.o Building CXX object src/declarativeimports/dirmodel/CMakeFiles/dirmodelplugin.dir/dirmodel.cpp.o Generating layouttemplatepackagestructure.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/shell/scripting/layouttemplatepackagestructure.cpp:0: Note: No relevant classes found. No output generated. Generating moc_customDataContainersEngine.cpp Generating moc_httpContainer.cpp [ 13%] Built target plasma_dataengine_example_customDataContainers_automoc [ 14%] Building CXX object src/declarativeimports/dirmodel/CMakeFiles/dirmodelplugin.dir/dirmodelplugin.cpp.o Generating panel.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/shell/scripting/panel.cpp:0: Note: No relevant classes found. No output generated. Scanning dependencies of target plasma Generating scriptengine.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/shell/scripting/scriptengine.cpp:0: Note: No relevant classes found. No output generated. [ 14%] Building CXX object src/plasma/CMakeFiles/plasma.dir/plasma.cpp.o Generating widget.moc http://build.kde.org/job/plasma-framework_master_qt5/ws/src/shell/scripting/widget.cpp:0: Note: No relevant classes found. No output generated. In file included from /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/KMimeType:1:0, from http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/dirmodel/dirmodel.cpp:29: /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/../kmimetype.h:54:42: warning: ‘KMimeType’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/../kmimetype.h:50) [-Wdeprecated-declarations] [ 15%] Building CXX object src/plasma/CMakeFiles/plasma.dir/pluginloader.cpp.o Scanning dependencies of target fullmodelaccesstest [ 16%] Building CXX object src/declarativeimports/qtextracomponents/tests/CMakeFiles/fullmodelaccesstest.dir/columnproxymodeltest.cpp.o [ 16%] Building CXX object src/declarativeimports/dirmodel/CMakeFiles/dirmodelplugin.dir/dirmodelplugin_automoc.cpp.o [ 17%] Building CXX object src/declarativeimports/draganddrop/CMakeFiles/draganddropplugin.dir/DeclarativeDragArea.cpp.o Linking CXX shared library ../../../lib/libdirmodelplugin.so In file included from http://build.kde.org/job/plasma-framework_master_qt5/ws/src/plasma/pluginloader.cpp:27:0: /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kglobal.h: In function ‘T KGlobal::findDirectChild(const QObject*)’: /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kglobal.h:514:31: warning: ‘QObject* KGlobal::findDirectChild_helper(const QObject*, const QMetaObject)’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kglobal.h:504) [-Wdeprecated-declarations] http://build.kde.org/job/plasma-framework_master_qt5/ws/src/plasma/pluginloader.cpp: In member function ‘Plasma::DataEngine* Plasma::PluginLoader::loadDataEngine(const QString)’: http://build.kde.org/job/plasma-framework_master_qt5/ws/src/plasma/pluginloader.cpp:257:63: warning: ‘KPluginInfo::KPluginInfo(KService::Ptr)’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kplugininfo.h:114) [-Wdeprecated-declarations] [ 17%] Built target dirmodelplugin [ 17%] Building CXX object src/declarativeimports/qtextracomponents/tests/CMakeFiles/fullmodelaccesstest.dir/__/columnproxymodel.cpp.o Generating moc_shellcorona.cpp Generating moc_widgetexplorer.cpp Generating moc_appinterface.cpp Generating moc_applet.cpp Generating moc_configgroup.cpp Generating moc_containment.cpp Generating moc_desktopscriptengine.cpp Generating moc_layouttemplatepackagestructure.cpp Generating moc_panel.cpp Generating moc_scriptengine.cpp Generating moc_widget.cpp Generating moc_shellmanager.cpp Generating moc_kcategorizeditemsviewmodels_p.cpp Generating moc_plasmaappletitemmodel_p.cpp Generating moc_widgetexplorerview.cpp [ 17%] Built target plasma-shell_automoc [ 18%] Building CXX object src/declarativeimports/qtextracomponents/tests/CMakeFiles/fullmodelaccesstest.dir/__/__/core/tests/modeltest.cpp.o http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/draganddrop/DeclarativeDragArea.cpp:207:6: warning: unused parameter ‘event’ [-Wunused-parameter] In file included from /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/qtest_kde.h:28:0,
Build failed in Jenkins: plasma-framework_master_qt5 #715
See http://build.kde.org/job/plasma-framework_master_qt5/715/changes Changes: [notmart] just use c++0x for now -- [...truncated 861 lines...] Building CXX object src/declarativeimports/core/tests/CMakeFiles/runnermodeltest.dir/main.cpp.o [ 54%] Built target runnercontexttest [ 55%] [ 56%] Building CXX object src/declarativeimports/core/tests/CMakeFiles/runnermodeltest.dir/dynamictreemodel.cpp.o Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/theme.cpp.o Linking CXX executable storagetest [ 56%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/datamodel.cpp.o [ 56%] Building CXX object src/declarativeimports/core/tests/CMakeFiles/runnermodeltest.dir/modeltest.cpp.o [ 56%] Built target storagetest [ 57%] Building CXX object src/declarativeimports/core/tests/CMakeFiles/runnermodeltest.dir/__/runnermodel.cpp.o [ 58%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/datasource.cpp.o http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp: In member function ‘void ModelTest::nonDestructiveBasicTest()’: http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp:128:19: warning: variable ‘flags’ set but not used [-Wunused-but-set-variable] http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp: In member function ‘void ModelTest::hasIndex()’: http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp:208:9: warning: unused variable ‘columns’ [-Wunused-variable] http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp: In member function ‘void ModelTest::index()’: http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp:233:9: warning: unused variable ‘columns’ [-Wunused-variable] http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp:243:17: warning: variable ‘a’ set but not used [-Wunused-but-set-variable] http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp:244:17: warning: variable ‘b’ set but not used [-Wunused-but-set-variable] http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp: In member function ‘void ModelTest::parent()’: http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp:277:21: warning: variable ‘childIndex’ set but not used [-Wunused-but-set-variable] http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp:286:21: warning: variable ‘childIndex’ set but not used [-Wunused-but-set-variable] http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp:287:21: warning: variable ‘childIndex1’ set but not used [-Wunused-but-set-variable] http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp: In member function ‘void ModelTest::checkChildren(const QModelIndex, int)’: http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp:354:25: warning: variable ‘modifiedIndex’ set but not used [-Wunused-but-set-variable] http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp:358:25: warning: variable ‘a’ set but not used [-Wunused-but-set-variable] http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp:359:25: warning: variable ‘b’ set but not used [-Wunused-but-set-variable] http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp:393:25: warning: variable ‘newerIndex’ set but not used [-Wunused-but-set-variable] http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp: In member function ‘void ModelTest::data()’: http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp:445:13: warning: unused variable ‘alignment’ [-Wunused-variable] http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp:463:13: warning: unused variable ‘state’ [-Wunused-variable] http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp: At global scope: http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp:475:6: warning: unused parameter ‘end’ [-Wunused-parameter] http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/core/tests/modeltest.cpp:494:6: warning: unused parameter ‘parent’ [-Wunused-parameter] Scanning
Jenkins build is back to normal : plasma-framework_master_qt5 #716
See http://build.kde.org/job/plasma-framework_master_qt5/716/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 112665: Drop Obsolete modules from ECM
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112665/ --- Review request for KDE Frameworks. Description --- ECMVersion.cmake and ECMWriteVersionHeader.cmake are both obsoleted by ecm_setup_version and are not used anywhere. Keeping them around isn't necessary anymore. Diffs - modules/ECMVersion.cmake ccac31b modules/ECMWriteVersionHeader.cmake 4521cc3 Diff: http://git.reviewboard.kde.org/r/112665/diff/ Testing --- Thanks, Christophe Giboudeaux ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112660: KPluginInfo rework for KPluginTrader
On Sept. 11, 2013, 6:22 a.m., David Gil Oliva wrote: staging/kservice/src/services/kplugininfo.cpp, line 61 http://git.reviewboard.kde.org/r/112660/diff/1/?file=188728#file188728line61 I think that two variables (hidden and _hidden) so similar are confusing. Hm, I think it's pretty clear, especially since _hidden is defined above it. The _ signifies here that it's just caching a string. I don't see any part in the code where it's ambigious. Question: How long did it take you to understand it? Do others mind this part? (If not, I'd rather drop this issue, since it's really clear in every call either of these vars is involved.) On Sept. 11, 2013, 6:22 a.m., David Gil Oliva wrote: staging/kservice/src/services/kplugininfo.cpp, line 67 http://git.reviewboard.kde.org/r/112660/diff/1/?file=188728#file188728line67 In kdelibs I don't usually see private members in the _variable form, but m_variable. Nevertheless, members of a private class don't usually have any underscore or m_, because when accessing them as d-name makes it clear that they are private. Probably you have a reason, though :-) . Members in the d-pointer usually don't have the m_ prefix, they're just written in lower case. Maybe you're confusing this with members of the actual class (which, indeed, use m_ normally)? - Sebastian --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112660/#review39793 --- On Sept. 10, 2013, 11:32 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112660/ --- (Updated Sept. 10, 2013, 11:32 p.m.) Review request for KDE Frameworks and David Faure. Description --- This patch prepares KPluginInfo for usage with KPluginTrader (to be submitted in a separate patch). It basically makes KPluginInfo's API a little bit more like KService by adding a property(QString) accessor to the plugin info. This allows us on the one hand Part of this patch, and much of its churn, is the internal change from independent QStrings and QStringLists to a QVariantMap. This is how the metadata comes in from KPlugin*, and it allows us to make properties accessible by name. There's also a fair bit of moving from QLatin1String to QStringLiteral in there, most of these lines needed changes anyway. Additionally, the keys of properties are now shared in the d-pointer. This change is source compatible to the old version. Diffs - staging/kservice/src/services/kplugininfo.cpp 21e0882 Diff: http://git.reviewboard.kde.org/r/112660/diff/ Testing --- All tests still pass, no regressions encountered otherwise. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112665: Drop Obsolete modules from ECM
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112665/#review39814 --- Ship it! Ship It! - Stephen Kelly On Sept. 11, 2013, 9:44 a.m., Christophe Giboudeaux wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112665/ --- (Updated Sept. 11, 2013, 9:44 a.m.) Review request for KDE Frameworks. Description --- ECMVersion.cmake and ECMWriteVersionHeader.cmake are both obsoleted by ecm_setup_version and are not used anywhere. Keeping them around isn't necessary anymore. Diffs - modules/ECMVersion.cmake ccac31b modules/ECMWriteVersionHeader.cmake 4521cc3 Diff: http://git.reviewboard.kde.org/r/112665/diff/ Testing --- Thanks, Christophe Giboudeaux ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112665: Drop Obsolete modules from ECM
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112665/#review39816 --- This review has been submitted with commit 75887108189813f3c05266e863041cd47a986100 by Christophe Giboudeaux to branch master. - Commit Hook On Sept. 11, 2013, 9:44 a.m., Christophe Giboudeaux wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112665/ --- (Updated Sept. 11, 2013, 9:44 a.m.) Review request for KDE Frameworks. Description --- ECMVersion.cmake and ECMWriteVersionHeader.cmake are both obsoleted by ecm_setup_version and are not used anywhere. Keeping them around isn't necessary anymore. Diffs - modules/ECMVersion.cmake ccac31b modules/ECMWriteVersionHeader.cmake 4521cc3 Diff: http://git.reviewboard.kde.org/r/112665/diff/ Testing --- Thanks, Christophe Giboudeaux ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112660: KPluginInfo rework for KPluginTrader
On Sept. 11, 2013, 6:22 a.m., David Gil Oliva wrote: staging/kservice/src/services/kplugininfo.cpp, line 61 http://git.reviewboard.kde.org/r/112660/diff/1/?file=188728#file188728line61 I think that two variables (hidden and _hidden) so similar are confusing. Sebastian Kügler wrote: Hm, I think it's pretty clear, especially since _hidden is defined above it. The _ signifies here that it's just caching a string. I don't see any part in the code where it's ambigious. Question: How long did it take you to understand it? Do others mind this part? (If not, I'd rather drop this issue, since it's really clear in every call either of these vars is involved.) Hmmm, I think you're taking it too seriously... I wouldn't have two variables so similar to each other in my code, but if you think it's ok, please drop it! Yes, you're right, I didn't take it too long to understand your code, but I don't think reviews are meant to be so profound. If I see something that I don't see clear, I say so. I think I don't deserve your tone, because I did it with my best intention. On Sept. 11, 2013, 6:22 a.m., David Gil Oliva wrote: staging/kservice/src/services/kplugininfo.cpp, line 67 http://git.reviewboard.kde.org/r/112660/diff/1/?file=188728#file188728line67 In kdelibs I don't usually see private members in the _variable form, but m_variable. Nevertheless, members of a private class don't usually have any underscore or m_, because when accessing them as d-name makes it clear that they are private. Probably you have a reason, though :-) . Sebastian Kügler wrote: Members in the d-pointer usually don't have the m_ prefix, they're just written in lower case. Maybe you're confusing this with members of the actual class (which, indeed, use m_ normally)? Members in the d-pointer usually don't have the m_ prefix Yes, I know, that's because I was confused with the _ prefix. Maybe you're confusing this with members of the actual class (which, indeed, use m_ normally)? No, I'm not :-) - David --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112660/#review39793 --- On Sept. 10, 2013, 11:32 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112660/ --- (Updated Sept. 10, 2013, 11:32 p.m.) Review request for KDE Frameworks and David Faure. Description --- This patch prepares KPluginInfo for usage with KPluginTrader (to be submitted in a separate patch). It basically makes KPluginInfo's API a little bit more like KService by adding a property(QString) accessor to the plugin info. This allows us on the one hand Part of this patch, and much of its churn, is the internal change from independent QStrings and QStringLists to a QVariantMap. This is how the metadata comes in from KPlugin*, and it allows us to make properties accessible by name. There's also a fair bit of moving from QLatin1String to QStringLiteral in there, most of these lines needed changes anyway. Additionally, the keys of properties are now shared in the d-pointer. This change is source compatible to the old version. Diffs - staging/kservice/src/services/kplugininfo.cpp 21e0882 Diff: http://git.reviewboard.kde.org/r/112660/diff/ Testing --- All tests still pass, no regressions encountered otherwise. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112660: KPluginInfo rework for KPluginTrader
On Sept. 11, 2013, 6:22 a.m., David Gil Oliva wrote: staging/kservice/src/services/kplugininfo.cpp, line 61 http://git.reviewboard.kde.org/r/112660/diff/1/?file=188728#file188728line61 I think that two variables (hidden and _hidden) so similar are confusing. Sebastian Kügler wrote: Hm, I think it's pretty clear, especially since _hidden is defined above it. The _ signifies here that it's just caching a string. I don't see any part in the code where it's ambigious. Question: How long did it take you to understand it? Do others mind this part? (If not, I'd rather drop this issue, since it's really clear in every call either of these vars is involved.) David Gil Oliva wrote: Hmmm, I think you're taking it too seriously... I wouldn't have two variables so similar to each other in my code, but if you think it's ok, please drop it! Yes, you're right, I didn't take it too long to understand your code, but I don't think reviews are meant to be so profound. If I see something that I don't see clear, I say so. I think I don't deserve your tone, because I did it with my best intention. David, I'm sorry if I came over as unfriendly, rude or condescending. I much appreciate your review and the comments. (Doesn't necessarily mean I agree with all of them, but for discussing this, we have this review. :)) Please don't feel dealt with undeservedly, it was far from my intention. - Sebastian --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112660/#review39793 --- On Sept. 10, 2013, 11:32 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112660/ --- (Updated Sept. 10, 2013, 11:32 p.m.) Review request for KDE Frameworks and David Faure. Description --- This patch prepares KPluginInfo for usage with KPluginTrader (to be submitted in a separate patch). It basically makes KPluginInfo's API a little bit more like KService by adding a property(QString) accessor to the plugin info. This allows us on the one hand Part of this patch, and much of its churn, is the internal change from independent QStrings and QStringLists to a QVariantMap. This is how the metadata comes in from KPlugin*, and it allows us to make properties accessible by name. There's also a fair bit of moving from QLatin1String to QStringLiteral in there, most of these lines needed changes anyway. Additionally, the keys of properties are now shared in the d-pointer. This change is source compatible to the old version. Diffs - staging/kservice/src/services/kplugininfo.cpp 21e0882 Diff: http://git.reviewboard.kde.org/r/112660/diff/ Testing --- All tests still pass, no regressions encountered otherwise. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112556: Move itemviews to tier2
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112556/ --- (Updated Sept. 11, 2013, 3:22 p.m.) Review request for KDE Frameworks. Changes --- Make toplevel CMakeLists.txt and ItemViewConfig.cmake.in look more like other frameworks. Description --- In itemviews/CMakeLists.txt: I took the find_package(Qt5) out of the if (NOT kdelibs_SOURCE_DIR) test otherwise it would not build within kdelibs. Diffs (updated) - staging/CMakeLists.txt f0b6bf0 staging/itemviews/CMakeLists.txt f5c3c8d staging/itemviews/ItemViewsConfig.cmake.in c10f49f staging/itemviews/autotests/CMakeLists.txt staging/itemviews/autotests/klistwidgetsearchlinetest.cpp staging/itemviews/src/CMakeLists.txt staging/itemviews/src/kcategorizedsortfilterproxymodel.h staging/itemviews/src/kcategorizedsortfilterproxymodel.cpp staging/itemviews/src/kcategorizedsortfilterproxymodel_p.h staging/itemviews/src/kcategorizedview.h staging/itemviews/src/kcategorizedview.cpp staging/itemviews/src/kcategorizedview_p.h staging/itemviews/src/kcategorydrawer.h staging/itemviews/src/kcategorydrawer.cpp staging/itemviews/src/kextendableitemdelegate.h staging/itemviews/src/kextendableitemdelegate.cpp staging/itemviews/src/kfilterproxysearchline.h staging/itemviews/src/kfilterproxysearchline.cpp staging/itemviews/src/klistwidgetsearchline.h staging/itemviews/src/klistwidgetsearchline.cpp staging/itemviews/src/ktreewidgetsearchline.h staging/itemviews/src/ktreewidgetsearchline.cpp staging/itemviews/src/kwidgetitemdelegate.h staging/itemviews/src/kwidgetitemdelegate.cpp staging/itemviews/src/kwidgetitemdelegate_p.h staging/itemviews/src/kwidgetitemdelegatepool.cpp staging/itemviews/src/kwidgetitemdelegatepool_p.h staging/itemviews/tests/CMakeLists.txt staging/itemviews/tests/kcategorizedviewtest.cpp staging/itemviews/tests/ktreewidgetsearchlinetest.h staging/itemviews/tests/ktreewidgetsearchlinetest.cpp staging/itemviews/tests/kwidgetitemdelegatetest.cpp tier2/CMakeLists.txt 62faacb Diff: http://git.reviewboard.kde.org/r/112556/diff/ Testing --- Builds and passes tests when build from kdelibs and standalone. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Moving itemviews to tier2
Hi,
I am moving itemviews to tier2 [1], but I have a few questions:
First, I noticed ItemViewConfig.cmake.in was lacking some calls other
frameworks have, for example:
find_dependency(Qt5Widgets @REQUIRED_QT_VERSION@)
find_dependency(KCoreAddons ${PACKAGE_VERSION})
I just modified it (and updated the review request) but it feels like cargo-
culting, is there any documentation on what should be in a KF5
*Config.cmake.in file?
Second, the top-level CMakeLists.txt now looks like this:
cmake_minimum_required(VERSION 2.8.11)
project(ItemViews)
find_package(ECM 0.0.8 REQUIRED NO_MODULE)
set(CMAKE_MODULE_PATH ${ECM_MODULE_PATH})
set(REQUIRED_QT_VERSION 5.2.0)
find_package(Qt5 ${REQUIRED_QT_VERSION} REQUIRED NO_MODULE
COMPONENTS Widgets)
find_package(KF5 5.0.0 REQUIRED MODULE
COMPONENTS CMake Compiler InstallDirs KCoreAddons)
itemviews depends on KCoreAddons, so when I ran cmake to build it standalone,
I expected cmake to report KCoreAddons as a required package, but it is listed
in the optional packages section. How does one tell KCoreAddons is
*required*?
Aurélien
[1]: https://git.reviewboard.kde.org/r/112556/
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Moving itemviews to tier2
On Wednesday 11 September 2013 15:23:15 Aurélien Gâteau wrote:
Second, the top-level CMakeLists.txt now looks like this:
cmake_minimum_required(VERSION 2.8.11)
project(ItemViews)
find_package(ECM 0.0.8 REQUIRED NO_MODULE)
set(CMAKE_MODULE_PATH ${ECM_MODULE_PATH})
set(REQUIRED_QT_VERSION 5.2.0)
find_package(Qt5 ${REQUIRED_QT_VERSION} REQUIRED NO_MODULE
COMPONENTS Widgets)
find_package(KF5 5.0.0 REQUIRED MODULE
COMPONENTS CMake Compiler InstallDirs KCoreAddons)
itemviews depends on KCoreAddons, so when I ran cmake to build it
standalone, I expected cmake to report KCoreAddons as a required package,
but it is listed in the optional packages section. How does one tell
KCoreAddons is *required*?
It has been brought to my attention requiring KCoreAddons like this wrong and
is going to lead to build failure on clean builds of kdelibs, since it
attempts to find something which kdelibs builds. So the KF5 part should be in
a if(NOT kdelibs_SOURCE_DIR).
I also found out how to make KCoreAddons required: request it with a
find_package() call. Here is my new version, does it make sense to you?
cmake_minimum_required(VERSION 2.8.11)
project(ItemViews)
find_package(ECM 0.0.8 REQUIRED NO_MODULE)
set(CMAKE_MODULE_PATH ${ECM_MODULE_PATH})
set(REQUIRED_QT_VERSION 5.2.0)
find_package(Qt5 ${REQUIRED_QT_VERSION} REQUIRED NO_MODULE
COMPONENTS Widgets)
if(NOT kdelibs_SOURCE_DIR)
find_package(KF5 5.0.0 REQUIRED MODULE
COMPONENTS CMake Compiler InstallDirs)
find_package(KCoreAddons 5.0.0 REQUIRED)
endif()
Aurélien
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112583/
---
(Updated Sept. 11, 2013, 2:55 p.m.)
Review request for KDE Frameworks.
Description
---
KConfigWidgets relies on a private header in KWidgetAddons. This prevents
KConfigWidgets building on it's own
By exposing the two of these private members in protected methods, we can solve
this problem.
Commit log below:
--
change target link libraries to ${lib_LIBRARIES} format
--
Remove inheritance on KSelectionActionPrivate in KRecentFileActions
This is in a different framework so cannot be used when building
standalone.
--
Expose associated comboboxes and toolbuttons in KSelectAction
Diffs (updated)
-
staging/kconfigwidgets/src/CMakeLists.txt
dad6bcc140cb4fe56380bd44ea007fe1f06edace
staging/kconfigwidgets/src/krecentfilesaction.h
edf77a24866018134d9c5a200c6e35213742c555
staging/kconfigwidgets/src/krecentfilesaction.cpp
9aa5f8bd83d064402dd6333c7cd89a388d373fe1
staging/kconfigwidgets/src/krecentfilesaction_p.h
8b3cc8f82b248cc9ed8a1f1be69cf4160f97378c
tier1/kwidgetsaddons/src/kselectaction.h
07afaa960d2be4877aeef0ff074d0fd20c7b7f40
tier1/kwidgetsaddons/src/kselectaction.cpp
3aa079731cd19ccad4f6a6344ebe5d6921d0bd7e
Diff: http://git.reviewboard.kde.org/r/112583/diff/
Testing
---
Thanks,
David Edmundson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to stable : plasma-framework_master_qt5 #727
See http://build.kde.org/job/plasma-framework_master_qt5/727/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112583/#review39840
---
A few nitpicks, but I like this version better.
tier1/kwidgetsaddons/src/kselectaction.h
http://git.reviewboard.kde.org/r/112583/#comment29377
Missing @since 5.0
tier1/kwidgetsaddons/src/kselectaction.cpp
http://git.reviewboard.kde.org/r/112583/#comment29376
To avoid duplication you could reimplement KSelectAction::addAction(act) as
insertAction(0, act)
You might also want to make KSelectAction::addAction() not virtual, so that
there is only one way to change the class behavior when actions are
added/inserted.
- Aurélien Gâteau
On Sept. 11, 2013, 4:55 p.m., David Edmundson wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112583/
---
(Updated Sept. 11, 2013, 4:55 p.m.)
Review request for KDE Frameworks.
Description
---
KConfigWidgets relies on a private header in KWidgetAddons. This prevents
KConfigWidgets building on it's own
By exposing the two of these private members in protected methods, we can
solve this problem.
Commit log below:
--
change target link libraries to ${lib_LIBRARIES} format
--
Remove inheritance on KSelectionActionPrivate in KRecentFileActions
This is in a different framework so cannot be used when building
standalone.
--
Expose associated comboboxes and toolbuttons in KSelectAction
Diffs
-
staging/kconfigwidgets/src/CMakeLists.txt
dad6bcc140cb4fe56380bd44ea007fe1f06edace
staging/kconfigwidgets/src/krecentfilesaction.h
edf77a24866018134d9c5a200c6e35213742c555
staging/kconfigwidgets/src/krecentfilesaction.cpp
9aa5f8bd83d064402dd6333c7cd89a388d373fe1
staging/kconfigwidgets/src/krecentfilesaction_p.h
8b3cc8f82b248cc9ed8a1f1be69cf4160f97378c
tier1/kwidgetsaddons/src/kselectaction.h
07afaa960d2be4877aeef0ff074d0fd20c7b7f40
tier1/kwidgetsaddons/src/kselectaction.cpp
3aa079731cd19ccad4f6a6344ebe5d6921d0bd7e
Diff: http://git.reviewboard.kde.org/r/112583/diff/
Testing
---
Thanks,
David Edmundson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112583/
---
(Updated Sept. 11, 2013, 5:06 p.m.)
Review request for KDE Frameworks.
Description
---
KConfigWidgets relies on a private header in KWidgetAddons. This prevents
KConfigWidgets building on it's own
By exposing the two of these private members in protected methods, we can solve
this problem.
Commit log below:
--
change target link libraries to ${lib_LIBRARIES} format
--
Remove inheritance on KSelectionActionPrivate in KRecentFileActions
This is in a different framework so cannot be used when building
standalone.
--
Expose associated comboboxes and toolbuttons in KSelectAction
Diffs (updated)
-
staging/kconfigwidgets/src/CMakeLists.txt
dad6bcc140cb4fe56380bd44ea007fe1f06edace
staging/kconfigwidgets/src/krecentfilesaction.h
edf77a24866018134d9c5a200c6e35213742c555
staging/kconfigwidgets/src/krecentfilesaction.cpp
9aa5f8bd83d064402dd6333c7cd89a388d373fe1
staging/kconfigwidgets/src/krecentfilesaction_p.h
8b3cc8f82b248cc9ed8a1f1be69cf4160f97378c
tier1/kwidgetsaddons/src/kselectaction.h
07afaa960d2be4877aeef0ff074d0fd20c7b7f40
tier1/kwidgetsaddons/src/kselectaction.cpp
3aa079731cd19ccad4f6a6344ebe5d6921d0bd7e
Diff: http://git.reviewboard.kde.org/r/112583/diff/
Testing
---
Thanks,
David Edmundson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build became unstable: plasma-framework_master_qt5 #726
See http://build.kde.org/job/plasma-framework_master_qt5/726/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone
On Sept. 11, 2013, 4:13 p.m., Aurélien Gâteau wrote:
tier1/kwidgetsaddons/src/kselectaction.cpp, line 240
http://git.reviewboard.kde.org/r/112583/diff/2/?file=188967#file188967line240
To avoid duplication you could reimplement
KSelectAction::addAction(act) as insertAction(0, act)
You might also want to make KSelectAction::addAction() not virtual, so
that there is only one way to change the class behavior when actions are
added/inserted.
I originally thought about doing that then rejected it assuming
QWidget::addAction() would be somehow faster than insertAction() and we
shouldn't throw that away.
Now I've looked at Qt code it shows that they just call insertAction(0,
action); so it does make sense for us to do the same thing. Will change.
- David
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112583/#review39840
---
On Sept. 11, 2013, 2:55 p.m., David Edmundson wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112583/
---
(Updated Sept. 11, 2013, 2:55 p.m.)
Review request for KDE Frameworks.
Description
---
KConfigWidgets relies on a private header in KWidgetAddons. This prevents
KConfigWidgets building on it's own
By exposing the two of these private members in protected methods, we can
solve this problem.
Commit log below:
--
change target link libraries to ${lib_LIBRARIES} format
--
Remove inheritance on KSelectionActionPrivate in KRecentFileActions
This is in a different framework so cannot be used when building
standalone.
--
Expose associated comboboxes and toolbuttons in KSelectAction
Diffs
-
staging/kconfigwidgets/src/CMakeLists.txt
dad6bcc140cb4fe56380bd44ea007fe1f06edace
staging/kconfigwidgets/src/krecentfilesaction.h
edf77a24866018134d9c5a200c6e35213742c555
staging/kconfigwidgets/src/krecentfilesaction.cpp
9aa5f8bd83d064402dd6333c7cd89a388d373fe1
staging/kconfigwidgets/src/krecentfilesaction_p.h
8b3cc8f82b248cc9ed8a1f1be69cf4160f97378c
tier1/kwidgetsaddons/src/kselectaction.h
07afaa960d2be4877aeef0ff074d0fd20c7b7f40
tier1/kwidgetsaddons/src/kselectaction.cpp
3aa079731cd19ccad4f6a6344ebe5d6921d0bd7e
Diff: http://git.reviewboard.kde.org/r/112583/diff/
Testing
---
Thanks,
David Edmundson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 112673: Expose setStandardActionNames as public API in kacceleratormanager
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112673/ --- Review request for KDE Frameworks. Description --- Expose setStandardActionNames as public API in kacceleratormanager This is needed by KStandardAction which is in a different tier to kacceleratormanager. I changed it from setStandardActionNames to addStandardActionNames as now it it public API it shouldn't break if two classes use it. Diffs - staging/kconfigwidgets/src/kstandardaction.cpp 23e3b32 tier1/kwidgetsaddons/src/kacceleratormanager.h 108cb85 tier1/kwidgetsaddons/src/kacceleratormanager.cpp f50057e tier1/kwidgetsaddons/src/kacceleratormanager_p.h 89ccde5 Diff: http://git.reviewboard.kde.org/r/112673/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Dependency specifications
On Tue, Sep 10, 2013 at 7:42 PM, Michael Palimaka kensing...@gentoo.orgwrote: Hi, Currently, the specification for Qt dependencies is not always consistent between tier1 frameworks. In particular, I notice dependencies being specified twice (eg. QtTest in both project root and in autotests), and test dependencies split (eg. QtTest in project root only, and QtXml in autotests only). What is the intended behaviour? All dependencies specified in the project root? Common dependencies specified in the project root, and specific dependencies in directories that require them? Something else? Best regards, Michael __**_ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/**listinfo/kde-frameworks-develhttps://mail.kde.org/mailman/listinfo/kde-frameworks-devel I'd say that all Qt dependencies in the module should be defined only once in the root CMakeLists.txt. Actually this should be the only file with find_package calls. We could try an be stricter, but in practice what is useful for distribution is the find_dependency call in the Config.cmake.in file... Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 112679: Make KTraderParseTree fit for searching in KPluginInfo::List
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112679/ --- Review request for KDE Frameworks and David Faure. Description --- This patch allows search through KPluginInfo::List, additionally to KService::List. Together with the other patches from my set It makes it possible to search through the plugin's (JSON-based) metadata, using our constraint syntax. It adds a ctor that takes a KPluginInfo::List and adds the necessary branches to look within either the KService::List or the KPluginInfo::List. There's one problem I don't know an elegant solution to, will point that out in the diff. This, and the other patches from this set are also in kdelibs[sebas/pluginlocator] Diffs - staging/kservice/src/services/ktraderparsetree.cpp 4257e43 staging/kservice/src/services/ktraderparsetree_p.h 7664943 Diff: http://git.reviewboard.kde.org/r/112679/diff/ Testing --- - Added tests (separate review), all pass - Ported Plasma::PluginLoader from KServiceTypeTrader to KPluginTrader and tested the querying in a real-world scenario, no regressions spotted - No regressions in existing tests Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112679: Make KTraderParseTree fit for searching in KPluginInfo::List
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112679/#review39859 --- 2 issues I'd like to get advise for inline. staging/kservice/src/services/ktraderparsetree_p.h http://git.reviewboard.kde.org/r/112679/#comment29389 Here, the KPluginInfo::List goes out of scope immediately, so we end up with an invalid reference. It's not accessed, but this seems rather ugly. It also yields a compiler warning. How can this be solved elegantly? (Same problem in the other ctor, where the KService::List becomes invalid.) staging/kservice/src/services/ktraderparsetree_p.h http://git.reviewboard.kde.org/r/112679/#comment29390 here, the KService::List becomes invalid, see issue right above. - Sebastian Kügler On Sept. 12, 2013, 1:33 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112679/ --- (Updated Sept. 12, 2013, 1:33 a.m.) Review request for KDE Frameworks and David Faure. Description --- This patch allows search through KPluginInfo::List, additionally to KService::List. Together with the other patches from my set It makes it possible to search through the plugin's (JSON-based) metadata, using our constraint syntax. It adds a ctor that takes a KPluginInfo::List and adds the necessary branches to look within either the KService::List or the KPluginInfo::List. There's one problem I don't know an elegant solution to, will point that out in the diff. This, and the other patches from this set are also in kdelibs[sebas/pluginlocator] Diffs - staging/kservice/src/services/ktraderparsetree.cpp 4257e43 staging/kservice/src/services/ktraderparsetree_p.h 7664943 Diff: http://git.reviewboard.kde.org/r/112679/diff/ Testing --- - Added tests (separate review), all pass - Ported Plasma::PluginLoader from KServiceTypeTrader to KPluginTrader and tested the querying in a real-world scenario, no regressions spotted - No regressions in existing tests Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 112680: KPluginTrader: QPluginLoader/metadata-based querying of Plugins
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112680/ --- Review request for KDE Frameworks and David Faure. Description --- A trader interface (similar to the CORBA Trader), which provides a way query specific subdirectories in the Qt plugin paths for plugins. KPluginTrader provides an easy way to load a plugin instance from a KPluginFactory, just querying for existing plugins. KPluginTrader provides a way for an application to query directories in the Qt plugin paths, accessed through QCoreApplication::libraryPaths(). Plugins may match a specific set of requirements. This allows to find specific plugins at run-time without having to hard-code their names and/or paths. KPluginTrader does not search recursively, you are rather encouraged to install plugins into specific subdirectories to further speed searching. KPluginTrader exclusively searches within the plugin binaries' metadata (via QPluginLoader::metaData()). It does not search these directories recursively and it does not use KServiceTypeTrader or KSyCoCa. Currently, no caching is done, this should/will be implemented separately on top of this patch. The implementation is losely based on KServiceTypeTrader, meant for easy porting. Code, along with other needed patches can be found in kdelibs[sebas/pluginlocator]. Diffs - staging/kservice/src/plugin/kplugintrader.h PRE-CREATION staging/kservice/src/plugin/kplugintrader.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112680/diff/ Testing --- - A whole bunch of newly written unit tests pass, to be submitted separately - Ported Plasma::PluginLoader's dataengine handling, it works without apparent regressions Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 112681: Tests for KPluginTrader and friends
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112681/ --- Review request for KDE Frameworks and David Faure. Description --- Tests for KPluginTrader. Under autotests/, there's a new test class which runs a variety of queries using KPluginTrader. There's also a small plugin, which is used to verify correct metadata querying and loading. It's not installed since QPluginLoader conveniently contains the working directory when looking for plugins - it's found just fine. Under tests/, there's a test which will query for a variety of other plugins. This one is more geared towards performance testing. When run from make test, it will pass anyway. Code can also be found in kdelibs[sebas/pluginlocator]. Diffs - staging/kservice/autotests/CMakeLists.txt d341040 staging/kservice/autotests/fakeplugin.desktop PRE-CREATION staging/kservice/autotests/fakeplugin.json PRE-CREATION staging/kservice/autotests/nsaplugin.h PRE-CREATION staging/kservice/autotests/nsaplugin.cpp PRE-CREATION staging/kservice/autotests/pluginlocatortest.h PRE-CREATION staging/kservice/autotests/pluginlocatortest.cpp PRE-CREATION staging/kservice/tests/CMakeLists.txt 3793aea staging/kservice/tests/pluginlocator/CMakeLists.txt PRE-CREATION staging/kservice/tests/pluginlocator/main.cpp PRE-CREATION staging/kservice/tests/pluginlocator/plugintest.h PRE-CREATION staging/kservice/tests/pluginlocator/plugintest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112681/diff/ Testing --- make test =) All tests pass on top of my patches. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
