Re: Review Request 112808: Port away from KDirWatch in KEmoticons (prior to splitting)

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112808/#review40316
---

Ship it!


Looks good to me.

- Aleix Pol Gonzalez


On Sept. 18, 2013, 10:26 p.m., David Gil Oliva wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112808/
> ---
> 
> (Updated Sept. 18, 2013, 10:26 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Port away from KDirWatch in KEmoticons (prior to splitting)
> 
> 
> Diffs
> -
> 
>   staging/kemoticons/src/core/CMakeLists.txt 
> 0e79eaae60dfd5cd5e0c5f6848b86dbb90c0c818 
>   staging/kemoticons/src/core/kemoticons.cpp 
> 5f6a23ec606b3c6dceac2e01a280413e6899a59b 
> 
> Diff: http://git.reviewboard.kde.org/r/112808/diff/
> 
> 
> Testing
> ---
> 
> It builds and installs correctly.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112808: Port away from KDirWatch in KEmoticons (prior to splitting)

[David Gil Oliva]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112808/
---

Review request for KDE Frameworks.


Description
---

Port away from KDirWatch in KEmoticons (prior to splitting)


Diffs
-

  staging/kemoticons/src/core/CMakeLists.txt 
0e79eaae60dfd5cd5e0c5f6848b86dbb90c0c818 
  staging/kemoticons/src/core/kemoticons.cpp 
5f6a23ec606b3c6dceac2e01a280413e6899a59b 

Diff: http://git.reviewboard.kde.org/r/112808/diff/


Testing
---

It builds and installs correctly.


Thanks,

David Gil Oliva

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112681: Tests for KPluginTrader and friends

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112681/#review40314
---

Ship it!



staging/kservice/autotests/pluginlocatortest.cpp


remove the if, QVERIFY will "return" on error.



staging/kservice/tests/pluginlocator/CMakeLists.txt


what is it used for?



staging/kservice/tests/pluginlocator/CMakeLists.txt


nothing to install here -> remove



staging/kservice/tests/pluginlocator/main.cpp


where is this option used?

("plugin_s_" vs "name" seems strange, too; or is this a search string that 
can return multiple results?)



staging/kservice/tests/pluginlocator/plugintest.h


const QList<...> &



staging/kservice/tests/pluginlocator/plugintest.cpp


unused



staging/kservice/tests/pluginlocator/plugintest.cpp


hehe


- David Faure


On Sept. 18, 2013, 12:12 p.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112681/
> ---
> 
> (Updated Sept. 18, 2013, 12:12 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Description
> ---
> 
> Tests for KPluginTrader.
> 
> Under autotests/, there's a new test class which runs a variety of queries 
> using KPluginTrader. There's also a small plugin, which is used to verify 
> correct metadata querying and loading. It's not installed since QPluginLoader 
> conveniently contains the working directory when looking for plugins -> it's 
> found just fine.
> 
> Under tests/, there's a test which will query for a variety of other plugins. 
> This one is more geared towards performance testing. When run from make test, 
> it will pass anyway.
> 
> Code can also be found in kdelibs[sebas/pluginlocator].
> 
> 
> Diffs
> -
> 
>   staging/kservice/autotests/CMakeLists.txt d341040 
>   staging/kservice/autotests/fakeplugin.desktop PRE-CREATION 
>   staging/kservice/autotests/fakeplugin.json PRE-CREATION 
>   staging/kservice/autotests/nsaplugin.h PRE-CREATION 
>   staging/kservice/autotests/nsaplugin.cpp PRE-CREATION 
>   staging/kservice/autotests/pluginlocatortest.h PRE-CREATION 
>   staging/kservice/autotests/pluginlocatortest.cpp PRE-CREATION 
>   staging/kservice/tests/CMakeLists.txt 3793aea 
>   staging/kservice/tests/pluginlocator/CMakeLists.txt PRE-CREATION 
>   staging/kservice/tests/pluginlocator/main.cpp PRE-CREATION 
>   staging/kservice/tests/pluginlocator/plugintest.h PRE-CREATION 
>   staging/kservice/tests/pluginlocator/plugintest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112681/diff/
> 
> 
> Testing
> ---
> 
> make test =)
> 
> All tests pass on top of my patches.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112772: Create an ecm_mark_as_autotest macro

[Alexander Neundorf]

> On Sept. 17, 2013, 6:26 p.m., Alexander Neundorf wrote:
> > The macro does more than the name implies, additionally to marking it as 
> > test it also actually adds the test.
> > So I'd prefer a different name.
> > 
> > Having said that, the CMakeLists.txt in the various tests/ subdirs in KDE 
> > frameworks look all quite similar, they more or less all feature a quite 
> > similar macro, foo_unit_tests(). Maybe a more advanced function can be 
> > written which can be used in all those places ?
> 
> Alexander Richardson wrote:
> I just played around with adding a new macro to replace the 
> _UNIT_TESTS macros which are in every autotests directory: 
> http://paste.kde.org/p11adaa09/
> 
> Could something like this be considered for ecm? If so I will add some 
> documentation and create a review request for ecm.
> 
> Aleix Pol Gonzalez wrote:
> Neundorf: well, the difference between mark_as_test and mark_as_autotest 
> is that it marks it as a test. Actually I think that mark_as_test is in fact 
> a bit misleading, because it's not marking it as a test, only making it build 
> as a test.
> 
> About foo_unit_tests, I don't hate the idea, but then I don't think it 
> pays off that much, if we go with that, we can just keep kde4_add_unit_test 
> just as well.

Alex: IMO yes.
Aleix: if the function from Alex R. is generic enough to be usable by non 
KDE-projects, I think it would be useful to have in ecm. Still, having two 
macros ecm_mark_as_test() and ecm_mark_as_autotest() would IMO not be good, 
since they sound quite similar but do different things. I'd prefer a more 
powerful function which does more than just wrap two calls.

But that's just my opinion, I leave it up to Stephen.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112772/#review40240
---


On Sept. 17, 2013, 12:35 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112772/
> ---
> 
> (Updated Sept. 17, 2013, 12:35 p.m.)
> 
> 
> Review request for Build System and KDE Frameworks.
> 
> 
> Description
> ---
> 
> Creates a function that will define a unit test with the project name (like 
> it's being done in KF5) and calls ecm_mark_as_test.
> 
> This should help simplify the tests creation that at the moment is quite 
> verbose.
> 
> 
> Diffs
> -
> 
>   modules/ECMMarkAsTest.cmake f1e53e4 
> 
> Diff: http://git.reviewboard.kde.org/r/112772/diff/
> 
> 
> Testing
> ---
> 
> Ported some tests in KF5, it worked.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #1222

[KDE CI System]

See 

--
[...truncated 3593 lines...]
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/camera.cpp.o
[ 25%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/opticaldrive.cpp.o
[ 25%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/battery.cpp.o
[ 25%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/block.cpp.o
[ 25%] [ 25%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/button.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/keyboard.cpp.o
[ 25%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/device.cpp.o
[ 25%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/deviceinterface.cpp.o
[ 25%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/pointingdevice.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/devicemanager.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/dvbinterface.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/camera.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/genericinterface.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/networkinterface.cpp.o
:
 In function ‘void 
Solid::PowerManagement::requestSleep(Solid::PowerManagement::SleepState, 
QObject*, const char*)’:
:97:12:
 warning: enumeration value ‘HybridSuspendState’ not handled in switch 
[-Wswitch]
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/networkshare.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/opticaldrive.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/serialinterface.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/device.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/deviceinterface.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/devicemanager.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/dvbinterface.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/genericinterface.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/opticaldisc.cpp.o
[ 27%] [ 27%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/networkinterface.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/portablemediaplayer.cpp.o
[ 27%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/networkshare.cpp.o
[ 27%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/processor.cpp.o
[ 27%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/serialinterface.cpp.o
[ 27%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/storagedrive.cpp.o
[ 27%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/storagevolume.cpp.o
[ 27%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/storageaccess.cpp.o
[ 27%] [ 27%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/video.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/opticaldisc.cpp.o
[ 27%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/portablemediaplayer.cpp.o
[ 27%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/smartcardreader.cpp.o
[ 27%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/internetgateway.cpp.o
[ 27%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/processor.cpp.o
[ 27%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/fakehw/fakeacadapter.cpp.o
[ 27%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/fakehw/fakeaudiointerface.cpp.o
[ 27%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/storagedrive.cpp.o
[ 27%] [ 27%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/fakehw/fakebattery.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/storagevolume.cpp.o
[ 27%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/storageaccess.cpp.o
[ 27%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/video.cpp.o
[ 27%] Building CXX object 
ti

Review Request 112803: Start cleaning up KDNSSD

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112803/
---

Review request for KDE Frameworks.


Description
---

Renames target to KDNSSD.
Properly look-up Qt and KF5.

After that I'll move it to staging.


Diffs
-

  dnssd/CMakeLists.txt 7f2620a 

Diff: http://git.reviewboard.kde.org/r/112803/diff/


Testing
---

Builds, there are no tests.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #1221

[KDE CI System]

See 

Changes:

[ivan.cukic] Using cbegin and cend when assigning to const iterators

--
[...truncated 3588 lines...]
[ 24%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/block.cpp.o
[ 24%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/button.cpp.o
[ 24%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/pointingdevice.cpp.o
[ 24%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/camera.cpp.o
[ 24%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/opticaldrive.cpp.o
[ 24%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/device.cpp.o
[ 24%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/keyboard.cpp.o
[ 24%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/pointingdevice.cpp.o
[ 24%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/deviceinterface.cpp.o
:
 In function ‘void 
Solid::PowerManagement::requestSleep(Solid::PowerManagement::SleepState, 
QObject*, const char*)’:
:97:12:
 warning: enumeration value ‘HybridSuspendState’ not handled in switch 
[-Wswitch]
[ 24%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/devicemanager.cpp.o
[ 24%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/dvbinterface.cpp.o
[ 24%] [ 24%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/camera.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/opticaldrive.cpp.o
[ 24%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/device.cpp.o
[ 24%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/genericinterface.cpp.o
[ 25%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/networkinterface.cpp.o
[ 25%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/deviceinterface.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/devicemanager.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/networkshare.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/serialinterface.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/dvbinterface.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/opticaldisc.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/genericinterface.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/networkinterface.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/networkshare.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/portablemediaplayer.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/processor.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/serialinterface.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/storagedrive.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/opticaldisc.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/storagevolume.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/storageaccess.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/portablemediaplayer.cpp.o
[ 26%] [ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/video.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/smartcardreader.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/processor.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/internetgateway.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/storagedrive.cpp.o
[ 26%] [ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/storagevolume.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/storageaccess.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/video.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/smartcardreader.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/fakehw/fakeacadapter.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMa

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

[Mark Gaiser]

> On Sept. 18, 2013, 5:23 p.m., Mark Gaiser wrote:
> > Posting the same here as i just said in your other review request. (I 
> > didn't see this one)
> > Idea: restore naturalCompare as it was and add a "collatorNaturalCompare" 
> > that is taking the QCollator route. That way it's easily testable as well.
> > 
> > I think we can all agree on that, right?
> 
> Aleix Pol Gonzalez wrote:
> ** posting again as well... **
> 
> I don't think creating such function would be a good thing because it 
> means using QCollator the wrong way. I much rather prefer working on tools to 
> properly use QCollator, for example by making it possible to sort things with 
> the sort key instead of QCollator::compare which will be the place where we 
> can actually test performance.

True, but then it can't be used as a 1 on 1 replacement. Since QCollatorSortKey 
would first have to be generated for every string and stored in the list that 
is to be sorted (That would be the ItemData struct 
http://quickgit.kde.org/?p=kde-baseapps.git&a=blob&h=841016138c4a67691177ae9d759eae6399adc762&hb=7dde35ccb97ac2958e45fe6b0759901e02d5e5e3&f=dolphin%2Fsrc%2Fkitemviews%2Fkfileitemmodel.h
 from line 299). But yeah, that does seem like a very nice idea and close to an 
idea that was floating the kfm-devel list ~1 year ago which also involved 
adding some "precompiled" sort data in that very same structure to speed up 
sorting.

Anyway, +1 from me but someone else must give a ship it.


- Mark


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112797/#review40289
---


On Sept. 18, 2013, 4:55 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112797/
> ---
> 
> (Updated Sept. 18, 2013, 4:55 p.m.)
> 
> 
> Review request for KDE Frameworks, Frank Reininghaus and Mark Gaiser.
> 
> 
> Description
> ---
> 
> Apparently there's people who still want to have it. Leave it in KCoreAddons 
> for the moment, until we decide that it can be replaced for good by QCollator.
> 
> 
> Diffs
> -
> 
>   tier1/kcoreaddons/autotests/kstringhandlertest.cpp 93da351 
>   tier1/kcoreaddons/src/lib/text/kstringhandler.h 442b97a 
>   tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5 
> 
> Diff: http://git.reviewboard.kde.org/r/112797/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

[Mark Gaiser]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112797/#review40289
---


Posting the same here as i just said in your other review request. (I didn't 
see this one)
Idea: restore naturalCompare as it was and add a "collatorNaturalCompare" that 
is taking the QCollator route. That way it's easily testable as well.

I think we can all agree on that, right?

- Mark Gaiser


On Sept. 18, 2013, 4:55 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112797/
> ---
> 
> (Updated Sept. 18, 2013, 4:55 p.m.)
> 
> 
> Review request for KDE Frameworks, Frank Reininghaus and Mark Gaiser.
> 
> 
> Description
> ---
> 
> Apparently there's people who still want to have it. Leave it in KCoreAddons 
> for the moment, until we decide that it can be replaced for good by QCollator.
> 
> 
> Diffs
> -
> 
>   tier1/kcoreaddons/autotests/kstringhandlertest.cpp 93da351 
>   tier1/kcoreaddons/src/lib/text/kstringhandler.h 442b97a 
>   tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5 
> 
> Diff: http://git.reviewboard.kde.org/r/112797/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112717: Start adopting QCollator

[Mark Gaiser]

> On Sept. 18, 2013, 3:22 p.m., Mark Gaiser wrote:
> > How RUDE to just commit this without a addressing the concerns Frank and i 
> > have. That is not appreciated!
> 
> Aleix Pol Gonzalez wrote:
> Alright, maybe I didn't think this through. I'll un-deprecate and bring 
> back the KStringHandler::naturalCompare code as you want.
> 
> Said that, I doubt these concerns make that much a difference. QCollator 
> has to be adopted. Not because of performance reasons but localization alone. 
> Performance will happen as well, but for that we need development on the 
> applications side, which I'm afraid cannot be up to me as well.
> 
> Either way, if you really shouldn't consider ::naturalCompare as a 
> solution. ICU is much better tested than naturalCompare (yes, even) and has 
> people more qualified than us by making it locale aware (::naturalCompare 
> implementation is naive to localization).

Idea: restore naturalCompare as it was and add a "collatorNaturalCompare" that 
is taking the QCollator route. That way it's easily testable as well.


- Mark


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112717/#review40277
---


On Sept. 18, 2013, 2:58 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112717/
> ---
> 
> (Updated Sept. 18, 2013, 2:58 p.m.)
> 
> 
> Review request for KDE Frameworks, Frank Reininghaus and Aurélien Gâteau.
> 
> 
> Description
> ---
> 
> Now that QCollator is public API, I wanted to give it a try, so I decided to 
> port all uses KStringHandler::naturalCompare() to QCollator.
> 
> All the porting was quite straightforward I'd say, the only weird part is 
> that I removed some tests of the KStringHandler tests. There are 2 kind of 
> tests disabled:
> - The ones that say that "A" == "a" in case of Qt::CaseInsensitive. ICU is 
> deterministic and it will decide itself which one goes in, so the test 
> doesn't make sense anymore.
> - There's a mention to the 237788 bug where in some cases our former 
> algorithm wouldn't be deterministic. This doesn't apply anymore, but also now 
> ICU takes care about it now, so there's little point of keeping unit testing 
> it.
> I decided to leave the unit test because it might be useful eventually 
> (although note that it was not being compiled so far). In any case we 
> probably want it out.
> 
> In any case, the rest seems straightforward enough. I didn't concentrate on 
> performance though, in some cases we'll want to use the QCollatorSortKey.
> 
> 
> Diffs
> -
> 
>   KDE5PORTING.html 1287de7 
>   kfile/kdirsortfilterproxymodel.cpp 7c7aa5f 
>   kfile/kurlnavigatorbutton.cpp d2c27fd 
>   staging/itemviews/src/CMakeLists.txt 353a413 
>   staging/itemviews/src/kcategorizedsortfilterproxymodel.h a21e7ca 
>   staging/itemviews/src/kcategorizedsortfilterproxymodel.cpp c8b652d 
>   staging/itemviews/src/kcategorizedsortfilterproxymodel_p.h eb1a67b 
>   staging/kcompletion/src/kcompletion.cpp 5f60a6c 
>   staging/xmlgui/src/kshortcutsdialog_p.h ab102bc 
>   staging/xmlgui/src/kshortcutseditoritem.cpp e89a8aa 
>   tier1/kcoreaddons/autotests/CMakeLists.txt 19227dc 
>   tier1/kcoreaddons/autotests/kstringhandlertest.cpp d12f086 
>   tier1/kcoreaddons/src/lib/text/kstringhandler.h 1b08f6f 
>   tier1/kcoreaddons/src/lib/text/kstringhandler.cpp 2f192aa 
> 
> Diff: http://git.reviewboard.kde.org/r/112717/diff/
> 
> 
> Testing
> ---
> 
> Builds, affected tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

[Aleix Pol Gonzalez]

> On Sept. 18, 2013, 5:23 p.m., Mark Gaiser wrote:
> > Posting the same here as i just said in your other review request. (I 
> > didn't see this one)
> > Idea: restore naturalCompare as it was and add a "collatorNaturalCompare" 
> > that is taking the QCollator route. That way it's easily testable as well.
> > 
> > I think we can all agree on that, right?

** posting again as well... **

I don't think creating such function would be a good thing because it means 
using QCollator the wrong way. I much rather prefer working on tools to 
properly use QCollator, for example by making it possible to sort things with 
the sort key instead of QCollator::compare which will be the place where we can 
actually test performance.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112797/#review40289
---


On Sept. 18, 2013, 4:55 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112797/
> ---
> 
> (Updated Sept. 18, 2013, 4:55 p.m.)
> 
> 
> Review request for KDE Frameworks, Frank Reininghaus and Mark Gaiser.
> 
> 
> Description
> ---
> 
> Apparently there's people who still want to have it. Leave it in KCoreAddons 
> for the moment, until we decide that it can be replaced for good by QCollator.
> 
> 
> Diffs
> -
> 
>   tier1/kcoreaddons/autotests/kstringhandlertest.cpp 93da351 
>   tier1/kcoreaddons/src/lib/text/kstringhandler.h 442b97a 
>   tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5 
> 
> Diff: http://git.reviewboard.kde.org/r/112797/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112717: Start adopting QCollator

[Aleix Pol Gonzalez]

> On Sept. 18, 2013, 3:22 p.m., Mark Gaiser wrote:
> > How RUDE to just commit this without a addressing the concerns Frank and i 
> > have. That is not appreciated!
> 
> Aleix Pol Gonzalez wrote:
> Alright, maybe I didn't think this through. I'll un-deprecate and bring 
> back the KStringHandler::naturalCompare code as you want.
> 
> Said that, I doubt these concerns make that much a difference. QCollator 
> has to be adopted. Not because of performance reasons but localization alone. 
> Performance will happen as well, but for that we need development on the 
> applications side, which I'm afraid cannot be up to me as well.
> 
> Either way, if you really shouldn't consider ::naturalCompare as a 
> solution. ICU is much better tested than naturalCompare (yes, even) and has 
> people more qualified than us by making it locale aware (::naturalCompare 
> implementation is naive to localization).
> 
> Mark Gaiser wrote:
> Idea: restore naturalCompare as it was and add a "collatorNaturalCompare" 
> that is taking the QCollator route. That way it's easily testable as well.

See the other patch I just sent.

I don't think creating such function would be a good thing because it means 
using QCollator the wrong way. I much rather prefer working on tools to 
properly use QCollator, for example by making it possible to sort things with 
the sort key instead of QCollator::compare.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112717/#review40277
---


On Sept. 18, 2013, 2:58 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112717/
> ---
> 
> (Updated Sept. 18, 2013, 2:58 p.m.)
> 
> 
> Review request for KDE Frameworks, Frank Reininghaus and Aurélien Gâteau.
> 
> 
> Description
> ---
> 
> Now that QCollator is public API, I wanted to give it a try, so I decided to 
> port all uses KStringHandler::naturalCompare() to QCollator.
> 
> All the porting was quite straightforward I'd say, the only weird part is 
> that I removed some tests of the KStringHandler tests. There are 2 kind of 
> tests disabled:
> - The ones that say that "A" == "a" in case of Qt::CaseInsensitive. ICU is 
> deterministic and it will decide itself which one goes in, so the test 
> doesn't make sense anymore.
> - There's a mention to the 237788 bug where in some cases our former 
> algorithm wouldn't be deterministic. This doesn't apply anymore, but also now 
> ICU takes care about it now, so there's little point of keeping unit testing 
> it.
> I decided to leave the unit test because it might be useful eventually 
> (although note that it was not being compiled so far). In any case we 
> probably want it out.
> 
> In any case, the rest seems straightforward enough. I didn't concentrate on 
> performance though, in some cases we'll want to use the QCollatorSortKey.
> 
> 
> Diffs
> -
> 
>   KDE5PORTING.html 1287de7 
>   kfile/kdirsortfilterproxymodel.cpp 7c7aa5f 
>   kfile/kurlnavigatorbutton.cpp d2c27fd 
>   staging/itemviews/src/CMakeLists.txt 353a413 
>   staging/itemviews/src/kcategorizedsortfilterproxymodel.h a21e7ca 
>   staging/itemviews/src/kcategorizedsortfilterproxymodel.cpp c8b652d 
>   staging/itemviews/src/kcategorizedsortfilterproxymodel_p.h eb1a67b 
>   staging/kcompletion/src/kcompletion.cpp 5f60a6c 
>   staging/xmlgui/src/kshortcutsdialog_p.h ab102bc 
>   staging/xmlgui/src/kshortcutseditoritem.cpp e89a8aa 
>   tier1/kcoreaddons/autotests/CMakeLists.txt 19227dc 
>   tier1/kcoreaddons/autotests/kstringhandlertest.cpp d12f086 
>   tier1/kcoreaddons/src/lib/text/kstringhandler.h 1b08f6f 
>   tier1/kcoreaddons/src/lib/text/kstringhandler.cpp 2f192aa 
> 
> Diff: http://git.reviewboard.kde.org/r/112717/diff/
> 
> 
> Testing
> ---
> 
> Builds, affected tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112797: Bring back KStringHandler::naturalCompare()

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112797/
---

Review request for KDE Frameworks, Frank Reininghaus and Mark Gaiser.


Description
---

Apparently there's people who still want to have it. Leave it in KCoreAddons 
for the moment, until we decide that it can be replaced for good by QCollator.


Diffs
-

  tier1/kcoreaddons/autotests/kstringhandlertest.cpp 93da351 
  tier1/kcoreaddons/src/lib/text/kstringhandler.h 442b97a 
  tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5 

Diff: http://git.reviewboard.kde.org/r/112797/diff/


Testing
---

Builds, tests pass.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #754

[KDE CI System]

See 

Changes:

[notmart] catch file types by extension too

--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 in workspace 

Running Prebuild steps
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson5774647984199142816.sh
+ /home/jenkins/scripts/setup-env.sh
>From git://anongit.kde.org/plasma-framework
   6d65ece..d567b34  master -> origin/master
Branch jenkins set up to track remote branch master from origin.
Success build forhudson.tasks.Shell@57a1760b
Checkout:plasma-framework_master_qt5 / 
 - 
hudson.remoting.Channel@b634f90:LinuxSlave - 3
Using strategy: Default
Last Built Revision: Revision 6d65ece95a377318b052d012fae9deff5f15a77c 
(refs/heads/jenkins)
Fetching changes from 1 remote Git repository
Fetching upstream changes from origin
Commencing build of Revision d567b3414b078b6cee36034df1beec18556393ef 
(refs/heads/jenkins)
Checking out Revision d567b3414b078b6cee36034df1beec18556393ef 
(refs/heads/jenkins)
[plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson7300454319724177289.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-framework - Branch master
== Build Dependencies:
 extra-cmake-modules - Branch master
 libstreamanalyzer - Branch master
 strigiclient - Branch master
 strigiutils - Branch master
 attica - Branch master
 kdelibs - Branch frameworks
 libstreams - Branch master
 qt5 - Branch dev
 strigidaemon - Branch master

== Cleaning Source Tree

HEAD is now at d567b34 catch file types by extension too
Removing build/
Removing install/

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

Read from socket failed: Connection reset by peer
rsync: connection unexpectedly closed (0 bytes received so far) [Receiver]
rsync error: unexplained error (code 255) at io.c(605) [Receiver=3.0.9]
Syncing dependencies from master server for project plasma-framework failed.
Build step 'Execute shell' marked build as failure
[WARNINGS] Skipping publisher since build result is FAILURE
Skipping Cobertura coverage report as build was not UNSTABLE or better ...
Recording test results
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112717: Start adopting QCollator

[Aleix Pol Gonzalez]

> On Sept. 18, 2013, 3:22 p.m., Mark Gaiser wrote:
> > How RUDE to just commit this without a addressing the concerns Frank and i 
> > have. That is not appreciated!

Alright, maybe I didn't think this through. I'll un-deprecate and bring back 
the KStringHandler::naturalCompare code as you want.

Said that, I doubt these concerns make that much a difference. QCollator has to 
be adopted. Not because of performance reasons but localization alone. 
Performance will happen as well, but for that we need development on the 
applications side, which I'm afraid cannot be up to me as well.

Either way, if you really shouldn't consider ::naturalCompare as a solution. 
ICU is much better tested than naturalCompare (yes, even) and has people more 
qualified than us by making it locale aware (::naturalCompare implementation is 
naive to localization).


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112717/#review40277
---


On Sept. 18, 2013, 2:58 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112717/
> ---
> 
> (Updated Sept. 18, 2013, 2:58 p.m.)
> 
> 
> Review request for KDE Frameworks, Frank Reininghaus and Aurélien Gâteau.
> 
> 
> Description
> ---
> 
> Now that QCollator is public API, I wanted to give it a try, so I decided to 
> port all uses KStringHandler::naturalCompare() to QCollator.
> 
> All the porting was quite straightforward I'd say, the only weird part is 
> that I removed some tests of the KStringHandler tests. There are 2 kind of 
> tests disabled:
> - The ones that say that "A" == "a" in case of Qt::CaseInsensitive. ICU is 
> deterministic and it will decide itself which one goes in, so the test 
> doesn't make sense anymore.
> - There's a mention to the 237788 bug where in some cases our former 
> algorithm wouldn't be deterministic. This doesn't apply anymore, but also now 
> ICU takes care about it now, so there's little point of keeping unit testing 
> it.
> I decided to leave the unit test because it might be useful eventually 
> (although note that it was not being compiled so far). In any case we 
> probably want it out.
> 
> In any case, the rest seems straightforward enough. I didn't concentrate on 
> performance though, in some cases we'll want to use the QCollatorSortKey.
> 
> 
> Diffs
> -
> 
>   KDE5PORTING.html 1287de7 
>   kfile/kdirsortfilterproxymodel.cpp 7c7aa5f 
>   kfile/kurlnavigatorbutton.cpp d2c27fd 
>   staging/itemviews/src/CMakeLists.txt 353a413 
>   staging/itemviews/src/kcategorizedsortfilterproxymodel.h a21e7ca 
>   staging/itemviews/src/kcategorizedsortfilterproxymodel.cpp c8b652d 
>   staging/itemviews/src/kcategorizedsortfilterproxymodel_p.h eb1a67b 
>   staging/kcompletion/src/kcompletion.cpp 5f60a6c 
>   staging/xmlgui/src/kshortcutsdialog_p.h ab102bc 
>   staging/xmlgui/src/kshortcutseditoritem.cpp e89a8aa 
>   tier1/kcoreaddons/autotests/CMakeLists.txt 19227dc 
>   tier1/kcoreaddons/autotests/kstringhandlertest.cpp d12f086 
>   tier1/kcoreaddons/src/lib/text/kstringhandler.h 1b08f6f 
>   tier1/kcoreaddons/src/lib/text/kstringhandler.cpp 2f192aa 
> 
> Diff: http://git.reviewboard.kde.org/r/112717/diff/
> 
> 
> Testing
> ---
> 
> Builds, affected tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #755

[KDE CI System]

See 

Changes:

[notmart] platform specific resolution of imports

--
[...truncated 841 lines...]
In file included from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/KGlobal:1:0,
 from 
:36:
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/../kglobal.h:
 In function ‘T KGlobal::findDirectChild(const QObject*)’:
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/../kglobal.h:514:31:
 warning: ‘QObject* KGlobal::findDirectChild_helper(const QObject*, const 
QMetaObject&)’ is deprecated (declared at 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/../kglobal.h:504)
 [-Wdeprecated-declarations]
:
 In member function ‘bool Plasma::PluginTest::loadFromKService(const QString&)’:
:154:63:
 warning: ‘KPluginInfo::KPluginInfo(KService::Ptr)’ is deprecated (declared at 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kplugininfo.h:114)
 [-Wdeprecated-declarations]
:
 In member function ‘bool Plasma::PluginTest::loadKService(const QString&)’:
:260:63:
 warning: ‘KPluginInfo::KPluginInfo(KService::Ptr)’ is deprecated (declared at 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kplugininfo.h:114)
 [-Wdeprecated-declarations]
:
 At global scope:
:287:6:
 warning: unused parameter ‘s’ [-Wunused-parameter]
:287:6:
 warning: unused parameter ‘d’ [-Wunused-parameter]
[ 55%] Built target runnercontexttest
Linking CXX executable configloadertest
[ 56%] Building CXX object 
src/plasma/autotests/CMakeFiles/storagetest.dir/__/private/storagethread.cpp.o
[ 56%] Building CXX object 
src/plasma/autotests/CMakeFiles/storagetest.dir/storagetest_automoc.cpp.o
Linking CXX executable packagestructuretest
[ 56%] Building CXX object 
src/plasma/tests/kplugins/CMakeFiles/plugintest.dir/plugintest_automoc.cpp.o
Linking CXX executable plugintest
[ 56%] Built target configloadertest
[ 56%] Built target packagestructuretest
[ 56%] Built target plugintest
Scanning dependencies of target runnermodeltest
[ 57%] Scanning dependencies of target corebindingsplugin
Building CXX object 
src/declarativeimports/core/tests/CMakeFiles/runnermodeltest.dir/main.cpp.o
[ 57%] Building CXX object 
src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/corebindingsplugin.cpp.o
Scanning dependencies of target sortfiltermodeltest
[ 58%] Building CXX object 
src/declarativeimports/core/tests/CMakeFiles/sortfiltermodeltest.dir/sortfiltermodeltest.cpp.o
[ 58%] Building CXX object 
src/declarativeimports/core/tests/CMakeFiles/runnermodeltest.dir/dynamictreemodel.cpp.o
Linking CXX executable storagetest
[ 58%] Building CXX object 
src/declarativeimports/core/tests/CMakeFiles/runnermodeltest.dir/modeltest.cpp.o
[ 58%] Built target storagetest
[ 58%] Building CXX object 
src/declarativeimports/core/tests/CMakeFiles/sortfiltermodeltest.dir/__/__/__/plasma/dataengineconsumer.cpp.o
In file included from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/qtest_kde.h:28:0,
 from 
:24:
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:60:52:
 warning: ‘KCmdLineOptions’ is deprecated [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:65:63:
 warning: ‘KCmdLineOptions’ is deprecated (declared at 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:46)
 [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:65:63:
 warning: ‘KCmdLineOptions’ is deprecated [-Wdeprecated-declarations]
In file included from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/qtest_kde.h:28:0,
 from 
:24:
/srv/jenkins/install/linux/x64_64/g++/qt

Review Request 112796: Move kcolorutilsdemo from kconfigwidgets/tests to kguiaddons/tests

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112796/
---

Review request for KDE Frameworks.


Description
---

This is required for kconfigwidgets to build standalone because 
kcolorutilsdemo.cpp includes kcolorspaces.h, which is part of kguiaddons but 
not installed.


Diffs
-

  staging/kconfigwidgets/tests/CMakeLists.txt bc52bc1 
  staging/kconfigwidgets/tests/kcolorutilsdemo.h 09e867a 
  staging/kconfigwidgets/tests/kcolorutilsdemo.cpp 940569e 
  staging/kconfigwidgets/tests/kcolorutilsdemo.ui c6604fd 
  staging/kconfigwidgets/tests/kimageframe.h d521cb5 
  staging/kconfigwidgets/tests/kimageframe.cpp 60a5e9d 
  tier1/kguiaddons/tests/CMakeLists.txt 4d91ed8 
  tier1/kguiaddons/tests/kcolorutilsdemo.h PRE-CREATION 
  tier1/kguiaddons/tests/kcolorutilsdemo.cpp PRE-CREATION 
  tier1/kguiaddons/tests/kcolorutilsdemo.ui PRE-CREATION 
  tier1/kguiaddons/tests/kimageframe.h PRE-CREATION 
  tier1/kguiaddons/tests/kimageframe.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112796/diff/


Testing
---

Still builds, kcolorutilsdemo runs correctly.


Thanks,

Aurélien Gâteau

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : plasma-framework_master_qt5 #756

[KDE CI System]

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112795: Move KDocTools to tier2

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112795/
---

Review request for KDE Frameworks.


Description
---

Does the move, changes a couple of things so the macros are still found.


Diffs
-

  cmake/modules/KDE4Macros.cmake 403679f 
  staging/CMakeLists.txt 7826b07 
  tier2/CMakeLists.txt 6c98a7d 
  tier2/kdoctools/CMakeLists.txt 7e09279 

Diff: http://git.reviewboard.kde.org/r/112795/diff/


Testing
---

Builds, no tests.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #1220

[KDE CI System]

See 

Changes:

[wojtask9.kde] KStyle trim down

--
[...truncated 3595 lines...]
[ 29%] [ 29%] [ 29%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/fakehw/fakevideo.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/shared/cpufeatures.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/udev/udevdevice.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/fakehw/fakevolume.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/udev/utils.cpp.o
[ 29%] [ 29%] [ 29%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/fakehw/fakesmartcardreader.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/udev/udevmanager.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/udev/udevdeviceinterface.cpp.o
[ 29%] [ 29%] [ 29%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/udev/udevgenericinterface.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/udev/cpuinfo.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/shared/rootdevice.cpp.o
[ 29%] [ 29%] [ 29%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/udev/udevcamera.cpp.o
[ 29%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/udev/udevprocessor.cpp.o
[ 29%] [ 29%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/udev/udevvideo.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/shared/cpufeatures.cpp.o
Generating moc_downloadmanager.cpp
Generating moc_downloadwidget.cpp
Generating moc_uploaddialog.cpp
Generating moc_atticaprovider.cpp
Generating moc_cache.cpp
Generating moc_engine.cpp
Generating moc_installation.cpp
Generating moc_provider.cpp
Generating moc_security.cpp
Generating moc_xmlloader.cpp
Generating moc_downloaddialog.cpp
Generating moc_knewstuffbutton.cpp
Generating moc_staticxmlprovider.cpp
Generating moc_entrydetailsdialog.cpp
Generating moc_imageloader.cpp
Generating moc_imagepreviewwidget.cpp
Generating moc_itemsgridviewdelegate.cpp
Generating moc_itemsmodel.cpp
Generating moc_itemsviewbasedelegate.cpp
Generating moc_itemsviewdelegate.cpp
Generating moc_progressindicator.cpp
Generating moc_atticahelper.cpp
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/udev/udevnetworkinterface.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/udev/udevaudiointerface.cpp.o
[ 29%] [ 29%] Built target knewstuff3_automoc
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/udev/udevserialinterface.cpp.o
[ 29%] [ 29%] [ 29%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/udev/utils.cpp.o
[ 29%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/udev/udevaudiointerface_p.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/udev/udevportablemediaplayer.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevdevice.cpp.o
[ 29%] [ 29%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevmanager.cpp.o
[ 29%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevdeviceinterface.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevgenericinterface.cpp.o
[ 29%] [ 29%] [ 29%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/udev/udevdvbinterface.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/udev/cpuinfo.cpp.o
[ 30%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/udev/udevblock.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/udev/udevbutton.cpp.o
[ 30%] [ 30%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/udev/udevkeyboard.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/udev/udevpointingdevice.cpp.o
[ 30%] [ 30%] [ 30%] [ 30%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevprocessor.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/shared/udevqtclient.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevvideo.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevcamera.cpp.o
[ 30%] [ 30%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/shared/udevqtdevice.cpp.o
[ 30%] [ 30%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevaudiointerface.cpp.o
Building CXX object 
tier1/solid/

Re: Review Request 112519: trim KStyle

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112519/#review40278
---


This review has been submitted with commit 
807b861a434aef32aeb82b1e9afa9bef364206c8 by Wojciech Kapuscinski to branch 
frameworks.

- Commit Hook


On Sept. 17, 2013, 1:54 p.m., Wojciech Kapuscinski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112519/
> ---
> 
> (Updated Sept. 17, 2013, 1:54 p.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Feck and Hugo Pereira Da Costa.
> 
> 
> Description
> ---
> 
> KStyle 2/3: Remove everything from KStyle which is not a reimplementation of 
> the following methods: polish, unpolish, eventFilter, styleHint, 
> pixelMetrics, standardIcons.
> 
> 
> Note:
> Probably we can remove drawKStylePrimitive (and a lot enums/structs in 
> kstyle.h) but right now I'm unsure if I understand KStyle::eventFilter 
> correctly and this is material for 3/3 KStyle task :)
> 
> 
> Diffs
> -
> 
>   staging/frameworkintegration/src/kstyle/kstyle.h a3061d3 
>   staging/frameworkintegration/src/kstyle/kstyle.cpp 17a1d41 
> 
> Diff: http://git.reviewboard.kde.org/r/112519/diff/
> 
> 
> Testing
> ---
> 
> It builds and tests looks OK
> 
> 
> Thanks,
> 
> Wojciech Kapuscinski
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112519: trim KStyle

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112519/
---

(Updated Sept. 18, 2013, 3:29 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Christoph Feck and Hugo Pereira Da Costa.


Description
---

KStyle 2/3: Remove everything from KStyle which is not a reimplementation of 
the following methods: polish, unpolish, eventFilter, styleHint, pixelMetrics, 
standardIcons.


Note:
Probably we can remove drawKStylePrimitive (and a lot enums/structs in 
kstyle.h) but right now I'm unsure if I understand KStyle::eventFilter 
correctly and this is material for 3/3 KStyle task :)


Diffs
-

  staging/frameworkintegration/src/kstyle/kstyle.h a3061d3 
  staging/frameworkintegration/src/kstyle/kstyle.cpp 17a1d41 

Diff: http://git.reviewboard.kde.org/r/112519/diff/


Testing
---

It builds and tests looks OK


Thanks,

Wojciech Kapuscinski

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112717: Start adopting QCollator

[Mark Gaiser]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112717/#review40277
---


How RUDE to just commit this without a addressing the concerns Frank and i 
have. That is not appreciated!

- Mark Gaiser


On Sept. 18, 2013, 2:58 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112717/
> ---
> 
> (Updated Sept. 18, 2013, 2:58 p.m.)
> 
> 
> Review request for KDE Frameworks, Frank Reininghaus and Aurélien Gâteau.
> 
> 
> Description
> ---
> 
> Now that QCollator is public API, I wanted to give it a try, so I decided to 
> port all uses KStringHandler::naturalCompare() to QCollator.
> 
> All the porting was quite straightforward I'd say, the only weird part is 
> that I removed some tests of the KStringHandler tests. There are 2 kind of 
> tests disabled:
> - The ones that say that "A" == "a" in case of Qt::CaseInsensitive. ICU is 
> deterministic and it will decide itself which one goes in, so the test 
> doesn't make sense anymore.
> - There's a mention to the 237788 bug where in some cases our former 
> algorithm wouldn't be deterministic. This doesn't apply anymore, but also now 
> ICU takes care about it now, so there's little point of keeping unit testing 
> it.
> I decided to leave the unit test because it might be useful eventually 
> (although note that it was not being compiled so far). In any case we 
> probably want it out.
> 
> In any case, the rest seems straightforward enough. I didn't concentrate on 
> performance though, in some cases we'll want to use the QCollatorSortKey.
> 
> 
> Diffs
> -
> 
>   KDE5PORTING.html 1287de7 
>   kfile/kdirsortfilterproxymodel.cpp 7c7aa5f 
>   kfile/kurlnavigatorbutton.cpp d2c27fd 
>   staging/itemviews/src/CMakeLists.txt 353a413 
>   staging/itemviews/src/kcategorizedsortfilterproxymodel.h a21e7ca 
>   staging/itemviews/src/kcategorizedsortfilterproxymodel.cpp c8b652d 
>   staging/itemviews/src/kcategorizedsortfilterproxymodel_p.h eb1a67b 
>   staging/kcompletion/src/kcompletion.cpp 5f60a6c 
>   staging/xmlgui/src/kshortcutsdialog_p.h ab102bc 
>   staging/xmlgui/src/kshortcutseditoritem.cpp e89a8aa 
>   tier1/kcoreaddons/autotests/CMakeLists.txt 19227dc 
>   tier1/kcoreaddons/autotests/kstringhandlertest.cpp d12f086 
>   tier1/kcoreaddons/src/lib/text/kstringhandler.h 1b08f6f 
>   tier1/kcoreaddons/src/lib/text/kstringhandler.cpp 2f192aa 
> 
> Diff: http://git.reviewboard.kde.org/r/112717/diff/
> 
> 
> Testing
> ---
> 
> Builds, affected tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #1219

[KDE CI System]

See 

Changes:

[aleixpol] Reorganize KDocTools cmake code

[aleixpol] Start adopting QCollator

--
[...truncated 3600 lines...]
[ 24%] [ 24%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/button.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/block.cpp.o
[ 24%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/keyboard.cpp.o
[ 24%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/pointingdevice.cpp.o
[ 24%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/button.cpp.o
[ 24%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/camera.cpp.o
[ 24%] [ 24%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/keyboard.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/pointingdevice.cpp.o
[ 24%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/camera.cpp.o
[ 24%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/opticaldrive.cpp.o
[ 24%] [ 24%] [ 24%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/device.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/opticaldrive.cpp.o
[ 24%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/deviceinterface.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/device.cpp.o
[ 24%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/deviceinterface.cpp.o
[ 24%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/devicemanager.cpp.o
[ 24%] [ 25%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/dvbinterface.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/devicemanager.cpp.o
[ 25%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/genericinterface.cpp.o
[ 26%] [ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/networkinterface.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/dvbinterface.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/genericinterface.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/networkinterface.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/networkshare.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/serialinterface.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/opticaldisc.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/networkshare.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/serialinterface.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/opticaldisc.cpp.o
[ 26%] [ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/portablemediaplayer.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/portablemediaplayer.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/processor.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/processor.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/storagedrive.cpp.o
[ 26%] [ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/storagevolume.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/storageaccess.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/video.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/storagedrive.cpp.o
[ 26%] [ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/smartcardreader.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/storagevolume.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/storageaccess.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/video.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/smartcardreader.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/internetgateway.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/internetgateway.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/fakehw/fakeacadapter.cpp.o
[ 26%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/fakehw/fakeaudiointerface.cpp.o
[ 26%] Building CXX object 
tier1/solid

Re: Review Request 112792: Move itemviews to tier2

[Aleix Pol Gonzalez]

> On Sept. 18, 2013, 2:58 p.m., Aleix Pol Gonzalez wrote:
> > I was waiting for alex to send the meeting minutes telling people to 
> > upgrade their Qt repo.
> > 
> > Pushing it now.

It's pushed, sorry for the wait >.<


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112792/#review40272
---


On Sept. 18, 2013, 2:50 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112792/
> ---
> 
> (Updated Sept. 18, 2013, 2:50 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Move itemviews to tier2. Was waiting for the QCollator request (  
> https://git.reviewboard.kde.org/r/112717/ ) to go in before so that itemviews 
> could go to tier1, but it seems it is not going in, so let's go tier2 for now.
> 
> 
> Diffs
> -
> 
>   staging/CMakeLists.txt 7826b07 
>   staging/itemviews/CMakeLists.txt  
>   staging/itemviews/ItemViewsConfig.cmake.in  
>   staging/itemviews/autotests/CMakeLists.txt  
>   staging/itemviews/autotests/klistwidgetsearchlinetest.cpp  
>   staging/itemviews/src/CMakeLists.txt  
>   staging/itemviews/src/kcategorizedsortfilterproxymodel.h  
>   staging/itemviews/src/kcategorizedsortfilterproxymodel.cpp  
>   staging/itemviews/src/kcategorizedsortfilterproxymodel_p.h  
>   staging/itemviews/src/kcategorizedview.h  
>   staging/itemviews/src/kcategorizedview.cpp  
>   staging/itemviews/src/kcategorizedview_p.h  
>   staging/itemviews/src/kcategorydrawer.h  
>   staging/itemviews/src/kcategorydrawer.cpp  
>   staging/itemviews/src/kextendableitemdelegate.h  
>   staging/itemviews/src/kextendableitemdelegate.cpp  
>   staging/itemviews/src/kfilterproxysearchline.h  
>   staging/itemviews/src/kfilterproxysearchline.cpp  
>   staging/itemviews/src/klistwidgetsearchline.h  
>   staging/itemviews/src/klistwidgetsearchline.cpp  
>   staging/itemviews/src/ktreewidgetsearchline.h  
>   staging/itemviews/src/ktreewidgetsearchline.cpp  
>   staging/itemviews/src/kwidgetitemdelegate.h  
>   staging/itemviews/src/kwidgetitemdelegate.cpp  
>   staging/itemviews/src/kwidgetitemdelegate_p.h  
>   staging/itemviews/src/kwidgetitemdelegatepool.cpp  
>   staging/itemviews/src/kwidgetitemdelegatepool_p.h  
>   staging/itemviews/tests/CMakeLists.txt  
>   staging/itemviews/tests/kcategorizedviewtest.cpp  
>   staging/itemviews/tests/ktreewidgetsearchlinetest.h  
>   staging/itemviews/tests/ktreewidgetsearchlinetest.cpp  
>   staging/itemviews/tests/kwidgetitemdelegatetest.cpp  
>   superbuild/CMakeLists.txt c297be6 
>   tier2/CMakeLists.txt 6c98a7d 
> 
> Diff: http://git.reviewboard.kde.org/r/112792/diff/
> 
> 
> Testing
> ---
> 
> Builds within kdelibs and standalone. The single auto test passes, manual 
> tests are running correctly.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112717: Start adopting QCollator

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112717/
---

(Updated Sept. 18, 2013, 2:58 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Frank Reininghaus and Aurélien Gâteau.


Description
---

Now that QCollator is public API, I wanted to give it a try, so I decided to 
port all uses KStringHandler::naturalCompare() to QCollator.

All the porting was quite straightforward I'd say, the only weird part is that 
I removed some tests of the KStringHandler tests. There are 2 kind of tests 
disabled:
- The ones that say that "A" == "a" in case of Qt::CaseInsensitive. ICU is 
deterministic and it will decide itself which one goes in, so the test doesn't 
make sense anymore.
- There's a mention to the 237788 bug where in some cases our former algorithm 
wouldn't be deterministic. This doesn't apply anymore, but also now ICU takes 
care about it now, so there's little point of keeping unit testing it.
I decided to leave the unit test because it might be useful eventually 
(although note that it was not being compiled so far). In any case we probably 
want it out.

In any case, the rest seems straightforward enough. I didn't concentrate on 
performance though, in some cases we'll want to use the QCollatorSortKey.


Diffs
-

  KDE5PORTING.html 1287de7 
  kfile/kdirsortfilterproxymodel.cpp 7c7aa5f 
  kfile/kurlnavigatorbutton.cpp d2c27fd 
  staging/itemviews/src/CMakeLists.txt 353a413 
  staging/itemviews/src/kcategorizedsortfilterproxymodel.h a21e7ca 
  staging/itemviews/src/kcategorizedsortfilterproxymodel.cpp c8b652d 
  staging/itemviews/src/kcategorizedsortfilterproxymodel_p.h eb1a67b 
  staging/kcompletion/src/kcompletion.cpp 5f60a6c 
  staging/xmlgui/src/kshortcutsdialog_p.h ab102bc 
  staging/xmlgui/src/kshortcutseditoritem.cpp e89a8aa 
  tier1/kcoreaddons/autotests/CMakeLists.txt 19227dc 
  tier1/kcoreaddons/autotests/kstringhandlertest.cpp d12f086 
  tier1/kcoreaddons/src/lib/text/kstringhandler.h 1b08f6f 
  tier1/kcoreaddons/src/lib/text/kstringhandler.cpp 2f192aa 

Diff: http://git.reviewboard.kde.org/r/112717/diff/


Testing
---

Builds, affected tests pass.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112717: Start adopting QCollator

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112717/#review40273
---


This review has been submitted with commit 
e7c9d9720635131bef2255a47c6c557d0f406cf0 by Aleix Pol to branch frameworks.

- Commit Hook


On Sept. 13, 2013, 5:55 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112717/
> ---
> 
> (Updated Sept. 13, 2013, 5:55 p.m.)
> 
> 
> Review request for KDE Frameworks, Frank Reininghaus and Aurélien Gâteau.
> 
> 
> Description
> ---
> 
> Now that QCollator is public API, I wanted to give it a try, so I decided to 
> port all uses KStringHandler::naturalCompare() to QCollator.
> 
> All the porting was quite straightforward I'd say, the only weird part is 
> that I removed some tests of the KStringHandler tests. There are 2 kind of 
> tests disabled:
> - The ones that say that "A" == "a" in case of Qt::CaseInsensitive. ICU is 
> deterministic and it will decide itself which one goes in, so the test 
> doesn't make sense anymore.
> - There's a mention to the 237788 bug where in some cases our former 
> algorithm wouldn't be deterministic. This doesn't apply anymore, but also now 
> ICU takes care about it now, so there's little point of keeping unit testing 
> it.
> I decided to leave the unit test because it might be useful eventually 
> (although note that it was not being compiled so far). In any case we 
> probably want it out.
> 
> In any case, the rest seems straightforward enough. I didn't concentrate on 
> performance though, in some cases we'll want to use the QCollatorSortKey.
> 
> 
> Diffs
> -
> 
>   KDE5PORTING.html 1287de7 
>   kfile/kdirsortfilterproxymodel.cpp 7c7aa5f 
>   kfile/kurlnavigatorbutton.cpp d2c27fd 
>   staging/itemviews/src/CMakeLists.txt 353a413 
>   staging/itemviews/src/kcategorizedsortfilterproxymodel.h a21e7ca 
>   staging/itemviews/src/kcategorizedsortfilterproxymodel.cpp c8b652d 
>   staging/itemviews/src/kcategorizedsortfilterproxymodel_p.h eb1a67b 
>   staging/kcompletion/src/kcompletion.cpp 5f60a6c 
>   staging/xmlgui/src/kshortcutsdialog_p.h ab102bc 
>   staging/xmlgui/src/kshortcutseditoritem.cpp e89a8aa 
>   tier1/kcoreaddons/autotests/CMakeLists.txt 19227dc 
>   tier1/kcoreaddons/autotests/kstringhandlertest.cpp d12f086 
>   tier1/kcoreaddons/src/lib/text/kstringhandler.h 1b08f6f 
>   tier1/kcoreaddons/src/lib/text/kstringhandler.cpp 2f192aa 
> 
> Diff: http://git.reviewboard.kde.org/r/112717/diff/
> 
> 
> Testing
> ---
> 
> Builds, affected tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112792: Move itemviews to tier2

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112792/#review40272
---


I was waiting for alex to send the meeting minutes telling people to upgrade 
their Qt repo.

Pushing it now.

- Aleix Pol Gonzalez


On Sept. 18, 2013, 2:50 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112792/
> ---
> 
> (Updated Sept. 18, 2013, 2:50 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Move itemviews to tier2. Was waiting for the QCollator request (  
> https://git.reviewboard.kde.org/r/112717/ ) to go in before so that itemviews 
> could go to tier1, but it seems it is not going in, so let's go tier2 for now.
> 
> 
> Diffs
> -
> 
>   staging/CMakeLists.txt 7826b07 
>   staging/itemviews/CMakeLists.txt  
>   staging/itemviews/ItemViewsConfig.cmake.in  
>   staging/itemviews/autotests/CMakeLists.txt  
>   staging/itemviews/autotests/klistwidgetsearchlinetest.cpp  
>   staging/itemviews/src/CMakeLists.txt  
>   staging/itemviews/src/kcategorizedsortfilterproxymodel.h  
>   staging/itemviews/src/kcategorizedsortfilterproxymodel.cpp  
>   staging/itemviews/src/kcategorizedsortfilterproxymodel_p.h  
>   staging/itemviews/src/kcategorizedview.h  
>   staging/itemviews/src/kcategorizedview.cpp  
>   staging/itemviews/src/kcategorizedview_p.h  
>   staging/itemviews/src/kcategorydrawer.h  
>   staging/itemviews/src/kcategorydrawer.cpp  
>   staging/itemviews/src/kextendableitemdelegate.h  
>   staging/itemviews/src/kextendableitemdelegate.cpp  
>   staging/itemviews/src/kfilterproxysearchline.h  
>   staging/itemviews/src/kfilterproxysearchline.cpp  
>   staging/itemviews/src/klistwidgetsearchline.h  
>   staging/itemviews/src/klistwidgetsearchline.cpp  
>   staging/itemviews/src/ktreewidgetsearchline.h  
>   staging/itemviews/src/ktreewidgetsearchline.cpp  
>   staging/itemviews/src/kwidgetitemdelegate.h  
>   staging/itemviews/src/kwidgetitemdelegate.cpp  
>   staging/itemviews/src/kwidgetitemdelegate_p.h  
>   staging/itemviews/src/kwidgetitemdelegatepool.cpp  
>   staging/itemviews/src/kwidgetitemdelegatepool_p.h  
>   staging/itemviews/tests/CMakeLists.txt  
>   staging/itemviews/tests/kcategorizedviewtest.cpp  
>   staging/itemviews/tests/ktreewidgetsearchlinetest.h  
>   staging/itemviews/tests/ktreewidgetsearchlinetest.cpp  
>   staging/itemviews/tests/kwidgetitemdelegatetest.cpp  
>   superbuild/CMakeLists.txt c297be6 
>   tier2/CMakeLists.txt 6c98a7d 
> 
> Diff: http://git.reviewboard.kde.org/r/112792/diff/
> 
> 
> Testing
> ---
> 
> Builds within kdelibs and standalone. The single auto test passes, manual 
> tests are running correctly.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

KF5 Update Meeting Minutes 2013-w38

[Àlex Fiestas]

Hi there

These are the minutes of the Week 38 KF5 meeting. As usual it has been held on 
#kde-devel at 4pm Barcelona (CEST / UTC+2) time.

Present on the meeting: agateau, apol, dfaure, jpwhiting, mck182, 
mgraesslin, sebas, steveire, svuorela, teo-, vHanda, afiestas, d_ed

Announcements:
*This friday is Qt feature Freeze.
*kde-workspace master branch will become Qt5/KF5 based next Monday
*Please upgrade your Qt snapshot (At least it should contain 
1864b485e4c37db2ef09b8a47a5bf3cc570cc222)

Topics discussed:
*apol: QCollator is finally in!
*apol: Working on adoption of QCollator in KF5
*apol: Moved k18n to tier2
*apol: Moved KCompletion to tier2
*apol: Moved KNotifications to tier2
*apol: Working in KF5 alternatives for kde4_add_executable and 
kde4_add_unit_test

*teo-: QXcbSessionManager got merged
*teo-: Working on KEncodingFileDialog making it static

*dfaure: The Reviewer

*agateau:  Will move ItemViews to tier1 now that QCollator is in
*agateau:  Waiting feedback for KInterProcessWindowing
*agateau: Wrote tests for KInterProcessWindowing

*jpwhiting: Will put kde4uic.cmake in place
*jpwhiting: Clean KNewStuff and move it to a tier

*mck182: Continue working on Printing stuff

*sebas: KPluginTrader work querying for plugins using the json metadata 
instead of KSycoca.
*sebas: Some niggles in the tests still to work out, patch already on RB
*sebas: Looking into performance right now, especially on rotating disks it's 
quite a lot slower than ksycoca, I'll post some more numbers to the list once 
I have numbers that make sense.
*sebas: libdbusmenu-qt cmake foo needs doing
*sebas: K_PLUGIN_VERIFICATION_DATA fixage
*sebas: Escalate crasher in Qt's v4 javascript engine
*sebas: Porting of Plasma's systray

*mgraesslin: KWin getting stable
*mgraesslin: Adding tests into KWindowSystem

*svorela: QtPaths (kde4-config successor) merged in qt.

*wojtask9_: Working on a graph cleaner
*wojtask9_: Waiting for review in KStyle

*d__ed: Moved KConfigWidgets away from using _p.h files from another tier *2.
*d__ed: Working on a Qt patch where they hardcode control+U control+E in key 
handling, but not in shortcut overrides 
(https://codereview.qt-project.org/#change,65537) working in a new patch since 
it was discarted

*afiestas: Moved KIO::NetAccess to kde4support
*afiestas: Working on KIconTheme (trying to make kpixmapsequencer* tier1)

If you got questions, feel free to ask.

Cheers !

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112792: Move itemviews to tier2

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112792/
---

Review request for KDE Frameworks.


Description
---

Move itemviews to tier2. Was waiting for the QCollator request (  
https://git.reviewboard.kde.org/r/112717/ ) to go in before so that itemviews 
could go to tier1, but it seems it is not going in, so let's go tier2 for now.


Diffs
-

  staging/CMakeLists.txt 7826b07 
  staging/itemviews/CMakeLists.txt  
  staging/itemviews/ItemViewsConfig.cmake.in  
  staging/itemviews/autotests/CMakeLists.txt  
  staging/itemviews/autotests/klistwidgetsearchlinetest.cpp  
  staging/itemviews/src/CMakeLists.txt  
  staging/itemviews/src/kcategorizedsortfilterproxymodel.h  
  staging/itemviews/src/kcategorizedsortfilterproxymodel.cpp  
  staging/itemviews/src/kcategorizedsortfilterproxymodel_p.h  
  staging/itemviews/src/kcategorizedview.h  
  staging/itemviews/src/kcategorizedview.cpp  
  staging/itemviews/src/kcategorizedview_p.h  
  staging/itemviews/src/kcategorydrawer.h  
  staging/itemviews/src/kcategorydrawer.cpp  
  staging/itemviews/src/kextendableitemdelegate.h  
  staging/itemviews/src/kextendableitemdelegate.cpp  
  staging/itemviews/src/kfilterproxysearchline.h  
  staging/itemviews/src/kfilterproxysearchline.cpp  
  staging/itemviews/src/klistwidgetsearchline.h  
  staging/itemviews/src/klistwidgetsearchline.cpp  
  staging/itemviews/src/ktreewidgetsearchline.h  
  staging/itemviews/src/ktreewidgetsearchline.cpp  
  staging/itemviews/src/kwidgetitemdelegate.h  
  staging/itemviews/src/kwidgetitemdelegate.cpp  
  staging/itemviews/src/kwidgetitemdelegate_p.h  
  staging/itemviews/src/kwidgetitemdelegatepool.cpp  
  staging/itemviews/src/kwidgetitemdelegatepool_p.h  
  staging/itemviews/tests/CMakeLists.txt  
  staging/itemviews/tests/kcategorizedviewtest.cpp  
  staging/itemviews/tests/ktreewidgetsearchlinetest.h  
  staging/itemviews/tests/ktreewidgetsearchlinetest.cpp  
  staging/itemviews/tests/kwidgetitemdelegatetest.cpp  
  superbuild/CMakeLists.txt c297be6 
  tier2/CMakeLists.txt 6c98a7d 

Diff: http://git.reviewboard.kde.org/r/112792/diff/


Testing
---

Builds within kdelibs and standalone. The single auto test passes, manual tests 
are running correctly.


Thanks,

Aurélien Gâteau

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112699: Reorganize KDocTools cmake code

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112699/
---

(Updated Sept. 18, 2013, 2:41 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Stephen Kelly.


Description
---

Move the finders from kdoctools/CMakeLists.txt to kdoctools/src/CMakeLists.txt.
This should make it possible to move kdoctools to its own tier.

Question: At the moment, to use kdoctools from an application, we'll have to 
include KDocToolsMacros.cmake.
Wouldn't it make sense to rename it to FindKDocTools.cmake?


Diffs
-

  staging/kdoctools/CMakeLists.txt 7687f97 
  staging/kdoctools/src/CMakeLists.txt 6910ef7 

Diff: http://git.reviewboard.kde.org/r/112699/diff/


Testing
---

Builds


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112699: Reorganize KDocTools cmake code

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112699/#review40270
---


This review has been submitted with commit 
66b627f9a4f62d4c8e90fb9b0fe8949fa8376706 by Aleix Pol to branch frameworks.

- Commit Hook


On Sept. 13, 2013, 11:15 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112699/
> ---
> 
> (Updated Sept. 13, 2013, 11:15 a.m.)
> 
> 
> Review request for KDE Frameworks and Stephen Kelly.
> 
> 
> Description
> ---
> 
> Move the finders from kdoctools/CMakeLists.txt to 
> kdoctools/src/CMakeLists.txt.
> This should make it possible to move kdoctools to its own tier.
> 
> Question: At the moment, to use kdoctools from an application, we'll have to 
> include KDocToolsMacros.cmake.
> Wouldn't it make sense to rename it to FindKDocTools.cmake?
> 
> 
> Diffs
> -
> 
>   staging/kdoctools/CMakeLists.txt 7687f97 
>   staging/kdoctools/src/CMakeLists.txt 6910ef7 
> 
> Diff: http://git.reviewboard.kde.org/r/112699/diff/
> 
> 
> Testing
> ---
> 
> Builds
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: ki18n

[Aleix Pol]

On Tue, Sep 17, 2013 at 10:55 PM, Treeve Jelbert  wrote:

> 1. ki18n exists in both tier2 and staging
>
> 2. kunitconversion (tier2) depends on ki18n(tier2)
> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>

You were right, just fixed these two problems.

Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112681: Tests for KPluginTrader and friends

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112681/
---

(Updated Sept. 18, 2013, 12:12 p.m.)


Review request for KDE Frameworks and David Faure.


Changes
---

Fixed version.


Description
---

Tests for KPluginTrader.

Under autotests/, there's a new test class which runs a variety of queries 
using KPluginTrader. There's also a small plugin, which is used to verify 
correct metadata querying and loading. It's not installed since QPluginLoader 
conveniently contains the working directory when looking for plugins -> it's 
found just fine.

Under tests/, there's a test which will query for a variety of other plugins. 
This one is more geared towards performance testing. When run from make test, 
it will pass anyway.

Code can also be found in kdelibs[sebas/pluginlocator].


Diffs (updated)
-

  staging/kservice/autotests/CMakeLists.txt d341040 
  staging/kservice/autotests/fakeplugin.desktop PRE-CREATION 
  staging/kservice/autotests/fakeplugin.json PRE-CREATION 
  staging/kservice/autotests/nsaplugin.h PRE-CREATION 
  staging/kservice/autotests/nsaplugin.cpp PRE-CREATION 
  staging/kservice/autotests/pluginlocatortest.h PRE-CREATION 
  staging/kservice/autotests/pluginlocatortest.cpp PRE-CREATION 
  staging/kservice/tests/CMakeLists.txt 3793aea 
  staging/kservice/tests/pluginlocator/CMakeLists.txt PRE-CREATION 
  staging/kservice/tests/pluginlocator/main.cpp PRE-CREATION 
  staging/kservice/tests/pluginlocator/plugintest.h PRE-CREATION 
  staging/kservice/tests/pluginlocator/plugintest.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112681/diff/


Testing
---

make test =)

All tests pass on top of my patches.


Thanks,

Sebastian Kügler

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112519: trim KStyle

[Wojciech Kapuscinski]

> On Sept. 17, 2013, 11:32 p.m., Christoph Feck wrote:
> > What exactly is the plan for "KStyle 3/3"? I see many more cruft that could 
> > be removed for the KF5 version, in particular, all the enums. If that's the 
> > idea, please ship this in the meantime.

>From KF5 wiki "3/3 From what remains of KStyle after the previous two tasks, 
>evaluate what is here to enforce platform settings and what might make style 
>developers life too hard, keep only the parts about platform settings and let 
>go the rest".

In KF5 world oxygen-style and others must subclass KStyle because we want 
enforce some users settings (activate item on single click, show icons/text on 
buttons/menu, animate widget etc).

And yes probably we can get rid off all enums :)


> On Sept. 17, 2013, 11:32 p.m., Christoph Feck wrote:
> > staging/frameworkintegration/src/kstyle/kstyle.cpp, line 274
> > 
> >
> > Could you check the diff on reviewboard site? Here, I see many red 
> > "whitespace" issues now.

Copy & Paste error :) I'll fix whitespace issues


- Wojciech


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112519/#review40252
---


On Sept. 17, 2013, 1:54 p.m., Wojciech Kapuscinski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112519/
> ---
> 
> (Updated Sept. 17, 2013, 1:54 p.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Feck and Hugo Pereira Da Costa.
> 
> 
> Description
> ---
> 
> KStyle 2/3: Remove everything from KStyle which is not a reimplementation of 
> the following methods: polish, unpolish, eventFilter, styleHint, 
> pixelMetrics, standardIcons.
> 
> 
> Note:
> Probably we can remove drawKStylePrimitive (and a lot enums/structs in 
> kstyle.h) but right now I'm unsure if I understand KStyle::eventFilter 
> correctly and this is material for 3/3 KStyle task :)
> 
> 
> Diffs
> -
> 
>   staging/frameworkintegration/src/kstyle/kstyle.h a3061d3 
>   staging/frameworkintegration/src/kstyle/kstyle.cpp 17a1d41 
> 
> Diff: http://git.reviewboard.kde.org/r/112519/diff/
> 
> 
> Testing
> ---
> 
> It builds and tests looks OK
> 
> 
> Thanks,
> 
> Wojciech Kapuscinski
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel