date:20130919

Re: kde4_add_plugin on KF5

2013-09-19 Thread Aleix Pol

On Thu, Sep 19, 2013 at 7:39 PM, Alexander Neundorf wrote:

> On Thursday 19 September 2013, Alex Merry wrote:
> > On 19/09/13 17:00, Aleix Pol wrote:
> > > Hi,
> > > We should decide what we do with the add_plugin macro. Should I install
> > > it as kf5_add_plugin from KCoreAddons? Do we want something different
> or
> > > better?
> >
> > Would e-c-m be the right place for it?
>
> Depends on what it does.
> IMO, if it is generally useful, and has no KDE dependencies, yes.
> If it is only useful for KDE, it might go into kde-modules and get a KDEish
> prefix. But this is actually not wanted.
>
> But I think Stephens plan is to get rid of those macros and use plain cmake
> instead, i.e. add_library(... MODULE ...), as with add_executable() and
> add_library().
>
> Alex
> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>

Ah, right. So maybe I can just change those to add_library(MODULE) and
forget about macros, right?

Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112808: Port away from KDirWatch in KEmoticons (prior to splitting)

2013-09-19 Thread David Gil Oliva


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112808/
---

(Updated Sept. 19, 2013, 8:37 p.m.)


Review request for KDE Frameworks.


Changes
---

Address David's suggestion.


Description
---

Port away from KDirWatch in KEmoticons (prior to splitting)


Diffs (updated)
-

  staging/kemoticons/src/core/CMakeLists.txt 
0e79eaae60dfd5cd5e0c5f6848b86dbb90c0c818 
  staging/kemoticons/src/core/kemoticons.cpp 
5f6a23ec606b3c6dceac2e01a280413e6899a59b 

Diff: http://git.reviewboard.kde.org/r/112808/diff/


Testing
---

It builds and installs correctly.


Thanks,

David Gil Oliva

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112828: Provide ecm_add_unit_test() and ecm_add_multiple_unit_tests()

2013-09-19 Thread Alexander Neundorf

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112828/#review40365
---

If it is good enough to be used in all frameworks in tier1/, and maybe more, 
then I'm for adding that.
Whether it is "auto" or "unit" test, I don't care that much.
In KF5 a test which runs on "make test" is an "autotest".
The other tests are more example programs.

In cmake language, only these "autotests" are tests, since only they have been 
added via add_test().
The other "tests" are for cmake just some executables.

e-c-m is not part of part of KF5, otherwise it would be the one "tier0" 
package. From my POV, it is an add-on package to cmake, which happens to be 
useful to KDE. So IMO it doesn't matter much how these tests are called in KF5.

But all that is just my opinion, I leave it to Stephen to decide.

- Alexander Neundorf

On Sept. 19, 2013, 3:57 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112828/
> ---
> 
> (Updated Sept. 19, 2013, 3:57 p.m.)
> 
> 
> Review request for Extra Cmake Modules and KDE Frameworks.
> 
> 
> Description
> ---
> 
> Add a new functions to add unit tests
> 
> Every framework in KF5 has a macro similar to these, this reduces
> the unnecessary duplication inside all of the frameworks
> 
> 
> Diffs
> -
> 
>   modules/ECMAddUnitTest.cmake PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112828/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #759

2013-09-19 Thread KDE CI System

See 

Changes:

[notmart] manage args also for pasted text without urls

--
[...truncated 26 lines...]
 attica - Branch master
 libstreamanalyzer - Branch master
 kdelibs - Branch frameworks
 qt5 - Branch dev
 strigidaemon - Branch master

== Cleaning Source Tree

HEAD is now at 3656c41 manage args also for pasted text without urls
Removing build/

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.6.0
-- The CXX compiler identification is GNU 4.6.0
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- KF5[InstallDirs]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake
-- KF5[CMake]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL - Success
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- KF5[Compiler]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake
-- KF5[KIdleTime]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KIdleTime/KIdleTimeConfig.cmake
-- KF5[ItemModels]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ItemModels/ItemModelsConfig.cmake
-- KF5[KWidgetsAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWidgetsAddons/KWidgetsAddonsConfig.cmake
-- KF5[KWindowSystem]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWindowSystem/KWindowSystemConfig.cmake
-- KF5[KCodecs]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCodecs/KCodecsConfig.cmake
-- KF5[KArchive]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KArchive/KArchiveConfig.cmake
-- KF5[KCoreAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCoreAddons/KCoreAddonsConfig.cmake
-- KF5[Solid]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/Solid/SolidConfig.cmake
-- KF5[ThreadWeaver]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ThreadWeaver/ThreadWeaverConfig.cmake
-- KF5[KConfig]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KConfig/KConfigConfig.cmake
-- KF5[KAuth]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KAuth/KAuthConfig.cmake
-- KF5[KJS]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KJS/KJSConfig.cmake
-- KF5[KWallet]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWallet/KWalletConfig.cmake
-- KF5[KDBusAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KDBusAddons/KDBusAddonsConfig.cmake
-- KF5[KI18n]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KI18n/KI18nConfig.cmake
-- KF5[KGuiAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KGuiAddons/KGuiAddonsConfig.cmake
-- KF5[KConfigWidgets]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KConfigWidgets/KConfigWidgetsConfig.cmake
-- KF5[KService]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KService/KServiceConfig.cmake
-- KF5[ItemViews]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ItemViews/ItemViewsConfig.cmake
-- KF5[KNotifications]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KNotifications/KNotificationsConfig.cmake
-- KF5[KIconThemes]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KIconThemes/KIconThemesConfig.cmake
-- KF5[KCompletion]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCom

Review Request 112830: Start splitting KParts

2013-09-19 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112830/
---

Review request for KDE Frameworks.


Description
---

Started reorganizing KParts, everything stopped compiling, that fixes it too.

Make string to QStrign casts explicit.
KParts was exporting the "kio" linking, don't do it anymore.


Diffs
-

  interfaces/kmediaplayer/CMakeLists.txt 3d1797d 
  interfaces/terminal/example/CMakeLists.txt 57201fa 
  kdewebkit/CMakeLists.txt cdc5835 
  khtml/CMakeLists.txt bbaa4bb 
  khtml/html/ksslkeygen.cpp a3118da 
  khtml/html/ksslkeygen_p.h 95c1a71 
  khtml/java/CMakeLists.txt a9e5abf 
  khtml/java/tests/CMakeLists.txt 59bef3a 
  khtml/kmultipart/CMakeLists.txt aa62156 
  khtml/tests/CMakeLists.txt 99b3bdd 
  kio/CMakeLists.txt aedded2 
  kparts/CMakeLists.txt 6ab9391 
  kparts/browserrun.h e758241 
  kparts/tests/CMakeLists.txt 0e9b2b2 
  kparts/tests/normalktm.cpp dcc3a5e 
  kparts/tests/notepad.cpp b7c3778 
  kparts/tests/openorsavequestion.cpp c080cfc 
  kparts/tests/openorsavequestion_unittest.cpp 72285b1 
  kparts/tests/parts.cpp ee198e3 
  kparts/tests/parttest.h  
  kparts/tests/parttest.cpp 828666f 
  kparts/tests/partviewer.cpp eeeb63a 
  kparts/tests/plugin_spellcheck.cpp 073144b 
  kparts/tests/testmainwindow.cpp fd77af0 
  kross/modules/CMakeLists.txt fa5cc10 
  kross/ui/CMakeLists.txt 9e7806d 
  kutils/CMakeLists.txt 0cb281d 
  staging/xmlgui/tests/krichtexteditor/CMakeLists.txt 372856b 

Diff: http://git.reviewboard.kde.org/r/112830/diff/


Testing
---

Builds


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kde4_add_plugin on KF5

2013-09-19 Thread Alexander Neundorf

On Thursday 19 September 2013, Alex Merry wrote:
> On 19/09/13 17:00, Aleix Pol wrote:
> > Hi,
> > We should decide what we do with the add_plugin macro. Should I install
> > it as kf5_add_plugin from KCoreAddons? Do we want something different or
> > better?
> 
> Would e-c-m be the right place for it?

Depends on what it does.
IMO, if it is generally useful, and has no KDE dependencies, yes.
If it is only useful for KDE, it might go into kde-modules and get a KDEish 
prefix. But this is actually not wanted.

But I think Stephens plan is to get rid of those macros and use plain cmake 
instead, i.e. add_library(... MODULE ...), as with add_executable() and 
add_library().

Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

kde-workspace master becomes Qt5-based

2013-09-19 Thread Sebastian Kügler

Hi all,

We're planning to merge the frameworks-scratch branch of kde-workspace into 
master next Monday. That means if you're building your Plasma yourself from 
Git (and you're not yet ready for Plasma2 ;)), you should switch to the 
KDE/4.11 branch. The build will fail otherwise, so you will notice.

This was a public service announcement. (And you can ask questions here.)

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #758

2013-09-19 Thread KDE CI System

See 

Changes:

[notmart] new install targe

[notmart] argsrc for config that can be passed as parameter

--
[...truncated 27 lines...]
 strigidaemon - Branch master
 libstreamanalyzer - Branch master
 kdelibs - Branch frameworks
 qt5 - Branch dev

== Cleaning Source Tree

HEAD is now at 7489fa3 argsrc for config that can be passed as parameter
Removing build/
Removing install/

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.6.0
-- The CXX compiler identification is GNU 4.6.0
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- KF5[InstallDirs]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake
-- KF5[CMake]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL - Success
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- KF5[Compiler]: Loaded settings from 
/srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake
-- KF5[KIdleTime]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KIdleTime/KIdleTimeConfig.cmake
-- KF5[ItemModels]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ItemModels/ItemModelsConfig.cmake
-- KF5[KWidgetsAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWidgetsAddons/KWidgetsAddonsConfig.cmake
-- KF5[KWindowSystem]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWindowSystem/KWindowSystemConfig.cmake
-- KF5[KCodecs]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCodecs/KCodecsConfig.cmake
-- KF5[KArchive]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KArchive/KArchiveConfig.cmake
-- KF5[KCoreAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCoreAddons/KCoreAddonsConfig.cmake
-- KF5[Solid]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/Solid/SolidConfig.cmake
-- KF5[ThreadWeaver]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ThreadWeaver/ThreadWeaverConfig.cmake
-- KF5[KConfig]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KConfig/KConfigConfig.cmake
-- KF5[KAuth]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KAuth/KAuthConfig.cmake
-- KF5[KJS]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KJS/KJSConfig.cmake
-- KF5[KWallet]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWallet/KWalletConfig.cmake
-- KF5[KDBusAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KDBusAddons/KDBusAddonsConfig.cmake
-- KF5[KI18n]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KI18n/KI18nConfig.cmake
-- KF5[KGuiAddons]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KGuiAddons/KGuiAddonsConfig.cmake
-- KF5[KConfigWidgets]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KConfigWidgets/KConfigWidgetsConfig.cmake
-- KF5[KService]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KService/KServiceConfig.cmake
-- KF5[ItemViews]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ItemViews/ItemViewsConfig.cmake
-- KF5[KNotifications]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KNotifications/KNotificationsConfig.cmake
-- KF5[KIconThemes]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KIconThemes/KIconThemesConfig.cmake
-- KF5[KCompletion]: Loaded 
/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/

Re: kde4_add_plugin on KF5

2013-09-19 Thread Sebastian Kügler

On Thursday, September 19, 2013 18:26:54 Aleix Pol wrote:
> Well, I thought of something like that, but I checked and there are projects
> using the different arguments that kde4_add_plugin has. I don't see the
> point of oversimplifying there.

I didn't mean oversimplifying, but:

- to provide inspiration for what it should be / do
- to point out that I'd be happy to remove plasma_add_plugin in favor of
  another solution

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kde4_add_plugin on KF5

2013-09-19 Thread Sebastian Kügler

On Thursday, September 19, 2013 18:00:41 Aleix Pol wrote:
> Hi,
> We should decide what we do with the add_plugin macro. Should I install it
> as kf5_add_plugin from KCoreAddons? Do we want something different or
> better?

This is what we're using in Plasma (PlasmaMacros.cmake):

# plasma_add_plugin(pluginname sources_SRC)
#
# Use instead of add_library. Replacement for kde4_add_plugin
# Basically does add_library and removes the prefix of the library
#
# @arg pluginname The name of the plugin,
# @arg sources_SRC The source files to be built
#
# Example:
# plasma_add_plugin(plasma_engine_statusnotifieritem 
${statusnotifieritem_engine_SRCS})
#
macro(plasma_add_plugin plugin)
set(plugin_sources ${ARGN} )
add_library(${plugin} MODULE ${plugin_sources} )
set_target_properties(${plugin} PROPERTIES PREFIX "")
endmacro()

I would not mind having that available somewhere else.

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112829: Move XMLGUI to Tier3

2013-09-19 Thread Àlex Fiestas


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112829/
---

Review request for KDE Frameworks.


Description
---

Move xmlgui to tier3, done all the checks.


Diffs
-

  staging/CMakeLists.txt 2a31994 
  staging/xmlgui/CMakeLists.txt  
  staging/xmlgui/TODO.xmlgui  
  staging/xmlgui/XmlGuiConfig.cmake.in  
  staging/xmlgui/autotests/CMakeLists.txt  
  staging/xmlgui/autotests/kactioncategorytest.h  
  staging/xmlgui/autotests/kactioncategorytest.cpp  
  staging/xmlgui/autotests/kactioncollectiontest.h  
  staging/xmlgui/autotests/kactioncollectiontest.cpp  
  staging/xmlgui/autotests/kglobalshortcuttest.h  
  staging/xmlgui/autotests/kglobalshortcuttest.cpp  
  staging/xmlgui/autotests/kmainwindow_unittest.h  
  staging/xmlgui/autotests/kmainwindow_unittest.cpp  
  staging/xmlgui/autotests/ktoolbar_unittest.cpp  
  staging/xmlgui/autotests/kxmlgui_unittest.h  
  staging/xmlgui/autotests/kxmlgui_unittest.cpp  
  staging/xmlgui/autotests/testguiclient.h  
  staging/xmlgui/autotests/testxmlguiwindow.h  
  staging/xmlgui/make_kdepackages.sh  
  staging/xmlgui/make_kdepackages_updated.py  
  staging/xmlgui/src/CMakeLists.txt b1d7d17 
  staging/xmlgui/src/README  
  staging/xmlgui/src/TODO  
  staging/xmlgui/src/aboutkde.png  
  staging/xmlgui/src/config-xmlgui.h.cmake  
  staging/xmlgui/src/kaboutapplicationconfigattica_p.h.cmake  
  staging/xmlgui/src/kaboutapplicationdialog.h  
  staging/xmlgui/src/kaboutapplicationdialog.cpp  
  staging/xmlgui/src/kaboutapplicationpersonlistdelegate_p.h  
  staging/xmlgui/src/kaboutapplicationpersonlistdelegate_p.cpp  
  staging/xmlgui/src/kaboutapplicationpersonlistview_p.h  
  staging/xmlgui/src/kaboutapplicationpersonlistview_p.cpp  
  staging/xmlgui/src/kaboutapplicationpersonmodel_p.h  
  staging/xmlgui/src/kaboutapplicationpersonmodel_p.cpp  
  staging/xmlgui/src/kaboutkdedialog_p.h  
  staging/xmlgui/src/kaboutkdedialog_p.cpp  
  staging/xmlgui/src/kactioncategory.h  
  staging/xmlgui/src/kactioncategory.cpp  
  staging/xmlgui/src/kactioncollection.h  
  staging/xmlgui/src/kactioncollection.cpp  
  staging/xmlgui/src/kactionconflictdetector.cpp  
  staging/xmlgui/src/kbugreport.h  
  staging/xmlgui/src/kbugreport.cpp  
  staging/xmlgui/src/kcheckaccelerators.h  
  staging/xmlgui/src/kcheckaccelerators.cpp  
  staging/xmlgui/src/kdepackages.h  
  staging/xmlgui/src/kedittoolbar.h  
  staging/xmlgui/src/kedittoolbar.cpp  
  staging/xmlgui/src/kedittoolbar_p.h  
  staging/xmlgui/src/kglobalaccel.h  
  staging/xmlgui/src/kglobalaccel.cpp  
  staging/xmlgui/src/kglobalaccel_p.h  
  staging/xmlgui/src/kglobalshortcutinfo.h  
  staging/xmlgui/src/kglobalshortcutinfo.cpp  
  staging/xmlgui/src/kglobalshortcutinfo_dbus.cpp  
  staging/xmlgui/src/kglobalshortcutinfo_p.h  
  staging/xmlgui/src/khelpclient.h  
  staging/xmlgui/src/khelpclient.cpp  
  staging/xmlgui/src/khelpmenu.h  
  staging/xmlgui/src/khelpmenu.cpp  
  staging/xmlgui/src/kkeysequencewidget.h  
  staging/xmlgui/src/kkeysequencewidget.cpp  
  staging/xmlgui/src/kkeysequencewidget_p.h  
  staging/xmlgui/src/kmainwindow.h  
  staging/xmlgui/src/kmainwindow.cpp  
  staging/xmlgui/src/kmainwindow_p.h  
  staging/xmlgui/src/kmainwindowiface.cpp  
  staging/xmlgui/src/kmainwindowiface_p.h  
  staging/xmlgui/src/kmenumenuhandler_p.h  
  staging/xmlgui/src/kmenumenuhandler_p.cpp  
  staging/xmlgui/src/kpartgui.dtd  
  staging/xmlgui/src/kshortcuteditwidget.cpp  
  staging/xmlgui/src/kshortcutschemeseditor.cpp  
  staging/xmlgui/src/kshortcutschemeshelper.cpp  
  staging/xmlgui/src/kshortcutschemeshelper_p.h  
  staging/xmlgui/src/kshortcutsdialog.h  
  staging/xmlgui/src/kshortcutsdialog.cpp  
  staging/xmlgui/src/kshortcutsdialog.ui  
  staging/xmlgui/src/kshortcutsdialog_p.h  
  staging/xmlgui/src/kshortcutseditor.h  
  staging/xmlgui/src/kshortcutseditor.cpp  
  staging/xmlgui/src/kshortcutseditordelegate.cpp  
  staging/xmlgui/src/kshortcutseditoritem.cpp  
  staging/xmlgui/src/kshortcutwidget.h  
  staging/xmlgui/src/kshortcutwidget.cpp  
  staging/xmlgui/src/kshortcutwidget.ui  
  staging/xmlgui/src/kswitchlanguagedialog_p.h  
  staging/xmlgui/src/kswitchlanguagedialog_p.cpp  
  staging/xmlgui/src/ktoggletoolbaraction.h  
  staging/xmlgui/src/ktoggletoolbaraction.cpp  
  staging/xmlgui/src/ktoolbar.h  
  staging/xmlgui/src/ktoolbar.cpp  
  staging/xmlgui/src/ktoolbarhandler.cpp  
  staging/xmlgui/src/ktoolbarhandler_p.h  
  staging/xmlgui/src/kundoactions.h  
  staging/xmlgui/src/kundoactions.cpp  
  staging/xmlgui/src/kxmlgui.xsd  
  staging/xmlgui/src/kxmlguibuilder.h  
  staging/xmlgui/src/kxmlguibuilder.cpp  
  staging/xmlgui/src/kxmlguiclient.h  
  staging/xmlgui/src/kxmlguiclient.cpp  
  staging/xmlgui/src/kxmlguifactory.h  
  staging/xmlgui/src/kxmlguifactory.cpp  
  staging/xmlgui/src/kxmlguifactory_p.h  
  staging/xmlgui/src/kxmlguifactor

Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons

2013-09-19 Thread Aurélien Gâteau


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112823/#review40361
---

Ship it!


Patch does not apply there (complains about kpixmap-animation.png), but I 
assume this is a reviewboard glitch, so ship it.

- Aurélien Gâteau


On Sept. 19, 2013, 5:25 p.m., Àlex Fiestas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112823/
> ---
> 
> (Updated Sept. 19, 2013, 5:25 p.m.)
> 
> 
> Review request for KDE Frameworks and Aurélien Gâteau.
> 
> 
> Description
> ---
> 
> Removes KIconLoader dependency from KPixmapSequencer*, and adds 
> KIconLoader::loadPixmapSequence for those applications that require 
> animations shipped with XDG.
> 
> As a TODO, I'd like to find a way of adding XDG compatibility without 
> KIconLoader, maybe using QStandardPath.
> 
> 
> Diffs
> -
> 
>   KDE5PORTING.html c1dde0a 
>   knewstuff/src/ui/itemsviewbasedelegate.cpp 4c2733d 
>   knewstuff/src/ui/progressindicator.cpp 1ca9478 
>   staging/kiconthemes/autotests/CMakeLists.txt 1e5899f 
>   staging/kiconthemes/autotests/kiconloader_unittest.cpp 116203c 
>   staging/kiconthemes/src/CMakeLists.txt 0de6456 
>   staging/kiconthemes/src/kiconloader.h 65346df 
>   staging/kiconthemes/src/kiconloader.cpp 36a61a1 
>   staging/kiconthemes/src/kpixmapsequence.h ef94596 
>   staging/kiconthemes/src/kpixmapsequence.cpp c5b42e1 
>   staging/kiconthemes/src/kpixmapsequenceoverlaypainter.h 1c64e82 
>   staging/kiconthemes/src/kpixmapsequenceoverlaypainter.cpp 4632e74 
>   staging/kiconthemes/src/kpixmapsequencewidget.h c6c7e17 
>   staging/kiconthemes/src/kpixmapsequencewidget.cpp f7ab00c 
>   staging/kiconthemes/tests/CMakeLists.txt 855d45d 
>   staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.h  
>   staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.cpp e60682c 
>   tier1/kwidgetsaddons/src/CMakeLists.txt e1d039b 
>   tier1/kwidgetsaddons/tests/CMakeLists.txt e4227a2 
>   tier1/kwidgetsaddons/tests/kpixmap-animation.png PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112823/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112828: Provide ecm_add_unit_test() and ecm_add_multiple_unit_tests()

2013-09-19 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112828/#review40360
---


It should be called autotests instead of unittests. It's the nomenclature we're 
using so far in KF5.
Additionally, an executable has many unit tests inside.

- Aleix Pol Gonzalez


On Sept. 19, 2013, 3:57 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112828/
> ---
> 
> (Updated Sept. 19, 2013, 3:57 p.m.)
> 
> 
> Review request for Extra Cmake Modules and KDE Frameworks.
> 
> 
> Description
> ---
> 
> Add a new functions to add unit tests
> 
> Every framework in KF5 has a macro similar to these, this reduces
> the unnecessary duplication inside all of the frameworks
> 
> 
> Diffs
> -
> 
>   modules/ECMAddUnitTest.cmake PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112828/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

kde4_add_plugin on KF5

2013-09-19 Thread Aleix Pol

Hi,
We should decide what we do with the add_plugin macro. Should I install it
as kf5_add_plugin from KCoreAddons? Do we want something different or
better?

Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112828: Provide ecm_add_unit_test() and ecm_add_multiple_unit_tests()

2013-09-19 Thread Alexander Richardson


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112828/
---

Review request for Extra Cmake Modules and KDE Frameworks.


Description
---

Add a new functions to add unit tests

Every framework in KF5 has a macro similar to these, this reduces
the unnecessary duplication inside all of the frameworks


Diffs
-

  modules/ECMAddUnitTest.cmake PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112828/diff/


Testing
---


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Frameworks Overview

2013-09-19 Thread Sebastian Kügler

Hi,

I've created a list of the individual frameworks in KF5, including 
description. Now I'm not an expert in all of them, they might be incomplete, 
or contain errors.

It would be nice if a few people could have a look, and expand, fix where 
necessary.

http://community.kde.org/Frameworks/Overview

The list currently only contains the frameworks in kdelibs/tier{1,2,3}, so 
"newly split" frameworks will need to be added later.

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kde4_add_plugin on KF5

2013-09-19 Thread Alex Merry

On 19/09/13 17:00, Aleix Pol wrote:
> Hi,
> We should decide what we do with the add_plugin macro. Should I install
> it as kf5_add_plugin from KCoreAddons? Do we want something different or
> better?

Would e-c-m be the right place for it?

Alex

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kde4_add_plugin on KF5

2013-09-19 Thread Aleix Pol

On Thu, Sep 19, 2013 at 6:15 PM, Sebastian Kügler  wrote:

> On Thursday, September 19, 2013 18:00:41 Aleix Pol wrote:
> > Hi,
> > We should decide what we do with the add_plugin macro. Should I install
> it
> > as kf5_add_plugin from KCoreAddons? Do we want something different or
> > better?
>
> This is what we're using in Plasma (PlasmaMacros.cmake):
>
> # plasma_add_plugin(pluginname sources_SRC)
> #
> # Use instead of add_library. Replacement for kde4_add_plugin
> # Basically does add_library and removes the prefix of the library
> #
> # @arg pluginname The name of the plugin,
> # @arg sources_SRC The source files to be built
> #
> # Example:
> # plasma_add_plugin(plasma_engine_statusnotifieritem
> ${statusnotifieritem_engine_SRCS})
> #
> macro(plasma_add_plugin plugin)
> set(plugin_sources ${ARGN} )
> add_library(${plugin} MODULE ${plugin_sources} )
> set_target_properties(${plugin} PROPERTIES PREFIX "")
> endmacro()
>
>
> I would not mind having that available somewhere else.
>
> Cheers,
> --
> sebas
>
> http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>

Well, I thought of something like that, but I checked and there are
projects using the different arguments that kde4_add_plugin has.
I don't see the point of oversimplifying there.

Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons

2013-09-19 Thread Àlex Fiestas


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112823/
---

(Updated Sept. 19, 2013, 3:07 p.m.)


Review request for KDE Frameworks and Aurélien Gâteau.


Changes
---

Added kde5porting.


Description
---

Removes KIconLoader dependency from KPixmapSequencer*, and adds 
KIconLoader::loadPixmapSequence for those applications that require animations 
shipped with XDG.

As a TODO, I'd like to find a way of adding XDG compatibility without 
KIconLoader, maybe using QStandardPath.


Diffs (updated)
-

  KDE5PORTING.html c1dde0a 
  knewstuff/src/ui/itemsviewbasedelegate.cpp 4c2733d 
  knewstuff/src/ui/progressindicator.cpp 1ca9478 
  staging/kiconthemes/autotests/CMakeLists.txt 1e5899f 
  staging/kiconthemes/autotests/kiconloader_unittest.cpp 116203c 
  staging/kiconthemes/src/CMakeLists.txt 0de6456 
  staging/kiconthemes/src/kiconloader.h 65346df 
  staging/kiconthemes/src/kiconloader.cpp 36a61a1 
  staging/kiconthemes/src/kpixmapsequence.h ef94596 
  staging/kiconthemes/src/kpixmapsequence.cpp c5b42e1 
  staging/kiconthemes/src/kpixmapsequenceoverlaypainter.h 1c64e82 
  staging/kiconthemes/src/kpixmapsequenceoverlaypainter.cpp 4632e74 
  staging/kiconthemes/src/kpixmapsequencewidget.h c6c7e17 
  staging/kiconthemes/src/kpixmapsequencewidget.cpp f7ab00c 
  staging/kiconthemes/tests/CMakeLists.txt 855d45d 
  staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.h  
  staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.cpp e60682c 
  tier1/kwidgetsaddons/src/CMakeLists.txt e1d039b 
  tier1/kwidgetsaddons/tests/CMakeLists.txt e4227a2 
  tier1/kwidgetsaddons/tests/kpixmap-animation.png PRE-CREATION 
  tier1/kwidgetsaddons/tests/kpixmapsequence_config.h.in PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112823/diff/


Testing
---


Thanks,

Àlex Fiestas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons

2013-09-19 Thread Sebastian Kügler



> On Sept. 19, 2013, 2:27 p.m., Aurélien Gâteau wrote:
> > tier1/kwidgetsaddons/tests/CMakeLists.txt, line 6
> > 
> >
> > In KDE4 days programs marked as test had  a KDESRCDIR define set which 
> > pointed to CMAKE_CURRENT_SOURCE_DIR. If it still exists it would be simpler 
> > to use it than to define a config file.

QFINDTESTDATA("kpixmap-animation.png")

should do it (in your .cpp file).


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112823/#review40352
---


On Sept. 19, 2013, 2:04 p.m., Àlex Fiestas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112823/
> ---
> 
> (Updated Sept. 19, 2013, 2:04 p.m.)
> 
> 
> Review request for KDE Frameworks and Aurélien Gâteau.
> 
> 
> Description
> ---
> 
> Removes KIconLoader dependency from KPixmapSequencer*, and adds 
> KIconLoader::loadPixmapSequence for those applications that require 
> animations shipped with XDG.
> 
> As a TODO, I'd like to find a way of adding XDG compatibility without 
> KIconLoader, maybe using QStandardPath.
> 
> 
> Diffs
> -
> 
>   knewstuff/src/ui/itemsviewbasedelegate.cpp 4c2733d 
>   knewstuff/src/ui/progressindicator.cpp 1ca9478 
>   staging/kiconthemes/autotests/CMakeLists.txt 1e5899f 
>   staging/kiconthemes/autotests/kiconloader_unittest.cpp 116203c 
>   staging/kiconthemes/src/CMakeLists.txt 0de6456 
>   staging/kiconthemes/src/kiconloader.h 65346df 
>   staging/kiconthemes/src/kiconloader.cpp 36a61a1 
>   staging/kiconthemes/src/kpixmapsequence.h ef94596 
>   staging/kiconthemes/src/kpixmapsequence.cpp c5b42e1 
>   staging/kiconthemes/src/kpixmapsequenceoverlaypainter.h 1c64e82 
>   staging/kiconthemes/src/kpixmapsequenceoverlaypainter.cpp 4632e74 
>   staging/kiconthemes/src/kpixmapsequencewidget.h c6c7e17 
>   staging/kiconthemes/src/kpixmapsequencewidget.cpp f7ab00c 
>   staging/kiconthemes/tests/CMakeLists.txt 855d45d 
>   staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.h  
>   staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.cpp e60682c 
>   tier1/kwidgetsaddons/src/CMakeLists.txt e1d039b 
>   tier1/kwidgetsaddons/tests/CMakeLists.txt e4227a2 
>   tier1/kwidgetsaddons/tests/kpixmap-animation.png PRE-CREATION 
>   tier1/kwidgetsaddons/tests/kpixmapsequence_config.h.in PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112823/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons

2013-09-19 Thread Àlex Fiestas



> On Sept. 19, 2013, 2:27 p.m., Aurélien Gâteau wrote:
> > tier1/kwidgetsaddons/tests/CMakeLists.txt, line 6
> > 
> >
> > In KDE4 days programs marked as test had  a KDESRCDIR define set which 
> > pointed to CMAKE_CURRENT_SOURCE_DIR. If it still exists it would be simpler 
> > to use it than to define a config file.
> 
> Sebastian Kügler wrote:
> QFINDTESTDATA("kpixmap-animation.png")
> 
> should do it (in your .cpp file).
> 
>

Awesome! really useful!


- Àlex


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112823/#review40352
---


On Sept. 19, 2013, 3:25 p.m., Àlex Fiestas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112823/
> ---
> 
> (Updated Sept. 19, 2013, 3:25 p.m.)
> 
> 
> Review request for KDE Frameworks and Aurélien Gâteau.
> 
> 
> Description
> ---
> 
> Removes KIconLoader dependency from KPixmapSequencer*, and adds 
> KIconLoader::loadPixmapSequence for those applications that require 
> animations shipped with XDG.
> 
> As a TODO, I'd like to find a way of adding XDG compatibility without 
> KIconLoader, maybe using QStandardPath.
> 
> 
> Diffs
> -
> 
>   KDE5PORTING.html c1dde0a 
>   knewstuff/src/ui/itemsviewbasedelegate.cpp 4c2733d 
>   knewstuff/src/ui/progressindicator.cpp 1ca9478 
>   staging/kiconthemes/autotests/CMakeLists.txt 1e5899f 
>   staging/kiconthemes/autotests/kiconloader_unittest.cpp 116203c 
>   staging/kiconthemes/src/CMakeLists.txt 0de6456 
>   staging/kiconthemes/src/kiconloader.h 65346df 
>   staging/kiconthemes/src/kiconloader.cpp 36a61a1 
>   staging/kiconthemes/src/kpixmapsequence.h ef94596 
>   staging/kiconthemes/src/kpixmapsequence.cpp c5b42e1 
>   staging/kiconthemes/src/kpixmapsequenceoverlaypainter.h 1c64e82 
>   staging/kiconthemes/src/kpixmapsequenceoverlaypainter.cpp 4632e74 
>   staging/kiconthemes/src/kpixmapsequencewidget.h c6c7e17 
>   staging/kiconthemes/src/kpixmapsequencewidget.cpp f7ab00c 
>   staging/kiconthemes/tests/CMakeLists.txt 855d45d 
>   staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.h  
>   staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.cpp e60682c 
>   tier1/kwidgetsaddons/src/CMakeLists.txt e1d039b 
>   tier1/kwidgetsaddons/tests/CMakeLists.txt e4227a2 
>   tier1/kwidgetsaddons/tests/kpixmap-animation.png PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112823/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons

2013-09-19 Thread Àlex Fiestas


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112823/
---

(Updated Sept. 19, 2013, 3:25 p.m.)


Review request for KDE Frameworks and Aurélien Gâteau.


Changes
---

Fixed all opened issues.


Description
---

Removes KIconLoader dependency from KPixmapSequencer*, and adds 
KIconLoader::loadPixmapSequence for those applications that require animations 
shipped with XDG.

As a TODO, I'd like to find a way of adding XDG compatibility without 
KIconLoader, maybe using QStandardPath.


Diffs (updated)
-

  KDE5PORTING.html c1dde0a 
  knewstuff/src/ui/itemsviewbasedelegate.cpp 4c2733d 
  knewstuff/src/ui/progressindicator.cpp 1ca9478 
  staging/kiconthemes/autotests/CMakeLists.txt 1e5899f 
  staging/kiconthemes/autotests/kiconloader_unittest.cpp 116203c 
  staging/kiconthemes/src/CMakeLists.txt 0de6456 
  staging/kiconthemes/src/kiconloader.h 65346df 
  staging/kiconthemes/src/kiconloader.cpp 36a61a1 
  staging/kiconthemes/src/kpixmapsequence.h ef94596 
  staging/kiconthemes/src/kpixmapsequence.cpp c5b42e1 
  staging/kiconthemes/src/kpixmapsequenceoverlaypainter.h 1c64e82 
  staging/kiconthemes/src/kpixmapsequenceoverlaypainter.cpp 4632e74 
  staging/kiconthemes/src/kpixmapsequencewidget.h c6c7e17 
  staging/kiconthemes/src/kpixmapsequencewidget.cpp f7ab00c 
  staging/kiconthemes/tests/CMakeLists.txt 855d45d 
  staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.h  
  staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.cpp e60682c 
  tier1/kwidgetsaddons/src/CMakeLists.txt e1d039b 
  tier1/kwidgetsaddons/tests/CMakeLists.txt e4227a2 
  tier1/kwidgetsaddons/tests/kpixmap-animation.png PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112823/diff/


Testing
---


Thanks,

Àlex Fiestas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112825: Adopt modules directory structure

2013-09-19 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112825/
---

Review request for KDE Frameworks.


Description
---

Moves all code to src/.
Adds forward includers so that it can keep including dnssd/*.
Splits the CMakeLists.txt files in 2, the one in dnssd and the one in src.


Diffs
-

  dnssd/CMakeLists.txt eec325c 
  dnssd/avahi-domainbrowser.cpp  
  dnssd/avahi-domainbrowser_p.h  
  dnssd/avahi-publicservice.cpp  
  dnssd/avahi-publicservice_p.h  
  dnssd/avahi-remoteservice.cpp  
  dnssd/avahi-remoteservice_p.h  
  dnssd/avahi-servicebrowser.cpp  
  dnssd/avahi-servicebrowser_p.h  
  dnssd/avahi-servicetypebrowser.cpp  
  dnssd/avahi-servicetypebrowser_p.h  
  dnssd/avahi_entrygroup_interface.h  
  dnssd/avahi_entrygroup_interface.cpp  
  dnssd/avahi_server_interface.h  
  dnssd/avahi_server_interface.cpp  
  dnssd/avahi_serviceresolver_interface.h  
  dnssd/avahi_serviceresolver_interface.cpp  
  dnssd/domainbrowser.h  
  dnssd/domainmodel.h  
  dnssd/domainmodel.cpp  
  dnssd/dummy-domainbrowser.cpp  
  dnssd/dummy-publicservice.cpp  
  dnssd/dummy-remoteservice.cpp  
  dnssd/dummy-servicebrowser.cpp  
  dnssd/dummy-servicetypebrowser.cpp  
  dnssd/kcm_kdnssd.kcfg  
  dnssd/mdnsd-domainbrowser.cpp  
  dnssd/mdnsd-domainbrowser_p.h  
  dnssd/mdnsd-publicservice.cpp  
  dnssd/mdnsd-remoteservice.cpp  
  dnssd/mdnsd-responder.h  
  dnssd/mdnsd-responder.cpp  
  dnssd/mdnsd-sdevent.h  
  dnssd/mdnsd-servicebrowser.cpp  
  dnssd/mdnsd-servicebrowser_p.h  
  dnssd/mdnsd-servicetypebrowser.cpp  
  dnssd/mdnsd-servicetypebrowser_p.h  
  dnssd/org.freedesktop.Avahi.DomainBrowser.xml  
  dnssd/org.freedesktop.Avahi.ServiceBrowser.xml  
  dnssd/org.freedesktop.Avahi.ServiceTypeBrowser.xml  
  dnssd/publicservice.h  
  dnssd/remoteservice.h  
  dnssd/servicebase.h  
  dnssd/servicebase.cpp  
  dnssd/servicebase_p.h  
  dnssd/servicebrowser.h  
  dnssd/servicemodel.h  
  dnssd/servicemodel.cpp  
  dnssd/servicetypebrowser.h  
  dnssd/settings.kcfgc  
  dnssd/src/CMakeLists.txt PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112825/diff/


Testing
---

Builds, there are no tests.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons

2013-09-19 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112823/#review40350
---


Maybe you should add a note in KDE5Porting.html?

- Aleix Pol Gonzalez


On Sept. 19, 2013, 2:04 p.m., Àlex Fiestas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112823/
> ---
> 
> (Updated Sept. 19, 2013, 2:04 p.m.)
> 
> 
> Review request for KDE Frameworks and Aurélien Gâteau.
> 
> 
> Description
> ---
> 
> Removes KIconLoader dependency from KPixmapSequencer*, and adds 
> KIconLoader::loadPixmapSequence for those applications that require 
> animations shipped with XDG.
> 
> As a TODO, I'd like to find a way of adding XDG compatibility without 
> KIconLoader, maybe using QStandardPath.
> 
> 
> Diffs
> -
> 
>   knewstuff/src/ui/itemsviewbasedelegate.cpp 4c2733d 
>   knewstuff/src/ui/progressindicator.cpp 1ca9478 
>   staging/kiconthemes/autotests/CMakeLists.txt 1e5899f 
>   staging/kiconthemes/autotests/kiconloader_unittest.cpp 116203c 
>   staging/kiconthemes/src/CMakeLists.txt 0de6456 
>   staging/kiconthemes/src/kiconloader.h 65346df 
>   staging/kiconthemes/src/kiconloader.cpp 36a61a1 
>   staging/kiconthemes/src/kpixmapsequence.h ef94596 
>   staging/kiconthemes/src/kpixmapsequence.cpp c5b42e1 
>   staging/kiconthemes/src/kpixmapsequenceoverlaypainter.h 1c64e82 
>   staging/kiconthemes/src/kpixmapsequenceoverlaypainter.cpp 4632e74 
>   staging/kiconthemes/src/kpixmapsequencewidget.h c6c7e17 
>   staging/kiconthemes/src/kpixmapsequencewidget.cpp f7ab00c 
>   staging/kiconthemes/tests/CMakeLists.txt 855d45d 
>   staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.h  
>   staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.cpp e60682c 
>   tier1/kwidgetsaddons/src/CMakeLists.txt e1d039b 
>   tier1/kwidgetsaddons/tests/CMakeLists.txt e4227a2 
>   tier1/kwidgetsaddons/tests/kpixmap-animation.png PRE-CREATION 
>   tier1/kwidgetsaddons/tests/kpixmapsequence_config.h.in PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112823/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons

2013-09-19 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112823/#review40351
---


Maybe you should add a note in KDE5Porting.html?

- Aleix Pol Gonzalez


On Sept. 19, 2013, 2:04 p.m., Àlex Fiestas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112823/
> ---
> 
> (Updated Sept. 19, 2013, 2:04 p.m.)
> 
> 
> Review request for KDE Frameworks and Aurélien Gâteau.
> 
> 
> Description
> ---
> 
> Removes KIconLoader dependency from KPixmapSequencer*, and adds 
> KIconLoader::loadPixmapSequence for those applications that require 
> animations shipped with XDG.
> 
> As a TODO, I'd like to find a way of adding XDG compatibility without 
> KIconLoader, maybe using QStandardPath.
> 
> 
> Diffs
> -
> 
>   knewstuff/src/ui/itemsviewbasedelegate.cpp 4c2733d 
>   knewstuff/src/ui/progressindicator.cpp 1ca9478 
>   staging/kiconthemes/autotests/CMakeLists.txt 1e5899f 
>   staging/kiconthemes/autotests/kiconloader_unittest.cpp 116203c 
>   staging/kiconthemes/src/CMakeLists.txt 0de6456 
>   staging/kiconthemes/src/kiconloader.h 65346df 
>   staging/kiconthemes/src/kiconloader.cpp 36a61a1 
>   staging/kiconthemes/src/kpixmapsequence.h ef94596 
>   staging/kiconthemes/src/kpixmapsequence.cpp c5b42e1 
>   staging/kiconthemes/src/kpixmapsequenceoverlaypainter.h 1c64e82 
>   staging/kiconthemes/src/kpixmapsequenceoverlaypainter.cpp 4632e74 
>   staging/kiconthemes/src/kpixmapsequencewidget.h c6c7e17 
>   staging/kiconthemes/src/kpixmapsequencewidget.cpp f7ab00c 
>   staging/kiconthemes/tests/CMakeLists.txt 855d45d 
>   staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.h  
>   staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.cpp e60682c 
>   tier1/kwidgetsaddons/src/CMakeLists.txt e1d039b 
>   tier1/kwidgetsaddons/tests/CMakeLists.txt e4227a2 
>   tier1/kwidgetsaddons/tests/kpixmap-animation.png PRE-CREATION 
>   tier1/kwidgetsaddons/tests/kpixmapsequence_config.h.in PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112823/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons

2013-09-19 Thread Aurélien Gâteau


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112823/#review40352
---


Looks good overall, but I found a few minor issues.


staging/kiconthemes/src/kiconloader.h


Missing "@since 5.0"



staging/kiconthemes/src/kiconloader.h


should be const



staging/kiconthemes/src/kpixmapsequence.h


No need for "explicit" now that the constructor takes two mandatory 
arguments.



tier1/kwidgetsaddons/tests/CMakeLists.txt


In KDE4 days programs marked as test had  a KDESRCDIR define set which 
pointed to CMAKE_CURRENT_SOURCE_DIR. If it still exists it would be simpler to 
use it than to define a config file.


- Aurélien Gâteau


On Sept. 19, 2013, 4:04 p.m., Àlex Fiestas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112823/
> ---
> 
> (Updated Sept. 19, 2013, 4:04 p.m.)
> 
> 
> Review request for KDE Frameworks and Aurélien Gâteau.
> 
> 
> Description
> ---
> 
> Removes KIconLoader dependency from KPixmapSequencer*, and adds 
> KIconLoader::loadPixmapSequence for those applications that require 
> animations shipped with XDG.
> 
> As a TODO, I'd like to find a way of adding XDG compatibility without 
> KIconLoader, maybe using QStandardPath.
> 
> 
> Diffs
> -
> 
>   knewstuff/src/ui/itemsviewbasedelegate.cpp 4c2733d 
>   knewstuff/src/ui/progressindicator.cpp 1ca9478 
>   staging/kiconthemes/autotests/CMakeLists.txt 1e5899f 
>   staging/kiconthemes/autotests/kiconloader_unittest.cpp 116203c 
>   staging/kiconthemes/src/CMakeLists.txt 0de6456 
>   staging/kiconthemes/src/kiconloader.h 65346df 
>   staging/kiconthemes/src/kiconloader.cpp 36a61a1 
>   staging/kiconthemes/src/kpixmapsequence.h ef94596 
>   staging/kiconthemes/src/kpixmapsequence.cpp c5b42e1 
>   staging/kiconthemes/src/kpixmapsequenceoverlaypainter.h 1c64e82 
>   staging/kiconthemes/src/kpixmapsequenceoverlaypainter.cpp 4632e74 
>   staging/kiconthemes/src/kpixmapsequencewidget.h c6c7e17 
>   staging/kiconthemes/src/kpixmapsequencewidget.cpp f7ab00c 
>   staging/kiconthemes/tests/CMakeLists.txt 855d45d 
>   staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.h  
>   staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.cpp e60682c 
>   tier1/kwidgetsaddons/src/CMakeLists.txt e1d039b 
>   tier1/kwidgetsaddons/tests/CMakeLists.txt e4227a2 
>   tier1/kwidgetsaddons/tests/kpixmap-animation.png PRE-CREATION 
>   tier1/kwidgetsaddons/tests/kpixmapsequence_config.h.in PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112823/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112823: Move KPixmapSequencer to KWidgetsAddons

2013-09-19 Thread Àlex Fiestas


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112823/
---

Review request for KDE Frameworks and Aurélien Gâteau.


Description
---

Removes KIconLoader dependency from KPixmapSequencer*, and adds 
KIconLoader::loadPixmapSequence for those applications that require animations 
shipped with XDG.

As a TODO, I'd like to find a way of adding XDG compatibility without 
KIconLoader, maybe using QStandardPath.


Diffs
-

  knewstuff/src/ui/itemsviewbasedelegate.cpp 4c2733d 
  knewstuff/src/ui/progressindicator.cpp 1ca9478 
  staging/kiconthemes/autotests/CMakeLists.txt 1e5899f 
  staging/kiconthemes/autotests/kiconloader_unittest.cpp 116203c 
  staging/kiconthemes/src/CMakeLists.txt 0de6456 
  staging/kiconthemes/src/kiconloader.h 65346df 
  staging/kiconthemes/src/kiconloader.cpp 36a61a1 
  staging/kiconthemes/src/kpixmapsequence.h ef94596 
  staging/kiconthemes/src/kpixmapsequence.cpp c5b42e1 
  staging/kiconthemes/src/kpixmapsequenceoverlaypainter.h 1c64e82 
  staging/kiconthemes/src/kpixmapsequenceoverlaypainter.cpp 4632e74 
  staging/kiconthemes/src/kpixmapsequencewidget.h c6c7e17 
  staging/kiconthemes/src/kpixmapsequencewidget.cpp f7ab00c 
  staging/kiconthemes/tests/CMakeLists.txt 855d45d 
  staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.h  
  staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.cpp e60682c 
  tier1/kwidgetsaddons/src/CMakeLists.txt e1d039b 
  tier1/kwidgetsaddons/tests/CMakeLists.txt e4227a2 
  tier1/kwidgetsaddons/tests/kpixmap-animation.png PRE-CREATION 
  tier1/kwidgetsaddons/tests/kpixmapsequence_config.h.in PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112823/diff/


Testing
---


Thanks,

Àlex Fiestas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Qt Dev Days Stuff

2013-09-19 Thread John Layt

Hi,

Qt Dev Days is short on Lightning Talks, so if you have a Qt-related
topic you want to present or demo for up to 10 minutes, please submit
it at http://www.qtdeveloperdays.com/lightning-talks by tomorrow.

I'd especially like to see a KF5 lightning talk focussed on the
libraries we will be releasing and why people would want to use them.
Another talk perhaps could be about KDE's contributions to Qt in both
code and community, i.e. what new features we've added to Qt5, the
benefits of Free Qt, etc.  I could do them myself, but I already have
one lightning talk planned and it might be better coming from someone
more actively involved, so volunteers welcome.

I want to make a marketing push for KF5 at QtDD around these two
themes as well, with handouts and talking points for our booth staff,
so I'll be ransacking the wiki and picking peoples brains about that
over the next few days.

And yes, we still have a couple of tickets available if you want to
come and join in the fun.

Cheers!

John.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112803: Start cleaning up KDNSSD

2013-09-19 Thread Commit Hook


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112803/#review40347
---


This review has been submitted with commit 
1bf4d77ccd727a04a88e6e875227e05e1d1f87f1 by Aleix Pol to branch frameworks.

- Commit Hook


On Sept. 19, 2013, 11:24 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112803/
> ---
> 
> (Updated Sept. 19, 2013, 11:24 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Renames target to KDNSSD.
> Properly look-up Qt and KF5.
> 
> After that I'll move it to staging.
> 
> 
> Diffs
> -
> 
>   dnssd/CMakeLists.txt 7f2620a 
> 
> Diff: http://git.reviewboard.kde.org/r/112803/diff/
> 
> 
> Testing
> ---
> 
> Builds, there are no tests.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112803: Start cleaning up KDNSSD

2013-09-19 Thread Commit Hook


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112803/
---

(Updated Sept. 19, 2013, 1:33 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Description
---

Renames target to KDNSSD.
Properly look-up Qt and KF5.

After that I'll move it to staging.


Diffs
-

  dnssd/CMakeLists.txt 7f2620a 

Diff: http://git.reviewboard.kde.org/r/112803/diff/


Testing
---

Builds, there are no tests.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112814: kjs - remove unused dependencies

2013-09-19 Thread Michael Palimaka


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112814/
---

Review request for KDE Frameworks.


Description
---

QtWidgets is not required, and move QtTest to autotests.


Diffs
-

  tier1/kjs/CMakeLists.txt f67846499fcd08cbf69cab4c29fc625af607bd37 
  tier1/kjs/autotests/CMakeLists.txt 2c8089fb432d1dafc0dcbaa9ff917d0696c00bf3 

Diff: http://git.reviewboard.kde.org/r/112814/diff/


Testing
---

With QtWidgets not installed, build and tests pass.


Thanks,

Michael Palimaka

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

2013-09-19 Thread Mark Gaiser


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112797/#review40341
---

Ship it!


Now that i think of it again, why shouldn't i give a ship it? You only bring 
back code that was there a day ago :)

- Mark Gaiser


On Sept. 18, 2013, 4:55 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112797/
> ---
> 
> (Updated Sept. 18, 2013, 4:55 p.m.)
> 
> 
> Review request for KDE Frameworks, Frank Reininghaus and Mark Gaiser.
> 
> 
> Description
> ---
> 
> Apparently there's people who still want to have it. Leave it in KCoreAddons 
> for the moment, until we decide that it can be replaced for good by QCollator.
> 
> 
> Diffs
> -
> 
>   tier1/kcoreaddons/autotests/kstringhandlertest.cpp 93da351 
>   tier1/kcoreaddons/src/lib/text/kstringhandler.h 442b97a 
>   tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5 
> 
> Diff: http://git.reviewboard.kde.org/r/112797/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112803: Start cleaning up KDNSSD

2013-09-19 Thread David Faure


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112803/#review40340
---

Ship it!


Looks good to me.


dnssd/CMakeLists.txt


still there?


- David Faure


On Sept. 19, 2013, 11:24 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112803/
> ---
> 
> (Updated Sept. 19, 2013, 11:24 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Renames target to KDNSSD.
> Properly look-up Qt and KF5.
> 
> After that I'll move it to staging.
> 
> 
> Diffs
> -
> 
>   dnssd/CMakeLists.txt 7f2620a 
> 
> Diff: http://git.reviewboard.kde.org/r/112803/diff/
> 
> 
> Testing
> ---
> 
> Builds, there are no tests.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112811: Make kguiaddons build standalone

2013-09-19 Thread Aurélien Gâteau


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112811/
---

Review request for KDE Frameworks and Martin Klapetek.


Description
---

Add missing include() calls and mark it as tier1 in superbuild.


Diffs
-

  superbuild/CMakeLists.txt c297be6 
  tier1/kguiaddons/CMakeLists.txt 46877bd 

Diff: http://git.reviewboard.kde.org/r/112811/diff/


Testing
---

Builds within kdelibs and using superbuild.


Thanks,

Aurélien Gâteau

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112803: Start cleaning up KDNSSD

2013-09-19 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112803/
---

(Updated Sept. 19, 2013, 11:24 a.m.)


Review request for KDE Frameworks.


Changes
---

Adopt David's suggestions.


Description
---

Renames target to KDNSSD.
Properly look-up Qt and KF5.

After that I'll move it to staging.


Diffs (updated)
-

  dnssd/CMakeLists.txt 7f2620a 

Diff: http://git.reviewboard.kde.org/r/112803/diff/


Testing
---

Builds, there are no tests.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112758: Move KCompletion to tier2

2013-09-19 Thread Commit Hook


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112758/
---

(Updated Sept. 19, 2013, 11:13 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Description
---

Not much else.


Diffs
-

  staging/CMakeLists.txt 7826b07 
  staging/kcompletion/CMakeLists.txt  
  staging/kcompletion/KCompletionConfig.cmake.in  
  staging/kcompletion/autotests/CMakeLists.txt  
  staging/kcompletion/autotests/kcombobox_unittest.cpp  
  staging/kcompletion/autotests/kcompletioncoretest.h  
  staging/kcompletion/autotests/kcompletioncoretest.cpp  
  staging/kcompletion/autotests/klineedit_unittest.cpp  
  staging/kcompletion/autotests/ksortablelisttest.cpp  
  staging/kcompletion/src/CMakeLists.txt  
  staging/kcompletion/src/kcombobox.h  
  staging/kcompletion/src/kcombobox.cpp  
  staging/kcompletion/src/kcompletion.h  
  staging/kcompletion/src/kcompletion.cpp  
  staging/kcompletion/src/kcompletion_p.h  
  staging/kcompletion/src/kcompletionbase.cpp  
  staging/kcompletion/src/kcompletionbox.h  
  staging/kcompletion/src/kcompletionbox.cpp  
  staging/kcompletion/src/khistorycombobox.h  
  staging/kcompletion/src/khistorycombobox.cpp  
  staging/kcompletion/src/klineedit.h  
  staging/kcompletion/src/klineedit.cpp  
  staging/kcompletion/src/klineedit_p.h  
  staging/kcompletion/src/kpixmapprovider.h  
  staging/kcompletion/src/kpixmapprovider.cpp  
  staging/kcompletion/src/ksortablelist.h  
  staging/kcompletion/src/kzoneallocator.cpp  
  staging/kcompletion/src/kzoneallocator_p.h  
  staging/kcompletion/tests/CMakeLists.txt  
  staging/kcompletion/tests/kcomboboxtest.h  
  staging/kcompletion/tests/kcomboboxtest.cpp  
  staging/kcompletion/tests/kcompletionuitest.h  
  staging/kcompletion/tests/kcompletionuitest.cpp  
  staging/kcompletion/tests/klineedittest.h  
  staging/kcompletion/tests/klineedittest.cpp  
  tier2/CMakeLists.txt 51f093b 

Diff: http://git.reviewboard.kde.org/r/112758/diff/


Testing
---

Builds, tests pass.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112758: Move KCompletion to tier2

2013-09-19 Thread Commit Hook


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112758/#review40338
---


This review has been submitted with commit 
a8e0e51de8c5dd3beadc0254758a0d05dc1b5cee by Aleix Pol to branch frameworks.

- Commit Hook


On Sept. 16, 2013, 3:08 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112758/
> ---
> 
> (Updated Sept. 16, 2013, 3:08 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Not much else.
> 
> 
> Diffs
> -
> 
>   staging/CMakeLists.txt 7826b07 
>   staging/kcompletion/CMakeLists.txt  
>   staging/kcompletion/KCompletionConfig.cmake.in  
>   staging/kcompletion/autotests/CMakeLists.txt  
>   staging/kcompletion/autotests/kcombobox_unittest.cpp  
>   staging/kcompletion/autotests/kcompletioncoretest.h  
>   staging/kcompletion/autotests/kcompletioncoretest.cpp  
>   staging/kcompletion/autotests/klineedit_unittest.cpp  
>   staging/kcompletion/autotests/ksortablelisttest.cpp  
>   staging/kcompletion/src/CMakeLists.txt  
>   staging/kcompletion/src/kcombobox.h  
>   staging/kcompletion/src/kcombobox.cpp  
>   staging/kcompletion/src/kcompletion.h  
>   staging/kcompletion/src/kcompletion.cpp  
>   staging/kcompletion/src/kcompletion_p.h  
>   staging/kcompletion/src/kcompletionbase.cpp  
>   staging/kcompletion/src/kcompletionbox.h  
>   staging/kcompletion/src/kcompletionbox.cpp  
>   staging/kcompletion/src/khistorycombobox.h  
>   staging/kcompletion/src/khistorycombobox.cpp  
>   staging/kcompletion/src/klineedit.h  
>   staging/kcompletion/src/klineedit.cpp  
>   staging/kcompletion/src/klineedit_p.h  
>   staging/kcompletion/src/kpixmapprovider.h  
>   staging/kcompletion/src/kpixmapprovider.cpp  
>   staging/kcompletion/src/ksortablelist.h  
>   staging/kcompletion/src/kzoneallocator.cpp  
>   staging/kcompletion/src/kzoneallocator_p.h  
>   staging/kcompletion/tests/CMakeLists.txt  
>   staging/kcompletion/tests/kcomboboxtest.h  
>   staging/kcompletion/tests/kcomboboxtest.cpp  
>   staging/kcompletion/tests/kcompletionuitest.h  
>   staging/kcompletion/tests/kcompletionuitest.cpp  
>   staging/kcompletion/tests/klineedittest.h  
>   staging/kcompletion/tests/klineedittest.cpp  
>   tier2/CMakeLists.txt 51f093b 
> 
> Diff: http://git.reviewboard.kde.org/r/112758/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112772: Create an ecm_mark_as_autotest macro

2013-09-19 Thread Aleix Pol Gonzalez



> On Sept. 17, 2013, 6:26 p.m., Alexander Neundorf wrote:
> > The macro does more than the name implies, additionally to marking it as 
> > test it also actually adds the test.
> > So I'd prefer a different name.
> > 
> > Having said that, the CMakeLists.txt in the various tests/ subdirs in KDE 
> > frameworks look all quite similar, they more or less all feature a quite 
> > similar macro, foo_unit_tests(). Maybe a more advanced function can be 
> > written which can be used in all those places ?
> 
> Alexander Richardson wrote:
> I just played around with adding a new macro to replace the 
> _UNIT_TESTS macros which are in every autotests directory: 
> http://paste.kde.org/p11adaa09/
> 
> Could something like this be considered for ecm? If so I will add some 
> documentation and create a review request for ecm.
> 
> Aleix Pol Gonzalez wrote:
> Neundorf: well, the difference between mark_as_test and mark_as_autotest 
> is that it marks it as a test. Actually I think that mark_as_test is in fact 
> a bit misleading, because it's not marking it as a test, only making it build 
> as a test.
> 
> About foo_unit_tests, I don't hate the idea, but then I don't think it 
> pays off that much, if we go with that, we can just keep kde4_add_unit_test 
> just as well.
> 
> Alexander Neundorf wrote:
> Alex: IMO yes.
> Aleix: if the function from Alex R. is generic enough to be usable by non 
> KDE-projects, I think it would be useful to have in ecm. Still, having two 
> macros ecm_mark_as_test() and ecm_mark_as_autotest() would IMO not be good, 
> since they sound quite similar but do different things. I'd prefer a more 
> powerful function which does more than just wrap two calls.
> 
> But that's just my opinion, I leave it up to Stephen.

Meanwhile, Richardson can you open a proper review request with the other 
macro? Should I do it?


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112772/#review40240
---


On Sept. 17, 2013, 12:35 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112772/
> ---
> 
> (Updated Sept. 17, 2013, 12:35 p.m.)
> 
> 
> Review request for Build System and KDE Frameworks.
> 
> 
> Description
> ---
> 
> Creates a function that will define a unit test with the project name (like 
> it's being done in KF5) and calls ecm_mark_as_test.
> 
> This should help simplify the tests creation that at the moment is quite 
> verbose.
> 
> 
> Diffs
> -
> 
>   modules/ECMMarkAsTest.cmake f1e53e4 
> 
> Diff: http://git.reviewboard.kde.org/r/112772/diff/
> 
> 
> Testing
> ---
> 
> Ported some tests in KF5, it worked.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #1225

2013-09-19 Thread KDE CI System

See 

Changes:

[aleixpol] Move KDocTools to tier2

--
[...truncated 4275 lines...]
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/hal/halfstabhandling.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/hal/halsmartcardreader.cpp.o
Scanning dependencies of target dummy
[ 42%] [ 42%] Scanning dependencies of target desktoptojson
Building CXX object 
staging/kde4support/src/kio/dummyanalyzers/CMakeFiles/dummy.dir/dummyanalyzers.cpp.o
[ 42%] Building CXX object 
staging/kservice/src/CMakeFiles/KService.dir/sycoca/ksycocafactory.cpp.o
[ 42%] [ 42%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/hal/halgenericinterface.cpp.o
[ 42%] Building CXX object 
staging/kservice/src/desktoptojson/CMakeFiles/desktoptojson.dir/main.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/upower/upowermanager.cpp.o
Built target xslt_kde
[ 42%] [ 42%] Building CXX object 
staging/kde4support/src/kio/dummyanalyzers/CMakeFiles/dummy.dir/dummy_automoc.cpp.o
Scanning dependencies of target kpty
Building CXX object 
staging/kservice/src/CMakeFiles/KService.dir/sycoca/kmemfile.cpp.o
[ 42%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/hal/haldevice.cpp.o
[ 42%] Building CXX object kpty/CMakeFiles/kpty.dir/kpty.cpp.o
[ 42%] [ 42%] Building CXX object 
staging/kservice/src/CMakeFiles/KService.dir/plugin/klibrary.cpp.o
Building CXX object 
staging/kservice/src/desktoptojson/CMakeFiles/desktoptojson.dir/kconfigtojson.cpp.o
[ 42%] [ 42%] Building CXX object kpty/CMakeFiles/kpty.dir/kptydevice.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/upower/upowerdevice.cpp.o
[ 42%] Building CXX object 
staging/kservice/src/desktoptojson/CMakeFiles/desktoptojson.dir/desktoptojson_automoc.cpp.o
[ 42%] Building CXX object 
staging/kservice/src/CMakeFiles/KService.dir/plugin/kpluginfactory.cpp.o
[ 42%] Building CXX object kpty/CMakeFiles/kpty.dir/kptyprocess.cpp.o
Linking CXX shared module strigiea_dummy.so
[ 42%] [ 42%] Building CXX object kpty/CMakeFiles/kpty.dir/kpty_automoc.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/upower/upowerbattery.cpp.o
Linking CXX shared library ../lib/libkpty.so
Linking CXX executable desktoptojson
[ 42%] [ 42%] Building CXX object 
staging/kservice/src/CMakeFiles/KService.dir/plugin/kpluginloader.cpp.o
Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/hal/halmanager.cpp.o
[ 42%] Built target KWallet
:
 In member function ‘KPluginFactory* KPluginLoader::factory()’:
:223:48:
 warning: ‘KPluginFactory* KLibrary::factory(const char*)’ is deprecated 
(declared at 
:58)
 [-Wdeprecated-declarations]
[ 43%] [ 43%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid.dir/backends/upower/upoweracadapter.cpp.o
Scanning dependencies of target kdesu_stub
Generating avahi_servicetypebrowser_interface.cpp, 
avahi_servicetypebrowser_interface.h
:
 In destructor ‘virtual KPluginFactory::~KPluginFactory()’:
:55:35:
 warning: unused variable ‘d’ [-Wunused-variable]
:
 In member function ‘virtual QObject* KPluginFactory::create(const char*, 
QWidget*, QObject*, const QVariantList&, const QString&)’:
:143:114:
 warning: ‘virtual KParts::Part* KPluginFactory::createPartObject(QWidget*, 
QObject*, const char*, const QStringList&)’ is deprecated (declared at 
:117)
 [-Wdeprecated-declarations]
:148:62:
 warning: ‘virtual QObject* KPluginFactory::createObject(QObject*, const char*, 
const QStringList&)’ is deprecated (declared at 
:107)
 [-Wdeprecated-declarations]
[ 43%] [ 43%] [ 43%] [ 43%] Building CXX object 
tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/hal/halnetworkinterface.cpp.o
Generating settings.h, settings.cpp
Building CXX object 
staging/kservice/src/CMakeFiles/KService.dir/plugin/kplugintrader.cpp.o
[ 43%]

Re: Review Request 112795: Move KDocTools to tier2

2013-09-19 Thread Commit Hook


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112795/#review40336
---


This review has been submitted with commit 
6ce4ed498e70c91ca68f0d0c91400efbfb51ad18 by Aleix Pol to branch frameworks.

- Commit Hook


On Sept. 18, 2013, 3:34 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112795/
> ---
> 
> (Updated Sept. 18, 2013, 3:34 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Does the move, changes a couple of things so the macros are still found.
> 
> 
> Diffs
> -
> 
>   cmake/modules/KDE4Macros.cmake 403679f 
>   staging/CMakeLists.txt 7826b07 
>   tier2/CMakeLists.txt 6c98a7d 
>   tier2/kdoctools/CMakeLists.txt 7e09279 
> 
> Diff: http://git.reviewboard.kde.org/r/112795/diff/
> 
> 
> Testing
> ---
> 
> Builds, no tests.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112795: Move KDocTools to tier2

2013-09-19 Thread Commit Hook


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112795/
---

(Updated Sept. 19, 2013, 10:48 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Description
---

Does the move, changes a couple of things so the macros are still found.


Diffs
-

  cmake/modules/KDE4Macros.cmake 403679f 
  staging/CMakeLists.txt 7826b07 
  tier2/CMakeLists.txt 6c98a7d 
  tier2/kdoctools/CMakeLists.txt 7e09279 

Diff: http://git.reviewboard.kde.org/r/112795/diff/


Testing
---

Builds, no tests.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112795: Move KDocTools to tier2

2013-09-19 Thread Aleix Pol Gonzalez



> On Sept. 19, 2013, 7:40 a.m., David Faure wrote:
> > tier2/kdoctools/CMakeLists.txt, line 44
> > 
> >
> > I'm curious, what does that do?

It's where the *Config.cmake file will go. Each module define its own 
CMAKECONFIG_INSTALL_DIR.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112795/#review40321
---


On Sept. 18, 2013, 3:34 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112795/
> ---
> 
> (Updated Sept. 18, 2013, 3:34 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Does the move, changes a couple of things so the macros are still found.
> 
> 
> Diffs
> -
> 
>   cmake/modules/KDE4Macros.cmake 403679f 
>   staging/CMakeLists.txt 7826b07 
>   tier2/CMakeLists.txt 6c98a7d 
>   tier2/kdoctools/CMakeLists.txt 7e09279 
> 
> Diff: http://git.reviewboard.kde.org/r/112795/diff/
> 
> 
> Testing
> ---
> 
> Builds, no tests.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112808: Port away from KDirWatch in KEmoticons (prior to splitting)

2013-09-19 Thread Aleix Pol Gonzalez



> On Sept. 19, 2013, 7:48 a.m., David Faure wrote:
> > staging/kemoticons/src/core/kemoticons.cpp, line 110
> > 
> >
> > This test is already done internally in QFSW, remove it from here.

But then, it keeps outputting that it's already in, doesn't it? At least on Qt4 
it does.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112808/#review40325
---


On Sept. 18, 2013, 10:26 p.m., David Gil Oliva wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112808/
> ---
> 
> (Updated Sept. 18, 2013, 10:26 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Port away from KDirWatch in KEmoticons (prior to splitting)
> 
> 
> Diffs
> -
> 
>   staging/kemoticons/src/core/CMakeLists.txt 
> 0e79eaae60dfd5cd5e0c5f6848b86dbb90c0c818 
>   staging/kemoticons/src/core/kemoticons.cpp 
> 5f6a23ec606b3c6dceac2e01a280413e6899a59b 
> 
> Diff: http://git.reviewboard.kde.org/r/112808/diff/
> 
> 
> Testing
> ---
> 
> It builds and installs correctly.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112681: Tests for KPluginTrader and friends

2013-09-19 Thread Commit Hook


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112681/#review40331
---


This review has been submitted with commit 
afcaf264cb5417fea36e8688f5c5579e0226fb12 by Sebastian Kügler to branch 
frameworks.

- Commit Hook


On Sept. 18, 2013, 12:12 p.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112681/
> ---
> 
> (Updated Sept. 18, 2013, 12:12 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Description
> ---
> 
> Tests for KPluginTrader.
> 
> Under autotests/, there's a new test class which runs a variety of queries 
> using KPluginTrader. There's also a small plugin, which is used to verify 
> correct metadata querying and loading. It's not installed since QPluginLoader 
> conveniently contains the working directory when looking for plugins -> it's 
> found just fine.
> 
> Under tests/, there's a test which will query for a variety of other plugins. 
> This one is more geared towards performance testing. When run from make test, 
> it will pass anyway.
> 
> Code can also be found in kdelibs[sebas/pluginlocator].
> 
> 
> Diffs
> -
> 
>   staging/kservice/autotests/CMakeLists.txt d341040 
>   staging/kservice/autotests/fakeplugin.desktop PRE-CREATION 
>   staging/kservice/autotests/fakeplugin.json PRE-CREATION 
>   staging/kservice/autotests/nsaplugin.h PRE-CREATION 
>   staging/kservice/autotests/nsaplugin.cpp PRE-CREATION 
>   staging/kservice/autotests/pluginlocatortest.h PRE-CREATION 
>   staging/kservice/autotests/pluginlocatortest.cpp PRE-CREATION 
>   staging/kservice/tests/CMakeLists.txt 3793aea 
>   staging/kservice/tests/pluginlocator/CMakeLists.txt PRE-CREATION 
>   staging/kservice/tests/pluginlocator/main.cpp PRE-CREATION 
>   staging/kservice/tests/pluginlocator/plugintest.h PRE-CREATION 
>   staging/kservice/tests/pluginlocator/plugintest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112681/diff/
> 
> 
> Testing
> ---
> 
> make test =)
> 
> All tests pass on top of my patches.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112681: Tests for KPluginTrader and friends

2013-09-19 Thread Commit Hook


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112681/
---

(Updated Sept. 19, 2013, 10:19 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Description
---

Tests for KPluginTrader.

Under autotests/, there's a new test class which runs a variety of queries 
using KPluginTrader. There's also a small plugin, which is used to verify 
correct metadata querying and loading. It's not installed since QPluginLoader 
conveniently contains the working directory when looking for plugins -> it's 
found just fine.

Under tests/, there's a test which will query for a variety of other plugins. 
This one is more geared towards performance testing. When run from make test, 
it will pass anyway.

Code can also be found in kdelibs[sebas/pluginlocator].


Diffs
-

  staging/kservice/autotests/CMakeLists.txt d341040 
  staging/kservice/autotests/fakeplugin.desktop PRE-CREATION 
  staging/kservice/autotests/fakeplugin.json PRE-CREATION 
  staging/kservice/autotests/nsaplugin.h PRE-CREATION 
  staging/kservice/autotests/nsaplugin.cpp PRE-CREATION 
  staging/kservice/autotests/pluginlocatortest.h PRE-CREATION 
  staging/kservice/autotests/pluginlocatortest.cpp PRE-CREATION 
  staging/kservice/tests/CMakeLists.txt 3793aea 
  staging/kservice/tests/pluginlocator/CMakeLists.txt PRE-CREATION 
  staging/kservice/tests/pluginlocator/main.cpp PRE-CREATION 
  staging/kservice/tests/pluginlocator/plugintest.h PRE-CREATION 
  staging/kservice/tests/pluginlocator/plugintest.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112681/diff/


Testing
---

make test =)

All tests pass on top of my patches.


Thanks,

Sebastian Kügler

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112796: Move kcolorutilsdemo from kconfigwidgets/tests to kguiaddons/tests

2013-09-19 Thread Aurélien Gâteau


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112796/
---

(Updated Sept. 19, 2013, 11:30 a.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks.


Description
---

This is required for kconfigwidgets to build standalone because 
kcolorutilsdemo.cpp includes kcolorspaces.h, which is part of kguiaddons but 
not installed.


Diffs
-

  staging/kconfigwidgets/tests/CMakeLists.txt bc52bc1 
  staging/kconfigwidgets/tests/kcolorutilsdemo.h 09e867a 
  staging/kconfigwidgets/tests/kcolorutilsdemo.cpp 940569e 
  staging/kconfigwidgets/tests/kcolorutilsdemo.ui c6604fd 
  staging/kconfigwidgets/tests/kimageframe.h d521cb5 
  staging/kconfigwidgets/tests/kimageframe.cpp 60a5e9d 
  tier1/kguiaddons/tests/CMakeLists.txt 4d91ed8 
  tier1/kguiaddons/tests/kcolorutilsdemo.h PRE-CREATION 
  tier1/kguiaddons/tests/kcolorutilsdemo.cpp PRE-CREATION 
  tier1/kguiaddons/tests/kcolorutilsdemo.ui PRE-CREATION 
  tier1/kguiaddons/tests/kimageframe.h PRE-CREATION 
  tier1/kguiaddons/tests/kimageframe.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112796/diff/


Testing
---

Still builds, kcolorutilsdemo runs correctly.


Thanks,

Aurélien Gâteau

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112796: Move kcolorutilsdemo from kconfigwidgets/tests to kguiaddons/tests

2013-09-19 Thread Aurélien Gâteau



> On Sept. 19, 2013, 9:43 a.m., David Faure wrote:
> > tier1/kguiaddons/tests/CMakeLists.txt, line 28
> > 
> >
> > But now it's kguiaddons (a tier1) that doesn't build standalone (with 
> > tests enabled), because it needs KConfigWidgets which is in a higher tier.
> > 
> > Can you look further into kcolorspaces.h?
> > Should it be installed? If not, it should be called _p.h. Can the test 
> > use higher-level public API instead of an internal header?

Indeed, you are right. kcolorspaces.h provides a KHCY class, which has public 
single-letter fields. To make the file public, those should at least be made 
private and properly named accessors should be added, maybe the fields should 
be moved to a d-pointer? What do you think?


- Aurélien


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112796/#review40323
---


On Sept. 18, 2013, 6:27 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112796/
> ---
> 
> (Updated Sept. 18, 2013, 6:27 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> This is required for kconfigwidgets to build standalone because 
> kcolorutilsdemo.cpp includes kcolorspaces.h, which is part of kguiaddons but 
> not installed.
> 
> 
> Diffs
> -
> 
>   staging/kconfigwidgets/tests/CMakeLists.txt bc52bc1 
>   staging/kconfigwidgets/tests/kcolorutilsdemo.h 09e867a 
>   staging/kconfigwidgets/tests/kcolorutilsdemo.cpp 940569e 
>   staging/kconfigwidgets/tests/kcolorutilsdemo.ui c6604fd 
>   staging/kconfigwidgets/tests/kimageframe.h d521cb5 
>   staging/kconfigwidgets/tests/kimageframe.cpp 60a5e9d 
>   tier1/kguiaddons/tests/CMakeLists.txt 4d91ed8 
>   tier1/kguiaddons/tests/kcolorutilsdemo.h PRE-CREATION 
>   tier1/kguiaddons/tests/kcolorutilsdemo.cpp PRE-CREATION 
>   tier1/kguiaddons/tests/kcolorutilsdemo.ui PRE-CREATION 
>   tier1/kguiaddons/tests/kimageframe.h PRE-CREATION 
>   tier1/kguiaddons/tests/kimageframe.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112796/diff/
> 
> 
> Testing
> ---
> 
> Still builds, kcolorutilsdemo runs correctly.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112681: Tests for KPluginTrader and friends

2013-09-19 Thread Sebastian Kügler



> On Sept. 18, 2013, 10 p.m., David Faure wrote:
> > staging/kservice/tests/pluginlocator/plugintest.cpp, line 170
> > 
> >
> > hehe

I'll leave this in for now. It's the call which parses the stuff created by 
createtestdirs.py. It would be a bit inconvenient to keep a separate branch for 
that right now.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112681/#review40314
---


On Sept. 18, 2013, 12:12 p.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112681/
> ---
> 
> (Updated Sept. 18, 2013, 12:12 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Description
> ---
> 
> Tests for KPluginTrader.
> 
> Under autotests/, there's a new test class which runs a variety of queries 
> using KPluginTrader. There's also a small plugin, which is used to verify 
> correct metadata querying and loading. It's not installed since QPluginLoader 
> conveniently contains the working directory when looking for plugins -> it's 
> found just fine.
> 
> Under tests/, there's a test which will query for a variety of other plugins. 
> This one is more geared towards performance testing. When run from make test, 
> it will pass anyway.
> 
> Code can also be found in kdelibs[sebas/pluginlocator].
> 
> 
> Diffs
> -
> 
>   staging/kservice/autotests/CMakeLists.txt d341040 
>   staging/kservice/autotests/fakeplugin.desktop PRE-CREATION 
>   staging/kservice/autotests/fakeplugin.json PRE-CREATION 
>   staging/kservice/autotests/nsaplugin.h PRE-CREATION 
>   staging/kservice/autotests/nsaplugin.cpp PRE-CREATION 
>   staging/kservice/autotests/pluginlocatortest.h PRE-CREATION 
>   staging/kservice/autotests/pluginlocatortest.cpp PRE-CREATION 
>   staging/kservice/tests/CMakeLists.txt 3793aea 
>   staging/kservice/tests/pluginlocator/CMakeLists.txt PRE-CREATION 
>   staging/kservice/tests/pluginlocator/main.cpp PRE-CREATION 
>   staging/kservice/tests/pluginlocator/plugintest.h PRE-CREATION 
>   staging/kservice/tests/pluginlocator/plugintest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112681/diff/
> 
> 
> Testing
> ---
> 
> make test =)
> 
> All tests pass on top of my patches.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Fwd: Print Dialog - next steps

2013-09-19 Thread John Layt

On 18 September 2013 08:18, David Faure  wrote:
> On Monday 09 September 2013 14:07:31 Martin Klapetek wrote:
>> 5) In KF5 the KdePrintDialog stuff can either be removed entirely, or more
>> conservatively modified to no longer insert the extra KDE Cups widgets and
>> modifications so they don't appear twice.  Discuss with Kevin and David
>> which they would prefer.
>
> What else does KdePrintDialog bring?
>
> I assume nothing, and your suggestion is merely for source compatibility,
> right?
>
> Martin: please use lxr.kde.org to see how much it's used. If less than 5
> times, kill it. If more than 50, provide it in kde4support. In between, use
> your own judgement (more precisely, choose whichever option will lead to less
> effort overall, trimming down KdePrintDialog vs porting all usages).

All it provided was the extra CUPS features, there's no other benefit
to it unless we want to add any other KDE features to the print dialog
that we can't convince the print maintainer to include :-)  I can't
think of anything we would need to add, everything else we want needs
new cross-platform api in Qt.

It gets used in all KDE applications that want to print, lxr says
exactly 50 actual uses, I remember spending a day to port them all for
4.0 :-)  They would almost all be a 1 line change, or 2 lines if
adding widgets.

John.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Build failed in Jenkins: kdelibs_frameworks_qt5 #1219

2013-09-19 Thread Aleix Pol

On Wed, Sep 18, 2013 at 5:03 PM, KDE CI System  wrote:

> See 
>
> Changes:
>
> [aleixpol] Reorganize KDocTools cmake code
>
> [aleixpol] Start adopting QCollator
>
> --
> [...truncated 3600 lines...]
> [ 24%] [ 24%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/button.cpp.o
> Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/block.cpp.o
> [ 24%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/keyboard.cpp.o
> [ 24%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/pointingdevice.cpp.o
> [ 24%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/button.cpp.o
> [ 24%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/camera.cpp.o
> [ 24%] [ 24%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/keyboard.cpp.o
> Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/pointingdevice.cpp.o
> [ 24%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/camera.cpp.o
> [ 24%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/opticaldrive.cpp.o
> [ 24%] [ 24%] [ 24%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/device.cpp.o
> Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/opticaldrive.cpp.o
> [ 24%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/deviceinterface.cpp.o
> Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/device.cpp.o
> [ 24%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/deviceinterface.cpp.o
> [ 24%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/devicemanager.cpp.o
> [ 24%] [ 25%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/dvbinterface.cpp.o
> Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/devicemanager.cpp.o
> [ 25%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/genericinterface.cpp.o
> [ 26%] [ 26%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/networkinterface.cpp.o
> Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/dvbinterface.cpp.o
> [ 26%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/genericinterface.cpp.o
> [ 26%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/networkinterface.cpp.o
> [ 26%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/networkshare.cpp.o
> [ 26%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/serialinterface.cpp.o
> [ 26%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/opticaldisc.cpp.o
> [ 26%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/networkshare.cpp.o
> [ 26%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/serialinterface.cpp.o
> [ 26%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/opticaldisc.cpp.o
> [ 26%] [ 26%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/portablemediaplayer.cpp.o
> Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/portablemediaplayer.cpp.o
> [ 26%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/processor.cpp.o
> [ 26%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/processor.cpp.o
> [ 26%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/storagedrive.cpp.o
> [ 26%] [ 26%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/storagevolume.cpp.o
> [ 26%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/storageaccess.cpp.o
> Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/video.cpp.o
> [ 26%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/storagedrive.cpp.o
> [ 26%] [ 26%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/smartcardreader.cpp.o
> Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/storagevolume.cpp.o
> [ 26%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/storageaccess.cpp.o
> [ 26%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/video.cpp.o
> [ 26%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/smartcardreader.cpp.o
> [ 26%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid_static.dir/ifaces/internetgateway.cpp.o
> [ 26%] Building CXX object
> tier1/solid/src/solid/CMakeFiles/Solid.dir/ifaces/internetgateway.cpp.o
> [ 26%] Building CXX object
> tier1/solid/src/soli

Re: Review Request 112808: Port away from KDirWatch in KEmoticons (prior to splitting)

2013-09-19 Thread David Faure


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112808/#review40325
---



staging/kemoticons/src/core/kemoticons.cpp


This test is already done internally in QFSW, remove it from here.


- David Faure


On Sept. 18, 2013, 10:26 p.m., David Gil Oliva wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112808/
> ---
> 
> (Updated Sept. 18, 2013, 10:26 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Port away from KDirWatch in KEmoticons (prior to splitting)
> 
> 
> Diffs
> -
> 
>   staging/kemoticons/src/core/CMakeLists.txt 
> 0e79eaae60dfd5cd5e0c5f6848b86dbb90c0c818 
>   staging/kemoticons/src/core/kemoticons.cpp 
> 5f6a23ec606b3c6dceac2e01a280413e6899a59b 
> 
> Diff: http://git.reviewboard.kde.org/r/112808/diff/
> 
> 
> Testing
> ---
> 
> It builds and installs correctly.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112803: Start cleaning up KDNSSD

2013-09-19 Thread David Faure


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112803/#review40324
---



dnssd/CMakeLists.txt


not exactly



dnssd/CMakeLists.txt


not useful, we don't set it anymore
(such a line should probably be removed all over kdelibs)



dnssd/CMakeLists.txt


this line is missing LINK_PUBLIC or LINK_PRIVATE (I would guess the latter?)


- David Faure


On Sept. 18, 2013, 6:41 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112803/
> ---
> 
> (Updated Sept. 18, 2013, 6:41 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Renames target to KDNSSD.
> Properly look-up Qt and KF5.
> 
> After that I'll move it to staging.
> 
> 
> Diffs
> -
> 
>   dnssd/CMakeLists.txt 7f2620a 
> 
> Diff: http://git.reviewboard.kde.org/r/112803/diff/
> 
> 
> Testing
> ---
> 
> Builds, there are no tests.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112796: Move kcolorutilsdemo from kconfigwidgets/tests to kguiaddons/tests

2013-09-19 Thread David Faure


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112796/#review40323
---



tier1/kguiaddons/tests/CMakeLists.txt


But now it's kguiaddons (a tier1) that doesn't build standalone (with tests 
enabled), because it needs KConfigWidgets which is in a higher tier.

Can you look further into kcolorspaces.h?
Should it be installed? If not, it should be called _p.h. Can the test use 
higher-level public API instead of an internal header?


- David Faure


On Sept. 18, 2013, 4:27 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112796/
> ---
> 
> (Updated Sept. 18, 2013, 4:27 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> This is required for kconfigwidgets to build standalone because 
> kcolorutilsdemo.cpp includes kcolorspaces.h, which is part of kguiaddons but 
> not installed.
> 
> 
> Diffs
> -
> 
>   staging/kconfigwidgets/tests/CMakeLists.txt bc52bc1 
>   staging/kconfigwidgets/tests/kcolorutilsdemo.h 09e867a 
>   staging/kconfigwidgets/tests/kcolorutilsdemo.cpp 940569e 
>   staging/kconfigwidgets/tests/kcolorutilsdemo.ui c6604fd 
>   staging/kconfigwidgets/tests/kimageframe.h d521cb5 
>   staging/kconfigwidgets/tests/kimageframe.cpp 60a5e9d 
>   tier1/kguiaddons/tests/CMakeLists.txt 4d91ed8 
>   tier1/kguiaddons/tests/kcolorutilsdemo.h PRE-CREATION 
>   tier1/kguiaddons/tests/kcolorutilsdemo.cpp PRE-CREATION 
>   tier1/kguiaddons/tests/kcolorutilsdemo.ui PRE-CREATION 
>   tier1/kguiaddons/tests/kimageframe.h PRE-CREATION 
>   tier1/kguiaddons/tests/kimageframe.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112796/diff/
> 
> 
> Testing
> ---
> 
> Still builds, kcolorutilsdemo runs correctly.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

2013-09-19 Thread David Faure


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112785/#review40322
---


https://git.reviewboard.kde.org/r/112795/diff/ might provide insights on how to 
use kdelibs-kf5-defined macros inside kdelibs-kf5.

- David Faure


On Sept. 17, 2013, 7:56 p.m., Jeremy Whiting wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112785/
> ---
> 
> (Updated Sept. 17, 2013, 7:56 p.m.)
> 
> 
> Review request for KDE Frameworks and Alexander Neundorf.
> 
> 
> Description
> ---
> 
> It builds and installs, but doesn't seem to be usable from within kdelibs, 
> i.e. ki18n_wrap_ui in knewstuff/src/CMakeLists.txt fails with this. I suspect 
> one more thing is needed to make it work from within kdelibs builds.
> 
> 
> Diffs
> -
> 
>   tier2/ki18n/CMakeLists.txt d0ed448 
>   tier2/ki18n/KI18nConfig.cmake.in 18b6e2f 
>   tier2/ki18n/cmake/KI18NMacros.cmake PRE-CREATION 
>   tier2/ki18n/cmake/ki18nuic.cmake PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112785/diff/
> 
> 
> Testing
> ---
> 
> Builds and installs into PREFIX/lib64/cmake/KI18N next to KI18nConfig.cmake
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112795: Move KDocTools to tier2

2013-09-19 Thread David Faure


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112795/#review40321
---

Ship it!


Did you check that it passes the "definition of done" from the wiki?


tier2/kdoctools/CMakeLists.txt


I'm curious, what does that do?


- David Faure


On Sept. 18, 2013, 3:34 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112795/
> ---
> 
> (Updated Sept. 18, 2013, 3:34 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Does the move, changes a couple of things so the macros are still found.
> 
> 
> Diffs
> -
> 
>   cmake/modules/KDE4Macros.cmake 403679f 
>   staging/CMakeLists.txt 7826b07 
>   tier2/CMakeLists.txt 6c98a7d 
>   tier2/kdoctools/CMakeLists.txt 7e09279 
> 
> Diff: http://git.reviewboard.kde.org/r/112795/diff/
> 
> 
> Testing
> ---
> 
> Builds, no tests.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112758: Move KCompletion to tier2

2013-09-19 Thread David Faure


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112758/#review40320
---

Ship it!


Did you check that it passes the "definition of done" from the wiki?

- David Faure


On Sept. 16, 2013, 3:08 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112758/
> ---
> 
> (Updated Sept. 16, 2013, 3:08 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Not much else.
> 
> 
> Diffs
> -
> 
>   staging/CMakeLists.txt 7826b07 
>   staging/kcompletion/CMakeLists.txt  
>   staging/kcompletion/KCompletionConfig.cmake.in  
>   staging/kcompletion/autotests/CMakeLists.txt  
>   staging/kcompletion/autotests/kcombobox_unittest.cpp  
>   staging/kcompletion/autotests/kcompletioncoretest.h  
>   staging/kcompletion/autotests/kcompletioncoretest.cpp  
>   staging/kcompletion/autotests/klineedit_unittest.cpp  
>   staging/kcompletion/autotests/ksortablelisttest.cpp  
>   staging/kcompletion/src/CMakeLists.txt  
>   staging/kcompletion/src/kcombobox.h  
>   staging/kcompletion/src/kcombobox.cpp  
>   staging/kcompletion/src/kcompletion.h  
>   staging/kcompletion/src/kcompletion.cpp  
>   staging/kcompletion/src/kcompletion_p.h  
>   staging/kcompletion/src/kcompletionbase.cpp  
>   staging/kcompletion/src/kcompletionbox.h  
>   staging/kcompletion/src/kcompletionbox.cpp  
>   staging/kcompletion/src/khistorycombobox.h  
>   staging/kcompletion/src/khistorycombobox.cpp  
>   staging/kcompletion/src/klineedit.h  
>   staging/kcompletion/src/klineedit.cpp  
>   staging/kcompletion/src/klineedit_p.h  
>   staging/kcompletion/src/kpixmapprovider.h  
>   staging/kcompletion/src/kpixmapprovider.cpp  
>   staging/kcompletion/src/ksortablelist.h  
>   staging/kcompletion/src/kzoneallocator.cpp  
>   staging/kcompletion/src/kzoneallocator_p.h  
>   staging/kcompletion/tests/CMakeLists.txt  
>   staging/kcompletion/tests/kcomboboxtest.h  
>   staging/kcompletion/tests/kcomboboxtest.cpp  
>   staging/kcompletion/tests/kcompletionuitest.h  
>   staging/kcompletion/tests/kcompletionuitest.cpp  
>   staging/kcompletion/tests/klineedittest.h  
>   staging/kcompletion/tests/klineedittest.cpp  
>   tier2/CMakeLists.txt 51f093b 
> 
> Diff: http://git.reviewboard.kde.org/r/112758/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Splitting out a KX11Extras frameworks from KWindowSystems

2013-09-19 Thread David Faure

On Monday 16 September 2013 15:07:37 Martin Graesslin wrote:
> Hi,
> 
> KWindowSystems is a framework which looks to me like a KX11Extras framework.
> Most of the things inside this framework are X11 specific. Some API even
> has XLib/XCB specific data types as arguments or return values (e.g.
> netwm.h). The only class which has a non-X11 implementation is
> KWindowSystem and KWindowInfo, but also those are highly X11 inspired.
> 
> My suggestion would be to create a new tier1 framework KX11Extras which
> contains:
> * fixx11h.h
> * KManagerSelection
> * KStartupInfo
> * KXMessages
> * NETwm

I'm not convinced about KStartupInfo. It's used pervasively and it's much more
convenient if the class is available on all platforms, even if it does nothing.
Otherwise it leads to such horrors like in krun_p.h:

#if !HAVE_X11
KProcessRunner(const QString &command, const QString & binName, const 
QString &workingDirectory);
#else
KProcessRunner(const QString &command, const QString & binName, const 
KStartupInfoId& id, const QString &workingDirectory);
#endif

OK, this shows that "it's already only on X11" though, so your suggestion 
doesn't make
things worse, it just goes in the opposite direction to what I thought would be 
nicer for app code.
Not a strong veto then, if you think this makes sense, proceed, I just wanted 
to raise the
question of whether it wouldn't be possible to make the class available on all 
platforms
for less ifdef-ery.

About splitting out an extra framework: what do we gain from it, actually?
It's not like KWindowSystem brings in any more dependencies, so users of the 
above classes
wouldn't have been bothered by the other classes in the framework. It seems the 
proposal
is merely about naming? (making the purpose of the framework clearer).
Ah and about making it clear which classes are only available on X11, and which 
ones are
available everywhere, I guess. I'm just a bit uneasy about making too many too 
small
frameworks when we can avoid it, but OK, that's another "not a strong veto".

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

57 matches

Mail list logo