Re: Compiling Plasma-Framework with a QT5 compiled with -egl -opengl es2
On Wednesday 09 October 2013 22:18:26 nerdopolis wrote: Hi. I am trying to compile plasma-framework against a qt5 that is ready for Wayland, which does not have Desktop GL enabled. Wayland does not require OpenGL ES. This is a common misunderstanding due to first Weston versions requiring OpenGL ES. It should be possible to compile with OpenGL Desktop (note: desktop gl still includes glx but glx is not required to get an OpenGL context). However I seem to get an error that seems to be related to opengl in QT. Is this a bug I should file? no need to file a bug about it. It's code I have written and I know that it currently requires glx. The problem here is that GLX is found on your system but Qt is compiled as gles. This is an unfortunate situation and should not happen in real world as one has either desktop gl or gles and not both on a system. Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113148: Move and clean KBuildsycoca to KService
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113148/ --- (Updated Oct. 10, 2013, 10:04 a.m.) Review request for KDE Frameworks. Changes --- Nuked KCrash usage Repository: kdelibs Description --- Moved KBuildsyscoca to KService. I have done the moving and the cleaning in different commits, just unified them for reviewboard. Diffs (updated) - kded/CMakeLists.txt 4f9133f kded/applications.menu kded/kbuildmimetypefactory.h kded/kbuildmimetypefactory.cpp 2e81ce7 kded/kbuildservicefactory.h kded/kbuildservicefactory.cpp 971f327 kded/kbuildservicegroupfactory.h kded/kbuildservicegroupfactory.cpp 5485b1c kded/kbuildservicetypefactory.h kded/kbuildservicetypefactory.cpp f473cd6 kded/kbuildsycoca.h kded/kbuildsycoca.cpp 8ea2d2e kded/kbuildsycocainterface.h kded/kctimefactory.h kded/kctimefactory.cpp kded/kmimeassociations.h kded/kmimeassociations.cpp kded/ksycocaresourcelist.h kded/tests/CMakeLists.txt ca392d2 kded/tests/kmimeassociationstest.cpp kded/vfolder_menu.h kded/vfolder_menu.cpp staging/kservice/CMakeLists.txt b244731 staging/kservice/kbuildsycoca/CMakeLists.txt PRE-CREATION staging/kservice/tests/CMakeLists.txt 23d4854 Diff: http://git.reviewboard.kde.org/r/113148/diff/ Testing --- Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113179: Make the runners compile again
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113179/#review41496 --- Ship it! With the two issues I've pointed out, this patch can be committed, as it's not going to cause merge conflicts. - Sebastian Kügler On Oct. 8, 2013, 5:14 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113179/ --- (Updated Oct. 8, 2013, 5:14 p.m.) Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- Recently there's been some big changes in the ThreadWeaver API. So big that they break the source compatibility we were supposed to maintain, big time. This patch tries to port plasma-framework to that new API. Diffs - src/plasma/CMakeLists.txt 411256a src/plasma/private/runnerjobs.cpp d11f7e9 src/plasma/private/runnerjobs_p.h 7fd7076 src/plasma/private/storage.cpp 35b222e src/plasma/runnermanager.cpp 135279e src/plasma/scripting/runnerscript.cpp d5142a2 Diff: http://git.reviewboard.kde.org/r/113179/diff/ Testing --- Everything builds, including kde-workspace. Couldn't test it, there's no tests for it or even an application to test it :/. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113154: Remove KFileMetaDataWidget and friends
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113154/ --- (Updated Oct. 10, 2013, 12:56 p.m.) Review request for KDE Frameworks. Changes --- Added a note in KDE5Porting.html Repository: kdelibs Description --- Remove KFileMetaDataWidget and friends These have been deprecated in KDE4.[1] This also removes the KFileMetaPropsPlugin in the KPropertiesDialog - The code was commented out so it doesn't really make a difference. Eventually we will need a proper plugin based system so that the Nepomuk2::FileMetadataWidget can be used in the KPropertiesDialog [1] https://git.reviewboard.kde.org/r/113153/ Diffs (updated) - KDE5PORTING.html 3171afc kdewidgets/kde.widgets b138d4e staging/kde4support/src/CMakeLists.txt 5eb649c staging/kde4support/src/kio/kcommentwidget.cpp 6223a0c staging/kde4support/src/kio/kcommentwidget_p.h 7a9c710 staging/kde4support/src/kio/kfilemetadataconfigurationwidget.h 52735ad staging/kde4support/src/kio/kfilemetadataconfigurationwidget.cpp 018d183 staging/kde4support/src/kio/kfilemetadataprovider.cpp 59cb238 staging/kde4support/src/kio/kfilemetadataprovider_p.h 0969f53 staging/kde4support/src/kio/kfilemetadatareader.cpp 6a7909c staging/kde4support/src/kio/kfilemetadatareader_p.h af054c2 staging/kde4support/src/kio/kfilemetadatareaderprocess.cpp 0d2b993 staging/kde4support/src/kio/kfilemetadatawidget.h 31dd3c7 staging/kde4support/src/kio/kfilemetadatawidget.cpp 2df2312 staging/kde4support/src/kio/kmetaprops.h b03dd4c staging/kde4support/src/kio/kmetaprops.cpp 46624c5 staging/kde4support/src/kio/knfotranslator.cpp 0494679 staging/kde4support/src/kio/knfotranslator_p.h ddbe4a1 staging/kio/src/widgets/kpropertiesdialog.cpp 63e4435 Diff: http://git.reviewboard.kde.org/r/113154/diff/ Testing --- Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113050: Use enum for KMessageBox return types
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113050/#review41507 --- This review has been submitted with commit 1f1cdd6966df8a0f1f542e5a6d5018e55437b1d3 by Aurélien Gâteau to branch frameworks. - Commit Hook On Oct. 2, 2013, 2:43 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113050/ --- (Updated Oct. 2, 2013, 2:43 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Use enum for KMessageBox return types instead of int. Diffs - staging/kde4support/src/kdeui/kmessagebox_queued.cpp 00e9eb0 tier1/kwidgetsaddons/src/kmessagebox.h 4d1306b tier1/kwidgetsaddons/src/kmessagebox.cpp d974cd6 Diff: http://git.reviewboard.kde.org/r/113050/diff/ Testing --- Builds, tests pass. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113174: Cleanup KJsEmbed
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113174/ --- (Updated Oct. 10, 2013, 1:30 p.m.) Review request for KDE Frameworks. Changes --- Fix the issues pointed by David and Kevin. Repository: kdelibs Description --- Adopt directory organization, naming scheme, cmake structures, documents dependencies. Diffs (updated) - kjsembed/kjsembed/fileio.cpp kjsembed/kjsembed/font.h kjsembed/kjsembed/font.cpp kjsembed/kjsembed/image.h kjsembed/kjsembed/image.cpp kjsembed/kjsembed/iosupport.h kjsembed/kjsembed/iosupport.cpp kjsembed/kjsembed/jseventmapper.h kjsembed/kjsembed/jseventmapper.cpp kjsembed/kjsembed/jseventutils.h kjsembed/kjsembed/jseventutils.cpp kjsembed/kjsembed/kjseglobal.h kjsembed/kjsembed/kjseglobal.cpp kjsembed/kjsembed/kjsembed.h 74dfab8 kjsembed/kjsembed/kjsembed.cpp kjsembed/kjsembed/object_binding.h kjsembed/kjsembed/object_binding.cpp kjsembed/kjsembed/pen.h kjsembed/kjsembed/pen.cpp kjsembed/kjsembed/pixmap.h kjsembed/kjsembed/pixmap.cpp kjsembed/kjsembed/point.h kjsembed/kjsembed/point.cpp kjsembed/kjsembed/pointer.h kjsembed/kjsembed/qaction_binding.h kjsembed/kjsembed/qaction_binding.cpp kjsembed/kjsembed/qformbuilder_binding.h kjsembed/kjsembed/qformbuilder_binding.cpp kjsembed/kjsembed/qlayout_binding.h kjsembed/kjsembed/qlayout_binding.cpp kjsembed/kjsembed/qobject_binding.h kjsembed/kjsembed/qobject_binding.cpp kjsembed/kjsembed/qpainter_binding.h kjsembed/kjsembed/qpainter_binding.cpp kjsembed/kjsembed/quiloader_binding.h kjsembed/kjsembed/quiloader_binding.cpp kjsembed/kjsembed/qwidget_binding.h kjsembed/kjsembed/qwidget_binding.cpp kjsembed/kjsembed/rect.h kjsembed/kjsembed/rect.cpp kjsembed/kjsembed/settings.h kjsembed/kjsembed/settings.cpp kjsembed/kjsembed/size.h kjsembed/kjsembed/size.cpp kjsembed/kjsembed/slotproxy.h 48b88ef kjsembed/kjsembed/slotproxy.cpp kjsembed/kjsembed/static_binding.h kjsembed/kjsembed/static_binding.cpp kjsembed/kjsembed/svg_binding.h kjsembed/kjsembed/svg_binding.cpp kjsembed/kjsembed/test/QByteArray_bind.h kjsembed/kjsembed/test/QByteArray_bind.cpp kjsembed/kjsembed/url.h kjsembed/kjsembed/url.cpp kjsembed/kjsembed/util.h kjsembed/kjsembed/value_binding.h kjsembed/kjsembed/value_binding.cpp kjsembed/kjsembed/variant_binding.h kjsembed/kjsembed/variant_binding.cpp staging/CMakeLists.txt 55cc3d3 staging/kjsembed/CMakeLists.txt PRE-CREATION staging/kjsembed/KJsEmbedConfig.cmake.in PRE-CREATION staging/kjsembed/examples/kjsconsole/CMakeLists.txt PRE-CREATION staging/kjsembed/src/CMakeLists.txt PRE-CREATION staging/kjsembed/src/kjscmd/CMakeLists.txt PRE-CREATION staging/kjsembed/src/kjsembed/CMakeLists.txt PRE-CREATION staging/kross/src/kjs/CMakeLists.txt cfa026e tier1/kjs/src/wtf/Platform.h 843cfd2 kjsembed/kjsembed/fileio.h kjsembed/kjsembed/filedialog_binding.cpp kjsembed/kjsembed/filedialog_binding.h kjsembed/kjsembed/eventproxy.cpp kjsembed/kjsembed/eventproxy.h kjsembed/kjsembed/dom.cpp kjsembed/kjsembed/dom.h kjsembed/kjsembed/brush.cpp kjsembed/kjsembed/builtins.h kjsembed/kjsembed/builtins.cpp kjsembed/kjsembed/color.h kjsembed/kjsembed/color.cpp kjsembed/kjsembed/brush.h kjsembed/kjsembed/binding_support.cpp kjsembed/kjsembed/binding_support.h kjsembed/kjsembed/application.h kjsembed/kjsembed/application.cpp kjsembed/kjsembed/QBrush_bind.cpp kjsembed/kjsembed/QBrush_bind.h CMakeLists.txt 368584e kjsembed/AUTHORS kjsembed/CMakeLists.txt 6cb6727 kjsembed/Mainpage.dox kjsembed/examples/calc/calc.js kjsembed/examples/calc/calc.ui kjsembed/examples/console/console.js kjsembed/examples/console/console.ui kjsembed/examples/docviewer/docviewer.js kjsembed/examples/docviewer/docviewer.ui kjsembed/examples/fancy/fancy.js kjsembed/examples/grammar/grammar.js kjsembed/examples/kjsconsole/CMakeLists.txt d06f27b kjsembed/examples/kjsconsole/console.h kjsembed/examples/kjsconsole/console.cpp f65f39b kjsembed/examples/kjsconsole/console.qrc kjsembed/examples/kjsconsole/images/bug.png kjsembed/examples/kjsconsole/images/class.png kjsembed/examples/kjsconsole/images/constant.png kjsembed/examples/kjsconsole/images/method.png kjsembed/examples/kjsconsole/images/next.png kjsembed/examples/kjsconsole/images/no.png kjsembed/examples/kjsconsole/images/property.png kjsembed/examples/kjsconsole/images/runto.png kjsembed/examples/kjsconsole/images/start.png kjsembed/examples/kjsconsole/images/step.png kjsembed/examples/kjsconsole/images/stop.png
Re: Review Request 113174: Cleanup KJsEmbed
On Oct. 9, 2013, 4:19 p.m., David Edmundson wrote: kjsembed/kjscmd/kjscmd.cpp, line 78 http://git.reviewboard.kde.org/r/113174/diff/1/?file=200020#file200020line78 this seems to break whitespace for no reason? - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113174/#review41435 --- On Oct. 10, 2013, 1:30 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113174/ --- (Updated Oct. 10, 2013, 1:30 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Adopt directory organization, naming scheme, cmake structures, documents dependencies. Diffs - kjsembed/kjsembed/fileio.cpp kjsembed/kjsembed/font.h kjsembed/kjsembed/font.cpp kjsembed/kjsembed/image.h kjsembed/kjsembed/image.cpp kjsembed/kjsembed/iosupport.h kjsembed/kjsembed/iosupport.cpp kjsembed/kjsembed/jseventmapper.h kjsembed/kjsembed/jseventmapper.cpp kjsembed/kjsembed/jseventutils.h kjsembed/kjsembed/jseventutils.cpp kjsembed/kjsembed/kjseglobal.h kjsembed/kjsembed/kjseglobal.cpp kjsembed/kjsembed/kjsembed.h 74dfab8 kjsembed/kjsembed/kjsembed.cpp kjsembed/kjsembed/object_binding.h kjsembed/kjsembed/object_binding.cpp kjsembed/kjsembed/pen.h kjsembed/kjsembed/pen.cpp kjsembed/kjsembed/pixmap.h kjsembed/kjsembed/pixmap.cpp kjsembed/kjsembed/point.h kjsembed/kjsembed/point.cpp kjsembed/kjsembed/pointer.h kjsembed/kjsembed/qaction_binding.h kjsembed/kjsembed/qaction_binding.cpp kjsembed/kjsembed/qformbuilder_binding.h kjsembed/kjsembed/qformbuilder_binding.cpp kjsembed/kjsembed/qlayout_binding.h kjsembed/kjsembed/qlayout_binding.cpp kjsembed/kjsembed/qobject_binding.h kjsembed/kjsembed/qobject_binding.cpp kjsembed/kjsembed/qpainter_binding.h kjsembed/kjsembed/qpainter_binding.cpp kjsembed/kjsembed/quiloader_binding.h kjsembed/kjsembed/quiloader_binding.cpp kjsembed/kjsembed/qwidget_binding.h kjsembed/kjsembed/qwidget_binding.cpp kjsembed/kjsembed/rect.h kjsembed/kjsembed/rect.cpp kjsembed/kjsembed/settings.h kjsembed/kjsembed/settings.cpp kjsembed/kjsembed/size.h kjsembed/kjsembed/size.cpp kjsembed/kjsembed/slotproxy.h 48b88ef kjsembed/kjsembed/slotproxy.cpp kjsembed/kjsembed/static_binding.h kjsembed/kjsembed/static_binding.cpp kjsembed/kjsembed/svg_binding.h kjsembed/kjsembed/svg_binding.cpp kjsembed/kjsembed/test/QByteArray_bind.h kjsembed/kjsembed/test/QByteArray_bind.cpp kjsembed/kjsembed/url.h kjsembed/kjsembed/url.cpp kjsembed/kjsembed/util.h kjsembed/kjsembed/value_binding.h kjsembed/kjsembed/value_binding.cpp kjsembed/kjsembed/variant_binding.h kjsembed/kjsembed/variant_binding.cpp staging/CMakeLists.txt 55cc3d3 staging/kjsembed/CMakeLists.txt PRE-CREATION staging/kjsembed/KJsEmbedConfig.cmake.in PRE-CREATION staging/kjsembed/examples/kjsconsole/CMakeLists.txt PRE-CREATION staging/kjsembed/src/CMakeLists.txt PRE-CREATION staging/kjsembed/src/kjscmd/CMakeLists.txt PRE-CREATION staging/kjsembed/src/kjsembed/CMakeLists.txt PRE-CREATION staging/kross/src/kjs/CMakeLists.txt cfa026e tier1/kjs/src/wtf/Platform.h 843cfd2 kjsembed/kjsembed/fileio.h kjsembed/kjsembed/filedialog_binding.cpp kjsembed/kjsembed/filedialog_binding.h kjsembed/kjsembed/eventproxy.cpp kjsembed/kjsembed/eventproxy.h kjsembed/kjsembed/dom.cpp kjsembed/kjsembed/dom.h kjsembed/kjsembed/brush.cpp kjsembed/kjsembed/builtins.h kjsembed/kjsembed/builtins.cpp kjsembed/kjsembed/color.h kjsembed/kjsembed/color.cpp kjsembed/kjsembed/brush.h kjsembed/kjsembed/binding_support.cpp kjsembed/kjsembed/binding_support.h kjsembed/kjsembed/application.h kjsembed/kjsembed/application.cpp kjsembed/kjsembed/QBrush_bind.cpp kjsembed/kjsembed/QBrush_bind.h CMakeLists.txt 368584e kjsembed/AUTHORS kjsembed/CMakeLists.txt 6cb6727 kjsembed/Mainpage.dox kjsembed/examples/calc/calc.js kjsembed/examples/calc/calc.ui kjsembed/examples/console/console.js kjsembed/examples/console/console.ui kjsembed/examples/docviewer/docviewer.js kjsembed/examples/docviewer/docviewer.ui kjsembed/examples/fancy/fancy.js kjsembed/examples/grammar/grammar.js kjsembed/examples/kjsconsole/CMakeLists.txt d06f27b kjsembed/examples/kjsconsole/console.h kjsembed/examples/kjsconsole/console.cpp f65f39b
Re: Review Request 113174: Cleanup KJsEmbed
On Oct. 9, 2013, 5:22 p.m., Kevin Ottens wrote: kjsembed/examples/kjsconsole/console.cpp, line 35 http://git.reviewboard.kde.org/r/113174/diff/1/?file=199962#file199962line35 Hm actually surprising, where does this include come from? KJS, JSVariableObject.h is where GlobalObject is declared. On Oct. 9, 2013, 5:22 p.m., Kevin Ottens wrote: staging/kjsembed/CMakeLists.txt, line 26 http://git.reviewboard.kde.org/r/113174/diff/1/?file=200102#file200102line26 Hm... if this if really needed? UiTools being declared as a REQUIRED component in the find_package above. Well, I just wanted to make sure Qt5::UiTools was not required, but it probably doesn't make sense since the rest of the modules that depend on KJsEmbed shouldn't be compiled then too. - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113174/#review41456 --- On Oct. 10, 2013, 1:30 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113174/ --- (Updated Oct. 10, 2013, 1:30 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Adopt directory organization, naming scheme, cmake structures, documents dependencies. Diffs - kjsembed/kjsembed/fileio.cpp kjsembed/kjsembed/font.h kjsembed/kjsembed/font.cpp kjsembed/kjsembed/image.h kjsembed/kjsembed/image.cpp kjsembed/kjsembed/iosupport.h kjsembed/kjsembed/iosupport.cpp kjsembed/kjsembed/jseventmapper.h kjsembed/kjsembed/jseventmapper.cpp kjsembed/kjsembed/jseventutils.h kjsembed/kjsembed/jseventutils.cpp kjsembed/kjsembed/kjseglobal.h kjsembed/kjsembed/kjseglobal.cpp kjsembed/kjsembed/kjsembed.h 74dfab8 kjsembed/kjsembed/kjsembed.cpp kjsembed/kjsembed/object_binding.h kjsembed/kjsembed/object_binding.cpp kjsembed/kjsembed/pen.h kjsembed/kjsembed/pen.cpp kjsembed/kjsembed/pixmap.h kjsembed/kjsembed/pixmap.cpp kjsembed/kjsembed/point.h kjsembed/kjsembed/point.cpp kjsembed/kjsembed/pointer.h kjsembed/kjsembed/qaction_binding.h kjsembed/kjsembed/qaction_binding.cpp kjsembed/kjsembed/qformbuilder_binding.h kjsembed/kjsembed/qformbuilder_binding.cpp kjsembed/kjsembed/qlayout_binding.h kjsembed/kjsembed/qlayout_binding.cpp kjsembed/kjsembed/qobject_binding.h kjsembed/kjsembed/qobject_binding.cpp kjsembed/kjsembed/qpainter_binding.h kjsembed/kjsembed/qpainter_binding.cpp kjsembed/kjsembed/quiloader_binding.h kjsembed/kjsembed/quiloader_binding.cpp kjsembed/kjsembed/qwidget_binding.h kjsembed/kjsembed/qwidget_binding.cpp kjsembed/kjsembed/rect.h kjsembed/kjsembed/rect.cpp kjsembed/kjsembed/settings.h kjsembed/kjsembed/settings.cpp kjsembed/kjsembed/size.h kjsembed/kjsembed/size.cpp kjsembed/kjsembed/slotproxy.h 48b88ef kjsembed/kjsembed/slotproxy.cpp kjsembed/kjsembed/static_binding.h kjsembed/kjsembed/static_binding.cpp kjsembed/kjsembed/svg_binding.h kjsembed/kjsembed/svg_binding.cpp kjsembed/kjsembed/test/QByteArray_bind.h kjsembed/kjsembed/test/QByteArray_bind.cpp kjsembed/kjsembed/url.h kjsembed/kjsembed/url.cpp kjsembed/kjsembed/util.h kjsembed/kjsembed/value_binding.h kjsembed/kjsembed/value_binding.cpp kjsembed/kjsembed/variant_binding.h kjsembed/kjsembed/variant_binding.cpp staging/CMakeLists.txt 55cc3d3 staging/kjsembed/CMakeLists.txt PRE-CREATION staging/kjsembed/KJsEmbedConfig.cmake.in PRE-CREATION staging/kjsembed/examples/kjsconsole/CMakeLists.txt PRE-CREATION staging/kjsembed/src/CMakeLists.txt PRE-CREATION staging/kjsembed/src/kjscmd/CMakeLists.txt PRE-CREATION staging/kjsembed/src/kjsembed/CMakeLists.txt PRE-CREATION staging/kross/src/kjs/CMakeLists.txt cfa026e tier1/kjs/src/wtf/Platform.h 843cfd2 kjsembed/kjsembed/fileio.h kjsembed/kjsembed/filedialog_binding.cpp kjsembed/kjsembed/filedialog_binding.h kjsembed/kjsembed/eventproxy.cpp kjsembed/kjsembed/eventproxy.h kjsembed/kjsembed/dom.cpp kjsembed/kjsembed/dom.h kjsembed/kjsembed/brush.cpp kjsembed/kjsembed/builtins.h kjsembed/kjsembed/builtins.cpp kjsembed/kjsembed/color.h kjsembed/kjsembed/color.cpp kjsembed/kjsembed/brush.h kjsembed/kjsembed/binding_support.cpp kjsembed/kjsembed/binding_support.h kjsembed/kjsembed/application.h kjsembed/kjsembed/application.cpp kjsembed/kjsembed/QBrush_bind.cpp kjsembed/kjsembed/QBrush_bind.h CMakeLists.txt 368584e kjsembed/AUTHORS
Re: update your cmake!
On Thursday 10 October 2013 15:17:12 Sebastian Kügler wrote: Hi, In order to build KF5 and Plasma2 code, you have to update your cmake to 2.8.12. Otherwise, you'll get build errors. Oh... this means we can now make use of ALIAS targets and build truly standalone frameworks \o/ Aurélien ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: libnm-qt Qt5 port: -fPIC or fPIE needed?
On Wednesday 09 October 2013, Sebastian Kügler wrote: Hi, While porting libnm-qt to Qt5, I'm running into the following problem when building the tests. I've not seen this error before, and I'd like advice how to fix it. [ 59%] Building CXX object tests/CMakeFiles/test_8021xsetting.dir/8021xsetting.cpp.o In file included from /home/sebas/kf5/qt5/qtbase/include/QtCore/qglobal.h:1:0, from /home/sebas/kf5/qt5/qtbase/include/QtCore/../../src/corelib/global/qnamespa ce.h:45, from /home/sebas/kf5/qt5/qtbase/include/QtCore/qnamespace.h:1, from /home/sebas/kf5/qt5/qtbase/include/QtCore/../../src/corelib/kernel/qobjectd efs.h:45, from /home/sebas/kf5/qt5/qtbase/include/QtCore/qobjectdefs.h:1, from /home/sebas/kf5/qt5/qtbase/include/QtCore/../../src/corelib/kernel/qobject. h:48, from /home/sebas/kf5/qt5/qtbase/include/QtCore/qobject.h:1, from /home/sebas/kf5/qt5/qtbase/include/QtCore/QObject:1, from /home/sebas/kf5/src/libnm-qt/tests/8021xsetting.h:24, from /home/sebas/kf5/src/libnm-qt/tests/8021xsetting.cpp:21: /home/sebas/kf5/qt5/qtbase/include/QtCore/../../src/corelib/global/qglobal .h:991:4: error: #error You must build your code with position independent code if Qt was built with -reduce-relocations. Compile your code with -fPIC or -fPIE. make[2]: *** [tests/CMakeFiles/test_8021xsetting.dir/8021xsetting.cpp.o] Error 1 This error comes up for a whole slew of tests. I've tried adding -fpie and PIE to the CMAKE_EXE_LINKER_FLAGS (also tried CMAKE_LIBRARY_LINKER_FLAGS) by just setting this variable, but to no avail. The rest of libnm-qt builds fine. Could anyone give me a hint how to fix this? I think Stephens work on target properties etc. in CMake is related to this/should make it work. But I don't know the details. Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: update your cmake!
On Thursday 10 October 2013, Sebastian Kügler wrote: Hi, In order to build KF5 and Plasma2 code, you have to update your cmake to 2.8.12. Otherwise, you'll get build errors. Doesn't it error out in cmake_minimum_required() ? If not, I'd suggest that somebody takes care of handling this properly. If you start using features of some specific cmake version, make sure cmake_minimum_required() ensures that you have at least this version. Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: libnm-qt Qt5 port: -fPIC or fPIE needed?
Sebastian Kügler wrote:
Could anyone give me a hint how to fix this?
You are apparently using empty variables like ${QT_QTCORE_LIBRARY}. Those
are not defined in Qt 5.
-target_link_libraries(NetworkManagerQt ${MODEMMANAGERQT_LIBRARY}
${QT_QTCORE_LIBRARY} ${QT_QTDBUS_LIBRARY} ${QT_QTNETWORK_LIBRARY})
+target_link_libraries(NetworkManagerQt ${MODEMMANAGERQT_LIBRARY} Qt5::DBus
Qt5::Network)
Thanks,
Steve.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: update your cmake!
Alexander Neundorf wrote: On Thursday 10 October 2013, Sebastian Kügler wrote: Hi, In order to build KF5 and Plasma2 code, you have to update your cmake to 2.8.12. Otherwise, you'll get build errors. Doesn't it error out in cmake_minimum_required() ? If not, I'd suggest that somebody takes care of handling this properly. If you start using features of some specific cmake version, make sure cmake_minimum_required() ensures that you have at least this version. As sebas didn't specify what the error is, I don't know what happened here. It might be an accidental side-effect of Bens change, as he wrote, he removed an IS_ABSOLUTE from his patch before submitting: https://git.reviewboard.kde.org/r/113139 That would explain why the minimum version is not bumped, at least. Thanks, Steve. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112918: Add index argument to KWidgetItemDelegate::createItemWidgets
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112918/#review41528 --- This review has been submitted with commit 0816b86275eb78a8dd0d42d84b051ab7010516b2 by David Edmundson to branch frameworks. - Commit Hook On Sept. 24, 2013, 2:33 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112918/ --- (Updated Sept. 24, 2013, 2:33 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Add index argument to KWidgetItemDelegate::createItemWidgets This fixes a KDE5 TODO which used to pass an argument as a property Diffs - staging/kcmutils/src/kpluginselector.cpp 77cbfda5987195f15341e41c3280726e5583d87e KDE5PORTING.html 57ecf2e007e270b634cc8d16462b73e96553c92d staging/kcmutils/src/kpluginselector_p.h 2dffae05dd87cc299ecdb05612f02dd2ad37cd2c staging/xmlgui/src/kaboutapplicationpersonlistdelegate_p.h 0e325915070006d2cfa093719d5c967f3181737d staging/xmlgui/src/kaboutapplicationpersonlistdelegate_p.cpp 84f9ca548068088c0bc0ff99fa460e5f7fecbccd tier1/itemviews/src/kwidgetitemdelegate.h b874c10e9a7ab9ee9bf756ae82ce99bd64ec92d1 tier1/itemviews/src/kwidgetitemdelegatepool.cpp e9bbcad0b030c8d03fadeb6635bfa0d69d996ac9 tier1/itemviews/tests/kwidgetitemdelegatetest.cpp cfca1f9ae3df9bec1e8a570f03b5256cc935e8bb Diff: http://git.reviewboard.kde.org/r/112918/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113155: Port all kde4_add_unit_test uses
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113155/ --- (Updated Oct. 10, 2013, 6:08 p.m.) Review request for KDE Frameworks. Changes --- Ping! Rebase to frameworks branch. Repository: kdelibs Description --- Stop using kde4_add_unit_test. One step less towards no kde4_* uses. Diffs (updated) - kded/tests/CMakeLists.txt ca392d2 kfile/tests/CMakeLists.txt d28d642 khtml/tests/CMakeLists.txt 59a0a56 kio/tests/CMakeLists.txt a60eac0 kioslave/http/kcookiejar/tests/CMakeLists.txt cb67f26 kioslave/http/tests/CMakeLists.txt 000c488 Diff: http://git.reviewboard.kde.org/r/113155/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113179: Make the runners compile again
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113179/#review41533 --- This review has been submitted with commit a3c7a9690f4321700154d2dcf0974de0dd8a7818 by Aleix Pol to branch master. - Commit Hook On Oct. 8, 2013, 5:14 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113179/ --- (Updated Oct. 8, 2013, 5:14 p.m.) Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- Recently there's been some big changes in the ThreadWeaver API. So big that they break the source compatibility we were supposed to maintain, big time. This patch tries to port plasma-framework to that new API. Diffs - src/plasma/CMakeLists.txt 411256a src/plasma/private/runnerjobs.cpp d11f7e9 src/plasma/private/runnerjobs_p.h 7fd7076 src/plasma/private/storage.cpp 35b222e src/plasma/runnermanager.cpp 135279e src/plasma/scripting/runnerscript.cpp d5142a2 Diff: http://git.reviewboard.kde.org/r/113179/diff/ Testing --- Everything builds, including kde-workspace. Couldn't test it, there's no tests for it or even an application to test it :/. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113179: Make the runners compile again
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113179/ --- (Updated Oct. 10, 2013, 6:29 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- Recently there's been some big changes in the ThreadWeaver API. So big that they break the source compatibility we were supposed to maintain, big time. This patch tries to port plasma-framework to that new API. Diffs - src/plasma/CMakeLists.txt 411256a src/plasma/private/runnerjobs.cpp d11f7e9 src/plasma/private/runnerjobs_p.h 7fd7076 src/plasma/private/storage.cpp 35b222e src/plasma/runnermanager.cpp 135279e src/plasma/scripting/runnerscript.cpp d5142a2 Diff: http://git.reviewboard.kde.org/r/113179/diff/ Testing --- Everything builds, including kde-workspace. Couldn't test it, there's no tests for it or even an application to test it :/. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113155: Port all kde4_add_unit_test uses
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113155/#review41535 --- kfile/tests/CMakeLists.txt http://git.reviewboard.kde.org/r/113155/#comment30344 ecm_add_tests expects the source file to be passed (i.e. kurlnavigatortest.cpp) kio/tests/CMakeLists.txt http://git.reviewboard.kde.org/r/113155/#comment30345 same here kioslave/http/tests/CMakeLists.txt http://git.reviewboard.kde.org/r/113155/#comment30346 same - Alexander Richardson On Oct. 10, 2013, 8:08 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113155/ --- (Updated Oct. 10, 2013, 8:08 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Stop using kde4_add_unit_test. One step less towards no kde4_* uses. Diffs - kded/tests/CMakeLists.txt ca392d2 kfile/tests/CMakeLists.txt d28d642 khtml/tests/CMakeLists.txt 59a0a56 kio/tests/CMakeLists.txt a60eac0 kioslave/http/kcookiejar/tests/CMakeLists.txt cb67f26 kioslave/http/tests/CMakeLists.txt 000c488 Diff: http://git.reviewboard.kde.org/r/113155/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: kio-related build error in plasma-framework
On Friday, October 04, 2013 17:56:52 Sebastian Kügler wrote: I'm getting a build error in a few places in plasma-framework, kio isn't found. I can't seem to figure out why, maybe someone who has a better overview of what in KIO is where, and what I need to tell cmake to figure this out? The error is: /usr/lib64/gcc/x86_64-suse-linux/4.7/../../../../x86_64-suse-linux/bin/ld: cannot find -lkio collect2: error: ld returned 1 exit status I've figured it out: using add_library(...) this fails, using kde4_add_library(...) it succeeds, same for add_executable(...) vs kde4_add_executable(...). It's only needed in a few places, once everything has moved into its final place, we'll just keep it like that. Thanks everybody for the input! -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: update your cmake!
Aurélien Gâteau wrote: On Thursday 10 October 2013 15:17:12 Sebastian Kügler wrote: Hi, In order to build KF5 and Plasma2 code, you have to update your cmake to 2.8.12. Otherwise, you'll get build errors. Oh... this means we can now make use of ALIAS targets and build truly standalone frameworks \o/ I have a way to script that, but it can't be done yet. First decide if the feature-use which requires 2.8.12 is a mistake or not. If not, then update the version requirement in the code. Then I can run my script. Thanks, Steve. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: update your cmake!
On Fri, Oct 11, 2013 at 2:43 AM, Stephen Kelly steve...@gmail.com wrote: Aurélien Gâteau wrote: On Thursday 10 October 2013 15:17:12 Sebastian Kügler wrote: Hi, In order to build KF5 and Plasma2 code, you have to update your cmake to 2.8.12. Otherwise, you'll get build errors. Oh... this means we can now make use of ALIAS targets and build truly standalone frameworks \o/ I have a way to script that, but it can't be done yet. First decide if the feature-use which requires 2.8.12 is a mistake or not. If not, then update the version requirement in the code. Then I can run my script. Thanks, Steve. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel I think we already agreed on depending on 2.8.12. Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
