Re: [kdelibs/frameworks] tier4/kde4support/src/kdeui: Unbreak build
On Friday 08 November 2013 08:23:52 Aurélien Gâteau wrote: Git commit bb9fd7c91ccee66bbd6f4efef944e20c19a23178 by Aurélien Gâteau. Committed on 08/11/2013 at 08:23. Pushed by gateau into branch 'frameworks'. Unbreak build Moc was failing on the KDE4SUPPORT_DEPRECATED macro. I initially tried to just wrap it in a #ifndef KDE_NO_DEPRECATED block, but it still did not like it, so I removed the KDE4SUPPORT_DEPRECATED. What is the proper way to mark a signal deprecated? From kdemacros.h: * It does not make much sense to use the KDE_DEPRECATED keyword for a Qt signal; * this is because usually get called by the class which they belong to, * and one would assume that a class author does not use deprecated methods of * his own class. The only exception to this are signals which are connected to * other signals; they get invoked from moc-generated code. In any case, * printing a warning message in either case is not useful. * For slots, it can make sense (since slots can be invoked directly) but be * aware that if the slots get triggered by a signal, the will get called from * moc code as well and thus the warnings are useless. But Qt (moc) has a solution for us: QT_MOC_COMPAT void mySignal(); -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: [kdelibs/frameworks] tier4/kde4support/src/kdeui: Unbreak build
On Fri, Nov 8, 2013 at 9:23 AM, Aurélien Gâteau agat...@kde.org wrote: Git commit bb9fd7c91ccee66bbd6f4efef944e20c19a23178 by Aurélien Gâteau. Committed on 08/11/2013 at 08:23. Pushed by gateau into branch 'frameworks'. Unbreak build Moc was failing on the KDE4SUPPORT_DEPRECATED macro. I initially tried to just wrap it in a #ifndef KDE_NO_DEPRECATED block, but it still did not like it, so I removed the KDE4SUPPORT_DEPRECATED. Note that currently there's a bug with moc preventing signals with some macros from successfully moc'ing, see https://bugreports.qt-project.org/browse/QTBUG-33668 Cheers -- Martin Klapetek | KDE Developer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113701: Fix KBookmarks standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113701/#review43248 --- Ship it! Ship It! - David Faure On Nov. 7, 2013, 10:38 a.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113701/ --- (Updated Nov. 7, 2013, 10:38 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Fix KBookmarks standalone build. Nothing special. Diffs - superbuild/CMakeLists.txt 90688f6 tier3/kbookmarks/CMakeLists.txt daf2cab tier3/kbookmarks/src/CMakeLists.txt 0346193 Diff: http://git.reviewboard.kde.org/r/113701/diff/ Testing --- Builds alone and as part of kdelibs. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113686: Fix KParts standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113686/#review43252 --- Ship it! Tested, it builds both independently and with the whole repo. - Àlex Fiestas On Nov. 7, 2013, 1:04 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113686/ --- (Updated Nov. 7, 2013, 1:04 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Adds all the dependencies so it can be compiled. Diffs - staging/kio/src/core/kprotocolmanager.h af8c8a8 superbuild/CMakeLists.txt e965cc8 tier3/kparts/CMakeLists.txt 77557bf tier3/kparts/autotests/CMakeLists.txt d47a821 tier3/kparts/src/browserrun.h 9038fd4 tier3/kparts/tests/CMakeLists.txt 1e675f0 Diff: http://git.reviewboard.kde.org/r/113686/diff/ Testing --- Builds, installs, tests still pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113695: Fix KDEWebKit standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113695/#review43253 --- Ship it! Tested, it builds and looks good. - Àlex Fiestas On Nov. 7, 2013, 12:38 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113695/ --- (Updated Nov. 7, 2013, 12:38 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Adds missing dependencies, small other fixes. Diffs - superbuild/CMakeLists.txt 90688f6 tier3/kdewebkit/CMakeLists.txt b56e71d tier3/kdewebkit/src/CMakeLists.txt c48b7ed Diff: http://git.reviewboard.kde.org/r/113695/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113693: Fix KNotifyConfig standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113693/#review43254 --- Ship it! I think this can go in once the comment is changed. - Àlex Fiestas On Nov. 7, 2013, 1:07 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113693/ --- (Updated Nov. 7, 2013, 1:07 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Add the dependencies of dependencies. Small fixes. Diffs - superbuild/CMakeLists.txt 90688f6 tier3/knotifyconfig/CMakeLists.txt 8be2ceb tier3/knotifyconfig/tests/CMakeLists.txt 385ff70 Diff: http://git.reviewboard.kde.org/r/113693/diff/ Testing --- Builds, installs, the test seems to work. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113712: Add popup for window with SkipTaskbar set in kpassivepopuptest
On Nov. 8, 2013, 5:38 a.m., Martin Gräßlin wrote: tier2/knotifications/tests/CMakeLists.txt, line 22 http://git.reviewboard.kde.org/r/113712/diff/1/?file=211813#file211813line22 do you need to link XLib? From the code changes you did it looks like you don't use any XLib call at all. Oh, yes, you're right. I just copied the link arguments from the knotifications library. - Alex --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113712/#review43247 --- On Nov. 7, 2013, 7:03 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113712/ --- (Updated Nov. 7, 2013, 7:03 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Add popup for window with SkipTaskbar set in kpassivepopuptest KPassivePopup should place this next to the window itself. Diffs - tier2/knotifications/tests/kpassivepopuptest.cpp 266842aa336793248663a15e19d4ba22c32ee412 tier2/knotifications/tests/kpassivepopuptest.h c9620b975295be6d59b974824d1cb4e08c860f6f tier2/knotifications/tests/CMakeLists.txt ce87f1752856dcc0b37ef86fb3bfdbdaf4ef5685 tier2/knotifications/src/CMakeLists.txt cf312e028c323521504bd9ccd4c8f3f817e13497 tier2/knotifications/CMakeLists.txt 6df0022536436477cc9cd875e0bccd70e78d32d3 Diff: http://git.reviewboard.kde.org/r/113712/diff/ Testing --- Builds, runs, new test does the right thing. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113712: Add popup for window with SkipTaskbar set in kpassivepopuptest
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113712/ --- (Updated Nov. 8, 2013, 12:12 p.m.) Review request for KDE Frameworks. Changes --- Remove X11 libs from target_link_libraries. Repository: kdelibs Description --- Add popup for window with SkipTaskbar set in kpassivepopuptest KPassivePopup should place this next to the window itself. Diffs (updated) - tier2/knotifications/tests/kpassivepopuptest.cpp 266842aa336793248663a15e19d4ba22c32ee412 tier2/knotifications/tests/kpassivepopuptest.h c9620b975295be6d59b974824d1cb4e08c860f6f tier2/knotifications/tests/CMakeLists.txt ce87f1752856dcc0b37ef86fb3bfdbdaf4ef5685 tier2/knotifications/src/CMakeLists.txt cf312e028c323521504bd9ccd4c8f3f817e13497 tier2/knotifications/CMakeLists.txt 6df0022536436477cc9cd875e0bccd70e78d32d3 Diff: http://git.reviewboard.kde.org/r/113712/diff/ Testing --- Builds, runs, new test does the right thing. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113694: Fix KNewStuff standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113694/#review43256 --- Ship it! Looks good, builds standalone and with frameworks. - Àlex Fiestas On Nov. 7, 2013, 1:04 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113694/ --- (Updated Nov. 7, 2013, 1:04 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Adds dependencies to make sure KNewStuff can be compiled alone Diffs - superbuild/CMakeLists.txt 90688f6 tier3/knewstuff/CMakeLists.txt f7f4dfa Diff: http://git.reviewboard.kde.org/r/113694/diff/ Testing --- Builds and installs. All tests are commented out. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: [kdelibs/frameworks] tier4/kde4support/src/kdeui: Unbreak build
On Fri, 8 Nov 2013 09:59:37 +0100, Martin Klapetek wrote: On Fri, Nov 8, 2013 at 9:23 AM, Aurélien Gâteau wrote: Git commit bb9fd7c91ccee66bbd6f4efef944e20c19a23178 by Aurélien Gâteau. Committed on 08/11/2013 at 08:23. Pushed by gateau into branch 'frameworks'. Unbreak build Moc was failing on the KDE4SUPPORT_DEPRECATED macro. I initially tried to just wrap it in a #ifndef KDE_NO_DEPRECATED block, but it still did not like it, so I removed the KDE4SUPPORT_DEPRECATED. Note that currently there's a bug with moc preventing signals with some macros from successfully moc'ing, see https://bugreports.qt-project.org/browse/QTBUG-33668 [2] Looks like the patch proposed by Olivier would fix the build issue. Good news! Aurélien ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113702: Fix KEmoticons standalone build
On Nov. 7, 2013, 1:47 p.m., Aurélien Gâteau wrote: superbuild/CMakeLists.txt, line 34 http://git.reviewboard.kde.org/r/113702/diff/1/?file=211375#file211375line34 kemoticons should be listed after kservice, otherwise superbuild won't pick up the standalone version of it. /me goes documenting this Maarten De Meyer wrote: Yes. I noticed when making superbuild. Already fixed here. Do you want me to upload a new diff? No it's OK, I trust you. - Aurélien --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113702/#review43216 --- On Nov. 7, 2013, 11:47 a.m., Maarten De Meyer wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113702/ --- (Updated Nov. 7, 2013, 11:47 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Make KEmoticons build standalone. Diffs - superbuild/CMakeLists.txt 90688f6 tier3/kemoticons/CMakeLists.txt bc2812b tier3/kemoticons/autotests/CMakeLists.txt c88a288 tier3/kemoticons/src/core/CMakeLists.txt 556d9bb Diff: http://git.reviewboard.kde.org/r/113702/diff/ Testing --- Builds. KCoreAddons is pulled in by KService Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113702: Fix KEmoticons standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113702/#review43260 --- Ship it! Ship It! - Aurélien Gâteau On Nov. 7, 2013, 11:47 a.m., Maarten De Meyer wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113702/ --- (Updated Nov. 7, 2013, 11:47 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Make KEmoticons build standalone. Diffs - superbuild/CMakeLists.txt 90688f6 tier3/kemoticons/CMakeLists.txt bc2812b tier3/kemoticons/autotests/CMakeLists.txt c88a288 tier3/kemoticons/src/core/CMakeLists.txt 556d9bb Diff: http://git.reviewboard.kde.org/r/113702/diff/ Testing --- Builds. KCoreAddons is pulled in by KService Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113701: Fix KBookmarks standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113701/ --- (Updated Nov. 8, 2013, 3:13 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Fix KBookmarks standalone build. Nothing special. Diffs - superbuild/CMakeLists.txt 90688f6 tier3/kbookmarks/CMakeLists.txt daf2cab tier3/kbookmarks/src/CMakeLists.txt 0346193 Diff: http://git.reviewboard.kde.org/r/113701/diff/ Testing --- Builds alone and as part of kdelibs. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113701: Fix KBookmarks standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113701/#review43263 --- This review has been submitted with commit 015062773ed6afa9cc98eb1d692b3aee9bf6fb82 by Aurélien Gâteau to branch frameworks. - Commit Hook On Nov. 7, 2013, 10:38 a.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113701/ --- (Updated Nov. 7, 2013, 10:38 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Fix KBookmarks standalone build. Nothing special. Diffs - superbuild/CMakeLists.txt 90688f6 tier3/kbookmarks/CMakeLists.txt daf2cab tier3/kbookmarks/src/CMakeLists.txt 0346193 Diff: http://git.reviewboard.kde.org/r/113701/diff/ Testing --- Builds alone and as part of kdelibs. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112896: Rework NETWM classes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112896/ --- (Updated Nov. 8, 2013, 4:14 p.m.) Review request for KDE Frameworks. Changes --- rebased the unit tests on top of Fredrik's NETWM branch and thus I recommend to merge the NETWM branch into frameworks. In addtion to the unit tests I added the following commits: commit b1cc24532261ee3619f2d40de6fe1b9ab3e313ce Author: Martin Gräßlin mgraess...@kde.org Date: Fri Nov 8 16:02:18 2013 +0100 Porting notes for NETRootInfo and NETWinInfo commit 59fab80a735d78c093090363244dd28da6ebeb4f Author: Martin Gräßlin mgraess...@kde.org Date: Fri Nov 8 15:51:26 2013 +0100 Pass xcb connection into ctor of NETRootInfo and NETWinInfo With that the last usage of XLib inside netwm is gone. Note: this is a source incompatible change. commit 0b4be85851e22fc9265cefd78dc3046c338a368c Author: Martin Gräßlin mgraess...@kde.org Date: Fri Nov 8 15:06:12 2013 +0100 Use xcb types instead of XLib types in netwm API (NETRootInfo, NETWinInfo) Window - xcb_window_t Time - xcb_timestamp_t Atom - xcb_atom_t Inheriting classes need to adjust. commit 239ad5baebaae942b0081b90106769758cfb3f4e Author: Martin Gräßlin mgraess...@kde.org Date: Fri Nov 8 13:07:15 2013 +0100 Fix NETWinInfo::setVisibleName copy'n'paste error. commit 087d0337a70e0cba918f17fa70de67fc7149b016 Author: Martin Gräßlin mgraess...@kde.org Date: Mon Sep 16 14:06:49 2013 +0200 Use bool/true/false instead of Bool/True/False in netwm For our internal API we can just use the proper datatypes instead of the XLib macros. commit 855d1639d1c87a788773d4dd65cda51655c2e1bf Author: Martin Gräßlin mgraess...@kde.org Date: Fri Nov 8 12:44:38 2013 +0100 Fix NETWinInfo::setBlockingCompositing Property needs to be set on window, not on the root window. commit 424861da0c25982f2ed9faa23f86227ba9ac0a57 Author: Martin Gräßlin mgraess...@kde.org Date: Thu Sep 19 07:20:57 2013 +0200 Merge NETWinInfo2 into NETWinInfo Class only existed for BIC changes and had a TODO remove KDE5 marker. commit adbc10ac322b5955aa1c11576fda1c0a4283abf4 Author: Martin Gräßlin mgraess...@kde.org Date: Fri Nov 8 12:24:05 2013 +0100 Remove NETRootInfo::screenNumber The screen number is no longer set, so let's remove it. commit fdaa0eea057d2b6a6511536ef59b466ae0ba5329 Author: Martin Gräßlin mgraess...@kde.org Date: Thu Sep 19 07:16:00 2013 +0200 Drop desktop argument from NETRootInfo::(set)DesktopGeometry The desktop argument was only there because of a different semantic in an early draft of NETwm and completely unused. Doesn't make sense to carry it into the next version. commit ca7f5087b4a1a1fc4deab22c66ba8f991d1594ea Author: Martin Gräßlin mgraess...@kde.org Date: Wed Sep 18 13:47:16 2013 +0200 NETRootInfo opperates on WindowTypeMask not on WindowType ::isSupported and ::setSupported for WindowType operated on the wrong type. This needs to be the mask. This will be a source incompatible change. I will take care of adjusting downstream usages (e.g. plasma, kde-workspace) when this goes in. Repository: kdelibs Description --- This is a patch series, if needed I can push the branch. The patches address the following topics: * add unit tests for NETRootInfo and NETWinInfo which do not require a running window manager. Test coverage of netwm.h is: ** line coverage: 75 % ** functions coverage: 84 % ** branch coverage: 62 % The tests start their own Xvfb to have a clean state and not mess up with the Window Manager of a user or cause followint tests to fail on the CI system * areas which are covered by unit tests are changed from XLib to XCB. This mostly affects changing and reading window properties * API is changed from XLib types to XCB types. E.g. xcb_window_t instead of Window. Note: this is an API break, which I consider as necessary, given that especially the type Window is problematic. * several bugs which were discovered through the added tests are fixed * NETWinInfo2 is merged into NETWinInfo (marked as TODO KDE5) * Small wrapper class for intern atom added to KXUtils. Similar code already in usage in KWin. = Commits: commit 2e50845a5d0df436106aeb776e3936691c32a753 Author: Martin Gräßlin mgraess...@kde.org Date: Mon Sep 23 14:31:42 2013 +0200 Use XCB for reading properties in NETRootInfo::update Viewport handling was incorrect and is adjusted to be read correctly. commit 23887726c03c49b4e0021c01f319653d3b9f36c5 Author: Martin Gräßlin mgraess...@kde.org Date: Mon Sep 23 11:41:26 2013 +0200 Use XCB for reading properties in NETWinInfo::update Those areas which are covered by unit tests are migrated from XGetWindowProperty to
Re: Review Request 113670: Link kde4support privately to QtX11Extras, QtSvg and QtTest
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113670/#review43271 --- Please use X11 stuff conditionally (Q_WS_X11). - Andrius da Costa Ribas On Nov. 7, 2013, 8:33 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113670/ --- (Updated Nov. 7, 2013, 8:33 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Link kde4support privately to QtX11Extras, QtSvg and QtTest Otherwise every user of the target KF5::KDE4Support will also have Qt5::X11Extras Qt5::Svg Qt5::Test linked. This can cause linker errors like ld: cannot find -lQt5::Test REVIEW: 113670 Diffs - tier4/kde4support/src/kdeui/kxerrorhandler.cpp 3f4765d03559c99833c573fe0e0072bc9973b973 tier4/kde4support/src/kdeui/kxerrorhandler.h babf931e8a750d405885f02443f4910356511429 tier4/kde4support/src/CMakeLists.txt cbfac3e9e4363cb66d0941c9048d8f501311084c Diff: http://git.reviewboard.kde.org/r/113670/diff/ Testing --- I previously got the following error compiling okteta, now it works: /usr/lib64/gcc/x86_64-suse-linux/4.7/../../../../x86_64-suse-linux/bin/ld: cannot find -lQt5::X11Extras /usr/lib64/gcc/x86_64-suse-linux/4.7/../../../../x86_64-suse-linux/bin/ld: cannot find -lQt5::Svg QtX11Info and QtSvg are not used in any installed headers, so IMO this should be fine qtest_kde.h does actually include QtTest headers, but only uses these types inside macros. And I guess any user of that header already also links to QtTest Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113723: Fix KIO to build standalone, prepare for moving into its tier
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113723/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- As you will see, this splitting was a bit harder than others: - KIO was using a couple of private headers from kjobwidgets, which now they will be installed. - The xslt_kde target was being used from KDocTools without having it exported. Now it will be properly exported. - Also defines all dependencies so it can be compiled independently, modularization is done as well. Diffs - tier2/kdoctools/src/CMakeLists.txt 3940e98 tier2/kdoctools/KDocToolsConfig.cmake.in PRE-CREATION tier2/kdoctools/KDocToolsConfig.cmake d501dc8 tier2/kdoctools/CMakeLists.txt c2256ff superbuild/CMakeLists.txt 458fb4c tier1/kcoreaddons/src/lib/CMakeLists.txt fad55c5 staging/kio/tests/CMakeLists.txt 6cee291 staging/kio/src/widgets/CMakeLists.txt d90386d staging/kio/src/ioslaves/http/tests/CMakeLists.txt 52c9f6c staging/kio/src/ioslaves/http/kcookiejar/CMakeLists.txt b0feff6 staging/kio/src/ioslaves/help/CMakeLists.txt 40637dc staging/kio/src/filewidgets/CMakeLists.txt 31fe8c6 staging/kio/CMakeLists.txt 6c7297e cmake/modules/FindGSSAPI.cmake cmake/modules/CMakeLists.txt 7910270 tier3/kded/KDEDConfig.cmake.in 32f8d56 tier3/kservice/src/CMakeLists.txt cc0c1a4 Diff: http://git.reviewboard.kde.org/r/113723/diff/ Testing --- Builds, Installs, tests still pass; both modularized and monolithic kdelibs. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113702: Fix KEmoticons standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113702/#review43278 --- This review has been submitted with commit 62fb092823ca5c7ca38010d2146ee1af489036b2 by Maarten De Meyer to branch frameworks. - Commit Hook On Nov. 7, 2013, 10:47 a.m., Maarten De Meyer wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113702/ --- (Updated Nov. 7, 2013, 10:47 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Make KEmoticons build standalone. Diffs - superbuild/CMakeLists.txt 90688f6 tier3/kemoticons/CMakeLists.txt bc2812b tier3/kemoticons/autotests/CMakeLists.txt c88a288 tier3/kemoticons/src/core/CMakeLists.txt 556d9bb Diff: http://git.reviewboard.kde.org/r/113702/diff/ Testing --- Builds. KCoreAddons is pulled in by KService Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113702: Fix KEmoticons standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113702/ --- (Updated Nov. 8, 2013, 7:41 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Make KEmoticons build standalone. Diffs - superbuild/CMakeLists.txt 90688f6 tier3/kemoticons/CMakeLists.txt bc2812b tier3/kemoticons/autotests/CMakeLists.txt c88a288 tier3/kemoticons/src/core/CMakeLists.txt 556d9bb Diff: http://git.reviewboard.kde.org/r/113702/diff/ Testing --- Builds. KCoreAddons is pulled in by KService Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113703: Fix KRoss standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113703/#review43280 --- This review has been submitted with commit 1bab5c4c483aed3e863b25f5a81b52f501be63fc by Maarten De Meyer to branch frameworks. - Commit Hook On Nov. 7, 2013, 1:45 p.m., Maarten De Meyer wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113703/ --- (Updated Nov. 7, 2013, 1:45 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Make kross build standalone. Diffs - tier3/kross/CMakeLists.txt 440edf2 tier3/kross/src/modules/CMakeLists.txt 198cb04 Diff: http://git.reviewboard.kde.org/r/113703/diff/ Testing --- Builds. Not added to superbuild. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113703: Fix KRoss standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113703/ --- (Updated Nov. 8, 2013, 8:16 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Make kross build standalone. Diffs - tier3/kross/CMakeLists.txt 440edf2 tier3/kross/src/modules/CMakeLists.txt 198cb04 Diff: http://git.reviewboard.kde.org/r/113703/diff/ Testing --- Builds. Not added to superbuild. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113670: Link kde4support privately to QtX11Extras, QtSvg and QtTest
On Nov. 8, 2013, 4:25 p.m., Andrius da Costa Ribas wrote: Please use X11 stuff conditionally (Q_WS_X11). There's no need to put conditionals in the file (since the whole thing is conditionally compiled), but the linking should be done conditionally. Specifically, you should take Qt5::X11Extras out of the target_link_libraries, and put it in its own call wrapped in X11_FOUND, like if (X11_FOUND) target_link_libraries(KDE4Support PRIVATE Qt5::X11Extras) endif () Or, even better, find the conditional where kxerrorhandler is added to libkde4support_SRCS, and add Qt5::X11Extras to libkd4support_OPTIONAL_LIBS in that same conditional. - Alex --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113670/#review43271 --- On Nov. 7, 2013, 8:33 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113670/ --- (Updated Nov. 7, 2013, 8:33 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Link kde4support privately to QtX11Extras, QtSvg and QtTest Otherwise every user of the target KF5::KDE4Support will also have Qt5::X11Extras Qt5::Svg Qt5::Test linked. This can cause linker errors like ld: cannot find -lQt5::Test REVIEW: 113670 Diffs - tier4/kde4support/src/kdeui/kxerrorhandler.cpp 3f4765d03559c99833c573fe0e0072bc9973b973 tier4/kde4support/src/kdeui/kxerrorhandler.h babf931e8a750d405885f02443f4910356511429 tier4/kde4support/src/CMakeLists.txt cbfac3e9e4363cb66d0941c9048d8f501311084c Diff: http://git.reviewboard.kde.org/r/113670/diff/ Testing --- I previously got the following error compiling okteta, now it works: /usr/lib64/gcc/x86_64-suse-linux/4.7/../../../../x86_64-suse-linux/bin/ld: cannot find -lQt5::X11Extras /usr/lib64/gcc/x86_64-suse-linux/4.7/../../../../x86_64-suse-linux/bin/ld: cannot find -lQt5::Svg QtX11Info and QtSvg are not used in any installed headers, so IMO this should be fine qtest_kde.h does actually include QtTest headers, but only uses these types inside macros. And I guess any user of that header already also links to QtTest Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
kdelibs/interfaces/khexedit
Hi Friedrich, I'm looking at interfaces/khexedit in kdelibs-frameworks, and wondering what to do with it. Are you still happy with it? Should we bring it into the KF5 world? If so, we need to find a place for it. It's only header files so it could be installed by any framework without any additional cost for the framework. The only dependency seems to be on kservicetypetrader.h, so we could move the whole set of headers to the KService framework. Seems that the only implementor of the service is okteta, and the only user of the service is kdevelop. But apart from a direct dependency of kdevelop on okteta, or fragile dynamic stuff (invokeMethod etc.), I admit that I don't see a better solution. Input welcome. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113723: Fix KIO to build standalone, prepare for moving into its tier
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113723/#review43285 --- staging/kio/CMakeLists.txt http://git.reviewboard.kde.org/r/113723/#comment31176 already listed 6 lines above staging/kio/CMakeLists.txt http://git.reviewboard.kde.org/r/113723/#comment31180 Why? KDED doesn't provide a library. staging/kio/CMakeLists.txt http://git.reviewboard.kde.org/r/113723/#comment31175 already listed 3 lines before. staging/kio/CMakeLists.txt http://git.reviewboard.kde.org/r/113723/#comment31181 needed? tier1/kcoreaddons/src/lib/CMakeLists.txt http://git.reviewboard.kde.org/r/113723/#comment31179 I agree about this one. tier1/kcoreaddons/src/lib/CMakeLists.txt http://git.reviewboard.kde.org/r/113723/#comment31178 I think we should instead treat them as separate libs, and remove the inheritance from KCompositeJobPrivate in KIO::JobPrivate. It's just an optimization. We don't want to break BIC in an existing libkio if we ever change kcoreaddons' private classes. (Unless we can guarantee that they are always the same version - like Qt does, but the difference is that they don't need to install private headers for this; and they have a runtime check for version mismatches). All in all, I think an extra call to new per kio job is the simplest solution; a kio job takes much longer than that anyway. tier3/kservice/src/CMakeLists.txt http://git.reviewboard.kde.org/r/113723/#comment31177 Why? My grepping for KServiceOffer says that it's only used in the kservice framework. - David Faure On Nov. 8, 2013, 5:01 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113723/ --- (Updated Nov. 8, 2013, 5:01 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- As you will see, this splitting was a bit harder than others: - KIO was using a couple of private headers from kjobwidgets, which now they will be installed. - The xslt_kde target was being used from KDocTools without having it exported. Now it will be properly exported. - Also defines all dependencies so it can be compiled independently, modularization is done as well. Diffs - tier2/kdoctools/src/CMakeLists.txt 3940e98 tier2/kdoctools/KDocToolsConfig.cmake.in PRE-CREATION tier2/kdoctools/KDocToolsConfig.cmake d501dc8 tier2/kdoctools/CMakeLists.txt c2256ff superbuild/CMakeLists.txt 458fb4c tier1/kcoreaddons/src/lib/CMakeLists.txt fad55c5 staging/kio/tests/CMakeLists.txt 6cee291 staging/kio/src/widgets/CMakeLists.txt d90386d staging/kio/src/ioslaves/http/tests/CMakeLists.txt 52c9f6c staging/kio/src/ioslaves/http/kcookiejar/CMakeLists.txt b0feff6 staging/kio/src/ioslaves/help/CMakeLists.txt 40637dc staging/kio/src/filewidgets/CMakeLists.txt 31fe8c6 staging/kio/CMakeLists.txt 6c7297e cmake/modules/FindGSSAPI.cmake cmake/modules/CMakeLists.txt 7910270 tier3/kded/KDEDConfig.cmake.in 32f8d56 tier3/kservice/src/CMakeLists.txt cc0c1a4 Diff: http://git.reviewboard.kde.org/r/113723/diff/ Testing --- Builds, Installs, tests still pass; both modularized and monolithic kdelibs. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Question about kimproxy
Hi Will, I'm looking at interfaces/kimproxy in kdelibs, which has your copyright. http://lxr.kde.org/ident?i=KIMProxy says that it's now unused in all of KDE SC, the only user is playground/pim/leute/services/imaddress/ but an interface requires a provider and a user anyway, so surely this isn't even enough to make it useful. Is it OK if I just kill kimproxy in KF5? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
the kspeech interface
Hi Jeremy, I'm looking at kdelibs-frameworks/interface/kspeech, and trying to find a home for it, in the KF5 reorganization. I see that it's actually used in a number of places (http://lxr.kde.org/ident?i=soPlainText for instance). and that it's basically just a header file that depends only on QtCore, plus some data files (dbus xml, desktop file). Are you still happy with that interface? Any idea where it would belong, in KF5? Maybe in kdbusaddons, since it's only usable with a dbus dependency? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: the kspeech interface
I was actually wondering that myself the other day as I added to it in kdelibs master (that got branched into KDE/4.12) for a feature that hit jovie in KDE SC 4.12. It's used but really only needed to expose jovie's dbus interface for applications to use. Interestingly, knotify uses jovie but doesn't include kspeech.h somehow. Could we move the dbus interface into kdeaccessibility/jovie and install it only when jovie is installed, and use the dbus interface the same way it is used in knotify in the places it's currently used directly? Jeremy On Fri, Nov 8, 2013 at 5:53 PM, David Faure fa...@kde.org wrote: Hi Jeremy, I'm looking at kdelibs-frameworks/interface/kspeech, and trying to find a home for it, in the KF5 reorganization. I see that it's actually used in a number of places (http://lxr.kde.org/ident?i=soPlainText for instance). and that it's basically just a header file that depends only on QtCore, plus some data files (dbus xml, desktop file). Are you still happy with that interface? Any idea where it would belong, in KF5? Maybe in kdbusaddons, since it's only usable with a dbus dependency? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: the kspeech interface
Oops, that link was just users of soPlainText. It seems http://lxr.kde.org/ident?i=KSpeech the class itself is used in quite a few places, and is how any application uses speech capabilities. I guess kdbusaddons is as good a place as any for it and it will need to stay in kdelibs itself. On Fri, Nov 8, 2013 at 10:40 PM, Jeremy Whiting jpwhit...@kde.org wrote: I was actually wondering that myself the other day as I added to it in kdelibs master (that got branched into KDE/4.12) for a feature that hit jovie in KDE SC 4.12. It's used but really only needed to expose jovie's dbus interface for applications to use. Interestingly, knotify uses jovie but doesn't include kspeech.h somehow. Could we move the dbus interface into kdeaccessibility/jovie and install it only when jovie is installed, and use the dbus interface the same way it is used in knotify in the places it's currently used directly? Jeremy On Fri, Nov 8, 2013 at 5:53 PM, David Faure fa...@kde.org wrote: Hi Jeremy, I'm looking at kdelibs-frameworks/interface/kspeech, and trying to find a home for it, in the KF5 reorganization. I see that it's actually used in a number of places (http://lxr.kde.org/ident?i=soPlainText for instance). and that it's basically just a header file that depends only on QtCore, plus some data files (dbus xml, desktop file). Are you still happy with that interface? Any idea where it would belong, in KF5? Maybe in kdbusaddons, since it's only usable with a dbus dependency? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
