Review Request 114524: Load the kdoctools macro before trying to find the build deps

[Christophe Giboudeaux]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114524/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Tiny fix for kdoctools.

While trying to build the split frameworks, the ones calling kdoctools were 
failing because find_dependency was called before including 
KF5DocToolsTargets.cmake.

If find_dependency is called before, the PACKAGE_PREFIX_DIR gets changed to 
point to the dependency install dir.
This causes build issues if kdoctools is installed in a different prefix since 
KDOCTOOLS_CUSTOMIZATION_DIR will have an incorrect value.


Diffs
-

  tier2/kdoctools/KF5DocToolsConfig.cmake.in 94ad675 

Diff: http://git.reviewboard.kde.org/r/114524/diff/


Testing
---

Built and installed all the framework modules in different prefixes without 
issue.

The commit is already in the split kdoctools repo.


Thanks,

Christophe Giboudeaux

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Let's get in release mode!

[Ben Cooksley]

On Tue, Dec 17, 2013 at 11:47 PM, Martin Klapetek  wrote:

> On Tue, Dec 17, 2013 at 11:39 AM, David Faure  wrote:
>
>> On Tuesday 17 December 2013 23:27:39 Ben Cooksley wrote:
>> > Other than apidox, I was also concerned about frameworkintegration,
>> > itemmodels, itemviews and dnssd. The rest of the names are quite
>> > descriptive as to what they contain and are fine.
>>
>> Yeah, itemmodels and itemviews often come up as not descriptive enough,
>> but nobody has fixed that. What could we do? kf5itemmodels, kf5itemviews?
>>
>
> Fwiw, I'd suggest to remove the "5" from repo name, because when we'll do
> kf6 (couple years away, but still..), we'll have to either rename the repos
> again or create set of new repos.
>

I have now re-split kdelibs, updated repositories can be found in the usual
place.
One new conflict did come up - kdnssd is already taken, so it was called
kdnssd-framework instead.



>
> Cheers
> --
> Martin Klapetek | KDE Developer
>

Thanks,
Ben


>
> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>
>
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : plasma-framework_master_qt5 #972

[KDE CI System]

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #971

[KDE CI System]

See 

Changes:

[sebas] Fix borders in dialog depending on location

--
[...truncated 320 lines...]
:0:
 Note: No relevant classes found. No output generated.
Generating moc_platformstatus.cpp
[ 13%] Built target kded_platformstatus_automoc
Scanning dependencies of target packageurlinterceptortest_automoc
Generating moc_calendarplugin.cpp
Generating moc_calendar.cpp
Generating moc_calendardata.cpp
Generating moc_daysmodel.cpp
[ 13%] Built target calendarplugin_automoc
[ 14%] Automatic moc for target packageurlinterceptortest
Scanning dependencies of target plasma-shell_automoc
[ 15%] Automatic moc for target plasma-shell
Generating qtextracomponentsplugin.moc
:0:
 Note: No relevant classes found. No output generated.
Generating dialog.moc
:0:
 Note: No relevant classes found. No output generated.
Generating moc_packageurlinterceptortest.cpp
[ 15%] Built target packageurlinterceptortest_automoc
Scanning dependencies of target plasma_dataengine_example_simpleEngine_automoc
[ 15%] Generating private/moc_dataengineconsumer_p.cpp
Generating moc_datamodel.cpp
Generating moc_datasource.cpp
Generating moc_sortfiltermodeltest.cpp
Automatic moc for target plasma_dataengine_example_simpleEngine
[ 15%] Generating activity.moc
:0:
 Note: No relevant classes found. No output generated.
Built target sortfiltermodeltest_automoc
Generating moc_qmenu.cpp
Generating moc_qmenuitem.cpp
Generating moc_qrangemodel.cpp
Generating moc_units.cpp
[ 15%] Scanning dependencies of target 
plasma_dataengine_example_sourcesOnRequest_automoc
Built target plasmacomponentsplugin_automoc
[ 16%] Automatic moc for target plasma_dataengine_example_sourcesOnRequest
Generating moc_dialogshadows_p.cpp
Generating framesvgitem.moc
:0:
 Note: No relevant classes found. No output generated.
Generating moc_configmodel.cpp
Generating moc_configview.cpp
Generating moc_plasmaquickview.cpp
Generating private/moc_configcategory_p.cpp
[ 16%] Scanning dependencies of target 
plasma_dataengine_example_customDataContainers_automoc
Built target KF5PlasmaQuick_automoc
[ 17%] Automatic moc for target plasma_dataengine_example_customDataContainers
Scanning dependencies of target dirmodelplugin
Generating simpleEngine.moc
Generating moc_simpleEngine.cpp
[ 17%] Building CXX object 
src/declarativeimports/dirmodel/CMakeFiles/dirmodelplugin.dir/dirmodel.cpp.o
[ 17%] Generating moc_appletinterface.cpp
Generating moc_containmentinterface.cpp
Generating declarativeappletscript.moc
QIODevice::read: device not open
Built target plasma_dataengine_example_simpleEngine_automoc
Generating iconitem.moc
:0:
 Note: No relevant classes found. No output generated.
Generating sourcesOnRequest.moc
Generating moc_sourcesOnRequest.cpp
[ 18%] [ 18%] Built target plasma_dataengine_example_sourcesOnRequest_automoc
Building CXX object 
src/declarativeimports/dirmodel/CMakeFiles/dirmodelplugin.dir/dirmodelplugin.cpp.o
Generating serviceoperationstatus.moc
:0:
 Note: No relevant classes found. No output generated.
Scanning dependencies of target draganddropplugin
Generating customDataContainersEngine.moc
Generating httpContainer.moc
:0:
 Note: No relevant classes found. No output generated.
[ 18%] Building CXX object 
src/declarativeimports/draganddrop/CMakeFiles/draganddropplugin.dir/draganddropplugin.cpp.o
Generating moc_columnproxymodel.cpp
Generating moc_mouseeventlistener.cpp
Generating moc_qiconitem.cpp
Generating moc_qimageitem.cpp
Generating moc_qpixmapitem.cpp
Generating moc_qtextracomponentsplugin.cpp
[ 18%] Built target qtextracomponentsplugin_automoc
[ 18%] Building CXX object 
src/declarativeimports/dirmodel/CMakeFiles/dirmodelplugin.dir/dirmodelplugin_automoc.cpp.o
Generating svgitem.moc
:0:
 Note: No relevant classes found. No output generated.
Generating moc_wallpaperinterface.cpp
Generating moc_declarativeappletscript.cpp
[ 18%] Built target plasma_appletscript_declarative_automoc
[ 19%] [ 19%] Building CXX object 
src/declarativeimports/draganddrop/CMake

Re: Review Request 114478: Add kshareddatacache.h include

[Albert Astals Cid]

> On Dec. 15, 2013, 9:22 p.m., Kevin Ottens wrote:
> > It is in fact intended that way as kguiaddons isn't supposed to include 
> > stuff coming from kcoreaddons (yeah I know it's slightly convoluted in that 
> > particular case).
> 
> Albert Astals Cid wrote:
> So basically we have a header that when you include it, it breaks your 
> compilation. Do you really think this is a good idea?
> 
> Alex Merry wrote:
> If KSharedPixmapCacheMixin is never intended to be used directly, but 
> only via KImageCache, I think we should really have the #include; not having 
> KGuiAddons depend on KCoreAddons is one thing, but that header is useless 
> without KSharedDataCache.
> 
> Essentially, the current way is broken unless you add a non-obvious 
> KSharedDataCache include to your code, regardless of whether you have 
> KCoreAddons added to your project.  Albert's suggestion would make the common 
> case work (where you have KCoreAddons).
> 
> Of course, there are other tricks you could pull, such as having the 
> KF5::CoreAddons target add -DHAS_K_SHARED_DATA_CACHE to the compiler flags, 
> and only do the #include in the presence of that define.
> 
> Kevin Ottens wrote:
> I actually like this last suggestion.
> 
> Alex Merry wrote:
> Something for after the split, though.

Really? So how the process works for a random developer that wants to use 
KImageCache work? Go to apidocs, see that he has to link against KGuiAddons and 
#include "kimagecache.h".

He does so.

He doesn't get KImageCache because he's not linking against KCoreAddons

He gives up, buys a beer and watches some TV.

Now seriosuly, if KImageCache depends on kcoreaddons, why is it not in a tier 
that can make it depend on kcoreaddons?


- Albert


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114478/#review45732
---


On Dec. 15, 2013, 4:15 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114478/
> ---
> 
> (Updated Dec. 15, 2013, 4:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Since
> #define KImageCache KSharedPixmapCacheMixin
> I think it is only fair that kimagecache.h includes kshareddatacache.h 
> otherwise a 
> #include 
> is not enough to use it.
> 
> 
> Diffs
> -
> 
>   tier1/kguiaddons/src/util/kimagecache.h 682aa66 
> 
> Diff: http://git.reviewboard.kde.org/r/114478/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Let's get in release mode!

[Cornelius Schumacher]

On Tuesday 17 December 2013 Kevin Ottens wrote:
> 
> That's an option. We could also see if we could make inqlude.org job
> easier, I guess it uses a similar input format too.

Yes, inqlude.org uses a similar meta file, but I would argue it's more simple, 
and we have full control about it. I was actually planning to look into adding 
inqlude manifests to the frameworks repositories, but wanted to wait with 
putting up a patch for review until after the split.

-- 
Cornelius Schumacher 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #970

[KDE CI System]

See 

Changes:

[sebas] constness++

--
[...truncated 320 lines...]
Generating units.moc
:0:
 Note: No relevant classes found. No output generated.
Generating moc_platformstatus.cpp
[ 13%] Built target kded_platformstatus_automoc
Scanning dependencies of target packageurlinterceptortest_automoc
Generating moc_calendarplugin.cpp
Generating moc_calendar.cpp
Generating moc_calendardata.cpp
Generating moc_daysmodel.cpp
[ 14%] [ 14%] Generating qtextracomponentsplugin.moc
:0:
 Note: No relevant classes found. No output generated.
Built target calendarplugin_automoc
Automatic moc for target packageurlinterceptortest
Scanning dependencies of target plasma-shell_automoc
[ 15%] Automatic moc for target plasma-shell
Generating dialog.moc
:0:
 Note: No relevant classes found. No output generated.
Generating moc_packageurlinterceptortest.cpp
[ 15%] Built target packageurlinterceptortest_automoc
Scanning dependencies of target plasma_dataengine_example_simpleEngine_automoc
[ 15%] Automatic moc for target plasma_dataengine_example_simpleEngine
Generating private/moc_dataengineconsumer_p.cpp
Generating moc_datamodel.cpp
Generating moc_datasource.cpp
Generating moc_sortfiltermodeltest.cpp
[ 15%] Built target sortfiltermodeltest_automoc
Scanning dependencies of target 
plasma_dataengine_example_sourcesOnRequest_automoc
[ 16%] Automatic moc for target plasma_dataengine_example_sourcesOnRequest
Generating activity.moc
:0:
 Note: No relevant classes found. No output generated.
Generating moc_qmenu.cpp
Generating moc_qmenuitem.cpp
Generating moc_qrangemodel.cpp
Generating moc_units.cpp
[ 16%] Generating moc_configmodel.cpp
Generating moc_configview.cpp
Generating moc_plasmaquickview.cpp
Generating private/moc_configcategory_p.cpp
Built target plasmacomponentsplugin_automoc
[ 16%] Scanning dependencies of target 
plasma_dataengine_example_customDataContainers_automoc
Built target KF5PlasmaQuick_automoc
Generating moc_dialogshadows_p.cpp
Generating framesvgitem.moc
:0:
 Note: No relevant classes found. No output generated.
[ 17%] Automatic moc for target plasma_dataengine_example_customDataContainers
Generating simpleEngine.moc
Generating moc_simpleEngine.cpp
[ 17%] Built target plasma_dataengine_example_simpleEngine_automoc
Generating sourcesOnRequest.moc
Generating moc_sourcesOnRequest.cpp
[ 17%] Built target plasma_dataengine_example_sourcesOnRequest_automoc
Scanning dependencies of target dirmodelplugin
Generating moc_appletinterface.cpp
Generating moc_containmentinterface.cpp
Generating declarativeappletscript.moc
QIODevice::read: device not open
[ 17%] Scanning dependencies of target draganddropplugin
[ 17%] Building CXX object 
src/declarativeimports/dirmodel/CMakeFiles/dirmodelplugin.dir/dirmodel.cpp.o
Building CXX object 
src/declarativeimports/draganddrop/CMakeFiles/draganddropplugin.dir/draganddropplugin.cpp.o
Generating iconitem.moc
:0:
 Note: No relevant classes found. No output generated.
Scanning dependencies of target fullmodelaccesstest
[ 18%] Building CXX object 
src/declarativeimports/qtextracomponents/tests/CMakeFiles/fullmodelaccesstest.dir/columnproxymodeltest.cpp.o
Generating customDataContainersEngine.moc
Generating httpContainer.moc
:0:
 Note: No relevant classes found. No output generated.
Generating serviceoperationstatus.moc
:0:
 Note: No relevant classes found. No output generated.
Generating moc_columnproxymodel.cpp
Generating moc_mouseeventlistener.cpp
Generating moc_qiconitem.cpp
Generating moc_qimageitem.cpp
Generating moc_qpixmapitem.cpp
Generating moc_qtextracomponentsplugin.cpp
Generating moc_wallpaperinterface.cpp
Generating moc_declarativeappletscript.cpp
[ 18%] [ 18%] Generating svgitem.moc
:0:
 Note: No relevant classes found. No output generated.
Built target qtextracomponentsplugin_automoc
Built target plasma_appletscript_declarative_automoc
[ 18%] Building CXX object 
src/declarativeimports/qtextracomponents/tests/CMakeFiles/fullmodelaccesstest.dir/__/columnproxymod

Re: Review Request 114521: Rename DNSSD to KDNSSD

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114521/#review45885
---


This review has been submitted with commit 
4a5546b1c57126f8e60cb124e31fe8e485917604 by Aurélien Gâteau to branch 
frameworks.

- Commit Hook


On Dec. 17, 2013, 6:11 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114521/
> ---
> 
> (Updated Dec. 17, 2013, 6:11 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Similar to the rename of the itemmodels framework to kitemmodels. The mdns 
> part of the code was actually broken, and has been so for quite some time 
> now. Might be worth evaluating whether we want to drop it to simplify 
> maintenance (would have the nice side effect of making KDNSSD a tier1 
> framework).
> 
> Since the DBus name has changed, a fix is needed in kde-runtime[frameworks]. 
> Will do so when this patch is in.
> 
> 
> Diffs
> -
> 
>   superbuild/CMakeLists.txt 14b6904 
>   tier2/CMakeLists.txt aecb4c1 
>   tier2/dnssd/CMakeLists.txt eafc94b 
>   tier2/dnssd/COPYING.LIB  
>   tier2/dnssd/ConfigureChecks.cmake  
>   tier2/dnssd/KF5DNSSDConfig.cmake.in  
>   tier2/dnssd/Mainpage.dox 1686164 
>   tier2/dnssd/PACKAGERS  
>   tier2/dnssd/cmake/FindAvahi.cmake  
>   tier2/dnssd/cmake/FindDNSSD.cmake  
>   tier2/dnssd/config-dnssd.h.cmake  
>   tier2/dnssd/src/CMakeLists.txt 301f452 
>   tier2/dnssd/src/avahi-domainbrowser.cpp 8690671 
>   tier2/dnssd/src/avahi-domainbrowser_p.h 1bf895c 
>   tier2/dnssd/src/avahi-publicservice.cpp b3306f7 
>   tier2/dnssd/src/avahi-publicservice_p.h aa4efbd 
>   tier2/dnssd/src/avahi-remoteservice.cpp f039054 
>   tier2/dnssd/src/avahi-remoteservice_p.h 0b25d60 
>   tier2/dnssd/src/avahi-servicebrowser.cpp a2951ed 
>   tier2/dnssd/src/avahi-servicebrowser_p.h 2611b26 
>   tier2/dnssd/src/avahi-servicetypebrowser.cpp a694dd0 
>   tier2/dnssd/src/avahi-servicetypebrowser_p.h 97cd50d 
>   tier2/dnssd/src/avahi_entrygroup_interface.h  
>   tier2/dnssd/src/avahi_entrygroup_interface.cpp  
>   tier2/dnssd/src/avahi_server_interface.h f6955b1 
>   tier2/dnssd/src/avahi_server_interface.cpp 7a6fa92 
>   tier2/dnssd/src/avahi_serviceresolver_interface.h  
>   tier2/dnssd/src/avahi_serviceresolver_interface.cpp  
>   tier2/dnssd/src/domainbrowser.h 901a936 
>   tier2/dnssd/src/domainmodel.h b7cfbe5 
>   tier2/dnssd/src/domainmodel.cpp 1bea715 
>   tier2/dnssd/src/dummy-domainbrowser.cpp a41bb2e 
>   tier2/dnssd/src/dummy-publicservice.cpp d3135a4 
>   tier2/dnssd/src/dummy-remoteservice.cpp 22eb623 
>   tier2/dnssd/src/dummy-servicebrowser.cpp 260c1ff 
>   tier2/dnssd/src/dummy-servicetypebrowser.cpp 18895cb 
>   tier2/dnssd/src/kcm_kdnssd.kcfg  
>   tier2/dnssd/src/mdnsd-domainbrowser.cpp c3c2032 
>   tier2/dnssd/src/mdnsd-domainbrowser_p.h f7e1754 
>   tier2/dnssd/src/mdnsd-publicservice.cpp 96f8db2 
>   tier2/dnssd/src/mdnsd-remoteservice.cpp 3efaead 
>   tier2/dnssd/src/mdnsd-responder.h b944cce 
>   tier2/dnssd/src/mdnsd-responder.cpp 9c0bc45 
>   tier2/dnssd/src/mdnsd-sdevent.h d20b0de 
>   tier2/dnssd/src/mdnsd-servicebrowser.cpp a17694a 
>   tier2/dnssd/src/mdnsd-servicebrowser_p.h 9d31c3a 
>   tier2/dnssd/src/mdnsd-servicetypebrowser.cpp 2ac3f7f 
>   tier2/dnssd/src/mdnsd-servicetypebrowser_p.h 9289588 
>   tier2/dnssd/src/org.freedesktop.Avahi.DomainBrowser.xml  
>   tier2/dnssd/src/org.freedesktop.Avahi.ServiceBrowser.xml  
>   tier2/dnssd/src/org.freedesktop.Avahi.ServiceTypeBrowser.xml  
>   tier2/dnssd/src/publicservice.h 6232f1b 
>   tier2/dnssd/src/remoteservice.h 35edac8 
>   tier2/dnssd/src/servicebase.h 3c487b0 
>   tier2/dnssd/src/servicebase.cpp 9ddfdf5 
>   tier2/dnssd/src/servicebase_p.h 066c35e 
>   tier2/dnssd/src/servicebrowser.h 0a28e42 
>   tier2/dnssd/src/servicemodel.h 4812831 
>   tier2/dnssd/src/servicemodel.cpp f3de566 
>   tier2/dnssd/src/servicetypebrowser.h b5a2452 
>   tier2/dnssd/src/settings.kcfgc 01a31f0 
>   tier4/kde4support/src/includes/CMakeLists.txt 710cfa9 
>   tier4/kde4support/src/includes/DNSSD/Configuration afafd3d 
>   tier4/kde4support/src/includes/DNSSD/DomainBrowser f2b9a9a 
>   tier4/kde4support/src/includes/DNSSD/DomainModel 63d1a21 
>   tier4/kde4support/src/includes/DNSSD/PublicService 4f665f1 
>   tier4/kde4support/src/includes/DNSSD/RemoteService 1e0dc06 
>   tier4/kde4support/src/includes/DNSSD/ServiceBase dc40c19 
>   tier4/kde4support/src/includes/DNSSD/ServiceBrowser 221e9e9 
>   tier4/kde4support/src/includes/DNSSD/ServiceModel cd07f94 
>   tier4/kde4support/src/includes/DNSSD/ServiceTypeBrowser 03e384f 
>   tier4/kde4support/src/includes/KDNSSD/Configuration PRE-CREATION 
>   tier4/kde4support/src/includes/KDN

Re: Review Request 114522: Rename itemviews to kitemviews

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114522/#review45887
---


This review has been submitted with commit 
ba5307d1e45baabf2355eec9223fe707fdd979f8 by Aurélien Gâteau to branch 
frameworks.

- Commit Hook


On Dec. 17, 2013, 4:54 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114522/
> ---
> 
> (Updated Dec. 17, 2013, 4:54 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Same as itemmodels => kitemmodels
> 
> 
> Diffs
> -
> 
>   superbuild/CMakeLists.txt 146d34c 
>   tier1/CMakeLists.txt b23e8ea 
>   tier1/itemviews/CMakeLists.txt 0462274 
>   tier1/itemviews/COPYING  
>   tier1/itemviews/COPYING.LIB  
>   tier1/itemviews/KF5ItemViewsConfig.cmake.in  
>   tier1/itemviews/Mainpage.dox 39bd075 
>   tier1/itemviews/autotests/CMakeLists.txt feb8087 
>   tier1/itemviews/autotests/klistwidgetsearchlinetest.cpp  
>   tier1/itemviews/src/CMakeLists.txt cc59ae5 
>   tier1/itemviews/src/kcategorizedsortfilterproxymodel.h bd6c1d9 
>   tier1/itemviews/src/kcategorizedsortfilterproxymodel.cpp  
>   tier1/itemviews/src/kcategorizedsortfilterproxymodel_p.h  
>   tier1/itemviews/src/kcategorizedview.h 1028b5c 
>   tier1/itemviews/src/kcategorizedview.cpp  
>   tier1/itemviews/src/kcategorizedview_p.h  
>   tier1/itemviews/src/kcategorydrawer.h 14a87bb 
>   tier1/itemviews/src/kcategorydrawer.cpp  
>   tier1/itemviews/src/kextendableitemdelegate.h 386730d 
>   tier1/itemviews/src/kextendableitemdelegate.cpp  
>   tier1/itemviews/src/kfilterproxysearchline.h 85059d7 
>   tier1/itemviews/src/kfilterproxysearchline.cpp  
>   tier1/itemviews/src/klistwidgetsearchline.h f38dc83 
>   tier1/itemviews/src/klistwidgetsearchline.cpp  
>   tier1/itemviews/src/ktreewidgetsearchline.h 3570080 
>   tier1/itemviews/src/ktreewidgetsearchline.cpp  
>   tier1/itemviews/src/kwidgetitemdelegate.h fbd843e 
>   tier1/itemviews/src/kwidgetitemdelegate.cpp  
>   tier1/itemviews/src/kwidgetitemdelegate_p.h  
>   tier1/itemviews/src/kwidgetitemdelegatepool.cpp  
>   tier1/itemviews/src/kwidgetitemdelegatepool_p.h  
>   tier1/itemviews/tests/CMakeLists.txt e1ce7b3 
>   tier1/itemviews/tests/kcategorizedviewtest.cpp  
>   tier1/itemviews/tests/ktreewidgetsearchlinetest.h  
>   tier1/itemviews/tests/ktreewidgetsearchlinetest.cpp  
>   tier1/itemviews/tests/kwidgetitemdelegatetest.cpp  
>   tier1/kitemviews/Mainpage.dox PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/114522/diff/
> 
> 
> Testing
> ---
> 
> kdelibs builds.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114521: Rename DNSSD to KDNSSD

[Christophe Giboudeaux]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114521/#review45884
---

Ship it!


Ship It!

- Christophe Giboudeaux


On Dec. 17, 2013, 6:11 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114521/
> ---
> 
> (Updated Dec. 17, 2013, 6:11 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Similar to the rename of the itemmodels framework to kitemmodels. The mdns 
> part of the code was actually broken, and has been so for quite some time 
> now. Might be worth evaluating whether we want to drop it to simplify 
> maintenance (would have the nice side effect of making KDNSSD a tier1 
> framework).
> 
> Since the DBus name has changed, a fix is needed in kde-runtime[frameworks]. 
> Will do so when this patch is in.
> 
> 
> Diffs
> -
> 
>   superbuild/CMakeLists.txt 14b6904 
>   tier2/CMakeLists.txt aecb4c1 
>   tier2/dnssd/CMakeLists.txt eafc94b 
>   tier2/dnssd/COPYING.LIB  
>   tier2/dnssd/ConfigureChecks.cmake  
>   tier2/dnssd/KF5DNSSDConfig.cmake.in  
>   tier2/dnssd/Mainpage.dox 1686164 
>   tier2/dnssd/PACKAGERS  
>   tier2/dnssd/cmake/FindAvahi.cmake  
>   tier2/dnssd/cmake/FindDNSSD.cmake  
>   tier2/dnssd/config-dnssd.h.cmake  
>   tier2/dnssd/src/CMakeLists.txt 301f452 
>   tier2/dnssd/src/avahi-domainbrowser.cpp 8690671 
>   tier2/dnssd/src/avahi-domainbrowser_p.h 1bf895c 
>   tier2/dnssd/src/avahi-publicservice.cpp b3306f7 
>   tier2/dnssd/src/avahi-publicservice_p.h aa4efbd 
>   tier2/dnssd/src/avahi-remoteservice.cpp f039054 
>   tier2/dnssd/src/avahi-remoteservice_p.h 0b25d60 
>   tier2/dnssd/src/avahi-servicebrowser.cpp a2951ed 
>   tier2/dnssd/src/avahi-servicebrowser_p.h 2611b26 
>   tier2/dnssd/src/avahi-servicetypebrowser.cpp a694dd0 
>   tier2/dnssd/src/avahi-servicetypebrowser_p.h 97cd50d 
>   tier2/dnssd/src/avahi_entrygroup_interface.h  
>   tier2/dnssd/src/avahi_entrygroup_interface.cpp  
>   tier2/dnssd/src/avahi_server_interface.h f6955b1 
>   tier2/dnssd/src/avahi_server_interface.cpp 7a6fa92 
>   tier2/dnssd/src/avahi_serviceresolver_interface.h  
>   tier2/dnssd/src/avahi_serviceresolver_interface.cpp  
>   tier2/dnssd/src/domainbrowser.h 901a936 
>   tier2/dnssd/src/domainmodel.h b7cfbe5 
>   tier2/dnssd/src/domainmodel.cpp 1bea715 
>   tier2/dnssd/src/dummy-domainbrowser.cpp a41bb2e 
>   tier2/dnssd/src/dummy-publicservice.cpp d3135a4 
>   tier2/dnssd/src/dummy-remoteservice.cpp 22eb623 
>   tier2/dnssd/src/dummy-servicebrowser.cpp 260c1ff 
>   tier2/dnssd/src/dummy-servicetypebrowser.cpp 18895cb 
>   tier2/dnssd/src/kcm_kdnssd.kcfg  
>   tier2/dnssd/src/mdnsd-domainbrowser.cpp c3c2032 
>   tier2/dnssd/src/mdnsd-domainbrowser_p.h f7e1754 
>   tier2/dnssd/src/mdnsd-publicservice.cpp 96f8db2 
>   tier2/dnssd/src/mdnsd-remoteservice.cpp 3efaead 
>   tier2/dnssd/src/mdnsd-responder.h b944cce 
>   tier2/dnssd/src/mdnsd-responder.cpp 9c0bc45 
>   tier2/dnssd/src/mdnsd-sdevent.h d20b0de 
>   tier2/dnssd/src/mdnsd-servicebrowser.cpp a17694a 
>   tier2/dnssd/src/mdnsd-servicebrowser_p.h 9d31c3a 
>   tier2/dnssd/src/mdnsd-servicetypebrowser.cpp 2ac3f7f 
>   tier2/dnssd/src/mdnsd-servicetypebrowser_p.h 9289588 
>   tier2/dnssd/src/org.freedesktop.Avahi.DomainBrowser.xml  
>   tier2/dnssd/src/org.freedesktop.Avahi.ServiceBrowser.xml  
>   tier2/dnssd/src/org.freedesktop.Avahi.ServiceTypeBrowser.xml  
>   tier2/dnssd/src/publicservice.h 6232f1b 
>   tier2/dnssd/src/remoteservice.h 35edac8 
>   tier2/dnssd/src/servicebase.h 3c487b0 
>   tier2/dnssd/src/servicebase.cpp 9ddfdf5 
>   tier2/dnssd/src/servicebase_p.h 066c35e 
>   tier2/dnssd/src/servicebrowser.h 0a28e42 
>   tier2/dnssd/src/servicemodel.h 4812831 
>   tier2/dnssd/src/servicemodel.cpp f3de566 
>   tier2/dnssd/src/servicetypebrowser.h b5a2452 
>   tier2/dnssd/src/settings.kcfgc 01a31f0 
>   tier4/kde4support/src/includes/CMakeLists.txt 710cfa9 
>   tier4/kde4support/src/includes/DNSSD/Configuration afafd3d 
>   tier4/kde4support/src/includes/DNSSD/DomainBrowser f2b9a9a 
>   tier4/kde4support/src/includes/DNSSD/DomainModel 63d1a21 
>   tier4/kde4support/src/includes/DNSSD/PublicService 4f665f1 
>   tier4/kde4support/src/includes/DNSSD/RemoteService 1e0dc06 
>   tier4/kde4support/src/includes/DNSSD/ServiceBase dc40c19 
>   tier4/kde4support/src/includes/DNSSD/ServiceBrowser 221e9e9 
>   tier4/kde4support/src/includes/DNSSD/ServiceModel cd07f94 
>   tier4/kde4support/src/includes/DNSSD/ServiceTypeBrowser 03e384f 
>   tier4/kde4support/src/includes/KDNSSD/Configuration PRE-CREATION 
>   tier4/kde4support/src/includes/KDNSSD/DomainBrowser PRE-CREATION 
>   tier4/kde4support/src/includes/KDNSSD/DomainModel PRE-CREATION

Re: Review Request 114522: Rename itemviews to kitemviews

[Christophe Giboudeaux]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114522/#review45886
---

Ship it!


Ship It!

- Christophe Giboudeaux


On Dec. 17, 2013, 4:54 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114522/
> ---
> 
> (Updated Dec. 17, 2013, 4:54 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Same as itemmodels => kitemmodels
> 
> 
> Diffs
> -
> 
>   superbuild/CMakeLists.txt 146d34c 
>   tier1/CMakeLists.txt b23e8ea 
>   tier1/itemviews/CMakeLists.txt 0462274 
>   tier1/itemviews/COPYING  
>   tier1/itemviews/COPYING.LIB  
>   tier1/itemviews/KF5ItemViewsConfig.cmake.in  
>   tier1/itemviews/Mainpage.dox 39bd075 
>   tier1/itemviews/autotests/CMakeLists.txt feb8087 
>   tier1/itemviews/autotests/klistwidgetsearchlinetest.cpp  
>   tier1/itemviews/src/CMakeLists.txt cc59ae5 
>   tier1/itemviews/src/kcategorizedsortfilterproxymodel.h bd6c1d9 
>   tier1/itemviews/src/kcategorizedsortfilterproxymodel.cpp  
>   tier1/itemviews/src/kcategorizedsortfilterproxymodel_p.h  
>   tier1/itemviews/src/kcategorizedview.h 1028b5c 
>   tier1/itemviews/src/kcategorizedview.cpp  
>   tier1/itemviews/src/kcategorizedview_p.h  
>   tier1/itemviews/src/kcategorydrawer.h 14a87bb 
>   tier1/itemviews/src/kcategorydrawer.cpp  
>   tier1/itemviews/src/kextendableitemdelegate.h 386730d 
>   tier1/itemviews/src/kextendableitemdelegate.cpp  
>   tier1/itemviews/src/kfilterproxysearchline.h 85059d7 
>   tier1/itemviews/src/kfilterproxysearchline.cpp  
>   tier1/itemviews/src/klistwidgetsearchline.h f38dc83 
>   tier1/itemviews/src/klistwidgetsearchline.cpp  
>   tier1/itemviews/src/ktreewidgetsearchline.h 3570080 
>   tier1/itemviews/src/ktreewidgetsearchline.cpp  
>   tier1/itemviews/src/kwidgetitemdelegate.h fbd843e 
>   tier1/itemviews/src/kwidgetitemdelegate.cpp  
>   tier1/itemviews/src/kwidgetitemdelegate_p.h  
>   tier1/itemviews/src/kwidgetitemdelegatepool.cpp  
>   tier1/itemviews/src/kwidgetitemdelegatepool_p.h  
>   tier1/itemviews/tests/CMakeLists.txt e1ce7b3 
>   tier1/itemviews/tests/kcategorizedviewtest.cpp  
>   tier1/itemviews/tests/ktreewidgetsearchlinetest.h  
>   tier1/itemviews/tests/ktreewidgetsearchlinetest.cpp  
>   tier1/itemviews/tests/kwidgetitemdelegatetest.cpp  
>   tier1/kitemviews/Mainpage.dox PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/114522/diff/
> 
> 
> Testing
> ---
> 
> kdelibs builds.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114521: Rename DNSSD to KDNSSD

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114521/
---

(Updated Dec. 17, 2013, 7 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Similar to the rename of the itemmodels framework to kitemmodels. The mdns part 
of the code was actually broken, and has been so for quite some time now. Might 
be worth evaluating whether we want to drop it to simplify maintenance (would 
have the nice side effect of making KDNSSD a tier1 framework).

Since the DBus name has changed, a fix is needed in kde-runtime[frameworks]. 
Will do so when this patch is in.


Diffs
-

  superbuild/CMakeLists.txt 14b6904 
  tier2/CMakeLists.txt aecb4c1 
  tier2/dnssd/CMakeLists.txt eafc94b 
  tier2/dnssd/COPYING.LIB  
  tier2/dnssd/ConfigureChecks.cmake  
  tier2/dnssd/KF5DNSSDConfig.cmake.in  
  tier2/dnssd/Mainpage.dox 1686164 
  tier2/dnssd/PACKAGERS  
  tier2/dnssd/cmake/FindAvahi.cmake  
  tier2/dnssd/cmake/FindDNSSD.cmake  
  tier2/dnssd/config-dnssd.h.cmake  
  tier2/dnssd/src/CMakeLists.txt 301f452 
  tier2/dnssd/src/avahi-domainbrowser.cpp 8690671 
  tier2/dnssd/src/avahi-domainbrowser_p.h 1bf895c 
  tier2/dnssd/src/avahi-publicservice.cpp b3306f7 
  tier2/dnssd/src/avahi-publicservice_p.h aa4efbd 
  tier2/dnssd/src/avahi-remoteservice.cpp f039054 
  tier2/dnssd/src/avahi-remoteservice_p.h 0b25d60 
  tier2/dnssd/src/avahi-servicebrowser.cpp a2951ed 
  tier2/dnssd/src/avahi-servicebrowser_p.h 2611b26 
  tier2/dnssd/src/avahi-servicetypebrowser.cpp a694dd0 
  tier2/dnssd/src/avahi-servicetypebrowser_p.h 97cd50d 
  tier2/dnssd/src/avahi_entrygroup_interface.h  
  tier2/dnssd/src/avahi_entrygroup_interface.cpp  
  tier2/dnssd/src/avahi_server_interface.h f6955b1 
  tier2/dnssd/src/avahi_server_interface.cpp 7a6fa92 
  tier2/dnssd/src/avahi_serviceresolver_interface.h  
  tier2/dnssd/src/avahi_serviceresolver_interface.cpp  
  tier2/dnssd/src/domainbrowser.h 901a936 
  tier2/dnssd/src/domainmodel.h b7cfbe5 
  tier2/dnssd/src/domainmodel.cpp 1bea715 
  tier2/dnssd/src/dummy-domainbrowser.cpp a41bb2e 
  tier2/dnssd/src/dummy-publicservice.cpp d3135a4 
  tier2/dnssd/src/dummy-remoteservice.cpp 22eb623 
  tier2/dnssd/src/dummy-servicebrowser.cpp 260c1ff 
  tier2/dnssd/src/dummy-servicetypebrowser.cpp 18895cb 
  tier2/dnssd/src/kcm_kdnssd.kcfg  
  tier2/dnssd/src/mdnsd-domainbrowser.cpp c3c2032 
  tier2/dnssd/src/mdnsd-domainbrowser_p.h f7e1754 
  tier2/dnssd/src/mdnsd-publicservice.cpp 96f8db2 
  tier2/dnssd/src/mdnsd-remoteservice.cpp 3efaead 
  tier2/dnssd/src/mdnsd-responder.h b944cce 
  tier2/dnssd/src/mdnsd-responder.cpp 9c0bc45 
  tier2/dnssd/src/mdnsd-sdevent.h d20b0de 
  tier2/dnssd/src/mdnsd-servicebrowser.cpp a17694a 
  tier2/dnssd/src/mdnsd-servicebrowser_p.h 9d31c3a 
  tier2/dnssd/src/mdnsd-servicetypebrowser.cpp 2ac3f7f 
  tier2/dnssd/src/mdnsd-servicetypebrowser_p.h 9289588 
  tier2/dnssd/src/org.freedesktop.Avahi.DomainBrowser.xml  
  tier2/dnssd/src/org.freedesktop.Avahi.ServiceBrowser.xml  
  tier2/dnssd/src/org.freedesktop.Avahi.ServiceTypeBrowser.xml  
  tier2/dnssd/src/publicservice.h 6232f1b 
  tier2/dnssd/src/remoteservice.h 35edac8 
  tier2/dnssd/src/servicebase.h 3c487b0 
  tier2/dnssd/src/servicebase.cpp 9ddfdf5 
  tier2/dnssd/src/servicebase_p.h 066c35e 
  tier2/dnssd/src/servicebrowser.h 0a28e42 
  tier2/dnssd/src/servicemodel.h 4812831 
  tier2/dnssd/src/servicemodel.cpp f3de566 
  tier2/dnssd/src/servicetypebrowser.h b5a2452 
  tier2/dnssd/src/settings.kcfgc 01a31f0 
  tier4/kde4support/src/includes/CMakeLists.txt 710cfa9 
  tier4/kde4support/src/includes/DNSSD/Configuration afafd3d 
  tier4/kde4support/src/includes/DNSSD/DomainBrowser f2b9a9a 
  tier4/kde4support/src/includes/DNSSD/DomainModel 63d1a21 
  tier4/kde4support/src/includes/DNSSD/PublicService 4f665f1 
  tier4/kde4support/src/includes/DNSSD/RemoteService 1e0dc06 
  tier4/kde4support/src/includes/DNSSD/ServiceBase dc40c19 
  tier4/kde4support/src/includes/DNSSD/ServiceBrowser 221e9e9 
  tier4/kde4support/src/includes/DNSSD/ServiceModel cd07f94 
  tier4/kde4support/src/includes/DNSSD/ServiceTypeBrowser 03e384f 
  tier4/kde4support/src/includes/KDNSSD/Configuration PRE-CREATION 
  tier4/kde4support/src/includes/KDNSSD/DomainBrowser PRE-CREATION 
  tier4/kde4support/src/includes/KDNSSD/DomainModel PRE-CREATION 
  tier4/kde4support/src/includes/KDNSSD/PublicService PRE-CREATION 
  tier4/kde4support/src/includes/KDNSSD/RemoteService PRE-CREATION 
  tier4/kde4support/src/includes/KDNSSD/ServiceBase PRE-CREATION 
  tier4/kde4support/src/includes/KDNSSD/ServiceBrowser PRE-CREATION 
  tier4/kde4support/src/includes/KDNSSD/ServiceModel PRE-CREATION 
  tier4/kde4support/src/includes/KDNSSD/ServiceTypeBrowser PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/114521/diff/


Testing
---

Buil

Re: Review Request 114522: Rename itemviews to kitemviews

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114522/
---

(Updated Dec. 17, 2013, 7:21 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Same as itemmodels => kitemmodels


Diffs
-

  superbuild/CMakeLists.txt 146d34c 
  tier1/CMakeLists.txt b23e8ea 
  tier1/itemviews/CMakeLists.txt 0462274 
  tier1/itemviews/COPYING  
  tier1/itemviews/COPYING.LIB  
  tier1/itemviews/KF5ItemViewsConfig.cmake.in  
  tier1/itemviews/Mainpage.dox 39bd075 
  tier1/itemviews/autotests/CMakeLists.txt feb8087 
  tier1/itemviews/autotests/klistwidgetsearchlinetest.cpp  
  tier1/itemviews/src/CMakeLists.txt cc59ae5 
  tier1/itemviews/src/kcategorizedsortfilterproxymodel.h bd6c1d9 
  tier1/itemviews/src/kcategorizedsortfilterproxymodel.cpp  
  tier1/itemviews/src/kcategorizedsortfilterproxymodel_p.h  
  tier1/itemviews/src/kcategorizedview.h 1028b5c 
  tier1/itemviews/src/kcategorizedview.cpp  
  tier1/itemviews/src/kcategorizedview_p.h  
  tier1/itemviews/src/kcategorydrawer.h 14a87bb 
  tier1/itemviews/src/kcategorydrawer.cpp  
  tier1/itemviews/src/kextendableitemdelegate.h 386730d 
  tier1/itemviews/src/kextendableitemdelegate.cpp  
  tier1/itemviews/src/kfilterproxysearchline.h 85059d7 
  tier1/itemviews/src/kfilterproxysearchline.cpp  
  tier1/itemviews/src/klistwidgetsearchline.h f38dc83 
  tier1/itemviews/src/klistwidgetsearchline.cpp  
  tier1/itemviews/src/ktreewidgetsearchline.h 3570080 
  tier1/itemviews/src/ktreewidgetsearchline.cpp  
  tier1/itemviews/src/kwidgetitemdelegate.h fbd843e 
  tier1/itemviews/src/kwidgetitemdelegate.cpp  
  tier1/itemviews/src/kwidgetitemdelegate_p.h  
  tier1/itemviews/src/kwidgetitemdelegatepool.cpp  
  tier1/itemviews/src/kwidgetitemdelegatepool_p.h  
  tier1/itemviews/tests/CMakeLists.txt e1ce7b3 
  tier1/itemviews/tests/kcategorizedviewtest.cpp  
  tier1/itemviews/tests/ktreewidgetsearchlinetest.h  
  tier1/itemviews/tests/ktreewidgetsearchlinetest.cpp  
  tier1/itemviews/tests/kwidgetitemdelegatetest.cpp  
  tier1/kitemviews/Mainpage.dox PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/114522/diff/


Testing
---

kdelibs builds.


Thanks,

Aurélien Gâteau

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114521: Rename DNSSD to KDNSSD

[Aurélien Gâteau]

> On Dec. 17, 2013, 6:14 p.m., Christophe Giboudeaux wrote:
> > tier2/dnssd/src/CMakeLists.txt, line 85
> > 
> >
> > dnssd or kdnssd for headers ? (same thing line 89)
> > 
> > If you choose the later, the camelcased files in kde4support need to be 
> > changed as well

Decided to go for kdnssd and updated the kde4support headers accordingly. 
Thanks for pointing that out.


- Aurélien


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114521/#review45876
---


On Dec. 17, 2013, 7:11 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114521/
> ---
> 
> (Updated Dec. 17, 2013, 7:11 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Similar to the rename of the itemmodels framework to kitemmodels. The mdns 
> part of the code was actually broken, and has been so for quite some time 
> now. Might be worth evaluating whether we want to drop it to simplify 
> maintenance (would have the nice side effect of making KDNSSD a tier1 
> framework).
> 
> Since the DBus name has changed, a fix is needed in kde-runtime[frameworks]. 
> Will do so when this patch is in.
> 
> 
> Diffs
> -
> 
>   superbuild/CMakeLists.txt 14b6904 
>   tier2/CMakeLists.txt aecb4c1 
>   tier2/dnssd/CMakeLists.txt eafc94b 
>   tier2/dnssd/COPYING.LIB  
>   tier2/dnssd/ConfigureChecks.cmake  
>   tier2/dnssd/KF5DNSSDConfig.cmake.in  
>   tier2/dnssd/Mainpage.dox 1686164 
>   tier2/dnssd/PACKAGERS  
>   tier2/dnssd/cmake/FindAvahi.cmake  
>   tier2/dnssd/cmake/FindDNSSD.cmake  
>   tier2/dnssd/config-dnssd.h.cmake  
>   tier2/dnssd/src/CMakeLists.txt 301f452 
>   tier2/dnssd/src/avahi-domainbrowser.cpp 8690671 
>   tier2/dnssd/src/avahi-domainbrowser_p.h 1bf895c 
>   tier2/dnssd/src/avahi-publicservice.cpp b3306f7 
>   tier2/dnssd/src/avahi-publicservice_p.h aa4efbd 
>   tier2/dnssd/src/avahi-remoteservice.cpp f039054 
>   tier2/dnssd/src/avahi-remoteservice_p.h 0b25d60 
>   tier2/dnssd/src/avahi-servicebrowser.cpp a2951ed 
>   tier2/dnssd/src/avahi-servicebrowser_p.h 2611b26 
>   tier2/dnssd/src/avahi-servicetypebrowser.cpp a694dd0 
>   tier2/dnssd/src/avahi-servicetypebrowser_p.h 97cd50d 
>   tier2/dnssd/src/avahi_entrygroup_interface.h  
>   tier2/dnssd/src/avahi_entrygroup_interface.cpp  
>   tier2/dnssd/src/avahi_server_interface.h f6955b1 
>   tier2/dnssd/src/avahi_server_interface.cpp 7a6fa92 
>   tier2/dnssd/src/avahi_serviceresolver_interface.h  
>   tier2/dnssd/src/avahi_serviceresolver_interface.cpp  
>   tier2/dnssd/src/domainbrowser.h 901a936 
>   tier2/dnssd/src/domainmodel.h b7cfbe5 
>   tier2/dnssd/src/domainmodel.cpp 1bea715 
>   tier2/dnssd/src/dummy-domainbrowser.cpp a41bb2e 
>   tier2/dnssd/src/dummy-publicservice.cpp d3135a4 
>   tier2/dnssd/src/dummy-remoteservice.cpp 22eb623 
>   tier2/dnssd/src/dummy-servicebrowser.cpp 260c1ff 
>   tier2/dnssd/src/dummy-servicetypebrowser.cpp 18895cb 
>   tier2/dnssd/src/kcm_kdnssd.kcfg  
>   tier2/dnssd/src/mdnsd-domainbrowser.cpp c3c2032 
>   tier2/dnssd/src/mdnsd-domainbrowser_p.h f7e1754 
>   tier2/dnssd/src/mdnsd-publicservice.cpp 96f8db2 
>   tier2/dnssd/src/mdnsd-remoteservice.cpp 3efaead 
>   tier2/dnssd/src/mdnsd-responder.h b944cce 
>   tier2/dnssd/src/mdnsd-responder.cpp 9c0bc45 
>   tier2/dnssd/src/mdnsd-sdevent.h d20b0de 
>   tier2/dnssd/src/mdnsd-servicebrowser.cpp a17694a 
>   tier2/dnssd/src/mdnsd-servicebrowser_p.h 9d31c3a 
>   tier2/dnssd/src/mdnsd-servicetypebrowser.cpp 2ac3f7f 
>   tier2/dnssd/src/mdnsd-servicetypebrowser_p.h 9289588 
>   tier2/dnssd/src/org.freedesktop.Avahi.DomainBrowser.xml  
>   tier2/dnssd/src/org.freedesktop.Avahi.ServiceBrowser.xml  
>   tier2/dnssd/src/org.freedesktop.Avahi.ServiceTypeBrowser.xml  
>   tier2/dnssd/src/publicservice.h 6232f1b 
>   tier2/dnssd/src/remoteservice.h 35edac8 
>   tier2/dnssd/src/servicebase.h 3c487b0 
>   tier2/dnssd/src/servicebase.cpp 9ddfdf5 
>   tier2/dnssd/src/servicebase_p.h 066c35e 
>   tier2/dnssd/src/servicebrowser.h 0a28e42 
>   tier2/dnssd/src/servicemodel.h 4812831 
>   tier2/dnssd/src/servicemodel.cpp f3de566 
>   tier2/dnssd/src/servicetypebrowser.h b5a2452 
>   tier2/dnssd/src/settings.kcfgc 01a31f0 
>   tier4/kde4support/src/includes/CMakeLists.txt 710cfa9 
>   tier4/kde4support/src/includes/DNSSD/Configuration afafd3d 
>   tier4/kde4support/src/includes/DNSSD/DomainBrowser f2b9a9a 
>   tier4/kde4support/src/includes/DNSSD/DomainModel 63d1a21 
>   tier4/kde4support/src/includes/DNSSD/PublicService 4f665f1 
>   tier4/kde4support/src/includes/DNSSD/RemoteService 1e0dc06 
>   tier4/kde4support/src/inc

Re: Review Request 114521: Rename DNSSD to KDNSSD

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114521/
---

(Updated Dec. 17, 2013, 7:11 p.m.)


Review request for KDE Frameworks.


Changes
---

Fixed issues reported by Christophe.


Repository: kdelibs


Description
---

Similar to the rename of the itemmodels framework to kitemmodels. The mdns part 
of the code was actually broken, and has been so for quite some time now. Might 
be worth evaluating whether we want to drop it to simplify maintenance (would 
have the nice side effect of making KDNSSD a tier1 framework).

Since the DBus name has changed, a fix is needed in kde-runtime[frameworks]. 
Will do so when this patch is in.


Diffs (updated)
-

  superbuild/CMakeLists.txt 14b6904 
  tier2/CMakeLists.txt aecb4c1 
  tier2/dnssd/CMakeLists.txt eafc94b 
  tier2/dnssd/COPYING.LIB  
  tier2/dnssd/ConfigureChecks.cmake  
  tier2/dnssd/KF5DNSSDConfig.cmake.in  
  tier2/dnssd/Mainpage.dox 1686164 
  tier2/dnssd/PACKAGERS  
  tier2/dnssd/cmake/FindAvahi.cmake  
  tier2/dnssd/cmake/FindDNSSD.cmake  
  tier2/dnssd/config-dnssd.h.cmake  
  tier2/dnssd/src/CMakeLists.txt 301f452 
  tier2/dnssd/src/avahi-domainbrowser.cpp 8690671 
  tier2/dnssd/src/avahi-domainbrowser_p.h 1bf895c 
  tier2/dnssd/src/avahi-publicservice.cpp b3306f7 
  tier2/dnssd/src/avahi-publicservice_p.h aa4efbd 
  tier2/dnssd/src/avahi-remoteservice.cpp f039054 
  tier2/dnssd/src/avahi-remoteservice_p.h 0b25d60 
  tier2/dnssd/src/avahi-servicebrowser.cpp a2951ed 
  tier2/dnssd/src/avahi-servicebrowser_p.h 2611b26 
  tier2/dnssd/src/avahi-servicetypebrowser.cpp a694dd0 
  tier2/dnssd/src/avahi-servicetypebrowser_p.h 97cd50d 
  tier2/dnssd/src/avahi_entrygroup_interface.h  
  tier2/dnssd/src/avahi_entrygroup_interface.cpp  
  tier2/dnssd/src/avahi_server_interface.h f6955b1 
  tier2/dnssd/src/avahi_server_interface.cpp 7a6fa92 
  tier2/dnssd/src/avahi_serviceresolver_interface.h  
  tier2/dnssd/src/avahi_serviceresolver_interface.cpp  
  tier2/dnssd/src/domainbrowser.h 901a936 
  tier2/dnssd/src/domainmodel.h b7cfbe5 
  tier2/dnssd/src/domainmodel.cpp 1bea715 
  tier2/dnssd/src/dummy-domainbrowser.cpp a41bb2e 
  tier2/dnssd/src/dummy-publicservice.cpp d3135a4 
  tier2/dnssd/src/dummy-remoteservice.cpp 22eb623 
  tier2/dnssd/src/dummy-servicebrowser.cpp 260c1ff 
  tier2/dnssd/src/dummy-servicetypebrowser.cpp 18895cb 
  tier2/dnssd/src/kcm_kdnssd.kcfg  
  tier2/dnssd/src/mdnsd-domainbrowser.cpp c3c2032 
  tier2/dnssd/src/mdnsd-domainbrowser_p.h f7e1754 
  tier2/dnssd/src/mdnsd-publicservice.cpp 96f8db2 
  tier2/dnssd/src/mdnsd-remoteservice.cpp 3efaead 
  tier2/dnssd/src/mdnsd-responder.h b944cce 
  tier2/dnssd/src/mdnsd-responder.cpp 9c0bc45 
  tier2/dnssd/src/mdnsd-sdevent.h d20b0de 
  tier2/dnssd/src/mdnsd-servicebrowser.cpp a17694a 
  tier2/dnssd/src/mdnsd-servicebrowser_p.h 9d31c3a 
  tier2/dnssd/src/mdnsd-servicetypebrowser.cpp 2ac3f7f 
  tier2/dnssd/src/mdnsd-servicetypebrowser_p.h 9289588 
  tier2/dnssd/src/org.freedesktop.Avahi.DomainBrowser.xml  
  tier2/dnssd/src/org.freedesktop.Avahi.ServiceBrowser.xml  
  tier2/dnssd/src/org.freedesktop.Avahi.ServiceTypeBrowser.xml  
  tier2/dnssd/src/publicservice.h 6232f1b 
  tier2/dnssd/src/remoteservice.h 35edac8 
  tier2/dnssd/src/servicebase.h 3c487b0 
  tier2/dnssd/src/servicebase.cpp 9ddfdf5 
  tier2/dnssd/src/servicebase_p.h 066c35e 
  tier2/dnssd/src/servicebrowser.h 0a28e42 
  tier2/dnssd/src/servicemodel.h 4812831 
  tier2/dnssd/src/servicemodel.cpp f3de566 
  tier2/dnssd/src/servicetypebrowser.h b5a2452 
  tier2/dnssd/src/settings.kcfgc 01a31f0 
  tier4/kde4support/src/includes/CMakeLists.txt 710cfa9 
  tier4/kde4support/src/includes/DNSSD/Configuration afafd3d 
  tier4/kde4support/src/includes/DNSSD/DomainBrowser f2b9a9a 
  tier4/kde4support/src/includes/DNSSD/DomainModel 63d1a21 
  tier4/kde4support/src/includes/DNSSD/PublicService 4f665f1 
  tier4/kde4support/src/includes/DNSSD/RemoteService 1e0dc06 
  tier4/kde4support/src/includes/DNSSD/ServiceBase dc40c19 
  tier4/kde4support/src/includes/DNSSD/ServiceBrowser 221e9e9 
  tier4/kde4support/src/includes/DNSSD/ServiceModel cd07f94 
  tier4/kde4support/src/includes/DNSSD/ServiceTypeBrowser 03e384f 
  tier4/kde4support/src/includes/KDNSSD/Configuration PRE-CREATION 
  tier4/kde4support/src/includes/KDNSSD/DomainBrowser PRE-CREATION 
  tier4/kde4support/src/includes/KDNSSD/DomainModel PRE-CREATION 
  tier4/kde4support/src/includes/KDNSSD/PublicService PRE-CREATION 
  tier4/kde4support/src/includes/KDNSSD/RemoteService PRE-CREATION 
  tier4/kde4support/src/includes/KDNSSD/ServiceBase PRE-CREATION 
  tier4/kde4support/src/includes/KDNSSD/ServiceBrowser PRE-CREATION 
  tier4/kde4support/src/includes/KDNSSD/ServiceModel PRE-CREATION 
  tier4/kde4support/src/includes/KDNSSD/ServiceTypeBrowser PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/114521/diff/


Testing
---

Re: Review Request 114478: Add kshareddatacache.h include

[Alex Merry]

> On Dec. 15, 2013, 9:22 p.m., Kevin Ottens wrote:
> > It is in fact intended that way as kguiaddons isn't supposed to include 
> > stuff coming from kcoreaddons (yeah I know it's slightly convoluted in that 
> > particular case).
> 
> Albert Astals Cid wrote:
> So basically we have a header that when you include it, it breaks your 
> compilation. Do you really think this is a good idea?
> 
> Alex Merry wrote:
> If KSharedPixmapCacheMixin is never intended to be used directly, but 
> only via KImageCache, I think we should really have the #include; not having 
> KGuiAddons depend on KCoreAddons is one thing, but that header is useless 
> without KSharedDataCache.
> 
> Essentially, the current way is broken unless you add a non-obvious 
> KSharedDataCache include to your code, regardless of whether you have 
> KCoreAddons added to your project.  Albert's suggestion would make the common 
> case work (where you have KCoreAddons).
> 
> Of course, there are other tricks you could pull, such as having the 
> KF5::CoreAddons target add -DHAS_K_SHARED_DATA_CACHE to the compiler flags, 
> and only do the #include in the presence of that define.
> 
> Kevin Ottens wrote:
> I actually like this last suggestion.

Something for after the split, though.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114478/#review45732
---


On Dec. 15, 2013, 4:15 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114478/
> ---
> 
> (Updated Dec. 15, 2013, 4:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Since
> #define KImageCache KSharedPixmapCacheMixin
> I think it is only fair that kimagecache.h includes kshareddatacache.h 
> otherwise a 
> #include 
> is not enough to use it.
> 
> 
> Diffs
> -
> 
>   tier1/kguiaddons/src/util/kimagecache.h 682aa66 
> 
> Diff: http://git.reviewboard.kde.org/r/114478/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114521: Rename DNSSD to KDNSSD

[Christophe Giboudeaux]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114521/#review45876
---



tier2/dnssd/src/CMakeLists.txt


kdnssd/kdnssd_export.h



tier2/dnssd/src/CMakeLists.txt


kdnssd/kdnssd_export.h



tier2/dnssd/src/CMakeLists.txt


dnssd or kdnssd for headers ? (same thing line 89)

If you choose the later, the camelcased files in kde4support need to be 
changed as well


- Christophe Giboudeaux


On Dec. 17, 2013, 4:43 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114521/
> ---
> 
> (Updated Dec. 17, 2013, 4:43 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Similar to the rename of the itemmodels framework to kitemmodels. The mdns 
> part of the code was actually broken, and has been so for quite some time 
> now. Might be worth evaluating whether we want to drop it to simplify 
> maintenance (would have the nice side effect of making KDNSSD a tier1 
> framework).
> 
> Since the DBus name has changed, a fix is needed in kde-runtime[frameworks]. 
> Will do so when this patch is in.
> 
> 
> Diffs
> -
> 
>   superbuild/CMakeLists.txt 146d34c 
>   tier2/CMakeLists.txt aecb4c1 
>   tier2/dnssd/CMakeLists.txt eafc94b 
>   tier2/dnssd/COPYING.LIB  
>   tier2/dnssd/ConfigureChecks.cmake  
>   tier2/dnssd/KF5DNSSDConfig.cmake.in  
>   tier2/dnssd/Mainpage.dox 1686164 
>   tier2/dnssd/PACKAGERS  
>   tier2/dnssd/cmake/FindAvahi.cmake  
>   tier2/dnssd/cmake/FindDNSSD.cmake  
>   tier2/dnssd/config-dnssd.h.cmake  
>   tier2/dnssd/src/CMakeLists.txt 301f452 
>   tier2/dnssd/src/avahi-domainbrowser.cpp 8690671 
>   tier2/dnssd/src/avahi-domainbrowser_p.h 1bf895c 
>   tier2/dnssd/src/avahi-publicservice.cpp b3306f7 
>   tier2/dnssd/src/avahi-publicservice_p.h aa4efbd 
>   tier2/dnssd/src/avahi-remoteservice.cpp f039054 
>   tier2/dnssd/src/avahi-remoteservice_p.h 0b25d60 
>   tier2/dnssd/src/avahi-servicebrowser.cpp a2951ed 
>   tier2/dnssd/src/avahi-servicebrowser_p.h 2611b26 
>   tier2/dnssd/src/avahi-servicetypebrowser.cpp a694dd0 
>   tier2/dnssd/src/avahi-servicetypebrowser_p.h 97cd50d 
>   tier2/dnssd/src/avahi_entrygroup_interface.h  
>   tier2/dnssd/src/avahi_entrygroup_interface.cpp  
>   tier2/dnssd/src/avahi_server_interface.h f6955b1 
>   tier2/dnssd/src/avahi_server_interface.cpp 7a6fa92 
>   tier2/dnssd/src/avahi_serviceresolver_interface.h  
>   tier2/dnssd/src/avahi_serviceresolver_interface.cpp  
>   tier2/dnssd/src/domainbrowser.h 901a936 
>   tier2/dnssd/src/domainmodel.h b7cfbe5 
>   tier2/dnssd/src/domainmodel.cpp 1bea715 
>   tier2/dnssd/src/dummy-domainbrowser.cpp a41bb2e 
>   tier2/dnssd/src/dummy-publicservice.cpp d3135a4 
>   tier2/dnssd/src/dummy-remoteservice.cpp 22eb623 
>   tier2/dnssd/src/dummy-servicebrowser.cpp 260c1ff 
>   tier2/dnssd/src/dummy-servicetypebrowser.cpp 18895cb 
>   tier2/dnssd/src/kcm_kdnssd.kcfg  
>   tier2/dnssd/src/mdnsd-domainbrowser.cpp c3c2032 
>   tier2/dnssd/src/mdnsd-domainbrowser_p.h f7e1754 
>   tier2/dnssd/src/mdnsd-publicservice.cpp 96f8db2 
>   tier2/dnssd/src/mdnsd-remoteservice.cpp 3efaead 
>   tier2/dnssd/src/mdnsd-responder.h b944cce 
>   tier2/dnssd/src/mdnsd-responder.cpp 9c0bc45 
>   tier2/dnssd/src/mdnsd-sdevent.h d20b0de 
>   tier2/dnssd/src/mdnsd-servicebrowser.cpp a17694a 
>   tier2/dnssd/src/mdnsd-servicebrowser_p.h 9d31c3a 
>   tier2/dnssd/src/mdnsd-servicetypebrowser.cpp 2ac3f7f 
>   tier2/dnssd/src/mdnsd-servicetypebrowser_p.h 9289588 
>   tier2/dnssd/src/org.freedesktop.Avahi.DomainBrowser.xml  
>   tier2/dnssd/src/org.freedesktop.Avahi.ServiceBrowser.xml  
>   tier2/dnssd/src/org.freedesktop.Avahi.ServiceTypeBrowser.xml  
>   tier2/dnssd/src/publicservice.h 6232f1b 
>   tier2/dnssd/src/remoteservice.h 35edac8 
>   tier2/dnssd/src/servicebase.h 3c487b0 
>   tier2/dnssd/src/servicebase.cpp 9ddfdf5 
>   tier2/dnssd/src/servicebase_p.h 066c35e 
>   tier2/dnssd/src/servicebrowser.h 0a28e42 
>   tier2/dnssd/src/servicemodel.h 4812831 
>   tier2/dnssd/src/servicemodel.cpp f3de566 
>   tier2/dnssd/src/servicetypebrowser.h b5a2452 
>   tier2/dnssd/src/settings.kcfgc 01a31f0 
> 
> Diff: http://git.reviewboard.kde.org/r/114521/diff/
> 
> 
> Testing
> ---
> 
> Built kdelibs once with Avahi and once with mdns.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114518: Rename the itemmodels frameworks to kitemmodels

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114518/
---

(Updated Dec. 17, 2013, 5:57 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Rename the itemmodels frameworks to kitemmodels, as "itemmodels" is considered 
too generic.


Diffs
-

  KDE5PORTING.html a727079 
  superbuild/CMakeLists.txt 146d34c 
  tier1/CMakeLists.txt b23e8ea 
  tier1/itemmodels/CMakeLists.txt 60105fc 
  tier1/itemmodels/COPYING.LIB  
  tier1/itemmodels/KF5ItemModelsConfig.cmake.in  
  tier1/itemmodels/Mainpage.dox  
  tier1/itemmodels/autotests/CMakeLists.txt 8beb0bf 
  tier1/itemmodels/autotests/bihash/CMakeLists.txt  
  tier1/itemmodels/autotests/bihash/aggregrator.xls  
  tier1/itemmodels/autotests/bihash/benchmarker.py  
  tier1/itemmodels/autotests/bihash/benchmarks.cpp  
  tier1/itemmodels/autotests/bihash/functionalitytest.cpp  
  tier1/itemmodels/autotests/bihash/script.py  
  tier1/itemmodels/autotests/kdescendantentitiesproxymodeltest.cpp  
  tier1/itemmodels/autotests/kdescendantsproxymodeltest.cpp  
  tier1/itemmodels/autotests/klinkitemselectionmodeltest.h  
  tier1/itemmodels/autotests/klinkitemselectionmodeltest.cpp  
  tier1/itemmodels/autotests/kselectionproxymodeltest.cpp  
  tier1/itemmodels/autotests/kselectionproxymodeltestsuite.h  
  tier1/itemmodels/autotests/kselectionproxymodeltestsuite.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/CMakeLists.txt  
  tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbdirectionwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbdirectionwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbnavigationwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbnavigationwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbswidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbswidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/checkablewidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/checkablewidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/descendantpmwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/descendantpmwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/kidentityproxymodelwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/kidentityproxymodelwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/kreparentingproxymodel.h  
  tier1/itemmodels/autotests/proxymodeltestapp/kreparentingproxymodel.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/lessthanwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/lessthanwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/main.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/mainwindow.h  
  tier1/itemmodels/autotests/proxymodeltestapp/mainwindow.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/matchcheckingwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/matchcheckingwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/modelcommanderwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/modelcommanderwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/proxyitemselectionwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/proxyitemselectionwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/proxymodeltestwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/proxymodeltestwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/recursivefilterpmwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/recursivefilterpmwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/reparenting1.png  
  tier1/itemmodels/autotests/proxymodeltestapp/reparenting2.png  
  tier1/itemmodels/autotests/proxymodeltestapp/reparenting3.png  
  tier1/itemmodels/autotests/proxymodeltestapp/reparentingpmwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/reparentingpmwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/scriptablereparentingwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/scriptablereparentingwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/selectionpmwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/selectionpmwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/statesaverwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/statesaverwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestsuite/CMakeLists.txt  
  tier1/itemmodels/autotests/proxymodeltestsuite/dynamictreemodel.h  
  tier1/itemmodels/autotests/proxymodeltestsuite/dynamictreemodel.cpp  
  tier1/itemmodels/autotests/proxymodeltestsuite/dynamictreewidget.h  
  tier1/itemmodels/autotests/proxymodeltestsuite/dynamictreewidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestsuite/eventlogger.qrc  
  tier1/itemmodels/autotests/proxymodeltestsuite/eventlog

Review Request 114522: Rename itemviews to kitemviews

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114522/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Same as itemmodels => kitemmodels


Diffs
-

  superbuild/CMakeLists.txt 146d34c 
  tier1/CMakeLists.txt b23e8ea 
  tier1/itemviews/CMakeLists.txt 0462274 
  tier1/itemviews/COPYING  
  tier1/itemviews/COPYING.LIB  
  tier1/itemviews/KF5ItemViewsConfig.cmake.in  
  tier1/itemviews/Mainpage.dox 39bd075 
  tier1/itemviews/autotests/CMakeLists.txt feb8087 
  tier1/itemviews/autotests/klistwidgetsearchlinetest.cpp  
  tier1/itemviews/src/CMakeLists.txt cc59ae5 
  tier1/itemviews/src/kcategorizedsortfilterproxymodel.h bd6c1d9 
  tier1/itemviews/src/kcategorizedsortfilterproxymodel.cpp  
  tier1/itemviews/src/kcategorizedsortfilterproxymodel_p.h  
  tier1/itemviews/src/kcategorizedview.h 1028b5c 
  tier1/itemviews/src/kcategorizedview.cpp  
  tier1/itemviews/src/kcategorizedview_p.h  
  tier1/itemviews/src/kcategorydrawer.h 14a87bb 
  tier1/itemviews/src/kcategorydrawer.cpp  
  tier1/itemviews/src/kextendableitemdelegate.h 386730d 
  tier1/itemviews/src/kextendableitemdelegate.cpp  
  tier1/itemviews/src/kfilterproxysearchline.h 85059d7 
  tier1/itemviews/src/kfilterproxysearchline.cpp  
  tier1/itemviews/src/klistwidgetsearchline.h f38dc83 
  tier1/itemviews/src/klistwidgetsearchline.cpp  
  tier1/itemviews/src/ktreewidgetsearchline.h 3570080 
  tier1/itemviews/src/ktreewidgetsearchline.cpp  
  tier1/itemviews/src/kwidgetitemdelegate.h fbd843e 
  tier1/itemviews/src/kwidgetitemdelegate.cpp  
  tier1/itemviews/src/kwidgetitemdelegate_p.h  
  tier1/itemviews/src/kwidgetitemdelegatepool.cpp  
  tier1/itemviews/src/kwidgetitemdelegatepool_p.h  
  tier1/itemviews/tests/CMakeLists.txt e1ce7b3 
  tier1/itemviews/tests/kcategorizedviewtest.cpp  
  tier1/itemviews/tests/ktreewidgetsearchlinetest.h  
  tier1/itemviews/tests/ktreewidgetsearchlinetest.cpp  
  tier1/itemviews/tests/kwidgetitemdelegatetest.cpp  
  tier1/kitemviews/Mainpage.dox PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/114522/diff/


Testing
---

kdelibs builds.


Thanks,

Aurélien Gâteau

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 114521: Rename DNSSD to KDNSSD

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114521/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Similar to the rename of the itemmodels framework to kitemmodels. The mdns part 
of the code was actually broken, and has been so for quite some time now. Might 
be worth evaluating whether we want to drop it to simplify maintenance (would 
have the nice side effect of making KDNSSD a tier1 framework).

Since the DBus name has changed, a fix is needed in kde-runtime[frameworks]. 
Will do so when this patch is in.


Diffs
-

  superbuild/CMakeLists.txt 146d34c 
  tier2/CMakeLists.txt aecb4c1 
  tier2/dnssd/CMakeLists.txt eafc94b 
  tier2/dnssd/COPYING.LIB  
  tier2/dnssd/ConfigureChecks.cmake  
  tier2/dnssd/KF5DNSSDConfig.cmake.in  
  tier2/dnssd/Mainpage.dox 1686164 
  tier2/dnssd/PACKAGERS  
  tier2/dnssd/cmake/FindAvahi.cmake  
  tier2/dnssd/cmake/FindDNSSD.cmake  
  tier2/dnssd/config-dnssd.h.cmake  
  tier2/dnssd/src/CMakeLists.txt 301f452 
  tier2/dnssd/src/avahi-domainbrowser.cpp 8690671 
  tier2/dnssd/src/avahi-domainbrowser_p.h 1bf895c 
  tier2/dnssd/src/avahi-publicservice.cpp b3306f7 
  tier2/dnssd/src/avahi-publicservice_p.h aa4efbd 
  tier2/dnssd/src/avahi-remoteservice.cpp f039054 
  tier2/dnssd/src/avahi-remoteservice_p.h 0b25d60 
  tier2/dnssd/src/avahi-servicebrowser.cpp a2951ed 
  tier2/dnssd/src/avahi-servicebrowser_p.h 2611b26 
  tier2/dnssd/src/avahi-servicetypebrowser.cpp a694dd0 
  tier2/dnssd/src/avahi-servicetypebrowser_p.h 97cd50d 
  tier2/dnssd/src/avahi_entrygroup_interface.h  
  tier2/dnssd/src/avahi_entrygroup_interface.cpp  
  tier2/dnssd/src/avahi_server_interface.h f6955b1 
  tier2/dnssd/src/avahi_server_interface.cpp 7a6fa92 
  tier2/dnssd/src/avahi_serviceresolver_interface.h  
  tier2/dnssd/src/avahi_serviceresolver_interface.cpp  
  tier2/dnssd/src/domainbrowser.h 901a936 
  tier2/dnssd/src/domainmodel.h b7cfbe5 
  tier2/dnssd/src/domainmodel.cpp 1bea715 
  tier2/dnssd/src/dummy-domainbrowser.cpp a41bb2e 
  tier2/dnssd/src/dummy-publicservice.cpp d3135a4 
  tier2/dnssd/src/dummy-remoteservice.cpp 22eb623 
  tier2/dnssd/src/dummy-servicebrowser.cpp 260c1ff 
  tier2/dnssd/src/dummy-servicetypebrowser.cpp 18895cb 
  tier2/dnssd/src/kcm_kdnssd.kcfg  
  tier2/dnssd/src/mdnsd-domainbrowser.cpp c3c2032 
  tier2/dnssd/src/mdnsd-domainbrowser_p.h f7e1754 
  tier2/dnssd/src/mdnsd-publicservice.cpp 96f8db2 
  tier2/dnssd/src/mdnsd-remoteservice.cpp 3efaead 
  tier2/dnssd/src/mdnsd-responder.h b944cce 
  tier2/dnssd/src/mdnsd-responder.cpp 9c0bc45 
  tier2/dnssd/src/mdnsd-sdevent.h d20b0de 
  tier2/dnssd/src/mdnsd-servicebrowser.cpp a17694a 
  tier2/dnssd/src/mdnsd-servicebrowser_p.h 9d31c3a 
  tier2/dnssd/src/mdnsd-servicetypebrowser.cpp 2ac3f7f 
  tier2/dnssd/src/mdnsd-servicetypebrowser_p.h 9289588 
  tier2/dnssd/src/org.freedesktop.Avahi.DomainBrowser.xml  
  tier2/dnssd/src/org.freedesktop.Avahi.ServiceBrowser.xml  
  tier2/dnssd/src/org.freedesktop.Avahi.ServiceTypeBrowser.xml  
  tier2/dnssd/src/publicservice.h 6232f1b 
  tier2/dnssd/src/remoteservice.h 35edac8 
  tier2/dnssd/src/servicebase.h 3c487b0 
  tier2/dnssd/src/servicebase.cpp 9ddfdf5 
  tier2/dnssd/src/servicebase_p.h 066c35e 
  tier2/dnssd/src/servicebrowser.h 0a28e42 
  tier2/dnssd/src/servicemodel.h 4812831 
  tier2/dnssd/src/servicemodel.cpp f3de566 
  tier2/dnssd/src/servicetypebrowser.h b5a2452 
  tier2/dnssd/src/settings.kcfgc 01a31f0 

Diff: http://git.reviewboard.kde.org/r/114521/diff/


Testing
---

Built kdelibs once with Avahi and once with mdns.


Thanks,

Aurélien Gâteau

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Let's get in release mode!

[Kevin Ottens]

On Tuesday 17 December 2013 11:32:46 Aurélien Gâteau wrote:
> On Tue, 17 Dec 2013 11:17:35 +0100, Aurélien Gâteau wrote:
> > On Mon, 16 Dec 2013 18:17:59 +0100, Kevin Ottens wrote:
> >>> Regarding the split: what is going to happen to the frameworks
> >>> branch of the
> >>> kdelibs repository after the split? Is it going to be removed or is
> >>> it
> >>> going to stay there with the framework folders pointing to the
> >>> framework
> >>> repositories through git sub-modules? The work on the graph
> >>> generator and
> >>> api.kde.org will be different depending on what the branch becomes.
> >> 
> >> Consider it removed from the graph generator pov. Technically it'll
> >> stay but
> >> will be frozen (no push allowed).
> > 
> > Do you have a plan to indicate which tier a framework belongs to? My
> > kf5dot tool relies on folder names right now, but it's not going to
> > work
> > anymore. I am thinking there should be either a standard
> > meta-information file in the root of each framework repository, or a
> > standard variable set within CMake which we can grep out (a bit
> > ugly).
> 
> Replying to myself: I think using DOAP files [1] would provide a place
> to store this (through an extension) and other information like
> licenses and maintainers.

That's an option. We could also see if we could make inqlude.org job easier, I 
guess it uses a similar input format too.

Cheers.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114478: Add kshareddatacache.h include

[Kevin Ottens]

> On Dec. 15, 2013, 9:22 p.m., Kevin Ottens wrote:
> > It is in fact intended that way as kguiaddons isn't supposed to include 
> > stuff coming from kcoreaddons (yeah I know it's slightly convoluted in that 
> > particular case).
> 
> Albert Astals Cid wrote:
> So basically we have a header that when you include it, it breaks your 
> compilation. Do you really think this is a good idea?
> 
> Alex Merry wrote:
> If KSharedPixmapCacheMixin is never intended to be used directly, but 
> only via KImageCache, I think we should really have the #include; not having 
> KGuiAddons depend on KCoreAddons is one thing, but that header is useless 
> without KSharedDataCache.
> 
> Essentially, the current way is broken unless you add a non-obvious 
> KSharedDataCache include to your code, regardless of whether you have 
> KCoreAddons added to your project.  Albert's suggestion would make the common 
> case work (where you have KCoreAddons).
> 
> Of course, there are other tricks you could pull, such as having the 
> KF5::CoreAddons target add -DHAS_K_SHARED_DATA_CACHE to the compiler flags, 
> and only do the #include in the presence of that define.

I actually like this last suggestion.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114478/#review45732
---


On Dec. 15, 2013, 4:15 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114478/
> ---
> 
> (Updated Dec. 15, 2013, 4:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Since
> #define KImageCache KSharedPixmapCacheMixin
> I think it is only fair that kimagecache.h includes kshareddatacache.h 
> otherwise a 
> #include 
> is not enough to use it.
> 
> 
> Diffs
> -
> 
>   tier1/kguiaddons/src/util/kimagecache.h 682aa66 
> 
> Diff: http://git.reviewboard.kde.org/r/114478/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Fwd: Tracking bugs in Frameworks

[Kevin Ottens]

On Monday 16 December 2013 23:30:15 Sebastian Kügler wrote:
> On Monday, December 16, 2013 19:30:25 Martin Graesslin wrote:
> > On Monday 16 December 2013 19:01:25 David Edmundson wrote:
> > > On Mon, Dec 16, 2013 at 6:08 PM, Martin Graesslin 
> > > 
> > > > On Monday 16 December 2013 11:58:35 David Edmundson wrote:
> > > >> I think if we did that it would be a good idea to prefix the names
> > > >> with a common element like
> > > >> "frameworks-coreaddons" "frameworks-kio" etc.
> > > > 
> > > > I don't think it needs the prefix. For a description, we have the
> > > > product
> > > > description in bugzilla. So that should be fine. We don't have users
> > > > who
> > > > report bugs against frameworks directly, they neither know "kio" nor
> > > > "frameworks- kio". For our triaging team it shouldn't matter much and
> > > > from us developers I expect that we know it.
> > > 
> > > I disagree.
> > > 
> > > We will (hopefully) have a lot of developers who use Frameworks who
> > > are not 'KDE' reporting bugs on the parts they do use.
> > 
> > You mean 3rd party developers using e.g. KF5Archive? In that case I expect
> > that
> > a) they know that they use KArchive
> > b) they will use Ctrl+F to find it in the product list. Hey even I do that
> > to  get to KWin, I'm not scrolling a list of hundreds of products starting
> > with "K". It would be just the same with a prefix frameworks.
> > 
> > > Having the
> > > frameworks scattered over a huge list of 'noise'  when they are sorted
> > > alphabetically would be really annoying. Certainly when I have to
> > > update all the versions in bugzilla after a release I do not want to
> > > have to go hunting to find all of them.
> > 
> > No, you don't want to create those versions in the first place. If we have
> > to  create a version for each of the frameworks manually through the web
> > interface we do something wrong.
> > 
> > > That said, I don't want to bikeshed over what isn't a particularly
> > > massive point. Maybe someone can make an executive decision.
> 
> Let's go for the prefix.
> 
> Here's my reasoning: if we have a list to choose from, users will see a huge
> load of generic names (Archive, to name one). If it's prefixed with
> frameworks, or maybe framework-, it's much easier to dismiss it, and scroll
> down to the right application (or component). I think it's also clear to
> those that use our libraries, which is an important (new) target group.

I agree with that, let's use a frameworks- prefix.
 
> > neither do I and this time I cannot bring the argument that you have no
> > clue  about bugzilla to silence your argument :-P So executive decision
> > sounds fine.
> 
> You can claim that I have no clue about bugzilla, and you'd be right. But
> there's your executive decision. Feel free to ignore it. :-)

Our main users being splitted between our triagers (who have a clue about 
bugzilla) and third parties developers (who might not), it's sane to make 
their job easier in finding stuff. The prefix will help with that IMO.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: framework names (Re: Let's get in release mode!)

[Alex Merry]

On 17/12/13 15:31, Alex Merry wrote:
> On 17/12/13 15:26, Aurélien Gâteau wrote:
>> On Tue, 17 Dec 2013 14:54:44 +, Alex Merry wrote:
>>> On 17/12/13 12:57, Aurélien Gâteau wrote:
> I guess the question is - what does this module actually bring. I
> assume, a consistent look-n-feel for KDE-produced api docs, right?

 Yes. It also goes a bit further by doing things like generating menus
 in the sidebar and handling cross-doxygen search (though that bit could
 use some improvements). It should at some point include the work I did
 on dependency diagram generation.
>>>
>>> It almost sounds like this is more sysadmin-ish than framework-ish...
>>
>> In all case, this code was in kdelibs until now, so even if it is not a
>> framework since it does not provide libraries for applications to
>> link to and is not used by the end user, it needs a repository.
>>
>> It is tied to frameworks though. It expects to find certain files in
>> projects source code in order to build its documentation, for example a
>> Mainpage.dox file to build api.kde.org sidebar menu.
>>
>> I expect more conventions regarding docs are going to be defined, which
>> all projects documented on api.kde.org will have to follow so that
>> apidox can extract relevant information from there.
> 
> Oh, absolutely, I agree with all of that.  However, it might be better
> suited to a different location on projects.kde.org.

And, I should add, this may influence the name it is given.

Personally, I'd go for something like kde-apidox: it generates apidox in
the preferred style of the KDE community.

Alex

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: framework names (Re: Let's get in release mode!)

[Aurélien Gâteau]

On Tue, 17 Dec 2013 14:54:44 +, Alex Merry wrote:

On 17/12/13 12:57, Aurélien Gâteau wrote:

I guess the question is - what does this module actually bring. I
assume, a consistent look-n-feel for KDE-produced api docs, right?


Yes. It also goes a bit further by doing things like generating 
menus
in the sidebar and handling cross-doxygen search (though that bit 
could
use some improvements). It should at some point include the work I 
did

on dependency diagram generation.


It almost sounds like this is more sysadmin-ish than framework-ish...


In all case, this code was in kdelibs until now, so even if it is not a
framework since it does not provide libraries for applications to
link to and is not used by the end user, it needs a repository.

It is tied to frameworks though. It expects to find certain files in
projects source code in order to build its documentation, for example a
Mainpage.dox file to build api.kde.org sidebar menu.

I expect more conventions regarding docs are going to be defined, which
all projects documented on api.kde.org will have to follow so that
apidox can extract relevant information from there.

Aurélien

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: framework names (Re: Let's get in release mode!)

[Alex Merry]

On 17/12/13 15:26, Aurélien Gâteau wrote:
> On Tue, 17 Dec 2013 14:54:44 +, Alex Merry wrote:
>> On 17/12/13 12:57, Aurélien Gâteau wrote:
 I guess the question is - what does this module actually bring. I
 assume, a consistent look-n-feel for KDE-produced api docs, right?
>>>
>>> Yes. It also goes a bit further by doing things like generating menus
>>> in the sidebar and handling cross-doxygen search (though that bit could
>>> use some improvements). It should at some point include the work I did
>>> on dependency diagram generation.
>>
>> It almost sounds like this is more sysadmin-ish than framework-ish...
> 
> In all case, this code was in kdelibs until now, so even if it is not a
> framework since it does not provide libraries for applications to
> link to and is not used by the end user, it needs a repository.
> 
> It is tied to frameworks though. It expects to find certain files in
> projects source code in order to build its documentation, for example a
> Mainpage.dox file to build api.kde.org sidebar menu.
> 
> I expect more conventions regarding docs are going to be defined, which
> all projects documented on api.kde.org will have to follow so that
> apidox can extract relevant information from there.

Oh, absolutely, I agree with all of that.  However, it might be better
suited to a different location on projects.kde.org.

Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114518: Rename the itemmodels frameworks to kitemmodels

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114518/
---

(Updated Dec. 17, 2013, 4:29 p.m.)


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Rename the itemmodels frameworks to kitemmodels, as "itemmodels" is considered 
too generic.


Diffs (updated)
-

  KDE5PORTING.html a727079 
  superbuild/CMakeLists.txt 146d34c 
  tier1/CMakeLists.txt b23e8ea 
  tier1/itemmodels/CMakeLists.txt 60105fc 
  tier1/itemmodels/COPYING.LIB  
  tier1/itemmodels/KF5ItemModelsConfig.cmake.in  
  tier1/itemmodels/Mainpage.dox  
  tier1/itemmodels/autotests/CMakeLists.txt 8beb0bf 
  tier1/itemmodels/autotests/bihash/CMakeLists.txt  
  tier1/itemmodels/autotests/bihash/aggregrator.xls  
  tier1/itemmodels/autotests/bihash/benchmarker.py  
  tier1/itemmodels/autotests/bihash/benchmarks.cpp  
  tier1/itemmodels/autotests/bihash/functionalitytest.cpp  
  tier1/itemmodels/autotests/bihash/script.py  
  tier1/itemmodels/autotests/kdescendantentitiesproxymodeltest.cpp  
  tier1/itemmodels/autotests/kdescendantsproxymodeltest.cpp  
  tier1/itemmodels/autotests/klinkitemselectionmodeltest.h  
  tier1/itemmodels/autotests/klinkitemselectionmodeltest.cpp  
  tier1/itemmodels/autotests/kselectionproxymodeltest.cpp  
  tier1/itemmodels/autotests/kselectionproxymodeltestsuite.h  
  tier1/itemmodels/autotests/kselectionproxymodeltestsuite.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/CMakeLists.txt  
  tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbdirectionwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbdirectionwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbnavigationwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbnavigationwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbswidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbswidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/checkablewidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/checkablewidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/descendantpmwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/descendantpmwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/kidentityproxymodelwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/kidentityproxymodelwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/kreparentingproxymodel.h  
  tier1/itemmodels/autotests/proxymodeltestapp/kreparentingproxymodel.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/lessthanwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/lessthanwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/main.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/mainwindow.h  
  tier1/itemmodels/autotests/proxymodeltestapp/mainwindow.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/matchcheckingwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/matchcheckingwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/modelcommanderwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/modelcommanderwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/proxyitemselectionwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/proxyitemselectionwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/proxymodeltestwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/proxymodeltestwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/recursivefilterpmwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/recursivefilterpmwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/reparenting1.png  
  tier1/itemmodels/autotests/proxymodeltestapp/reparenting2.png  
  tier1/itemmodels/autotests/proxymodeltestapp/reparenting3.png  
  tier1/itemmodels/autotests/proxymodeltestapp/reparentingpmwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/reparentingpmwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/scriptablereparentingwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/scriptablereparentingwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/selectionpmwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/selectionpmwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/statesaverwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/statesaverwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestsuite/CMakeLists.txt  
  tier1/itemmodels/autotests/proxymodeltestsuite/dynamictreemodel.h  
  tier1/itemmodels/autotests/proxymodeltestsuite/dynamictreemodel.cpp  
  tier1/itemmodels/autotests/proxymodeltestsuite/dynamictreewidget.h  
  tier1/itemmodels/autotests/proxymodeltestsuite/dynamictreewidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestsuite/eventlogger.qrc  
  tier1/itemmodels/autotests/proxymodeltestsuite/eventloggerregister.h  
  tier1/itemmodels/autotests/prox

Re: Review Request 114518: Rename the itemmodels frameworks to kitemmodels

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114518/#review45872
---

Ship it!


- David Faure


On Dec. 17, 2013, 3:10 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114518/
> ---
> 
> (Updated Dec. 17, 2013, 3:10 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Rename the itemmodels frameworks to kitemmodels, as "itemmodels" is 
> considered too generic.
> 
> 
> Diffs
> -
> 
>   KDE5PORTING.html a727079 
>   superbuild/CMakeLists.txt 146d34c 
>   tier1/CMakeLists.txt b23e8ea 
>   tier1/itemmodels/CMakeLists.txt 60105fc 
>   tier1/itemmodels/COPYING.LIB  
>   tier1/itemmodels/KF5ItemModelsConfig.cmake.in  
>   tier1/itemmodels/Mainpage.dox  
>   tier1/itemmodels/autotests/CMakeLists.txt 8beb0bf 
>   tier1/itemmodels/autotests/bihash/CMakeLists.txt  
>   tier1/itemmodels/autotests/bihash/aggregrator.xls  
>   tier1/itemmodels/autotests/bihash/benchmarker.py  
>   tier1/itemmodels/autotests/bihash/benchmarks.cpp  
>   tier1/itemmodels/autotests/bihash/functionalitytest.cpp  
>   tier1/itemmodels/autotests/bihash/script.py  
>   tier1/itemmodels/autotests/kdescendantentitiesproxymodeltest.cpp  
>   tier1/itemmodels/autotests/kdescendantsproxymodeltest.cpp  
>   tier1/itemmodels/autotests/klinkitemselectionmodeltest.h  
>   tier1/itemmodels/autotests/klinkitemselectionmodeltest.cpp  
>   tier1/itemmodels/autotests/kselectionproxymodeltest.cpp  
>   tier1/itemmodels/autotests/kselectionproxymodeltestsuite.h  
>   tier1/itemmodels/autotests/kselectionproxymodeltestsuite.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/CMakeLists.txt  
>   tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbdirectionwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbdirectionwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbnavigationwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbnavigationwidget.cpp 
>  
>   tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbswidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbswidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/checkablewidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/checkablewidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/descendantpmwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/descendantpmwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/kidentityproxymodelwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/kidentityproxymodelwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/kreparentingproxymodel.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/kreparentingproxymodel.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/lessthanwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/lessthanwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/main.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/mainwindow.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/mainwindow.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/matchcheckingwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/matchcheckingwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/modelcommanderwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/modelcommanderwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/proxyitemselectionwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/proxyitemselectionwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/proxymodeltestwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/proxymodeltestwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/recursivefilterpmwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/recursivefilterpmwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/reparenting1.png  
>   tier1/itemmodels/autotests/proxymodeltestapp/reparenting2.png  
>   tier1/itemmodels/autotests/proxymodeltestapp/reparenting3.png  
>   tier1/itemmodels/autotests/proxymodeltestapp/reparentingpmwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/reparentingpmwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/scriptablereparentingwidget.h  
>   
> tier1/itemmodels/autotests/proxymodeltestapp/scriptablereparentingwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/selectionpmwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/selectionpmwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/statesaverwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/statesaverwidget.cpp  
>   tier1/itemmodels/autotests/proxymodel

Re: Review Request 114518: Rename the itemmodels frameworks to kitemmodels

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114518/
---

(Updated Dec. 17, 2013, 4:10 p.m.)


Review request for KDE Frameworks.


Changes
---

Fix issues reported by Christophe.


Repository: kdelibs


Description
---

Rename the itemmodels frameworks to kitemmodels, as "itemmodels" is considered 
too generic.


Diffs (updated)
-

  KDE5PORTING.html a727079 
  superbuild/CMakeLists.txt 146d34c 
  tier1/CMakeLists.txt b23e8ea 
  tier1/itemmodels/CMakeLists.txt 60105fc 
  tier1/itemmodels/COPYING.LIB  
  tier1/itemmodels/KF5ItemModelsConfig.cmake.in  
  tier1/itemmodels/Mainpage.dox  
  tier1/itemmodels/autotests/CMakeLists.txt 8beb0bf 
  tier1/itemmodels/autotests/bihash/CMakeLists.txt  
  tier1/itemmodels/autotests/bihash/aggregrator.xls  
  tier1/itemmodels/autotests/bihash/benchmarker.py  
  tier1/itemmodels/autotests/bihash/benchmarks.cpp  
  tier1/itemmodels/autotests/bihash/functionalitytest.cpp  
  tier1/itemmodels/autotests/bihash/script.py  
  tier1/itemmodels/autotests/kdescendantentitiesproxymodeltest.cpp  
  tier1/itemmodels/autotests/kdescendantsproxymodeltest.cpp  
  tier1/itemmodels/autotests/klinkitemselectionmodeltest.h  
  tier1/itemmodels/autotests/klinkitemselectionmodeltest.cpp  
  tier1/itemmodels/autotests/kselectionproxymodeltest.cpp  
  tier1/itemmodels/autotests/kselectionproxymodeltestsuite.h  
  tier1/itemmodels/autotests/kselectionproxymodeltestsuite.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/CMakeLists.txt  
  tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbdirectionwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbdirectionwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbnavigationwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbnavigationwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbswidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbswidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/checkablewidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/checkablewidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/descendantpmwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/descendantpmwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/kidentityproxymodelwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/kidentityproxymodelwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/kreparentingproxymodel.h  
  tier1/itemmodels/autotests/proxymodeltestapp/kreparentingproxymodel.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/lessthanwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/lessthanwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/main.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/mainwindow.h  
  tier1/itemmodels/autotests/proxymodeltestapp/mainwindow.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/matchcheckingwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/matchcheckingwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/modelcommanderwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/modelcommanderwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/proxyitemselectionwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/proxyitemselectionwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/proxymodeltestwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/proxymodeltestwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/recursivefilterpmwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/recursivefilterpmwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/reparenting1.png  
  tier1/itemmodels/autotests/proxymodeltestapp/reparenting2.png  
  tier1/itemmodels/autotests/proxymodeltestapp/reparenting3.png  
  tier1/itemmodels/autotests/proxymodeltestapp/reparentingpmwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/reparentingpmwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/scriptablereparentingwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/scriptablereparentingwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/selectionpmwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/selectionpmwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/statesaverwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/statesaverwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestsuite/CMakeLists.txt  
  tier1/itemmodels/autotests/proxymodeltestsuite/dynamictreemodel.h  
  tier1/itemmodels/autotests/proxymodeltestsuite/dynamictreemodel.cpp  
  tier1/itemmodels/autotests/proxymodeltestsuite/dynamictreewidget.h  
  tier1/itemmodels/autotests/proxymodeltestsuite/dynamictreewidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestsuite/eventlogger.qrc  
  tier1/itemmodels/autotests/proxymodeltestsuite/eve

Re: Review Request 114518: Rename the itemmodels frameworks to kitemmodels

[Christophe Giboudeaux]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114518/#review45870
---


tier4/kde4support/KF5KDE4SupportConfig.cmake.in:60 also need a change


tier1/itemmodels/autotests/CMakeLists.txt


you didn't rename the macro



tier1/itemmodels/CMakeLists.txt


project(KItemModels)


- Christophe Giboudeaux


On Dec. 17, 2013, 3:03 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114518/
> ---
> 
> (Updated Dec. 17, 2013, 3:03 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Rename the itemmodels frameworks to kitemmodels, as "itemmodels" is 
> considered too generic.
> 
> 
> Diffs
> -
> 
>   KDE5PORTING.html a727079 
>   superbuild/CMakeLists.txt 146d34c 
>   tier1/CMakeLists.txt b23e8ea 
>   tier1/itemmodels/CMakeLists.txt 60105fc 
>   tier1/itemmodels/COPYING.LIB  
>   tier1/itemmodels/KF5ItemModelsConfig.cmake.in  
>   tier1/itemmodels/Mainpage.dox  
>   tier1/itemmodels/autotests/CMakeLists.txt 8beb0bf 
>   tier1/itemmodels/autotests/bihash/CMakeLists.txt  
>   tier1/itemmodels/autotests/bihash/aggregrator.xls  
>   tier1/itemmodels/autotests/bihash/benchmarker.py  
>   tier1/itemmodels/autotests/bihash/benchmarks.cpp  
>   tier1/itemmodels/autotests/bihash/functionalitytest.cpp  
>   tier1/itemmodels/autotests/bihash/script.py  
>   tier1/itemmodels/autotests/kdescendantentitiesproxymodeltest.cpp  
>   tier1/itemmodels/autotests/kdescendantsproxymodeltest.cpp  
>   tier1/itemmodels/autotests/klinkitemselectionmodeltest.h  
>   tier1/itemmodels/autotests/klinkitemselectionmodeltest.cpp  
>   tier1/itemmodels/autotests/kselectionproxymodeltest.cpp  
>   tier1/itemmodels/autotests/kselectionproxymodeltestsuite.h  
>   tier1/itemmodels/autotests/kselectionproxymodeltestsuite.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/CMakeLists.txt  
>   tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbdirectionwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbdirectionwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbnavigationwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbnavigationwidget.cpp 
>  
>   tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbswidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbswidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/checkablewidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/checkablewidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/descendantpmwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/descendantpmwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/kidentityproxymodelwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/kidentityproxymodelwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/kreparentingproxymodel.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/kreparentingproxymodel.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/lessthanwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/lessthanwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/main.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/mainwindow.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/mainwindow.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/matchcheckingwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/matchcheckingwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/modelcommanderwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/modelcommanderwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/proxyitemselectionwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/proxyitemselectionwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/proxymodeltestwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/proxymodeltestwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/recursivefilterpmwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/recursivefilterpmwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/reparenting1.png  
>   tier1/itemmodels/autotests/proxymodeltestapp/reparenting2.png  
>   tier1/itemmodels/autotests/proxymodeltestapp/reparenting3.png  
>   tier1/itemmodels/autotests/proxymodeltestapp/reparentingpmwidget.h  
>   tier1/itemmodels/autotests/proxymodeltestapp/reparentingpmwidget.cpp  
>   tier1/itemmodels/autotests/proxymodeltestapp/scriptablereparentingwidget.h  
>   
> tier1/itemmodels/autotests/proxymodeltestapp/scriptablereparentingwidget.cpp  
>   t

Re: Review Request 114518: Rename the itemmodels frameworks to kitemmodels

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114518/
---

(Updated Dec. 17, 2013, 4:03 p.m.)


Review request for KDE Frameworks.


Changes
---

Fix KDE5PORTING.html


Repository: kdelibs


Description
---

Rename the itemmodels frameworks to kitemmodels, as "itemmodels" is considered 
too generic.


Diffs (updated)
-

  KDE5PORTING.html a727079 
  superbuild/CMakeLists.txt 146d34c 
  tier1/CMakeLists.txt b23e8ea 
  tier1/itemmodels/CMakeLists.txt 60105fc 
  tier1/itemmodels/COPYING.LIB  
  tier1/itemmodels/KF5ItemModelsConfig.cmake.in  
  tier1/itemmodels/Mainpage.dox  
  tier1/itemmodels/autotests/CMakeLists.txt 8beb0bf 
  tier1/itemmodels/autotests/bihash/CMakeLists.txt  
  tier1/itemmodels/autotests/bihash/aggregrator.xls  
  tier1/itemmodels/autotests/bihash/benchmarker.py  
  tier1/itemmodels/autotests/bihash/benchmarks.cpp  
  tier1/itemmodels/autotests/bihash/functionalitytest.cpp  
  tier1/itemmodels/autotests/bihash/script.py  
  tier1/itemmodels/autotests/kdescendantentitiesproxymodeltest.cpp  
  tier1/itemmodels/autotests/kdescendantsproxymodeltest.cpp  
  tier1/itemmodels/autotests/klinkitemselectionmodeltest.h  
  tier1/itemmodels/autotests/klinkitemselectionmodeltest.cpp  
  tier1/itemmodels/autotests/kselectionproxymodeltest.cpp  
  tier1/itemmodels/autotests/kselectionproxymodeltestsuite.h  
  tier1/itemmodels/autotests/kselectionproxymodeltestsuite.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/CMakeLists.txt  
  tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbdirectionwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbdirectionwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbnavigationwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbnavigationwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbswidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbswidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/checkablewidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/checkablewidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/descendantpmwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/descendantpmwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/kidentityproxymodelwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/kidentityproxymodelwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/kreparentingproxymodel.h  
  tier1/itemmodels/autotests/proxymodeltestapp/kreparentingproxymodel.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/lessthanwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/lessthanwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/main.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/mainwindow.h  
  tier1/itemmodels/autotests/proxymodeltestapp/mainwindow.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/matchcheckingwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/matchcheckingwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/modelcommanderwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/modelcommanderwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/proxyitemselectionwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/proxyitemselectionwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/proxymodeltestwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/proxymodeltestwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/recursivefilterpmwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/recursivefilterpmwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/reparenting1.png  
  tier1/itemmodels/autotests/proxymodeltestapp/reparenting2.png  
  tier1/itemmodels/autotests/proxymodeltestapp/reparenting3.png  
  tier1/itemmodels/autotests/proxymodeltestapp/reparentingpmwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/reparentingpmwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/scriptablereparentingwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/scriptablereparentingwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/selectionpmwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/selectionpmwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/statesaverwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/statesaverwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestsuite/CMakeLists.txt  
  tier1/itemmodels/autotests/proxymodeltestsuite/dynamictreemodel.h  
  tier1/itemmodels/autotests/proxymodeltestsuite/dynamictreemodel.cpp  
  tier1/itemmodels/autotests/proxymodeltestsuite/dynamictreewidget.h  
  tier1/itemmodels/autotests/proxymodeltestsuite/dynamictreewidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestsuite/eventlogger.qrc  
  tier1/itemmodels/autotests/proxymodeltestsuite/eventloggerregist

Re: Review Request 114512: Move Qt imageformat .desktop files to kde4support

[David Faure]

On Tuesday 17 December 2013 14:52:56 Alex Merry wrote:
> Except I can't, because of Ben's push blocking :-)

Aurélien, Kévin and I have superpowers :)

Stuff that needs moving between frameworks, or renaming actual frameworks, is 
a lot easier to handle before splitting, so we're doing that today, then Ben 
run the splitting script again.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 114518: Rename the itemmodels frameworks to kitemmodels

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114518/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Rename the itemmodels frameworks to kitemmodels, as "itemmodels" is considered 
too generic.


Diffs
-

  tier1/itemmodels/autotests/bihash/CMakeLists.txt  
  tier1/itemmodels/autotests/CMakeLists.txt 8beb0bf 
  tier1/itemmodels/Mainpage.dox  
  tier1/itemmodels/COPYING.LIB  
  tier1/itemmodels/KF5ItemModelsConfig.cmake.in  
  tier1/itemmodels/CMakeLists.txt 60105fc 
  superbuild/CMakeLists.txt 146d34c 
  tier1/CMakeLists.txt b23e8ea 
  KDE5PORTING.html a727079 
  tier1/itemmodels/autotests/bihash/aggregrator.xls  
  tier1/itemmodels/autotests/bihash/benchmarker.py  
  tier1/itemmodels/autotests/bihash/benchmarks.cpp  
  tier1/itemmodels/autotests/bihash/functionalitytest.cpp  
  tier1/itemmodels/autotests/bihash/script.py  
  tier1/itemmodels/autotests/kdescendantentitiesproxymodeltest.cpp  
  tier1/itemmodels/autotests/kdescendantsproxymodeltest.cpp  
  tier1/itemmodels/autotests/klinkitemselectionmodeltest.h  
  tier1/itemmodels/autotests/klinkitemselectionmodeltest.cpp  
  tier1/itemmodels/autotests/kselectionproxymodeltest.cpp  
  tier1/itemmodels/autotests/kselectionproxymodeltestsuite.h  
  tier1/itemmodels/autotests/kselectionproxymodeltestsuite.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/CMakeLists.txt  
  tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbdirectionwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbdirectionwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbnavigationwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbnavigationwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbswidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbswidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/checkablewidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/checkablewidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/descendantpmwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/descendantpmwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/kidentityproxymodelwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/kidentityproxymodelwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/kreparentingproxymodel.h  
  tier1/itemmodels/autotests/proxymodeltestapp/kreparentingproxymodel.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/lessthanwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/lessthanwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/main.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/mainwindow.h  
  tier1/itemmodels/autotests/proxymodeltestapp/mainwindow.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/matchcheckingwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/matchcheckingwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/modelcommanderwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/modelcommanderwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/proxyitemselectionwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/proxyitemselectionwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/proxymodeltestwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/proxymodeltestwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/recursivefilterpmwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/recursivefilterpmwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/reparenting1.png  
  tier1/itemmodels/autotests/proxymodeltestapp/reparenting2.png  
  tier1/itemmodels/autotests/proxymodeltestapp/reparenting3.png  
  tier1/itemmodels/autotests/proxymodeltestapp/reparentingpmwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/reparentingpmwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/scriptablereparentingwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/scriptablereparentingwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/selectionpmwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/selectionpmwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestapp/statesaverwidget.h  
  tier1/itemmodels/autotests/proxymodeltestapp/statesaverwidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestsuite/CMakeLists.txt  
  tier1/itemmodels/autotests/proxymodeltestsuite/dynamictreemodel.h  
  tier1/itemmodels/autotests/proxymodeltestsuite/dynamictreemodel.cpp  
  tier1/itemmodels/autotests/proxymodeltestsuite/dynamictreewidget.h  
  tier1/itemmodels/autotests/proxymodeltestsuite/dynamictreewidget.cpp  
  tier1/itemmodels/autotests/proxymodeltestsuite/eventlogger.qrc  
  tier1/itemmodels/autotests/proxymodeltestsuite/eventloggerregister.h  
  tier1/itemmodels/autotests/proxymodeltestsuite/eventloggerregister.cpp  
  tie

Re: migration KIcon to QIcon

[Michal Humpula]

Thanks Aleix! The KDE_FULL_SESSION=true fixed the thing:)

Would be nice to add it to the list of variables in "Runtime setup" section at 
http://community.kde.org/Frameworks/Building. I've completely missed it in
"Running unit tests" one:)

Cheers
Michal

On Tuesday 17 of December 2013 14:56:46 Aleix Pol wrote:
> On Mon, Dec 16, 2013 at 5:18 PM, Michal Humpula 
wrote:
> > Hi there,
> > 
> > have a small glitch with icon loading on frameworks. If I understand
> > correctly, the migration path for KIcon is QIcon::fromTheme, right?
> > 
> > Unfortunately this is giving me empty results, which might be caused by
> > QIcon::themeName() giving me empty string. If I configure the theme
> > manually,
> > i.e. by calling QIcon::setThemeName("oxygen"), everything works fine,
> > icons
> > are displayed again.
> > 
> > The "kcmshell5 icons" is showing me the selected oxygen icons, though.
> > 
> > Any idea what my be missing/misconfigured in my installation?
> > 
> > frameworks: latest git
> > Qt: v5.2
> > system: Debian unstable
> > 
> > Cheers
> > 
> > Michal
> > 
> > ___
> > Kde-frameworks-devel mailing list
> > Kde-frameworks-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
> 
> Maybe you should make sure the correct QPA is called? If it is, we should
> probably do the setThemeName from the QPA You can find the code in
> tier4/frameworksintegration.
> Also, make sure all environment variables are set,
> especially KDE_FULL_SESSION=true.
> 
> Cheers!
> Aleix

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: framework names (Re: Let's get in release mode!)

[Alex Merry]

On 17/12/13 12:57, Aurélien Gâteau wrote:
>> I guess the question is - what does this module actually bring. I
>> assume, a consistent look-n-feel for KDE-produced api docs, right?
> 
> Yes. It also goes a bit further by doing things like generating menus
> in the sidebar and handling cross-doxygen search (though that bit could
> use some improvements). It should at some point include the work I did
> on dependency diagram generation.

It almost sounds like this is more sysadmin-ish than framework-ish...

Alex

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114512: Move Qt imageformat .desktop files to kde4support

[Alex Merry]

> On Dec. 17, 2013, 2:50 p.m., David Faure wrote:
> > Ship It!

Except I can't, because of Ben's push blocking :-)


- Alex


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114512/#review45866
---


On Dec. 17, 2013, 2:52 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114512/
> ---
> 
> (Updated Dec. 17, 2013, 2:52 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Move Qt imageformat .desktop files to kde4support
> 
> These files are installed for the benefit of KImageIO in KDE4Support.
> The ones for imageformat plugins in Qt should therefore be installed by
> kde4support itself.
> 
> 
> Diffs
> -
> 
>   tier4/kde4support/src/kio/imageformats/CMakeLists.txt PRE-CREATION 
>   tier4/kde4support/src/CMakeLists.txt 
> 467e8378e555139774924f053b477050ebba9f5c 
>   tier1/kimageformats/src/imageformats/xpm.desktop  
>   tier1/kimageformats/src/imageformats/xbm.desktop  
>   tier1/kimageformats/src/imageformats/wbmp.desktop  
>   tier1/kimageformats/src/imageformats/tiff.desktop  
>   tier1/kimageformats/src/imageformats/svg+xml.desktop  
>   tier1/kimageformats/src/imageformats/svg+xml-compressed.desktop  
>   tier1/kimageformats/src/imageformats/qimageio_plugin.desktop  
>   tier1/kimageformats/src/imageformats/ppm.desktop  
>   tier1/kimageformats/src/imageformats/png.desktop  
>   tier1/kimageformats/src/imageformats/pgm.desktop  
>   tier1/kimageformats/src/imageformats/pbm.desktop  
>   tier1/kimageformats/src/imageformats/mng.desktop  
>   tier1/kimageformats/src/imageformats/jpeg.desktop  
>   tier1/kimageformats/src/imageformats/gif.desktop  
>   tier1/kimageformats/src/imageformats/ico.desktop  
>   tier1/kimageformats/src/imageformats/bmp.desktop  
>   tier1/kimageformats/src/imageformats/CMakeLists.txt 
> 614bba078ddc828e4d4f5b1a1ce3f6678248dc99 
> 
> Diff: http://git.reviewboard.kde.org/r/114512/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114512: Move Qt imageformat .desktop files to kde4support

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114512/#review45868
---


This review has been submitted with commit 
24f5d19bfd4a622b4cb7571520ec0deddd15af9a by Aurélien Gâteau on behalf of Alex 
Merry to branch frameworks.

- Commit Hook


On Dec. 16, 2013, 9:13 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114512/
> ---
> 
> (Updated Dec. 16, 2013, 9:13 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Move Qt imageformat .desktop files to kde4support
> 
> These files are installed for the benefit of KImageIO in KDE4Support.
> The ones for imageformat plugins in Qt should therefore be installed by
> kde4support itself.
> 
> 
> Diffs
> -
> 
>   tier4/kde4support/src/kio/imageformats/CMakeLists.txt PRE-CREATION 
>   tier4/kde4support/src/CMakeLists.txt 
> 467e8378e555139774924f053b477050ebba9f5c 
>   tier1/kimageformats/src/imageformats/xpm.desktop  
>   tier1/kimageformats/src/imageformats/xbm.desktop  
>   tier1/kimageformats/src/imageformats/wbmp.desktop  
>   tier1/kimageformats/src/imageformats/tiff.desktop  
>   tier1/kimageformats/src/imageformats/svg+xml.desktop  
>   tier1/kimageformats/src/imageformats/svg+xml-compressed.desktop  
>   tier1/kimageformats/src/imageformats/qimageio_plugin.desktop  
>   tier1/kimageformats/src/imageformats/ppm.desktop  
>   tier1/kimageformats/src/imageformats/png.desktop  
>   tier1/kimageformats/src/imageformats/pgm.desktop  
>   tier1/kimageformats/src/imageformats/pbm.desktop  
>   tier1/kimageformats/src/imageformats/mng.desktop  
>   tier1/kimageformats/src/imageformats/jpeg.desktop  
>   tier1/kimageformats/src/imageformats/gif.desktop  
>   tier1/kimageformats/src/imageformats/ico.desktop  
>   tier1/kimageformats/src/imageformats/bmp.desktop  
>   tier1/kimageformats/src/imageformats/CMakeLists.txt 
> 614bba078ddc828e4d4f5b1a1ce3f6678248dc99 
> 
> Diff: http://git.reviewboard.kde.org/r/114512/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114512: Move Qt imageformat .desktop files to kde4support

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114512/
---

(Updated Dec. 17, 2013, 2:52 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Move Qt imageformat .desktop files to kde4support

These files are installed for the benefit of KImageIO in KDE4Support.
The ones for imageformat plugins in Qt should therefore be installed by
kde4support itself.


Diffs
-

  tier4/kde4support/src/kio/imageformats/CMakeLists.txt PRE-CREATION 
  tier4/kde4support/src/CMakeLists.txt 467e8378e555139774924f053b477050ebba9f5c 
  tier1/kimageformats/src/imageformats/xpm.desktop  
  tier1/kimageformats/src/imageformats/xbm.desktop  
  tier1/kimageformats/src/imageformats/wbmp.desktop  
  tier1/kimageformats/src/imageformats/tiff.desktop  
  tier1/kimageformats/src/imageformats/svg+xml.desktop  
  tier1/kimageformats/src/imageformats/svg+xml-compressed.desktop  
  tier1/kimageformats/src/imageformats/qimageio_plugin.desktop  
  tier1/kimageformats/src/imageformats/ppm.desktop  
  tier1/kimageformats/src/imageformats/png.desktop  
  tier1/kimageformats/src/imageformats/pgm.desktop  
  tier1/kimageformats/src/imageformats/pbm.desktop  
  tier1/kimageformats/src/imageformats/mng.desktop  
  tier1/kimageformats/src/imageformats/jpeg.desktop  
  tier1/kimageformats/src/imageformats/gif.desktop  
  tier1/kimageformats/src/imageformats/ico.desktop  
  tier1/kimageformats/src/imageformats/bmp.desktop  
  tier1/kimageformats/src/imageformats/CMakeLists.txt 
614bba078ddc828e4d4f5b1a1ce3f6678248dc99 

Diff: http://git.reviewboard.kde.org/r/114512/diff/


Testing
---


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114512: Move Qt imageformat .desktop files to kde4support

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114512/#review45866
---

Ship it!


Ship It!

- David Faure


On Dec. 16, 2013, 9:13 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114512/
> ---
> 
> (Updated Dec. 16, 2013, 9:13 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Move Qt imageformat .desktop files to kde4support
> 
> These files are installed for the benefit of KImageIO in KDE4Support.
> The ones for imageformat plugins in Qt should therefore be installed by
> kde4support itself.
> 
> 
> Diffs
> -
> 
>   tier4/kde4support/src/kio/imageformats/CMakeLists.txt PRE-CREATION 
>   tier4/kde4support/src/CMakeLists.txt 
> 467e8378e555139774924f053b477050ebba9f5c 
>   tier1/kimageformats/src/imageformats/xpm.desktop  
>   tier1/kimageformats/src/imageformats/xbm.desktop  
>   tier1/kimageformats/src/imageformats/wbmp.desktop  
>   tier1/kimageformats/src/imageformats/tiff.desktop  
>   tier1/kimageformats/src/imageformats/svg+xml.desktop  
>   tier1/kimageformats/src/imageformats/svg+xml-compressed.desktop  
>   tier1/kimageformats/src/imageformats/qimageio_plugin.desktop  
>   tier1/kimageformats/src/imageformats/ppm.desktop  
>   tier1/kimageformats/src/imageformats/png.desktop  
>   tier1/kimageformats/src/imageformats/pgm.desktop  
>   tier1/kimageformats/src/imageformats/pbm.desktop  
>   tier1/kimageformats/src/imageformats/mng.desktop  
>   tier1/kimageformats/src/imageformats/jpeg.desktop  
>   tier1/kimageformats/src/imageformats/gif.desktop  
>   tier1/kimageformats/src/imageformats/ico.desktop  
>   tier1/kimageformats/src/imageformats/bmp.desktop  
>   tier1/kimageformats/src/imageformats/CMakeLists.txt 
> 614bba078ddc828e4d4f5b1a1ce3f6678248dc99 
> 
> Diff: http://git.reviewboard.kde.org/r/114512/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: migration KIcon to QIcon

[Aleix Pol]

On Mon, Dec 16, 2013 at 5:18 PM, Michal Humpula wrote:

> Hi there,
>
> have a small glitch with icon loading on frameworks. If I understand
> correctly, the migration path for KIcon is QIcon::fromTheme, right?
>
> Unfortunately this is giving me empty results, which might be caused by
> QIcon::themeName() giving me empty string. If I configure the theme
> manually,
> i.e. by calling QIcon::setThemeName("oxygen"), everything works fine, icons
> are displayed again.
>
> The "kcmshell5 icons" is showing me the selected oxygen icons, though.
>
> Any idea what my be missing/misconfigured in my installation?
>
> frameworks: latest git
> Qt: v5.2
> system: Debian unstable
>
> Cheers
>
> Michal
>
> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>

Maybe you should make sure the correct QPA is called? If it is, we should
probably do the setThemeName from the QPA You can find the code in
tier4/frameworksintegration.
Also, make sure all environment variables are set,
especially KDE_FULL_SESSION=true.

Cheers!
Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: framework names (Re: Let's get in release mode!)

[Aurélien Gâteau]

On Tue, 17 Dec 2013 13:25:02 +0100, David Faure wrote:

On Tuesday 17 December 2013 23:27:39 Ben Cooksley wrote:

Other than apidox, I was also concerned about frameworkintegration,
itemmodels, itemviews and dnssd.


Let's rename the repos to kitemmodels, kitemviews and kdnssd,
this will be in line with karchive and most others (this doesn't 
change the

actual framework target name or the library name).
Anyone up for doing this today?

Aurélien: so apidox is useful to all kde software?


It is used to build all docs on api.kde.org, which covers most of KDE 
SC

I think.


Then it could be kdeapidox or kapidox or something like that, right?


Both are equally undescriptive, but I don't have any better 
suggestions,

so I am fine with either :)


I guess the question is - what does this module actually bring. I
assume, a consistent look-n-feel for KDE-produced api docs, right?


Yes. It also goes a bit further by doing things like generating menus
in the sidebar and handling cross-doxygen search (though that bit could
use some improvements). It should at some point include the work I did
on dependency diagram generation.

Aurélien

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

framework names (Re: Let's get in release mode!)

[David Faure]

On Tuesday 17 December 2013 23:27:39 Ben Cooksley wrote:
> Other than apidox, I was also concerned about frameworkintegration,
> itemmodels, itemviews and dnssd.

Let's rename the repos to kitemmodels, kitemviews and kdnssd,
this will be in line with karchive and most others (this doesn't change the 
actual framework target name or the library name).
Anyone up for doing this today?

Aurélien: so apidox is useful to all kde software? Then it could be kdeapidox 
or kapidox or something like that, right?
I guess the question is - what does this module actually bring. I assume, a 
consistent look-n-feel for KDE-produced api docs, right?

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114478: Add kshareddatacache.h include

[Alex Merry]

> On Dec. 15, 2013, 9:22 p.m., Kevin Ottens wrote:
> > It is in fact intended that way as kguiaddons isn't supposed to include 
> > stuff coming from kcoreaddons (yeah I know it's slightly convoluted in that 
> > particular case).
> 
> Albert Astals Cid wrote:
> So basically we have a header that when you include it, it breaks your 
> compilation. Do you really think this is a good idea?

If KSharedPixmapCacheMixin is never intended to be used directly, but only via 
KImageCache, I think we should really have the #include; not having KGuiAddons 
depend on KCoreAddons is one thing, but that header is useless without 
KSharedDataCache.

Essentially, the current way is broken unless you add a non-obvious 
KSharedDataCache include to your code, regardless of whether you have 
KCoreAddons added to your project.  Albert's suggestion would make the common 
case work (where you have KCoreAddons).

Of course, there are other tricks you could pull, such as having the 
KF5::CoreAddons target add -DHAS_K_SHARED_DATA_CACHE to the compiler flags, and 
only do the #include in the presence of that define.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114478/#review45732
---


On Dec. 15, 2013, 4:15 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114478/
> ---
> 
> (Updated Dec. 15, 2013, 4:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Since
> #define KImageCache KSharedPixmapCacheMixin
> I think it is only fair that kimagecache.h includes kshareddatacache.h 
> otherwise a 
> #include 
> is not enough to use it.
> 
> 
> Diffs
> -
> 
>   tier1/kguiaddons/src/util/kimagecache.h 682aa66 
> 
> Diff: http://git.reviewboard.kde.org/r/114478/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114496: Rename kdewidgets to kf5designerplugin

[Alex Merry]

> On Dec. 17, 2013, 10:35 a.m., Commit Hook wrote:
> > This review has been submitted with commit 
> > dea0dcccb922e528a1c2f2a2bd3a102cf756d3e9 by David Faure on behalf of Alex 
> > Merry to branch frameworks.

Thanks!


- Alex


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114496/#review45853
---


On Dec. 17, 2013, 10:35 a.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114496/
> ---
> 
> (Updated Dec. 17, 2013, 10:35 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Rename kdewidgets to kf5designerplugin
> 
> This includes renaming makekdewidgets to kgendesignerplugin.
> 
> 
> Just throwing this at reviewboard before I dash for a train.
> 
> 
> Diffs
> -
> 
>   superbuild/CMakeLists.txt b53cae64698562588f39ed28b2f30bf0a1f46809 
>   tier3/CMakeLists.txt 374396b3909d5a71dff6d891249ab33194a45522 
>   tier3/kdesignerplugin/KF5DesignerPluginConfig.cmake PRE-CREATION 
>   tier3/kdesignerplugin/Mainpage.dox PRE-CREATION 
>   tier3/kdesignerplugin/docs/CMakeLists.txt PRE-CREATION 
>   tier3/kdesignerplugin/docs/kgendesignerplugin/CMakeLists.txt PRE-CREATION 
>   
> tier3/kdesignerplugin/docs/kgendesignerplugin/man-kgendesignerplugin.1.docbook
>  PRE-CREATION 
>   tier3/kdesignerplugin/src/CMakeLists.txt PRE-CREATION 
>   tier3/kdesignerplugin/tests/README PRE-CREATION 
>   tier3/kdewidgets/CMakeLists.txt 87c3d5484dfb86018cdd203807588ea6ebd6ac31 
>   tier3/kdewidgets/KDEWidgetsConfig.cmake 
> d38c875c67a3073e7634bd6f873a38411127b759 
>   tier3/kdewidgets/KDEWidgetsMacros.cmake 
> 92d2960a7dfe1645d7c75e3dc6690d78b50706d8 
>   tier3/kdewidgets/Mainpage.dox 85da237c9d4367a37b9b0750565d42e1e73d1ba4 
>   tier3/kdewidgets/docs/CMakeLists.txt 
> 2b38f53f807c528fdcd6ea128567f6087bd8c673 
>   tier3/kdewidgets/docs/makekdewidgets/CMakeLists.txt 
> c283b926f542402d80e22cc42406b119e400a05f 
>   tier3/kdewidgets/docs/makekdewidgets/man-makekdewidgets.1.docbook 
> cab0c5b51f2bb5be29960f43fe6fb940fffb5402 
>   tier3/kdewidgets/src/AUTHORS  
>   tier3/kdewidgets/src/CMakeLists.txt 
> e8626c84227a2ccd0459c5732a51e9ecea49f699 
>   tier3/kdewidgets/src/README  
>   tier3/kdewidgets/src/classpreviews.h  
>   tier3/kdewidgets/src/classpreviews.cpp  
>   tier3/kdewidgets/src/kde.widgets 7bcc669d14ed40da6217d09296e25d60a59413b7 
>   tier3/kdewidgets/src/kdewebkit.widgets  
>   tier3/kdewidgets/src/kdewebkitwidgets.qrc  
>   tier3/kdewidgets/src/kdewidgets.qrc  
>   tier3/kdewidgets/src/makekdewidgets.cpp 
> d20e49956a939a06fe3bc2280d57c5c6d31fe24c 
>   tier3/kdewidgets/src/pics/CMakeLists.txt 
> 688224a6a1ca9f68b7e7f918fa6b8aee3dbe6180 
>   tier3/kdewidgets/src/pics/k3iconview.png  
>   tier3/kdewidgets/src/pics/k3listview.png  
>   tier3/kdewidgets/src/pics/kactionselector.png  
>   tier3/kdewidgets/src/pics/kactivelabel.png  
>   tier3/kdewidgets/src/pics/kcharselect.png  
>   tier3/kdewidgets/src/pics/kcmodule.png  
>   tier3/kdewidgets/src/pics/kcolorbutton.png  
>   tier3/kdewidgets/src/pics/kcolorcombo.png  
>   tier3/kdewidgets/src/pics/kcombobox.png  
>   tier3/kdewidgets/src/pics/kdatepicker.png  
>   tier3/kdewidgets/src/pics/kdatetable.png  
>   tier3/kdewidgets/src/pics/kdualcolorbutton.png  
>   tier3/kdewidgets/src/pics/keditlistwidget.png  
>   tier3/kdewidgets/src/pics/kfontcombo.png  
>   tier3/kdewidgets/src/pics/kfontrequester.png  
>   tier3/kdewidgets/src/pics/kgradientselector.png  
>   tier3/kdewidgets/src/pics/khistorycombo.png  
>   tier3/kdewidgets/src/pics/khsselector.png  
>   tier3/kdewidgets/src/pics/kiconbutton.png  
>   tier3/kdewidgets/src/pics/kkeybutton.png  
>   tier3/kdewidgets/src/pics/kled.png  
>   tier3/kdewidgets/src/pics/klineedit.png  
>   tier3/kdewidgets/src/pics/klistbox.png  
>   tier3/kdewidgets/src/pics/kpalettetable.png  
>   tier3/kdewidgets/src/pics/kpasswordedit.png  
>   tier3/kdewidgets/src/pics/kruler.png  
>   tier3/kdewidgets/src/pics/ksqueezedtextlabel.png  
>   tier3/kdewidgets/src/pics/ktextedit.png  
>   tier3/kdewidgets/src/pics/kurlcomborequester.png  
>   tier3/kdewidgets/src/pics/kurllabel.png  
>   tier3/kdewidgets/src/pics/kurlrequester.png  
>   tier3/kdewidgets/tests/CMakeLists.txt  
>   tier3/kdewidgets/tests/README 9dd2132fa7c3601ae04f243a5996aa809b42f7bf 
>   tier3/kdewidgets/tests/sums  
>   tier3/kdewidgets/tests/test.widgets  
>   tier4/kde4support/CMakeLists.txt ccbffd24ede13d5ae6d8386a4aac1853018fcc97 
>   tier4/kde4support/cmake/modules/KDE4Macros.cmake 
> ddfd374607d0eef436fdd6c9e408cd98e59181ae 
>   tier4/kde4support/src/CMakeLists.txt 
> 467e8378e555139774924f053b477050ebba9f5c 
>   tier4/kde4support/src/KDEUIMacros.cmake 
> 31a180c1aab1

Re: Let's get in release mode!

[Martin Klapetek]

On Tue, Dec 17, 2013 at 11:39 AM, David Faure  wrote:

> On Tuesday 17 December 2013 23:27:39 Ben Cooksley wrote:
> > Other than apidox, I was also concerned about frameworkintegration,
> > itemmodels, itemviews and dnssd. The rest of the names are quite
> > descriptive as to what they contain and are fine.
>
> Yeah, itemmodels and itemviews often come up as not descriptive enough,
> but nobody has fixed that. What could we do? kf5itemmodels, kf5itemviews?
>

Fwiw, I'd suggest to remove the "5" from repo name, because when we'll do
kf6 (couple years away, but still..), we'll have to either rename the repos
again or create set of new repos.

Cheers
-- 
Martin Klapetek | KDE Developer
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #1871

[KDE CI System]

See 

Changes:

[agateau] KDE4_ENABLE_EXCEPTIONS => KDE_ENABLE_EXCEPTIONS

[agateau] Fix line endings

--
[...truncated 303 lines...]
-- Looking for include file sys/time.h - found
-- Looking for include file arpa/nameser_compat.h
-- Looking for include file arpa/nameser_compat.h - not found
-- Looking for include file arpa/nameser8_compat.h
-- Looking for include file arpa/nameser8_compat.h - not found
-- Looking for include files sys/types.h, netinet/in.h
-- Looking for include files sys/types.h, netinet/in.h - found
-- Looking for res_init in resolv
-- Looking for res_init in resolv - not found
-- Looking for __res_init in resolv
-- Looking for __res_init in resolv - found
-- Looking for gethostbyname in nsl
-- Looking for gethostbyname in nsl - found
-- Looking for include files sys/types.h, libutil.h
-- Looking for include files sys/types.h, libutil.h - not found
-- Looking for include file util.h
-- Looking for include file util.h - not found
-- Looking for include file termios.h
-- Looking for include file termios.h - found
-- Looking for include file termio.h
-- Looking for include file termio.h - found
-- Looking for include file pty.h
-- Looking for include file pty.h - found
-- Looking for include file sys/stropts.h
-- Looking for include file sys/stropts.h - found
-- Looking for include file sys/filio.h
-- Looking for include file sys/filio.h - not found
-- Looking for addToUtmp in utempter
-- Looking for addToUtmp in utempter - found
-- Looking for include file utempter.h
-- Looking for include file utempter.h - found
-- Looking for openpty
-- Looking for openpty - not found
-- Looking for openpty in util
-- Looking for openpty in util - found
-- Looking for ptsname
-- Looking for ptsname - found
-- Looking for setpriority
-- Looking for setpriority - found
-- Looking for getpeereid
-- Looking for getpeereid - not found
-- Looking for initgroups
-- Looking for initgroups - found
-- Looking for stddef.h
-- Looking for stddef.h - found
-- Check size of struct ucred
-- Check size of struct ucred - failed
CMake Error at tier4/kde4support/CMakeLists.txt:51 (include):
  include could not find load file:





-- Looking for include file time.h
-- Looking for include file time.h - found
-- Check size of time_t
-- Check size of time_t - done
-- Performing Test HAVE_STRUCT_TM_TM_ZONE
-- Performing Test HAVE_STRUCT_TM_TM_ZONE - Success
-- Looking for dgettext
-- Looking for dgettext - found
-- Found Libintl: /usr/include  
-- Performing Test HAVE_QSSLSOCKET
-- Performing Test HAVE_QSSLSOCKET - Success
-- Looking for 3 include files sys/types.h, ..., net/if.h
-- Looking for 3 include files sys/types.h, ..., net/if.h - found
-- Looking for include file stropts.h
-- Looking for include file stropts.h - found
-- Looking for include file paths.h
-- Looking for include file paths.h - found
-- Looking for fdatasync
-- Looking for fdatasync - found
-- Looking for inet_pton
-- Looking for inet_pton - found
-- Looking for inet_ntop
-- Looking for inet_ntop - found
-- Looking for getprotobyname_r
-- Looking for getprotobyname_r - found
-- Looking for poll
-- Looking for poll - found
-- Looking for getservbyname_r
-- Looking for getservbyname_r - found
-- Looking for getservbyport_r
-- Looking for getservbyport_r - found
-- Looking for gethostbyname2
-- Looking for gethostbyname2 - found
-- Looking for gethostbyname2_r
-- Looking for gethostbyname2_r - found
-- Looking for gethostbyname
-- Looking for gethostbyname - found
-- Looking for gethostbyname_r
-- Looking for gethostbyname_r - found
-- Looking for if_nametoindex
-- Looking for if_nametoindex - found
-- Performing Test HAVE_GETSERVBYNAME_R_PROTO
-- Performing Test HAVE_GETSERVBYNAME_R_PROTO - Success
-- Looking for freeaddrinfo
-- Looking for freeaddrinfo - found
-- Looking for getnameinfo
-- Looking for getnameinfo - found
-- Looking for getaddrinfo
-- Looking for getaddrinfo - found
-- Looking for res_init
-- Looking for res_init - found
-- Performing Test HAVE_GAI_STRERROR_PROTO
-- Performing Test HAVE_GAI_STRERROR_PROTO - Success
-- Check size of struct addrinfo
-- Check size of struct addrinfo - done
-- Check size of struct sockaddr_in6
-- Check size of struct sockaddr_in6 - done
-- Performing Test HAVE_RES_INIT_PROTO
-- Performing Test HAVE_RES_INIT_PROTO - Success
-- Performing Test HAVE_GOOD_GETADDRINFO
-- Performing Test HAVE_GOOD_GETADDRINFO - Success
-- Performing Test GIF_GifFileType_UserData
-- Performing Test GIF_GifFileType_UserData - Success
-- Found GIF: /usr/lib64/libgif.so (found version "4") 
-- Found PNG: /usr/lib64/libpng.so (found version "1.5.13") 
-- 
-- The following features have been enabled:

 * X Screensaver Extension (libXss) , Support for KIdleTime (fallback mode)
 * X Sync Extension (libXext) , Efficient operation of KI

Re: Review Request 114502: KDE4_ENABLE_EXCEPTIONS => KDE_ENABLE_EXCEPTIONS

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114502/
---

(Updated Dec. 17, 2013, 10:42 a.m.)


Status
--

This change has been marked as submitted.


Review request for Build System and KDE Frameworks.


Repository: kdelibs


Description
---

Use the new KDE_ENABLE_EXCEPTIONS flag, define KDE4_ENABLE_EXCEPTIONS in 
KDE4Support. Needs https://git.reviewboard.kde.org/r/114501/


Diffs
-

  tier4/khtml/src/CMakeLists.txt a8eb322 
  tier4/kde4support/cmake/modules/FindKDE4Internal.cmake e3f8c63 
  tier1/threadweaver/src/Weaver/CMakeLists.txt 8e18b46 
  tier3/kio/src/kpac/CMakeLists.txt 57d5694 
  tier1/kimageformats/src/imageformats/CMakeLists.txt 614bba0 

Diff: http://git.reviewboard.kde.org/r/114502/diff/


Testing
---

kdelibs builds, even after removing the KDE4_ENABLE_EXCEPTIONS definition from 
ECM (see ECM review).


Thanks,

Aurélien Gâteau

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114502: KDE4_ENABLE_EXCEPTIONS => KDE_ENABLE_EXCEPTIONS

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114502/#review45854
---


This review has been submitted with commit 
d18d3cfc5516c9fdc2415ea4ee60c6ac588005bb by Aurélien Gâteau to branch 
frameworks.

- Commit Hook


On Dec. 16, 2013, 5:10 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114502/
> ---
> 
> (Updated Dec. 16, 2013, 5:10 p.m.)
> 
> 
> Review request for Build System and KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Use the new KDE_ENABLE_EXCEPTIONS flag, define KDE4_ENABLE_EXCEPTIONS in 
> KDE4Support. Needs https://git.reviewboard.kde.org/r/114501/
> 
> 
> Diffs
> -
> 
>   tier4/khtml/src/CMakeLists.txt a8eb322 
>   tier4/kde4support/cmake/modules/FindKDE4Internal.cmake e3f8c63 
>   tier1/threadweaver/src/Weaver/CMakeLists.txt 8e18b46 
>   tier3/kio/src/kpac/CMakeLists.txt 57d5694 
>   tier1/kimageformats/src/imageformats/CMakeLists.txt 614bba0 
> 
> Diff: http://git.reviewboard.kde.org/r/114502/diff/
> 
> 
> Testing
> ---
> 
> kdelibs builds, even after removing the KDE4_ENABLE_EXCEPTIONS definition 
> from ECM (see ECM review).
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Let's get in release mode!

[David Faure]

On Tuesday 17 December 2013 23:27:39 Ben Cooksley wrote:
> Other than apidox, I was also concerned about frameworkintegration,
> itemmodels, itemviews and dnssd. The rest of the names are quite
> descriptive as to what they contain and are fine.

Yeah, itemmodels and itemviews often come up as not descriptive enough,
but nobody has fixed that. What could we do? kf5itemmodels, kf5itemviews?
But actually the frameworks are already called that way, right? So this is 
really just about the git repo? Which are in fact frameworks/itemmodels.git, 
in terms of projects.kde.org?

> kde4support is also problematic as it is very similar to kdesupport and
> could become confused with it.

Yeah, it's always been the case though (kde4support vs kdesupport).
People know what to find in kde4support, from its name, for historical 
reasons.

kdesupport, OTOH is kind of going away anyway, its contents should be 
framework-ified soon.

> kf5umbrella also seemed a little odd...

Better than "umbrella" :-)

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #1870

[KDE CI System]

See 

Changes:

[faure] Rename kdewidgets to kdesignerplugin

--
[...truncated 304 lines...]
-- Looking for include file sys/time.h - found
-- Looking for include file arpa/nameser_compat.h
-- Looking for include file arpa/nameser_compat.h - not found
-- Looking for include file arpa/nameser8_compat.h
-- Looking for include file arpa/nameser8_compat.h - not found
-- Looking for include files sys/types.h, netinet/in.h
-- Looking for include files sys/types.h, netinet/in.h - found
-- Looking for res_init in resolv
-- Looking for res_init in resolv - not found
-- Looking for __res_init in resolv
-- Looking for __res_init in resolv - found
-- Looking for gethostbyname in nsl
-- Looking for gethostbyname in nsl - found
-- Looking for include files sys/types.h, libutil.h
-- Looking for include files sys/types.h, libutil.h - not found
-- Looking for include file util.h
-- Looking for include file util.h - not found
-- Looking for include file termios.h
-- Looking for include file termios.h - found
-- Looking for include file termio.h
-- Looking for include file termio.h - found
-- Looking for include file pty.h
-- Looking for include file pty.h - found
-- Looking for include file sys/stropts.h
-- Looking for include file sys/stropts.h - found
-- Looking for include file sys/filio.h
-- Looking for include file sys/filio.h - not found
-- Looking for addToUtmp in utempter
-- Looking for addToUtmp in utempter - found
-- Looking for include file utempter.h
-- Looking for include file utempter.h - found
-- Looking for openpty
-- Looking for openpty - not found
-- Looking for openpty in util
-- Looking for openpty in util - found
-- Looking for ptsname
-- Looking for ptsname - found
-- Looking for setpriority
-- Looking for setpriority - found
-- Looking for getpeereid
-- Looking for getpeereid - not found
-- Looking for initgroups
-- Looking for initgroups - found
-- Looking for stddef.h
-- Looking for stddef.h - found
-- Check size of struct ucred
-- Check size of struct ucred - failed
CMake Error at tier4/kde4support/CMakeLists.txt:51 (include):
  include could not find load file:





-- Looking for include file time.h
-- Looking for include file time.h - found
-- Check size of time_t
-- Check size of time_t - done
-- Performing Test HAVE_STRUCT_TM_TM_ZONE
-- Performing Test HAVE_STRUCT_TM_TM_ZONE - Success
-- Looking for dgettext
-- Looking for dgettext - found
-- Found Libintl: /usr/include  
-- Performing Test HAVE_QSSLSOCKET
-- Performing Test HAVE_QSSLSOCKET - Success
-- Looking for 3 include files sys/types.h, ..., net/if.h
-- Looking for 3 include files sys/types.h, ..., net/if.h - found
-- Looking for include file stropts.h
-- Looking for include file stropts.h - found
-- Looking for include file paths.h
-- Looking for include file paths.h - found
-- Looking for fdatasync
-- Looking for fdatasync - found
-- Looking for inet_pton
-- Looking for inet_pton - found
-- Looking for inet_ntop
-- Looking for inet_ntop - found
-- Looking for getprotobyname_r
-- Looking for getprotobyname_r - found
-- Looking for poll
-- Looking for poll - found
-- Looking for getservbyname_r
-- Looking for getservbyname_r - found
-- Looking for getservbyport_r
-- Looking for getservbyport_r - found
-- Looking for gethostbyname2
-- Looking for gethostbyname2 - found
-- Looking for gethostbyname2_r
-- Looking for gethostbyname2_r - found
-- Looking for gethostbyname
-- Looking for gethostbyname - found
-- Looking for gethostbyname_r
-- Looking for gethostbyname_r - found
-- Looking for if_nametoindex
-- Looking for if_nametoindex - found
-- Performing Test HAVE_GETSERVBYNAME_R_PROTO
-- Performing Test HAVE_GETSERVBYNAME_R_PROTO - Success
-- Looking for freeaddrinfo
-- Looking for freeaddrinfo - found
-- Looking for getnameinfo
-- Looking for getnameinfo - found
-- Looking for getaddrinfo
-- Looking for getaddrinfo - found
-- Looking for res_init
-- Looking for res_init - found
-- Performing Test HAVE_GAI_STRERROR_PROTO
-- Performing Test HAVE_GAI_STRERROR_PROTO - Success
-- Check size of struct addrinfo
-- Check size of struct addrinfo - done
-- Check size of struct sockaddr_in6
-- Check size of struct sockaddr_in6 - done
-- Performing Test HAVE_RES_INIT_PROTO
-- Performing Test HAVE_RES_INIT_PROTO - Success
-- Performing Test HAVE_GOOD_GETADDRINFO
-- Performing Test HAVE_GOOD_GETADDRINFO - Success
-- Performing Test GIF_GifFileType_UserData
-- Performing Test GIF_GifFileType_UserData - Success
-- Found GIF: /usr/lib64/libgif.so (found version "4") 
-- Found PNG: /usr/lib64/libpng.so (found version "1.5.13") 
-- 
-- The following features have been enabled:

 * X Screensaver Extension (libXss) , Support for KIdleTime (fallback mode)
 * X Sync Extension (libXext) , Efficient operation of KIdleTime. STRONGLY 
RECOMMENDED
 * X Scree

Re: Review Request 114496: Rename kdewidgets to kf5designerplugin

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114496/
---

(Updated Dec. 17, 2013, 10:35 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Rename kdewidgets to kf5designerplugin

This includes renaming makekdewidgets to kgendesignerplugin.


Just throwing this at reviewboard before I dash for a train.


Diffs
-

  superbuild/CMakeLists.txt b53cae64698562588f39ed28b2f30bf0a1f46809 
  tier3/CMakeLists.txt 374396b3909d5a71dff6d891249ab33194a45522 
  tier3/kdesignerplugin/KF5DesignerPluginConfig.cmake PRE-CREATION 
  tier3/kdesignerplugin/Mainpage.dox PRE-CREATION 
  tier3/kdesignerplugin/docs/CMakeLists.txt PRE-CREATION 
  tier3/kdesignerplugin/docs/kgendesignerplugin/CMakeLists.txt PRE-CREATION 
  
tier3/kdesignerplugin/docs/kgendesignerplugin/man-kgendesignerplugin.1.docbook 
PRE-CREATION 
  tier3/kdesignerplugin/src/CMakeLists.txt PRE-CREATION 
  tier3/kdesignerplugin/tests/README PRE-CREATION 
  tier3/kdewidgets/CMakeLists.txt 87c3d5484dfb86018cdd203807588ea6ebd6ac31 
  tier3/kdewidgets/KDEWidgetsConfig.cmake 
d38c875c67a3073e7634bd6f873a38411127b759 
  tier3/kdewidgets/KDEWidgetsMacros.cmake 
92d2960a7dfe1645d7c75e3dc6690d78b50706d8 
  tier3/kdewidgets/Mainpage.dox 85da237c9d4367a37b9b0750565d42e1e73d1ba4 
  tier3/kdewidgets/docs/CMakeLists.txt 2b38f53f807c528fdcd6ea128567f6087bd8c673 
  tier3/kdewidgets/docs/makekdewidgets/CMakeLists.txt 
c283b926f542402d80e22cc42406b119e400a05f 
  tier3/kdewidgets/docs/makekdewidgets/man-makekdewidgets.1.docbook 
cab0c5b51f2bb5be29960f43fe6fb940fffb5402 
  tier3/kdewidgets/src/AUTHORS  
  tier3/kdewidgets/src/CMakeLists.txt e8626c84227a2ccd0459c5732a51e9ecea49f699 
  tier3/kdewidgets/src/README  
  tier3/kdewidgets/src/classpreviews.h  
  tier3/kdewidgets/src/classpreviews.cpp  
  tier3/kdewidgets/src/kde.widgets 7bcc669d14ed40da6217d09296e25d60a59413b7 
  tier3/kdewidgets/src/kdewebkit.widgets  
  tier3/kdewidgets/src/kdewebkitwidgets.qrc  
  tier3/kdewidgets/src/kdewidgets.qrc  
  tier3/kdewidgets/src/makekdewidgets.cpp 
d20e49956a939a06fe3bc2280d57c5c6d31fe24c 
  tier3/kdewidgets/src/pics/CMakeLists.txt 
688224a6a1ca9f68b7e7f918fa6b8aee3dbe6180 
  tier3/kdewidgets/src/pics/k3iconview.png  
  tier3/kdewidgets/src/pics/k3listview.png  
  tier3/kdewidgets/src/pics/kactionselector.png  
  tier3/kdewidgets/src/pics/kactivelabel.png  
  tier3/kdewidgets/src/pics/kcharselect.png  
  tier3/kdewidgets/src/pics/kcmodule.png  
  tier3/kdewidgets/src/pics/kcolorbutton.png  
  tier3/kdewidgets/src/pics/kcolorcombo.png  
  tier3/kdewidgets/src/pics/kcombobox.png  
  tier3/kdewidgets/src/pics/kdatepicker.png  
  tier3/kdewidgets/src/pics/kdatetable.png  
  tier3/kdewidgets/src/pics/kdualcolorbutton.png  
  tier3/kdewidgets/src/pics/keditlistwidget.png  
  tier3/kdewidgets/src/pics/kfontcombo.png  
  tier3/kdewidgets/src/pics/kfontrequester.png  
  tier3/kdewidgets/src/pics/kgradientselector.png  
  tier3/kdewidgets/src/pics/khistorycombo.png  
  tier3/kdewidgets/src/pics/khsselector.png  
  tier3/kdewidgets/src/pics/kiconbutton.png  
  tier3/kdewidgets/src/pics/kkeybutton.png  
  tier3/kdewidgets/src/pics/kled.png  
  tier3/kdewidgets/src/pics/klineedit.png  
  tier3/kdewidgets/src/pics/klistbox.png  
  tier3/kdewidgets/src/pics/kpalettetable.png  
  tier3/kdewidgets/src/pics/kpasswordedit.png  
  tier3/kdewidgets/src/pics/kruler.png  
  tier3/kdewidgets/src/pics/ksqueezedtextlabel.png  
  tier3/kdewidgets/src/pics/ktextedit.png  
  tier3/kdewidgets/src/pics/kurlcomborequester.png  
  tier3/kdewidgets/src/pics/kurllabel.png  
  tier3/kdewidgets/src/pics/kurlrequester.png  
  tier3/kdewidgets/tests/CMakeLists.txt  
  tier3/kdewidgets/tests/README 9dd2132fa7c3601ae04f243a5996aa809b42f7bf 
  tier3/kdewidgets/tests/sums  
  tier3/kdewidgets/tests/test.widgets  
  tier4/kde4support/CMakeLists.txt ccbffd24ede13d5ae6d8386a4aac1853018fcc97 
  tier4/kde4support/cmake/modules/KDE4Macros.cmake 
ddfd374607d0eef436fdd6c9e408cd98e59181ae 
  tier4/kde4support/src/CMakeLists.txt 467e8378e555139774924f053b477050ebba9f5c 
  tier4/kde4support/src/KDEUIMacros.cmake 
31a180c1aab14f22e6a157e8aabfa901db15081a 
  tier4/kde4support/src/kdedeprecated.widgets 
604358ac69ba8a8cfbdd8b41a796405fdddebd12 
  tier4/kde4support/src/pics/CMakeLists.txt 
c0e1c2064af67e9ad90d8f5e8a9c892208c6cda0 

Diff: http://git.reviewboard.kde.org/r/114496/diff/


Testing
---

CMake runs, nothing else tested.


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114496: Rename kdewidgets to kf5designerplugin

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114496/#review45853
---


This review has been submitted with commit 
dea0dcccb922e528a1c2f2a2bd3a102cf756d3e9 by David Faure on behalf of Alex Merry 
to branch frameworks.

- Commit Hook


On Dec. 16, 2013, 9:06 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114496/
> ---
> 
> (Updated Dec. 16, 2013, 9:06 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Rename kdewidgets to kf5designerplugin
> 
> This includes renaming makekdewidgets to kgendesignerplugin.
> 
> 
> Just throwing this at reviewboard before I dash for a train.
> 
> 
> Diffs
> -
> 
>   superbuild/CMakeLists.txt b53cae64698562588f39ed28b2f30bf0a1f46809 
>   tier3/CMakeLists.txt 374396b3909d5a71dff6d891249ab33194a45522 
>   tier3/kdesignerplugin/KF5DesignerPluginConfig.cmake PRE-CREATION 
>   tier3/kdesignerplugin/Mainpage.dox PRE-CREATION 
>   tier3/kdesignerplugin/docs/CMakeLists.txt PRE-CREATION 
>   tier3/kdesignerplugin/docs/kgendesignerplugin/CMakeLists.txt PRE-CREATION 
>   
> tier3/kdesignerplugin/docs/kgendesignerplugin/man-kgendesignerplugin.1.docbook
>  PRE-CREATION 
>   tier3/kdesignerplugin/src/CMakeLists.txt PRE-CREATION 
>   tier3/kdesignerplugin/tests/README PRE-CREATION 
>   tier3/kdewidgets/CMakeLists.txt 87c3d5484dfb86018cdd203807588ea6ebd6ac31 
>   tier3/kdewidgets/KDEWidgetsConfig.cmake 
> d38c875c67a3073e7634bd6f873a38411127b759 
>   tier3/kdewidgets/KDEWidgetsMacros.cmake 
> 92d2960a7dfe1645d7c75e3dc6690d78b50706d8 
>   tier3/kdewidgets/Mainpage.dox 85da237c9d4367a37b9b0750565d42e1e73d1ba4 
>   tier3/kdewidgets/docs/CMakeLists.txt 
> 2b38f53f807c528fdcd6ea128567f6087bd8c673 
>   tier3/kdewidgets/docs/makekdewidgets/CMakeLists.txt 
> c283b926f542402d80e22cc42406b119e400a05f 
>   tier3/kdewidgets/docs/makekdewidgets/man-makekdewidgets.1.docbook 
> cab0c5b51f2bb5be29960f43fe6fb940fffb5402 
>   tier3/kdewidgets/src/AUTHORS  
>   tier3/kdewidgets/src/CMakeLists.txt 
> e8626c84227a2ccd0459c5732a51e9ecea49f699 
>   tier3/kdewidgets/src/README  
>   tier3/kdewidgets/src/classpreviews.h  
>   tier3/kdewidgets/src/classpreviews.cpp  
>   tier3/kdewidgets/src/kde.widgets 7bcc669d14ed40da6217d09296e25d60a59413b7 
>   tier3/kdewidgets/src/kdewebkit.widgets  
>   tier3/kdewidgets/src/kdewebkitwidgets.qrc  
>   tier3/kdewidgets/src/kdewidgets.qrc  
>   tier3/kdewidgets/src/makekdewidgets.cpp 
> d20e49956a939a06fe3bc2280d57c5c6d31fe24c 
>   tier3/kdewidgets/src/pics/CMakeLists.txt 
> 688224a6a1ca9f68b7e7f918fa6b8aee3dbe6180 
>   tier3/kdewidgets/src/pics/k3iconview.png  
>   tier3/kdewidgets/src/pics/k3listview.png  
>   tier3/kdewidgets/src/pics/kactionselector.png  
>   tier3/kdewidgets/src/pics/kactivelabel.png  
>   tier3/kdewidgets/src/pics/kcharselect.png  
>   tier3/kdewidgets/src/pics/kcmodule.png  
>   tier3/kdewidgets/src/pics/kcolorbutton.png  
>   tier3/kdewidgets/src/pics/kcolorcombo.png  
>   tier3/kdewidgets/src/pics/kcombobox.png  
>   tier3/kdewidgets/src/pics/kdatepicker.png  
>   tier3/kdewidgets/src/pics/kdatetable.png  
>   tier3/kdewidgets/src/pics/kdualcolorbutton.png  
>   tier3/kdewidgets/src/pics/keditlistwidget.png  
>   tier3/kdewidgets/src/pics/kfontcombo.png  
>   tier3/kdewidgets/src/pics/kfontrequester.png  
>   tier3/kdewidgets/src/pics/kgradientselector.png  
>   tier3/kdewidgets/src/pics/khistorycombo.png  
>   tier3/kdewidgets/src/pics/khsselector.png  
>   tier3/kdewidgets/src/pics/kiconbutton.png  
>   tier3/kdewidgets/src/pics/kkeybutton.png  
>   tier3/kdewidgets/src/pics/kled.png  
>   tier3/kdewidgets/src/pics/klineedit.png  
>   tier3/kdewidgets/src/pics/klistbox.png  
>   tier3/kdewidgets/src/pics/kpalettetable.png  
>   tier3/kdewidgets/src/pics/kpasswordedit.png  
>   tier3/kdewidgets/src/pics/kruler.png  
>   tier3/kdewidgets/src/pics/ksqueezedtextlabel.png  
>   tier3/kdewidgets/src/pics/ktextedit.png  
>   tier3/kdewidgets/src/pics/kurlcomborequester.png  
>   tier3/kdewidgets/src/pics/kurllabel.png  
>   tier3/kdewidgets/src/pics/kurlrequester.png  
>   tier3/kdewidgets/tests/CMakeLists.txt  
>   tier3/kdewidgets/tests/README 9dd2132fa7c3601ae04f243a5996aa809b42f7bf 
>   tier3/kdewidgets/tests/sums  
>   tier3/kdewidgets/tests/test.widgets  
>   tier4/kde4support/CMakeLists.txt ccbffd24ede13d5ae6d8386a4aac1853018fcc97 
>   tier4/kde4support/cmake/modules/KDE4Macros.cmake 
> ddfd374607d0eef436fdd6c9e408cd98e59181ae 
>   tier4/kde4support/src/CMakeLists.txt 
> 467e8378e555139774924f053b477050ebba9f5c 
>   tier4/kde4support/src/KDEUIMacros.cmake 
> 31a180c1aab14f22e6a157e8aabfa901db15081a 
>   tier4/kde4support/src/kdedeprecated

Re: Let's get in release mode!

[Aurélien Gâteau]

On Tue, 17 Dec 2013 11:17:35 +0100, Aurélien Gâteau wrote:

On Mon, 16 Dec 2013 18:17:59 +0100, Kevin Ottens wrote:
Regarding the split: what is going to happen to the frameworks 
branch of the
kdelibs repository after the split? Is it going to be removed or is 
it
going to stay there with the framework folders pointing to the 
framework
repositories through git sub-modules? The work on the graph 
generator and

api.kde.org will be different depending on what the branch becomes.


Consider it removed from the graph generator pov. Technically it'll 
stay but

will be frozen (no push allowed).


Do you have a plan to indicate which tier a framework belongs to? My
kf5dot tool relies on folder names right now, but it's not going to 
work

anymore. I am thinking there should be either a standard
meta-information file in the root of each framework repository, or a
standard variable set within CMake which we can grep out (a bit 
ugly).


Replying to myself: I think using DOAP files [1] would provide a place
to store this (through an extension) and other information like
licenses and maintainers.

Aurélien

[1]: https://github.com/edumbill/doap/wiki

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Let's get in release mode!

[Ben Cooksley]

On Tue, Dec 17, 2013 at 10:59 PM, David Faure  wrote:

> On Tuesday 17 December 2013 21:40:48 Ben Cooksley wrote:
> > On Tue, Dec 17, 2013 at 9:37 PM, David Faure  wrote:
> > > On Tuesday 17 December 2013 14:10:56 Ben Cooksley wrote:
> > > > I do have some reservations as to the name of quite a few of those
> > > > repositories however as they are very generic - and thus tread on
> common
> > > > namespace. Suggestions are welcome.
> > >
> > > In case anyone wonders, here's the full list of frameworks:
> > >
> > > apidoxkauthkconfigwidgets  kded
>  kf5umbrella
> > > kiconthemeskjs kparts   ktextwidgets sonnet
> > > dnssd kbookmarks   kcoreaddons kdesu
> > > kfileaudiopreview  kidletime  kjsembedkplotting
> > >  kunitconversion threadweaver
> > > frameworkintegration  kcmutils kcrash  kdewebkit
> > > kglobalaccel
> > > kimageformats  kmediaplayerkprintutils  kwallet  xmlgui
> > > itemmodelskcodecs  kdbusaddons kdewidgets
>  kguiaddons
> > > kinit  knewstuff   kpty kwidgetsaddons
> > > itemviews kcompletion  kde4support kdoctools   khtml
> > > kioknotifications  krosskwindowsystem
> > > karchive  kconfig  kdeclarativekemoticons  ki18n
> > > kjobwidgetsknotifyconfig   kservice solid
>
> Did we really mean for apidox to be a framework?
>
> Other than that, it's not too bad, is it?


> Only very few don't start with a k, and those who don't, map to the actual
> brand name of the framework (ThreadWeaver, Sollid).


Other than apidox, I was also concerned about frameworkintegration,
itemmodels, itemviews and dnssd. The rest of the names are quite
descriptive as to what they contain and are fine.

It isn't the lack of starting with a k which bothers me - but more the
claim to a generic name. KPty, KArchive, KConfig all stand on their own -
itemmodels doesn't really...

kde4support is also problematic as it is very similar to kdesupport and
could become confused with it. kf5umbrella also seemed a little odd...


> > > > There is one exception to the above naming scheme, KWallet - as the
> > > > "kwallet" repository already exists it has been called
> > > > "kwallet-framework" instead.
> > >
> > > We should probably merge these two repos together
> >
> > I see. The current KWallet repository exists as part of kdeutils, so that
> > will be a little difficult in the interim.
>
> Can someone else help with that? I think this requires clever usage of git
> filter-branch, which I don't know anything about.
>
> > > > Also, the following frameworks could not be pushed due to audit (EOL)
> > > > failures, something which shouldn't exist in final code:
> > > > - kde4support
> > > > - kdoctools
> > > > - kjsembed
> > >
> > > What's the plan? Shall I include support for fixing that in the
> splitting
> > > script, and we re-run it for these?
> >
> > That would be a good idea, alternately one could fix it in commits made
> to
> > kdelibs prior to the split. Either would work I imagine, depends on what
> > makes it easier for the Git graft I guess.
>
> Ah, that means re-splitting everything, so it conflicts with the last
> issue in
> this email (pushing onto the existing repos). OK, let's fix one thing at a
> time then.
>
> Do you have the error messages for these 3 repos? Or how can I find out
> where
> the EOL problems are? (`file` doesn't help much with C++ code).
>
> Is it missing EOL at EOF, or CRLF/LF mixup? I assumed the latter but
> flip -u **/*.cpp **/*.h doesn't make any changes...
>

It was a CRLF/LF issue - the hooks don't check for EOL at EOF.
Output is at http://pastebin.kde.org/ppl8uu2bt


> > > > Everything else went fine as far as I can tell, although it wasn't
> > > > possible to see if the astyle tools ran or not.
> > >
> > > It didn't. Can I run it and push to the frameworks repos?
> >
> > I've granted you force push powers to the frameworks repos. The commit
> > notification hooks should still be off for them.
>
> Thanks, I'll do that later then, after the re-splitting.
>

Oki.


>
> --
> David Faure, fa...@kde.org, http://www.davidfaure.fr
> Working on KDE, in particular KDE Frameworks 5
>
>
Thanks,
Ben
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114496: Rename kdewidgets to kf5designerplugin

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114496/#review45848
---

Ship it!


This should go in before the split, since it affects the name of one of the 
splitted frameworks.

If everyone is OK with the naming, I'll push this before the re-splitting.

- David Faure


On Dec. 16, 2013, 9:06 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114496/
> ---
> 
> (Updated Dec. 16, 2013, 9:06 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Rename kdewidgets to kf5designerplugin
> 
> This includes renaming makekdewidgets to kgendesignerplugin.
> 
> 
> Just throwing this at reviewboard before I dash for a train.
> 
> 
> Diffs
> -
> 
>   superbuild/CMakeLists.txt b53cae64698562588f39ed28b2f30bf0a1f46809 
>   tier3/CMakeLists.txt 374396b3909d5a71dff6d891249ab33194a45522 
>   tier3/kdesignerplugin/KF5DesignerPluginConfig.cmake PRE-CREATION 
>   tier3/kdesignerplugin/Mainpage.dox PRE-CREATION 
>   tier3/kdesignerplugin/docs/CMakeLists.txt PRE-CREATION 
>   tier3/kdesignerplugin/docs/kgendesignerplugin/CMakeLists.txt PRE-CREATION 
>   
> tier3/kdesignerplugin/docs/kgendesignerplugin/man-kgendesignerplugin.1.docbook
>  PRE-CREATION 
>   tier3/kdesignerplugin/src/CMakeLists.txt PRE-CREATION 
>   tier3/kdesignerplugin/tests/README PRE-CREATION 
>   tier3/kdewidgets/CMakeLists.txt 87c3d5484dfb86018cdd203807588ea6ebd6ac31 
>   tier3/kdewidgets/KDEWidgetsConfig.cmake 
> d38c875c67a3073e7634bd6f873a38411127b759 
>   tier3/kdewidgets/KDEWidgetsMacros.cmake 
> 92d2960a7dfe1645d7c75e3dc6690d78b50706d8 
>   tier3/kdewidgets/Mainpage.dox 85da237c9d4367a37b9b0750565d42e1e73d1ba4 
>   tier3/kdewidgets/docs/CMakeLists.txt 
> 2b38f53f807c528fdcd6ea128567f6087bd8c673 
>   tier3/kdewidgets/docs/makekdewidgets/CMakeLists.txt 
> c283b926f542402d80e22cc42406b119e400a05f 
>   tier3/kdewidgets/docs/makekdewidgets/man-makekdewidgets.1.docbook 
> cab0c5b51f2bb5be29960f43fe6fb940fffb5402 
>   tier3/kdewidgets/src/AUTHORS  
>   tier3/kdewidgets/src/CMakeLists.txt 
> e8626c84227a2ccd0459c5732a51e9ecea49f699 
>   tier3/kdewidgets/src/README  
>   tier3/kdewidgets/src/classpreviews.h  
>   tier3/kdewidgets/src/classpreviews.cpp  
>   tier3/kdewidgets/src/kde.widgets 7bcc669d14ed40da6217d09296e25d60a59413b7 
>   tier3/kdewidgets/src/kdewebkit.widgets  
>   tier3/kdewidgets/src/kdewebkitwidgets.qrc  
>   tier3/kdewidgets/src/kdewidgets.qrc  
>   tier3/kdewidgets/src/makekdewidgets.cpp 
> d20e49956a939a06fe3bc2280d57c5c6d31fe24c 
>   tier3/kdewidgets/src/pics/CMakeLists.txt 
> 688224a6a1ca9f68b7e7f918fa6b8aee3dbe6180 
>   tier3/kdewidgets/src/pics/k3iconview.png  
>   tier3/kdewidgets/src/pics/k3listview.png  
>   tier3/kdewidgets/src/pics/kactionselector.png  
>   tier3/kdewidgets/src/pics/kactivelabel.png  
>   tier3/kdewidgets/src/pics/kcharselect.png  
>   tier3/kdewidgets/src/pics/kcmodule.png  
>   tier3/kdewidgets/src/pics/kcolorbutton.png  
>   tier3/kdewidgets/src/pics/kcolorcombo.png  
>   tier3/kdewidgets/src/pics/kcombobox.png  
>   tier3/kdewidgets/src/pics/kdatepicker.png  
>   tier3/kdewidgets/src/pics/kdatetable.png  
>   tier3/kdewidgets/src/pics/kdualcolorbutton.png  
>   tier3/kdewidgets/src/pics/keditlistwidget.png  
>   tier3/kdewidgets/src/pics/kfontcombo.png  
>   tier3/kdewidgets/src/pics/kfontrequester.png  
>   tier3/kdewidgets/src/pics/kgradientselector.png  
>   tier3/kdewidgets/src/pics/khistorycombo.png  
>   tier3/kdewidgets/src/pics/khsselector.png  
>   tier3/kdewidgets/src/pics/kiconbutton.png  
>   tier3/kdewidgets/src/pics/kkeybutton.png  
>   tier3/kdewidgets/src/pics/kled.png  
>   tier3/kdewidgets/src/pics/klineedit.png  
>   tier3/kdewidgets/src/pics/klistbox.png  
>   tier3/kdewidgets/src/pics/kpalettetable.png  
>   tier3/kdewidgets/src/pics/kpasswordedit.png  
>   tier3/kdewidgets/src/pics/kruler.png  
>   tier3/kdewidgets/src/pics/ksqueezedtextlabel.png  
>   tier3/kdewidgets/src/pics/ktextedit.png  
>   tier3/kdewidgets/src/pics/kurlcomborequester.png  
>   tier3/kdewidgets/src/pics/kurllabel.png  
>   tier3/kdewidgets/src/pics/kurlrequester.png  
>   tier3/kdewidgets/tests/CMakeLists.txt  
>   tier3/kdewidgets/tests/README 9dd2132fa7c3601ae04f243a5996aa809b42f7bf 
>   tier3/kdewidgets/tests/sums  
>   tier3/kdewidgets/tests/test.widgets  
>   tier4/kde4support/CMakeLists.txt ccbffd24ede13d5ae6d8386a4aac1853018fcc97 
>   tier4/kde4support/cmake/modules/KDE4Macros.cmake 
> ddfd374607d0eef436fdd6c9e408cd98e59181ae 
>   tier4/kde4support/src/CMakeLists.txt 
> 467e8378e555139774924f053b477050ebba9f5c 
>   tier4/kde4support/src/KDEUIMacros.cmake 
> 31a180c1aab14f22e6a157e8aabfa901db15081a 
> 

Re: Let's get in release mode!

[Ben Cooksley]

On Tue, Dec 17, 2013 at 11:15 PM, Alex Merry  wrote:

> On 17/12/13 08:37, David Faure wrote:
> > On Tuesday 17 December 2013 14:10:56 Ben Cooksley wrote:
> >> I do have some reservations as to the name of quite a few of those
> >> repositories however as they are very generic - and thus tread on common
> >> namespace. Suggestions are welcome.
> >
> > In case anyone wonders, here's the full list of frameworks:
> >
> > apidoxkauthkconfigwidgets  kded
>  kf5umbrella
> > kiconthemeskjs kparts   ktextwidgets sonnet
> > dnssd kbookmarks   kcoreaddons kdesu
> > kfileaudiopreview  kidletime  kjsembedkplotting
>  kunitconversion
> > threadweaver
> > frameworkintegration  kcmutils kcrash  kdewebkit
> kglobalaccel
> > kimageformats  kmediaplayerkprintutils  kwallet  xmlgui
> > itemmodelskcodecs  kdbusaddons kdewidgets  kguiaddons
> > kinit  knewstuff   kpty kwidgetsaddons
> > itemviews kcompletion  kde4support kdoctools   khtml
> > kioknotifications  krosskwindowsystem
> > karchive  kconfig  kdeclarativekemoticons  ki18n
> > kjobwidgetsknotifyconfig   kservice solid
>
> kdewidgets needs to become kdesignerplugin -- I was too late getting
> that commit in to the kdelibs repo.  The "internal" renaming can happen
> later, but is it easier to rename the repo itself now or later?
>

That needs to happen as soon as possible essentially. Once things get set
in concrete they'll be much harder to change as it will mean making changes
in many, many places.


>
> Alex
>

Thanks,
Ben


>
> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: karchive bad split

[Treeve Jelbert]

On Tuesday 17 December 2013 22:37:09 Ben Cooksley wrote:
> Hi Treeve,
> 
> It seems that I may have mis-pushed this repository.
> I have now adjusted it's contents with what is supposed to be the KArchive
> repository - can you please check?
> 
> Thanks,
> Ben
fixed now, and kio also builds against it

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Let's get in release mode!

[Aurélien Gâteau]

On Mon, 16 Dec 2013 18:17:59 +0100, Kevin Ottens wrote:

Hello,

On Monday 16 December 2013 15:16:42 Aurélien Gâteau wrote:
Do you want us to add ourselves as contacts in the table or do you 
plan to
fill it later? If the former, I would assign myself to "Get the 
dependency
graph generator script ready", "Have the frameworks on api.kde.org" 
(already

did some work in that area last week,
http://api.kde.org/frameworks/kdelibs-apidocs/ looks more complete 
now) and

I'd like to help with "Reduce the KDE footprint in ECM as much as
possible".


As usual, put your name next to it when you turn it into "in
progress". I pre-
allocated a couple because I knew some discussion was going on (maybe 
I

shouldn't have).


OK, will do.

Regarding the split: what is going to happen to the frameworks 
branch of the
kdelibs repository after the split? Is it going to be removed or is 
it
going to stay there with the framework folders pointing to the 
framework
repositories through git sub-modules? The work on the graph 
generator and

api.kde.org will be different depending on what the branch becomes.


Consider it removed from the graph generator pov. Technically it'll 
stay but

will be frozen (no push allowed).


Do you have a plan to indicate which tier a framework belongs to? My
kf5dot tool relies on folder names right now, but it's not going to 
work

anymore. I am thinking there should be either a standard
meta-information file in the root of each framework repository, or a
standard variable set within CMake which we can grep out (a bit ugly).

Aurélien

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Let's get in release mode!

[Alex Merry]

On 17/12/13 08:37, David Faure wrote:
> On Tuesday 17 December 2013 14:10:56 Ben Cooksley wrote:
>> I do have some reservations as to the name of quite a few of those
>> repositories however as they are very generic - and thus tread on common
>> namespace. Suggestions are welcome.
> 
> In case anyone wonders, here's the full list of frameworks:
> 
> apidoxkauthkconfigwidgets  kdedkf5umbrella
> 
> kiconthemeskjs kparts   ktextwidgets sonnet
> dnssd kbookmarks   kcoreaddons kdesu   
> kfileaudiopreview  kidletime  kjsembedkplotting
> kunitconversion  
> threadweaver
> frameworkintegration  kcmutils kcrash  kdewebkit   kglobalaccel   
> 
> kimageformats  kmediaplayerkprintutils  kwallet  xmlgui
> itemmodelskcodecs  kdbusaddons kdewidgets  kguiaddons 
> 
> kinit  knewstuff   kpty kwidgetsaddons
> itemviews kcompletion  kde4support kdoctools   khtml  
> 
> kioknotifications  krosskwindowsystem
> karchive  kconfig  kdeclarativekemoticons  ki18n  
> 
> kjobwidgetsknotifyconfig   kservice solid

kdewidgets needs to become kdesignerplugin -- I was too late getting
that commit in to the kdelibs repo.  The "internal" renaming can happen
later, but is it easier to rename the repo itself now or later?

Alex

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Let's get in release mode!

[Aurélien Gâteau]

On Tue, 17 Dec 2013 10:59:45 +0100, David Faure wrote:

On Tuesday 17 December 2013 21:40:48 Ben Cooksley wrote:

On Tue, Dec 17, 2013 at 9:37 PM, David Faure  wrote:
> On Tuesday 17 December 2013 14:10:56 Ben Cooksley wrote:
> > I do have some reservations as to the name of quite a few of 
those
> > repositories however as they are very generic - and thus tread 
on common

> > namespace. Suggestions are welcome.
>
> In case anyone wonders, here's the full list of frameworks:
>
> apidoxkauthkconfigwidgets  kded
kf5umbrella
> kiconthemeskjs kparts   ktextwidgets 
sonnet

> dnssd kbookmarks   kcoreaddons kdesu
> kfileaudiopreview  kidletime  kjsembedkplotting
>  kunitconversion threadweaver
> frameworkintegration  kcmutils kcrash  kdewebkit
> kglobalaccel
> kimageformats  kmediaplayerkprintutils  kwallet  
xmlgui
> itemmodelskcodecs  kdbusaddons kdewidgets  
kguiaddons

> kinit  knewstuff   kpty kwidgetsaddons
> itemviews kcompletion  kde4support kdoctools   
khtml

> kioknotifications  krosskwindowsystem
> karchive  kconfig  kdeclarativekemoticons  
ki18n

> kjobwidgetsknotifyconfig   kservice solid


Did we really mean for apidox to be a framework?


Poor apidox needs a home :). Even if it is does not provide libraries 
to

build applications on top of it, it needs to have a repository, right?

Apidox is used by several libraries to agregate multiple Doxygen
projects, I'd be actually interested in turning it into something 
usable

outside of api.kde.org (I am weird in that way: I like to work on
documentation tools)

Aurélien

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Let's get in release mode!

[David Faure]

On Tuesday 17 December 2013 21:40:48 Ben Cooksley wrote:
> On Tue, Dec 17, 2013 at 9:37 PM, David Faure  wrote:
> > On Tuesday 17 December 2013 14:10:56 Ben Cooksley wrote:
> > > I do have some reservations as to the name of quite a few of those
> > > repositories however as they are very generic - and thus tread on common
> > > namespace. Suggestions are welcome.
> > 
> > In case anyone wonders, here's the full list of frameworks:
> > 
> > apidoxkauthkconfigwidgets  kdedkf5umbrella
> > kiconthemeskjs kparts   ktextwidgets sonnet
> > dnssd kbookmarks   kcoreaddons kdesu
> > kfileaudiopreview  kidletime  kjsembedkplotting
> >  kunitconversion threadweaver
> > frameworkintegration  kcmutils kcrash  kdewebkit  
> > kglobalaccel
> > kimageformats  kmediaplayerkprintutils  kwallet  xmlgui
> > itemmodelskcodecs  kdbusaddons kdewidgets  kguiaddons
> > kinit  knewstuff   kpty kwidgetsaddons
> > itemviews kcompletion  kde4support kdoctools   khtml
> > kioknotifications  krosskwindowsystem
> > karchive  kconfig  kdeclarativekemoticons  ki18n
> > kjobwidgetsknotifyconfig   kservice solid

Did we really mean for apidox to be a framework?

Other than that, it's not too bad, is it?

Only very few don't start with a k, and those who don't, map to the actual 
brand name of the framework (ThreadWeaver, Sollid).

> > > There is one exception to the above naming scheme, KWallet - as the
> > > "kwallet" repository already exists it has been called
> > > "kwallet-framework" instead.
> > 
> > We should probably merge these two repos together
> 
> I see. The current KWallet repository exists as part of kdeutils, so that
> will be a little difficult in the interim.

Can someone else help with that? I think this requires clever usage of git 
filter-branch, which I don't know anything about.

> > > Also, the following frameworks could not be pushed due to audit (EOL)
> > > failures, something which shouldn't exist in final code:
> > > - kde4support
> > > - kdoctools
> > > - kjsembed
> > 
> > What's the plan? Shall I include support for fixing that in the splitting
> > script, and we re-run it for these?
> 
> That would be a good idea, alternately one could fix it in commits made to
> kdelibs prior to the split. Either would work I imagine, depends on what
> makes it easier for the Git graft I guess.

Ah, that means re-splitting everything, so it conflicts with the last issue in 
this email (pushing onto the existing repos). OK, let's fix one thing at a 
time then.

Do you have the error messages for these 3 repos? Or how can I find out where 
the EOL problems are? (`file` doesn't help much with C++ code).

Is it missing EOL at EOF, or CRLF/LF mixup? I assumed the latter but
flip -u **/*.cpp **/*.h doesn't make any changes...

> > > Everything else went fine as far as I can tell, although it wasn't
> > > possible to see if the astyle tools ran or not.
> > 
> > It didn't. Can I run it and push to the frameworks repos?
> 
> I've granted you force push powers to the frameworks repos. The commit
> notification hooks should still be off for them.

Thanks, I'll do that later then, after the re-splitting.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: karchive bad split

[Ben Cooksley]

Hi Treeve,

It seems that I may have mis-pushed this repository.
I have now adjusted it's contents with what is supposed to be the KArchive
repository - can you please check?

Thanks,
Ben
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

karchive bad split

[Treeve Jelbert]

/karchive contains the itemviews data

karchive$ ls
autotests  CMakeLists.txt  COPYING  COPYING.LIB  KF5ItemViewsConfig.cmake.in  
Mainpage.dox  src  tests


it installs the following files:

/opt/qt5/include/KF5/itemviews_export.h
/opt/qt5/include/KF5/itemviews_version.h
/opt/qt5/include/KF5/kcategorizedsortfilterproxymodel.h
/opt/qt5/include/KF5/kcategorizedview.h
/opt/qt5/include/KF5/kcategorydrawer.h
/opt/qt5/include/KF5/kextendableitemdelegate.h
/opt/qt5/include/KF5/kfilterproxysearchline.h
/opt/qt5/include/KF5/klistwidgetsearchline.h
/opt/qt5/include/KF5/ktreewidgetsearchline.h
/opt/qt5/include/KF5/kwidgetitemdelegate.h
/opt/qt5/lib
/opt/qt5/lib/cmake
/opt/qt5/lib/cmake/KF5ItemViews
/opt/qt5/lib/cmake/KF5ItemViews/KF5ItemViewsConfig.cmake
/opt/qt5/lib/cmake/KF5ItemViews/KF5ItemViewsConfigVersion.cmake
/opt/qt5/lib/cmake/KF5ItemViews/KF5ItemViewsTargets.cmake
/opt/qt5/lib/cmake/KF5ItemViews/KF5ItemViewsTargets-release.cmake
/opt/qt5/lib/libKF5ItemViews.so.5.0.0

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Where's kf5_add_ui_files ?

[Chusslove Illich]

> [: Aleix Pol :]
> FWIW, how could this have worked before? :/

There was an initial patch, then some weeks of hiatus and discussion, and
then it was committed very recently as a stop-gap measure. Probably
something got lost in the process.

-- 
Chusslove Illich (Часлав Илић)


signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Let's get in release mode!

[Ben Cooksley]

On Tue, Dec 17, 2013 at 9:37 PM, David Faure  wrote:

> On Tuesday 17 December 2013 14:10:56 Ben Cooksley wrote:
> > I do have some reservations as to the name of quite a few of those
> > repositories however as they are very generic - and thus tread on common
> > namespace. Suggestions are welcome.
>
> In case anyone wonders, here's the full list of frameworks:
>
> apidoxkauthkconfigwidgets  kdedkf5umbrella
> kiconthemeskjs kparts   ktextwidgets sonnet
> dnssd kbookmarks   kcoreaddons kdesu
> kfileaudiopreview  kidletime  kjsembedkplotting
>  kunitconversion
> threadweaver
> frameworkintegration  kcmutils kcrash  kdewebkit   kglobalaccel
> kimageformats  kmediaplayerkprintutils  kwallet  xmlgui
> itemmodelskcodecs  kdbusaddons kdewidgets  kguiaddons
> kinit  knewstuff   kpty kwidgetsaddons
> itemviews kcompletion  kde4support kdoctools   khtml
> kioknotifications  krosskwindowsystem
> karchive  kconfig  kdeclarativekemoticons  ki18n
> kjobwidgetsknotifyconfig   kservice solid
>
> > There is one exception to the above naming scheme, KWallet - as the
> > "kwallet" repository already exists it has been called
> "kwallet-framework"
> > instead.
>
> We should probably merge these two repos together
>

I see. The current KWallet repository exists as part of kdeutils, so that
will be a little difficult in the interim.


>
> > Also, the following frameworks could not be pushed due to audit (EOL)
> > failures, something which shouldn't exist in final code:
> > - kde4support
> > - kdoctools
> > - kjsembed
>
> What's the plan? Shall I include support for fixing that in the splitting
> script, and we re-run it for these?
>

That would be a good idea, alternately one could fix it in commits made to
kdelibs prior to the split. Either would work I imagine, depends on what
makes it easier for the Git graft I guess.


>
> > Everything else went fine as far as I can tell, although it wasn't
> possible
> > to see if the astyle tools ran or not.
>
> It didn't. Can I run it and push to the frameworks repos?
>

I've granted you force push powers to the frameworks repos. The commit
notification hooks should still be off for them.


>
> --
> David Faure, fa...@kde.org, http://www.davidfaure.fr
> Working on KDE, in particular KDE Frameworks 5
>
>
Thanks,
Ben
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Let's get in release mode!

[David Faure]

On Tuesday 17 December 2013 14:10:56 Ben Cooksley wrote:
> I do have some reservations as to the name of quite a few of those
> repositories however as they are very generic - and thus tread on common
> namespace. Suggestions are welcome.

In case anyone wonders, here's the full list of frameworks:

apidoxkauthkconfigwidgets  kdedkf5umbrella  
  
kiconthemeskjs kparts   ktextwidgets sonnet
dnssd kbookmarks   kcoreaddons kdesu   
kfileaudiopreview  kidletime  kjsembedkplottingkunitconversion  
threadweaver
frameworkintegration  kcmutils kcrash  kdewebkit   kglobalaccel 
  
kimageformats  kmediaplayerkprintutils  kwallet  xmlgui
itemmodelskcodecs  kdbusaddons kdewidgets  kguiaddons   
  
kinit  knewstuff   kpty kwidgetsaddons
itemviews kcompletion  kde4support kdoctools   khtml
  
kioknotifications  krosskwindowsystem
karchive  kconfig  kdeclarativekemoticons  ki18n
  
kjobwidgetsknotifyconfig   kservice solid

> There is one exception to the above naming scheme, KWallet - as the
> "kwallet" repository already exists it has been called "kwallet-framework"
> instead.

We should probably merge these two repos together

> Also, the following frameworks could not be pushed due to audit (EOL)
> failures, something which shouldn't exist in final code:
> - kde4support
> - kdoctools
> - kjsembed

What's the plan? Shall I include support for fixing that in the splitting 
script, and we re-run it for these?

> Everything else went fine as far as I can tell, although it wasn't possible
> to see if the astyle tools ran or not.

It didn't. Can I run it and push to the frameworks repos?

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

migration KIcon to QIcon

[Michal Humpula]

Hi there,

have a small glitch with icon loading on frameworks. If I understand 
correctly, the migration path for KIcon is QIcon::fromTheme, right?

Unfortunately this is giving me empty results, which might be caused by 
QIcon::themeName() giving me empty string. If I configure the theme manually, 
i.e. by calling QIcon::setThemeName("oxygen"), everything works fine, icons 
are displayed again.

The "kcmshell5 icons" is showing me the selected oxygen icons, though.

Any idea what my be missing/misconfigured in my installation?

frameworks: latest git
Qt: v5.2
system: Debian unstable

Cheers

Michal

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel