New doxygen script

2014-01-09 Thread Alex Merry 
Hey Aurélien,

I wrote a new script to generate apidocs.  It's in Python rather than
shell script (because (a) yay for proper programming languages and (b)
cross-platformness).

If you run it on a framework like KCoreAddons, you'll get actual bona
fide apidocs (unlike if you try to run doxygen.sh on it).  It even pulls
in README.md as the main page text.

It can be found in kde:clones/kapidox/alexmerry/kapidox on the
frameworks branch.

Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kio_master_qt5 #36

2014-01-09 Thread KDE CI System 
See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kio_master_qt5 #35

2014-01-09 Thread KDE CI System 
See 

Changes:

[frank78ac] Make KFileItemActions the parent of the actions it creates

--
[...truncated 859 lines...]
[ 57%] Building CXX object 
src/ioslaves/http/CMakeFiles/kio_http.dir/kio_http_automoc.cpp.o
[ 57%] [ 57%] Building CXX object 
src/ioslaves/http/tests/CMakeFiles/kioslave-httpobjecttest.dir/__/httpfilter.cpp.o
Built target kio_help
Scanning dependencies of target kioslave
[ 57%] Building CXX object src/kioslave/CMakeFiles/kioslave.dir/kioslave.cpp.o
[ 57%] Building CXX object 
src/ioslaves/http/tests/CMakeFiles/kioslave-httpobjecttest.dir/kioslave-httpobjecttest_automoc.cpp.o
Scanning dependencies of target kded_proxyscout
[ 57%] Building CXX object 
src/kpac/CMakeFiles/kded_proxyscout.dir/proxyscout.cpp.o
[ 58%] Building CXX object src/kpac/CMakeFiles/kded_proxyscout.dir/script.cpp.o
Scanning dependencies of target dataprotocoltest
[ 59%] Building CXX object 
autotests/CMakeFiles/dataprotocoltest.dir/dataprotocoltest.cpp.o
Linking CXX shared module kio_ftp.so
[ 59%] Built target kio_ftp
[ 60%] Building CXX object 
src/kioslave/CMakeFiles/kioslave.dir/kioslave_automoc.cpp.o
Scanning dependencies of target globaltest
Linking CXX shared module kio_http.so
[ 61%] Building CXX object autotests/CMakeFiles/globaltest.dir/globaltest.cpp.o
Linking CXX executable kioslave
Linking CXX shared module kded_kssld.so
Linking CXX executable kioslave-httpobjecttest
[ 61%] Built target kio_http
[ 61%] Built target kioslave
[ 62%] [ 62%] Building CXX object 
src/widgets/CMakeFiles/KF5KIOWidgets.dir/kpropertiesdialog.cpp.o
Scanning dependencies of target jobremotetest
Built target kded_kssld
[ 62%] [ 62%] Building CXX object 
autotests/CMakeFiles/jobremotetest.dir/jobremotetest.cpp.o
Building C object src/widgets/CMakeFiles/KF5KIOWidgets.dir/getgrouplist-fake.c.o
cc1: warning: command line option ‘-fvisibility-inlines-hidden’ is valid for 
C++/ObjC++ but not for C [enabled by default]
cc1: warning: command line option ‘-fvisibility-inlines-hidden’ is valid for 
C++/ObjC++ but not for C [enabled by default]
[ 62%] Building CXX object 
autotests/CMakeFiles/jobremotetest.dir/jobremotetest_automoc.cpp.o
[ 62%] Built target kioslave-httpobjecttest
[ 62%] Building CXX object 
src/kpac/CMakeFiles/kded_proxyscout.dir/downloader.cpp.o
[ 62%] Building CXX object 
autotests/CMakeFiles/dataprotocoltest.dir/dataprotocoltest_automoc.cpp.o
[ 62%] Building CXX object 
autotests/CMakeFiles/globaltest.dir/globaltest_automoc.cpp.o
[ 62%] Building CXX object 
src/widgets/CMakeFiles/KF5KIOWidgets.dir/kurlrequesterdialog.cpp.o
[ 62%] Building CXX object 
src/kpac/CMakeFiles/kded_proxyscout.dir/discovery.cpp.o
[ 62%] Building CXX object 
src/widgets/CMakeFiles/KF5KIOWidgets.dir/kurlcombobox.cpp.o
Linking CXX executable jobremotetest
[ 63%] Building CXX object 
src/widgets/CMakeFiles/KF5KIOWidgets.dir/kfileitemactions.cpp.o
Linking CXX executable globaltest
Scanning dependencies of target jobtest
[ 64%] Building CXX object autotests/CMakeFiles/jobtest.dir/jobtest.cpp.o
Linking CXX executable dataprotocoltest
[ 64%] Built target jobremotetest
[ 64%] Building CXX object 
src/kpac/CMakeFiles/kded_proxyscout.dir/kded_proxyscout_automoc.cpp.o
[ 64%] Built target globaltest
[ 64%] Scanning dependencies of target kacltest
Built target dataprotocoltest
[ 64%] Building CXX object autotests/CMakeFiles/kacltest.dir/kacltest.cpp.o
Scanning dependencies of target kfileitemtest
[ 65%] Building CXX object 
autotests/CMakeFiles/kfileitemtest.dir/kfileitemtest.cpp.o
Scanning dependencies of target klocalsocketservertest
[ 65%] Building CXX object 
autotests/CMakeFiles/klocalsocketservertest.dir/klocalsocketservertest.cpp.o
:
 In member function ‘QFileDialog* KUrlRequesterDialog::fileDialog()’:
:146:40:
 warning: ‘virtual QFileDialog* KUrlRequester::fileDialog() const’ is 
deprecated (declared at 
:154) 
[-Wdeprecated-declarations]
[ 65%] Building CXX object 
autotests/CMakeFiles/jobtest.dir/jobtest_automoc.cpp.o
Linking CXX shared module kded_proxyscout.so
Scanning dependencies of target klocalsockettest
[ 66%] [ 66%] Built target kded_proxyscout
[ 67%] Building CXX object 
autotests/CMakeFiles/klocalsockettest.dir/klocalsockettest.cpp.o
Building CXX object autotests/CMakeFiles/kacltest.dir/kacltest_automoc.cpp.o
[ 67%] Building CXX object 
autotests/CMakeFiles/kfileitemtest.dir/kfileitemtest_automoc.cpp.o
[ 67%] Building CXX object 
src/widgets/CMakeFiles/KF5KIOWidgets.dir/delegateanimationhandler.cpp.o
[ 67%] Building CXX object 
src/widgets/CMakeFiles/KF5KIOWidgets.dir/imagefilter.cpp.o
[ 67%] Building CXX object 
src/widgets/CMakeFiles/KF5KIOWidgets.dir/kfileitemdelegate.cpp.o
Linking CXX executable jobtest
[ 67%] Building CXX

Re: Review Request 114921: Make KFileItemActions the parent of the actions it creates

2014-01-09 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114921/#review47128
---


This review has been submitted with commit 
7a1543f82d4f4464b204eddbaa439120de0636f2 by Frank Reininghaus to branch master.

- Commit Hook


On Jan. 9, 2014, 9:26 p.m., Frank Reininghaus wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114921/
> ---
> 
> (Updated Jan. 9, 2014, 9:26 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> This patch is a result of the discussion in 
> http://lists.kde.org/?t=13868700941&r=1&w=2
> 
> Currently, KFileItemActions makes the widget that is set with 
> setParentWidget(QWidget*) the parent not only of any dialogs that are shown 
> (as advertised by the API docs), but also of the created actions. 
> Nonetheless, KFileItemActions remembers pointers to all created actions and 
> deletes them in the destructor. This can cause problems if the widget is 
> deleted before the KFileItemActions instance - the destructor will then try 
> to delete dangling pointers and cause a crash.
> 
> This problem can be fixed by making KFileItemActions the parent of the 
> actions. This also makes the code a bit simpler because the m_ownActions 
> member is not needed any more.
> 
> In fact, this issue is the cause of crashes in Dolphin (see 
> https://bugs.kde.org/show_bug.cgi?id=259089). I still think that we don't 
> really have to change it in kdelibs 4.x because the problem can be worked 
> around (https://git.reviewboard.kde.org/r/114440/ , which isn't pushed yet 
> because it turns out that there is still another source of crashes in the 
> problematic Dolphin use case).
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 2868327 
>   autotests/kfileitemactionstest.cpp PRE-CREATION 
>   src/widgets/kfileitemactions.cpp eee2ebe 
>   src/widgets/kfileitemactions_p.h 9f9a701 
> 
> Diff: https://git.reviewboard.kde.org/r/114921/diff/
> 
> 
> Testing
> ---
> 
> New unit test crashes with master, and passes if the patch is applied.
> 
> Existing kio unit tests pass on my system (except for kiocore-kacltest, but I 
> believe that the failure is unrelated to this patch).
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114921: Make KFileItemActions the parent of the actions it creates

2014-01-09 Thread Frank Reininghaus 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114921/
---

(Updated Jan. 9, 2014, 9:28 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Repository: kio


Description
---

This patch is a result of the discussion in 
http://lists.kde.org/?t=13868700941&r=1&w=2

Currently, KFileItemActions makes the widget that is set with 
setParentWidget(QWidget*) the parent not only of any dialogs that are shown (as 
advertised by the API docs), but also of the created actions. Nonetheless, 
KFileItemActions remembers pointers to all created actions and deletes them in 
the destructor. This can cause problems if the widget is deleted before the 
KFileItemActions instance - the destructor will then try to delete dangling 
pointers and cause a crash.

This problem can be fixed by making KFileItemActions the parent of the actions. 
This also makes the code a bit simpler because the m_ownActions member is not 
needed any more.

In fact, this issue is the cause of crashes in Dolphin (see 
https://bugs.kde.org/show_bug.cgi?id=259089). I still think that we don't 
really have to change it in kdelibs 4.x because the problem can be worked 
around (https://git.reviewboard.kde.org/r/114440/ , which isn't pushed yet 
because it turns out that there is still another source of crashes in the 
problematic Dolphin use case).


Diffs
-

  autotests/CMakeLists.txt 2868327 
  autotests/kfileitemactionstest.cpp PRE-CREATION 
  src/widgets/kfileitemactions.cpp eee2ebe 
  src/widgets/kfileitemactions_p.h 9f9a701 

Diff: https://git.reviewboard.kde.org/r/114921/diff/


Testing
---

New unit test crashes with master, and passes if the patch is applied.

Existing kio unit tests pass on my system (except for kiocore-kacltest, but I 
believe that the failure is unrelated to this patch).


Thanks,

Frank Reininghaus

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113805: Do not change the build types available with cmake

2014-01-09 Thread Sune Vuorela 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113805/
---

(Updated Jan. 9, 2014, 9:27 p.m.)


Status
--

This change has been discarded.


Review request for Build System and KDE Frameworks.


Repository: extra-cmake-modules


Description
---

Do not change the build types available with cmake.


Diffs
-

  kde-modules/KDECompilerSettings.cmake 
b034751a5be8073f9628971b552faa079c64e8b6 

Diff: https://git.reviewboard.kde.org/r/113805/diff/


Testing
---

Built kdelibs on linux with gcc.


Thanks,

Sune Vuorela

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114921: Make KFileItemActions the parent of the actions it creates

2014-01-09 Thread Frank Reininghaus 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114921/
---

(Updated Jan. 9, 2014, 9:26 p.m.)


Review request for KDE Frameworks and David Faure.


Changes
---

Thanks everyone for the comments! I've updated the diff, which I will push soon:

1. Use QUrl::fromLocalFile() as suggested by David.
2. Updated copyright year.
3. Added a few 'const' where it was possible.

About Alexander's idea to make the QMenu the parent of the actions: usually, 
one does not make the menu the parent of the actions (see, e.g., David's 
explanation in http://lists.kde.org/?l=kfm-devel&m=138688704130331&w=2 ). 
Nonetheless, we are not going to waste memory. At least Konqueror's and 
Dolphin's context menu implementations destroy the KFileItemActions instance 
(including, after this patch, the actions) when the menu itself is deleted.


Repository: kio


Description
---

This patch is a result of the discussion in 
http://lists.kde.org/?t=13868700941&r=1&w=2

Currently, KFileItemActions makes the widget that is set with 
setParentWidget(QWidget*) the parent not only of any dialogs that are shown (as 
advertised by the API docs), but also of the created actions. Nonetheless, 
KFileItemActions remembers pointers to all created actions and deletes them in 
the destructor. This can cause problems if the widget is deleted before the 
KFileItemActions instance - the destructor will then try to delete dangling 
pointers and cause a crash.

This problem can be fixed by making KFileItemActions the parent of the actions. 
This also makes the code a bit simpler because the m_ownActions member is not 
needed any more.

In fact, this issue is the cause of crashes in Dolphin (see 
https://bugs.kde.org/show_bug.cgi?id=259089). I still think that we don't 
really have to change it in kdelibs 4.x because the problem can be worked 
around (https://git.reviewboard.kde.org/r/114440/ , which isn't pushed yet 
because it turns out that there is still another source of crashes in the 
problematic Dolphin use case).


Diffs (updated)
-

  autotests/CMakeLists.txt 2868327 
  autotests/kfileitemactionstest.cpp PRE-CREATION 
  src/widgets/kfileitemactions.cpp eee2ebe 
  src/widgets/kfileitemactions_p.h 9f9a701 

Diff: https://git.reviewboard.kde.org/r/114921/diff/


Testing
---

New unit test crashes with master, and passes if the patch is applied.

Existing kio unit tests pass on my system (except for kiocore-kacltest, but I 
believe that the failure is unrelated to this patch).


Thanks,

Frank Reininghaus

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114921: Make KFileItemActions the parent of the actions it creates

2014-01-09 Thread Alexander Richardson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114921/#review47125
---


Why not simply make the QMenu* the parent of the QAction?
I am not familiar with the code so I may be missing something, but won't 
makeing KFileItemActions the parent mean that the actions only get deleted once 
the KFileItemActions gets deleted?
I guess this could waste quite a bit of memory. 

- Alexander Richardson


On Jan. 9, 2014, 9:15 a.m., Frank Reininghaus wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114921/
> ---
> 
> (Updated Jan. 9, 2014, 9:15 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> This patch is a result of the discussion in 
> http://lists.kde.org/?t=13868700941&r=1&w=2
> 
> Currently, KFileItemActions makes the widget that is set with 
> setParentWidget(QWidget*) the parent not only of any dialogs that are shown 
> (as advertised by the API docs), but also of the created actions. 
> Nonetheless, KFileItemActions remembers pointers to all created actions and 
> deletes them in the destructor. This can cause problems if the widget is 
> deleted before the KFileItemActions instance - the destructor will then try 
> to delete dangling pointers and cause a crash.
> 
> This problem can be fixed by making KFileItemActions the parent of the 
> actions. This also makes the code a bit simpler because the m_ownActions 
> member is not needed any more.
> 
> In fact, this issue is the cause of crashes in Dolphin (see 
> https://bugs.kde.org/show_bug.cgi?id=259089). I still think that we don't 
> really have to change it in kdelibs 4.x because the problem can be worked 
> around (https://git.reviewboard.kde.org/r/114440/ , which isn't pushed yet 
> because it turns out that there is still another source of crashes in the 
> problematic Dolphin use case).
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 2868327 
>   autotests/kfileitemactionstest.cpp PRE-CREATION 
>   src/widgets/kfileitemactions.cpp eee2ebe 
>   src/widgets/kfileitemactions_p.h 9f9a701 
> 
> Diff: https://git.reviewboard.kde.org/r/114921/diff/
> 
> 
> Testing
> ---
> 
> New unit test crashes with master, and passes if the patch is applied.
> 
> Existing kio unit tests pass on my system (except for kiocore-kacltest, but I 
> believe that the failure is unrelated to this patch).
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114921: Make KFileItemActions the parent of the actions it creates

2014-01-09 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114921/#review47124
---

Ship it!


Yep, as discussed. Looks good, except for one invalid URL.


autotests/kfileitemactionstest.cpp


This is an invalid way to create a URL from a local file, you must use 
QUrl::fromLocalFile().

Then again ... it means this whole code really doesn't care about the URL 
being used, does it? ;-)
So you might just as well use "file:///" or whatever.


- David Faure


On Jan. 9, 2014, 8:15 a.m., Frank Reininghaus wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114921/
> ---
> 
> (Updated Jan. 9, 2014, 8:15 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> This patch is a result of the discussion in 
> http://lists.kde.org/?t=13868700941&r=1&w=2
> 
> Currently, KFileItemActions makes the widget that is set with 
> setParentWidget(QWidget*) the parent not only of any dialogs that are shown 
> (as advertised by the API docs), but also of the created actions. 
> Nonetheless, KFileItemActions remembers pointers to all created actions and 
> deletes them in the destructor. This can cause problems if the widget is 
> deleted before the KFileItemActions instance - the destructor will then try 
> to delete dangling pointers and cause a crash.
> 
> This problem can be fixed by making KFileItemActions the parent of the 
> actions. This also makes the code a bit simpler because the m_ownActions 
> member is not needed any more.
> 
> In fact, this issue is the cause of crashes in Dolphin (see 
> https://bugs.kde.org/show_bug.cgi?id=259089). I still think that we don't 
> really have to change it in kdelibs 4.x because the problem can be worked 
> around (https://git.reviewboard.kde.org/r/114440/ , which isn't pushed yet 
> because it turns out that there is still another source of crashes in the 
> problematic Dolphin use case).
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 2868327 
>   autotests/kfileitemactionstest.cpp PRE-CREATION 
>   src/widgets/kfileitemactions.cpp eee2ebe 
>   src/widgets/kfileitemactions_p.h 9f9a701 
> 
> Diff: https://git.reviewboard.kde.org/r/114921/diff/
> 
> 
> Testing
> ---
> 
> New unit test crashes with master, and passes if the patch is applied.
> 
> Existing kio unit tests pass on my system (except for kiocore-kacltest, but I 
> believe that the failure is unrelated to this patch).
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114921: Make KFileItemActions the parent of the actions it creates

2014-01-09 Thread Alex Merry 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114921/#review47123
---

Ship it!


I say ship it - deleting anything that has been parented to another class is 
definitely a bad idea.

Of course, you may want to wait for someone more familiar with this code to 
chime in - if there is a compelling reason for making the actions children of 
the relevant widget, then another approach would be to use QPointers.

- Alex Merry


On Jan. 9, 2014, 8:15 a.m., Frank Reininghaus wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114921/
> ---
> 
> (Updated Jan. 9, 2014, 8:15 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> This patch is a result of the discussion in 
> http://lists.kde.org/?t=13868700941&r=1&w=2
> 
> Currently, KFileItemActions makes the widget that is set with 
> setParentWidget(QWidget*) the parent not only of any dialogs that are shown 
> (as advertised by the API docs), but also of the created actions. 
> Nonetheless, KFileItemActions remembers pointers to all created actions and 
> deletes them in the destructor. This can cause problems if the widget is 
> deleted before the KFileItemActions instance - the destructor will then try 
> to delete dangling pointers and cause a crash.
> 
> This problem can be fixed by making KFileItemActions the parent of the 
> actions. This also makes the code a bit simpler because the m_ownActions 
> member is not needed any more.
> 
> In fact, this issue is the cause of crashes in Dolphin (see 
> https://bugs.kde.org/show_bug.cgi?id=259089). I still think that we don't 
> really have to change it in kdelibs 4.x because the problem can be worked 
> around (https://git.reviewboard.kde.org/r/114440/ , which isn't pushed yet 
> because it turns out that there is still another source of crashes in the 
> problematic Dolphin use case).
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 2868327 
>   autotests/kfileitemactionstest.cpp PRE-CREATION 
>   src/widgets/kfileitemactions.cpp eee2ebe 
>   src/widgets/kfileitemactions_p.h 9f9a701 
> 
> Diff: https://git.reviewboard.kde.org/r/114921/diff/
> 
> 
> Testing
> ---
> 
> New unit test crashes with master, and passes if the patch is applied.
> 
> Existing kio unit tests pass on my system (except for kiocore-kacltest, but I 
> believe that the failure is unrelated to this patch).
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114922: Add runtime windowing system platform support to KWindowEffects

2014-01-09 Thread Alex Merry 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114922/#review47122
---

Ship it!


All looks sane to me (and I can't see anything obvious that would cause any 
regressions).


src/kwindoweffects_dummy.cpp


Sort of orthogonal to the change, but is it worth doing 
windowSizes.reserve(ids.count()) here?


- Alex Merry


On Jan. 9, 2014, 9:03 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114922/
> ---
> 
> (Updated Jan. 9, 2014, 9:03 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> So far KWindowEffects had a compile time switch. Either it got compiled
> for X11 or a dummy implementation got used. The actual runtime platform
> got not considered at all. This change ensures that the X11
> implementation is only used if the runtime platform is xcb. So if for
> example one uses Wayland, but KWindowSystem got compiled with X11
> support the dummy implementation is picked.
> 
> To achieve that a new pure virtual KWindowEffectsPrivate class is
> introduced which has two implementations: KWindowEffectsPrivateDummy
> and KWindowEffectsPrivateX11.
> 
> A new implementation for KWindowEffects is added which uses a global
> static which holds a pointer to the KWindowEffectsPrivate. Thus the
> global static functions acts as a factory method to pick the proper
> implementation for the runtime system. The implementation of the
> methods just delegate to the respective method of
> KWindowEffectsPrivate.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6a500fe9b257d8ff1871e799f7cdcd880de06128 
>   src/kwindoweffects.cpp PRE-CREATION 
>   src/kwindoweffects_dummy.cpp ce3b9bf4405d1befe3e36d3ede0a4bafe81d850d 
>   src/kwindoweffects_p.h PRE-CREATION 
>   src/kwindoweffects_x11.cpp b71e6b9f30d2f02ea86aa58b0b135a206904af7b 
> 
> Diff: https://git.reviewboard.kde.org/r/114922/diff/
> 
> 
> Testing
> ---
> 
> X11 unit test is working
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : kconfig_master_qt5 #13

2014-01-09 Thread KDE CI System 
See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KTextEditor & Frameworks question

2014-01-09 Thread Alex Merry 
On 09/01/14 13:11, Kevin Ottens wrote:
> On Wednesday 08 January 2014 23:00:02 Alex Merry wrote:
>> On 08/01/14 22:24, Kevin Ottens wrote:
>>> I also modified a bit one of the policies:
>>> http://community.kde.org/Frameworks/Policies#Frameworks_buildsystem_is_con
>>> sistent (was saying "installation rules" but it's really more about style
>>> of the buildsystem, we might want to reference aurélien's template there
>>> if someone feels like adding that).
>>
>> Done.
> 
> Hm? I don't see any change to the section?

Ah, it turns out that's because I got confused and added it to
http://community.kde.org/Frameworks/CreationGuidelines.  I've now also
added it to the Policies page.

Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kconfig_master_qt5 #11

2014-01-09 Thread KDE CI System 
See 

Changes:

[jr] Further renaming to kconfig_compiler_kf5

--
[...truncated 100 lines...]
Automatic moc for target kconf_update
Automatic moc for target kconfigskeletontest
Automatic moc for target kconfigtest
[  5%] Built target kconf_update_automoc
[  5%] Built target kconfig_compiler_kf5_automoc
Scanning dependencies of target kdesktopfiletest_automoc
[  6%] Automatic moc for target kdesktopfiletest
Generating moc_kconfigguitest.cpp
[  6%] Scanning dependencies of target kentrymaptest_automoc
Generating moc_kconfigtest.cpp
Built target kconfigguitest_automoc
[  6%] [  6%] Built target kconfigtest_automoc
Automatic moc for target kentrymaptest
Scanning dependencies of target ksharedconfigtest_automoc
Generating moc_kconfigskeleton.cpp
Scanning dependencies of target kstandardshortcuttest_automoc
Generating moc_kconfigskeletontest.cpp
[  6%] [  6%] Built target KF5ConfigGui_automoc
[  7%] Built target kconfigskeletontest_automoc
Automatic moc for target kstandardshortcuttest
Scanning dependencies of target test_kconf_update_automoc
Scanning dependencies of target test_kconfigutils_automoc
[  8%] [  9%] Automatic moc for target ksharedconfigtest
Generating moc_kdesktopfiletest.cpp
[  9%] Automatic moc for target test_kconf_update
[  9%] Automatic moc for target test_kconfigutils
Built target kdesktopfiletest_automoc
Scanning dependencies of target kconfigcompiler_test_automoc
Generating moc_kconfigbackend.cpp
Generating moc_kcoreconfigskeleton.cpp
[  9%] [ 10%] Built target KF5ConfigCore_automoc
Generating kconfignokdehometest.moc
Automatic moc for target kconfigcompiler_test
Generating moc_kentrymaptest.cpp
[ 10%] Scanning dependencies of target test1_automoc
[ 10%] Generating moc_kstandardshortcuttest.cpp
Built target kconfignokdehometest_automoc
[ 11%] [ 11%] Built target kentrymaptest_automoc
Built target kstandardshortcuttest_automoc
Generating moc_kconfigloadertest.cpp
Scanning dependencies of target test10_automoc
Scanning dependencies of target test11_automoc
Automatic moc for target test1
[ 11%] [ 12%] Scanning dependencies of target test12_automoc
Generating moc_test_kconfigutils.cpp
Built target kconfigloadertest_automoc
[ 12%] Automatic moc for target test10
[ 12%] Generating moc_test_kconf_update.cpp
[ 13%] Built target test_kconfigutils_automoc
Automatic moc for target test11
[ 13%] Automatic moc for target test12
[ 13%] Built target test_kconf_update_automoc
Built target test1_automoc
Scanning dependencies of target test2_automoc
[ 13%] [ 13%] Scanning dependencies of target test3a_automoc
Scanning dependencies of target test3_automoc
[ 13%] Automatic moc for target test2
Scanning dependencies of target test4_automoc
Built target test11_automoc
Built target test10_automoc
[ 14%] [ 15%] Automatic moc for target test3
[ 15%] Automatic moc for target test3a
[ 15%] Generating moc_kconfigcompiler_test.cpp
[ 15%] Built target test12_automoc
Built target test2_automoc
[ 15%] Automatic moc for target test4
Scanning dependencies of target test5_automoc
[ 15%] Built target kconfigcompiler_test_automoc
Built target test3_automoc
Scanning dependencies of target test6_automoc
Scanning dependencies of target test7_automoc
[ 15%] Scanning dependencies of target test8_automoc
[ 16%] Built target test3a_automoc
[ 17%] Scanning dependencies of target test9_automoc
[ 18%] [ 18%] [ 19%] Automatic moc for target test5
Scanning dependencies of target test_dpointer_automoc
Automatic moc for target test6
[ 20%] Automatic moc for target test7
Built target test4_automoc
Automatic moc for target test8
[ 20%] Automatic moc for target test9
Scanning dependencies of target test_signal_automoc
Automatic moc for target test_dpointer
[ 20%] [ 20%] [ 21%] [ 21%] Built target test5_automoc
[ 21%] [ 21%] Built target test6_automoc
Built target test7_automoc
Automatic moc for target test_signal
Built target test9_automoc
Built target test8_automoc
[ 21%] Built target test_dpointer_automoc
[ 21%] Built target test_signal_automoc
Generating ksharedconfigtest.moc
[ 21%] Built target ksharedconfigtest_automoc
Scanning dependencies of target kconfig_compiler_kf5
[ 22%] [ 22%] Building CXX object 
src/kconfig_compiler/CMakeFiles/kconfig_compiler_kf5.dir/kconfig_compiler_kf5_automoc.cpp.o
Building CXX object 
src/kconfig_compiler/CMakeFiles/kconfig_compiler_kf5.dir/kconfig_compiler.cpp.o
Scanning dependencies of target kconfigcompiler_test
Scanning dependencies of target KF5ConfigCore
[ 22%] [ 23%] Building CXX object 
autotests/kconfig_compiler/CMakeFiles/kconfigcompiler_test.dir/kconfigcompiler_test.cpp.o
Building CXX object 
autotests/kconfig_compiler/CMakeFiles/kconfigcompiler_test.dir/kconfigcompiler_test_automoc.cpp.o
[ 23%] [ 24%] [ 24%] [ 25%] Building CXX object 
src/core/CMakeFiles/KF5ConfigCore.dir/kconfig.cpp.o
Building CXX object src/core/CMakeFiles/KF5ConfigCore.dir/kconfigbase.cpp.o
Building CXX object src/core/CMakeFiles

Build failed in Jenkins: kconfig_master_qt5 #10

2014-01-09 Thread KDE CI System 
See 

Changes:

[jr] rename kconfig_compiler to kconfig_compiler_kf5

--
[...truncated 82 lines...]

Scanning dependencies of target KF5ConfigGui_automoc
Scanning dependencies of target kconfigguitest_automoc
Scanning dependencies of target kconfig_compiler_kf5_automoc
Scanning dependencies of target kconfigloadertest_automoc
Scanning dependencies of target kconf_update_automoc
Scanning dependencies of target KF5ConfigCore_automoc
Scanning dependencies of target kconfignokdehometest_automoc
[  1%] [  1%] Scanning dependencies of target kconfigtest_automoc
[  1%] Scanning dependencies of target kconfigskeletontest_automoc
[  1%] [  1%] [  3%] [  3%] Automatic moc for target kconfig_compiler_kf5
Automatic moc for target kconfigguitest
Automatic moc for target kconfignokdehometest
[  4%] Automatic moc for target KF5ConfigGui
[  5%] Automatic moc for target kconf_update
Automatic moc for target KF5ConfigCore
Automatic moc for target kconfigloadertest
Automatic moc for target kconfigtest
Automatic moc for target kconfigskeletontest
[  5%] Built target kconf_update_automoc
[  5%] Built target kconfig_compiler_kf5_automoc
Scanning dependencies of target kentrymaptest_automoc
[  5%] Automatic moc for target kentrymaptest
Generating moc_kconfigguitest.cpp
[  5%] Generating moc_kconfigtest.cpp
Built target kconfigguitest_automoc
[  5%] Scanning dependencies of target kdesktopfiletest_automoc
Built target kconfigtest_automoc
[  6%] Scanning dependencies of target ksharedconfigtest_automoc
Automatic moc for target kdesktopfiletest
Scanning dependencies of target kstandardshortcuttest_automoc
[  8%] [  8%] Generating moc_kconfigskeleton.cpp
Automatic moc for target kstandardshortcuttest
Automatic moc for target ksharedconfigtest
[  8%] Built target KF5ConfigGui_automoc
Scanning dependencies of target test_kconf_update_automoc
Generating moc_kconfigskeletontest.cpp
[  8%] Automatic moc for target test_kconf_update
[  8%] Generating moc_kentrymaptest.cpp
Generating kconfignokdehometest.moc
Generating moc_kdesktopfiletest.cpp
Generating moc_kstandardshortcuttest.cpp
Built target kconfigskeletontest_automoc
Generating moc_kconfigbackend.cpp
Generating moc_kcoreconfigskeleton.cpp
[  8%] [  8%] [  8%] [  8%] Built target kentrymaptest_automoc
Built target kdesktopfiletest_automoc
Built target kconfignokdehometest_automoc
[  8%] Built target kstandardshortcuttest_automoc
Built target KF5ConfigCore_automoc
Scanning dependencies of target test_kconfigutils_automoc
Generating moc_kconfigloadertest.cpp
Scanning dependencies of target test10_automoc
[  8%] Built target kconfigloadertest_automoc
[ 10%] [ 10%] Scanning dependencies of target test11_automoc
Scanning dependencies of target kconfigcompiler_test_automoc
Scanning dependencies of target test1_automoc
Scanning dependencies of target test12_automoc
Generating moc_test_kconf_update.cpp
Scanning dependencies of target test2_automoc
Automatic moc for target test_kconfigutils
Automatic moc for target test10
[ 10%] [ 11%] [ 11%] [ 12%] [ 13%] [ 13%] Built target test_kconf_update_automoc
Automatic moc for target test11
Automatic moc for target test12
Automatic moc for target kconfigcompiler_test
Automatic moc for target test1
Automatic moc for target test2
[ 13%] Built target test10_automoc
Scanning dependencies of target test3_automoc
[ 13%] [ 13%] [ 13%] [ 13%] Scanning dependencies of target test3a_automoc
Built target test1_automoc
Built target test12_automoc
Built target test11_automoc
[ 14%] Built target test2_automoc
[ 15%] Automatic moc for target test3
Scanning dependencies of target test5_automoc
Scanning dependencies of target test4_automoc
Automatic moc for target test3a
Scanning dependencies of target test6_automoc
Scanning dependencies of target test7_automoc
[ 16%] [ 16%] [ 17%] [ 17%] Built target test3_automoc
Automatic moc for target test5
[ 18%] [ 18%] Built target test3a_automoc
Automatic moc for target test4
Automatic moc for target test6
Automatic moc for target test7
Scanning dependencies of target test8_automoc
Scanning dependencies of target test9_automoc
[ 18%] [ 18%] Generating ksharedconfigtest.moc
Built target test5_automoc
Built target test4_automoc
[ 19%] [ 20%] [ 20%] [ 20%] [ 20%] Built target test6_automoc
Built target ksharedconfigtest_automoc
Built target test7_automoc
Generating moc_test_kconfigutils.cpp
Automatic moc for target test8
Automatic moc for target test9
Generating moc_kconfigcompiler_test.cpp
Scanning dependencies of target test_signal_automoc
[ 20%] Scanning dependencies of target test_dpointer_automoc
[ 20%] Built target test_kconfigutils_automoc
[ 21%] Built target kconfigcompiler_test_automoc
[ 21%] Automatic moc for target test_signal
[ 21%] [ 21%] Automatic moc for target test_dpointer
Built target test8_automoc
Built target test9_automoc
[ 21%] [ 21%] Built target test_signal_automoc
Built target test_dpointer_automoc
Scanning de

Re: KTextEditor & Frameworks question

2014-01-09 Thread Kevin Ottens 
On Wednesday 08 January 2014 23:00:02 Alex Merry wrote:
> On 08/01/14 22:24, Kevin Ottens wrote:
> > I also modified a bit one of the policies:
> > http://community.kde.org/Frameworks/Policies#Frameworks_buildsystem_is_con
> > sistent (was saying "installation rules" but it's really more about style
> > of the buildsystem, we might want to reference aurélien's template there
> > if someone feels like adding that).
> 
> Done.

Hm? I don't see any change to the section?

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : sonnet_master_qt5 #8

2014-01-09 Thread KDE CI System 
See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 114922: Add runtime windowing system platform support to KWindowEffects

2014-01-09 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114922/
---

Review request for KDE Frameworks.


Repository: kwindowsystem


Description
---

So far KWindowEffects had a compile time switch. Either it got compiled
for X11 or a dummy implementation got used. The actual runtime platform
got not considered at all. This change ensures that the X11
implementation is only used if the runtime platform is xcb. So if for
example one uses Wayland, but KWindowSystem got compiled with X11
support the dummy implementation is picked.

To achieve that a new pure virtual KWindowEffectsPrivate class is
introduced which has two implementations: KWindowEffectsPrivateDummy
and KWindowEffectsPrivateX11.

A new implementation for KWindowEffects is added which uses a global
static which holds a pointer to the KWindowEffectsPrivate. Thus the
global static functions acts as a factory method to pick the proper
implementation for the runtime system. The implementation of the
methods just delegate to the respective method of
KWindowEffectsPrivate.


Diffs
-

  src/CMakeLists.txt 6a500fe9b257d8ff1871e799f7cdcd880de06128 
  src/kwindoweffects.cpp PRE-CREATION 
  src/kwindoweffects_dummy.cpp ce3b9bf4405d1befe3e36d3ede0a4bafe81d850d 
  src/kwindoweffects_p.h PRE-CREATION 
  src/kwindoweffects_x11.cpp b71e6b9f30d2f02ea86aa58b0b135a206904af7b 

Diff: https://git.reviewboard.kde.org/r/114922/diff/


Testing
---

X11 unit test is working


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 114921: Make KFileItemActions the parent of the actions it creates

2014-01-09 Thread Frank Reininghaus 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114921/
---

Review request for KDE Frameworks and David Faure.


Repository: kio


Description
---

This patch is a result of the discussion in 
http://lists.kde.org/?t=13868700941&r=1&w=2

Currently, KFileItemActions makes the widget that is set with 
setParentWidget(QWidget*) the parent not only of any dialogs that are shown (as 
advertised by the API docs), but also of the created actions. Nonetheless, 
KFileItemActions remembers pointers to all created actions and deletes them in 
the destructor. This can cause problems if the widget is deleted before the 
KFileItemActions instance - the destructor will then try to delete dangling 
pointers and cause a crash.

This problem can be fixed by making KFileItemActions the parent of the actions. 
This also makes the code a bit simpler because the m_ownActions member is not 
needed any more.

In fact, this issue is the cause of crashes in Dolphin (see 
https://bugs.kde.org/show_bug.cgi?id=259089). I still think that we don't 
really have to change it in kdelibs 4.x because the problem can be worked 
around (https://git.reviewboard.kde.org/r/114440/ , which isn't pushed yet 
because it turns out that there is still another source of crashes in the 
problematic Dolphin use case).


Diffs
-

  autotests/CMakeLists.txt 2868327 
  autotests/kfileitemactionstest.cpp PRE-CREATION 
  src/widgets/kfileitemactions.cpp eee2ebe 
  src/widgets/kfileitemactions_p.h 9f9a701 

Diff: https://git.reviewboard.kde.org/r/114921/diff/


Testing
---

New unit test crashes with master, and passes if the patch is applied.

Existing kio unit tests pass on my system (except for kiocore-kacltest, but I 
believe that the failure is unrelated to this patch).


Thanks,

Frank Reininghaus

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel