Re: Review Request 115050: Declare the correct Qt version in QCA pkg-config file.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115050/#review47555 --- This review has been submitted with commit 9537815da5c59032b4ecf900b017b852e6023c2e by Ivan Romanov on behalf of Uwe L. Korn to branch master. - Commit Hook On Jan. 17, 2014, 1:03 a.m., Uwe L. Korn wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115050/ --- (Updated Jan. 17, 2014, 1:03 a.m.) Review request for KDE Frameworks and Ivan Romanov. Repository: qca Description --- Declare the correct Qt version the pkg-config file. Qt4 is called QtCore whereas Qt5 is called Qt5Core. Declaring QtCore when building with Qt5 will either link to Qt4 when both are installed and a project depending on QCA is resolving dependencies via pkg-config or will fail because of missing dependencies if Qt4 is not installed. Diffs - CMakeLists.txt 87b0702 qca2.pc.cmake 22004cc Diff: https://git.reviewboard.kde.org/r/115050/diff/ Testing --- Compiled, installed and used on Gentoo (with Qt5). Thanks, Uwe L. Korn ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115050: Declare the correct Qt version in QCA pkg-config file.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115050/ --- (Updated Jan. 17, 2014, 7:59 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Ivan Romanov. Repository: qca Description --- Declare the correct Qt version the pkg-config file. Qt4 is called QtCore whereas Qt5 is called Qt5Core. Declaring QtCore when building with Qt5 will either link to Qt4 when both are installed and a project depending on QCA is resolving dependencies via pkg-config or will fail because of missing dependencies if Qt4 is not installed. Diffs - CMakeLists.txt 87b0702 qca2.pc.cmake 22004cc Diff: https://git.reviewboard.kde.org/r/115050/diff/ Testing --- Compiled, installed and used on Gentoo (with Qt5). Thanks, Uwe L. Korn ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Q: Rules on inclusion of own headers? how to provide header inclusion kde4-compat? (was: Re: Extending ecm_generate_headers to create cross-forwarding headers?)
On Thursday 16 January 2014 17:57:51 Friedrich W. H. Kossebau wrote: Am Mittwoch, 15. Januar 2014, 12:14:59 schrieb David Faure: On Wednesday 15 January 2014 11:01:55 Friedrich W. H. Kossebau wrote: Guess you already started to tackle that? :) Or should I give it a try tonight? Go ahead :) Some questions while I go ahead: 1. How should own headers be included, what is preferred? #include kparts/part.h or #include part.h And both the same in the public headers and in the normal sources? Myself I also use the second version, but I found a mixture in use, so wonder if one is preferred/recommended in the frameworks. They should both work just the same, I can't see how/when either one would break. I think my preference would be part.h in part.cpp (makes it easy for krazy to check the rule include your own header first), and kparts/part.h in header files -- so that if anyone copies that to their own app, it'll work. 2. How to do KDE4-compatibility for moved header content? E.g. in event.h for KDE4-compatibility the declarations which have been moved to their own headers would need to be pulled in again, at least for builds using KDE4Support Is that done by having includes in the normal file, guarded by a flag, like // KDE4 compat #if KDE4COMPATIBLE #include kparts/guiactivateevent.h #include kparts/partactivateevent.h #include kparts/partselectevent.h #endif I don't think we need a #if. The headers installed by kde4support become unavailable as soon as you stop linking kde4support. So app who want to be clean from compat stuff will eventually have to stop using such compat headers, in order to reach the goal does not link to kde4support anymore. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Git merge checking
On 16/01/14 23:53, Luigi Toscano wrote: I can retrieve the full history using grafts. Only two details: - flat.css, kde.css and print.css are part of the doxygen stuff, they should be in the other repository; Good catch. - mainfooter.html and mainheader.html have been removed from both repositories, but they are (were) part of doxygen stuff. Is it correct? They were unused, so no point keeping them. Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115063: Created missing manpage for desktoptojson binary
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115063/#review47561 --- Hi Scarlett, Congrats to your first patch (that I see coming by)! I think it's a useful contribution and as far as I can judge, almost good to go in. I've put a comment inline how the explanation could be further improved. I don't know much about manpages, so I'll let someone else comment on the mechanics. Thanks for taking care of this. docs/desktoptojson/man-desktoptojson.8.docbook https://git.reviewboard.kde.org/r/115063/#comment33781 A link to the API docs for KPluginTrader would be useful. There, the user (developer, really, this is a development tool) finds more extensive documentation about its usage. As API documentation location hasn't really settled down yet, adding a sentence like this would probably be enough already: For further reference how to use this programme and its underlying mechanism, please refer to the documentation for the KPluginTrader class in KDE's KService framework. - Sebastian Kügler On Jan. 17, 2014, 2:52 a.m., Scarlett Clark wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115063/ --- (Updated Jan. 17, 2014, 2:52 a.m.) Review request for Documentation, KDE Frameworks, Jonathan Riddell, and Sebastian Kügler. Repository: kservice Description --- While building the package for kubuntu lintian complained about missing manpage for binary. So I created one :) This is my first manpage so be kind. I have no idea how to determine what type eg 1, 7, 8. Diffs - docs/CMakeLists.txt 86ed60b docs/desktoptojson/CMakeLists.txt PRE-CREATION docs/desktoptojson/man-desktoptojson.8.docbook PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115063/diff/ Testing --- meinproc5 --stylesheet /usr/share/ksgmltools2/customization/kde-include-man.xsl --check man-desktoptojson.8.docbook Thanks, Scarlett Clark ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114972: Trim default settings from Doxyfile.global
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114972/#review47563 --- This review has been submitted with commit 8a7650c12de04486af645e8b1b1511db1d529a69 by Alex Merry to branch master. - Commit Hook On Jan. 15, 2014, 2:49 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114972/ --- (Updated Jan. 15, 2014, 2:49 p.m.) Review request for KDE Frameworks and Aurélien Gâteau. Repository: kapidox Description --- Trim default settings from Doxyfile.global A lot of settings were just the doxygen defaults. This makes the file a managable size where you can see what's going on. Diffs - common/Doxyfile.global d1f0d2da0b10fd067ec678fa0bb94c899ed1f86c Diff: https://git.reviewboard.kde.org/r/114972/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114969: Add common files required for documentation generation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114969/ --- (Updated Jan. 17, 2014, 11:08 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Aurélien Gâteau and Luigi Toscano. Repository: kdoctools Description --- Add common files required for documentation generation These files belong here, rather than in kapidox; only a small subset of them are used by kapidox, and the kapidox scripts are never installed anyway. I copied everything from kapidox/common that was referenced in any of the files in the kdoctools repository. Note also: https://git.reviewboard.kde.org/r/114971/ Diffs - CMakeLists.txt 74c7af5d42ff5688b606b3c580e349bea0d13cad common/CMakeLists.txt PRE-CREATION common/api_searchbox.html PRE-CREATION common/artistic-license.html PRE-CREATION common/block_title_bottom.png PRE-CREATION common/block_title_mid.png PRE-CREATION common/block_title_top.png PRE-CREATION common/bsd-license.html PRE-CREATION common/fdl-license.html PRE-CREATION common/fdl-notice.html PRE-CREATION common/flat.css PRE-CREATION common/gpl-license.html PRE-CREATION common/kde-default.css PRE-CREATION common/kde-docs.css PRE-CREATION common/kde-localised.css.template PRE-CREATION common/kde.css PRE-CREATION common/kde_logo.png PRE-CREATION common/kde_logo_bg.png PRE-CREATION common/kmenu.png PRE-CREATION common/lgpl-license.html PRE-CREATION common/print.css PRE-CREATION common/qpl-license.html PRE-CREATION common/top-kde.jpg PRE-CREATION common/top-left.jpg PRE-CREATION common/top-right.jpg PRE-CREATION common/top.jpg PRE-CREATION common/x11-license.html PRE-CREATION common/xml.dcl PRE-CREATION Diff: https://git.reviewboard.kde.org/r/114969/diff/ Testing --- It still configures and installs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114979: Do not install licenses
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114979/#review47565 --- This review has been submitted with commit 43eec02513ab92b465e020777f10bf7457c01d64 by Alex Merry to branch master. - Commit Hook On Jan. 15, 2014, 2:54 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114979/ --- (Updated Jan. 15, 2014, 2:54 p.m.) Review request for KDE Frameworks and Aurélien Gâteau. Repository: kapidox Description --- Do not install licenses Firstly, we should certainly not be installing something as generic as standard license texts to a location as generic as share/LICENSES. Secondly, it is not our job to install license text at all. We provide licenses with all parts of our source distributions, and it is up to the producers of binary distributions to decide on the best way to make license text available for those. Note that the combination of this and https://git.reviewboard.kde.org/r/114971/ will result in nothing being installed by kapidox at all. I eventually intend to install the apidox generation scripts themselves, along with the necessary data files. Diffs - CMakeLists.txt 02114642f0713e44f581e58c4d47192b4db2d238 licenses/ARTISTIC 8f9bdefc4db9428a02812c0d24c887b0f3d7ef40 licenses/BSD cca2a5c9abb92e2f4d4d2ad7085dcd9f59809bd0 licenses/CMakeLists.txt ffc215b208cd7ebb5318e1283e306d24d396dc0d licenses/GPL_V2 64a675c0f0e75697595e31e7c3ed75dbbe65e567 licenses/GPL_V3 94a9ed024d3859793618152ea559a168bbcbb5e2 licenses/LGPL_V2 172c288f875590edacca050630b1c99d11eb6385 licenses/LGPL_V3 fc8a5de7edf437cdc98a216370faf7c757279bcb licenses/QPL_V1.0 85bc6356f50d05096c4b877f8587e361b5fed7c7 Diff: https://git.reviewboard.kde.org/r/114979/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114973: Remove spurious image files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114973/#review47564 --- This review has been submitted with commit 1db8547e62d528705ae81fb34e06c84116e1e3ad by Alex Merry to branch master. - Commit Hook On Jan. 15, 2014, 2:49 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114973/ --- (Updated Jan. 15, 2014, 2:49 p.m.) Review request for KDE Frameworks and Aurélien Gâteau. Repository: kapidox Description --- Remove spurious image files I'm not sure how these even came to be here. Two of them appear to be duplicates of images in kdesignerplugin. Diffs - src/kdualcolorbutton.png 1f8d3f6f873d4fec643c74b0dfa2b8b5bcff3825 src/khsselector.png 1283c50ca95fc2faf3b73658524a9006797178eb src/kpixmapio-perf.png ed4d935aedf360d8889a594b03dca6e439f65558 src/ktimewidget.png ccd2b12aa2bcd8df793aa385984ac29951ac2c95 Diff: https://git.reviewboard.kde.org/r/114973/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114969: Add common files required for documentation generation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114969/#review47566 --- This review has been submitted with commit 655520848e853815565abb2e350994b4dff108d9 by Alex Merry to branch master. - Commit Hook On Jan. 15, 2014, 2:08 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114969/ --- (Updated Jan. 15, 2014, 2:08 p.m.) Review request for KDE Frameworks, Aurélien Gâteau and Luigi Toscano. Repository: kdoctools Description --- Add common files required for documentation generation These files belong here, rather than in kapidox; only a small subset of them are used by kapidox, and the kapidox scripts are never installed anyway. I copied everything from kapidox/common that was referenced in any of the files in the kdoctools repository. Note also: https://git.reviewboard.kde.org/r/114971/ Diffs - CMakeLists.txt 74c7af5d42ff5688b606b3c580e349bea0d13cad common/CMakeLists.txt PRE-CREATION common/api_searchbox.html PRE-CREATION common/artistic-license.html PRE-CREATION common/block_title_bottom.png PRE-CREATION common/block_title_mid.png PRE-CREATION common/block_title_top.png PRE-CREATION common/bsd-license.html PRE-CREATION common/fdl-license.html PRE-CREATION common/fdl-notice.html PRE-CREATION common/flat.css PRE-CREATION common/gpl-license.html PRE-CREATION common/kde-default.css PRE-CREATION common/kde-docs.css PRE-CREATION common/kde-localised.css.template PRE-CREATION common/kde.css PRE-CREATION common/kde_logo.png PRE-CREATION common/kde_logo_bg.png PRE-CREATION common/kmenu.png PRE-CREATION common/lgpl-license.html PRE-CREATION common/print.css PRE-CREATION common/qpl-license.html PRE-CREATION common/top-kde.jpg PRE-CREATION common/top-left.jpg PRE-CREATION common/top-right.jpg PRE-CREATION common/top.jpg PRE-CREATION common/x11-license.html PRE-CREATION common/xml.dcl PRE-CREATION Diff: https://git.reviewboard.kde.org/r/114969/diff/ Testing --- It still configures and installs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115065/ --- (Updated Jan. 17, 2014, 11:30 a.m.) Review request for Documentation, KDE Frameworks, Luigi Toscano, and Scarlett Clark. Repository: kdoctools Description --- Rename man pages and checkXML tool to prevent clashes with kdelibs4 credit should go to scarlett Diffs - CMakeLists.txt 74c7af5 checkXML.in.cmake d7a57c7 checkXML5.in.cmake PRE-CREATION docs/CMakeLists.txt 7e9612f docs/checkXML/CMakeLists.txt 7f8226c docs/checkXML/man-checkXML.1.docbook 2bfb3f3 docs/checkXML5/CMakeLists.txt PRE-CREATION docs/checkXML5/man-checkXML5.1.docbook PRE-CREATION docs/kde5options/CMakeLists.txt PRE-CREATION docs/kde5options/man-kde5options.7.docbook PRE-CREATION docs/kdeoptions/CMakeLists.txt a91f451 docs/kdeoptions/man-kdeoptions.7.docbook 7e62f41 docs/qt5options/CMakeLists.txt PRE-CREATION docs/qt5options/man-qt5options.7.docbook PRE-CREATION docs/qtoptions/CMakeLists.txt f1dbb6c docs/qtoptions/man-qtoptions.7.docbook a00677a Diff: https://git.reviewboard.kde.org/r/115065/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114971: Remove unused common files and do not install any of them
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114971/ --- (Updated Jan. 17, 2014, 12:35 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Aurélien Gâteau and Luigi Toscano. Repository: kapidox Description --- Remove unused common files and do not install any of them Any files not actually used in apidox generation are removed (most of these actually belong in kdoctools, and should be installed from there). None of the common files are installed any more, because there is little point when we do not install the script that uses them. See https://git.reviewboard.kde.org/r/114969/ I don't think we should be installing the licenses either (certainly not to as generic a location as share/LICENSES). Incidentally, I plan on actually installing the scripts and everything once I've completed the frameworks port. Diffs - CMakeLists.txt 02114642f0713e44f581e58c4d47192b4db2d238 common/1.png a9ea29c1c4f52a90d62a1d0ca3586e4e82a46125 common/10.png 00ba60fff1d08e0d04f1c28e7aa9565b4da56e5a common/2.png cc9762a8774fec901ef9ebe6efb8921c3c826d03 common/3.png 7e0e4f185ebd534ae61e07323b75da7d00a65d01 common/4.png fd80c9227489a5f613ba1f401434ff30b85453f9 common/5.png cbad31966d92b6946818748df82f16b17cc38b3e common/6.png 20ddbd5becba7e0e0321ef161cb56c435fc022a1 common/7.png 22fee5bc83c53be63341e17f1dd35e817202027e common/8.png a9adacfdab46cdc78c7779fe056fab30f7cfdeca common/9.png 56b36121d76a0cf474cc3d7d6dda79c8be6ac24a common/CMakeLists.txt 422862587499679d4bd4d10677b57e101b3ecb15 common/artistic-license.html 2069b4ed07b67cb8d042926fce91bc1665fb9a07 common/bottom-left.png a2d8a49093ab1840c3cb16de640bff6a7cf02763 common/bottom-middle.png eba0bb056e3ffabafcbef1898cff7c73b3e0b01c common/bottom-right.png 01d5cd5055eccb5520726b3a7d56ac6df1022887 common/bsd-license.html 422bb339fe00e62281f305e41b74e054f331e874 common/fdl-license 4a0fe1c8deeb9861435d0aafa0c2096a6d624d2b common/fdl-license.html 9ce378a303567c9c8954638a02267fe0dd6bd775 common/fdl-notice.html 862f09e7b3ac5dab09dc9c7ce805ff9cef1f496a common/gpl-license 93796b60a25f0174448a03d438d270fca49ae4ab common/gpl-license.html 26ae3af1f0cccbb6d30daf7128bad78d974d7926 common/kde-default.css 24ef928201896a9d42b706f3edc7525882c33751 common/kde-docs.css 12291a4c6ec5698d4b55fe644a3d053a2acefc49 common/kde-localised.css.template abcd1ec916a6ebd610fdb5ae8b87699b8d301324 common/kde_logo.png 336bfd858aa2d5b6146013eaa8bc45f0f7eca9c4 common/kde_logo_bg.png 6cf47f17d794dadfa7f1ea1dca8fbea00fdc3649 common/kmenu.png ff077c225a2af4c5b3e809c3a7cc1c1c203f8790 common/lgpl-license ec47efc0608776917d0a5e4c33c6621c2a48278e common/lgpl-license.html 343576dfb5d869a7c2e14507f8bbbfe160ae937d common/mainfooter.html b12919329279b97d35fbb13b2d4fca685687396b common/mainheader.html 63fa04fc40a00235161bd45441f858f5d053ee45 common/qpl-license.html 19a863bc52894fcf7337b5d805b7e2ae76fe69fb common/top-left.png 22e3bc698902b6ecaedd9a0bc98b51bd0b1b88b9 common/top-middle.png 280ee2e2892ffc6c6b59c69601187cec11ea8779 common/top-right.png 02598bc1d723a3129c324f8e4fe34f27649671b1 common/x11-license.html 444a27bec97c26688dbb87f60fd7fe6e99859762 common/xml.dcl fed210309215a3c7a8f447d85bdd9bca12ba5916 Diff: https://git.reviewboard.kde.org/r/114971/diff/ Testing --- It still configures and installs (what little it does install). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114971: Remove unused common files and do not install any of them
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114971/#review47568 --- This review has been submitted with commit eafc35d3a02fb6b0f5ef00213aa841cc6aebf8ed by Alex Merry to branch master. - Commit Hook On Jan. 15, 2014, 2:08 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114971/ --- (Updated Jan. 15, 2014, 2:08 p.m.) Review request for KDE Frameworks, Aurélien Gâteau and Luigi Toscano. Repository: kapidox Description --- Remove unused common files and do not install any of them Any files not actually used in apidox generation are removed (most of these actually belong in kdoctools, and should be installed from there). None of the common files are installed any more, because there is little point when we do not install the script that uses them. See https://git.reviewboard.kde.org/r/114969/ I don't think we should be installing the licenses either (certainly not to as generic a location as share/LICENSES). Incidentally, I plan on actually installing the scripts and everything once I've completed the frameworks port. Diffs - CMakeLists.txt 02114642f0713e44f581e58c4d47192b4db2d238 common/1.png a9ea29c1c4f52a90d62a1d0ca3586e4e82a46125 common/10.png 00ba60fff1d08e0d04f1c28e7aa9565b4da56e5a common/2.png cc9762a8774fec901ef9ebe6efb8921c3c826d03 common/3.png 7e0e4f185ebd534ae61e07323b75da7d00a65d01 common/4.png fd80c9227489a5f613ba1f401434ff30b85453f9 common/5.png cbad31966d92b6946818748df82f16b17cc38b3e common/6.png 20ddbd5becba7e0e0321ef161cb56c435fc022a1 common/7.png 22fee5bc83c53be63341e17f1dd35e817202027e common/8.png a9adacfdab46cdc78c7779fe056fab30f7cfdeca common/9.png 56b36121d76a0cf474cc3d7d6dda79c8be6ac24a common/CMakeLists.txt 422862587499679d4bd4d10677b57e101b3ecb15 common/artistic-license.html 2069b4ed07b67cb8d042926fce91bc1665fb9a07 common/bottom-left.png a2d8a49093ab1840c3cb16de640bff6a7cf02763 common/bottom-middle.png eba0bb056e3ffabafcbef1898cff7c73b3e0b01c common/bottom-right.png 01d5cd5055eccb5520726b3a7d56ac6df1022887 common/bsd-license.html 422bb339fe00e62281f305e41b74e054f331e874 common/fdl-license 4a0fe1c8deeb9861435d0aafa0c2096a6d624d2b common/fdl-license.html 9ce378a303567c9c8954638a02267fe0dd6bd775 common/fdl-notice.html 862f09e7b3ac5dab09dc9c7ce805ff9cef1f496a common/gpl-license 93796b60a25f0174448a03d438d270fca49ae4ab common/gpl-license.html 26ae3af1f0cccbb6d30daf7128bad78d974d7926 common/kde-default.css 24ef928201896a9d42b706f3edc7525882c33751 common/kde-docs.css 12291a4c6ec5698d4b55fe644a3d053a2acefc49 common/kde-localised.css.template abcd1ec916a6ebd610fdb5ae8b87699b8d301324 common/kde_logo.png 336bfd858aa2d5b6146013eaa8bc45f0f7eca9c4 common/kde_logo_bg.png 6cf47f17d794dadfa7f1ea1dca8fbea00fdc3649 common/kmenu.png ff077c225a2af4c5b3e809c3a7cc1c1c203f8790 common/lgpl-license ec47efc0608776917d0a5e4c33c6621c2a48278e common/lgpl-license.html 343576dfb5d869a7c2e14507f8bbbfe160ae937d common/mainfooter.html b12919329279b97d35fbb13b2d4fca685687396b common/mainheader.html 63fa04fc40a00235161bd45441f858f5d053ee45 common/qpl-license.html 19a863bc52894fcf7337b5d805b7e2ae76fe69fb common/top-left.png 22e3bc698902b6ecaedd9a0bc98b51bd0b1b88b9 common/top-middle.png 280ee2e2892ffc6c6b59c69601187cec11ea8779 common/top-right.png 02598bc1d723a3129c324f8e4fe34f27649671b1 common/x11-license.html 444a27bec97c26688dbb87f60fd7fe6e99859762 common/xml.dcl fed210309215a3c7a8f447d85bdd9bca12ba5916 Diff: https://git.reviewboard.kde.org/r/114971/diff/ Testing --- It still configures and installs (what little it does install). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115065/#review47577 --- Got this after applying this patch: [...] Linking CXX executable meinproc5 [ 76%] Built target KF5XsltKde [ 76%] Built target meinproc5 Scanning dependencies of target kde5options-manpage-man-kdeoptions Scanning dependencies of target checkXML5-manpage-man-checkXML gmake[2]: *** No rule to make target '/home/david/Projects/Frameworks/src/frameworks/kdoctools/docs/checkXML5/man-checkXML.1.docbook', needed by 'docs/checkXML5/checkXML.1'. Stop. Scanning dependencies of target qt5options-manpage-man-qtoptions gmake[2]: *** No rule to make target '/home/david/Projects/Frameworks/src/frameworks/kdoctools/docs/kde5options/man-kdeoptions.7.docbook', needed by 'docs/kde5options/kdeoptions.7'. Stop. CMakeFiles/Makefile2:199: recipe for target 'docs/kde5options/CMakeFiles/kde5options-manpage-man-kdeoptions.dir/all' failed gmake[1]: *** [docs/kde5options/CMakeFiles/kde5options-manpage-man-kdeoptions.dir/all] Error 2 gmake[1]: *** Waiting for unfinished jobs CMakeFiles/Makefile2:99: recipe for target 'docs/checkXML5/CMakeFiles/checkXML5-manpage-man-checkXML.dir/all' failed gmake[1]: *** [docs/checkXML5/CMakeFiles/checkXML5-manpage-man-checkXML.dir/all] Error 2 Scanning dependencies of target meinproc5-manpage-man-meinproc5 gmake[2]: *** No rule to make target '/home/david/Projects/Frameworks/src/frameworks/kdoctools/docs/qt5options/man-qtoptions.7.docbook', needed by 'docs/qt5options/qtoptions.7'. Stop. CMakeFiles/Makefile2:249: recipe for target 'docs/qt5options/CMakeFiles/qt5options-manpage-man-qtoptions.dir/all' failed gmake[1]: *** [docs/qt5options/CMakeFiles/qt5options-manpage-man-qtoptions.dir/all] Error 2 [ 82%] Generating meinproc5.8 Warn: meta author : no refentry/info/authormeinproc5 Note: meta author : see http://docbook.sf.net/el/authormeinproc5 Warn: meta author : no author data, so inserted a fixmemeinproc5 Note: Writing meinproc5.8 [ 82%] Built target meinproc5-manpage-man-meinproc5 Makefile:127: recipe for target 'all' failed gmake: *** [all] Error 2 I think you need to rename the targets in the new folders. Complete log at http://paste.kde.org/pf215b902 - David Narváez On Jan. 17, 2014, 11:30 a.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115065/ --- (Updated Jan. 17, 2014, 11:30 a.m.) Review request for Documentation, KDE Frameworks, Luigi Toscano, and Scarlett Clark. Repository: kdoctools Description --- Rename man pages and checkXML tool to prevent clashes with kdelibs4 credit should go to scarlett Diffs - CMakeLists.txt 74c7af5 checkXML.in.cmake d7a57c7 checkXML5.in.cmake PRE-CREATION docs/CMakeLists.txt 7e9612f docs/checkXML/CMakeLists.txt 7f8226c docs/checkXML/man-checkXML.1.docbook 2bfb3f3 docs/checkXML5/CMakeLists.txt PRE-CREATION docs/checkXML5/man-checkXML5.1.docbook PRE-CREATION docs/kde5options/CMakeLists.txt PRE-CREATION docs/kde5options/man-kde5options.7.docbook PRE-CREATION docs/kdeoptions/CMakeLists.txt a91f451 docs/kdeoptions/man-kdeoptions.7.docbook 7e62f41 docs/qt5options/CMakeLists.txt PRE-CREATION docs/qt5options/man-qt5options.7.docbook PRE-CREATION docs/qtoptions/CMakeLists.txt f1dbb6c docs/qtoptions/man-qtoptions.7.docbook a00677a Diff: https://git.reviewboard.kde.org/r/115065/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115077: Rename Macros in KF5DocTools to KDE5_
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115077/ --- Review request for Documentation and KDE Frameworks. Repository: kdoctools Description --- Part of the overall task of removing mentions of KDE4 from the code. Diffs - KF5DocToolsMacros.cmake 191a2c5 Diff: https://git.reviewboard.kde.org/r/115077/diff/ Testing --- Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115065/#review47579 --- Correct, the CMakefiles in the manpages subdirectories need to be updated with the new manpage file names. Thank you Jonathon! - Scarlett Clark On Jan. 17, 2014, 3:30 a.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115065/ --- (Updated Jan. 17, 2014, 3:30 a.m.) Review request for Documentation, KDE Frameworks, Luigi Toscano, and Scarlett Clark. Repository: kdoctools Description --- Rename man pages and checkXML tool to prevent clashes with kdelibs4 credit should go to scarlett Diffs - CMakeLists.txt 74c7af5 checkXML.in.cmake d7a57c7 checkXML5.in.cmake PRE-CREATION docs/CMakeLists.txt 7e9612f docs/checkXML/CMakeLists.txt 7f8226c docs/checkXML/man-checkXML.1.docbook 2bfb3f3 docs/checkXML5/CMakeLists.txt PRE-CREATION docs/checkXML5/man-checkXML5.1.docbook PRE-CREATION docs/kde5options/CMakeLists.txt PRE-CREATION docs/kde5options/man-kde5options.7.docbook PRE-CREATION docs/kdeoptions/CMakeLists.txt a91f451 docs/kdeoptions/man-kdeoptions.7.docbook 7e62f41 docs/qt5options/CMakeLists.txt PRE-CREATION docs/qt5options/man-qt5options.7.docbook PRE-CREATION docs/qtoptions/CMakeLists.txt f1dbb6c docs/qtoptions/man-qtoptions.7.docbook a00677a Diff: https://git.reviewboard.kde.org/r/115065/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115065/#review47580
---
docs/checkXML5/CMakeLists.txt
https://git.reviewboard.kde.org/r/115065/#comment33786
kdoctools_create_manpage(man-checkXML5.1.docbook 1 INSTALL_DESTINATION
${MAN_INSTALL_DIR})
- Scarlett Clark
On Jan. 17, 2014, 3:30 a.m., Jonathan Riddell wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115065/
---
(Updated Jan. 17, 2014, 3:30 a.m.)
Review request for Documentation, KDE Frameworks, Luigi Toscano, and Scarlett
Clark.
Repository: kdoctools
Description
---
Rename man pages and checkXML tool to prevent clashes with kdelibs4
credit should go to scarlett
Diffs
-
CMakeLists.txt 74c7af5
checkXML.in.cmake d7a57c7
checkXML5.in.cmake PRE-CREATION
docs/CMakeLists.txt 7e9612f
docs/checkXML/CMakeLists.txt 7f8226c
docs/checkXML/man-checkXML.1.docbook 2bfb3f3
docs/checkXML5/CMakeLists.txt PRE-CREATION
docs/checkXML5/man-checkXML5.1.docbook PRE-CREATION
docs/kde5options/CMakeLists.txt PRE-CREATION
docs/kde5options/man-kde5options.7.docbook PRE-CREATION
docs/kdeoptions/CMakeLists.txt a91f451
docs/kdeoptions/man-kdeoptions.7.docbook 7e62f41
docs/qt5options/CMakeLists.txt PRE-CREATION
docs/qt5options/man-qt5options.7.docbook PRE-CREATION
docs/qtoptions/CMakeLists.txt f1dbb6c
docs/qtoptions/man-qtoptions.7.docbook a00677a
Diff: https://git.reviewboard.kde.org/r/115065/diff/
Testing
---
Thanks,
Jonathan Riddell
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115065/#review47581
---
docs/kde5options/CMakeLists.txt
https://git.reviewboard.kde.org/r/115065/#comment33787
kdoctools_create_manpage(man-kde5options.7.docbook 7 INSTALL_DESTINATION
${MAN_INSTALL_DIR})
- Scarlett Clark
On Jan. 17, 2014, 3:30 a.m., Jonathan Riddell wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115065/
---
(Updated Jan. 17, 2014, 3:30 a.m.)
Review request for Documentation, KDE Frameworks, Luigi Toscano, and Scarlett
Clark.
Repository: kdoctools
Description
---
Rename man pages and checkXML tool to prevent clashes with kdelibs4
credit should go to scarlett
Diffs
-
CMakeLists.txt 74c7af5
checkXML.in.cmake d7a57c7
checkXML5.in.cmake PRE-CREATION
docs/CMakeLists.txt 7e9612f
docs/checkXML/CMakeLists.txt 7f8226c
docs/checkXML/man-checkXML.1.docbook 2bfb3f3
docs/checkXML5/CMakeLists.txt PRE-CREATION
docs/checkXML5/man-checkXML5.1.docbook PRE-CREATION
docs/kde5options/CMakeLists.txt PRE-CREATION
docs/kde5options/man-kde5options.7.docbook PRE-CREATION
docs/kdeoptions/CMakeLists.txt a91f451
docs/kdeoptions/man-kdeoptions.7.docbook 7e62f41
docs/qt5options/CMakeLists.txt PRE-CREATION
docs/qt5options/man-qt5options.7.docbook PRE-CREATION
docs/qtoptions/CMakeLists.txt f1dbb6c
docs/qtoptions/man-qtoptions.7.docbook a00677a
Diff: https://git.reviewboard.kde.org/r/115065/diff/
Testing
---
Thanks,
Jonathan Riddell
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115065/#review47582
---
docs/qt5options/CMakeLists.txt
https://git.reviewboard.kde.org/r/115065/#comment33788
kdoctools_create_manpage(man-qt5options.7.docbook 7 INSTALL_DESTINATION
${MAN_INSTALL_DIR})
- Scarlett Clark
On Jan. 17, 2014, 3:30 a.m., Jonathan Riddell wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115065/
---
(Updated Jan. 17, 2014, 3:30 a.m.)
Review request for Documentation, KDE Frameworks, Luigi Toscano, and Scarlett
Clark.
Repository: kdoctools
Description
---
Rename man pages and checkXML tool to prevent clashes with kdelibs4
credit should go to scarlett
Diffs
-
CMakeLists.txt 74c7af5
checkXML.in.cmake d7a57c7
checkXML5.in.cmake PRE-CREATION
docs/CMakeLists.txt 7e9612f
docs/checkXML/CMakeLists.txt 7f8226c
docs/checkXML/man-checkXML.1.docbook 2bfb3f3
docs/checkXML5/CMakeLists.txt PRE-CREATION
docs/checkXML5/man-checkXML5.1.docbook PRE-CREATION
docs/kde5options/CMakeLists.txt PRE-CREATION
docs/kde5options/man-kde5options.7.docbook PRE-CREATION
docs/kdeoptions/CMakeLists.txt a91f451
docs/kdeoptions/man-kdeoptions.7.docbook 7e62f41
docs/qt5options/CMakeLists.txt PRE-CREATION
docs/qt5options/man-qt5options.7.docbook PRE-CREATION
docs/qtoptions/CMakeLists.txt f1dbb6c
docs/qtoptions/man-qtoptions.7.docbook a00677a
Diff: https://git.reviewboard.kde.org/r/115065/diff/
Testing
---
Thanks,
Jonathan Riddell
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115078: don't install dbus interface files in kglobalaccel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - KF5GlobalAccelConfig.cmake.in 5f069d3 src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
kjsembed should install variant_binding.h
kde-workspaces references variant_binding,h, which is not installed plasma/generic/dataengines/share/shareprovider.cpp: #include kjsembed/kjsembed.h #include KJsEmbed/variant_binding.h ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115063: Created missing manpage for desktoptojson binary
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115063/ --- (Updated Jan. 17, 2014, 8:10 a.m.) Review request for Documentation, KDE Frameworks, Jonathan Riddell, and Sebastian Kügler. Changes --- Add link to API Repository: kservice Description --- While building the package for kubuntu lintian complained about missing manpage for binary. So I created one :) This is my first manpage so be kind. I have no idea how to determine what type eg 1, 7, 8. Diffs (updated) - docs/CMakeLists.txt 86ed60b docs/desktoptojson/CMakeLists.txt PRE-CREATION docs/desktoptojson/man-desktoptojson.8.docbook PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115063/diff/ Testing --- meinproc5 --stylesheet /usr/share/ksgmltools2/customization/kde-include-man.xsl --check man-desktoptojson.8.docbook Thanks, Scarlett Clark ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47583 --- https://git.reviewboard.kde.org/r/115079/ is matching part in kde-workspace - Jonathan Riddell On Jan. 17, 2014, 4:07 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 17, 2014, 4:07 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - KF5GlobalAccelConfig.cmake.in 5f069d3 src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115065/ --- (Updated Jan. 17, 2014, 4:48 p.m.) Review request for Documentation, KDE Frameworks, Luigi Toscano, and Scarlett Clark. Repository: kdoctools Description --- Rename man pages and checkXML tool to prevent clashes with kdelibs4 credit should go to scarlett Diffs (updated) - CMakeLists.txt 74c7af5 checkXML.in.cmake d7a57c7 checkXML5.in.cmake PRE-CREATION docs/CMakeLists.txt 7e9612f docs/checkXML/CMakeLists.txt 7f8226c docs/checkXML/man-checkXML.1.docbook 2bfb3f3 docs/checkXML5/CMakeLists.txt PRE-CREATION docs/checkXML5/man-checkXML5.1.docbook PRE-CREATION docs/kde5options/CMakeLists.txt PRE-CREATION docs/kde5options/man-kde5options.7.docbook PRE-CREATION docs/kdeoptions/CMakeLists.txt a91f451 docs/kdeoptions/man-kdeoptions.7.docbook 7e62f41 docs/qt5options/CMakeLists.txt PRE-CREATION docs/qt5options/man-qt5options.7.docbook PRE-CREATION docs/qtoptions/CMakeLists.txt f1dbb6c docs/qtoptions/man-qtoptions.7.docbook a00677a Diff: https://git.reviewboard.kde.org/r/115065/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47587 --- and what if kdelibs (really, not kde-runtime?) from SC4 is not installed? KF/5 would be broken then, would it not? What about having a common data package downstream? - Thomas Lübking On Jan. 17, 2014, 4:07 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 17, 2014, 4:07 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - KF5GlobalAccelConfig.cmake.in 5f069d3 src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 #1077
See http://build.kde.org/job/plasma-framework_master_qt5/1077/changes Changes: [notmart] fix some crashes [notmart] panels in multiscreen is broken, add a todo -- [...truncated 2 lines...] Running Prebuild steps [plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson2379263005253118885.sh + /home/jenkins/scripts/setup-env.sh Preparing to perform KDE Continuous Integration build == Setting Up Sources From git://anongit.kde.org/plasma-framework 6b86584..9e25b45 master - origin/master Branch jenkins set up to track remote branch master from origin. == Cleaning Source Tree HEAD is now at 6b86584 Make it possible to fetch data for a said format Removing build/ Removing install/ Success build forhudson.tasks.Shell@7d5950f4 Fetching changes from the remote Git repository Fetching upstream changes from git://anongit.kde.org/plasma-framework.git Checking out Revision 9e25b45c0425d585e5b038b9cbdf0fe83244aa2e (refs/heads/jenkins) [plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson9108826114275151073.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: plasma-framework - Branch master == Build Dependencies: kinit - Branch master kauth - Branch master ktexteditor - Branch master kparts - Branch master kxmlgui - Branch master threadweaver - Branch master kdesupport-svn - Branch master qt5 - Branch stable knotifyconfig - Branch master kdeclarative - Branch master khtml - Branch master kcoreaddons - Branch master kitemmodels - Branch master kconfig - Branch master kactivities - Branch frameworks kded - Branch master kwallet-framework - Branch master kdoctools - Branch master knewstuff - Branch master kcrash - Branch master kdbusaddons - Branch master sonnet - Branch master kconfigwidgets - Branch master polkit-qt-1 - Branch qt5 kjobwidgets - Branch master kemoticons - Branch master kio - Branch master kde4support - Branch master kwidgetsaddons - Branch master kdesu - Branch master kglobalaccel - Branch master kitemviews - Branch master phonon - Branch master cmake - Branch master kjs - Branch master kdesignerplugin - Branch master kunitconversion - Branch master kdewebkit - Branch master knotifications - Branch master kiconthemes - Branch master karchive - Branch master kcompletion - Branch master kprintutils - Branch master solid - Branch master kguiaddons - Branch master kwindowsystem - Branch master attica - Branch master kf5umbrella - Branch master kcodecs - Branch master kross - Branch master kbookmarks - Branch master extra-cmake-modules - Branch master ktextwidgets - Branch master kplotting - Branch master kcmutils - Branch master kdnssd-framework - Branch master ki18n - Branch master kidletime - Branch master kpty - Branch master kservice - Branch master frameworkintegration - Branch master == Applying Patches === No patches to apply == Syncing Dependencies from Master Server == Configuring Build -- The C compiler identification is GNU 4.7.2 -- The CXX compiler identification is GNU 4.7.2 -- Check for working C compiler: /home/jenkins/bin/cc -- Check for working C compiler: /home/jenkins/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /home/jenkins/bin/c++ -- Check for working CXX compiler: /home/jenkins/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL -- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL - Success -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so - found -- Looking for gethostbyname -- Looking for gethostbyname - found -- Looking for connect -- Looking for connect - found -- Looking for remove -- Looking for remove - found -- Looking for shmat -- Looking for shmat - found -- Looking for IceConnectionNumber in ICE -- Looking for IceConnectionNumber in ICE - found -- Found X11: /usr/lib64/libX11.so -- Found PkgConfig: /usr/bin/pkg-config (found version 0.27.1) -- XCB[XCB]: Found component XCB -- Found XCB_XCB: /usr/lib64/libxcb.so -- XCB[COMPOSITE]: Found component COMPOSITE -- Found XCB_COMPOSITE: /usr/lib64/libxcb-composite.so -- XCB[DAMAGE]: Found component DAMAGE -- Found XCB_DAMAGE: /usr/lib64/libxcb-damage.so -- Found XCB: /usr/lib64/libxcb.so;/usr/lib64/libxcb-composite.so;/usr/lib64/libxcb-damage.so -- Found OpenSSL: /usr/lib64/libssl.so;/usr/lib64/libcrypto.so (found version 1.0.1e) CMake Warning at CMakeLists.txt:104 (find_package): Could not find a package configuration file provided by LibAttica with
Jenkins build is back to normal : plasma-framework_master_qt5 #1078
See http://build.kde.org/job/plasma-framework_master_qt5/1078/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115077/#review47592 --- KF5DocToolsMacros.cmake https://git.reviewboard.kde.org/r/115077/#comment33794 These should *not* be renamed, as they are compatibility macros. However, they should probably be moved to kde4support. - Alex Merry On Jan. 17, 2014, 3:14 p.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115077/ --- (Updated Jan. 17, 2014, 3:14 p.m.) Review request for Documentation and KDE Frameworks. Repository: kdoctools Description --- Part of the overall task of removing mentions of KDE4 from the code. Diffs - KF5DocToolsMacros.cmake 191a2c5 Diff: https://git.reviewboard.kde.org/r/115077/diff/ Testing --- Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115083: Python3 support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115083/#review47594 --- Ship it! Ah, I made too many changes since I last tested with python 3 :-) - Alex Merry On Jan. 17, 2014, 5:56 p.m., Alex Turbov wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115083/ --- (Updated Jan. 17, 2014, 5:56 p.m.) Review request for KDE Frameworks and Aurélien Gâteau. Repository: kapidox Description --- make it Python 3 compatible Diffs - src/doxyfilewriter.py 1a45934d8acccee1c0f3ca5dcf076b959dd466ef src/kgenapidox.py 5cc45bc50cb957db2708035594b11c8229ca5d91 Diff: https://git.reviewboard.kde.org/r/115083/diff/ Testing --- tested w/ python 3.3 and 2.7 Thanks, Alex Turbov ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115086: Adapt to new attica name
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115086/ --- Review request for KDE Frameworks. Repository: knewstuff Description --- Patch adjust KNewStuff buildsystem for the renamed attica lib. Diffs - KF5NewStuffConfig.cmake.in 1ab5269 src/CMakeLists.txt e26c678 Diff: https://git.reviewboard.kde.org/r/115086/diff/ Testing --- Builds. Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115086: Adapt to new attica name
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115086/#review47607 --- Ship it! Ship It! - Christophe Giboudeaux On Jan. 17, 2014, 8:15 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115086/ --- (Updated Jan. 17, 2014, 8:15 p.m.) Review request for KDE Frameworks. Repository: knewstuff Description --- Patch adjust KNewStuff buildsystem for the renamed attica lib. Diffs - KF5NewStuffConfig.cmake.in 1ab5269 src/CMakeLists.txt e26c678 Diff: https://git.reviewboard.kde.org/r/115086/diff/ Testing --- Builds. Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115083: Python3 support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115083/#review47608 --- This review has been submitted with commit 2b22c9e46afcdd6a80d075d0751184ca5bb21d19 by Alex Merry on behalf of Alex Turbov to branch master. - Commit Hook On Jan. 17, 2014, 5:56 p.m., Alex Turbov wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115083/ --- (Updated Jan. 17, 2014, 5:56 p.m.) Review request for KDE Frameworks and Aurélien Gâteau. Repository: kapidox Description --- make it Python 3 compatible Diffs - src/doxyfilewriter.py 1a45934d8acccee1c0f3ca5dcf076b959dd466ef src/kgenapidox.py 5cc45bc50cb957db2708035594b11c8229ca5d91 Diff: https://git.reviewboard.kde.org/r/115083/diff/ Testing --- tested w/ python 3.3 and 2.7 Thanks, Alex Turbov ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115083: Python3 support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115083/ --- (Updated Jan. 17, 2014, 8:21 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Aurélien Gâteau. Repository: kapidox Description --- make it Python 3 compatible Diffs - src/doxyfilewriter.py 1a45934d8acccee1c0f3ca5dcf076b959dd466ef src/kgenapidox.py 5cc45bc50cb957db2708035594b11c8229ca5d91 Diff: https://git.reviewboard.kde.org/r/115083/diff/ Testing --- tested w/ python 3.3 and 2.7 Thanks, Alex Turbov ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115086: Adapt to new attica name
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115086/#review47609 --- This review has been submitted with commit 1ffc383d0e32651e2f1b459a1bc26da4cafc1429 by Hrvoje Senjan to branch master. - Commit Hook On Jan. 17, 2014, 8:15 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115086/ --- (Updated Jan. 17, 2014, 8:15 p.m.) Review request for KDE Frameworks. Repository: knewstuff Description --- Patch adjust KNewStuff buildsystem for the renamed attica lib. Diffs - KF5NewStuffConfig.cmake.in 1ab5269 src/CMakeLists.txt e26c678 Diff: https://git.reviewboard.kde.org/r/115086/diff/ Testing --- Builds. Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115086: Adapt to new attica name
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115086/ --- (Updated Jan. 17, 2014, 8:23 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: knewstuff Description --- Patch adjust KNewStuff buildsystem for the renamed attica lib. Diffs - KF5NewStuffConfig.cmake.in 1ab5269 src/CMakeLists.txt e26c678 Diff: https://git.reviewboard.kde.org/r/115086/diff/ Testing --- Builds. Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47614 --- this would break my workflow given that I install kde4 and kf5 to different prefixes. I think this needs a different approach, but please don't ask me for it. I'm lacking ideas how we could solve this upstream. - Martin Gräßlin On Jan. 17, 2014, 5:07 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 17, 2014, 5:07 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - KF5GlobalAccelConfig.cmake.in 5f069d3 src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115087: Adapt to new attica name
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115087/ --- Review request for KDE Frameworks. Repository: kxmlgui Description --- Patch adjusts KXmlGui buildsystem for the renamed attica lib. Diffs - CMakeLists.txt 11a5af1 KF5XmlGuiConfig.cmake.in 0b01ae1 src/CMakeLists.txt 29e7dfe src/kaboutapplicationconfigattica_p.h.cmake d0c8ae7 Diff: https://git.reviewboard.kde.org/r/115087/diff/ Testing --- Builds w/ w/o KF5Attica Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115087: Adapt to new attica name
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115087/#review47615 --- Ship it! Ship It! - Christophe Giboudeaux On Jan. 17, 2014, 8:51 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115087/ --- (Updated Jan. 17, 2014, 8:51 p.m.) Review request for KDE Frameworks. Repository: kxmlgui Description --- Patch adjusts KXmlGui buildsystem for the renamed attica lib. Diffs - CMakeLists.txt 11a5af1 KF5XmlGuiConfig.cmake.in 0b01ae1 src/CMakeLists.txt 29e7dfe src/kaboutapplicationconfigattica_p.h.cmake d0c8ae7 Diff: https://git.reviewboard.kde.org/r/115087/diff/ Testing --- Builds w/ w/o KF5Attica Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115087: Adapt to new attica name
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115087/ --- (Updated Jan. 17, 2014, 8:57 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kxmlgui Description --- Patch adjusts KXmlGui buildsystem for the renamed attica lib. Diffs - CMakeLists.txt 11a5af1 KF5XmlGuiConfig.cmake.in 0b01ae1 src/CMakeLists.txt 29e7dfe src/kaboutapplicationconfigattica_p.h.cmake d0c8ae7 Diff: https://git.reviewboard.kde.org/r/115087/diff/ Testing --- Builds w/ w/o KF5Attica Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115087: Adapt to new attica name
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115087/#review47616 --- This review has been submitted with commit 4464daac6e487e2fdf7910231655ef774e05c5ae by Hrvoje Senjan to branch master. - Commit Hook On Jan. 17, 2014, 8:51 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115087/ --- (Updated Jan. 17, 2014, 8:51 p.m.) Review request for KDE Frameworks. Repository: kxmlgui Description --- Patch adjusts KXmlGui buildsystem for the renamed attica lib. Diffs - CMakeLists.txt 11a5af1 KF5XmlGuiConfig.cmake.in 0b01ae1 src/CMakeLists.txt 29e7dfe src/kaboutapplicationconfigattica_p.h.cmake d0c8ae7 Diff: https://git.reviewboard.kde.org/r/115087/diff/ Testing --- Builds w/ w/o KF5Attica Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115093: Add setup.py
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115093/ --- Review request for KDE Frameworks and Aurélien Gâteau. Repository: kapidox Description --- (sorry about the diff not recognising moved files; I couldn't get rbtools to upload the diff) Add setup.py Remove Mainpage.dox Drop .py extention from scripts Refactor to add a kapidox python package Diffs - .gitignore 0d20b64 Mainpage.dox 39104ea README.md 919c89b common/Doxyfile.global 96cb1c1 common/api_searchbox.html 9fd1ade common/dependencies.md 5e30d09 common/doxygen.css a0f924e common/footer.html 6e1683d common/frameworks.html f569f64 common/header.html 109045e common/htmlresource/block_title_bottom.png c0c0af5 common/htmlresource/block_title_mid.png f1ce933 common/htmlresource/block_title_top.png 2344376 common/htmlresource/favicon.ico 3741beb common/htmlresource/flat.css e1db552 common/htmlresource/kde.css c6c2d86 common/htmlresource/print.css 16818ba common/htmlresource/tabs.css a61552a common/htmlresource/top-kde.jpg 48967d3 common/htmlresource/top-left.jpg 23c31c7 common/htmlresource/top-right.jpg 22d2a29 common/htmlresource/top.jpg 8be8caa setup.py PRE-CREATION src/doxyfilewriter.py b071c01 src/kapidox/__init__.py PRE-CREATION src/kapidox/data/Doxyfile.global PRE-CREATION src/kapidox/data/api_searchbox.html PRE-CREATION src/kapidox/data/dependencies.md PRE-CREATION src/kapidox/data/doxygen.css PRE-CREATION src/kapidox/data/footer.html PRE-CREATION src/kapidox/data/frameworks.html PRE-CREATION src/kapidox/data/header.html PRE-CREATION src/kapidox/data/htmlresource/block_title_bottom.png PRE-CREATION src/kapidox/data/htmlresource/block_title_mid.png PRE-CREATION src/kapidox/data/htmlresource/block_title_top.png PRE-CREATION src/kapidox/data/htmlresource/favicon.ico PRE-CREATION src/kapidox/data/htmlresource/flat.css PRE-CREATION src/kapidox/data/htmlresource/kde.css PRE-CREATION src/kapidox/data/htmlresource/print.css PRE-CREATION src/kapidox/data/htmlresource/tabs.css PRE-CREATION src/kapidox/data/htmlresource/top-kde.jpg PRE-CREATION src/kapidox/data/htmlresource/top-left.jpg PRE-CREATION src/kapidox/data/htmlresource/top-right.jpg PRE-CREATION src/kapidox/data/htmlresource/top.jpg PRE-CREATION src/kapidox/doxyfilewriter.py PRE-CREATION src/kgenapidox PRE-CREATION src/kgenapidox.py 4a502c9 src/kgenframeworksapidox PRE-CREATION src/kgenframeworksapidox.py 37e8f96 Diff: https://git.reviewboard.kde.org/r/115093/diff/ Testing --- - ran kgenapidox on karchive from repo (python 2.7 and 3.3) - ran kgenframeworksapidox on frameworks from repo (python 2.7 and 3.3) - ran python setup.py install --prefix=$HOME/kf5 (python 2.7 and 3.3) - ran kgenapidox on karchive from installed location (python 2.7 and 3.3) - ran kgenframeworksapidox on frameworks from installed location (python 2.7 and 3.3) Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115097: KParts: Move each class into its own header/source file pair
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115097/ --- Review request for KDE Frameworks and David Faure. Repository: kparts Description --- As discussed in http://lists.kde.org/?l=kde-frameworks-develm=138994749530457w=2 this patch ensures that all (exported) classes are declared in header files which match the class name. And while includes had to be touched the patch also does some fixup/cleanup of includes, so the headers only include what is needed and have kparts/part.h in the installed headers and use part.h in the sources. These headers have been split out as new ones: From browserextension.h: * browserarguments.h * windowargs.h * openurlevent.h * browserhostextension.h * liveconnectextension.h From event.h: * guiactivateevent.h * partactivateevent.h * partselectevent.h From part.h: * openurlarguments.h * partbase.h * readonlypart.h * readwritepart.h From htmlextension.h: * selectorinterface.h * htmlsettingsinterface.h listingextension.h has been split up even, as there is no class ListingExtension, into: * listingfilterextension.h * listingnotificationextension.h Matching adaption for KDE4Support: https://git.reviewboard.kde.org/r/115098/ There is one issue: KDE4 code relies on getting all the now moved-out classes when including browserextension.h, event.h, part.h, htmlextension.h. While for CamelCase-forwarding headers, like KParts/Part or KParts/Event in KDE4Support this can be catched by just including all the now needed headers, I found no way yet to also have proper backward support for normal includes like kparts/part.h. There is lots of code which includes that to use KParts::ReadOnlyPart. Because kparts/part.h is now also the correct path for the now-only KParts::Part declaring header from the KParts modul, I could not simply install a kde4-compat part.h from KDE4Support into KDE4Support/kparts/ and then forward include the current headers, because it will fail at least with #include kparts/part.h Would it be acceptable to simply break SC for old code including the lowercase headers (like kparts/part.h) and using classes declared in there not matching the filename (like KParts::ReadOnlyPart)? Or is there a smart workaround for the problem? One workaround I proposed in the email: The real headers would just have the fallback support directly. E.g the new part.h would have // KDE4 compat #if KDE4COMPATIBLE #include kparts/guiactivateevent.h #include kparts/partactivateevent.h #include kparts/partselectevent.h #endif to include the other headers at the places where their classes had been defined before. This would mean having still KDE4 mentioned in KF5 code :) But KDE4COMPATIBLE (or a better name) should be only defined when KDE4Support is linked as well. No strong opinion myself. I would opt for the small SC-break :) Looking at all the stuff build with kdesrc-build/kf5-qt5-build-include there are small adaptions needed for * khtml * kross * kmediaplayer * kdewebkit * ktexteditor * kprintutils * okteta Mainly stuff like -#include kparts/part.h +#include kparts/readonlypart.h Locally all fixed, would commit the adaptions directly to those modules. Diffs - src/windowargs.cpp PRE-CREATION tests/normalktm.h f3bc291 tests/notepad.h 73a6fa2 tests/parts.h 1207c2c tests/parts.cpp 872bdb8 tests/partviewer.h bfe3158 tests/terminal_test.cpp eda318a tests/testmainwindow.h 7ba44e0 src/browserinterface.cpp a008e84 src/browseropenorsavequestion.h cb8d3ed src/browseropenorsavequestion.cpp dd52608 src/browserrun.h 5a0b996 src/browserrun.cpp bcf50df src/browserrun_p.h fbfbea6 src/event.h 056d735 src/event.cpp 1d88c82 src/fileinfoextension.h e1efbc1 src/fileinfoextension.cpp 8ecb234 src/guiactivateevent.h PRE-CREATION src/guiactivateevent.cpp PRE-CREATION src/historyprovider.h f167f30 src/historyprovider.cpp 1e4733a src/htmlextension.h 66966e4 src/htmlextension.cpp 3a6df16 src/htmlsettingsinterface.h PRE-CREATION src/htmlsettingsinterface.cpp PRE-CREATION src/kde_terminal_interface.h d029e02 src/listingextension.h 0b2e1dd src/listingextension.cpp d380584 src/listingfilterextension.h PRE-CREATION src/listingfilterextension.cpp PRE-CREATION src/listingnotificationextension.h PRE-CREATION src/listingnotificationextension.cpp PRE-CREATION src/liveconnectextension.h PRE-CREATION src/liveconnectextension.cpp PRE-CREATION src/mainwindow.h 11d0067 src/mainwindow.cpp 5c3917e src/openurlarguments.h PRE-CREATION src/openurlarguments.cpp PRE-CREATION src/openurlevent.h PRE-CREATION src/openurlevent.cpp PRE-CREATION src/part.h 05194d3 src/part.cpp 5a63777 src/part_p.h PRE-CREATION src/partactivateevent.h PRE-CREATION src/partactivateevent.cpp PRE-CREATION
Review Request 115098: Adapt KParts compat-forwarding headers to new one-header-per-class policy in KParts
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115098/ --- Review request for KDE Frameworks and David Faure. Repository: kde4support Description --- Counterpart to: https://git.reviewboard.kde.org/r/115097/ Main discussion over there, please. Diffs - src/includes/KParts/OpenUrlEvent c3e9e59 src/includes/KParts/Part bcb6c5e src/includes/KParts/PartActivateEvent dabdd2f src/includes/KParts/PartBase bcb6c5e src/includes/KParts/PartManager 2dcfeb3 src/includes/KParts/PartSelectEvent dabdd2f src/includes/KParts/Plugin f73168d src/includes/KParts/ReadOnlyPart bcb6c5e src/includes/KParts/ReadWritePart bcb6c5e src/includes/KParts/StatusBarExtension 8c8a481 src/includes/KParts/TextExtension cb73ab5 src/includes/KParts/WindowArgs c3e9e59 src/kparts/listingextension.h PRE-CREATION src/CMakeLists.txt 23b0d6d src/includes/CMakeLists.txt 2b2130f src/includes/KParts/BrowserExtension c3e9e59 src/includes/KParts/BrowserHostExtension c3e9e59 src/includes/KParts/BrowserInterface 640f47b src/includes/KParts/BrowserRun b63479b src/includes/KParts/Event dabdd2f src/includes/KParts/FileInfoExtension 13c7c41 src/includes/KParts/GUIActivateEvent dabdd2f src/includes/KParts/HistoryProvider b8c3fc9 src/includes/KParts/HtmlExtension aae280e src/includes/KParts/ListingExtension 38598f9 src/includes/KParts/LiveConnectExtension c3e9e59 src/includes/KParts/MainWindow 452e115 Diff: https://git.reviewboard.kde.org/r/115098/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
