Re: Review Request 115186: rename dbus interface file for kjobviewer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115186/#review48257 --- Ship it! Ship It! - David Faure On Jan. 21, 2014, 5:02 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115186/ --- (Updated Jan. 21, 2014, 5:02 p.m.) Review request for KDE Frameworks. Repository: kjobwidgets Description --- This dbus interface file also gets installed in kdelibs4 which overlaps it in kf5, some distros can not handle this. So rename the file on install. The dbus interface remains the same. This is the same technique used for kglobalaccel. Diffs - src/CMakeLists.txt 7527a0a Diff: https://git.reviewboard.kde.org/r/115186/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115300: Fix KKeySequence shortcut types flags
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115300/#review48258 --- Ship it! Hehe, nice find. The bug is in KDE 4.x too, but fixing it would be BIC, so yeah. - David Faure On Jan. 24, 2014, 4:13 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115300/ --- (Updated Jan. 24, 2014, 4:13 p.m.) Review request for KDE Frameworks. Repository: kxmlgui Description --- I assume the code was /trying/ to default to checking against local and global shortcuts, in practice it was only ever going to select local shortcuts. Diffs - src/kkeysequencewidget.cpp cc9016b src/kkeysequencewidget.h d5d70ea Diff: https://git.reviewboard.kde.org/r/115300/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: kf5options and qt5options manpages
On Tuesday 21 January 2014 18:38:28 Jonathan Riddell wrote: kdeoptions and qtoptions manpages listed the common options to applications using kdelibs4 and qt4. These have just become kf5options and qt5options. But which options are still true? From qt5options: All of these are now single-dash again (like Qt always made them, it's just that kcmdlineargs added double-dash equivalents for them). --display displayname Use the X-server display displayname. -display works --session sessionId Restore the application for the given sessionId. -session is still there. --cmap Causes the application to install a private color map on an 8-bit display. Remove. --ncols count Limits the number of colors allocated in the color cube on an 8-bit display, if the application is using the QApplication::ManyColor color specification. Remove. --nograb Tells Qt(TM) to never grab the mouse or the keyboard. --dograb Running under a debugger can cause an implicit --nograb, use --dograb to override. -nograb and -dograb are still there --sync Switches to synchronous mode for debugging. Seems to be gone, maybe due to the switch to XCB. --fn,--font fontname Defines the application font. --bg,--background color Sets the default background color and an application palette (light and dark shades are calculated). --fg,--foreground color Sets the default foreground color --btn,--button color Sets the default button color. Can't see any of this in the Qt code - remove. --name name Sets the application name. -name exists, in the XCB code, it sets the WM_CLASS. This docu should probably be made much more accurate. --title title Sets the application title (caption). Gone. --visual TrueColor Forces the application to use a TrueColor visual on an 8-bit display. Gone. --inputstyle inputstyle Sets XIM (X Input Method) input style. Possible values are onthespot, overthespot, offthespot and root. --im XIM server Set XIM server. --noxim Disable XIM Can't find anywhere, remove. --reverse mirrors the whole layout of widgets -reverse works --stylesheet file.qss applies the Qt stylesheet to the application widgets New in qt5: -platform qpa_platform_name -qwindowgeometry (as the portable equivalent for -geometry, which only works on xcb) -plugin plugin_name, not sure what it's used for exactly These should be documented in the QGuiApplication ctor docu but they are not, the list there is incomplete... From kf5options: --caption caption Use caption as name in the titlebar. Ah, this is a kde4support thing (kcmdlineargs). If we think this is useful, we should add it to Qt. Is it useful? --icon icon Use icon as the application icon. Same thing. --config filename Use the alternative configuration filename kde4support only - remove [one can use XDG_CONFIG_HOME instead, I suppose]. --nocrashhandler Disable the crash handler, to get core dumps. Removed, set KDE_DEBUG=1 instead. --waitforwm Waits for a WM_NET compatible windowmanager. kde4support only (- remove). --style style Sets the application GUI style. -style (is a Qt option, move it there) Add -stylesheet too See QApplication class docu for these. --geometry geometry Sets the client geometry of the main widget. Was from Qt. -geometry still works, on X11. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115099: This file provides the function ecm_generate_pri_file(). Make ECMSetupVersion set PROJECT_VERSION_*
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115099/#review48259
---
This review has been submitted with commit
fc09a7e81864ad5901a7996648ffe161370f2971 by David Faure to branch master.
- Commit Hook
On Jan. 22, 2014, 9:21 a.m., David Faure wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115099/
---
(Updated Jan. 22, 2014, 9:21 a.m.)
Review request for Build System, Extra Cmake Modules and KDE Frameworks.
Repository: extra-cmake-modules
Description
---
This file provides the function ecm_generate_pri_file().
ECM_GENERATE_PRI_FILE() creates a .pri file for a library so that qmake-based
apps can more easily use the library.
It also sets ECM_MKSPECS_INSTALL_DIR as the directory to install the .pri
file to.
REVIEW: 115099
Make ECMSetupVersion set PROJECT_VERSION_*
This makes it easier for other functions to access the project version,
for instance my upcoming ECM_GENERATE_PRI_FILE()
Diffs
-
modules/ECMGeneratePriFile.cmake PRE-CREATION
modules/ECMSetupVersion.cmake 6c3a9959be31ee186cf173bb28585dfc52860a55
Diff: https://git.reviewboard.kde.org/r/115099/diff/
Testing
---
Adding these lines to kwidgetaddons/src/CMakeLists.txt:
include(ECMGeneratePriFile)
ecm_generate_pri_file(BASE_NAME KWidgetsAddons LIB_NAME KF5WidgetsAddons DEPS
widgets FILENAME_VAR PRI_FILENAME)
install(FILES ${PRI_FILENAME} DESTINATION ${ECM_MKSPECS_INSTALL_DIR})
And these to kjobwidgets:
include(ECMGeneratePriFile)
ecm_generate_pri_file(BASE_NAME KJobWidgets LIB_NAME KF5JobWidgets DEPS
KCoreAddons widgets FILENAME_VAR PRI_FILENAME)
install(FILES ${PRI_FILENAME} DESTINATION ${ECM_MKSPECS_INSTALL_DIR})
And I added a qmake_test subdir in kf5umbrella with qmake_test.pro saying:
QT += KArchive KJobWidgets KWidgetsAddons
SOURCES += main.cpp
- links to all the mentionned libs, including KCoreAddons (via KJobWidgets).
This requires $QMAKEPATH set to the kf5 install prefix.
Thanks,
David Faure
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115186: rename dbus interface file for kjobviewer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115186/#review48260 --- This review has been submitted with commit 6ac3a3949166bd0519a96268bea24e498b48d602 by Jonathan Riddell to branch master. - Commit Hook On Jan. 21, 2014, 5:02 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115186/ --- (Updated Jan. 21, 2014, 5:02 p.m.) Review request for KDE Frameworks. Repository: kjobwidgets Description --- This dbus interface file also gets installed in kdelibs4 which overlaps it in kf5, some distros can not handle this. So rename the file on install. The dbus interface remains the same. This is the same technique used for kglobalaccel. Diffs - src/CMakeLists.txt 7527a0a Diff: https://git.reviewboard.kde.org/r/115186/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115186: rename dbus interface file for kjobviewer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115186/ --- (Updated Jan. 25, 2014, 9:40 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kjobwidgets Description --- This dbus interface file also gets installed in kdelibs4 which overlaps it in kf5, some distros can not handle this. So rename the file on install. The dbus interface remains the same. This is the same technique used for kglobalaccel. Diffs - src/CMakeLists.txt 7527a0a Diff: https://git.reviewboard.kde.org/r/115186/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kemoticons_master_qt5 #12
See http://build.kde.org/job/kemoticons_master_qt5/12/changes Changes: [faure] Generate and install .pri file [faure] Generate and install .pri file -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 in workspace http://build.kde.org/job/kemoticons_master_qt5/ws/ Running Prebuild steps [kemoticons_master_qt5] $ /bin/sh -xe /tmp/hudson6460480197596639587.sh + /home/jenkins/scripts/setup-env.sh Preparing to perform KDE Continuous Integration build == Setting Up Sources From git://anongit.kde.org/kemoticons 8568490..2982bd3 master - origin/master * [new tag] v4.95.0- v4.95.0 Branch jenkins set up to track remote branch master from origin. == Cleaning Source Tree HEAD is now at 8568490 Install all headers into camelcase FrameworkName. Removing build/ Removing install/ Success build forhudson.tasks.Shell@18fe0a71 Fetching changes from the remote Git repository Fetching upstream changes from git://anongit.kde.org/kemoticons Checking out Revision 2982bd3ce372ac28f570a18d23f100cf8d3cef8b (refs/heads/jenkins) Run condition [File exists] enabling prebuild for step [Publish JUnit test result report] Run condition [File exists] enabling prebuild for step [Publish Cppcheck results] [kemoticons_master_qt5] $ /bin/sh -xe /tmp/hudson5455188254947087084.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: kemoticons - Branch master == Build Dependencies: kcoreaddons - Branch master kdoctools - Branch master kconfig - Branch master kservice - Branch master karchive - Branch master qt5 - Branch stable kcrash - Branch master kjs - Branch master kdbusaddons - Branch master ki18n - Branch master cmake - Branch master extra-cmake-modules - Branch master kwindowsystem - Branch master == Applying Patches === No patches to apply == Syncing Dependencies from Master Server == Configuring Build -- The C compiler identification is GNU 4.7.2 -- The CXX compiler identification is GNU 4.7.2 -- Check for working C compiler: /home/jenkins/bin/cc -- Check for working C compiler: /home/jenkins/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /home/jenkins/bin/c++ -- Check for working CXX compiler: /home/jenkins/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL -- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL - Success -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success -- Performing Test COMPILER_HAS_DEPRECATED_ATTR -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success CMake Error at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/kdesupport/extra-cmake-modules/inst/share/ECM/modules/ECMGeneratePriFile.cmake:45 (message): Required argument BASE_NAME missing in ECM_GENERATE_PRI_FILE() call Call Stack (most recent call first): src/CMakeLists.txt:6 (ecm_generate_pri_file) -- Configuring incomplete, errors occurred! See also http://build.kde.org/job/kemoticons_master_qt5/ws/build/CMakeFiles/CMakeOutput.log;. Configure step exited with non-zero code, assuming failure to configure for project kemoticons. Build step 'Execute shell' marked build as failure [File exists] check if file exists [build/JUnitTestResults.xml] Run condition [File exists] preventing perform for step [Publish JUnit test result report] [File exists] check if file exists [build/cppcheck.xml] Run condition [File exists] preventing perform for step [Publish Cppcheck results] [WARNINGS] Skipping publisher since build result is FAILURE ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : kemoticons_master_qt5 #13
See http://build.kde.org/job/kemoticons_master_qt5/13/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115289: MSVC fix: Check for libintl.h and libintl.lib
On Jan. 24, 2014, 9:09 p.m., Alex Merry wrote: cmake/FindLibIntl.cmake, line 26 https://git.reviewboard.kde.org/r/115289/diff/2/?file=240465#file240465line26 Why not check if a libintl symbol exists without linking against any special libraries? Would be better, but I have to admit that I lack the required CMake skills. What would I have to do for that check? - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115289/#review48246 --- On Jan. 24, 2014, 5:06 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115289/ --- (Updated Jan. 24, 2014, 5:06 p.m.) Review request for KDE Frameworks and Chusslove Illich. Repository: ki18n Description --- MSVC fix: Check for libintl.h and libintl.lib On MSVC we have libintl as a separate library and must therefore explicitly link to it. This is not required on linux since gettext is part of glibc. On Windows libintl.h is not always found in the default include path and has to be searched for. Fix linking on MSVC by using KTRANSCRIPT_EXPORT Diffs - src/ktranscript.cpp e0570f1cccabb8e3a59ff952eac2817081ec4e9e src/kcatalog.cpp d337a50fb973e810e549671b60b2227db78d0628 src/gettext.h 3d3c2733576b5d2b977c3360519636662caf18c5 src/CMakeLists.txt bfb7d793a8cea883378555368eeec7582e8f88b1 cmake/FindLibIntl.cmake PRE-CREATION CMakeLists.txt 165f8c84156ebdb5034424752cc5f80a5d70319c Diff: https://git.reviewboard.kde.org/r/115289/diff/ Testing --- Compiles on Windows, no change to Linux Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Tier status of attica kwallet
On 01/25/2014 08:19 AM, Valentin Rusu wrote: On Friday, January 24, 2014 07:22:22 AM Kevin Ottens wrote: On Thursday 23 January 2014 22:47:45 Valentin Rusu wrote: On Wednesday, January 22, 2014 10:48:00 PM Kevin Ottens wrote: On Wednesday 22 January 2014 22:21:47 Valentin Rusu wrote: On Thursday, January 23, 2014 04:24:37 AM Michael Palimaka wrote: Hi, attica seems to have been absorbed as a framework, but does not appear to have been assigned a tier. Based on its dependencies, it looks like it would fit in tier 1? kwallet is in tier 2, but since b60582640d99e0ef603bf4e02df974793fb5ad27 it includes kwalletd which depends on higher tier frameworks - does it still belong in tier 2? kwallet-framework is still tier2, as there are no higher dependencies, AFAIK. If it depends on anything else which is not in Qt or tier 1, it automatically becomes tier 3. It can't depend on anything which is tier 2. OK, then it's tier3 :-) Please make sure http://community.kde.org/Frameworks/List is up to date then. Done. Also updated kde-build-metadata (minor change). kwallet-framework.yaml in the repo will need updating too. :-) ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: kf5options and qt5options manpages
El Dissabte, 25 de gener de 2014, a les 10:20:20, David Faure va escriure: On Tuesday 21 January 2014 18:38:28 Jonathan Riddell wrote: kdeoptions and qtoptions manpages listed the common options to applications using kdelibs4 and qt4. These have just become kf5options and qt5options. But which options are still true? --caption caption Use caption as name in the titlebar. Ah, this is a kde4support thing (kcmdlineargs). If we think this is useful, we should add it to Qt. Is it useful? --icon icon Use icon as the application icon. Isn't this kind of mandated by the desktop entry spec that says that %i will be translated to --icon? Besides ./kio/src/core/desktopexecparser.cpp seems to use it. Not sure about -caption but i'd say it may make sense too in some cases. Cheers, Albert ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115164: Keep tests together
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115164/#review48264 --- This review has been submitted with commit 3d69de1b9fe6055b727ee5ff8dd93f49aee8d096 by Michael Palimaka to branch master. - Commit Hook On Jan. 22, 2014, 3:57 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115164/ --- (Updated Jan. 22, 2014, 3:57 p.m.) Review request for KDE Frameworks and Valentin Rusu. Repository: kio Description --- There are two sets of sets in the middle of the source tree, away from the usual autotests/. This moves them so that they are all together. (I don't know why git didn't recognise certain files as just being moved in the diff) Diffs - src/ioslaves/http/kcookiejar/tests/cookie_rfc.test src/ioslaves/http/kcookiejar/tests/cookie_saving.test src/ioslaves/http/kcookiejar/tests/cookie_session.test src/ioslaves/http/kcookiejar/tests/cookie_settings.test src/ioslaves/http/kcookiejar/tests/kcookiejartest.cpp src/ioslaves/http/tests/CMakeLists.txt src/ioslaves/http/tests/httpauthenticationtest.h src/ioslaves/http/tests/httpauthenticationtest.cpp src/ioslaves/http/tests/httpfiltertest.cpp src/ioslaves/http/tests/httpheaderdispositiontest.h src/ioslaves/http/tests/httpheaderdispositiontest.cpp src/ioslaves/http/tests/httpheadertokenizetest.h src/ioslaves/http/tests/httpheadertokenizetest.cpp src/ioslaves/http/tests/httpobjecttest.h src/ioslaves/http/tests/httpobjecttest.cpp autotests/CMakeLists.txt 5655d45efcfd9455e1745a2ec93e2da30a9b83b2 autotests/http/CMakeLists.txt PRE-CREATION autotests/http/httpfiltertest.cpp PRE-CREATION autotests/http/tests/httpauthenticationtest.h PRE-CREATION autotests/http/tests/httpauthenticationtest.cpp PRE-CREATION autotests/http/tests/httpheaderdispositiontest.h PRE-CREATION autotests/http/tests/httpheaderdispositiontest.cpp PRE-CREATION autotests/http/tests/httpheadertokenizetest.h PRE-CREATION autotests/http/tests/httpheadertokenizetest.cpp PRE-CREATION autotests/http/tests/httpobjecttest.h PRE-CREATION autotests/http/tests/httpobjecttest.cpp PRE-CREATION autotests/kcookiejar/kcookiejartest.cpp PRE-CREATION autotests/kcookiejar/tests/CMakeLists.txt PRE-CREATION autotests/kcookiejar/tests/cookie.test PRE-CREATION autotests/kcookiejar/tests/cookie_rfc.test PRE-CREATION autotests/kcookiejar/tests/cookie_saving.test PRE-CREATION autotests/kcookiejar/tests/cookie_session.test PRE-CREATION autotests/kcookiejar/tests/cookie_settings.test PRE-CREATION src/ioslaves/http/CMakeLists.txt 39fd42f62bd583f92f655739a97a02b09c61 src/ioslaves/http/kcookiejar/CMakeLists.txt 54b1fe0b818f63cd76ac79d5233a3c00da866950 src/ioslaves/http/kcookiejar/tests/CMakeLists.txt src/ioslaves/http/kcookiejar/tests/cookie.test Diff: https://git.reviewboard.kde.org/r/115164/diff/ Testing --- Builds, affected tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115164: Keep tests together
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115164/ --- (Updated Jan. 25, 2014, 3:44 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Valentin Rusu. Repository: kio Description --- There are two sets of sets in the middle of the source tree, away from the usual autotests/. This moves them so that they are all together. (I don't know why git didn't recognise certain files as just being moved in the diff) Diffs - src/ioslaves/http/kcookiejar/tests/cookie_rfc.test src/ioslaves/http/kcookiejar/tests/cookie_saving.test src/ioslaves/http/kcookiejar/tests/cookie_session.test src/ioslaves/http/kcookiejar/tests/cookie_settings.test src/ioslaves/http/kcookiejar/tests/kcookiejartest.cpp src/ioslaves/http/tests/CMakeLists.txt src/ioslaves/http/tests/httpauthenticationtest.h src/ioslaves/http/tests/httpauthenticationtest.cpp src/ioslaves/http/tests/httpfiltertest.cpp src/ioslaves/http/tests/httpheaderdispositiontest.h src/ioslaves/http/tests/httpheaderdispositiontest.cpp src/ioslaves/http/tests/httpheadertokenizetest.h src/ioslaves/http/tests/httpheadertokenizetest.cpp src/ioslaves/http/tests/httpobjecttest.h src/ioslaves/http/tests/httpobjecttest.cpp autotests/CMakeLists.txt 5655d45efcfd9455e1745a2ec93e2da30a9b83b2 autotests/http/CMakeLists.txt PRE-CREATION autotests/http/httpfiltertest.cpp PRE-CREATION autotests/http/tests/httpauthenticationtest.h PRE-CREATION autotests/http/tests/httpauthenticationtest.cpp PRE-CREATION autotests/http/tests/httpheaderdispositiontest.h PRE-CREATION autotests/http/tests/httpheaderdispositiontest.cpp PRE-CREATION autotests/http/tests/httpheadertokenizetest.h PRE-CREATION autotests/http/tests/httpheadertokenizetest.cpp PRE-CREATION autotests/http/tests/httpobjecttest.h PRE-CREATION autotests/http/tests/httpobjecttest.cpp PRE-CREATION autotests/kcookiejar/kcookiejartest.cpp PRE-CREATION autotests/kcookiejar/tests/CMakeLists.txt PRE-CREATION autotests/kcookiejar/tests/cookie.test PRE-CREATION autotests/kcookiejar/tests/cookie_rfc.test PRE-CREATION autotests/kcookiejar/tests/cookie_saving.test PRE-CREATION autotests/kcookiejar/tests/cookie_session.test PRE-CREATION autotests/kcookiejar/tests/cookie_settings.test PRE-CREATION src/ioslaves/http/CMakeLists.txt 39fd42f62bd583f92f655739a97a02b09c61 src/ioslaves/http/kcookiejar/CMakeLists.txt 54b1fe0b818f63cd76ac79d5233a3c00da866950 src/ioslaves/http/kcookiejar/tests/CMakeLists.txt src/ioslaves/http/kcookiejar/tests/cookie.test Diff: https://git.reviewboard.kde.org/r/115164/diff/ Testing --- Builds, affected tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kio_master_qt5 #47
See http://build.kde.org/job/kio_master_qt5/47/changes Changes: [kensington] Move tests buried in the source tree out into autotests. -- [...truncated 792 lines...] [ 39%] [ 39%] [ 40%] Building CXX object src/kioslave/CMakeFiles/kioslave.dir/kioslave.cpp.o Building CXX object src/ioslaves/http/CMakeFiles/kio_http_cache_cleaner.dir/http_cache_cleaner.cpp.o [ 40%] Building CXX object src/kssld/CMakeFiles/kded_kssld.dir/kssld.cpp.o Generating fileundomanager_adaptor.cpp, fileundomanager_adaptor.h Scanning dependencies of target kio_ftp Scanning dependencies of target kio_file [ 41%] Building CXX object src/ioslaves/ftp/CMakeFiles/kio_ftp.dir/ftp.cpp.o [ 42%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/file.cpp.o [ 42%] Generating kuiserver_interface.cpp, kuiserver_interface.h Scanning dependencies of target kio_http [ 42%] Building CXX object src/ioslaves/http/CMakeFiles/kio_http.dir/http.cpp.o [ 43%] Generating ui_certificateparty.h [ 43%] Building CXX object src/kioslave/CMakeFiles/kioslave.dir/kioslave_automoc.cpp.o [ 43%] Building CXX object src/ioslaves/http/CMakeFiles/kio_http.dir/httpauthentication.cpp.o [ 43%] Generating ui_sslinfo.h Linking CXX executable kioslave [ 43%] Generating ui_kpropertiesdesktopadvbase.h [ 43%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/file_unix.cpp.o [ 44%] Generating ui_kpropertiesdesktopbase.h [ 44%] Building CXX object src/kssld/CMakeFiles/kded_kssld.dir/kded_kssld_automoc.cpp.o [ 45%] Generating fileundomanager_adaptor.moc [ 45%] Generating kuiserver_interface.moc [ 45%] Built target kioslave [ 45%] Linking CXX shared module kded_kssld.so Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/kio_file_automoc.cpp.o [ 46%] Building CXX object src/ioslaves/http/CMakeFiles/kio_http_cache_cleaner.dir/kio_http_cache_cleaner_automoc.cpp.o [ 47%] Building CXX object src/ioslaves/http/CMakeFiles/kio_http.dir/httpfilter.cpp.o [ 47%] Built target kded_kssld [ 47%] Building CXX object src/ioslaves/http/CMakeFiles/kio_http.dir/kio_http_automoc.cpp.o [ 47%] Building CXX object src/ioslaves/ftp/CMakeFiles/kio_ftp.dir/kio_ftp_automoc.cpp.o Linking CXX shared module kio_file.so Scanning dependencies of target dataprotocoltest [ 47%] Building CXX object autotests/CMakeFiles/dataprotocoltest.dir/dataprotocoltest.cpp.o Linking CXX executable kio_http_cache_cleaner [ 47%] Built target kio_file Scanning dependencies of target kio_help Scanning dependencies of target kio_ghelp [ 48%] [ 48%] Building CXX object src/ioslaves/help/CMakeFiles/kio_help.dir/kio_help.cpp.o Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/kio_help.cpp.o [ 48%] Building CXX object src/ioslaves/help/CMakeFiles/kio_help.dir/main.cpp.o Scanning dependencies of target globaltest [ 48%] Building CXX object autotests/CMakeFiles/globaltest.dir/globaltest.cpp.o [ 48%] [ 49%] Built target kio_http_cache_cleaner [ 49%] Building CXX object autotests/CMakeFiles/dataprotocoltest.dir/dataprotocoltest_automoc.cpp.o Building CXX object src/ioslaves/help/CMakeFiles/kio_help.dir/xslt_help.cpp.o Linking CXX shared module kio_ftp.so Linking CXX shared module kio_http.so [ 50%] Building CXX object autotests/CMakeFiles/globaltest.dir/globaltest_automoc.cpp.o [ 51%] Building CXX object src/ioslaves/help/CMakeFiles/kio_help.dir/kio_help_automoc.cpp.o [ 51%] Built target kio_ftp Linking CXX executable globaltest Linking CXX executable dataprotocoltest [ 52%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/main_ghelp.cpp.o Scanning dependencies of target jobremotetest [ 53%] Building CXX object autotests/CMakeFiles/jobremotetest.dir/jobremotetest.cpp.o Scanning dependencies of target jobtest [ 53%] [ 53%] Building CXX object autotests/CMakeFiles/jobremotetest.dir/jobremotetest_automoc.cpp.o [ 53%] Building CXX object autotests/CMakeFiles/jobtest.dir/jobtest.cpp.o Linking CXX shared module kio_help.so Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/xslt_help.cpp.o [ 53%] [ 53%] Built target kio_http Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/kio_ghelp_automoc.cpp.o [ 54%] Building CXX object autotests/CMakeFiles/jobtest.dir/jobtest_automoc.cpp.o [ 54%] Built target globaltest [ 54%] Built target dataprotocoltest Scanning dependencies of target kacltest [ 54%] Building CXX object autotests/CMakeFiles/kacltest.dir/kacltest.cpp.o Linking CXX shared module kio_ghelp.so Scanning dependencies of target kfileitemtest Linking CXX executable jobtest Scanning dependencies of target klocalsocketservertest [ 54%] Building CXX object autotests/CMakeFiles/kfileitemtest.dir/kfileitemtest.cpp.o [ 54%] Building CXX object autotests/CMakeFiles/klocalsocketservertest.dir/klocalsocketservertest.cpp.o Scanning dependencies of target klocalsockettest [ 54%] Building CXX object autotests/CMakeFiles/klocalsockettest.dir/klocalsockettest.cpp.o Linking CXX executable jobremotetest [ 54%] [ 54%]
Jenkins build is back to normal : kio_master_qt5 #48
See http://build.kde.org/job/kio_master_qt5/48/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115164: Keep tests together
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115164/#review48267 --- Please note that I also committed b0d4f3a86a46da4aed1812e9e8bda5bed5d8aa59 to fix a build failure this introduced when using GSSAPI. It just moves find_package(GSSAPI) to the root CMakeLists.txt - Michael Palimaka On Jan. 25, 2014, 3:44 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115164/ --- (Updated Jan. 25, 2014, 3:44 p.m.) Review request for KDE Frameworks and Valentin Rusu. Repository: kio Description --- There are two sets of sets in the middle of the source tree, away from the usual autotests/. This moves them so that they are all together. (I don't know why git didn't recognise certain files as just being moved in the diff) Diffs - src/ioslaves/http/kcookiejar/tests/cookie_rfc.test src/ioslaves/http/kcookiejar/tests/cookie_saving.test src/ioslaves/http/kcookiejar/tests/cookie_session.test src/ioslaves/http/kcookiejar/tests/cookie_settings.test src/ioslaves/http/kcookiejar/tests/kcookiejartest.cpp src/ioslaves/http/tests/CMakeLists.txt src/ioslaves/http/tests/httpauthenticationtest.h src/ioslaves/http/tests/httpauthenticationtest.cpp src/ioslaves/http/tests/httpfiltertest.cpp src/ioslaves/http/tests/httpheaderdispositiontest.h src/ioslaves/http/tests/httpheaderdispositiontest.cpp src/ioslaves/http/tests/httpheadertokenizetest.h src/ioslaves/http/tests/httpheadertokenizetest.cpp src/ioslaves/http/tests/httpobjecttest.h src/ioslaves/http/tests/httpobjecttest.cpp autotests/CMakeLists.txt 5655d45efcfd9455e1745a2ec93e2da30a9b83b2 autotests/http/CMakeLists.txt PRE-CREATION autotests/http/httpfiltertest.cpp PRE-CREATION autotests/http/tests/httpauthenticationtest.h PRE-CREATION autotests/http/tests/httpauthenticationtest.cpp PRE-CREATION autotests/http/tests/httpheaderdispositiontest.h PRE-CREATION autotests/http/tests/httpheaderdispositiontest.cpp PRE-CREATION autotests/http/tests/httpheadertokenizetest.h PRE-CREATION autotests/http/tests/httpheadertokenizetest.cpp PRE-CREATION autotests/http/tests/httpobjecttest.h PRE-CREATION autotests/http/tests/httpobjecttest.cpp PRE-CREATION autotests/kcookiejar/kcookiejartest.cpp PRE-CREATION autotests/kcookiejar/tests/CMakeLists.txt PRE-CREATION autotests/kcookiejar/tests/cookie.test PRE-CREATION autotests/kcookiejar/tests/cookie_rfc.test PRE-CREATION autotests/kcookiejar/tests/cookie_saving.test PRE-CREATION autotests/kcookiejar/tests/cookie_session.test PRE-CREATION autotests/kcookiejar/tests/cookie_settings.test PRE-CREATION src/ioslaves/http/CMakeLists.txt 39fd42f62bd583f92f655739a97a02b09c61 src/ioslaves/http/kcookiejar/CMakeLists.txt 54b1fe0b818f63cd76ac79d5233a3c00da866950 src/ioslaves/http/kcookiejar/tests/CMakeLists.txt src/ioslaves/http/kcookiejar/tests/cookie.test Diff: https://git.reviewboard.kde.org/r/115164/diff/ Testing --- Builds, affected tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build became unstable: kconfig_master_qt5 #22
See http://build.kde.org/job/kconfig_master_qt5/22/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kde4support_master_qt5 #36
See http://build.kde.org/job/kde4support_master_qt5/36/changes Changes: [scripty] SVN_SILENT made messages (.desktop file) -- [...truncated 605 lines...] Generating moc_kfiletreeview_p.cpp Generating moc_kmetaprops.cpp Generating moc_k3bufferedsocket.cpp Generating moc_k3clientsocketbase.cpp Generating moc_k3resolver.cpp Generating moc_k3reverseresolver.cpp Generating moc_k3serversocket.cpp Generating moc_k3socketbase.cpp Generating moc_k3streamsocket.cpp Generating moc_klibloader.cpp Generating moc_k4style.cpp Generating moc_k4timezonewidget.cpp Generating moc_karrowbutton.cpp Generating moc_kcolorvalueselector.cpp Generating moc_kdatetimewidget.cpp Generating moc_kdatewidget.cpp Generating moc_kdeuiwidgetsproxystyle_p.cpp Generating moc_kdialogbuttonbox.cpp Generating moc_keditlistbox.cpp Generating moc_kfontdialog.cpp Generating moc_khbox.cpp Generating moc_khuesaturationselect.cpp Generating moc_kmenubar.cpp Generating moc_kmessageboxmessagehandler.cpp Generating moc_knumvalidator.cpp Generating moc_kpassivepopupmessagehandler.cpp Generating moc_krestrictedline.cpp Generating moc_ksplashscreen.cpp Generating moc_kstatusbar.cpp Generating moc_kstringvalidator.cpp Generating moc_ktabbar.cpp Generating moc_ktextbrowser.cpp Generating moc_kundostack.cpp Generating moc_kvbox.cpp Generating moc_kdatatool.cpp Generating moc_kfileitemactionplugin.cpp Generating moc_kfilewriteplugin.cpp Generating moc_kscan.cpp Generating moc_metainfojob.cpp Generating moc_netaccess.cpp Generating moc_passworddialog.cpp Generating moc_factory.cpp [ 24%] Built target KF5KDE4Support_automoc Scanning dependencies of target KF5KDE4Support [ 24%] [ 24%] [ 24%] [ 24%] [ 25%] [ 25%] [ 25%] [ 26%] [ 26%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/k4aboutdata.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kcomponentdata.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kdebug.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kdebugdbusiface.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kdeversion.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kkernel_mac.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kkernel_win.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/klibloader.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/ktemporaryfile.cpp.o [ 26%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/ktempdir.cpp.o [ 26%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kmd5.cpp.o [ 27%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kmimetype.cpp.o http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k4aboutdata.cpp: In member function ‘void K4AboutData::translateInternalProgramName() const’: http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k4aboutdata.cpp:723:92: note: #pragma message: KDE5 FIXME: This code must be replaced by something with KLocalizedString http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k4aboutdata.cpp: In member function ‘QListK4AboutPerson K4AboutData::translators() const’: http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k4aboutdata.cpp:832:52: note: #pragma message: KDE5 TODO: What about this code ? [ 27%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kmimetyperepository.cpp.o [ 27%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/ksavefile.cpp.o http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/klibloader.cpp: In member function ‘KPluginFactory* KLibLoader::factory(const QString, QLibrary::LoadHints)’: http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/klibloader.cpp:136:40: warning: ‘KPluginFactory* KLibrary::factory(const char*)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/klibrary.h:58) [-Wdeprecated-declarations] [ 27%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/ksocketfactory.cpp.o [ 28%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3socks.cpp.o [ 28%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3sockssocketdevice.cpp.o [ 28%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3socketdevice.cpp.o In file included from http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k3socketdevice.h:29:0, from http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k3sockssocketdevice.h:23, from http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k3sockssocketdevice.cpp:20: http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k3socketbase.h:700:20: warning: ‘virtual qint64 KNetwork::KActiveSocketBase::readData(char*, qint64)’ was hidden [-Woverloaded-virtual] In file included from
Re: Review Request 115292: Do Configure Checks in the Correct Language
On Jan. 24, 2014, 2:17 p.m., Alex Merry wrote: src/ConfigureChecks.cmake, line 20 https://git.reviewboard.kde.org/r/115292/diff/1/?file=240431#file240431line20 This is the underlying cause of the issue. I think the reason your changes fix it is the same reason removing the -std=iso9899:1990 fixes it; GCC auto-enables various bits of functionality based on the -std variable, and the one for CXX is -std=c++0x. Alex Merry wrote: I'm just compile-checking my own fix for this, btw. Alex Merry wrote: Oh, but that doesn't mean you should discard your changes. If these features are used from C++ code, they should be checked in C++ code. Proper fixes at: https://git.reviewboard.kde.org/r/115294/ https://git.reviewboard.kde.org/r/115295/ https://git.reviewboard.kde.org/r/115296/ - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115292/#review48219 --- On Jan. 24, 2014, 1:55 p.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115292/ --- (Updated Jan. 24, 2014, 1:55 p.m.) Review request for KDE Frameworks and Alex Merry. Repository: kde4support Description --- A recent change in ECM revealed an issue with ConfigureChecks.cmake, where the check_symbol_exist calls would use the C compiler (with CFLAGS) and the compilation would happen in C++ (with CXXFLAGS). This change ports all checks to CXX where possible. Diffs - src/ConfigureChecks.cmake 7c8951f Diff: https://git.reviewboard.kde.org/r/115292/diff/ Testing --- 1. Refreshed builds for ECM and KDE4Support, both building OK 2. $ grep HAVE_GETADDRINFO src/config-network.h #define HAVE_GETADDRINFO 1 Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115289: MSVC fix: Check for libintl.h and libintl.lib
On Jan. 24, 2014, 8:09 p.m., Alex Merry wrote: cmake/FindLibIntl.cmake, line 26 https://git.reviewboard.kde.org/r/115289/diff/2/?file=240465#file240465line26 Why not check if a libintl symbol exists without linking against any special libraries? Alexander Richardson wrote: Would be better, but I have to admit that I lack the required CMake skills. What would I have to do for that check? Alex Merry wrote: I'm a bit rushed today, but you probably want to use http://www.cmake.org/cmake/help/v2.8.12/cmake.html#module:CheckCXXSymbolExists (quoting: If the header files declare the symbol as a function or variable then the symbol must also be available for linking.). If it fails, you need to find libintl. If you get stuck, let me know, and I'll try to look at it tomorrow or Monday. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115289/#review48246 --- On Jan. 24, 2014, 4:06 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115289/ --- (Updated Jan. 24, 2014, 4:06 p.m.) Review request for KDE Frameworks and Chusslove Illich. Repository: ki18n Description --- MSVC fix: Check for libintl.h and libintl.lib On MSVC we have libintl as a separate library and must therefore explicitly link to it. This is not required on linux since gettext is part of glibc. On Windows libintl.h is not always found in the default include path and has to be searched for. Fix linking on MSVC by using KTRANSCRIPT_EXPORT Diffs - src/ktranscript.cpp e0570f1cccabb8e3a59ff952eac2817081ec4e9e src/kcatalog.cpp d337a50fb973e810e549671b60b2227db78d0628 src/gettext.h 3d3c2733576b5d2b977c3360519636662caf18c5 src/CMakeLists.txt bfb7d793a8cea883378555368eeec7582e8f88b1 cmake/FindLibIntl.cmake PRE-CREATION CMakeLists.txt 165f8c84156ebdb5034424752cc5f80a5d70319c Diff: https://git.reviewboard.kde.org/r/115289/diff/ Testing --- Compiles on Windows, no change to Linux Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115289: MSVC fix: Check for libintl.h and libintl.lib
On Jan. 24, 2014, 8:09 p.m., Alex Merry wrote: cmake/FindLibIntl.cmake, line 26 https://git.reviewboard.kde.org/r/115289/diff/2/?file=240465#file240465line26 Why not check if a libintl symbol exists without linking against any special libraries? Alexander Richardson wrote: Would be better, but I have to admit that I lack the required CMake skills. What would I have to do for that check? I'm a bit rushed today, but you probably want to use http://www.cmake.org/cmake/help/v2.8.12/cmake.html#module:CheckCXXSymbolExists (quoting: If the header files declare the symbol as a function or variable then the symbol must also be available for linking.). If it fails, you need to find libintl. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115289/#review48246 --- On Jan. 24, 2014, 4:06 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115289/ --- (Updated Jan. 24, 2014, 4:06 p.m.) Review request for KDE Frameworks and Chusslove Illich. Repository: ki18n Description --- MSVC fix: Check for libintl.h and libintl.lib On MSVC we have libintl as a separate library and must therefore explicitly link to it. This is not required on linux since gettext is part of glibc. On Windows libintl.h is not always found in the default include path and has to be searched for. Fix linking on MSVC by using KTRANSCRIPT_EXPORT Diffs - src/ktranscript.cpp e0570f1cccabb8e3a59ff952eac2817081ec4e9e src/kcatalog.cpp d337a50fb973e810e549671b60b2227db78d0628 src/gettext.h 3d3c2733576b5d2b977c3360519636662caf18c5 src/CMakeLists.txt bfb7d793a8cea883378555368eeec7582e8f88b1 cmake/FindLibIntl.cmake PRE-CREATION CMakeLists.txt 165f8c84156ebdb5034424752cc5f80a5d70319c Diff: https://git.reviewboard.kde.org/r/115289/diff/ Testing --- Compiles on Windows, no change to Linux Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115316: Add demo for KRecentFileList
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115316/ --- Review request for KDE Frameworks. Repository: kconfigwidgets Description --- This is a demo test for KRecentFileList (in combination with KSharedConfig). The patch also contains a documentation update for krecentfilesaction.h/loadEntries() saying that Local file entries that do not exist anymore are not restored.. As a side note: Does it makes sense to optionally disable the automated removal of non-existing recent files? Or have the possibility to return the files that were automatically removed? Diffs - src/krecentfilesaction.h 38d1b5e3455d081304b064d13bccfc2164d12a14 tests/CMakeLists.txt 617a55944b2c91c9b09125ad92d070d3cd9a6551 tests/krecentfilesactiondemo.h PRE-CREATION tests/krecentfilesactiondemo.cpp PRE-CREATION tests/krecentfilesactiondemo.ui PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115316/diff/ Testing --- Thanks, Gregor Mi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KIO::convertSize(.,.) vs. KFormat::formatByteSize(...)
Hi David, Michael, everyone,
Am Freitag, 24. Januar 2014, 09:40:00 schrieb David Faure:
On Thursday 23 January 2014 23:43:36 Friedrich W. H. Kossebau wrote:
Hi,
I see a few overlappings between methods in KFormat (KCoreAddons) and KIO
(KIOCore), mainly this pair:
namespace KIO
{
typedef qulonglong filesize_t;
KIOCORE_EXPORT QString convertSize(KIO::filesize_t size);
}
and
class KCOREADDONS_EXPORT KFormat Q_DECL_FINAL
{
QString formatByteSize(double size,
int precision = 1,
KFormat::BinaryUnitDialect dialect =
KFormat::DefaultBinaryDialect,
KFormat::BinarySizeUnits units =
KFormat::DefaultBinaryUnits) const;
};
I think it makes sense to have two methods, at two different layers.
The KFormat one is like Qt: the caller of the method decides what they want.
The KIO one is as we like things in KDE, very often: it takes into account
the user's preference, for consistency across all KDE applications.
The KF5/Qt5 trend is to make that happen automatically behind the scenes of
the lowlevel (e.g. Qt) API, but that doesn't work for a method that is so
low-level that it actually takes the settings as parameters :)
Now, KFormat::formatByteSize(...) takes as default values
KFormat::DefaultBinaryDialect and KFormat::DefaultBinaryUnits. Both settings
mean that something should be chosen that is default. So from an API point of
view
KFormat::formatByteSize( byteSize )
and
KIO::convertSize( byteSize )
should behave and look the same, right? :)
(Currently just the used defaults are/can be different)
You say consistency across all KDE applications:
As a user I would like consistency across all my apps :) I do not (want to)
care what programming language and toolkit the developers preferred to know
what to expect in the UI. Programs should simply adapt to the system settings.
And the system is: the environment the program is running in, either something
fixed when creating the binary/package (Android, Sailfish, BB, Windows, OSX)
or something less fixed (Plasma Workspace, LXDE/Razor, GNOME Shell, Unity,
Enlightenment, XFCE).
So for systems where the default of a certain parameter is an option, I expect
the code to read that option in, and where it is not, I expect it to be
hardcoded to what makes sense on the system. For fixed systems that could be
compiled in hard, for less fixed this needs some runtime switching, either by
plugin or if-else code.
In a Plasma Workspace I expect the bytesize parameter defaults to be
configurable, like it used to be. And any program which wants to properly
integrate into that environment should pick these defaults up. Like I expect
the position of the Cancel/Ok buttons to be picked up :)
Possibly Plasma Workspace might be the only one where it is configurable, but
fine. That is one of the added-value of it :) (LXDE/Razor might be interested
to have it as well)
Or what is the direction? Maybe I misunderstood the intention of KF5, but I
thought it should be more nice Qt5 extension and not depend on lots of the
typical KDE runtime, unless useful for integration in a Plasma workspace (or
any other environment from KDE).
Questions:
Q1) What config files can be expected from KF5 modules?
So can KIO::convertSize(...) (which is already KDE4 code) expect such
config files to exist? Only in a Plasma workspace platform, or? How is
platform integration done in the KDE frameworks? E.g. in Unity, GNOME
Shell, Win, etc. I would expect that any matching config data is picked,
if there is, otherwise a hardcoded default.
http://community.kde.org/Frameworks/Policies does not mention that yet,
but I guess that has been discussed before?
Well, does a setting exist for how to format byte sizes (including the
choice between GB and GiB) in all these frameworks? I seriously doubt
that So it seems to me that picking this from a KConfig file for which
we have a KCM is the only solution?
... for which we have...: well, we have it in Plasma Workspace. There we
should use it, sure.
But we have not in Sailfish or on Android (or would you think it makes sense
to have a tuning app for all programs which use KF5? I do not.). And I doubt
people interested in KF5 would like their code to still reach out for all
those config files on those platforms as well. Especially as their apps are
additional apps, that IMHO should integrate smoothly with what is already
there and not suddenly start to show different formattings for file sizes,
dates etc. Or?
Now, KCoreAddons is a Functional Qt Addon in tier 1, KIO is a Solution in
tier 3. Hm. I wonder if that means anything for platform/system integration.
For comparison, QtCore is expected to integrate with
Re: KIO::convertSize(.,.) vs. KFormat::formatByteSize(...)
On Sun, January 26, 2014 00:20:02 Friedrich W. H. Kossebau wrote: In a Plasma Workspace I expect the bytesize parameter defaults to be configurable, like it used to be. And any program which wants to properly integrate into that environment should pick these defaults up. Like I expect the position of the Cancel/Ok buttons to be picked up :) Possibly Plasma Workspace might be the only one where it is configurable, but fine. That is one of the added-value of it :) (LXDE/Razor might be interested to have it as well) If it helps (and might also answer a quasi-question of David's), this setting is configurable in the Other tab of the 'language' KCM (the Locale button in KDE 4's System Settings). I'm not sure where that was put in KF5/PW2 yet. Regards, - Michael Pyne signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KIO::convertSize(.,.) vs. KFormat::formatByteSize(...)
Am Samstag, 25. Januar 2014, 21:20:25 schrieb Michael Pyne: On Sun, January 26, 2014 00:20:02 Friedrich W. H. Kossebau wrote: In a Plasma Workspace I expect the bytesize parameter defaults to be configurable, like it used to be. And any program which wants to properly integrate into that environment should pick these defaults up. Like I expect the position of the Cancel/Ok buttons to be picked up :) Possibly Plasma Workspace might be the only one where it is configurable, but fine. That is one of the added-value of it :) (LXDE/Razor might be interested to have it as well) If it helps (and might also answer a quasi-question of David's), this setting is configurable in the Other tab of the 'language' KCM (the Locale button in KDE 4's System Settings). I'm not sure where that was put in KF5/PW2 yet. Hm, that was not my point :) I was not wondering where in the UI of a Plasma (or perhaps Razor) environment a certain setting can be configured. Instead I was wondering what I if I wear the hat of a developer who considers using next to Qt5 also KF5 should expect in non-Plasma(/Razor) environments. And IMHO we (KDE hat on) should with KF5 also target/embrace those who look at Qt5 as the option to reach a lot of platforms in one go (even those less preferred by us, such is life). And IMHO KF5 code should integrate as much as possible in other platforms/system. And things which can not be configured in those systems should be hardcoded there to sensible values. Otherwise I fear KF5 will continue to be considered rather bloatware by so far Qt-only using devs because it pulls in all things needed for the rich configurability also in non-Plasma environments. Cheers Friedrich ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to stable : kconfig_master_qt5 #23
See http://build.kde.org/job/kconfig_master_qt5/23/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kde4support_master_qt5 #37
See http://build.kde.org/job/kde4support_master_qt5/37/changes Changes: [scripty] SVN_SILENT made messages (.desktop file) -- [...truncated 632 lines...] Generating moc_ksplashscreen.cpp Generating moc_kstatusbar.cpp Generating moc_kstringvalidator.cpp Generating moc_ktabbar.cpp Generating moc_ktextbrowser.cpp Generating moc_kundostack.cpp Generating moc_kvbox.cpp Generating moc_kdatatool.cpp Generating moc_kfileitemactionplugin.cpp Generating moc_kfilewriteplugin.cpp Generating moc_kscan.cpp Generating moc_metainfojob.cpp Generating moc_netaccess.cpp Generating moc_passworddialog.cpp Generating moc_factory.cpp [ 24%] Built target KF5KDE4Support_automoc Scanning dependencies of target KF5KDE4Support [ 24%] [ 24%] [ 24%] [ 24%] [ 25%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/k4aboutdata.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kcomponentdata.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kdebug.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kdeversion.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kdebugdbusiface.cpp.o [ 25%] [ 25%] [ 26%] [ 26%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kkernel_win.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kkernel_mac.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/klibloader.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/ktemporaryfile.cpp.o [ 26%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/ktempdir.cpp.o http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k4aboutdata.cpp: In member function ‘void K4AboutData::translateInternalProgramName() const’: http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k4aboutdata.cpp:723:92: note: #pragma message: KDE5 FIXME: This code must be replaced by something with KLocalizedString http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k4aboutdata.cpp: In member function ‘QListK4AboutPerson K4AboutData::translators() const’: http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k4aboutdata.cpp:832:52: note: #pragma message: KDE5 TODO: What about this code ? [ 26%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kmd5.cpp.o [ 27%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kmimetype.cpp.o [ 27%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/kmimetyperepository.cpp.o [ 27%] [ 27%] [ 28%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/ksavefile.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3socks.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/ksocketfactory.cpp.o [ 28%] [ 28%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3sockssocketdevice.cpp.o Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3socketdevice.cpp.o [ 28%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3bufferedsocket.cpp.o [ 29%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3clientsocketbase.cpp.o [ 29%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3resolver.cpp.o http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/klibloader.cpp: In member function ‘KPluginFactory* KLibLoader::factory(const QString, QLibrary::LoadHints)’: http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/klibloader.cpp:136:40: warning: ‘KPluginFactory* KLibrary::factory(const char*)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/klibrary.h:58) [-Wdeprecated-declarations] [ 29%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3resolvermanager.cpp.o [ 29%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3resolverworkerbase.cpp.o [ 30%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3resolverstandardworkers.cpp.o In file included from http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k3socketdevice.h:29:0, from http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k3sockssocketdevice.h:23, from http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k3sockssocketdevice.cpp:20: http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k3socketbase.h:700:20: warning: ‘virtual qint64 KNetwork::KActiveSocketBase::readData(char*, qint64)’ was hidden [-Woverloaded-virtual] In file included from http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k3sockssocketdevice.h:23:0, from http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k3sockssocketdevice.cpp:20: http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k3socketdevice.h:265:20: warning: by ‘virtual qint64 KNetwork::KSocketDevice::readData(char*, qint64, KNetwork::KSocketAddress*)’
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115078/#review48281
---
src/CMakeLists.txt
https://git.reviewboard.kde.org/r/115078/#comment34165
maybe I'm wrong but my logic says that this should be
install(FILES ${kglobalaccel_component_xml} DESTINATION
${DBUS_INTERFACES_INSTALL_DIR} RENAME kf5_org.kde.KGlobalAccel.Component.xml)
- István Kapcsándi
On Jan. 21, 2014, 4:24 p.m., Jonathan Riddell wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115078/
---
(Updated Jan. 21, 2014, 4:24 p.m.)
Review request for KDE Frameworks and Martin Gräßlin.
Repository: kglobalaccel
Description
---
don't install dbus interface files in kglobalaccel, these overlap with the
equivalent files in kdelibs4 which causes problems for some distributions
Diffs
-
src/CMakeLists.txt d48e92e
Diff: https://git.reviewboard.kde.org/r/115078/diff/
Testing
---
Thanks,
Jonathan Riddell
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
