Re: let's get ready for Google Summer of Code 2014

2014-02-09 Thread Lydia Pintscher
On Tue, Feb 4, 2014 at 9:24 AM, Lydia Pintscher ly...@kde.org wrote:
 Hey everyone :)

 It is time to get ready for GSoC 2014. It's another great chance to
 get some large projects done this year and welcome new enthusiastic
 people to KDE. I am working on our application.
 I have started our ideas page at
 http://community.kde.org/GSoC/2014/Ideas  Please go and add projects
 proposals that you think would be awesome to have a student work on
 them. Please only add proposals where either you or someone you know
 are willing to mentor them. If you have ideas but don't have a mentor
 for them please find a mentor first on the appropriate mailinglist.

 The ideas page needs to be in good shape by 14 February at 19:00 UTC.
 Go go go go! ;-)  http://community.kde.org/GSoC/2014/Ideas
 In case of questions please ask on #kde-soc or kde-soc-men...@kde.org.

Hey folks :)

*poke* about this. The ideas page is still looking rather empty and
the application deadline is getting closer. Please help with filling
up the ideas page. If you have questions or are unsure about a project
please ping me to discuss it.


Cheers
Lydia

-- 
Lydia Pintscher - http://about.me/lydia.pintscher
KDE e.V. Board of Directors / KDE Community Working Group
http://kde.org - http://open-advice.org
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115541: Build fix for Mac OS X

2014-02-09 Thread David Faure


 On Feb. 8, 2014, 10:07 a.m., David Faure wrote:
  Urgh, we were hoping this wouldn't be an issue.
  
  This commit would break #include attica/event.h, so it cannot go in.
  
  All namespaced frameworks do it this way already btw, see kparts for 
  instance:
  
  -- Up-to-date: 
  /d/kde/inst/kde_frameworks/include/KF5/KParts/KParts/ReadWritePart
  -- Up-to-date: 
  /d/kde/inst/kde_frameworks/include/KF5/KParts/kparts/readwritepart.h
  
  Since there is no filename clash, what is the issue if these end up in the 
  same folder on Mac OSX?
 
 Harald Fernengel wrote:
 Here's the layout after make install on OS X:
 
 include/KF5/KParts/textextension.h contains:
 
 #include /tmp/kf5-kparts-ty2Y/src/textextension.h
 
 ^^^ this is broken, points to the temporary build dir...? What should 
 this include?
 
 Then, we have include/KF5/KParts/KParts/ which contains both lower case 
 and upper case headers.
 
 include/KF5/KParts/KParts/textextension.h is the actual header
 
 include/KF5/KParts/KParts/TextExtension contains:
 
 #include kparts/textextension.h
 


Ah, I see. The local forwarding includes which are supposed to only be used 
during compilation of kparts, get installed because they end up in KParts/ 
instead of kparts/ (and the cmakelists.txt file just installs the whole 
directory).

I can think of two solutions...
1) put local forwarders into ./local/kparts instead of ./kparts, to ensure they 
stay out of ./KParts
2) change cmakelists.txt to install a list of camelcase headers instead of just 
the whole directory (which gives surprises with an unclean builddir, 
installing old stuff still lying around)

The first one seems simpler.

In kparts/src:
- target_include_directories(KF5Parts PUBLIC 
$BUILD_INTERFACE:${KParts_BINARY_DIR})
+ target_include_directories(KF5Parts PUBLIC 
$BUILD_INTERFACE:${KParts_BINARY_DIR}/local)

And in CEM:

diff --git a/modules/ECMGenerateHeaders.cmake b/modules/ECMGenerateHeaders.cmake
index e98a22e..38839f2 100644
--- a/modules/ECMGenerateHeaders.cmake
+++ b/modules/ECMGenerateHeaders.cmake
@@ -50,7 +50,7 @@ function(ECM_GENERATE_HEADERS)
 endif()
 
 if(NOT EGH_OUTPUT_DIR)
-set(EGH_OUTPUT_DIR ${CMAKE_CURRENT_BINARY_DIR})
+set(EGH_OUTPUT_DIR ${CMAKE_CURRENT_BINARY_DIR}/local)
 endif()
 
 # Make sure EGH_RELATIVE is /-terminated when it's not empty

Can you try it?


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115541/#review49240
---


On Feb. 7, 2014, 7:37 p.m., Harald Fernengel wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115541/
 ---
 
 (Updated Feb. 7, 2014, 7:37 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: attica
 
 
 Description
 ---
 
 Case-insensitive filesystems don't like the Attica vs. attica pathes, when 
 installing, the headers would all be messed up. Instead, install everything 
 to include/KF5/Attica to be in line with the other frameworks.
 
 Note - this might not be the best solution, but we need one in order to 
 deploy on Mac OS X :)
 
 
 Diffs
 -
 
   src/CMakeLists.txt 676c8a8e78420371bba19414b3f090180a49758d 
 
 Diff: https://git.reviewboard.kde.org/r/115541/diff/
 
 
 Testing
 ---
 
 Only on Mac OS X
 
 
 Thanks,
 
 Harald Fernengel
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115586: Improve attica tests

2014-02-09 Thread David Faure

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115586/#review49343
---


All looks good, but I'm not sure about removing the broken PrivateDataParser 
test (the class still exists, but is not exported and has a private parseXml 
method; it could be exported for the test and the test class marked as friend, 
for instance?).

sandsmark, can you confirm or deny removal of the autotest?

- David Faure


On Feb. 8, 2014, 7:52 p.m., Michael Palimaka wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115586/
 ---
 
 (Updated Feb. 8, 2014, 7:52 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: attica
 
 
 Description
 ---
 
 - Use BUILD_TESTING from ECM instead of custom ATTICA_ENABLE_TESTS
 - Remove enable_testing since this is done automatically by KDECMakeSettings
 - Mark tests
 - Remove old test that doesn't build, which tests API that no longer exists
 
 
 Diffs
 -
 
   CMakeLists.txt 445503efba2b49546137ce1548b3ddcddb2a0ebb 
   autotests/CMakeLists.txt e4a455730fd1faddf547b6c91d4477d707f41551 
   autotests/privatedatatest.cpp e5c2d2675b1f33631f2b31a2ce0eb5db28f3406a 
   tests/projecttest/CMakeLists.txt 0fce1bf8b2f9f93b9ee5b7961a12aeecdc8828a8 
 
 Diff: https://git.reviewboard.kde.org/r/115586/diff/
 
 
 Testing
 ---
 
 Builds. Tests pass when enabled, and do not run when not.
 
 
 Thanks,
 
 Michael Palimaka
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115586: Improve attica tests

2014-02-09 Thread Michael Palimaka

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115586/
---

(Updated Feb. 9, 2014, 2:49 p.m.)


Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.


Repository: attica


Description
---

- Use BUILD_TESTING from ECM instead of custom ATTICA_ENABLE_TESTS
- Remove enable_testing since this is done automatically by KDECMakeSettings
- Mark tests
- Remove old test that doesn't build, which tests API that no longer exists


Diffs
-

  CMakeLists.txt 445503efba2b49546137ce1548b3ddcddb2a0ebb 
  autotests/CMakeLists.txt e4a455730fd1faddf547b6c91d4477d707f41551 
  autotests/privatedatatest.cpp e5c2d2675b1f33631f2b31a2ce0eb5db28f3406a 
  tests/projecttest/CMakeLists.txt 0fce1bf8b2f9f93b9ee5b7961a12aeecdc8828a8 

Diff: https://git.reviewboard.kde.org/r/115586/diff/


Testing
---

Builds. Tests pass when enabled, and do not run when not.


Thanks,

Michael Palimaka

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 115597: Move customization directory from ksgmltools2 to kdoctools5

2014-02-09 Thread Luigi Toscano

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115597/
---

Review request for Documentation and KDE Frameworks.


Repository: kdoctools


Description
---

A name more in line with the module name is better, I think.


Diffs
-

  KF5DocToolsConfig.cmake.in aba1626 
  src/CMakeLists.txt 7526041 
  src/meinproc.cpp f340845 
  src/xslt.cpp 79578ed 

Diff: https://git.reviewboard.kde.org/r/115597/diff/


Testing
---

Documentation of higher level frameworks (kio) and applications (kate, konsole) 
compiles.


Thanks,

Luigi Toscano

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 115602: Rename kactivitymanagerd

2014-02-09 Thread Hrvoje Senjan

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115602/
---

Review request for KDE Frameworks and Ivan Čukić.


Repository: kactivities


Description
---

...so it can co-exists with kactivities4 in the same prefix


Diffs
-

  src/lib/core/manager_p.cpp 57f60be 
  src/service/CMakeLists.txt 348f8a3 
  src/service/files/kactivitymanagerd.desktop ce68a49 
  tests/core/Process.cpp b6279d0 

Diff: https://git.reviewboard.kde.org/r/115602/diff/


Testing
---

Both Plasma1 and Next ran fine with this patch and withouth 
kactivitymanagerd(4) installed. Haven't tested the case when they are both 
installed.


Thanks,

Hrvoje Senjan

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115602: Rename kactivitymanagerd

2014-02-09 Thread Ivan Čukić

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115602/#review49377
---


This is not something I'd give a green light for.

ActivityManager/KF5 is a drop-in replacement for the current one. They should 
*not* be installed side-by-side.



- Ivan Čukić


On Feb. 9, 2014, 6:45 p.m., Hrvoje Senjan wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115602/
 ---
 
 (Updated Feb. 9, 2014, 6:45 p.m.)
 
 
 Review request for KDE Frameworks and Ivan Čukić.
 
 
 Repository: kactivities
 
 
 Description
 ---
 
 ...so it can co-exists with kactivities4 in the same prefix
 
 
 Diffs
 -
 
   src/lib/core/manager_p.cpp 57f60be 
   src/service/CMakeLists.txt 348f8a3 
   src/service/files/kactivitymanagerd.desktop ce68a49 
   tests/core/Process.cpp b6279d0 
 
 Diff: https://git.reviewboard.kde.org/r/115602/diff/
 
 
 Testing
 ---
 
 Both Plasma1 and Next ran fine with this patch and withouth 
 kactivitymanagerd(4) installed. Haven't tested the case when they are both 
 installed.
 
 
 Thanks,
 
 Hrvoje Senjan
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115602: Rename kactivitymanagerd

2014-02-09 Thread Michael Palimaka


 On Feb. 9, 2014, 7:12 p.m., Ivan Čukić wrote:
  This is not something I'd give a green light for.
  
  ActivityManager/KF5 is a drop-in replacement for the current one. They 
  should *not* be installed side-by-side.
  
 

kactivitymanagerd might be drop in, but the rest of the framework is not. Any 
consumers that are not ported to KF5 will need to be dropped by packagers if 
it's not coinstallable.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115602/#review49377
---


On Feb. 9, 2014, 6:45 p.m., Hrvoje Senjan wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115602/
 ---
 
 (Updated Feb. 9, 2014, 6:45 p.m.)
 
 
 Review request for KDE Frameworks and Ivan Čukić.
 
 
 Repository: kactivities
 
 
 Description
 ---
 
 ...so it can co-exists with kactivities4 in the same prefix
 
 
 Diffs
 -
 
   src/lib/core/manager_p.cpp 57f60be 
   src/service/CMakeLists.txt 348f8a3 
   src/service/files/kactivitymanagerd.desktop ce68a49 
   tests/core/Process.cpp b6279d0 
 
 Diff: https://git.reviewboard.kde.org/r/115602/diff/
 
 
 Testing
 ---
 
 Both Plasma1 and Next ran fine with this patch and withouth 
 kactivitymanagerd(4) installed. Haven't tested the case when they are both 
 installed.
 
 
 Thanks,
 
 Hrvoje Senjan
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115602: Rename kactivitymanagerd

2014-02-09 Thread Ivan Čukić


 On Feb. 9, 2014, 7:12 p.m., Ivan Čukić wrote:
  This is not something I'd give a green light for.
  
  ActivityManager/KF5 is a drop-in replacement for the current one. They 
  should *not* be installed side-by-side.
  
 
 
 Michael Palimaka wrote:
 kactivitymanagerd might be drop in, but the rest of the framework is not. 
 Any consumers that are not ported to KF5 will need to be dropped by packagers 
 if it's not coinstallable.

The library is co-installable. And the old clients will continue working fine.

I don't want someone starting a libkactivities/kf5 client with a 
kactivitymanagerd/kf4

I would accept porting the KACTIVITIES_LIBRARY_ONLY build option from the kf5 
branch to kf4 version.


- Ivan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115602/#review49377
---


On Feb. 9, 2014, 6:45 p.m., Hrvoje Senjan wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115602/
 ---
 
 (Updated Feb. 9, 2014, 6:45 p.m.)
 
 
 Review request for KDE Frameworks and Ivan Čukić.
 
 
 Repository: kactivities
 
 
 Description
 ---
 
 ...so it can co-exists with kactivities4 in the same prefix
 
 
 Diffs
 -
 
   src/lib/core/manager_p.cpp 57f60be 
   src/service/CMakeLists.txt 348f8a3 
   src/service/files/kactivitymanagerd.desktop ce68a49 
   tests/core/Process.cpp b6279d0 
 
 Diff: https://git.reviewboard.kde.org/r/115602/diff/
 
 
 Testing
 ---
 
 Both Plasma1 and Next ran fine with this patch and withouth 
 kactivitymanagerd(4) installed. Haven't tested the case when they are both 
 installed.
 
 
 Thanks,
 
 Hrvoje Senjan
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 115605: Rename plasmapkg

2014-02-09 Thread Hrvoje Senjan

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115605/
---

Review request for KDE Frameworks, Plasma and Sebastian Kügler.


Repository: plasma-framework


Description
---

...so it can be co-installed in the same prefix as kde-runtime(4)


Diffs
-

  src/plasmapkg/CMakeLists.txt a9e186f 

Diff: https://git.reviewboard.kde.org/r/115605/diff/


Testing
---

Builds


Thanks,

Hrvoje Senjan

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115602: Rename kactivitymanagerd

2014-02-09 Thread Hrvoje Senjan


 On Feb. 9, 2014, 7:12 p.m., Ivan Čukić wrote:
  This is not something I'd give a green light for.
  
  ActivityManager/KF5 is a drop-in replacement for the current one. They 
  should *not* be installed side-by-side.
  
 
 
 Michael Palimaka wrote:
 kactivitymanagerd might be drop in, but the rest of the framework is not. 
 Any consumers that are not ported to KF5 will need to be dropped by packagers 
 if it's not coinstallable.
 
 Ivan Čukić wrote:
 The library is co-installable. And the old clients will continue working 
 fine.
 
 I don't want someone starting a libkactivities/kf5 client with a 
 kactivitymanagerd/kf4
 
 I would accept porting the KACTIVITIES_LIBRARY_ONLY build option from the 
 kf5 branch to kf4 version.
 
 Michael Palimaka wrote:
 Are you suggesting to ship kactivitymanagerd in KF5 package only, and 
 have kactivities consumers depend on both kactivities 4 and 5?

Ivan, we (distros) cannot make 'LTS' workspace depened on unreleased code, but 
we would like to provide both kactivities4 and kf5 version to users. As said, 
at least the most used clients, work with this patch without further adjusting 
on their side.


- Hrvoje


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115602/#review49377
---


On Feb. 9, 2014, 6:45 p.m., Hrvoje Senjan wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115602/
 ---
 
 (Updated Feb. 9, 2014, 6:45 p.m.)
 
 
 Review request for KDE Frameworks and Ivan Čukić.
 
 
 Repository: kactivities
 
 
 Description
 ---
 
 ...so it can co-exists with kactivities4 in the same prefix
 
 
 Diffs
 -
 
   src/lib/core/manager_p.cpp 57f60be 
   src/service/CMakeLists.txt 348f8a3 
   src/service/files/kactivitymanagerd.desktop ce68a49 
   tests/core/Process.cpp b6279d0 
 
 Diff: https://git.reviewboard.kde.org/r/115602/diff/
 
 
 Testing
 ---
 
 Both Plasma1 and Next ran fine with this patch and withouth 
 kactivitymanagerd(4) installed. Haven't tested the case when they are both 
 installed.
 
 
 Thanks,
 
 Hrvoje Senjan
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: let's get ready for Google Summer of Code 2014

2014-02-09 Thread Mark Gaiser
On Sun, Feb 9, 2014 at 1:37 PM, Lydia Pintscher ly...@kde.org wrote:
 On Tue, Feb 4, 2014 at 9:24 AM, Lydia Pintscher ly...@kde.org wrote:
 Hey everyone :)

 It is time to get ready for GSoC 2014. It's another great chance to
 get some large projects done this year and welcome new enthusiastic
 people to KDE. I am working on our application.
 I have started our ideas page at
 http://community.kde.org/GSoC/2014/Ideas  Please go and add projects
 proposals that you think would be awesome to have a student work on
 them. Please only add proposals where either you or someone you know
 are willing to mentor them. If you have ideas but don't have a mentor
 for them please find a mentor first on the appropriate mailinglist.

 The ideas page needs to be in good shape by 14 February at 19:00 UTC.
 Go go go go! ;-)  http://community.kde.org/GSoC/2014/Ideas
 In case of questions please ask on #kde-soc or kde-soc-men...@kde.org.

 Hey folks :)

 *poke* about this. The ideas page is still looking rather empty and
 the application deadline is getting closer. Please help with filling
 up the ideas page. If you have questions or are unsure about a project
 please ping me to discuss it.


 Cheers
 Lydia

(only leaving kde-soc-mentor in cc)

I do have an idea for KIO in the next GSoC.

Revive the KioFuse code to todays KIO version and update it.
The start is there [1] and it's even working on kdelibs 4.0 (don't
know it's current state). But it would be very wonderful if that could
be working and then integrated in Dolphin (and obviously in my
Accretion ^_^)

Having this would resolve the issue that opening a network file from
Dolphin in (for example) mplayer downloads the entire file to your
hdd/ssd before opening it in mplayer.

The code is here, the opportunity (due to GSoC) is here. All we need
now is a student willing to take on this massive task and someone to
mentor the student.

[1] http://techbase.kde.org/Projects/KioFuse
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 115606: Ommit ontologies/ dir from installing

2014-02-09 Thread Hrvoje Senjan

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115606/
---

Review request for KDE Frameworks and Ivan Čukić.


Repository: kactivities


Description
---

So kf5 kactivities can be co-installed with kactivities4. First approach is 
just to comment out the dir. I don't know what are the plans, so potentially i 
can git rm the dir, considering the emerge of baloo with 4.13


Diffs
-

  src/CMakeLists.txt 8a00cf8 

Diff: https://git.reviewboard.kde.org/r/115606/diff/


Testing
---

Builds.


Thanks,

Hrvoje Senjan

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115602: Rename kactivitymanagerd

2014-02-09 Thread Ivan Čukić


 On Feb. 9, 2014, 7:12 p.m., Ivan Čukić wrote:
  This is not something I'd give a green light for.
  
  ActivityManager/KF5 is a drop-in replacement for the current one. They 
  should *not* be installed side-by-side.
  
 
 
 Michael Palimaka wrote:
 kactivitymanagerd might be drop in, but the rest of the framework is not. 
 Any consumers that are not ported to KF5 will need to be dropped by packagers 
 if it's not coinstallable.
 
 Ivan Čukić wrote:
 The library is co-installable. And the old clients will continue working 
 fine.
 
 I don't want someone starting a libkactivities/kf5 client with a 
 kactivitymanagerd/kf4
 
 I would accept porting the KACTIVITIES_LIBRARY_ONLY build option from the 
 kf5 branch to kf4 version.
 
 Michael Palimaka wrote:
 Are you suggesting to ship kactivitymanagerd in KF5 package only, and 
 have kactivities consumers depend on both kactivities 4 and 5?
 
 Hrvoje Senjan wrote:
 Ivan, we (distros) cannot make 'LTS' workspace depened on unreleased 
 code, but we would like to provide both kactivities4 and kf5 version to 
 users. As said, at least the most used clients, work with this patch without 
 further adjusting on their side.

This might not be clear: libkactivities/5 *needs* kactivitymanagerd/5

--

When we get the next workspace and all, Qt4/KDElibs4 clients will require 
libkactivities/4, Qt5/KF5 clients will require libkactivities/5. And kamd/qt5 
will be the only choice.

In the transition period, the packagers can easily create a meta-package called 
kactivitymanager that depends on either 4 or 5 (with those versions mutually 
exclusive), and libkactivities/qt4 would depend on that one. libkactivities/qt5 
would depend on kactivitymanager-kf5.

@Hrvoje

I do get that. But, if you want kactivities5 clients, you *need* the 
kactivities5 service, and thus you need the unreleased code. And you get the 
problems of config files not being converted etc.

With that said, the packagers can use this patch if they want to. That way, if 
somebody reports bugs due to the library being newer than the service (the new 
library uses added apis), I can freely mark them as downstream.

Or you can install the unreleased things in a different prefix (like it was 
usually done for kde4 while it was in development) to tell the user 'this is 
not ready'.

Still, I'd rather have the situation above, all relevant distros have package 
management systems that can handle things like these.


- Ivan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115602/#review49377
---


On Feb. 9, 2014, 6:45 p.m., Hrvoje Senjan wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115602/
 ---
 
 (Updated Feb. 9, 2014, 6:45 p.m.)
 
 
 Review request for KDE Frameworks and Ivan Čukić.
 
 
 Repository: kactivities
 
 
 Description
 ---
 
 ...so it can co-exists with kactivities4 in the same prefix
 
 
 Diffs
 -
 
   src/lib/core/manager_p.cpp 57f60be 
   src/service/CMakeLists.txt 348f8a3 
   src/service/files/kactivitymanagerd.desktop ce68a49 
   tests/core/Process.cpp b6279d0 
 
 Diff: https://git.reviewboard.kde.org/r/115602/diff/
 
 
 Testing
 ---
 
 Both Plasma1 and Next ran fine with this patch and withouth 
 kactivitymanagerd(4) installed. Haven't tested the case when they are both 
 installed.
 
 
 Thanks,
 
 Hrvoje Senjan
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 115610: Hide private method behind the d-pointer in KLineEdit

2014-02-09 Thread David Gil Oliva

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115610/
---

Review request for KDE Frameworks.


Repository: kcompletion


Description
---

Hide private method behind the d-pointer in KLineEdit

Also:
--Move declaration of KLineEditPrivate to klineedit_p.h and leave 
implementation in klineedit.cpp
--For coherence, change initWidget() for init()
--Un-include headers not used

In another patch I will hide other private methods and private slots


Diffs
-

  src/klineedit.h bea787a 
  src/klineedit.cpp 73e91df 
  src/klineedit_p.h 333135c 

Diff: https://git.reviewboard.kde.org/r/115610/diff/


Testing
---

It builds. Tests pass.


Thanks,

David Gil Oliva

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: let's get ready for Google Summer of Code 2014

2014-02-09 Thread Aleix Pol
On Sun, Feb 9, 2014 at 8:57 PM, Mark Gaiser mark...@gmail.com wrote:

 On Sun, Feb 9, 2014 at 1:37 PM, Lydia Pintscher ly...@kde.org wrote:
  On Tue, Feb 4, 2014 at 9:24 AM, Lydia Pintscher ly...@kde.org wrote:
  Hey everyone :)
 
  It is time to get ready for GSoC 2014. It's another great chance to
  get some large projects done this year and welcome new enthusiastic
  people to KDE. I am working on our application.
  I have started our ideas page at
  http://community.kde.org/GSoC/2014/Ideas  Please go and add projects
  proposals that you think would be awesome to have a student work on
  them. Please only add proposals where either you or someone you know
  are willing to mentor them. If you have ideas but don't have a mentor
  for them please find a mentor first on the appropriate mailinglist.
 
  The ideas page needs to be in good shape by 14 February at 19:00 UTC.
  Go go go go! ;-)  http://community.kde.org/GSoC/2014/Ideas
  In case of questions please ask on #kde-soc or kde-soc-men...@kde.org.
 
  Hey folks :)
 
  *poke* about this. The ideas page is still looking rather empty and
  the application deadline is getting closer. Please help with filling
  up the ideas page. If you have questions or are unsure about a project
  please ping me to discuss it.
 
 
  Cheers
  Lydia

 (only leaving kde-soc-mentor in cc)

 I do have an idea for KIO in the next GSoC.

 Revive the KioFuse code to todays KIO version and update it.
 The start is there [1] and it's even working on kdelibs 4.0 (don't
 know it's current state). But it would be very wonderful if that could
 be working and then integrated in Dolphin (and obviously in my
 Accretion ^_^)

 Having this would resolve the issue that opening a network file from
 Dolphin in (for example) mplayer downloads the entire file to your
 hdd/ssd before opening it in mplayer.

 The code is here, the opportunity (due to GSoC) is here. All we need
 now is a student willing to take on this massive task and someone to
 mentor the student.

 [1] http://techbase.kde.org/Projects/KioFuse
 ___
 Kde-frameworks-devel mailing list
 Kde-frameworks-devel@kde.org
 https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Hi Mark,
Feel free to add the proposal yourself. :) It's a wiki.

Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: let's get ready for Google Summer of Code 2014

2014-02-09 Thread Mark Gaiser
On Mon, Feb 10, 2014 at 12:51 AM, Aleix Pol aleix...@kde.org wrote:
 On Sun, Feb 9, 2014 at 8:57 PM, Mark Gaiser mark...@gmail.com wrote:

 On Sun, Feb 9, 2014 at 1:37 PM, Lydia Pintscher ly...@kde.org wrote:
  On Tue, Feb 4, 2014 at 9:24 AM, Lydia Pintscher ly...@kde.org wrote:
  Hey everyone :)
 
  It is time to get ready for GSoC 2014. It's another great chance to
  get some large projects done this year and welcome new enthusiastic
  people to KDE. I am working on our application.
  I have started our ideas page at
  http://community.kde.org/GSoC/2014/Ideas  Please go and add projects
  proposals that you think would be awesome to have a student work on
  them. Please only add proposals where either you or someone you know
  are willing to mentor them. If you have ideas but don't have a mentor
  for them please find a mentor first on the appropriate mailinglist.
 
  The ideas page needs to be in good shape by 14 February at 19:00 UTC.
  Go go go go! ;-)  http://community.kde.org/GSoC/2014/Ideas
  In case of questions please ask on #kde-soc or kde-soc-men...@kde.org.
 
  Hey folks :)
 
  *poke* about this. The ideas page is still looking rather empty and
  the application deadline is getting closer. Please help with filling
  up the ideas page. If you have questions or are unsure about a project
  please ping me to discuss it.
 
 
  Cheers
  Lydia

 (only leaving kde-soc-mentor in cc)

 I do have an idea for KIO in the next GSoC.

 Revive the KioFuse code to todays KIO version and update it.
 The start is there [1] and it's even working on kdelibs 4.0 (don't
 know it's current state). But it would be very wonderful if that could
 be working and then integrated in Dolphin (and obviously in my
 Accretion ^_^)

 Having this would resolve the issue that opening a network file from
 Dolphin in (for example) mplayer downloads the entire file to your
 hdd/ssd before opening it in mplayer.

 The code is here, the opportunity (due to GSoC) is here. All we need
 now is a student willing to take on this massive task and someone to
 mentor the student.

 [1] http://techbase.kde.org/Projects/KioFuse
 ___
 Kde-frameworks-devel mailing list
 Kde-frameworks-devel@kde.org
 https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


 Hi Mark,
 Feel free to add the proposal yourself. :) It's a wiki.

 Aleix

 ___
 Kde-frameworks-devel mailing list
 Kde-frameworks-devel@kde.org
 https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


I know :)

Posting this here to see if anyone would be interested in mentoring this.
Will add it to the wiki somewhere tomorrow.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115530: Find Qt5::X11Extras only if X11 is found

2014-02-09 Thread Martin Gräßlin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115530/
---

(Updated Feb. 10, 2014, 6:56 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kwindowsystem


Description
---

Find Qt5::X11Extras only if X11 is found

No need to have a required dependency on X11Extras if we don't build
for X11.


Diffs
-

  CMakeLists.txt 6cebf0cb22f5c0192e0423c4084f12b9dda75151 

Diff: https://git.reviewboard.kde.org/r/115530/diff/


Testing
---

compiles with and without X11


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115528: Suppress warnings if built without X11 support

2014-02-09 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115528/#review49409
---


This review has been submitted with commit 
0cceeaeda740adf8d5e0e28818a13e6157515bcd by Martin Gräßlin to branch master.

- Commit Hook


On Feb. 7, 2014, 8:30 a.m., Martin Gräßlin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115528/
 ---
 
 (Updated Feb. 7, 2014, 8:30 a.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kwindowsystem
 
 
 Description
 ---
 
 Suppress warnings if built without X11 support
 
 
 Diffs
 -
 
   src/kusertimestamp.cpp 1fe7cd4379892ded9ac22378b675b6974f385022 
   src/kstartupinfo.cpp d0022512748d11462409e2111ce6f592ebfa656a 
 
 Diff: https://git.reviewboard.kde.org/r/115528/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Martin Gräßlin
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115528: Suppress warnings if built without X11 support

2014-02-09 Thread Martin Gräßlin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115528/
---

(Updated Feb. 10, 2014, 6:56 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kwindowsystem


Description
---

Suppress warnings if built without X11 support


Diffs
-

  src/kusertimestamp.cpp 1fe7cd4379892ded9ac22378b675b6974f385022 
  src/kstartupinfo.cpp d0022512748d11462409e2111ce6f592ebfa656a 

Diff: https://git.reviewboard.kde.org/r/115528/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115530: Find Qt5::X11Extras only if X11 is found

2014-02-09 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115530/#review49408
---


This review has been submitted with commit 
757fc25af49a5cdd1971d37f618e5581f562c505 by Martin Gräßlin to branch master.

- Commit Hook


On Feb. 7, 2014, 8:46 a.m., Martin Gräßlin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115530/
 ---
 
 (Updated Feb. 7, 2014, 8:46 a.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kwindowsystem
 
 
 Description
 ---
 
 Find Qt5::X11Extras only if X11 is found
 
 No need to have a required dependency on X11Extras if we don't build
 for X11.
 
 
 Diffs
 -
 
   CMakeLists.txt 6cebf0cb22f5c0192e0423c4084f12b9dda75151 
 
 Diff: https://git.reviewboard.kde.org/r/115530/diff/
 
 
 Testing
 ---
 
 compiles with and without X11
 
 
 Thanks,
 
 Martin Gräßlin
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115531: Only build kx(utils|errorhandler).cpp if we HAVE_X11

2014-02-09 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115531/#review49410
---


This review has been submitted with commit 
bc473053b1fe3b78b15c99ff0da5b0112156e6e3 by Martin Gräßlin to branch master.

- Commit Hook


On Feb. 7, 2014, 8:51 a.m., Martin Gräßlin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115531/
 ---
 
 (Updated Feb. 7, 2014, 8:51 a.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kwindowsystem
 
 
 Description
 ---
 
 Only build kx(utils|errorhandler).cpp if we HAVE_X11
 
 The name even says it's x specific...
 
 
 Diffs
 -
 
   src/CMakeLists.txt 9c1d4523d7f630c7df8aff4eff984d25b2116db9 
   src/kxerrorhandler.cpp 7bd9af3eb54cef697662e3bcf72a0e100f636706 
   src/kxutils.cpp d7b89024a4fc8d3cc48f5ddc9ca86ba159a4da5a 
 
 Diff: https://git.reviewboard.kde.org/r/115531/diff/
 
 
 Testing
 ---
 
 built with and without X11
 
 
 Thanks,
 
 Martin Gräßlin
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115531: Only build kx(utils|errorhandler).cpp if we HAVE_X11

2014-02-09 Thread Martin Gräßlin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115531/
---

(Updated Feb. 10, 2014, 6:56 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kwindowsystem


Description
---

Only build kx(utils|errorhandler).cpp if we HAVE_X11

The name even says it's x specific...


Diffs
-

  src/CMakeLists.txt 9c1d4523d7f630c7df8aff4eff984d25b2116db9 
  src/kxerrorhandler.cpp 7bd9af3eb54cef697662e3bcf72a0e100f636706 
  src/kxutils.cpp d7b89024a4fc8d3cc48f5ddc9ca86ba159a4da5a 

Diff: https://git.reviewboard.kde.org/r/115531/diff/


Testing
---

built with and without X11


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115527: Remove not needed HAVE_X11

2014-02-09 Thread Martin Gräßlin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115527/
---

(Updated Feb. 10, 2014, 6:59 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kio


Description
---

Remove not needed HAVE_X11

KWindowSystem::setState is not X11 specific. If a platform does not
support KeepAbove it just doesn't set it.


Diffs
-

  src/ioslaves/http/kcookiejar/kcookiewin.cpp 
8c3250af2d7f51866f1bce9046beaec7dadce84b 

Diff: https://git.reviewboard.kde.org/r/115527/diff/


Testing
---

compiles on X11, warning about not-defined HAVE_X11 gone


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115517: Do not crash if there is no QMimeData in decodeIsCutSelection

2014-02-09 Thread Martin Gräßlin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115517/
---

(Updated Feb. 10, 2014, 6:59 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Repository: kio


Description
---

Do not crash if there is no QMimeData in decodeIsCutSelection

On Wayland the QMimeData is null and thus the Open File dialog
crashed when trying to enter a directory.


Diffs
-

  src/filewidgets/kfilepreviewgenerator.cpp 
cdc18a18508eceb58b9fbcad9b68b47bf534996c 

Diff: https://git.reviewboard.kde.org/r/115517/diff/


Testing
---

Kate on Wayland can open files now: http://paste.opensuse.org/79557635


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115527: Remove not needed HAVE_X11

2014-02-09 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115527/#review49412
---


This review has been submitted with commit 
3daf0a4900aff9d16b749b40e8c5b3ab9efab60b by Martin Gräßlin to branch master.

- Commit Hook


On Feb. 7, 2014, 8:01 a.m., Martin Gräßlin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115527/
 ---
 
 (Updated Feb. 7, 2014, 8:01 a.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kio
 
 
 Description
 ---
 
 Remove not needed HAVE_X11
 
 KWindowSystem::setState is not X11 specific. If a platform does not
 support KeepAbove it just doesn't set it.
 
 
 Diffs
 -
 
   src/ioslaves/http/kcookiejar/kcookiewin.cpp 
 8c3250af2d7f51866f1bce9046beaec7dadce84b 
 
 Diff: https://git.reviewboard.kde.org/r/115527/diff/
 
 
 Testing
 ---
 
 compiles on X11, warning about not-defined HAVE_X11 gone
 
 
 Thanks,
 
 Martin Gräßlin
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115517: Do not crash if there is no QMimeData in decodeIsCutSelection

2014-02-09 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115517/#review49411
---


This review has been submitted with commit 
7ce81bd9a1bf95a5813f59c4c39a3aa482410af8 by Martin Gräßlin to branch master.

- Commit Hook


On Feb. 6, 2014, 1:37 p.m., Martin Gräßlin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115517/
 ---
 
 (Updated Feb. 6, 2014, 1:37 p.m.)
 
 
 Review request for KDE Frameworks and David Faure.
 
 
 Repository: kio
 
 
 Description
 ---
 
 Do not crash if there is no QMimeData in decodeIsCutSelection
 
 On Wayland the QMimeData is null and thus the Open File dialog
 crashed when trying to enter a directory.
 
 
 Diffs
 -
 
   src/filewidgets/kfilepreviewgenerator.cpp 
 cdc18a18508eceb58b9fbcad9b68b47bf534996c 
 
 Diff: https://git.reviewboard.kde.org/r/115517/diff/
 
 
 Testing
 ---
 
 Kate on Wayland can open files now: http://paste.opensuse.org/79557635
 
 
 Thanks,
 
 Martin Gräßlin
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 115613: Drop platform name from default user agent string

2014-02-09 Thread Martin Gräßlin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115613/
---

Review request for KDE Frameworks.


Repository: kio


Description
---

Drop platform name from default user agent string

The platform name (e.g. X11) was currently broken on compile time.
On Linux it returned unknown and on all other platforms the same
name as already included in the OS name.

We cannot really determine the platform name as this is a core
application and the Qt's platform name is only available in a GUI
application. Compile time is no solution as we cannot know whether
the binary is executed on X11, Wayland, Android or whatever.


Diffs
-

  src/core/kprotocolmanager.cpp f81b6797887eebd868c36b98e867eb055b05a1e2 

Diff: https://git.reviewboard.kde.org/r/115613/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel