Re: Review Request 115717: Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

[Martin Gräßlin]

> On Feb. 19, 2014, 3:07 p.m., Alex Merry wrote:
> > I don't think papering over the X11-ness of kdesu like this is the right 
> > approach.  Of course, what this framework really needs is a test app; maybe 
> > a simple port of the kdesu app from kde-runtime?
> 
> Kevin Ottens wrote:
> This kind of "papering over" can only be temporary indeed. Just wondering 
> if Martin has the possibility to clean that up better at that stage?
> 
> As for the test app: hell yes, definitely needed.
> 
> Martin Gräßlin wrote:
> well yes if there's a testapp and that works I can implement it properly. 
> But IIRC kdesu never worked on my setup (not having a password for root).
> 
> Kevin Ottens wrote:
> You can use it for other users than root you know. ;-)
> 
> Martin Gräßlin wrote:
> no, I didn't and which other users? ;-)
> 
> Kevin Ottens wrote:
> My point is that if you need to test it's trivial to add a temporary 
> user...
> 
> Kevin Ottens wrote:
> So what do we do of this patch? Any chance of a test app?

> Any chance of a test app?

I would prefer if the test app could be integrated by a domain expert. I do not 
really feel comfortable about it.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115717/#review50240
---


On Feb. 13, 2014, 10:41 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115717/
> ---
> 
> (Updated Feb. 13, 2014, 10:41 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdesu
> 
> 
> Description
> ---
> 
> Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set
> 
> If kdesu is compiled with X11 it required the DISPLAY variable to be
> set. This is no longer correct as it might have been compiled with
> X11 but is run on Wayland. Thus the code checks now also for
> WAYLAND_DISPLAY in the HAVE_X11 ifdef blocks. The Wayland support
> should become more complete, I do not know how it behaves if we compile
> without X11 support. Unfortunately there are no autotests and no test
> applications which one could use.
> 
> 
> Diffs
> -
> 
>   src/client.cpp 91bfd78fbca6e5d8d365d924c0260087e3937948 
>   src/kcookie.cpp 59448351696c503b34b7507e9c3fa8efc53139f9 
> 
> Diff: https://git.reviewboard.kde.org/r/115717/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116766: Use a desktop file we might find for testing KServiceActions

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116766/#review52874
---


It would have been better to just put a local copy of that desktop file into 
the kservice autotests subdir, so that it's always available to run the test on.
Now we depend on konsolerun.desktop which might change in the future, etc.
And this way we can add stuff to the desktop file to test more "Actions" 
features in the future.

- David Faure


On March 12, 2014, 3:47 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116766/
> ---
> 
> (Updated March 12, 2014, 3:47 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> Use a desktop file we might find for testing KServiceActions
> 
> The screensaver stuff isn't ported to frameworks 5 yet, so looking for
> those desktop files won't work.  This uses something that might actually
> be installed instead.
> 
> 
> Diffs
> -
> 
>   autotests/kservicetest.h aa1c691c75c9e5b6903bcbf6e2dc95809ee1ce21 
>   autotests/kservicetest.cpp 711fb9b649e580ad474b0cdecd26dcdbfdc302a2 
> 
> Diff: https://git.reviewboard.kde.org/r/116766/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116747: Clean up KCompletionBox

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116747/#review52881
---



src/kcompletionbox.cpp


Is this comment definitely no longer relevant?  It looks like it refers to 
the sendPostedEvents() call that's still there.


- Alex Merry


On March 12, 2014, 10:57 p.m., David Gil Oliva wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116747/
> ---
> 
> (Updated March 12, 2014, 10:57 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> ---
> 
> Clean up KCompletionBox
> 
> -canceled() -> cancelled (private method)
> -Deprecate sizeAndPosition() --> resizeAndReposition()
> -Remove old comments and commented-out code
> -Move some slots to be normal methods, since they don't seem to be able to
> work as slots.
> 
> 
> Diffs
> -
> 
>   src/kcompletionbox.h 09b7527 
>   src/kcompletionbox.cpp 92e87b3 
> 
> Diff: https://git.reviewboard.kde.org/r/116747/diff/
> 
> 
> Testing
> ---
> 
> It builds and tests pass.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116766: Use a desktop file we might find for testing KServiceActions

[Alex Merry]

> On March 13, 2014, 8:41 a.m., David Faure wrote:
> > It would have been better to just put a local copy of that desktop file 
> > into the kservice autotests subdir, so that it's always available to run 
> > the test on.
> > Now we depend on konsolerun.desktop which might change in the future, etc.
> > And this way we can add stuff to the desktop file to test more "Actions" 
> > features in the future.

Yeah, I vaguely intended to move to that in the future; I mostly made this 
change so I could check that some other changes *really* didn't break any 
tests.  But I'll look at doing that change up front.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116766/#review52874
---


On March 12, 2014, 3:47 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116766/
> ---
> 
> (Updated March 12, 2014, 3:47 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> Use a desktop file we might find for testing KServiceActions
> 
> The screensaver stuff isn't ported to frameworks 5 yet, so looking for
> those desktop files won't work.  This uses something that might actually
> be installed instead.
> 
> 
> Diffs
> -
> 
>   autotests/kservicetest.h aa1c691c75c9e5b6903bcbf6e2dc95809ee1ce21 
>   autotests/kservicetest.cpp 711fb9b649e580ad474b0cdecd26dcdbfdc302a2 
> 
> Diff: https://git.reviewboard.kde.org/r/116766/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116766: Use a desktop file we might find for testing KServiceActions

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116766/
---

(Updated March 13, 2014, 11:27 a.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks and David Faure.


Repository: kservice


Description
---

Use a desktop file we might find for testing KServiceActions

The screensaver stuff isn't ported to frameworks 5 yet, so looking for
those desktop files won't work.  This uses something that might actually
be installed instead.


Diffs
-

  autotests/kservicetest.h aa1c691c75c9e5b6903bcbf6e2dc95809ee1ce21 
  autotests/kservicetest.cpp 711fb9b649e580ad474b0cdecd26dcdbfdc302a2 

Diff: https://git.reviewboard.kde.org/r/116766/diff/


Testing
---


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 116781: List catalog from all install dirs

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116781/
---

Review request for Documentation, KDE Frameworks and Luigi Toscano.


Repository: kdoctools


Description
---

This makes sure that if XDG_DATA_DIRS contains kde4support install prefix and 
then kdoctools install prefix, then kdoctools catalogs are listed nevertheless.

Should fix build of kde-workspace and kate on build.kde.org.


Diffs
-

  src/xslt.cpp 6d5819e 

Diff: https://git.reviewboard.kde.org/r/116781/diff/


Testing
---

Rebuilt kde-runtime (was failing there), kate and kde-workspace. No build 
failures.


Thanks,

Aurélien Gâteau

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116781: List catalog from all install dirs

[Luigi Toscano]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116781/#review52886
---

Ship it!


Thank you; I can't test now but it looks sane; as a suggestion, I would 
explicitly mention that this is for "environments where each module is 
installed using a different prefix" as I wrote in the related commit (for 
https://git.reviewboard.kde.org/r/116670/).

- Luigi Toscano


On March 13, 2014, 12:59 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116781/
> ---
> 
> (Updated March 13, 2014, 12:59 p.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> This makes sure that if XDG_DATA_DIRS contains kde4support install prefix and 
> then kdoctools install prefix, then kdoctools catalogs are listed 
> nevertheless.
> 
> Should fix build of kde-workspace and kate on build.kde.org.
> 
> 
> Diffs
> -
> 
>   src/xslt.cpp 6d5819e 
> 
> Diff: https://git.reviewboard.kde.org/r/116781/diff/
> 
> 
> Testing
> ---
> 
> Rebuilt kde-runtime (was failing there), kate and kde-workspace. No build 
> failures.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116781: List catalog from all install dirs

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116781/
---

(Updated March 13, 2014, 1:47 p.m.)


Review request for Documentation, KDE Frameworks and Luigi Toscano.


Changes
---

Improve comment.


Repository: kdoctools


Description
---

This makes sure that if XDG_DATA_DIRS contains kde4support install prefix and 
then kdoctools install prefix, then kdoctools catalogs are listed nevertheless.

Should fix build of kde-workspace and kate on build.kde.org.


Diffs (updated)
-

  src/xslt.cpp 6d5819e 

Diff: https://git.reviewboard.kde.org/r/116781/diff/


Testing
---

Rebuilt kde-runtime (was failing there), kate and kde-workspace. No build 
failures.


Thanks,

Aurélien Gâteau

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116781: List catalog from all install dirs

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116781/#review52890
---


This review has been submitted with commit 
02478b34df416862c50da8186742491bd29012e8 by Aurélien Gâteau to branch master.

- Commit Hook


On March 13, 2014, 12:47 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116781/
> ---
> 
> (Updated March 13, 2014, 12:47 p.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> This makes sure that if XDG_DATA_DIRS contains kde4support install prefix and 
> then kdoctools install prefix, then kdoctools catalogs are listed 
> nevertheless.
> 
> Should fix build of kde-workspace and kate on build.kde.org.
> 
> 
> Diffs
> -
> 
>   src/xslt.cpp 6d5819e 
> 
> Diff: https://git.reviewboard.kde.org/r/116781/diff/
> 
> 
> Testing
> ---
> 
> Rebuilt kde-runtime (was failing there), kate and kde-workspace. No build 
> failures.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116781: List catalog from all install dirs

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116781/
---

(Updated March 13, 2014, 1:01 p.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation, KDE Frameworks and Luigi Toscano.


Repository: kdoctools


Description
---

This makes sure that if XDG_DATA_DIRS contains kde4support install prefix and 
then kdoctools install prefix, then kdoctools catalogs are listed nevertheless.

Should fix build of kde-workspace and kate on build.kde.org.


Diffs
-

  src/xslt.cpp 6d5819e 

Diff: https://git.reviewboard.kde.org/r/116781/diff/


Testing
---

Rebuilt kde-runtime (was failing there), kate and kde-workspace. No build 
failures.


Thanks,

Aurélien Gâteau

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdoctools_master_qt5 #38

[KDE CI System]

See 

Changes:

[agateau] List catalog from all install dirs

--
Started by remote host 127.0.0.1 with note: Triggered by commit
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[kdoctools_master_qt5] $ /bin/sh -xe /tmp/hudson6887938633212081990.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

>From git://anongit.kde.org/kdoctools
   5c6ada2..02478b3  master -> origin/master
 * [new tag] v4.97.0-> v4.97.0
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at 5c6ada2 Fix installing on Windows
Removing build/
Removing dotdata/
Removing install/
Success build forhudson.tasks.Shell@3a256540
Fetching changes from the remote Git repository
Fetching upstream changes from git://anongit.kde.org/kdoctools
Checking out Revision 02478b34df416862c50da8186742491bd29012e8 
(refs/heads/jenkins)
Run condition [File exists] enabling prebuild for step [Publish JUnit test 
result report]
Run condition [File exists] enabling prebuild for step [Publish Cppcheck 
results]
[kdoctools_master_qt5] $ /bin/sh -xe /tmp/hudson2416363039616394716.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: kdoctools - Branch master
== Build Dependencies:
 cmake - Branch master
 qt5 - Branch stable
 karchive - Branch master
 extra-cmake-modules - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.7.2
-- The CXX compiler identification is GNU 4.7.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Found LibXslt: /usr/lib64/libxslt.so (found version "1.1.28") 
-- Found LibXml2: /usr/lib64/libxml2.so (found version "2.9.0") 
-- Found DocBookXML4: /usr/share/xml/docbook/schema/dtd/4.5 (Required is at 
least version "4.5") 
-- Found DocBookXSL: /usr/share/xml/docbook/stylesheet/nwalsh/current  
-- Looking for include file stdio.h
-- Looking for include file stdio.h - found
-- Looking for include file stdlib.h
-- Looking for include file stdlib.h - found
-- Looking for include file sys/types.h
-- Looking for include file sys/types.h - found
-- Looking for include file sys/stat.h
-- Looking for include file sys/stat.h - found
-- 
-- The following REQUIRED packages have been found:

 * ECM (required version >= 0.0.11)
 * Qt5Core (required version >= 5.2.0)
 * KF5Archive
 * LibXslt , 
   Required by the KDE help system to process DocBook XML
 * LibXml2 , 
   Required by the KDE help system to process DocBook XML
 * DocBookXML4 (required version >= 4.5) , DocBook XML 4 , 

   Required by the KDE help system to process DocBook XML
 * DocBookXSL , DocBook XSL , 

   Required by the KDE help system to process DocBook XML

-- Configuring done
-- Generating done
CMake Warning:
  Manually-specified variables were not used by the project:

KDE4_BUILD_TESTS
LIB_SUFFIX
SIP_DEFAULT_SIP_DIR


-- Build files have been written to: 


== Commencing the Build

Scanning dependencies of target docbookl10nhelper_automoc
Scanning dependencies of target meinproc5_automoc
Scanning dependencies of target KF5XsltKde_automoc
[  5%] [ 11%] [ 17%] Automatic moc for target docbookl10nhelper
Automatic moc for target KF5XsltKde
Automatic moc for target meinproc5
[ 17%] Built target docbookl10nhelper_automoc
[ 17%] [ 17%] Built target meinproc5_automoc
Built target KF5XsltKde_automoc
Scanning dependencies of target docbookl10nhelper
[ 29%] [ 29%] Building CXX object 
src/CMakeFiles/docbookl10nhelper.dir/docbookl10nhelper_automoc.cpp.o
Building CXX object src/CMakeFiles/docbookl10nhelper.dir/docbookl10nhelper.cpp.o
Scanning dependencies of target KF5XsltKde
[ 35%] Scanning dependencies of target meinproc5
[ 41%] Building CXX object src/CMakeFiles/KF5XsltKde.dir/xslt.cpp.o
[ 47%] Building CXX object 
src/CMakeFiles/KF5XsltKde.dir/KF5XsltKde_automoc.cpp.o
[ 52%] Building CXX object src/CMakeFiles/KF5XsltKde.dir/xslt_kde.cpp.o
[ 58%] [ 64%] Building CXX object 
src/CMakeFiles/meinproc5.dir/meinproc_common.cpp.o
Building CXX object src/CMakeFiles/meinproc5.dir/xslt.cpp.o
Building CXX object src/CMakeFiles/meinproc5.dir/meinproc.cpp.o
[ 70%] [ 76%]

Review Request 116785: Unbreak bootstrapping

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116785/
---

Review request for Documentation, KDE Frameworks and Luigi Toscano.


Repository: kdoctools


Description
---

We still need to be able to load catalog files from source dir when building 
kdoctools itself, so generalize code from locateFileInDtdResource() instead of 
doing our own.


Diffs
-

  src/xslt.h 83d48b3 
  src/xslt.cpp 0954720 

Diff: https://git.reviewboard.kde.org/r/116785/diff/


Testing
---

Rebuilt kdoctools in a clean environment, as well as the rest of the frameworks.


Thanks,

Aurélien Gâteau

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116785: Unbreak bootstrapping

[Luigi Toscano]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116785/#review52892
---

Ship it!


Discussed on IRC

- Luigi Toscano


On March 13, 2014, 2:50 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116785/
> ---
> 
> (Updated March 13, 2014, 2:50 p.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> We still need to be able to load catalog files from source dir when building 
> kdoctools itself, so generalize code from locateFileInDtdResource() instead 
> of doing our own.
> 
> 
> Diffs
> -
> 
>   src/xslt.h 83d48b3 
>   src/xslt.cpp 0954720 
> 
> Diff: https://git.reviewboard.kde.org/r/116785/diff/
> 
> 
> Testing
> ---
> 
> Rebuilt kdoctools in a clean environment, as well as the rest of the 
> frameworks.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116785: Unbreak bootstrapping

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116785/#review52893
---


This review has been submitted with commit 
4ba9dc99782de21d9fcc89910847a4a1d98889f9 by Aurélien Gâteau to branch master.

- Commit Hook


On March 13, 2014, 1:50 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116785/
> ---
> 
> (Updated March 13, 2014, 1:50 p.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> We still need to be able to load catalog files from source dir when building 
> kdoctools itself, so generalize code from locateFileInDtdResource() instead 
> of doing our own.
> 
> 
> Diffs
> -
> 
>   src/xslt.h 83d48b3 
>   src/xslt.cpp 0954720 
> 
> Diff: https://git.reviewboard.kde.org/r/116785/diff/
> 
> 
> Testing
> ---
> 
> Rebuilt kdoctools in a clean environment, as well as the rest of the 
> frameworks.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kdoctools_master_qt5 #39

[KDE CI System]

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116785: Unbreak bootstrapping

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116785/
---

(Updated March 13, 2014, 2:09 p.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation, KDE Frameworks and Luigi Toscano.


Repository: kdoctools


Description
---

We still need to be able to load catalog files from source dir when building 
kdoctools itself, so generalize code from locateFileInDtdResource() instead of 
doing our own.


Diffs
-

  src/xslt.h 83d48b3 
  src/xslt.cpp 0954720 

Diff: https://git.reviewboard.kde.org/r/116785/diff/


Testing
---

Rebuilt kdoctools in a clean environment, as well as the rest of the frameworks.


Thanks,

Aurélien Gâteau

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116760: Remove kcookiescfg update scripts

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116760/
---

(Updated March 13, 2014, 2:49 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks and David Faure.


Repository: kio


Description
---

Am I right about this?


Remove kcookiescfg update scripts

kf5 stores configuration in different locations to kde4, so there should
be nothing to update.


Diffs
-

  src/ioslaves/http/kcookiejar/CMakeLists.txt 
2bb4cc232b7011d38033da10bb312a12215cb29d 
  src/ioslaves/http/kcookiejar/kcookiescfg.pl 
7fef01d5c208a00987b3594411ce06799457 
  src/ioslaves/http/kcookiejar/kcookiescfg.upd 
745f545090875d5d24e1e6bb397af9926704350f 

Diff: https://git.reviewboard.kde.org/r/116760/diff/


Testing
---


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116760: Remove kcookiescfg update scripts

[Alex Merry]

> On March 12, 2014, 5:39 p.m., David Faure wrote:
> > well I'm still hoping some sort of migration of the useful config data will 
> > happen

OK, I'll leave this for now, then.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116760/#review52831
---


On March 12, 2014, 3:44 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116760/
> ---
> 
> (Updated March 12, 2014, 3:44 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Am I right about this?
> 
> 
> Remove kcookiescfg update scripts
> 
> kf5 stores configuration in different locations to kde4, so there should
> be nothing to update.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/kcookiejar/CMakeLists.txt 
> 2bb4cc232b7011d38033da10bb312a12215cb29d 
>   src/ioslaves/http/kcookiejar/kcookiescfg.pl 
> 7fef01d5c208a00987b3594411ce06799457 
>   src/ioslaves/http/kcookiejar/kcookiescfg.upd 
> 745f545090875d5d24e1e6bb397af9926704350f 
> 
> Diff: https://git.reviewboard.kde.org/r/116760/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 116786: Make error handling more consistent and fail earlier

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116786/
---

Review request for Documentation, KDE Frameworks and Luigi Toscano.


Repository: kdoctools


Description
---

This should makes it easier to interpret future failures, for example by not 
running xmllint if catalogs are missing.


Diffs
-

  src/meinproc.cpp 22150ab 

Diff: https://git.reviewboard.kde.org/r/116786/diff/


Testing
---

Clean-rebuilt all frameworks which depends on kdoctools, plus kde-runtime, 
kde-workspace, konsole, kate.


Thanks,

Aurélien Gâteau

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

[Aaron J. Seigo]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116787/
---

Review request for KDE Frameworks, kwin and Martin Gräßlin.


Repository: kwindowsystem


Description
---

When using KWindowInfo from a thread other than the main application thread, 
the application fails on an assert triggered by creating a QWidget in another 
thread. This is due to NETEventFilter being a QWidget. This patch addresses the 
issue by using a QObject to create the NETEventFilter, which is itself first 
moved to the main application thread. 


Diffs
-

  src/kwindowsystem_p_x11.h 75f3028 
  src/kwindowsystem_x11.cpp 95c396b 

Diff: https://git.reviewboard.kde.org/r/116787/diff/


Testing
---

Used in the Sprinter Windows plugin and works lovely to find desktops, windows, 
etc.


Thanks,

Aaron J. Seigo

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

[Matthew Dawson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116689/#review52902
---


Looks good, just a few items below:


src/core/kconfigini.cpp


Is there a reason for these extra debug statements?



src/core/kcoreconfigskeleton.cpp


Similarly, does this need to be uncommented now?



src/core/kcoreconfigskeleton.cpp


Also, can you change the documentation for KCoreConfigSkeleton to reflect 
this change?  Specifically, for the configname parameter, can you change it 
something like:
name of config file. If no name is given, the default from 
KSharedConfig::openConfig() is used


- Matthew Dawson


On March 10, 2014, 4:36 a.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116689/
> ---
> 
> (Updated March 10, 2014, 4:36 a.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> KCoreConfigSkeleton: delay parsing until the call to readConfig()
> 
> 
> Diffs
> -
> 
>   src/core/kconfig.h d27eebe7c41cb433b1808882c53cbf7b4c870950 
>   src/core/kconfig.cpp 5b51cce8c62c2c4de91baddcd3fb2893b842326d 
>   src/core/kconfigini.cpp df834f57fc44bbf9f4f28f1bc4eb5717e2ff1cee 
>   src/core/kcoreconfigskeleton.cpp 9c5fb4a80d500e81b483b749a137ad5f2c99a55f 
> 
> Diff: https://git.reviewboard.kde.org/r/116689/diff/
> 
> 
> Testing
> ---
> 
> strace -e open kate |& grep -v NOENT | grep oxygenrc
>  goes from 4 to 3
> (still three because the same KSharedConfig is used in 3 skeletons -> 3 * 
> readConfig calling reparseConfiguration)
> 
> To go further down we could add a flag to readConfig()
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

[David Faure]

> On March 13, 2014, 7:54 p.m., Matthew Dawson wrote:
> > src/core/kconfigini.cpp, lines 86-89
> > 
> >
> > Is there a reason for these extra debug statements?

Argh, that stupid post-review script+alias always grabs local uncommitted 
changes while I only want to push the last commit. Let me try to fix that


> On March 13, 2014, 7:54 p.m., Matthew Dawson wrote:
> > src/core/kcoreconfigskeleton.cpp, line 990
> > 
> >
> > Also, can you change the documentation for KCoreConfigSkeleton to 
> > reflect this change?  Specifically, for the configname parameter, can you 
> > change it something like:
> > name of config file. If no name is given, the default from 
> > KSharedConfig::openConfig() is used

I don't understand, the documentation already says that.
Do you mean mentionning DelayedParsing in the documentation?
It's kind of an internal detail though.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116689/#review52902
---


On March 10, 2014, 8:36 a.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116689/
> ---
> 
> (Updated March 10, 2014, 8:36 a.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> KCoreConfigSkeleton: delay parsing until the call to readConfig()
> 
> 
> Diffs
> -
> 
>   src/core/kconfig.h d27eebe7c41cb433b1808882c53cbf7b4c870950 
>   src/core/kconfig.cpp 5b51cce8c62c2c4de91baddcd3fb2893b842326d 
>   src/core/kconfigini.cpp df834f57fc44bbf9f4f28f1bc4eb5717e2ff1cee 
>   src/core/kcoreconfigskeleton.cpp 9c5fb4a80d500e81b483b749a137ad5f2c99a55f 
> 
> Diff: https://git.reviewboard.kde.org/r/116689/diff/
> 
> 
> Testing
> ---
> 
> strace -e open kate |& grep -v NOENT | grep oxygenrc
>  goes from 4 to 3
> (still three because the same KSharedConfig is used in 3 skeletons -> 3 * 
> readConfig calling reparseConfiguration)
> 
> To go further down we could add a flag to readConfig()
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116689/
---

(Updated March 13, 2014, 8:06 p.m.)


Review request for KDE Frameworks and Matthew Dawson.


Changes
---

Ah! Fixed my post-review git alias using
--revision-range=HEAD~:HEAD


Repository: kconfig


Description
---

KCoreConfigSkeleton: delay parsing until the call to readConfig()


Diffs (updated)
-

  src/core/kconfig.h d27eebe7c41cb433b1808882c53cbf7b4c870950 
  src/core/kconfig.cpp 5b51cce8c62c2c4de91baddcd3fb2893b842326d 
  src/core/kcoreconfigskeleton.cpp 9c5fb4a80d500e81b483b749a137ad5f2c99a55f 

Diff: https://git.reviewboard.kde.org/r/116689/diff/


Testing
---

strace -e open kate |& grep -v NOENT | grep oxygenrc
 goes from 4 to 3
(still three because the same KSharedConfig is used in 3 skeletons -> 3 * 
readConfig calling reparseConfiguration)

To go further down we could add a flag to readConfig()


Thanks,

David Faure

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116786: Make error handling more consistent and fail earlier

[Luigi Toscano]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116786/#review52907
---



src/meinproc.cpp


Please save the value of tss before the call, otherwise it will be always 
empty


- Luigi Toscano


On March 13, 2014, 5:39 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116786/
> ---
> 
> (Updated March 13, 2014, 5:39 p.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> This should makes it easier to interpret future failures, for example by not 
> running xmllint if catalogs are missing.
> 
> 
> Diffs
> -
> 
>   src/meinproc.cpp 22150ab 
> 
> Diff: https://git.reviewboard.kde.org/r/116786/diff/
> 
> 
> Testing
> ---
> 
> Clean-rebuilt all frameworks which depends on kdoctools, plus kde-runtime, 
> kde-workspace, konsole, kate.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

[Matthew Dawson]

> On March 13, 2014, 3:54 p.m., Matthew Dawson wrote:
> > src/core/kcoreconfigskeleton.cpp, line 990
> > 
> >
> > Also, can you change the documentation for KCoreConfigSkeleton to 
> > reflect this change?  Specifically, for the configname parameter, can you 
> > change it something like:
> > name of config file. If no name is given, the default from 
> > KSharedConfig::openConfig() is used
> 
> David Faure wrote:
> I don't understand, the documentation already says that.
> Do you mean mentionning DelayedParsing in the documentation?
> It's kind of an internal detail though.

It does basically say that.  The current text is:
name of config file. If no name is given, the default config file as returned 
by KSharedConfig::openConfig() is used

I just worry the wording may have people assume we don't change any other 
parameters, though it could just be me looking to closely at this issue.  If 
you think the current version is more clear, then the patch can go in as is.  
If you have a third option, I'm happy for to hear it, otherwise I'd prefer the 
updated version.


- Matthew


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116689/#review52902
---


On March 13, 2014, 4:06 p.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116689/
> ---
> 
> (Updated March 13, 2014, 4:06 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> KCoreConfigSkeleton: delay parsing until the call to readConfig()
> 
> 
> Diffs
> -
> 
>   src/core/kconfig.h d27eebe7c41cb433b1808882c53cbf7b4c870950 
>   src/core/kconfig.cpp 5b51cce8c62c2c4de91baddcd3fb2893b842326d 
>   src/core/kcoreconfigskeleton.cpp 9c5fb4a80d500e81b483b749a137ad5f2c99a55f 
> 
> Diff: https://git.reviewboard.kde.org/r/116689/diff/
> 
> 
> Testing
> ---
> 
> strace -e open kate |& grep -v NOENT | grep oxygenrc
>  goes from 4 to 3
> (still three because the same KSharedConfig is used in 3 skeletons -> 3 * 
> readConfig calling reparseConfiguration)
> 
> To go further down we could add a flag to readConfig()
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

[David Faure]

> On March 13, 2014, 7:54 p.m., Matthew Dawson wrote:
> > src/core/kcoreconfigskeleton.cpp, line 990
> > 
> >
> > Also, can you change the documentation for KCoreConfigSkeleton to 
> > reflect this change?  Specifically, for the configname parameter, can you 
> > change it something like:
> > name of config file. If no name is given, the default from 
> > KSharedConfig::openConfig() is used
> 
> David Faure wrote:
> I don't understand, the documentation already says that.
> Do you mean mentionning DelayedParsing in the documentation?
> It's kind of an internal detail though.
> 
> Matthew Dawson wrote:
> It does basically say that.  The current text is:
> name of config file. If no name is given, the default config file as 
> returned by KSharedConfig::openConfig() is used
> 
> I just worry the wording may have people assume we don't change any other 
> parameters, though it could just be me looking to closely at this issue.  If 
> you think the current version is more clear, then the patch can go in as is.  
> If you have a third option, I'm happy for to hear it, otherwise I'd prefer 
> the updated version.

I cannot see a meaningful difference between "the default config file as 
returned by openConfig()" and "the default from openConfig()" ?
I kind of doubt anyone reading the docs would really see a difference there.
In fact the first one is arguably more correct, since we use the default config 
file but not with the default flags...


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116689/#review52902
---


On March 13, 2014, 8:06 p.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116689/
> ---
> 
> (Updated March 13, 2014, 8:06 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> KCoreConfigSkeleton: delay parsing until the call to readConfig()
> 
> 
> Diffs
> -
> 
>   src/core/kconfig.h d27eebe7c41cb433b1808882c53cbf7b4c870950 
>   src/core/kconfig.cpp 5b51cce8c62c2c4de91baddcd3fb2893b842326d 
>   src/core/kcoreconfigskeleton.cpp 9c5fb4a80d500e81b483b749a137ad5f2c99a55f 
> 
> Diff: https://git.reviewboard.kde.org/r/116689/diff/
> 
> 
> Testing
> ---
> 
> strace -e open kate |& grep -v NOENT | grep oxygenrc
>  goes from 4 to 3
> (still three because the same KSharedConfig is used in 3 skeletons -> 3 * 
> readConfig calling reparseConfiguration)
> 
> To go further down we could add a flag to readConfig()
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116747: Clean up KCompletionBox

[David Gil Oliva]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116747/
---

(Updated March 13, 2014, 10:13 p.m.)


Review request for KDE Frameworks.


Changes
---

Restore and rephrase comment in kcompletionbox.cpp, following suggestion of 
Alex Merry.


Repository: kcompletion


Description
---

Clean up KCompletionBox

-canceled() -> cancelled (private method)
-Deprecate sizeAndPosition() --> resizeAndReposition()
-Remove old comments and commented-out code
-Move some slots to be normal methods, since they don't seem to be able to
work as slots.


Diffs (updated)
-

  src/kcompletionbox.h 09b7527 
  src/kcompletionbox.cpp 92e87b3 

Diff: https://git.reviewboard.kde.org/r/116747/diff/


Testing
---

It builds and tests pass.


Thanks,

David Gil Oliva

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

[Matthew Dawson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116689/#review52913
---

Ship it!


Ship It!

- Matthew Dawson


On March 13, 2014, 4:06 p.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116689/
> ---
> 
> (Updated March 13, 2014, 4:06 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> KCoreConfigSkeleton: delay parsing until the call to readConfig()
> 
> 
> Diffs
> -
> 
>   src/core/kconfig.h d27eebe7c41cb433b1808882c53cbf7b4c870950 
>   src/core/kconfig.cpp 5b51cce8c62c2c4de91baddcd3fb2893b842326d 
>   src/core/kcoreconfigskeleton.cpp 9c5fb4a80d500e81b483b749a137ad5f2c99a55f 
> 
> Diff: https://git.reviewboard.kde.org/r/116689/diff/
> 
> 
> Testing
> ---
> 
> strace -e open kate |& grep -v NOENT | grep oxygenrc
>  goes from 4 to 3
> (still three because the same KSharedConfig is used in 3 skeletons -> 3 * 
> readConfig calling reparseConfiguration)
> 
> To go further down we could add a flag to readConfig()
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

[Matthew Dawson]

> On March 13, 2014, 3:54 p.m., Matthew Dawson wrote:
> > src/core/kcoreconfigskeleton.cpp, line 990
> > 
> >
> > Also, can you change the documentation for KCoreConfigSkeleton to 
> > reflect this change?  Specifically, for the configname parameter, can you 
> > change it something like:
> > name of config file. If no name is given, the default from 
> > KSharedConfig::openConfig() is used
> 
> David Faure wrote:
> I don't understand, the documentation already says that.
> Do you mean mentionning DelayedParsing in the documentation?
> It's kind of an internal detail though.
> 
> Matthew Dawson wrote:
> It does basically say that.  The current text is:
> name of config file. If no name is given, the default config file as 
> returned by KSharedConfig::openConfig() is used
> 
> I just worry the wording may have people assume we don't change any other 
> parameters, though it could just be me looking to closely at this issue.  If 
> you think the current version is more clear, then the patch can go in as is.  
> If you have a third option, I'm happy for to hear it, otherwise I'd prefer 
> the updated version.
> 
> David Faure wrote:
> I cannot see a meaningful difference between "the default config file as 
> returned by openConfig()" and "the default from openConfig()" ?
> I kind of doubt anyone reading the docs would really see a difference 
> there.
> In fact the first one is arguably more correct, since we use the default 
> config file but not with the default flags...
>

Yes, on second thought I think you are right, the first one is best.


- Matthew


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116689/#review52902
---


On March 13, 2014, 4:06 p.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116689/
> ---
> 
> (Updated March 13, 2014, 4:06 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> KCoreConfigSkeleton: delay parsing until the call to readConfig()
> 
> 
> Diffs
> -
> 
>   src/core/kconfig.h d27eebe7c41cb433b1808882c53cbf7b4c870950 
>   src/core/kconfig.cpp 5b51cce8c62c2c4de91baddcd3fb2893b842326d 
>   src/core/kcoreconfigskeleton.cpp 9c5fb4a80d500e81b483b749a137ad5f2c99a55f 
> 
> Diff: https://git.reviewboard.kde.org/r/116689/diff/
> 
> 
> Testing
> ---
> 
> strace -e open kate |& grep -v NOENT | grep oxygenrc
>  goes from 4 to 3
> (still three because the same KSharedConfig is used in 3 skeletons -> 3 * 
> readConfig calling reparseConfiguration)
> 
> To go further down we could add a flag to readConfig()
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116787/#review52914
---


did you try to make it not use QWidget anymore? There shouldn't be a reason why 
it is QWidget.

- Martin Gräßlin


On March 13, 2014, 7:44 p.m., Aaron J. Seigo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116787/
> ---
> 
> (Updated March 13, 2014, 7:44 p.m.)
> 
> 
> Review request for KDE Frameworks, kwin and Martin Gräßlin.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> When using KWindowInfo from a thread other than the main application thread, 
> the application fails on an assert triggered by creating a QWidget in another 
> thread. This is due to NETEventFilter being a QWidget. This patch addresses 
> the issue by using a QObject to create the NETEventFilter, which is itself 
> first moved to the main application thread. 
> 
> 
> Diffs
> -
> 
>   src/kwindowsystem_p_x11.h 75f3028 
>   src/kwindowsystem_x11.cpp 95c396b 
> 
> Diff: https://git.reviewboard.kde.org/r/116787/diff/
> 
> 
> Testing
> ---
> 
> Used in the Sprinter Windows plugin and works lovely to find desktops, 
> windows, etc.
> 
> 
> Thanks,
> 
> Aaron J. Seigo
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

[Thomas Lübking]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116787/#review52915
---


You'll need a drawable, clients will require XInitThreads if that is accessed 
from a different than the GUI thread, but it might be possible to use an 
internal Window and move the QObject to the GUI thread on construction.


src/kwindowsystem_x11.cpp


QWidget::winId()



src/kwindowsystem_x11.cpp


QWidget::winId()


- Thomas Lübking


On March 13, 2014, 6:44 p.m., Aaron J. Seigo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116787/
> ---
> 
> (Updated March 13, 2014, 6:44 p.m.)
> 
> 
> Review request for KDE Frameworks, kwin and Martin Gräßlin.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> When using KWindowInfo from a thread other than the main application thread, 
> the application fails on an assert triggered by creating a QWidget in another 
> thread. This is due to NETEventFilter being a QWidget. This patch addresses 
> the issue by using a QObject to create the NETEventFilter, which is itself 
> first moved to the main application thread. 
> 
> 
> Diffs
> -
> 
>   src/kwindowsystem_p_x11.h 75f3028 
>   src/kwindowsystem_x11.cpp 95c396b 
> 
> Diff: https://git.reviewboard.kde.org/r/116787/diff/
> 
> 
> Testing
> ---
> 
> Used in the Sprinter Windows plugin and works lovely to find desktops, 
> windows, etc.
> 
> 
> Thanks,
> 
> Aaron J. Seigo
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 116792: Fix deprecation warning in KComboBox and fix all KDE_NO_DEPRECATED

[David Gil Oliva]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116792/
---

Review request for KDE Frameworks.


Repository: kcompletion


Description
---

Fix deprecation warning in KComboBox and fix all KDE_NO_DEPRECATED

There are other warnings related to the deprecated 
KComboBox::setUrlDropsEnabled, which calls KLineEdit::setUrlDropsEnabled (also 
deprecated). I tried to solve it by copying the KLineEdit::setUrlDropsEnabled 
contents into KComboBox::setUrlDropsEnabled, but it contains private variables 
which it cannot see. Any hint??


Diffs
-

  autotests/klineedit_unittest.cpp b84e126 
  src/kcombobox.h 32dc3e9 
  src/kcombobox.cpp 7195b3e 
  src/kcompletion.h 387a05e 
  src/klineedit.h c7c46b5 
  src/klineedit.cpp ae15093 

Diff: https://git.reviewboard.kde.org/r/116792/diff/


Testing
---

It builds and tests pass.


Thanks,

David Gil Oliva

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel