Re: Review Request 117560: ECMCreateQmFromPoFiles: adjust API to make it usable from within trunk/l10n-kf5

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117560/
---

(Updated April 16, 2014, 8:28 a.m.)


Status
--

This change has been marked as submitted.


Review request for Build System, Extra Cmake Modules and KDE Frameworks.


Repository: extra-cmake-modules


Description
---

Translators (are going to) translate KF5 in trunk/l10n-kf5 ( 
http://websvn.kde.org/trunk/l10n-kf5/ ). It is necessary to support their 
work-flow, which consists of:
1) build the code from git
2) builds and installs all translations from one language

The patch makes several changes to ECMCreateQmFromPoFiles to support this 
work-flow:

- It splits the code into two functions: one to create the .qm and install 
them, another to build the .qm loader. This way the loader can be generated 
even if no translations are available.

- It changes the syntax of ecm_create_qm_from_po_files() to accept po files 
instead of a po directory. This is needed because within the same language 
directory some .po are going to be turned into .qm while others are turned into 
.mo.

- It creates "translation-N" targets (like CMake gettext code does) to support 
multiple calls within one cmake project.

- It installs to share/locale//LC_MESSAGES (like gettext), because 
l10n-kf5 build system cannot know where the framework would decide to keep its 
.qm file, so it's simpler to use a standard place.

This potentially breaks existing framework builds, but only for developers who 
created manually po/ directories in their work tree (almost nobody, I expect), 
so I think it can be pushed as is. I already have the code ready to fix 
existing frameworks.

Those changes still support shipping translations within frameworks tarballs. 
Assuming this patch gets in, the build system of each framework is going to be 
patched like this:

-
diff --git a/CMakeLists.txt b/CMakeLists.txt
index b5e445c..c9a706c 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -16,6 +16,8 @@ include(GenerateExportHeader)
 include(ECMSetupVersion)
 include(ECMGenerateHeaders)
 
+include(ECMCreateQmFromPoFiles)
+
 set(KF5_VERSION "4.98.0")
 
 ecm_setup_version(${KF5_VERSION}
@@ -37,14 +39,9 @@ if ("${CMAKE_BINARY_DIR}" STREQUAL 
"${CMAKE_CURRENT_BINARY_DIR}")
   find_package(KF5XmlGui ${KF5_VERSION} REQUIRED)
 endif()
 
-if (EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/po)
-  include(ECMCreateQmFromPoFiles)
-  ecm_create_qm_from_po_files(
-PO_DIR po
-POT_NAME kbookmarks5.pot
-DATA_INSTALL_SUB_DIR kbookmarks
-CREATE_LOADER kbookmarks_QM_LOADER
-  )
+file(GLOB PO_FILES "po/*.po")
+if (PO_FILES)
+  ecm_create_qm_from_po_files(PO_FILES ${PO_FILES} CATALOG_NAME kbookmarks5)
 endif()
 
 add_subdirectory(src)
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 676b172..faa25e1 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -1,6 +1,8 @@
 # TODO
 remove_definitions(-DQT_NO_CAST_FROM_ASCII)
 
+ecm_create_qm_loader(kbookmarks_QM_LOADER kbookmarks5)
+
 set(kbookmarks_SRCS
   kbookmark.cpp
   kbookmarkaction.cpp
-


Diffs
-

  modules/ECMCreateQmFromPoFiles.cmake 92d0d1a 
  modules/ECMQmLoader.cpp.in 4fd9c11 

Diff: https://git.reviewboard.kde.org/r/117560/diff/


Testing
---

Built translations for KF5 from within frameworks source and from a patched 
l10n-kf5.


Thanks,

Aurélien Gâteau

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117560: ECMCreateQmFromPoFiles: adjust API to make it usable from within trunk/l10n-kf5

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117560/#review55845
---


This review has been submitted with commit 
071581a3f899c881c9938efd082fd32589822b45 by Aurélien Gâteau to branch master.

- Commit Hook


On April 15, 2014, 3:36 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117560/
> ---
> 
> (Updated April 15, 2014, 3:36 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Translators (are going to) translate KF5 in trunk/l10n-kf5 ( 
> http://websvn.kde.org/trunk/l10n-kf5/ ). It is necessary to support their 
> work-flow, which consists of:
> 1) build the code from git
> 2) builds and installs all translations from one language
> 
> The patch makes several changes to ECMCreateQmFromPoFiles to support this 
> work-flow:
> 
> - It splits the code into two functions: one to create the .qm and install 
> them, another to build the .qm loader. This way the loader can be generated 
> even if no translations are available.
> 
> - It changes the syntax of ecm_create_qm_from_po_files() to accept po files 
> instead of a po directory. This is needed because within the same language 
> directory some .po are going to be turned into .qm while others are turned 
> into .mo.
> 
> - It creates "translation-N" targets (like CMake gettext code does) to 
> support multiple calls within one cmake project.
> 
> - It installs to share/locale//LC_MESSAGES (like gettext), because 
> l10n-kf5 build system cannot know where the framework would decide to keep 
> its .qm file, so it's simpler to use a standard place.
> 
> This potentially breaks existing framework builds, but only for developers 
> who created manually po/ directories in their work tree (almost nobody, I 
> expect), so I think it can be pushed as is. I already have the code ready to 
> fix existing frameworks.
> 
> Those changes still support shipping translations within frameworks tarballs. 
> Assuming this patch gets in, the build system of each framework is going to 
> be patched like this:
> 
> -
> diff --git a/CMakeLists.txt b/CMakeLists.txt
> index b5e445c..c9a706c 100644
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt
> @@ -16,6 +16,8 @@ include(GenerateExportHeader)
>  include(ECMSetupVersion)
>  include(ECMGenerateHeaders)
>  
> +include(ECMCreateQmFromPoFiles)
> +
>  set(KF5_VERSION "4.98.0")
>  
>  ecm_setup_version(${KF5_VERSION}
> @@ -37,14 +39,9 @@ if ("${CMAKE_BINARY_DIR}" STREQUAL 
> "${CMAKE_CURRENT_BINARY_DIR}")
>find_package(KF5XmlGui ${KF5_VERSION} REQUIRED)
>  endif()
>  
> -if (EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/po)
> -  include(ECMCreateQmFromPoFiles)
> -  ecm_create_qm_from_po_files(
> -PO_DIR po
> -POT_NAME kbookmarks5.pot
> -DATA_INSTALL_SUB_DIR kbookmarks
> -CREATE_LOADER kbookmarks_QM_LOADER
> -  )
> +file(GLOB PO_FILES "po/*.po")
> +if (PO_FILES)
> +  ecm_create_qm_from_po_files(PO_FILES ${PO_FILES} CATALOG_NAME kbookmarks5)
>  endif()
>  
>  add_subdirectory(src)
> diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
> index 676b172..faa25e1 100644
> --- a/src/CMakeLists.txt
> +++ b/src/CMakeLists.txt
> @@ -1,6 +1,8 @@
>  # TODO
>  remove_definitions(-DQT_NO_CAST_FROM_ASCII)
>  
> +ecm_create_qm_loader(kbookmarks_QM_LOADER kbookmarks5)
> +
>  set(kbookmarks_SRCS
>kbookmark.cpp
>kbookmarkaction.cpp
> -
> 
> 
> Diffs
> -
> 
>   modules/ECMCreateQmFromPoFiles.cmake 92d0d1a 
>   modules/ECMQmLoader.cpp.in 4fd9c11 
> 
> Diff: https://git.reviewboard.kde.org/r/117560/diff/
> 
> 
> Testing
> ---
> 
> Built translations for KF5 from within frameworks source and from a patched 
> l10n-kf5.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117581: Deprecate ecm_dbus_add_activation_service()

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117581/
---

Review request for Build System, Extra Cmake Modules and KDE Frameworks.


Repository: extra-cmake-modules


Description
---

Deprecate ecm_dbus_add_activation_service()

This is a bit of a pointless macro: it can be replaced with two lines
for each input file (and it is usually only called with a single input
file), and it is much clearer what those two lines do.


Diffs
-

  modules/ECMDBusAddActivationService.cmake 
128482e35f9f15025868f3e283db839556a0ce82 

Diff: https://git.reviewboard.kde.org/r/117581/diff/


Testing
---

Built documentation; built and installed KWallet (one of the two users of this 
macro).


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117582: Simplify D-Bus service CMake code

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117582/
---

Review request for KDE Frameworks.


Repository: kded


Description
---

Simplify D-Bus service CMake code


Diffs
-

  src/CMakeLists.txt 8d5ec90a56d48d6be8f126cc5b228a5f965386b6 

Diff: https://git.reviewboard.kde.org/r/117582/diff/


Testing
---

Configured, built, installed.  Installation step reported that 
"/home/kf5-devel/kf5/share/dbus-1/services/org.kde.kded5.service" was 
"Up-to-date".


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117583: Remove use of ecm_dbus_add_activation_service()

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117583/
---

Review request for KDE Frameworks.


Repository: kwallet


Description
---

Remove use of ecm_dbus_add_activation_service()

There is no point using an obscure macro that can be replaced with two
straightforward CMake commands.


Diffs
-

  src/runtime/kwalletd/CMakeLists.txt d9fb4b3 

Diff: https://git.reviewboard.kde.org/r/117583/diff/


Testing
---

Configured, built, installed, visually inspected 
$PREFIX/share/dbus-1/services/org.kde.kwalletd5.service.


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117585: ECMFindModuleHelpers: set traditional variables

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117585/
---

Review request for Build System, Extra Cmake Modules and KDE Frameworks.


Repository: extra-cmake-modules


Description
---

ECMFindModuleHelpers: set traditional variables

The traditional *_LIBRARIES, *_INCLUDE_DIRS and *_DEFINITIONS do have
some uses - they make it easier to create package config files that use
found libraries in their link interface.  So this makes sure these
variables are set by ecm_find_package_handle_library_components() (and
hence by FindWayland.cmake and FindXCB.cmake).


Diffs
-

  modules/ECMFindModuleHelpers.cmake 15df9ef05f8367df3ebf60dd3f3c9bfe937d2547 
  find-modules/FindXCB.cmake dd876b214edd35993b8e8d3582536a24776a2e64 
  find-modules/FindWayland.cmake b7790e750e8ae9b1c6d5be81b7683b489d60a5a7 

Diff: https://git.reviewboard.kde.org/r/117585/diff/


Testing
---

Configured, built and installed KWindowSystem and KWin.


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117593: ECMGeneratePriFile: Allow lib and include install dirs to be overridden

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117593/
---

Review request for Build System, Extra Cmake Modules, KDE Frameworks, and David 
Faure.


Repository: extra-cmake-modules


Description
---

ECMGeneratePriFile: Allow lib and include install dirs to be overridden

Rather than blindly using ${LIB_INSTALL_DIR} and ${INCLUDE_INSTALL_DIR}
(which assume the inclusion of KDEInstallDirs), this checks whether they
exist, also checks for ${CMAKE_INSTALL_LIBDIR} and
${CMAKE_INSTALL_INCLUDEDIR} (set by GNUInstallDirs), provides hard-coded
defaults and allows arguments to be used to override the values.

This should make it useful to projects that aren't KDE Frameworks.


Diffs
-

  modules/ECMGeneratePriFile.cmake bff2961f9a5fe72c84dff4d0ea4466c7693fe00c 

Diff: https://git.reviewboard.kde.org/r/117593/diff/


Testing
---

Configured, built and installed KArchive.  Visually inspected installed .pri 
file.


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117596: ECMCreateQmFromPoFiles: Also check CMAKE_INSTALL_LOCALEDIR

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117596/
---

Review request for Build System, Extra Cmake Modules, KDE Frameworks, and 
Aurélien Gâteau.


Repository: extra-cmake-modules


Description
---

ECMCreateQmFromPoFiles: Also check CMAKE_INSTALL_LOCALEDIR

This is the variable set by GNUInstallDirs.


Diffs
-

  modules/ECMCreateQmFromPoFiles.cmake b8f3c651d29bec273834d848de89150829a1c91e 

Diff: https://git.reviewboard.kde.org/r/117596/diff/


Testing
---

Built, ran `make test`.

Note to self: ECM needs more unit tests.


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117565: Expose the quit slot on KDBusService-enabled applications

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117565/#review55880
---

Ship it!


Ship It!

- David Edmundson


On April 14, 2014, 4:12 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117565/
> ---
> 
> (Updated April 14, 2014, 4:12 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdbusaddons
> 
> 
> Description
> ---
> 
> Makes it possible to use kquitapp again. So far quit wasn't being exposed 
> because QCoreApplication::quit is not a scriptable slot, but a regular slot 
> instead.
> 
> 
> Diffs
> -
> 
>   src/kdbusservice.cpp 497c774 
> 
> Diff: https://git.reviewboard.kde.org/r/117565/diff/
> 
> 
> Testing
> ---
> 
> Now I have a way to close plasma-shell that doesn't lose all unsaved 
> configuration.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117565: Expose the quit slot on KDBusService-enabled applications

[David Edmundson]

> On April 15, 2014, 1:43 p.m., Àlex Fiestas wrote:
> > Not sure if exporting all Slots is what we want, but I think we do want to 
> > have Quit exposed in dbus.

there is only one slot, and we can't really change QCoreApplication at this 
point.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117565/#review55813
---


On April 14, 2014, 4:12 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117565/
> ---
> 
> (Updated April 14, 2014, 4:12 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdbusaddons
> 
> 
> Description
> ---
> 
> Makes it possible to use kquitapp again. So far quit wasn't being exposed 
> because QCoreApplication::quit is not a scriptable slot, but a regular slot 
> instead.
> 
> 
> Diffs
> -
> 
>   src/kdbusservice.cpp 497c774 
> 
> Diff: https://git.reviewboard.kde.org/r/117565/diff/
> 
> 
> Testing
> ---
> 
> Now I have a way to close plasma-shell that doesn't lose all unsaved 
> configuration.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117565: Expose the quit slot on KDBusService-enabled applications

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117565/
---

(Updated April 16, 2014, 2:28 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Repository: kdbusaddons


Description
---

Makes it possible to use kquitapp again. So far quit wasn't being exposed 
because QCoreApplication::quit is not a scriptable slot, but a regular slot 
instead.


Diffs
-

  src/kdbusservice.cpp 497c774 

Diff: https://git.reviewboard.kde.org/r/117565/diff/


Testing
---

Now I have a way to close plasma-shell that doesn't lose all unsaved 
configuration.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117565: Expose the quit slot on KDBusService-enabled applications

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117565/#review55881
---


This review has been submitted with commit 
29e485f793ef818c83fc4b8e36a1a467fc2f5805 by Aleix Pol to branch master.

- Commit Hook


On April 14, 2014, 4:12 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117565/
> ---
> 
> (Updated April 14, 2014, 4:12 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdbusaddons
> 
> 
> Description
> ---
> 
> Makes it possible to use kquitapp again. So far quit wasn't being exposed 
> because QCoreApplication::quit is not a scriptable slot, but a regular slot 
> instead.
> 
> 
> Diffs
> -
> 
>   src/kdbusservice.cpp 497c774 
> 
> Diff: https://git.reviewboard.kde.org/r/117565/diff/
> 
> 
> Testing
> ---
> 
> Now I have a way to close plasma-shell that doesn't lose all unsaved 
> configuration.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117596: ECMCreateQmFromPoFiles: Also check CMAKE_INSTALL_LOCALEDIR

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117596/#review55882
---

Ship it!


Ship It!

- Aurélien Gâteau


On April 16, 2014, 3:43 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117596/
> ---
> 
> (Updated April 16, 2014, 3:43 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, and 
> Aurélien Gâteau.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> ECMCreateQmFromPoFiles: Also check CMAKE_INSTALL_LOCALEDIR
> 
> This is the variable set by GNUInstallDirs.
> 
> 
> Diffs
> -
> 
>   modules/ECMCreateQmFromPoFiles.cmake 
> b8f3c651d29bec273834d848de89150829a1c91e 
> 
> Diff: https://git.reviewboard.kde.org/r/117596/diff/
> 
> 
> Testing
> ---
> 
> Built, ran `make test`.
> 
> Note to self: ECM needs more unit tests.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kwindowsystem_master_qt5 » All,LINBUILDER #44

[KDE CI System]

See 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Update your copy of extra-cmake-modules

[Aurélien Gâteau]

Hi,

I just pushed some changes to frameworks using Qt for translations which
requires a recent version of extra-cmake-modules (you need to have
071581a3f899c881c9938efd082fd32589822b45). If you get build failures
complaining about an unknown "ecm_create_qm_loader", then you need to
update.

Aurélien
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117596: ECMCreateQmFromPoFiles: Also check CMAKE_INSTALL_LOCALEDIR

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117596/#review55888
---


This review has been submitted with commit 
f017671e5543667a695146a4df0e1cb694812ca3 by Alex Merry to branch master.

- Commit Hook


On April 16, 2014, 1:43 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117596/
> ---
> 
> (Updated April 16, 2014, 1:43 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, and 
> Aurélien Gâteau.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> ECMCreateQmFromPoFiles: Also check CMAKE_INSTALL_LOCALEDIR
> 
> This is the variable set by GNUInstallDirs.
> 
> 
> Diffs
> -
> 
>   modules/ECMCreateQmFromPoFiles.cmake 
> b8f3c651d29bec273834d848de89150829a1c91e 
> 
> Diff: https://git.reviewboard.kde.org/r/117596/diff/
> 
> 
> Testing
> ---
> 
> Built, ran `make test`.
> 
> Note to self: ECM needs more unit tests.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117596: ECMCreateQmFromPoFiles: Also check CMAKE_INSTALL_LOCALEDIR

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117596/
---

(Updated April 16, 2014, 3:54 p.m.)


Status
--

This change has been marked as submitted.


Review request for Build System, Extra Cmake Modules, KDE Frameworks, and 
Aurélien Gâteau.


Repository: extra-cmake-modules


Description
---

ECMCreateQmFromPoFiles: Also check CMAKE_INSTALL_LOCALEDIR

This is the variable set by GNUInstallDirs.


Diffs
-

  modules/ECMCreateQmFromPoFiles.cmake b8f3c651d29bec273834d848de89150829a1c91e 

Diff: https://git.reviewboard.kde.org/r/117596/diff/


Testing
---

Built, ran `make test`.

Note to self: ECM needs more unit tests.


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117600: Allow ecm_create_qm_loader() to be passed the _SRCS variable

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117600/
---

Review request for Build System, Extra Cmake Modules, KDE Frameworks, and 
Aurélien Gâteau.


Repository: extra-cmake-modules


Description
---

Allow ecm_create_qm_loader() to be passed the _SRCS variable

This allows a more straightforward way of using it, which matches the
macros that generate things like D-Bus interfaces.


Diffs
-

  modules/ECMCreateQmFromPoFiles.cmake e7a401a185dd3d00017cb2fd2419e2a218a9b354 

Diff: https://git.reviewboard.kde.org/r/117600/diff/


Testing
---

Built kdesignerplugin, then modified it to use the kdesignerplugin_SRCS 
variable directly and built it again.  Both times, `make VERBOSE=1` showed that 
ECMQmLoader.cpp was compiled and linked into the executable.


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117600: Allow ecm_create_qm_loader() to be passed the _SRCS variable

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117600/#review55894
---

Ship it!


Ship It!

- Aurélien Gâteau


On April 16, 2014, 6:33 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117600/
> ---
> 
> (Updated April 16, 2014, 6:33 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, and 
> Aurélien Gâteau.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Allow ecm_create_qm_loader() to be passed the _SRCS variable
> 
> This allows a more straightforward way of using it, which matches the
> macros that generate things like D-Bus interfaces.
> 
> 
> Diffs
> -
> 
>   modules/ECMCreateQmFromPoFiles.cmake 
> e7a401a185dd3d00017cb2fd2419e2a218a9b354 
> 
> Diff: https://git.reviewboard.kde.org/r/117600/diff/
> 
> 
> Testing
> ---
> 
> Built kdesignerplugin, then modified it to use the kdesignerplugin_SRCS 
> variable directly and built it again.  Both times, `make VERBOSE=1` showed 
> that ECMQmLoader.cpp was compiled and linked into the executable.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117376: fix kded build on Windows

[Alexander Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117376/
---

(Updated April 16, 2014, 4:46 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and kdewin.


Repository: kded


Description
---

fix kded build on Windows


also add KCONF_UPDATE_EXE define to kded5 target


Diffs
-

  src/CMakeLists.txt 8d5ec90a56d48d6be8f126cc5b228a5f965386b6 
  src/kded.cpp 3a222bd14ff6dd8727212a74e621d069e05dda28 

Diff: https://git.reviewboard.kde.org/r/117376/diff/


Testing
---

compiles


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117376: fix kded build on Windows

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117376/#review55895
---


This review has been submitted with commit 
3015d1dc2525c529f9772274db98c6ce6f80fb44 by Alex Richardson to branch master.

- Commit Hook


On April 4, 2014, 7:43 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117376/
> ---
> 
> (Updated April 4, 2014, 7:43 p.m.)
> 
> 
> Review request for KDE Frameworks and kdewin.
> 
> 
> Repository: kded
> 
> 
> Description
> ---
> 
> fix kded build on Windows
> 
> 
> also add KCONF_UPDATE_EXE define to kded5 target
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 8d5ec90a56d48d6be8f126cc5b228a5f965386b6 
>   src/kded.cpp 3a222bd14ff6dd8727212a74e621d069e05dda28 
> 
> Diff: https://git.reviewboard.kde.org/r/117376/diff/
> 
> 
> Testing
> ---
> 
> compiles
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117080: cleanup KDirModelTest

[Alexander Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117080/
---

(Updated April 16, 2014, 6:47 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks.


Repository: kio


Description
---

Use Qt5 new signal slot syntax for KDirModelTest

This allows removing #define connect(...) QVERIFY(QObject::connect(...)),
since now the connections are checked at compile time.
Also removed all disconnect calls at the end of a test, now this is done
in cleanup() which is automatically called after each test case

Always use QTestEventLoop (as is the case now already)

This merely removes the #define and #ifdefs for it


Diffs
-

  autotests/kdirmodeltest.h b8b41ec52a61a083c6c76e9184a556835551443e 
  autotests/kdirmodeltest.cpp 5d59eba45495de30db5e70da2e80bb3d5cba424c 

Diff: https://git.reviewboard.kde.org/r/117080/diff/


Testing
---

Test still passes (except for testFontUrlWithHost, but that has always timed 
out for me)


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117475: kmimeassociationstest: remove kde4- prefix from desktop file names

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117475/
---

(Updated April 16, 2014, 4:50 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Repository: kservice


Description
---

kmimeassociationstest: remove kde4- prefix from desktop file names

The code path this tested no longer exists.


Diffs
-

  autotests/kmimeassociationstest.cpp d7b3ac29ca7292c0250286b241f20891c988bab6 

Diff: https://git.reviewboard.kde.org/r/117475/diff/


Testing
---

Test still passes.


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117475: kmimeassociationstest: remove kde4- prefix from desktop file names

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117475/#review55897
---


This review has been submitted with commit 
9bbdd1615b484c229657fd0896b2dbebdea9988d by Alex Merry to branch master.

- Commit Hook


On April 12, 2014, 6:39 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117475/
> ---
> 
> (Updated April 12, 2014, 6:39 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> kmimeassociationstest: remove kde4- prefix from desktop file names
> 
> The code path this tested no longer exists.
> 
> 
> Diffs
> -
> 
>   autotests/kmimeassociationstest.cpp 
> d7b3ac29ca7292c0250286b241f20891c988bab6 
> 
> Diff: https://git.reviewboard.kde.org/r/117475/diff/
> 
> 
> Testing
> ---
> 
> Test still passes.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117475: kmimeassociationstest: remove kde4- prefix from desktop file names

[Alex Merry]

> On April 16, 2014, 4:50 p.m., Commit Hook wrote:
> > This review has been submitted with commit 
> > 9bbdd1615b484c229657fd0896b2dbebdea9988d by Alex Merry to branch master.

Oops, wrong RR number.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117475/#review55897
---


On April 16, 2014, 4:50 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117475/
> ---
> 
> (Updated April 16, 2014, 4:50 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> kmimeassociationstest: remove kde4- prefix from desktop file names
> 
> The code path this tested no longer exists.
> 
> 
> Diffs
> -
> 
>   autotests/kmimeassociationstest.cpp 
> d7b3ac29ca7292c0250286b241f20891c988bab6 
> 
> Diff: https://git.reviewboard.kde.org/r/117475/diff/
> 
> 
> Testing
> ---
> 
> Test still passes.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117599: Improve tests

[Michael Palimaka]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117599/
---

Review request for KDE Frameworks.


Repository: plasma-framework


Description
---

Move some stray tests to the root directory in line with other tests.


Diffs
-

  src/plasmaquick/autotests/CMakeLists.txt 
9a54d186359729fe37d0fe03c7faee1e478bf3af 
  src/plasmaquick/CMakeLists.txt 0b43f9156f3b4c32ad0a7f9a1ffcb55ff29e1a9c 
  src/declarativeimports/core/tests/sortfiltermodeltest.h  
  src/declarativeimports/core/tests/sortfiltermodeltest.cpp 
f4f930c2ec3abffed4773e6f2340693117426dd5 
  src/declarativeimports/core/tests/modeltest.cpp  
  src/declarativeimports/core/tests/modeltest.h  
  src/declarativeimports/core/tests/manual/dialog_positioning.qml  
  src/declarativeimports/core/tests/dynamictreemodel.cpp  
  src/declarativeimports/core/tests/dynamictreemodel.h  
  src/declarativeimports/core/tests/CMakeLists.txt 
9fc9f894a4b8131f5870a839e892de6cf6e9026e 
  src/declarativeimports/core/CMakeLists.txt 
044e043cf980d54448495dbe4450b892907ecf39 
  autotests/CMakeLists.txt e5db1c5290f421da4606c9a0a0bc673fe61f94da 
  CMakeLists.txt 3052efc471cfd6518f0c82148eb08409da56b6bf 
  src/plasmaquick/autotests/packageurlinterceptortest.h  
  src/plasmaquick/autotests/packageurlinterceptortest.cpp 
d39a89aaba811b1ab1045be2b5dbe0d279a39235 

Diff: https://git.reviewboard.kde.org/r/117599/diff/


Testing
---

Builds, tests still pass.


Thanks,

Michael Palimaka

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117600: Allow ecm_create_qm_loader() to be passed the _SRCS variable

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117600/
---

(Updated April 16, 2014, 4:52 p.m.)


Status
--

This change has been marked as submitted.


Review request for Build System, Extra Cmake Modules, KDE Frameworks, and 
Aurélien Gâteau.


Repository: extra-cmake-modules


Description
---

Allow ecm_create_qm_loader() to be passed the _SRCS variable

This allows a more straightforward way of using it, which matches the
macros that generate things like D-Bus interfaces.


Diffs
-

  modules/ECMCreateQmFromPoFiles.cmake e7a401a185dd3d00017cb2fd2419e2a218a9b354 

Diff: https://git.reviewboard.kde.org/r/117600/diff/


Testing
---

Built kdesignerplugin, then modified it to use the kdesignerplugin_SRCS 
variable directly and built it again.  Both times, `make VERBOSE=1` showed that 
ECMQmLoader.cpp was compiled and linked into the executable.


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Update your copy of extra-cmake-modules

[šumski]

On Wednesday 16 of April 2014 07:36:57 Aurélien Gâteau wrote:
> Hi,
> 
> I just pushed some changes to frameworks using Qt for translations which
> requires a recent version of extra-cmake-modules (you need to have
> 071581a3f899c881c9938efd082fd32589822b45). If you get build failures
> complaining about an unknown "ecm_create_qm_loader", then you need to
> update.
Hi Aurélien,
would it be possible to leave the previous logic in Frameworks? With these 
changes all frameworks always include ECMCreateQmFromPoFiles, which require 
development files for qttools, which then requires QtGui and QtWidgets 
development files, which require ... etc ;-)
Just curious.

Cheers,
Hrvoje

> Aurélien
> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Hitting assertion in kio-trash (KF5KIOCore)

[Kevin Funk]

Hey,

While running unit tests from kdevplatform I hit the following assert in 
trash/trashimpl.cpp (from workspace/kio-extras)

Output of the unit test (which attempts to trash some folders):
trying to create  "/home/krf/.local/share/Trash/info/.trashinfo" 
trying to create  "/home/krf/.local/share/Trash/info/.trashinfo 1" 
trying to create  "/home/krf/.local/share/Trash/info/.trashinfo 2" 
trying to create  "/home/krf/.local/share/Trash/info/.trashinfo 3" 
trying to create  "/home/krf/.local/share/Trash/info/.trashinfo 4" 
trying to create  "/home/krf/.local/share/Trash/info/.trashinfo 5" 
trying to create  "/home/krf/.local/share/Trash/info/.trashinfo 6" 
ASSERT: "fileId.endsWith( QLatin1String(".trashinfo") )" in file 
/home/krf/devel/src/kf5/kde/workspace/kio-extras/trash/trashimpl.cpp, line 272
kioslave: ### CRASH ## protocol = trash pid = 6144 signal = 6
/home/krf/devel/install/kf5/lib/x86_64-linux-gnu/libKF5KIOCore.so.5(+0x8d609)
[0x7fbbbfe79609]
(...)

Looking at the code, that assert looks very suspicious. The code above the 
assert seems to generate file ids such as '.trashinfo' or '.trashinfo 
SOME_NUMBER'. In case of the latter, the assert will always be hit.

Any ideas? Did KIO::RenameDialog::suggestName change?

Reproducable with:
./plugins/git/tests/kdevgit-test testRemoveEmptyFolder

from kdevplatform.git.

Greets

-- 
Kevin Funk
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117602: Remove more UPnP stuff

[Michael Palimaka]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117602/
---

Review request for KDE Frameworks and Àlex Fiestas.


Repository: solid


Description
---

Since the UPnP backend was removed, it looks like this other UPnP stuff can go 
too.


Diffs
-

  KF5SolidConfig.cmake.in a767f1963816a1f706ee6a4871f0ba95745b7151 
  cmake/FindHUpnp.cmake 8b34c2e8279c0cf21f2703e1cd5b22c3c35891dc 
  src/solid/backends/fstab/fstabdevice.h 
cd8d92622ae35230cf9e90422a68260c1bab1bdb 
  src/solid/config-solid.h.cmake 84d12604e0177d5af7108daf11b9b99be33468d5 
  src/solid/managerbase.cpp 66338125df7eb58fefb31c423b37258b9b96f1da 
  src/solid/networkshare.h 6d8ab1e914d0f2fc570a48b4959aed99f3859c15 

Diff: https://git.reviewboard.kde.org/r/117602/diff/


Testing
---

Builds, tests pass.


Thanks,

Michael Palimaka

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kdelibs_stable #1063

[KDE CI System]

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117604: Fix KDBusServiceStarter::findServiceFor() not returning error string

[David Jarvie]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117604/
---

Review request for KDE Frameworks and David Faure.


Repository: kservice


Description
---

When KDBusServiceStarter::findServiceFor() fails to start the requested service 
after it is found to not be running, it does not return the error string. This 
patch fixes that and makes it behave as in the apidox.

This is a copy of https://git.reviewboard.kde.org/r/116951/ for KDE 4, except 
that the qDebug line has been uncommented on the grounds that it reports an 
error.


Diffs
-

  src/plugin/kdbusservicestarter.cpp 6f011bd 

Diff: https://git.reviewboard.kde.org/r/117604/diff/


Testing
---

Tested for review 116951.


Thanks,

David Jarvie

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117604: Fix KDBusServiceStarter::findServiceFor() not returning error string

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117604/#review55921
---



src/plugin/kdbusservicestarter.cpp


It should be a qWarning.


Looks good to me though, it's very annoying to debug this kind of problems 
without feedback. +1

- Aleix Pol Gonzalez


On April 16, 2014, 9:07 p.m., David Jarvie wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117604/
> ---
> 
> (Updated April 16, 2014, 9:07 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> When KDBusServiceStarter::findServiceFor() fails to start the requested 
> service after it is found to not be running, it does not return the error 
> string. This patch fixes that and makes it behave as in the apidox.
> 
> This is a copy of https://git.reviewboard.kde.org/r/116951/ for KDE 4, except 
> that the qDebug line has been uncommented on the grounds that it reports an 
> error.
> 
> 
> Diffs
> -
> 
>   src/plugin/kdbusservicestarter.cpp 6f011bd 
> 
> Diff: https://git.reviewboard.kde.org/r/117604/diff/
> 
> 
> Testing
> ---
> 
> Tested for review 116951.
> 
> 
> Thanks,
> 
> David Jarvie
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117599: Improve tests

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117599/#review55922
---

Ship it!


Looks good, interesting work towards a more unified experience across 
frameworks.

- Aleix Pol Gonzalez


On April 16, 2014, 4:53 p.m., Michael Palimaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117599/
> ---
> 
> (Updated April 16, 2014, 4:53 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Move some stray tests to the root directory in line with other tests.
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/autotests/CMakeLists.txt 
> 9a54d186359729fe37d0fe03c7faee1e478bf3af 
>   src/plasmaquick/CMakeLists.txt 0b43f9156f3b4c32ad0a7f9a1ffcb55ff29e1a9c 
>   src/declarativeimports/core/tests/sortfiltermodeltest.h  
>   src/declarativeimports/core/tests/sortfiltermodeltest.cpp 
> f4f930c2ec3abffed4773e6f2340693117426dd5 
>   src/declarativeimports/core/tests/modeltest.cpp  
>   src/declarativeimports/core/tests/modeltest.h  
>   src/declarativeimports/core/tests/manual/dialog_positioning.qml  
>   src/declarativeimports/core/tests/dynamictreemodel.cpp  
>   src/declarativeimports/core/tests/dynamictreemodel.h  
>   src/declarativeimports/core/tests/CMakeLists.txt 
> 9fc9f894a4b8131f5870a839e892de6cf6e9026e 
>   src/declarativeimports/core/CMakeLists.txt 
> 044e043cf980d54448495dbe4450b892907ecf39 
>   autotests/CMakeLists.txt e5db1c5290f421da4606c9a0a0bc673fe61f94da 
>   CMakeLists.txt 3052efc471cfd6518f0c82148eb08409da56b6bf 
>   src/plasmaquick/autotests/packageurlinterceptortest.h  
>   src/plasmaquick/autotests/packageurlinterceptortest.cpp 
> d39a89aaba811b1ab1045be2b5dbe0d279a39235 
> 
> Diff: https://git.reviewboard.kde.org/r/117599/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests still pass.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel