date:20140502

Re: Review Request 117961: remove several warnings on mingw

2014-05-02 Thread Patrick Spendrin



> On May 3, 2014, 4:25 a.m., Nicolás Alvarez wrote:
> > src/lib/util/kuser_win.cpp, line 849
> > 
> >
> > What's the warning here? Is it about signed vs unsigned? If so, change 
> > the format specifier to %u instead of casting.

no, the warning is about DWORD vs. (long) int.


- Patrick


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117961/#review57173
---


On May 2, 2014, 9:16 p.m., Patrick Spendrin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117961/
> ---
> 
> (Updated May 2, 2014, 9:16 p.m.)
> 
> 
> Review request for KDE Frameworks, kdewin and Alexander Richardson.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> remove several warnings on mingw
> 
> 
> Diffs
> -
> 
>   autotests/kformattest.cpp 7479bb2c2f9730f70831a965f7a03b9e30dd442c 
>   autotests/kprocesstest.cpp 3dbaa9ab3cb238618cae54aed3797c69997aea66 
>   autotests/kusertest.cpp 4ee9e86613bbf7044ac025b128449afeeac00940 
>   src/lib/util/kuser_win.cpp 2018a129f3ef9911df0c3f071d1617cac3026168 
> 
> Diff: https://git.reviewboard.kde.org/r/117961/diff/
> 
> 
> Testing
> ---
> 
> mingw only, needs testing on *nix and on msvc
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117961: remove several warnings on mingw

2014-05-02 Thread Nicolás Alvarez


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117961/#review57173
---



src/lib/util/kuser_win.cpp


What's the warning here? Is it about signed vs unsigned? If so, change the 
format specifier to %u instead of casting.


- Nicolás Alvarez


On May 2, 2014, 6:16 p.m., Patrick Spendrin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117961/
> ---
> 
> (Updated May 2, 2014, 6:16 p.m.)
> 
> 
> Review request for KDE Frameworks, kdewin and Alexander Richardson.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> remove several warnings on mingw
> 
> 
> Diffs
> -
> 
>   autotests/kformattest.cpp 7479bb2c2f9730f70831a965f7a03b9e30dd442c 
>   autotests/kprocesstest.cpp 3dbaa9ab3cb238618cae54aed3797c69997aea66 
>   autotests/kusertest.cpp 4ee9e86613bbf7044ac025b128449afeeac00940 
>   src/lib/util/kuser_win.cpp 2018a129f3ef9911df0c3f071d1617cac3026168 
> 
> Diff: https://git.reviewboard.kde.org/r/117961/diff/
> 
> 
> Testing
> ---
> 
> mingw only, needs testing on *nix and on msvc
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117695: change where dynamic replace tabs is performed

2014-05-02 Thread Sven Brauch


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117695/
---

(Updated May 3, 2014, 12:57 a.m.)


Review request for KDE Frameworks and Christoph Cullmann.


Changes
---

Sorry this took so long, here are some tests demonstrating the new behaviour.


Repository: ktexteditor


Description
---

This makes typeChars handle replacing tabs by spaces, instead of insertText. 
The rationale is that insertText is often called programatically, and the 
caller should be able to rely on the text he requests to be inserted is 
actually inserted, and not changed on-the-fly. Examples for where the previous 
solution caused problems are KDevelop (the codegen) and kte-collaborative.

I'm not sure what the code I removed was doing (heh). It looks like it is 
supposed to advance to the next indent level if the current indent level is 
odd, but that still works after removing it.

The obvious user-visible change here is that tabs in pasted text will no longer 
be replaced. But since I always found this behaviour undesirable anyways, I did 
not bother to replicate it. I will instead wait for people to yell at me for 
removing it. ;)


Diffs (updated)
-

  autotests/src/katedocument_test.h cff61d0 
  autotests/src/katedocument_test.cpp f3eef18 
  src/document/katedocument.h 83cc031 
  src/document/katedocument.cpp 546d3e6 

Diff: https://git.reviewboard.kde.org/r/117695/diff/


Testing
---

Just some quick manual tests, it seems to still work as intended.


Thanks,

Sven Brauch

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117967: use different syntax to run the target in question instead of an executable in the path

2014-05-02 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117967/
---

Review request for Build System, Extra Cmake Modules, KDE Frameworks, and 
kdewin.


Repository: extra-cmake-modules


Description
---

use different syntax to run the target in question instead of an executable in 
the path.
Currently cmake uses some logic to find the executable in the path or in some 
subdirectories of the current directory. It doesn't look for targets of the 
same name though, which is the wanted behaviour here.


Diffs
-

  modules/ECMAddTests.cmake 9052d8863fb9447b751387199e649efaedc69a3d 

Diff: https://git.reviewboard.kde.org/r/117967/diff/


Testing
---

windows


Thanks,

Patrick Spendrin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117965: use the correct global variables

2014-05-02 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117965/
---

Review request for Build System, Extra Cmake Modules, KDE Frameworks, and 
kdewin.


Repository: extra-cmake-modules


Description
---

use the correct global variables


Diffs
-

  kde-modules/KDECMakeSettings.cmake c206ff82ca76e7fda6538f407b83eea6ecab1242 

Diff: https://git.reviewboard.kde.org/r/117965/diff/


Testing
---

windows


Thanks,

Patrick Spendrin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117964: Fix references to translation of licenses

2014-05-02 Thread Luigi Toscano


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117964/
---

Review request for Documentation and KDE Frameworks.


Repository: kdoctools


Description
---

Use the -translated version if and only if the translation is available.
(but few files are still missing).


Diffs
-

  src/customization/af/entities/underGPL.docbook 7ba1046 
  src/customization/cs/entities/underGPL.docbook 83272a2 
  src/customization/da/entities/underGPL.docbook d2a50914 
  src/customization/de/entities/underLGPL.docbook e60e315 
  src/customization/el/entities/underGPL.docbook 83272a2 
  src/customization/eo/entities/underGPL.docbook 83fd738 
  src/customization/es/entities/underGPL.docbook 629acac 
  src/customization/et/entities/underGPL.docbook 63a0e4c 
  src/customization/fi/entities/underGPL.docbook 29a3508 
  src/customization/hu/entities/underFDL.docbook 74d0853 
  src/customization/id/entities/underGPL.docbook 83272a2 
  src/customization/it/entities/underGPL.docbook d28fbc6 
  src/customization/ja/entities/underGPL.docbook 7d9e108 
  src/customization/nds/entities/underFDL.docbook 415706d 
  src/customization/nds/entities/underGPL.docbook 50a1f8a 
  src/customization/nds/entities/underLGPL.docbook c6076c8 
  src/customization/nl/entities/underFDL.docbook 5cc87c7 
  src/customization/nl/entities/underLGPL.docbook a70e1c3 
  src/customization/nn/entities/underGPL.docbook 220c120 
  src/customization/no/entities/underGPL.docbook 83272a2 
  src/customization/pt/entities/underGPL.docbook e6f54fb 
  src/customization/ro/entities/underGPL.docbook a82629b 
  src/customization/ru/entities/underGPL.docbook a6eb447 
  src/customization/sk/entities/underGPL.docbook 7f1538e 
  src/customization/sl/entities/underFDL.docbook 73c6f46 
  src/customization/sv/entities/underGPL.docbook b21aa3b 
  src/customization/sv/entities/underLGPL.docbook 562835a 
  src/customization/uk/entities/underFDL.docbook da90809 
  src/customization/uk/entities/underLGPL.docbook efbcd4e 
  src/customization/zh-TW/entities/underFDL.docbook 7899e04 

Diff: https://git.reviewboard.kde.org/r/117964/diff/


Testing
---


Thanks,

Luigi Toscano

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117963: Install the English fallback for license translations, simplify the installation of language-specific files

2014-05-02 Thread Luigi Toscano


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117963/
---

Review request for Documentation and KDE Frameworks.


Repository: kdoctools


Description
---

This is the combination of two commits:
-- 
Simplify the installation of language-specific files
-- 
Add the English version of license translation file as fallback

When the -translated version of the license file is available,
help:/kdoctools5-common/gpl-translated.html always works even
the translated file for the current language does not exist,
thanks to kio_help's fallback on the English version.


Diffs
-

  common/CMakeLists.txt cfdcd71 

Diff: https://git.reviewboard.kde.org/r/117963/diff/


Testing
---

Compiles; the old files from common are still installed; copie of the 
(translatable) licenses are created from the English ones.


Thanks,

Luigi Toscano

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117962: forward declare specialisation

2014-05-02 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117962/
---

Review request for KDE Frameworks, kdewin and Alexander Richardson.


Repository: kcoreaddons


Description
---

This is needed because otherwise mingw will use the inherited
specialisations for KUserId / KGroupId instead and fail with an
error that specialisation happens after instantiation.


Diffs
-

  src/lib/util/kuser.h 7b14ab2b2b31fcc3c624bba6068df6ad80b779fe 

Diff: https://git.reviewboard.kde.org/r/117962/diff/


Testing
---

mingw gcc, *nix and msvc still required


Thanks,

Patrick Spendrin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117961: remove several warnings on mingw

2014-05-02 Thread Patrick Spendrin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117961/
---

Review request for KDE Frameworks, kdewin and Alexander Richardson.


Repository: kcoreaddons


Description
---

remove several warnings on mingw


Diffs
-

  autotests/kformattest.cpp 7479bb2c2f9730f70831a965f7a03b9e30dd442c 
  autotests/kprocesstest.cpp 3dbaa9ab3cb238618cae54aed3797c69997aea66 
  autotests/kusertest.cpp 4ee9e86613bbf7044ac025b128449afeeac00940 
  src/lib/util/kuser_win.cpp 2018a129f3ef9911df0c3f071d1617cac3026168 

Diff: https://git.reviewboard.kde.org/r/117961/diff/


Testing
---

mingw only, needs testing on *nix and on msvc


Thanks,

Patrick Spendrin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117911: ECMGeneratePriFile: prefer KF5_INCLUDE_INSTALL_DIR

2014-05-02 Thread David Faure


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117911/
---

(Updated May 2, 2014, 9:15 p.m.)


Status
--

This change has been discarded.


Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Alex 
Merry.


Repository: extra-cmake-modules


Description
---

ECMGeneratePriFile: prefer KF5_INCLUDE_INSTALL_DIR

This adjusts the generated .pri files so that they have the right include
dir for frameworks. Testcase: karchive/examples/helloworld

The alternative is to patch all frameworks...


Diffs
-

  modules/ECMGeneratePriFile.cmake 34001d6cc2791d9b813d9500c392b68a73d9661b 

Diff: https://git.reviewboard.kde.org/r/117911/diff/


Testing
---

cd karchive/examples/helloworld ; qmake


Thanks,

David Faure

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117805: Introduce kdoctools_install()

2014-05-02 Thread Aurélien Gâteau


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117805/
---

(Updated May 2, 2014, 8:01 p.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation, KDE Frameworks and Luigi Toscano.


Repository: kdoctools


Description
---

This function makes it easy to install all .docbook of a framework. It is 
similar to ki18n_install() (see https://git.reviewboard.kde.org/r/117804/ ).

The primary user of this function is the build system of the framework 
tarballs. The tarballs will ship with a po/ directory which follows the 
structure expected by kdoctools_install(). The only necessary change is to add 
the following lines to the root CMakeLists.txt file:

if (IS_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/po")
kdoctools_install(po)
endif()

Since the code checks for the presence of a po/ directory, it can be committed 
in the framework repository (no need for the tarball release scripts to alter 
the CMake files), making it easier for developers to reproduce the situation of 
a released tarball by creating/copying a po/ directory in their working copy.


Diffs
-

  KF5DocToolsMacros.cmake c4e33bd 

Diff: https://git.reviewboard.kde.org/r/117805/diff/


Testing
---

Tested with fake content on kiconthemes, with and without the po dir.


Thanks,

Aurélien Gâteau

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117805: Introduce kdoctools_install()

2014-05-02 Thread Commit Hook


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117805/#review57159
---


This review has been submitted with commit 
8930b2fd333610133654d58c7baf5e0b03d2d72d by Aurélien Gâteau to branch master.

- Commit Hook


On April 30, 2014, 12:44 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117805/
> ---
> 
> (Updated April 30, 2014, 12:44 p.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> This function makes it easy to install all .docbook of a framework. It is 
> similar to ki18n_install() (see https://git.reviewboard.kde.org/r/117804/ ).
> 
> The primary user of this function is the build system of the framework 
> tarballs. The tarballs will ship with a po/ directory which follows the 
> structure expected by kdoctools_install(). The only necessary change is to 
> add the following lines to the root CMakeLists.txt file:
> 
> if (IS_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/po")
> kdoctools_install(po)
> endif()
> 
> Since the code checks for the presence of a po/ directory, it can be 
> committed in the framework repository (no need for the tarball release 
> scripts to alter the CMake files), making it easier for developers to 
> reproduce the situation of a released tarball by creating/copying a po/ 
> directory in their working copy.
> 
> 
> Diffs
> -
> 
>   KF5DocToolsMacros.cmake c4e33bd 
> 
> Diff: https://git.reviewboard.kde.org/r/117805/diff/
> 
> 
> Testing
> ---
> 
> Tested with fake content on kiconthemes, with and without the po dir.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : kpty_master_qt5 #32

2014-05-02 Thread KDE CI System

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117952: Fix KIO::suggestName() for the case of leading dots, and no other dot.

2014-05-02 Thread David Faure


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117952/
---

(Updated May 2, 2014, 4:30 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Kevin Funk.


Repository: kio


Description
---

Fix KIO::suggestName() for the case of leading dots, and no other dot.

We don't want to change the extension in that case.

With a unittest for that method, finally.


Diffs
-

  autotests/globaltest.h b955329cf7d5841d9f9c1230e41d1261a268420e 
  autotests/globaltest.cpp 4367e53b44e077c566316081e21f429ac15b74a0 
  src/core/global.cpp b6f523d66ef5b9308f615c485d6dcf3069b26ace 

Diff: https://git.reviewboard.kde.org/r/117952/diff/


Testing
---


Thanks,

David Faure

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Hitting assertion in kio-trash (KF5KIOCore)

2014-05-02 Thread Kevin Funk

On Wednesday 16 April 2014 21:31:01 Kevin Funk wrote:
> Hey,
> 
> While running unit tests from kdevplatform I hit the following assert in
> trash/trashimpl.cpp (from workspace/kio-extras)
> 
> Output of the unit test (which attempts to trash some folders):
> trying to create  "/home/krf/.local/share/Trash/info/.trashinfo"
> trying to create  "/home/krf/.local/share/Trash/info/.trashinfo 1"
> trying to create  "/home/krf/.local/share/Trash/info/.trashinfo 2"
> trying to create  "/home/krf/.local/share/Trash/info/.trashinfo 3"
> trying to create  "/home/krf/.local/share/Trash/info/.trashinfo 4"
> trying to create  "/home/krf/.local/share/Trash/info/.trashinfo 5"
> trying to create  "/home/krf/.local/share/Trash/info/.trashinfo 6"
> ASSERT: "fileId.endsWith( QLatin1String(".trashinfo") )" in file
> /home/krf/devel/src/kf5/kde/workspace/kio-extras/trash/trashimpl.cpp, line
> 272 kioslave: ### CRASH ## protocol = trash pid = 6144 signal = 6
> /home/krf/devel/install/kf5/lib/x86_64-linux-gnu/libKF5KIOCore.so.5(+0x8d60
> 9) [0x7fbbbfe79609]
> (...)
> 
> Looking at the code, that assert looks very suspicious. The code above the
> assert seems to generate file ids such as '.trashinfo' or '.trashinfo
> SOME_NUMBER'. In case of the latter, the assert will always be hit.
> 
> Any ideas? Did KIO::RenameDialog::suggestName change?
> 
> Reproducable with:
> ./plugins/git/tests/kdevgit-test testRemoveEmptyFolder
> 
> from kdevplatform.git.
> 
> Greets

Hey,

https://git.reviewboard.kde.org/r/117951/ fixed this, btw.

It was a porting bug (KUrl -> QUrl) within trashimpl.cpp

Greets

-- 
Kevin Funk
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117951: trash: Fix KUrl->QUrl porting bug

2014-05-02 Thread Commit Hook


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117951/#review57152
---


This review has been submitted with commit 
800b2bda194eeb0433a136a96047102c0c1d60aa by Kevin Funk to branch master.

- Commit Hook


On May 2, 2014, 4:10 p.m., Kevin Funk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117951/
> ---
> 
> (Updated May 2, 2014, 4:10 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> ---
> 
> trash: Fix KUrl->QUrl porting bug
> 
> Make sure we keep the old behavior
> 
> 
> Diffs
> -
> 
>   trash/tests/testtrash.h f35574d7a18739652545cda751aa925a40bfc5d3 
>   trash/tests/testtrash.cpp 411c7913193dbbb527edfe3601b91dd1f7af99e6 
>   trash/trashimpl.cpp 91c671332dd9545486c2086944c247e0defe8bba 
> 
> Diff: https://git.reviewboard.kde.org/r/117951/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117951: trash: Fix KUrl->QUrl porting bug

2014-05-02 Thread Kevin Funk


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117951/
---

(Updated May 2, 2014, 4:24 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Repository: kio-extras


Description
---

trash: Fix KUrl->QUrl porting bug

Make sure we keep the old behavior


Diffs
-

  trash/tests/testtrash.h f35574d7a18739652545cda751aa925a40bfc5d3 
  trash/tests/testtrash.cpp 411c7913193dbbb527edfe3601b91dd1f7af99e6 
  trash/trashimpl.cpp 91c671332dd9545486c2086944c247e0defe8bba 

Diff: https://git.reviewboard.kde.org/r/117951/diff/


Testing
---


Thanks,

Kevin Funk

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117951: trash: Fix KUrl->QUrl porting bug

2014-05-02 Thread Kevin Funk



> On May 2, 2014, 4:14 p.m., David Faure wrote:
> > I assume the test failed before the fix, right? ;-)

Yep.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117951/#review57148
---


On May 2, 2014, 4:10 p.m., Kevin Funk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117951/
> ---
> 
> (Updated May 2, 2014, 4:10 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> ---
> 
> trash: Fix KUrl->QUrl porting bug
> 
> Make sure we keep the old behavior
> 
> 
> Diffs
> -
> 
>   trash/tests/testtrash.h f35574d7a18739652545cda751aa925a40bfc5d3 
>   trash/tests/testtrash.cpp 411c7913193dbbb527edfe3601b91dd1f7af99e6 
>   trash/trashimpl.cpp 91c671332dd9545486c2086944c247e0defe8bba 
> 
> Diff: https://git.reviewboard.kde.org/r/117951/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117952: Fix KIO::suggestName() for the case of leading dots, and no other dot.

2014-05-02 Thread Kevin Funk


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117952/#review57150
---

Ship it!


LGTM

- Kevin Funk


On May 2, 2014, 4:12 p.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117952/
> ---
> 
> (Updated May 2, 2014, 4:12 p.m.)
> 
> 
> Review request for KDE Frameworks and Kevin Funk.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Fix KIO::suggestName() for the case of leading dots, and no other dot.
> 
> We don't want to change the extension in that case.
> 
> With a unittest for that method, finally.
> 
> 
> Diffs
> -
> 
>   autotests/globaltest.h b955329cf7d5841d9f9c1230e41d1261a268420e 
>   autotests/globaltest.cpp 4367e53b44e077c566316081e21f429ac15b74a0 
>   src/core/global.cpp b6f523d66ef5b9308f615c485d6dcf3069b26ace 
> 
> Diff: https://git.reviewboard.kde.org/r/117952/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117951: trash: Fix KUrl->QUrl porting bug

2014-05-02 Thread David Faure


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117951/#review57148
---

Ship it!


I assume the test failed before the fix, right? ;-)

- David Faure


On May 2, 2014, 4:10 p.m., Kevin Funk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117951/
> ---
> 
> (Updated May 2, 2014, 4:10 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> ---
> 
> trash: Fix KUrl->QUrl porting bug
> 
> Make sure we keep the old behavior
> 
> 
> Diffs
> -
> 
>   trash/tests/testtrash.h f35574d7a18739652545cda751aa925a40bfc5d3 
>   trash/tests/testtrash.cpp 411c7913193dbbb527edfe3601b91dd1f7af99e6 
>   trash/trashimpl.cpp 91c671332dd9545486c2086944c247e0defe8bba 
> 
> Diff: https://git.reviewboard.kde.org/r/117951/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117952: Fix KIO::suggestName() for the case of leading dots, and no other dot.

2014-05-02 Thread David Faure


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117952/
---

Review request for KDE Frameworks and Kevin Funk.


Repository: kio


Description
---

Fix KIO::suggestName() for the case of leading dots, and no other dot.

We don't want to change the extension in that case.

With a unittest for that method, finally.


Diffs
-

  autotests/globaltest.h b955329cf7d5841d9f9c1230e41d1261a268420e 
  autotests/globaltest.cpp 4367e53b44e077c566316081e21f429ac15b74a0 
  src/core/global.cpp b6f523d66ef5b9308f615c485d6dcf3069b26ace 

Diff: https://git.reviewboard.kde.org/r/117952/diff/


Testing
---


Thanks,

David Faure

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117951: trash: Fix KUrl->QUrl porting bug

2014-05-02 Thread Kevin Funk


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117951/
---

Review request for KDE Frameworks and David Faure.


Repository: kio-extras


Description
---

trash: Fix KUrl->QUrl porting bug

Make sure we keep the old behavior


Diffs
-

  trash/tests/testtrash.h f35574d7a18739652545cda751aa925a40bfc5d3 
  trash/tests/testtrash.cpp 411c7913193dbbb527edfe3601b91dd1f7af99e6 
  trash/trashimpl.cpp 91c671332dd9545486c2086944c247e0defe8bba 

Diff: https://git.reviewboard.kde.org/r/117951/diff/


Testing
---


Thanks,

Kevin Funk

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117946: Track screen changes in the containment when the containment is inside an applet

2014-05-02 Thread Martin Klapetek


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117946/#review57143
---

Ship it!


Looks good to me

- Martin Klapetek


On May 2, 2014, 4:42 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117946/
> ---
> 
> (Updated May 2, 2014, 4:42 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Track screen changes in the containment when the containment is inside an 
> applet
> 
> Make the system tray containment update which screen it is on when the
> system tray applet is moved.
> 
> This fixes notifications if the panel is moved between screens.
> 
> 
> Diffs
> -
> 
>   src/plasma/private/containment_p.h 24049c7 
>   src/plasma/private/containment_p.cpp 9e67382 
> 
> Diff: https://git.reviewboard.kde.org/r/117946/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117946: Track screen changes in the containment when the containment is inside an applet

2014-05-02 Thread David Edmundson


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117946/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

Track screen changes in the containment when the containment is inside an applet

Make the system tray containment update which screen it is on when the
system tray applet is moved.

This fixes notifications if the panel is moved between screens.


Diffs
-

  src/plasma/private/containment_p.h 24049c7 
  src/plasma/private/containment_p.cpp 9e67382 

Diff: https://git.reviewboard.kde.org/r/117946/diff/


Testing
---


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117944: Rewrite the PIC image format handler

2014-05-02 Thread Alex Merry


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117944/
---

Review request for KDE Frameworks.


Repository: kimageformats


Description
---

Rewrite the PIC image format handler

It now uses QDataStream to deal with endianness. It also supports
several QImageIOHandler options.

This comes with a more comprehensive test suite than the old code. Note
that the old test suite was incorrect as the old code wrote the floats
in the header out incorrectly (although no-one noticed because no
software seems to care about those values).

All the test PIC files in the test suite appear correct according to the
specification (by inspection with Okteta). Unfortunately, there is a
lack of other freely-available software that reads and writes PIC files
(the main application that uses them is proprietary), and so this is the
best I can do.


Diffs
-

  autotests/CMakeLists.txt 86c540c81b6a15f908b9435a2309d9123a6ab1d4 
  autotests/long-runs.pic PRE-CREATION 
  autotests/pic/4x4-alpha-uncompressed.pic PRE-CREATION 
  autotests/pic/4x4-alpha.pic PRE-CREATION 
  autotests/pic/4x4-alpha.png PRE-CREATION 
  autotests/pic/4x4-simple-color-uncompressed.pic PRE-CREATION 
  autotests/pic/4x4-simple-color.pic PRE-CREATION 
  autotests/pic/4x4-simple-color.png PRE-CREATION 
  autotests/pic/long-comment.pic PRE-CREATION 
  autotests/pic/long-runs.pic PRE-CREATION 
  autotests/pic/long-runs.png PRE-CREATION 
  autotests/pic/short-comment.pic PRE-CREATION 
  autotests/pictest.cpp PRE-CREATION 
  autotests/read/pic/bw.pic 552c2e8eb15e30018ae365a5994e8d8d9a9d442e 
  autotests/read/pic/bw.png e2d506bb3da276c09b8f9388dc8ad6b96f987f5e 
  autotests/read/pic/bwa.pic affc603bebdd64a1d63b5477f6c71e827405733b 
  autotests/read/pic/bwa.png a75415012846b5eead134ac502aa740c0cf1cfa7 
  autotests/read/pic/rgb.pic f8a1b9cf58589d407006a6b64eefe37b6786d6a8 
  autotests/read/pic/rgb.png 267d67841ad5f80e0f36cbf514c33d6e9cac146b 
  autotests/read/pic/rgba.pic 05fed0fccecb597d236d30fd020e681a96ea69a6 
  autotests/read/pic/rgba.png cb0cae071b4e59cd18f168bb93f824b93bab3aa8 
  autotests/write/bw.pic 552c2e8eb15e30018ae365a5994e8d8d9a9d442e 
  autotests/write/bwa.pic affc603bebdd64a1d63b5477f6c71e827405733b 
  autotests/write/rgb.pic f8a1b9cf58589d407006a6b64eefe37b6786d6a8 
  autotests/write/rgba.pic 05fed0fccecb597d236d30fd020e681a96ea69a6 
  src/imageformats/CMakeLists.txt 59472ae49e473faa7ab78db6eb9f3623fd7b6a4b 
  src/imageformats/pic.h add0a35bb205b989d4485cec83ce49c23c701ded 
  src/imageformats/pic.cpp 9d8a7ede31c5c03a699d6a76c88aeb5e3d37ac4a 
  src/imageformats/pic_read.cpp 484c63426723e04e5c7e96ae5355ccceccab03f4 
  src/imageformats/pic_rw.h 2cc958927403de57049bbd7cb3200f0b7489da3c 
  src/imageformats/pic_write.cpp 0632eebd507e58e480856b53e71c24afc543de26 

Diff: https://git.reviewboard.kde.org/r/117944/diff/


Testing
---

Autotests now all pass.


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117842: Add/fix message extraction for repo frameworks/kconfig

2014-05-02 Thread Commit Hook


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117842/#review57135
---


This review has been submitted with commit 
42930de3abb945f456d3a6d36ef0b07a91310b03 by Burkhard Lück to branch master.

- Commit Hook


On April 28, 2014, 3:02 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117842/
> ---
> 
> (Updated April 28, 2014, 3:02 p.m.)
> 
> 
> Review request for KDE Frameworks and Aurélien Gâteau.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> kconfig has kreadconfig/Messages.sh using gettext for extraction,
> but that fails to generate a catalog, because kreadconfig/kwriteconfig 
> were switched to Qt translations
> 
> Add a src/Messages.sh which extracts also all messages other missing string 
> in this repo
> 
> Loading the catalog (via ecm_create_qm_loader?) is still missing.
> 
> 
> Diffs
> -
> 
>   src/Messages.sh PRE-CREATION 
>   src/kreadconfig/Messages.sh 55b886c 
> 
> Diff: https://git.reviewboard.kde.org/r/117842/diff/
> 
> 
> Testing
> ---
> 
> Using l10-kf5/scripts/extract_messages generates a pot file with all strings.
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117842: Add/fix message extraction for repo frameworks/kconfig

2014-05-02 Thread Burkhard Lück


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117842/
---

(Updated May 2, 2014, 1:59 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Aurélien Gâteau.


Repository: kconfig


Description
---

kconfig has kreadconfig/Messages.sh using gettext for extraction,
but that fails to generate a catalog, because kreadconfig/kwriteconfig 
were switched to Qt translations

Add a src/Messages.sh which extracts also all messages other missing string in 
this repo

Loading the catalog (via ecm_create_qm_loader?) is still missing.


Diffs
-

  src/Messages.sh PRE-CREATION 
  src/kreadconfig/Messages.sh 55b886c 

Diff: https://git.reviewboard.kde.org/r/117842/diff/


Testing
---

Using l10-kf5/scripts/extract_messages generates a pot file with all strings.


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117935: Also set KF5_LIBEXEC_INSTALL_DIR on Windows

2014-05-02 Thread Alexander Richardson


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117935/
---

(Updated May 2, 2014, 1:17 p.m.)


Status
--

This change has been marked as submitted.


Review request for Build System, Extra Cmake Modules and KDE Frameworks.


Repository: extra-cmake-modules


Description
---

Also set KF5_LIBEXEC_INSTALL_DIR on Windows


Diffs
-

  kde-modules/KDEInstallDirs.cmake 6de73e643429e82eb3f98fffc865c51b1f370521 

Diff: https://git.reviewboard.kde.org/r/117935/diff/


Testing
---


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117935: Also set KF5_LIBEXEC_INSTALL_DIR on Windows

2014-05-02 Thread Commit Hook


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117935/#review57130
---


This review has been submitted with commit 
f8b5cf4773c8f860894bc43c48d8bdac8ac07cad by Alex Richardson to branch master.

- Commit Hook


On May 1, 2014, 9:16 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117935/
> ---
> 
> (Updated May 1, 2014, 9:16 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Also set KF5_LIBEXEC_INSTALL_DIR on Windows
> 
> 
> Diffs
> -
> 
>   kde-modules/KDEInstallDirs.cmake 6de73e643429e82eb3f98fffc865c51b1f370521 
> 
> Diff: https://git.reviewboard.kde.org/r/117935/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117940: rename country entry.desktop to country.desktop for ease and install into /usr/share/kf5

2014-05-02 Thread Jonathan Riddell


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117940/
---

(Updated May 2, 2014, 1:04 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and John Layt.


Repository: kdelibs4support


Description
---

rename country entry.desktop to country.desktop for ease and install into 
/usr/share/kf5
this also fixes co-installability due to region .desktop files e.g. 
/usr/share/locale/l10n/caribbean.desktop

if accepted this also needs an update to 
http://lxr.kde.org/source/kde/workspace/plasma-desktop/kcms/locale/kcmlocale.cpp?v=kf5-qt5
 (and .h)


Diffs
-

  autotests/klocaletimeformattest.cpp c77adc8d31b949123ce4e858995b673050afa481 
  src/kdecore/klocale_kde.cpp 02758ffb4b8727a0dd6e3453a892e625706c7429 
  src/l10n/C/entry.desktop  
  src/l10n/CMakeLists.txt beed0a6b22258cd25d8083f2433175c22b1bb581 
  src/l10n/ad/entry.desktop  
  src/l10n/ae/entry.desktop  
  src/l10n/af/entry.desktop  
  src/l10n/ag/entry.desktop  
  src/l10n/ai/entry.desktop  
  src/l10n/al/entry.desktop  
  src/l10n/am/entry.desktop  
  src/l10n/an/entry.desktop  
  src/l10n/ao/entry.desktop  
  src/l10n/ar/entry.desktop  
  src/l10n/as/entry.desktop  
  src/l10n/at/entry.desktop  
  src/l10n/au/entry.desktop  
  src/l10n/aw/entry.desktop  
  src/l10n/ax/entry.desktop  
  src/l10n/az/entry.desktop  
  src/l10n/ba/entry.desktop  
  src/l10n/bb/entry.desktop  
  src/l10n/bd/entry.desktop  
  src/l10n/be/entry.desktop  
  src/l10n/bf/entry.desktop  
  src/l10n/bg/entry.desktop  
  src/l10n/bh/entry.desktop  
  src/l10n/bi/entry.desktop  
  src/l10n/bj/entry.desktop  
  src/l10n/bl/entry.desktop  
  src/l10n/bm/entry.desktop  
  src/l10n/bn/entry.desktop  
  src/l10n/bo/entry.desktop  
  src/l10n/br/entry.desktop  
  src/l10n/bs/entry.desktop  
  src/l10n/bt/entry.desktop  
  src/l10n/bw/entry.desktop  
  src/l10n/by/entry.desktop  
  src/l10n/bz/entry.desktop  
  src/l10n/ca/entry.desktop  
  src/l10n/cc/entry.desktop  
  src/l10n/cd/entry.desktop  
  src/l10n/cf/entry.desktop  
  src/l10n/cg/entry.desktop  
  src/l10n/ch/entry.desktop  
  src/l10n/ci/entry.desktop  
  src/l10n/ck/entry.desktop  
  src/l10n/cl/entry.desktop  
  src/l10n/cm/entry.desktop  
  src/l10n/cn/entry.desktop  
  src/l10n/co/entry.desktop  
  src/l10n/cr/entry.desktop  
  src/l10n/cu/entry.desktop  
  src/l10n/cv/entry.desktop  
  src/l10n/cx/entry.desktop  
  src/l10n/cy/entry.desktop  
  src/l10n/cz/entry.desktop  
  src/l10n/de/entry.desktop  
  src/l10n/dj/entry.desktop  
  src/l10n/dk/entry.desktop  
  src/l10n/dm/entry.desktop  
  src/l10n/do/entry.desktop  
  src/l10n/dz/entry.desktop  
  src/l10n/ec/entry.desktop  
  src/l10n/ee/entry.desktop  
  src/l10n/eg/entry.desktop  
  src/l10n/eh/entry.desktop  
  src/l10n/er/entry.desktop  
  src/l10n/es/entry.desktop  
  src/l10n/et/entry.desktop  
  src/l10n/fi/entry.desktop  
  src/l10n/fj/entry.desktop  
  src/l10n/fk/entry.desktop  
  src/l10n/fm/entry.desktop  
  src/l10n/fo/entry.desktop  
  src/l10n/fr/entry.desktop  
  src/l10n/ga/entry.desktop  
  src/l10n/gb/entry.desktop  
  src/l10n/gd/entry.desktop  
  src/l10n/ge/entry.desktop  
  src/l10n/gf/entry.desktop  
  src/l10n/gg/entry.desktop  
  src/l10n/gh/entry.desktop  
  src/l10n/gi/entry.desktop  
  src/l10n/gl/entry.desktop  
  src/l10n/gm/entry.desktop  
  src/l10n/gn/entry.desktop  
  src/l10n/gp/entry.desktop  
  src/l10n/gq/entry.desktop  
  src/l10n/gr/entry.desktop  
  src/l10n/gt/entry.desktop  
  src/l10n/gu/entry.desktop  
  src/l10n/gw/entry.desktop  
  src/l10n/gy/entry.desktop  
  src/l10n/hk/entry.desktop  
  src/l10n/hn/entry.desktop  
  src/l10n/hr/entry.desktop  
  src/l10n/ht/entry.desktop  
  src/l10n/hu/entry.desktop  
  src/l10n/id/entry.desktop  
  src/l10n/ie/entry.desktop  
  src/l10n/il/entry.desktop  
  src/l10n/im/entry.desktop  
  src/l10n/in/entry.desktop  
  src/l10n/iq/entry.desktop  
  src/l10n/ir/entry.desktop  
  src/l10n/is/entry.desktop  
  src/l10n/it/entry.desktop  
  src/l10n/je/entry.desktop  
  src/l10n/jm/entry.desktop  
  src/l10n/jo/entry.desktop  
  src/l10n/jp/entry.desktop  
  src/l10n/ke/entry.desktop  
  src/l10n/kg/entry.desktop  
  src/l10n/kh/entry.desktop  
  src/l10n/ki/entry.desktop  
  src/l10n/km/entry.desktop  
  src/l10n/kn/entry.desktop  
  src/l10n/kp/entry.desktop  
  src/l10n/kr/entry.desktop  
  src/l10n/kw/entry.desktop  
  src/l10n/ky/entry.desktop  
  src/l10n/kz/entry.desktop  
  src/l10n/la/entry.desktop  
  src/l10n/lb/entry.desktop  
  src/l10n/lc/entry.desktop  
  src/l10n/li/entry.desktop  
  src/l10n/lk/entry.desktop  
  src/l10n/lr/entry.desktop  
  src/l10n/ls/entry.desktop  
  src/l10n/lt/entry.desktop  
  src/l10n/lu/entry.desktop  
  src/l10n/lv/entry.desktop  
  src/l10n/ly/entry.desktop  
  src/l10n/ma/entry.desktop  
  src/l10n/mc/entry.desktop  
  src/l10n/

Re: Review Request 117940: rename country entry.desktop to country.desktop for ease and install into /usr/share/kf5

2014-05-02 Thread Commit Hook


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117940/#review57127
---


This review has been submitted with commit 
e26337f1b1ef0e378db3985589a0e8cd1fedd978 by Jonathan Riddell to branch master.

- Commit Hook


On May 2, 2014, 12:50 p.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117940/
> ---
> 
> (Updated May 2, 2014, 12:50 p.m.)
> 
> 
> Review request for KDE Frameworks and John Layt.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> ---
> 
> rename country entry.desktop to country.desktop for ease and install into 
> /usr/share/kf5
> this also fixes co-installability due to region .desktop files e.g. 
> /usr/share/locale/l10n/caribbean.desktop
> 
> if accepted this also needs an update to 
> http://lxr.kde.org/source/kde/workspace/plasma-desktop/kcms/locale/kcmlocale.cpp?v=kf5-qt5
>  (and .h)
> 
> 
> Diffs
> -
> 
>   autotests/klocaletimeformattest.cpp 
> c77adc8d31b949123ce4e858995b673050afa481 
>   src/kdecore/klocale_kde.cpp 02758ffb4b8727a0dd6e3453a892e625706c7429 
>   src/l10n/C/entry.desktop  
>   src/l10n/CMakeLists.txt beed0a6b22258cd25d8083f2433175c22b1bb581 
>   src/l10n/ad/entry.desktop  
>   src/l10n/ae/entry.desktop  
>   src/l10n/af/entry.desktop  
>   src/l10n/ag/entry.desktop  
>   src/l10n/ai/entry.desktop  
>   src/l10n/al/entry.desktop  
>   src/l10n/am/entry.desktop  
>   src/l10n/an/entry.desktop  
>   src/l10n/ao/entry.desktop  
>   src/l10n/ar/entry.desktop  
>   src/l10n/as/entry.desktop  
>   src/l10n/at/entry.desktop  
>   src/l10n/au/entry.desktop  
>   src/l10n/aw/entry.desktop  
>   src/l10n/ax/entry.desktop  
>   src/l10n/az/entry.desktop  
>   src/l10n/ba/entry.desktop  
>   src/l10n/bb/entry.desktop  
>   src/l10n/bd/entry.desktop  
>   src/l10n/be/entry.desktop  
>   src/l10n/bf/entry.desktop  
>   src/l10n/bg/entry.desktop  
>   src/l10n/bh/entry.desktop  
>   src/l10n/bi/entry.desktop  
>   src/l10n/bj/entry.desktop  
>   src/l10n/bl/entry.desktop  
>   src/l10n/bm/entry.desktop  
>   src/l10n/bn/entry.desktop  
>   src/l10n/bo/entry.desktop  
>   src/l10n/br/entry.desktop  
>   src/l10n/bs/entry.desktop  
>   src/l10n/bt/entry.desktop  
>   src/l10n/bw/entry.desktop  
>   src/l10n/by/entry.desktop  
>   src/l10n/bz/entry.desktop  
>   src/l10n/ca/entry.desktop  
>   src/l10n/cc/entry.desktop  
>   src/l10n/cd/entry.desktop  
>   src/l10n/cf/entry.desktop  
>   src/l10n/cg/entry.desktop  
>   src/l10n/ch/entry.desktop  
>   src/l10n/ci/entry.desktop  
>   src/l10n/ck/entry.desktop  
>   src/l10n/cl/entry.desktop  
>   src/l10n/cm/entry.desktop  
>   src/l10n/cn/entry.desktop  
>   src/l10n/co/entry.desktop  
>   src/l10n/cr/entry.desktop  
>   src/l10n/cu/entry.desktop  
>   src/l10n/cv/entry.desktop  
>   src/l10n/cx/entry.desktop  
>   src/l10n/cy/entry.desktop  
>   src/l10n/cz/entry.desktop  
>   src/l10n/de/entry.desktop  
>   src/l10n/dj/entry.desktop  
>   src/l10n/dk/entry.desktop  
>   src/l10n/dm/entry.desktop  
>   src/l10n/do/entry.desktop  
>   src/l10n/dz/entry.desktop  
>   src/l10n/ec/entry.desktop  
>   src/l10n/ee/entry.desktop  
>   src/l10n/eg/entry.desktop  
>   src/l10n/eh/entry.desktop  
>   src/l10n/er/entry.desktop  
>   src/l10n/es/entry.desktop  
>   src/l10n/et/entry.desktop  
>   src/l10n/fi/entry.desktop  
>   src/l10n/fj/entry.desktop  
>   src/l10n/fk/entry.desktop  
>   src/l10n/fm/entry.desktop  
>   src/l10n/fo/entry.desktop  
>   src/l10n/fr/entry.desktop  
>   src/l10n/ga/entry.desktop  
>   src/l10n/gb/entry.desktop  
>   src/l10n/gd/entry.desktop  
>   src/l10n/ge/entry.desktop  
>   src/l10n/gf/entry.desktop  
>   src/l10n/gg/entry.desktop  
>   src/l10n/gh/entry.desktop  
>   src/l10n/gi/entry.desktop  
>   src/l10n/gl/entry.desktop  
>   src/l10n/gm/entry.desktop  
>   src/l10n/gn/entry.desktop  
>   src/l10n/gp/entry.desktop  
>   src/l10n/gq/entry.desktop  
>   src/l10n/gr/entry.desktop  
>   src/l10n/gt/entry.desktop  
>   src/l10n/gu/entry.desktop  
>   src/l10n/gw/entry.desktop  
>   src/l10n/gy/entry.desktop  
>   src/l10n/hk/entry.desktop  
>   src/l10n/hn/entry.desktop  
>   src/l10n/hr/entry.desktop  
>   src/l10n/ht/entry.desktop  
>   src/l10n/hu/entry.desktop  
>   src/l10n/id/entry.desktop  
>   src/l10n/ie/entry.desktop  
>   src/l10n/il/entry.desktop  
>   src/l10n/im/entry.desktop  
>   src/l10n/in/entry.desktop  
>   src/l10n/iq/entry.desktop  
>   src/l10n/ir/entry.desktop  
>   src/l10n/is/entry.desktop  
>   src/l10n/it/entry.desktop  
>   src/l10n/je/entry.desktop  
>   src/l10n/jm/entry.desktop  
>   src/l10n/jo/entry.desktop  
>   src/l10n/jp/entry.desktop  
>   src/l10n/ke/entry.desktop  
>   src/l10n/kg/entry.desktop  
>   src

Re: Review Request 117940: rename country entry.desktop to country.desktop for ease and install into /usr/share/kf5

2014-05-02 Thread David Faure


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117940/#review57125
---

Ship it!


Yay for non-confusing filenames :-)

- David Faure


On May 2, 2014, 12:50 p.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117940/
> ---
> 
> (Updated May 2, 2014, 12:50 p.m.)
> 
> 
> Review request for KDE Frameworks and John Layt.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> ---
> 
> rename country entry.desktop to country.desktop for ease and install into 
> /usr/share/kf5
> this also fixes co-installability due to region .desktop files e.g. 
> /usr/share/locale/l10n/caribbean.desktop
> 
> if accepted this also needs an update to 
> http://lxr.kde.org/source/kde/workspace/plasma-desktop/kcms/locale/kcmlocale.cpp?v=kf5-qt5
>  (and .h)
> 
> 
> Diffs
> -
> 
>   autotests/klocaletimeformattest.cpp 
> c77adc8d31b949123ce4e858995b673050afa481 
>   src/kdecore/klocale_kde.cpp 02758ffb4b8727a0dd6e3453a892e625706c7429 
>   src/l10n/C/entry.desktop  
>   src/l10n/CMakeLists.txt beed0a6b22258cd25d8083f2433175c22b1bb581 
>   src/l10n/ad/entry.desktop  
>   src/l10n/ae/entry.desktop  
>   src/l10n/af/entry.desktop  
>   src/l10n/ag/entry.desktop  
>   src/l10n/ai/entry.desktop  
>   src/l10n/al/entry.desktop  
>   src/l10n/am/entry.desktop  
>   src/l10n/an/entry.desktop  
>   src/l10n/ao/entry.desktop  
>   src/l10n/ar/entry.desktop  
>   src/l10n/as/entry.desktop  
>   src/l10n/at/entry.desktop  
>   src/l10n/au/entry.desktop  
>   src/l10n/aw/entry.desktop  
>   src/l10n/ax/entry.desktop  
>   src/l10n/az/entry.desktop  
>   src/l10n/ba/entry.desktop  
>   src/l10n/bb/entry.desktop  
>   src/l10n/bd/entry.desktop  
>   src/l10n/be/entry.desktop  
>   src/l10n/bf/entry.desktop  
>   src/l10n/bg/entry.desktop  
>   src/l10n/bh/entry.desktop  
>   src/l10n/bi/entry.desktop  
>   src/l10n/bj/entry.desktop  
>   src/l10n/bl/entry.desktop  
>   src/l10n/bm/entry.desktop  
>   src/l10n/bn/entry.desktop  
>   src/l10n/bo/entry.desktop  
>   src/l10n/br/entry.desktop  
>   src/l10n/bs/entry.desktop  
>   src/l10n/bt/entry.desktop  
>   src/l10n/bw/entry.desktop  
>   src/l10n/by/entry.desktop  
>   src/l10n/bz/entry.desktop  
>   src/l10n/ca/entry.desktop  
>   src/l10n/cc/entry.desktop  
>   src/l10n/cd/entry.desktop  
>   src/l10n/cf/entry.desktop  
>   src/l10n/cg/entry.desktop  
>   src/l10n/ch/entry.desktop  
>   src/l10n/ci/entry.desktop  
>   src/l10n/ck/entry.desktop  
>   src/l10n/cl/entry.desktop  
>   src/l10n/cm/entry.desktop  
>   src/l10n/cn/entry.desktop  
>   src/l10n/co/entry.desktop  
>   src/l10n/cr/entry.desktop  
>   src/l10n/cu/entry.desktop  
>   src/l10n/cv/entry.desktop  
>   src/l10n/cx/entry.desktop  
>   src/l10n/cy/entry.desktop  
>   src/l10n/cz/entry.desktop  
>   src/l10n/de/entry.desktop  
>   src/l10n/dj/entry.desktop  
>   src/l10n/dk/entry.desktop  
>   src/l10n/dm/entry.desktop  
>   src/l10n/do/entry.desktop  
>   src/l10n/dz/entry.desktop  
>   src/l10n/ec/entry.desktop  
>   src/l10n/ee/entry.desktop  
>   src/l10n/eg/entry.desktop  
>   src/l10n/eh/entry.desktop  
>   src/l10n/er/entry.desktop  
>   src/l10n/es/entry.desktop  
>   src/l10n/et/entry.desktop  
>   src/l10n/fi/entry.desktop  
>   src/l10n/fj/entry.desktop  
>   src/l10n/fk/entry.desktop  
>   src/l10n/fm/entry.desktop  
>   src/l10n/fo/entry.desktop  
>   src/l10n/fr/entry.desktop  
>   src/l10n/ga/entry.desktop  
>   src/l10n/gb/entry.desktop  
>   src/l10n/gd/entry.desktop  
>   src/l10n/ge/entry.desktop  
>   src/l10n/gf/entry.desktop  
>   src/l10n/gg/entry.desktop  
>   src/l10n/gh/entry.desktop  
>   src/l10n/gi/entry.desktop  
>   src/l10n/gl/entry.desktop  
>   src/l10n/gm/entry.desktop  
>   src/l10n/gn/entry.desktop  
>   src/l10n/gp/entry.desktop  
>   src/l10n/gq/entry.desktop  
>   src/l10n/gr/entry.desktop  
>   src/l10n/gt/entry.desktop  
>   src/l10n/gu/entry.desktop  
>   src/l10n/gw/entry.desktop  
>   src/l10n/gy/entry.desktop  
>   src/l10n/hk/entry.desktop  
>   src/l10n/hn/entry.desktop  
>   src/l10n/hr/entry.desktop  
>   src/l10n/ht/entry.desktop  
>   src/l10n/hu/entry.desktop  
>   src/l10n/id/entry.desktop  
>   src/l10n/ie/entry.desktop  
>   src/l10n/il/entry.desktop  
>   src/l10n/im/entry.desktop  
>   src/l10n/in/entry.desktop  
>   src/l10n/iq/entry.desktop  
>   src/l10n/ir/entry.desktop  
>   src/l10n/is/entry.desktop  
>   src/l10n/it/entry.desktop  
>   src/l10n/je/entry.desktop  
>   src/l10n/jm/entry.desktop  
>   src/l10n/jo/entry.desktop  
>   src/l10n/jp/entry.desktop  
>   src/l10n/ke/entry.desktop  
>   src/l10n/kg/entry.desktop  
>   src/l10n/kh/entry.desktop  
>   src/l10n/ki/entry.desktop  
>   src/l10n/km/entr

Re: Review Request 117940: rename country entry.desktop to country.desktop for ease and install into /usr/share/kf5

2014-05-02 Thread Jonathan Riddell


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117940/
---

(Updated May 2, 2014, 12:50 p.m.)


Review request for KDE Frameworks and John Layt.


Repository: kdelibs4support


Description (updated)
---

rename country entry.desktop to country.desktop for ease and install into 
/usr/share/kf5
this also fixes co-installability due to region .desktop files e.g. 
/usr/share/locale/l10n/caribbean.desktop

if accepted this also needs an update to 
http://lxr.kde.org/source/kde/workspace/plasma-desktop/kcms/locale/kcmlocale.cpp?v=kf5-qt5
 (and .h)


Diffs
-

  autotests/klocaletimeformattest.cpp c77adc8d31b949123ce4e858995b673050afa481 
  src/kdecore/klocale_kde.cpp 02758ffb4b8727a0dd6e3453a892e625706c7429 
  src/l10n/C/entry.desktop  
  src/l10n/CMakeLists.txt beed0a6b22258cd25d8083f2433175c22b1bb581 
  src/l10n/ad/entry.desktop  
  src/l10n/ae/entry.desktop  
  src/l10n/af/entry.desktop  
  src/l10n/ag/entry.desktop  
  src/l10n/ai/entry.desktop  
  src/l10n/al/entry.desktop  
  src/l10n/am/entry.desktop  
  src/l10n/an/entry.desktop  
  src/l10n/ao/entry.desktop  
  src/l10n/ar/entry.desktop  
  src/l10n/as/entry.desktop  
  src/l10n/at/entry.desktop  
  src/l10n/au/entry.desktop  
  src/l10n/aw/entry.desktop  
  src/l10n/ax/entry.desktop  
  src/l10n/az/entry.desktop  
  src/l10n/ba/entry.desktop  
  src/l10n/bb/entry.desktop  
  src/l10n/bd/entry.desktop  
  src/l10n/be/entry.desktop  
  src/l10n/bf/entry.desktop  
  src/l10n/bg/entry.desktop  
  src/l10n/bh/entry.desktop  
  src/l10n/bi/entry.desktop  
  src/l10n/bj/entry.desktop  
  src/l10n/bl/entry.desktop  
  src/l10n/bm/entry.desktop  
  src/l10n/bn/entry.desktop  
  src/l10n/bo/entry.desktop  
  src/l10n/br/entry.desktop  
  src/l10n/bs/entry.desktop  
  src/l10n/bt/entry.desktop  
  src/l10n/bw/entry.desktop  
  src/l10n/by/entry.desktop  
  src/l10n/bz/entry.desktop  
  src/l10n/ca/entry.desktop  
  src/l10n/cc/entry.desktop  
  src/l10n/cd/entry.desktop  
  src/l10n/cf/entry.desktop  
  src/l10n/cg/entry.desktop  
  src/l10n/ch/entry.desktop  
  src/l10n/ci/entry.desktop  
  src/l10n/ck/entry.desktop  
  src/l10n/cl/entry.desktop  
  src/l10n/cm/entry.desktop  
  src/l10n/cn/entry.desktop  
  src/l10n/co/entry.desktop  
  src/l10n/cr/entry.desktop  
  src/l10n/cu/entry.desktop  
  src/l10n/cv/entry.desktop  
  src/l10n/cx/entry.desktop  
  src/l10n/cy/entry.desktop  
  src/l10n/cz/entry.desktop  
  src/l10n/de/entry.desktop  
  src/l10n/dj/entry.desktop  
  src/l10n/dk/entry.desktop  
  src/l10n/dm/entry.desktop  
  src/l10n/do/entry.desktop  
  src/l10n/dz/entry.desktop  
  src/l10n/ec/entry.desktop  
  src/l10n/ee/entry.desktop  
  src/l10n/eg/entry.desktop  
  src/l10n/eh/entry.desktop  
  src/l10n/er/entry.desktop  
  src/l10n/es/entry.desktop  
  src/l10n/et/entry.desktop  
  src/l10n/fi/entry.desktop  
  src/l10n/fj/entry.desktop  
  src/l10n/fk/entry.desktop  
  src/l10n/fm/entry.desktop  
  src/l10n/fo/entry.desktop  
  src/l10n/fr/entry.desktop  
  src/l10n/ga/entry.desktop  
  src/l10n/gb/entry.desktop  
  src/l10n/gd/entry.desktop  
  src/l10n/ge/entry.desktop  
  src/l10n/gf/entry.desktop  
  src/l10n/gg/entry.desktop  
  src/l10n/gh/entry.desktop  
  src/l10n/gi/entry.desktop  
  src/l10n/gl/entry.desktop  
  src/l10n/gm/entry.desktop  
  src/l10n/gn/entry.desktop  
  src/l10n/gp/entry.desktop  
  src/l10n/gq/entry.desktop  
  src/l10n/gr/entry.desktop  
  src/l10n/gt/entry.desktop  
  src/l10n/gu/entry.desktop  
  src/l10n/gw/entry.desktop  
  src/l10n/gy/entry.desktop  
  src/l10n/hk/entry.desktop  
  src/l10n/hn/entry.desktop  
  src/l10n/hr/entry.desktop  
  src/l10n/ht/entry.desktop  
  src/l10n/hu/entry.desktop  
  src/l10n/id/entry.desktop  
  src/l10n/ie/entry.desktop  
  src/l10n/il/entry.desktop  
  src/l10n/im/entry.desktop  
  src/l10n/in/entry.desktop  
  src/l10n/iq/entry.desktop  
  src/l10n/ir/entry.desktop  
  src/l10n/is/entry.desktop  
  src/l10n/it/entry.desktop  
  src/l10n/je/entry.desktop  
  src/l10n/jm/entry.desktop  
  src/l10n/jo/entry.desktop  
  src/l10n/jp/entry.desktop  
  src/l10n/ke/entry.desktop  
  src/l10n/kg/entry.desktop  
  src/l10n/kh/entry.desktop  
  src/l10n/ki/entry.desktop  
  src/l10n/km/entry.desktop  
  src/l10n/kn/entry.desktop  
  src/l10n/kp/entry.desktop  
  src/l10n/kr/entry.desktop  
  src/l10n/kw/entry.desktop  
  src/l10n/ky/entry.desktop  
  src/l10n/kz/entry.desktop  
  src/l10n/la/entry.desktop  
  src/l10n/lb/entry.desktop  
  src/l10n/lc/entry.desktop  
  src/l10n/li/entry.desktop  
  src/l10n/lk/entry.desktop  
  src/l10n/lr/entry.desktop  
  src/l10n/ls/entry.desktop  
  src/l10n/lt/entry.desktop  
  src/l10n/lu/entry.desktop  
  src/l10n/lv/entry.desktop  
  src/l10n/ly/entry.desktop  
  src/l10n/ma/entry.desktop  
  src/l10n/mc/entry.desktop  
  src/l10n/md/entry.desktop  
  src/l10n/me/entry.desktop

Review Request 117940: rename country entry.desktop to country.desktop for ease and install into /usr/share/kf5

2014-05-02 Thread Jonathan Riddell


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117940/
---

Review request for KDE Frameworks and John Layt.


Repository: kdelibs4support


Description
---

rename country entry.desktop to country.desktop for ease and install into 
/usr/share/kf5
this also fixes co-installability due to region .desktop files e.g. 
/usr/share/locale/l10n/caribbean.desktop


Diffs
-

  autotests/klocaletimeformattest.cpp c77adc8d31b949123ce4e858995b673050afa481 
  src/kdecore/klocale_kde.cpp 02758ffb4b8727a0dd6e3453a892e625706c7429 
  src/l10n/C/entry.desktop  
  src/l10n/CMakeLists.txt beed0a6b22258cd25d8083f2433175c22b1bb581 
  src/l10n/ad/entry.desktop  
  src/l10n/ae/entry.desktop  
  src/l10n/af/entry.desktop  
  src/l10n/ag/entry.desktop  
  src/l10n/ai/entry.desktop  
  src/l10n/al/entry.desktop  
  src/l10n/am/entry.desktop  
  src/l10n/an/entry.desktop  
  src/l10n/ao/entry.desktop  
  src/l10n/ar/entry.desktop  
  src/l10n/as/entry.desktop  
  src/l10n/at/entry.desktop  
  src/l10n/au/entry.desktop  
  src/l10n/aw/entry.desktop  
  src/l10n/ax/entry.desktop  
  src/l10n/az/entry.desktop  
  src/l10n/ba/entry.desktop  
  src/l10n/bb/entry.desktop  
  src/l10n/bd/entry.desktop  
  src/l10n/be/entry.desktop  
  src/l10n/bf/entry.desktop  
  src/l10n/bg/entry.desktop  
  src/l10n/bh/entry.desktop  
  src/l10n/bi/entry.desktop  
  src/l10n/bj/entry.desktop  
  src/l10n/bl/entry.desktop  
  src/l10n/bm/entry.desktop  
  src/l10n/bn/entry.desktop  
  src/l10n/bo/entry.desktop  
  src/l10n/br/entry.desktop  
  src/l10n/bs/entry.desktop  
  src/l10n/bt/entry.desktop  
  src/l10n/bw/entry.desktop  
  src/l10n/by/entry.desktop  
  src/l10n/bz/entry.desktop  
  src/l10n/ca/entry.desktop  
  src/l10n/cc/entry.desktop  
  src/l10n/cd/entry.desktop  
  src/l10n/cf/entry.desktop  
  src/l10n/cg/entry.desktop  
  src/l10n/ch/entry.desktop  
  src/l10n/ci/entry.desktop  
  src/l10n/ck/entry.desktop  
  src/l10n/cl/entry.desktop  
  src/l10n/cm/entry.desktop  
  src/l10n/cn/entry.desktop  
  src/l10n/co/entry.desktop  
  src/l10n/cr/entry.desktop  
  src/l10n/cu/entry.desktop  
  src/l10n/cv/entry.desktop  
  src/l10n/cx/entry.desktop  
  src/l10n/cy/entry.desktop  
  src/l10n/cz/entry.desktop  
  src/l10n/de/entry.desktop  
  src/l10n/dj/entry.desktop  
  src/l10n/dk/entry.desktop  
  src/l10n/dm/entry.desktop  
  src/l10n/do/entry.desktop  
  src/l10n/dz/entry.desktop  
  src/l10n/ec/entry.desktop  
  src/l10n/ee/entry.desktop  
  src/l10n/eg/entry.desktop  
  src/l10n/eh/entry.desktop  
  src/l10n/er/entry.desktop  
  src/l10n/es/entry.desktop  
  src/l10n/et/entry.desktop  
  src/l10n/fi/entry.desktop  
  src/l10n/fj/entry.desktop  
  src/l10n/fk/entry.desktop  
  src/l10n/fm/entry.desktop  
  src/l10n/fo/entry.desktop  
  src/l10n/fr/entry.desktop  
  src/l10n/ga/entry.desktop  
  src/l10n/gb/entry.desktop  
  src/l10n/gd/entry.desktop  
  src/l10n/ge/entry.desktop  
  src/l10n/gf/entry.desktop  
  src/l10n/gg/entry.desktop  
  src/l10n/gh/entry.desktop  
  src/l10n/gi/entry.desktop  
  src/l10n/gl/entry.desktop  
  src/l10n/gm/entry.desktop  
  src/l10n/gn/entry.desktop  
  src/l10n/gp/entry.desktop  
  src/l10n/gq/entry.desktop  
  src/l10n/gr/entry.desktop  
  src/l10n/gt/entry.desktop  
  src/l10n/gu/entry.desktop  
  src/l10n/gw/entry.desktop  
  src/l10n/gy/entry.desktop  
  src/l10n/hk/entry.desktop  
  src/l10n/hn/entry.desktop  
  src/l10n/hr/entry.desktop  
  src/l10n/ht/entry.desktop  
  src/l10n/hu/entry.desktop  
  src/l10n/id/entry.desktop  
  src/l10n/ie/entry.desktop  
  src/l10n/il/entry.desktop  
  src/l10n/im/entry.desktop  
  src/l10n/in/entry.desktop  
  src/l10n/iq/entry.desktop  
  src/l10n/ir/entry.desktop  
  src/l10n/is/entry.desktop  
  src/l10n/it/entry.desktop  
  src/l10n/je/entry.desktop  
  src/l10n/jm/entry.desktop  
  src/l10n/jo/entry.desktop  
  src/l10n/jp/entry.desktop  
  src/l10n/ke/entry.desktop  
  src/l10n/kg/entry.desktop  
  src/l10n/kh/entry.desktop  
  src/l10n/ki/entry.desktop  
  src/l10n/km/entry.desktop  
  src/l10n/kn/entry.desktop  
  src/l10n/kp/entry.desktop  
  src/l10n/kr/entry.desktop  
  src/l10n/kw/entry.desktop  
  src/l10n/ky/entry.desktop  
  src/l10n/kz/entry.desktop  
  src/l10n/la/entry.desktop  
  src/l10n/lb/entry.desktop  
  src/l10n/lc/entry.desktop  
  src/l10n/li/entry.desktop  
  src/l10n/lk/entry.desktop  
  src/l10n/lr/entry.desktop  
  src/l10n/ls/entry.desktop  
  src/l10n/lt/entry.desktop  
  src/l10n/lu/entry.desktop  
  src/l10n/lv/entry.desktop  
  src/l10n/ly/entry.desktop  
  src/l10n/ma/entry.desktop  
  src/l10n/mc/entry.desktop  
  src/l10n/md/entry.desktop  
  src/l10n/me/entry.desktop  
  src/l10n/mf/entry.desktop  
  src/l10n/mg/entry.desktop  
  src/l10n/mh/entry.desktop  
  src/l10n/mk/entry.desktop  
  src/l10n/ml/entry.desktop  
  src/l10n/mm/entry.desktop  
  src/l10

Re: Review Request 117935: Also set KF5_LIBEXEC_INSTALL_DIR on Windows

2014-05-02 Thread Alex Merry


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117935/#review57105
---

Ship it!


Ship It!

- Alex Merry


On May 1, 2014, 9:16 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117935/
> ---
> 
> (Updated May 1, 2014, 9:16 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Also set KF5_LIBEXEC_INSTALL_DIR on Windows
> 
> 
> Diffs
> -
> 
>   kde-modules/KDEInstallDirs.cmake 6de73e643429e82eb3f98fffc865c51b1f370521 
> 
> Diff: https://git.reviewboard.kde.org/r/117935/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117799: Clean up private slots in KCompletion

2014-05-02 Thread David Gil Oliva

Hi!

El 02/05/2014 10:19, "Luca Beltrame"  escribió:
>
> Commit Hook wrote:
>
> > 210ed36c1ae1e3ce33fbd752e460651e31d1a37d by David Gil to branch
> > clean_up_private_slots.
>
> Was this the right branch, or a mistake?
Oops! Did I create a branch? :-O

I did something wrong. I will fix it on Monday :-/

Cheers

David Gil

> --
> Luca Beltrame - KDE Forums team
> KDE Science supporter
> GPG key ID: 6E1A4E79
>
> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117823: Add ecm_install_po_files_as_qm() function

2014-05-02 Thread Aurélien Gâteau



> On May 1, 2014, 11:58 a.m., Alex Merry wrote:
> > modules/ECMPoQmTools.cmake, lines 25-27
> > 
> >
> > I wonder if it would be better to actually just have this as an extra 
> > argument. I mean, it's easy enough to make the frameworks use
> > ecm_install_po_files_as_qm(po ${LOCALE_INSTALL_DIR})
> > or
> > ecm_install_po_files_as_qm(PODIR po DESTINATION ${LOCALE_INSTALL_DIR})
> > or something like that.

I'd rather follow the "convention over configuration" approach here. This 
argument can always be added later if needed.


- Aurélien


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117823/#review57049
---


On May 2, 2014, 10:55 a.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117823/
> ---
> 
> (Updated May 2, 2014, 10:55 a.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> This patch adds a ecm_install_po_files_as_qm() function to 
> ECMCreateQmFromPoFiles.cmake. This function makes it easy to install all the 
> .po files of a Qt-translated framework.
> 
> The primary user of this function is the build system of the framework 
> tarballs. The tarballs will ship with a po/ directory which follows the 
> structure expected by ecm_install_po_files_as_qm(). The only necessary change 
> is to add the following lines to the root CMakeLists.txt file:
> 
> if (IS_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/po")
> ecm_install_po_files_as_qm(po)
> endif()
> 
> Since the code checks for the presence of a po/ directory, it can be 
> committed in the framework repository (no need for the tarball release 
> scripts to alter the CMake files), making it easier for developers to 
> reproduce the situation of a released tarball by creating/copying a po/ 
> directory in their working copy.
> 
> We need this function (or something similar) because the way we are going to 
> organize po files in the framework tarballs have changed: the current CMake 
> code expects the po files to contain files named '-.po', but 
> the final structure is going to be '/.po'.
> 
> This new function works similarly to ki18n_install() ( 
> https://git.reviewboard.kde.org/r/117804/ ) and kdoctools_install() ( 
> https://git.reviewboard.kde.org/r/117805/ )
> 
> 
> Diffs
> -
> 
>   modules/ECMCreateQmFromPoFiles.cmake 7457fc5 
>   modules/ECMPoQmTools.cmake PRE-CREATION 
>   modules/ECMQmLoader.cpp.in 2d8531f 
>   tests/CMakeLists.txt 171f44a 
>   tests/ECMPoQmToolsTest/CMakeLists.txt PRE-CREATION 
>   tests/ECMPoQmToolsTest/check_tree.cmake.in PRE-CREATION 
>   tests/ECMPoQmToolsTest/po/es/install-test.po PRE-CREATION 
>   tests/ECMPoQmToolsTest/po/fr/install-test.po PRE-CREATION 
>   tests/ECMPoQmToolsTest/test.po PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/117823/diff/
> 
> 
> Testing
> ---
> 
> Modified kbookmarks to call ecm_install_po_files_as_qm(). Works as expected.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117823: Add ecm_install_po_files_as_qm() function

2014-05-02 Thread Aurélien Gâteau


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117823/
---

(Updated May 2, 2014, 10:55 a.m.)


Review request for Build System, Extra Cmake Modules and KDE Frameworks.


Changes
---

Fixes the documentation issues. Still need to improve the unit-tests.


Repository: extra-cmake-modules


Description
---

This patch adds a ecm_install_po_files_as_qm() function to 
ECMCreateQmFromPoFiles.cmake. This function makes it easy to install all the 
.po files of a Qt-translated framework.

The primary user of this function is the build system of the framework 
tarballs. The tarballs will ship with a po/ directory which follows the 
structure expected by ecm_install_po_files_as_qm(). The only necessary change 
is to add the following lines to the root CMakeLists.txt file:

if (IS_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/po")
ecm_install_po_files_as_qm(po)
endif()

Since the code checks for the presence of a po/ directory, it can be committed 
in the framework repository (no need for the tarball release scripts to alter 
the CMake files), making it easier for developers to reproduce the situation of 
a released tarball by creating/copying a po/ directory in their working copy.

We need this function (or something similar) because the way we are going to 
organize po files in the framework tarballs have changed: the current CMake 
code expects the po files to contain files named '-.po', but the 
final structure is going to be '/.po'.

This new function works similarly to ki18n_install() ( 
https://git.reviewboard.kde.org/r/117804/ ) and kdoctools_install() ( 
https://git.reviewboard.kde.org/r/117805/ )


Diffs (updated)
-

  modules/ECMCreateQmFromPoFiles.cmake 7457fc5 
  modules/ECMPoQmTools.cmake PRE-CREATION 
  modules/ECMQmLoader.cpp.in 2d8531f 
  tests/CMakeLists.txt 171f44a 
  tests/ECMPoQmToolsTest/CMakeLists.txt PRE-CREATION 
  tests/ECMPoQmToolsTest/check_tree.cmake.in PRE-CREATION 
  tests/ECMPoQmToolsTest/po/es/install-test.po PRE-CREATION 
  tests/ECMPoQmToolsTest/po/fr/install-test.po PRE-CREATION 
  tests/ECMPoQmToolsTest/test.po PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/117823/diff/


Testing
---

Modified kbookmarks to call ecm_install_po_files_as_qm(). Works as expected.


Thanks,

Aurélien Gâteau

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117799: Clean up private slots in KCompletion

2014-05-02 Thread Luca Beltrame

Commit Hook wrote:

> 210ed36c1ae1e3ce33fbd752e460651e31d1a37d by David Gil to branch
> clean_up_private_slots.

Was this the right branch, or a mistake?

-- 
Luca Beltrame - KDE Forums team
KDE Science supporter
GPG key ID: 6E1A4E79

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

39 matches

Mail list logo