Re: Review Request 118128: Use actual bytes formatter for sizes in KDirModel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118128/#review58849 --- Ship it! Ship It! - David Faure On May 29, 2014, 5 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118128/ --- (Updated May 29, 2014, 5 p.m.) Review request for KDE Frameworks and David Faure. Repository: kio Description --- Now I'm not sure if returning the unit together with the size won't break some things, but as it returns string already, I thought returning it in the human readable form would be better than always returning bytes. Diffs - src/widgets/kdirmodel.cpp 70d5ee4 Diff: https://git.reviewboard.kde.org/r/118128/diff/ Testing --- Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118340/#review58850 --- I'm happy with this. I think this should go in, even if there isn't another release, because packagers can pick it up as an official patch if they want. But I'll let Ivan have the final say. - Alex Merry On May 31, 2014, 3:42 a.m., Matthew Dawson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118340/ --- (Updated May 31, 2014, 3:42 a.m.) Review request for KDE Frameworks, Plasma and Ivan Čukić. Repository: kactivities Description --- To allow for the library to be co-installed with the frameworks version, allow the daemon to be disabled. I'm not sure if this is the best way to do this. If there is any better way, I'll update the patch as appropriate. Diffs - src/CMakeLists.txt b4733648fd53ebd681694f185cc5b23f51dfd3f9 Diff: https://git.reviewboard.kde.org/r/118340/diff/ Testing --- Visually inspected install directories. Seems to remove only what is necessary. Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118362: handle the case of exact timeouts correctly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118362/ --- (Updated May 31, 2014, 7:38 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kidletime Description --- handle the case of exact timeouts correctly Diffs - src/widgetbasedpoller.cpp 81d352953d38f625885602c4bfcfbc2a9eee1874 Diff: https://git.reviewboard.kde.org/r/118362/diff/ Testing --- Thanks, Ian Monroe ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118340/ --- (Updated May 31, 2014, 10:33 p.m.) Review request for KDE Frameworks, Plasma and Ivan Čukić. Changes --- Updating the RR to match what I push. I changed the option name to match what is in master, and re-verified everything installs as appropriate. Repository: kactivities Description --- To allow for the library to be co-installed with the frameworks version, allow the daemon to be disabled. I'm not sure if this is the best way to do this. If there is any better way, I'll update the patch as appropriate. Diffs (updated) - src/CMakeLists.txt b4733648fd53ebd681694f185cc5b23f51dfd3f9 Diff: https://git.reviewboard.kde.org/r/118340/diff/ Testing --- Visually inspected install directories. Seems to remove only what is necessary. Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118340/#review58868 --- This review has been submitted with commit f6c2bddb07b43ca857098c5bb2661e236d07bb57 by Matthew Dawson to branch KDE/4.13. - Commit Hook On June 1, 2014, 2:33 a.m., Matthew Dawson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118340/ --- (Updated June 1, 2014, 2:33 a.m.) Review request for KDE Frameworks, Plasma and Ivan Čukić. Repository: kactivities Description --- To allow for the library to be co-installed with the frameworks version, allow the daemon to be disabled. I'm not sure if this is the best way to do this. If there is any better way, I'll update the patch as appropriate. Diffs - src/CMakeLists.txt b4733648fd53ebd681694f185cc5b23f51dfd3f9 Diff: https://git.reviewboard.kde.org/r/118340/diff/ Testing --- Visually inspected install directories. Seems to remove only what is necessary. Thanks, Matthew Dawson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
