Re: Update of the metainfo.yaml file of all the frameworks

[Ben Cooksley]

On Thu, Aug 14, 2014 at 3:16 AM, Denis Steckelmacher
 wrote:
> On 08/13/2014 02:41 PM, Albert Astals Cid wrote:
>>
>> El Dimecres, 13 d'agost de 2014, a les 14:20:58, Aleix Pol va escriure:
>>>
>>> On Wed, Aug 13, 2014 at 12:29 PM, Denis Steckelmacher
>>> 
>>>
>>> wrote:

 On 08/13/2014 12:14 PM, Luigi Toscano wrote:
>
> On Wednesday 13 of August 2014 11:30:48 Denis Steckelmacher wrote:
>>
>> Hi,
>>
>> Yesterday, api.kde.org has been updated so that it displays a bit more
>> information about the frameworks, including code snippets telling the
>> user how to add a framework to his/her CMakeLists.txt or .pro file.
>
>
> How is the email address of the maintainer generated?
> kdoctools/metadata.yml for example shows my identity username
> (ltoscano)
> but I
> don't own ltosc...@kde.org as shown on
> http://api.kde.org/frameworks-api/frameworks5-apidocs/
> kdoctools/html/index.html
>
> What are the fields needed to specify the links previously on the
> README
> file?
> KDocTools has a different IRC channel and an additional mailing list,
> for
> example.
>
> Ciao


 Hi,

 The e-mail is currently generated by appending "@kde.org" after the
 maintainer name. If this is not correct, you can put a full e-mail
 address
 in "maintainer" and it will be used. I don't know if "maintainer" is
 used
 somewhere else, though, so maybe having an e-mail address there is not
 acceptable. If it is the case, then I can update kapidox so that the
 "maintainer_email" key is used when present.

 Regarding the IRC channel and the mailing list, this information could
 also be added to the metainfo.yaml file of projects having specific IRC
 channels or mailing lists. We can discuss how the corresponding keys
 should
 be named ("mailinglist" and "irc" for instance), and whether multiple
 values should be possible (does a framework has several mailing lists,
 and
 are the project-specific mailing lists meant to replace
 kde-frameworks-devel or to be used in addition to it?)

 Denis
>>>
>>>
>>> It's not correct, the name you're using is the identity.kde.org
>>> identifier,
>>> the correct solution would be to query identity.kde.org and fetch the
>>> name
>>> and e-mail from there.
>>
>>
>> If querying identity.kde.org is too hard you can always query
>> http://websvn.kde.org/trunk/kde-common/accounts?view=markup
>>
>> Cheers,
>>Albert
>>
>>>
>>> Aleix
>>
>>
>>
>
> Nice! kapidox now downloads the list of the KDE accounts from
> websvn.kde.org, and these two fields can now be used in metainfo.yaml:

Just wondering - how often does the tool fetch a copy of this file?
WebSVN isn't really intended for accessing the content of Subversion
repositories in a frequent automated manner...
(We actually have it configured to block access if the referer isn't
set properly, to prevent people hotlinking to images through it)

>
> * irc: IRC channel (with the #, without "on FreeNode"), defaults to
> #kde-devel. Don't forget to put quotes around the name so that the file
> remains valid Yaml.
> * mailinglist: Mailing list name, defaults to kde-frameworks-devel. Is there
> any framework whose mailing list is not available in mail.kde.org/mailman?
>
> Denis

Thanks,
Ben

>
> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 119777: Make KFontUtils::adaptFontSize be a bit more exact

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119777/
---

Review request for KDE Frameworks.


Repository: kguiaddons


Description
---

Not all fonts are linear in drawn size against their point size, the old code 
assumes so and simply guesses the next font size taking into account the 
pointSize we drawn, the geometry we got and the geometry we want. The new code 
is a bit slower but will make sure that we get better pointSize results in non 
linear fonts.

This is a continuation from https://git.reviewboard.kde.org/r/114907/


Diffs
-

  src/fonts/kfontutils.cpp 3a80039 

Diff: https://git.reviewboard.kde.org/r/119777/diff/


Testing
---

Blinken still works. Font sizes are similar.

I did code an autotest to try situations like 9 and 10 like David suggested, 
problem is that i can't upload that test since it depends on the font, etc so 
that would be extremely unstable.


Thanks,

Albert Astals Cid

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119713: Switch to breeze or oxygen if they are available and icon theme is either not set or hicolor

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119713/
---

(Updated ago. 13, 2014, 8:55 p.m.)


Review request for KDE Frameworks.


Summary (updated)
-

Switch to breeze or oxygen if they are available and icon theme is either not 
set or hicolor


Repository: kconfigwidgets


Description (updated)
---

Putting it in this framework is a bit random, but since it's the one that has 
KStandardAction i thought it was a "good enough place". I'm open to discussion 
on where to put this.

I am running KGeography in a user which has oxygen icons available but since 
i'm not running neither the kde QPT nor oxygen style nor anything, while moving 
from KIcon to QIcon::fromTheme i lost most of my icons (since there is no 
kiconloader in the middle anymore), and the same for kstandardaction icons.

This patch makes it so that if you are using kstandardactions and your icon 
theme is hicolor but you have breeze or oxygen installed it changes the theme 
to one of those.

I am unconvinced if we want this here or if i want this in my (and potentially) 
every application so when we run in Gnome or Unity, our apps get icons what 
were getting in kde4 times because they were using KIcon and they would lose 
now because of the QIcon::fromTheme recommendation.

Obviously the missing icons also get fixed by QT_QPA_PLATFORMTHEME=kde but one 
can not expect to have this define when on non Plasma desktops and since in the 
past KIcon gave you oxygen-icons even if you were not on plasma i think it 
makes sense to do this.


Diffs
-

  src/kstandardaction.cpp a18527b 

Diff: https://git.reviewboard.kde.org/r/119713/diff/


Testing
---

KGeography menu items have icons again.


Thanks,

Albert Astals Cid

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119698: Save radio button index in QGroupBox that are composed only by radio buttons

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119698/
---

(Updated Aug. 13, 2014, 8:53 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kconfigwidgets


Description
---

We are suggesting people to port from deprecated KButtonGroup to QGroupBox but 
the dialog manager does not behave the same. This patch fixes it by assuming 
that in a groupbox that is composed exclusively by radio buttons and whose 
config item is an int to save the index of the checked radio button instead of 
if the group box itself is checked.


Diffs
-

  src/kconfigdialogmanager.cpp 94d3cd1 

Diff: https://git.reviewboard.kde.org/r/119698/diff/


Testing
---

KGeography frameworks with KButtonGroup ported to QGroupBox works.


Thanks,

Albert Astals Cid

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 119773: Launch scripts in autostart-directories

[Martin Yrjölä]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119773/
---

Review request for KDE Frameworks.


Bugs: 335878 and 338242
https://bugs.kde.org/show_bug.cgi?id=335878
https://bugs.kde.org/show_bug.cgi?id=338242


Repository: kinit


Description
---

This fixes execution of scripts other than ".desktop"-files in the 
~/.config/autostart directory when starting a session. This functionality was 
removed in https://git.reviewboard.kde.org/r/118977/ because of 
https://bugs.kde.org/show_bug.cgi?id=335878.

Things that still have to be discussed:
* Is kinit the right place for this functionality? I think it makes sense 
because all other autostart functionality is there.
* Is kioclient5 the correct way to start the scripts?
* Which kind of files in autostart-directories gets executed?
 * I chose a simple *.sh regex for testing purposes.
 * In KSMServer and KDE4 only obvious backup files (*.bak, *~, %*% etc.) were 
excluded.


Diffs
-

  src/klauncher/autostart.cpp 0706c735c3caf1c010d9968337456bfc5a0805c1 

Diff: https://git.reviewboard.kde.org/r/119773/diff/


Testing
---

Works for scripts that exit and those that run the whole session. Now the only 
limitation is the *.sh wildcard.


Thanks,

Martin Yrjölä

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119755: Support more number types in haskell highlighting

[Dominik Haumann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119755/#review64499
---

Ship it!


Patch looks good, but please increase the version number in the language 
element.

- Dominik Haumann


On Aug. 13, 2014, 4:33 p.m., Bastian Holst wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119755/
> ---
> 
> (Updated Aug. 13, 2014, 4:33 p.m.)
> 
> 
> Review request for Kate, KDE Frameworks and Christoph Cullmann.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> ---
> 
> Support highlighting for the following types of numbers:
> * octal numbers
> * hexadecimal numbers
> * floating point numbers with exponent notation
> 
> 
> Diffs
> -
> 
>   src/syntax/data/haskell.xml 49583a116df9b3f3d86e65a617729385048455b7 
> 
> Diff: https://git.reviewboard.kde.org/r/119755/diff/
> 
> 
> Testing
> ---
> 
> Manually testing with a number of Haskell files
> 
> 
> Thanks,
> 
> Bastian Holst
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119767: Add Hamlet and Haskell quasiquotation

[Dominik Haumann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119767/#review64497
---



src/syntax/data/hamlet.xml


Better than ^\s* is to use the attribute firstNonSpace="true", i.e.:


And as such, you can switch to 




src/syntax/data/hamlet.xml


Is the beginRegion="element" somewhere missing to match this 
endRegion="element" ?



src/syntax/data/hamlet.xml


^ means you match only at the beginning of the line. Faster is adding a 
column="0".



src/syntax/data/hamlet.xml


Are you looking for words only here?
If so, you may want to use WordDetect instead of RegExr, see (search for 
WordDetect):

http://docs.kde.org/stable/en/applications/kate/kate-highlight-rules-detailled.html



src/syntax/data/hamlet.xml


Use WordDetect instead of RegExpr.



src/syntax/data/hamlet.xml


Use WordDetect instead of RegExpr



src/syntax/data/haskell.xml


Increase the version to 2.3.



src/syntax/data/haskell.xml


This rule switches to the context "List or QuasiQuote" on '['. The rules in 
the context "List or QuasiQuote" again switch to other contexts.

Question: Do you ever #pop back to the context "code"?

Would it also be possible to use fallthrough and fallthroughContext like 
this:
 
and then remove the line 360?
 


Hi, nice. Could you please send a revised version with the issues addressed?

- Dominik Haumann


On Aug. 13, 2014, 4:33 p.m., Bastian Holst wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119767/
> ---
> 
> (Updated Aug. 13, 2014, 4:33 p.m.)
> 
> 
> Review request for Kate, KDE Frameworks and Christoph Cullmann.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> ---
> 
> This request request mostly contains syntax highlighting for Hamlet
> files. Hamlet is a Haskell based Template language for creating
> HTML documents. As Hamlet can be embedded into an ordinary Haskell
> file with quasi quotation, this also implements QuasiQuotation support
> for Haskell files.
> 
> 
> Diffs
> -
> 
>   src/syntax/data/hamlet.xml PRE-CREATION 
>   src/syntax/data/haskell.xml 49583a116df9b3f3d86e65a617729385048455b7 
> 
> Diff: https://git.reviewboard.kde.org/r/119767/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bastian Holst
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119755: Support more number types in haskell highlighting

[Bastian Holst]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119755/
---

(Updated Aug. 13, 2014, 4:33 nachm.)


Review request for Kate, KDE Frameworks and Christoph Cullmann.


Repository: ktexteditor


Description
---

Support highlighting for the following types of numbers:
* octal numbers
* hexadecimal numbers
* floating point numbers with exponent notation


Diffs
-

  src/syntax/data/haskell.xml 49583a116df9b3f3d86e65a617729385048455b7 

Diff: https://git.reviewboard.kde.org/r/119755/diff/


Testing
---

Manually testing with a number of Haskell files


Thanks,

Bastian Holst

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 119767: Add Hamlet and Haskell quasiquotation

[Bastian Holst]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119767/
---

Review request for Kate, KDE Frameworks and Christoph Cullmann.


Repository: ktexteditor


Description
---

This request request mostly contains syntax highlighting for Hamlet
files. Hamlet is a Haskell based Template language for creating
HTML documents. As Hamlet can be embedded into an ordinary Haskell
file with quasi quotation, this also implements QuasiQuotation support
for Haskell files.


Diffs
-

  src/syntax/data/hamlet.xml PRE-CREATION 
  src/syntax/data/haskell.xml 49583a116df9b3f3d86e65a617729385048455b7 

Diff: https://git.reviewboard.kde.org/r/119767/diff/


Testing
---


Thanks,

Bastian Holst

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119736: Convert the ki18n programmers' guide to Markdown

[Nicolás Alvarez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119736/
---

(Updated Aug. 13, 2014, 4:19 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: ki18n


Description
---

Convert the ki18n programmers' guide to Markdown.

This will make it easier for the frameworks book to use the same content.


Diffs
-

  docs/programmers-guide.dox 2298b18 
  docs/programmers-guide.md PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/119736/diff/


Testing
---

I ensured the final HTML result from doxygen looks (nearly) identical to the 
.dox version.


Thanks,

Nicolás Alvarez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Update of the metainfo.yaml file of all the frameworks

[Denis Steckelmacher]

On 08/13/2014 02:41 PM, Albert Astals Cid wrote:

El Dimecres, 13 d'agost de 2014, a les 14:20:58, Aleix Pol va escriure:

On Wed, Aug 13, 2014 at 12:29 PM, Denis Steckelmacher 

wrote:

On 08/13/2014 12:14 PM, Luigi Toscano wrote:

On Wednesday 13 of August 2014 11:30:48 Denis Steckelmacher wrote:

Hi,

Yesterday, api.kde.org has been updated so that it displays a bit more
information about the frameworks, including code snippets telling the
user how to add a framework to his/her CMakeLists.txt or .pro file.


How is the email address of the maintainer generated?
kdoctools/metadata.yml for example shows my identity username (ltoscano)
but I
don't own ltosc...@kde.org as shown on
http://api.kde.org/frameworks-api/frameworks5-apidocs/
kdoctools/html/index.html

What are the fields needed to specify the links previously on the README
file?
KDocTools has a different IRC channel and an additional mailing list, for
example.

Ciao


Hi,

The e-mail is currently generated by appending "@kde.org" after the
maintainer name. If this is not correct, you can put a full e-mail address
in "maintainer" and it will be used. I don't know if "maintainer" is used
somewhere else, though, so maybe having an e-mail address there is not
acceptable. If it is the case, then I can update kapidox so that the
"maintainer_email" key is used when present.

Regarding the IRC channel and the mailing list, this information could
also be added to the metainfo.yaml file of projects having specific IRC
channels or mailing lists. We can discuss how the corresponding keys
should
be named ("mailinglist" and "irc" for instance), and whether multiple
values should be possible (does a framework has several mailing lists, and
are the project-specific mailing lists meant to replace
kde-frameworks-devel or to be used in addition to it?)

Denis


It's not correct, the name you're using is the identity.kde.org identifier,
the correct solution would be to query identity.kde.org and fetch the name
and e-mail from there.


If querying identity.kde.org is too hard you can always query
http://websvn.kde.org/trunk/kde-common/accounts?view=markup

Cheers,
   Albert



Aleix





Nice! kapidox now downloads the list of the KDE accounts from 
websvn.kde.org, and these two fields can now be used in metainfo.yaml:


* irc: IRC channel (with the #, without "on FreeNode"), defaults to 
#kde-devel. Don't forget to put quotes around the name so that the file 
remains valid Yaml.
* mailinglist: Mailing list name, defaults to kde-frameworks-devel. Is 
there any framework whose mailing list is not available in 
mail.kde.org/mailman?


Denis
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119736: Convert the ki18n programmers' guide to Markdown

[Rohan Garg]

> On Aug. 13, 2014, 6:24 p.m., Rohan Garg wrote:
> > \o/
> > 
> > Thanks Nicolas :)
> 
> Albert Astals Cid wrote:
> Is doxygen smart enough to read the .md?

Yep, atleast the version I have can read .md, @Nicolas does the doxygen version 
on api.kde.org handle .md files?


- Rohan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119736/#review64464
---


On Aug. 12, 2014, 10:19 p.m., Nicolás Alvarez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119736/
> ---
> 
> (Updated Aug. 12, 2014, 10:19 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: ki18n
> 
> 
> Description
> ---
> 
> Convert the ki18n programmers' guide to Markdown.
> 
> This will make it easier for the frameworks book to use the same content.
> 
> 
> Diffs
> -
> 
>   docs/programmers-guide.dox 2298b18 
>   docs/programmers-guide.md PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119736/diff/
> 
> 
> Testing
> ---
> 
> I ensured the final HTML result from doxygen looks (nearly) identical to the 
> .dox version.
> 
> 
> Thanks,
> 
> Nicolás Alvarez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Update of the metainfo.yaml file of all the frameworks

[Kevin Ottens]

On Wednesday 13 August 2014 14:20:58 Aleix Pol wrote:
> On Wed, Aug 13, 2014 at 12:29 PM, Denis Steckelmacher 
> > The e-mail is currently generated by appending "@kde.org" after the
> > maintainer name. If this is not correct, you can put a full e-mail address
> > in "maintainer" and it will be used. I don't know if "maintainer" is used
> > somewhere else, though, so maybe having an e-mail address there is not
> > acceptable. If it is the case, then I can update kapidox so that the
> > "maintainer_email" key is used when present.
> > 
> > Regarding the IRC channel and the mailing list, this information could
> > also be added to the metainfo.yaml file of projects having specific IRC
> > channels or mailing lists. We can discuss how the corresponding keys
> > should be named ("mailinglist" and "irc" for instance), and whether
> > multiple values should be possible (does a framework has several mailing
> > lists, and are the project-specific mailing lists meant to replace
> > kde-frameworks-devel or to be used in addition to it?)
> 
> It's not correct, the name you're using is the identity.kde.org identifier,
> the correct solution would be to query identity.kde.org and fetch the name
> and e-mail from there.

Indeed. And that was actually the plan when I discussed this particular key 
with Aurélien back at the sprint.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119736: Convert the ki18n programmers' guide to Markdown

[Albert Astals Cid]

> On ago. 13, 2014, 12:54 p.m., Rohan Garg wrote:
> > \o/
> > 
> > Thanks Nicolas :)

Is doxygen smart enough to read the .md?


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119736/#review64464
---


On ago. 12, 2014, 4:49 p.m., Nicolás Alvarez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119736/
> ---
> 
> (Updated ago. 12, 2014, 4:49 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: ki18n
> 
> 
> Description
> ---
> 
> Convert the ki18n programmers' guide to Markdown.
> 
> This will make it easier for the frameworks book to use the same content.
> 
> 
> Diffs
> -
> 
>   docs/programmers-guide.dox 2298b18 
>   docs/programmers-guide.md PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119736/diff/
> 
> 
> Testing
> ---
> 
> I ensured the final HTML result from doxygen looks (nearly) identical to the 
> .dox version.
> 
> 
> Thanks,
> 
> Nicolás Alvarez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119736: Convert the ki18n programmers' guide to Markdown

[Rohan Garg]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119736/#review64464
---

Ship it!


\o/

Thanks Nicolas :)

- Rohan Garg


On Aug. 12, 2014, 10:19 p.m., Nicolás Alvarez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119736/
> ---
> 
> (Updated Aug. 12, 2014, 10:19 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: ki18n
> 
> 
> Description
> ---
> 
> Convert the ki18n programmers' guide to Markdown.
> 
> This will make it easier for the frameworks book to use the same content.
> 
> 
> Diffs
> -
> 
>   docs/programmers-guide.dox 2298b18 
>   docs/programmers-guide.md PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119736/diff/
> 
> 
> Testing
> ---
> 
> I ensured the final HTML result from doxygen looks (nearly) identical to the 
> .dox version.
> 
> 
> Thanks,
> 
> Nicolás Alvarez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KUnitConversion

[David Narvaez]

On Wed, Aug 13, 2014 at 1:46 AM, Garret Wassermann  wrote:
> A library that allows one to define new derived units in terms of
> base units and register them with the library would be really cool.
> it could be useful for anyone no matter how specialized the field,
> rather than having to update the library itself every time someone
> wants a new unit.
>
> I would also like to see a library that allows basic arithmetic with
> these units. Perhaps overloaded operators to allow one to add or
> multiply quantities and preserve the correct resulting units.
> Being able to for example set a = 2 kg, and b = 9.8 m/s^2,
> then type c = a * b and have the library know that
> c has the unit of Newtons now (or at least, know how to combine
> the units and show the resulting kg*m/s^2 and check that it is
> equivalent to a newton). It will be useful
> as a sanity check on my work, though I also see this being
> useful for more educational oriented software.

There is what I consider a good design idea for such a library at

http://www.stroustrup.com/Software-for-infrastructure.pdf

written by someone that I think knows some stuff about C++.

David E. Narvaez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Update of the metainfo.yaml file of all the frameworks

[Albert Astals Cid]

El Dimecres, 13 d'agost de 2014, a les 14:20:58, Aleix Pol va escriure:
> On Wed, Aug 13, 2014 at 12:29 PM, Denis Steckelmacher 
> 
> wrote:
> > On 08/13/2014 12:14 PM, Luigi Toscano wrote:
> >> On Wednesday 13 of August 2014 11:30:48 Denis Steckelmacher wrote:
> >>> Hi,
> >>> 
> >>> Yesterday, api.kde.org has been updated so that it displays a bit more
> >>> information about the frameworks, including code snippets telling the
> >>> user how to add a framework to his/her CMakeLists.txt or .pro file.
> >> 
> >> How is the email address of the maintainer generated?
> >> kdoctools/metadata.yml for example shows my identity username (ltoscano)
> >> but I
> >> don't own ltosc...@kde.org as shown on
> >> http://api.kde.org/frameworks-api/frameworks5-apidocs/
> >> kdoctools/html/index.html
> >> 
> >> What are the fields needed to specify the links previously on the README
> >> file?
> >> KDocTools has a different IRC channel and an additional mailing list, for
> >> example.
> >> 
> >> Ciao
> > 
> > Hi,
> > 
> > The e-mail is currently generated by appending "@kde.org" after the
> > maintainer name. If this is not correct, you can put a full e-mail address
> > in "maintainer" and it will be used. I don't know if "maintainer" is used
> > somewhere else, though, so maybe having an e-mail address there is not
> > acceptable. If it is the case, then I can update kapidox so that the
> > "maintainer_email" key is used when present.
> > 
> > Regarding the IRC channel and the mailing list, this information could
> > also be added to the metainfo.yaml file of projects having specific IRC
> > channels or mailing lists. We can discuss how the corresponding keys
> > should
> > be named ("mailinglist" and "irc" for instance), and whether multiple
> > values should be possible (does a framework has several mailing lists, and
> > are the project-specific mailing lists meant to replace
> > kde-frameworks-devel or to be used in addition to it?)
> > 
> > Denis
> 
> It's not correct, the name you're using is the identity.kde.org identifier,
> the correct solution would be to query identity.kde.org and fetch the name
> and e-mail from there.

If querying identity.kde.org is too hard you can always query 
http://websvn.kde.org/trunk/kde-common/accounts?view=markup

Cheers,
  Albert

> 
> Aleix

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Update of the metainfo.yaml file of all the frameworks

[Aleix Pol]

On Wed, Aug 13, 2014 at 12:29 PM, Denis Steckelmacher 
wrote:

> On 08/13/2014 12:14 PM, Luigi Toscano wrote:
>
>> On Wednesday 13 of August 2014 11:30:48 Denis Steckelmacher wrote:
>>
>>> Hi,
>>>
>>> Yesterday, api.kde.org has been updated so that it displays a bit more
>>> information about the frameworks, including code snippets telling the
>>> user how to add a framework to his/her CMakeLists.txt or .pro file.
>>>
>>
>> How is the email address of the maintainer generated?
>> kdoctools/metadata.yml for example shows my identity username (ltoscano)
>> but I
>> don't own ltosc...@kde.org as shown on
>> http://api.kde.org/frameworks-api/frameworks5-apidocs/
>> kdoctools/html/index.html
>>
>> What are the fields needed to specify the links previously on the README
>> file?
>> KDocTools has a different IRC channel and an additional mailing list, for
>> example.
>>
>> Ciao
>>
>>
> Hi,
>
> The e-mail is currently generated by appending "@kde.org" after the
> maintainer name. If this is not correct, you can put a full e-mail address
> in "maintainer" and it will be used. I don't know if "maintainer" is used
> somewhere else, though, so maybe having an e-mail address there is not
> acceptable. If it is the case, then I can update kapidox so that the
> "maintainer_email" key is used when present.
>
> Regarding the IRC channel and the mailing list, this information could
> also be added to the metainfo.yaml file of projects having specific IRC
> channels or mailing lists. We can discuss how the corresponding keys should
> be named ("mailinglist" and "irc" for instance), and whether multiple
> values should be possible (does a framework has several mailing lists, and
> are the project-specific mailing lists meant to replace
> kde-frameworks-devel or to be used in addition to it?)
>
> Denis
>
>
It's not correct, the name you're using is the identity.kde.org identifier,
the correct solution would be to query identity.kde.org and fetch the name
and e-mail from there.

Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KDE Frameworks 2014 Sprint Dot Article missing

[Jonathan Riddell]

¡así!
https://dot.kde.org/2014/08/13/kde-frameworks-sprint-how-release-platform

Jonathan



On 28 July 2014 00:48, Albert Astals Cid  wrote:

> Hi guys, please note that the Dot Article of the KDE Frameworks 2014
> Sprint is
> missing.
>
> Can someone of the guys that was there write something?
>
> Cheers,
>   Albert
> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Update of the metainfo.yaml file of all the frameworks

[Denis Steckelmacher]

On 08/13/2014 12:14 PM, Luigi Toscano wrote:

On Wednesday 13 of August 2014 11:30:48 Denis Steckelmacher wrote:

Hi,

Yesterday, api.kde.org has been updated so that it displays a bit more
information about the frameworks, including code snippets telling the
user how to add a framework to his/her CMakeLists.txt or .pro file.


How is the email address of the maintainer generated?
kdoctools/metadata.yml for example shows my identity username (ltoscano) but I
don't own ltosc...@kde.org as shown on
http://api.kde.org/frameworks-api/frameworks5-apidocs/kdoctools/html/index.html

What are the fields needed to specify the links previously on the README file?
KDocTools has a different IRC channel and an additional mailing list, for
example.

Ciao



Hi,

The e-mail is currently generated by appending "@kde.org" after the 
maintainer name. If this is not correct, you can put a full e-mail 
address in "maintainer" and it will be used. I don't know if 
"maintainer" is used somewhere else, though, so maybe having an e-mail 
address there is not acceptable. If it is the case, then I can update 
kapidox so that the "maintainer_email" key is used when present.


Regarding the IRC channel and the mailing list, this information could 
also be added to the metainfo.yaml file of projects having specific IRC 
channels or mailing lists. We can discuss how the corresponding keys 
should be named ("mailinglist" and "irc" for instance), and whether 
multiple values should be possible (does a framework has several mailing 
lists, and are the project-specific mailing lists meant to replace 
kde-frameworks-devel or to be used in addition to it?)


Denis
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119530: kcoreaddons: Fix kautosave doesn't work with more than 1 file per application

[Andreas Xavier]

> On Aug. 13, 2014, 7:47 a.m., David Faure wrote:
> > src/lib/io/kautosavefile.h, line 49
> > 
> >
> > To me kautosavefile was about the KOffice/Calligra use case: saving 
> > into a temp file in order to recover the stuff typed by the user and not 
> > saved yet, in case of a crash.
> > 
> > For backups we also have KBackupFile, in kcoreaddons. This makes me a 
> > bit confused about who does what and what's the difference (between 
> > KBackupFile and KAutoSaveFile with this (new?) "backup" use case) for an 
> > app. Can you clarify?

You are correct.  It should serve one purpose well, answering this question: 
Did I crash while editing this file?  

At the time (4.8, 1 month ago), it could be used to answer these 3 questions:
Is there an autosave?
Did I crash?
Is someone else editing the file?

It did what I wanted, so I used it.


BTW, backupFile was hard to find in the documentation.  KBackup is a namespace 
that doesn't show up under the namespace list.  backupFile is non-member 
function of that namespace, so it has no place of its own in the documentation. 
 Neither show up in the search on http://api.kde.org . kbackup.h does show up 
in the filelist.


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119530/#review64423
---


On Aug. 11, 2014, 9:22 p.m., Andreas Xavier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119530/
> ---
> 
> (Updated Aug. 11, 2014, 9:22 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> kautosave doesn't work when any app tries to use a second filename, because 
> it doesn't filter on filename.  The unit tests can be droppped into master to 
> show the problem, if you remove the include on line 21.
> 
> This patch:
> 1. Adds unit tests to test more behavior mentioned in the header.
> 2. Fixes kautosave working with multple files per application.
> 3. Fixes filenaming brittleness, which would cause kautosave to randomly fail 
> when the last 3 randomly generated characters in the filename matched any 3 
> consequtive chracters in the managed filename.
> 
> 
> Diffs
> -
> 
>   src/lib/io/kautosavefile_p.cpp PRE-CREATION 
>   src/lib/io/kautosavefile_p.h PRE-CREATION 
>   src/lib/io/kautosavefile.cpp 13a13d7 
>   src/lib/io/kautosavefile.h 05cc3ae 
>   src/lib/CMakeLists.txt 26eb5a1 
>   autotests/kautosavefiletest.h cf70f4c 
>   autotests/kautosavefiletest.cpp ec0309e 
>   ! PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119530/diff/
> 
> 
> Testing
> ---
> 
> Ran unit tests.
> Ran kdeedu with kanagram.
> 
> 
> Thanks,
> 
> Andreas Xavier
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Update of the metainfo.yaml file of all the frameworks

[Luigi Toscano]

On Wednesday 13 of August 2014 11:30:48 Denis Steckelmacher wrote:
> Hi,
> 
> Yesterday, api.kde.org has been updated so that it displays a bit more
> information about the frameworks, including code snippets telling the
> user how to add a framework to his/her CMakeLists.txt or .pro file.

How is the email address of the maintainer generated? 
kdoctools/metadata.yml for example shows my identity username (ltoscano) but I 
don't own ltosc...@kde.org as shown on 
http://api.kde.org/frameworks-api/frameworks5-apidocs/kdoctools/html/index.html

What are the fields needed to specify the links previously on the README file? 
KDocTools has a different IRC channel and an additional mailing list, for 
example.

Ciao
-- 
Luigi


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Update of the metainfo.yaml file of all the frameworks

[Kevin Ottens]

Hello,

On Wednesday 13 August 2014 11:30:48 Denis Steckelmacher wrote:
> Yesterday, api.kde.org has been updated so that it displays a bit more
> information about the frameworks, including code snippets telling the
> user how to add a framework to his/her CMakeLists.txt or .pro file.
> 
> In order to display accurate information and because some frameworks
> have slightly different names for the CMake package file, CMake
> libraries and QMake libraries, I've updated all the metainfo.yaml files
> of the framework so that they include those names. Feel free to contact
> me if you have any comment or complain.

Really nice improvement. Thanks!

You might want to adjust that page too (if not done already):
https://community.kde.org/Frameworks/Frameworks_Documentation_Policy

Cheers.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Breeze widget style for KF5

[Hugo Pereira Da Costa]

On 08/12/2014 11:34 PM, Àlex Fiestas wrote:

On Monday 11 August 2014 12:51:21 Milian Wolff wrote:

a) what's the advantage of having a native widget style, compared to using
QtCurve settings? Are there things missing / not implementable in QtCurve?

We did some rought tests and QtCurve was wy slower than Oxygen (that at
the same time was slower than Fusion).

The test we did was re-painting widgets over and over with different styles and
then measuring instructions and time iirc.

Cheerz.

Hi Alex,

many thanks for doing this test (glad to hear that oxygen is not the 
biggest beast around :))


Now, to be honest, I'm not sure how 'relevant' the test is, and the 
outcome might well be very GPU related.
Oxygen, unlike QtCurve, uses a lot of QPixmap all over the place for 
rendering and caching, which is known to be quite expensive on some 
GPUs, and not at all on others.
Also, for the comparison to fusion, oxygen has tons of animations, which 
causes several (as opposed to one) localized repaints for basically each 
user interaction, and this will cost, naturally. (not sure what's the 
status of QtCurve with that respect).
In any case, I'd also be curious to see the outcome for the current 
breeze code (kde:scratch/hpereiradacosta/breeze), for which the 
rendering is supposedly much simpler than oxygen, and no caching is 
used. (but animations are there)


Best,

Hugo




___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

New i18n fields in projects.kde.org

[Albert Astals Cid]

Hi everybody, projects.kde.org has just got 2 new fields to declare i18n 
branches, now we have

i18n trunk branch (kdelibs4)
i18n stable branch (kdelibs4)
i18n trunk branch (KF5)
i18n stable branch (KF5) 

Please set those accordingly in your projects to help scripty and other 
scripts that have to work on both kdelibs4 and KF5 based branches on repos to 
make things better.

Cheers,
  Albert
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: kwindowsystem_master_qt5 » All,LINBUILDER #90

[KDE CI System]

See 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Update of the metainfo.yaml file of all the frameworks

[Denis Steckelmacher]

Hi,

Yesterday, api.kde.org has been updated so that it displays a bit more 
information about the frameworks, including code snippets telling the 
user how to add a framework to his/her CMakeLists.txt or .pro file.


In order to display accurate information and because some frameworks 
have slightly different names for the CMake package file, CMake 
libraries and QMake libraries, I've updated all the metainfo.yaml files 
of the framework so that they include those names. Feel free to contact 
me if you have any comment or complain.


Denis Steckelmacher
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework

[Eike Hein]

> On Aug. 13, 2014, 8:58 a.m., David Faure wrote:
> > src/kcms/webshortcuts/main.cpp, line 112
> > 
> >
> > The indentation seems wrong. Can you run astyle-kdelibs on the whole 
> > thing? It will also remove these pesky spaces inside parentheses.

http://commits.kde.org/kio/55d5a1d8b9786ee381353ea99a5c7415bb83b50f


> On Aug. 13, 2014, 8:58 a.m., David Faure wrote:
> > src/kcms/webshortcuts/main.cpp, line 52
> > 
> >
> > Maybe it's time to update this example, altavista is gone...

http://commits.kde.org/kio/7aae5264711c79576ecfc96034dafa5fd0fc04df


> On Aug. 13, 2014, 8:58 a.m., David Faure wrote:
> > src/kcms/webshortcuts/main.cpp, line 54
> > 
> >
> > (the word 'shortcut' is used twice for two different things here... 
> > prepend "keyboard" before the first one?)

http://commits.kde.org/kio/7aae5264711c79576ecfc96034dafa5fd0fc04df


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119280/#review64436
---


On July 14, 2014, 8:36 p.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119280/
> ---
> 
> (Updated July 14, 2014, 8:36 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> As discussed, this adds the Web Shortcuts KCM, formerly shipped as part as 
> Konqueror, to the KIO framework, where the URI Filters framework it 
> configures resides as well. This makes more sense than stuffing it into 
> workspace, since Web Shortcuts have many app level downstreams (e.g. 
> Konversation, Okular and Konsole) which try to run the KCM via kcmshell5, and 
> may not be running inside Plasma Desktop at the time.
> 
> I've lightly modified the code to make it build, and made the naming more 
> consistent - "webshortcuts" is now used throughout where previously was a mix 
> of "ebrowsing" and "kurifilt". This means .po name changed, but the KCM only 
> contains a single string. More importantly it means apps calling the KCM via 
> kcmshell5 need to be changed to use the new name - I promise to take care of 
> that.
> 
> I'm the least confident on the CMake stuff, especially the TRANSLATION_DOMAIN 
> redefinition, so I'd be happy for review.
> 
> Note the categorization is already what the recategorization effort 
> proscribed for this KCM.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6f8373f 
>   src/kcms/CMakeLists.txt PRE-CREATION 
>   src/kcms/webshortcuts/CMakeLists.txt PRE-CREATION 
>   src/kcms/webshortcuts/Messages.sh PRE-CREATION 
>   src/kcms/webshortcuts/main.h PRE-CREATION 
>   src/kcms/webshortcuts/main.cpp PRE-CREATION 
>   src/kcms/webshortcuts/webshortcuts.desktop PRE-CREATION 
>   src/urifilters/ikws/CMakeLists.txt 4efe24e 
> 
> Diff: https://git.reviewboard.kde.org/r/119280/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Breeze widget style for KF5

[Milian Wolff]

On Tuesday 12 August 2014 23:34:40 Àlex Fiestas wrote:
> On Monday 11 August 2014 12:51:21 Milian Wolff wrote:
> > a) what's the advantage of having a native widget style, compared to using
> > QtCurve settings? Are there things missing / not implementable in QtCurve?
> 
> We did some rought tests and QtCurve was wy slower than Oxygen (that at
> the same time was slower than Fusion).
> 
> The test we did was re-painting widgets over and over with different styles
> and then measuring instructions and time iirc.

Cool, did you publish the code for these benchmarks somewhere? If so, where? I 
no, could you?

Bye
-- 
Milian Wolff
m...@milianw.de
http://milianw.de

signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119755: Support more number types in haskell highlighting

[Bastian Holst]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119755/
---

(Updated Aug. 13, 2014, 9:18 vorm.)


Review request for KDE Frameworks and Christoph Cullmann.


Repository: ktexteditor


Description (updated)
---

Support highlighting for the following types of numbers:
* octal numbers
* hexadecimal numbers
* floating point numbers with exponent notation


Diffs
-

  src/syntax/data/haskell.xml 49583a116df9b3f3d86e65a617729385048455b7 

Diff: https://git.reviewboard.kde.org/r/119755/diff/


Testing (updated)
---

Manually testing with a number of Haskell files


Thanks,

Bastian Holst

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework

[Eike Hein]

> On Aug. 13, 2014, 8:58 a.m., David Faure wrote:
> >

So I just realized I screwed up last week-ish and actually pushed this into 
kio.git already when I pushed the KFPG/KAVA fixes -- I didn't realize I had 
this on the same branch. I'll do the fixes asked for below and reply with the 
commit hashes.


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119280/#review64436
---


On July 14, 2014, 8:36 p.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119280/
> ---
> 
> (Updated July 14, 2014, 8:36 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> As discussed, this adds the Web Shortcuts KCM, formerly shipped as part as 
> Konqueror, to the KIO framework, where the URI Filters framework it 
> configures resides as well. This makes more sense than stuffing it into 
> workspace, since Web Shortcuts have many app level downstreams (e.g. 
> Konversation, Okular and Konsole) which try to run the KCM via kcmshell5, and 
> may not be running inside Plasma Desktop at the time.
> 
> I've lightly modified the code to make it build, and made the naming more 
> consistent - "webshortcuts" is now used throughout where previously was a mix 
> of "ebrowsing" and "kurifilt". This means .po name changed, but the KCM only 
> contains a single string. More importantly it means apps calling the KCM via 
> kcmshell5 need to be changed to use the new name - I promise to take care of 
> that.
> 
> I'm the least confident on the CMake stuff, especially the TRANSLATION_DOMAIN 
> redefinition, so I'd be happy for review.
> 
> Note the categorization is already what the recategorization effort 
> proscribed for this KCM.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6f8373f 
>   src/kcms/CMakeLists.txt PRE-CREATION 
>   src/kcms/webshortcuts/CMakeLists.txt PRE-CREATION 
>   src/kcms/webshortcuts/Messages.sh PRE-CREATION 
>   src/kcms/webshortcuts/main.h PRE-CREATION 
>   src/kcms/webshortcuts/main.cpp PRE-CREATION 
>   src/kcms/webshortcuts/webshortcuts.desktop PRE-CREATION 
>   src/urifilters/ikws/CMakeLists.txt 4efe24e 
> 
> Diff: https://git.reviewboard.kde.org/r/119280/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 119755: Support more number types in haskell highlighting

[Bastian Holst]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119755/
---

Review request for KDE Frameworks and Christoph Cullmann.


Repository: ktexteditor


Description
---

Support highlighting for the following types of numbers:
* octal numbers
* hexadecimal numbers
* floating point numbers with exponent notation


Diffs
-

  src/syntax/data/haskell.xml 49583a116df9b3f3d86e65a617729385048455b7 

Diff: https://git.reviewboard.kde.org/r/119755/diff/


Testing
---


Thanks,

Bastian Holst

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119280/#review64436
---



src/kcms/webshortcuts/main.cpp


Maybe it's time to update this example, altavista is gone...



src/kcms/webshortcuts/main.cpp


(the word 'shortcut' is used twice for two different things here... prepend 
"keyboard" before the first one?)



src/kcms/webshortcuts/main.cpp


The indentation seems wrong. Can you run astyle-kdelibs on the whole thing? 
It will also remove these pesky spaces inside parentheses.


- David Faure


On July 14, 2014, 8:36 p.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119280/
> ---
> 
> (Updated July 14, 2014, 8:36 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> As discussed, this adds the Web Shortcuts KCM, formerly shipped as part as 
> Konqueror, to the KIO framework, where the URI Filters framework it 
> configures resides as well. This makes more sense than stuffing it into 
> workspace, since Web Shortcuts have many app level downstreams (e.g. 
> Konversation, Okular and Konsole) which try to run the KCM via kcmshell5, and 
> may not be running inside Plasma Desktop at the time.
> 
> I've lightly modified the code to make it build, and made the naming more 
> consistent - "webshortcuts" is now used throughout where previously was a mix 
> of "ebrowsing" and "kurifilt". This means .po name changed, but the KCM only 
> contains a single string. More importantly it means apps calling the KCM via 
> kcmshell5 need to be changed to use the new name - I promise to take care of 
> that.
> 
> I'm the least confident on the CMake stuff, especially the TRANSLATION_DOMAIN 
> redefinition, so I'd be happy for review.
> 
> Note the categorization is already what the recategorization effort 
> proscribed for this KCM.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6f8373f 
>   src/kcms/CMakeLists.txt PRE-CREATION 
>   src/kcms/webshortcuts/CMakeLists.txt PRE-CREATION 
>   src/kcms/webshortcuts/Messages.sh PRE-CREATION 
>   src/kcms/webshortcuts/main.h PRE-CREATION 
>   src/kcms/webshortcuts/main.cpp PRE-CREATION 
>   src/kcms/webshortcuts/webshortcuts.desktop PRE-CREATION 
>   src/urifilters/ikws/CMakeLists.txt 4efe24e 
> 
> Diff: https://git.reviewboard.kde.org/r/119280/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kcoreaddons fails to build properly on OSX/CI (was OSX/CI: kauth fails to build )

[Aleix Pol]

On Wed, Aug 13, 2014 at 7:22 AM, Marko Käning  wrote:

> Hi Aleix,
>
> On 13 Aug 2014, at 02:01 , Aleix Pol  wrote:
>
> Here KCoreAddons installs much more things!
> http://paste.kde.org/pa4xgdehw
>
>
> well, that list coincides with what I was used up to now...
>
>  So, although kcoreaddons got built without error (see below) it by far
> doesn’t build everything!
>
> What can be done to analyse this further?
>
> Greets,
> Marko
>
>
> ---
>
>
> KDE Continuous Integration Build
> == Building Project: kcoreaddons - Branch master
> == Build Dependencies:
>  cmake - Branch master
>  qt5 - Branch stable
>  extra-cmake-modules - Branch master
>  dogtail - Branch master
>
> == Applying Patches
> === No patches to apply
>
> == Syncing Dependencies from Master Server
>
>
> == Configuring Build
>
>
> == Commencing the Build
>
>
> == Installing the Build
>
>
> == Deploying Installation
>
>
> == Executing Tests
>
>
> == Executing cppcheck
>
>
> == Performing lcov processing
>
>
> == Extracting dependency information from CMake
>
>
> == Run Completed Successfully
>
>

I'm unsure, try cleaning the build directory and trying again?
There certainly hasn't been a change on the kf5 side, that I know of at
least.

Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KUnitConversion

[Garret Wassermann]

> I'm the maintainer for KUnitConversion, you can find the maintainer in
> the metainfo.yaml file in each Framework repo [aside: perhaps we need
> to generate a page with this listed?].  I'm also the person looking at
> KStandards, or KCodes as I'm now calling it.  For now KCodes will be
> sticking to the ISO code support and not doing any unit conversion
> stuff, that's a long way away if at all. At the moment I'm talking to
> the Wikidata people about improving their ISO code data so we can just
> become a consumer of their data, rather than having to maintain it on
> our own. I'm hoping to have that resolved soon and will push the code
> forward at that point.

Hi John,
Thanks for the info! I am new to much of this stuff, so let me ask a
potentially dumb question -- what are the ISO codes? From past
conversations I assume you mean switching between formats/currencies
for different countries, but I would appreciate any elaboration so
I understand what is going on and how to help better.

Would unit conversions even go together with the ISO codes, or
would they be better off split off as two different libraries? (perhaps
KStandards for unit conversions and KCodes for ISO?)

> KUnitConversion does have it's limitations which is why I'm thinking
> about how to improve or replace it, but that won't happen any time
> soon so it's best to keep improving it in the meantime.  The main
> thing I dislike is every unit regardless of category being in a single
> enum, which can lead to nonsense like trying to convert 1 meter in
> degrees Celsius. That's a version 2 fix though

That bothers me as well. I am also bothered by what seems to be
(from my admittedly quick look over the source code) a lack of
extensibility. More below.

> You say there are units and features you need
> that we don't support?  The obvious place to start is to implement
> those in the existing library so we understand them better if once we
> get around to designing a new api.  The best place to discuss these is
> always here on list, so can you say what it is you are missing?

A little bit of context -- I'm working on some academic software
and think proper unit conversion would be a great help for some
problems long term. I have done work with electricity/magnetism in
past, but am currently working on a heat transfer project.

Volts, Amperes, Ohms, Teslas and the like are missing, despite being
regular SI units (although magnetism especially uses many CGS
units, so this is where I think such a library may come in handy).

>From heat transfer, more compound units such as a thermal conductivity
(watt per meter-kelvin) are missing, and of course being able
to translate between metric and the old BTUs would be nice.

I am glad to start adding these units to play with the idea, but I think
ultimately it shows a limitation of the current design. It is missing
a few SI base units, and several categories of common units,
and the thought of adding a new category for EVERYTHING out there
seems a bit silly.

A library that allows one to define new derived units in terms of
base units and register them with the library would be really cool.
it could be useful for anyone no matter how specialized the field,
rather than having to update the library itself every time someone
wants a new unit.

I would also like to see a library that allows basic arithmetic with
these units. Perhaps overloaded operators to allow one to add or
multiply quantities and preserve the correct resulting units.
Being able to for example set a = 2 kg, and b = 9.8 m/s^2,
then type c = a * b and have the library know that
c has the unit of Newtons now (or at least, know how to combine
the units and show the resulting kg*m/s^2 and check that it is
equivalent to a newton). It will be useful
as a sanity check on my work, though I also see this being
useful for more educational oriented software.

Obviously this is my whole laundry list of ideas/interests. I am not
sure what is feasible and what might be harder than I expect, but
if we can bounce ideas around and settle on a path forward, I will
be glad to contribute when I can!

In the meantime, I can write up some basic classes for the extra
units I currently need, and see how that fits into the library.

Thanks for your help,

Garret
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework

[Eike Hein]

> On July 15, 2014, 6:27 a.m., Kevin Ottens wrote:
> > Note that as mentioned in the "Web Shortcuts KCM" thread, I'm very much not 
> > in favor of such a code move.

kde-frameworks-devel ended up discussing this extensively and in the end things 
seemed to settle on "it's a go" -- David, can I get a ship it?


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119280/#review62372
---


On July 14, 2014, 8:36 p.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119280/
> ---
> 
> (Updated July 14, 2014, 8:36 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> As discussed, this adds the Web Shortcuts KCM, formerly shipped as part as 
> Konqueror, to the KIO framework, where the URI Filters framework it 
> configures resides as well. This makes more sense than stuffing it into 
> workspace, since Web Shortcuts have many app level downstreams (e.g. 
> Konversation, Okular and Konsole) which try to run the KCM via kcmshell5, and 
> may not be running inside Plasma Desktop at the time.
> 
> I've lightly modified the code to make it build, and made the naming more 
> consistent - "webshortcuts" is now used throughout where previously was a mix 
> of "ebrowsing" and "kurifilt". This means .po name changed, but the KCM only 
> contains a single string. More importantly it means apps calling the KCM via 
> kcmshell5 need to be changed to use the new name - I promise to take care of 
> that.
> 
> I'm the least confident on the CMake stuff, especially the TRANSLATION_DOMAIN 
> redefinition, so I'd be happy for review.
> 
> Note the categorization is already what the recategorization effort 
> proscribed for this KCM.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6f8373f 
>   src/kcms/CMakeLists.txt PRE-CREATION 
>   src/kcms/webshortcuts/CMakeLists.txt PRE-CREATION 
>   src/kcms/webshortcuts/Messages.sh PRE-CREATION 
>   src/kcms/webshortcuts/main.h PRE-CREATION 
>   src/kcms/webshortcuts/main.cpp PRE-CREATION 
>   src/kcms/webshortcuts/webshortcuts.desktop PRE-CREATION 
>   src/urifilters/ikws/CMakeLists.txt 4efe24e 
> 
> Diff: https://git.reviewboard.kde.org/r/119280/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework

[Eike Hein]

> On July 15, 2014, 5:37 a.m., Martin Gräßlin wrote:
> > The code is GPLv2+ - is that allowed in frameworks?
> 
> Jonathan Riddell wrote:
> Yes.  From licence policy: "Source files that are part of a library with 
> a public API which is part of the KDE Platform" but a kcm isn't part of a 
> public API

And it seems there are other GPL'd KCMs in kio already (as pointed out by 
Riddell).


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119280/#review62370
---


On July 14, 2014, 8:36 p.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119280/
> ---
> 
> (Updated July 14, 2014, 8:36 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> As discussed, this adds the Web Shortcuts KCM, formerly shipped as part as 
> Konqueror, to the KIO framework, where the URI Filters framework it 
> configures resides as well. This makes more sense than stuffing it into 
> workspace, since Web Shortcuts have many app level downstreams (e.g. 
> Konversation, Okular and Konsole) which try to run the KCM via kcmshell5, and 
> may not be running inside Plasma Desktop at the time.
> 
> I've lightly modified the code to make it build, and made the naming more 
> consistent - "webshortcuts" is now used throughout where previously was a mix 
> of "ebrowsing" and "kurifilt". This means .po name changed, but the KCM only 
> contains a single string. More importantly it means apps calling the KCM via 
> kcmshell5 need to be changed to use the new name - I promise to take care of 
> that.
> 
> I'm the least confident on the CMake stuff, especially the TRANSLATION_DOMAIN 
> redefinition, so I'd be happy for review.
> 
> Note the categorization is already what the recategorization effort 
> proscribed for this KCM.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6f8373f 
>   src/kcms/CMakeLists.txt PRE-CREATION 
>   src/kcms/webshortcuts/CMakeLists.txt PRE-CREATION 
>   src/kcms/webshortcuts/Messages.sh PRE-CREATION 
>   src/kcms/webshortcuts/main.h PRE-CREATION 
>   src/kcms/webshortcuts/main.cpp PRE-CREATION 
>   src/kcms/webshortcuts/webshortcuts.desktop PRE-CREATION 
>   src/urifilters/ikws/CMakeLists.txt 4efe24e 
> 
> Diff: https://git.reviewboard.kde.org/r/119280/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework

[Jonathan Riddell]

> On July 15, 2014, 5:37 a.m., Martin Gräßlin wrote:
> > The code is GPLv2+ - is that allowed in frameworks?

Yes.  From licence policy: "Source files that are part of a library with a 
public API which is part of the KDE Platform" but a kcm isn't part of a public 
API


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119280/#review62370
---


On July 14, 2014, 8:36 p.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119280/
> ---
> 
> (Updated July 14, 2014, 8:36 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> As discussed, this adds the Web Shortcuts KCM, formerly shipped as part as 
> Konqueror, to the KIO framework, where the URI Filters framework it 
> configures resides as well. This makes more sense than stuffing it into 
> workspace, since Web Shortcuts have many app level downstreams (e.g. 
> Konversation, Okular and Konsole) which try to run the KCM via kcmshell5, and 
> may not be running inside Plasma Desktop at the time.
> 
> I've lightly modified the code to make it build, and made the naming more 
> consistent - "webshortcuts" is now used throughout where previously was a mix 
> of "ebrowsing" and "kurifilt". This means .po name changed, but the KCM only 
> contains a single string. More importantly it means apps calling the KCM via 
> kcmshell5 need to be changed to use the new name - I promise to take care of 
> that.
> 
> I'm the least confident on the CMake stuff, especially the TRANSLATION_DOMAIN 
> redefinition, so I'd be happy for review.
> 
> Note the categorization is already what the recategorization effort 
> proscribed for this KCM.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6f8373f 
>   src/kcms/CMakeLists.txt PRE-CREATION 
>   src/kcms/webshortcuts/CMakeLists.txt PRE-CREATION 
>   src/kcms/webshortcuts/Messages.sh PRE-CREATION 
>   src/kcms/webshortcuts/main.h PRE-CREATION 
>   src/kcms/webshortcuts/main.cpp PRE-CREATION 
>   src/kcms/webshortcuts/webshortcuts.desktop PRE-CREATION 
>   src/urifilters/ikws/CMakeLists.txt 4efe24e 
> 
> Diff: https://git.reviewboard.kde.org/r/119280/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119530: kcoreaddons: Fix kautosave doesn't work with more than 1 file per application

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119530/#review64423
---


I agree that further features should be developed in conjunction with an 
application for a real use case.

E.g. I'm not sure there's a use case for "all autosavefiles for all apps"...


autotests/kautosavefiletest.cpp


Well, I meant that there's a QVERIFY here and not in the other two loops 
that follow. Pretty inconsistent ;)



autotests/kautosavefiletest.cpp


It can - as long as the function returns void.



autotests/kautosavefiletest.cpp


unnecessary if before delete.



autotests/kautosavefiletest.cpp


Don't use bitfield operators on booleans, i.e. remove the '&' here since 
it's the first use.
Interestingly all the following ones are correct.



src/lib/io/kautosavefile.h


To me kautosavefile was about the KOffice/Calligra use case: saving into a 
temp file in order to recover the stuff typed by the user and not saved yet, in 
case of a crash.

For backups we also have KBackupFile, in kcoreaddons. This makes me a bit 
confused about who does what and what's the difference (between KBackupFile and 
KAutoSaveFile with this (new?) "backup" use case) for an app. Can you clarify?



src/lib/io/kautosavefile.h


remove spaces around 'x' ;)



src/lib/io/kautosavefile.cpp


space after ! should be removed



src/lib/io/kautosavefile.cpp


If .first is a URL, why not use QUrl in the first place as the data type? 
Otherwise I can see url/path confusions coming up



src/lib/io/kautosavefile.cpp


two spaces before applicationName, it seems



src/lib/io/kautosavefile_p.cpp


no space after !



src/lib/io/kautosavefile_p.cpp


I doubt that schemes can contain special characters ;) I'm even sure they 
can't. So encoded() isn't really useful (but ok, doesn't really hurt either)



src/lib/io/kautosavefile_p.cpp


one set of () too many


- David Faure


On Aug. 11, 2014, 9:22 p.m., Andreas Xavier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119530/
> ---
> 
> (Updated Aug. 11, 2014, 9:22 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> kautosave doesn't work when any app tries to use a second filename, because 
> it doesn't filter on filename.  The unit tests can be droppped into master to 
> show the problem, if you remove the include on line 21.
> 
> This patch:
> 1. Adds unit tests to test more behavior mentioned in the header.
> 2. Fixes kautosave working with multple files per application.
> 3. Fixes filenaming brittleness, which would cause kautosave to randomly fail 
> when the last 3 randomly generated characters in the filename matched any 3 
> consequtive chracters in the managed filename.
> 
> 
> Diffs
> -
> 
>   src/lib/io/kautosavefile_p.cpp PRE-CREATION 
>   src/lib/io/kautosavefile_p.h PRE-CREATION 
>   src/lib/io/kautosavefile.cpp 13a13d7 
>   src/lib/io/kautosavefile.h 05cc3ae 
>   src/lib/CMakeLists.txt 26eb5a1 
>   autotests/kautosavefiletest.h cf70f4c 
>   autotests/kautosavefiletest.cpp ec0309e 
>   ! PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119530/diff/
> 
> 
> Testing
> ---
> 
> Ran unit tests.
> Ran kdeedu with kanagram.
> 
> 
> Thanks,
> 
> Andreas Xavier
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel