Jenkins build is back to normal : knewstuff_master_qt5 #102

[KDE CI System]

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: knewstuff_master_qt5 #101

[KDE CI System]

See 

Changes:

[jpwhiting] Enable autotests.

--
[...truncated 39 lines...]
KDE Continuous Integration Build
== Building Project: knewstuff - Branch master
== Build Dependencies:
 kio - Branch master
 ki18n - Branch master
 kguiaddons - Branch master
 ktextwidgets - Branch master
 kglobalaccel - Branch master
 kservice - Branch master
 kcrash - Branch master
 kiconthemes - Branch master
 kcodecs - Branch master
 kdoctools - Branch master
 kxmlgui - Branch master
 extra-cmake-modules - Branch master
 karchive - Branch master
 kwindowsystem - Branch master
 kbookmarks - Branch master
 kdbusaddons - Branch master
 kjobwidgets - Branch master
 kwallet - Branch master
 kitemviews - Branch master
 kconfigwidgets - Branch master
 sonnet - Branch master
 phonon - Branch master
 knotifications - Branch master
 kcoreaddons - Branch master
 cmake - Branch master
 kwidgetsaddons - Branch master
 polkit-qt-1 - Branch master
 dogtail - Branch master
 kcompletion - Branch master
 kconfig - Branch master
 kauth - Branch master
 qt5 - Branch stable
 solid - Branch master
 attica - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Looking for __GLIBC__
-- Looking for __GLIBC__ - found
-- Performing Test _OFFT_IS_64BIT
-- Performing Test _OFFT_IS_64BIT - Success
-- Found Gettext: /usr/bin/msgmerge (found version "0.18.1") 
-- Found PythonInterp: /usr/bin/python (found version "2.7.3") 
CMake Warning (dev) at src/CMakeLists.txt:1 (project):
  Policy CMP0048 is not set: project() command manages VERSION variables.
  Run "cmake --help-policy CMP0048" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  The following variable(s) would be set to empty:

PROJECT_VERSION
PROJECT_VERSION_MAJOR
PROJECT_VERSION_MINOR
PROJECT_VERSION_PATCH
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- 
-- The following REQUIRED packages have been found:

 * ECM (required version >= 1.3.0)
 * Qt5Core (required version >= 5.3.1)
 * Qt5Gui (required version >= 5.3.1)
 * Qt5Widgets
 * Qt5Xml
 * KF5Archive (required version >= 5.3.0)
 * KF5Completion (required version >= 5.3.0)
 * KF5Config (required version >= 5.3.0)
 * KF5CoreAddons (required version >= 5.3.0)
 * Gettext
 * PythonInterp
 * KF5I18n (required version >= 5.3.0)
 * KF5IconThemes (required version >= 5.3.0)
 * KF5KIO (required version >= 5.3.0)
 * KF5ItemViews (required version >= 5.3.0)
 * KF5TextWidgets (required version >= 5.3.0)
 * KF5WidgetsAddons (required version >= 5.3.0)
 * KF5XmlGui (required version >= 5.3.0)
 * KF5Attica (required version >= 5.3.0) , A Qt library that implements the 
Open Collaboration Services API , 
   Support for Get Hot New Stuff in KNewStuff
 * Qt5Test
   Required for unit tests
 * Qt5 (required version >= 5.2.0)

-- Configuring done
-- Generating done
CMake Warning:
  Manually-specified variables were not used by the project:

KDE4_BUILD_TESTS
LIB_SUFFIX
SIP_DEFAULT_SIP_DIR


-- Build files have been written to: 


== Commencing the Build

Scanning dependencies of target knewstuffauthortest_automoc
Scanning dependencies of target KF5NewStuff_automoc
Scanning dependencies of target knewstuffentrytest_automoc
Scanning dependencies of target khotnewstuff_automoc
Scanning dependencies of target khotnewstuff_upload_automoc
[  1%] [  3%] [  7%] [  7%] [  9%] Automatic moc for target knewstuffauthortest
Automatic moc for target KF5NewStuff
Automatic moc for target knewstuffentrytest
Automatic moc for target khotnewstuff_upload
Automatic moc for target khotnewstuff
[  9%] [  9%] Built target khotnewstuff_upload_automoc
Built target khotnewstuff_automoc
Generating knewstuffentrytest.moc
Generating moc_xmlloader_p.cpp
[  9%] Built target knewstuffentrytest_automo

Re: Review Request 120592: enable autotests for knewstuff

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120592/
---

(Updated Oct. 15, 2014, 1:41 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Jeremy Whiting.


Repository: knewstuff


Description
---

Enable autotests.

Make autotests build in the sources they need to test to avoid exporting.
Patch by Albert Astals Cid 


Diffs
-

  autotests/CMakeLists.txt c210f70c493fc7febb9157f212e23c92042315c7 
  autotests/knewstuffentrytest.cpp fbf2e0d7478def609a2cb9912139a6bbc20197fc 

Diff: https://git.reviewboard.kde.org/r/120592/diff/


Testing
---

The tests build and pass here.


Thanks,

Jeremy Whiting

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120592: enable autotests for knewstuff

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120592/#review68423
---

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Oct. 14, 2014, 11:19 p.m., Jeremy Whiting wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120592/
> ---
> 
> (Updated Oct. 14, 2014, 11:19 p.m.)
> 
> 
> Review request for KDE Frameworks and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> ---
> 
> Enable autotests.
> 
> Make autotests build in the sources they need to test to avoid exporting.
> Patch by Albert Astals Cid 
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt c210f70c493fc7febb9157f212e23c92042315c7 
>   autotests/knewstuffentrytest.cpp fbf2e0d7478def609a2cb9912139a6bbc20197fc 
> 
> Diff: https://git.reviewboard.kde.org/r/120592/diff/
> 
> 
> Testing
> ---
> 
> The tests build and pass here.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: private export

[Jeremy Whiting]

Meh, Albert found a decent enough way to do it. Posted to rb to look at.

On Tue, Oct 14, 2014 at 5:03 PM, Aleix Pol  wrote:
> On Tue, Oct 14, 2014 at 10:37 PM, Jeremy Whiting  wrote:
>>
>> Hello,
>>
>> In KNewStuff autotests there are two disabled tests that build and
>> work if I export the Author and EntryInternal classes, but these two
>> classes are private (declared in _p.h files) so I'd rather not export
>> them, since they aren't public api. Is there a way to have them
>> exported when BUILD_TESTING is set only? I didn't see anything obvious
>> in the knewstuff_export.h generated header. I guess I could have the
>> class declarations wrapped in #ifdef BUILD_TESTING but that seems like
>> a hack. Is there a proper way to only export private classes when
>> building and running tests?
>>
>> thanks,
>> Jeremy
>
>
> You can do things like that with cmake library objects. See documentation
> for add_library(... OBJECT ...).
>
> It will make it possible for you to have objects in different targets so
> they are compiled once but in different places. I used it here as a test
> [1]. It's not magic, but it saves some compilation time and possible
> complexity.
>
> Cheers!
> Aleix
>
> [1] kde:scratch/apol/kanboardclient
>
> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 120592: Remove #ifndefs for WIN CE, we don't support CE anymore.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120592/
---

Review request for KDE Frameworks and Jeremy Whiting.


Repository: knewstuff


Description
---

Enable autotests.

Make autotests build in the sources they need to test to avoid exporting.
Patch by Albert Astals Cid 


Diffs
-

  autotests/CMakeLists.txt c210f70c493fc7febb9157f212e23c92042315c7 
  autotests/knewstuffentrytest.cpp fbf2e0d7478def609a2cb9912139a6bbc20197fc 

Diff: https://git.reviewboard.kde.org/r/120592/diff/


Testing
---

The tests build and pass here.


Thanks,

Jeremy Whiting

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120592: enable autotests for knewstuff

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120592/
---

(Updated Oct. 14, 2014, 5:19 p.m.)


Review request for KDE Frameworks and Jeremy Whiting.


Changes
---

Fix summary


Summary (updated)
-

enable autotests for knewstuff


Repository: knewstuff


Description
---

Enable autotests.

Make autotests build in the sources they need to test to avoid exporting.
Patch by Albert Astals Cid 


Diffs
-

  autotests/CMakeLists.txt c210f70c493fc7febb9157f212e23c92042315c7 
  autotests/knewstuffentrytest.cpp fbf2e0d7478def609a2cb9912139a6bbc20197fc 

Diff: https://git.reviewboard.kde.org/r/120592/diff/


Testing
---

The tests build and pass here.


Thanks,

Jeremy Whiting

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: private export

[Aleix Pol]

On Tue, Oct 14, 2014 at 10:37 PM, Jeremy Whiting  wrote:

> Hello,
>
> In KNewStuff autotests there are two disabled tests that build and
> work if I export the Author and EntryInternal classes, but these two
> classes are private (declared in _p.h files) so I'd rather not export
> them, since they aren't public api. Is there a way to have them
> exported when BUILD_TESTING is set only? I didn't see anything obvious
> in the knewstuff_export.h generated header. I guess I could have the
> class declarations wrapped in #ifdef BUILD_TESTING but that seems like
> a hack. Is there a proper way to only export private classes when
> building and running tests?
>
> thanks,
> Jeremy
>

You can do things like that with cmake library objects. See documentation
for add_library(... OBJECT ...).

It will make it possible for you to have objects in different targets so
they are compiled once but in different places. I used it here as a test
[1]. It's not magic, but it saves some compilation time and possible
complexity.

Cheers!
Aleix

[1] kde:scratch/apol/kanboardclient
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

private export

[Jeremy Whiting]

Hello,

In KNewStuff autotests there are two disabled tests that build and
work if I export the Author and EntryInternal classes, but these two
classes are private (declared in _p.h files) so I'd rather not export
them, since they aren't public api. Is there a way to have them
exported when BUILD_TESTING is set only? I didn't see anything obvious
in the knewstuff_export.h generated header. I guess I could have the
class declarations wrapped in #ifdef BUILD_TESTING but that seems like
a hack. Is there a proper way to only export private classes when
building and running tests?

thanks,
Jeremy
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 120589: Remove #ifndefs for WIN CE, we don't support CE anymore.

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120589/
---

Review request for KDE Frameworks, Nicolás Alvarez and Jeremy Whiting.


Repository: knewstuff


Description
---

Remove #ifndefs for WIN CE, we don't support CE anymore.


Diffs
-

  src/core/installation.cpp b69837db5b9ec05bce0a9c7bdc854fa0c9391f0e 

Diff: https://git.reviewboard.kde.org/r/120589/diff/


Testing
---

It still builds on linux, though I didn't modify any linux code. Someone to 
test on windows would be awesome.


Thanks,

Jeremy Whiting

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120574: Add explicit to ctors with one parameter

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120574/
---

(Updated Oct. 14, 2014, 7:47 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, David Faure, Vavelin Kevin, and Jeremy 
Whiting.


Repository: knewstuff


Description
---

Add explicit to ctors with one parameter


Diffs
-

  src/attica/atticaprovider_p.h 8638aff0e6548705a22f125a7adc25ff6b1db165 
  src/button.h 155b6dc5f4b032970bcd0e5400cf5dba12f76e81 
  src/core/engine_p.h f7a6884d9a22c56f1feff8b6c97fa242f46533da 
  src/core/installation_p.h 9d855a26590dcee2259fe657fc7c3293669e3f81 
  src/core/xmlloader_p.h 7167417c1fcfbeafea1ceb9c7cb5eb56b9d8ac29 
  src/downloadwidget_p.h 37c7f0872fe0ff6fe65ab7bc63e1239f1b0d8e36 
  src/ui/itemsview_p.h df65d0b47abaddd404a171890e47af1b93c4203f 
  src/ui/progressindicator_p.h 3d18bff8eac6b8a21f94da39b21b51ee334ec3de 

Diff: https://git.reviewboard.kde.org/r/120574/diff/


Testing
---

It builds and khotnewstuff test app still works.

My only question is if this source incompatible change is allowed in frameworks 
or not.


Thanks,

Jeremy Whiting

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Gerrit available for trial

[David Faure]

On Tuesday 14 October 2014 10:47:34 Jan Kundrát wrote:
> On Friday, 10 October 2014 22:57:26 CEST, David Faure wrote:
> > However I can't add the KDE contributors that I want, to the request.
> > They all have a KDE identity account, but obviously didn't create a gerrit
> > account yet.
> 
> Hi David, all KDE developers are now available in Gerrit, so you can start
> adding them to review requests now.

Thank you! This really rocks.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120574: Add explicit to ctors with one parameter

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120574/#review68414
---

Ship it!


This is technically source incompatible, but only for cases where the code had 
a horrendous mistake like
 QLabel label(new QLabel(this));
 (replace QLabel with your own class names)
so yes, better break at compile-time than show really weird stuff at runtime.

The only ctor which didn't take a parent pointer as the argument was in a 
private class, so no problem.

- David Faure


On Oct. 14, 2014, 4:11 p.m., Jeremy Whiting wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120574/
> ---
> 
> (Updated Oct. 14, 2014, 4:11 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure, Vavelin Kevin, and Jeremy 
> Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> ---
> 
> Add explicit to ctors with one parameter
> 
> 
> Diffs
> -
> 
>   src/attica/atticaprovider_p.h 8638aff0e6548705a22f125a7adc25ff6b1db165 
>   src/button.h 155b6dc5f4b032970bcd0e5400cf5dba12f76e81 
>   src/core/engine_p.h f7a6884d9a22c56f1feff8b6c97fa242f46533da 
>   src/core/installation_p.h 9d855a26590dcee2259fe657fc7c3293669e3f81 
>   src/core/xmlloader_p.h 7167417c1fcfbeafea1ceb9c7cb5eb56b9d8ac29 
>   src/downloadwidget_p.h 37c7f0872fe0ff6fe65ab7bc63e1239f1b0d8e36 
>   src/ui/itemsview_p.h df65d0b47abaddd404a171890e47af1b93c4203f 
>   src/ui/progressindicator_p.h 3d18bff8eac6b8a21f94da39b21b51ee334ec3de 
> 
> Diff: https://git.reviewboard.kde.org/r/120574/diff/
> 
> 
> Testing
> ---
> 
> It builds and khotnewstuff test app still works.
> 
> My only question is if this source incompatible change is allowed in 
> frameworks or not.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 120586: Fix KPluginSelector not adding non .desktop file plugins

[Alexander Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120586/
---

Review request for KDE Frameworks.


Repository: kcmutils


Description
---

KPluginSelector always assumed those plugins had already been added to
the list because it only compares KPluginInfo::entryPath() for equality
which returns an empty string if the plugin metadata was loaded directly
from the shared library. Therefore as soon as one plugin with the
metadata embedded into the library had been loaded all others would
compare equal to that.

Is this the correct fix or should KPluginInfo::entryPath() be changed?


Diffs
-

  src/kpluginselector_p.h 43648114224f476ea3c30f6bd255206f9c415d21 

Diff: https://git.reviewboard.kde.org/r/120586/diff/


Testing
---


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem

[Marco Martin]

> On Oct. 13, 2014, 1:35 p.m., Marco Martin wrote:
> > src/quickaddons/managedtexturenode.h, line 52
> > 
> >
> > even if will always remain just this member, just to me sure, it should 
> > be in a dpointer
> 
> Aleix Pol Gonzalez wrote:
> I don't think it's a good idea to add a d-pointer there. It's a class to 
> encapsulate the object, I don't see why we should store more things in there.
> 
> If needs changed, then I'd suggest to create another class.
> 
> Marco Martin wrote:
> if it's exported, i prefer a dpointer anyways
> 
> Aleix Pol Gonzalez wrote:
> Can we please discuss this? I really don't think we want to be so cheap 
> when it comes to memory usage. This means that each node in the scene will 
> take a payload for no much reason.
> 
> Vishesh Handa wrote:
> It's not only about memory usage. The memory gets defragmented as well.
> 
> Also, maybe considering this class is so small, you may want to inline 
> the function definitions.

heap fragmentation may be a valid argument, yeah


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120550/#review68307
---


On Oct. 13, 2014, 5:54 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120550/
> ---
> 
> (Updated Oct. 13, 2014, 5:54 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma, David Edmundson, and Marco Martin.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> Moves the caching types used in Plasma Workspace into a QuickAddons submodule.
> 
> Adopts them in QIconItem by moving it from a QPainterItem to a QQuickPainter 
> item. Uses the same strategies used in Plasma Framework for caching the 
> textures.
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 2977812 
>   src/qmlcontrols/kquickcontrolsaddons/qiconitem.h 839a33f 
>   src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp 0eb46b1 
>   src/quickaddons/CMakeLists.txt PRE-CREATION 
>   src/quickaddons/imagetexturescache.h PRE-CREATION 
>   src/quickaddons/imagetexturescache.cpp PRE-CREATION 
>   src/quickaddons/managedtexturenode.h PRE-CREATION 
>   src/quickaddons/managedtexturenode.cpp PRE-CREATION 
>   tests/qiconitem_test.qml PRE-CREATION 
>   src/CMakeLists.txt eb0dfd3 
> 
> Diff: https://git.reviewboard.kde.org/r/120550/diff/
> 
> 
> Testing
> ---
> 
> I added some manual test (that was impossible to run before the patch). Also 
> tested it in KRunner and Muon Discover, which use the component. Everything 
> still works.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120574: Add explicit to ctors with one parameter

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120574/
---

(Updated Oct. 14, 2014, 10:11 a.m.)


Review request for KDE Frameworks, David Faure, Vavelin Kevin, and Jeremy 
Whiting.


Changes
---

Added Kevin and David to weigh in.


Repository: knewstuff


Description
---

Add explicit to ctors with one parameter


Diffs
-

  src/attica/atticaprovider_p.h 8638aff0e6548705a22f125a7adc25ff6b1db165 
  src/button.h 155b6dc5f4b032970bcd0e5400cf5dba12f76e81 
  src/core/engine_p.h f7a6884d9a22c56f1feff8b6c97fa242f46533da 
  src/core/installation_p.h 9d855a26590dcee2259fe657fc7c3293669e3f81 
  src/core/xmlloader_p.h 7167417c1fcfbeafea1ceb9c7cb5eb56b9d8ac29 
  src/downloadwidget_p.h 37c7f0872fe0ff6fe65ab7bc63e1239f1b0d8e36 
  src/ui/itemsview_p.h df65d0b47abaddd404a171890e47af1b93c4203f 
  src/ui/progressindicator_p.h 3d18bff8eac6b8a21f94da39b21b51ee334ec3de 

Diff: https://git.reviewboard.kde.org/r/120574/diff/


Testing
---

It builds and khotnewstuff test app still works.

My only question is if this source incompatible change is allowed in frameworks 
or not.


Thanks,

Jeremy Whiting

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kde-baseapps_frameworks_qt5 #141

[KDE CI System]

See 

Changes:

[me] Port Dolphin to the new Baloo APIs

--
[...truncated 2955 lines...]
   KDialog *regExpDialog;
^
:134:8:
 warning: ‘KUrl’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109)
 [-Wdeprecated-declarations]
   KUrl m_url;
^
In file included from 
:9:0,
 from 
:6:
:51:33:
 warning: ‘KUrl’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109)
 [-Wdeprecated-declarations]
   void setPath(const KUrl & url );
 ^
:64:19:
 warning: ‘KUrl’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109)
 [-Wdeprecated-declarations]
   const KUrl& url()  {return m_url;}
   ^
:95:8:
 warning: ‘KUrl’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109)
 [-Wdeprecated-declarations]
   KUrl m_url;
^
In file included from 
:9:0,
 from 
:6:
:52:48:
 warning: ‘KUrl’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109)
 [-Wdeprecated-declarations]
 KUrl urlForIndex(const QModelIndex& index) const;
^
:55:44:
 warning: ‘KUrl’ is deprecated [-Wdeprecated-declarations]
 void openUrlInNewWindow(const KUrl& url);
^
:56:41:
 warning: ‘KUrl’ is deprecated [-Wdeprecated-declarations]
 void openUrlInNewTab(const KUrl& url);
 ^
In file included from 
:6:0:
:
 In static member function ‘static void 
KonqHistoryView::qt_static_metacall(QObject*, QMetaObject::Call, int, void**)’:
:116:72:
 warning: ‘KUrl’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109)
 [-Wdeprecated-declarations]
 case 0: _t->openUrlInNewWindow((*reinterpret_cast< const 
KUrl(*)>(_a[1]))); break;
^
:117:69:
 warning: ‘KUrl’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109)
 [-Wdeprecated-declarations]
 case 1: _t->openUrlInNewTab((*reinterpret_cast< const 
KUrl(*)>(_a[1]))); break;
 ^
:134:62:
 warning: ‘KUrl’ is deprecated [-Wdeprecated-declarations]
 typedef void (KonqHistoryView::*_t)(const KUrl & );
  ^
:140:62:
 warning: ‘KUrl’ is deprecated [-Wdeprecated-declarations]
 typedef void (KonqHistoryView::*_t)(const KUrl & );
  ^

Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem

[Vishesh Handa]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120550/#review68396
---



src/quickaddons/imagetexturescache.h


Strange indentation.


- Vishesh Handa


On Oct. 13, 2014, 5:54 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120550/
> ---
> 
> (Updated Oct. 13, 2014, 5:54 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma, David Edmundson, and Marco Martin.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> Moves the caching types used in Plasma Workspace into a QuickAddons submodule.
> 
> Adopts them in QIconItem by moving it from a QPainterItem to a QQuickPainter 
> item. Uses the same strategies used in Plasma Framework for caching the 
> textures.
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 2977812 
>   src/qmlcontrols/kquickcontrolsaddons/qiconitem.h 839a33f 
>   src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp 0eb46b1 
>   src/quickaddons/CMakeLists.txt PRE-CREATION 
>   src/quickaddons/imagetexturescache.h PRE-CREATION 
>   src/quickaddons/imagetexturescache.cpp PRE-CREATION 
>   src/quickaddons/managedtexturenode.h PRE-CREATION 
>   src/quickaddons/managedtexturenode.cpp PRE-CREATION 
>   tests/qiconitem_test.qml PRE-CREATION 
>   src/CMakeLists.txt eb0dfd3 
> 
> Diff: https://git.reviewboard.kde.org/r/120550/diff/
> 
> 
> Testing
> ---
> 
> I added some manual test (that was impossible to run before the patch). Also 
> tested it in KRunner and Muon Discover, which use the component. Everything 
> still works.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem

[Vishesh Handa]

> On Oct. 13, 2014, 1:35 p.m., Marco Martin wrote:
> > src/quickaddons/managedtexturenode.h, line 52
> > 
> >
> > even if will always remain just this member, just to me sure, it should 
> > be in a dpointer
> 
> Aleix Pol Gonzalez wrote:
> I don't think it's a good idea to add a d-pointer there. It's a class to 
> encapsulate the object, I don't see why we should store more things in there.
> 
> If needs changed, then I'd suggest to create another class.
> 
> Marco Martin wrote:
> if it's exported, i prefer a dpointer anyways
> 
> Aleix Pol Gonzalez wrote:
> Can we please discuss this? I really don't think we want to be so cheap 
> when it comes to memory usage. This means that each node in the scene will 
> take a payload for no much reason.

It's not only about memory usage. The memory gets defragmented as well.

Also, maybe considering this class is so small, you may want to inline the 
function definitions.


- Vishesh


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120550/#review68307
---


On Oct. 13, 2014, 5:54 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120550/
> ---
> 
> (Updated Oct. 13, 2014, 5:54 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma, David Edmundson, and Marco Martin.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> Moves the caching types used in Plasma Workspace into a QuickAddons submodule.
> 
> Adopts them in QIconItem by moving it from a QPainterItem to a QQuickPainter 
> item. Uses the same strategies used in Plasma Framework for caching the 
> textures.
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 2977812 
>   src/qmlcontrols/kquickcontrolsaddons/qiconitem.h 839a33f 
>   src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp 0eb46b1 
>   src/quickaddons/CMakeLists.txt PRE-CREATION 
>   src/quickaddons/imagetexturescache.h PRE-CREATION 
>   src/quickaddons/imagetexturescache.cpp PRE-CREATION 
>   src/quickaddons/managedtexturenode.h PRE-CREATION 
>   src/quickaddons/managedtexturenode.cpp PRE-CREATION 
>   tests/qiconitem_test.qml PRE-CREATION 
>   src/CMakeLists.txt eb0dfd3 
> 
> Diff: https://git.reviewboard.kde.org/r/120550/diff/
> 
> 
> Testing
> ---
> 
> I added some manual test (that was impossible to run before the patch). Also 
> tested it in KRunner and Muon Discover, which use the component. Everything 
> still works.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120581: Don't crash if the plasmoid wasn't properly loaded

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120581/
---

(Updated Oct. 14, 2014, 1:46 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

If d->applet->package().isValid(), then d->qmlObject->mainComponent() is null.

This makes Plasma crash when a plasmoid is loaded.


Diffs
-

  src/plasmaquick/appletquickitem.cpp 45055a5 

Diff: https://git.reviewboard.kde.org/r/120581/diff/


Testing
---

Doesn't crash anymore.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120581: Don't crash if the plasmoid wasn't properly loaded

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120581/#review68390
---

Ship it!


Inviala!

- Marco Martin


On Ott. 14, 2014, 1:09 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120581/
> ---
> 
> (Updated Ott. 14, 2014, 1:09 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> If d->applet->package().isValid(), then d->qmlObject->mainComponent() is null.
> 
> This makes Plasma crash when a plasmoid is loaded.
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/appletquickitem.cpp 45055a5 
> 
> Diff: https://git.reviewboard.kde.org/r/120581/diff/
> 
> 
> Testing
> ---
> 
> Doesn't crash anymore.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 120581: Don't crash if the plasmoid wasn't properly loaded

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120581/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

If d->applet->package().isValid(), then d->qmlObject->mainComponent() is null.

This makes Plasma crash when a plasmoid is loaded.


Diffs
-

  src/plasmaquick/appletquickitem.cpp 45055a5 

Diff: https://git.reviewboard.kde.org/r/120581/diff/


Testing
---

Doesn't crash anymore.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120443: Add ctags configuration option to highlighting

[Bastian Holst]

> On Okt. 10, 2014, 7:55 nachm., Christoph Cullmann wrote:
> > Hi, I think that should not be in KTextEditor.
> > Thats really special and given that only a very limited amount of languages 
> > with ctags specials exists, it would make more sense to just have a 
> > heuristic in the project plugin to figure that out on its own.
> 
> Dominik Haumann wrote:
> I agree with Christoph here.

Ok, you are right. what about the part that exposes the languagee detection in 
the API?


- Bastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120443/#review68224
---


On Sept. 30, 2014, 8:34 nachm., Bastian Holst wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120443/
> ---
> 
> (Updated Sept. 30, 2014, 8:34 nachm.)
> 
> 
> Review request for KDE Frameworks and Christoph Cullmann.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> ---
> 
> Add ctags configuration option to highlighting
> 
> I need the added function to ask for the ctags command from kate's project 
> plugin. I am still not sure if this is the right place to add the function. 
> What do you think?
> 
> 
> Diffs
> -
> 
>   src/document/katedocument.cpp 82363ed73bac515918b99d935cfc53d667bde3f7 
>   src/include/ktexteditor/mainwindow.h 
> bfee68a6536282d4ac58fc6adf16349b0d514d0b 
>   src/mode/katemodemanager.h e249913483cd184e9c66066bc49907fd49325a9d 
>   src/mode/katemodemanager.cpp 694ca6219c80b8812f86912e58f3c14fe9324f92 
>   src/syntax/data/haskell.xml f0e7f8f955ea9cd56795add8de03c6627313301a 
>   src/syntax/data/katehighlightingindexer.cpp 
> 3f02e8c2a76e471489bc6df2a9f4ac0463c3afe0 
>   src/syntax/data/language.xsd 3f20304efe9c7a29df0dbe0a822196ec612437e8 
>   src/syntax/data/literate-haskell.xml 
> f69dbc56d7effbfa02398456cea616f0fce2d706 
>   src/syntax/katehighlight.h 237cf1a1837a4cf7d530be5a6a74ba9df7d0f8b7 
>   src/syntax/katesyntaxmanager.h 94c2b597cb0935feea01e454ba92eddc24be7af6 
>   src/syntax/katesyntaxmanager.cpp c51fbaf9eb230dfd1fb1602000860bf21a5cd8ce 
>   src/utils/mainwindow.cpp 6e664a9e7d0d9301ef12d9b1d7050fa2e3007d6f 
> 
> Diff: https://git.reviewboard.kde.org/r/120443/diff/
> 
> 
> Testing
> ---
> 
> Testing with modified version of Kates project plugin 
> (https://git.reviewboard.kde.org/r/120444/).
> 
> 
> Thanks,
> 
> Bastian Holst
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Gerrit available for trial

[Jan Kundrát]

On Friday, 10 October 2014 22:57:26 CEST, David Faure wrote:

However I can't add the KDE contributors that I want, to the request.
They all have a KDE identity account, but obviously didn't create a gerrit 
account yet.


Hi David, all KDE developers are now available in Gerrit, so you can start 
adding them to review requests now.


They will still have to upload their SSH keys once they want to start 
pushing stuff through Gerrit.


With kind regards,
Jan

--
Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel