Review Request 121082: Add TODO for private signals in KJob

2014-11-09 Thread Kevin Funk 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121082/
---

Review request for KDE Frameworks.


Repository: kcoreaddons


Description
---

Can't change that now because it would be BIC.


Diffs
-

  src/lib/jobs/kjob.h d4b7abd3774626f450aadb4e43185ed5bb654792 

Diff: https://git.reviewboard.kde.org/r/121082/diff/


Testing
---


Thanks,

Kevin Funk

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: How to port KTabBar::mouseMiddleClick?

2014-11-09 Thread Frank Reininghaus 
Hi,

2014-11-06 2:59 GMT+01:00 Milian Wolff:
> Hey all,
>
> what do I do to get middle-click-closes-tab in Qt 5 without KTabBar?
> Previously, we used KTabBar and its mouseMiddleClick signal.

AFAIK, currently the only solution is to subclass QTabBar, override
the mousePressEvent method and emit a signal from there. Dolphin uses
this approach. There were many other reasons why Emmanuel created a
custom QTabBar subclass for Dolphin though .

If many apps need the "middle click to close" bevavior, then
reanimating KTabBar or getting this functionality into QTabBar might
be better than making every app create its own tab bar class.

Best regards,
Frank
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121086: Rename jpegcreatorsettings.kcfg to avoid conflicts with KDE4

2014-11-09 Thread Armin K. 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121086/
---

Review request for KDE Runtime, KDE Frameworks and Plasma.


Repository: kio-extras


Description
---

Simply add 5 as a suffix to avoid conflicts with KDE 4 version which
is shipped in KDE-Runtime which isn't going away any time now.


Diffs
-

  thumbnail/CMakeLists.txt e9ab79b 
  thumbnail/jpegcreator.cpp de4902b 
  thumbnail/jpegcreatorsettings.kcfg 8f68f46 
  thumbnail/jpegcreatorsettings.kcfgc 3f6cdab 
  thumbnail/jpegcreatorsettings5.kcfg PRE-CREATION 
  thumbnail/jpegcreatorsettings5.kcfgc PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/121086/diff/


Testing
---


Thanks,

Armin K.

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121084: Rename libmolletnetwork to avoid conflict with KDE4

2014-11-09 Thread Armin K. 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121084/
---

Review request for KDE Runtime, KDE Frameworks and Plasma.


Repository: kio-extras


Description
---

KDE-Runtime already provides libmolletnetwork, so lets rename
this one to include 5 as a suffix since many apps outside of
KDE still depend on KDE-Runtime.


Diffs
-

  network/ioslave/CMakeLists.txt 06a964d 
  network/kded/CMakeLists.txt 3be676e 
  network/network/CMakeLists.txt c0fb43e 

Diff: https://git.reviewboard.kde.org/r/121084/diff/


Testing
---


Thanks,

Armin K.

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121082: Add TODO for private signals in KJob

2014-11-09 Thread Alexander Richardson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121082/#review70124
---

Ship it!


Ship It!

- Alexander Richardson


On Nov. 9, 2014, 10:49 vorm., Kevin Funk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121082/
> ---
> 
> (Updated Nov. 9, 2014, 10:49 vorm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Can't change that now because it would be BIC.
> 
> 
> Diffs
> -
> 
>   src/lib/jobs/kjob.h d4b7abd3774626f450aadb4e43185ed5bb654792 
> 
> Diff: https://git.reviewboard.kde.org/r/121082/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121082: Add TODO for private signals in KJob

2014-11-09 Thread Alexander Richardson 


> On Nov. 9, 2014, 8:09 nachm., Alexander Richardson wrote:
> > Ship It!

Strangely enough you can connect using new-style syntax when you use clang... 
Sorry for breakig the kdevplatform build


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121082/#review70124
---


On Nov. 9, 2014, 10:49 vorm., Kevin Funk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121082/
> ---
> 
> (Updated Nov. 9, 2014, 10:49 vorm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Can't change that now because it would be BIC.
> 
> 
> Diffs
> -
> 
>   src/lib/jobs/kjob.h d4b7abd3774626f450aadb4e43185ed5bb654792 
> 
> Diff: https://git.reviewboard.kde.org/r/121082/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121076: Do not require KF5::Su on Windows

2014-11-09 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121076/#review70147
---

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Nov. 8, 2014, 10:14 p.m., Andrius da Costa Ribas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121076/
> ---
> 
> (Updated Nov. 8, 2014, 10:14 p.m.)
> 
> 
> Review request for KDE Base Apps, KDE Frameworks and kdewin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> ---
> 
> kdepasswd, which requires it, is already disabled on Windows. There is also 
> konq-plugins/shellcmdplugins which was also disabled on Windows, but 
> konq-plugins is entirely disabled now.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt f02b069 
> 
> Diff: https://git.reviewboard.kde.org/r/121076/diff/
> 
> 
> Testing
> ---
> 
> It builds (MSVC2013 - 64bit) after this patch (along other patches I'm 
> sending to review today). Kdebase-apps is still not very functional, though 
> (missing icons and weird UI).
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121078: Fix exports.

2014-11-09 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121078/#review70148
---

Ship it!


Looks good to me, really useful and definitely a step forward towards a ported 
dolphin.

I'm saying shipit because I've ended having to do that in many projects 
already. Thanks!

- Aleix Pol Gonzalez


On Nov. 8, 2014, 10:25 p.m., Andrius da Costa Ribas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121078/
> ---
> 
> (Updated Nov. 8, 2014, 10:25 p.m.)
> 
> 
> Review request for KDE Base Apps, KDE Frameworks and kdewin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> ---
> 
> Use CMake's generate_export_header whenever possible, and fix some 
> inconsistent exports.
> Also, use Q_DECL_EXPORT consistently across occurrences of kdemain for 
> kdeinit apps (removing kdemacros.h where KDE_EXPORT was being in use).
> 
> 
> Diffs
> -
> 
>   dolphin/src/views/dolphinfileitemlistwidget.h 5f7c181 
>   dolphin/src/views/dolphinitemlistview.h 7fd72e5 
>   dolphin/src/views/versioncontrol/updateitemstatesthread.h 9b744d5 
>   dolphin/src/views/versioncontrol/versioncontrolobserver.h 034ef8b 
>   dolphin/src/views/viewmodecontroller.h 9ea717a 
>   dolphin/src/views/viewproperties.h d3ea428 
>   keditbookmarks/kbookmarkmodel/CMakeLists.txt 2f83af2 
>   keditbookmarks/kbookmarkmodel/kbookmarkmodel_export.h b759bf9 
>   keditbookmarks/main.cpp bc64193 
>   konqueror/client/kfmclient.cpp 276452b 
>   konqueror/src/CMakeLists.txt 6831c88 
>   konqueror/src/konq_statusbarmessagelabel.h a115d39 
>   konqueror/src/konqmain.cpp 7a73231 
>   konqueror/src/konqprivate_export.h 2dec78b 
>   dolphin/src/libdolphin_export.h ff0f125 
>   dolphin/src/main.cpp 91d32a0 
>   dolphin/src/kitemviews/private/kitemlistviewlayouter.h 0efcab1 
>   dolphin/src/CMakeLists.txt c074908 
>   dolphin/src/kitemviews/kfileitemlistview.h 9f07c9d 
>   dolphin/src/kitemviews/kfileitemlistwidget.h b7061d3 
>   dolphin/src/kitemviews/kfileitemmodel.h 535e0f3 
>   dolphin/src/kitemviews/kfileitemmodelrolesupdater.h e8b186a 
>   dolphin/src/kitemviews/kitemlistcontainer.h 55a9a11 
>   dolphin/src/kitemviews/kitemlistcontroller.h 99df531 
>   dolphin/src/kitemviews/kitemlistgroupheader.h 66fe929 
>   dolphin/src/kitemviews/kitemlistheader.h fe2d0ac 
>   dolphin/src/kitemviews/kitemlistselectionmanager.h c4decd3 
>   dolphin/src/kitemviews/kitemliststyleoption.h 782dd0e 
>   dolphin/src/kitemviews/kitemlistview.h cc0754f 
>   dolphin/src/kitemviews/kitemlistviewaccessible.h 674f1d1 
>   dolphin/src/kitemviews/kitemlistwidget.h 07fc789 
>   dolphin/src/kitemviews/kitemmodelbase.h 283cfa5 
>   dolphin/src/kitemviews/kstandarditem.h 59190bf 
>   dolphin/src/kitemviews/kstandarditemlistgroupheader.h 871c93d 
>   dolphin/src/kitemviews/kstandarditemlistview.h eb07c7f 
>   dolphin/src/kitemviews/kstandarditemlistwidget.h 7683f84 
>   dolphin/src/kitemviews/kstandarditemmodel.h 9d1db1a 
>   dolphin/src/kitemviews/private/kbaloorolesprovider.h f1ad5c7 
>   dolphin/src/kitemviews/private/kfileitemmodeldirlister.h 94a0e39 
>   dolphin/src/kitemviews/private/kfileitemmodelfilter.h e4fb0a2 
>   dolphin/src/kitemviews/private/kitemlistheaderwidget.h b99f45f 
>   dolphin/src/kitemviews/private/kitemlistkeyboardsearchmanager.h 661178d 
>   dolphin/src/kitemviews/private/kitemlistrubberband.h aea58af 
>   dolphin/src/kitemviews/private/kitemlistselectiontoggle.h 8a1a857 
>   dolphin/src/kitemviews/private/kitemlistsizehintresolver.h a0ad033 
>   dolphin/src/kitemviews/private/kitemlistsmoothscroller.h ea56822 
>   dolphin/src/kitemviews/private/kitemlistviewanimation.h e2e5338 
>   dolphin/src/kitemviews/private/kpixmapmodifier.h 4f863c3 
> 
> Diff: https://git.reviewboard.kde.org/r/121078/diff/
> 
> 
> Testing
> ---
> 
> It builds (MSVC2013 - 64bit) after this patch (along other patches I'm 
> sending to review today). Kdebase-apps is still not very functional, though 
> (missing icons and weird UI).
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

2014-11-09 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121080/#review70149
---


Shouldn't it be actually implemented then?

- Aleix Pol Gonzalez


On Nov. 8, 2014, 10:26 p.m., Andrius da Costa Ribas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121080/
> ---
> 
> (Updated Nov. 8, 2014, 10:26 p.m.)
> 
> 
> Review request for KDE Base Apps, KDE Frameworks and kdewin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> ---
> 
> Since we're not using kdemacros.h here anymore, KDE_DUMMY_QHASH_FUNCTION is 
> not available. Implement it instead.
> 
> 
> Diffs
> -
> 
>   lib/konq/src/konq_historyentry.h de34d6b 
> 
> Diff: https://git.reviewboard.kde.org/r/121080/diff/
> 
> 
> Testing
> ---
> 
> It builds (MSVC2013 - 64bit) after this patch (along other patches I'm 
> sending to review today). Kdebase-apps is still not very functional, though 
> (missing icons and weird UI).
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

2014-11-09 Thread Alexander Richardson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121080/#review70152
---


When I originally got KF5 to compile on windows I seem to remember having to do 
this a few times manually as well.

Would it make sense to add the macro to KCoreAddons?

- Alexander Richardson


On Nov. 8, 2014, 11:26 nachm., Andrius da Costa Ribas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121080/
> ---
> 
> (Updated Nov. 8, 2014, 11:26 nachm.)
> 
> 
> Review request for KDE Base Apps, KDE Frameworks and kdewin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> ---
> 
> Since we're not using kdemacros.h here anymore, KDE_DUMMY_QHASH_FUNCTION is 
> not available. Implement it instead.
> 
> 
> Diffs
> -
> 
>   lib/konq/src/konq_historyentry.h de34d6b 
> 
> Diff: https://git.reviewboard.kde.org/r/121080/diff/
> 
> 
> Testing
> ---
> 
> It builds (MSVC2013 - 64bit) after this patch (along other patches I'm 
> sending to review today). Kdebase-apps is still not very functional, though 
> (missing icons and weird UI).
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121062: use correct ki18n_wrap_ui in ki18n based framework

2014-11-09 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121062/#review70153
---

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Nov. 8, 2014, 2:06 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121062/
> ---
> 
> (Updated Nov. 8, 2014, 2:06 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: khtml
> 
> 
> Description
> ---
> 
> see summary
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 9e71fc3 
>   tests/CMakeLists.txt 40f37ee 
> 
> Diff: https://git.reviewboard.kde.org/r/121062/diff/
> 
> 
> Testing
> ---
> 
> builds
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121065: use correct ki18n_wrap_ui in ki18n based plasma-frameworks

2014-11-09 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121065/#review70154
---

Ship it!



examples/kpart/CMakeLists.txt


missing an _

:)


Note the typo, but looks good.

- Aleix Pol Gonzalez


On Nov. 8, 2014, 2:15 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121065/
> ---
> 
> (Updated Nov. 8, 2014, 2:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> see summary
> 
> 
> Diffs
> -
> 
>   examples/kpart/CMakeLists.txt ff62817 
>   examples/testcontainmentactionsplugin/CMakeLists.txt cb2cd56 
>   src/tools/port-cmake.sh 4d49e9a 
> 
> Diff: https://git.reviewboard.kde.org/r/121065/diff/
> 
> 
> Testing
> ---
> 
> builds
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121066: use correct ki18n_wrap_ui in ki18n based frameworks/kwallet

2014-11-09 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121066/#review70155
---

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Nov. 8, 2014, 2:19 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121066/
> ---
> 
> (Updated Nov. 8, 2014, 2:19 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> see summary
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/CMakeLists.txt 907ef19 
> 
> Diff: https://git.reviewboard.kde.org/r/121066/diff/
> 
> 
> Testing
> ---
> 
> builds
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121067: use correct ki18n_wrap_ui in ki18n based frameworks/knotifyconfig

2014-11-09 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121067/#review70156
---

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Nov. 8, 2014, 2:25 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121067/
> ---
> 
> (Updated Nov. 8, 2014, 2:25 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: knotifyconfig
> 
> 
> Description
> ---
> 
> see summary
> 
> 
> Diffs
> -
> 
>   tests/CMakeLists.txt 8787858 
> 
> Diff: https://git.reviewboard.kde.org/r/121067/diff/
> 
> 
> Testing
> ---
> 
> builds
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121068: use correct ki18n_wrap_ui in ki18n based frameworks/kjsembed

2014-11-09 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121068/#review70157
---

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Nov. 8, 2014, 2:30 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121068/
> ---
> 
> (Updated Nov. 8, 2014, 2:30 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kjsembed
> 
> 
> Description
> ---
> 
> see summary
> 
> 
> Diffs
> -
> 
>   examples/kjsconsole/CMakeLists.txt ba98fff 
> 
> Diff: https://git.reviewboard.kde.org/r/121068/diff/
> 
> 
> Testing
> ---
> 
> builds
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121062: use correct ki18n_wrap_ui in ki18n based framework

2014-11-09 Thread Burkhard Lück 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121062/
---

(Updated Nov. 10, 2014, 7:27 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.


Repository: khtml


Description
---

see summary


Diffs
-

  src/CMakeLists.txt 9e71fc3 
  tests/CMakeLists.txt 40f37ee 

Diff: https://git.reviewboard.kde.org/r/121062/diff/


Testing
---

builds


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel