date:20141111

Re: Review Request 121100: Add qCDebug statements back into knewstuff sources.

2014-11-11 Thread Jeremy Whiting


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121100/
---

(Updated Nov. 12, 2014, 2:01 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: knewstuff


Description
---

Add qCDebug statements back into knewstuff sources.


Diffs
-

  tests/knewstuff2_standard.cpp e44628b549ea5ad3b002c3a11eac298b92b5a6ae 
  tests/khotnewstuff.cpp 1aba7de48a8b7cf7f8886957fc473bf0cc631a13 
  tests/knewstuff2_cache.cpp e7e8a48666237f468d986e99a8c472fe37fd7a77 
  tests/knewstuff2_download.cpp 39d756e30f5b4f56f9254ae1e08c0d8310daf4d1 
  src/staticxml/staticxmlprovider.cpp 434ecef0b71543bf4504c9781d1d3a21b9cf6e34 
  src/ui/entrydetailsdialog.cpp 8a36d33f9a390a211313b11fba65030261a54446 
  src/ui/itemsgridviewdelegate.cpp 19ddc59eb4acbb2b7a591119453be407d01d9a9f 
  src/ui/itemsmodel.cpp 0254e88a5c16a2f8c5818a45bb7ec28eef4973e8 
  src/ui/itemsviewbasedelegate.cpp 5137beb93ee8cccd15b28b9a9f47eff60fc17fc8 
  src/ui/itemsviewdelegate.cpp 5e9b985cc155d141664a944b3d2bd1e751d96136 
  src/uploaddialog.cpp 1a087b30a7fc6198062f0f7a012ae37ed6f396af 
  src/core/engine.cpp 017154323cfd3f48fc61c0c705d4842f3c2f94a4 
  src/core/entryinternal.cpp d3af619e9908b2f9e6176c7c87eda44897e93f0a 
  src/core/installation.cpp d8de905bd2d19d098fb08a64897f5617f04e996d 
  src/core/upload.cpp 166e69417b687fef6e89ef7fb5c383ec478c5c2d 
  src/core/xmlloader.cpp 2cee02b66f8ec2a0f1fc407aaadd0ea397b89939 
  src/downloadmanager.cpp 60d0d37ef0bd35efdcfe5e6ac58fefb3a2ce9954 
  src/downloadwidget.cpp 358bb8b5222ac596dd3f0025778cd2721c1f3120 
  src/entry.h df3095e3f75d2f6ca15daf9e87172990214d6352 
  src/entry.cpp 48a92a7db04eec9b7b1b824841c95c280f31fab7 
  autotests/knewstuffentrytest.cpp bf55f063dc8cb0b0984fdc73501a13107241a75a 
  src/attica/atticaprovider.cpp 7103b59d62de468ba0c21a6b6260e5befc8575a2 
  src/core/cache.cpp 3ba6cb4f4d344781d7b95c966d0a0643777e1e6a 
  tests/knewstuff2_test.cpp ee2ead451be06854ea65ee9128231d37b118355c 

Diff: https://git.reviewboard.kde.org/r/121100/diff/


Testing
---

Builds and works still, more debug output filterable with the kanagram logging 
category.


Thanks,

Jeremy Whiting

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

2014-11-11 Thread Albert Astals Cid



> On nov. 11, 2014, 2:39 p.m., Albert Astals Cid wrote:
> > I sincerely think this is a *VERY BAD* idea. I don't want my app behaving 
> > differently depending if a third party misterious compononent that is not 
> > documented anywhere is installed or not. If you have a dependency, well put 
> > it in a tier with direct access to that dependency, or put a huge warning 
> > in the docu saying this will lose the functionality if something else is 
> > not there.
> 
> Daniel Vrátil wrote:
> This requirement is documented in ktexttohtml.h in /r/121094.
> 
> /**
>  * Replace text emoticons smileys by emoticons images.
>  *
>  * @note
>  * This option works only when FrameworkIntegration plugin is 
> installed,
>  * and requires QGuiApplication. This will not work with 
> QCoreApplication.
>  * If the FrameworkIntegration plugin is not available, or this is 
> called
>  * from a QCoreApplication, this option will not do anything.
>  */
> ReplaceSmileys  = 1 << 2,
> 
> The behaviour change in case the conditions above are not fulfiled are 
> not drastical - the flag will simply be ignored. I don't see much difference 
> over MessageBox not remembering "Don't show this again" between sessions, 
> because it would be using only memory storage when FrameworkIntegrationPlugin 
> is not installed (which btw is not documented at all)
> 
> Albert Astals Cid wrote:
> Why is the plugin in FrameworkIntegration and not in KEmoticons?
> 
> Daniel Vrátil wrote:
> Theoretically it could be in KEmoticons as some sort of plugin, but the 
> original idea was to simply follow the same path as KMessageBox to create a 
> runtime frameworks integration (for which "FrameworkIntegrationPlugin" seems 
> to be exactly the right place).

But what's the point? now if i want to provide that feature i need to pull a 
bazillion of dependencies instead of just KEmoticons. KMessageBox don't show 
again is actually an integration feature, is this feature one?


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121095/#review70238
---


On nov. 11, 2014, 2:51 p.m., Daniel Vrátil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121095/
> ---
> 
> (Updated nov. 11, 2014, 2:51 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Michael Pyne.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> This patch is related to /r/121094, which moves KTextToHTML conversion 
> utility from KPimUtils to KCoreAddons. Since KCoreAddons can't depend on 
> KEmoticons needed for smileys conversion, I added the actual KEmoticons code 
> here, to create a run-time dependency, similar to the KWidgetsAddons-KConfig 
> dependency for KMessageBox.
> 
> This patch refactors the FrameworkIntegrationPlugin a bit - I split the 
> KMessageBox-specific code into a separate file, and added a new file with the 
> KTextToHTMLEmoticonsInterface implementation, as we can't just keep stacking 
> more and more classes into a single file :-)
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3721bfa 
>   src/integrationplugin/CMakeLists.txt 3395368 
>   src/integrationplugin/frameworkintegrationplugin.h 6dc6825 
>   src/integrationplugin/frameworkintegrationplugin.cpp a45ba9d 
>   src/integrationplugin/kmessagebox.h PRE-CREATION 
>   src/integrationplugin/kmessagebox.cpp PRE-CREATION 
>   src/integrationplugin/ktexttohtml.h PRE-CREATION 
>   src/integrationplugin/ktexttohtml.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121095/diff/
> 
> 
> Testing
> ---
> 
> Tested with KTextToHTML code from /r/121094 in a QGuiApplication and it seems 
> to work.
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

2014-11-11 Thread Daniel Vrátil



> On Nov. 11, 2014, 3:39 p.m., Albert Astals Cid wrote:
> > I sincerely think this is a *VERY BAD* idea. I don't want my app behaving 
> > differently depending if a third party misterious compononent that is not 
> > documented anywhere is installed or not. If you have a dependency, well put 
> > it in a tier with direct access to that dependency, or put a huge warning 
> > in the docu saying this will lose the functionality if something else is 
> > not there.
> 
> Daniel Vrátil wrote:
> This requirement is documented in ktexttohtml.h in /r/121094.
> 
> /**
>  * Replace text emoticons smileys by emoticons images.
>  *
>  * @note
>  * This option works only when FrameworkIntegration plugin is 
> installed,
>  * and requires QGuiApplication. This will not work with 
> QCoreApplication.
>  * If the FrameworkIntegration plugin is not available, or this is 
> called
>  * from a QCoreApplication, this option will not do anything.
>  */
> ReplaceSmileys  = 1 << 2,
> 
> The behaviour change in case the conditions above are not fulfiled are 
> not drastical - the flag will simply be ignored. I don't see much difference 
> over MessageBox not remembering "Don't show this again" between sessions, 
> because it would be using only memory storage when FrameworkIntegrationPlugin 
> is not installed (which btw is not documented at all)
> 
> Albert Astals Cid wrote:
> Why is the plugin in FrameworkIntegration and not in KEmoticons?

Theoretically it could be in KEmoticons as some sort of plugin, but the 
original idea was to simply follow the same path as KMessageBox to create a 
runtime frameworks integration (for which "FrameworkIntegrationPlugin" seems to 
be exactly the right place).


- Daniel


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121095/#review70238
---


On Nov. 11, 2014, 3:51 p.m., Daniel Vrátil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121095/
> ---
> 
> (Updated Nov. 11, 2014, 3:51 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Michael Pyne.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> This patch is related to /r/121094, which moves KTextToHTML conversion 
> utility from KPimUtils to KCoreAddons. Since KCoreAddons can't depend on 
> KEmoticons needed for smileys conversion, I added the actual KEmoticons code 
> here, to create a run-time dependency, similar to the KWidgetsAddons-KConfig 
> dependency for KMessageBox.
> 
> This patch refactors the FrameworkIntegrationPlugin a bit - I split the 
> KMessageBox-specific code into a separate file, and added a new file with the 
> KTextToHTMLEmoticonsInterface implementation, as we can't just keep stacking 
> more and more classes into a single file :-)
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3721bfa 
>   src/integrationplugin/CMakeLists.txt 3395368 
>   src/integrationplugin/frameworkintegrationplugin.h 6dc6825 
>   src/integrationplugin/frameworkintegrationplugin.cpp a45ba9d 
>   src/integrationplugin/kmessagebox.h PRE-CREATION 
>   src/integrationplugin/kmessagebox.cpp PRE-CREATION 
>   src/integrationplugin/ktexttohtml.h PRE-CREATION 
>   src/integrationplugin/ktexttohtml.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121095/diff/
> 
> 
> Testing
> ---
> 
> Tested with KTextToHTML code from /r/121094 in a QGuiApplication and it seems 
> to work.
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

2014-11-11 Thread Albert Astals Cid



> On nov. 11, 2014, 2:39 p.m., Albert Astals Cid wrote:
> > I sincerely think this is a *VERY BAD* idea. I don't want my app behaving 
> > differently depending if a third party misterious compononent that is not 
> > documented anywhere is installed or not. If you have a dependency, well put 
> > it in a tier with direct access to that dependency, or put a huge warning 
> > in the docu saying this will lose the functionality if something else is 
> > not there.
> 
> Daniel Vrátil wrote:
> This requirement is documented in ktexttohtml.h in /r/121094.
> 
> /**
>  * Replace text emoticons smileys by emoticons images.
>  *
>  * @note
>  * This option works only when FrameworkIntegration plugin is 
> installed,
>  * and requires QGuiApplication. This will not work with 
> QCoreApplication.
>  * If the FrameworkIntegration plugin is not available, or this is 
> called
>  * from a QCoreApplication, this option will not do anything.
>  */
> ReplaceSmileys  = 1 << 2,
> 
> The behaviour change in case the conditions above are not fulfiled are 
> not drastical - the flag will simply be ignored. I don't see much difference 
> over MessageBox not remembering "Don't show this again" between sessions, 
> because it would be using only memory storage when FrameworkIntegrationPlugin 
> is not installed (which btw is not documented at all)

Why is the plugin in FrameworkIntegration and not in KEmoticons?


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121095/#review70238
---


On nov. 11, 2014, 2:51 p.m., Daniel Vrátil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121095/
> ---
> 
> (Updated nov. 11, 2014, 2:51 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Michael Pyne.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> This patch is related to /r/121094, which moves KTextToHTML conversion 
> utility from KPimUtils to KCoreAddons. Since KCoreAddons can't depend on 
> KEmoticons needed for smileys conversion, I added the actual KEmoticons code 
> here, to create a run-time dependency, similar to the KWidgetsAddons-KConfig 
> dependency for KMessageBox.
> 
> This patch refactors the FrameworkIntegrationPlugin a bit - I split the 
> KMessageBox-specific code into a separate file, and added a new file with the 
> KTextToHTMLEmoticonsInterface implementation, as we can't just keep stacking 
> more and more classes into a single file :-)
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3721bfa 
>   src/integrationplugin/CMakeLists.txt 3395368 
>   src/integrationplugin/frameworkintegrationplugin.h 6dc6825 
>   src/integrationplugin/frameworkintegrationplugin.cpp a45ba9d 
>   src/integrationplugin/kmessagebox.h PRE-CREATION 
>   src/integrationplugin/kmessagebox.cpp PRE-CREATION 
>   src/integrationplugin/ktexttohtml.h PRE-CREATION 
>   src/integrationplugin/ktexttohtml.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121095/diff/
> 
> 
> Testing
> ---
> 
> Tested with KTextToHTML code from /r/121094 in a QGuiApplication and it seems 
> to work.
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [RFC] [kservice] KPluginMetadata indexing

2014-11-11 Thread Sebastian Kügler

Hi Nicolas,

Sorry for my late reply, I thought I had replied, but apparently that was 
never sent. :/

On Thursday, November 06, 2014 16:26:01 Nicolás Alvarez wrote:
> 2014-11-05 23:44 GMT-03:00 Sebastian Kügler :
> > So, this code is in a bit of a draft stage, I'd very much welcome feedback
> > about the approach, and of course the code itself. It can be found in
> > kservice[sebas/kpluginindex]. the kpluginmetadata autotest gives a useful
> > testing target. I didn't submit it to reviewboard yet, because I want to
> > nail down the further direction, and provide a base to discuss on.
> 
> I tried it on Windows :)
> 
> Needed a minor tweak to build on MSVC2010 (have to specify the return
> type of lambdas). Can I commit this?

Sure, feel free to push this kind of trivial stuff. I'm not easily annoyed by 
someone who helps, and I usually make sure not to have pending stuff on my 
disk for something I've announced in public.

> findPluginSubdirectories is checking if the filename ends with ".so",
> I had to change it to ".dll". But why is the check there, if
> QDirIterator is already filtering?

I'll have to check, I don't exclude oversight as a reason right from the bat. 
;)

> After those changes, kplugin-update-index -a successfully generated 14
> .json files. I think .json isn't a good file extension for them if
> they aren't text JSON.

Me neither, suggestions for a better extension are welcome, or perhaps just no 
extension?

> I ran the benchmark a few times and having the index made it about 24x
> faster, with warm caches (I have no idea if there is anything like
> drop_caches on Windows or if I'd have to reboot).

That's consistent with my measurements, thanks for a data point I'm not easy 
to acquire!

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

2014-11-11 Thread Daniel Vrátil


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121095/
---

(Updated Nov. 11, 2014, 3:51 p.m.)


Review request for KDE Frameworks, David Faure and Michael Pyne.


Repository: frameworkintegration


Description
---

This patch is related to /r/121094, which moves KTextToHTML conversion utility 
from KPimUtils to KCoreAddons. Since KCoreAddons can't depend on KEmoticons 
needed for smileys conversion, I added the actual KEmoticons code here, to 
create a run-time dependency, similar to the KWidgetsAddons-KConfig dependency 
for KMessageBox.

This patch refactors the FrameworkIntegrationPlugin a bit - I split the 
KMessageBox-specific code into a separate file, and added a new file with the 
KTextToHTMLEmoticonsInterface implementation, as we can't just keep stacking 
more and more classes into a single file :-)


Diffs
-

  CMakeLists.txt 3721bfa 
  src/integrationplugin/CMakeLists.txt 3395368 
  src/integrationplugin/frameworkintegrationplugin.h 6dc6825 
  src/integrationplugin/frameworkintegrationplugin.cpp a45ba9d 
  src/integrationplugin/kmessagebox.h PRE-CREATION 
  src/integrationplugin/kmessagebox.cpp PRE-CREATION 
  src/integrationplugin/ktexttohtml.h PRE-CREATION 
  src/integrationplugin/ktexttohtml.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/121095/diff/


Testing
---

Tested with KTextToHTML code from /r/121094 in a QGuiApplication and it seems 
to work.


Thanks,

Daniel Vrátil

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121094: KCoreAddons: add KTextToHTML class for plaintext -> HTML conversion

2014-11-11 Thread Daniel Vrátil


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121094/
---

(Updated Nov. 11, 2014, 3:51 p.m.)


Review request for KDE Frameworks and Michael Pyne.


Repository: kcoreaddons


Description
---

This class comes from KPimUtils::LinkLocator from kdepimlibs.git. This class 
takes plaintext string, and converts it to HTML while perserving spacing, 
converting URLs and email addresses into  links and interpreting 
highligting markup (*bold*, _underline_, /italic/) and wrapping it to 
corresponding HTML tags. It can also convert text emoticons into  smileys.

The last - emoticons conversion - depends on KEmoticons, which we can't use 
directly from KCoreAddons, so I moved the actual KEmoticons code into 
FrameworkIntegration plugin. There is a dummy implementation provided by 
default in KCoreAddons that is loaded when the FrameworkIntegration plugin is 
not available, or when the application is only a QCoreApplication (since 
KEmoticons require QGuiApplication, so we must not load the plugin). The dummy 
implementation does nothing and returns the original string unaltered.

The reason for moving the class from KPimUtils is that KPimUtils is going to 
die, and while we could make this internal to KDE PIM, I think this is a rather 
useful code, that can be used by many applications that need to deal with 3rd 
party text data and want to provide user-friendly clickable links.

If you compare this with the original KPimUtils::LinkLocator you find, that I 
removed all public API except for the convertToHTML method. This is because the 
remaining methods (getUrl, getEmailAddress) depend on the actual state of the 
LinkLocator object, but LinkLocator provides no API for step-by-step parsing, 
so they were actually useless for public use. For that reason I decided to only 
publish the convertToHTML method, and hide the remaining methods as internal 
methods of the KTextToHTMLHelper (useful for unit-testing).

This patch also contains a unit-test from KPimUtils.


Diffs
-

  autotests/CMakeLists.txt d5a5feb 
  autotests/ktexttohtmltest.h PRE-CREATION 
  autotests/ktexttohtmltest.cpp PRE-CREATION 
  src/lib/CMakeLists.txt 1dc5627 
  src/lib/text/ktexttohtml.h PRE-CREATION 
  src/lib/text/ktexttohtml.cpp PRE-CREATION 
  src/lib/text/ktexttohtml_p.h PRE-CREATION 
  src/lib/text/ktexttohtmlemoticonsinterface.h PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/121094/diff/


Testing
---

Unit test passes


Thanks,

Daniel Vrátil

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

2014-11-11 Thread Daniel Vrátil



> On Nov. 11, 2014, 3:39 p.m., Albert Astals Cid wrote:
> > I sincerely think this is a *VERY BAD* idea. I don't want my app behaving 
> > differently depending if a third party misterious compononent that is not 
> > documented anywhere is installed or not. If you have a dependency, well put 
> > it in a tier with direct access to that dependency, or put a huge warning 
> > in the docu saying this will lose the functionality if something else is 
> > not there.

This requirement is documented in ktexttohtml.h in /r/121094.

/**
 * Replace text emoticons smileys by emoticons images.
 *
 * @note
 * This option works only when FrameworkIntegration plugin is installed,
 * and requires QGuiApplication. This will not work with QCoreApplication.
 * If the FrameworkIntegration plugin is not available, or this is called
 * from a QCoreApplication, this option will not do anything.
 */
ReplaceSmileys  = 1 << 2,

The behaviour change in case the conditions above are not fulfiled are not 
drastical - the flag will simply be ignored. I don't see much difference over 
MessageBox not remembering "Don't show this again" between sessions, because it 
would be using only memory storage when FrameworkIntegrationPlugin is not 
installed (which btw is not documented at all)


- Daniel


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121095/#review70238
---


On Nov. 11, 2014, 1:12 p.m., Daniel Vrátil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121095/
> ---
> 
> (Updated Nov. 11, 2014, 1:12 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> This patch is related to /r/121094, which moves KTextToHTML conversion 
> utility from KPimUtils to KCoreAddons. Since KCoreAddons can't depend on 
> KEmoticons needed for smileys conversion, I added the actual KEmoticons code 
> here, to create a run-time dependency, similar to the KWidgetsAddons-KConfig 
> dependency for KMessageBox.
> 
> This patch refactors the FrameworkIntegrationPlugin a bit - I split the 
> KMessageBox-specific code into a separate file, and added a new file with the 
> KTextToHTMLEmoticonsInterface implementation, as we can't just keep stacking 
> more and more classes into a single file :-)
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3721bfa 
>   src/integrationplugin/CMakeLists.txt 3395368 
>   src/integrationplugin/frameworkintegrationplugin.h 6dc6825 
>   src/integrationplugin/frameworkintegrationplugin.cpp a45ba9d 
>   src/integrationplugin/kmessagebox.h PRE-CREATION 
>   src/integrationplugin/kmessagebox.cpp PRE-CREATION 
>   src/integrationplugin/ktexttohtml.h PRE-CREATION 
>   src/integrationplugin/ktexttohtml.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121095/diff/
> 
> 
> Testing
> ---
> 
> Tested with KTextToHTML code from /r/121094 in a QGuiApplication and it seems 
> to work.
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

2014-11-11 Thread Albert Astals Cid


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121095/#review70238
---


I sincerely think this is a *VERY BAD* idea. I don't want my app behaving 
differently depending if a third party misterious compononent that is not 
documented anywhere is installed or not. If you have a dependency, well put it 
in a tier with direct access to that dependency, or put a huge warning in the 
docu saying this will lose the functionality if something else is not there.

- Albert Astals Cid


On nov. 11, 2014, 12:12 p.m., Daniel Vrátil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121095/
> ---
> 
> (Updated nov. 11, 2014, 12:12 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> This patch is related to /r/121094, which moves KTextToHTML conversion 
> utility from KPimUtils to KCoreAddons. Since KCoreAddons can't depend on 
> KEmoticons needed for smileys conversion, I added the actual KEmoticons code 
> here, to create a run-time dependency, similar to the KWidgetsAddons-KConfig 
> dependency for KMessageBox.
> 
> This patch refactors the FrameworkIntegrationPlugin a bit - I split the 
> KMessageBox-specific code into a separate file, and added a new file with the 
> KTextToHTMLEmoticonsInterface implementation, as we can't just keep stacking 
> more and more classes into a single file :-)
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3721bfa 
>   src/integrationplugin/CMakeLists.txt 3395368 
>   src/integrationplugin/frameworkintegrationplugin.h 6dc6825 
>   src/integrationplugin/frameworkintegrationplugin.cpp a45ba9d 
>   src/integrationplugin/kmessagebox.h PRE-CREATION 
>   src/integrationplugin/kmessagebox.cpp PRE-CREATION 
>   src/integrationplugin/ktexttohtml.h PRE-CREATION 
>   src/integrationplugin/ktexttohtml.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121095/diff/
> 
> 
> Testing
> ---
> 
> Tested with KTextToHTML code from /r/121094 in a QGuiApplication and it seems 
> to work.
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

2014-11-11 Thread Laurent Montel


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121095/#review70236
---


Perhaps add a framework guy to this request (and other request) as David Faure 
for example.
Without a specific guy I think that nobody will comment them.
Regards

- Laurent Montel


On nov. 11, 2014, 12:12 après-midi, Daniel Vrátil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121095/
> ---
> 
> (Updated nov. 11, 2014, 12:12 après-midi)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> This patch is related to /r/121094, which moves KTextToHTML conversion 
> utility from KPimUtils to KCoreAddons. Since KCoreAddons can't depend on 
> KEmoticons needed for smileys conversion, I added the actual KEmoticons code 
> here, to create a run-time dependency, similar to the KWidgetsAddons-KConfig 
> dependency for KMessageBox.
> 
> This patch refactors the FrameworkIntegrationPlugin a bit - I split the 
> KMessageBox-specific code into a separate file, and added a new file with the 
> KTextToHTMLEmoticonsInterface implementation, as we can't just keep stacking 
> more and more classes into a single file :-)
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3721bfa 
>   src/integrationplugin/CMakeLists.txt 3395368 
>   src/integrationplugin/frameworkintegrationplugin.h 6dc6825 
>   src/integrationplugin/frameworkintegrationplugin.cpp a45ba9d 
>   src/integrationplugin/kmessagebox.h PRE-CREATION 
>   src/integrationplugin/kmessagebox.cpp PRE-CREATION 
>   src/integrationplugin/ktexttohtml.h PRE-CREATION 
>   src/integrationplugin/ktexttohtml.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121095/diff/
> 
> 
> Testing
> ---
> 
> Tested with KTextToHTML code from /r/121094 in a QGuiApplication and it seems 
> to work.
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121103: KCodecs: Import KEmailAddress class from email address parsing and validation from KPimUtils

2014-11-11 Thread Daniel Vrátil


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121103/
---

(Updated Nov. 11, 2014, 2:27 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks.


Repository: kcodecs


Description
---

This class can be very useful to many applications that need to deal with email
address validation, and so it should not be hidden somewhere in PIM, but
should be available in some more visibile framework. Also I need to kill the
KPimUtils framework, and we don't really have any better-fitting framework
available at this moment :)


Diffs
-

  src/kcodecsbase64.cpp PRE-CREATION 
  src/kcodecsidentity.h PRE-CREATION 
  src/kcodecsidentity.cpp PRE-CREATION 
  src/kcodecsqp.h PRE-CREATION 
  src/kcodecsqp.cpp PRE-CREATION 
  src/kcodecsuuencode.h PRE-CREATION 
  src/kcodecsuuencode.cpp PRE-CREATION 
  src/kemailaddress.h PRE-CREATION 
  src/kemailaddress.cpp PRE-CREATION 
  src/CMakeLists.txt adc0f2ab8706cd120041df0ef97ca19cb3aa9315 
  src/kcodecs.h 48effbbe9cb26586c94c4d1492604345c0e1ca0b 
  src/kcodecs.cpp 4fd660d28b6db98bc63140ca6e9852947481c6f0 
  src/kcodecsbase64.h PRE-CREATION 
  autotests/data/codec_x-kmime-rfc2231/null-encode PRE-CREATION 
  autotests/data/codec_x-kmime-rfc2231/null-encode.expected PRE-CREATION 
  autotests/data/codec_x-uuencode/basic-decode.x-uuencode PRE-CREATION 
  autotests/data/codec_x-uuencode/basic-decode.x-uuencode.expected PRE-CREATION 
  autotests/kcodecstest.h PRE-CREATION 
  autotests/kcodecstest.cpp PRE-CREATION 
  autotests/kemailaddresstest.h PRE-CREATION 
  autotests/kemailaddresstest.cpp PRE-CREATION 
  autotests/rfc2047test.h PRE-CREATION 
  autotests/rfc2047test.cpp PRE-CREATION 
  autotests/CMakeLists.txt 4c41ba20809d063d6fe2a17833f87fd89df538e5 
  autotests/base64benchmark.cpp PRE-CREATION 
  autotests/codectest.h PRE-CREATION 
  autotests/codectest.cpp PRE-CREATION 
  autotests/data/codec_b/basic-decode.b PRE-CREATION 
  autotests/data/codec_b/basic-decode.b.expected PRE-CREATION 
  autotests/data/codec_b/basic-encode PRE-CREATION 
  autotests/data/codec_b/basic-encode.expected PRE-CREATION 
  autotests/data/codec_b/null-decode.b PRE-CREATION 
  autotests/data/codec_b/null-decode.b.expected PRE-CREATION 
  autotests/data/codec_b/null-encode PRE-CREATION 
  autotests/data/codec_b/null-encode.expected PRE-CREATION 
  autotests/data/codec_b/padding0-encode PRE-CREATION 
  autotests/data/codec_b/padding0-encode.expected PRE-CREATION 
  autotests/data/codec_b/padding1-encode PRE-CREATION 
  autotests/data/codec_b/padding1-encode.expected PRE-CREATION 
  autotests/data/codec_b/padding2-encode PRE-CREATION 
  autotests/data/codec_b/padding2-encode.expected PRE-CREATION 
  autotests/data/codec_base64/basic-decode.base64 PRE-CREATION 
  autotests/data/codec_base64/basic-decode.base64.expected PRE-CREATION 
  autotests/data/codec_base64/basic-encode PRE-CREATION 
  autotests/data/codec_base64/basic-encode.expected PRE-CREATION 
  autotests/data/codec_base64/corrupt.base64 PRE-CREATION 
  autotests/data/codec_base64/corrupt.base64.expected PRE-CREATION 
  autotests/data/codec_base64/very_small-encode PRE-CREATION 
  autotests/data/codec_base64/very_small-encode.expected PRE-CREATION 
  autotests/data/codec_q/all-encoded-decode.q PRE-CREATION 
  autotests/data/codec_q/all-encoded-decode.q.expected PRE-CREATION 
  autotests/data/codec_q/basic-encode PRE-CREATION 
  autotests/data/codec_q/basic-encode.expected PRE-CREATION 
  autotests/data/codec_q/null-decode.q PRE-CREATION 
  autotests/data/codec_q/null-decode.q.expected PRE-CREATION 
  autotests/data/codec_q/null-encode PRE-CREATION 
  autotests/data/codec_q/null-encode.expected PRE-CREATION 
  autotests/data/codec_quoted-printable/basic-decode.quoted-printable 
PRE-CREATION 
  autotests/data/codec_quoted-printable/basic-decode.quoted-printable.expected 
PRE-CREATION 
  autotests/data/codec_quoted-printable/basic-encode PRE-CREATION 
  autotests/data/codec_quoted-printable/basic-encode.expected PRE-CREATION 
  autotests/data/codec_quoted-printable/corrupt.quoted-printable PRE-CREATION 
  autotests/data/codec_quoted-printable/corrupt.quoted-printable.expected 
PRE-CREATION 
  autotests/data/codec_quoted-printable/corrupt2.quoted-printable PRE-CREATION 
  autotests/data/codec_quoted-printable/corrupt2.quoted-printable.expected 
PRE-CREATION 
  autotests/data/codec_quoted-printable/corrupt3.quoted-printable PRE-CREATION 
  autotests/data/codec_quoted-printable/corrupt3.quoted-printable.expected 
PRE-CREATION 
  autotests/data/codec_quoted-printable/corrupt4.quoted-printable PRE-CREATION 
  autotests/data/codec_quoted-printable/corrupt4.quoted-printable.expected 
PRE-CREATION 
  autotests/data/codec_quoted-printable/wrap-encode PRE-CREATION 
  autotests/data/codec_quoted-printable/wrap-encode.expected PRE-CREATION 
  autotests/data/codec_x-

Review Request 121103: KCodecs: Import KEmailAddress class from email address parsing and validation from KPimUtils

2014-11-11 Thread Daniel Vrátil


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121103/
---

Review request for KDE Frameworks.


Repository: kcodecs


Description
---

This class can be very useful to many applications that need to deal with email
address validation, and so it should not be hidden somewhere in PIM, but
should be available in some more visibile framework. Also I need to kill the
KPimUtils framework, and we don't really have any better-fitting framework
available at this moment :)


Diffs
-

  src/kcodecsbase64.cpp PRE-CREATION 
  src/kcodecsidentity.h PRE-CREATION 
  src/kcodecsidentity.cpp PRE-CREATION 
  src/kcodecsqp.h PRE-CREATION 
  src/kcodecsqp.cpp PRE-CREATION 
  src/kcodecsuuencode.h PRE-CREATION 
  src/kcodecsuuencode.cpp PRE-CREATION 
  src/kemailaddress.h PRE-CREATION 
  src/kemailaddress.cpp PRE-CREATION 
  src/CMakeLists.txt adc0f2ab8706cd120041df0ef97ca19cb3aa9315 
  src/kcodecs.h 48effbbe9cb26586c94c4d1492604345c0e1ca0b 
  src/kcodecs.cpp 4fd660d28b6db98bc63140ca6e9852947481c6f0 
  src/kcodecsbase64.h PRE-CREATION 
  autotests/data/codec_x-kmime-rfc2231/null-encode PRE-CREATION 
  autotests/data/codec_x-kmime-rfc2231/null-encode.expected PRE-CREATION 
  autotests/data/codec_x-uuencode/basic-decode.x-uuencode PRE-CREATION 
  autotests/data/codec_x-uuencode/basic-decode.x-uuencode.expected PRE-CREATION 
  autotests/kcodecstest.h PRE-CREATION 
  autotests/kcodecstest.cpp PRE-CREATION 
  autotests/kemailaddresstest.h PRE-CREATION 
  autotests/kemailaddresstest.cpp PRE-CREATION 
  autotests/rfc2047test.h PRE-CREATION 
  autotests/rfc2047test.cpp PRE-CREATION 
  autotests/CMakeLists.txt 4c41ba20809d063d6fe2a17833f87fd89df538e5 
  autotests/base64benchmark.cpp PRE-CREATION 
  autotests/codectest.h PRE-CREATION 
  autotests/codectest.cpp PRE-CREATION 
  autotests/data/codec_b/basic-decode.b PRE-CREATION 
  autotests/data/codec_b/basic-decode.b.expected PRE-CREATION 
  autotests/data/codec_b/basic-encode PRE-CREATION 
  autotests/data/codec_b/basic-encode.expected PRE-CREATION 
  autotests/data/codec_b/null-decode.b PRE-CREATION 
  autotests/data/codec_b/null-decode.b.expected PRE-CREATION 
  autotests/data/codec_b/null-encode PRE-CREATION 
  autotests/data/codec_b/null-encode.expected PRE-CREATION 
  autotests/data/codec_b/padding0-encode PRE-CREATION 
  autotests/data/codec_b/padding0-encode.expected PRE-CREATION 
  autotests/data/codec_b/padding1-encode PRE-CREATION 
  autotests/data/codec_b/padding1-encode.expected PRE-CREATION 
  autotests/data/codec_b/padding2-encode PRE-CREATION 
  autotests/data/codec_b/padding2-encode.expected PRE-CREATION 
  autotests/data/codec_base64/basic-decode.base64 PRE-CREATION 
  autotests/data/codec_base64/basic-decode.base64.expected PRE-CREATION 
  autotests/data/codec_base64/basic-encode PRE-CREATION 
  autotests/data/codec_base64/basic-encode.expected PRE-CREATION 
  autotests/data/codec_base64/corrupt.base64 PRE-CREATION 
  autotests/data/codec_base64/corrupt.base64.expected PRE-CREATION 
  autotests/data/codec_base64/very_small-encode PRE-CREATION 
  autotests/data/codec_base64/very_small-encode.expected PRE-CREATION 
  autotests/data/codec_q/all-encoded-decode.q PRE-CREATION 
  autotests/data/codec_q/all-encoded-decode.q.expected PRE-CREATION 
  autotests/data/codec_q/basic-encode PRE-CREATION 
  autotests/data/codec_q/basic-encode.expected PRE-CREATION 
  autotests/data/codec_q/null-decode.q PRE-CREATION 
  autotests/data/codec_q/null-decode.q.expected PRE-CREATION 
  autotests/data/codec_q/null-encode PRE-CREATION 
  autotests/data/codec_q/null-encode.expected PRE-CREATION 
  autotests/data/codec_quoted-printable/basic-decode.quoted-printable 
PRE-CREATION 
  autotests/data/codec_quoted-printable/basic-decode.quoted-printable.expected 
PRE-CREATION 
  autotests/data/codec_quoted-printable/basic-encode PRE-CREATION 
  autotests/data/codec_quoted-printable/basic-encode.expected PRE-CREATION 
  autotests/data/codec_quoted-printable/corrupt.quoted-printable PRE-CREATION 
  autotests/data/codec_quoted-printable/corrupt.quoted-printable.expected 
PRE-CREATION 
  autotests/data/codec_quoted-printable/corrupt2.quoted-printable PRE-CREATION 
  autotests/data/codec_quoted-printable/corrupt2.quoted-printable.expected 
PRE-CREATION 
  autotests/data/codec_quoted-printable/corrupt3.quoted-printable PRE-CREATION 
  autotests/data/codec_quoted-printable/corrupt3.quoted-printable.expected 
PRE-CREATION 
  autotests/data/codec_quoted-printable/corrupt4.quoted-printable PRE-CREATION 
  autotests/data/codec_quoted-printable/corrupt4.quoted-printable.expected 
PRE-CREATION 
  autotests/data/codec_quoted-printable/wrap-encode PRE-CREATION 
  autotests/data/codec_quoted-printable/wrap-encode.expected PRE-CREATION 
  autotests/data/codec_x-kmime-rfc2231/all-encoded.x-kmime-rfc2231-decode 
PRE-CREATION 
  
autotests/data/code

Re: Review Request 121094: KCoreAddons: add KTextToHTML class for plaintext -> HTML conversion

2014-11-11 Thread Daniel Vrátil


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121094/
---

(Updated Nov. 11, 2014, 1:49 p.m.)


Review request for KDE Frameworks.


Repository: kcoreaddons


Description
---

This class comes from KPimUtils::LinkLocator from kdepimlibs.git. This class 
takes plaintext string, and converts it to HTML while perserving spacing, 
converting URLs and email addresses into  links and interpreting 
highligting markup (*bold*, _underline_, /italic/) and wrapping it to 
corresponding HTML tags. It can also convert text emoticons into  smileys.

The last - emoticons conversion - depends on KEmoticons, which we can't use 
directly from KCoreAddons, so I moved the actual KEmoticons code into 
FrameworkIntegration plugin. There is a dummy implementation provided by 
default in KCoreAddons that is loaded when the FrameworkIntegration plugin is 
not available, or when the application is only a QCoreApplication (since 
KEmoticons require QGuiApplication, so we must not load the plugin). The dummy 
implementation does nothing and returns the original string unaltered.

The reason for moving the class from KPimUtils is that KPimUtils is going to 
die, and while we could make this internal to KDE PIM, I think this is a rather 
useful code, that can be used by many applications that need to deal with 3rd 
party text data and want to provide user-friendly clickable links.

If you compare this with the original KPimUtils::LinkLocator you find, that I 
removed all public API except for the convertToHTML method. This is because the 
remaining methods (getUrl, getEmailAddress) depend on the actual state of the 
LinkLocator object, but LinkLocator provides no API for step-by-step parsing, 
so they were actually useless for public use. For that reason I decided to only 
publish the convertToHTML method, and hide the remaining methods as internal 
methods of the KTextToHTMLHelper (useful for unit-testing).

This patch also contains a unit-test from KPimUtils.


Diffs (updated)
-

  autotests/CMakeLists.txt d5a5feb 
  autotests/ktexttohtmltest.h PRE-CREATION 
  autotests/ktexttohtmltest.cpp PRE-CREATION 
  src/lib/CMakeLists.txt 1dc5627 
  src/lib/text/ktexttohtml.h PRE-CREATION 
  src/lib/text/ktexttohtml.cpp PRE-CREATION 
  src/lib/text/ktexttohtml_p.h PRE-CREATION 
  src/lib/text/ktexttohtmlemoticonsinterface.h PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/121094/diff/


Testing
---

Unit test passes


Thanks,

Daniel Vrátil

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121094: KCoreAddons: add KTextToHTML class for plaintext -> HTML conversion

2014-11-11 Thread Laurent Montel


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121094/#review70234
---



src/lib/text/ktexttohtml.cpp


same here



src/lib/text/ktexttohtml.cpp


QStringLiteral here ?



src/lib/text/ktexttohtml.cpp


QStringLiteral ?



src/lib/text/ktexttohtml.cpp


++helper.mpos;



src/lib/text/ktexttohtml.cpp


++x



src/lib/text/ktexttohtml.cpp


same here



src/lib/text/ktexttohtml.cpp


same here



src/lib/text/ktexttohtml.cpp


same here



src/lib/text/ktexttohtml.cpp


same here


- Laurent Montel


On nov. 10, 2014, 3:59 après-midi, Dan Vrátil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121094/
> ---
> 
> (Updated nov. 10, 2014, 3:59 après-midi)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> This class comes from KPimUtils::LinkLocator from kdepimlibs.git. This class 
> takes plaintext string, and converts it to HTML while perserving spacing, 
> converting URLs and email addresses into  links and interpreting 
> highligting markup (*bold*, _underline_, /italic/) and wrapping it to 
> corresponding HTML tags. It can also convert text emoticons into  
> smileys.
> 
> The last - emoticons conversion - depends on KEmoticons, which we can't use 
> directly from KCoreAddons, so I moved the actual KEmoticons code into 
> FrameworkIntegration plugin. There is a dummy implementation provided by 
> default in KCoreAddons that is loaded when the FrameworkIntegration plugin is 
> not available, or when the application is only a QCoreApplication (since 
> KEmoticons require QGuiApplication, so we must not load the plugin). The 
> dummy implementation does nothing and returns the original string unaltered.
> 
> The reason for moving the class from KPimUtils is that KPimUtils is going to 
> die, and while we could make this internal to KDE PIM, I think this is a 
> rather useful code, that can be used by many applications that need to deal 
> with 3rd party text data and want to provide user-friendly clickable links.
> 
> If you compare this with the original KPimUtils::LinkLocator you find, that I 
> removed all public API except for the convertToHTML method. This is because 
> the remaining methods (getUrl, getEmailAddress) depend on the actual state of 
> the LinkLocator object, but LinkLocator provides no API for step-by-step 
> parsing, so they were actually useless for public use. For that reason I 
> decided to only publish the convertToHTML method, and hide the remaining 
> methods as internal methods of the KTextToHTMLHelper (useful for 
> unit-testing).
> 
> This patch also contains a unit-test from KPimUtils.
> 
> 
> Diffs
> -
> 
>   autotests/ktexttohtmltest.cpp PRE-CREATION 
>   src/lib/CMakeLists.txt 1dc5627 
>   src/lib/text/ktexttohtml.h PRE-CREATION 
>   src/lib/text/ktexttohtml.cpp PRE-CREATION 
>   src/lib/text/ktexttohtml_p.h PRE-CREATION 
>   src/lib/text/ktexttohtmlemoticonsinterface.h PRE-CREATION 
>   autotests/CMakeLists.txt d5a5feb 
>   autotests/ktexttohtmltest.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121094/diff/
> 
> 
> Testing
> ---
> 
> Unit test passes
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

2014-11-11 Thread Dan Vrátil


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121095/
---

(Updated Nov. 11, 2014, 1:12 p.m.)


Review request for KDE Frameworks.


Repository: frameworkintegration


Description
---

This patch is related to /r/121094, which moves KTextToHTML conversion utility 
from KPimUtils to KCoreAddons. Since KCoreAddons can't depend on KEmoticons 
needed for smileys conversion, I added the actual KEmoticons code here, to 
create a run-time dependency, similar to the KWidgetsAddons-KConfig dependency 
for KMessageBox.

This patch refactors the FrameworkIntegrationPlugin a bit - I split the 
KMessageBox-specific code into a separate file, and added a new file with the 
KTextToHTMLEmoticonsInterface implementation, as we can't just keep stacking 
more and more classes into a single file :-)


Diffs (updated)
-

  CMakeLists.txt 3721bfa 
  src/integrationplugin/CMakeLists.txt 3395368 
  src/integrationplugin/frameworkintegrationplugin.h 6dc6825 
  src/integrationplugin/frameworkintegrationplugin.cpp a45ba9d 
  src/integrationplugin/kmessagebox.h PRE-CREATION 
  src/integrationplugin/kmessagebox.cpp PRE-CREATION 
  src/integrationplugin/ktexttohtml.h PRE-CREATION 
  src/integrationplugin/ktexttohtml.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/121095/diff/


Testing
---

Tested with KTextToHTML code from /r/121094 in a QGuiApplication and it seems 
to work.


Thanks,

Dan Vrátil

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

2014-11-11 Thread Laurent Montel


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121095/#review70233
---



src/integrationplugin/frameworkintegrationplugin.cpp


Perhaps we can remove this  #if QT_VERSION no ?:) We use QT> 5.0 :)


- Laurent Montel


On nov. 10, 2014, 3:59 après-midi, Dan Vrátil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121095/
> ---
> 
> (Updated nov. 10, 2014, 3:59 après-midi)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> This patch is related to /r/121094, which moves KTextToHTML conversion 
> utility from KPimUtils to KCoreAddons. Since KCoreAddons can't depend on 
> KEmoticons needed for smileys conversion, I added the actual KEmoticons code 
> here, to create a run-time dependency, similar to the KWidgetsAddons-KConfig 
> dependency for KMessageBox.
> 
> This patch refactors the FrameworkIntegrationPlugin a bit - I split the 
> KMessageBox-specific code into a separate file, and added a new file with the 
> KTextToHTMLEmoticonsInterface implementation, as we can't just keep stacking 
> more and more classes into a single file :-)
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3721bfa 
>   src/integrationplugin/CMakeLists.txt 3395368 
>   src/integrationplugin/frameworkintegrationplugin.h 6dc6825 
>   src/integrationplugin/frameworkintegrationplugin.cpp a45ba9d 
>   src/integrationplugin/kmessagebox.h PRE-CREATION 
>   src/integrationplugin/kmessagebox.cpp PRE-CREATION 
>   src/integrationplugin/ktexttohtml.h PRE-CREATION 
>   src/integrationplugin/ktexttohtml.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121095/diff/
> 
> 
> Testing
> ---
> 
> Tested with KTextToHTML code from /r/121094 in a QGuiApplication and it seems 
> to work.
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

2014-11-11 Thread Alexander Richardson


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120198/
---

(Updated Nov. 11, 2014, 11:20 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kservice


Description
---

A series of 4 commits:



KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

This means that KPluginInfo can now simply reuse the QJsonObject
returned by QPluginLoader.metaData() (by storing it in a 
KPluginMetaData object instead of having to convert the JSON to a
QVariantMap first.

Additionally this allows very efficient conversion between KPluginInfo
and KPluginMetaData.

---
Add compatibility key names to KPluginInfo::property()

---

KPluginInfo: Fix loading JSON metadata that only has compatibility keys

This can be removed in KF6, but for now allows loading all both old
style as well as new style metadata



kplugininfotest: also test objects constructed from JSON

This tests both new style JSON as well as JSON using the old key names


Diffs
-

  src/services/kplugininfo.cpp 54593e57ca2b898a7d68de2915b7e40c3aa96f5f 
  autotests/CMakeLists.txt 913e848ba5d1754ef7726f92604d1aaa398fa107 
  autotests/kplugininfotest.cpp 9d4ee046db1e5d0b9f30a9a68929147763ee1cfa 
  src/services/kplugininfo.h 871d6a2ead5a9b358d864372152cbfa0c43d8a68 

Diff: https://git.reviewboard.kde.org/r/120198/diff/


Testing
---

All unit tests still work


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kservice_master_qt5 #199

2014-11-11 Thread KDE CI System

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121100: Add qCDebug statements back into knewstuff sources.

2014-11-11 Thread Sebastian Kügler


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121100/#review70228
---

Ship it!


Looks sane.

Some minor (and unrelated) comments inline.


src/attica/atticaprovider.cpp


would probably make sense to not comment it here, or show a warning. (I 
don't know how critical this particular FIXME is.)



src/core/installation.cpp


unrelated to this patch, but this looks quite fishy, yet easy to fix.



tests/knewstuff2_test.cpp


WTF? (Unrelated, yes.)


- Sebastian Kügler


On Nov. 11, 2014, 2:42 a.m., Jeremy Whiting wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121100/
> ---
> 
> (Updated Nov. 11, 2014, 2:42 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> ---
> 
> Add qCDebug statements back into knewstuff sources.
> 
> 
> Diffs
> -
> 
>   tests/knewstuff2_standard.cpp e44628b549ea5ad3b002c3a11eac298b92b5a6ae 
>   tests/khotnewstuff.cpp 1aba7de48a8b7cf7f8886957fc473bf0cc631a13 
>   tests/knewstuff2_cache.cpp e7e8a48666237f468d986e99a8c472fe37fd7a77 
>   tests/knewstuff2_download.cpp 39d756e30f5b4f56f9254ae1e08c0d8310daf4d1 
>   src/staticxml/staticxmlprovider.cpp 
> 434ecef0b71543bf4504c9781d1d3a21b9cf6e34 
>   src/ui/entrydetailsdialog.cpp 8a36d33f9a390a211313b11fba65030261a54446 
>   src/ui/itemsgridviewdelegate.cpp 19ddc59eb4acbb2b7a591119453be407d01d9a9f 
>   src/ui/itemsmodel.cpp 0254e88a5c16a2f8c5818a45bb7ec28eef4973e8 
>   src/ui/itemsviewbasedelegate.cpp 5137beb93ee8cccd15b28b9a9f47eff60fc17fc8 
>   src/ui/itemsviewdelegate.cpp 5e9b985cc155d141664a944b3d2bd1e751d96136 
>   src/uploaddialog.cpp 1a087b30a7fc6198062f0f7a012ae37ed6f396af 
>   src/core/engine.cpp 017154323cfd3f48fc61c0c705d4842f3c2f94a4 
>   src/core/entryinternal.cpp d3af619e9908b2f9e6176c7c87eda44897e93f0a 
>   src/core/installation.cpp d8de905bd2d19d098fb08a64897f5617f04e996d 
>   src/core/upload.cpp 166e69417b687fef6e89ef7fb5c383ec478c5c2d 
>   src/core/xmlloader.cpp 2cee02b66f8ec2a0f1fc407aaadd0ea397b89939 
>   src/downloadmanager.cpp 60d0d37ef0bd35efdcfe5e6ac58fefb3a2ce9954 
>   src/downloadwidget.cpp 358bb8b5222ac596dd3f0025778cd2721c1f3120 
>   src/entry.h df3095e3f75d2f6ca15daf9e87172990214d6352 
>   src/entry.cpp 48a92a7db04eec9b7b1b824841c95c280f31fab7 
>   autotests/knewstuffentrytest.cpp bf55f063dc8cb0b0984fdc73501a13107241a75a 
>   src/attica/atticaprovider.cpp 7103b59d62de468ba0c21a6b6260e5befc8575a2 
>   src/core/cache.cpp 3ba6cb4f4d344781d7b95c966d0a0643777e1e6a 
>   tests/knewstuff2_test.cpp ee2ead451be06854ea65ee9128231d37b118355c 
> 
> Diff: https://git.reviewboard.kde.org/r/121100/diff/
> 
> 
> Testing
> ---
> 
> Builds and works still, more debug output filterable with the kanagram 
> logging category.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: How to port KTabBar::mouseMiddleClick?

2014-11-11 Thread David Gil Oliva

El 11/11/2014 10:50, "Kevin Funk"  escribió:
>
> On Monday 10 November 2014 15:19:22 Nicolás Alvarez wrote:
> > 2014-11-09 7:28 GMT-03:00 Frank Reininghaus :
> > > Hi,
> > >
> > > 2014-11-06 2:59 GMT+01:00 Milian Wolff:
> > >> Hey all,
> > >>
> > >> what do I do to get middle-click-closes-tab in Qt 5 without KTabBar?
> > >> Previously, we used KTabBar and its mouseMiddleClick signal.
> > >
> > > AFAIK, currently the only solution is to subclass QTabBar, override
> > > the mousePressEvent method and emit a signal from there. Dolphin uses
> > > this approach. There were many other reasons why Emmanuel created a
> > > custom QTabBar subclass for Dolphin though .
> > >
> > > If many apps need the "middle click to close" bevavior, then
> > > reanimating KTabBar or getting this functionality into QTabBar might
> > > be better than making every app create its own tab bar class.
> >
> > Or maybe contribute mouseMiddleClick to QTabBar?
> > (I'm not volunteering :P)
>
> Yep. I'm wondering if an a patch just reacting on middle clicks would be
> accepted. It's not like it breaks existing work flows, it's just there for
> convenience.
>
> Grepping qtbase showed that QMdiArea has a similar feature:
>
> widgets/qmdiarea.cpp
> 582-void QMdiAreaTabBar::mousePressEvent(QMouseEvent *event)
> 583-{
> 584:if (event->button() != Qt::MidButton) {
> 585-QTabBar::mousePressEvent(event);
> 586-return;
> 587-}
> 588-
> 589-QMdiSubWindow *subWindow =
subWindowFromIndex(tabAt(event->pos()));
> 590-if (!subWindow) {
> 591-event->ignore();
> 592-return;
> 593-}
> 594-
> 595-subWindow->close();
> 596-}
>
> Worth trying to patch this into QTabBar right away, I think.

Didn't see it. Sorry for the noise.

David Gil

> Cheers
>
> --
> Kevin Funk | kf...@kde.org | http://kfunk.org
> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: How to port KTabBar::mouseMiddleClick?

2014-11-11 Thread David Gil Oliva

El 10/11/2014 19:19, "Nicolás Alvarez"  escribió:
>
> 2014-11-09 7:28 GMT-03:00 Frank Reininghaus :
> > Hi,
> >
> > 2014-11-06 2:59 GMT+01:00 Milian Wolff:
> >> Hey all,
> >>
> >> what do I do to get middle-click-closes-tab in Qt 5 without KTabBar?
> >> Previously, we used KTabBar and its mouseMiddleClick signal.
> >
> > AFAIK, currently the only solution is to subclass QTabBar, override
> > the mousePressEvent method and emit a signal from there. Dolphin uses
> > this approach. There were many other reasons why Emmanuel created a
> > custom QTabBar subclass for Dolphin though .
> >
> > If many apps need the "middle click to close" bevavior, then
> > reanimating KTabBar or getting this functionality into QTabBar might
> > be better than making every app create its own tab bar class.
>
> Or maybe contribute mouseMiddleClick to QTabBar?
> (I'm not volunteering :P)

I am, but only if it can wait until after the 29 of November. Is it ok?

Cheers,

David Gil

>
> --
> Nicolás
> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: How to port KTabBar::mouseMiddleClick?

2014-11-11 Thread Kevin Funk

On Monday 10 November 2014 15:19:22 Nicolás Alvarez wrote:
> 2014-11-09 7:28 GMT-03:00 Frank Reininghaus :
> > Hi,
> > 
> > 2014-11-06 2:59 GMT+01:00 Milian Wolff:
> >> Hey all,
> >> 
> >> what do I do to get middle-click-closes-tab in Qt 5 without KTabBar?
> >> Previously, we used KTabBar and its mouseMiddleClick signal.
> > 
> > AFAIK, currently the only solution is to subclass QTabBar, override
> > the mousePressEvent method and emit a signal from there. Dolphin uses
> > this approach. There were many other reasons why Emmanuel created a
> > custom QTabBar subclass for Dolphin though .
> > 
> > If many apps need the "middle click to close" bevavior, then
> > reanimating KTabBar or getting this functionality into QTabBar might
> > be better than making every app create its own tab bar class.
> 
> Or maybe contribute mouseMiddleClick to QTabBar?
> (I'm not volunteering :P)

Yep. I'm wondering if an a patch just reacting on middle clicks would be 
accepted. It's not like it breaks existing work flows, it's just there for 
convenience.

Grepping qtbase showed that QMdiArea has a similar feature:

widgets/qmdiarea.cpp
582-void QMdiAreaTabBar::mousePressEvent(QMouseEvent *event)
583-{
584:if (event->button() != Qt::MidButton) {
585-QTabBar::mousePressEvent(event);
586-return;
587-}
588-
589-QMdiSubWindow *subWindow = subWindowFromIndex(tabAt(event->pos()));
590-if (!subWindow) {
591-event->ignore();
592-return;
593-}
594-
595-subWindow->close();
596-}

Worth trying to patch this into QTabBar right away, I think.

Cheers

-- 
Kevin Funk | kf...@kde.org | http://kfunk.org
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

2014-11-11 Thread David Faure



> On Nov. 10, 2014, 9:57 p.m., David Faure wrote:
> > src/services/kplugininfo.cpp, line 47
> > 
> >
> > Missing "static" before inline, if these methods are only used in this 
> > .cpp file.
> 
> Alexander Richardson wrote:
> I put it all in an anonymous namespace as Milian suggested. Should be 
> equivalent to marking them as static.

Ah, yes, indeed, sorry.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120198/#review70220
---


On Nov. 7, 2014, 4:38 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120198/
> ---
> 
> (Updated Nov. 7, 2014, 4:38 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> A series of 4 commits:
> 
> 
> 
> KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage
> 
> This means that KPluginInfo can now simply reuse the QJsonObject
> returned by QPluginLoader.metaData() (by storing it in a 
> KPluginMetaData object instead of having to convert the JSON to a
> QVariantMap first.
> 
> Additionally this allows very efficient conversion between KPluginInfo
> and KPluginMetaData.
> 
> ---
> Add compatibility key names to KPluginInfo::property()
> 
> ---
> 
> KPluginInfo: Fix loading JSON metadata that only has compatibility keys
> 
> This can be removed in KF6, but for now allows loading all both old
> style as well as new style metadata
> 
> 
> 
> kplugininfotest: also test objects constructed from JSON
> 
> This tests both new style JSON as well as JSON using the old key names
> 
> 
> Diffs
> -
> 
>   src/services/kplugininfo.cpp 54593e57ca2b898a7d68de2915b7e40c3aa96f5f 
>   autotests/CMakeLists.txt 913e848ba5d1754ef7726f92604d1aaa398fa107 
>   autotests/kplugininfotest.cpp 9d4ee046db1e5d0b9f30a9a68929147763ee1cfa 
>   src/services/kplugininfo.h 871d6a2ead5a9b358d864372152cbfa0c43d8a68 
> 
> Diff: https://git.reviewboard.kde.org/r/120198/diff/
> 
> 
> Testing
> ---
> 
> All unit tests still work
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121082: Add TODO for private signals in KJob

2014-11-11 Thread Kevin Funk


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121082/
---

(Updated Nov. 11, 2014, 8:48 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kcoreaddons


Description
---

Can't change that now because it would be BIC.


Diffs
-

  src/lib/jobs/kjob.h d4b7abd3774626f450aadb4e43185ed5bb654792 

Diff: https://git.reviewboard.kde.org/r/121082/diff/


Testing
---


Thanks,

Kevin Funk

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121100: Add qCDebug statements back into knewstuff sources.

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

Re: [RFC] [kservice] KPluginMetadata indexing

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

Re: Review Request 121094: KCoreAddons: add KTextToHTML class for plaintext -> HTML conversion

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

Re: Review Request 121103: KCodecs: Import KEmailAddress class from email address parsing and validation from KPimUtils

Review Request 121103: KCodecs: Import KEmailAddress class from email address parsing and validation from KPimUtils

Re: Review Request 121094: KCoreAddons: add KTextToHTML class for plaintext -> HTML conversion

Re: Review Request 121094: KCoreAddons: add KTextToHTML class for plaintext -> HTML conversion

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

Jenkins build became unstable: kservice_master_qt5 #199

Re: Review Request 121100: Add qCDebug statements back into knewstuff sources.

Re: How to port KTabBar::mouseMiddleClick?

Re: How to port KTabBar::mouseMiddleClick?

Re: How to port KTabBar::mouseMiddleClick?

Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

Re: Review Request 121082: Add TODO for private signals in KJob

24 matches

Site Navigation

Mail list logo

Footer information