FAM in kdirwatch

2014-11-28 Thread Jonathan Riddell
At Kubuntu we're trying to work out if we want kcoreaddons to build-dep on FAM.

FAM isn't used if inotify is available and kdelibs never built against FAM.

But we had this bug report about FAM being needed for NFS 
 https://bugs.launchpad.net/ubuntu/+source/kde4libs/+bug/525005
will build-dep on FAM fix uses using NFS and are there any downsides to 
building with FAM?

Jonathan
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Where are my systray icons cont'd

2014-11-28 Thread Kevin Funk
On Thursday 27 November 2014 21:10:10 Kevin Funk wrote:
 Heya,
 
 I'm still missing my beloved systray icons for a few applications in Plasma
 5 on Ubuntu 14.10 (using distro provided packages).
 
 I have every package installed according to [1] (sni-qt, libindicator*), but
 still, systray icons for Pidgin or Skype won't show up. Also see [2].
 
 What am I doing wrong? :)
 
 PS: I really don't have a clue about implementation details here, so any
 hints are more than welcome.
 PPS: Doesn't seem distro-related, Helio has the same issues on Fedora, self-
 compiled Plasma 5
 
 [1]
 http://blog.martin-graesslin.com/blog/2014/06/where-are-my-systray-icons/
 [2] https://developer.pidgin.im/ticket/16456

Alright. I fixed my issue with Pidgin by installing another plugin: 
Installed the 'pidgin-indicator' plugin [1], which provides an AppIndicator.

PS: IOW that means, Xembed-based icons still don't seem to work for me. Is 
this an Ubuntu-only problem or am I missing something? (I have a Qt5-based 
app, using QSystemTrayIcon, whose systray icon doesn't show up)

[1] http://www.webupd8.org/2014/01/pidgin-indicator-ubuntu-appindicator.html

-- 
Kevin Funk | kf...@kde.org | http://kfunk.org
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Re: Where are my systray icons cont'd

2014-11-28 Thread Martin Gräßlin
On Friday 28 November 2014 16:49:51 Kevin Funk wrote:
 On Thursday 27 November 2014 21:10:10 Kevin Funk wrote:
  Heya,
  
  I'm still missing my beloved systray icons for a few applications in
  Plasma
  5 on Ubuntu 14.10 (using distro provided packages).
  
  I have every package installed according to [1] (sni-qt, libindicator*),
  but still, systray icons for Pidgin or Skype won't show up. Also see [2].
  
  What am I doing wrong? :)
  
  PS: I really don't have a clue about implementation details here, so any
  hints are more than welcome.
  PPS: Doesn't seem distro-related, Helio has the same issues on Fedora,
  self- compiled Plasma 5
  
  [1]
  http://blog.martin-graesslin.com/blog/2014/06/where-are-my-systray-icons/
  [2] https://developer.pidgin.im/ticket/16456
 
 Alright. I fixed my issue with Pidgin by installing another plugin:
 Installed the 'pidgin-indicator' plugin [1], which provides an AppIndicator.

good :-)

 
 PS: IOW that means, Xembed-based icons still don't seem to work for me. Is
 this an Ubuntu-only problem or am I missing something? (I have a Qt5-based
 app, using QSystemTrayIcon, whose systray icon doesn't show up)

do you use Qt 5.4? As indicated in my blog post Qt 5.3 is not sufficient and 
needs a patch. Also the frameworksintegration plugin needs to be adjusted for 
running with Qt 5.3+patch IIRC.

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2014-11-28 Thread Alexander Richardson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121218/
---

(Updated Nov. 28, 2014, 7:51 nachm.)


Review request for KDE Frameworks.


Changes
---

Also allow using e.g. KStandardAction::undo() with new style connect syntax


Repository: kconfigwidgets


Description
---

Not sure if MSVC has the necessary type_traits working, but can't test that now 
since it don't have a Windows machine available.


Diffs (updated)
-

  autotests/kstandardactiontest.h 0008d281c0353e872feb7483c75762a0012a7b76 
  autotests/kstandardactiontest.cpp 09ae35db05467d61b8baf50fac70c6228e324492 
  src/kstandardaction.h d511778b7a24b1ec2e546949dab21f1ec2fea96f 
  src/kstandardaction.cpp e5bea7965032355501b4c238e37abcc0f883c0b7 

Diff: https://git.reviewboard.kde.org/r/121218/diff/


Testing
---

The newly added unit test passes


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 121063: use correct ki18n_wrap_ui in ki18n based framework

2014-11-28 Thread Burkhard Lück

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121063/#review71060
---


Ping?

- Burkhard Lück


On Nov. 8, 2014, 2:10 nachm., Burkhard Lück wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121063/
 ---
 
 (Updated Nov. 8, 2014, 2:10 nachm.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kdelibs4support
 
 
 Description
 ---
 
 see summary 
 
 
 Diffs
 -
 
   src/kssl/kcm/CMakeLists.txt 4e5ac11 
   tests/CMakeLists.txt 25275e8 
 
 Diff: https://git.reviewboard.kde.org/r/121063/diff/
 
 
 Testing
 ---
 
 builds
 
 
 Thanks,
 
 Burkhard Lück
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2014-11-28 Thread Alexander Richardson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121218/
---

(Updated Nov. 28, 2014, 8:02 nachm.)


Review request for KDE Frameworks.


Changes
---

remove unneccesary code, this is handled below


Repository: kconfigwidgets


Description
---

Not sure if MSVC has the necessary type_traits working, but can't test that now 
since it don't have a Windows machine available.


Diffs (updated)
-

  autotests/kstandardactiontest.h 0008d281c0353e872feb7483c75762a0012a7b76 
  src/kstandardaction.cpp e5bea7965032355501b4c238e37abcc0f883c0b7 
  autotests/kstandardactiontest.cpp 09ae35db05467d61b8baf50fac70c6228e324492 
  src/kstandardaction.h d511778b7a24b1ec2e546949dab21f1ec2fea96f 

Diff: https://git.reviewboard.kde.org/r/121218/diff/


Testing
---

The newly added unit test passes


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 121283: Allow using new style connect in KActionCollection::add[Action]()

2014-11-28 Thread Alexander Richardson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121283/
---

Review request for KDE Frameworks.


Repository: kxmlgui


Description
---

Allow using new style connect in KActionCollection::add[Action]()


Diffs
-

  src/kactioncollection.h 879f5920bddc04c9ff48d137ae386a860382 

Diff: https://git.reviewboard.kde.org/r/121283/diff/


Testing
---


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 121063: use correct ki18n_wrap_ui in ki18n based framework

2014-11-28 Thread Aleix Pol Gonzalez

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121063/#review71065
---

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Nov. 8, 2014, 2:10 p.m., Burkhard Lück wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121063/
 ---
 
 (Updated Nov. 8, 2014, 2:10 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kdelibs4support
 
 
 Description
 ---
 
 see summary 
 
 
 Diffs
 -
 
   src/kssl/kcm/CMakeLists.txt 4e5ac11 
   tests/CMakeLists.txt 25275e8 
 
 Diff: https://git.reviewboard.kde.org/r/121063/diff/
 
 
 Testing
 ---
 
 builds
 
 
 Thanks,
 
 Burkhard Lück
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: FAM in kdirwatch

2014-11-28 Thread Matthew Dawson
On November 28, 2014 01:16:02 PM Jonathan Riddell wrote:
 At Kubuntu we're trying to work out if we want kcoreaddons to build-dep on
 FAM.
 
 FAM isn't used if inotify is available and kdelibs never built against FAM.
 
 But we had this bug report about FAM being needed for NFS
  https://bugs.launchpad.net/ubuntu/+source/kde4libs/+bug/525005
 will build-dep on FAM fix uses using NFS and are there any downsides to
 building with FAM?
Be careful with FAM on local file systems if you use the old FAM daemon.  
There is a bug in either FAM or the kernel that breaks FAM's use of dnotify.  
Gamin doesn't suffer this issue on local disks (as it uses inotify).  I don't 
know if this would affect NFS users in either program.

I've been meaning to dig deeper and find out what is going on, I just haven't 
had time.
-- 
Matthew

smime.p7s
Description: S/MIME cryptographic signature
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel