date:20141228


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120388/#review72634
---


low-level review: no need to create a QFile, use QFile::exists(path)

higher-level review: ensuring that a file exists before calling KSaveFile, 
which *creates* the file, sounds weird. I mean, isn't this exactly what will 
happen the very first time a wallet is created? (disclaimer - I don't know this 
code so I'm probably missing context).

- David Faure


On Dec. 11, 2014, 2:16 a.m., Arjun AK wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120388/
> ---
> 
> (Updated Dec. 11, 2014, 2:16 a.m.)
> 
> 
> Review request for KDE Frameworks, Àlex Fiestas, Teo Mrnjavac, and Valentin 
> Rusu.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> 1. Create a new wallet "foo"
> 2. immediately remove the 'kwalletd5' directory
> 3. `KWalletD::timedOutSync()` will call sync on a nonexistant wallet (which 
> will create "foo.kwl")
> 
> Kwalletmanager still lists the wallet and new data can be added to the 
> wallet, but this data will be lost once the wallet is closed since the salt 
> has been deleted and therefore the wallet cannot be opened again.
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/backend/kwalletbackend.cc b072cec 
> 
> Diff: https://git.reviewboard.kde.org/r/120388/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: OSX/CI: kio placed files erroneously due to missing required backslash in path

2014-12-28 23:22 GMT+01:00 David Faure:
> On Sunday 28 December 2014 22:54:51 Frank Reininghaus wrote:
>> Hi,
>>
>> 2014-12-23 9:44 GMT+01:00 David Faure:
>> > On Tuesday 23 December 2014 00:59:56 Marko Käning wrote:
>> >>   Fixed in
>> >>
>> >> http://commits.kde.org/kio/c5522b6931908d3fd8ad97555a3edf2a3e859b50
>> >>
>> >> Ooops, should I have pushed this through Gerrit before committing?
>> >
>> > Nope, that's fine, trivial fix. Thanks!
>>
>> Wouldn't it be better to use QDir::separator() though, in order to
>> make sure that it works on non-Unix operating systems?
>
> This seems to be a very common misconception
>
> All of the Qt API works fine with forward slashes.
>
> The Windows file-engine in Qt takes care of converting if necessary for the
> underlying native calls, but Qt encapsulates all of that for us, in order to
> make application development much easier.
>
> You only need to use QDir::separator()  well, never, mostly ;)
> If you want to display a path to the user you can use
> QDir::toNativeSeparators() and when reading a path from the user you can use
> QDir::fromNativeSeparators().
>
> Anyway, in this commit we're not talking about user-visible stuff, so '/' is
> perfectly fine.

I see. Thanks for the explanation, David!

Regards,
Fran
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121081: QT_WA


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121081/#review72633
---

Ship it!


Ship It!

- David Faure


On Nov. 8, 2014, 10:27 p.m., Andrius da Costa Ribas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121081/
> ---
> 
> (Updated Nov. 8, 2014, 10:27 p.m.)
> 
> 
> Review request for KDE Base Apps, KDE Frameworks and kdewin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> ---
> 
> QT_WA is not available on Qt5. We also only use the Unicode version, anyways.
> 
> 
> Diffs
> -
> 
>   lib/konq/src/konq_copytomenu.cpp 7f97c12 
> 
> Diff: https://git.reviewboard.kde.org/r/121081/diff/
> 
> 
> Testing
> ---
> 
> It builds (MSVC2013 - 64bit) after this patch (along other patches I'm 
> sending to review today). Kdebase-apps is still not very functional, though 
> (missing icons and weird UI).
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118452/
---

(Updated Dec. 28, 2014, 10:22 p.m.)

Status
--

This change has been marked as submitted.

Review request for KDE Frameworks and David Faure.

Repository: kio

Description
---

I am continuing to split up https://git.reviewboard.kde.org/r/113355/ , which
attempts to make UDSEntry more efficient memory and CPU-wise, into independent
parts. This is the third step after
https://git.reviewboard.kde.org/r/113591/ and
https://git.reviewboard.kde.org/r/115739/ .

The present patch modifies the internal data storage of UDSEntry. UDSEntry
contains a mapping from unsigned int keys to "Field" values, where Field is a
struct that contains a QString and a long long (some keys correspond to numeric
values, like size, date, etc, whereas others, like user and group, correspond
to a QString).

Currently, UDSEntry stores all data in a QHash internally. This
ensures that everything can be accessed in O(1) time, but is not very efficient
memory-wise because a separate memory allocation is done for each hash node.

I propose to change this and store both the uint keys and the Field values in a
QVector each. This means that accessing a value becomes a O(n) operation, since
the entire QVector of keys may need to be scanned in order to find a value, but
because the number n of values in a UDSEntry is usually quite small and can
currently not exceed a number ~100, this should not matter in practice.

Some parts of https://git.reviewboard.kde.org/r/113355/ are still missing:

(a) The QVectors which store the keys (which are usually the same for all items
in a directory) are not shared yet. Changing this would reduce the memory usage
further, but I decided to keep this change separate in order to keep the
current patch small and easy to understand. Moreover, this makes it easier to
benchmark other similar approaches (e.g., replace QVector by std::vector, or
store keys and values together in a std::vector>).

(b) No space is reserved in the vectors when key/value pairs are inserted one
by one. Implementing this would make UDSEntry faster on the slave side (since
repeated re-allocations would not be necessary any more), but this can be done
in a later patch. Moreover, it might not be needed any more if UDSEntry is not
used directly any more on the slave side, as suggested on the frameworks
mailing list by Aaron (good idea BTW!).

Diffs
-

tests/udsentrybenchmark.cpp 9bedb7b
autotests/udsentry_benchmark.cpp b5fa8d6
src/core/udsentry.h 98a7035
src/core/udsentry.cpp b806e0e
src/ioslaves/file/file.cpp 1a2a767

Diff: https://git.reviewboard.kde.org/r/118452/diff/

Testing
---

Unit tests still pass.

The memory usage of listjobtest with a directory with 100,000 files is reduced
from 71344 K to 35392 K according to KSysGuard. I see similar savings when
opening the directory in Dolphin.

I still haven't set up a Qt5/KF5 build in release mode (shame on me!), so I
cannot present any benchmark results.

File Attachments

Benchmark results

https://git.reviewboard.kde.org/media/uploaded/files/2014/12/09/038e443c-78eb-443b-b33a-b451b28d10ea__UDSEntry-benchmarks.png

Thanks,

Frank Reininghaus

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118452/
---

(Updated Dez. 28, 2014, 10:22 nachm.)

Review request for KDE Frameworks and David Faure.

Repository: kio

Description
---

Some parts of https://git.reviewboard.kde.org/r/113355/ are still missing:

Diffs (updated)
-

tests/udsentrybenchmark.cpp 9bedb7b
autotests/udsentry_benchmark.cpp b5fa8d6
src/core/udsentry.h 98a7035
src/core/udsentry.cpp b806e0e
src/ioslaves/file/file.cpp 1a2a767

Diff: https://git.reviewboard.kde.org/r/118452/diff/

Testing
---

Unit tests still pass.

The memory usage of listjobtest with a directory with 100,000 files is reduced
from 71344 K to 35392 K according to KSysGuard. I see similar savings when
opening the directory in Dolphin.

I still haven't set up a Qt5/KF5 build in release mode (shame on me!), so I
cannot present any benchmark results.

File Attachments

Benchmark results

https://git.reviewboard.kde.org/media/uploaded/files/2014/12/09/038e443c-78eb-443b-b33a-b451b28d10ea__UDSEntry-benchmarks.png

Thanks,

Frank Reininghaus

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: OSX/CI: kio placed files erroneously due to missing required backslash in path

On Sunday 28 December 2014 22:54:51 Frank Reininghaus wrote:
> Hi,
> 
> 2014-12-23 9:44 GMT+01:00 David Faure:
> > On Tuesday 23 December 2014 00:59:56 Marko Käning wrote:
> >>   Fixed in
> >> 
> >> http://commits.kde.org/kio/c5522b6931908d3fd8ad97555a3edf2a3e859b50
> >> 
> >> Ooops, should I have pushed this through Gerrit before committing?
> > 
> > Nope, that's fine, trivial fix. Thanks!
> 
> Wouldn't it be better to use QDir::separator() though, in order to
> make sure that it works on non-Unix operating systems?

This seems to be a very common misconception

All of the Qt API works fine with forward slashes.

The Windows file-engine in Qt takes care of converting if necessary for the 
underlying native calls, but Qt encapsulates all of that for us, in order to 
make application development much easier.

You only need to use QDir::separator()  well, never, mostly ;)
If you want to display a path to the user you can use 
QDir::toNativeSeparators() and when reading a path from the user you can use 
QDir::fromNativeSeparators().

Anyway, in this commit we're not talking about user-visible stuff, so '/' is 
perfectly fine.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage



> On Dez. 20, 2014, 11:46 vorm., David Faure wrote:
> > src/core/udsentry.cpp, line 51
> > 
> >
> > Can you add an example, to ease the understanding of the data structure?
> > 
> > Do I understand it correctly that this is how it works?
> > udsIndexes=[UDS_NAME, UDS_FILE_SIZE, ...]
> > and fields=[Field("filename"), Field(1234), ...]
> > 
> > and therefore the two vectors will always have the same size?

Yes indeed, thanks for bringing that issue up! I'll add the example and then 
push the commit in a minute.


- Frank


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118452/#review72334
---


On Dez. 11, 2014, 10:08 nachm., Frank Reininghaus wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118452/
> ---
> 
> (Updated Dez. 11, 2014, 10:08 nachm.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> I am continuing to split up https://git.reviewboard.kde.org/r/113355/ , which 
> attempts to make UDSEntry more efficient memory and CPU-wise, into 
> independent parts. This is the third step after 
> https://git.reviewboard.kde.org/r/113591/ and 
> https://git.reviewboard.kde.org/r/115739/ .
> 
> The present patch modifies the internal data storage of UDSEntry. UDSEntry 
> contains a mapping from unsigned int keys to "Field" values, where Field is a 
> struct that contains a QString and a long long (some keys correspond to 
> numeric values, like size, date, etc, whereas others, like user and group, 
> correspond to a QString).
> 
> Currently, UDSEntry stores all data in a QHash internally. This 
> ensures that everything can be accessed in O(1) time, but is not very 
> efficient memory-wise because a separate memory allocation is done for each 
> hash node.
> 
> I propose to change this and store both the uint keys and the Field values in 
> a QVector each. This means that accessing a value becomes a O(n) operation, 
> since the entire QVector of keys may need to be scanned in order to find a 
> value, but because the number n of values in a UDSEntry is usually quite 
> small and can currently not exceed a number ~100, this should not matter in 
> practice.
> 
> Some parts of https://git.reviewboard.kde.org/r/113355/ are still missing:
> 
> (a) The QVectors which store the keys (which are usually the same for all 
> items in a directory) are not shared yet. Changing this would reduce the 
> memory usage further, but I decided to keep this change separate in order to 
> keep the current patch small and easy to understand. Moreover, this makes it 
> easier to benchmark other similar approaches (e.g., replace QVector by 
> std::vector, or store keys and values together in a 
> std::vector>).
> 
> (b) No space is reserved in the vectors when key/value pairs are inserted one 
> by one. Implementing this would make UDSEntry faster on the slave side (since 
> repeated re-allocations would not be necessary any more), but this can be 
> done in a later patch. Moreover, it might not be needed any more if UDSEntry 
> is not used directly any more on the slave side, as suggested on the 
> frameworks mailing list by Aaron (good idea BTW!). 
> 
> 
> Diffs
> -
> 
>   autotests/udsentry_benchmark.cpp b5fa8d6 
>   src/core/udsentry.h 98a7035 
>   src/core/udsentry.cpp b806e0e 
>   src/ioslaves/file/file.cpp 1a2a767 
>   tests/udsentrybenchmark.cpp 9bedb7b 
> 
> Diff: https://git.reviewboard.kde.org/r/118452/diff/
> 
> 
> Testing
> ---
> 
> Unit tests still pass.
> 
> The memory usage of listjobtest with a directory with 100,000 files is 
> reduced from 71344 K to 35392 K according to KSysGuard. I see similar savings 
> when opening the directory in Dolphin.
> 
> I still haven't set up a Qt5/KF5 build in release mode (shame on me!), so I 
> cannot present any benchmark results.
> 
> 
> File Attachments
> 
> 
> Benchmark results
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/12/09/038e443c-78eb-443b-b33a-b451b28d10ea__UDSEntry-benchmarks.png
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Jenkins build became unstable: kio_master_qt5 #489

2014-12-28 Thread Ben Cooksley

On Mon, Dec 29, 2014 at 11:15 AM, David Faure  wrote:
> On Sunday 28 December 2014 21:36:02 KDE CI System wrote:
>> See 
>
> Timeout.
>
> The test does finish in time, it's just that it spawns a kioexec process that
> sleeps 3 minutes before exiting. Looks like the CI waits for that, somehow...

My guess is that the kioexec process doesn't fork off appropriately -
CTest is rather sensitive to that.
I've noticed the same behaviour occurs when kdeinit and the like get
autolaunched - the tests will block then as well.

>
> I guess I'll have to add an --immediate command-line option then...
>
> --
> David Faure, fa...@kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5

Cheers,
Ben

>
> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Jenkins build became unstable: kio_master_qt5 #489

On Sunday 28 December 2014 21:36:02 KDE CI System wrote:
> See 

Timeout.

The test does finish in time, it's just that it spawns a kioexec process that 
sleeps 3 minutes before exiting. Looks like the CI waits for that, somehow...

I guess I'll have to add an --immediate command-line option then...

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: OSX/CI: kio placed files erroneously due to missing required backslash in path

Hi,

2014-12-23 9:44 GMT+01:00 David Faure:
> On Tuesday 23 December 2014 00:59:56 Marko Käning wrote:
>>   Fixed in
>> http://commits.kde.org/kio/c5522b6931908d3fd8ad97555a3edf2a3e859b50
>>
>> Ooops, should I have pushed this through Gerrit before committing?
>
> Nope, that's fine, trivial fix. Thanks!

Wouldn't it be better to use QDir::separator() though, in order to
make sure that it works on non-Unix operating systems?

Cheers,
Frank
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kio_stable_qt5 #52

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kio_master_qt5 #489

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121618: Better name for kdoctools translation domain


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121618/#review72613
---

Ship it!


Yep, go for it, I'll release next saturday, so you have one week to adjust the 
po file names.

(I'll write down more dates on https://techbase.kde.org/Schedules/Frameworks, 
but it's basically the first saturday of every month).

- David Faure


On Dec. 28, 2014, 4 p.m., Luigi Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121618/
> ---
> 
> (Updated Dec. 28, 2014, 4 p.m.)
> 
> 
> Review request for KDE Frameworks, Localization and Translation (l10n) and 
> David Faure.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> The current name for kdoctools translation domain is an historical leftover 
> from the split (code shared mostly with kio_help, now in a totally different 
> repository), so better use a more descriptive name.
> 
> I will take care of renaming the existing translation files.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 357148b 
>   src/Messages.sh c63c180 
> 
> Diff: https://git.reviewboard.kde.org/r/121618/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121618: Better name for kdoctools translation domain

2014-12-28 Thread Luigi Toscano


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121618/
---

(Updated Dic. 28, 2014, 5 p.m.)


Review request for KDE Frameworks, Localization and Translation (l10n) and 
David Faure.


Changes
---

Adding dfaure to see if it's possible to push it for 5.6 and also because this 
affect the release scripts.


Repository: kdoctools


Description
---

The current name for kdoctools translation domain is an historical leftover 
from the split (code shared mostly with kio_help, now in a totally different 
repository), so better use a more descriptive name.

I will take care of renaming the existing translation files.


Diffs
-

  CMakeLists.txt 357148b 
  src/Messages.sh c63c180 

Diff: https://git.reviewboard.kde.org/r/121618/diff/


Testing
---


Thanks,

Luigi Toscano

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121672: Properly convert .desktop files that have an associated servicetype



> On Dec. 28, 2014, 12:19 p.m., David Faure wrote:
> > Ouch.
> > 
> > This information *is* available, in the servicetype definition file. Why 
> > not try and read it from there?
> 
> Alex Richardson wrote:
> Well, it only works once these files are installed. This is probably not 
> be the case when running kcoreaddons_desktop_to_json(). I agree it could be 
> done when creating a KPluginMetaData instance from a .desktop file, but that 
> would be very slow since we would need to parse all the service types. 
> Otherwise we need to do some caching again...

I see.

A random thought: passing the path to the servicetype desktop file to 
kcoreaddons_desktop_to_json()?
(could be either using ${CMAKE_CURRENT_SOURCE_DIR} if it's from the same repo, 
or an installed path using ${CMAKE_INSTALL_FULL_KSERVICETYPES5DIR})

(the latter wouldn't work when installing an app into a different prefix than 
the thing that installs the servicetype file, so maybe a proper lookup is 
needed, using QStandardPaths::locate in the C++ tool)


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121672/#review72590
---


On Dec. 26, 2014, 5:21 p.m., Alex Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121672/
> ---
> 
> (Updated Dec. 26, 2014, 5:21 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> This ensures that properties that are defined to be of type QStringList
> or int or bool are properly converted to the right JSON type.
> 
> Not sure if this code should also be part of KF5CoreAddons.so, since it
> does increase the library size quite a bit. It would however be very
> useful for kcoreaddons_desktop_to_json(), so that the initial conversion
> to JSON does not have to be done by hand.
> 
> I probably don't have all the service types that exist installed on my
> system so I might be missing some properties. I included the script to
> generate the list of these properties, so that missing properties can
> be added by anyone who has the required servicetypes/*.desktop files
> installed.
> 
> 
> Diffs
> -
> 
>   src/lib/plugin/read-servicetypes.py PRE-CREATION 
>   autotests/desktoptojsontest.cpp 64373d5be930426dd8a1f8e455e33c411a4795fd 
>   src/lib/plugin/desktopfileparser.cpp 
> b1b5440b48e4fd412932a7d7e794d641b1406699 
> 
> Diff: https://git.reviewboard.kde.org/r/121672/diff/
> 
> 
> Testing
> ---
> 
> Unit test works
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121672: Properly convert .desktop files that have an associated servicetype

2014-12-28 Thread Alex Richardson



> On Dez. 28, 2014, 12:19 nachm., David Faure wrote:
> > Ouch.
> > 
> > This information *is* available, in the servicetype definition file. Why 
> > not try and read it from there?

Well, it only works once these files are installed. This is probably not be the 
case when running kcoreaddons_desktop_to_json(). I agree it could be done when 
creating a KPluginMetaData instance from a .desktop file, but that would be 
very slow since we would need to parse all the service types. Otherwise we need 
to do some caching again...


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121672/#review72590
---


On Dez. 26, 2014, 5:21 nachm., Alex Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121672/
> ---
> 
> (Updated Dez. 26, 2014, 5:21 nachm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> This ensures that properties that are defined to be of type QStringList
> or int or bool are properly converted to the right JSON type.
> 
> Not sure if this code should also be part of KF5CoreAddons.so, since it
> does increase the library size quite a bit. It would however be very
> useful for kcoreaddons_desktop_to_json(), so that the initial conversion
> to JSON does not have to be done by hand.
> 
> I probably don't have all the service types that exist installed on my
> system so I might be missing some properties. I included the script to
> generate the list of these properties, so that missing properties can
> be added by anyone who has the required servicetypes/*.desktop files
> installed.
> 
> 
> Diffs
> -
> 
>   src/lib/plugin/read-servicetypes.py PRE-CREATION 
>   autotests/desktoptojsontest.cpp 64373d5be930426dd8a1f8e455e33c411a4795fd 
>   src/lib/plugin/desktopfileparser.cpp 
> b1b5440b48e4fd412932a7d7e794d641b1406699 
> 
> Diff: https://git.reviewboard.kde.org/r/121672/diff/
> 
> 
> Testing
> ---
> 
> Unit test works
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121712: Add install target for the KF5 Book

2014-12-28 Thread Andreas Cord-Landwehr


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121712/
---

Review request for KDE Frameworks.


Repository: kf5book


Description
---

Install the book to /usr/share/doc/frameworks5


Diffs
-

  CMakeLists.txt 4e10120 

Diff: https://git.reviewboard.kde.org/r/121712/diff/


Testing
---

manual testing


Thanks,

Andreas Cord-Landwehr

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121672: Properly convert .desktop files that have an associated servicetype


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121672/#review72590
---


Ouch.

This information *is* available, in the servicetype definition file. Why not 
try and read it from there?

- David Faure


On Dec. 26, 2014, 5:21 p.m., Alex Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121672/
> ---
> 
> (Updated Dec. 26, 2014, 5:21 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> This ensures that properties that are defined to be of type QStringList
> or int or bool are properly converted to the right JSON type.
> 
> Not sure if this code should also be part of KF5CoreAddons.so, since it
> does increase the library size quite a bit. It would however be very
> useful for kcoreaddons_desktop_to_json(), so that the initial conversion
> to JSON does not have to be done by hand.
> 
> I probably don't have all the service types that exist installed on my
> system so I might be missing some properties. I included the script to
> generate the list of these properties, so that missing properties can
> be added by anyone who has the required servicetypes/*.desktop files
> installed.
> 
> 
> Diffs
> -
> 
>   src/lib/plugin/read-servicetypes.py PRE-CREATION 
>   autotests/desktoptojsontest.cpp 64373d5be930426dd8a1f8e455e33c411a4795fd 
>   src/lib/plugin/desktopfileparser.cpp 
> b1b5440b48e4fd412932a7d7e794d641b1406699 
> 
> Diff: https://git.reviewboard.kde.org/r/121672/diff/
> 
> 
> Testing
> ---
> 
> Unit test works
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121461: Fix for bug 341773 and minor changes



> On Dec. 26, 2014, 8:14 a.m., David Faure wrote:
> > This has been reverted for now, it broke the kio_trash unittest, because it 
> > doesn't preserve extensions anymore. Please revisit.
> 
> Arjun AK wrote:
> Like i said in the ML, what should be done with the following files:
> `.txt`
> `..txt`
> `...`
> 
> David Faure wrote:
> With the goal of "preserving extensions", I would say:
> 
> .txt -> 1.txt
> ..txt -> 1..txt or .1.txt (don't really care which one)
> ... -> whatever
> 
> What the patch broke was much more severe:   file.foo became file.foo1 
> (for any unknown extension).
> 
> Arjun AK wrote:
> >.txt -> 1.txt
> >..txt -> 1..txt or .1.txt (don't really care which one)
> 
> But the problem with that is `.txt` is a hidden file, If you change it to 
> `1.txt`, it becomes visible. The user most likely doesn't want that.
> 
> >What the patch broke was much more severe:   file.foo became file.foo1 
> (for any unknown extension).
> 
> That indeed was wrong, i didn't handle the else part of 
> `!db.suffixForFileName(oldName).isEmpty()`

Ah right. Then let's try to meet both goals:

.txt -> .1.txt  (special case, adding '.' in front again so it stays hidden)
..txt -> .1.txt
... -> ..1.

It seems to me that this is easy to achieve: with the old (current) algorithm, 
just add
   if (oldName.startsWith('.') && !newName.startsWith('.')) {
   newName.prepend('.');
   }


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121461/#review72518
---


On Dec. 23, 2014, 5:56 p.m., Arjun AK wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121461/
> ---
> 
> (Updated Dec. 23, 2014, 5:56 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 341773
> https://bugs.kde.org/show_bug.cgi?id=341773
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> 1.Fix bug 341773 (Replace dialog suggests incorrect filename when it contains 
> dots). Make use of `QMimeDatabase::suffixForFileName` for calculating the 
> extension.
> 2. Rename `.foo` and `..foo` into `.foo 1` and `..foo 1` respectively, 
> instead of `1.foo` and `.1.foo`, since they are hidden files and we shouldn't 
> be changing that.
> 
> 
> Diffs
> -
> 
>   autotests/globaltest.cpp 06cb500 
>   src/core/global.cpp f18ac10 
> 
> Diff: https://git.reviewboard.kde.org/r/121461/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121461: Fix for bug 341773 and minor changes

2014-12-28 Thread Arjun AK



> On Dec. 26, 2014, 1:44 p.m., David Faure wrote:
> > This has been reverted for now, it broke the kio_trash unittest, because it 
> > doesn't preserve extensions anymore. Please revisit.
> 
> Arjun AK wrote:
> Like i said in the ML, what should be done with the following files:
> `.txt`
> `..txt`
> `...`
> 
> David Faure wrote:
> With the goal of "preserving extensions", I would say:
> 
> .txt -> 1.txt
> ..txt -> 1..txt or .1.txt (don't really care which one)
> ... -> whatever
> 
> What the patch broke was much more severe:   file.foo became file.foo1 
> (for any unknown extension).

>.txt -> 1.txt
>..txt -> 1..txt or .1.txt (don't really care which one)

But the problem with that is `.txt` is a hidden file, If you change it to 
`1.txt`, it becomes visible. The user most likely doesn't want that.

>What the patch broke was much more severe:   file.foo became file.foo1 (for 
>any unknown extension).

That indeed was wrong, i didn't handle the else part of 
`!db.suffixForFileName(oldName).isEmpty()`


- Arjun


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121461/#review72518
---


On Dec. 23, 2014, 11:26 p.m., Arjun AK wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121461/
> ---
> 
> (Updated Dec. 23, 2014, 11:26 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 341773
> https://bugs.kde.org/show_bug.cgi?id=341773
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> 1.Fix bug 341773 (Replace dialog suggests incorrect filename when it contains 
> dots). Make use of `QMimeDatabase::suffixForFileName` for calculating the 
> extension.
> 2. Rename `.foo` and `..foo` into `.foo 1` and `..foo 1` respectively, 
> instead of `1.foo` and `.1.foo`, since they are hidden files and we shouldn't 
> be changing that.
> 
> 
> Diffs
> -
> 
>   autotests/globaltest.cpp 06cb500 
>   src/core/global.cpp f18ac10 
> 
> Diff: https://git.reviewboard.kde.org/r/121461/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121461: Fix for bug 341773 and minor changes



> On Dec. 26, 2014, 8:14 a.m., David Faure wrote:
> > This has been reverted for now, it broke the kio_trash unittest, because it 
> > doesn't preserve extensions anymore. Please revisit.
> 
> Arjun AK wrote:
> Like i said in the ML, what should be done with the following files:
> `.txt`
> `..txt`
> `...`

With the goal of "preserving extensions", I would say:

.txt -> 1.txt
..txt -> 1..txt or .1.txt (don't really care which one)
... -> whatever

What the patch broke was much more severe:   file.foo became file.foo1 (for any 
unknown extension).


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121461/#review72518
---


On Dec. 23, 2014, 5:56 p.m., Arjun AK wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121461/
> ---
> 
> (Updated Dec. 23, 2014, 5:56 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 341773
> https://bugs.kde.org/show_bug.cgi?id=341773
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> 1.Fix bug 341773 (Replace dialog suggests incorrect filename when it contains 
> dots). Make use of `QMimeDatabase::suffixForFileName` for calculating the 
> extension.
> 2. Rename `.foo` and `..foo` into `.foo 1` and `..foo 1` respectively, 
> instead of `1.foo` and `.1.foo`, since they are hidden files and we shouldn't 
> be changing that.
> 
> 
> Diffs
> -
> 
>   autotests/globaltest.cpp 06cb500 
>   src/core/global.cpp f18ac10 
> 
> Diff: https://git.reviewboard.kde.org/r/121461/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kf5book_master_qt5 #6

See 

--
Started by user Ben Cooksley
Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[kf5book_master_qt5] $ /bin/sh -xe /tmp/hudson1167906114539833064.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at c76bd56 Handle top level headers as chapters.
Success build forhudson.tasks.Shell@44b85707
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/kf5book # timeout=10
Fetching upstream changes from git://anongit.kde.org/kf5book
 > git --version # timeout=10
 > git fetch --tags --progress git://anongit.kde.org/kf5book 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
 > git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision c76bd56580c6eeeaf7764f4e766af58eec16a7a3 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f c76bd56580c6eeeaf7764f4e766af58eec16a7a3
 > git rev-list c76bd56580c6eeeaf7764f4e766af58eec16a7a3 # timeout=10
 > git tag -a -f -m Jenkins Build #6 jenkins-kf5book_master_qt5-6 # timeout=10
 > git remote # timeout=10
 > git submodule init # timeout=10
 > git submodule sync # timeout=10
 > git config --get remote.origin.url # timeout=10
 > git submodule update --init --recursive
Run condition [File exists] enabling prebuild for step [Publish JUnit test 
result report]
Run condition [File exists] enabling prebuild for step [Publish Cppcheck 
results]
[kf5book_master_qt5] $ /bin/sh -xe /tmp/hudson8947972810877049949.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: kf5book - Branch master
== Build Dependencies:
 qt5 - Branch 5.3.2
 snippetextractor - Branch master
 extra-cmake-modules - Branch master
 cmake - Branch master
 dogtail - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- Configuring done
-- Generating done
CMake Warning:
  Manually-specified variables were not used by the project:

KDE4_BUILD_TESTS
LIB_SUFFIX
SIP_DEFAULT_SIP_DIR


-- Build files have been written to: 


== Commencing the Build

Scanning dependencies of target epubbook
Scanning dependencies of target htmlbook
Scanning dependencies of target pdfbook
[  2%] [  5%] [  8%] [ 13%] [ 16%] [ 19%] [ 19%] [ 22%] [ 25%] Extracting 
snippets from intro_kidletime.in.md
Extracting snippets from introduction_to_TW.in.md
Extracting snippets from adding_tw_to_a_project.in.md
Extracting snippets from introduction_to_TW.in.md
Extracting snippets from introduction_to_TW.in.md
Extracting snippets from HelloWorldRaw.in.md
Extracting snippets from intro_kidletime.in.md
Extracting snippets from HelloInternet.in.md
Extracting snippets from adding_tw_to_a_project.in.md
snippetextractor - process special instructions in markdown articles to include 
code samples
* Author: Mirko Boehm 
* Licensed under the GPLv3.
snippetextractor - process special instructions in markdown articles to include 
code samples
* Author: Mirko Boehm 
* Licensed under the GPLv3.
snippetextractor - process special instructions in markdown articles to include 
code samples
* Author: Mirko Boehm 
* Licensed under the GPLv3.
snippetextractor - process special instructions in markdown articles to include 
code samples
* Author: Mirko Boehm 
* Licensed under the GPLv3.
snippetextractor - process special instructions in markdown articles to include 
code samples
* Author: Mirko Boehm 
* Licensed under the GPLv3.
snippetextractor - process special instructions in markdown articles to include 
code samples
* Author: Mirko Boehm 
* Licensed under the GPLv3.
snippetextractor - process special instructions in markdown articles to include 
code samples
* Author: Mirko Boehm 
* Licensed under the GPLv3.
snippetextractor - process special instructions in markdown articles to include 
code samples
* Author: Mirko Boehm 
* Licensed under the GPLv3.
snippetextractor - process special instructions in markdown articles to include 
code samples
* Author: Mirko Boehm 
* Licensed under the GPLv3.
[ 30%] [ 30%] [ 33%] [ 36%] [ 41%] [ 41%] [ 44%] [ 47%] Extracting snippets 
from HelloWorldRaw.in.md
Extracting snippets from HelloInternet.in.md
Extracting snippets from adding_tw_to_a_project.in.md
[ 50%] Extracting snippets from ThumbNailer.in.md
Extracting snippets from HelloInternet.in.md
Extracting snippets from kitemmodels.md
Extracting snippets fro

Build failed in Jenkins: kf5book_master_qt5 #5