Build failed in Jenkins: kio_stable_qt5 #56

2014-12-29 Thread KDE CI System 
See 

Changes:

[Kevin Funk] Quick MSVC build fix for Qt < v5.4

--
[...truncated 895 lines...]
[ 13%] Scanning dependencies of target udsentry_benchmark_automoc
Generating kurlrequestertest.moc
Built target mkpathjobtest_automoc
Scanning dependencies of target threadtest_automoc
[ 13%] Scanning dependencies of target udsentrytest_automoc
Scanning dependencies of target upurltest_automoc
[ 13%] [ 13%] Automatic moc for target udsentry_benchmark
Automatic moc for target threadtest
[ 13%] [ 14%] Automatic moc for target udsentrytest
Built target kurlrequestertest_automoc
Scanning dependencies of target httpauthenticationtest_automoc
Automatic moc for target upurltest
Generating moc_pastetest.cpp
[ 14%] [ 14%] Built target pastetest_automoc
Generating moc_udsentrytest.cpp
Scanning dependencies of target httpfiltertest_automoc
Automatic moc for target httpauthenticationtest
[ 14%] [ 14%] Built target udsentrytest_automoc
Automatic moc for target httpfiltertest
Generating udsentry_benchmark.moc
[ 14%] Scanning dependencies of target httpheaderdispositiontest_automoc
Generating threadtest.moc
Generating moc_httpauthenticationtest.cpp
Built target udsentry_benchmark_automoc
[ 14%] [ 14%] Generating upurltest.moc
[ 15%] Built target threadtest_automoc
Automatic moc for target httpheaderdispositiontest
[ 15%] Built target httpauthenticationtest_automoc
Built target upurltest_automoc
Scanning dependencies of target httpheadertokenizetest_automoc
Scanning dependencies of target kcookiejartest_automoc
[ 15%] Scanning dependencies of target getalltest_automoc
Scanning dependencies of target httpobjecttest_automoc
Automatic moc for target kcookiejartest
[ 15%] Automatic moc for target getalltest
[ 15%] [ 15%] Automatic moc for target httpobjecttest
Automatic moc for target httpheadertokenizetest
[ 15%] Built target getalltest_automoc
Scanning dependencies of target kdirlistertest_gui_automoc
[ 15%] Generating moc_httpheaderdispositiontest.cpp
Automatic moc for target kdirlistertest_gui
[ 15%] Built target httpheaderdispositiontest_automoc
Generating httpfiltertest.moc
Generating moc_httpfilter.cpp
Generating moc_kdiroperator.cpp
Generating moc_kdirsortfilterproxymodel.cpp
Generating moc_kencodingfiledialog.cpp
Generating moc_kfilebookmarkhandler_p.cpp
Generating moc_kfilefiltercombo.cpp
Generating moc_kfileplacesitem_p.cpp
Generating moc_kfileplacesmodel.cpp
Generating moc_kfileplacessharedbookmarks_p.cpp
Generating moc_kfileplacesview.cpp
Generating moc_kfileplacesview_p.cpp
Generating moc_kfilepreviewgenerator.cpp
Generating moc_kfilewidget.cpp
Generating moc_kimagefilepreview.cpp
Generating moc_knameandurlinputdialog.cpp
Generating moc_knewfilemenu.cpp
Generating moc_kpreviewwidgetbase.cpp
Generating moc_kstatusbarofflineindicator.cpp
Generating moc_kurlnavigator.cpp
Generating moc_kurlnavigatorbutton_p.cpp
Generating moc_kurlnavigatorbuttonbase_p.cpp
Generating moc_kurlnavigatordropdownbutton_p.cpp
Generating moc_kurlnavigatormenu_p.cpp
Generating moc_kurlnavigatorplacesselector_p.cpp
Generating moc_kurlnavigatorprotocolcombo_p.cpp
Generating moc_kurlnavigatortogglebutton_p.cpp
Generating moc_kdiroperatordetailview_p.cpp
Generating moc_kfilemetapreview_p.cpp
Generating moc_kfileplaceeditdialog.cpp
Scanning dependencies of target kdirmodeltest_gui_automoc
[ 15%] Generating moc_httpheadertokenizetest.cpp
[ 15%] [ 15%] Built target httpfiltertest_automoc
Built target KF5KIOFileWidgets_automoc
Built target httpheadertokenizetest_automoc
Generating kcookiejartest.moc
Scanning dependencies of target kencodingfiledialogtest_gui_automoc
[ 15%] [ 15%] [ 15%] Built target kcookiejartest_automoc
Scanning dependencies of target kionetrctest_automoc
Automatic moc for target kdirmodeltest_gui
Scanning dependencies of target kioslavetest_automoc
Scanning dependencies of target kmountpoint_debug_automoc
[ 16%] Automatic moc for target kencodingfiledialogtest_gui
[ 16%] [ 16%] Automatic moc for target kionetrctest
Automatic moc for target kioslavetest
Automatic moc for target kmountpoint_debug
[ 16%] Generating moc_kdirlistertest_gui.cpp
Built target kencodingfiledialogtest_gui_automoc
[ 16%] [ 16%] [ 16%] Built target kdirlistertest_gui_automoc
Built target kionetrctest_automoc
Built target kmountpoint_debug_automoc
Scanning dependencies of target kpropertiesdialogtest_automoc
Scanning dependencies of target kruntest_automoc
[ 16%] Scanning dependencies of target kopenwithtest_automoc
[ 17%] Automatic moc for target kruntest
Automatic moc for target kpropertiesdialogtest
[ 17%] Generating moc_httpfilter.cpp
Generating moc_httpobjecttest.cpp
Generating moc_http.cpp
[ 17%] [ 17%] Built target httpobjecttest_automoc
Built target kpropertiesdialogtest_automoc
Automatic moc for target kopenwithtest
Scanning dependencies of target listjobtest_automoc
Generating moc_kioslavetest.cpp
[ 17%] Scanning dependencies of target kurlrequestertest_gui_autom

Re: Review Request 121747: Fix broken unittest for QFileDialog::setViewMode.

2014-12-29 Thread Mark Gaiser 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121747/#review72757
---

Ship it!



autotests/kfiledialog_unittest.cpp


Coding style.



autotests/kfiledialog_unittest.cpp


Coding style.



autotests/kfiledialog_unittest.cpp


Coding style.



autotests/kfiledialog_unittest.cpp


Coding style.



autotests/kfiledialog_unittest.cpp


One more sace.



autotests/kfiledialog_unittest.cpp


Coding style.


Looks like i owe you a big sorry. Much (or all?) of those coding style issues 
seem to introduced by... me...
Anyhow, looks OK to me.

- Mark Gaiser


On dec 29, 2014, 10:38 p.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121747/
> ---
> 
> (Updated dec 29, 2014, 10:38 p.m.)
> 
> 
> Review request for KDE Frameworks, Lukáš Tinkl, Mark Gaiser, and Martin 
> Klapetek.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Commit 0b8ab82e7fa9ea0948a841ebf8523b62da made the view mode a choice of
> the user (as it always was in KDE code) rather than a choice of the
> developer (as QFileDialog::setViewMode allows).
> 
> Typical Qt/KDE difference: Qt empowers the developer, KDE empowers the user.
> I agree with Lukas that the latter makes more sense in KDE code.
> 
> => I rewrote the unittest to check that the user's changes are restored
> on the next file dialog.
> 
> 
> Diffs
> -
> 
>   autotests/kfiledialog_unittest.cpp e5108ead5a381864cfa2b8ddf62b5d6c64b13db9 
> 
> Diff: https://git.reviewboard.kde.org/r/121747/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121747: Fix broken unittest for QFileDialog::setViewMode.

2014-12-29 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121747/#review72758
---


+1 I like it.

Some late-night nitpicking. Feel free to ignore as it's only in the unit test.


autotests/kfiledialog_unittest.cpp


switch()? Use QStringLiteral?



autotests/kfiledialog_unittest.cpp


Are you sure this builds? I thought QString(char* ) wasn't allowed in 
frameworks.


- Aleix Pol Gonzalez


On Dec. 29, 2014, 10:38 p.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121747/
> ---
> 
> (Updated Dec. 29, 2014, 10:38 p.m.)
> 
> 
> Review request for KDE Frameworks, Lukáš Tinkl, Mark Gaiser, and Martin 
> Klapetek.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Commit 0b8ab82e7fa9ea0948a841ebf8523b62da made the view mode a choice of
> the user (as it always was in KDE code) rather than a choice of the
> developer (as QFileDialog::setViewMode allows).
> 
> Typical Qt/KDE difference: Qt empowers the developer, KDE empowers the user.
> I agree with Lukas that the latter makes more sense in KDE code.
> 
> => I rewrote the unittest to check that the user's changes are restored
> on the next file dialog.
> 
> 
> Diffs
> -
> 
>   autotests/kfiledialog_unittest.cpp e5108ead5a381864cfa2b8ddf62b5d6c64b13db9 
> 
> Diff: https://git.reviewboard.kde.org/r/121747/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121747: Fix broken unittest for QFileDialog::setViewMode.

2014-12-29 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121747/
---

Review request for KDE Frameworks, Lukáš Tinkl, Mark Gaiser, and Martin 
Klapetek.


Repository: frameworkintegration


Description
---

Commit 0b8ab82e7fa9ea0948a841ebf8523b62da made the view mode a choice of
the user (as it always was in KDE code) rather than a choice of the
developer (as QFileDialog::setViewMode allows).

Typical Qt/KDE difference: Qt empowers the developer, KDE empowers the user.
I agree with Lukas that the latter makes more sense in KDE code.

=> I rewrote the unittest to check that the user's changes are restored
on the next file dialog.


Diffs
-

  autotests/kfiledialog_unittest.cpp e5108ead5a381864cfa2b8ddf62b5d6c64b13db9 

Diff: https://git.reviewboard.kde.org/r/121747/diff/


Testing
---


Thanks,

David Faure

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120388: Do not sync if wallet file does not exist

2014-12-29 Thread Valentin Rusu 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120388/#review72750
---

Ship it!


Looks goot to me.

- Valentin Rusu


On Dec. 29, 2014, 1:17 p.m., Arjun AK wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120388/
> ---
> 
> (Updated Dec. 29, 2014, 1:17 p.m.)
> 
> 
> Review request for KDE Frameworks, Àlex Fiestas, Teo Mrnjavac, and Valentin 
> Rusu.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> 1. Create a new wallet "foo"
> 2. immediately remove the 'kwalletd5' directory
> 3. `KWalletD::timedOutSync()` will call sync on a nonexistant wallet (which 
> will create "foo.kwl")
> 
> Kwalletmanager still lists the wallet and new data can be added to the 
> wallet, but this data will be lost once the wallet is closed since the salt 
> has been deleted and therefore the wallet cannot be opened again.
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/backend/kwalletbackend.cc b072cec 
>   src/runtime/kwalletd/kwalletd.h b94df15 
>   src/runtime/kwalletd/kwalletd.cpp 882eb72 
> 
> Diff: https://git.reviewboard.kde.org/r/120388/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120388: Do not sync if wallet file does not exist

2014-12-29 Thread Valentin Rusu 


> On Sept. 27, 2014, 11:59 a.m., Arjun AK wrote:
> > src/runtime/kwalletd/backend/kwalletbackend.cc, line 421
> > 
> >
> > Is the return value correct?

Perhaps better file a bug report?


- Valentin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120388/#review67522
---


On Dec. 29, 2014, 1:17 p.m., Arjun AK wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120388/
> ---
> 
> (Updated Dec. 29, 2014, 1:17 p.m.)
> 
> 
> Review request for KDE Frameworks, Àlex Fiestas, Teo Mrnjavac, and Valentin 
> Rusu.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> 1. Create a new wallet "foo"
> 2. immediately remove the 'kwalletd5' directory
> 3. `KWalletD::timedOutSync()` will call sync on a nonexistant wallet (which 
> will create "foo.kwl")
> 
> Kwalletmanager still lists the wallet and new data can be added to the 
> wallet, but this data will be lost once the wallet is closed since the salt 
> has been deleted and therefore the wallet cannot be opened again.
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/backend/kwalletbackend.cc b072cec 
>   src/runtime/kwalletd/kwalletd.h b94df15 
>   src/runtime/kwalletd/kwalletd.cpp 882eb72 
> 
> Diff: https://git.reviewboard.kde.org/r/120388/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121461: Fix for bug 341773 and minor changes

2014-12-29 Thread David Faure 


> On Dec. 26, 2014, 8:14 a.m., David Faure wrote:
> > This has been reverted for now, it broke the kio_trash unittest, because it 
> > doesn't preserve extensions anymore. Please revisit.
> 
> Arjun AK wrote:
> Like i said in the ML, what should be done with the following files:
> `.txt`
> `..txt`
> `...`
> 
> David Faure wrote:
> With the goal of "preserving extensions", I would say:
> 
> .txt -> 1.txt
> ..txt -> 1..txt or .1.txt (don't really care which one)
> ... -> whatever
> 
> What the patch broke was much more severe:   file.foo became file.foo1 
> (for any unknown extension).
> 
> Arjun AK wrote:
> >.txt -> 1.txt
> >..txt -> 1..txt or .1.txt (don't really care which one)
> 
> But the problem with that is `.txt` is a hidden file, If you change it to 
> `1.txt`, it becomes visible. The user most likely doesn't want that.
> 
> >What the patch broke was much more severe:   file.foo became file.foo1 
> (for any unknown extension).
> 
> That indeed was wrong, i didn't handle the else part of 
> `!db.suffixForFileName(oldName).isEmpty()`
> 
> David Faure wrote:
> Ah right. Then let's try to meet both goals:
> 
> .txt -> .1.txt  (special case, adding '.' in front again so it stays 
> hidden)
> ..txt -> .1.txt
> ... -> ..1.
> 
> It seems to me that this is easy to achieve: with the old (current) 
> algorithm, just add
>if (oldName.startsWith('.') && !newName.startsWith('.')) {
>newName.prepend('.');
>}
> 
> Arjun AK wrote:
> >.1.txt
> 
> Shouldn't there be a space before 1 (ie ". 1.txt") else the second file 
> will be ".1 1.txt" instead of ". 2.txt"
> 
> >..txt -> .1.txt
> 
> Shouldn't that be "..1.txt" ?

Right about the first one, I forgot that the code adds spaces.

For the second, I would say ". 1.txt". There's no need to prepend another dot, 
since it's already a hidden file. My suggested code above would work like this.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121461/#review72518
---


On Dec. 23, 2014, 5:56 p.m., Arjun AK wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121461/
> ---
> 
> (Updated Dec. 23, 2014, 5:56 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 341773
> https://bugs.kde.org/show_bug.cgi?id=341773
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> 1.Fix bug 341773 (Replace dialog suggests incorrect filename when it contains 
> dots). Make use of `QMimeDatabase::suffixForFileName` for calculating the 
> extension.
> 2. Rename `.foo` and `..foo` into `.foo 1` and `..foo 1` respectively, 
> instead of `1.foo` and `.1.foo`, since they are hidden files and we shouldn't 
> be changing that.
> 
> 
> Diffs
> -
> 
>   autotests/globaltest.cpp 06cb500 
>   src/core/global.cpp f18ac10 
> 
> Diff: https://git.reviewboard.kde.org/r/121461/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121737: KPluginInfo: Fix properties not being copied from KService::Ptr

2014-12-29 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121737/#review72744
---


Yep, looks better to me. Could be unittested?

- David Faure


On Dec. 29, 2014, 7:34 p.m., Alex Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121737/
> ---
> 
> (Updated Dec. 29, 2014, 7:34 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> This should fix property() returning empty QVariants even if it
> existed in the .desktop file
> 
> 
> Diffs
> -
> 
>   src/services/kplugininfo.cpp aa5d26386eb17a7e552b29c8fa7961d68b16 
> 
> Diff: https://git.reviewboard.kde.org/r/121737/diff/
> 
> 
> Testing
> ---
> 
> KDED now correctly reads X-Kded-* in 
> https://git.reviewboard.kde.org/r/121315/ instead of reading the default 
> value.
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121737: KPluginInfo: Fix properties not being copied from KService::Ptr

2014-12-29 Thread Alex Richardson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121737/
---

(Updated Dez. 29, 2014, 7:34 nachm.)


Review request for KDE Frameworks and David Faure.


Changes
---

Don't print the debug messages when converting from KService::Ptr


Repository: kservice


Description
---

This should fix property() returning empty QVariants even if it
existed in the .desktop file


Diffs (updated)
-

  src/services/kplugininfo.cpp aa5d26386eb17a7e552b29c8fa7961d68b16 

Diff: https://git.reviewboard.kde.org/r/121737/diff/


Testing
---

KDED now correctly reads X-Kded-* in https://git.reviewboard.kde.org/r/121315/ 
instead of reading the default value.


Thanks,

Alex Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : plasma-framework_stable_qt5 » NoX11,LINBUILDER #45

2014-12-29 Thread KDE CI System 
See 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121737: KPluginInfo: Fix properties not being copied from KService::Ptr

2014-12-29 Thread Alex Richardson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121737/
---

(Updated Dez. 29, 2014, 7:30 nachm.)


Review request for KDE Frameworks and David Faure.


Changes
---

Remove the conversion code below and reuse KPluginInfoPrivate::setMetaData()


Repository: kservice


Description
---

This should fix property() returning empty QVariants even if it
existed in the .desktop file


Diffs (updated)
-

  src/services/kplugininfo.cpp aa5d26386eb17a7e552b29c8fa7961d68b16 

Diff: https://git.reviewboard.kde.org/r/121737/diff/


Testing
---

KDED now correctly reads X-Kded-* in https://git.reviewboard.kde.org/r/121315/ 
instead of reading the default value.


Thanks,

Alex Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : plasma-framework_stable_qt5 » All,LINBUILDER #45

2014-12-29 Thread KDE CI System 
See 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121737: KPluginInfo: Fix properties not being copied from KService::Ptr

2014-12-29 Thread Alex Richardson 


> On Dez. 29, 2014, 5:56 nachm., David Faure wrote:
> > propertyNames() includes the common stuff like Name, Comment, etc.
> > 
> > So maybe this removes the need for the code that follows? Or at least a 
> > good part of it?
> 
> Alex Richardson wrote:
> Yeah we probably don't want those properties, do you think letting 
> KPluginInfo access the QVariantMap in KServicePrivate is a better idea?
> 
> I.e. `json = QJsonObject::fromVariantMap(service->d->m_mapProps)`
> 
> That would be more efficient and skip all those standard .desktop 
> properties.
> 
> David Faure wrote:
> Ah, hmm, not exactly what I meant :-)
> 
> Are you sure you don't want stuff like "Keywords"? What if someone wants 
> to find KCMs that have certain keywords, shouldn't that be in the json file?
> 
> Or "MimeTypes", for the same reason?
> Or "Icon", to display per-plugin icons without loading them? (e.g. in the 
> plugin selector)
> 
> I'm surprised by the idea of having only Name, Comment, ServiceType, and 
> custom properties, but not some of the other standard stuff above.
> 
> But maybe I'm missing some context.

Ah yes, I didn't look properly, there are a lot more properties in 
KServicePrivate that are not stored in the map.
These should definitively also be converted. Maybe the easiest solution is to 
just pass the .desktop file to the KPluginMetaData constructor which then 
rereads all the properties.
Less efficient, but the constructor is deprecated anyway.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121737/#review72724
---


On Dez. 29, 2014, 5:51 nachm., Alex Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121737/
> ---
> 
> (Updated Dez. 29, 2014, 5:51 nachm.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> This should fix property() returning empty QVariants even if it
> existed in the .desktop file
> 
> 
> Diffs
> -
> 
>   src/services/kplugininfo.cpp aa5d26386eb17a7e552b29c8fa7961d68b16 
> 
> Diff: https://git.reviewboard.kde.org/r/121737/diff/
> 
> 
> Testing
> ---
> 
> KDED now correctly reads X-Kded-* in 
> https://git.reviewboard.kde.org/r/121315/ instead of reading the default 
> value.
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121737: KPluginInfo: Fix properties not being copied from KService::Ptr

2014-12-29 Thread David Faure 


> On Dec. 29, 2014, 5:56 p.m., David Faure wrote:
> > propertyNames() includes the common stuff like Name, Comment, etc.
> > 
> > So maybe this removes the need for the code that follows? Or at least a 
> > good part of it?
> 
> Alex Richardson wrote:
> Yeah we probably don't want those properties, do you think letting 
> KPluginInfo access the QVariantMap in KServicePrivate is a better idea?
> 
> I.e. `json = QJsonObject::fromVariantMap(service->d->m_mapProps)`
> 
> That would be more efficient and skip all those standard .desktop 
> properties.

Ah, hmm, not exactly what I meant :-)

Are you sure you don't want stuff like "Keywords"? What if someone wants to 
find KCMs that have certain keywords, shouldn't that be in the json file?

Or "MimeTypes", for the same reason?
Or "Icon", to display per-plugin icons without loading them? (e.g. in the 
plugin selector)

I'm surprised by the idea of having only Name, Comment, ServiceType, and custom 
properties, but not some of the other standard stuff above.

But maybe I'm missing some context.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121737/#review72724
---


On Dec. 29, 2014, 5:51 p.m., Alex Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121737/
> ---
> 
> (Updated Dec. 29, 2014, 5:51 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> This should fix property() returning empty QVariants even if it
> existed in the .desktop file
> 
> 
> Diffs
> -
> 
>   src/services/kplugininfo.cpp aa5d26386eb17a7e552b29c8fa7961d68b16 
> 
> Diff: https://git.reviewboard.kde.org/r/121737/diff/
> 
> 
> Testing
> ---
> 
> KDED now correctly reads X-Kded-* in 
> https://git.reviewboard.kde.org/r/121315/ instead of reading the default 
> value.
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121737: KPluginInfo: Fix properties not being copied from KService::Ptr

2014-12-29 Thread Alex Richardson 


> On Dez. 29, 2014, 5:56 nachm., David Faure wrote:
> > propertyNames() includes the common stuff like Name, Comment, etc.
> > 
> > So maybe this removes the need for the code that follows? Or at least a 
> > good part of it?

Yeah we probably don't want those properties, do you think letting KPluginInfo 
access the QVariantMap in KServicePrivate is a better idea?

I.e. `json = QJsonObject::fromVariantMap(service->d->m_mapProps)`

That would be more efficient and skip all those standard .desktop properties.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121737/#review72724
---


On Dez. 29, 2014, 5:51 nachm., Alex Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121737/
> ---
> 
> (Updated Dez. 29, 2014, 5:51 nachm.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> This should fix property() returning empty QVariants even if it
> existed in the .desktop file
> 
> 
> Diffs
> -
> 
>   src/services/kplugininfo.cpp aa5d26386eb17a7e552b29c8fa7961d68b16 
> 
> Diff: https://git.reviewboard.kde.org/r/121737/diff/
> 
> 
> Testing
> ---
> 
> KDED now correctly reads X-Kded-* in 
> https://git.reviewboard.kde.org/r/121315/ instead of reading the default 
> value.
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121315: Allow using kded modules with JSON metadata

2014-12-29 Thread David Faure 


> On Dec. 20, 2014, 11:58 a.m., David Faure wrote:
> > Looks good to me overall (for the details, you're the expert ;)
> > 
> > Good example of how to port from KServiceTypeTrader to KPluginMetaData. Is 
> > that documented somewhere else BTW?
> > 
> > (Right now I would even need a solution for KMimeTypeTrader -> 
> > KPluginMetaData, but filtering by mimetype doesn't seem to be available?)
> 
> Alex Richardson wrote:
> Not quite sure how KMimeTypeTrader works, I will have to look into that.
> 
> I don't think it is documented anywhere. If you tell me what page I 
> should add it to I can write a little bit on the wiki.

KMimeTypeTrader adds "filtering on a mimetype" (including derived mimetypes), 
compared to what KServiceTypeTrader/KPluginMetaData do.

About where to document, I see two options:
1) https://community.kde.org/Frameworks/Porting_Notes
2) in the api docs for KPluginMetaData.

I guess both are needed. The first one written more like "how to port", while 
the second one should have sample code for "how to use" - even when not coming 
from KServiceTypeTrader.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121315/#review72335
---


On Dec. 29, 2014, 5:55 p.m., Alex Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121315/
> ---
> 
> (Updated Dec. 29, 2014, 5:55 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kded
> 
> 
> Description
> ---
> 
> The old .desktop based ones will still be loaded (with a debug message).
> 
> 
> Diffs
> -
> 
>   src/kded.cpp 40e549f6443d5cd2b26c5f9bad9695462a3467aa 
>   src/kded.h a91a94ce1e68032156eb070bdb1e722410d44b64 
> 
> Diff: https://git.reviewboard.kde.org/r/121315/diff/
> 
> 
> Testing
> ---
> 
> everything seems to work correctly.
> 
> No plugins are converted yet so they are all still loaded from .desktop files
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121737: KPluginInfo: Fix properties not being copied from KService::Ptr

2014-12-29 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121737/#review72724
---


propertyNames() includes the common stuff like Name, Comment, etc.

So maybe this removes the need for the code that follows? Or at least a good 
part of it?

- David Faure


On Dec. 29, 2014, 5:51 p.m., Alex Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121737/
> ---
> 
> (Updated Dec. 29, 2014, 5:51 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> This should fix property() returning empty QVariants even if it
> existed in the .desktop file
> 
> 
> Diffs
> -
> 
>   src/services/kplugininfo.cpp aa5d26386eb17a7e552b29c8fa7961d68b16 
> 
> Diff: https://git.reviewboard.kde.org/r/121737/diff/
> 
> 
> Testing
> ---
> 
> KDED now correctly reads X-Kded-* in 
> https://git.reviewboard.kde.org/r/121315/ instead of reading the default 
> value.
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121315: Allow using kded modules with JSON metadata

2014-12-29 Thread Alex Richardson 


> On Dez. 20, 2014, 11:58 vorm., David Faure wrote:
> > Looks good to me overall (for the details, you're the expert ;)
> > 
> > Good example of how to port from KServiceTypeTrader to KPluginMetaData. Is 
> > that documented somewhere else BTW?
> > 
> > (Right now I would even need a solution for KMimeTypeTrader -> 
> > KPluginMetaData, but filtering by mimetype doesn't seem to be available?)

Not quite sure how KMimeTypeTrader works, I will have to look into that.

I don't think it is documented anywhere. If you tell me what page I should add 
it to I can write a little bit on the wiki.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121315/#review72335
---


On Dez. 1, 2014, 4:29 nachm., Alex Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121315/
> ---
> 
> (Updated Dez. 1, 2014, 4:29 nachm.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kded
> 
> 
> Description
> ---
> 
> The old .desktop based ones will still be loaded (with a debug message).
> 
> 
> Diffs
> -
> 
>   src/kded.cpp 40e549f6443d5cd2b26c5f9bad9695462a3467aa 
>   src/kded.h a91a94ce1e68032156eb070bdb1e722410d44b64 
> 
> Diff: https://git.reviewboard.kde.org/r/121315/diff/
> 
> 
> Testing
> ---
> 
> everything seems to work correctly.
> 
> No plugins are converted yet so they are all still loaded from .desktop files
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121315: Allow using kded modules with JSON metadata

2014-12-29 Thread Alex Richardson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121315/
---

(Updated Dez. 29, 2014, 5:55 nachm.)


Review request for KDE Frameworks and David Faure.


Repository: kded


Description
---

The old .desktop based ones will still be loaded (with a debug message).


Diffs
-

  src/kded.cpp 40e549f6443d5cd2b26c5f9bad9695462a3467aa 
  src/kded.h a91a94ce1e68032156eb070bdb1e722410d44b64 

Diff: https://git.reviewboard.kde.org/r/121315/diff/


Testing
---

everything seems to work correctly.

No plugins are converted yet so they are all still loaded from .desktop files


Thanks,

Alex Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121737: KPluginInfo: Fix properties not being copied from KService::Ptr

2014-12-29 Thread Alex Richardson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121737/
---

Review request for KDE Frameworks and David Faure.


Repository: kservice


Description
---

This should fix property() returning empty QVariants even if it
existed in the .desktop file


Diffs
-

  src/services/kplugininfo.cpp aa5d26386eb17a7e552b29c8fa7961d68b16 

Diff: https://git.reviewboard.kde.org/r/121737/diff/


Testing
---

KDED now correctly reads X-Kded-* in https://git.reviewboard.kde.org/r/121315/ 
instead of reading the default value.


Thanks,

Alex Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Required and supported Qt versions

2014-12-29 Thread Jan Kundrát 

Hi,
is there a minimal required Qt version which applies to all of KF5? I see 
that most of the modules I currently have checked out say that they need 
5.2.0 while polkit-qt-1 declares itself compatible with 5.1.0.


- Is that information correct? Is 5.2.0 universally supported?
- Is there any value in having CI checks for this oldest supported version?
- Should the CI check other versions of Qt as well? Which ones?
- Would there be any value in testing e.g. libdep1 built against Qt 5.3.2 
with a project that uses libdep1 but is itself built with Qt 5.4?


Cheers,
Jan

--
Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: krunner_master_qt5 #114

2014-12-29 Thread KDE CI System 
See 

Changes:

[me] Do not detect anything with a '.' as a NetworkLocation

[me] Fix unused variables warnings

[me] RunnerManager: Remove unused variable loadAll

[me] QueryMatchPrivate: Rename local variable

--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[krunner_master_qt5] $ /bin/sh -xe /tmp/hudson6257899364796523464.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

>From git://anongit.kde.org/krunner
   42328f5..c84f0cd  master -> origin/master
 * [new tag] v5.5.0 -> v5.5.0
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at 42328f5 SVN_SILENT made messages (.desktop file)
Removing build/
Removing dotdata/
Removing local-inst/
Success build forhudson.tasks.Shell@2d86eed9
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/krunner # timeout=10
Fetching upstream changes from git://anongit.kde.org/krunner
 > git --version # timeout=10
 > git fetch --tags --progress git://anongit.kde.org/krunner 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
 > git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision c84f0cd42fc740f06e7131ff5a7a6f49bc4186e8 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f c84f0cd42fc740f06e7131ff5a7a6f49bc4186e8
 > git rev-list 7f6c888c25cabfdaed37713f6cf33861f261821e # timeout=10
 > git tag -a -f -m Jenkins Build #114 jenkins-krunner_master_qt5-114 # 
 > timeout=10
Run condition [File exists] enabling prebuild for step [Publish JUnit test 
result report]
Run condition [File exists] enabling prebuild for step [Publish Cppcheck 
results]
[krunner_master_qt5] $ /bin/sh -xe /tmp/hudson8425782566707970235.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: krunner - Branch master
== Build Dependencies:
 kcodecs - Branch master
 kbookmarks - Branch master
 kross - Branch master
 kglobalaccel - Branch master
 polkit-qt-1 - Branch master
 ki18n - Branch master
 kjobwidgets - Branch master
 plasma-framework - Branch master
 kservice - Branch master
 dogtail - Branch master
 ktexteditor - Branch master
 kpackage - Branch master
 kparts - Branch master
 kiconthemes - Branch master
 qt5 - Branch 5.3.2
 cmake - Branch master
 kguiaddons - Branch master
 kconfig - Branch master
 kxmlgui - Branch master
 attica - Branch master
 kcoreaddons - Branch master
 kio - Branch master
 kunitconversion - Branch master
 kcompletion - Branch master
 ktextwidgets - Branch master
 libgit2 - Branch master
 kidletime - Branch master
 extra-cmake-modules - Branch master
 kdoctools - Branch master
 kitemviews - Branch master
 knotifications - Branch master
 threadweaver - Branch master
 kwallet - Branch master
 kwidgetsaddons - Branch master
 kactivities - Branch master
 kcmutils - Branch master
 kwindowsystem - Branch master
 kcrash - Branch master
 kjs - Branch master
 solid - Branch master
 sonnet - Branch master
 kauth - Branch master
 phonon - Branch master
 kdnssd - Branch master
 kconfigwidgets - Branch master
 kdeclarative - Branch master
 kdbusaddons - Branch master
 karchive - Branch master
 kitemmodels - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for __GLIBC__
-- Looking for __GLIBC__ - found
-- Performing Test _OFFT_IS_64BIT
-- Performing Test _OFFT_IS_64BIT - Success
-- Found Gettext: /usr/bin/msgmerge (found version "0.18.1") 
-- Found PythonInterp: /usr/bin/python (found version "2.7.3") 
CMake Error at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/kdesupport

Re: OSX/CI: QSP patch ( was "KF5 Update Meeting Minutes 2014-w28" )

2014-12-29 Thread René JV Bertin 
Hi

Interesting. Would you mind giving some context, arguments behind choices and 
things like that?

Also, do I understand correctly that you set Oxygen as the default style? Does 
it work correctly on Ms Windows?

On 28 Dec 2014, at 01:24, Andrius da Costa Ribas  wrote:

> In our Windows Emerge scripts QStandardPaths is already being patched for a 
> while:
> 
> http://quickgit.kde.org/?p=emerge.git&a=blob&h=e716bf675669139059a96db6be76cc3470487d64&hb=b64cc189fa1918894653f185068e1786b31bd02e&f=portage%2Flibs%2Fqt5%2Fqtbase%2Fqtbase-20130714.patch
> 
> 
> 
> 2014-12-15 19:12 GMT-02:00 Marko Käning :
>> Hi David,
>> 
>> back to our discussion during this summer:
>> 
>> On 10 Jul 2014, at 11:57 , David Faure  wrote:
>> > Wrong approach. XDG is a freedesktop thing which doesn't apply to Mac.
>> >
>> > This should be fixed the other way around:
>> > 1) finding out how Mac OS lets people configure the location for their 
>> > files,
>> > or if this isn't configurable, coming up with QT_* environment variables.
>> > 2) patching QStandardPaths to use these
>> > 3) setting these vars in the CT scripts
>> 
>> 
>> Since a fortnight we’re discussing the QStandardPaths patch needed for the 
>> OSX/CI
>> system [0] on KDE-MAC [1,2] and it would be good if you’d join this 
>> discussion now,
>> as Ben also wants to come up with a patch for Windows very soon.
>> (Ian actually had already included you in his last post [3] to thread [1].)
>> 
>> Can we have this discussion on KDE-MAC (or on both lists), as Ian and René 
>> aren’t
>> subscribed to K-F-D?!
>> 
>> Regards,
>> Marko
>> 
>> 
>> 
>> 
>> [0] 
>> http://quickgit.kde.org/?p=clones%2Fwebsites%2Fbuild-kde-org%2Fkaning%2Fmp-osx-ci.git&a=blob&h=27deb1cb8f8f70ea949fc241e049d9b47a10f6df&hb=8126ab8cb976f42a4ebe5d3b7d2cb7a3d42217d1&f=patches%2Fqt5%2Fkf5-qt5%2Fpatch-qstandardpaths_mac.cpp.diff
>> 
>> [1] http://mail.kde.org/pipermail/kde-mac/2014-December/002590.html
>> 
>> [2] http://mail.kde.org/pipermail/kde-mac/2014-December/002705.html
>> 
>> [3] http://mail.kde.org/pipermail/kde-mac/2014-December/002737.html
>> ___
>> Kde-frameworks-devel mailing list
>> Kde-frameworks-devel@kde.org
>> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
> 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121618: Better name for kdoctools translation domain

2014-12-29 Thread Luigi Toscano 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121618/
---

(Updated Dec. 29, 2014, 2:32 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Localization and Translation (l10n) and 
David Faure.


Repository: kdoctools


Description
---

The current name for kdoctools translation domain is an historical leftover 
from the split (code shared mostly with kio_help, now in a totally different 
repository), so better use a more descriptive name.

I will take care of renaming the existing translation files.


Diffs
-

  CMakeLists.txt 357148b 
  src/Messages.sh c63c180 

Diff: https://git.reviewboard.kde.org/r/121618/diff/


Testing
---


Thanks,

Luigi Toscano

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : plasma-framework_master_qt5 » All,LINBUILDER #933

2014-12-29 Thread KDE CI System 
See 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_stable_qt5 » NoX11,LINBUILDER #44

2014-12-29 Thread KDE CI System 
See 


Changes:

[kde] Set visibility on mainItem to match Dialog

--
Started by upstream project "plasma-framework_stable_qt5" build number 44
originally caused by:
 Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[LINBUILDER] $ /bin/sh -xe /tmp/hudson244230218232845669.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

>From git://anongit.kde.org/plasma-framework
   185bd45..c6b7186  mart/KPackage -> origin/mart/KPackage
   53d6940..0f5e9b1  master -> origin/master
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at 53d6940 SVN_SILENT made messages (.desktop file)
Success build forhudson.tasks.Shell@70a60377
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/plasma-framework.git # 
 > timeout=10
Fetching upstream changes from git://anongit.kde.org/plasma-framework.git
 > git --version # timeout=10
 > git fetch --tags --progress git://anongit.kde.org/plasma-framework.git 
 > +refs/heads/*:refs/remotes/origin/*
Checking out Revision 0f5e9b1a5d826253cf2afa1532b55c30055569df 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 0f5e9b1a5d826253cf2afa1532b55c30055569df
 > git rev-list dd866b427e49aafb8a07931c7fed6a48c9021766 # timeout=10
[LINBUILDER] $ /bin/sh -xe /tmp/hudson3486106794637771157.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-framework - Branch master
== Build Dependencies:
 kcodecs - Branch master
 kross - Branch master
 kglobalaccel - Branch master
 ki18n - Branch master
 cmake - Branch master
 kitemviews - Branch master
 phonon - Branch master
 kservice - Branch master
 kdeclarative - Branch master
 polkit-qt-1 - Branch master
 kguiaddons - Branch master
 ktexteditor - Branch master
 kwidgetsaddons - Branch master
 karchive - Branch master
 solid - Branch master
 kiconthemes - Branch master
 qt5 - Branch stable
 kwallet - Branch master
 dogtail - Branch master
 kconfig - Branch master
 attica - Branch master
 kcoreaddons - Branch master
 kdnssd - Branch master
 kunitconversion - Branch master
 kcompletion - Branch master
 ktextwidgets - Branch master
 kidletime - Branch master
 kbookmarks - Branch master
 kcrash - Branch master
 kdoctools - Branch master
 extra-cmake-modules - Branch master
 knotifications - Branch master
 threadweaver - Branch master
 kauth - Branch master
 kxmlgui - Branch master
 kcmutils - Branch master
 kwindowsystem - Branch master
 kjs - Branch master
 kjobwidgets - Branch master
 sonnet - Branch master
 kparts - Branch master
 kio - Branch master
 kconfigwidgets - Branch master
 kactivities - Branch master
 kdbusaddons - Branch master
 libgit2 - Branch master
 kitemmodels - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for __GLIBC__
-- Looking for __GLIBC__ - found
-- Performing Test _OFFT_IS_64BIT
-- Performing Test _OFFT_IS_64BIT - Success
-- Found Gettext: /usr/bin/msgmerge (found version "0.18.1") 
-- Found PythonInterp: /usr/bin/python (found version "2.7.3") 
CMake Error at CMakeLists.txt:62 (find_package):
  By not providing "FindKF5Package.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "KF5Package", but CMake did not find one.

  Could not find a package configuration file provided by "KF5Package"
  (requested version 5.5.0) with any of the following names:

KF5PackageConfig.cmake
kf5package-config.cmake

  Add the installation prefix of "KF5Package" to CMAKE_PREFIX_PATH or set
  "KF5Package_DIR" to a directory containing one of the above

Build failed in Jenkins: plasma-framework_stable_qt5 » All,LINBUILDER #44

2014-12-29 Thread KDE CI System 
See 


Changes:

[kde] Set visibility on mainItem to match Dialog

--
Started by upstream project "plasma-framework_stable_qt5" build number 44
originally caused by:
 Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[LINBUILDER] $ /bin/sh -xe /tmp/hudson3807626331553875510.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

>From git://anongit.kde.org/plasma-framework
   dd866b4..0f5e9b1  master -> origin/master
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at dd866b4 Merge "migrate to KPackage"
Removing build/
Success build forhudson.tasks.Shell@70a60377
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/plasma-framework.git # 
 > timeout=10
Fetching upstream changes from git://anongit.kde.org/plasma-framework.git
 > git --version # timeout=10
 > git fetch --tags --progress git://anongit.kde.org/plasma-framework.git 
 > +refs/heads/*:refs/remotes/origin/*
Checking out Revision 0f5e9b1a5d826253cf2afa1532b55c30055569df 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 0f5e9b1a5d826253cf2afa1532b55c30055569df
 > git rev-list dd866b427e49aafb8a07931c7fed6a48c9021766 # timeout=10
[LINBUILDER] $ /bin/sh -xe /tmp/hudson9078225691270619797.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-framework - Branch master
== Build Dependencies:
 kwidgetsaddons - Branch master
 kcodecs - Branch master
 kbookmarks - Branch master
 kross - Branch master
 kcoreaddons - Branch master
 ki18n - Branch master
 kjobwidgets - Branch master
 kservice - Branch master
 kguiaddons - Branch master
 libgit2 - Branch master
 ktexteditor - Branch master
 karchive - Branch master
 cmake - Branch master
 kiconthemes - Branch master
 qt5 - Branch stable
 kwallet - Branch master
 dogtail - Branch master
 kconfig - Branch master
 attica - Branch master
 kglobalaccel - Branch master
 kdnssd - Branch master
 kparts - Branch master
 kunitconversion - Branch master
 extra-cmake-modules - Branch master
 kcompletion - Branch master
 ktextwidgets - Branch master
 phonon - Branch master
 kidletime - Branch master
 polkit-qt-1 - Branch master
 kcrash - Branch master
 kdoctools - Branch master
 kitemviews - Branch master
 knotifications - Branch master
 threadweaver - Branch master
 kauth - Branch master
 solid - Branch master
 kwindowsystem - Branch master
 kjs - Branch master
 kcmutils - Branch master
 sonnet - Branch master
 kactivities - Branch master
 kxmlgui - Branch master
 kio - Branch master
 kconfigwidgets - Branch master
 kdbusaddons - Branch master
 kdeclarative - Branch master
 kitemmodels - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for __GLIBC__
-- Looking for __GLIBC__ - found
-- Performing Test _OFFT_IS_64BIT
-- Performing Test _OFFT_IS_64BIT - Success
-- Found Gettext: /usr/bin/msgmerge (found version "0.18.1") 
-- Found PythonInterp: /usr/bin/python (found version "2.7.3") 
CMake Error at CMakeLists.txt:62 (find_package):
  By not providing "FindKF5Package.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "KF5Package", but CMake did not find one.

  Could not find a package configuration file provided by "KF5Package"
  (requested version 5.5.0) with any of the following names:

KF5PackageConfig.cmake
kf5package-config.cmake

  Add the installation prefix of "KF5Package" to CMAKE_PREFIX_PATH or set
  "KF5Package_DIR" to a directory containing one of the above files.  If
  "KF5Package" provides a separate development p

Jenkins build became unstable: plasma-framework_master_qt5 » All,LINBUILDER #932

2014-12-29 Thread KDE CI System 
See 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_stable_qt5 » NoX11,LINBUILDER #43

2014-12-29 Thread KDE CI System 
See 


Changes:

[notmart] migrate to KPackage

--
Started by upstream project "plasma-framework_stable_qt5" build number 43
originally caused by:
 Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[LINBUILDER] $ /bin/sh -xe /tmp/hudson9169377588241416175.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

>From git://anongit.kde.org/plasma-framework
   b4e1fd5..dd866b4  master -> origin/master
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at b4e1fd5 Keep the event filter around so get notified of font 
changes at runtime
Removing build/
Removing dotdata/
Removing local-inst/
Success build forhudson.tasks.Shell@70a60377
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/plasma-framework.git # 
 > timeout=10
Fetching upstream changes from git://anongit.kde.org/plasma-framework.git
 > git --version # timeout=10
 > git fetch --tags --progress git://anongit.kde.org/plasma-framework.git 
 > +refs/heads/*:refs/remotes/origin/*
Checking out Revision dd866b427e49aafb8a07931c7fed6a48c9021766 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f dd866b427e49aafb8a07931c7fed6a48c9021766
 > git rev-list b4e1fd5f1ca389e17e0b5b771938eb59fb60535b # timeout=10
[LINBUILDER] $ /bin/sh -xe /tmp/hudson9120430104091688964.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-framework - Branch master
== Build Dependencies:
 kcodecs - Branch master
 kross - Branch master
 kglobalaccel - Branch master
 ki18n - Branch master
 kjobwidgets - Branch master
 phonon - Branch master
 kservice - Branch master
 polkit-qt-1 - Branch master
 kguiaddons - Branch master
 kitemviews - Branch master
 ktexteditor - Branch master
 karchive - Branch master
 kdeclarative - Branch master
 kiconthemes - Branch master
 qt5 - Branch stable
 cmake - Branch master
 dogtail - Branch master
 kconfig - Branch master
 attica - Branch master
 kcoreaddons - Branch master
 kio - Branch master
 kunitconversion - Branch master
 kcompletion - Branch master
 ktextwidgets - Branch master
 kxmlgui - Branch master
 kidletime - Branch master
 kactivities - Branch master
 kwidgetsaddons - Branch master
 kparts - Branch master
 kdoctools - Branch master
 extra-cmake-modules - Branch master
 knotifications - Branch master
 threadweaver - Branch master
 kauth - Branch master
 kbookmarks - Branch master
 kcmutils - Branch master
 kwindowsystem - Branch master
 kjs - Branch master
 sonnet - Branch master
 solid - Branch master
 kdnssd - Branch master
 kconfigwidgets - Branch master
 kcrash - Branch master
 libgit2 - Branch master
 kdbusaddons - Branch master
 kwallet - Branch master
 kitemmodels - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for __GLIBC__
-- Looking for __GLIBC__ - found
-- Performing Test _OFFT_IS_64BIT
-- Performing Test _OFFT_IS_64BIT - Success
-- Found Gettext: /usr/bin/msgmerge (found version "0.18.1") 
-- Found PythonInterp: /usr/bin/python (found version "2.7.3") 
CMake Error at CMakeLists.txt:62 (find_package):
  By not providing "FindKF5Package.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "KF5Package", but CMake did not find one.

  Could not find a package configuration file provided by "KF5Package"
  (requested version 5.5.0) with any of the following names:

KF5PackageConfig.cmake
kf5package-config.cmake

  Add the installation prefix of "KF5Package" to CMAKE_PREFIX_PATH or set
  "KF5Package_DIR" to a directory containing one of

Build failed in Jenkins: plasma-framework_stable_qt5 » All,LINBUILDER #43

2014-12-29 Thread KDE CI System 
See 


Changes:

[notmart] migrate to KPackage

--
Started by upstream project "plasma-framework_stable_qt5" build number 43
originally caused by:
 Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[LINBUILDER] $ /bin/sh -xe /tmp/hudson7965632923761303978.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

>From git://anongit.kde.org/plasma-framework
   b4e1fd5..dd866b4  master -> origin/master
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at b4e1fd5 Keep the event filter around so get notified of font 
changes at runtime
Removing build/
Removing dotdata/
Removing local-inst/
Success build forhudson.tasks.Shell@70a60377
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/plasma-framework.git # 
 > timeout=10
Fetching upstream changes from git://anongit.kde.org/plasma-framework.git
 > git --version # timeout=10
 > git fetch --tags --progress git://anongit.kde.org/plasma-framework.git 
 > +refs/heads/*:refs/remotes/origin/*
Checking out Revision dd866b427e49aafb8a07931c7fed6a48c9021766 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f dd866b427e49aafb8a07931c7fed6a48c9021766
 > git rev-list b4e1fd5f1ca389e17e0b5b771938eb59fb60535b # timeout=10
[LINBUILDER] $ /bin/sh -xe /tmp/hudson621821964529620.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-framework - Branch master
== Build Dependencies:
 kcodecs - Branch master
 kross - Branch master
 kglobalaccel - Branch master
 ki18n - Branch master
 libgit2 - Branch master
 kjobwidgets - Branch master
 kservice - Branch master
 kguiaddons - Branch master
 ktexteditor - Branch master
 karchive - Branch master
 kparts - Branch master
 kiconthemes - Branch master
 qt5 - Branch stable
 cmake - Branch master
 dogtail - Branch master
 kconfig - Branch master
 attica - Branch master
 kcoreaddons - Branch master
 kdnssd - Branch master
 kxmlgui - Branch master
 kunitconversion - Branch master
 kcompletion - Branch master
 ktextwidgets - Branch master
 kidletime - Branch master
 extra-cmake-modules - Branch master
 kdoctools - Branch master
 kitemviews - Branch master
 knotifications - Branch master
 threadweaver - Branch master
 kwallet - Branch master
 kwidgetsaddons - Branch master
 kactivities - Branch master
 kcmutils - Branch master
 kwindowsystem - Branch master
 kjs - Branch master
 kdeclarative - Branch master
 sonnet - Branch master
 kcrash - Branch master
 solid - Branch master
 kio - Branch master
 kconfigwidgets - Branch master
 kbookmarks - Branch master
 phonon - Branch master
 kdbusaddons - Branch master
 polkit-qt-1 - Branch master
 kauth - Branch master
 kitemmodels - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for __GLIBC__
-- Looking for __GLIBC__ - found
-- Performing Test _OFFT_IS_64BIT
-- Performing Test _OFFT_IS_64BIT - Success
-- Found Gettext: /usr/bin/msgmerge (found version "0.18.1") 
-- Found PythonInterp: /usr/bin/python (found version "2.7.3") 
CMake Error at CMakeLists.txt:62 (find_package):
  By not providing "FindKF5Package.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "KF5Package", but CMake did not find one.

  Could not find a package configuration file provided by "KF5Package"
  (requested version 5.5.0) with any of the following names:

KF5PackageConfig.cmake
kf5package-config.cmake

  Add the installation prefix of "KF5Package" to CMAKE_PREFIX_PATH or set
  "KF5Package_DIR" to a directory containing one of the

Re: Review Request 120388: Do not sync if wallet file does not exist

2014-12-29 Thread Arjun AK 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120388/
---

(Updated Dec. 29, 2014, 6:47 p.m.)


Review request for KDE Frameworks, Àlex Fiestas, Teo Mrnjavac, and Valentin 
Rusu.


Changes
---

1. Use static method QFile::Exists
2. When a wallet file is removed from kwalletd5 directory, remove corresponding 
entry from `_wallet`. This not only fixes the memory leak but also ensures that 
sync() doesn't get called in the first place.


Repository: kwallet


Description
---

1. Create a new wallet "foo"
2. immediately remove the 'kwalletd5' directory
3. `KWalletD::timedOutSync()` will call sync on a nonexistant wallet (which 
will create "foo.kwl")

Kwalletmanager still lists the wallet and new data can be added to the wallet, 
but this data will be lost once the wallet is closed since the salt has been 
deleted and therefore the wallet cannot be opened again.


Diffs (updated)
-

  src/runtime/kwalletd/backend/kwalletbackend.cc b072cec 
  src/runtime/kwalletd/kwalletd.h b94df15 
  src/runtime/kwalletd/kwalletd.cpp 882eb72 

Diff: https://git.reviewboard.kde.org/r/120388/diff/


Testing
---


Thanks,

Arjun AK

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120388: Do not sync if wallet file does not exist

2014-12-29 Thread Arjun AK 


> On Dec. 29, 2014, 3:58 a.m., David Faure wrote:
> > low-level review: no need to create a QFile, use QFile::exists(path)
> > 
> > higher-level review: ensuring that a file exists before calling KSaveFile, 
> > which *creates* the file, sounds weird. I mean, isn't this exactly what 
> > will happen the very first time a wallet is created? (disclaimer - I don't 
> > know this code so I'm probably missing context).

>low-level review: no need to create a QFile, use QFile::exists(path)

Ok

>higher-level review: ensuring that a file exists before calling KSaveFile, 
>which creates the file, sounds weird. I mean, isn't this exactly what will 
>happen the very first time a wallet is created? (disclaimer - I don't know 
>this code so I'm probably missing context).

If we delete the kwallet directory we would loose both the kwl as well as salt 
files. Now if we were to call sync, kwl file gets written to disk and user can 
continue to add data to the wallet untill he closes it, after which he no 
longer would be able to access it since he doesn't have the salt file with him. 
Any data that was added to the wallet in the meantime would be lost forever.


- Arjun


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120388/#review72634
---


On Dec. 11, 2014, 7:46 a.m., Arjun AK wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120388/
> ---
> 
> (Updated Dec. 11, 2014, 7:46 a.m.)
> 
> 
> Review request for KDE Frameworks, Àlex Fiestas, Teo Mrnjavac, and Valentin 
> Rusu.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> 1. Create a new wallet "foo"
> 2. immediately remove the 'kwalletd5' directory
> 3. `KWalletD::timedOutSync()` will call sync on a nonexistant wallet (which 
> will create "foo.kwl")
> 
> Kwalletmanager still lists the wallet and new data can be added to the 
> wallet, but this data will be lost once the wallet is closed since the salt 
> has been deleted and therefore the wallet cannot be opened again.
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/backend/kwalletbackend.cc b072cec 
> 
> Diff: https://git.reviewboard.kde.org/r/120388/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121581: Plotter in kdeclarative

2014-12-29 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121581/
---

(Updated Dec. 29, 2014, 12:17 p.m.)


Review request for KDE Frameworks and Plasma.


Repository: kdeclarative


Description
---

This is an alternative, mutually exclusive to
https://gerrit.vesnicky.cesnet.cz/r/#/c/244
and dependent from
https://git.reviewboard.kde.org/r/121575/

since the plotter component doesn't depend from libplasma, it may be useful to 
have it outside of libplasma, so any applciation that wants it may use it.
Any opinion whether this should go here or in libplasma is welcome.


Diffs (updated)
-

  src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp 0e2eb2f 
  src/qmlcontrols/kquickcontrolsaddons/plotter.h PRE-CREATION 
  src/qmlcontrols/kquickcontrolsaddons/plotter.cpp PRE-CREATION 
  CMakeLists.txt 233ccce 
  cmake/Findepoxy.cmake PRE-CREATION 
  src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 786aaa5 

Diff: https://git.reviewboard.kde.org/r/121581/diff/


Testing
---


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[kapidox] src: Workaround broken metadata in the NetworkManager-Qt Framework which broke all Frameworks API generation on api.kde.org.

2014-12-29 Thread Ben Cooksley 
Git commit 6843f218411db3dba8d5fb53a578564dcb67d50e by Ben Cooksley.
Committed on 29/12/2014 at 10:10.
Pushed by bcooksley into branch 'master'.

Workaround broken metadata in the NetworkManager-Qt Framework which broke all 
Frameworks API generation on api.kde.org.
CCMAIL: release-t...@kde.org
CCMAIL: kde-frameworks-devel@kde.org
CCMAIL: jgrul...@redhat.com
CCMAIL: lamar...@kde.org
CCMAIL: lti...@redhat.com
CCMAIL: christ...@maxiom.de

M  +3-0src/kgenframeworksapidox

http://commits.kde.org/kapidox/6843f218411db3dba8d5fb53a578564dcb67d50e

diff --git a/src/kgenframeworksapidox b/src/kgenframeworksapidox
index 4b2d36f..7a0e237 100755
--- a/src/kgenframeworksapidox
+++ b/src/kgenframeworksapidox
@@ -107,6 +107,9 @@ def process_toplevel_html_file(outputfile, doxdatadir, 
tiers, title,
 logging.warning('{} framework lacks platform 
definitions'.format(fw['fancyname']))
 fw['platforms'] = [dict(name=PLATFORM_UNKNOWN)]
 
+# In case the metadata is bad, we don't want to die so clean it up 
first
+fw['platforms'] = [x for x in fw['platforms'] if 'name' in x]
+
 platform_lst = [x['name'] for x in fw['platforms'] if x['name'] 
not in (PLATFORM_ALL, PLATFORM_UNKNOWN)]
 available_platforms.update(set(platform_lst))
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121712: Add install target for the KF5 Book

2014-12-29 Thread Sune Vuorela 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121712/#review72687
---


looks right to me

- Sune Vuorela


On Dec. 28, 2014, 11:58 p.m., Andreas Cord-Landwehr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121712/
> ---
> 
> (Updated Dec. 28, 2014, 11:58 p.m.)
> 
> 
> Review request for KDE Frameworks, Rohan Garg, Mirko Boehm, and Valorie 
> Zimmerman.
> 
> 
> Repository: kf5book
> 
> 
> Description
> ---
> 
> Install the book to /usr/share/doc/frameworks5
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 4e10120 
> 
> Diff: https://git.reviewboard.kde.org/r/121712/diff/
> 
> 
> Testing
> ---
> 
> manual testing
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel