Re: OSX/CI: kde-baseapps fails to build for branch-group stable-kf5-qt5
OK, I understood only now, that kde-baseapps [1] and likely also the other two projects are KDE4-only. There is no EMPTY entry for “stable-kd5-qt5” branch group for these three projects in our logical dependencies, which should be the reason for this. Should I add those? (I suspect also that I’ll stumble over more than these 3…) P.S.: Just now I ran into ark and pairs failing as well! ;-) ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: OSX/CI: kde-baseapps fails to build for branch-group stable-kf5-qt5
On Fri, Feb 13, 2015 at 9:52 PM, Kevin Funk kf...@kde.org wrote: On Friday 13 February 2015 08:49:10 Marko Käning wrote: Hi Albert, I just realised that kde-baseapps fails on OSX/CI when being build for branch group stable-kf5-qt5: -- Group: stable-kf5-qt5 Project : kde/applications/kde-baseapps Branch : Applications/14.12 Linux-CI : UNSTABLE OSX/CI : FAILURE Prep... Build... : BUILD FAILED == This I find in the build log: --- -- The C compiler identification is AppleClang 6.0.0.656 -- The CXX compiler identification is AppleClang 6.0.0.656 -- Check for working C compiler: /usr/bin/cc -- Check for working C compiler: /usr/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /usr/bin/c++ -- Check for working CXX compiler: /usr/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done CMake Error at /opt/kde/install/darwin/mavericks/clang/shared/general/cmake/share/cmake-3. 1/Modules/FindKDE4.cmake:71 (message): ERROR: Could not find KDE4 kde4-config Call Stack (most recent call first): CMakeLists.txt:10 (find_package) You're quite obviously on the wrong branch in kde-baseapps.git. You're probably on master (KDE4-based), while you should be on frameworks (KF5-based). This means the build metadata for kde-baseapps is incorrect. It is the responsibility of developers to maintain this metadata, as those who maintain kdesrc-build, the CI system and make releases cannot be expected to do so with the number of repositories and projects we have. CMake Warning (dev) in CMakeLists.txt: No cmake_minimum_required command is present. A line of code such as cmake_minimum_required(VERSION 3.1) should be added at the top of the file. The version specified may be lower if you wish to support older CMake versions for this project. For more information run cmake --help-policy CMP. This warning is for project developers. Use -Wno-dev to suppress it. -- Configuring incomplete, errors occurred! See also /Users/marko/WC/KDECI-builds/stable-kf5-qt5/kde-baseapps/build/CMakeFiles/ CMakeOutput.log. KDE Continuous Integration Build == Building Project: kde-baseapps - Branch Applications/14.12 --- Any idea what goes wrong? Regards, Marko ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel -- Kevin Funk | kf...@kde.org | http://kfunk.org ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel Regards, Ben ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: OSX/CI: kde-baseapps fails to build for branch-group stable-kf5-qt5
On Fri, Feb 13, 2015 at 10:15 PM, Kevin Funk kf...@kde.org wrote:
On Friday 13 February 2015 21:56:42 Ben Cooksley wrote:
On Fri, Feb 13, 2015 at 9:52 PM, Kevin Funk kf...@kde.org wrote:
On Friday 13 February 2015 08:49:10 Marko Käning wrote:
Hi Albert,
I just realised that kde-baseapps fails on OSX/CI when being build for
branch group stable-kf5-qt5:
--
Group: stable-kf5-qt5
Project : kde/applications/kde-baseapps
Branch : Applications/14.12
Linux-CI : UNSTABLE
OSX/CI : FAILURE
Prep...
Build... : BUILD FAILED
==
This I find in the build log:
---
-- The C compiler identification is AppleClang 6.0.0.656
-- The CXX compiler identification is AppleClang 6.0.0.656
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
CMake Error at
/opt/kde/install/darwin/mavericks/clang/shared/general/cmake/share/cmake-
3.
1/Modules/FindKDE4.cmake:71 (message): ERROR: Could not find KDE4
kde4-config
Call Stack (most recent call first):
CMakeLists.txt:10 (find_package)
You're quite obviously on the wrong branch in kde-baseapps.git.
You're probably on master (KDE4-based), while you should be on frameworks
(KF5-based).
This means the build metadata for kde-baseapps is incorrect.
It is the responsibility of developers to maintain this metadata, as
those who maintain kdesrc-build, the CI system and make releases
cannot be expected to do so with the number of repositories and
projects we have.
Sorry, I've been a bit scarce about information here.
Indeed, the kde/* rule in 'logical-module-structure' is wrong already:
kde/* : {
stable-qt4: Applications/14.12,
latest-qt4: master,
kf5-qt5: frameworks,
stable-kf5-qt5: Applications/14.12
},
Both stable-qt4 and stable-kf5-qt5 point Applications/14.12 -- which is not
what we want. Can someone fix? (short in time atm)
I've now fixed that.
Regards
Cheers,
Ben
CMake Warning (dev) in CMakeLists.txt:
No cmake_minimum_required command is present. A line of code such as
cmake_minimum_required(VERSION 3.1)
should be added at the top of the file. The version specified may be
lower if you wish to support older CMake versions for this project. For
more information run cmake --help-policy CMP.
This warning is for project developers. Use -Wno-dev to suppress it.
-- Configuring incomplete, errors occurred!
See also
/Users/marko/WC/KDECI-builds/stable-kf5-qt5/kde-baseapps/build/CMakeFile
s/
CMakeOutput.log.
KDE Continuous Integration Build
== Building Project: kde-baseapps - Branch Applications/14.12
---
Any idea what goes wrong?
Regards,
Marko
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
--
Kevin Funk | kf...@kde.org | http://kfunk.org
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Regards,
Ben
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
--
Kevin Funk | kf...@kde.org | http://kfunk.org
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: New framework: KXmlRpcClient
On Thu, Feb 12, 2015 at 8:25 PM, Albert Astals Cid aa...@kde.org wrote: El Dijous, 12 de febrer de 2015, a les 12:31:14, Daniel Vrátil va escriure: On Friday, January 30, 2015 09:12:01 AM David Faure wrote: On Wednesday 28 January 2015 17:12:04 Daniel Vrátil wrote: I guess I should update kde-build-metadata and release-tools and ask for the _stable_qt5 build once the repo is moved to frameworks on projects.k.o, so that changes don't have to be done twice (I don't really know if build.k.o has to be updated when module moves...?). No, build.kde.org uses a git url, so it doesn't matter where the module is logically placed on projects.kde.org. But yes, for kde-build-metadata it matters. (there is nothing to update in release-tools, just set release to true in your yaml file) KXmlRpcClient has been moved to frameworks. I enabled the release flag, adjusted kde-build-metadata, created bugzilla entry, so we should be good to go. Can someone tell the distro packagers list they'll have a duplciation issue when using frameworks 5.8 + Plasma 5.2? if the translation catalog gets renamed there is no conflict. currently it is libkxmlrpcclient5.pot, so simply aligning that with the actual library name would neatly solve this. in workspace xmlrpc was handled as a private lib (filename had a private suffix, no cmake config installed, no headers installed etc.) so tother than translations here should be no problems mixing kf5.8 with plasma5.2. HS ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: OSX/CI: kde-baseapps fails to build for branch-group stable-kf5-qt5
On Friday 13 February 2015 21:56:42 Ben Cooksley wrote:
On Fri, Feb 13, 2015 at 9:52 PM, Kevin Funk kf...@kde.org wrote:
On Friday 13 February 2015 08:49:10 Marko Käning wrote:
Hi Albert,
I just realised that kde-baseapps fails on OSX/CI when being build for
branch group stable-kf5-qt5:
--
Group: stable-kf5-qt5
Project : kde/applications/kde-baseapps
Branch : Applications/14.12
Linux-CI : UNSTABLE
OSX/CI : FAILURE
Prep...
Build... : BUILD FAILED
==
This I find in the build log:
---
-- The C compiler identification is AppleClang 6.0.0.656
-- The CXX compiler identification is AppleClang 6.0.0.656
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
CMake Error at
/opt/kde/install/darwin/mavericks/clang/shared/general/cmake/share/cmake-
3.
1/Modules/FindKDE4.cmake:71 (message): ERROR: Could not find KDE4
kde4-config
Call Stack (most recent call first):
CMakeLists.txt:10 (find_package)
You're quite obviously on the wrong branch in kde-baseapps.git.
You're probably on master (KDE4-based), while you should be on frameworks
(KF5-based).
This means the build metadata for kde-baseapps is incorrect.
It is the responsibility of developers to maintain this metadata, as
those who maintain kdesrc-build, the CI system and make releases
cannot be expected to do so with the number of repositories and
projects we have.
Sorry, I've been a bit scarce about information here.
Indeed, the kde/* rule in 'logical-module-structure' is wrong already:
kde/* : {
stable-qt4: Applications/14.12,
latest-qt4: master,
kf5-qt5: frameworks,
stable-kf5-qt5: Applications/14.12
},
Both stable-qt4 and stable-kf5-qt5 point Applications/14.12 -- which is not
what we want. Can someone fix? (short in time atm)
Regards
CMake Warning (dev) in CMakeLists.txt:
No cmake_minimum_required command is present. A line of code such as
cmake_minimum_required(VERSION 3.1)
should be added at the top of the file. The version specified may be
lower if you wish to support older CMake versions for this project. For
more information run cmake --help-policy CMP.
This warning is for project developers. Use -Wno-dev to suppress it.
-- Configuring incomplete, errors occurred!
See also
/Users/marko/WC/KDECI-builds/stable-kf5-qt5/kde-baseapps/build/CMakeFile
s/
CMakeOutput.log.
KDE Continuous Integration Build
== Building Project: kde-baseapps - Branch Applications/14.12
---
Any idea what goes wrong?
Regards,
Marko
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
--
Kevin Funk | kf...@kde.org | http://kfunk.org
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Regards,
Ben
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
--
Kevin Funk | kf...@kde.org | http://kfunk.org
signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: New framework: KXmlRpcClient
On Fri, Feb 13, 2015 at 10:34 AM, Harald Sitter sit...@kde.org wrote: Can someone tell the distro packagers list they'll have a duplciation issue when using frameworks 5.8 + Plasma 5.2? if the translation catalog gets renamed there is no conflict. currently it is libkxmlrpcclient5.pot, so simply aligning that with the actual library name would neatly solve this. in workspace xmlrpc was handled as a private lib (filename had a private suffix, no cmake config installed, no headers installed etc.) so tother than translations here should be no problems mixing kf5.8 with plasma5.2. It should still probably get an if in the plasma-workspace to not build the internal library with frameworks 5.8 though. Cheers -- Martin Klapetek | KDE Developer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/#review75983 --- +1 What's the status of QtSpeech? - Aleix Pol Gonzalez On Feb. 13, 2015, 4:06 a.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/ --- (Updated Feb. 13, 2015, 4:06 a.m.) Review request for KDE Frameworks and Frederik Gladhorn. Repository: knotifyconfig Description --- Change config from KTTS to Speech. If QtSpeech is available when building return true from have_speech static method. Otherwise return false. Could also add a check to see if there are any backend errors later on. Diffs - CMakeLists.txt f5aa0e78d89a4c14c3acfd9384b100e507e30067 src/knotifyconfigactionswidget.h 88b341a909d466b8eaf065c5220ac05f8c963697 src/knotifyconfigactionswidget.cpp 27012e3b803ef0a99d5bafcebea270e2d7419d62 src/knotifyconfigactionswidgetbase.ui cbe647b70eb41ba540b7bf6d87f519b3246973a1 src/knotifyconfigelement.h 703952d23d1622e4b6214acc52461ea75b480254 src/knotifyconfigelement.cpp 5a1ac57fa5a4139682327d14c55a489450ea956b src/knotifyeventlist.cpp 148bca7d33c722a4aeecabac45286a5e501c81b3 Diff: https://git.reviewboard.kde.org/r/122554/diff/ Testing --- It builds, the config widget shows, the icon for speech is properly showing when that configuration is enabled. Speech from konversation's new message notifications are spoken. Something strange here: After enabling this notification, no messages are spoken until restarting the application with the notifications (konversation in my test case). Similarly, after disabling this notification, messages are still spoken until restarting the application. I checked and the konversation.notifyrc file is getting updated, but for some reason the changes aren't taking effect imediately yet. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
KPeople part of KDE Frameworks
Hi, I would like to submit KPeople for review process so it can join the KF5 family in the next 5.8 release. KPeople is a tier 3 framework (because of KService, which will be dropped eventually, without breaking ABI) and it offers cross-source contact aggregation. More information about it can be read on the README [1]. Your reviews will be welcome. Thanks! Aleix [1] https://projects.kde.org/projects/playground/network/kpeople/repository/revisions/master/entry/README.md ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : kjs_stable_qt5 #10
See http://build.kde.org/job/kjs_stable_qt5/10/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build became unstable: kcodecs_master_qt5 #82
See http://build.kde.org/job/kcodecs_master_qt5/82/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : frameworkintegration_stable_qt5 #31
See http://build.kde.org/job/frameworkintegration_stable_qt5/31/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to stable : plasma-framework_master_qt5 » All,LINBUILDER #999
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/999/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117985: frameworks/kjs: add missing man page docbook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117985/ --- (Updated Feb. 13, 2015, 1:29 p.m.) Status -- This change has been marked as submitted. Review request for Documentation and KDE Frameworks. Repository: kjs Description --- add missing man page docbook, which got lost in the transition from kdelibs to frameworks Diffs - CMakeLists.txt 60ee824 docs/CMakeLists.txt PRE-CREATION docs/kjs/CMakeLists.txt PRE-CREATION docs/kjs/man-kjs5.1.docbook PRE-CREATION Diff: https://git.reviewboard.kde.org/r/117985/diff/ Testing --- build + installed, viewed with man kjs5 Thanks, Burkhard Lück ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KPeople part of KDE Frameworks
On Fri, Feb 13, 2015 at 2:25 PM, Aleix Pol aleix...@kde.org wrote: Hi, I would like to submit KPeople for review process so it can join the KF5 family in the next 5.8 release. KPeople is a tier 3 framework (because of KService, which will be dropped eventually, without breaking ABI) and it offers cross-source contact aggregation. More information about it can be read on the README [1]. Your reviews will be welcome. Thanks! Aleix [1] https://projects.kde.org/projects/playground/network/kpeople/repository/revisions/master/entry/README.md Hi, Somebody requested generated API documentation for easier review, I just ran kapidox on kpeople, hope this helps: http://proli.net/meu/kpeople/apidocs/html/ Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kjs_stable_qt5 #9
See http://build.kde.org/job/kjs_stable_qt5/9/changes
Changes:
[aacid] add missing man page docbook
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/kjs_stable_qt5/ws/
Running Prebuild steps
[kjs_stable_qt5] $ /bin/sh -xe /tmp/hudson9216339809963718879.sh
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
From git://anongit.kde.org/kjs
12cf97b..a413985 master - origin/master
* [new tag] v5.7.0-rc1 - v5.7.0-rc1
Branch jenkins set up to track remote branch master from origin.
== Cleaning Source Tree
HEAD is now at 12cf97b Upgrade ECM and KF5 version requirements for 5.7.0
release.
Removing build/
Removing dotdata/
Removing local-inst/
Success build forhudson.tasks.Shell@4dd2d672
git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
git config remote.origin.url git://anongit.kde.org/kjs # timeout=10
Fetching upstream changes from git://anongit.kde.org/kjs
git --version # timeout=10
git -c core.askpass=true fetch --tags --progress git://anongit.kde.org/kjs
+refs/heads/*:refs/remotes/origin/*
git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision a4139852a3b4f61912c2e1cae9d0798f3708c612
(refs/heads/jenkins)
git config core.sparsecheckout # timeout=10
git checkout -f a4139852a3b4f61912c2e1cae9d0798f3708c612
git rev-list 12cf97b33e96dc45de0486d3dd5501c99a768a54 # timeout=10
git tag -a -f -m Jenkins Build #9 jenkins-kjs_stable_qt5-9 # timeout=10
Run condition [File exists] enabling prebuild for step [Publish JUnit test
result report]
Run condition [File exists] enabling prebuild for step [Publish Cppcheck
results]
[kjs_stable_qt5] $ /bin/sh -xe /tmp/hudson960620944498695588.sh
+ /home/jenkins/scripts/execute-job.sh
KDE Continuous Integration Build
== Building Project: kjs - Branch master
== Build Dependencies:
qt5 - Branch 5.3.2
dogtail - Branch master
extra-cmake-modules - Branch master
cmake - Branch master
== Applying Patches
=== No patches to apply
== Syncing Dependencies from Master Server
== Configuring Build
-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for __GLIBC__
-- Looking for __GLIBC__ - found
-- Performing Test _OFFT_IS_64BIT
-- Performing Test _OFFT_IS_64BIT - Success
-- Found Perl: /usr/bin/perl (found version 5.16.2)
-- Found PkgConfig: /usr/bin/pkg-config (found version 0.27.1)
-- Found PCRE: /usr/include
CMake Error at CMakeLists.txt:48 (find_package):
By not providing FindKF5DocTools.cmake in CMAKE_MODULE_PATH this project
has asked CMake to find a package configuration file provided by
KF5DocTools, but CMake did not find one.
Could not find a package configuration file provided by KF5DocTools with
any of the following names:
KF5DocToolsConfig.cmake
kf5doctools-config.cmake
Add the installation prefix of KF5DocTools to CMAKE_PREFIX_PATH or set
KF5DocTools_DIR to a directory containing one of the above files. If
KF5DocTools provides a separate development package or SDK, be sure it
has been installed.
-- Configuring incomplete, errors occurred!
See also
http://build.kde.org/job/kjs_stable_qt5/ws/build/CMakeFiles/CMakeOutput.log;.
Configure step exited with non-zero code, assuming failure to configure for
project kjs.
Build step 'Execute shell' marked build as failure
[File exists] check if file exists [build/JUnitTestResults.xml]
Run condition [File exists] preventing perform for step [Publish JUnit test
result report]
[File exists] check if file exists [build/cppcheck.xml]
Run condition [File exists] preventing perform for step [Publish Cppcheck
results]
[WARNINGS] Skipping publisher since build result is FAILURE
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kjs_master_qt5 #71
See http://build.kde.org/job/kjs_master_qt5/71/changes
Changes:
[aacid] add missing man page docbook
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/kjs_master_qt5/ws/
Running Prebuild steps
[kjs_master_qt5] $ /bin/sh -xe /tmp/hudson1088157092747017670.sh
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
Cloning into '.'...
Branch jenkins set up to track remote branch master from origin.
== Cleaning Source Tree
HEAD is now at a413985 add missing man page docbook
Success build forhudson.tasks.Shell@1eba1c2
git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
git config remote.origin.url git://anongit.kde.org/kjs # timeout=10
Fetching upstream changes from git://anongit.kde.org/kjs
git --version # timeout=10
git -c core.askpass=true fetch --tags --progress git://anongit.kde.org/kjs
+refs/heads/*:refs/remotes/origin/*
git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision a4139852a3b4f61912c2e1cae9d0798f3708c612
(refs/heads/jenkins)
git config core.sparsecheckout # timeout=10
git checkout -f a4139852a3b4f61912c2e1cae9d0798f3708c612
git rev-list 12cf97b33e96dc45de0486d3dd5501c99a768a54 # timeout=10
git tag -a -f -m Jenkins Build #71 jenkins-kjs_master_qt5-71 # timeout=10
Run condition [File exists] enabling prebuild for step [Publish JUnit test
result report]
Run condition [File exists] enabling prebuild for step [Publish Cppcheck
results]
[kjs_master_qt5] $ /bin/sh -xe /tmp/hudson6634783418771565559.sh
+ /home/jenkins/scripts/execute-job.sh
KDE Continuous Integration Build
== Building Project: kjs - Branch master
== Build Dependencies:
qt5 - Branch 5.4.1
dogtail - Branch master
extra-cmake-modules - Branch master
cmake - Branch master
== Applying Patches
=== No patches to apply
== Syncing Dependencies from Master Server
== Configuring Build
-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for __GLIBC__
-- Looking for __GLIBC__ - found
-- Performing Test _OFFT_IS_64BIT
-- Performing Test _OFFT_IS_64BIT - Success
-- Found Perl: /usr/bin/perl (found version 5.16.2)
-- Found PkgConfig: /usr/bin/pkg-config (found version 0.27.1)
-- Found PCRE: /usr/include
CMake Error at CMakeLists.txt:48 (find_package):
By not providing FindKF5DocTools.cmake in CMAKE_MODULE_PATH this project
has asked CMake to find a package configuration file provided by
KF5DocTools, but CMake did not find one.
Could not find a package configuration file provided by KF5DocTools with
any of the following names:
KF5DocToolsConfig.cmake
kf5doctools-config.cmake
Add the installation prefix of KF5DocTools to CMAKE_PREFIX_PATH or set
KF5DocTools_DIR to a directory containing one of the above files. If
KF5DocTools provides a separate development package or SDK, be sure it
has been installed.
-- Configuring incomplete, errors occurred!
See also
http://build.kde.org/job/kjs_master_qt5/ws/build/CMakeFiles/CMakeOutput.log;.
Configure step exited with non-zero code, assuming failure to configure for
project kjs.
Build step 'Execute shell' marked build as failure
[File exists] check if file exists [build/JUnitTestResults.xml]
Run condition [File exists] preventing perform for step [Publish JUnit test
result report]
[File exists] check if file exists [build/cppcheck.xml]
Run condition [File exists] preventing perform for step [Publish Cppcheck
results]
[WARNINGS] Skipping publisher since build result is FAILURE
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : kjs_master_qt5 #72
See http://build.kde.org/job/kjs_master_qt5/72/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: frameworkintegration_stable_qt5 #30
See http://build.kde.org/job/frameworkintegration_stable_qt5/30/changes Changes: [Kevin Funk] Use Q_DECL_OVERRIDE where possible -- [...truncated 87 lines...] -- Check for working C compiler: /home/jenkins/bin/cc -- Check for working C compiler: /home/jenkins/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Detecting C compile features -- Detecting C compile features - done -- Check for working CXX compiler: /home/jenkins/bin/c++ -- Check for working CXX compiler: /home/jenkins/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Detecting CXX compile features -- Detecting CXX compile features - done -- Looking for __GLIBC__ -- Looking for __GLIBC__ - found -- Performing Test _OFFT_IS_64BIT -- Performing Test _OFFT_IS_64BIT - Success -- Found Gettext: /usr/bin/msgmerge (found version 0.18.1) -- Found PythonInterp: /usr/bin/python (found version 2.7.3) CMake Warning at CMakeLists.txt:38 (find_package): By not providing FindOxygenFont.cmake in CMAKE_MODULE_PATH this project has asked CMake to find a package configuration file provided by OxygenFont, but CMake did not find one. Could not find a package configuration file provided by OxygenFont (requested version 0.4) with any of the following names: OxygenFontConfig.cmake oxygenfont-config.cmake Add the installation prefix of OxygenFont to CMAKE_PREFIX_PATH or set OxygenFont_DIR to a directory containing one of the above files. If OxygenFont provides a separate development package or SDK, be sure it has been installed. -- Found PkgConfig: /usr/bin/pkg-config (found version 0.27.1) -- Found XCB_XCB: /usr/lib64/libxcb.so (found version 1.9) -- Found XCB: /usr/lib64/libxcb.so (found version 1.9) found components: XCB -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so - found -- Looking for gethostbyname -- Looking for gethostbyname - found -- Looking for connect -- Looking for connect - found -- Looking for remove -- Looking for remove - found -- Looking for shmat -- Looking for shmat - found -- Looking for IceConnectionNumber in ICE -- Looking for IceConnectionNumber in ICE - found -- Found X11: /usr/lib64/libX11.so -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success -- Performing Test COMPILER_HAS_DEPRECATED_ATTR -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success -- -- The following OPTIONAL packages have been found: * PkgConfig -- The following RECOMMENDED packages have been found: * XCB , X protocol C-language Binding , http://xcb.freedesktop.org Required for flushing the XCB connection on the X11 Platform Required to pass style properties to native Windows on X11 Platform -- The following REQUIRED packages have been found: * ECM (required version = 1.7.0) * Qt5Core (required version = 5.3.2) * Qt5Gui (required version = 5.3.2) * Qt5Widgets * Qt5DBus * KF5Config (required version = 5.7.0) * KF5ConfigWidgets (required version = 5.7.0) * Gettext * PythonInterp * KF5I18n (required version = 5.7.0) * KF5IconThemes (required version = 5.7.0) * KF5KIO (required version = 5.7.0) * KF5Notifications (required version = 5.7.0) * KF5WidgetsAddons (required version = 5.7.0) * X11 , Required for updating the Cursor theme on X11 , http://www.x.org * Qt5X11Extras * Qt5 (required version = 5.2.0) -- The following RUNTIME packages have not been found: * OxygenFont (required version = 0.4) Default font for KDE Applications -- Configuring done -- Generating done CMake Warning: Manually-specified variables were not used by the project: KDE4_BUILD_TESTS LIB_SUFFIX SIP_DEFAULT_SIP_DIR -- Build files have been written to: http://build.kde.org/job/frameworkintegration_stable_qt5/ws/build == Commencing the Build Scanning dependencies of target KF5Style_automoc Scanning dependencies of target KDEPlatformTheme_automoc Scanning dependencies of target FrameworkIntegrationPlugin_automoc Scanning dependencies of target kdeplatformtheme_unittest_automoc Scanning dependencies of target kfiledialog_unittest_automoc [ 2%] Scanning dependencies of target kfontsettingsdata_unittest_automoc Scanning dependencies of target kstyle_unittest_automoc [ 4%] [ 6%] Scanning dependencies of target kstyletest_automoc Scanning dependencies of target qfiledialogtest_automoc [ 13%] [ 13%] [ 13%] Automatic moc for target KDEPlatformTheme [ 15%] Automatic moc for target KF5Style [ 18%] Automatic moc for target FrameworkIntegrationPlugin [ 20%] Automatic moc for target kfontsettingsdata_unittest Automatic moc for target kfiledialog_unittest Automatic moc for target kdeplatformtheme_unittest Automatic moc
Review Request 122562: Add method for converting from QVariant to base64
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122562/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- I need some method like that over at the QuickShare plasmoid. I'm unsure where to put it, anybody knows of a good place? Otherwise I guess it works fine with the clipboard, that returns QVariant. Diffs - src/qmlcontrols/kquickcontrolsaddons/clipboard.cpp 23ce29b src/qmlcontrols/kquickcontrolsaddons/clipboard.h ac89b9d Diff: https://git.reviewboard.kde.org/r/122562/diff/ Testing --- Adopted locally in my QuickShare plasmoid implementation Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122555: knotifications: Add optional dependency on Qt5TextToSpeech for speech notifications.
On Feb. 13, 2015, 5:11 a.m., Martin Klapetek wrote: src/notifybyspeech.cpp, line 65 https://git.reviewboard.kde.org/r/122555/diff/1/?file=348637#file348637line65 Is there any way to know when the say() has finished? Because the finished() below will delete the notification object if it's the only plugin, which may just interrupt the speech in the middle We could watch the tts object for state change, but we wouldn't know which speech job it's finishing. Anyway, I don't think it matters, we pass the text to speak then the knotification object can get deleted with no effect on the speech itself from what I've heard (with my ears, not through the grape vine). - Jeremy --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122555/#review75986 --- On Feb. 12, 2015, 8:11 p.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122555/ --- (Updated Feb. 12, 2015, 8:11 p.m.) Review request for KDE Frameworks and Frederik Gladhorn. Repository: knotifications Description --- Add optional dependency on Qt5TextToSpeech for speech notifications. Diffs - CMakeLists.txt 208fd02153a0607e4cfbc02e4b289ef835cedbfd src/CMakeLists.txt 6a3d81707a0e27e2d7bbfbf7f3924852ab737bf9 src/knotification.h c85621699793436442090b7f94ea82ef10c45b89 src/knotificationmanager.cpp affb6a673468bf6585cbda6fafdd008beb445cd9 src/kstatusnotifieritem.h 113dad513c320ef97f59b221b3541ca2f388693e src/notifybyktts.h 43756f776678bd7700a77a3357577363b36d2542 src/notifybyktts.cpp a2a15a9c77089527f54dfc63f13699d44336dda1 src/notifybyspeech.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122555/diff/ Testing --- As I said in the knotifyconfig review something at runtime isn't refreshing/reloading the config when it is changed. Otherwise this works fine when QtSpeech is available. QtSpeech is still in development, so this change is added as an optional dependency. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.
On Feb. 13, 2015, 4:49 a.m., Aleix Pol Gonzalez wrote: +1 What's the status of QtSpeech? I'll blog about it shortly. - Jeremy --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/#review75983 --- On Feb. 12, 2015, 8:06 p.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/ --- (Updated Feb. 12, 2015, 8:06 p.m.) Review request for KDE Frameworks and Frederik Gladhorn. Repository: knotifyconfig Description --- Change config from KTTS to Speech. If QtSpeech is available when building return true from have_speech static method. Otherwise return false. Could also add a check to see if there are any backend errors later on. Diffs - CMakeLists.txt f5aa0e78d89a4c14c3acfd9384b100e507e30067 src/knotifyconfigactionswidget.h 88b341a909d466b8eaf065c5220ac05f8c963697 src/knotifyconfigactionswidget.cpp 27012e3b803ef0a99d5bafcebea270e2d7419d62 src/knotifyconfigactionswidgetbase.ui cbe647b70eb41ba540b7bf6d87f519b3246973a1 src/knotifyconfigelement.h 703952d23d1622e4b6214acc52461ea75b480254 src/knotifyconfigelement.cpp 5a1ac57fa5a4139682327d14c55a489450ea956b src/knotifyeventlist.cpp 148bca7d33c722a4aeecabac45286a5e501c81b3 Diff: https://git.reviewboard.kde.org/r/122554/diff/ Testing --- It builds, the config widget shows, the icon for speech is properly showing when that configuration is enabled. Speech from konversation's new message notifications are spoken. Something strange here: After enabling this notification, no messages are spoken until restarting the application with the notifications (konversation in my test case). Similarly, after disabling this notification, messages are still spoken until restarting the application. I checked and the konversation.notifyrc file is getting updated, but for some reason the changes aren't taking effect imediately yet. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/ --- (Updated Feb. 13, 2015, 12:42 p.m.) Review request for KDE Frameworks and Frederik Gladhorn. Changes --- Updated to use TTS name instead of Speech. Repository: knotifyconfig Description --- Change config from KTTS to Speech. If QtSpeech is available when building return true from have_speech static method. Otherwise return false. Could also add a check to see if there are any backend errors later on. Diffs (updated) - CMakeLists.txt f5aa0e78d89a4c14c3acfd9384b100e507e30067 src/knotifyconfigactionswidget.h 88b341a909d466b8eaf065c5220ac05f8c963697 src/knotifyconfigactionswidget.cpp 27012e3b803ef0a99d5bafcebea270e2d7419d62 src/knotifyconfigactionswidgetbase.ui cbe647b70eb41ba540b7bf6d87f519b3246973a1 src/knotifyconfigelement.h 703952d23d1622e4b6214acc52461ea75b480254 src/knotifyconfigelement.cpp 5a1ac57fa5a4139682327d14c55a489450ea956b src/knotifyeventlist.cpp 148bca7d33c722a4aeecabac45286a5e501c81b3 Diff: https://git.reviewboard.kde.org/r/122554/diff/ Testing --- It builds, the config widget shows, the icon for speech is properly showing when that configuration is enabled. Speech from konversation's new message notifications are spoken. Something strange here: After enabling this notification, no messages are spoken until restarting the application with the notifications (konversation in my test case). Similarly, after disabling this notification, messages are still spoken until restarting the application. I checked and the konversation.notifyrc file is getting updated, but for some reason the changes aren't taking effect imediately yet. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: OSX/CI: kde-baseapps fails to build for branch-group stable-kf5-qt5
Hi,
On 13 Feb 2015, at 10:15 , Kevin Funk kf...@kde.org wrote:
Indeed, the kde/* rule in 'logical-module-structure' is wrong already:
yep, that’s what I wanted to express. =)
Ben has fixed that in the meantime [1] and then changed it later again [2].
So, now one would have to introduce for all the below projects a separate
dependency block to ensure that “stable-kf5-qt5” is set to empty:
==
FAILURE SUMMARY:
libkdcraw
kqtquickcharts
pairs
ark
cantor
kmplot
kolourpaint
kmahjongg
granatier
killbots
ktuberling
knavalbattle
lskat
palapeli
kreversi
ksirk
kturtle
ksnakeduel
knetwalk
ksudoku
kubrick
ksquares
kspaceduel
katomic
kbreakout
kfourinline
kgoldrunner
kiriki
kjumpingcube
klickety
kolf
kollision
konquest
kpat
kigo
==
It seems to me, though, that at least something like this
---
kde/kdegames/*: {
stable-qt4: Applications/14.12,
latest-qt4: Applications/14.12,
kf5-qt5: frameworks,
stable-kf5-qt5:
}
---
might be more appropriate as a default setting, no!?
Greets,
Marko
[1]
http://quickgit.kde.org/?p=kde-build-metadata.gita=commitdiffh=f2332e41a47184f43946675d01b05d3ece74d7ec
[2]
http://quickgit.kde.org/?p=kde-build-metadata.gita=commitdiffh=04833a43f38bc5d316102b6fd675d0d177542e19
signature.asc
Description: Message signed with OpenPGP using GPGMail
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122555: knotifications: Add optional dependency on Qt5TextToSpeech for speech notifications.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122555/ --- (Updated Feb. 13, 2015, 4:01 p.m.) Review request for KDE Frameworks and Frederik Gladhorn. Changes --- Fixed issues noted. Repository: knotifications Description --- Add optional dependency on Qt5TextToSpeech for speech notifications. Diffs (updated) - CMakeLists.txt 208fd02153a0607e4cfbc02e4b289ef835cedbfd src/CMakeLists.txt 6a3d81707a0e27e2d7bbfbf7f3924852ab737bf9 src/knotification.h dc0c975e261f1a03b8b4875bc1069417cf8ea094 src/knotificationmanager.cpp affb6a673468bf6585cbda6fafdd008beb445cd9 src/knotifyconfig.cpp af6be92bd320eaa881d8420cadf175edf6bf41aa src/kstatusnotifieritem.h 74b97ba7c63d52cae8ee80326daa9f24ce03a331 src/notifybyktts.h 43756f776678bd7700a77a3357577363b36d2542 src/notifybyktts.cpp a2a15a9c77089527f54dfc63f13699d44336dda1 src/notifybytts.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122555/diff/ Testing --- As I said in the knotifyconfig review something at runtime isn't refreshing/reloading the config when it is changed. Otherwise this works fine when QtSpeech is available. QtSpeech is still in development, so this change is added as an optional dependency. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122555: knotifications: Add optional dependency on Qt5TextToSpeech for speech notifications.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122555/#review76006 --- src/notifybyktts.h https://git.reviewboard.kde.org/r/122555/#comment52450 I have no idea how this is used, should it be i18n'ed? And Text to Speech - Frederik Gladhorn On Feb. 13, 2015, 3:11 a.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122555/ --- (Updated Feb. 13, 2015, 3:11 a.m.) Review request for KDE Frameworks and Frederik Gladhorn. Repository: knotifications Description --- Add optional dependency on Qt5TextToSpeech for speech notifications. Diffs - CMakeLists.txt 208fd02153a0607e4cfbc02e4b289ef835cedbfd src/CMakeLists.txt 6a3d81707a0e27e2d7bbfbf7f3924852ab737bf9 src/knotification.h c85621699793436442090b7f94ea82ef10c45b89 src/knotificationmanager.cpp affb6a673468bf6585cbda6fafdd008beb445cd9 src/kstatusnotifieritem.h 113dad513c320ef97f59b221b3541ca2f388693e src/notifybyktts.h 43756f776678bd7700a77a3357577363b36d2542 src/notifybyktts.cpp a2a15a9c77089527f54dfc63f13699d44336dda1 src/notifybyspeech.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122555/diff/ Testing --- As I said in the knotifyconfig review something at runtime isn't refreshing/reloading the config when it is changed. Otherwise this works fine when QtSpeech is available. QtSpeech is still in development, so this change is added as an optional dependency. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.
On Feb. 13, 2015, 11:49 a.m., Aleix Pol Gonzalez wrote: +1 What's the status of QtSpeech? Jeremy Whiting wrote: I'll blog about it shortly. I think QtSpeech is Qt 5.6 material realistically. It's usable on most platforms but needs cleanup and API review and a couple of features are not done on all platforms. - Frederik --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/#review75983 --- On Feb. 13, 2015, 7:42 p.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/ --- (Updated Feb. 13, 2015, 7:42 p.m.) Review request for KDE Frameworks and Frederik Gladhorn. Repository: knotifyconfig Description --- Change config from KTTS to Speech. If QtSpeech is available when building return true from have_speech static method. Otherwise return false. Could also add a check to see if there are any backend errors later on. Diffs - CMakeLists.txt f5aa0e78d89a4c14c3acfd9384b100e507e30067 src/knotifyconfigactionswidget.h 88b341a909d466b8eaf065c5220ac05f8c963697 src/knotifyconfigactionswidget.cpp 27012e3b803ef0a99d5bafcebea270e2d7419d62 src/knotifyconfigactionswidgetbase.ui cbe647b70eb41ba540b7bf6d87f519b3246973a1 src/knotifyconfigelement.h 703952d23d1622e4b6214acc52461ea75b480254 src/knotifyconfigelement.cpp 5a1ac57fa5a4139682327d14c55a489450ea956b src/knotifyeventlist.cpp 148bca7d33c722a4aeecabac45286a5e501c81b3 Diff: https://git.reviewboard.kde.org/r/122554/diff/ Testing --- It builds, the config widget shows, the icon for speech is properly showing when that configuration is enabled. Speech from konversation's new message notifications are spoken. Something strange here: After enabling this notification, no messages are spoken until restarting the application with the notifications (konversation in my test case). Similarly, after disabling this notification, messages are still spoken until restarting the application. I checked and the konversation.notifyrc file is getting updated, but for some reason the changes aren't taking effect imediately yet. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122551: New feature: Open all recent files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122551/#review76011 --- This only covers your point 3): You added a menu item Open all recent files. What about hide it by default and let the client (kate, kaffeine etc.) decide if it should be shown or not by - e.g. with .setOpenAllMenuItemVisible(true); or .setAllowOpenAll(true); - Gregor Mi On Feb. 12, 2015, 11:56 p.m., Thomas Murach wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122551/ --- (Updated Feb. 12, 2015, 11:56 p.m.) Review request for KDE Frameworks. Repository: kconfigwidgets Description --- I've always been looking for a feature (mostly in Kate et al.) to open all recently opened files at once. Every once in a while I think I'm done with some source code editing, realise that I'm not, and then have to click through all files one by one. With this patch opening all files at once gets possible. So much for the background. Still there are some open questions: 1) Is such a feature wanted at all? 2) Is the code quality/style ok? 3) Last but not least: This patch will work nicely with kate, presumably also with okular and some others, but I guess it will not work as expected with Kaffeine, for example, as new files which are to be opened will not get appended to a playlist but instead each file will get opened for an instance and then be replaced by the next opened file. Possible solutions: In principle it would be possible to add another signal passing a list of URLs to applications, which then have to define a suitable slot. Alternatively this patch could just not be applied and the feature I'm trying to introduce could be added to kate only... (I don't prefer that option ;) ) So, what are your opinions, comments, ideas? Thanks in advance! PS I hope the reviewer group kdeframeworks is the right one... Diffs - src/krecentfilesaction.h 06965d4 src/krecentfilesaction.cpp 40fdf93 src/krecentfilesaction_p.h 2c690a7 Diff: https://git.reviewboard.kde.org/r/122551/diff/ Testing --- I don't run KF5 on a daily basis, but in a Docker session the patch works nicely with Kate. Thanks, Thomas Murach ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.
On Feb. 13, 2015, 12:17 p.m., Martin Klapetek wrote: src/knotifyconfigactionswidgetbase.ui, line 141 https://git.reviewboard.kde.org/r/122554/diff/1/?file=348626#file348626line141 Is Jovie still used in QtSpeech? If not, it should be removed from here I tend to agree to TTS or even better Text to Speech/Text-To-Speech. - Frederik --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/#review75987 --- On Feb. 13, 2015, 7:42 p.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/ --- (Updated Feb. 13, 2015, 7:42 p.m.) Review request for KDE Frameworks and Frederik Gladhorn. Repository: knotifyconfig Description --- Change config from KTTS to Speech. If QtSpeech is available when building return true from have_speech static method. Otherwise return false. Could also add a check to see if there are any backend errors later on. Diffs - CMakeLists.txt f5aa0e78d89a4c14c3acfd9384b100e507e30067 src/knotifyconfigactionswidget.h 88b341a909d466b8eaf065c5220ac05f8c963697 src/knotifyconfigactionswidget.cpp 27012e3b803ef0a99d5bafcebea270e2d7419d62 src/knotifyconfigactionswidgetbase.ui cbe647b70eb41ba540b7bf6d87f519b3246973a1 src/knotifyconfigelement.h 703952d23d1622e4b6214acc52461ea75b480254 src/knotifyconfigelement.cpp 5a1ac57fa5a4139682327d14c55a489450ea956b src/knotifyeventlist.cpp 148bca7d33c722a4aeecabac45286a5e501c81b3 Diff: https://git.reviewboard.kde.org/r/122554/diff/ Testing --- It builds, the config widget shows, the icon for speech is properly showing when that configuration is enabled. Speech from konversation's new message notifications are spoken. Something strange here: After enabling this notification, no messages are spoken until restarting the application with the notifications (konversation in my test case). Similarly, after disabling this notification, messages are still spoken until restarting the application. I checked and the konversation.notifyrc file is getting updated, but for some reason the changes aren't taking effect imediately yet. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122551: New feature: Open all recent files
On Feb. 13, 2015, 12:06 vorm., Kevin Funk wrote: You're aware that Kate (and any other decent editor) has session management which probably solves your issue? It saves the session when you close it, and re-opens all the files that had been opened. Sure, I use sessions quite frequently. To me the need to re-open many/all recently opened files occurs _within_ sessions. One session (in my case) corresponds to one project / code base containing usually many files, so I don't have all of them open. Then if I think I'm done fixing a bug or similar, I close files I won't need again in the next days, and the situation described above has started. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122551/#review75958 --- On Feb. 12, 2015, 11:56 nachm., Thomas Murach wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122551/ --- (Updated Feb. 12, 2015, 11:56 nachm.) Review request for KDE Frameworks. Repository: kconfigwidgets Description --- I've always been looking for a feature (mostly in Kate et al.) to open all recently opened files at once. Every once in a while I think I'm done with some source code editing, realise that I'm not, and then have to click through all files one by one. With this patch opening all files at once gets possible. So much for the background. Still there are some open questions: 1) Is such a feature wanted at all? 2) Is the code quality/style ok? 3) Last but not least: This patch will work nicely with kate, presumably also with okular and some others, but I guess it will not work as expected with Kaffeine, for example, as new files which are to be opened will not get appended to a playlist but instead each file will get opened for an instance and then be replaced by the next opened file. Possible solutions: In principle it would be possible to add another signal passing a list of URLs to applications, which then have to define a suitable slot. Alternatively this patch could just not be applied and the feature I'm trying to introduce could be added to kate only... (I don't prefer that option ;) ) So, what are your opinions, comments, ideas? Thanks in advance! PS I hope the reviewer group kdeframeworks is the right one... Diffs - src/krecentfilesaction.h 06965d4 src/krecentfilesaction.cpp 40fdf93 src/krecentfilesaction_p.h 2c690a7 Diff: https://git.reviewboard.kde.org/r/122551/diff/ Testing --- I don't run KF5 on a daily basis, but in a Docker session the patch works nicely with Kate. Thanks, Thomas Murach ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: OSX/CI: kde-baseapps fails to build for branch-group stable-kf5-qt5
On Sat, Feb 14, 2015 at 8:17 AM, Marko Käning mk-li...@email.de wrote:
Hi,
Hi Marko,
On 13 Feb 2015, at 10:15 , Kevin Funk kf...@kde.org wrote:
Indeed, the kde/* rule in 'logical-module-structure' is wrong already:
yep, that’s what I wanted to express. =)
Ben has fixed that in the meantime [1] and then changed it later again [2].
So, now one would have to introduce for all the below projects a separate
dependency block to ensure that “stable-kf5-qt5” is set to empty:
==
FAILURE SUMMARY:
libkdcraw
kqtquickcharts
pairs
ark
cantor
kmplot
kolourpaint
kmahjongg
granatier
killbots
ktuberling
knavalbattle
lskat
palapeli
kreversi
ksirk
kturtle
ksnakeduel
knetwalk
ksudoku
kubrick
ksquares
kspaceduel
katomic
kbreakout
kfourinline
kgoldrunner
kiriki
kjumpingcube
klickety
kolf
kollision
konquest
kpat
kigo
==
It seems to me, though, that at least something like this
---
kde/kdegames/*: {
stable-qt4: Applications/14.12,
latest-qt4: Applications/14.12,
kf5-qt5: frameworks,
stable-kf5-qt5:
}
---
might be more appropriate as a default setting, no!?
For now, that should do the case, yes.
Long term, we need a better solution to this of course.
Greets,
Marko
Thanks,
Ben
[1]
http://quickgit.kde.org/?p=kde-build-metadata.gita=commitdiffh=f2332e41a47184f43946675d01b05d3ece74d7ec
[2]
http://quickgit.kde.org/?p=kde-build-metadata.gita=commitdiffh=04833a43f38bc5d316102b6fd675d0d177542e19
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122555: knotifications: Add optional dependency on Qt5TextToSpeech for speech notifications.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122555/#review75986
---
Looks good, thanks for that! I'm wondering if using TTS in the name rather than
Speech would be more appropriate? TTS is an abbreviation that is well known
while Speech can mean many things...
src/kstatusnotifieritem.h
https://git.reviewboard.kde.org/r/122555/#comment52414
This is unrelated to this patch, but please do commit it (separately)
src/notifybyspeech.cpp
https://git.reviewboard.kde.org/r/122555/#comment52415
CamelCaseHeaders?
src/notifybyspeech.cpp
https://git.reviewboard.kde.org/r/122555/#comment52416
KNotifyConfig * config ) -- KNotifyConfig *config)
src/notifybyspeech.cpp
https://git.reviewboard.kde.org/r/122555/#comment52420
Could you add some comments on what this is and what it's for?
src/notifybyspeech.cpp
https://git.reviewboard.kde.org/r/122555/#comment52417
No spaces inside ()s
src/notifybyspeech.cpp
https://git.reviewboard.kde.org/r/122555/#comment52418
No spaces in ()s and add {}
src/notifybyspeech.cpp
https://git.reviewboard.kde.org/r/122555/#comment52419
Is there any way to know when the say() has finished? Because the
finished() below will delete the notification object if it's the only plugin,
which may just interrupt the speech in the middle
- Martin Klapetek
On Feb. 13, 2015, 4:11 a.m., Jeremy Whiting wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122555/
---
(Updated Feb. 13, 2015, 4:11 a.m.)
Review request for KDE Frameworks and Frederik Gladhorn.
Repository: knotifications
Description
---
Add optional dependency on Qt5TextToSpeech for speech notifications.
Diffs
-
CMakeLists.txt 208fd02153a0607e4cfbc02e4b289ef835cedbfd
src/CMakeLists.txt 6a3d81707a0e27e2d7bbfbf7f3924852ab737bf9
src/knotification.h c85621699793436442090b7f94ea82ef10c45b89
src/knotificationmanager.cpp affb6a673468bf6585cbda6fafdd008beb445cd9
src/kstatusnotifieritem.h 113dad513c320ef97f59b221b3541ca2f388693e
src/notifybyktts.h 43756f776678bd7700a77a3357577363b36d2542
src/notifybyktts.cpp a2a15a9c77089527f54dfc63f13699d44336dda1
src/notifybyspeech.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122555/diff/
Testing
---
As I said in the knotifyconfig review something at runtime isn't
refreshing/reloading the config when it is changed. Otherwise this works fine
when QtSpeech is available.
QtSpeech is still in development, so this change is added as an optional
dependency.
Thanks,
Jeremy Whiting
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122554/#review75987
---
As I said in the other review, I believe the user facing strings should use
TTS rather than Speech as TTS or Text-To-Speech is an estabilished
abbreviation in the field. Any other opinions on that? Frederik?
As for the config not updating, can you try this:
```
src/knotifyconfig.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/knotifyconfig.cpp b/src/knotifyconfig.cpp
index af6be92..e9b684b 100644
--- a/src/knotifyconfig.cpp
+++ b/src/knotifyconfig.cpp
@@ -37,6 +37,7 @@ static KSharedConfig::Ptr retrieve_from_cache(const QString
filename, QStandard
{
QCacheQString, KSharedConfig::Ptr cache = *static_cache;
if (cache.contains(filename)) {
+(*cache[filename])-reparseConfiguration();
return *cache[filename];
}
```
src/knotifyconfigactionswidgetbase.ui
https://git.reviewboard.kde.org/r/122554/#comment52421
Is Jovie still used in QtSpeech? If not, it should be removed from here
- Martin Klapetek
On Feb. 13, 2015, 4:06 a.m., Jeremy Whiting wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122554/
---
(Updated Feb. 13, 2015, 4:06 a.m.)
Review request for KDE Frameworks and Frederik Gladhorn.
Repository: knotifyconfig
Description
---
Change config from KTTS to Speech.
If QtSpeech is available when building return true from have_speech static
method.
Otherwise return false.
Could also add a check to see if there are any backend errors later on.
Diffs
-
CMakeLists.txt f5aa0e78d89a4c14c3acfd9384b100e507e30067
src/knotifyconfigactionswidget.h 88b341a909d466b8eaf065c5220ac05f8c963697
src/knotifyconfigactionswidget.cpp 27012e3b803ef0a99d5bafcebea270e2d7419d62
src/knotifyconfigactionswidgetbase.ui
cbe647b70eb41ba540b7bf6d87f519b3246973a1
src/knotifyconfigelement.h 703952d23d1622e4b6214acc52461ea75b480254
src/knotifyconfigelement.cpp 5a1ac57fa5a4139682327d14c55a489450ea956b
src/knotifyeventlist.cpp 148bca7d33c722a4aeecabac45286a5e501c81b3
Diff: https://git.reviewboard.kde.org/r/122554/diff/
Testing
---
It builds, the config widget shows, the icon for speech is properly showing
when that configuration is enabled. Speech from konversation's new message
notifications are spoken.
Something strange here:
After enabling this notification, no messages are spoken until restarting the
application with the notifications (konversation in my test case).
Similarly, after disabling this notification, messages are still spoken until
restarting the application.
I checked and the konversation.notifyrc file is getting updated, but for some
reason the changes aren't taking effect imediately yet.
Thanks,
Jeremy Whiting
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #998
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122542/ --- (Updated Feb. 13, 2015, 12:40 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Description --- This is a huge patch (almost 30 000 lines) covering all frameworks. This was done using clang-modernize and a few wrapper scripts. If you'll give me the okay, I'll push this to the individual frameworks. Diffs - Diff: https://git.reviewboard.kde.org/r/122542/diff/ Testing --- Compiles fine on my machine. File Attachments frameworks-add-override.patch https://git.reviewboard.kde.org/media/uploaded/files/2015/02/12/97a4c658-1517-4ab8-88ee-f76c09146393__frameworks-add-override.patch Without 'virtual' https://git.reviewboard.kde.org/media/uploaded/files/2015/02/12/8c42d21f-6a7b-496f-addf-757cb45dbc77__frameworks-add-override.patch Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Extra patch for KConfig 5.7 release
Hi all, If it is not too late to sneak an extra patch into KConfig's 5.7 release, could commit 9eee15917e01a89d937d1cba2eebbe9d65daeb72 ( http://commits.kde.org/kconfig/9eee15917e01a89d937d1cba2eebbe9d65daeb72 ) be added in? This change reverts a SIC, which will break updating of configuration files using kconf_update. The underlying bug from the original commit is still a problem after this revert, and I had hoped to tackle the entire issue before 5.7. Since that didn't get done, I rather fix the SIC for 5.7 then break existing software. The change is only into a couple lines + documentation and tests. It is relatively straight forward, and shouldn't cause any regressions (Jenkins remains green). Thanks, -- Matthew smime.p7s Description: S/MIME cryptographic signature ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
