Re: Review Request 122462: [KCompletion] Fix typos in documentation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122462/#review76203 --- +1 Looks good to me. - Aleix Pol Gonzalez On Feb. 8, 2015, 11:46 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122462/ --- (Updated Feb. 8, 2015, 11:46 p.m.) Review request for KDE Frameworks. Repository: kcompletion Description --- Fix typos in documentation - Substitute double space after period for single space - emition -- emission - Re-implemented -- Reimplemented Diffs - src/kcombobox.h 075d42f src/kcompletion.h a6ed372 src/kcompletion_p.h 138c228 src/kcompletionbase.h 6111f9a src/kcompletionbox.h 1759eba src/klineedit.h 460a2ae src/kzoneallocator_p.h 2d75a83 Diff: https://git.reviewboard.kde.org/r/122462/diff/ Testing --- None needed Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122462: [KCompletion] Fix typos in documentation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122462/#review76202 --- Ping? - David Gil Oliva On feb. 8, 2015, 10:46 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122462/ --- (Updated feb. 8, 2015, 10:46 p.m.) Review request for KDE Frameworks. Repository: kcompletion Description --- Fix typos in documentation - Substitute double space after period for single space - emition -- emission - Re-implemented -- Reimplemented Diffs - src/kcombobox.h 075d42f src/kcompletion.h a6ed372 src/kcompletion_p.h 138c228 src/kcompletionbase.h 6111f9a src/kcompletionbox.h 1759eba src/klineedit.h 460a2ae src/kzoneallocator_p.h 2d75a83 Diff: https://git.reviewboard.kde.org/r/122462/diff/ Testing --- None needed Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kde-baseapps_master_qt5 #241
See http://build.kde.org/job/kde-baseapps_master_qt5/241/changes Changes: [andreas.sturmlechner] Make tests optional -- [...truncated 2663 lines...] ^ http://build.kde.org/job/kde-baseapps_master_qt5/ws/kfind/kfindtreeview.cpp: At global scope: http://build.kde.org/job/kde-baseapps_master_qt5/ws/kfind/kfindtreeview.cpp:395:52: warning: ‘KUrl’ is deprecated [-Wdeprecated-declarations] void KFindTreeView::beginSearch(const KUrl baseUrl) ^ http://build.kde.org/job/kde-baseapps_master_qt5/ws/kfind/kfindtreeview.cpp:412:48: warning: ‘KUrl’ is deprecated [-Wdeprecated-declarations] void KFindTreeView::removeItem(const KUrl url) ^ http://build.kde.org/job/kde-baseapps_master_qt5/ws/kfind/kfindtreeview.cpp: In member function ‘void KFindTreeView::removeItem(const KUrl)’: http://build.kde.org/job/kde-baseapps_master_qt5/ws/kfind/kfindtreeview.cpp:414:16: warning: ‘List’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:143) [-Wdeprecated-declarations] KUrl::List list = selectedUrls(); ^ http://build.kde.org/job/kde-baseapps_master_qt5/ws/kfind/kfindtreeview.cpp: In member function ‘void KFindTreeView::saveResults()’: http://build.kde.org/job/kde-baseapps_master_qt5/ws/kfind/kfindtreeview.cpp:441:18: warning: ‘KFileDialog’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kfiledialog.h:74) [-Wdeprecated-declarations] KFileDialog *dlg = new KFileDialog(QString(), QString(), this); ^ http://build.kde.org/job/kde-baseapps_master_qt5/ws/kfind/kfindtreeview.cpp:441:28: warning: ‘KFileDialog’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kfiledialog.h:74) [-Wdeprecated-declarations] KFileDialog *dlg = new KFileDialog(QString(), QString(), this); ^ http://build.kde.org/job/kde-baseapps_master_qt5/ws/kfind/kfindtreeview.cpp:449:10: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109) [-Wdeprecated-declarations] KUrl u = dlg-selectedUrl(); ^ http://build.kde.org/job/kde-baseapps_master_qt5/ws/kfind/kfindtreeview.cpp: In member function ‘void KFindTreeView::openContainingFolder()’: http://build.kde.org/job/kde-baseapps_master_qt5/ws/kfind/kfindtreeview.cpp:508:16: warning: ‘List’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:143) [-Wdeprecated-declarations] KUrl::List uris = selectedUrls(); ^ http://build.kde.org/job/kde-baseapps_master_qt5/ws/kfind/kfindtreeview.cpp:509:10: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109) [-Wdeprecated-declarations] QMapKUrl, int folderMaps; ^ In file included from /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/qt5/inst/include/QtGui/qwindowdefs.h:37:0, from /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/qt5/inst/include/QtWidgets/qwidget.h:37, from /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/qt5/inst/include/QtWidgets/qframe.h:37, from /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/qt5/inst/include/QtWidgets/qabstractscrollarea.h:37, from /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/qt5/inst/include/QtWidgets/qabstractitemview.h:37, from /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/qt5/inst/include/QtWidgets/qtreeview.h:37, from /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/qt5/inst/include/QtWidgets/QTreeView:1, from http://build.kde.org/job/kde-baseapps_master_qt5/ws/kfind/kfindtreeview.h:23, from http://build.kde.org/job/kde-baseapps_master_qt5/ws/kfind/kfindtreeview.cpp:20: http://build.kde.org/job/kde-baseapps_master_qt5/ws/kfind/kfindtreeview.cpp:512:29: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109) [-Wdeprecated-declarations] Q_FOREACH( const KUrl url, uris ) ^ http://build.kde.org/job/kde-baseapps_master_qt5/ws/kfind/kfindtreeview.cpp:514:14: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109) [-Wdeprecated-declarations] KUrl dir = url; ^ In file included from
Re: Review Request 122549: Avoid code path that leaves local config files locked
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122549/#review76212 --- bump? - David Edmundson On Feb. 12, 2015, 9:34 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122549/ --- (Updated Feb. 12, 2015, 9:34 p.m.) Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig Description --- The local config file gets locked on line 415, if we return early we need to unlock it otherwise we keep a stray .lock file on the config. We've been getting a lot of lockups in Plasma with stray .lock files so I code reviewed the relevant bit of code to look for any problems. I doubt this is the cause but it seems wrong anyway. Diffs - src/core/kconfig.cpp 782e971 Diff: https://git.reviewboard.kde.org/r/122549/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/#review76186 --- Ship it! src/knotifyconfigelement.h https://git.reviewboard.kde.org/r/122554/#comment52538 whether - Lukáš Tinkl On Úno. 13, 2015, 8:42 odp., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/ --- (Updated Úno. 13, 2015, 8:42 odp.) Review request for KDE Frameworks and Frederik Gladhorn. Repository: knotifyconfig Description --- Change config from KTTS to Speech. If QtSpeech is available when building return true from have_speech static method. Otherwise return false. Could also add a check to see if there are any backend errors later on. Diffs - CMakeLists.txt f5aa0e78d89a4c14c3acfd9384b100e507e30067 src/knotifyconfigactionswidget.h 88b341a909d466b8eaf065c5220ac05f8c963697 src/knotifyconfigactionswidget.cpp 27012e3b803ef0a99d5bafcebea270e2d7419d62 src/knotifyconfigactionswidgetbase.ui cbe647b70eb41ba540b7bf6d87f519b3246973a1 src/knotifyconfigelement.h 703952d23d1622e4b6214acc52461ea75b480254 src/knotifyconfigelement.cpp 5a1ac57fa5a4139682327d14c55a489450ea956b src/knotifyeventlist.cpp 148bca7d33c722a4aeecabac45286a5e501c81b3 Diff: https://git.reviewboard.kde.org/r/122554/diff/ Testing --- It builds, the config widget shows, the icon for speech is properly showing when that configuration is enabled. Speech from konversation's new message notifications are spoken. Something strange here: After enabling this notification, no messages are spoken until restarting the application with the notifications (konversation in my test case). Similarly, after disabling this notification, messages are still spoken until restarting the application. I checked and the konversation.notifyrc file is getting updated, but for some reason the changes aren't taking effect imediately yet. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to stable : plasma-framework_master_qt5 » All,LINBUILDER #1007
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/1007/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122608: Fix QIcon::fromTheme(xxx, someFallback) would not return the fallback
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122608/#review76195 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 17, 2015, 3:51 p.m., Olivier Goffart wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122608/ --- (Updated Feb. 17, 2015, 3:51 p.m.) Review request for KDE Frameworks, David Faure and Kevin Ottens. Repository: kiconthemes Description --- Fix QIcon::fromTheme(xxx, someFallback) would not return the fallback because KIconEngine::availableSize always return something even if the icon is not there BUG: 342906 Diffs - src/kiconengine.cpp 530403e Diff: https://git.reviewboard.kde.org/r/122608/diff/ Testing --- Thanks, Olivier Goffart ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review request: QBluez
Using Q* is usually frowned upon since the Qt people have made it quick clear that they reserve the right to use Q* names themselves, i'd look for a new name. I see. What about renaming it to BluezQt? Also tried to run the tests and qbluez-managertest seems to get stuck forever. Does it take much to run? Does it need that i actually have bluetooth hardware? Tests are running with both real org.bluez (system bus) and fake org.qbluez.bluez (session bus). You don't need to have any bluetooth hardware, nor Bluez installed at all to run the tests. The reason why it hangs is probably that fakebluez cannot, for some reason, start. I have pushed a change that fixes the hang, and also show some info why it cannot start. Can you please send me the output of qbluez-managertest? Thanks, David On Mon, Feb 16, 2015 at 11:51 PM, Albert Astals Cid aa...@kde.org wrote: El Dilluns, 16 de febrer de 2015, a les 10:40:44, David Rosca va escriure: Hi all, I'd like to ask for a review of the QBluez library [1]. Using Q* is usually frowned upon since the Qt people have made it quick clear that they reserve the right to use Q* names themselves, i'd look for a new name. Also tried to run the tests and qbluez-managertest seems to get stuck forever. Does it take much to run? Does it need that i actually have bluetooth hardware? Cheers, Albert QBluez is a Qt 5 wrapper for Bluez 5 DBus API. I have started working on it as a GSoC 2014 project. It is intended to be a libbluedevil replacement, main difference being that every DBus call is made asynchronous. It also exposes more Bluez API than libbluedevil, including Obex API. This library will be used in Bluedevil frameworks branch. I have also written a new Bluetooth plasmoid [2] that uses a QBluez QML plugin. Bellow is a list of some additional QBluez features compared to libbluedevil: * it is a tier 1 framework * asynchronous API using jobs/pending calls with possibility to run synchronously (for tests/cli apps) * extended API - this currently includes API for Obex File Transfer, Obex Object Push and Profile API for implementing Bluetooth profiles * build-time optional QML plugin - currently exposing Manager, Adapter, Device, DevicesModel and PendingCall * possibility to be notified when method call finishes and to be notified about possible errors Currently, there is a qbluez branch in Bluedevil [3]. It will be merged to frameworks branch once QBluez is reviewed. You can find generated documentation here [4]. Thanks, David Rosca [1] http://quickgit.kde.org/?p=scratch%2Fdrosca%2Fqbluez.git [2] https://github.com/nowrep/qbluez-plasmoid [3] https://projects.kde.org/projects/kde/workspace/bluedevil/repository/show?r ev=qbluez [4] http://david.rosca.cz/qbluez-apidoc/html/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Making prison a framework
Hi The KDESupport library, libprison, a bar code rendering abstraction layer could be heading forward for the first release of a qt5, widgets free version. People also suggesting to make it a framework. So please, take a look at kde:prison and let's try to get it reviewed for frameworks /Sune - developer of that thing ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122608: Fix QIcon::fromTheme(xxx, someFallback) would not return the fallback
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122608/ --- (Updated Feb. 17, 2015, 2:51 p.m.) Review request for KDE Frameworks, David Faure and Kevin Ottens. Repository: kiconthemes Description --- Fix QIcon::fromTheme(xxx, someFallback) would not return the fallback because KIconEngine::availableSize always return something even if the icon is not there BUG: 342906 Diffs - src/kiconengine.cpp 530403e Diff: https://git.reviewboard.kde.org/r/122608/diff/ Testing --- Thanks, Olivier Goffart ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122606: Fix startup of kssld5 dbus service
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122606/ --- Review request for KDE Frameworks. Repository: kio Description --- KSslCertificateManager is trying to connect to org.kde.kssld5 directly which doesn't work because it lacks it's own .service dbus file needed for start-on-demand. This patch makes it connect correctly to org.kde.kiod5 (which then loads kssld5 module and makes service available) instead. Diffs - src/core/ksslcertificatemanager.cpp a47ca68 Diff: https://git.reviewboard.kde.org/r/122606/diff/ Testing --- KIO git with patch, tested with Konversation which used to spam SSL errors before applying patch. Thanks, Bartosz Sławianowski ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/#review76184 --- Ship it! i'm not 100% sure on the issue below, apart from that seems fine src/knotifyconfigelement.h https://git.reviewboard.kde.org/r/122554/#comment52536 uuh, this seems not exported, so should be fine to rename i think - Marco Martin On Feb. 13, 2015, 7:42 p.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/ --- (Updated Feb. 13, 2015, 7:42 p.m.) Review request for KDE Frameworks and Frederik Gladhorn. Repository: knotifyconfig Description --- Change config from KTTS to Speech. If QtSpeech is available when building return true from have_speech static method. Otherwise return false. Could also add a check to see if there are any backend errors later on. Diffs - CMakeLists.txt f5aa0e78d89a4c14c3acfd9384b100e507e30067 src/knotifyconfigactionswidget.h 88b341a909d466b8eaf065c5220ac05f8c963697 src/knotifyconfigactionswidget.cpp 27012e3b803ef0a99d5bafcebea270e2d7419d62 src/knotifyconfigactionswidgetbase.ui cbe647b70eb41ba540b7bf6d87f519b3246973a1 src/knotifyconfigelement.h 703952d23d1622e4b6214acc52461ea75b480254 src/knotifyconfigelement.cpp 5a1ac57fa5a4139682327d14c55a489450ea956b src/knotifyeventlist.cpp 148bca7d33c722a4aeecabac45286a5e501c81b3 Diff: https://git.reviewboard.kde.org/r/122554/diff/ Testing --- It builds, the config widget shows, the icon for speech is properly showing when that configuration is enabled. Speech from konversation's new message notifications are spoken. Something strange here: After enabling this notification, no messages are spoken until restarting the application with the notifications (konversation in my test case). Similarly, after disabling this notification, messages are still spoken until restarting the application. I checked and the konversation.notifyrc file is getting updated, but for some reason the changes aren't taking effect imediately yet. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KPeople part of KDE Frameworks
On Tue, Feb 17, 2015 at 7:56 PM, Albert Astals Cid aa...@kde.org wrote: El Divendres, 13 de febrer de 2015, a les 14:25:33, Aleix Pol va escriure: Hi, I would like to submit KPeople for review process so it can join the KF5 family in the next 5.8 release. KPeople is a tier 3 framework (because of KService, which will be dropped eventually, without breaking ABI) and it offers cross-source contact aggregation. More information about it can be read on the README [1]. Your reviews will be welcome. Please fix ./src/widgets/plugins/emaildetailswidget.cpp:50:return i18n(Email); ./src/match.cpp:55:ret += i18n(E-mail); Also add context to make it clear if it's an action or a noun. I think I fixed it now, I also added a couple other i18nc's. Thanks! Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build became unstable: plasma-framework_master_qt5 » All,LINBUILDER #1008
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/1008/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : kdelibs4support_master_qt5 #329
See http://build.kde.org/job/kdelibs4support_master_qt5/329/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KPeople part of KDE Frameworks
El Divendres, 13 de febrer de 2015, a les 14:25:33, Aleix Pol va escriure: Hi, I would like to submit KPeople for review process so it can join the KF5 family in the next 5.8 release. KPeople is a tier 3 framework (because of KService, which will be dropped eventually, without breaking ABI) and it offers cross-source contact aggregation. More information about it can be read on the README [1]. Your reviews will be welcome. Please fix ./src/widgets/plugins/emaildetailswidget.cpp:50:return i18n(Email); ./src/match.cpp:55:ret += i18n(E-mail); Also add context to make it clear if it's an action or a noun. Cheers, Albert Thanks! Aleix [1] https://projects.kde.org/projects/playground/network/kpeople/repository/rev isions/master/entry/README.md ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122183: [KUnitConversion] Currency: Fetch the currency file properly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122183/#review76177 --- src/currency.cpp https://git.reviewboard.kde.org/r/122183/#comment52534 I'm really not sure what to do if we cannot open the file. Abort? Print out an error message? Or just silently ignore it like right now. - Vishesh Handa On Feb. 17, 2015, 11:22 a.m., Vishesh Handa wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122183/ --- (Updated Feb. 17, 2015, 11:22 a.m.) Review request for KDE Frameworks. Bugs: 340819 https://bugs.kde.org/show_bug.cgi?id=340819 Repository: kunitconversion Description --- Currency: Fetch the currency file properly Properly run an event loop and wait for the file to be fetched. Also add a test to make sure currency conversion is working. This patch also contains - * https://git.reviewboard.kde.org/r/122182/ * https://git.reviewboard.kde.org/r/122181/ * https://git.reviewboard.kde.org/r/122180/ This is because reviewboard refuses to upload only a part of the diff. Please only look at currency.cpp w.r.t the EventLoop. Diffs - src/currency.cpp 715233c autotests/convertertest.h 8129a48 autotests/convertertest.cpp ae4298e Diff: https://git.reviewboard.kde.org/r/122183/diff/ Testing --- Test now passes. Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122183: [KUnitConversion] Currency: Fetch the currency file properly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122183/ --- (Updated Feb. 17, 2015, 11:22 a.m.) Review request for KDE Frameworks. Bugs: 340819 https://bugs.kde.org/show_bug.cgi?id=340819 Repository: kunitconversion Description --- Currency: Fetch the currency file properly Properly run an event loop and wait for the file to be fetched. Also add a test to make sure currency conversion is working. This patch also contains - * https://git.reviewboard.kde.org/r/122182/ * https://git.reviewboard.kde.org/r/122181/ * https://git.reviewboard.kde.org/r/122180/ This is because reviewboard refuses to upload only a part of the diff. Please only look at currency.cpp w.r.t the EventLoop. Diffs (updated) - src/currency.cpp 715233c autotests/convertertest.h 8129a48 autotests/convertertest.cpp ae4298e Diff: https://git.reviewboard.kde.org/r/122183/diff/ Testing --- Test now passes. Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122608: Fix QIcon::fromTheme(xxx, someFallback) would not return the fallback
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122608/#review76197 --- Oh, cool. I hope it does not cause a slowdown. Can someone verify if it fixes the KRatingWidget with Oxygen theme when the frameworksintegration plugin is used? See bug 339863. - Christoph Feck On Feb. 17, 2015, 2:51 p.m., Olivier Goffart wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122608/ --- (Updated Feb. 17, 2015, 2:51 p.m.) Review request for KDE Frameworks, David Faure and Kevin Ottens. Repository: kiconthemes Description --- Fix QIcon::fromTheme(xxx, someFallback) would not return the fallback because KIconEngine::availableSize always return something even if the icon is not there BUG: 342906 Diffs - src/kiconengine.cpp 530403e Diff: https://git.reviewboard.kde.org/r/122608/diff/ Testing --- Thanks, Olivier Goffart ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review request: QBluez
El Dimarts, 17 de febrer de 2015, a les 10:36:59, David Rosca va escriure: Using Q* is usually frowned upon since the Qt people have made it quick clear that they reserve the right to use Q* names themselves, i'd look for a new name. I see. What about renaming it to BluezQt? That would work i guess, note it's not only about the project name, but also about the class names. Also tried to run the tests and qbluez-managertest seems to get stuck forever. Does it take much to run? Does it need that i actually have bluetooth hardware? Tests are running with both real org.bluez (system bus) and fake org.qbluez.bluez (session bus). You don't need to have any bluetooth hardware, nor Bluez installed at all to run the tests. The reason why it hangs is probably that fakebluez cannot, for some reason, start. I have pushed a change that fixes the hang, and also show some info why it cannot start. Can you please send me the output of qbluez-managertest? Now it doesnt' fail :D But i get two others to fail 4: Test command: /home/kdeunstable/qbluez/build/autotests/adaptertest 4: Test timeout computed to be: 9.99988e+06 4: * Start testing of AdapterTest * 4: Config: Using QtTest library 5.4.0, Qt 5.4.0 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 4.9.2) 4: QWARN : AdapterTest::initTestCase() QBluez: GetManagerJob Error: Rejected send message, 2 matched rules; type=method_call, sender=:1.171 (uid=1003 pid=11623 comm=/home/kdeunstable/qbluez/build/autotests/adapterte) interface=org.freedesktop.DBus.ObjectManager member=GetManagedObjects error name=(unset) requested_reply=0 destination=org.bluez (uid=0 pid=514 comm=/usr/sbin/bluetoothd ) 4: FAIL! : AdapterTest::initTestCase() '!initJob-error()' returned FALSE. () 4:Loc: [/home/kdeunstable/qbluez/autotests/adaptertest.cpp(71)] 4: PASS : AdapterTest::cleanupTestCase() 4: Totals: 1 passed, 1 failed, 0 skipped, 0 blacklisted 4: * Finished testing of AdapterTest * 4/6 Test #4: qbluez-adaptertest ...***Failed0.01 sec test 5 Start 5: qbluez-devicetest 5: Test command: /home/kdeunstable/qbluez/build/autotests/devicetest 5: Test timeout computed to be: 9.99988e+06 5: * Start testing of DeviceTest * 5: Config: Using QtTest library 5.4.0, Qt 5.4.0 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 4.9.2) 5: QWARN : DeviceTest::initTestCase() QBluez: GetManagerJob Error: Rejected send message, 2 matched rules; type=method_call, sender=:1.172 (uid=1003 pid=11624 comm=/home/kdeunstable/qbluez/build/autotests/devicetes) interface=org.freedesktop.DBus.ObjectManager member=GetManagedObjects error name=(unset) requested_reply=0 destination=org.bluez (uid=0 pid=514 comm=/usr/sbin/bluetoothd ) 5: FAIL! : DeviceTest::initTestCase() '!initJob-error()' returned FALSE. () 5:Loc: [/home/kdeunstable/qbluez/autotests/devicetest.cpp(91)] 5: PASS : DeviceTest::cleanupTestCase() 5: Totals: 1 passed, 1 failed, 0 skipped, 0 blacklisted 5: * Finished testing of DeviceTest * 5/6 Test #5: qbluez-devicetest ***Failed0.01 sec test 6 Start 6: qbluez-jobstest Any idea? Cheers, Albert Thanks, David On Mon, Feb 16, 2015 at 11:51 PM, Albert Astals Cid aa...@kde.org wrote: El Dilluns, 16 de febrer de 2015, a les 10:40:44, David Rosca va escriure: Hi all, I'd like to ask for a review of the QBluez library [1]. Using Q* is usually frowned upon since the Qt people have made it quick clear that they reserve the right to use Q* names themselves, i'd look for a new name. Also tried to run the tests and qbluez-managertest seems to get stuck forever. Does it take much to run? Does it need that i actually have bluetooth hardware? Cheers, Albert QBluez is a Qt 5 wrapper for Bluez 5 DBus API. I have started working on it as a GSoC 2014 project. It is intended to be a libbluedevil replacement, main difference being that every DBus call is made asynchronous. It also exposes more Bluez API than libbluedevil, including Obex API. This library will be used in Bluedevil frameworks branch. I have also written a new Bluetooth plasmoid [2] that uses a QBluez QML plugin. Bellow is a list of some additional QBluez features compared to libbluedevil: * it is a tier 1 framework * asynchronous API using jobs/pending calls with possibility to run synchronously (for tests/cli apps) * extended API - this currently includes API for Obex File Transfer, Obex Object Push and Profile API for implementing Bluetooth profiles * build-time optional QML plugin - currently exposing Manager, Adapter, Device, DevicesModel and PendingCall * possibility to be notified when method call finishes and to be notified about possible errors Currently, there is a qbluez branch in Bluedevil [3]. It will be
Jenkins build is back to normal : kconfig_stable_qt5 #22
See http://build.kde.org/job/kconfig_stable_qt5/22/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review request: QBluez
That would work i guess, note it's not only about the project name, but also about the class names. Sure. But i get two others to fail Any idea? Hmm, I would say that it is actually expected to fail if there is an error when calling GetManagedObjects on org.freedesktop.DBus.ObjectManager. By any chance, are you running Bluez 4? It doesn't have the DBus ObjectManager, so that call should fail like that. David On Tue, Feb 17, 2015 at 10:23 PM, Albert Astals Cid aa...@kde.org wrote: El Dimarts, 17 de febrer de 2015, a les 10:36:59, David Rosca va escriure: Using Q* is usually frowned upon since the Qt people have made it quick clear that they reserve the right to use Q* names themselves, i'd look for a new name. I see. What about renaming it to BluezQt? That would work i guess, note it's not only about the project name, but also about the class names. Also tried to run the tests and qbluez-managertest seems to get stuck forever. Does it take much to run? Does it need that i actually have bluetooth hardware? Tests are running with both real org.bluez (system bus) and fake org.qbluez.bluez (session bus). You don't need to have any bluetooth hardware, nor Bluez installed at all to run the tests. The reason why it hangs is probably that fakebluez cannot, for some reason, start. I have pushed a change that fixes the hang, and also show some info why it cannot start. Can you please send me the output of qbluez-managertest? Now it doesnt' fail :D But i get two others to fail 4: Test command: /home/kdeunstable/qbluez/build/autotests/adaptertest 4: Test timeout computed to be: 9.99988e+06 4: * Start testing of AdapterTest * 4: Config: Using QtTest library 5.4.0, Qt 5.4.0 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 4.9.2) 4: QWARN : AdapterTest::initTestCase() QBluez: GetManagerJob Error: Rejected send message, 2 matched rules; type=method_call, sender=:1.171 (uid=1003 pid=11623 comm=/home/kdeunstable/qbluez/build/autotests/adapterte) interface=org.freedesktop.DBus.ObjectManager member=GetManagedObjects error name=(unset) requested_reply=0 destination=org.bluez (uid=0 pid=514 comm=/usr/sbin/bluetoothd ) 4: FAIL! : AdapterTest::initTestCase() '!initJob-error()' returned FALSE. () 4:Loc: [/home/kdeunstable/qbluez/autotests/adaptertest.cpp(71)] 4: PASS : AdapterTest::cleanupTestCase() 4: Totals: 1 passed, 1 failed, 0 skipped, 0 blacklisted 4: * Finished testing of AdapterTest * 4/6 Test #4: qbluez-adaptertest ...***Failed0.01 sec test 5 Start 5: qbluez-devicetest 5: Test command: /home/kdeunstable/qbluez/build/autotests/devicetest 5: Test timeout computed to be: 9.99988e+06 5: * Start testing of DeviceTest * 5: Config: Using QtTest library 5.4.0, Qt 5.4.0 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 4.9.2) 5: QWARN : DeviceTest::initTestCase() QBluez: GetManagerJob Error: Rejected send message, 2 matched rules; type=method_call, sender=:1.172 (uid=1003 pid=11624 comm=/home/kdeunstable/qbluez/build/autotests/devicetes) interface=org.freedesktop.DBus.ObjectManager member=GetManagedObjects error name=(unset) requested_reply=0 destination=org.bluez (uid=0 pid=514 comm=/usr/sbin/bluetoothd ) 5: FAIL! : DeviceTest::initTestCase() '!initJob-error()' returned FALSE. () 5:Loc: [/home/kdeunstable/qbluez/autotests/devicetest.cpp(91)] 5: PASS : DeviceTest::cleanupTestCase() 5: Totals: 1 passed, 1 failed, 0 skipped, 0 blacklisted 5: * Finished testing of DeviceTest * 5/6 Test #5: qbluez-devicetest ***Failed0.01 sec test 6 Start 6: qbluez-jobstest Any idea? Cheers, Albert Thanks, David On Mon, Feb 16, 2015 at 11:51 PM, Albert Astals Cid aa...@kde.org wrote: El Dilluns, 16 de febrer de 2015, a les 10:40:44, David Rosca va escriure: Hi all, I'd like to ask for a review of the QBluez library [1]. Using Q* is usually frowned upon since the Qt people have made it quick clear that they reserve the right to use Q* names themselves, i'd look for a new name. Also tried to run the tests and qbluez-managertest seems to get stuck forever. Does it take much to run? Does it need that i actually have bluetooth hardware? Cheers, Albert QBluez is a Qt 5 wrapper for Bluez 5 DBus API. I have started working on it as a GSoC 2014 project. It is intended to be a libbluedevil replacement, main difference being that every DBus call is made asynchronous. It also exposes more Bluez API than libbluedevil, including Obex API. This library will be used in Bluedevil frameworks branch. I have also written a new Bluetooth plasmoid [2] that uses a QBluez QML plugin. Bellow is a list of some additional QBluez features compared to libbluedevil: * it is a tier 1 framework * asynchronous API using jobs/pending calls with possibility to
Re: Review Request 121447: Return inode/directory when isDir returns true (kfileitem)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121447/ --- (Updated Feb. 17, 2015, 9:43 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kio Description --- If we know that the item is a dir, return directly the correct mimetype for directories. More info of why this is needed at: https://git.reviewboard.kde.org/r/120909/ Diffs - autotests/kfileitemtest.h 0ee7204 autotests/kfileitemtest.cpp 59c104e src/core/kfileitem.cpp 5894226 Diff: https://git.reviewboard.kde.org/r/121447/diff/ Testing --- Besides tests, tried smb kioslave and it worked great. Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review request: QBluez
El Dimarts, 17 de febrer de 2015, a les 22:39:16, David Rosca va escriure: That would work i guess, note it's not only about the project name, but also about the class names. Sure. But i get two others to fail Any idea? Hmm, I would say that it is actually expected to fail if there is an error when calling GetManagedObjects on org.freedesktop.DBus.ObjectManager. By any chance, are you running Bluez 4? I am. It doesn't have the DBus ObjectManager, so that call should fail like that. Well, then the test should try to detect it and QEXPECT_FAIL, havign tests fail means something is bad, and as you say it's not bad, just expected. Cheers, Albert David On Tue, Feb 17, 2015 at 10:23 PM, Albert Astals Cid aa...@kde.org wrote: El Dimarts, 17 de febrer de 2015, a les 10:36:59, David Rosca va escriure: Using Q* is usually frowned upon since the Qt people have made it quick clear that they reserve the right to use Q* names themselves, i'd look for a new name. I see. What about renaming it to BluezQt? That would work i guess, note it's not only about the project name, but also about the class names. Also tried to run the tests and qbluez-managertest seems to get stuck forever. Does it take much to run? Does it need that i actually have bluetooth hardware? Tests are running with both real org.bluez (system bus) and fake org.qbluez.bluez (session bus). You don't need to have any bluetooth hardware, nor Bluez installed at all to run the tests. The reason why it hangs is probably that fakebluez cannot, for some reason, start. I have pushed a change that fixes the hang, and also show some info why it cannot start. Can you please send me the output of qbluez-managertest? Now it doesnt' fail :D But i get two others to fail 4: Test command: /home/kdeunstable/qbluez/build/autotests/adaptertest 4: Test timeout computed to be: 9.99988e+06 4: * Start testing of AdapterTest * 4: Config: Using QtTest library 5.4.0, Qt 5.4.0 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 4.9.2) 4: QWARN : AdapterTest::initTestCase() QBluez: GetManagerJob Error: Rejected send message, 2 matched rules; type=method_call, sender=:1.171 (uid=1003 pid=11623 comm=/home/kdeunstable/qbluez/build/autotests/adapterte) interface=org.freedesktop.DBus.ObjectManager member=GetManagedObjects error name=(unset) requested_reply=0 destination=org.bluez (uid=0 pid=514 comm=/usr/sbin/bluetoothd ) 4: FAIL! : AdapterTest::initTestCase() '!initJob-error()' returned FALSE. () 4:Loc: [/home/kdeunstable/qbluez/autotests/adaptertest.cpp(71)] 4: PASS : AdapterTest::cleanupTestCase() 4: Totals: 1 passed, 1 failed, 0 skipped, 0 blacklisted 4: * Finished testing of AdapterTest * 4/6 Test #4: qbluez-adaptertest ...***Failed0.01 sec test 5 Start 5: qbluez-devicetest 5: Test command: /home/kdeunstable/qbluez/build/autotests/devicetest 5: Test timeout computed to be: 9.99988e+06 5: * Start testing of DeviceTest * 5: Config: Using QtTest library 5.4.0, Qt 5.4.0 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 4.9.2) 5: QWARN : DeviceTest::initTestCase() QBluez: GetManagerJob Error: Rejected send message, 2 matched rules; type=method_call, sender=:1.172 (uid=1003 pid=11624 comm=/home/kdeunstable/qbluez/build/autotests/devicetes) interface=org.freedesktop.DBus.ObjectManager member=GetManagedObjects error name=(unset) requested_reply=0 destination=org.bluez (uid=0 pid=514 comm=/usr/sbin/bluetoothd ) 5: FAIL! : DeviceTest::initTestCase() '!initJob-error()' returned FALSE. () 5:Loc: [/home/kdeunstable/qbluez/autotests/devicetest.cpp(91)] 5: PASS : DeviceTest::cleanupTestCase() 5: Totals: 1 passed, 1 failed, 0 skipped, 0 blacklisted 5: * Finished testing of DeviceTest * 5/6 Test #5: qbluez-devicetest ***Failed0.01 sec test 6 Start 6: qbluez-jobstest Any idea? Cheers, Albert Thanks, David On Mon, Feb 16, 2015 at 11:51 PM, Albert Astals Cid aa...@kde.org wrote: El Dilluns, 16 de febrer de 2015, a les 10:40:44, David Rosca va escriure: Hi all, I'd like to ask for a review of the QBluez library [1]. Using Q* is usually frowned upon since the Qt people have made it quick clear that they reserve the right to use Q* names themselves, i'd look for a new name. Also tried to run the tests and qbluez-managertest seems to get stuck forever. Does it take much to run? Does it need that i actually have bluetooth hardware? Cheers, Albert QBluez is a Qt 5 wrapper for Bluez 5 DBus API. I have started working on it as a GSoC 2014 project. It is intended to be a libbluedevil replacement, main difference being that every DBus call is made asynchronous. It
Re: Review request: QBluez
Well, then the test should try to detect it and QEXPECT_FAIL, havign tests fail means something is bad, and as you say it's not bad, just expected. I meant it's expected to fail in the case that something goes wrong when initializing Manager. And that is, for example, the case with running Bluez 4 instead of Bluez 5. The problem is that there are some tests that are running on the real Bluez daemon and those tests obviously requires Bluez 5. They won't fail when there is no org.bluez on system bus, but they will actually fail when there is org.bluez but provided by Bluez 4. I will modify those tests to be skipped if Bluez 4 is detected. David On Tue, Feb 17, 2015 at 11:00 PM, Albert Astals Cid aa...@kde.org wrote: El Dimarts, 17 de febrer de 2015, a les 22:39:16, David Rosca va escriure: That would work i guess, note it's not only about the project name, but also about the class names. Sure. But i get two others to fail Any idea? Hmm, I would say that it is actually expected to fail if there is an error when calling GetManagedObjects on org.freedesktop.DBus.ObjectManager. By any chance, are you running Bluez 4? I am. It doesn't have the DBus ObjectManager, so that call should fail like that. Well, then the test should try to detect it and QEXPECT_FAIL, havign tests fail means something is bad, and as you say it's not bad, just expected. Cheers, Albert David On Tue, Feb 17, 2015 at 10:23 PM, Albert Astals Cid aa...@kde.org wrote: El Dimarts, 17 de febrer de 2015, a les 10:36:59, David Rosca va escriure: Using Q* is usually frowned upon since the Qt people have made it quick clear that they reserve the right to use Q* names themselves, i'd look for a new name. I see. What about renaming it to BluezQt? That would work i guess, note it's not only about the project name, but also about the class names. Also tried to run the tests and qbluez-managertest seems to get stuck forever. Does it take much to run? Does it need that i actually have bluetooth hardware? Tests are running with both real org.bluez (system bus) and fake org.qbluez.bluez (session bus). You don't need to have any bluetooth hardware, nor Bluez installed at all to run the tests. The reason why it hangs is probably that fakebluez cannot, for some reason, start. I have pushed a change that fixes the hang, and also show some info why it cannot start. Can you please send me the output of qbluez-managertest? Now it doesnt' fail :D But i get two others to fail 4: Test command: /home/kdeunstable/qbluez/build/autotests/adaptertest 4: Test timeout computed to be: 9.99988e+06 4: * Start testing of AdapterTest * 4: Config: Using QtTest library 5.4.0, Qt 5.4.0 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 4.9.2) 4: QWARN : AdapterTest::initTestCase() QBluez: GetManagerJob Error: Rejected send message, 2 matched rules; type=method_call, sender=:1.171 (uid=1003 pid=11623 comm=/home/kdeunstable/qbluez/build/autotests/adapterte) interface=org.freedesktop.DBus.ObjectManager member=GetManagedObjects error name=(unset) requested_reply=0 destination=org.bluez (uid=0 pid=514 comm=/usr/sbin/bluetoothd ) 4: FAIL! : AdapterTest::initTestCase() '!initJob-error()' returned FALSE. () 4:Loc: [/home/kdeunstable/qbluez/autotests/adaptertest.cpp(71)] 4: PASS : AdapterTest::cleanupTestCase() 4: Totals: 1 passed, 1 failed, 0 skipped, 0 blacklisted 4: * Finished testing of AdapterTest * 4/6 Test #4: qbluez-adaptertest ...***Failed0.01 sec test 5 Start 5: qbluez-devicetest 5: Test command: /home/kdeunstable/qbluez/build/autotests/devicetest 5: Test timeout computed to be: 9.99988e+06 5: * Start testing of DeviceTest * 5: Config: Using QtTest library 5.4.0, Qt 5.4.0 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 4.9.2) 5: QWARN : DeviceTest::initTestCase() QBluez: GetManagerJob Error: Rejected send message, 2 matched rules; type=method_call, sender=:1.172 (uid=1003 pid=11624 comm=/home/kdeunstable/qbluez/build/autotests/devicetes) interface=org.freedesktop.DBus.ObjectManager member=GetManagedObjects error name=(unset) requested_reply=0 destination=org.bluez (uid=0 pid=514 comm=/usr/sbin/bluetoothd ) 5: FAIL! : DeviceTest::initTestCase() '!initJob-error()' returned FALSE. () 5:Loc: [/home/kdeunstable/qbluez/autotests/devicetest.cpp(91)] 5: PASS : DeviceTest::cleanupTestCase() 5: Totals: 1 passed, 1 failed, 0 skipped, 0 blacklisted 5: * Finished testing of DeviceTest * 5/6 Test #5: qbluez-devicetest ***Failed0.01 sec test 6 Start 6: qbluez-jobstest Any idea? Cheers, Albert Thanks, David On Mon, Feb 16, 2015 at 11:51 PM, Albert Astals Cid aa...@kde.org wrote: El Dilluns, 16 de febrer de 2015, a les
Jenkins build is back to stable : plasma-framework_master_qt5 » All,LINBUILDER #1009
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/1009/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122613: Do not add an extra slash if item does not have a host (KUrlComboBoxPrivate::textForItem)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122613/ --- Review request for KDE Frameworks. Repository: kio Description --- The rest of kio internally is doing this correctly apparently it was only a problem in the GUI part of it. Diffs - autotests/CMakeLists.txt f613c1a autotests/kurlcomboboxtest.h PRE-CREATION autotests/kurlcomboboxtest.cpp PRE-CREATION src/widgets/kurlcombobox.cpp ed5b8a2 Diff: https://git.reviewboard.kde.org/r/122613/diff/ Testing --- Besides the added unit tests, I have used this patch while running a few ups, everything seems to work great. Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: kio and scheme://
Review request to fix this!
https://git.reviewboard.kde.org/r/122613/
Thanks for the support guys!
On Sun, Nov 2, 2014 at 1:43 PM, Àlex Fiestas afies...@kde.org wrote:
Hi there
There are quite a few places where the following code is found:
if (!url.path().endsWith('/')) {
url.setPath(url.path() + '/');
}
Given an url like: 'scheme://' KUrl will return '/' as path while QUrl
returns
empty string.
This is making kio add a third slash to the url in many places (because of
code like the one pasted before).
As a result if you open dolphin and type smb://, it will be redirected to
smb:///.
Is this an intended behavior or should I start sending patches to prevent
this
from happening?
Also, even though technically the path of 'smb://' is empty, users are
used to
that format (specially given how popular htp:// is) so I would like to keep
supporting it.
Cheers!
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122604: Do not require KSelectionWatcher and KSelectionOwner to be on platform xcb
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122604/ --- Review request for KDE Frameworks. Repository: kwindowsystem Description --- Adding dedicated constructor overloads taking the xcb_connection_t* and the root window. If these overloads are used it is not verified that platform xcb is used and QX11Info is not used. The other overloads still verify that platform is xcb and depend on QX11Info. Diffs - src/kselectionowner.h b5d358a0564b41d539cfc12d9a98f3719934b88d src/kselectionowner.cpp 90a0004046135e7fee61fe2ef865b75eb421ea99 src/kselectionwatcher.h f3b15a08a7fb15f91ce4b41cf2985a1047905e4a src/kselectionwatcher.cpp 2539fca83e2b737e50ef43c9b184f2ab566731a5 Diff: https://git.reviewboard.kde.org/r/122604/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #1006
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
