Re: cmake CMP0028 & missing targets - what does one do about it?

[Harald Sitter]

On Wed, Apr 1, 2015 at 10:41 PM, Alex Merry  wrote:
> On Wednesday 01 April 2015 21:39:45 Alex Merry wrote:
>> This appears to be a regression with the 3.0 branch of CMake. 2.8.12 doesn't
>> have an issue, and neither does 3.1.3.
>
> For reference: http://www.cmake.org/Bug/view.php?id=15101

Uh, thanks for looking into it. Somewhat sad, we have no better
solution than moving up find_package calls, but oh well.

HS
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Syncing ECM release number with KF5

[Stephen Kelly]

> I have no particular objection,

So, what needs to be done to get this synced up? Bump the version in
the CMakeLists.txt and update some release-tarball-creating script?
David I guess the latter is for you?

Thanks,

Steve.


On Fri, Mar 27, 2015 at 7:49 PM, Michael Palimaka  wrote:
> On 28/03/15 03:48, Alex Merry wrote:
>> On Wednesday 25 March 2015 22:35:24 Stephen Kelly wrote:
>>> Hello,
>>>
>>> ECM release numbers are in sync with KF5 release numbers, except for the
>>> major component.
>>>
>>> This means that if you want to build the 5.x.y release you have to download
>>> the 1.x.y release of ECM. That doubles the complexity of your script which
>>> downloads the tarball to build it.
>>>
>>> That is bad and it is not necessary.
>>>
>>> Let's sync the major number for the next release.
>>>
>>> At some point the reason to make them out of sync was to be able to make ECM
>>> releases more frequently. That is very rare because KF5 releases are
>>> happening every month. If ECM needs to make an out of band release, it can
>>> use the 4th version number component.
>>
>> I have no particular objection, although I think "doubling the complexity" of
>> scripts is overstating things a little.
>>
>> Alex
>
> Is ECM actually part of KF5, or just happens to be released alongside
> it? (I thought the latter, hence the different version).
>
> FWIW the different version doesn't bother me at all as a downstream.
>
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 123223: [Preliminary] Fix bug 344614: kservice splits filename wrong

[Gregor Mi]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123223/
---

Review request for KDE Frameworks.


Repository: kservice


Description
---

Patch for https://bugs.kde.org/show_bug.cgi?id=344614.

There is one issue: I would like to move the implementation of the new method 
KServicePrivate::entryPathToName from the .h to .cpp file but I get at link 
time: " .../autotests/kservicetest.cpp:824: undefined reference to 
'KServicePrivate::entryPathToName(QString const&)'" Is it generally possible to 
unit test methods delcared *Private classes?


Diffs
-

  autotests/kservicetest.h 929cd9fefe22308909e44650e8e4bfb2456fd534 
  autotests/kservicetest.cpp d46f868185c3bf45138d80d04f4eb0d2840de9ca 
  src/services/kservice.cpp 8c4e1a180a7628872d6f62486db9aee4b858547f 
  src/services/kservice_p.h 9a5a31caadc7487f8daf898eff062b2855800313 

Diff: https://git.reviewboard.kde.org/r/123223/diff/


Testing
---

1. new unit test succeeds
2. all other unit tests in ./kservicetest sill succeed
3. Call `kbuildsycoca5 --noincremental` without and with the patch and try out 
dolphin's Space Info menu. In the first case filelight is not found. With the 
patch filelight is found.


Thanks,

Gregor Mi

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123223: [Preliminary] Fix bug 344614: kservice splits filename wrong

[Gregor Mi]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123223/
---

(Updated April 2, 2015, 11:55 a.m.)


Review request for KDE Frameworks.


Repository: kservice


Description (updated)
---

Patch for https://bugs.kde.org/show_bug.cgi?id=344614.

The difference between the old and new code (which is moved to a separated 
method in the .h file) is: name.indexOf is replaced by name.lastIndexOf

There is one issue: I would like to move the implementation of the new method 
KServicePrivate::entryPathToName from the .h to .cpp file but I get at link 
time: " .../autotests/kservicetest.cpp:824: undefined reference to 
'KServicePrivate::entryPathToName(QString const&)'" Is it generally possible to 
unit test methods delcared *Private classes?


Diffs
-

  autotests/kservicetest.h 929cd9fefe22308909e44650e8e4bfb2456fd534 
  autotests/kservicetest.cpp d46f868185c3bf45138d80d04f4eb0d2840de9ca 
  src/services/kservice.cpp 8c4e1a180a7628872d6f62486db9aee4b858547f 
  src/services/kservice_p.h 9a5a31caadc7487f8daf898eff062b2855800313 

Diff: https://git.reviewboard.kde.org/r/123223/diff/


Testing
---

1. new unit test succeeds
2. all other unit tests in ./kservicetest sill succeed
3. Call `kbuildsycoca5 --noincremental` without and with the patch and try out 
dolphin's Space Info menu. In the first case filelight is not found. With the 
patch filelight is found.


Thanks,

Gregor Mi

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Syncing ECM release number with KF5

[Michael Palimaka]

On 02/04/15 21:29, Stephen Kelly wrote:
>> I have no particular objection,
> 
> So, what needs to be done to get this synced up? Bump the version in
> the CMakeLists.txt and update some release-tarball-creating script?
> David I guess the latter is for you?
> 
> Thanks,
> 
> Steve.

Can we at least find out why the versioning was different in the first
place. It would be nice to know the reason before we change anything.

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123095: ksnapshot: load kipi-plugins

[Gregor Mi]

> On March 30, 2015, 9:33 p.m., Gilles Caulier wrote:
> > yes. libkipi is fully ported to KF5.
> > Kipi-plugins is partially ported (only 6 tools). It's enough to test.
> > 
> > https://techbase.kde.org/Projects/Digikam/CodingSprint2014

I explicitly did `./kdesrc-build libkipi libkexiv2 libkdcraw kipi-plugins 
gwenview ksnapshot` and now it works. Thanks for giving input. I close this RR. 
(I wonder though since when the 6 tools were ported because the last months I 
tried every once a while...)


- Gregor


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123095/#review78259
---


On March 30, 2015, 9:22 p.m., Gregor Mi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123095/
> ---
> 
> (Updated March 30, 2015, 9:22 p.m.)
> 
> 
> Review request for KDE Frameworks, KDE Graphics, KSnapshot, and Gilles 
> Caulier.
> 
> 
> Repository: ksnapshot
> 
> 
> Description
> ---
> 
> Currently the list of kipi-plugins loaded by ksnapshot is empty. This RR adds 
> some comments to help with debugging.
> 
> The first question to be answered would be if the current ksnapshot code is 
> supposed to work or if the issue of the empty list is to be solved somewhere 
> else.
> 
> 
> Diffs
> -
> 
>   ksnapshotsendtoactions.cpp a8c4ccbb72cee3bef486af417aa637c3f41de48d 
> 
> Diff: https://git.reviewboard.kde.org/r/123095/diff/
> 
> 
> Testing
> ---
> 
> Run ksnapshot, click the SendTo... button and see debug output:
> 
> m_pluginLoader->init()
> KIPI_FOUND...
> m_pluginLoader->loadPlugins();
> ... pluginList.count() 0
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123095: ksnapshot: load kipi-plugins

[Gregor Mi]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123095/
---

(Updated April 2, 2015, 12:41 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks, KDE Graphics, KSnapshot, and Gilles Caulier.


Repository: ksnapshot


Description
---

Currently the list of kipi-plugins loaded by ksnapshot is empty. This RR adds 
some comments to help with debugging.

The first question to be answered would be if the current ksnapshot code is 
supposed to work or if the issue of the empty list is to be solved somewhere 
else.


Diffs
-

  ksnapshotsendtoactions.cpp a8c4ccbb72cee3bef486af417aa637c3f41de48d 

Diff: https://git.reviewboard.kde.org/r/123095/diff/


Testing
---

Run ksnapshot, click the SendTo... button and see debug output:

m_pluginLoader->init()
KIPI_FOUND...
m_pluginLoader->loadPlugins();
... pluginList.count() 0


Thanks,

Gregor Mi

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

[Gregor Mi]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122981/#review78410
---


I finally managed to make most the master unit tests pass:

* Start testing of KGlobalShortcutTest *
Config: Using QtTest library 5.4.2, Qt 5.4.2 (x86_64-little_endian-lp64 shared 
(dynamic) release build; by GCC 4.8.3 20140627 [gcc-4_8-branch revision 212064])
PASS   : KGlobalShortcutTest::initTestCase()
PASS   : KGlobalShortcutTest::testSetShortcut()
QDEBUG : KGlobalShortcutTest::testActivateShortcut() kf5.kiconthemes: "Theme 
tree: (Oxygen)"
FAIL!  : KGlobalShortcutTest::testActivateShortcut() 'actionASpy.wait()' 
returned FALSE. ()
   Loc: 
[/home/gregor/dev/kf5/src/frameworks/kglobalaccel/autotests/kglobalshortcuttest.cpp(172)]
PASS   : KGlobalShortcutTest::testFindActionByKey()
PASS   : KGlobalShortcutTest::testChangeShortcut()
PASS   : KGlobalShortcutTest::testStealShortcut()
PASS   : KGlobalShortcutTest::testSaveRestore()
PASS   : KGlobalShortcutTest::testListActions()
PASS   : KGlobalShortcutTest::testComponentAssignment()
PASS   : KGlobalShortcutTest::testConfigurationActions()
PASS   : KGlobalShortcutTest::testNotification()
PASS   : KGlobalShortcutTest::testOverrideMainComponentData()
FAIL!  : KGlobalShortcutTest::testForgetGlobalShortcut() 
'!components.contains(componentId)' returned FALSE. ()
   Loc: 
[/home/gregor/dev/kf5/src/frameworks/kglobalaccel/autotests/kglobalshortcuttest.cpp(481)]
PASS   : KGlobalShortcutTest::testLoadShortcutFromGlobalSettings()
PASS   : KGlobalShortcutTest::cleanupTestCase()
Totals: 13 passed, 2 failed, 0 skipped, 0 blacklisted
* Finished testing of KGlobalShortcutTest *


I did this by altering the test QKeySequences to:

const QKeySequence sequenceA = QKeySequence(Qt::SHIFT + Qt::META + Qt::CTRL + 
Qt::ALT + Qt::Key_F11);
const QKeySequence sequenceB = QKeySequence(Qt::Key_F26);
const QKeySequence sequenceC = QKeySequence(Qt::SHIFT + Qt::META + Qt::CTRL + 
Qt::Key_F26);
const QKeySequence sequenceD = QKeySequence(Qt::META + Qt::ALT + Qt::Key_F25);
const QKeySequence sequenceE = QKeySequence(Qt::META + Qt::Key_F24);
const QKeySequence sequenceF = QKeySequence(Qt::META + Qt::Key_F23);

and by replacing the component id "qttest" by "qt-test-1".

The problem is, I cannot go back to the original test code because it will fail 
because of old registered keyboard shortcuts.

I tried to reset my runtime settings manually by doing:

1)
* delete ~/.qttest/
* delete ~/.cache5
* delete ~/.config5/
* delete ~/.local5/

2)
I know the wrong actual string "testLoadShortcutFromGlobalSettings" because I 
added it in another branch to the test case but I am on master now.
I did a `find . -type f -size -900k | grep testLoadShortcutFromGlobalSettings` 
on my home directory which finds no result.
But somewhere this string must be stored. Any idea where?

3)
I used QDbusViewer to to query the method 
org.kde.kglobalaccel.getGlobalShortcutsByKey (where 16777292 is the number of 
the key):

Received reply from :1.15
  Arguments: [Argument: a(ssaiai) {[Argument: (ssaiai) "Action 
A:testLoadShortcutFromGlobalSettings", "Text For Action A", "qttest", "KDE Test 
Program 1", "default", "Default Context", [Argument: ai {0, 16777292}], 
[Argument: ai {520093771}]]}]

There is the wrong "Action A:testLoadShortcutFromGlobalSettings" again.

So the question is: How can I unregister the value retrieved by the method 
"getGlobalShortcutsByKey"? This would also fix the unit tests.

- Gregor Mi


On March 22, 2015, 4:05 p.m., Gregor Mi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122981/
> ---
> 
> (Updated March 22, 2015, 4:05 p.m.)
> 
> 
> Review request for KDE Frameworks, Martin Gräßlin and Thomas Lübking.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> ---
> 
> In some cases you need to call loadShortcutFromGlobalSettings() in order not 
> to get a an empty list when calling shortcut(). See discussion in 
> https://git.reviewboard.kde.org/r/122249/.
> 
> 
> Diffs
> -
> 
>   autotests/kglobalshortcuttest.h 2a7b40d34875e16345a659fb9764e4f536ad79c6 
>   autotests/kglobalshortcuttest.cpp 169bf92ffbff985cd4381e771c2fcecaff77156b 
>   src/kglobalaccel.h 3fe20ca8e4ec6ceb0bb9e54235aef7f1aeeb8c16 
>   src/kglobalaccel.cpp 1b6b3f5cb6d42401d684e6a491d12a6e57248fd1 
> 
> Diff: https://git.reviewboard.kde.org/r/122981/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

[Gregor Mi]

> On March 22, 2015, 3:56 p.m., Albert Astals Cid wrote:
> > src/kglobalaccel.h, line 260
> > 
> >
> > typo in following
> 
> Gregor Mi wrote:
> About why it is needed: see 
> KGlobalShortcutTest::testLoadShortcutFromGlobalSettings: shortcut() does not 
> behave as expected when the new method loadShortcutFromGlobalSettings() is 
> not called
> 
> I don't know if always calling loadShortcutFromGlobalSettings() before 
> shortcut() would break existing code. E.g. in 
> kwin/effects/desktopgrid/desktopgrid_config.cpp shortcut() is used without 
> prior call of loadShortcutFromGlobalSettings().
> 
> On the other hand, a call to loadShortcutFromGlobalSettings() might be 
> harmless but I don't have a good overview of the KGlobalAccel usage patterns.
> 
> Albert Astals Cid wrote:
> Honestly i have no idea on how this kglobalaccel thing works, but it 
> seems to me you're just adding a way to workaround a bug instead of fixing it.
> 
> Gregor Mi wrote:
> Me neither :-)
> 
> I was hoping that someone with more experience with kglobalaccel can say 
> more about the proposed solution.
> 
> Like you Thomas suggested to put the loading method into shortcut() 
> (which is essentially a one-liner: d->updateGlobalShortcut(action, 
> KGlobalAccelPrivate::ActiveShortcut, KGlobalAccel::Autoloading);).
> 
> Martin Gräßlin wrote:
> well we could try it: add the one-line change and try whether the unit 
> tests pass and then try whether the case in DesktopGridConfig works.
> 
> Unfortunately I'm also not that into KGloalAccel code yet to be 100 % 
> whether it's a valid change :-(

I tried to call loadShortcutFromGlobalSettings() from within shortcut() and 
found that this violates const constraints:

shortcut() is const
d->updateGlobalShortcut is not const

So this is not possible.

How to proceed now?


- Gregor


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122981/#review77912
---


On March 22, 2015, 4:05 p.m., Gregor Mi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122981/
> ---
> 
> (Updated March 22, 2015, 4:05 p.m.)
> 
> 
> Review request for KDE Frameworks, Martin Gräßlin and Thomas Lübking.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> ---
> 
> In some cases you need to call loadShortcutFromGlobalSettings() in order not 
> to get a an empty list when calling shortcut(). See discussion in 
> https://git.reviewboard.kde.org/r/122249/.
> 
> 
> Diffs
> -
> 
>   autotests/kglobalshortcuttest.h 2a7b40d34875e16345a659fb9764e4f536ad79c6 
>   autotests/kglobalshortcuttest.cpp 169bf92ffbff985cd4381e771c2fcecaff77156b 
>   src/kglobalaccel.h 3fe20ca8e4ec6ceb0bb9e54235aef7f1aeeb8c16 
>   src/kglobalaccel.cpp 1b6b3f5cb6d42401d684e6a491d12a6e57248fd1 
> 
> Diff: https://git.reviewboard.kde.org/r/122981/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

[Gregor Mi]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122981/
---

(Updated April 2, 2015, 2:56 p.m.)


Review request for KDE Frameworks, Martin Gräßlin and Thomas Lübking.


Changes
---

update description


Repository: kglobalaccel


Description (updated)
---

In some cases you need to call loadShortcutFromGlobalSettings() in order not to 
get a an empty list when calling shortcut() (which is const).

See discussion in https://git.reviewboard.kde.org/r/122249/ ("libksysguard: add 
Kill Window to End Process button and show correct keyboard shortcut").


Diffs
-

  autotests/kglobalshortcuttest.h 2a7b40d34875e16345a659fb9764e4f536ad79c6 
  autotests/kglobalshortcuttest.cpp 169bf92ffbff985cd4381e771c2fcecaff77156b 
  src/kglobalaccel.h 3fe20ca8e4ec6ceb0bb9e54235aef7f1aeeb8c16 
  src/kglobalaccel.cpp 1b6b3f5cb6d42401d684e6a491d12a6e57248fd1 

Diff: https://git.reviewboard.kde.org/r/122981/diff/


Testing
---


Thanks,

Gregor Mi

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123229/
---

Review request for KDE Frameworks.


Repository: kio


Description
---

Prevents the UiDelegate and UiTracker to get initialized, because they'll try 
to create windows and dialogs when some things happen and these will 
immediately end in a crash.


Diffs
-

  src/widgets/jobuidelegate.cpp 7df289f 
  src/widgets/kdynamicjobtracker.cpp 9bc4a4e 

Diff: https://git.reviewboard.kde.org/r/123229/diff/


Testing
---

Ran the tests, my unit test doesn't crash anymore.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122910: Introduce KMoreTools

[Gregor Mi]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122910/
---

(Updated April 2, 2015, 4:48 p.m.)


Review request for KDE Frameworks and Jeremy Whiting.


Changes
---

- make ConfigureDialogAccessible_Always default
- minor fixes and comments


Repository: knewstuff


Description
---

Moved from kservice (https://git.reviewboard.kde.org/r/122576/) to here 
(knewstuff).

Example usages:
- dolphin's SpaceInfoToolsMenu: https://git.reviewboard.kde.org/r/122911/
- kate's project addin: https://git.reviewboard.kde.org/r/122374/


Diffs (updated)
-

  docs/pics/kmoretools-kate-project-1-all-installed.png PRE-CREATION 
  docs/pics/kmoretools-kate-project-2-two-not-installed.png PRE-CREATION 
  docs/pics/kmoretools-kate-project-3-config-dialog-all-installed.png 
PRE-CREATION 
  src/CMakeLists.txt 3b9a403eb473e0c3760506b2757c71d603b99775 
  src/kmoretools/kmoretools.h PRE-CREATION 
  src/kmoretools/kmoretools.cpp PRE-CREATION 
  src/kmoretools/kmoretools_p.h PRE-CREATION 
  src/kmoretools/kmoretoolsconfigdialog_p.h PRE-CREATION 
  src/kmoretools/kmoretoolsconfigdialog_p.cpp PRE-CREATION 
  src/kmoretools/ui/kmoretoolsconfigwidget.ui PRE-CREATION 
  tests/CMakeLists.txt 103c5fc98deaf83288b843cc66a87f2d95ad9dfb 
  tests/kmoretools/1/a.desktop PRE-CREATION 
  tests/kmoretools/1/b.desktop PRE-CREATION 
  tests/kmoretools/1/c.desktop PRE-CREATION 
  tests/kmoretools/2/kate.desktop PRE-CREATION 
  tests/kmoretools/2/kate.png PRE-CREATION 
  tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION 
  tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION 
  tests/kmoretools/2/mynotinstapp2.desktop PRE-CREATION 
  tests/kmoretools/kmoretoolstest.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/122910/diff/


Testing
---


Thanks,

Gregor Mi

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123223: [Preliminary] Fix bug 344614: kservice splits filename wrong

[Dominik Haumann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123223/#review78424
---


Good catch, maybe we can use QFileInfo::completeBaseName() instead?


src/services/kservice.cpp (line 149)


I wonder whether QFileInfo(entryPath).completeBaseName() does exactly the 
same as entryPathToName(entryPath) ?

See: http://doc.qt.io/qt-5/qfileinfo.html#completeBaseName


- Dominik Haumann


On April 2, 2015, 11:55 a.m., Gregor Mi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123223/
> ---
> 
> (Updated April 2, 2015, 11:55 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> Patch for https://bugs.kde.org/show_bug.cgi?id=344614.
> 
> The difference between the old and new code (which is moved to a separated 
> method in the .h file) is: name.indexOf is replaced by name.lastIndexOf
> 
> There is one issue: I would like to move the implementation of the new method 
> KServicePrivate::entryPathToName from the .h to .cpp file but I get at link 
> time: " .../autotests/kservicetest.cpp:824: undefined reference to 
> 'KServicePrivate::entryPathToName(QString const&)'" Is it generally possible 
> to unit test methods delcared *Private classes?
> 
> 
> Diffs
> -
> 
>   autotests/kservicetest.h 929cd9fefe22308909e44650e8e4bfb2456fd534 
>   autotests/kservicetest.cpp d46f868185c3bf45138d80d04f4eb0d2840de9ca 
>   src/services/kservice.cpp 8c4e1a180a7628872d6f62486db9aee4b858547f 
>   src/services/kservice_p.h 9a5a31caadc7487f8daf898eff062b2855800313 
> 
> Diff: https://git.reviewboard.kde.org/r/123223/diff/
> 
> 
> Testing
> ---
> 
> 1. new unit test succeeds
> 2. all other unit tests in ./kservicetest sill succeed
> 3. Call `kbuildsycoca5 --noincremental` without and with the patch and try 
> out dolphin's Space Info menu. In the first case filelight is not found. With 
> the patch filelight is found.
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel