Re: Review Request 123669: Add KPluginLoader::findPluginsById convenience API

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123669/#review80001
---


+1 seems sensible.


autotests/kpluginloadertest.cpp (line 357)


not that it really matters, but invalid is spelt wrong.
Double the invalidity.


- David Edmundson


On May 6, 2015, 11:21 p.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123669/
> ---
> 
> (Updated May 6, 2015, 11:21 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Richardson and David Faure.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Add findPluginsById convenience API
> 
> It's a quite common case to load a plugin from an ID. This makes it
> easy.
> 
> CHANGELOG:New KPluginLoader::findPluginById() convenience API
> REVIEW:123669
> 
> 
> Diffs
> -
> 
>   autotests/kpluginloadertest.cpp 3ded0ebca2e0fd20e09bf6e4eca152d13ac11f46 
>   src/lib/plugin/kpluginloader.h 124bfab7e207b17d3c8ab4d5a88321af476aad42 
>   src/lib/plugin/kpluginloader.cpp 4310d6cd7792329511f12b28d7c68b0fdd013538 
> 
> Diff: https://git.reviewboard.kde.org/r/123669/diff/
> 
> 
> Testing
> ---
> 
> Added autotests, everything passes.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123626: port libplasma away from sycoca as much as possible

[Sebastian Kügler]

> On May 6, 2015, 10:54 p.m., Sebastian Kügler wrote:
> > I've read and tested it, everything still works nicely. Good job!
> > 
> > I like how the patch moves much of the query language into simple C++, 
> > avoids a lot of query parsing and moves some of the error paths to compile 
> > time.

https://git.reviewboard.kde.org/r/123669/

This moves the filtering by id, which is quite common, into KPluginLoader to 
save us a bit of churn.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123626/#review7
---


On May 6, 2015, 5:21 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123626/
> ---
> 
> (Updated May 6, 2015, 5:21 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> this ports most of libplasma away from sycoca, using instead a combination of 
> KPluginLoader and KPackage::PackageLoader instead (so eventually using their 
> own little caches instead of the global sycoca cache)
> a kservicetypetrader call is left in the loading of containmentactions since 
> is the only way to make an older workspace still work, but is only a 
> fallback, so containmentactions in plasma-workspace can be ported eventually 
> as well
> 
> 
> Diffs
> -
> 
>   KF5PlasmaConfig.cmake.in dee79ca 
>   src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml 
> be76a43 
>   src/plasma/applet.cpp 2dda381 
>   src/plasma/containment.cpp 7eabbb8 
>   src/plasma/containmentactions.cpp f24bdac 
>   src/plasma/dataengine.cpp 4b3d671 
>   src/plasma/package.cpp 4e0be88 
>   src/plasma/packagestructure.cpp b2686b6 
>   src/plasma/pluginloader.cpp 0ce349a 
>   src/plasma/private/applet_p.cpp 2cbfd06 
>   src/plasma/private/dataenginemanager.cpp b9c5d8e 
>   src/plasma/scripting/appletscript.h 863d707 
>   src/plasma/scripting/dataenginescript.h f7ad3c2 
>   src/plasma/scripting/scriptengine.cpp cc407e7 
>   src/plasma/service.h b5d9b5a 
>   src/plasma/service.cpp 3e9d852 
>   src/plasmapkg/plasmapkg.cpp d606365 
>   src/scriptengines/CMakeLists.txt f566406 
>   src/scriptengines/qml/CMakeLists.txt e7130db 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 
>   src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd 
>   src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 
> 
> Diff: https://git.reviewboard.kde.org/r/123626/diff/
> 
> 
> Testing
> ---
> 
> still needs a lot of testing, so far, with a master plasma-workspace notmal 
> workspace functions seems fine
> 
> latest version still installs metadata files in kservices5. I would keep this 
> for safety until Plasma 5.4 is released, then try to remove it again
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 123669: Add KPluginLoader::findPluginsById convenience API

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123669/
---

Review request for KDE Frameworks, Alex Richardson and David Faure.


Repository: kcoreaddons


Description
---

Add findPluginsById convenience API

It's a quite common case to load a plugin from an ID. This makes it
easy.

CHANGELOG:New KPluginLoader::findPluginById() convenience API
REVIEW:123669


Diffs
-

  autotests/kpluginloadertest.cpp 3ded0ebca2e0fd20e09bf6e4eca152d13ac11f46 
  src/lib/plugin/kpluginloader.h 124bfab7e207b17d3c8ab4d5a88321af476aad42 
  src/lib/plugin/kpluginloader.cpp 4310d6cd7792329511f12b28d7c68b0fdd013538 

Diff: https://git.reviewboard.kde.org/r/123669/diff/


Testing
---

Added autotests, everything passes.


Thanks,

Sebastian Kügler

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123626: port libplasma away from sycoca as much as possible

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123626/#review7
---

Ship it!


I've read and tested it, everything still works nicely. Good job!

I like how the patch moves much of the query language into simple C++, avoids a 
lot of query parsing and moves some of the error paths to compile time.


src/plasma/pluginloader.cpp 


Why did you remove this, seems unrelated? (I'd keep the sorting in, just to 
assure backwards compat.)



src/plasma/pluginloader.cpp (line 730)


Why? This remark makes it kinda magical and doesn't provide any other 
information than "rather don't touch this" which is counter-productive to 
actually fixing it.



src/plasma/pluginloader.cpp (line 796)


Can this lead to containmentactions being listed twice? (I haven't seen it 
in the UI, but seems plausible as a corner case.)



src/plasma/private/applet_p.cpp (line 182)


I think this may end up calling the non-const version, rather use 
foreach(const QString &..).



src/plasma/private/applet_p.cpp (line 461)


redundant. Forgot to delete a row?



src/plasmapkg/plasmapkg.cpp (line 581)


This can now be const


- Sebastian Kügler


On May 6, 2015, 5:21 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123626/
> ---
> 
> (Updated May 6, 2015, 5:21 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> this ports most of libplasma away from sycoca, using instead a combination of 
> KPluginLoader and KPackage::PackageLoader instead (so eventually using their 
> own little caches instead of the global sycoca cache)
> a kservicetypetrader call is left in the loading of containmentactions since 
> is the only way to make an older workspace still work, but is only a 
> fallback, so containmentactions in plasma-workspace can be ported eventually 
> as well
> 
> 
> Diffs
> -
> 
>   KF5PlasmaConfig.cmake.in dee79ca 
>   src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml 
> be76a43 
>   src/plasma/applet.cpp 2dda381 
>   src/plasma/containment.cpp 7eabbb8 
>   src/plasma/containmentactions.cpp f24bdac 
>   src/plasma/dataengine.cpp 4b3d671 
>   src/plasma/package.cpp 4e0be88 
>   src/plasma/packagestructure.cpp b2686b6 
>   src/plasma/pluginloader.cpp 0ce349a 
>   src/plasma/private/applet_p.cpp 2cbfd06 
>   src/plasma/private/dataenginemanager.cpp b9c5d8e 
>   src/plasma/scripting/appletscript.h 863d707 
>   src/plasma/scripting/dataenginescript.h f7ad3c2 
>   src/plasma/scripting/scriptengine.cpp cc407e7 
>   src/plasma/service.h b5d9b5a 
>   src/plasma/service.cpp 3e9d852 
>   src/plasmapkg/plasmapkg.cpp d606365 
>   src/scriptengines/CMakeLists.txt f566406 
>   src/scriptengines/qml/CMakeLists.txt e7130db 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 
>   src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd 
>   src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 
> 
> Diff: https://git.reviewboard.kde.org/r/123626/diff/
> 
> 
> Testing
> ---
> 
> still needs a lot of testing, so far, with a master plasma-workspace notmal 
> workspace functions seems fine
> 
> latest version still installs metadata files in kservices5. I would keep this 
> for safety until Plasma 5.4 is released, then try to remove it again
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123626: port libplasma away from sycoca as much as possible

[Sebastian Kügler]

> On May 6, 2015, 5:38 p.m., Hrvoje Senjan wrote:
> > >I would keep this for safety until Plasma 5.4 is released, then try to 
> > >remove it again
> > 
> > First, sorry for being the bad cop, i'd just like to avoid any future 
> > (irreversible) problems, and that distros delivering monthly KF5 updates 
> > continue doing so in the future ;-)
> > 
> > Please don't remove anything ever, KF5 promises backward compatibility 
> > forever, not until $someotherproductversion...
> > Distros where assured over and over again in the famous thread that 
> > no-bugfix-only KF5 releases will be a good thing for everyone, and they 
> > should be treated as bugfix releases (same as we can update kdelibs to 
> > 4.14.99 with kde-workspace 4.11.99).
> > 
> > If a distro would release with $someotherproductversion-1, and update KF5 
> > monthly they would get nice reports about broken desktops - and in 
> > principle all non-rolling distros won't deliver new feature releases for 
> > desktop and applications.
> 
> Marco Martin wrote:
> the thing is the systray that would not show plasmoids anymore. all the 
> rest should be 100% compatible.
> but yeah, we can leave the desktop files in kservices5 for the time being.
> we may eventually port the applets to a new install macro to have that 
> file not installed

Well, the .desktop files won't need to be installed anymore since we don't use 
them at runtime (the metadata is baked into the plugin), so we're in fact not 
breaking backwards compatibility, but we're reducing the installation footprint 
while keeping the functionality.

I agree, though, for safety to keep them around for a bit and remove them from 
the install in a later release.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123626/#review79977
---


On May 6, 2015, 5:21 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123626/
> ---
> 
> (Updated May 6, 2015, 5:21 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> this ports most of libplasma away from sycoca, using instead a combination of 
> KPluginLoader and KPackage::PackageLoader instead (so eventually using their 
> own little caches instead of the global sycoca cache)
> a kservicetypetrader call is left in the loading of containmentactions since 
> is the only way to make an older workspace still work, but is only a 
> fallback, so containmentactions in plasma-workspace can be ported eventually 
> as well
> 
> 
> Diffs
> -
> 
>   KF5PlasmaConfig.cmake.in dee79ca 
>   src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml 
> be76a43 
>   src/plasma/applet.cpp 2dda381 
>   src/plasma/containment.cpp 7eabbb8 
>   src/plasma/containmentactions.cpp f24bdac 
>   src/plasma/dataengine.cpp 4b3d671 
>   src/plasma/package.cpp 4e0be88 
>   src/plasma/packagestructure.cpp b2686b6 
>   src/plasma/pluginloader.cpp 0ce349a 
>   src/plasma/private/applet_p.cpp 2cbfd06 
>   src/plasma/private/dataenginemanager.cpp b9c5d8e 
>   src/plasma/scripting/appletscript.h 863d707 
>   src/plasma/scripting/dataenginescript.h f7ad3c2 
>   src/plasma/scripting/scriptengine.cpp cc407e7 
>   src/plasma/service.h b5d9b5a 
>   src/plasma/service.cpp 3e9d852 
>   src/plasmapkg/plasmapkg.cpp d606365 
>   src/scriptengines/CMakeLists.txt f566406 
>   src/scriptengines/qml/CMakeLists.txt e7130db 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 
>   src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd 
>   src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 
> 
> Diff: https://git.reviewboard.kde.org/r/123626/diff/
> 
> 
> Testing
> ---
> 
> still needs a lot of testing, so far, with a master plasma-workspace notmal 
> workspace functions seems fine
> 
> latest version still installs metadata files in kservices5. I would keep this 
> for safety until Plasma 5.4 is released, then try to remove it again
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

IRC and Email notifications

[Scarlett Clark]

Please help me help you,
I do not have lists containing who needs / wants what and where.. I tried my 
best to make some educated guesses.  I do not take rejection well and so 
I ask anyone that wishes to have your CI builds in email or IRC please tell 
me the rpoject and places you want them to go.  If I already set you up and 
you wish for my bots to go away, speak now or forever hold your peace.
I am available in many places, whatever is convenient for you..

1) Reply to this email
2) Send email to sgcl...@kubuntu.org
3) ping sgclark on many irc channels including #kde-sysadmin
4) create a ticket on https://sysadmin.kde.org/tickets/
Thank you for your help,
Scarlett

PS: I promise to document all this so this will not happen again.


signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123626: port libplasma away from sycoca as much as possible

[Marco Martin]

> On May 6, 2015, 5:38 p.m., Hrvoje Senjan wrote:
> > >I would keep this for safety until Plasma 5.4 is released, then try to 
> > >remove it again
> > 
> > First, sorry for being the bad cop, i'd just like to avoid any future 
> > (irreversible) problems, and that distros delivering monthly KF5 updates 
> > continue doing so in the future ;-)
> > 
> > Please don't remove anything ever, KF5 promises backward compatibility 
> > forever, not until $someotherproductversion...
> > Distros where assured over and over again in the famous thread that 
> > no-bugfix-only KF5 releases will be a good thing for everyone, and they 
> > should be treated as bugfix releases (same as we can update kdelibs to 
> > 4.14.99 with kde-workspace 4.11.99).
> > 
> > If a distro would release with $someotherproductversion-1, and update KF5 
> > monthly they would get nice reports about broken desktops - and in 
> > principle all non-rolling distros won't deliver new feature releases for 
> > desktop and applications.

the thing is the systray that would not show plasmoids anymore. all the rest 
should be 100% compatible.
but yeah, we can leave the desktop files in kservices5 for the time being.
we may eventually port the applets to a new install macro to have that file not 
installed


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123626/#review79977
---


On May 6, 2015, 5:21 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123626/
> ---
> 
> (Updated May 6, 2015, 5:21 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> this ports most of libplasma away from sycoca, using instead a combination of 
> KPluginLoader and KPackage::PackageLoader instead (so eventually using their 
> own little caches instead of the global sycoca cache)
> a kservicetypetrader call is left in the loading of containmentactions since 
> is the only way to make an older workspace still work, but is only a 
> fallback, so containmentactions in plasma-workspace can be ported eventually 
> as well
> 
> 
> Diffs
> -
> 
>   KF5PlasmaConfig.cmake.in dee79ca 
>   src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml 
> be76a43 
>   src/plasma/applet.cpp 2dda381 
>   src/plasma/containment.cpp 7eabbb8 
>   src/plasma/containmentactions.cpp f24bdac 
>   src/plasma/dataengine.cpp 4b3d671 
>   src/plasma/package.cpp 4e0be88 
>   src/plasma/packagestructure.cpp b2686b6 
>   src/plasma/pluginloader.cpp 0ce349a 
>   src/plasma/private/applet_p.cpp 2cbfd06 
>   src/plasma/private/dataenginemanager.cpp b9c5d8e 
>   src/plasma/scripting/appletscript.h 863d707 
>   src/plasma/scripting/dataenginescript.h f7ad3c2 
>   src/plasma/scripting/scriptengine.cpp cc407e7 
>   src/plasma/service.h b5d9b5a 
>   src/plasma/service.cpp 3e9d852 
>   src/plasmapkg/plasmapkg.cpp d606365 
>   src/scriptengines/CMakeLists.txt f566406 
>   src/scriptengines/qml/CMakeLists.txt e7130db 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 
>   src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd 
>   src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 
> 
> Diff: https://git.reviewboard.kde.org/r/123626/diff/
> 
> 
> Testing
> ---
> 
> still needs a lot of testing, so far, with a master plasma-workspace notmal 
> workspace functions seems fine
> 
> latest version still installs metadata files in kservices5. I would keep this 
> for safety until Plasma 5.4 is released, then try to remove it again
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123626: port libplasma away from sycoca as much as possible

[Hrvoje Senjan]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123626/#review79977
---


>I would keep this for safety until Plasma 5.4 is released, then try to remove 
>it again

First, sorry for being the bad cop, i'd just like to avoid any future 
(irreversible) problems, and that distros delivering monthly KF5 updates 
continue doing so in the future ;-)

Please don't remove anything ever, KF5 promises backward compatibility forever, 
not until $someotherproductversion...
Distros where assured over and over again in the famous thread that 
no-bugfix-only KF5 releases will be a good thing for everyone, and they should 
be treated as bugfix releases (same as we can update kdelibs to 4.14.99 with 
kde-workspace 4.11.99).

If a distro would release with $someotherproductversion-1, and update KF5 
monthly they would get nice reports about broken desktops - and in principle 
all non-rolling distros won't deliver new feature releases for desktop and 
applications.

- Hrvoje Senjan


On May 6, 2015, 7:21 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123626/
> ---
> 
> (Updated May 6, 2015, 7:21 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> this ports most of libplasma away from sycoca, using instead a combination of 
> KPluginLoader and KPackage::PackageLoader instead (so eventually using their 
> own little caches instead of the global sycoca cache)
> a kservicetypetrader call is left in the loading of containmentactions since 
> is the only way to make an older workspace still work, but is only a 
> fallback, so containmentactions in plasma-workspace can be ported eventually 
> as well
> 
> 
> Diffs
> -
> 
>   KF5PlasmaConfig.cmake.in dee79ca 
>   src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml 
> be76a43 
>   src/plasma/applet.cpp 2dda381 
>   src/plasma/containment.cpp 7eabbb8 
>   src/plasma/containmentactions.cpp f24bdac 
>   src/plasma/dataengine.cpp 4b3d671 
>   src/plasma/package.cpp 4e0be88 
>   src/plasma/packagestructure.cpp b2686b6 
>   src/plasma/pluginloader.cpp 0ce349a 
>   src/plasma/private/applet_p.cpp 2cbfd06 
>   src/plasma/private/dataenginemanager.cpp b9c5d8e 
>   src/plasma/scripting/appletscript.h 863d707 
>   src/plasma/scripting/dataenginescript.h f7ad3c2 
>   src/plasma/scripting/scriptengine.cpp cc407e7 
>   src/plasma/service.h b5d9b5a 
>   src/plasma/service.cpp 3e9d852 
>   src/plasmapkg/plasmapkg.cpp d606365 
>   src/scriptengines/CMakeLists.txt f566406 
>   src/scriptengines/qml/CMakeLists.txt e7130db 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 
>   src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd 
>   src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 
> 
> Diff: https://git.reviewboard.kde.org/r/123626/diff/
> 
> 
> Testing
> ---
> 
> still needs a lot of testing, so far, with a master plasma-workspace notmal 
> workspace functions seems fine
> 
> latest version still installs metadata files in kservices5. I would keep this 
> for safety until Plasma 5.4 is released, then try to remove it again
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123626: port libplasma away from sycoca as much as possible

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123626/
---

(Updated May 6, 2015, 5:21 p.m.)


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

this ports most of libplasma away from sycoca, using instead a combination of 
KPluginLoader and KPackage::PackageLoader instead (so eventually using their 
own little caches instead of the global sycoca cache)
a kservicetypetrader call is left in the loading of containmentactions since is 
the only way to make an older workspace still work, but is only a fallback, so 
containmentactions in plasma-workspace can be ported eventually as well


Diffs
-

  KF5PlasmaConfig.cmake.in dee79ca 
  src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml be76a43 
  src/plasma/applet.cpp 2dda381 
  src/plasma/containment.cpp 7eabbb8 
  src/plasma/containmentactions.cpp f24bdac 
  src/plasma/dataengine.cpp 4b3d671 
  src/plasma/package.cpp 4e0be88 
  src/plasma/packagestructure.cpp b2686b6 
  src/plasma/pluginloader.cpp 0ce349a 
  src/plasma/private/applet_p.cpp 2cbfd06 
  src/plasma/private/dataenginemanager.cpp b9c5d8e 
  src/plasma/scripting/appletscript.h 863d707 
  src/plasma/scripting/dataenginescript.h f7ad3c2 
  src/plasma/scripting/scriptengine.cpp cc407e7 
  src/plasma/service.h b5d9b5a 
  src/plasma/service.cpp 3e9d852 
  src/plasmapkg/plasmapkg.cpp d606365 
  src/scriptengines/CMakeLists.txt f566406 
  src/scriptengines/qml/CMakeLists.txt e7130db 
  src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 
  src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd 
  src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 

Diff: https://git.reviewboard.kde.org/r/123626/diff/


Testing (updated)
---

still needs a lot of testing, so far, with a master plasma-workspace notmal 
workspace functions seems fine

latest version still installs metadata files in kservices5. I would keep this 
for safety until Plasma 5.4 is released, then try to remove it again


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123626: port libplasma away from sycoca as much as possible

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123626/
---

(Updated May 6, 2015, 5:20 p.m.)


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

this ports most of libplasma away from sycoca, using instead a combination of 
KPluginLoader and KPackage::PackageLoader instead (so eventually using their 
own little caches instead of the global sycoca cache)
a kservicetypetrader call is left in the loading of containmentactions since is 
the only way to make an older workspace still work, but is only a fallback, so 
containmentactions in plasma-workspace can be ported eventually as well


Diffs (updated)
-

  KF5PlasmaConfig.cmake.in dee79ca 
  src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml be76a43 
  src/plasma/applet.cpp 2dda381 
  src/plasma/containment.cpp 7eabbb8 
  src/plasma/containmentactions.cpp f24bdac 
  src/plasma/dataengine.cpp 4b3d671 
  src/plasma/package.cpp 4e0be88 
  src/plasma/packagestructure.cpp b2686b6 
  src/plasma/pluginloader.cpp 0ce349a 
  src/plasma/private/applet_p.cpp 2cbfd06 
  src/plasma/private/dataenginemanager.cpp b9c5d8e 
  src/plasma/scripting/appletscript.h 863d707 
  src/plasma/scripting/dataenginescript.h f7ad3c2 
  src/plasma/scripting/scriptengine.cpp cc407e7 
  src/plasma/service.h b5d9b5a 
  src/plasma/service.cpp 3e9d852 
  src/plasmapkg/plasmapkg.cpp d606365 
  src/scriptengines/CMakeLists.txt f566406 
  src/scriptengines/qml/CMakeLists.txt e7130db 
  src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 
  src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd 
  src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 

Diff: https://git.reviewboard.kde.org/r/123626/diff/


Testing
---

still needs a lot of testing, so far, with a master plasma-workspace notmal 
workspace functions seems fine


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123595: Fix KUser test for Mac.

[René J . V . Bertin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123595/#review79976
---


I'm not sure, after reading http://pig.made-it.com/uidgid.html

also:

```
> id nobody
uid=4294967294(nobody) gid=4294967294(nobody) 
groups=4294967294(nobody),12(everyone),61(localaccounts),402(com.apple.sharepoint.group.1),403(com.apple.sharepoint.group.2),100(_lpoperator)
```

and

```
> id unknown
uid=99(_unknown) gid=99(_unknown) 
groups=99(_unknown),402(com.apple.sharepoint.group.1),12(everyone),61(localaccounts),403(com.apple.sharepoint.group.2),100(_lpoperator)
```

- René J.V. Bertin


On May 6, 2015, 6:08 p.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123595/
> ---
> 
> (Updated May 6, 2015, 6:08 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X, KDE Frameworks and Marko Käning.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> According to CI [1], an invalid user belongs to "nogroup" on Mac.
> Not sure if this is true on all OSX installations though?
> 
> https://build.kde.org/view/Frameworks%20kf5-qt5/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/19/testReport/%28root%29/TestSuite/kusertest/
> 
> 
> Diffs
> -
> 
>   autotests/kusertest.cpp d17a2d3e97d5056524281eb18766377e48a0da35 
> 
> Diff: https://git.reviewboard.kde.org/r/123595/diff/
> 
> 
> Testing
> ---
> 
> Still passes on Linux; should fix the CI for mac, AFAICS.
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123626: port libplasma away from sycoca as much as possible

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123626/
---

(Updated May 6, 2015, 2:35 p.m.)


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

this ports most of libplasma away from sycoca, using instead a combination of 
KPluginLoader and KPackage::PackageLoader instead (so eventually using their 
own little caches instead of the global sycoca cache)
a kservicetypetrader call is left in the loading of containmentactions since is 
the only way to make an older workspace still work, but is only a fallback, so 
containmentactions in plasma-workspace can be ported eventually as well


Diffs (updated)
-

  KF5PlasmaConfig.cmake.in dee79ca 
  KF5PlasmaMacros.cmake 24bebb4 
  src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml be76a43 
  src/plasma/applet.cpp 2dda381 
  src/plasma/containment.cpp 7eabbb8 
  src/plasma/containmentactions.cpp f24bdac 
  src/plasma/dataengine.cpp 4b3d671 
  src/plasma/package.cpp 4e0be88 
  src/plasma/packagestructure.cpp b2686b6 
  src/plasma/pluginloader.cpp 0ce349a 
  src/plasma/private/applet_p.cpp 2cbfd06 
  src/plasma/private/dataenginemanager.cpp b9c5d8e 
  src/plasma/scripting/appletscript.h 863d707 
  src/plasma/scripting/dataenginescript.h f7ad3c2 
  src/plasma/scripting/scriptengine.cpp cc407e7 
  src/plasma/service.h b5d9b5a 
  src/plasma/service.cpp 3e9d852 
  src/plasmapkg/plasmapkg.cpp d606365 
  src/scriptengines/CMakeLists.txt f566406 
  src/scriptengines/qml/CMakeLists.txt e7130db 
  src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 
  src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd 
  src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 

Diff: https://git.reviewboard.kde.org/r/123626/diff/


Testing
---

still needs a lot of testing, so far, with a master plasma-workspace notmal 
workspace functions seems fine


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123632: Fix the i18n after Jerome's patch

[Martin Klapetek]

> On May 4, 2015, 10:36 p.m., Albert Astals Cid wrote:
> > Sorry, that's not enough you need to add the loader to the sources, see 
> > CMakeLists.txt of the daemon.
> > 
> > And maybe you want to share your new acquired knowldge in the wiki?
> 
> Martin Klapetek wrote:
> Ah ok, update incoming.

I've added couple lines to 
https://techbase.kde.org/Development/Tutorials/Localization/i18n_Build_Systems#Qt5-only:_Code_using_Qt_translation_system
 please check


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123632/#review79868
---


On May 6, 2015, 3:19 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123632/
> ---
> 
> (Updated May 6, 2015, 3:19 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> ---
> 
> Jerome got stuck on the pointed i18n fixes in 
> https://git.reviewboard.kde.org/r/122680/ - this finishes it.
> 
> 
> Diffs
> -
> 
>   src/runtime/CMakeLists.txt 8c7c761 
>   src/runtime/Messages.sh 8a5e4a9 
> 
> Diff: https://git.reviewboard.kde.org/r/123632/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123632: Fix the i18n after Jerome's patch

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123632/
---

(Updated May 6, 2015, 1:19 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 4928539a48edd4729174f9c8aa906cf63fbe1b45 by Martin 
Klapetek on behalf of Jerome Leclanche to branch master.


Repository: kglobalaccel


Description
---

Jerome got stuck on the pointed i18n fixes in 
https://git.reviewboard.kde.org/r/122680/ - this finishes it.


Diffs
-

  src/runtime/CMakeLists.txt 8c7c761 
  src/runtime/Messages.sh 8a5e4a9 

Diff: https://git.reviewboard.kde.org/r/123632/diff/


Testing
---


Thanks,

Martin Klapetek

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

[Jerome Leclanche]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122680/
---

(Updated May 6, 2015, 1:19 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Localization and Translation (l10n), Albert 
Astals Cid, Martin Gräßlin, and Martin Klapetek.


Changes
---

Submitted with commit 4928539a48edd4729174f9c8aa906cf63fbe1b45 by Martin 
Klapetek on behalf of Jerome Leclanche to branch master.


Repository: kglobalaccel


Description
---

Remove the runtime's KAboutData

The about data was unexposed, but created a dependency on KCoreAddons (for
KAboutData) and in turn on KI18n for the translations of the aboutData.

This removes both dependencies as well as the string extraction scripts.

--

Author notes: This is a RFC. We don't use kglobalaccel in LXQt but we would
like to, however it currently has too many dependencies. See
https://github.com/lxde/lxqt/issues/507 for related discussion.
I'm unsure myself if the about data is actually exposed somewhere I completely
missed, but it doesn't look that way.


Diffs
-

  CMakeLists.txt 68ad795 
  src/runtime/CMakeLists.txt e639fa5 
  src/runtime/globalshortcutsregistry.cpp 3e4d720 
  src/runtime/kglobalacceld.cpp 4e7cb9d 
  src/runtime/main.cpp fdf4d62 

Diff: https://git.reviewboard.kde.org/r/122680/diff/


Testing
---

Compiles and runs. No further testing done.


Thanks,

Jerome Leclanche

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Versioning of Frameworks

[Jan Kundrát]

Hi Christian,
I think that the stuff you're looking for (reducing version churn) can also 
be provided by having stable branches for selected parts of KF5.


IMHO this can be quite an elegant solution given the usual cat-herding 
problem of FLOSS where people just do what they want to do. Those who value 
the benefits of having bugfix-only releases and those willing to put their 
time into this could well branch from a random KF5 release and keep 
backporting bugfixes. I can give you CI coverage pretty easily for this.


Would this solve this problem for you, and would you volunteer to become a 
maintainer for this? Has this been discussed before, or is there some 
reason against doing this?


Cheers,
Jan

--
Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123654: Improve performance of KFileItem and KDirSortFilterProxyModel

[Milian Wolff]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123654/#review79958
---


generally +1 from my side except for the open question for the case of 
displayName != fileName. and probably someone else with more knowledge of 
what's going on should give the final +2.


autotests/kdirsortfilterproxymodel_benchmark.cpp (line 45)


should this be part of the benchmark? can't you set it once and switch 
between sort columns? i.e. I'd expect this call to be outside the QBENCHMARK 
scope



src/core/kfileitem.cpp (line 1115)


what about this comment, it seems there are cases where the filename is 
different from the display name sometimes and the old code always used the 
filename. is that comment obsolete? or simply not applicable to the current 
directory which always has fileName() == m_strName ?



src/filewidgets/kdirsortfilterproxymodel.cpp (line 48)


is this check required, i.e. shouldn't the collator code in Qt handle it 
and do a no-op if nothing changes?


- Milian Wolff


On May 6, 2015, 2:35 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123654/
> ---
> 
> (Updated May 6, 2015, 2:35 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Reduces some operations in KDirSortFilterProxyModel.
> Removes usage of QUrl::fileName() in KFileItem::isHidden(), it comprised 75% 
> of the time spent running the benchmark in here.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 010074d 
>   autotests/kdirsortfilterproxymodel_benchmark.cpp PRE-CREATION 
>   src/core/kfileitem.cpp 344ac67 
>   src/filewidgets/kdirsortfilterproxymodel.cpp 22ac025 
> 
> Diff: https://git.reviewboard.kde.org/r/123654/diff/
> 
> 
> Testing
> ---
> 
> Everything seems to be working still, including tests.
> 
> There was a comment about trash:/ triggering an assert, but I couldn't 
> reproduce.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123595: Fix KUser test for Mac.

[David Faure]

> On May 5, 2015, 9:08 p.m., Marko Käning wrote:
> > Looks like the test is still failing: 
> > 
> > https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/24/PLATFORM=OSX,compiler=clang/testReport/(root)/TestSuite/kusertest/
> > 
> > Anything I could do?

Yes, you could try applying the patch :)

This isn't committed yet, due to no "Ship It".


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123595/#review79919
---


On May 2, 2015, 6:45 p.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123595/
> ---
> 
> (Updated May 2, 2015, 6:45 p.m.)
> 
> 
> Review request for KDE Frameworks and Marko Käning.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> According to CI [1], an invalid user belongs to "nogroup" on Mac.
> Not sure if this is true on all OSX installations though?
> 
> https://build.kde.org/view/Frameworks%20kf5-qt5/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/19/testReport/%28root%29/TestSuite/kusertest/
> 
> 
> Diffs
> -
> 
>   autotests/kusertest.cpp d17a2d3e97d5056524281eb18766377e48a0da35 
> 
> Diff: https://git.reviewboard.kde.org/r/123595/diff/
> 
> 
> Testing
> ---
> 
> Still passes on Linux; should fix the CI for mac, AFAICS.
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel