Re: Review Request 124065: KMimeType mimeTypeForNameAndData() -> mimeTypeForFileNameAndData()
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124065/#review81375 --- Ship it! Indeed it was renamed in QMineDatabase and we forgot to update script. Ship it. Thanks - Laurent Montel On juin 10, 2015, 7:51 après-midi, Jarosław Staniek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124065/ > --- > > (Updated juin 10, 2015, 7:51 après-midi) > > > Review request for KDE Frameworks and Laurent Montel. > > > Repository: kde-dev-scripts > > > Description > --- > > There's apparent mistake; mimeTypeForNameAndData() does not exist, shall be > mimeTypeForFileNameAndData(). > > > Diffs > - > > kf5/convert-kmimetype.pl 363ff21cd46331efe209a5051feca58e971739b2 > > Diff: https://git.reviewboard.kde.org/r/124065/diff/ > > > Testing > --- > > > Thanks, > > Jarosław Staniek > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124066: Recognize X-KDE-FormFactor as stringlist
> On June 11, 2015, 4:25 a.m., Bhushan Shah wrote: > > +1 > > > > I was looking for similar API when implementing plasmoids in pmc. Not all > > plasmoids would support mediacenter containment, so they might need to tell > > somehow which formfactors are supported.. About naming, name it > > X-KDE-SupportedFormFactor maybe? > > > > Also perhaps document what should be possible values of X-KDE-FormFactors > > somewhere? Yes, mediacenter is one of the usecases. About the key naming, not sure what the "Supported" really adds, to me, it sounds clear enough as it is. It would definitely have to be the plural form (more than one formfactor is the whole point of this patch). Possible values are freestyle by design, we don't know yet what formfactors we'll support in the future, and which application picks up what exactly. I agree that giving examples would make sense in the API docs perhaps. In my example, the --help of the active-settings application indicates which ones it supports explicitely. As it only checks if the "current formfactor" is in the list of supported formfactors, you can basically add "toaster" or "divecomputer" there if you want, and it won't break. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124066/#review81373 --- On June 11, 2015, 4:16 a.m., Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124066/ > --- > > (Updated June 11, 2015, 4:16 a.m.) > > > Review request for KDE Frameworks, Alex Richardson and David Faure. > > > Repository: kcoreaddons > > > Description > --- > > This patch adds X-KDE-FormFactor to the keys recognized as stringlists. > > We would like to see this to go in to allow us to filter plugins (KCMs for > example) by form factor, so we only display UI plugins that are suitable for > a given target device. > > The idea is that plugins indicate which form factor (for example media > center, tablet, desktop, etc...) they're suitable for, and the "host > application" filters based on these. > > If this approach is deemed valid, I'd be happy to add convenience API to > KPluginMetaData, i.e. QStringList KPluginMetaData::formFactor(). This patch > would be the minimal implementation we'd need. > > The naming of the key is of course open to better suggestions. > > > Diffs > - > > autotests/data/fakeplugin.desktop 95152f6 > autotests/kpluginmetadatatest.cpp 231ac36 > src/lib/plugin/desktopfileparser.cpp b19da6b > > Diff: https://git.reviewboard.kde.org/r/124066/diff/ > > > Testing > --- > > added autotest, also implemented using this in the Plasma Active settings app > as proof-of-concept, works like a charm. > > > Thanks, > > Sebastian Kügler > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124066: Recognize X-KDE-FormFactor as stringlist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124066/#review81373 --- +1 I was looking for similar API when implementing plasmoids in pmc. Not all plasmoids would support mediacenter containment, so they might need to tell somehow which formfactors are supported.. About naming, name it X-KDE-SupportedFormFactor maybe? Also perhaps document what should be possible values of X-KDE-FormFactors somewhere? - Bhushan Shah On June 11, 2015, 9:46 a.m., Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124066/ > --- > > (Updated June 11, 2015, 9:46 a.m.) > > > Review request for KDE Frameworks, Alex Richardson and David Faure. > > > Repository: kcoreaddons > > > Description > --- > > This patch adds X-KDE-FormFactor to the keys recognized as stringlists. > > We would like to see this to go in to allow us to filter plugins (KCMs for > example) by form factor, so we only display UI plugins that are suitable for > a given target device. > > The idea is that plugins indicate which form factor (for example media > center, tablet, desktop, etc...) they're suitable for, and the "host > application" filters based on these. > > If this approach is deemed valid, I'd be happy to add convenience API to > KPluginMetaData, i.e. QStringList KPluginMetaData::formFactor(). This patch > would be the minimal implementation we'd need. > > The naming of the key is of course open to better suggestions. > > > Diffs > - > > autotests/data/fakeplugin.desktop 95152f6 > autotests/kpluginmetadatatest.cpp 231ac36 > src/lib/plugin/desktopfileparser.cpp b19da6b > > Diff: https://git.reviewboard.kde.org/r/124066/diff/ > > > Testing > --- > > added autotest, also implemented using this in the Plasma Active settings app > as proof-of-concept, works like a charm. > > > Thanks, > > Sebastian Kügler > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 124066: Recognize X-KDE-FormFactor as stringlist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124066/ --- Review request for KDE Frameworks, Alex Richardson and David Faure. Repository: kcoreaddons Description --- This patch adds X-KDE-FormFactor to the keys recognized as stringlists. We would like to see this to go in to allow us to filter plugins (KCMs for example) by form factor, so we only display UI plugins that are suitable for a given target device. The idea is that plugins indicate which form factor (for example media center, tablet, desktop, etc...) they're suitable for, and the "host application" filters based on these. If this approach is deemed valid, I'd be happy to add convenience API to KPluginMetaData, i.e. QStringList KPluginMetaData::formFactor(). This patch would be the minimal implementation we'd need. The naming of the key is of course open to better suggestions. Diffs - autotests/data/fakeplugin.desktop 95152f6 autotests/kpluginmetadatatest.cpp 231ac36 src/lib/plugin/desktopfileparser.cpp b19da6b Diff: https://git.reviewboard.kde.org/r/124066/diff/ Testing --- added autotest, also implemented using this in the Plasma Active settings app as proof-of-concept, works like a charm. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124065: KMimeType mimeTypeForNameAndData() -> mimeTypeForFileNameAndData()
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124065/#review81372 --- Ship it! - Vishesh Handa On June 10, 2015, 7:51 p.m., Jarosław Staniek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124065/ > --- > > (Updated June 10, 2015, 7:51 p.m.) > > > Review request for KDE Frameworks and Laurent Montel. > > > Repository: kde-dev-scripts > > > Description > --- > > There's apparent mistake; mimeTypeForNameAndData() does not exist, shall be > mimeTypeForFileNameAndData(). > > > Diffs > - > > kf5/convert-kmimetype.pl 363ff21cd46331efe209a5051feca58e971739b2 > > Diff: https://git.reviewboard.kde.org/r/124065/diff/ > > > Testing > --- > > > Thanks, > > Jarosław Staniek > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: plasma-framework master kf5-qt5 » OSX,All,clang - Build # 21 - Fixed!
We thank you for fixing your build!___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 124065: KMimeType mimeTypeForNameAndData() -> mimeTypeForFileNameAndData()
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124065/ --- Review request for KDE Frameworks and Laurent Montel. Repository: kde-dev-scripts Description --- There's apparent mistake; mimeTypeForNameAndData() does not exist, shall be mimeTypeForFileNameAndData(). Diffs - kf5/convert-kmimetype.pl 363ff21cd46331efe209a5051feca58e971739b2 Diff: https://git.reviewboard.kde.org/r/124065/diff/ Testing --- Thanks, Jarosław Staniek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 20 - Fixed!
We thank you for fixing your build!___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: plasma-framework master kf5-qt5 » OSX,All,clang - Build # 19 - Still Failing!
Check console output at https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=OSX,Variation=All,compiler=clang/19/ to view the results. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: plasma-framework master kf5-qt5 » OSX,All,clang - Build # 18 - Failure!
Check console output at https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=OSX,Variation=All,compiler=clang/18/ to view the results. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: plasma-framework master kf5-qt5 » OSX,NoX11,clang - Build # 18 - Failure!
Check console output at https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=OSX,Variation=NoX11,compiler=clang/18/ to view the results. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 19 - Fixed!
We thank you for fixing your build!___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: kdeclarative master kf5-qt5 » OSX,clang - Build # 8 - Failure!
Check console output at https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/8/ to view the results. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124062: Verify service has valid plugin info before using it
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124062/#review81367 --- Would a warning there make sense? It's odd when things don't work without notice. - Aleix Pol Gonzalez On June 10, 2015, 6:39 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124062/ > --- > > (Updated June 10, 2015, 6:39 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > Basically the same as 8a6c0b00979d235f68c46de761ba030848591247 in > plasma-workspace but done at a higher level as applet listing occurs in more > places. > > > Diffs > - > > src/plasma/pluginloader.cpp 8b32f91306ed73777c3fc0e1bddc0bc014897cc1 > > Diff: https://git.reviewboard.kde.org/r/124062/diff/ > > > Testing > --- > > krunner stops crashing when listing applets. > > > Thanks, > > David Edmundson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123736: single QQmlEngine for all applets
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123736/ --- (Updated June 10, 2015, 4:41 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit 13bd6703c0dce6694ec0f06e8a3408cd3495ab29 by Marco Martin to branch master. Repository: plasma-framework Description --- use a single shared QQmlEngine for all applets, tooltip and wallpapers (each of which used to use an own one) views are still separed engines because being View subclass of QQuickView which api unfortunately requires it (a qquickengine can be passed to the ctor, but in that case they would share their QQmlContext, which wouldn't work) For compatibility, applets without X-Plasma-RequiredExtensions=LaunchApp will still have own engine Diffs - src/declarativeimports/core/tooltipdialog.cpp feeacc3 src/plasmaquick/appletquickitem.cpp c6fcf22 src/plasmaquick/packageurlinterceptor.h 36c85a9 src/plasmaquick/packageurlinterceptor.cpp 5f77c3a src/plasmaquick/private/appletquickitem_p.h a1ec683 src/scriptengines/qml/plasmoid/wallpaperinterface.cpp fcaca4b Diff: https://git.reviewboard.kde.org/r/123736/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123735: version of QmlObject with a static engine
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated June 10, 2015, 4:41 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit 5f7909408e30869980552b9d74ded57a4f8a6621 by Marco Martin to branch master. Repository: kdeclarative Description --- to make easier doing applications like plasma that use a lot of qml to have a single engine make a subclass of QmlObject called QmlObjectSharedEngine that has a single, static QQmlEngine Adds a class called QuickViewSharedEngine that has the same behavior as QmlObjectSharedEngine(using it): static QQmlEngine, separed rootContexts() for each instance. This is used by desktopviews and panelviews to share their engine. Unfortunately it may not be possible to get the applet configuration dialogs to use this, since they still need a separed engine in order to have a different controls style (qstyle based) than the stuff in the desktop/panel Diffs - autotests/CMakeLists.txt adc1102 autotests/quickviewsharedengine.cpp PRE-CREATION autotests/util.h PRE-CREATION autotests/util.cpp PRE-CREATION src/kdeclarative/CMakeLists.txt d73bff0 src/kdeclarative/kdeclarative.cpp b3906e2 src/kdeclarative/qmlobject.h f26b67d src/kdeclarative/qmlobject.cpp c483665 src/kdeclarative/qmlobjectsharedengine.h PRE-CREATION src/kdeclarative/qmlobjectsharedengine.cpp PRE-CREATION src/quickaddons/CMakeLists.txt 777d07c src/quickaddons/quickviewsharedengine.h PRE-CREATION src/quickaddons/quickviewsharedengine.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123735/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 124062: Verify service has valid plugin info before using it
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124062/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- Basically the same as 8a6c0b00979d235f68c46de761ba030848591247 in plasma-workspace but done at a higher level as applet listing occurs in more places. Diffs - src/plasma/pluginloader.cpp 8b32f91306ed73777c3fc0e1bddc0bc014897cc1 Diff: https://git.reviewboard.kde.org/r/124062/diff/ Testing --- krunner stops crashing when listing applets. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Custom translated fields
2015-06-10 14:24 GMT+03:00 Jaroslaw Staniek : > On 10 June 2015 at 12:26, Alexander Potashev wrote: >> (CCing kde-i18n-doc) >> Hi Jaroslaw, >> >> The list of fields to extract is hardcoded in [1]. >> >> How many fields do you want to add? Can they be useful in other projects? >> >> [1] >> http://websvn.kde.org/trunk/l10n-kf5/scripts/createdesktopcontext.pl?view=markup > > Thanks so much for the info, Alexander. > I need one field at the moment, it's a plural noun explaining a > "folder" name, that is for example: > for a Table plugin, the the folder could be called "Tables". > > It's quite custom as you see. Perhaps we can have a hint for the > createdesktopcontext.pl in a "# comment" line that some field is up > for translation? Jaroslaw, Nice idea, I like it! Let's see if someone else in kde-i18n-doc comes up with a better strategy. -- Alexander Potashev ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Custom translated fields
On 10 June 2015 at 12:26, Alexander Potashev wrote: > (CCing kde-i18n-doc) > Hi Jaroslaw, > > The list of fields to extract is hardcoded in [1]. > > How many fields do you want to add? Can they be useful in other projects? > > [1] > http://websvn.kde.org/trunk/l10n-kf5/scripts/createdesktopcontext.pl?view=markup Thanks so much for the info, Alexander. I need one field at the moment, it's a plural noun explaining a "folder" name, that is for example: for a Table plugin, the the folder could be called "Tables". It's quite custom as you see. Perhaps we can have a hint for the createdesktopcontext.pl in a "# comment" line that some field is up for translation? > -- > Alexander Potashev > > 2015-06-10 12:41 GMT+03:00 Jaroslaw Staniek : >> Hi, >> KPluginMetaData::readTranslatedValue() is cool as it supports custom >> translated fields, i.e. something more than Name[...] or Comment[...]. >> A question: How is make our scripty infrastructure know that a custom >> field such as Foo[...] should be translated as well? > > 2015-06-10 12:41 GMT+03:00 Jaroslaw Staniek : >> Hi, >> KPluginMetaData::readTranslatedValue() is cool as it supports custom >> translated fields, i.e. something more than Name[...] or Comment[...]. >> A question: How is make our scripty infrastructure know that a custom >> field such as Foo[...] should be translated as well? >> >> -- >> regards, Jaroslaw Staniek >> >> KDE: >> : A world-wide network of software engineers, artists, writers, translators >> : and facilitators committed to Free Software development - http://kde.org >> Calligra Suite: >> : A graphic art and office suite - http://calligra.org >> Kexi: >> : A visual database apps builder - http://calligra.org/kexi >> Qt Certified Specialist: >> : http://www.linkedin.com/in/jstaniek >> ___ >> Kde-frameworks-devel mailing list >> Kde-frameworks-devel@kde.org >> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel > > > > -- > Alexander Potashev > ___ > Kde-frameworks-devel mailing list > Kde-frameworks-devel@kde.org > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel -- regards, Jaroslaw Staniek KDE: : A world-wide network of software engineers, artists, writers, translators : and facilitators committed to Free Software development - http://kde.org Calligra Suite: : A graphic art and office suite - http://calligra.org Kexi: : A visual database apps builder - http://calligra.org/kexi Qt Certified Specialist: : http://www.linkedin.com/in/jstaniek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Custom translated fields
(CCing kde-i18n-doc) Hi Jaroslaw, The list of fields to extract is hardcoded in [1]. How many fields do you want to add? Can they be useful in other projects? [1] http://websvn.kde.org/trunk/l10n-kf5/scripts/createdesktopcontext.pl?view=markup -- Alexander Potashev 2015-06-10 12:41 GMT+03:00 Jaroslaw Staniek : > Hi, > KPluginMetaData::readTranslatedValue() is cool as it supports custom > translated fields, i.e. something more than Name[...] or Comment[...]. > A question: How is make our scripty infrastructure know that a custom > field such as Foo[...] should be translated as well? 2015-06-10 12:41 GMT+03:00 Jaroslaw Staniek : > Hi, > KPluginMetaData::readTranslatedValue() is cool as it supports custom > translated fields, i.e. something more than Name[...] or Comment[...]. > A question: How is make our scripty infrastructure know that a custom > field such as Foo[...] should be translated as well? > > -- > regards, Jaroslaw Staniek > > KDE: > : A world-wide network of software engineers, artists, writers, translators > : and facilitators committed to Free Software development - http://kde.org > Calligra Suite: > : A graphic art and office suite - http://calligra.org > Kexi: > : A visual database apps builder - http://calligra.org/kexi > Qt Certified Specialist: > : http://www.linkedin.com/in/jstaniek > ___ > Kde-frameworks-devel mailing list > Kde-frameworks-devel@kde.org > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel -- Alexander Potashev ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Custom translated fields
Hi, KPluginMetaData::readTranslatedValue() is cool as it supports custom translated fields, i.e. something more than Name[...] or Comment[...]. A question: How is make our scripty infrastructure know that a custom field such as Foo[...] should be translated as well? -- regards, Jaroslaw Staniek KDE: : A world-wide network of software engineers, artists, writers, translators : and facilitators committed to Free Software development - http://kde.org Calligra Suite: : A graphic art and office suite - http://calligra.org Kexi: : A visual database apps builder - http://calligra.org/kexi Qt Certified Specialist: : http://www.linkedin.com/in/jstaniek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
