Re: Review Request 124226: Delete old highlighter

[Lasse Liehu]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124226/
---

(Updated July 12, 2015, 8:12 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Laurent Montel.


Repository: ktextwidgets


Description
---

According to SpellCheckDecorator::setHighlighter's documentation, the old 
automatically created default highlighter must be manually deleted.

This fixes bug 343459 in Lokalize.


Diffs
-

  src/widgets/ktextedit.cpp e4bd41d 

Diff: https://git.reviewboard.kde.org/r/124226/diff/


Testing
---

Tested that it works in Lokalize. Also ran tests.


Thanks,

Lasse Liehu

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124328: Man pages for kapidox

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124328/#review82378
---

Ship it!


For all that troff is dark magic, the important parts of the file look easy to 
maintain (although I do wonder whether using help2man wouldn't be easier), so 
I'm happy to have this in if it makes downstreams' lives easier.


setup.py (lines 37 - 46)


There's no need to repeat the destination directory - the second part of 
the tuple is a list, so all the files can go in a single list.


- Alex Merry


On July 11, 2015, 9:34 p.m., Scott Kitterman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124328/
> ---
> 
> (Updated July 11, 2015, 9:34 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Merry, Aurélien Gâteau, and Kevin 
> Krammer.
> 
> 
> Repository: kapidox
> 
> 
> Description
> ---
> 
> Add man pages for kapidox scripts
> 
> 
> Diffs
> -
> 
>   docs/depdiagram-generate-all.1 PRE-CREATION 
>   docs/depdiagram-generate.1 PRE-CREATION 
>   docs/depdiagram-prepare.1 PRE-CREATION 
>   docs/kgenapidox.1 PRE-CREATION 
>   docs/kgenframeworksapidox.1 PRE-CREATION 
>   setup.py 083543f 
> 
> Diff: https://git.reviewboard.kde.org/r/124328/diff/
> 
> 
> Testing
> ---
> 
> Built and installed updated version and verified man pages were correctly 
> installed and readable in the KDE man page viewer.
> 
> 
> Thanks,
> 
> Scott Kitterman
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124331/
---

Review request for KDE Frameworks, Jesper Pedersen and Stephen Kelly.


Repository: kitemmodels


Description
---

New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.


Diffs
-

  autotests/CMakeLists.txt f98e87d49b965998f31c5ede1fefb03b159a150f 
  autotests/kextracolumnsproxymodeltest.cpp PRE-CREATION 
  autotests/test_model_helpers.h a44db8a9cb985f69b52be96f0ffe389ebd903d6f 
  src/CMakeLists.txt 82d776f1fcc2f7b15e74f0ed47702ed570ce9892 
  src/kextracolumnsproxymodel.h PRE-CREATION 
  src/kextracolumnsproxymodel.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124331/diff/


Testing
---

Wrote autotests (as extensive as possible); used this in one real project, 
AFAIK Jesper (blackie) did as well.


Thanks,

David Faure

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124328: Man pages for kapidox

[Scott Kitterman]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124328/
---

(Updated July 12, 2015, 4 p.m.)


Review request for KDE Frameworks, Alex Merry, Aurélien Gâteau, and Kevin 
Krammer.


Changes
---

Updated change to not repeat directory and to update maintainer information in 
setup.py.

I know you said shipit, but since I made an additional change, I wanted to 
publish the diff again first.  I did consider help2man, but decided that since 
these man pages are unlikely to change very often, do it once would be better 
than adding the dependency.


Repository: kapidox


Description
---

Add man pages for kapidox scripts


Diffs (updated)
-

  docs/depdiagram-generate-all.1 PRE-CREATION 
  docs/depdiagram-generate.1 PRE-CREATION 
  docs/depdiagram-prepare.1 PRE-CREATION 
  docs/kgenapidox.1 PRE-CREATION 
  docs/kgenframeworksapidox.1 PRE-CREATION 
  setup.py 083543f 

Diff: https://git.reviewboard.kde.org/r/124328/diff/


Testing
---

Built and installed updated version and verified man pages were correctly 
installed and readable in the KDE man page viewer.


Thanks,

Scott Kitterman

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124328: Man pages for kapidox

[Allen Winter]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124328/#review82394
---


hmm.. I sorta against committing roff code into our repository.  Since very few 
people will be able to understand it in this day and age.

perhaps you can write the "source" for the man pages in pod and convert them to 
roff using pod2man.  even if we had both the pod and the roff committed I'd be 
happier than just having the raw roff. Ideally the buildsystem runs pod2man.

- Allen Winter


On July 12, 2015, 4 p.m., Scott Kitterman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124328/
> ---
> 
> (Updated July 12, 2015, 4 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Merry, Aurélien Gâteau, and Kevin 
> Krammer.
> 
> 
> Repository: kapidox
> 
> 
> Description
> ---
> 
> Add man pages for kapidox scripts
> 
> 
> Diffs
> -
> 
>   docs/depdiagram-generate-all.1 PRE-CREATION 
>   docs/depdiagram-generate.1 PRE-CREATION 
>   docs/depdiagram-prepare.1 PRE-CREATION 
>   docs/kgenapidox.1 PRE-CREATION 
>   docs/kgenframeworksapidox.1 PRE-CREATION 
>   setup.py 083543f 
> 
> Diff: https://git.reviewboard.kde.org/r/124328/diff/
> 
> 
> Testing
> ---
> 
> Built and installed updated version and verified man pages were correctly 
> installed and readable in the KDE man page viewer.
> 
> 
> Thanks,
> 
> Scott Kitterman
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124328: Man pages for kapidox

[Kevin Krammer]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124328/#review82397
---


I thought our man pages are written in docbook and then translated by the usual 
docbook workflow?

- Kevin Krammer


On Juli 12, 2015, 4 nachm., Scott Kitterman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124328/
> ---
> 
> (Updated Juli 12, 2015, 4 nachm.)
> 
> 
> Review request for KDE Frameworks, Alex Merry, Aurélien Gâteau, and Kevin 
> Krammer.
> 
> 
> Repository: kapidox
> 
> 
> Description
> ---
> 
> Add man pages for kapidox scripts
> 
> 
> Diffs
> -
> 
>   docs/depdiagram-generate-all.1 PRE-CREATION 
>   docs/depdiagram-generate.1 PRE-CREATION 
>   docs/depdiagram-prepare.1 PRE-CREATION 
>   docs/kgenapidox.1 PRE-CREATION 
>   docs/kgenframeworksapidox.1 PRE-CREATION 
>   setup.py 083543f 
> 
> Diff: https://git.reviewboard.kde.org/r/124328/diff/
> 
> 
> Testing
> ---
> 
> Built and installed updated version and verified man pages were correctly 
> installed and readable in the KDE man page viewer.
> 
> 
> Thanks,
> 
> Scott Kitterman
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124328: Man pages for kapidox

[Albert Astals Cid]

> On jul. 12, 2015, 4:45 p.m., Kevin Krammer wrote:
> > I thought our man pages are written in docbook and then translated by the 
> > usual docbook workflow?

Correct.


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124328/#review82397
---


On jul. 12, 2015, 4 p.m., Scott Kitterman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124328/
> ---
> 
> (Updated jul. 12, 2015, 4 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Merry, Aurélien Gâteau, and Kevin 
> Krammer.
> 
> 
> Repository: kapidox
> 
> 
> Description
> ---
> 
> Add man pages for kapidox scripts
> 
> 
> Diffs
> -
> 
>   docs/depdiagram-generate-all.1 PRE-CREATION 
>   docs/depdiagram-generate.1 PRE-CREATION 
>   docs/depdiagram-prepare.1 PRE-CREATION 
>   docs/kgenapidox.1 PRE-CREATION 
>   docs/kgenframeworksapidox.1 PRE-CREATION 
>   setup.py 083543f 
> 
> Diff: https://git.reviewboard.kde.org/r/124328/diff/
> 
> 
> Testing
> ---
> 
> Built and installed updated version and verified man pages were correctly 
> installed and readable in the KDE man page viewer.
> 
> 
> Thanks,
> 
> Scott Kitterman
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124328: Man pages for kapidox

[Luigi Toscano]

> On Lug. 12, 2015, 6:45 p.m., Kevin Krammer wrote:
> > I thought our man pages are written in docbook and then translated by the 
> > usual docbook workflow?
> 
> Albert Astals Cid wrote:
> Correct.

Yes, because they can be translated. But that means a dependency on kdoctools. 
On the other side, kapidox is a tier1 (I would say tier0) project, it's python, 
it's not really Qt based. I don't have a proper solution for this problem right 
now.


- Luigi


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124328/#review82397
---


On Lug. 12, 2015, 6 p.m., Scott Kitterman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124328/
> ---
> 
> (Updated Lug. 12, 2015, 6 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Merry, Aurélien Gâteau, and Kevin 
> Krammer.
> 
> 
> Repository: kapidox
> 
> 
> Description
> ---
> 
> Add man pages for kapidox scripts
> 
> 
> Diffs
> -
> 
>   docs/depdiagram-generate-all.1 PRE-CREATION 
>   docs/depdiagram-generate.1 PRE-CREATION 
>   docs/depdiagram-prepare.1 PRE-CREATION 
>   docs/kgenapidox.1 PRE-CREATION 
>   docs/kgenframeworksapidox.1 PRE-CREATION 
>   setup.py 083543f 
> 
> Diff: https://git.reviewboard.kde.org/r/124328/diff/
> 
> 
> Testing
> ---
> 
> Built and installed updated version and verified man pages were correctly 
> installed and readable in the KDE man page viewer.
> 
> 
> Thanks,
> 
> Scott Kitterman
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124328: Man pages for kapidox

[Scott Kitterman]

> On July 12, 2015, 4:45 p.m., Kevin Krammer wrote:
> > I thought our man pages are written in docbook and then translated by the 
> > usual docbook workflow?
> 
> Albert Astals Cid wrote:
> Correct.
> 
> Luigi Toscano wrote:
> Yes, because they can be translated. But that means a dependency on 
> kdoctools. On the other side, kapidox is a tier1 (I would say tier0) project, 
> it's python, it's not really Qt based. I don't have a proper solution for 
> this problem right now.

It's really different than the other frameworks.  It's not a framework as much 
as a tool (Python application) for developing the frameworks.  I don't think it 
can/should be done exactly the same as everything else.


- Scott


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124328/#review82397
---


On July 12, 2015, 4 p.m., Scott Kitterman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124328/
> ---
> 
> (Updated July 12, 2015, 4 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Merry, Aurélien Gâteau, and Kevin 
> Krammer.
> 
> 
> Repository: kapidox
> 
> 
> Description
> ---
> 
> Add man pages for kapidox scripts
> 
> 
> Diffs
> -
> 
>   docs/depdiagram-generate-all.1 PRE-CREATION 
>   docs/depdiagram-generate.1 PRE-CREATION 
>   docs/depdiagram-prepare.1 PRE-CREATION 
>   docs/kgenapidox.1 PRE-CREATION 
>   docs/kgenframeworksapidox.1 PRE-CREATION 
>   setup.py 083543f 
> 
> Diff: https://git.reviewboard.kde.org/r/124328/diff/
> 
> 
> Testing
> ---
> 
> Built and installed updated version and verified man pages were correctly 
> installed and readable in the KDE man page viewer.
> 
> 
> Thanks,
> 
> Scott Kitterman
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124328: Man pages for kapidox

[Scott Kitterman]

> On July 12, 2015, 4:31 p.m., Allen Winter wrote:
> > hmm.. I sorta against committing roff code into our repository.  Since very 
> > few people will be able to understand it in this day and age.
> > 
> > perhaps you can write the "source" for the man pages in pod and convert 
> > them to roff using pod2man.  even if we had both the pod and the roff 
> > committed I'd be happier than just having the raw roff. Ideally the 
> > buildsystem runs pod2man.

If I was going to go this route, I think I'd use help2man, but I don't think 
it's worth the added dependency since I expect these man pages to almost never 
change.


- Scott


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124328/#review82394
---


On July 12, 2015, 4 p.m., Scott Kitterman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124328/
> ---
> 
> (Updated July 12, 2015, 4 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Merry, Aurélien Gâteau, and Kevin 
> Krammer.
> 
> 
> Repository: kapidox
> 
> 
> Description
> ---
> 
> Add man pages for kapidox scripts
> 
> 
> Diffs
> -
> 
>   docs/depdiagram-generate-all.1 PRE-CREATION 
>   docs/depdiagram-generate.1 PRE-CREATION 
>   docs/depdiagram-prepare.1 PRE-CREATION 
>   docs/kgenapidox.1 PRE-CREATION 
>   docs/kgenframeworksapidox.1 PRE-CREATION 
>   setup.py 083543f 
> 
> Diff: https://git.reviewboard.kde.org/r/124328/diff/
> 
> 
> Testing
> ---
> 
> Built and installed updated version and verified man pages were correctly 
> installed and readable in the KDE man page viewer.
> 
> 
> Thanks,
> 
> Scott Kitterman
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124328: Man pages for kapidox

[Albert Astals Cid]

> On jul. 12, 2015, 4:45 p.m., Kevin Krammer wrote:
> > I thought our man pages are written in docbook and then translated by the 
> > usual docbook workflow?
> 
> Albert Astals Cid wrote:
> Correct.
> 
> Luigi Toscano wrote:
> Yes, because they can be translated. But that means a dependency on 
> kdoctools. On the other side, kapidox is a tier1 (I would say tier0) project, 
> it's python, it's not really Qt based. I don't have a proper solution for 
> this problem right now.
> 
> Scott Kitterman wrote:
> It's really different than the other frameworks.  It's not a framework as 
> much as a tool (Python application) for developing the frameworks.  I don't 
> think it can/should be done exactly the same as everything else.

I'm not happy for not keeping our requeriment that our user visible stuff is 
translatable.


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124328/#review82397
---


On jul. 12, 2015, 4 p.m., Scott Kitterman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124328/
> ---
> 
> (Updated jul. 12, 2015, 4 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Merry, Aurélien Gâteau, and Kevin 
> Krammer.
> 
> 
> Repository: kapidox
> 
> 
> Description
> ---
> 
> Add man pages for kapidox scripts
> 
> 
> Diffs
> -
> 
>   docs/depdiagram-generate-all.1 PRE-CREATION 
>   docs/depdiagram-generate.1 PRE-CREATION 
>   docs/depdiagram-prepare.1 PRE-CREATION 
>   docs/kgenapidox.1 PRE-CREATION 
>   docs/kgenframeworksapidox.1 PRE-CREATION 
>   setup.py 083543f 
> 
> Diff: https://git.reviewboard.kde.org/r/124328/diff/
> 
> 
> Testing
> ---
> 
> Built and installed updated version and verified man pages were correctly 
> installed and readable in the KDE man page viewer.
> 
> 
> Thanks,
> 
> Scott Kitterman
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124328: Man pages for kapidox

[Scott Kitterman]

> On July 12, 2015, 4:45 p.m., Kevin Krammer wrote:
> > I thought our man pages are written in docbook and then translated by the 
> > usual docbook workflow?
> 
> Albert Astals Cid wrote:
> Correct.
> 
> Luigi Toscano wrote:
> Yes, because they can be translated. But that means a dependency on 
> kdoctools. On the other side, kapidox is a tier1 (I would say tier0) project, 
> it's python, it's not really Qt based. I don't have a proper solution for 
> this problem right now.
> 
> Scott Kitterman wrote:
> It's really different than the other frameworks.  It's not a framework as 
> much as a tool (Python application) for developing the frameworks.  I don't 
> think it can/should be done exactly the same as everything else.
> 
> Albert Astals Cid wrote:
> I'm not happy for not keeping our requeriment that our user visible stuff 
> is translatable.

The --help output (which is the only documentation that's currently provided) 
is already not translatable, so this is no different.


- Scott


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124328/#review82397
---


On July 12, 2015, 4 p.m., Scott Kitterman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124328/
> ---
> 
> (Updated July 12, 2015, 4 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Merry, Aurélien Gâteau, and Kevin 
> Krammer.
> 
> 
> Repository: kapidox
> 
> 
> Description
> ---
> 
> Add man pages for kapidox scripts
> 
> 
> Diffs
> -
> 
>   docs/depdiagram-generate-all.1 PRE-CREATION 
>   docs/depdiagram-generate.1 PRE-CREATION 
>   docs/depdiagram-prepare.1 PRE-CREATION 
>   docs/kgenapidox.1 PRE-CREATION 
>   docs/kgenframeworksapidox.1 PRE-CREATION 
>   setup.py 083543f 
> 
> Diff: https://git.reviewboard.kde.org/r/124328/diff/
> 
> 
> Testing
> ---
> 
> Built and installed updated version and verified man pages were correctly 
> installed and readable in the KDE man page viewer.
> 
> 
> Thanks,
> 
> Scott Kitterman
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124331/#review82440
---



autotests/kextracolumnsproxymodeltest.cpp (line 1)


It should have a licence.


I think this is really cool. :)

+1

- Aleix Pol Gonzalez


On July 12, 2015, 1:13 p.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124331/
> ---
> 
> (Updated July 12, 2015, 1:13 p.m.)
> 
> 
> Review request for KDE Frameworks, Jesper Pedersen and Stephen Kelly.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> ---
> 
> New proxy: KExtraColumnsProxyModel, allows to add columns to an existing 
> model.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt f98e87d49b965998f31c5ede1fefb03b159a150f 
>   autotests/kextracolumnsproxymodeltest.cpp PRE-CREATION 
>   autotests/test_model_helpers.h a44db8a9cb985f69b52be96f0ffe389ebd903d6f 
>   src/CMakeLists.txt 82d776f1fcc2f7b15e74f0ed47702ed570ce9892 
>   src/kextracolumnsproxymodel.h PRE-CREATION 
>   src/kextracolumnsproxymodel.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124331/diff/
> 
> 
> Testing
> ---
> 
> Wrote autotests (as extensive as possible); used this in one real project, 
> AFAIK Jesper (blackie) did as well.
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel