Re: Review Request 124065: KMimeType mimeTypeForNameAndData() -> mimeTypeForFileNameAndData()
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124065/ --- (Updated July 26, 2015, 9:38 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Laurent Montel. Changes --- Submitted with commit 7c937ed14e89adcc62f8ee050a84c966053307b4 by Jaroslaw Staniek to branch master. Repository: kde-dev-scripts Description --- There's apparent mistake; mimeTypeForNameAndData() does not exist, shall be mimeTypeForFileNameAndData(). Diffs - kf5/convert-kmimetype.pl 363ff21cd46331efe209a5051feca58e971739b2 Diff: https://git.reviewboard.kde.org/r/124065/diff/ Testing --- Thanks, Jarosław Staniek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124474: KCharSelect - fit contents to width
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124474/ --- (Updated July 26, 2015, 4:44 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit e515469fe112069b352fa9de1d967f4a10dd2abb by Rajeesh K Nambiar to branch master. Repository: kwidgetsaddons Description --- When displaying non-Latin character sets (for instance Malayalam[ml_IN] in South Asian languages group), letters were not fitting in table cell contents and get truncated. See screenshots. Fix this by calling QTableView=>resizeColumnsToContents(). Diffs - src/kcharselect.cpp 06c52c2 Diff: https://git.reviewboard.kde.org/r/124474/diff/ Testing --- Tested with South Asian languages, Latin (basic and extended) character sets. Didn't notice any regression. File Attachments KCharSelect before https://git.reviewboard.kde.org/media/uploaded/files/2015/07/26/b14b2712-2061-46db-a282-ee2a3905ac0e__kcharselect-before.png KCharSelect after https://git.reviewboard.kde.org/media/uploaded/files/2015/07/26/b9ae10fe-8963-4652-88ed-02e1b79f88f2__kcharselect-after.png Thanks, Rajeesh K Nambiar ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124474: KCharSelect - fit contents to width
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124474/#review83000 --- Ship it! Looks good to me. - David Faure On July 26, 2015, 4:35 p.m., Rajeesh K Nambiar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124474/ > --- > > (Updated July 26, 2015, 4:35 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kwidgetsaddons > > > Description > --- > > When displaying non-Latin character sets (for instance Malayalam[ml_IN] in > South Asian languages group), letters were not fitting in table cell contents > and get truncated. See screenshots. Fix this by calling > QTableView=>resizeColumnsToContents(). > > > Diffs > - > > src/kcharselect.cpp 06c52c2 > > Diff: https://git.reviewboard.kde.org/r/124474/diff/ > > > Testing > --- > > Tested with South Asian languages, Latin (basic and extended) character sets. > Didn't notice any regression. > > > File Attachments > > > KCharSelect before > > https://git.reviewboard.kde.org/media/uploaded/files/2015/07/26/b14b2712-2061-46db-a282-ee2a3905ac0e__kcharselect-before.png > KCharSelect after > > https://git.reviewboard.kde.org/media/uploaded/files/2015/07/26/b9ae10fe-8963-4652-88ed-02e1b79f88f2__kcharselect-after.png > > > Thanks, > > Rajeesh K Nambiar > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 124474: KCharSelect - fit contents to width
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124474/ --- Review request for KDE Frameworks and David Faure. Repository: kwidgetsaddons Description --- When displaying non-Latin character sets (for instance Malayalam[ml_IN] in South Asian languages group), letters were not fitting in table cell contents and get truncated. See screenshots. Fix this by calling QTableView=>resizeColumnsToContents(). Diffs - src/kcharselect.cpp 06c52c2 Diff: https://git.reviewboard.kde.org/r/124474/diff/ Testing --- Tested with South Asian languages, Latin (basic and extended) character sets. Didn't notice any regression. File Attachments KCharSelect before https://git.reviewboard.kde.org/media/uploaded/files/2015/07/26/b14b2712-2061-46db-a282-ee2a3905ac0e__kcharselect-before.png KCharSelect after https://git.reviewboard.kde.org/media/uploaded/files/2015/07/26/b9ae10fe-8963-4652-88ed-02e1b79f88f2__kcharselect-after.png Thanks, Rajeesh K Nambiar ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124467: Don't generate deprecated code
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124467/#review82993 --- Ship it! Ship It! - David Faure On July 26, 2015, 12:49 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124467/ > --- > > (Updated July 26, 2015, 12:49 p.m.) > > > Review request for KDE Frameworks and Matthew Dawson. > > > Repository: kconfig > > > Description > --- > > ::usrWriteConfig is deprecated, use ::usrSave as recommended by the > documentation. > > > Diffs > - > > autotests/kconfig_compiler/test_signal.cpp.ref 6faf8bd > autotests/kconfig_compiler/test_signal.h.ref e9f9c94 > src/core/kcoreconfigskeleton.h 4727849 > src/kconfig_compiler/kconfig_compiler.cpp 246cc92 > > Diff: https://git.reviewboard.kde.org/r/124467/diff/ > > > Testing > --- > > Tests still pass. > I don't get the warnings anymore when building. > > > Thanks, > > Aleix Pol Gonzalez > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124467: Don't generate deprecated code
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124467/#review82991 --- Ship it! Ship It! - Albert Astals Cid On jul. 26, 2015, 12:49 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124467/ > --- > > (Updated jul. 26, 2015, 12:49 p.m.) > > > Review request for KDE Frameworks and Matthew Dawson. > > > Repository: kconfig > > > Description > --- > > ::usrWriteConfig is deprecated, use ::usrSave as recommended by the > documentation. > > > Diffs > - > > autotests/kconfig_compiler/test_signal.cpp.ref 6faf8bd > autotests/kconfig_compiler/test_signal.h.ref e9f9c94 > src/core/kcoreconfigskeleton.h 4727849 > src/kconfig_compiler/kconfig_compiler.cpp 246cc92 > > Diff: https://git.reviewboard.kde.org/r/124467/diff/ > > > Testing > --- > > Tests still pass. > I don't get the warnings anymore when building. > > > Thanks, > > Aleix Pol Gonzalez > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124467: Don't generate deprecated code
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124467/ --- (Updated July 26, 2015, 2:49 p.m.) Review request for KDE Frameworks and Matthew Dawson. Changes --- Fix KCoreConfigSkeleton::save documentation as suggested by Albert on IRC. Repository: kconfig Description --- ::usrWriteConfig is deprecated, use ::usrSave as recommended by the documentation. Diffs (updated) - autotests/kconfig_compiler/test_signal.cpp.ref 6faf8bd autotests/kconfig_compiler/test_signal.h.ref e9f9c94 src/core/kcoreconfigskeleton.h 4727849 src/kconfig_compiler/kconfig_compiler.cpp 246cc92 Diff: https://git.reviewboard.kde.org/r/124467/diff/ Testing --- Tests still pass. I don't get the warnings anymore when building. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
