Re: kross unit tests broken
On Sunday 02 August 2015 18:45:38 Alexander Potashev wrote: 2015-08-01 12:57 GMT+03:00 David Faure fa...@kde.org: Hello Alexander, thanks for your recent commits related to the unit tests in kross. However it seems that they don't pass ;) See https://build.kde.org/job/kross%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/10/console I get the same error locally. Action::setInterpreter: interpreter not found: python Can you look into it? Hi David, This is because kross-interpreters[python] is not installed on CI server. I had to move these tests into the kross-interpreters repo, but didn't do that yet because I'm not sure how to share the autotests code between kross.git and kross-interpreters.git repos. I think we can disable all the python tests from kross.git. Why don't we move all the failing tests to kross-interpreters, rather? Clearly these can stay, since the pass: kross-metafunctiontest kross-unittest-es While these clearly require the python interpreter: 18:28:25 4 - kross-guiform-py (Failed) 18:28:25 5 - kross-guiqt-py (Failed) 18:28:25 6 - kross-guitk-py (Failed) 18:28:25 7 - kross-test-py (Failed) 18:28:25 8 - kross-unittest-py (Failed) The only one I'm not sure about is krossqtstest-test-es It says QTS (qtscript?) but fails due to python !?!? https://build.kde.org/job/kross%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/13/console kross is the only module with failing unittests now in KF5, I want to get it all green again. We *must* get it all green again. Disabling the tests again doesn't sound like a good approach to me, better move them to where they can be run. Do you agree? Do you want to handle it, or should I? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124682: Cmake fail to parse proper taglib version - extra-cmake-modules
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124682/ --- (Updated Aug. 11, 2015, 8:11 a.m.) Review request for KDE Frameworks. Repository: extra-cmake-modules Description --- Wrong string comparison of taglib version Diffs - attic/modules/FindTaglib.cmake 5bbb8ee Diff: https://git.reviewboard.kde.org/r/124682/diff/ Testing --- Run cmake with kdesrc-build on debian strecth taglib version correctly found and parsed Thanks, Luca Sartorelli ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124633: Parse formfactor in KService and KPluginInfo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124633/ --- (Updated Aug. 11, 2015, 11:05 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Plasma, Alex Richardson, and David Faure. Changes --- Submitted with commit 6d82a824b3a7e5e87b4691439ecba064a75fa8a1 by Sebastian Kügler to branch master. Repository: kservice Description --- Parse formfactor in KService and KPluginInfo Add an accessor QStringList KPluginInfo::formFactors() This corresponds to the X-KDE-FormFactors value in the .desktop file, and to the FormFactors value in the KPlugin block of the json metadata. We already have this in KPluginMetaData, this patch brings KPluginInfo and KService in line with that. Previously, the keys would not be recognized, and thus be missing from the KPluginMetaData if created through a KPluginInfo or a KService. This patch fixes this inconsistent behaviour. Also bump the sycoca version. Diffs - autotests/fakeplugin.desktop 200f023 autotests/fakeplugin.json de4aed9 autotests/kplugininfotest.cpp d99b92a autotests/kservicetest.h 380cf7b autotests/kservicetest.cpp 2c71331 src/services/kplugininfo.h 7b98576 src/services/kplugininfo.cpp 56dc0b4 src/services/kservice.cpp 3639a28 src/services/kservice_p.h bf59f38 src/sycoca/ksycoca.cpp 32d1689 Diff: https://git.reviewboard.kde.org/r/124633/diff/ Testing --- Added new tests, no problems. ksycocathreadtest currently fails, but this is unrelated (also in master without this patch). Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124696: Fix (worrying) MSVC warning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124696/ --- (Updated Aug. 11, 2015, 1:22 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Mirko Boehm. Changes --- Submitted with commit ea52fb68bad35c91ed2cb39dc8cd0aeeea2f4f48 by Kevin Funk to branch master. Repository: threadweaver Description --- Warning: Z:\kderoot\download\git\threadweaver\src\iddecorator.cpp(196): warning C4312: 'r einterpret_cast': conversion from 'const int' to 'ThreadWeaver::IdDecorator::Pri vate2 *' of greater size Diffs - src/iddecorator.cpp 5bf6d002eb2671a02f330cd3022e0692a0343fe4 Diff: https://git.reviewboard.kde.org/r/124696/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 24 - Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/24/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 11 Aug 2015 11:05:28 + Build duration: 4 min 18 sec CHANGE SET Revision 6d82a824b3a7e5e87b4691439ecba064a75fa8a1 by sebas: (Parse formfactor in KService and KPluginInfo) change: edit src/sycoca/ksycoca.cpp change: edit autotests/kservicetest.cpp change: edit autotests/kservicetest.h change: edit src/services/kservice.cpp change: edit src/services/kplugininfo.h change: edit src/services/kplugininfo.cpp change: edit src/services/kservice_p.h change: edit autotests/kplugininfotest.cpp change: edit autotests/fakeplugin.json change: edit autotests/fakeplugin.desktop JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 8 test(s)Failed: TestSuite.ksycocathreadtest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 6/7 (86%)FILES 69/78 (88%)CLASSES 69/78 (88%)LINE 5359/8011 (67%)CONDITIONAL 2740/4142 (66%) By packages autotests FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 1281/1387 (92%)CONDITIONAL 819/1472 (56%) src.kbuildsycoca FILES 14/18 (78%)CLASSES 14/18 (78%)LINE 1458/2007 (73%)CONDITIONAL 802/1048 (77%) src.kdeinit FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/324 (0%)CONDITIONAL 0/0 (100%) src.plugin FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 48/101 (48%)CONDITIONAL 36/54 (67%) src.services FILES 28/29 (97%)CLASSES 28/29 (97%)LINE 1787/3084 (58%)CONDITIONAL 758/1120 (68%) src.sycoca FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 675/987 (68%)CONDITIONAL 291/402 (72%) tests.pluginlocator FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 110/121 (91%)CONDITIONAL 34/46 (74%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 24 - Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/24/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 11 Aug 2015 11:05:28 + Build duration: 4 min 18 sec CHANGE SET Revision 6d82a824b3a7e5e87b4691439ecba064a75fa8a1 by sebas: (Parse formfactor in KService and KPluginInfo) change: edit src/sycoca/ksycoca.cpp change: edit autotests/kservicetest.cpp change: edit autotests/kservicetest.h change: edit src/services/kservice.cpp change: edit src/services/kplugininfo.h change: edit src/services/kplugininfo.cpp change: edit src/services/kservice_p.h change: edit autotests/kplugininfotest.cpp change: edit autotests/fakeplugin.json change: edit autotests/fakeplugin.desktop JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 8 test(s)Failed: TestSuite.ksycocathreadtest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 6/7 (86%)FILES 69/78 (88%)CLASSES 69/78 (88%)LINE 5359/8011 (67%)CONDITIONAL 2740/4142 (66%) By packages autotests FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 1281/1387 (92%)CONDITIONAL 819/1472 (56%) src.kbuildsycoca FILES 14/18 (78%)CLASSES 14/18 (78%)LINE 1458/2007 (73%)CONDITIONAL 802/1048 (77%) src.kdeinit FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/324 (0%)CONDITIONAL 0/0 (100%) src.plugin FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 48/101 (48%)CONDITIONAL 36/54 (67%) src.services FILES 28/29 (97%)CLASSES 28/29 (97%)LINE 1787/3084 (58%)CONDITIONAL 758/1120 (68%) src.sycoca FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 675/987 (68%)CONDITIONAL 291/402 (72%) tests.pluginlocator FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 110/121 (91%)CONDITIONAL 34/46 (74%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: [kubuntu-devel] Re: git moves
On Tue, Aug 11, 2015 at 01:18:20PM +0200, Valentin Rusu wrote: * Jonathan Riddell j...@jriddell.org [2015-08-05 18:11:56 +0200]: some changes to pkg-kde git today: I added kwallet-pam to plasma Why not include the kwallet-pam module in the kwallet framework? The src/runtime would be the perfect place for that module and users would have all the required pieces together. If nobody is against this merging - and to be sure I copy kde-frameworks-devel - then it's a matter of importing the kwallet-map repo into a directory under kwallet/src/runtime. I could help with that. This is a change in Plasma release tars (rather than Kubuntu packaging) and it was added there because Martin K said it was ported and should be released, and I think his motivation was just that enough people bugged him that he made Alex's work compile. But nobody is around who especially wants to maintain it so if you want to move it into wallet framework that would be very welcome. Jonathan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 124696: Fix (worrying) MSVC warning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124696/ --- Review request for KDE Frameworks and Mirko Boehm. Repository: threadweaver Description --- Warning: Z:\kderoot\download\git\threadweaver\src\iddecorator.cpp(196): warning C4312: 'r einterpret_cast': conversion from 'const int' to 'ThreadWeaver::IdDecorator::Pri vate2 *' of greater size Diffs - src/iddecorator.cpp 5bf6d002eb2671a02f330cd3022e0692a0343fe4 Diff: https://git.reviewboard.kde.org/r/124696/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124633: Parse formfactor in KService and KPluginInfo
On Aug. 6, 2015, 7:13 a.m., David Faure wrote: If the goal is to query this property for the K menu for instance, aren't you missing an accessor in KService? OK, on the other hand, if this is the only user, then property(...) would do too, but still, compile-time checking is more robust. About ksycocathreadtest: I just pushed many fixes for it, does it pass for you now? Sebastian Kügler wrote: My primary concern was to make sure FormFactors is not lost in conversion. Adding API in KPluginInfo was more a side-effect of this (for symmetry reasons with surrounding code). I don't care so much for an accessor also in KService. The ksycocathreadtest now succeeds, thanks. OK to commit this? - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124633/#review83476 --- On Aug. 5, 2015, 10:41 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124633/ --- (Updated Aug. 5, 2015, 10:41 p.m.) Review request for KDE Frameworks, Plasma, Alex Richardson, and David Faure. Repository: kservice Description --- Parse formfactor in KService and KPluginInfo Add an accessor QStringList KPluginInfo::formFactors() This corresponds to the X-KDE-FormFactors value in the .desktop file, and to the FormFactors value in the KPlugin block of the json metadata. We already have this in KPluginMetaData, this patch brings KPluginInfo and KService in line with that. Previously, the keys would not be recognized, and thus be missing from the KPluginMetaData if created through a KPluginInfo or a KService. This patch fixes this inconsistent behaviour. Also bump the sycoca version. Diffs - autotests/fakeplugin.desktop 200f023 autotests/fakeplugin.json de4aed9 autotests/kplugininfotest.cpp d99b92a autotests/kservicetest.h 380cf7b autotests/kservicetest.cpp 2c71331 src/services/kplugininfo.h 7b98576 src/services/kplugininfo.cpp 56dc0b4 src/services/kservice.cpp 3639a28 src/services/kservice_p.h bf59f38 src/sycoca/ksycoca.cpp 32d1689 Diff: https://git.reviewboard.kde.org/r/124633/diff/ Testing --- Added new tests, no problems. ksycocathreadtest currently fails, but this is unrelated (also in master without this patch). Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 24 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/24/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 11 Aug 2015 11:05:28 + Build duration: 4 min 39 sec CHANGE SET Revision 6d82a824b3a7e5e87b4691439ecba064a75fa8a1 by sebas: (Parse formfactor in KService and KPluginInfo) change: edit src/services/kplugininfo.cpp change: edit src/services/kservice.cpp change: edit src/services/kplugininfo.h change: edit src/sycoca/ksycoca.cpp change: edit autotests/fakeplugin.json change: edit autotests/fakeplugin.desktop change: edit autotests/kservicetest.h change: edit autotests/kservicetest.cpp change: edit src/services/kservice_p.h change: edit autotests/kplugininfotest.cpp JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 8 test(s)Failed: TestSuite.ksycocathreadtest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 6/7 (86%)FILES 69/78 (88%)CLASSES 69/78 (88%)LINE 5360/8011 (67%)CONDITIONAL 2741/4142 (66%) By packages autotests FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 1281/1387 (92%)CONDITIONAL 819/1472 (56%) src.kbuildsycoca FILES 14/18 (78%)CLASSES 14/18 (78%)LINE 1457/2007 (73%)CONDITIONAL 801/1048 (76%) src.kdeinit FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/324 (0%)CONDITIONAL 0/0 (100%) src.plugin FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 48/101 (48%)CONDITIONAL 36/54 (67%) src.services FILES 28/29 (97%)CLASSES 28/29 (97%)LINE 1788/3084 (58%)CONDITIONAL 759/1120 (68%) src.sycoca FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 676/987 (68%)CONDITIONAL 292/402 (73%) tests.pluginlocator FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 110/121 (91%)CONDITIONAL 34/46 (74%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124696: Fix (worrying) MSVC warning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124696/#review83699 --- Ship it! src/iddecorator.cpp (line 36) https://git.reviewboard.kde.org/r/124696/#comment57929 while at it: make static or wrap in anonymous namespace (in a separate commit?) - Milian Wolff On Aug. 11, 2015, 11 a.m., Kevin Funk wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124696/ --- (Updated Aug. 11, 2015, 11 a.m.) Review request for KDE Frameworks and Mirko Boehm. Repository: threadweaver Description --- Warning: Z:\kderoot\download\git\threadweaver\src\iddecorator.cpp(196): warning C4312: 'r einterpret_cast': conversion from 'const int' to 'ThreadWeaver::IdDecorator::Pri vate2 *' of greater size Diffs - src/iddecorator.cpp 5bf6d002eb2671a02f330cd3022e0692a0343fe4 Diff: https://git.reviewboard.kde.org/r/124696/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124633: Parse formfactor in KService and KPluginInfo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124633/#review83697 --- Ship it! - David Faure On Aug. 5, 2015, 10:41 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124633/ --- (Updated Aug. 5, 2015, 10:41 p.m.) Review request for KDE Frameworks, Plasma, Alex Richardson, and David Faure. Repository: kservice Description --- Parse formfactor in KService and KPluginInfo Add an accessor QStringList KPluginInfo::formFactors() This corresponds to the X-KDE-FormFactors value in the .desktop file, and to the FormFactors value in the KPlugin block of the json metadata. We already have this in KPluginMetaData, this patch brings KPluginInfo and KService in line with that. Previously, the keys would not be recognized, and thus be missing from the KPluginMetaData if created through a KPluginInfo or a KService. This patch fixes this inconsistent behaviour. Also bump the sycoca version. Diffs - autotests/fakeplugin.desktop 200f023 autotests/fakeplugin.json de4aed9 autotests/kplugininfotest.cpp d99b92a autotests/kservicetest.h 380cf7b autotests/kservicetest.cpp 2c71331 src/services/kplugininfo.h 7b98576 src/services/kplugininfo.cpp 56dc0b4 src/services/kservice.cpp 3639a28 src/services/kservice_p.h bf59f38 src/sycoca/ksycoca.cpp 32d1689 Diff: https://git.reviewboard.kde.org/r/124633/diff/ Testing --- Added new tests, no problems. ksycocathreadtest currently fails, but this is unrelated (also in master without this patch). Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 124698: KPasswordDialog: allow the user to show the password
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124698/ --- Review request for KDE Frameworks, KDE Usability and Christoph Feck. Bugs: 224686 https://bugs.kde.org/show_bug.cgi?id=224686 Repository: kwidgetsaddons Description --- Starting from Qt 5.2, adding a trailing QAction to a QLineEdit is fairly trivial. This patch implements such an action in order to allow a user to show the password being typed. The action is only available if no password is given to the dialog as preset. About the icon: for now I've used `games-hint` from Breeze. Let me know whether there is a more relevant icon already available. If not, we can either request it or create a symlink for this one, e.g. `password-hint` or similar. About the last screenshot: the greyed icon is due to Qt bug [39660](https://bugreports.qt.io/browse/QTBUG-39660). Once fixed upstream (Qt 5.5?), the action will be properly hidden and there will be no icon greyed out. Diffs - src/kpassworddialog.h 9de2724640f483d5ab1134510fb84e1245814d90 src/kpassworddialog.cpp 3d348964b4c44d26c44856fc08c199007a195aca Diff: https://git.reviewboard.kde.org/r/124698/diff/ Testing --- * Create a default KPasswordDialog. The new action is shown as soon as a password is being typed. The action is no more available as soon as the line edit is cleared. * Create a default KPasswordDialog, call `setPassword()` with a non-empty password and then show the dialog. The action is not available. File Attachments kpassworddialog1.png https://git.reviewboard.kde.org/media/uploaded/files/2015/08/11/8e7e0262-c185-42a3-a713-abea97619989__kpassworddialog1.png kpassworddialog2.png https://git.reviewboard.kde.org/media/uploaded/files/2015/08/11/90f1cbf4-952d-498f-b2a6-27d52a1f650f__kpassworddialog2.png kpassworddialog3.png https://git.reviewboard.kde.org/media/uploaded/files/2015/08/11/b4779acb-31b1-4950-87a4-6e65b5de16c6__kpassworddialog3.png Thanks, Elvis Angelaccio ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124698: KPasswordDialog: allow the user to show the password
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124698/#review83709 --- src/kpassworddialog.cpp (line 128) https://git.reviewboard.kde.org/r/124698/#comment57930 ... and add a tooltip :) - Christoph Feck On Aug. 11, 2015, 2:10 p.m., Elvis Angelaccio wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124698/ --- (Updated Aug. 11, 2015, 2:10 p.m.) Review request for KDE Frameworks, KDE Usability and Christoph Feck. Bugs: 224686 https://bugs.kde.org/show_bug.cgi?id=224686 Repository: kwidgetsaddons Description --- Starting from Qt 5.2, adding a trailing QAction to a QLineEdit is fairly trivial. This patch implements such an action in order to allow a user to show the password being typed. The action is only available if no password is given to the dialog as preset. About the icon: for now I've used `games-hint` from Breeze. Let me know whether there is a more relevant icon already available. If not, we can either request it or create a symlink for this one, e.g. `password-hint` or similar. About the last screenshot: the greyed icon is due to Qt bug [39660](https://bugreports.qt.io/browse/QTBUG-39660). Once fixed upstream (Qt 5.5?), the action will be properly hidden and there will be no icon greyed out. Diffs - src/kpassworddialog.h 9de2724640f483d5ab1134510fb84e1245814d90 src/kpassworddialog.cpp 3d348964b4c44d26c44856fc08c199007a195aca Diff: https://git.reviewboard.kde.org/r/124698/diff/ Testing --- * Create a default KPasswordDialog. The new action is shown as soon as a password is being typed. The action is no more available as soon as the line edit is cleared. * Create a default KPasswordDialog, call `setPassword()` with a non-empty password and then show the dialog. The action is not available. File Attachments kpassworddialog1.png https://git.reviewboard.kde.org/media/uploaded/files/2015/08/11/8e7e0262-c185-42a3-a713-abea97619989__kpassworddialog1.png kpassworddialog2.png https://git.reviewboard.kde.org/media/uploaded/files/2015/08/11/90f1cbf4-952d-498f-b2a6-27d52a1f650f__kpassworddialog2.png kpassworddialog3.png https://git.reviewboard.kde.org/media/uploaded/files/2015/08/11/b4779acb-31b1-4950-87a4-6e65b5de16c6__kpassworddialog3.png Thanks, Elvis Angelaccio ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124698: KPasswordDialog: allow the user to show the password
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124698/ --- (Updated Ago. 11, 2015, 3:46 p.m.) Review request for KDE Frameworks and Christoph Feck. Changes --- * Added tooltips Bugs: 224686 https://bugs.kde.org/show_bug.cgi?id=224686 Repository: kwidgetsaddons Description --- Starting from Qt 5.2, adding a trailing QAction to a QLineEdit is fairly trivial. This patch implements such an action in order to allow a user to show the password being typed. The action is only available if no password is given to the dialog as preset. About the icon: for now I've used `games-hint` from Breeze. Let me know whether there is a more relevant icon already available. If not, we can either request it or create a symlink for this one, e.g. `password-hint` or similar. About the last screenshot: the greyed icon is due to Qt bug [39660](https://bugreports.qt.io/browse/QTBUG-39660). Once fixed upstream (Qt 5.5?), the action will be properly hidden and there will be no icon greyed out. Diffs (updated) - src/kpassworddialog.h 9de2724640f483d5ab1134510fb84e1245814d90 src/kpassworddialog.cpp 3d348964b4c44d26c44856fc08c199007a195aca Diff: https://git.reviewboard.kde.org/r/124698/diff/ Testing --- * Create a default KPasswordDialog. The new action is shown as soon as a password is being typed. The action is no more available as soon as the line edit is cleared. * Create a default KPasswordDialog, call `setPassword()` with a non-empty password and then show the dialog. The action is not available. File Attachments kpassworddialog1.png https://git.reviewboard.kde.org/media/uploaded/files/2015/08/11/8e7e0262-c185-42a3-a713-abea97619989__kpassworddialog1.png kpassworddialog2.png https://git.reviewboard.kde.org/media/uploaded/files/2015/08/11/90f1cbf4-952d-498f-b2a6-27d52a1f650f__kpassworddialog2.png kpassworddialog3.png https://git.reviewboard.kde.org/media/uploaded/files/2015/08/11/b4779acb-31b1-4950-87a4-6e65b5de16c6__kpassworddialog3.png Thanks, Elvis Angelaccio ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 54 - Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/54/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 11 Aug 2015 18:18:24 + Build duration: 4 min 48 sec CHANGE SET Revision d8aafbc37daab3cd62ee77430a55b3d72ccc12e0 by emmanuelpescosta099: (Show custom folder icons again) change: edit src/core/kfileitem.cpp change: edit autotests/kfileitemtest.cpp change: edit autotests/kfileitemtest.h JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 20/20 (100%)FILES 249/327 (76%)CLASSES 249/327 (76%)LINE 23659/49608 (48%)CONDITIONAL 12585/19406 (65%) By packages autotests FILES 59/59 (100%)CLASSES 59/59 (100%)LINE 6623/7125 (93%)CONDITIONAL 3424/6299 (54%) autotests.http FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 475/476 (100%)CONDITIONAL 166/272 (61%) autotests.kcookiejar FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 182/199 (91%)CONDITIONAL 60/90 (67%) src.core FILES 94/116 (81%)CLASSES 94/116 (81%)LINE 7253/13911 (52%)CONDITIONAL 3761/5259 (72%) src.core.kssl FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 3/6 (50%) src.filewidgets FILES 19/36 (53%)CLASSES 19/36 (53%)LINE 1828/7564 (24%)CONDITIONAL 693/1087 (64%) src.ioslaves.file FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 423/836 (51%)CONDITIONAL 309/454 (68%) src.ioslaves.http FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 750/3793 (20%)CONDITIONAL 547/678 (81%) src.ioslaves.http.kcookiejar FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 642/804 (80%)CONDITIONAL 600/756 (79%) src.ioslaves.trash FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 679/1124 (60%)CONDITIONAL 352/487 (72%) src.ioslaves.trash.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 690/768 (90%)CONDITIONAL 431/818 (53%) src.kioslave FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/26 (54%)CONDITIONAL 5/10 (50%) src.kntlm FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 306/386 (79%)CONDITIONAL 88/112 (79%) src.kpasswdserver FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 384/601 (64%)CONDITIONAL 278/404 (69%) src.kpasswdserver.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 278/283 (98%)CONDITIONAL 144/254 (57%) src.urifilters.fixhost FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 32/35 (91%)CONDITIONAL 42/52 (81%) src.urifilters.ikws FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 238/741 (32%)CONDITIONAL 141/188 (75%) src.urifilters.localdomain FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 14/18 (78%) src.urifilters.shorturi FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 225/255 (88%)CONDITIONAL 292/358 (82%) src.widgets FILES 28/60 (47%)CLASSES 28/60 (47%)LINE 2583/10562 (24%)CONDITIONAL 1235/1804 (68%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 54 - Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/54/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 11 Aug 2015 18:18:24 + Build duration: 4 min 48 sec CHANGE SET Revision d8aafbc37daab3cd62ee77430a55b3d72ccc12e0 by emmanuelpescosta099: (Show custom folder icons again) change: edit src/core/kfileitem.cpp change: edit autotests/kfileitemtest.cpp change: edit autotests/kfileitemtest.h JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 20/20 (100%)FILES 249/327 (76%)CLASSES 249/327 (76%)LINE 23659/49608 (48%)CONDITIONAL 12585/19406 (65%) By packages autotests FILES 59/59 (100%)CLASSES 59/59 (100%)LINE 6623/7125 (93%)CONDITIONAL 3424/6299 (54%) autotests.http FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 475/476 (100%)CONDITIONAL 166/272 (61%) autotests.kcookiejar FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 182/199 (91%)CONDITIONAL 60/90 (67%) src.core FILES 94/116 (81%)CLASSES 94/116 (81%)LINE 7253/13911 (52%)CONDITIONAL 3761/5259 (72%) src.core.kssl FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 3/6 (50%) src.filewidgets FILES 19/36 (53%)CLASSES 19/36 (53%)LINE 1828/7564 (24%)CONDITIONAL 693/1087 (64%) src.ioslaves.file FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 423/836 (51%)CONDITIONAL 309/454 (68%) src.ioslaves.http FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 750/3793 (20%)CONDITIONAL 547/678 (81%) src.ioslaves.http.kcookiejar FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 642/804 (80%)CONDITIONAL 600/756 (79%) src.ioslaves.trash FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 679/1124 (60%)CONDITIONAL 352/487 (72%) src.ioslaves.trash.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 690/768 (90%)CONDITIONAL 431/818 (53%) src.kioslave FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/26 (54%)CONDITIONAL 5/10 (50%) src.kntlm FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 306/386 (79%)CONDITIONAL 88/112 (79%) src.kpasswdserver FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 384/601 (64%)CONDITIONAL 278/404 (69%) src.kpasswdserver.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 278/283 (98%)CONDITIONAL 144/254 (57%) src.urifilters.fixhost FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 32/35 (91%)CONDITIONAL 42/52 (81%) src.urifilters.ikws FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 238/741 (32%)CONDITIONAL 141/188 (75%) src.urifilters.localdomain FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 14/18 (78%) src.urifilters.shorturi FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 225/255 (88%)CONDITIONAL 292/358 (82%) src.widgets FILES 28/60 (47%)CLASSES 28/60 (47%)LINE 2583/10562 (24%)CONDITIONAL 1235/1804 (68%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124690: Show custom folder icons again
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124690/ --- (Updated Aug. 11, 2015, 6:18 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Àlex Fiestas and David Faure. Changes --- Submitted with commit d8aafbc37daab3cd62ee77430a55b3d72ccc12e0 by Emmanuel Pescosta to branch master. Bugs: 350612 https://bugs.kde.org/show_bug.cgi?id=350612 Repository: kio Description --- Show custom folder icons again Set mimetype as known when we assign the mime type for inode/directory This bug was introduced by commit 46cd152f BUG: 350612 FIXED-IN: 5.14 Diffs - autotests/kfileitemtest.h 95612ed autotests/kfileitemtest.cpp 4a87469 src/core/kfileitem.cpp 344ac67 Diff: https://git.reviewboard.kde.org/r/124690/diff/ Testing --- KFileItemTest::testIconNameForCustomFolderIcons() fails without the patch but works with the patch. Folder icons are displayed properly again in Dolphin. Thanks, Emmanuel Pescosta ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
