Review Request 125885: Support socks5 proxy in KTcpSocket

2015-10-30 Thread Xuetian Weng 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125885/
---

Review request for KDE Frameworks and David Faure.


Bugs: 342402
https://bugs.kde.org/show_bug.cgi?id=342402


Repository: kio


Description
---

Automatically set socks5 proxy in KTcpSocket.


Diffs
-

  src/core/ktcpsocket.h ffa3f0b 
  src/core/ktcpsocket.cpp fde35a7 

Diff: https://git.reviewboard.kde.org/r/125885/diff/


Testing
---

Test with akonadi imap agent, connect through socks5 proxy.


Thanks,

Xuetian Weng

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125884: Set default value for WheelScrollLines

2015-10-30 Thread Luca Beltrame 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125884/#review87766
---


+1.

- Luca Beltrame


On Ott. 30, 2015, 10 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125884/
> ---
> 
> (Updated Ott. 30, 2015, 10 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Use 3 (same as mouse kcm) as default value instead of 
> QApplication::wheelScrollLines().
> 
> 
> Diffs
> -
> 
>   src/platformtheme/khintssettings.cpp e5c362a 
> 
> Diff: https://git.reviewboard.kde.org/r/125884/diff/
> 
> 
> Testing
> ---
> 
> No longer sets 0 lines when WheelScrollLines entry is not in kdeglobals.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125833: Use QStringLiteral in generated code

2015-10-30 Thread Laurent Montel 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125833/
---

(Updated Oct. 30, 2015, 10:31 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, David Faure and Matthew Dawson.


Changes
---

Submitted with commit 75d11cc64fee09189bfe8f968f0558e3d1000db8 by Montel 
Laurent to branch master.


Repository: kconfig


Description
---

Use QStringLiteral in generated code.


Diffs
-

  autotests/kconfig_compiler/test1.cpp.ref dcb3ffc 
  autotests/kconfig_compiler/test10.cpp.ref f067cc6 
  autotests/kconfig_compiler/test11.cpp.ref 1e6ff9e 
  autotests/kconfig_compiler/test11a.cpp.ref 9165661 
  autotests/kconfig_compiler/test12.cpp.ref e1cd01a 
  autotests/kconfig_compiler/test13.cpp.ref 4eac103 
  autotests/kconfig_compiler/test2.cpp.ref e99eb7c 
  autotests/kconfig_compiler/test3.cpp.ref 1ac9525 
  autotests/kconfig_compiler/test3a.cpp.ref dc72171 
  autotests/kconfig_compiler/test4.cpp.ref 2199c16 
  autotests/kconfig_compiler/test5.cpp.ref 323c1ee 
  autotests/kconfig_compiler/test6.cpp.ref 629d828 
  autotests/kconfig_compiler/test7.cpp.ref f506b09 
  autotests/kconfig_compiler/test8a.cpp.ref 00d4d02 
  autotests/kconfig_compiler/test8b.cpp.ref 8890815 
  autotests/kconfig_compiler/test9.cpp.ref bc65f43 
  autotests/kconfig_compiler/test_dpointer.cpp.ref 7933bfb 
  autotests/kconfig_compiler/test_qdebugcategory.cpp.ref f2eea33 
  autotests/kconfig_compiler/test_signal.cpp.ref e959571 
  autotests/kconfig_compiler/test_translation_kde.cpp.ref 5c11133 
  autotests/kconfig_compiler/test_translation_kde_domain.cpp.ref 66fc4cb 
  autotests/kconfig_compiler/test_translation_qt.cpp.ref f5ae727 
  src/kconfig_compiler/kconfig_compiler.cpp 600d67a 

Diff: https://git.reviewboard.kde.org/r/125833/diff/


Testing
---

All tests are ok.


Thanks,

Laurent Montel

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 47 - Fixed!

2015-10-30 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/47/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 30 Oct 2015 21:06:32 +
Build duration: 3 min 39 sec

CHANGE SET
Revision 4ca3237c2e07ac035104af5730bd209c18f61fe2 by kenya888: (fix lost 
QuickViewSharedEngine initialSize on initializing.)
  change: edit src/quickaddons/quickviewsharedengine.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/5 (100%)FILES 20/25 (80%)CLASSES 20/25 (80%)LINE 726/1446 
(50%)CONDITIONAL 323/568 (57%)

By packages
  
autotests
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 388/470 (83%)CONDITIONAL 
196/370 (53%)
src.kdeclarative
FILES 3/4 (75%)CLASSES 3/4 (75%)LINE 154/309 (50%)CONDITIONAL 
59/98 (60%)
src.kdeclarative.private
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 29/295 (10%)CONDITIONAL 
7/12 (58%)
src.qmlcontrols.kquickcontrolsaddons
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 67/118 (57%)CONDITIONAL 
36/50 (72%)
src.quickaddons
FILES 2/6 (33%)CLASSES 2/6 (33%)LINE 88/254 (35%)CONDITIONAL 
25/38 (66%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 47 - Fixed!

2015-10-30 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/47/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 30 Oct 2015 21:06:32 +
Build duration: 3 min 39 sec

CHANGE SET
Revision 4ca3237c2e07ac035104af5730bd209c18f61fe2 by kenya888: (fix lost 
QuickViewSharedEngine initialSize on initializing.)
  change: edit src/quickaddons/quickviewsharedengine.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/5 (100%)FILES 20/25 (80%)CLASSES 20/25 (80%)LINE 726/1446 
(50%)CONDITIONAL 323/568 (57%)

By packages
  
autotests
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 388/470 (83%)CONDITIONAL 
196/370 (53%)
src.kdeclarative
FILES 3/4 (75%)CLASSES 3/4 (75%)LINE 154/309 (50%)CONDITIONAL 
59/98 (60%)
src.kdeclarative.private
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 29/295 (10%)CONDITIONAL 
7/12 (58%)
src.qmlcontrols.kquickcontrolsaddons
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 67/118 (57%)CONDITIONAL 
36/50 (72%)
src.quickaddons
FILES 2/6 (33%)CLASSES 2/6 (33%)LINE 88/254 (35%)CONDITIONAL 
25/38 (66%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdeclarative master stable-kf5-qt5 » Linux,gcc - Build # 48 - Fixed!

2015-10-30 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kdeclarative%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/48/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 30 Oct 2015 21:06:32 +
Build duration: 1 min 57 sec

CHANGE SET
Revision 4ca3237c2e07ac035104af5730bd209c18f61fe2 by kenya888: (fix lost 
QuickViewSharedEngine initialSize on initializing.)
  change: edit src/quickaddons/quickviewsharedengine.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/5 (100%)FILES 20/25 (80%)CLASSES 20/25 (80%)LINE 726/1446 
(50%)CONDITIONAL 319/568 (56%)

By packages
  
autotests
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 388/470 (83%)CONDITIONAL 
192/370 (52%)
src.kdeclarative
FILES 3/4 (75%)CLASSES 3/4 (75%)LINE 154/309 (50%)CONDITIONAL 
59/98 (60%)
src.kdeclarative.private
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 29/295 (10%)CONDITIONAL 
7/12 (58%)
src.qmlcontrols.kquickcontrolsaddons
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 67/118 (57%)CONDITIONAL 
36/50 (72%)
src.quickaddons
FILES 2/6 (33%)CLASSES 2/6 (33%)LINE 88/254 (35%)CONDITIONAL 
25/38 (66%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdeclarative master stable-kf5-qt5 » Linux,gcc - Build # 48 - Fixed!

2015-10-30 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kdeclarative%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/48/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 30 Oct 2015 21:06:32 +
Build duration: 1 min 57 sec

CHANGE SET
Revision 4ca3237c2e07ac035104af5730bd209c18f61fe2 by kenya888: (fix lost 
QuickViewSharedEngine initialSize on initializing.)
  change: edit src/quickaddons/quickviewsharedengine.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/5 (100%)FILES 20/25 (80%)CLASSES 20/25 (80%)LINE 726/1446 
(50%)CONDITIONAL 319/568 (56%)

By packages
  
autotests
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 388/470 (83%)CONDITIONAL 
192/370 (52%)
src.kdeclarative
FILES 3/4 (75%)CLASSES 3/4 (75%)LINE 154/309 (50%)CONDITIONAL 
59/98 (60%)
src.kdeclarative.private
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 29/295 (10%)CONDITIONAL 
7/12 (58%)
src.qmlcontrols.kquickcontrolsaddons
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 67/118 (57%)CONDITIONAL 
36/50 (72%)
src.quickaddons
FILES 2/6 (33%)CLASSES 2/6 (33%)LINE 88/254 (35%)CONDITIONAL 
25/38 (66%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125884: Set default value for WheelScrollLines

2015-10-30 Thread David Rosca 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125884/
---

Review request for KDE Frameworks.


Repository: frameworkintegration


Description
---

Use 3 (same as mouse kcm) as default value instead of 
QApplication::wheelScrollLines().


Diffs
-

  src/platformtheme/khintssettings.cpp e5c362a 

Diff: https://git.reviewboard.kde.org/r/125884/diff/


Testing
---

No longer sets 0 lines when WheelScrollLines entry is not in kdeglobals.


Thanks,

David Rosca

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5

2015-10-30 Thread David Rosca 


> On Oct. 30, 2015, 7:34 p.m., Luca Beltrame wrote:
> > It looks like this broke mouse wheel scrolling for me (on Qt 5.5.1): how 
> > can I debug to ensure this is the case and not a local issue?
> 
> David Rosca wrote:
> Broke in what way? Did you try if it works without this commit?
> 
> Luca Beltrame wrote:
> I just reverted it and wheel scrolls again.
> Broken as in, there is no wheel scrolling in (tested):
> 
> - Kate
> - Konversation
> - Kontact
> 
> But works in:
> - Dolphin
> 
> David Rosca wrote:
> It shouldn't break it, unless you have set 0 wheel scroll lines in mouse 
> kcm. In the worst case, it should just ignore that value from kcm and use 
> default 3 lines (but that is what this should be actually fixing).
> 
> Luca Beltrame wrote:
> FYI, it's set to 3 lines there.
> 
> David Rosca wrote:
> Ok, so can you add qDebug() << "wheelscrolllines" << 
> m_hints[QPlatformTheme::WheelScrollLines]; after it is fetched from config 
> and check it picks the correct value? (line 110 and 337 in khintssettings.cpp)
> Also can you test if changing the wheel scroll lines value in mouse kcm 
> and applying it fixes scrolling for running applications?
> 
> Luca Beltrame wrote:
> Before adjusting config in the mouse KCM:
> ```
> kate
> wheelscrolllines at line 110  QVariant(int, 0)
> 0x13dda40 void QWindowPrivate::setTopLevelScreen(QScreen*, bool) ( 
> QScreen(0x977880) ): Attempt to set a screen on a child window.
> 0x13ddf20 void QWindowPrivate::setTopLevelScreen(QScreen*, bool) ( 
> QScreen(0x977880) ): Attempt to set a screen on a child window.
> 0x13de8b0 void QWindowPrivate::setTopLevelScreen(QScreen*, bool) ( 
> QScreen(0x977880) ): Attempt to set a screen on a child window.
> 0x13df0a0 void QWindowPrivate::setTopLevelScreen(QScreen*, bool) ( 
> QScreen(0x977880) ): Attempt to set a screen on a child window.
> 0x13e2150 void QWindowPrivate::setTopLevelScreen(QScreen*, bool) ( 
> QScreen(0x977880) ): Attempt to set a screen on a child window.
> 0x145e790 void QWindowPrivate::setTopLevelScreen(QScreen*, bool) ( 
> QScreen(0x977880) ): Attempt to set a screen on a child window.
> wheelscrolllines at 338 QVariant(int, 0)
> 
> 
> After changing config, scrolling works again (need an application 
> restart).

https://git.reviewboard.kde.org/r/125884/


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125863/#review87757
---


On Oct. 29, 2015, 7:01 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125863/
> ---
> 
> (Updated Oct. 29, 2015, 7:01 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 291144
> https://bugs.kde.org/show_bug.cgi?id=291144
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Use platform theme hint instead of manually using 
> QApplication::setWheelScrollLines
> 
> 
> Diffs
> -
> 
>   src/platformtheme/khintssettings.cpp 6e8313d 
> 
> Diff: https://git.reviewboard.kde.org/r/125863/diff/
> 
> 
> Testing
> ---
> 
> Qt 5.5 apps now correctly scroll by the value set in mouse kcm
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5

2015-10-30 Thread Luca Beltrame 


> On Ott. 30, 2015, 8:34 p.m., Luca Beltrame wrote:
> > It looks like this broke mouse wheel scrolling for me (on Qt 5.5.1): how 
> > can I debug to ensure this is the case and not a local issue?
> 
> David Rosca wrote:
> Broke in what way? Did you try if it works without this commit?
> 
> Luca Beltrame wrote:
> I just reverted it and wheel scrolls again.
> Broken as in, there is no wheel scrolling in (tested):
> 
> - Kate
> - Konversation
> - Kontact
> 
> But works in:
> - Dolphin
> 
> David Rosca wrote:
> It shouldn't break it, unless you have set 0 wheel scroll lines in mouse 
> kcm. In the worst case, it should just ignore that value from kcm and use 
> default 3 lines (but that is what this should be actually fixing).
> 
> Luca Beltrame wrote:
> FYI, it's set to 3 lines there.
> 
> David Rosca wrote:
> Ok, so can you add qDebug() << "wheelscrolllines" << 
> m_hints[QPlatformTheme::WheelScrollLines]; after it is fetched from config 
> and check it picks the correct value? (line 110 and 337 in khintssettings.cpp)
> Also can you test if changing the wheel scroll lines value in mouse kcm 
> and applying it fixes scrolling for running applications?

Before adjusting config in the mouse KCM:
```
kate
wheelscrolllines at line 110  QVariant(int, 0)
0x13dda40 void QWindowPrivate::setTopLevelScreen(QScreen*, bool) ( 
QScreen(0x977880) ): Attempt to set a screen on a child window.
0x13ddf20 void QWindowPrivate::setTopLevelScreen(QScreen*, bool) ( 
QScreen(0x977880) ): Attempt to set a screen on a child window.
0x13de8b0 void QWindowPrivate::setTopLevelScreen(QScreen*, bool) ( 
QScreen(0x977880) ): Attempt to set a screen on a child window.
0x13df0a0 void QWindowPrivate::setTopLevelScreen(QScreen*, bool) ( 
QScreen(0x977880) ): Attempt to set a screen on a child window.
0x13e2150 void QWindowPrivate::setTopLevelScreen(QScreen*, bool) ( 
QScreen(0x977880) ): Attempt to set a screen on a child window.
0x145e790 void QWindowPrivate::setTopLevelScreen(QScreen*, bool) ( 
QScreen(0x977880) ): Attempt to set a screen on a child window.
wheelscrolllines at 338 QVariant(int, 0)


After changing config, scrolling works again (need an application restart).


- Luca


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125863/#review87757
---


On Ott. 29, 2015, 8:01 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125863/
> ---
> 
> (Updated Ott. 29, 2015, 8:01 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 291144
> https://bugs.kde.org/show_bug.cgi?id=291144
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Use platform theme hint instead of manually using 
> QApplication::setWheelScrollLines
> 
> 
> Diffs
> -
> 
>   src/platformtheme/khintssettings.cpp 6e8313d 
> 
> Diff: https://git.reviewboard.kde.org/r/125863/diff/
> 
> 
> Testing
> ---
> 
> Qt 5.5 apps now correctly scroll by the value set in mouse kcm
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5

2015-10-30 Thread David Rosca 


> On Oct. 30, 2015, 7:34 p.m., Luca Beltrame wrote:
> > It looks like this broke mouse wheel scrolling for me (on Qt 5.5.1): how 
> > can I debug to ensure this is the case and not a local issue?
> 
> David Rosca wrote:
> Broke in what way? Did you try if it works without this commit?
> 
> Luca Beltrame wrote:
> I just reverted it and wheel scrolls again.
> Broken as in, there is no wheel scrolling in (tested):
> 
> - Kate
> - Konversation
> - Kontact
> 
> But works in:
> - Dolphin
> 
> David Rosca wrote:
> It shouldn't break it, unless you have set 0 wheel scroll lines in mouse 
> kcm. In the worst case, it should just ignore that value from kcm and use 
> default 3 lines (but that is what this should be actually fixing).
> 
> Luca Beltrame wrote:
> FYI, it's set to 3 lines there.

Ok, so can you add qDebug() << "wheelscrolllines" << 
m_hints[QPlatformTheme::WheelScrollLines]; after it is fetched from config and 
check it picks the correct value? (line 110 and 337 in khintssettings.cpp)
Also can you test if changing the wheel scroll lines value in mouse kcm and 
applying it fixes scrolling for running applications?


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125863/#review87757
---


On Oct. 29, 2015, 7:01 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125863/
> ---
> 
> (Updated Oct. 29, 2015, 7:01 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 291144
> https://bugs.kde.org/show_bug.cgi?id=291144
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Use platform theme hint instead of manually using 
> QApplication::setWheelScrollLines
> 
> 
> Diffs
> -
> 
>   src/platformtheme/khintssettings.cpp 6e8313d 
> 
> Diff: https://git.reviewboard.kde.org/r/125863/diff/
> 
> 
> Testing
> ---
> 
> Qt 5.5 apps now correctly scroll by the value set in mouse kcm
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5

2015-10-30 Thread Luca Beltrame 


> On Ott. 30, 2015, 8:34 p.m., Luca Beltrame wrote:
> > It looks like this broke mouse wheel scrolling for me (on Qt 5.5.1): how 
> > can I debug to ensure this is the case and not a local issue?
> 
> David Rosca wrote:
> Broke in what way? Did you try if it works without this commit?
> 
> Luca Beltrame wrote:
> I just reverted it and wheel scrolls again.
> Broken as in, there is no wheel scrolling in (tested):
> 
> - Kate
> - Konversation
> - Kontact
> 
> But works in:
> - Dolphin
> 
> David Rosca wrote:
> It shouldn't break it, unless you have set 0 wheel scroll lines in mouse 
> kcm. In the worst case, it should just ignore that value from kcm and use 
> default 3 lines (but that is what this should be actually fixing).

FYI, it's set to 3 lines there.


- Luca


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125863/#review87757
---


On Ott. 29, 2015, 8:01 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125863/
> ---
> 
> (Updated Ott. 29, 2015, 8:01 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 291144
> https://bugs.kde.org/show_bug.cgi?id=291144
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Use platform theme hint instead of manually using 
> QApplication::setWheelScrollLines
> 
> 
> Diffs
> -
> 
>   src/platformtheme/khintssettings.cpp 6e8313d 
> 
> Diff: https://git.reviewboard.kde.org/r/125863/diff/
> 
> 
> Testing
> ---
> 
> Qt 5.5 apps now correctly scroll by the value set in mouse kcm
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5

2015-10-30 Thread David Rosca 


> On Oct. 30, 2015, 7:34 p.m., Luca Beltrame wrote:
> > It looks like this broke mouse wheel scrolling for me (on Qt 5.5.1): how 
> > can I debug to ensure this is the case and not a local issue?
> 
> David Rosca wrote:
> Broke in what way? Did you try if it works without this commit?
> 
> Luca Beltrame wrote:
> I just reverted it and wheel scrolls again.
> Broken as in, there is no wheel scrolling in (tested):
> 
> - Kate
> - Konversation
> - Kontact
> 
> But works in:
> - Dolphin

It shouldn't break it, unless you have set 0 wheel scroll lines in mouse kcm. 
In the worst case, it should just ignore that value from kcm and use default 3 
lines (but that is what this should be actually fixing).


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125863/#review87757
---


On Oct. 29, 2015, 7:01 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125863/
> ---
> 
> (Updated Oct. 29, 2015, 7:01 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 291144
> https://bugs.kde.org/show_bug.cgi?id=291144
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Use platform theme hint instead of manually using 
> QApplication::setWheelScrollLines
> 
> 
> Diffs
> -
> 
>   src/platformtheme/khintssettings.cpp 6e8313d 
> 
> Diff: https://git.reviewboard.kde.org/r/125863/diff/
> 
> 
> Testing
> ---
> 
> Qt 5.5 apps now correctly scroll by the value set in mouse kcm
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5

2015-10-30 Thread Luca Beltrame 


> On Ott. 30, 2015, 8:34 p.m., Luca Beltrame wrote:
> > It looks like this broke mouse wheel scrolling for me (on Qt 5.5.1): how 
> > can I debug to ensure this is the case and not a local issue?
> 
> David Rosca wrote:
> Broke in what way? Did you try if it works without this commit?

I just reverted it and wheel scrolls again.
Broken as in, there is no wheel scrolling in (tested):

- Kate
- Konversation
- Kontact

But works in:
- Dolphin


- Luca


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125863/#review87757
---


On Ott. 29, 2015, 8:01 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125863/
> ---
> 
> (Updated Ott. 29, 2015, 8:01 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 291144
> https://bugs.kde.org/show_bug.cgi?id=291144
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Use platform theme hint instead of manually using 
> QApplication::setWheelScrollLines
> 
> 
> Diffs
> -
> 
>   src/platformtheme/khintssettings.cpp 6e8313d 
> 
> Diff: https://git.reviewboard.kde.org/r/125863/diff/
> 
> 
> Testing
> ---
> 
> Qt 5.5 apps now correctly scroll by the value set in mouse kcm
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5

2015-10-30 Thread David Rosca 


> On Oct. 30, 2015, 7:34 p.m., Luca Beltrame wrote:
> > It looks like this broke mouse wheel scrolling for me (on Qt 5.5.1): how 
> > can I debug to ensure this is the case and not a local issue?

Broke in what way? Did you try if it works without this commit?


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125863/#review87757
---


On Oct. 29, 2015, 7:01 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125863/
> ---
> 
> (Updated Oct. 29, 2015, 7:01 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 291144
> https://bugs.kde.org/show_bug.cgi?id=291144
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Use platform theme hint instead of manually using 
> QApplication::setWheelScrollLines
> 
> 
> Diffs
> -
> 
>   src/platformtheme/khintssettings.cpp 6e8313d 
> 
> Diff: https://git.reviewboard.kde.org/r/125863/diff/
> 
> 
> Testing
> ---
> 
> Qt 5.5 apps now correctly scroll by the value set in mouse kcm
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5

2015-10-30 Thread Luca Beltrame 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125863/#review87757
---


It looks like this broke mouse wheel scrolling for me (on Qt 5.5.1): how can I 
debug to ensure this is the case and not a local issue?

- Luca Beltrame


On Ott. 29, 2015, 8:01 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125863/
> ---
> 
> (Updated Ott. 29, 2015, 8:01 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 291144
> https://bugs.kde.org/show_bug.cgi?id=291144
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Use platform theme hint instead of manually using 
> QApplication::setWheelScrollLines
> 
> 
> Diffs
> -
> 
>   src/platformtheme/khintssettings.cpp 6e8313d 
> 
> Diff: https://git.reviewboard.kde.org/r/125863/diff/
> 
> 
> Testing
> ---
> 
> Qt 5.5 apps now correctly scroll by the value set in mouse kcm
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125875: Fix build for Qt < 5.5

2015-10-30 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125875/#review87743
---


Seems David Faure committed the same thing.

commit 7a0639c692ea2054049c020bd1b309d369dd71bd
Author: David Faure 
Date:   Fri Oct 30 09:09:02 2015 +0100

fix build with Qt < 5.5

CCBUG: k...@davidedmundson.co.uk

- David Edmundson


On Oct. 29, 2015, 6:55 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125875/
> ---
> 
> (Updated Oct. 29, 2015, 6:55 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kauth
> 
> 
> Description
> ---
> 
> Fix build for Qt < 5.5
> 
> 
> Diffs
> -
> 
>   src/backends/dbus/DBusHelperProxy.cpp 
> c258db2811b1bdb5d51950bedf66f6d90a7ea3a9 
> 
> Diff: https://git.reviewboard.kde.org/r/125875/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125875: Fix build for Qt < 5.5

2015-10-30 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125875/
---

(Updated Oct. 30, 2015, 1:58 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kauth


Description
---

Fix build for Qt < 5.5


Diffs
-

  src/backends/dbus/DBusHelperProxy.cpp 
c258db2811b1bdb5d51950bedf66f6d90a7ea3a9 

Diff: https://git.reviewboard.kde.org/r/125875/diff/


Testing
---


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125164: Finish killed KIO jobs

2015-10-30 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125164/
---

(Updated Oct. 30, 2015, 12:46 p.m.)


Review request for KDE Frameworks.


Changes
---

Updated the patch not to try to kill jobs that already finished, as suggested 
by David.

Still doesn't solve the issue.

```
snapshot(2084)/(default) unknown: No file found for ".xml" , even though 
update-mime-info said it would exist.
ksnapshot(2084)/(default) unknown: Either it was just removed, or the directory 
doesn't have executable permission...
ksnapshot(2084)/(default) unknown: ("/home/apol/.local/share/mime", 
"/home/kde-devel/kde5/share/mime", "/usr/share/mime")
ksnapshot(2084)/(default) KIO::SimpleJob::doKill: killing a job that already 
finished KIO::ListJob(0xec3f90)
ksnapshot(2084)/(default) KIO::SimpleJobPrivate::simpleJobInit: Invalid URL: 
QUrl("kdevelop-build1.png")
ksnapshot(2084)/(default) KIO::SimpleJobPrivate::simpleJobInit: Invalid URL: 
QUrl("kdevelop-build1.bmp")
ksnapshot(2084)/(default) KIO::SimpleJobPrivate::simpleJobInit: Invalid URL: 
QUrl("kdevelop-build1.bmp")
ksnapshot(2084)/(default) KIO::SimpleJobPrivate::simpleJobInit: Invalid URL: 
QUrl("kdevelop-build1.png")
ksnapshot(2084)/(default) KDirModelPrivate::_k_slotNewItems: Items emitted in 
directory QUrl("file:///home/apol/Documents") but that directory isn't in 
KDirModel! Root directory: QUrl("file:///home/apol/imatges")
ksnapshot(2084)/(default) KDirModelPrivate::_k_slotNewItems: Item: 
QUrl("file:///home/apol/Documents/sudokuTitle.png")
ksnapshot(2084)/(default) KDirModelPrivate::_k_slotNewItems: Item: 
QUrl("file:///home/apol/Documents/firma.png")   

   
ksnapshot(2084)/(default) KDirModelPrivate::dump: Dumping contents of KDirModel 
KDirModel(0xa3c5f0) dirLister url: QUrl("file:///home/apol/imatges")

  
ksnapshot(2084)/(default) unknown: ASSERT: "result" in file 
/home/kde-devel/frameworks/kio/src/widgets/kdirmodel.cpp, line 433  

  



  
Program received signal SIGABRT, Aborted.   


  
0x722885f8 in raise () from /usr/lib/libc.so.6  


  
(gdb) where 


  
#0  0x722885f8 in raise () from /usr/lib/libc.so.6  


  
#1  0x72289a7a in abort () from /usr/lib/libc.so.6  


  
#2  0x72f2805e in qt_message_fatal (context=..., message=) at 
/home/kde-devel/frameworks/qt5/qtbase/src/corelib/global/qlogging.cpp:1610  

 
#3  QMessageLogger::fatal (this=this@entry=0x7fff9960, 
msg=msg@entry=0x731db7f0 "ASSERT: \"%s\" in file %s, line %d") at 
/home/kde-devel/frameworks/qt5/qtbase/src/corelib/global/qlogging.cpp:784   
 
#4  0x72f235de in qt_assert (assertion=, file=, line=) at 
/home/kde-devel/frameworks/qt5/qtbase/src/corelib/global/qglobal.cpp:3046   

   
Python Exception  cannot resolve overloaded method `data': 
no

Re: icons packages with frameworks

2015-10-30 Thread Harald Sitter 
On Thu, Oct 22, 2015 at 10:12 AM, David Faure  wrote:
> On Wednesday 21 October 2015 21:07:16 Christoph Cullmann wrote:
>> Hi,
>>
>> >> So maybe this wouldn't be such a bad move after all.
>> >
>> > Agreed, we have frameworks (e.g. KIconThemes) "depending" on breeze, so it
>> > makes some kind of sense to ship them together.
>> yeah, beside that, if you want to create some self-contained installers,
>> you need breeze (or some other full iconset), too.
>>
>> Therefore it is nice if one can grab the release matching the framework 
>> release one uses.
>
> I thought you wanted frameworks themselves to bundle icons rather
> than depend on a (large) icon theme.
> And I would agree -- I just don't know how this interacts with icon themes, 
> i.e.
> is it a problem to have a single icon in the .qrc.
>
> But Martin's argument (apps should be able to depend on icons) is indeed
> a good reason to treat the default icon theme like a framework.
>
> I'm OK with releasing an icon theme with KF5, provided that it follows the
> KF5 rules/policies (buildsystem, versioning etc.) so that it doesn't have
> to be special-cased.

So, are we moving icons to frameworks then? Did anyone actually ask
the icon maintainers for input? :/
I am due to split breeze-icons from the breeze repo, so I could get
that into frameworks instead of plasma right away.
Equally oxygen-icons (currently part of plasma) could still be
relocated to frameworks easily as it hasn't seen a release. As pointed
out by Riddell on a different thread though, this bugger ought to have
a tarball name different from its repo name as it was part of
applications and thus has higher version numbers.

> (Notice I don't say oxygen or breeze, because I'm confused about that ;)

They are both "supported" and I think for both it would make sense to
be in frameworks.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kauth master stable-kf5-qt5 » Linux,gcc - Build # 25 - Fixed!

2015-10-30 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kauth%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/25/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 30 Oct 2015 08:09:50 +
Build duration: 1 min 27 sec

CHANGE SET
Revision 7a0639c692ea2054049c020bd1b309d369dd71bd by David Faure: (fix build 
with Qt < 5.5)
  change: edit src/backends/dbus/DBusHelperProxy.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 3/3 (100%)FILES 15/20 (75%)CLASSES 15/20 (75%)LINE 528/786 
(67%)CONDITIONAL 187/311 (60%)

By packages
  
autotests
FILES 6/7 (86%)CLASSES 6/7 (86%)LINE 241/260 (93%)CONDITIONAL 
144/238 (61%)
src
FILES 8/11 (73%)CLASSES 8/11 (73%)LINE 192/349 (55%)CONDITIONAL 
26/45 (58%)
src.backends.dbus
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 95/177 (54%)CONDITIONAL 
17/28 (61%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kauth master stable-kf5-qt5 » Linux,gcc - Build # 25 - Fixed!

2015-10-30 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kauth%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/25/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 30 Oct 2015 08:09:50 +
Build duration: 1 min 27 sec

CHANGE SET
Revision 7a0639c692ea2054049c020bd1b309d369dd71bd by David Faure: (fix build 
with Qt < 5.5)
  change: edit src/backends/dbus/DBusHelperProxy.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 3/3 (100%)FILES 15/20 (75%)CLASSES 15/20 (75%)LINE 528/786 
(67%)CONDITIONAL 187/311 (60%)

By packages
  
autotests
FILES 6/7 (86%)CLASSES 6/7 (86%)LINE 241/260 (93%)CONDITIONAL 
144/238 (61%)
src
FILES 8/11 (73%)CLASSES 8/11 (73%)LINE 192/349 (55%)CONDITIONAL 
26/45 (58%)
src.backends.dbus
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 95/177 (54%)CONDITIONAL 
17/28 (61%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-10-30 Thread Christoph Cullmann 


> On Oct. 30, 2015, 7:29 a.m., David Faure wrote:
> > src/ioslaves/trash/trash.json, line 6
> > 
> >
> > That doesn't look very English to me ;)
> > 
> > The original is:
> > 
> > ExtraNames=Original Path,Deletion Date
> > 
> > But this shows a problem: missing support for translating this field. 
> > We didn't realize there was a translatable field in these files. Please add 
> > support for translations, like was done for other json files (talk to e.g. 
> > Luigi Toscano).
> 
> Christoph Cullmann wrote:
> Hmm, then we have a problem: We can no longer convert the stuff and 
> remove the .protocol files, or?
> 
> Christoph Cullmann wrote:
> Ok, did read up a bit, ExtraNames seems to be the only translated thing 
> (at least if I read KProtocolInfo docs the right way).
> Can do the same trick as desktop2json does for that. Seems not that hard.
> But then we need CMake stuff for it, or? To convert on the fly to have 
> translations using the .protocol files like we have ATM in the .desktop files 
> for the plugin stuff.
> 
> David Faure wrote:
> I don't think you're looking in the right direction. AFAIK there is 
> support for translating json files directly in l10n (json -> po -> json) 
> these days. As I said, please ask Luigi or maybe Albert.

Ok ;=)


- Christoph


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review87721
---


On Oct. 29, 2015, 5:03 p.m., Christoph Cullmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> ---
> 
> (Updated Oct. 29, 2015, 5:03 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Richardson and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/CMakeLists.txt 76a8e28 
>   src/ioslaves/help/main_ghelp.cpp 59c8558 
>   src/ioslaves/help/main.cpp 9939196 
>   src/ioslaves/help/help.protocol 1deefe5 
>   src/ioslaves/help/help.json PRE-CREATION 
>   src/ioslaves/help/ghelp.protocol d2a642a 
>   src/ioslaves/help/ghelp.json PRE-CREATION 
>   src/ioslaves/help/CMakeLists.txt 867b59d 
>   src/ioslaves/ftp/ftp.protocol 4c5f80c 
>   src/ioslaves/ftp/ftp.json PRE-CREATION 
>   src/ioslaves/ftp/ftp.cpp 382723a 
>   src/ioslaves/ftp/CMakeLists.txt 04f5600 
>   src/ioslaves/file/file.protocol 523c0f5 
>   src/ioslaves/file/file.json PRE-CREATION 
>   src/ioslaves/file/file.cpp 5ef1587 
>   src/ioslaves/file/CMakeLists.txt cb85cfb 
>   autotests/kprotocolinfotest.cpp fa3ad38 
>   src/ioslaves/http/http.protocol 49e5dc5 
>   src/ioslaves/http/https.protocol c15d06f 
>   src/ioslaves/http/webdav.protocol 05c977a 
>   src/ioslaves/http/webdavs.protocol d5e4b2f 
>   src/ioslaves/trash/CMakeLists.txt 05161cd 
>   src/ioslaves/trash/kio_trash.cpp cb23169 
>   src/ioslaves/trash/trash.json PRE-CREATION 
>   src/ioslaves/trash/trash.protocol 7430575 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> ---
> 
> Tests still work (one needed patching, as the exec line contains now the full 
> path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
> sometimes it works, sometimes not :/ but even without this change.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-10-30 Thread David Faure 


> On Oct. 30, 2015, 7:29 a.m., David Faure wrote:
> > src/ioslaves/trash/trash.json, line 6
> > 
> >
> > That doesn't look very English to me ;)
> > 
> > The original is:
> > 
> > ExtraNames=Original Path,Deletion Date
> > 
> > But this shows a problem: missing support for translating this field. 
> > We didn't realize there was a translatable field in these files. Please add 
> > support for translations, like was done for other json files (talk to e.g. 
> > Luigi Toscano).
> 
> Christoph Cullmann wrote:
> Hmm, then we have a problem: We can no longer convert the stuff and 
> remove the .protocol files, or?
> 
> Christoph Cullmann wrote:
> Ok, did read up a bit, ExtraNames seems to be the only translated thing 
> (at least if I read KProtocolInfo docs the right way).
> Can do the same trick as desktop2json does for that. Seems not that hard.
> But then we need CMake stuff for it, or? To convert on the fly to have 
> translations using the .protocol files like we have ATM in the .desktop files 
> for the plugin stuff.

I don't think you're looking in the right direction. AFAIK there is support for 
translating json files directly in l10n (json -> po -> json) these days. As I 
said, please ask Luigi or maybe Albert.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review87721
---


On Oct. 29, 2015, 5:03 p.m., Christoph Cullmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> ---
> 
> (Updated Oct. 29, 2015, 5:03 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Richardson and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/CMakeLists.txt 76a8e28 
>   src/ioslaves/help/main_ghelp.cpp 59c8558 
>   src/ioslaves/help/main.cpp 9939196 
>   src/ioslaves/help/help.protocol 1deefe5 
>   src/ioslaves/help/help.json PRE-CREATION 
>   src/ioslaves/help/ghelp.protocol d2a642a 
>   src/ioslaves/help/ghelp.json PRE-CREATION 
>   src/ioslaves/help/CMakeLists.txt 867b59d 
>   src/ioslaves/ftp/ftp.protocol 4c5f80c 
>   src/ioslaves/ftp/ftp.json PRE-CREATION 
>   src/ioslaves/ftp/ftp.cpp 382723a 
>   src/ioslaves/ftp/CMakeLists.txt 04f5600 
>   src/ioslaves/file/file.protocol 523c0f5 
>   src/ioslaves/file/file.json PRE-CREATION 
>   src/ioslaves/file/file.cpp 5ef1587 
>   src/ioslaves/file/CMakeLists.txt cb85cfb 
>   autotests/kprotocolinfotest.cpp fa3ad38 
>   src/ioslaves/http/http.protocol 49e5dc5 
>   src/ioslaves/http/https.protocol c15d06f 
>   src/ioslaves/http/webdav.protocol 05c977a 
>   src/ioslaves/http/webdavs.protocol d5e4b2f 
>   src/ioslaves/trash/CMakeLists.txt 05161cd 
>   src/ioslaves/trash/kio_trash.cpp cb23169 
>   src/ioslaves/trash/trash.json PRE-CREATION 
>   src/ioslaves/trash/trash.protocol 7430575 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> ---
> 
> Tests still work (one needed patching, as the exec line contains now the full 
> path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
> sometimes it works, sometimes not :/ but even without this change.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-10-30 Thread Christoph Cullmann 


> On Oct. 30, 2015, 7:29 a.m., David Faure wrote:
> > src/ioslaves/trash/trash.json, line 6
> > 
> >
> > That doesn't look very English to me ;)
> > 
> > The original is:
> > 
> > ExtraNames=Original Path,Deletion Date
> > 
> > But this shows a problem: missing support for translating this field. 
> > We didn't realize there was a translatable field in these files. Please add 
> > support for translations, like was done for other json files (talk to e.g. 
> > Luigi Toscano).
> 
> Christoph Cullmann wrote:
> Hmm, then we have a problem: We can no longer convert the stuff and 
> remove the .protocol files, or?

Ok, did read up a bit, ExtraNames seems to be the only translated thing (at 
least if I read KProtocolInfo docs the right way).
Can do the same trick as desktop2json does for that. Seems not that hard.
But then we need CMake stuff for it, or? To convert on the fly to have 
translations using the .protocol files like we have ATM in the .desktop files 
for the plugin stuff.


- Christoph


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review87721
---


On Oct. 29, 2015, 5:03 p.m., Christoph Cullmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> ---
> 
> (Updated Oct. 29, 2015, 5:03 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Richardson and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/CMakeLists.txt 76a8e28 
>   src/ioslaves/help/main_ghelp.cpp 59c8558 
>   src/ioslaves/help/main.cpp 9939196 
>   src/ioslaves/help/help.protocol 1deefe5 
>   src/ioslaves/help/help.json PRE-CREATION 
>   src/ioslaves/help/ghelp.protocol d2a642a 
>   src/ioslaves/help/ghelp.json PRE-CREATION 
>   src/ioslaves/help/CMakeLists.txt 867b59d 
>   src/ioslaves/ftp/ftp.protocol 4c5f80c 
>   src/ioslaves/ftp/ftp.json PRE-CREATION 
>   src/ioslaves/ftp/ftp.cpp 382723a 
>   src/ioslaves/ftp/CMakeLists.txt 04f5600 
>   src/ioslaves/file/file.protocol 523c0f5 
>   src/ioslaves/file/file.json PRE-CREATION 
>   src/ioslaves/file/file.cpp 5ef1587 
>   src/ioslaves/file/CMakeLists.txt cb85cfb 
>   autotests/kprotocolinfotest.cpp fa3ad38 
>   src/ioslaves/http/http.protocol 49e5dc5 
>   src/ioslaves/http/https.protocol c15d06f 
>   src/ioslaves/http/webdav.protocol 05c977a 
>   src/ioslaves/http/webdavs.protocol d5e4b2f 
>   src/ioslaves/trash/CMakeLists.txt 05161cd 
>   src/ioslaves/trash/kio_trash.cpp cb23169 
>   src/ioslaves/trash/trash.json PRE-CREATION 
>   src/ioslaves/trash/trash.protocol 7430575 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> ---
> 
> Tests still work (one needed patching, as the exec line contains now the full 
> path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
> sometimes it works, sometimes not :/ but even without this change.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125874: make kio_http_cache_cleaner deployable in application installer/bundles

2015-10-30 Thread Christoph Cullmann 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125874/
---

(Updated Oct. 30, 2015, 8:13 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Changes
---

Submitted with commit c529a97b11de3ba7d2671be269da68b46d7317f0 by Christoph 
Cullmann to branch master.


Repository: kio


Description
---

make kio_http_cache_cleaner deployable in application installer/bundles

uses findExecutable, that fixes problem with .exe extension on Windows, too.


Diffs
-

  src/ioslaves/http/http.cpp 2ff7ee5 

Diff: https://git.reviewboard.kde.org/r/125874/diff/


Testing
---

Still gets found.


Thanks,

Christoph Cullmann

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125762: External extractor plugin support for KFileMetaData

2015-10-30 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125762/#review87727
---



src/extractors/externalextractor.cpp (line 69)


That isn't even really the right reason.
Even if all supported compilers can do range-for, you still don't want to 
use range-for on a Qt container (it would cause a detach).

And vice-versa, don't use range-for on a Qt container, it makes a deep copy.

So the rule is simple:
* Q_FOREACH on Qt containers
* range-for on STL containers (*)

(*) after ensuring that all supported compilers can handle it; I thought 
this was the case btw, but I didn't check that wiki page.


- David Faure


On Oct. 24, 2015, 12:19 p.m., Boudhayan Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125762/
> ---
> 
> (Updated Oct. 24, 2015, 12:19 p.m.)
> 
> 
> Review request for Baloo, KDE Frameworks, Pinak Ahuja, and Vishesh Handa.
> 
> 
> Repository: kfilemetadata
> 
> 
> Description
> ---
> 
> This patch introduces support for external metadata extractors in 
> KFileMetaData
> 
> The external extractors themselves can be written in any language, provided 
> that it can be executed as a standalone executable (compiled or script with a 
> hashbang), with command line arguments, and can output data to stdout.
> 
> The extractors are executed like so:
> 
> * `extractor --mimetypes` - outputs a list of mimetypes supported by the 
> extractor, one per line.
> * `extractor filename` - outputs a json document with the metadata. The keys 
> are such that they can be directly used with PropertyInfo::fromName().
> 
> At the KFileMetaData end, an additional internal plugin (ExternalExtractor) 
> is provided that forms a conduit between external extractors and the internal 
> API. This plugin looks for executables called 
> kfilemetadata_extractor_ in /usr/bin to find external extractors, 
> and executes them with the --mimetypes arg to find the list of mimetypes each 
> extractor supports. ExternalExtractor then claims to support all of these 
> mimetypes, and then delegates to the extractor executable when doing the 
> actual extraction.
> 
> 
> Diffs
> -
> 
>   README.md 19b1a26 
>   src/extractors/CMakeLists.txt 5dd223e 
>   src/extractors/externalextractor.h PRE-CREATION 
>   src/extractors/externalextractor.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125762/diff/
> 
> 
> Testing
> ---
> 
> Tested with the sample executable file extractor (as attched, written in 
> python) with the dump manual test in KFileMetaData. Works.
> 
> 
> File Attachments
> 
> 
> kfilemetadata_extractor_executable
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/23/146b657f-31d9-4117-a82f-ef966a6339d4__kfilemetadata_extractor_executable
> 
> 
> Thanks,
> 
> Boudhayan Gupta
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125449: Add support for desktop file name to KAboutData

2015-10-30 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125449/
---

(Updated Oct. 30, 2015, 8:01 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, David Faure and Marco Martin.


Changes
---

Submitted with commit c0313039170d751c61a44a8f97e199b7ed8ffa4f by Martin 
Gräßlin to branch master.


Repository: kcoreaddons


Description
---

This change introduces a way to set the new QGuiApplication property
"desktopFileName" through KAboutData. By default it gets constructed
to a combination of reverse domain name and component name.
E.g.: org.kde.kwrite

In addition a new command line option --desktopfile is added to allow
passing the desktop file name to the application. This is in particular
useful for wrapper applications (such as kpackagelauncherqml) and
applications having in general multiple desktop files. Thus each desktop
file can put it's own name into the exec command.


Diffs
-

  autotests/kaboutdatatest.cpp 08690b7abed7727ab5610e41cfb124fc27cd88a5 
  src/lib/kaboutdata.h 134819b1ee32d5cf1e4f379b547e52e387dd674e 
  src/lib/kaboutdata.cpp af10fc60053b294789f2813680299be2bc4b7a64 

Diff: https://git.reviewboard.kde.org/r/125449/diff/


Testing
---

See added unit test. For the command line parser I only tested whether it gets 
added to applications.


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125875: Fix build for Qt < 5.5

2015-10-30 Thread Luca Beltrame 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125875/#review87725
---


+1

- Luca Beltrame


On Ott. 29, 2015, 7:55 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125875/
> ---
> 
> (Updated Ott. 29, 2015, 7:55 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kauth
> 
> 
> Description
> ---
> 
> Fix build for Qt < 5.5
> 
> 
> Diffs
> -
> 
>   src/backends/dbus/DBusHelperProxy.cpp 
> c258db2811b1bdb5d51950bedf66f6d90a7ea3a9 
> 
> Diff: https://git.reviewboard.kde.org/r/125875/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125766: Changed the manual command line parsing to use QCommandLineParser.

2015-10-30 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125766/#review87724
---

Ship it!



src/kded.cpp (line 684)


Yep, someone should contribute a 
QGuiApplication::disableSessionManagement()...



src/kded.cpp (line 687)


this could move to setupAppInfo, or you could remove that separate method 
now that it's called only from one place. It just looks a bit inconsistent now.



src/kded.cpp 


The reason the code was the way it was, was to only create a 
QCoreApplication rather than a QApplication when --check is called, since this 
was done at KDE startup where time matters and core-only is sufficient for this.

This being said, I'm not sure --check is still used anywhere. I did some 
searching and I can't find where it's used (neither in kdelibs4+startkde4 or in 
KF5+startkde5).

So I guess I'll forget about the --check optimization (we can keep it for 
compat but we don't have to make it super efficient then)


- David Faure


On Oct. 23, 2015, 5:58 p.m., Antonio Larrosa Jimenez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125766/
> ---
> 
> (Updated Oct. 23, 2015, 5:58 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kded
> 
> 
> Description
> ---
> 
> Changed the manual command line parsing to use QCommandLineParser instead of
> parsing it manually. Also, now kded5 --version and kded5 --help show the
> version information and help on options.
> 
> There's a new human readable text ("Check cache validity") that maybe
> should be inside i18n, but since kded doesn't user i18n at all and
> I wasn't sure it's desired to do so, I just left it untranslated.
> 
> Also, unset SESSION_MANAGER environment variable instead of setting it empty.
> This removes a warning from Qt when parsing the (wrong, empty)
> value of SESSION_MANAGER
> 
> 
> Diffs
> -
> 
>   src/kded.cpp 6929d7d3f24d3556f1b227d5a9bfb5b02b1c295e 
> 
> Diff: https://git.reviewboard.kde.org/r/125766/diff/
> 
> 
> Testing
> ---
> 
> I tested kded5 runs, and the --check, --version and --help options work as 
> expected.
> Also, now it doesn't show a warning every time it's run. I didn't really 
> check it's
> not doing any session management, but SESSION_MANAGER is only used in one 
> place in qtbase,
> at 
> [https://github.com/qtproject/qtbase/blob/dev/src/plugins/platforms/xcb/qxcbsessionmanager.cpp#L350](https://github.com/qtproject/qtbase/blob/dev/src/plugins/platforms/xcb/qxcbsessionmanager.cpp#L350)
> and reading that, I think unsetting the environment variable makes more sense.
> 
> 
> Thanks,
> 
> Antonio Larrosa Jimenez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-10-30 Thread Christoph Cullmann 


> On Oct. 30, 2015, 7:29 a.m., David Faure wrote:
> > src/ioslaves/trash/trash.json, line 6
> > 
> >
> > That doesn't look very English to me ;)
> > 
> > The original is:
> > 
> > ExtraNames=Original Path,Deletion Date
> > 
> > But this shows a problem: missing support for translating this field. 
> > We didn't realize there was a translatable field in these files. Please add 
> > support for translations, like was done for other json files (talk to e.g. 
> > Luigi Toscano).

Hmm, then we have a problem: We can no longer convert the stuff and remove the 
.protocol files, or?


- Christoph


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review87721
---


On Oct. 29, 2015, 5:03 p.m., Christoph Cullmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> ---
> 
> (Updated Oct. 29, 2015, 5:03 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Richardson and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/CMakeLists.txt 76a8e28 
>   src/ioslaves/help/main_ghelp.cpp 59c8558 
>   src/ioslaves/help/main.cpp 9939196 
>   src/ioslaves/help/help.protocol 1deefe5 
>   src/ioslaves/help/help.json PRE-CREATION 
>   src/ioslaves/help/ghelp.protocol d2a642a 
>   src/ioslaves/help/ghelp.json PRE-CREATION 
>   src/ioslaves/help/CMakeLists.txt 867b59d 
>   src/ioslaves/ftp/ftp.protocol 4c5f80c 
>   src/ioslaves/ftp/ftp.json PRE-CREATION 
>   src/ioslaves/ftp/ftp.cpp 382723a 
>   src/ioslaves/ftp/CMakeLists.txt 04f5600 
>   src/ioslaves/file/file.protocol 523c0f5 
>   src/ioslaves/file/file.json PRE-CREATION 
>   src/ioslaves/file/file.cpp 5ef1587 
>   src/ioslaves/file/CMakeLists.txt cb85cfb 
>   autotests/kprotocolinfotest.cpp fa3ad38 
>   src/ioslaves/http/http.protocol 49e5dc5 
>   src/ioslaves/http/https.protocol c15d06f 
>   src/ioslaves/http/webdav.protocol 05c977a 
>   src/ioslaves/http/webdavs.protocol d5e4b2f 
>   src/ioslaves/trash/CMakeLists.txt 05161cd 
>   src/ioslaves/trash/kio_trash.cpp cb23169 
>   src/ioslaves/trash/trash.json PRE-CREATION 
>   src/ioslaves/trash/trash.protocol 7430575 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> ---
> 
> Tests still work (one needed patching, as the exec line contains now the full 
> path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
> sometimes it works, sometimes not :/ but even without this change.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125833: Use QStringLiteral in generated code

2015-10-30 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125833/#review87722
---

Ship it!


Ship It!

- David Faure


On Oct. 28, 2015, 7:32 a.m., Laurent Montel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125833/
> ---
> 
> (Updated Oct. 28, 2015, 7:32 a.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> Use QStringLiteral in generated code.
> 
> 
> Diffs
> -
> 
>   autotests/kconfig_compiler/test1.cpp.ref dcb3ffc 
>   autotests/kconfig_compiler/test10.cpp.ref f067cc6 
>   autotests/kconfig_compiler/test11.cpp.ref 1e6ff9e 
>   autotests/kconfig_compiler/test11a.cpp.ref 9165661 
>   autotests/kconfig_compiler/test12.cpp.ref e1cd01a 
>   autotests/kconfig_compiler/test13.cpp.ref 4eac103 
>   autotests/kconfig_compiler/test2.cpp.ref e99eb7c 
>   autotests/kconfig_compiler/test3.cpp.ref 1ac9525 
>   autotests/kconfig_compiler/test3a.cpp.ref dc72171 
>   autotests/kconfig_compiler/test4.cpp.ref 2199c16 
>   autotests/kconfig_compiler/test5.cpp.ref 323c1ee 
>   autotests/kconfig_compiler/test6.cpp.ref 629d828 
>   autotests/kconfig_compiler/test7.cpp.ref f506b09 
>   autotests/kconfig_compiler/test8a.cpp.ref 00d4d02 
>   autotests/kconfig_compiler/test8b.cpp.ref 8890815 
>   autotests/kconfig_compiler/test9.cpp.ref bc65f43 
>   autotests/kconfig_compiler/test_dpointer.cpp.ref 7933bfb 
>   autotests/kconfig_compiler/test_qdebugcategory.cpp.ref f2eea33 
>   autotests/kconfig_compiler/test_signal.cpp.ref e959571 
>   autotests/kconfig_compiler/test_translation_kde.cpp.ref 5c11133 
>   autotests/kconfig_compiler/test_translation_kde_domain.cpp.ref 66fc4cb 
>   autotests/kconfig_compiler/test_translation_qt.cpp.ref f5ae727 
>   src/kconfig_compiler/kconfig_compiler.cpp 600d67a 
> 
> Diff: https://git.reviewboard.kde.org/r/125833/diff/
> 
> 
> Testing
> ---
> 
> All tests are ok.
> 
> 
> Thanks,
> 
> Laurent Montel
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-10-30 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review87721
---



src/ioslaves/file/file.cpp (line 80)


embedd -> embed



src/ioslaves/trash/trash.json (line 6)


That doesn't look very English to me ;)

The original is:

ExtraNames=Original Path,Deletion Date

But this shows a problem: missing support for translating this field. We 
didn't realize there was a translatable field in these files. Please add 
support for translations, like was done for other json files (talk to e.g. 
Luigi Toscano).


- David Faure


On Oct. 29, 2015, 5:03 p.m., Christoph Cullmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> ---
> 
> (Updated Oct. 29, 2015, 5:03 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Richardson and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/CMakeLists.txt 76a8e28 
>   src/ioslaves/help/main_ghelp.cpp 59c8558 
>   src/ioslaves/help/main.cpp 9939196 
>   src/ioslaves/help/help.protocol 1deefe5 
>   src/ioslaves/help/help.json PRE-CREATION 
>   src/ioslaves/help/ghelp.protocol d2a642a 
>   src/ioslaves/help/ghelp.json PRE-CREATION 
>   src/ioslaves/help/CMakeLists.txt 867b59d 
>   src/ioslaves/ftp/ftp.protocol 4c5f80c 
>   src/ioslaves/ftp/ftp.json PRE-CREATION 
>   src/ioslaves/ftp/ftp.cpp 382723a 
>   src/ioslaves/ftp/CMakeLists.txt 04f5600 
>   src/ioslaves/file/file.protocol 523c0f5 
>   src/ioslaves/file/file.json PRE-CREATION 
>   src/ioslaves/file/file.cpp 5ef1587 
>   src/ioslaves/file/CMakeLists.txt cb85cfb 
>   autotests/kprotocolinfotest.cpp fa3ad38 
>   src/ioslaves/http/http.protocol 49e5dc5 
>   src/ioslaves/http/https.protocol c15d06f 
>   src/ioslaves/http/webdav.protocol 05c977a 
>   src/ioslaves/http/webdavs.protocol d5e4b2f 
>   src/ioslaves/trash/CMakeLists.txt 05161cd 
>   src/ioslaves/trash/kio_trash.cpp cb23169 
>   src/ioslaves/trash/trash.json PRE-CREATION 
>   src/ioslaves/trash/trash.protocol 7430575 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> ---
> 
> Tests still work (one needed patching, as the exec line contains now the full 
> path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
> sometimes it works, sometimes not :/ but even without this change.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125874: make kio_http_cache_cleaner deployable in application installer/bundles

2015-10-30 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125874/#review87720
---

Ship it!


Ship It!

- David Faure


On Oct. 29, 2015, 5:21 p.m., Christoph Cullmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125874/
> ---
> 
> (Updated Oct. 29, 2015, 5:21 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> make kio_http_cache_cleaner deployable in application installer/bundles
> 
> uses findExecutable, that fixes problem with .exe extension on Windows, too.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/http.cpp 2ff7ee5 
> 
> Diff: https://git.reviewboard.kde.org/r/125874/diff/
> 
> 
> Testing
> ---
> 
> Still gets found.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125762: External extractor plugin support for KFileMetaData

2015-10-30 Thread Boudhayan Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125762/#review87719
---


Ping? :-)

- Boudhayan Gupta


On Oct. 24, 2015, 5:49 p.m., Boudhayan Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125762/
> ---
> 
> (Updated Oct. 24, 2015, 5:49 p.m.)
> 
> 
> Review request for Baloo, KDE Frameworks, Pinak Ahuja, and Vishesh Handa.
> 
> 
> Repository: kfilemetadata
> 
> 
> Description
> ---
> 
> This patch introduces support for external metadata extractors in 
> KFileMetaData
> 
> The external extractors themselves can be written in any language, provided 
> that it can be executed as a standalone executable (compiled or script with a 
> hashbang), with command line arguments, and can output data to stdout.
> 
> The extractors are executed like so:
> 
> * `extractor --mimetypes` - outputs a list of mimetypes supported by the 
> extractor, one per line.
> * `extractor filename` - outputs a json document with the metadata. The keys 
> are such that they can be directly used with PropertyInfo::fromName().
> 
> At the KFileMetaData end, an additional internal plugin (ExternalExtractor) 
> is provided that forms a conduit between external extractors and the internal 
> API. This plugin looks for executables called 
> kfilemetadata_extractor_ in /usr/bin to find external extractors, 
> and executes them with the --mimetypes arg to find the list of mimetypes each 
> extractor supports. ExternalExtractor then claims to support all of these 
> mimetypes, and then delegates to the extractor executable when doing the 
> actual extraction.
> 
> 
> Diffs
> -
> 
>   README.md 19b1a26 
>   src/extractors/CMakeLists.txt 5dd223e 
>   src/extractors/externalextractor.h PRE-CREATION 
>   src/extractors/externalextractor.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125762/diff/
> 
> 
> Testing
> ---
> 
> Tested with the sample executable file extractor (as attched, written in 
> python) with the dump manual test in KFileMetaData. Works.
> 
> 
> File Attachments
> 
> 
> kfilemetadata_extractor_executable
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/23/146b657f-31d9-4117-a82f-ef966a6339d4__kfilemetadata_extractor_executable
> 
> 
> Thanks,
> 
> Boudhayan Gupta
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel