Re: [OS X] "unknown type name 'KARCHIVE_DEPRECATED'" building kdoctools

2015-11-04 Thread René J . V . Bertin
Alex Merry wrote:

> Looks like your include path is wrong. /opt/local/include/KF5/KArchive
> should be in the include path (before wherever wherever your kdelibs4
> headers are).

I suppose you're right, but AFAIK I don't do anything either to alter the 
install location (relative to /opt/local) nor to alter the include path.
Would that also fix the error related to KARCHIVE_DEPRECATED, in other words, 
am 
I missing a header that defines that token because 
/opt/local/include/KF5/KArchive isn't on the include path?

R.

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: [OS X] "unknown type name 'KARCHIVE_DEPRECATED'" building kdoctools

2015-11-04 Thread René J . V . Bertin
Alex Merry wrote:


> Well, if we'd done it for kdelibs4 as well, you wouldn't have this issue
> - if you had to add -I/opt/local/include/kdelibs in order to find any
> kdelibs headers, none would be found by mistake.

Fair enough, but you didn't :)

FWIW (and because there are some on here who would like to let KF5 be as native 
as possible on OS X): with Apple's framework bundles that also contain the 
headers, you're more or less supposed to use statements like #include 
 (or #import  in ObjC).
Standardising on #include  where KFoo is expected to live in a 
standard include directory would make it more straightforward to build KF5 
frameworks as OS X frameworks (i.e. bundles).

R

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 125941: Add KCompressionDevice tests to KArchive

2015-11-04 Thread Romário Rios

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125941/#review88018
---



autotests/kcompressiondevicetest.cpp (line 29)


I don't believe it can. It can do the opposite -- CompressionType by 
filename or mimetype --, but not this.


- Romário Rios


On Nov. 4, 2015, 2:08 a.m., Romário Rios wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125941/
> ---
> 
> (Updated Nov. 4, 2015, 2:08 a.m.)
> 
> 
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> I recently noticed that using KTar with KCompressionDevice and QNetworkReply 
> did not work, so I'm adding some tests to confirm that
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 1b2e819 
>   autotests/kcompressiondevicetest.h PRE-CREATION 
>   autotests/kcompressiondevicetest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125941/diff/
> 
> 
> Testing
> ---
> 
> The tests run and show that KCompressionDevice isn't working as expected
> 
> 
> Thanks,
> 
> Romário Rios
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: [OS X] "unknown type name 'KARCHIVE_DEPRECATED'" building kdoctools

2015-11-04 Thread René J . V . Bertin
René J. V. Bertin wrote:

> Alex Merry wrote:
> 
>> Looks like your include path is wrong. /opt/local/include/KF5/KArchive
>> should be in the include path (before wherever wherever your kdelibs4
>> headers are).

In fact:

cd /opt/local/var/macports/build/_opt_local_site-ports_kf5_Frameworks/kf5-
kdoctools/work/build/src && 
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++
   
-DQT_CORE_LIB -DQT_MAC_USE_COCOA -DQT_NO_CAST_FROM_BYTEARRAY -
DQT_NO_CAST_TO_ASCII -DQT_NO_DEBUG -DQT_NO_SIGNALS_SLOTS_KEYWORDS -
DQT_NO_URL_CAST_FROM_STRING -DQT_QSP_XDG_LIB -DQT_USE_FAST_OPERATOR_PLUS -
DQT_USE_QSTRINGBUILDER -DTRANSLATION_DOMAIN=\"kdoctools5\" -D_DARWIN_C_SOURCE -
D_LARGEFILE64_SOURCE -O3 -march=native -g -DNDEBUG -stdlib=libc++  -std=c++0x -
fno-exceptions -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -
Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual -
Werror=return-type -pedantic -Wno-gnu-zero-variadic-macro-arguments -mmacosx-
version-min=10.9 -I/opt/local/var/macports/build/_opt_local_site-
ports_kf5_Frameworks/kf5-kdoctools/work/build/src -
I/opt/local/var/macports/build/_opt_local_site-ports_kf5_Frameworks/kf5-
kdoctools/work/kdoctools-5.15.0/src -I/opt/local/include/libxml2 -
I/opt/local/include -iframework /opt/local/libexec/qt5/Library/Frameworks -
isystem /opt/local/libexec/qt5/Library/Frameworks/QtCore.framework/Headers -
isystem /opt/local/share/qt5/mkspecs/macx-clang -isystem 
/opt/local/libexec/qt5/Library/Frameworks/QtQspXDG.framework/Headers -isystem 
/opt/local/include/KF5/KArchive -isystem /opt/local/include/KF5-fPIC -o 
CMakeFiles/meinproc5.dir/xslt_kde.cpp.o -c 
/opt/local/var/macports/build/_opt_local_site-ports_kf5_Frameworks/kf5-
kdoctools/work/kdoctools-5.15.0/src/xslt_kde.cpp

looking closely enough, you'll see that there's (in that order)

-I/opt/local/include -isystem /opt/local/include/KF5/KArchive

so it's perfectly correct that the KDE4 header is picked up first.

And the KARCHIVE_DEPRECATED error is explained the same way: the KDE4 
karchive_export.h header is found before the KF5 one ...

I must admit I don't really see the point in bundling headerfiles in a specific 
directory, only to relinquish the selectivity that allows from #include 
statements by adding the directory/ies to the -I includepath ...


R.

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: [OS X] "unknown type name 'KARCHIVE_DEPRECATED'" building kdoctools

2015-11-04 Thread Alex Merry

On 2015-11-04 21:45, René J. V.  Bertin wrote:

René J. V. Bertin wrote:


Alex Merry wrote:

Looks like your include path is wrong. 
/opt/local/include/KF5/KArchive

should be in the include path (before wherever wherever your kdelibs4
headers are).


In fact:

cd 
/opt/local/var/macports/build/_opt_local_site-ports_kf5_Frameworks/kf5-

kdoctools/work/build/src &&
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++

-DQT_CORE_LIB -DQT_MAC_USE_COCOA -DQT_NO_CAST_FROM_BYTEARRAY -
DQT_NO_CAST_TO_ASCII -DQT_NO_DEBUG -DQT_NO_SIGNALS_SLOTS_KEYWORDS -
DQT_NO_URL_CAST_FROM_STRING -DQT_QSP_XDG_LIB 
-DQT_USE_FAST_OPERATOR_PLUS -
DQT_USE_QSTRINGBUILDER -DTRANSLATION_DOMAIN=\"kdoctools5\" 
-D_DARWIN_C_SOURCE -
D_LARGEFILE64_SOURCE -O3 -march=native -g -DNDEBUG -stdlib=libc++  
-std=c++0x -
fno-exceptions -Wall -Wextra -Wcast-align -Wchar-subscripts 
-Wformat-security -
Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor 
-Woverloaded-virtual -
Werror=return-type -pedantic -Wno-gnu-zero-variadic-macro-arguments 
-mmacosx-

version-min=10.9 -I/opt/local/var/macports/build/_opt_local_site-
ports_kf5_Frameworks/kf5-kdoctools/work/build/src -
I/opt/local/var/macports/build/_opt_local_site-ports_kf5_Frameworks/kf5-
kdoctools/work/kdoctools-5.15.0/src -I/opt/local/include/libxml2 -
I/opt/local/include -iframework 
/opt/local/libexec/qt5/Library/Frameworks -
isystem 
/opt/local/libexec/qt5/Library/Frameworks/QtCore.framework/Headers -

isystem /opt/local/share/qt5/mkspecs/macx-clang -isystem
/opt/local/libexec/qt5/Library/Frameworks/QtQspXDG.framework/Headers 
-isystem
/opt/local/include/KF5/KArchive -isystem /opt/local/include/KF5
-fPIC -o

CMakeFiles/meinproc5.dir/xslt_kde.cpp.o -c
/opt/local/var/macports/build/_opt_local_site-ports_kf5_Frameworks/kf5-
kdoctools/work/kdoctools-5.15.0/src/xslt_kde.cpp

looking closely enough, you'll see that there's (in that order)

-I/opt/local/include -isystem /opt/local/include/KF5/KArchive

so it's perfectly correct that the KDE4 header is picked up first.

And the KARCHIVE_DEPRECATED error is explained the same way: the KDE4
karchive_export.h header is found before the KF5 one ...

I must admit I don't really see the point in bundling headerfiles in a 
specific

directory, only to relinquish the selectivity that allows from #include
statements by adding the directory/ies to the -I includepath ...


Well, if we'd done it for kdelibs4 as well, you wouldn't have this issue 
- if you had to add -I/opt/local/include/kdelibs in order to find any 
kdelibs headers, none would be found by mistake.


Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 125817: Add plugin system for Calendar events

2015-11-04 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125817/#review88030
---

Ship it!


Ship It!

- David Edmundson


On Nov. 2, 2015, 5:35 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125817/
> ---
> 
> (Updated Nov. 2, 2015, 5:35 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Daniel Vrátil.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This adds a simple plugin interface that can be subclassed
> and provide events integration with Plasma Calendar applet.
> 
> It's asynchronous and I've kept it deliberately simple.
> For now the Calendar tells the plugins which date range
> is being displayed, the plugins load the data and then
> emit the dataReady() signal containing the events.
> 
> The events are stored in a multihash for quick access
> by the Calendar's agenda part but also for overall
> easy-to-use (eg. in teh model data()).
> 
> The event data is stored in EventData class, which has
> a pretty self-explanatory members, except perhaps the
> "isMinor" one. The intention with this is to support
> namedays, where in some countries the calendars have
> different name every day. This is just a minor holiday
> and as such should not mark the calendar grid, otherwise
> the whole grid would be in a different color.
> 
> Putting the interface here might raise the question of
> depending on plasma-framework, but plugins provided by
> KDE can go to plasma-workspace and other 3rd party ones
> would just have to live with it. I don't think it will
> be a problem but if it turns out it is, we can rethink
> the placement.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/CMakeLists.txt 40ead91 
>   src/declarativeimports/calendar/calendarplugin.cpp bafe80c 
>   src/declarativeimports/calendar/daysmodel.h a5bdac9 
>   src/declarativeimports/calendar/daysmodel.cpp 2d059a8 
>   src/declarativeimports/calendar/eventdatadecorator.h PRE-CREATION 
>   src/declarativeimports/calendar/eventdatadecorator.cpp PRE-CREATION 
>   src/declarativeimports/calendar/plasmacalendarintegration/CMakeLists.txt 
> PRE-CREATION 
>   
> src/declarativeimports/calendar/plasmacalendarintegration/PlasmaCalendarIntegrationConfig.cmake.in
>  PRE-CREATION 
>   
> src/declarativeimports/calendar/plasmacalendarintegration/calendareventsplugin.h
>  PRE-CREATION 
>   
> src/declarativeimports/calendar/plasmacalendarintegration/calendareventsplugin.cpp
>  PRE-CREATION 
>   src/declarativeimports/calendar/plasmacalendarintegration/eventdata_p.cpp 
> PRE-CREATION 
>   
> src/declarativeimports/calendar/plasmacalendarintegration/plasmacalendarintegration_export.h
>  PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125817/diff/
> 
> 
> Testing
> ---
> 
> I have a simple KHolidays based plugin written (patch should be up later 
> today)
> and patches in the Calendar applet.
> 
> Everything works as expected:
> * the days are marked as containing an event
> * the agenda part displays details of that event (name)
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-11-04 Thread Alex Richardson


> On Nov. 3, 2015, 9:47 p.m., Albert Astals Cid wrote:
> > How does this work without modifying 
> > KProtocolInfoPrivate::KProtocolInfoPrivate?
> 
> Christoph Cullmann wrote:
> You mean the JSON stuff? That was implemented in 
> https://git.reviewboard.kde.org/r/125830/
> For the http slave, that already works nicely, but we missed that 
> "ExtraNames" as used by other slaves need i18n care.
> 
> Albert Astals Cid wrote:
> i see, i did not see that there's two almost copied 
> KProtocolInfoPrivate::KProtocolInfoPrivate implementations
> 
> So the json magic stuff (you can see 
> ./src/ioslaves/http/kcookiejar/kcookiejar.json in kio) only works for 
> Description and Name inside KPlugin, someone would need to update 
> createjsoncontext.py and filljsonfrompo.py so they also take into account 
> ExtraNames inside childs of "KDE-KIO-Protocols" and then make that new code 
> from 125830 extract the correct translation from the json.

Reading the translated string can be done using 
`KPluginMetaData::readTranslatedString()`


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review87966
---


On Nov. 1, 2015, 6:13 p.m., Christoph Cullmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> ---
> 
> (Updated Nov. 1, 2015, 6:13 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David 
> Faure, and Luigi Toscano.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/CMakeLists.txt 76a8e28 
>   src/ioslaves/help/main_ghelp.cpp 59c8558 
>   src/ioslaves/help/main.cpp 9939196 
>   src/ioslaves/help/help.protocol 1deefe5 
>   src/ioslaves/help/help.json PRE-CREATION 
>   src/ioslaves/help/ghelp.protocol d2a642a 
>   src/ioslaves/help/ghelp.json PRE-CREATION 
>   src/ioslaves/help/CMakeLists.txt 867b59d 
>   src/ioslaves/ftp/ftp.protocol 4c5f80c 
>   src/ioslaves/ftp/ftp.json PRE-CREATION 
>   src/ioslaves/ftp/ftp.cpp 382723a 
>   src/ioslaves/ftp/CMakeLists.txt 04f5600 
>   src/ioslaves/file/file.protocol 523c0f5 
>   src/ioslaves/file/file.json PRE-CREATION 
>   src/ioslaves/file/file.cpp 5ef1587 
>   src/ioslaves/file/CMakeLists.txt cb85cfb 
>   autotests/kprotocolinfotest.cpp fa3ad38 
>   src/ioslaves/http/http.protocol 49e5dc5 
>   src/ioslaves/http/https.protocol c15d06f 
>   src/ioslaves/http/webdav.protocol 05c977a 
>   src/ioslaves/http/webdavs.protocol d5e4b2f 
>   src/ioslaves/trash/CMakeLists.txt 05161cd 
>   src/ioslaves/trash/kio_trash.cpp cb23169 
>   src/ioslaves/trash/trash.json PRE-CREATION 
>   src/ioslaves/trash/trash.protocol 7430575 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> ---
> 
> Tests still work (one needed patching, as the exec line contains now the full 
> path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
> sometimes it works, sometimes not :/ but even without this change.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 32 - Still Unstable!

2015-11-04 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/32/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 04 Nov 2015 17:03:56 +
Build duration: 3 min 46 sec

CHANGE SET
Revision a9c816d857874a59165ebd5824a900e019bbac5a by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit plasma_workspace.notifyrc


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.frameworkintegration-kdeplatformtheme_unittest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 3/3 (100%)FILES 20/20 (100%)CLASSES 20/20 (100%)LINE 1118/1749 
(64%)CONDITIONAL 424/795 (53%)

By packages
  
autotests
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 410/435 (94%)CONDITIONAL 
211/389 (54%)
src.kstyle
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 45/178 (25%)CONDITIONAL 
28/103 (27%)
src.platformtheme
FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 663/1136 
(58%)CONDITIONAL 185/303 (61%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 157 - Fixed!

2015-11-04 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/157/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 04 Nov 2015 17:06:45 +
Build duration: 13 min

CHANGE SET
Revision 956e2fde8dc805842ca550753de5972804232209 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit src/kcms/kio/uasproviders/safari32.desktop
  change: edit src/kcms/kio/uasproviders/wgetoncurrent.desktop
  change: edit src/kcms/kio/uasproviders/googlebot.desktop
  change: edit src/kcms/kio/uasproviders/ie90onwinnt71.desktop
  change: edit src/kcms/kio/uasproviders/ie60oncurrent.desktop
  change: edit src/urifilters/ikws/searchproviders/ctan.desktop
  change: edit src/kcms/kio/uasproviders/chrome50oncurrent.desktop
  change: edit src/kcms/kio/uasproviders/safari40.desktop
  change: edit src/ioslaves/protocols/data.protocol
  change: edit src/kcms/kio/uasproviders/nn475onwin95.desktop
  change: edit src/urifilters/ikws/searchproviders/thesaurus.desktop
  change: edit src/new_file_templates/linkPath.desktop
  change: edit src/kcms/kio/uasproviders/chrome23oncurrent.desktop
  change: edit src/urifilters/ikws/searchproviders/duckduckgo_shopping.desktop
  change: edit src/kcms/kio/uasproviders/ie55onwinnt5.desktop
  change: edit src/widgets/kpropertiesdialogplugin.desktop
  change: edit src/urifilters/ikws/searchproviders/google_shopping.desktop
  change: edit src/urifilters/shorturi/kshorturifilter.desktop
  change: edit src/urifilters/ikws/kuriikwsfilter.desktop
  change: edit src/kcms/kio/netpref.desktop
  change: edit src/kcms/kio/uasproviders/chrome10onwinnt51.desktop
  change: edit src/kcms/kio/uasproviders/w3moncurrent.desktop
  change: edit src/new_file_templates/TextFile.desktop
  change: edit src/new_file_templates/linkURL.desktop
  change: edit src/urifilters/ikws/searchproviders/yahoo_shopping.desktop
  change: edit src/kcms/kio/uasproviders/ns71oncurrent.desktop
  change: edit src/kcms/kio/uasproviders/op962oncurrent.desktop
  change: edit src/kcms/kio/uasproviders/android10.desktop
  change: edit src/urifilters/ikws/searchproviders/qwant.desktop
  change: edit src/ioslaves/mailto/kmailservice5.desktop
  change: edit src/urifilters/ikws/searchproviders/uspto.desktop
  change: edit src/kcms/kio/uasproviders/op1202oncurrent.desktop
  change: edit src/kcms/kio/uasproviders/safari30oniphone.desktop
  change: edit src/urifilters/ikws/searchproviders/dbug.desktop
  change: edit src/urifilters/ikws/searchproviders/rfc.desktop
  change: edit src/kcms/kio/smb.desktop
  change: edit src/kcms/kio/uasproviders/lynxoncurrent.desktop
  change: edit src/new_file_templates/Directory.desktop
  change: edit src/urifilters/ikws/searchproviders/qwant_shopping.desktop
  change: edit src/kcms/kio/uasproviders/op403onwinnt4.desktop
  change: edit src/urifilters/ikws/searchproviders/qwant_videos.desktop
  change: edit src/kpasswdserver/kpasswdserver.json
  change: edit src/urifilters/ikws/searchproviders/deb.desktop
  change: edit src/urifilters/ikws/searchproviders/qwant_news.desktop
  change: edit src/urifilters/ikws/searchproviders/qwant_social.desktop
  change: edit src/kcms/kio/uasproviders/op90oncurrent.desktop
  change: edit src/urifilters/ikws/searchproviders/multitran-deru.desktop
  change: edit 
src/urifilters/ikws/searchproviders/ruby_application_archive.desktop
  change: edit src/urifilters/ikws/searchproviders/wordref.desktop
  change: edit src/urifilters/ikws/searchproviders/wiktionary.desktop
  change: edit src/kcms/kio/uasproviders/nn475oncurrent.desktop
  change: edit src/urifilters/ikws/searchproviders/kde.desktop
  change: edit src/kcms/kio/uasproviders/op1162oncurrent.desktop
  change: edit src/urifilters/ikws/searchproviders/technoratitags.desktop
  change: edit 
src/urifilters/ikws/searchproviders/hyperdictionary_thesaurus.desktop
  change: edit src/urifilters/ikws/searchproviders/multitran-itru.desktop
  change: edit src/kcms/kio/cache.desktop
  change: edit src/urifilters/ikws/searchproviders/kde_forums.desktop
  change: edit src/kcms/kio/uasprovider.desktop
  change: edit src/urifilters/ikws/searchproviders/google_advanced.desktop
  change: edit src/urifilters/ikws/searchproviders/msdn.desktop
  change: edit src/kcms/kio/uasproviders/firefox30oncurrent.desktop
  change: edit src/kcms/kio/uasproviders/firefox36oncurrent.desktop
  change: edit src/urifilters/ikws/searchproviders/webster.desktop
  change: edit src/kcms/kio/uasproviders/chrome22oncurrent.desktop
  change: edit src/urifilters/ikws/searchproviders/qwant_images.desktop
  change: edit src/urifilters/ikws/searchproviders/google_movie.desktop
  change: edit src/urifilters/ikws/searchproviders/backports.desktop
  change: edit src/urifilters/ikws/searchproviders/ctan_cat.desktop
  change: edit src/ioslaves/protocols/mms.protocol
  change: edit src/kcms/kio/uasproviders/firefox20oncurrent.desktop
  change: edit 

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 157 - Fixed!

2015-11-04 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/157/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 04 Nov 2015 17:06:45 +
Build duration: 13 min

CHANGE SET
Revision 956e2fde8dc805842ca550753de5972804232209 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit src/kcms/kio/uasproviders/safari32.desktop
  change: edit src/kcms/kio/uasproviders/wgetoncurrent.desktop
  change: edit src/kcms/kio/uasproviders/googlebot.desktop
  change: edit src/kcms/kio/uasproviders/ie90onwinnt71.desktop
  change: edit src/kcms/kio/uasproviders/ie60oncurrent.desktop
  change: edit src/urifilters/ikws/searchproviders/ctan.desktop
  change: edit src/kcms/kio/uasproviders/chrome50oncurrent.desktop
  change: edit src/kcms/kio/uasproviders/safari40.desktop
  change: edit src/ioslaves/protocols/data.protocol
  change: edit src/kcms/kio/uasproviders/nn475onwin95.desktop
  change: edit src/urifilters/ikws/searchproviders/thesaurus.desktop
  change: edit src/new_file_templates/linkPath.desktop
  change: edit src/kcms/kio/uasproviders/chrome23oncurrent.desktop
  change: edit src/urifilters/ikws/searchproviders/duckduckgo_shopping.desktop
  change: edit src/kcms/kio/uasproviders/ie55onwinnt5.desktop
  change: edit src/widgets/kpropertiesdialogplugin.desktop
  change: edit src/urifilters/ikws/searchproviders/google_shopping.desktop
  change: edit src/urifilters/shorturi/kshorturifilter.desktop
  change: edit src/urifilters/ikws/kuriikwsfilter.desktop
  change: edit src/kcms/kio/netpref.desktop
  change: edit src/kcms/kio/uasproviders/chrome10onwinnt51.desktop
  change: edit src/kcms/kio/uasproviders/w3moncurrent.desktop
  change: edit src/new_file_templates/TextFile.desktop
  change: edit src/new_file_templates/linkURL.desktop
  change: edit src/urifilters/ikws/searchproviders/yahoo_shopping.desktop
  change: edit src/kcms/kio/uasproviders/ns71oncurrent.desktop
  change: edit src/kcms/kio/uasproviders/op962oncurrent.desktop
  change: edit src/kcms/kio/uasproviders/android10.desktop
  change: edit src/urifilters/ikws/searchproviders/qwant.desktop
  change: edit src/ioslaves/mailto/kmailservice5.desktop
  change: edit src/urifilters/ikws/searchproviders/uspto.desktop
  change: edit src/kcms/kio/uasproviders/op1202oncurrent.desktop
  change: edit src/kcms/kio/uasproviders/safari30oniphone.desktop
  change: edit src/urifilters/ikws/searchproviders/dbug.desktop
  change: edit src/urifilters/ikws/searchproviders/rfc.desktop
  change: edit src/kcms/kio/smb.desktop
  change: edit src/kcms/kio/uasproviders/lynxoncurrent.desktop
  change: edit src/new_file_templates/Directory.desktop
  change: edit src/urifilters/ikws/searchproviders/qwant_shopping.desktop
  change: edit src/kcms/kio/uasproviders/op403onwinnt4.desktop
  change: edit src/urifilters/ikws/searchproviders/qwant_videos.desktop
  change: edit src/kpasswdserver/kpasswdserver.json
  change: edit src/urifilters/ikws/searchproviders/deb.desktop
  change: edit src/urifilters/ikws/searchproviders/qwant_news.desktop
  change: edit src/urifilters/ikws/searchproviders/qwant_social.desktop
  change: edit src/kcms/kio/uasproviders/op90oncurrent.desktop
  change: edit src/urifilters/ikws/searchproviders/multitran-deru.desktop
  change: edit 
src/urifilters/ikws/searchproviders/ruby_application_archive.desktop
  change: edit src/urifilters/ikws/searchproviders/wordref.desktop
  change: edit src/urifilters/ikws/searchproviders/wiktionary.desktop
  change: edit src/kcms/kio/uasproviders/nn475oncurrent.desktop
  change: edit src/urifilters/ikws/searchproviders/kde.desktop
  change: edit src/kcms/kio/uasproviders/op1162oncurrent.desktop
  change: edit src/urifilters/ikws/searchproviders/technoratitags.desktop
  change: edit 
src/urifilters/ikws/searchproviders/hyperdictionary_thesaurus.desktop
  change: edit src/urifilters/ikws/searchproviders/multitran-itru.desktop
  change: edit src/kcms/kio/cache.desktop
  change: edit src/urifilters/ikws/searchproviders/kde_forums.desktop
  change: edit src/kcms/kio/uasprovider.desktop
  change: edit src/urifilters/ikws/searchproviders/google_advanced.desktop
  change: edit src/urifilters/ikws/searchproviders/msdn.desktop
  change: edit src/kcms/kio/uasproviders/firefox30oncurrent.desktop
  change: edit src/kcms/kio/uasproviders/firefox36oncurrent.desktop
  change: edit src/urifilters/ikws/searchproviders/webster.desktop
  change: edit src/kcms/kio/uasproviders/chrome22oncurrent.desktop
  change: edit src/urifilters/ikws/searchproviders/qwant_images.desktop
  change: edit src/urifilters/ikws/searchproviders/google_movie.desktop
  change: edit src/urifilters/ikws/searchproviders/backports.desktop
  change: edit src/urifilters/ikws/searchproviders/ctan_cat.desktop
  change: edit src/ioslaves/protocols/mms.protocol
  change: edit src/kcms/kio/uasproviders/firefox20oncurrent.desktop
  change: edit 

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-11-04 Thread Christoph Cullmann


> On Nov. 3, 2015, 9:47 p.m., Albert Astals Cid wrote:
> > How does this work without modifying 
> > KProtocolInfoPrivate::KProtocolInfoPrivate?
> 
> Christoph Cullmann wrote:
> You mean the JSON stuff? That was implemented in 
> https://git.reviewboard.kde.org/r/125830/
> For the http slave, that already works nicely, but we missed that 
> "ExtraNames" as used by other slaves need i18n care.
> 
> Albert Astals Cid wrote:
> i see, i did not see that there's two almost copied 
> KProtocolInfoPrivate::KProtocolInfoPrivate implementations
> 
> So the json magic stuff (you can see 
> ./src/ioslaves/http/kcookiejar/kcookiejar.json in kio) only works for 
> Description and Name inside KPlugin, someone would need to update 
> createjsoncontext.py and filljsonfrompo.py so they also take into account 
> ExtraNames inside childs of "KDE-KIO-Protocols" and then make that new code 
> from 125830 extract the correct translation from the json.
> 
> Alex Richardson wrote:
> Reading the translated string can be done using 
> `KPluginMetaData::readTranslatedString()`

Hmm, Ok, can take a look at that scripts. Will it be a problem that the 
ExtraNames are a stringlist or is that fine?


- Christoph


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125869/#review87966
---


On Nov. 1, 2015, 6:13 p.m., Christoph Cullmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125869/
> ---
> 
> (Updated Nov. 1, 2015, 6:13 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David 
> Faure, and Luigi Toscano.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Convert all io slave .protocol data to json and embed it.
> Allows easier deployment of the slaves.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/CMakeLists.txt 76a8e28 
>   src/ioslaves/help/main_ghelp.cpp 59c8558 
>   src/ioslaves/help/main.cpp 9939196 
>   src/ioslaves/help/help.protocol 1deefe5 
>   src/ioslaves/help/help.json PRE-CREATION 
>   src/ioslaves/help/ghelp.protocol d2a642a 
>   src/ioslaves/help/ghelp.json PRE-CREATION 
>   src/ioslaves/help/CMakeLists.txt 867b59d 
>   src/ioslaves/ftp/ftp.protocol 4c5f80c 
>   src/ioslaves/ftp/ftp.json PRE-CREATION 
>   src/ioslaves/ftp/ftp.cpp 382723a 
>   src/ioslaves/ftp/CMakeLists.txt 04f5600 
>   src/ioslaves/file/file.protocol 523c0f5 
>   src/ioslaves/file/file.json PRE-CREATION 
>   src/ioslaves/file/file.cpp 5ef1587 
>   src/ioslaves/file/CMakeLists.txt cb85cfb 
>   autotests/kprotocolinfotest.cpp fa3ad38 
>   src/ioslaves/http/http.protocol 49e5dc5 
>   src/ioslaves/http/https.protocol c15d06f 
>   src/ioslaves/http/webdav.protocol 05c977a 
>   src/ioslaves/http/webdavs.protocol d5e4b2f 
>   src/ioslaves/trash/CMakeLists.txt 05161cd 
>   src/ioslaves/trash/kio_trash.cpp cb23169 
>   src/ioslaves/trash/trash.json PRE-CREATION 
>   src/ioslaves/trash/trash.protocol 7430575 
> 
> Diff: https://git.reviewboard.kde.org/r/125869/diff/
> 
> 
> Testing
> ---
> 
> Tests still work (one needed patching, as the exec line contains now the full 
> path).
> 
> Correction: Somehow the ./autotests/jobtest test is unstable for me here, 
> sometimes it works, sometimes not :/ but even without this change.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: [OS X] "unknown type name 'KARCHIVE_DEPRECATED'" building kdoctools

2015-11-04 Thread Alex Merry

On 2015-11-04 15:53, René J.V. Bertin wrote:

Hi,

Building KF5/kdoctools 5.15.0 on OS X, I run into 2 issues:

- the #include  statement finds the corresponding header
from KDELibs4
- after changing the statement into #include 
(which I think it should be anyway?), I get the error

In file included from
/opt/local/var/macports/build/_opt_local_site-ports_kf5_Frameworks/kf5-kdoctools/work/kdoctools-5.15.0/src/xslt_kde.cpp:2:
/opt/local/include/KF5/KArchive/kfilterdev.h:95:5: error: unknown type
name 'KARCHIVE_DEPRECATED'
KARCHIVE_DEPRECATED static KCompressionDevice *deviceForFile(const
QString ,
^
/opt/local/include/KF5/KArchive/kfilterdev.h:95:25: error: expected
member name or ';' after declaration specifiers
KARCHIVE_DEPRECATED static KCompressionDevice *deviceForFile(const
QString ,
~~~ ^

I take it that I could #define KARCHIVE_DEPRECATED to get around this,
but I have a hunch I shouldn't be getting the warning in the 1st
place?


Looks like your include path is wrong. /opt/local/include/KF5/KArchive 
should be in the include path (before wherever wherever your kdelibs4 
headers are).


Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 125815: Provide an alternative when khelpcenter is not available

2015-11-04 Thread Alex Merry

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125815/#review88019
---

Ship it!


As you noted, it's better than the current situation, so I say ship it.


src/util/urlhandler.cpp (line 29)


Unused include


- Alex Merry


On Nov. 4, 2015, 5:55 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125815/
> ---
> 
> (Updated Nov. 4, 2015, 5:55 p.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Cullmann and Luigi Toscano.
> 
> 
> Repository: kguiaddons
> 
> 
> Description
> ---
> 
> Tries to reach out to docs.kde.org when khelpcenter is not available.
> 
> 
> Diffs
> -
> 
>   src/util/urlhandler.cpp 5b46be2 
> 
> Diff: https://git.reviewboard.kde.org/r/125815/diff/
> 
> 
> Testing
> ---
> 
> I tried it with a couple of applications. For the main documentation just 
> works.
> 
> Needs figuring out for more complex cases, I'm unsure if applications are 
> opening the documentation in specific pages. In fact, I couldn't find the 
> documentation for docs.kde.org url scheme, and I just made up the `path` 
> part, although it seems to work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 125815: Provide an alternative when khelpcenter is not available

2015-11-04 Thread Ralf Habacker


> On Nov. 4, 2015, 1:43 vorm., Aleix Pol Gonzalez wrote:
> > Bump? Anyone with docs.kde.org knowledge around?
> 
> Ben Cooksley wrote:
> As long as the application name is being submitted in lower case, it 
> should work fine.
> 
> Examples: 
> https://docs.kde.org/index.php?branch=stable5=gwenview
> https://docs.kde.org/index.php?branch=stable5=konversation
> https://docs.kde.org/index.php?branch=stable5=dolphin
> 
> Luigi Toscano wrote:
> There are few exceptions for kioslaves and kcm modules:
> application=kioslave5/ftp for kioslaves (or kioslave/ftp for the kdelibs4 
> based version)
> application=kcontrol/powerdevil
> Not sure if they need to be handled there or those values are already 
> specified as applicationName()
> 
> For the record, all the source code is here:
> https://quickgit.kde.org/?p=websites%2Fdocs-kde-org.git=tree

What about language selection ? khelpcenter also covers to select the language 
currently used in the KDE environment.


- Ralf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125815/#review87979
---


On Nov. 4, 2015, 6:55 nachm., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125815/
> ---
> 
> (Updated Nov. 4, 2015, 6:55 nachm.)
> 
> 
> Review request for KDE Frameworks, Christoph Cullmann and Luigi Toscano.
> 
> 
> Repository: kguiaddons
> 
> 
> Description
> ---
> 
> Tries to reach out to docs.kde.org when khelpcenter is not available.
> 
> 
> Diffs
> -
> 
>   src/util/urlhandler.cpp 5b46be2 
> 
> Diff: https://git.reviewboard.kde.org/r/125815/diff/
> 
> 
> Testing
> ---
> 
> I tried it with a couple of applications. For the main documentation just 
> works.
> 
> Needs figuring out for more complex cases, I'm unsure if applications are 
> opening the documentation in specific pages. In fact, I couldn't find the 
> documentation for docs.kde.org url scheme, and I just made up the `path` 
> part, although it seems to work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


[OS X] "unknown type name 'KARCHIVE_DEPRECATED'" building kdoctools

2015-11-04 Thread René J . V . Bertin
Hi,

Building KF5/kdoctools 5.15.0 on OS X, I run into 2 issues:

- the #include  statement finds the corresponding header from 
KDELibs4
- after changing the statement into #include  (which I 
think it should be anyway?), I get the error

In file included from 
/opt/local/var/macports/build/_opt_local_site-ports_kf5_Frameworks/kf5-kdoctools/work/kdoctools-5.15.0/src/xslt_kde.cpp:2:
/opt/local/include/KF5/KArchive/kfilterdev.h:95:5: error: unknown type name 
'KARCHIVE_DEPRECATED'
KARCHIVE_DEPRECATED static KCompressionDevice *deviceForFile(const QString 
,
^
/opt/local/include/KF5/KArchive/kfilterdev.h:95:25: error: expected member name 
or ';' after declaration specifiers
KARCHIVE_DEPRECATED static KCompressionDevice *deviceForFile(const QString 
,
~~~ ^

I take it that I could #define KARCHIVE_DEPRECATED to get around this, but I 
have a hunch I shouldn't be getting the warning in the 1st place?

Thanks,
R.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 118 - Still Unstable!

2015-11-04 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/118/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Wed, 04 Nov 2015 11:11:59 +
Build duration: 7 min 17 sec

CHANGE SET
Revision 651f50071d081ffbbd24fd29f519dfd6ce14a1a4 by Marco Martin: (restore 
expanders)
  change: edit src/desktoptheme/breeze/widgets/tasks.svgz


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.dialognativetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 63/104 (61%)CLASSES 63/104 (61%)LINE 3908/10009 
(39%)CONDITIONAL 1917/3034 (63%)

By packages
  
autotests
FILES 20/20 (100%)CLASSES 20/20 (100%)LINE 543/564 
(96%)CONDITIONAL 338/606 (56%)
src.declarativeimports.core
FILES 7/20 (35%)CLASSES 7/20 (35%)LINE 355/2003 
(18%)CONDITIONAL 148/228 (65%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1588/3635 
(44%)CONDITIONAL 776/1192 (65%)
src.plasma.private
FILES 18/26 (69%)CLASSES 18/26 (69%)LINE 942/1739 
(54%)CONDITIONAL 395/600 (66%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/184 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 4/11 (36%)CLASSES 4/11 (36%)LINE 480/1771 
(27%)CONDITIONAL 260/408 (64%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 127 - Still Unstable!

2015-11-04 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/127/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Wed, 04 Nov 2015 11:11:59 +
Build duration: 7 min 51 sec

CHANGE SET
Revision 651f50071d081ffbbd24fd29f519dfd6ce14a1a4 by Marco Martin: (restore 
expanders)
  change: edit src/desktoptheme/breeze/widgets/tasks.svgz


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.dialognativetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 63/104 (61%)CLASSES 63/104 (61%)LINE 3915/10047 
(39%)CONDITIONAL 1916/3034 (63%)

By packages
  
autotests
FILES 20/20 (100%)CLASSES 20/20 (100%)LINE 542/565 
(96%)CONDITIONAL 338/606 (56%)
src.declarativeimports.core
FILES 7/20 (35%)CLASSES 7/20 (35%)LINE 356/2004 
(18%)CONDITIONAL 148/228 (65%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1591/3640 
(44%)CONDITIONAL 776/1192 (65%)
src.plasma.private
FILES 18/26 (69%)CLASSES 18/26 (69%)LINE 945/1746 
(54%)CONDITIONAL 394/600 (66%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/194 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 4/11 (36%)CLASSES 4/11 (36%)LINE 481/1785 
(27%)CONDITIONAL 260/408 (64%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 125815: Provide an alternative when khelpcenter is not available

2015-11-04 Thread Aleix Pol Gonzalez

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125815/
---

(Updated Nov. 4, 2015, 6:55 p.m.)


Review request for KDE Frameworks, Christoph Cullmann and Luigi Toscano.


Changes
---

The apache redirections do something similar to my patch 
https://quickgit.kde.org/?p=websites%2Fdocs-kde-org.git=blob=ae03e951c8d7cb8dda070e1a9592ea0a15ecc0f9=apache-docs.kde.org.conf=plain.

I suggest to have it merged, as it will always work better than the current 
state which is just show an error.


Summary (updated)
-

Provide an alternative when khelpcenter is not available


Repository: kguiaddons


Description
---

Tries to reach out to docs.kde.org when khelpcenter is not available.


Diffs
-

  src/util/urlhandler.cpp 5b46be2 

Diff: https://git.reviewboard.kde.org/r/125815/diff/


Testing
---

I tried it with a couple of applications. For the main documentation just works.

Needs figuring out for more complex cases, I'm unsure if applications are 
opening the documentation in specific pages. In fact, I couldn't find the 
documentation for docs.kde.org url scheme, and I just made up the `path` part, 
although it seems to work.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel