Re: Deadlock in kded whith Qt 5.6

2016-01-22 Thread David Faure
On Thursday 21 January 2016 13:54:32 Thiago Macieira wrote:
> Can I limit the spy hook to method calls? That is, exclude signals.

Yes, for the purpose of kded/kiod that is fine
A not-loaded-yet-module cannot possibly connect to a dbus signal.

> Another attempt, also untested.

It works !

Even the proxyscout module with its usage of system bus in the module ctor gets 
autostarted+autoloaded just fine.

Thanks Thiago.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kio master stable-kf5-qt5 ยป Linux,gcc - Build # 202 - Unstable!

2016-01-22 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/202/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 22 Jan 2016 08:22:56 +
Build duration: 7 min 57 sec

CHANGE SET
Revision 40dfecf226b24188c8866bfc9577d118da7cfba9 by David Faure: (Revert 
BlockingQueuedConnection hack, Qt 5.6 will contain a better fix.)
  change: edit src/kiod/kiod_main.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 
47 test(s)Failed: TestSuite.kiocore-threadtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 20/20 (100%)FILES 252/330 (76%)CLASSES 252/330 (76%)LINE 24884/50059 
(50%)CONDITIONAL 13443/20783 (65%)

By packages
  
autotests
FILES 60/60 (100%)CLASSES 60/60 (100%)LINE 7063/7280 
(97%)CONDITIONAL 3856/7093 (54%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 475/476 
(100%)CONDITIONAL 166/272 (61%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 182/199 (91%)CONDITIONAL 
60/90 (67%)
src.core
FILES 94/116 (81%)CLASSES 94/116 (81%)LINE 7448/14032 
(53%)CONDITIONAL 3909/5437 (72%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2281/7586 
(30%)CONDITIONAL 907/1399 (65%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 430/843 (51%)CONDITIONAL 
313/459 (68%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 750/3799 
(20%)CONDITIONAL 547/678 (81%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 642/804 (80%)CONDITIONAL 
602/758 (79%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 684/1182 (58%)CONDITIONAL 
358/495 (72%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 690/768 (90%)CONDITIONAL 
433/820 (53%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/26 (54%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 302/388 (78%)CONDITIONAL 
86/108 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 384/600 (64%)CONDITIONAL 
280/408 (69%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 280/285 (98%)CONDITIONAL 
144/254 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 32/35 (91%)CONDITIONAL 
42/52 (81%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 248/743 (33%)CONDITIONAL 
147/194 (76%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 20/27 (74%)CONDITIONAL 
14/18 (78%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 229/259 (88%)CONDITIONAL 
293/358 (82%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2695/10634 
(25%)CONDITIONAL 1278/1874 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 126836: DropArea: Fix correctly ignoring dragEnter event with preventStealing

2016-01-22 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126836/#review91437
---


Ship it!




Ship It!

- David Edmundson


On Jan. 21, 2016, 2:30 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126836/
> ---
> 
> (Updated Jan. 21, 2016, 2:30 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> temporaryInhibitParent must not be called when event is ignored.
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/draganddrop/DeclarativeDropArea.cpp 20d65e4 
> 
> Diff: https://git.reviewboard.kde.org/r/126836/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 126836: DropArea: Fix correctly ignoring dragEnter event with preventStealing

2016-01-22 Thread David Rosca

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126836/
---

(Updated Jan. 22, 2016, 11:31 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 014b8a2d263fec83da760a50ef44572a423add1e by David Rosca 
to branch master.


Repository: kdeclarative


Description
---

temporaryInhibitParent must not be called when event is ignored.


Diffs
-

  src/qmlcontrols/draganddrop/DeclarativeDropArea.cpp 20d65e4 

Diff: https://git.reviewboard.kde.org/r/126836/diff/


Testing
---


Thanks,

David Rosca

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Deadlock in kded whith Qt 5.6

2016-01-22 Thread Thiago Macieira
On Friday 22 January 2016 09:21:12 David Faure wrote:
> On Thursday 21 January 2016 13:54:32 Thiago Macieira wrote:
> > Can I limit the spy hook to method calls? That is, exclude signals.
> 
> Yes, for the purpose of kded/kiod that is fine
> A not-loaded-yet-module cannot possibly connect to a dbus signal.
> 
> > Another attempt, also untested.
> 
> It works !
> 
> Even the proxyscout module with its usage of system bus in the module ctor
> gets autostarted+autoloaded just fine.
> 
> Thanks Thiago.

You're welcome. This version is simpler too.

I've just uploaded PS 4 with this version and an updated commit message.

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center
  PGP/GPG: 0x6EF45358; fingerprint:
  E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 126632: add a "Complementary" color scheme to kcolorscheme

2016-01-22 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126632/
---

(Updated Jan. 22, 2016, 8:52 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 71ddb9ff47a00cc17c70a877794405d251a9130c by Marco Martin 
to branch master.


Repository: kconfigwidgets


Description
---

Since some releases, plasma-frameworks locally expands kcolorscheme to have a 
new "Complementary" section: this is done for things like the lockscreen and 
the logout ui, where the colors are flipped from the current theme.
A local extension there is kinda unfortunate as makes the color configs files 
not completely compatible, and I think there is an use case for this in normal 
applications as well (Gwenview switches to a dark palette when in fullscreen 
mode for instance)
Since I want to make the default plasma theme follow the system color scheme, I 
would need for it to support this "complementary" area as well.


Diffs
-

  src/kcolorscheme.h 22bc21b 
  src/kcolorscheme.cpp 427ffa4 

Diff: https://git.reviewboard.kde.org/r/126632/diff/


Testing
---


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel