Re: Review Request 126949: Remove Air and Oxygen themes

[Marco Martin]

> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
> 
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here: 
> http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of 
> the controls)
> 
> I can file all these as bugs if you want.
> 
> andreas kainz wrote:
> There are missing icons from the oxygen plasma theme and in the future 
> also in oxygen-icons. I will work on this but without this the theme is not 
> that broken as you show in the screenshot when you use everything from oxygen 
> (plasma theme, icons, window decoration, ...) 
> https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/OxygenDesktop.png
> 
> Marco Martin wrote:
> it's fine they are missing in the plasma themes, those themes were 
> designed to have systray icons explicitly different (to change that, all of 
> their icons can just be deleted and they will fallback)
> 
> Marco Martin wrote:
> what do you mean with the bottom frame of the controls?
> 
> Martin Klapetek wrote:
> @andreas - This is only about the Plasma theme, using different icons or 
> window decoration has zero impact on the theme itself.
> 
> The Plasma theme has many broken things, here's a list of what I've 
> noticed in just couple minutes:
> * task manager buttons have too big margins; the icons are tiny and text 
> is gone
> * all button-based controls have strangely stretched bottom frame
> * kicker has artifacts in the submenu corners that touch the parent menus
> * the selection box in listviews is smaller than the items, making the 
> icons in systray popup be painted outside of the selection rectangle
> * placeholder text has no inner left padding on text inputs
> * the blinking cursor in text inputs can be painted partially outside the 
> input field
> * sliders have artifacts in corners
> * network manager has no selection painted on hover, it's missing quite a 
> few graphical things it seems
> * everything has a hge shadow (although that may be a feature)
> 
> ...it's not just about setting the theme and looking at the default 
> desktop and making a screenshot. You have to use it for a while.
> 
> These are all fixable, but given the last useful commit in air/ was June 
> 2014, I had considered this as unmaintained.
> 
> Martin Klapetek wrote:
> > what do you mean with the bottom frame of the controls?
> 
> Look at the button or the checkbox in my screenshot, their bottom frame 
> looks huge.
> 
> Marco Martin wrote:
> many of those bugs are actually a symptom of bad compatibility with older 
> themes (tough made worse by high dpi).
> and this is actually a problem of plasma, as the compatibility of themes 
> was, and still is a promise (and I had already had to modify things around in 
> controls or plasmoids specifically to fix the look is some random old theme)
> 
> Martin Klapetek wrote:
> Yeah, I figured hidpi probably makes these details much more exposed. 
> Another thing to consider is the number of bug reports with old themes. I 
> remember a single one, I don't think there were that many more. Which either 
> means that nobody uses old themes or that all good themes were updated to 
> Plasma 5 already (or that Breeze is just perfect).
> 
> Maybe Air and Oxygen should then just be updated to not be "old" anymore? 
> I imagine that when theme creators tested the old themes against Plasma 
> 5(.0/.1), it looked broken and so they went ahead and fixed it on their side.
> 
> Marco Martin wrote:
> one regression over Plasma4 for instance is that it used to remove panel 
> border paddings even to 0 if needed if the panel size went less that allowing 
> for a smallmedium icon to be displayed. Breeze just happens to have tiny 
> margins but it's just a peculiarity of that theme. that should be restored.
> 
> Marco Martin wrote:
> I am willing to work on both of them, to fix the few objective bugs, but 
> most important to fix everything around it to have the behavior as identic as 
> possible.
> 
> Marco Martin wrote:
> > Look at the button or the checkbox in my screenshot, their bottom frame 
> looks huge.
> I know, it's how is supposed to be, as the giant shadow.
> 
> there are only two actual bugs i can hee here or in the screenshot: that 
> panel margins and the sliders grooves (tabbar indicators may also have a bit 
> of extra side margins that shouldn't be there).
> the rest you can say you don't like it, but it's how is supposed to look
> 
> Marco Martin wrote:
> so i would:
> 
> * fix the panel "decrease margins until icons are big enough" behavior 
> that was implemented but broken
> 
> * do a couple of fixes in air of actual problems (already on my hard 
> drive)
> 
> * remove custom icons in both themes
> 
> * fix another 

Re: Review Request 126949: Remove Air and Oxygen themes

[Martin Klapetek]

> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
> 
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here: 
> http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of 
> the controls)
> 
> I can file all these as bugs if you want.
> 
> andreas kainz wrote:
> There are missing icons from the oxygen plasma theme and in the future 
> also in oxygen-icons. I will work on this but without this the theme is not 
> that broken as you show in the screenshot when you use everything from oxygen 
> (plasma theme, icons, window decoration, ...) 
> https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/OxygenDesktop.png
> 
> Marco Martin wrote:
> it's fine they are missing in the plasma themes, those themes were 
> designed to have systray icons explicitly different (to change that, all of 
> their icons can just be deleted and they will fallback)
> 
> Marco Martin wrote:
> what do you mean with the bottom frame of the controls?
> 
> Martin Klapetek wrote:
> @andreas - This is only about the Plasma theme, using different icons or 
> window decoration has zero impact on the theme itself.
> 
> The Plasma theme has many broken things, here's a list of what I've 
> noticed in just couple minutes:
> * task manager buttons have too big margins; the icons are tiny and text 
> is gone
> * all button-based controls have strangely stretched bottom frame
> * kicker has artifacts in the submenu corners that touch the parent menus
> * the selection box in listviews is smaller than the items, making the 
> icons in systray popup be painted outside of the selection rectangle
> * placeholder text has no inner left padding on text inputs
> * the blinking cursor in text inputs can be painted partially outside the 
> input field
> * sliders have artifacts in corners
> * network manager has no selection painted on hover, it's missing quite a 
> few graphical things it seems
> * everything has a hge shadow (although that may be a feature)
> 
> ...it's not just about setting the theme and looking at the default 
> desktop and making a screenshot. You have to use it for a while.
> 
> These are all fixable, but given the last useful commit in air/ was June 
> 2014, I had considered this as unmaintained.
> 
> Martin Klapetek wrote:
> > what do you mean with the bottom frame of the controls?
> 
> Look at the button or the checkbox in my screenshot, their bottom frame 
> looks huge.
> 
> Marco Martin wrote:
> many of those bugs are actually a symptom of bad compatibility with older 
> themes (tough made worse by high dpi).
> and this is actually a problem of plasma, as the compatibility of themes 
> was, and still is a promise (and I had already had to modify things around in 
> controls or plasmoids specifically to fix the look is some random old theme)
> 
> Martin Klapetek wrote:
> Yeah, I figured hidpi probably makes these details much more exposed. 
> Another thing to consider is the number of bug reports with old themes. I 
> remember a single one, I don't think there were that many more. Which either 
> means that nobody uses old themes or that all good themes were updated to 
> Plasma 5 already (or that Breeze is just perfect).
> 
> Maybe Air and Oxygen should then just be updated to not be "old" anymore? 
> I imagine that when theme creators tested the old themes against Plasma 
> 5(.0/.1), it looked broken and so they went ahead and fixed it on their side.
> 
> Marco Martin wrote:
> one regression over Plasma4 for instance is that it used to remove panel 
> border paddings even to 0 if needed if the panel size went less that allowing 
> for a smallmedium icon to be displayed. Breeze just happens to have tiny 
> margins but it's just a peculiarity of that theme. that should be restored.
> 
> Marco Martin wrote:
> I am willing to work on both of them, to fix the few objective bugs, but 
> most important to fix everything around it to have the behavior as identic as 
> possible.
> 
> Marco Martin wrote:
> > Look at the button or the checkbox in my screenshot, their bottom frame 
> looks huge.
> I know, it's how is supposed to be, as the giant shadow.
> 
> there are only two actual bugs i can hee here or in the screenshot: that 
> panel margins and the sliders grooves (tabbar indicators may also have a bit 
> of extra side margins that shouldn't be there).
> the rest you can say you don't like it, but it's how is supposed to look
> 
> Marco Martin wrote:
> so i would:
> 
> * fix the panel "decrease margins until icons are big enough" behavior 
> that was implemented but broken
> 
> * do a couple of fixes in air of actual problems (already on my hard 
> drive)
> 
> * remove custom icons in both themes
> 
> * fix another

Re: Review Request 126949: Remove Air and Oxygen themes

[Marco Martin]

> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
> 
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here: 
> http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of 
> the controls)
> 
> I can file all these as bugs if you want.
> 
> andreas kainz wrote:
> There are missing icons from the oxygen plasma theme and in the future 
> also in oxygen-icons. I will work on this but without this the theme is not 
> that broken as you show in the screenshot when you use everything from oxygen 
> (plasma theme, icons, window decoration, ...) 
> https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/OxygenDesktop.png
> 
> Marco Martin wrote:
> it's fine they are missing in the plasma themes, those themes were 
> designed to have systray icons explicitly different (to change that, all of 
> their icons can just be deleted and they will fallback)
> 
> Marco Martin wrote:
> what do you mean with the bottom frame of the controls?
> 
> Martin Klapetek wrote:
> @andreas - This is only about the Plasma theme, using different icons or 
> window decoration has zero impact on the theme itself.
> 
> The Plasma theme has many broken things, here's a list of what I've 
> noticed in just couple minutes:
> * task manager buttons have too big margins; the icons are tiny and text 
> is gone
> * all button-based controls have strangely stretched bottom frame
> * kicker has artifacts in the submenu corners that touch the parent menus
> * the selection box in listviews is smaller than the items, making the 
> icons in systray popup be painted outside of the selection rectangle
> * placeholder text has no inner left padding on text inputs
> * the blinking cursor in text inputs can be painted partially outside the 
> input field
> * sliders have artifacts in corners
> * network manager has no selection painted on hover, it's missing quite a 
> few graphical things it seems
> * everything has a hge shadow (although that may be a feature)
> 
> ...it's not just about setting the theme and looking at the default 
> desktop and making a screenshot. You have to use it for a while.
> 
> These are all fixable, but given the last useful commit in air/ was June 
> 2014, I had considered this as unmaintained.
> 
> Martin Klapetek wrote:
> > what do you mean with the bottom frame of the controls?
> 
> Look at the button or the checkbox in my screenshot, their bottom frame 
> looks huge.
> 
> Marco Martin wrote:
> many of those bugs are actually a symptom of bad compatibility with older 
> themes (tough made worse by high dpi).
> and this is actually a problem of plasma, as the compatibility of themes 
> was, and still is a promise (and I had already had to modify things around in 
> controls or plasmoids specifically to fix the look is some random old theme)
> 
> Martin Klapetek wrote:
> Yeah, I figured hidpi probably makes these details much more exposed. 
> Another thing to consider is the number of bug reports with old themes. I 
> remember a single one, I don't think there were that many more. Which either 
> means that nobody uses old themes or that all good themes were updated to 
> Plasma 5 already (or that Breeze is just perfect).
> 
> Maybe Air and Oxygen should then just be updated to not be "old" anymore? 
> I imagine that when theme creators tested the old themes against Plasma 
> 5(.0/.1), it looked broken and so they went ahead and fixed it on their side.
> 
> Marco Martin wrote:
> one regression over Plasma4 for instance is that it used to remove panel 
> border paddings even to 0 if needed if the panel size went less that allowing 
> for a smallmedium icon to be displayed. Breeze just happens to have tiny 
> margins but it's just a peculiarity of that theme. that should be restored.
> 
> Marco Martin wrote:
> I am willing to work on both of them, to fix the few objective bugs, but 
> most important to fix everything around it to have the behavior as identic as 
> possible.
> 
> Marco Martin wrote:
> > Look at the button or the checkbox in my screenshot, their bottom frame 
> looks huge.
> I know, it's how is supposed to be, as the giant shadow.
> 
> there are only two actual bugs i can hee here or in the screenshot: that 
> panel margins and the sliders grooves (tabbar indicators may also have a bit 
> of extra side margins that shouldn't be there).
> the rest you can say you don't like it, but it's how is supposed to look
> 
> Marco Martin wrote:
> so i would:
> 
> * fix the panel "decrease margins until icons are big enough" behavior 
> that was implemented but broken
> 
> * do a couple of fixes in air of actual problems (already on my hard 
> drive)
> 
> * remove custom icons in both themes
> 
> * fix another 

Re: Review Request 126949: Remove Air and Oxygen themes

[Martin Klapetek]

> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
> 
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here: 
> http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of 
> the controls)
> 
> I can file all these as bugs if you want.
> 
> andreas kainz wrote:
> There are missing icons from the oxygen plasma theme and in the future 
> also in oxygen-icons. I will work on this but without this the theme is not 
> that broken as you show in the screenshot when you use everything from oxygen 
> (plasma theme, icons, window decoration, ...) 
> https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/OxygenDesktop.png
> 
> Marco Martin wrote:
> it's fine they are missing in the plasma themes, those themes were 
> designed to have systray icons explicitly different (to change that, all of 
> their icons can just be deleted and they will fallback)
> 
> Marco Martin wrote:
> what do you mean with the bottom frame of the controls?
> 
> Martin Klapetek wrote:
> @andreas - This is only about the Plasma theme, using different icons or 
> window decoration has zero impact on the theme itself.
> 
> The Plasma theme has many broken things, here's a list of what I've 
> noticed in just couple minutes:
> * task manager buttons have too big margins; the icons are tiny and text 
> is gone
> * all button-based controls have strangely stretched bottom frame
> * kicker has artifacts in the submenu corners that touch the parent menus
> * the selection box in listviews is smaller than the items, making the 
> icons in systray popup be painted outside of the selection rectangle
> * placeholder text has no inner left padding on text inputs
> * the blinking cursor in text inputs can be painted partially outside the 
> input field
> * sliders have artifacts in corners
> * network manager has no selection painted on hover, it's missing quite a 
> few graphical things it seems
> * everything has a hge shadow (although that may be a feature)
> 
> ...it's not just about setting the theme and looking at the default 
> desktop and making a screenshot. You have to use it for a while.
> 
> These are all fixable, but given the last useful commit in air/ was June 
> 2014, I had considered this as unmaintained.
> 
> Martin Klapetek wrote:
> > what do you mean with the bottom frame of the controls?
> 
> Look at the button or the checkbox in my screenshot, their bottom frame 
> looks huge.
> 
> Marco Martin wrote:
> many of those bugs are actually a symptom of bad compatibility with older 
> themes (tough made worse by high dpi).
> and this is actually a problem of plasma, as the compatibility of themes 
> was, and still is a promise (and I had already had to modify things around in 
> controls or plasmoids specifically to fix the look is some random old theme)
> 
> Martin Klapetek wrote:
> Yeah, I figured hidpi probably makes these details much more exposed. 
> Another thing to consider is the number of bug reports with old themes. I 
> remember a single one, I don't think there were that many more. Which either 
> means that nobody uses old themes or that all good themes were updated to 
> Plasma 5 already (or that Breeze is just perfect).
> 
> Maybe Air and Oxygen should then just be updated to not be "old" anymore? 
> I imagine that when theme creators tested the old themes against Plasma 
> 5(.0/.1), it looked broken and so they went ahead and fixed it on their side.
> 
> Marco Martin wrote:
> one regression over Plasma4 for instance is that it used to remove panel 
> border paddings even to 0 if needed if the panel size went less that allowing 
> for a smallmedium icon to be displayed. Breeze just happens to have tiny 
> margins but it's just a peculiarity of that theme. that should be restored.
> 
> Marco Martin wrote:
> I am willing to work on both of them, to fix the few objective bugs, but 
> most important to fix everything around it to have the behavior as identic as 
> possible.
> 
> Marco Martin wrote:
> > Look at the button or the checkbox in my screenshot, their bottom frame 
> looks huge.
> I know, it's how is supposed to be, as the giant shadow.
> 
> there are only two actual bugs i can hee here or in the screenshot: that 
> panel margins and the sliders grooves (tabbar indicators may also have a bit 
> of extra side margins that shouldn't be there).
> the rest you can say you don't like it, but it's how is supposed to look
> 
> Marco Martin wrote:
> so i would:
> 
> * fix the panel "decrease margins until icons are big enough" behavior 
> that was implemented but broken
> 
> * do a couple of fixes in air of actual problems (already on my hard 
> drive)
> 
> * remove custom icons in both themes
> 
> * fix another

Re: Review Request 126949: Remove Air and Oxygen themes

[Marco Martin]

> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
> 
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here: 
> http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of 
> the controls)
> 
> I can file all these as bugs if you want.
> 
> andreas kainz wrote:
> There are missing icons from the oxygen plasma theme and in the future 
> also in oxygen-icons. I will work on this but without this the theme is not 
> that broken as you show in the screenshot when you use everything from oxygen 
> (plasma theme, icons, window decoration, ...) 
> https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/OxygenDesktop.png
> 
> Marco Martin wrote:
> it's fine they are missing in the plasma themes, those themes were 
> designed to have systray icons explicitly different (to change that, all of 
> their icons can just be deleted and they will fallback)
> 
> Marco Martin wrote:
> what do you mean with the bottom frame of the controls?
> 
> Martin Klapetek wrote:
> @andreas - This is only about the Plasma theme, using different icons or 
> window decoration has zero impact on the theme itself.
> 
> The Plasma theme has many broken things, here's a list of what I've 
> noticed in just couple minutes:
> * task manager buttons have too big margins; the icons are tiny and text 
> is gone
> * all button-based controls have strangely stretched bottom frame
> * kicker has artifacts in the submenu corners that touch the parent menus
> * the selection box in listviews is smaller than the items, making the 
> icons in systray popup be painted outside of the selection rectangle
> * placeholder text has no inner left padding on text inputs
> * the blinking cursor in text inputs can be painted partially outside the 
> input field
> * sliders have artifacts in corners
> * network manager has no selection painted on hover, it's missing quite a 
> few graphical things it seems
> * everything has a hge shadow (although that may be a feature)
> 
> ...it's not just about setting the theme and looking at the default 
> desktop and making a screenshot. You have to use it for a while.
> 
> These are all fixable, but given the last useful commit in air/ was June 
> 2014, I had considered this as unmaintained.
> 
> Martin Klapetek wrote:
> > what do you mean with the bottom frame of the controls?
> 
> Look at the button or the checkbox in my screenshot, their bottom frame 
> looks huge.
> 
> Marco Martin wrote:
> many of those bugs are actually a symptom of bad compatibility with older 
> themes (tough made worse by high dpi).
> and this is actually a problem of plasma, as the compatibility of themes 
> was, and still is a promise (and I had already had to modify things around in 
> controls or plasmoids specifically to fix the look is some random old theme)
> 
> Martin Klapetek wrote:
> Yeah, I figured hidpi probably makes these details much more exposed. 
> Another thing to consider is the number of bug reports with old themes. I 
> remember a single one, I don't think there were that many more. Which either 
> means that nobody uses old themes or that all good themes were updated to 
> Plasma 5 already (or that Breeze is just perfect).
> 
> Maybe Air and Oxygen should then just be updated to not be "old" anymore? 
> I imagine that when theme creators tested the old themes against Plasma 
> 5(.0/.1), it looked broken and so they went ahead and fixed it on their side.
> 
> Marco Martin wrote:
> one regression over Plasma4 for instance is that it used to remove panel 
> border paddings even to 0 if needed if the panel size went less that allowing 
> for a smallmedium icon to be displayed. Breeze just happens to have tiny 
> margins but it's just a peculiarity of that theme. that should be restored.
> 
> Marco Martin wrote:
> I am willing to work on both of them, to fix the few objective bugs, but 
> most important to fix everything around it to have the behavior as identic as 
> possible.
> 
> Marco Martin wrote:
> > Look at the button or the checkbox in my screenshot, their bottom frame 
> looks huge.
> I know, it's how is supposed to be, as the giant shadow.
> 
> there are only two actual bugs i can hee here or in the screenshot: that 
> panel margins and the sliders grooves (tabbar indicators may also have a bit 
> of extra side margins that shouldn't be there).
> the rest you can say you don't like it, but it's how is supposed to look

so i would:

* fix the panel "decrease margins until icons are big enough" behavior that was 
implemented but broken

* do a couple of fixes in air of actual problems (already on my hard drive)

* remove custom icons in both themes

* fix another problem i found in push buttons because this is using the button 
shadow element, t

Re: Review Request 126949: Remove Air and Oxygen themes

[Marco Martin]

> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
> 
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here: 
> http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of 
> the controls)
> 
> I can file all these as bugs if you want.
> 
> andreas kainz wrote:
> There are missing icons from the oxygen plasma theme and in the future 
> also in oxygen-icons. I will work on this but without this the theme is not 
> that broken as you show in the screenshot when you use everything from oxygen 
> (plasma theme, icons, window decoration, ...) 
> https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/OxygenDesktop.png
> 
> Marco Martin wrote:
> it's fine they are missing in the plasma themes, those themes were 
> designed to have systray icons explicitly different (to change that, all of 
> their icons can just be deleted and they will fallback)
> 
> Marco Martin wrote:
> what do you mean with the bottom frame of the controls?
> 
> Martin Klapetek wrote:
> @andreas - This is only about the Plasma theme, using different icons or 
> window decoration has zero impact on the theme itself.
> 
> The Plasma theme has many broken things, here's a list of what I've 
> noticed in just couple minutes:
> * task manager buttons have too big margins; the icons are tiny and text 
> is gone
> * all button-based controls have strangely stretched bottom frame
> * kicker has artifacts in the submenu corners that touch the parent menus
> * the selection box in listviews is smaller than the items, making the 
> icons in systray popup be painted outside of the selection rectangle
> * placeholder text has no inner left padding on text inputs
> * the blinking cursor in text inputs can be painted partially outside the 
> input field
> * sliders have artifacts in corners
> * network manager has no selection painted on hover, it's missing quite a 
> few graphical things it seems
> * everything has a hge shadow (although that may be a feature)
> 
> ...it's not just about setting the theme and looking at the default 
> desktop and making a screenshot. You have to use it for a while.
> 
> These are all fixable, but given the last useful commit in air/ was June 
> 2014, I had considered this as unmaintained.
> 
> Martin Klapetek wrote:
> > what do you mean with the bottom frame of the controls?
> 
> Look at the button or the checkbox in my screenshot, their bottom frame 
> looks huge.
> 
> Marco Martin wrote:
> many of those bugs are actually a symptom of bad compatibility with older 
> themes (tough made worse by high dpi).
> and this is actually a problem of plasma, as the compatibility of themes 
> was, and still is a promise (and I had already had to modify things around in 
> controls or plasmoids specifically to fix the look is some random old theme)
> 
> Martin Klapetek wrote:
> Yeah, I figured hidpi probably makes these details much more exposed. 
> Another thing to consider is the number of bug reports with old themes. I 
> remember a single one, I don't think there were that many more. Which either 
> means that nobody uses old themes or that all good themes were updated to 
> Plasma 5 already (or that Breeze is just perfect).
> 
> Maybe Air and Oxygen should then just be updated to not be "old" anymore? 
> I imagine that when theme creators tested the old themes against Plasma 
> 5(.0/.1), it looked broken and so they went ahead and fixed it on their side.
> 
> Marco Martin wrote:
> one regression over Plasma4 for instance is that it used to remove panel 
> border paddings even to 0 if needed if the panel size went less that allowing 
> for a smallmedium icon to be displayed. Breeze just happens to have tiny 
> margins but it's just a peculiarity of that theme. that should be restored.
> 
> Marco Martin wrote:
> I am willing to work on both of them, to fix the few objective bugs, but 
> most important to fix everything around it to have the behavior as identic as 
> possible.

> Look at the button or the checkbox in my screenshot, their bottom frame looks 
> huge.
I know, it's how is supposed to be, as the giant shadow.

there are only two actual bugs i can hee here or in the screenshot: that panel 
margins and the sliders grooves (tabbar indicators may also have a bit of extra 
side margins that shouldn't be there).
the rest you can say you don't like it, but it's how is supposed to look


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91924
---


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automaticall

Re: Review Request 126949: Remove Air and Oxygen themes

[Marco Martin]

> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
> 
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here: 
> http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of 
> the controls)
> 
> I can file all these as bugs if you want.
> 
> andreas kainz wrote:
> There are missing icons from the oxygen plasma theme and in the future 
> also in oxygen-icons. I will work on this but without this the theme is not 
> that broken as you show in the screenshot when you use everything from oxygen 
> (plasma theme, icons, window decoration, ...) 
> https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/OxygenDesktop.png
> 
> Marco Martin wrote:
> it's fine they are missing in the plasma themes, those themes were 
> designed to have systray icons explicitly different (to change that, all of 
> their icons can just be deleted and they will fallback)
> 
> Marco Martin wrote:
> what do you mean with the bottom frame of the controls?
> 
> Martin Klapetek wrote:
> @andreas - This is only about the Plasma theme, using different icons or 
> window decoration has zero impact on the theme itself.
> 
> The Plasma theme has many broken things, here's a list of what I've 
> noticed in just couple minutes:
> * task manager buttons have too big margins; the icons are tiny and text 
> is gone
> * all button-based controls have strangely stretched bottom frame
> * kicker has artifacts in the submenu corners that touch the parent menus
> * the selection box in listviews is smaller than the items, making the 
> icons in systray popup be painted outside of the selection rectangle
> * placeholder text has no inner left padding on text inputs
> * the blinking cursor in text inputs can be painted partially outside the 
> input field
> * sliders have artifacts in corners
> * network manager has no selection painted on hover, it's missing quite a 
> few graphical things it seems
> * everything has a hge shadow (although that may be a feature)
> 
> ...it's not just about setting the theme and looking at the default 
> desktop and making a screenshot. You have to use it for a while.
> 
> These are all fixable, but given the last useful commit in air/ was June 
> 2014, I had considered this as unmaintained.
> 
> Martin Klapetek wrote:
> > what do you mean with the bottom frame of the controls?
> 
> Look at the button or the checkbox in my screenshot, their bottom frame 
> looks huge.
> 
> Marco Martin wrote:
> many of those bugs are actually a symptom of bad compatibility with older 
> themes (tough made worse by high dpi).
> and this is actually a problem of plasma, as the compatibility of themes 
> was, and still is a promise (and I had already had to modify things around in 
> controls or plasmoids specifically to fix the look is some random old theme)
> 
> Martin Klapetek wrote:
> Yeah, I figured hidpi probably makes these details much more exposed. 
> Another thing to consider is the number of bug reports with old themes. I 
> remember a single one, I don't think there were that many more. Which either 
> means that nobody uses old themes or that all good themes were updated to 
> Plasma 5 already (or that Breeze is just perfect).
> 
> Maybe Air and Oxygen should then just be updated to not be "old" anymore? 
> I imagine that when theme creators tested the old themes against Plasma 
> 5(.0/.1), it looked broken and so they went ahead and fixed it on their side.
> 
> Marco Martin wrote:
> one regression over Plasma4 for instance is that it used to remove panel 
> border paddings even to 0 if needed if the panel size went less that allowing 
> for a smallmedium icon to be displayed. Breeze just happens to have tiny 
> margins but it's just a peculiarity of that theme. that should be restored.

I am willing to work on both of them, to fix the few objective bugs, but most 
important to fix everything around it to have the behavior as identic as 
possible.


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91924
---


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remo

Re: Review Request 126949: Remove Air and Oxygen themes

[Marco Martin]

> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
> 
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here: 
> http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of 
> the controls)
> 
> I can file all these as bugs if you want.
> 
> andreas kainz wrote:
> There are missing icons from the oxygen plasma theme and in the future 
> also in oxygen-icons. I will work on this but without this the theme is not 
> that broken as you show in the screenshot when you use everything from oxygen 
> (plasma theme, icons, window decoration, ...) 
> https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/OxygenDesktop.png
> 
> Marco Martin wrote:
> it's fine they are missing in the plasma themes, those themes were 
> designed to have systray icons explicitly different (to change that, all of 
> their icons can just be deleted and they will fallback)
> 
> Marco Martin wrote:
> what do you mean with the bottom frame of the controls?
> 
> Martin Klapetek wrote:
> @andreas - This is only about the Plasma theme, using different icons or 
> window decoration has zero impact on the theme itself.
> 
> The Plasma theme has many broken things, here's a list of what I've 
> noticed in just couple minutes:
> * task manager buttons have too big margins; the icons are tiny and text 
> is gone
> * all button-based controls have strangely stretched bottom frame
> * kicker has artifacts in the submenu corners that touch the parent menus
> * the selection box in listviews is smaller than the items, making the 
> icons in systray popup be painted outside of the selection rectangle
> * placeholder text has no inner left padding on text inputs
> * the blinking cursor in text inputs can be painted partially outside the 
> input field
> * sliders have artifacts in corners
> * network manager has no selection painted on hover, it's missing quite a 
> few graphical things it seems
> * everything has a hge shadow (although that may be a feature)
> 
> ...it's not just about setting the theme and looking at the default 
> desktop and making a screenshot. You have to use it for a while.
> 
> These are all fixable, but given the last useful commit in air/ was June 
> 2014, I had considered this as unmaintained.
> 
> Martin Klapetek wrote:
> > what do you mean with the bottom frame of the controls?
> 
> Look at the button or the checkbox in my screenshot, their bottom frame 
> looks huge.
> 
> Marco Martin wrote:
> many of those bugs are actually a symptom of bad compatibility with older 
> themes (tough made worse by high dpi).
> and this is actually a problem of plasma, as the compatibility of themes 
> was, and still is a promise (and I had already had to modify things around in 
> controls or plasmoids specifically to fix the look is some random old theme)
> 
> Martin Klapetek wrote:
> Yeah, I figured hidpi probably makes these details much more exposed. 
> Another thing to consider is the number of bug reports with old themes. I 
> remember a single one, I don't think there were that many more. Which either 
> means that nobody uses old themes or that all good themes were updated to 
> Plasma 5 already (or that Breeze is just perfect).
> 
> Maybe Air and Oxygen should then just be updated to not be "old" anymore? 
> I imagine that when theme creators tested the old themes against Plasma 
> 5(.0/.1), it looked broken and so they went ahead and fixed it on their side.

one regression over Plasma4 for instance is that it used to remove panel border 
paddings even to 0 if needed if the panel size went less that allowing for a 
smallmedium icon to be displayed. Breeze just happens to have tiny margins but 
it's just a peculiarity of that theme. that should be restored.


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91924
---


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktopthe

Re: Review Request 126949: Remove Air and Oxygen themes

[Martin Klapetek]

> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
> 
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here: 
> http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of 
> the controls)
> 
> I can file all these as bugs if you want.
> 
> andreas kainz wrote:
> There are missing icons from the oxygen plasma theme and in the future 
> also in oxygen-icons. I will work on this but without this the theme is not 
> that broken as you show in the screenshot when you use everything from oxygen 
> (plasma theme, icons, window decoration, ...) 
> https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/OxygenDesktop.png
> 
> Marco Martin wrote:
> it's fine they are missing in the plasma themes, those themes were 
> designed to have systray icons explicitly different (to change that, all of 
> their icons can just be deleted and they will fallback)
> 
> Marco Martin wrote:
> what do you mean with the bottom frame of the controls?
> 
> Martin Klapetek wrote:
> @andreas - This is only about the Plasma theme, using different icons or 
> window decoration has zero impact on the theme itself.
> 
> The Plasma theme has many broken things, here's a list of what I've 
> noticed in just couple minutes:
> * task manager buttons have too big margins; the icons are tiny and text 
> is gone
> * all button-based controls have strangely stretched bottom frame
> * kicker has artifacts in the submenu corners that touch the parent menus
> * the selection box in listviews is smaller than the items, making the 
> icons in systray popup be painted outside of the selection rectangle
> * placeholder text has no inner left padding on text inputs
> * the blinking cursor in text inputs can be painted partially outside the 
> input field
> * sliders have artifacts in corners
> * network manager has no selection painted on hover, it's missing quite a 
> few graphical things it seems
> * everything has a hge shadow (although that may be a feature)
> 
> ...it's not just about setting the theme and looking at the default 
> desktop and making a screenshot. You have to use it for a while.
> 
> These are all fixable, but given the last useful commit in air/ was June 
> 2014, I had considered this as unmaintained.
> 
> Martin Klapetek wrote:
> > what do you mean with the bottom frame of the controls?
> 
> Look at the button or the checkbox in my screenshot, their bottom frame 
> looks huge.
> 
> Marco Martin wrote:
> many of those bugs are actually a symptom of bad compatibility with older 
> themes (tough made worse by high dpi).
> and this is actually a problem of plasma, as the compatibility of themes 
> was, and still is a promise (and I had already had to modify things around in 
> controls or plasmoids specifically to fix the look is some random old theme)

Yeah, I figured hidpi probably makes these details much more exposed. Another 
thing to consider is the number of bug reports with old themes. I remember a 
single one, I don't think there were that many more. Which either means that 
nobody uses old themes or that all good themes were updated to Plasma 5 already 
(or that Breeze is just perfect).

Maybe Air and Oxygen should then just be updated to not be "old" anymore? I 
imagine that when theme creators tested the old themes against Plasma 5(.0/.1), 
it looked broken and so they went ahead and fixed it on their side.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91924
---


On Feb. 1, 2016, 8:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 8:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c

Re: Review Request 126949: Remove Air and Oxygen themes

[Martin Klapetek]

> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
> 
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here: 
> http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of 
> the controls)
> 
> I can file all these as bugs if you want.
> 
> andreas kainz wrote:
> There are missing icons from the oxygen plasma theme and in the future 
> also in oxygen-icons. I will work on this but without this the theme is not 
> that broken as you show in the screenshot when you use everything from oxygen 
> (plasma theme, icons, window decoration, ...) 
> https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/OxygenDesktop.png
> 
> Marco Martin wrote:
> it's fine they are missing in the plasma themes, those themes were 
> designed to have systray icons explicitly different (to change that, all of 
> their icons can just be deleted and they will fallback)
> 
> Marco Martin wrote:
> what do you mean with the bottom frame of the controls?
> 
> Martin Klapetek wrote:
> @andreas - This is only about the Plasma theme, using different icons or 
> window decoration has zero impact on the theme itself.
> 
> The Plasma theme has many broken things, here's a list of what I've 
> noticed in just couple minutes:
> * task manager buttons have too big margins; the icons are tiny and text 
> is gone
> * all button-based controls have strangely stretched bottom frame
> * kicker has artifacts in the submenu corners that touch the parent menus
> * the selection box in listviews is smaller than the items, making the 
> icons in systray popup be painted outside of the selection rectangle
> * placeholder text has no inner left padding on text inputs
> * the blinking cursor in text inputs can be painted partially outside the 
> input field
> * sliders have artifacts in corners
> * network manager has no selection painted on hover, it's missing quite a 
> few graphical things it seems
> * everything has a hge shadow (although that may be a feature)
> 
> ...it's not just about setting the theme and looking at the default 
> desktop and making a screenshot. You have to use it for a while.
> 
> These are all fixable, but given the last useful commit in air/ was June 
> 2014, I had considered this as unmaintained.

> what do you mean with the bottom frame of the controls?

Look at the button or the checkbox in my screenshot, their bottom frame looks 
huge.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91924
---


On Feb. 1, 2016, 8:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 8:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab9

Re: Review Request 126949: Remove Air and Oxygen themes

[Marco Martin]

> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
> 
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here: 
> http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of 
> the controls)
> 
> I can file all these as bugs if you want.
> 
> andreas kainz wrote:
> There are missing icons from the oxygen plasma theme and in the future 
> also in oxygen-icons. I will work on this but without this the theme is not 
> that broken as you show in the screenshot when you use everything from oxygen 
> (plasma theme, icons, window decoration, ...) 
> https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/OxygenDesktop.png
> 
> Marco Martin wrote:
> it's fine they are missing in the plasma themes, those themes were 
> designed to have systray icons explicitly different (to change that, all of 
> their icons can just be deleted and they will fallback)
> 
> Marco Martin wrote:
> what do you mean with the bottom frame of the controls?
> 
> Martin Klapetek wrote:
> @andreas - This is only about the Plasma theme, using different icons or 
> window decoration has zero impact on the theme itself.
> 
> The Plasma theme has many broken things, here's a list of what I've 
> noticed in just couple minutes:
> * task manager buttons have too big margins; the icons are tiny and text 
> is gone
> * all button-based controls have strangely stretched bottom frame
> * kicker has artifacts in the submenu corners that touch the parent menus
> * the selection box in listviews is smaller than the items, making the 
> icons in systray popup be painted outside of the selection rectangle
> * placeholder text has no inner left padding on text inputs
> * the blinking cursor in text inputs can be painted partially outside the 
> input field
> * sliders have artifacts in corners
> * network manager has no selection painted on hover, it's missing quite a 
> few graphical things it seems
> * everything has a hge shadow (although that may be a feature)
> 
> ...it's not just about setting the theme and looking at the default 
> desktop and making a screenshot. You have to use it for a while.
> 
> These are all fixable, but given the last useful commit in air/ was June 
> 2014, I had considered this as unmaintained.
> 
> Martin Klapetek wrote:
> > what do you mean with the bottom frame of the controls?
> 
> Look at the button or the checkbox in my screenshot, their bottom frame 
> looks huge.

many of those bugs are actually a symptom of bad compatibility with older 
themes (tough made worse by high dpi).
and this is actually a problem of plasma, as the compatibility of themes was, 
and still is a promise (and I had already had to modify things around in 
controls or plasmoids specifically to fix the look is some random old theme)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91924
---


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorr

Re: Review Request 126949: Remove Air and Oxygen themes

[Martin Klapetek]

> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
> 
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here: 
> http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of 
> the controls)
> 
> I can file all these as bugs if you want.
> 
> andreas kainz wrote:
> There are missing icons from the oxygen plasma theme and in the future 
> also in oxygen-icons. I will work on this but without this the theme is not 
> that broken as you show in the screenshot when you use everything from oxygen 
> (plasma theme, icons, window decoration, ...) 
> https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/OxygenDesktop.png
> 
> Marco Martin wrote:
> it's fine they are missing in the plasma themes, those themes were 
> designed to have systray icons explicitly different (to change that, all of 
> their icons can just be deleted and they will fallback)
> 
> Marco Martin wrote:
> what do you mean with the bottom frame of the controls?

@andreas - This is only about the Plasma theme, using different icons or window 
decoration has zero impact on the theme itself.

The Plasma theme has many broken things, here's a list of what I've noticed in 
just couple minutes:
* task manager buttons have too big margins; the icons are tiny and text is gone
* all button-based controls have strangely stretched bottom frame
* kicker has artifacts in the submenu corners that touch the parent menus
* the selection box in listviews is smaller than the items, making the icons in 
systray popup be painted outside of the selection rectangle
* placeholder text has no inner left padding on text inputs
* the blinking cursor in text inputs can be painted partially outside the input 
field
* sliders have artifacts in corners
* network manager has no selection painted on hover, it's missing quite a few 
graphical things it seems
* everything has a hge shadow (although that may be a feature)

...it's not just about setting the theme and looking at the default desktop and 
making a screenshot. You have to use it for a while.

These are all fixable, but given the last useful commit in air/ was June 2014, 
I had considered this as unmaintained.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91924
---


On Feb. 1, 2016, 8:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 8:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/m

Re: Review Request 126949: Remove Air and Oxygen themes

[Marco Martin]

> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
> 
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here: 
> http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of 
> the controls)
> 
> I can file all these as bugs if you want.
> 
> andreas kainz wrote:
> There are missing icons from the oxygen plasma theme and in the future 
> also in oxygen-icons. I will work on this but without this the theme is not 
> that broken as you show in the screenshot when you use everything from oxygen 
> (plasma theme, icons, window decoration, ...) 
> https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/OxygenDesktop.png
> 
> Marco Martin wrote:
> it's fine they are missing in the plasma themes, those themes were 
> designed to have systray icons explicitly different (to change that, all of 
> their icons can just be deleted and they will fallback)

what do you mean with the bottom frame of the controls?


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91924
---


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
>   src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
>   src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
>   src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
>   src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
>   src/desktoptheme/air/widgets/actionbutton.svgz e1713ea 
>   src/desktoptheme/air/widgets/analog_meter.svgz f0d2163 
>   src/desktoptheme/air/widgets/arrows.svgz b987b32 
>   src/desktoptheme/air/widgets/background.svgz 174a8fc 
>   src/desktoptheme/air/widgets/bar_meter_horizontal.svgz 8031b77 
>   src/desktoptheme/air/widgets/bar_meter_vertical.svgz 1b0660d 
>   src/desktoptheme/air/widgets/branding.svgz c6316fb 
>   src/desktoptheme/air/widgets/

Re: Review Request 126949: Remove Air and Oxygen themes

[Marco Martin]

> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
> 
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here: 
> http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of 
> the controls)
> 
> I can file all these as bugs if you want.
> 
> andreas kainz wrote:
> There are missing icons from the oxygen plasma theme and in the future 
> also in oxygen-icons. I will work on this but without this the theme is not 
> that broken as you show in the screenshot when you use everything from oxygen 
> (plasma theme, icons, window decoration, ...) 
> https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/OxygenDesktop.png

it's fine they are missing in the plasma themes, those themes were designed to 
have systray icons explicitly different (to change that, all of their icons can 
just be deleted and they will fallback)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91924
---


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
>   src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
>   src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
>   src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
>   src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
>   src/desktoptheme/air/widgets/actionbutton.svgz e1713ea 
>   src/desktoptheme/air/widgets/analog_meter.svgz f0d2163 
>   src/desktoptheme/air/widgets/arrows.svgz b987b32 
>   src/desktoptheme/air/widgets/background.svgz 174a8fc 
>   src/desktoptheme/air/widgets/bar_meter_horizontal.svgz 8031b77 
>   src/desktoptheme/air/widgets/bar_meter_vertical.svgz 1b0660d 
>   src/desktoptheme/air/widgets/branding.svgz c6316fb 
>   src/desktoptheme/air/widgets/busywidget.svgz f638cfb 
>   src/desktoptheme/air/widgets/button.svgz 2c529bf 
>   src/desk

Re: Review Request 126949: Remove Air and Oxygen themes

[andreas kainz]

> On Feb. 2, 2016, 9:17 vorm., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme
> 
> Martin Klapetek wrote:
> Then we got some fixing to do as this is how Air looks like here: 
> http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of 
> the controls)
> 
> I can file all these as bugs if you want.

There are missing icons from the oxygen plasma theme and in the future also in 
oxygen-icons. I will work on this but without this the theme is not that broken 
as you show in the screenshot when you use everything from oxygen (plasma 
theme, icons, window decoration, ...) 
https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/OxygenDesktop.png


- andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91924
---


On Feb. 1, 2016, 7:30 nachm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
>   src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
>   src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
>   src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
>   src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
>   src/desktoptheme/air/widgets/actionbutton.svgz e1713ea 
>   src/desktoptheme/air/widgets/analog_meter.svgz f0d2163 
>   src/desktoptheme/air/widgets/arrows.svgz b987b32 
>   src/desktoptheme/air/widgets/background.svgz 174a8fc 
>   src/desktoptheme/air/widgets/bar_meter_horizontal.svgz 8031b77 
>   src/desktoptheme/air/widgets/bar_meter_vertical.svgz 1b0660d 
>   src/desktoptheme/air/widgets/branding.svgz c6316fb 
>   src/desktoptheme/air/widgets/busywidget.svgz f638cfb 
>   src/desktoptheme/air/widgets/button.svgz 2c529bf 
>   src/desktoptheme/air/widgets/calendar.svgz 2d80a49 
>   src/desktoptheme/air/widgets/checkmarks.svgz dcf2924 
>   src/desktoptheme/air/widgets/clock.svgz 3839dac 
>   src/desktoptheme/air/widgets/configuration-icons.svgz 9b212d3 
>   src/desk

Re: Review Request 126949: Remove Air and Oxygen themes

[Thomas Pfeiffer]

> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote:
> > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the 
> > time I need the plasma oxygen theme too to give the user the one single 
> > click feature (look & feel package). Is there an space where you can move 
> > "unmaintained" stuff and the distros can choose what they want to ship. now 
> > all distros ship oxygen.
> > 
> > I love breeze but oxygen is also really sexy in addition a lot of uers work 
> > with kde4 (which is unmainted too) and update to kf5 with Kubuntu 16.04 
> > LTS. It would be bad to support oxygen for an additional LTS cycle, but for 
> > the switch it would be nice to give the user the posibility for an soft 
> > switch.
> 
> andreas kainz wrote:
> in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Kai Uwe Broulik wrote:
> There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> andreas kainz wrote:
> ok. that would fit for me. since now we have not that much look and feel 
> packages most distros use it for there look and feel stuff and than breeze 
> and breeze-dark for people how don't like monochrome (there are a lot) is 
> oxygen. it would be nice to have more packages there available so move the 
> oxygen stuff in an spacific area is fine for me but don't move them to 
> kde-look cause than oxygen is more broken than now and no one can fix it any 
> more.
> 
> thanks Kai
> 
> Martin Klapetek wrote:
> > in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Really? Got any examples?
> 
> > There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> 
> Ok, I'll put it there then.
> 
> David Edmundson wrote:
> Andreas, note the oxygen widget style and plasma theme are different 
> things. 
> The Oxygen plasma style is this theme: 
> https://www.kde.org/announcements/4.0/screenshots/desktop.jpg
> 
> the widget style isn't being touched.
> 
> andreas kainz wrote:
> can we add ALL oxygen stuff in one "unmaintained" area?
> 
> Hugo Pereira Da Costa wrote:
> Wait wait, neither oxygen widget style nor window decoration are 
> unmaintained. (nor broken as far as I know)
> They are in "maintenance" mode on the contrary. Meaning: they are "done", 
> there won't be any new feature, but bugs get fixed when reported. 
> Please 
> - dont move them anywhere else,
> - dont move broken, nor truely unmaintained things in there.
> This is not a trash can :)
> 
> Thx,
> 
> Hugo
> 
> Kai Uwe Broulik wrote:
> Yes, Hugo is doing a fine job of maintaining Oxygen stuff and 
> cherry-picking fixes from Breeze. :) It's really just the Plasma theme that 
> is utterly broken and unmaintained.
> 
> andreas kainz wrote:
> I'v never done a plasma theme but I saw how the breeze theme get broken 
> and how it was fixed again. As Hugo maintaine oxygen stuff and I maintain 
> oxygen icon stuff, it would be good to have the plasma theme also available. 
> I can offer to maintain the oxygen plasma theme (one of them).
> 
> Marco Martin wrote:
> oxygen icon or oxygen style repository? for me both would be good.
> 
> note that if you chose the oxygen look and feel it sets the oxygen widget 
> style and the Air plasma theme, that should be still the case.
> 
> Thomas Pfeiffer wrote:
> I'd say we need one theme to go with the Oxygen Look & Feel package. If 
> Air is still maintainted and used in the L&F, then killing Oxygen from our 
> repos should be fine.
> I'm against putting it on kde-look, however, because we don't want 
> unmaintained and broken stuff on there, either. kde-look currently is used 
> kind of as a junkyard by some, but this has to change if we want to showcase 
> it more.
> 
> Boudhayan Gupta wrote:
> I'm still of the opinion that it makes more sense to put everything 
> Oxygen in one package; given that Oxygen is not the default theme for Plasma 
> anymore we shouldn't ship it with the default look-n-feel package at all.

Having everything needed for a complete Oxygen L&F theme package which then 
becomes an optional dependency for Plasma sounds sensible to me. That way, 
distros can decide whether they want to ship only Breeze and Breeze Dark L&Fs 
or Oxygen as well.
While of course it's possible for users to mix and match Breeze and Oxygen, I 
assume that most users will want either all Oxygen or all Breeze, so shipping 
anything Oxygen only makes sense if users can selecta  complete Oxygen L&F with 
all components working.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883

Re: Review Request 126949: Remove Air and Oxygen themes

[Boudhayan Gupta]

> On Feb. 2, 2016, 1:42 a.m., andreas kainz wrote:
> > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the 
> > time I need the plasma oxygen theme too to give the user the one single 
> > click feature (look & feel package). Is there an space where you can move 
> > "unmaintained" stuff and the distros can choose what they want to ship. now 
> > all distros ship oxygen.
> > 
> > I love breeze but oxygen is also really sexy in addition a lot of uers work 
> > with kde4 (which is unmainted too) and update to kf5 with Kubuntu 16.04 
> > LTS. It would be bad to support oxygen for an additional LTS cycle, but for 
> > the switch it would be nice to give the user the posibility for an soft 
> > switch.
> 
> andreas kainz wrote:
> in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Kai Uwe Broulik wrote:
> There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> andreas kainz wrote:
> ok. that would fit for me. since now we have not that much look and feel 
> packages most distros use it for there look and feel stuff and than breeze 
> and breeze-dark for people how don't like monochrome (there are a lot) is 
> oxygen. it would be nice to have more packages there available so move the 
> oxygen stuff in an spacific area is fine for me but don't move them to 
> kde-look cause than oxygen is more broken than now and no one can fix it any 
> more.
> 
> thanks Kai
> 
> Martin Klapetek wrote:
> > in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Really? Got any examples?
> 
> > There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> 
> Ok, I'll put it there then.
> 
> David Edmundson wrote:
> Andreas, note the oxygen widget style and plasma theme are different 
> things. 
> The Oxygen plasma style is this theme: 
> https://www.kde.org/announcements/4.0/screenshots/desktop.jpg
> 
> the widget style isn't being touched.
> 
> andreas kainz wrote:
> can we add ALL oxygen stuff in one "unmaintained" area?
> 
> Hugo Pereira Da Costa wrote:
> Wait wait, neither oxygen widget style nor window decoration are 
> unmaintained. (nor broken as far as I know)
> They are in "maintenance" mode on the contrary. Meaning: they are "done", 
> there won't be any new feature, but bugs get fixed when reported. 
> Please 
> - dont move them anywhere else,
> - dont move broken, nor truely unmaintained things in there.
> This is not a trash can :)
> 
> Thx,
> 
> Hugo
> 
> Kai Uwe Broulik wrote:
> Yes, Hugo is doing a fine job of maintaining Oxygen stuff and 
> cherry-picking fixes from Breeze. :) It's really just the Plasma theme that 
> is utterly broken and unmaintained.
> 
> andreas kainz wrote:
> I'v never done a plasma theme but I saw how the breeze theme get broken 
> and how it was fixed again. As Hugo maintaine oxygen stuff and I maintain 
> oxygen icon stuff, it would be good to have the plasma theme also available. 
> I can offer to maintain the oxygen plasma theme (one of them).
> 
> Marco Martin wrote:
> oxygen icon or oxygen style repository? for me both would be good.
> 
> note that if you chose the oxygen look and feel it sets the oxygen widget 
> style and the Air plasma theme, that should be still the case.
> 
> Thomas Pfeiffer wrote:
> I'd say we need one theme to go with the Oxygen Look & Feel package. If 
> Air is still maintainted and used in the L&F, then killing Oxygen from our 
> repos should be fine.
> I'm against putting it on kde-look, however, because we don't want 
> unmaintained and broken stuff on there, either. kde-look currently is used 
> kind of as a junkyard by some, but this has to change if we want to showcase 
> it more.

I'm still of the opinion that it makes more sense to put everything Oxygen in 
one package; given that Oxygen is not the default theme for Plasma anymore we 
shouldn't ship it with the default look-n-feel package at all.


- Boudhayan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883
---


On Feb. 2, 2016, 1 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 2, 2016, 1 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---

Re: Review Request 126969: KRecursiveFilterProxyModel::match: Fix crash

[Kevin Funk]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126969/
---

(Updated Feb. 2, 2016, 8:41 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Volker Krause.


Changes
---

Submitted with commit 11055706bca380b75da48b8f5d4c27c53d86372d by Kevin Funk to 
branch master.


Repository: kitemmodels


Description
---

As seen in GammaRay


Diffs
-

  src/krecursivefilterproxymodel.cpp dbb6eba421c0e680fffe43582f210ea3e42e6e7f 

Diff: https://git.reviewboard.kde.org/r/126969/diff/


Testing
---


Thanks,

Kevin Funk

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126949: Remove Air and Oxygen themes

[Thomas Pfeiffer]

> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote:
> > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the 
> > time I need the plasma oxygen theme too to give the user the one single 
> > click feature (look & feel package). Is there an space where you can move 
> > "unmaintained" stuff and the distros can choose what they want to ship. now 
> > all distros ship oxygen.
> > 
> > I love breeze but oxygen is also really sexy in addition a lot of uers work 
> > with kde4 (which is unmainted too) and update to kf5 with Kubuntu 16.04 
> > LTS. It would be bad to support oxygen for an additional LTS cycle, but for 
> > the switch it would be nice to give the user the posibility for an soft 
> > switch.
> 
> andreas kainz wrote:
> in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Kai Uwe Broulik wrote:
> There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> andreas kainz wrote:
> ok. that would fit for me. since now we have not that much look and feel 
> packages most distros use it for there look and feel stuff and than breeze 
> and breeze-dark for people how don't like monochrome (there are a lot) is 
> oxygen. it would be nice to have more packages there available so move the 
> oxygen stuff in an spacific area is fine for me but don't move them to 
> kde-look cause than oxygen is more broken than now and no one can fix it any 
> more.
> 
> thanks Kai
> 
> Martin Klapetek wrote:
> > in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Really? Got any examples?
> 
> > There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> 
> Ok, I'll put it there then.
> 
> David Edmundson wrote:
> Andreas, note the oxygen widget style and plasma theme are different 
> things. 
> The Oxygen plasma style is this theme: 
> https://www.kde.org/announcements/4.0/screenshots/desktop.jpg
> 
> the widget style isn't being touched.
> 
> andreas kainz wrote:
> can we add ALL oxygen stuff in one "unmaintained" area?
> 
> Hugo Pereira Da Costa wrote:
> Wait wait, neither oxygen widget style nor window decoration are 
> unmaintained. (nor broken as far as I know)
> They are in "maintenance" mode on the contrary. Meaning: they are "done", 
> there won't be any new feature, but bugs get fixed when reported. 
> Please 
> - dont move them anywhere else,
> - dont move broken, nor truely unmaintained things in there.
> This is not a trash can :)
> 
> Thx,
> 
> Hugo
> 
> Kai Uwe Broulik wrote:
> Yes, Hugo is doing a fine job of maintaining Oxygen stuff and 
> cherry-picking fixes from Breeze. :) It's really just the Plasma theme that 
> is utterly broken and unmaintained.
> 
> andreas kainz wrote:
> I'v never done a plasma theme but I saw how the breeze theme get broken 
> and how it was fixed again. As Hugo maintaine oxygen stuff and I maintain 
> oxygen icon stuff, it would be good to have the plasma theme also available. 
> I can offer to maintain the oxygen plasma theme (one of them).
> 
> Marco Martin wrote:
> oxygen icon or oxygen style repository? for me both would be good.
> 
> note that if you chose the oxygen look and feel it sets the oxygen widget 
> style and the Air plasma theme, that should be still the case.

I'd say we need one theme to go with the Oxygen Look & Feel package. If Air is 
still maintainted and used in the L&F, then killing Oxygen from our repos 
should be fine.
I'm against putting it on kde-look, however, because we don't want unmaintained 
and broken stuff on there, either. kde-look currently is used kind of as a 
junkyard by some, but this has to change if we want to showcase it more.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883
---


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   

Re: Review Request 126969: KRecursiveFilterProxyModel::match: Fix crash

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126969/#review91959
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Feb. 2, 2016, 3:42 p.m., Kevin Funk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126969/
> ---
> 
> (Updated Feb. 2, 2016, 3:42 p.m.)
> 
> 
> Review request for KDE Frameworks and Volker Krause.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> ---
> 
> As seen in GammaRay
> 
> 
> Diffs
> -
> 
>   src/krecursivefilterproxymodel.cpp dbb6eba421c0e680fffe43582f210ea3e42e6e7f 
> 
> Diff: https://git.reviewboard.kde.org/r/126969/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126969: KRecursiveFilterProxyModel::match: Fix crash

[Milian Wolff]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126969/#review91958
---


Ship it!




Ship It!

- Milian Wolff


On Feb. 2, 2016, 2:42 p.m., Kevin Funk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126969/
> ---
> 
> (Updated Feb. 2, 2016, 2:42 p.m.)
> 
> 
> Review request for KDE Frameworks and Volker Krause.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> ---
> 
> As seen in GammaRay
> 
> 
> Diffs
> -
> 
>   src/krecursivefilterproxymodel.cpp dbb6eba421c0e680fffe43582f210ea3e42e6e7f 
> 
> Diff: https://git.reviewboard.kde.org/r/126969/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126949: Remove Air and Oxygen themes

[Martin Klapetek]

> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote:
> > maybe not oxygen, but i want to point out that i *do* maintain the Air theme

Then we got some fixing to do as this is how Air looks like here: 
http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of 
the controls)

I can file all these as bugs if you want.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91924
---


On Feb. 1, 2016, 8:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 8:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
>   src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
>   src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
>   src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
>   src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
>   src/desktoptheme/air/widgets/actionbutton.svgz e1713ea 
>   src/desktoptheme/air/widgets/analog_meter.svgz f0d2163 
>   src/desktoptheme/air/widgets/arrows.svgz b987b32 
>   src/desktoptheme/air/widgets/background.svgz 174a8fc 
>   src/desktoptheme/air/widgets/bar_meter_horizontal.svgz 8031b77 
>   src/desktoptheme/air/widgets/bar_meter_vertical.svgz 1b0660d 
>   src/desktoptheme/air/widgets/branding.svgz c6316fb 
>   src/desktoptheme/air/widgets/busywidget.svgz f638cfb 
>   src/desktoptheme/air/widgets/button.svgz 2c529bf 
>   src/desktoptheme/air/widgets/calendar.svgz 2d80a49 
>   src/desktoptheme/air/widgets/checkmarks.svgz dcf2924 
>   src/desktoptheme/air/widgets/clock.svgz 3839dac 
>   src/desktoptheme/air/widgets/configuration-icons.svgz 9b212d3 
>   src/desktoptheme/air/widgets/containment-controls.svgz a3166ce 
>   src/desktoptheme/air/widgets/dragger.svgz 3629591 
>   src/desktoptheme/air/widgets/extender-background.svgz 4003079 
>   src/desktoptheme/air/widgets/extender-dragger.svgz 5bf3e0f 
>   src/desktoptheme/air/widgets/frame.svgz 327c284 
>   src/desktoptheme/air/widgets/glowbar.svgz 4a8a464 
>   src/desktoptheme/air/widgets/identiconshapes.s

Review Request 126969: KRecursiveFilterProxyModel::match: Fix crash

[Kevin Funk]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126969/
---

Review request for KDE Frameworks.


Repository: kitemmodels


Description
---

As seen in GammaRay


Diffs
-

  src/krecursivefilterproxymodel.cpp dbb6eba421c0e680fffe43582f210ea3e42e6e7f 

Diff: https://git.reviewboard.kde.org/r/126969/diff/


Testing
---


Thanks,

Kevin Funk

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126955: Fix crash in activities context menu

[David Faure]

> On Feb. 2, 2016, 7:49 a.m., David Faure wrote:
> > Looks correct, although IMHO it's the code that creates a class, that 
> > should decide how it should get deleted, rather than the class itself 
> > deciding that (same reason why for widgets, WA_DeleteOnClose should be set 
> > after new, not in the ctor).
> 
> David Edmundson wrote:
> In this case it looks like it's meant to be a KJob style pattern. It does 
> an emit(result) just before the original deleteLater()
> 
> I didn't really want to change the behaviour, but I'm happy to if that's 
> something wanted.
> 
> Ivan Čukić wrote:
> You can create a static method that creates it so that we do not have a 
> new-without-delete. I guess it is the easiest way to keep the logic and not 
> have the isssue David mentioned.

Ah, that's why KIO has KIO::get() I never really realized. But yeah, since 
then we have "new Job" for many things in many places indeed (akonadi, etc.). 
Jobs have a setAutoDelete(false) though, in case someone wants to get control 
over the lifetime again. Anyhow, I withdraw my objection, no big deal.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126955/#review91918
---


On Feb. 1, 2016, 9:16 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126955/
> ---
> 
> (Updated Feb. 1, 2016, 9:16 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 351485
> http://bugs.kde.org/show_bug.cgi?id=351485
> 
> 
> Repository: kactivities
> 
> 
> Description
> ---
> 
> Currently we call deleteLater() from inside ::run which is running in a
> different thread than the receiving object.
> (QThread objects live in the thread that created them, not in the thread they 
> create) 
> 
> This patch causes deleteLater to be run in the right thread.
> 
> QCoreApplication::postEvent is thread safe but it needs to be in the right 
> thread to work out the correct event loop level for deferred delete events.
> 
> BUG: 351485
> 
> 
> Diffs
> -
> 
>   src/workspace/fileitemplugin/FileItemLinkingPluginActionLoader.cpp 
> 3343eb4c5cfe209e20b0210a2b7fdf980a1e8b4a 
> 
> Diff: https://git.reviewboard.kde.org/r/126955/diff/
> 
> 
> Testing
> ---
> 
> Right click in dolpin. Still works.
> 
> Couldn't reproduce the original crash, so I don't know for sure it fixes it. 
> Debug in qcoreapplication showed we got a different eventLoopLevel on the 
> QDeferredDeleteEvent
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126945: Don't call exec() from QML

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126945/
---

(Updated Feb. 2, 2016, 5:23 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 6b83071705add65a5c0b4cf1b808c8ae8137967b by David 
Edmundson to branch master.


Bugs: 357435
http://bugs.kde.org/show_bug.cgi?id=357435


Repository: kactivities


Description
---

This is dangerous and leads to crashes as the QML processing still
continues in the new event loop.

Besides, one should never block the plasmashell UI anyway.

Also as far as I can see, no-one deleted the exec'd dialog and so it was 
leaking memory too.

BUG: 357435


Diffs
-

  src/workspace/settings/imports/activitysettings.cpp 
e673ec4950f34eaca91e06f410a69e125ef4faee 

Diff: https://git.reviewboard.kde.org/r/126945/diff/


Testing
---


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126955: Fix crash in activities context menu

[Ivan Čukić]

> On Feb. 2, 2016, 7:49 a.m., David Faure wrote:
> > Looks correct, although IMHO it's the code that creates a class, that 
> > should decide how it should get deleted, rather than the class itself 
> > deciding that (same reason why for widgets, WA_DeleteOnClose should be set 
> > after new, not in the ctor).
> 
> David Edmundson wrote:
> In this case it looks like it's meant to be a KJob style pattern. It does 
> an emit(result) just before the original deleteLater()
> 
> I didn't really want to change the behaviour, but I'm happy to if that's 
> something wanted.

You can create a static method that creates it so that we do not have a 
new-without-delete. I guess it is the easiest way to keep the logic and not 
have the isssue David mentioned.


- Ivan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126955/#review91918
---


On Feb. 1, 2016, 9:16 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126955/
> ---
> 
> (Updated Feb. 1, 2016, 9:16 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 351485
> http://bugs.kde.org/show_bug.cgi?id=351485
> 
> 
> Repository: kactivities
> 
> 
> Description
> ---
> 
> Currently we call deleteLater() from inside ::run which is running in a
> different thread than the receiving object.
> (QThread objects live in the thread that created them, not in the thread they 
> create) 
> 
> This patch causes deleteLater to be run in the right thread.
> 
> QCoreApplication::postEvent is thread safe but it needs to be in the right 
> thread to work out the correct event loop level for deferred delete events.
> 
> BUG: 351485
> 
> 
> Diffs
> -
> 
>   src/workspace/fileitemplugin/FileItemLinkingPluginActionLoader.cpp 
> 3343eb4c5cfe209e20b0210a2b7fdf980a1e8b4a 
> 
> Diff: https://git.reviewboard.kde.org/r/126955/diff/
> 
> 
> Testing
> ---
> 
> Right click in dolpin. Still works.
> 
> Couldn't reproduce the original crash, so I don't know for sure it fixes it. 
> Debug in qcoreapplication showed we got a different eventLoopLevel on the 
> QDeferredDeleteEvent
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126955: Fix crash in activities context menu

[David Edmundson]

> On Feb. 2, 2016, 7:49 a.m., David Faure wrote:
> > Looks correct, although IMHO it's the code that creates a class, that 
> > should decide how it should get deleted, rather than the class itself 
> > deciding that (same reason why for widgets, WA_DeleteOnClose should be set 
> > after new, not in the ctor).

In this case it looks like it's meant to be a KJob style pattern. It does an 
emit(result) just before the original deleteLater()

I didn't really want to change the behaviour, but I'm happy to if that's 
something wanted.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126955/#review91918
---


On Feb. 1, 2016, 9:16 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126955/
> ---
> 
> (Updated Feb. 1, 2016, 9:16 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 351485
> http://bugs.kde.org/show_bug.cgi?id=351485
> 
> 
> Repository: kactivities
> 
> 
> Description
> ---
> 
> Currently we call deleteLater() from inside ::run which is running in a
> different thread than the receiving object.
> (QThread objects live in the thread that created them, not in the thread they 
> create) 
> 
> This patch causes deleteLater to be run in the right thread.
> 
> QCoreApplication::postEvent is thread safe but it needs to be in the right 
> thread to work out the correct event loop level for deferred delete events.
> 
> BUG: 351485
> 
> 
> Diffs
> -
> 
>   src/workspace/fileitemplugin/FileItemLinkingPluginActionLoader.cpp 
> 3343eb4c5cfe209e20b0210a2b7fdf980a1e8b4a 
> 
> Diff: https://git.reviewboard.kde.org/r/126955/diff/
> 
> 
> Testing
> ---
> 
> Right click in dolpin. Still works.
> 
> Couldn't reproduce the original crash, so I don't know for sure it fixes it. 
> Debug in qcoreapplication showed we got a different eventLoopLevel on the 
> QDeferredDeleteEvent
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126945: Don't call exec() from QML

[Ivan Čukić]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126945/#review91941
---


Ship it!




A couple of nit-picks:

 - kactivities reviews should go via phabricator in the future
 - kactivities are in the process of repository splitting, the repository for 
this patch will be kde:kactivitymanagerd (I'll apply it to the repository when 
you push this)

- Ivan Čukić


On Feb. 2, 2016, 12:11 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126945/
> ---
> 
> (Updated Feb. 2, 2016, 12:11 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 357435
> http://bugs.kde.org/show_bug.cgi?id=357435
> 
> 
> Repository: kactivities
> 
> 
> Description
> ---
> 
> This is dangerous and leads to crashes as the QML processing still
> continues in the new event loop.
> 
> Besides, one should never block the plasmashell UI anyway.
> 
> Also as far as I can see, no-one deleted the exec'd dialog and so it was 
> leaking memory too.
> 
> BUG: 357435
> 
> 
> Diffs
> -
> 
>   src/workspace/settings/imports/activitysettings.cpp 
> e673ec4950f34eaca91e06f410a69e125ef4faee 
> 
> Diff: https://git.reviewboard.kde.org/r/126945/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126945: Don't call exec() from QML

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126945/
---

(Updated Feb. 2, 2016, 12:11 p.m.)


Review request for KDE Frameworks.


Bugs: 357435
http://bugs.kde.org/show_bug.cgi?id=357435


Repository: kactivities


Description
---

This is dangerous and leads to crashes as the QML processing still
continues in the new event loop.

Besides, one should never block the plasmashell UI anyway.

Also as far as I can see, no-one deleted the exec'd dialog and so it was 
leaking memory too.

BUG: 357435


Diffs (updated)
-

  src/workspace/settings/imports/activitysettings.cpp 
e673ec4950f34eaca91e06f410a69e125ef4faee 

Diff: https://git.reviewboard.kde.org/r/126945/diff/


Testing
---


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 178 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/178/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 02 Feb 2016 10:51:41 +
Build duration: 15 min

CHANGE SET
Revision 3347ceeb1caa3b7bf3182fd404be860147dfa8cd by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit src/part/katepart.desktop
  change: edit src/data/ktexteditor.desktop


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 
53 test(s)Failed: TestSuite.commands_testFailed: TestSuite.indenttest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 23/27 (85%)FILES 278/314 (89%)CLASSES 278/314 (89%)LINE 29936/46651 
(64%)CONDITIONAL 15514/21297 (73%)

By packages
  
autotests.src
FILES 48/48 (100%)CLASSES 48/48 (100%)LINE 3927/4236 
(93%)CONDITIONAL 1879/3540 (53%)
autotests.src.vimode
FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 3152/3167 
(100%)CONDITIONAL 374/632 (59%)
src.buffer
FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1666/1803 
(92%)CONDITIONAL 1255/1560 (80%)
src.completion
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 1794/3179 
(56%)CONDITIONAL 1204/1614 (75%)
src.completion.expandingtree
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 190/474 (40%)CONDITIONAL 
77/132 (58%)
src.dialogs
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/925 (0%)CONDITIONAL 0/0 
(100%)
src.document
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1851/3264 
(57%)CONDITIONAL 1433/1972 (73%)
src.export
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 109/126 (87%)CONDITIONAL 
106/152 (70%)
src.include.ktexteditor
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 190/229 
(83%)CONDITIONAL 144/178 (81%)
src.inputmode
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 186/331 (56%)CONDITIONAL 
64/83 (77%)
src.mode
FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 165/440 (38%)CONDITIONAL 
97/115 (84%)
src.printing
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/882 (0%)CONDITIONAL 0/0 
(100%)
src.render
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 934/1247 
(75%)CONDITIONAL 604/766 (79%)
src.schema
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1538 (1%)CONDITIONAL 
7/8 (88%)
src.script
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 707/1067 
(66%)CONDITIONAL 297/414 (72%)
src.search
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 900/1389 
(65%)CONDITIONAL 519/675 (77%)
src.spellcheck
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 387/1332 (29%)CONDITIONAL 
205/328 (63%)
src.swapfile
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 120/361 (33%)CONDITIONAL 
57/74 (77%)
src.syntax
FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1672/2165 
(77%)CONDITIONAL 1034/1238 (84%)
src.syntax.data
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 54/72 (75%)CONDITIONAL 
73/92 (79%)
src.undo
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 684/783 (87%)CONDITIONAL 
321/400 (80%)
src.utils
FILES 33/36 (92%)CLASSES 33/36 (92%)LINE 2542/3841 
(66%)CONDITIONAL 1244/1685 (74%)
src.variableeditor
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/664 (0%)CONDITIONAL 0/0 
(100%)
src.view
FILES 15/18 (83%)CLASSES 15/18 (83%)LINE 3106/6115 
(51%)CONDITIONAL 1383/1855 (75%)
src.vimode
FILES 34/35 (97%)CLASSES 34/35 (97%)LINE 2326/3134 
(74%)CONDITIONAL 1296/1649 (79%)
src.vimode.config
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/138 (0%)CONDITIONAL 0/0 
(100%)
src.vimode.modes
FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 3253/3749 
(87%)CONDITIONAL 1841/2135 (86%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126963: New class FavIconRequestJob in new lib KIOGui, for favicons retrieval.

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126963/
---

(Updated Feb. 2, 2016, 11:46 a.m.)


Review request for KDE Frameworks, Kevin Ottens, Laurent Montel, and Sune 
Vuorela.


Changes
---

address laurent's comments (using QLatin1String for endsWith, since there's an 
overload for it)


Repository: kio


Description (updated)
---

Replaces the favicons kded module from libkonq.

Looking up favicons from the cache no longer needs DBus, which makes
things considerably faster.

REVIEW: 126963

Change-Id: I9527b3d312117cbc3b3f854ffbdda07bafd782d7


Diffs (updated)
-

  autotests/CMakeLists.txt 376b1ed48cbd4a285d096866a73c1928ce6c7766 
  autotests/favicontest.cpp PRE-CREATION 
  src/CMakeLists.txt 62e04a68648f0db738d38ebddf2578a65ff10c07 
  src/core/CMakeLists.txt 3343a6960cdce422a2cc1ca5253f7825bb0e0ada 
  src/core/faviconscache.cpp PRE-CREATION 
  src/core/faviconscache_p.h PRE-CREATION 
  src/core/global.h 5e8e8a086d406402a23b37d2d4835f970ad92753 
  src/core/global.cpp f5c20ec6f169e413836172616cd3d42ccc2d19eb 
  src/gui/CMakeLists.txt PRE-CREATION 
  src/gui/faviconrequestjob.h PRE-CREATION 
  src/gui/faviconrequestjob.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126963/diff/


Testing
---

Wrote a unittest, as complete as possible.

Didn't port any apps yet.


Thanks,

David Faure

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 173 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/173/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 02 Feb 2016 10:51:41 +
Build duration: 7 min 0 sec

CHANGE SET
Revision 3347ceeb1caa3b7bf3182fd404be860147dfa8cd by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit src/part/katepart.desktop
  change: edit src/data/ktexteditor.desktop


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 
53 test(s)Failed: TestSuite.commands_testFailed: TestSuite.indenttest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 23/27 (85%)FILES 278/314 (89%)CLASSES 278/314 (89%)LINE 29911/46651 
(64%)CONDITIONAL 15485/21267 (73%)

By packages
  
autotests.src
FILES 48/48 (100%)CLASSES 48/48 (100%)LINE 3927/4236 
(93%)CONDITIONAL 1879/3540 (53%)
autotests.src.vimode
FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 3152/3167 
(100%)CONDITIONAL 374/632 (59%)
src.buffer
FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1666/1803 
(92%)CONDITIONAL 1255/1560 (80%)
src.completion
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 1794/3179 
(56%)CONDITIONAL 1204/1614 (75%)
src.completion.expandingtree
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 190/474 (40%)CONDITIONAL 
77/132 (58%)
src.dialogs
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/925 (0%)CONDITIONAL 0/0 
(100%)
src.document
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1851/3264 
(57%)CONDITIONAL 1433/1972 (73%)
src.export
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 109/126 (87%)CONDITIONAL 
106/152 (70%)
src.include.ktexteditor
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 190/229 
(83%)CONDITIONAL 144/178 (81%)
src.inputmode
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 180/331 (54%)CONDITIONAL 
55/73 (75%)
src.mode
FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 165/440 (38%)CONDITIONAL 
97/115 (84%)
src.printing
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/882 (0%)CONDITIONAL 0/0 
(100%)
src.render
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 934/1247 
(75%)CONDITIONAL 604/766 (79%)
src.schema
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1538 (1%)CONDITIONAL 
7/8 (88%)
src.script
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 707/1067 
(66%)CONDITIONAL 297/414 (72%)
src.search
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 900/1389 
(65%)CONDITIONAL 519/675 (77%)
src.spellcheck
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 387/1332 (29%)CONDITIONAL 
205/328 (63%)
src.swapfile
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 120/361 (33%)CONDITIONAL 
57/74 (77%)
src.syntax
FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1672/2165 
(77%)CONDITIONAL 1034/1238 (84%)
src.syntax.data
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 54/72 (75%)CONDITIONAL 
73/92 (79%)
src.undo
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 684/783 (87%)CONDITIONAL 
321/400 (80%)
src.utils
FILES 33/36 (92%)CLASSES 33/36 (92%)LINE 2542/3841 
(66%)CONDITIONAL 1244/1685 (74%)
src.variableeditor
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/664 (0%)CONDITIONAL 0/0 
(100%)
src.view
FILES 15/18 (83%)CLASSES 15/18 (83%)LINE 3087/6115 
(50%)CONDITIONAL 1363/1835 (74%)
src.vimode
FILES 34/35 (97%)CLASSES 34/35 (97%)LINE 2326/3134 
(74%)CONDITIONAL 1296/1649 (79%)
src.vimode.config
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/138 (0%)CONDITIONAL 0/0 
(100%)
src.vimode.modes
FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 3253/3749 
(87%)CONDITIONAL 1841/2135 (86%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126945: Don't call exec() from QML

[Milian Wolff]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126945/#review91935
---




src/workspace/settings/imports/dialog.cpp (line 142)


this is a very bad idea. Setting this attribute in a ctor prevents you from 
ever creating the dialog on the stack. Or well - it doesn't prevent you from 
doing so, but it will crash on exit - always. I suggest you set that from the 
outside whereever you are initializing the dialog. Alternatively, create a 
static function to create, initialize and show the dialog in a non-blocking 
manner.


- Milian Wolff


On Feb. 1, 2016, 6:03 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126945/
> ---
> 
> (Updated Feb. 1, 2016, 6:03 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 357435
> http://bugs.kde.org/show_bug.cgi?id=357435
> 
> 
> Repository: kactivities
> 
> 
> Description
> ---
> 
> This is dangerous and leads to crashes as the QML processing still
> continues in the new event loop.
> 
> Besides, one should never block the plasmashell UI anyway.
> 
> Also as far as I can see, no-one deleted the exec'd dialog and so it was 
> leaking memory too.
> 
> BUG: 357435
> 
> 
> Diffs
> -
> 
>   src/workspace/settings/imports/activitysettings.cpp 
> e673ec4950f34eaca91e06f410a69e125ef4faee 
>   src/workspace/settings/imports/dialog.cpp 
> ec496fda6150d59f285eba6f1a5447e672aa0214 
> 
> Diff: https://git.reviewboard.kde.org/r/126945/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126963: New class FavIconRequestJob in new lib KIOGui, for favicons retrieval.

[Laurent Montel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126963/#review91922
---




autotests/CMakeLists.txt (line 50)


indent here



autotests/favicontest.cpp (line 154)


QStringLiteral()



autotests/favicontest.cpp (line 173)


QStringLiteral(...)



src/core/faviconscache.cpp (line 66)


QLatin1Char('/') etc.



src/gui/faviconrequestjob.h (line 78)


Q_NULLPTR


- Laurent Montel


On fév. 2, 2016, 8:35 matin, David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126963/
> ---
> 
> (Updated fév. 2, 2016, 8:35 matin)
> 
> 
> Review request for KDE Frameworks, Kevin Ottens, Laurent Montel, and Sune 
> Vuorela.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Replaces the favicons kded module from libkonq.
> 
> Looking up favicons from the cache no longer needs DBus, which makes
> things considerably faster.
> 
> Change-Id: I9527b3d312117cbc3b3f854ffbdda07bafd782d7
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 376b1ed48cbd4a285d096866a73c1928ce6c7766 
>   autotests/favicontest.cpp PRE-CREATION 
>   src/CMakeLists.txt 62e04a68648f0db738d38ebddf2578a65ff10c07 
>   src/core/CMakeLists.txt 3343a6960cdce422a2cc1ca5253f7825bb0e0ada 
>   src/core/faviconscache.cpp PRE-CREATION 
>   src/core/faviconscache_p.h PRE-CREATION 
>   src/core/global.h 5e8e8a086d406402a23b37d2d4835f970ad92753 
>   src/core/global.cpp f5c20ec6f169e413836172616cd3d42ccc2d19eb 
>   src/gui/CMakeLists.txt PRE-CREATION 
>   src/gui/faviconrequestjob.h PRE-CREATION 
>   src/gui/faviconrequestjob.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126963/diff/
> 
> 
> Testing
> ---
> 
> Wrote a unittest, as complete as possible.
> 
> Didn't port any apps yet.
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126949: Remove Air and Oxygen themes

[Marco Martin]

> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote:
> > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the 
> > time I need the plasma oxygen theme too to give the user the one single 
> > click feature (look & feel package). Is there an space where you can move 
> > "unmaintained" stuff and the distros can choose what they want to ship. now 
> > all distros ship oxygen.
> > 
> > I love breeze but oxygen is also really sexy in addition a lot of uers work 
> > with kde4 (which is unmainted too) and update to kf5 with Kubuntu 16.04 
> > LTS. It would be bad to support oxygen for an additional LTS cycle, but for 
> > the switch it would be nice to give the user the posibility for an soft 
> > switch.
> 
> andreas kainz wrote:
> in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Kai Uwe Broulik wrote:
> There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> andreas kainz wrote:
> ok. that would fit for me. since now we have not that much look and feel 
> packages most distros use it for there look and feel stuff and than breeze 
> and breeze-dark for people how don't like monochrome (there are a lot) is 
> oxygen. it would be nice to have more packages there available so move the 
> oxygen stuff in an spacific area is fine for me but don't move them to 
> kde-look cause than oxygen is more broken than now and no one can fix it any 
> more.
> 
> thanks Kai
> 
> Martin Klapetek wrote:
> > in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Really? Got any examples?
> 
> > There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> 
> Ok, I'll put it there then.
> 
> David Edmundson wrote:
> Andreas, note the oxygen widget style and plasma theme are different 
> things. 
> The Oxygen plasma style is this theme: 
> https://www.kde.org/announcements/4.0/screenshots/desktop.jpg
> 
> the widget style isn't being touched.
> 
> andreas kainz wrote:
> can we add ALL oxygen stuff in one "unmaintained" area?
> 
> Hugo Pereira Da Costa wrote:
> Wait wait, neither oxygen widget style nor window decoration are 
> unmaintained. (nor broken as far as I know)
> They are in "maintenance" mode on the contrary. Meaning: they are "done", 
> there won't be any new feature, but bugs get fixed when reported. 
> Please 
> - dont move them anywhere else,
> - dont move broken, nor truely unmaintained things in there.
> This is not a trash can :)
> 
> Thx,
> 
> Hugo
> 
> Kai Uwe Broulik wrote:
> Yes, Hugo is doing a fine job of maintaining Oxygen stuff and 
> cherry-picking fixes from Breeze. :) It's really just the Plasma theme that 
> is utterly broken and unmaintained.
> 
> andreas kainz wrote:
> I'v never done a plasma theme but I saw how the breeze theme get broken 
> and how it was fixed again. As Hugo maintaine oxygen stuff and I maintain 
> oxygen icon stuff, it would be good to have the plasma theme also available. 
> I can offer to maintain the oxygen plasma theme (one of them).

oxygen icon or oxygen style repository? for me both would be good.

note that if you chose the oxygen look and feel it sets the oxygen widget style 
and the Air plasma theme, that should be still the case.


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883
---


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme

Re: Review Request 126949: Remove Air and Oxygen themes

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91924
---



maybe not oxygen, but i want to point out that i *do* maintain the Air theme

- Marco Martin


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
>   src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
>   src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
>   src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
>   src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
>   src/desktoptheme/air/widgets/actionbutton.svgz e1713ea 
>   src/desktoptheme/air/widgets/analog_meter.svgz f0d2163 
>   src/desktoptheme/air/widgets/arrows.svgz b987b32 
>   src/desktoptheme/air/widgets/background.svgz 174a8fc 
>   src/desktoptheme/air/widgets/bar_meter_horizontal.svgz 8031b77 
>   src/desktoptheme/air/widgets/bar_meter_vertical.svgz 1b0660d 
>   src/desktoptheme/air/widgets/branding.svgz c6316fb 
>   src/desktoptheme/air/widgets/busywidget.svgz f638cfb 
>   src/desktoptheme/air/widgets/button.svgz 2c529bf 
>   src/desktoptheme/air/widgets/calendar.svgz 2d80a49 
>   src/desktoptheme/air/widgets/checkmarks.svgz dcf2924 
>   src/desktoptheme/air/widgets/clock.svgz 3839dac 
>   src/desktoptheme/air/widgets/configuration-icons.svgz 9b212d3 
>   src/desktoptheme/air/widgets/containment-controls.svgz a3166ce 
>   src/desktoptheme/air/widgets/dragger.svgz 3629591 
>   src/desktoptheme/air/widgets/extender-background.svgz 4003079 
>   src/desktoptheme/air/widgets/extender-dragger.svgz 5bf3e0f 
>   src/desktoptheme/air/widgets/frame.svgz 327c284 
>   src/desktoptheme/air/widgets/glowbar.svgz 4a8a464 
>   src/desktoptheme/air/widgets/identiconshapes.svgz 67fe725 
>   src/desktoptheme/air/widgets/identicontheme.svgz ad881cd 
>   src/desktoptheme/air/widgets/labeltexture.svgz f52a78d 
>   src/desktoptheme/air/widgets/line.svgz 70efca4 
>   src/desktoptheme/air/widgets/lineedit.svgz 22347db 
>   src/de

Re: Review Request 126949: Remove Air and Oxygen themes

[andreas kainz]

> On Feb. 1, 2016, 8:12 nachm., andreas kainz wrote:
> > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the 
> > time I need the plasma oxygen theme too to give the user the one single 
> > click feature (look & feel package). Is there an space where you can move 
> > "unmaintained" stuff and the distros can choose what they want to ship. now 
> > all distros ship oxygen.
> > 
> > I love breeze but oxygen is also really sexy in addition a lot of uers work 
> > with kde4 (which is unmainted too) and update to kf5 with Kubuntu 16.04 
> > LTS. It would be bad to support oxygen for an additional LTS cycle, but for 
> > the switch it would be nice to give the user the posibility for an soft 
> > switch.
> 
> andreas kainz wrote:
> in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Kai Uwe Broulik wrote:
> There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> andreas kainz wrote:
> ok. that would fit for me. since now we have not that much look and feel 
> packages most distros use it for there look and feel stuff and than breeze 
> and breeze-dark for people how don't like monochrome (there are a lot) is 
> oxygen. it would be nice to have more packages there available so move the 
> oxygen stuff in an spacific area is fine for me but don't move them to 
> kde-look cause than oxygen is more broken than now and no one can fix it any 
> more.
> 
> thanks Kai
> 
> Martin Klapetek wrote:
> > in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Really? Got any examples?
> 
> > There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> 
> Ok, I'll put it there then.
> 
> David Edmundson wrote:
> Andreas, note the oxygen widget style and plasma theme are different 
> things. 
> The Oxygen plasma style is this theme: 
> https://www.kde.org/announcements/4.0/screenshots/desktop.jpg
> 
> the widget style isn't being touched.
> 
> andreas kainz wrote:
> can we add ALL oxygen stuff in one "unmaintained" area?
> 
> Hugo Pereira Da Costa wrote:
> Wait wait, neither oxygen widget style nor window decoration are 
> unmaintained. (nor broken as far as I know)
> They are in "maintenance" mode on the contrary. Meaning: they are "done", 
> there won't be any new feature, but bugs get fixed when reported. 
> Please 
> - dont move them anywhere else,
> - dont move broken, nor truely unmaintained things in there.
> This is not a trash can :)
> 
> Thx,
> 
> Hugo
> 
> Kai Uwe Broulik wrote:
> Yes, Hugo is doing a fine job of maintaining Oxygen stuff and 
> cherry-picking fixes from Breeze. :) It's really just the Plasma theme that 
> is utterly broken and unmaintained.

I'v never done a plasma theme but I saw how the breeze theme get broken and how 
it was fixed again. As Hugo maintaine oxygen stuff and I maintain oxygen icon 
stuff, it would be good to have the plasma theme also available. I can offer to 
maintain the oxygen plasma theme (one of them).


- andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883
---


On Feb. 1, 2016, 7:30 nachm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>

Re: Review Request 126949: Remove Air and Oxygen themes

[Kai Uwe Broulik]

> On Feb. 1, 2016, 8:12 nachm., andreas kainz wrote:
> > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the 
> > time I need the plasma oxygen theme too to give the user the one single 
> > click feature (look & feel package). Is there an space where you can move 
> > "unmaintained" stuff and the distros can choose what they want to ship. now 
> > all distros ship oxygen.
> > 
> > I love breeze but oxygen is also really sexy in addition a lot of uers work 
> > with kde4 (which is unmainted too) and update to kf5 with Kubuntu 16.04 
> > LTS. It would be bad to support oxygen for an additional LTS cycle, but for 
> > the switch it would be nice to give the user the posibility for an soft 
> > switch.
> 
> andreas kainz wrote:
> in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Kai Uwe Broulik wrote:
> There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> andreas kainz wrote:
> ok. that would fit for me. since now we have not that much look and feel 
> packages most distros use it for there look and feel stuff and than breeze 
> and breeze-dark for people how don't like monochrome (there are a lot) is 
> oxygen. it would be nice to have more packages there available so move the 
> oxygen stuff in an spacific area is fine for me but don't move them to 
> kde-look cause than oxygen is more broken than now and no one can fix it any 
> more.
> 
> thanks Kai
> 
> Martin Klapetek wrote:
> > in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Really? Got any examples?
> 
> > There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> 
> Ok, I'll put it there then.
> 
> David Edmundson wrote:
> Andreas, note the oxygen widget style and plasma theme are different 
> things. 
> The Oxygen plasma style is this theme: 
> https://www.kde.org/announcements/4.0/screenshots/desktop.jpg
> 
> the widget style isn't being touched.
> 
> andreas kainz wrote:
> can we add ALL oxygen stuff in one "unmaintained" area?
> 
> Hugo Pereira Da Costa wrote:
> Wait wait, neither oxygen widget style nor window decoration are 
> unmaintained. (nor broken as far as I know)
> They are in "maintenance" mode on the contrary. Meaning: they are "done", 
> there won't be any new feature, but bugs get fixed when reported. 
> Please 
> - dont move them anywhere else,
> - dont move broken, nor truely unmaintained things in there.
> This is not a trash can :)
> 
> Thx,
> 
> Hugo

Yes, Hugo is doing a fine job of maintaining Oxygen stuff and cherry-picking 
fixes from Breeze. :) It's really just the Plasma theme that is utterly broken 
and unmaintained.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883
---


On Feb. 1, 2016, 7:30 nachm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d

Review Request 126963: New class FavIconRequestJob in new lib KIOGui, for favicons retrieval.

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126963/
---

Review request for KDE Frameworks, Kevin Ottens, Laurent Montel, and Sune 
Vuorela.


Repository: kio


Description
---

Replaces the favicons kded module from libkonq.

Looking up favicons from the cache no longer needs DBus, which makes
things considerably faster.

Change-Id: I9527b3d312117cbc3b3f854ffbdda07bafd782d7


Diffs
-

  autotests/CMakeLists.txt 376b1ed48cbd4a285d096866a73c1928ce6c7766 
  autotests/favicontest.cpp PRE-CREATION 
  src/CMakeLists.txt 62e04a68648f0db738d38ebddf2578a65ff10c07 
  src/core/CMakeLists.txt 3343a6960cdce422a2cc1ca5253f7825bb0e0ada 
  src/core/faviconscache.cpp PRE-CREATION 
  src/core/faviconscache_p.h PRE-CREATION 
  src/core/global.h 5e8e8a086d406402a23b37d2d4835f970ad92753 
  src/core/global.cpp f5c20ec6f169e413836172616cd3d42ccc2d19eb 
  src/gui/CMakeLists.txt PRE-CREATION 
  src/gui/faviconrequestjob.h PRE-CREATION 
  src/gui/faviconrequestjob.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126963/diff/


Testing
---

Wrote a unittest, as complete as possible.

Didn't port any apps yet.


Thanks,

David Faure

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126934: Reduce use of gettext API.

[Andreas Cord-Landwehr]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126934/
---

(Updated Feb. 2, 2016, 8:03 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Aleix Pol Gonzalez and Chusslove Illich.


Changes
---

Submitted with commit c375e0d4e84837707bd9b12b5209b638dc777ca2 by Andreas 
Cord-Landwehr to branch master.


Repository: ki18n


Description
---

This change removes usage of dcnpgettext and npgettext and by this
allows building of ki18n against libintl-lite, which provides a
viable libintl alternative on e.g. Android systems (which does not
provide libintl). This change does not do any functional changes.
The changed gettext.h header is only used internally.


Diffs
-

  cmake/FindLibIntl.cmake 887dbc7 
  src/gettext.h 608f38a 

Diff: https://git.reviewboard.kde.org/r/126934/diff/


Testing
---

Unit tests still pass.


Thanks,

Andreas Cord-Landwehr

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel