Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

2016-02-11 Thread Andreas Cord-Landwehr 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127048/
---

Review request for KDE Frameworks, Aleix Pol Gonzalez and Chusslove Illich.


Repository: ki18n


Description
---

On Android, we do not have libintl but only libintl-lite, which does
not provide _nl_msg_cat_cntr. Actually, _nl_msg_cat_cntr is a GNU
gettext specific tool to prevent wrong localization after runtime language
changes. Thus, it is tied to the specific GNU gettext implementation.


Diffs
-

  src/kcatalog.cpp 095a6beec721729537a89214a1fbdb661fbfb548 

Diff: https://git.reviewboard.kde.org/r/127048/diff/


Testing
---

Tested compilation on Android and Linux.


Thanks,

Andreas Cord-Landwehr

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

2016-02-11 Thread Chusslove Illich 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127048/#review92271
---


Ship it!




Ship It!

- Chusslove Illich


On Феб. 11, 2016, 8:11 по п., Andreas Cord-Landwehr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127048/
> ---
> 
> (Updated Феб. 11, 2016, 8:11 по п.)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez and Chusslove Illich.
> 
> 
> Repository: ki18n
> 
> 
> Description
> ---
> 
> On Android, we do not have libintl but only libintl-lite, which does
> not provide _nl_msg_cat_cntr. Actually, _nl_msg_cat_cntr is a GNU
> gettext specific tool to prevent wrong localization after runtime language
> changes. Thus, it is tied to the specific GNU gettext implementation.
> 
> 
> Diffs
> -
> 
>   src/kcatalog.cpp 095a6beec721729537a89214a1fbdb661fbfb548 
> 
> Diff: https://git.reviewboard.kde.org/r/127048/diff/
> 
> 
> Testing
> ---
> 
> Tested compilation on Android and Linux.
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

2016-02-11 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127048/#review92280
---




src/kcatalog.cpp (line 179)


maybe it should be `#ifdef libintl-lite` no?


- Aleix Pol Gonzalez


On Feb. 11, 2016, 8:11 p.m., Andreas Cord-Landwehr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127048/
> ---
> 
> (Updated Feb. 11, 2016, 8:11 p.m.)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez and Chusslove Illich.
> 
> 
> Repository: ki18n
> 
> 
> Description
> ---
> 
> On Android, we do not have libintl but only libintl-lite, which does
> not provide _nl_msg_cat_cntr. Actually, _nl_msg_cat_cntr is a GNU
> gettext specific tool to prevent wrong localization after runtime language
> changes. Thus, it is tied to the specific GNU gettext implementation.
> 
> 
> Diffs
> -
> 
>   src/kcatalog.cpp 095a6beec721729537a89214a1fbdb661fbfb548 
> 
> Diff: https://git.reviewboard.kde.org/r/127048/diff/
> 
> 
> Testing
> ---
> 
> Tested compilation on Android and Linux.
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

2016-02-11 Thread Kåre Särs 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127048/#review92272
---



gettext is not so nice to compile on windows either. could we get an #ifdef 
that checks for libintl-lite?

- Kåre Särs


On Feb. 11, 2016, 7:11 p.m., Andreas Cord-Landwehr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127048/
> ---
> 
> (Updated Feb. 11, 2016, 7:11 p.m.)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez and Chusslove Illich.
> 
> 
> Repository: ki18n
> 
> 
> Description
> ---
> 
> On Android, we do not have libintl but only libintl-lite, which does
> not provide _nl_msg_cat_cntr. Actually, _nl_msg_cat_cntr is a GNU
> gettext specific tool to prevent wrong localization after runtime language
> changes. Thus, it is tied to the specific GNU gettext implementation.
> 
> 
> Diffs
> -
> 
>   src/kcatalog.cpp 095a6beec721729537a89214a1fbdb661fbfb548 
> 
> Diff: https://git.reviewboard.kde.org/r/127048/diff/
> 
> 
> Testing
> ---
> 
> Tested compilation on Android and Linux.
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127046: Move popup menu image actions into a submenu

2016-02-11 Thread Jonathan Marten 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127046/
---

Review request for KDE Frameworks and KDE Usability.


Repository: khtml


Description
---

The popup menu over an image (with actions "Save Image As..." etcetera, see 
screen shot) has in total 6 image actions which are not frequently used but 
make the menu very long.  Moving these actions onto a submenu makes the top 
level menu smaller and more logically grouped.


Diffs
-

  src/khtml_ext.cpp 0f522f4 

Diff: https://git.reviewboard.kde.org/r/127046/diff/


Testing
---

Built KHTML with these changes, tested in Konqueror.


File Attachments


Popup menu before
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/11/55c12311-73a3-472a-8a9a-6b6b9fce9de7__before.png
Popup menu after
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/11/313dbe3b-efb4-475c-bf76-8516f5bc85b4__after.png


Thanks,

Jonathan Marten

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127044: Show a warning if there's an error in the Engine

2016-02-11 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127044/
---

Review request for KDE Frameworks and Jeremy Whiting.


Repository: knewstuff


Description
---

So that we can know what's going on if things don't go smoothly.

Note the signal used to be emitted but nobody was listening to it.


Diffs
-

  src/downloadmanager.h 1990ef1 
  src/downloadmanager.cpp c99c524 

Diff: https://git.reviewboard.kde.org/r/127044/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel