Re: Review Request 127079: fix uninitialised var

2016-02-19 Thread Milian Wolff 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127079/#review92574
---


Ship it!




Ship It!

- Milian Wolff


On Feb. 19, 2016, 11:46 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127079/
> ---
> 
> (Updated Feb. 19, 2016, 11:46 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Valgrind pointed this out whilst debugging something else.
> 
> (though I'm not sure what on the desktop creates an Application object)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/platformcomponents/application.cpp 
> a3aecc4a13541d41136fd0b34e58b3107eda060f 
> 
> Diff: https://git.reviewboard.kde.org/r/127079/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: I'm missing the favicons interface

2016-02-19 Thread David Faure 
On Tuesday 16 February 2016 22:32:18 Robby Stephenson wrote:
> On Tue, Feb 16, 2016 at 5:00 PM, David Faure  wrote:
> 
> > I'm curious though, what's the use case for a large favicon? In KDE4 the
> > only
> > time I see this is when using Alt+Tab and with konqueror windows open (and
> > that
> > looks a bit weird because other apps have a much bigger icon than konq's,
> > but
> > that's an unrelated issue I guess). I guess your app has another use for
> > large
> > icons with a favicon, I'm just curious what it is, and whether the
> > text-html icon
> > as the main icon is the best icon to have. This is an opportunity to
> > rethink this
> > if we want to ;)
> >
> 
> Tellico searches a number of API end points, including some like SRU or
> z39.50 that could be any server at all. Many are also http servers and
> provide a favicon. In the configuration dialog for those sources, I chose
> to put a 64x64 icon next to all the specific data options and the favicon
> overlay fits the bill. I agree - it's an odd case, and as for whether
> text/html is the best icon, well, probably better than any other option.

OK.

I experimented a little bit, and realized that there are a few issues
even in kdelibs4 this isn't ideal, in Alt+Tab everything has much bigger
icons than konqueror's favicon... so an icon engine (and returning
a QIcon from the job) would be good, but a bit tricky for konqueror's code
(which uses QString for this in many places).

This also makes me wonder if KWindowSystem::setIcons should
still exist, it's limited to two icons sizes while QIcon can handle a lot
more --- Martin?

Coming back to favicons, I tried to at least see what happens
if kiconloader is adapted for full paths as you suggested, but
then it still didn't work, more changes where needed due to
the caching I came up with 
http://www.davidfaure.fr/2016/kiconloader.cpp.diff
how does that work for you?

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127117: Reverse the filtering logic

2016-02-19 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127117/
---

Review request for KDE Frameworks and KDEPIM.


Repository: kpeople


Description
---

For filtering multiple properties the logic needs to be OR
rather than AND.

For example in Plasma Mobile, one can start a conversation
either with a phonenumber contact or IM contact, so both
properties need to be requested. But with AND matching it
won't return anything (or only those contacts that have both
and user merged them).


Diffs
-

  src/personssortfilterproxymodel.cpp b011cbd 

Diff: https://git.reviewboard.kde.org/r/127117/diff/


Testing
---

I get both phonenumber and IM contacts in Plasma Mobile


Thanks,

Martin Klapetek

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127093: Drop KDocTools requirement

2016-02-19 Thread Alex Merry 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127093/#review92570
---




CMakeLists.txt (line 32)


You should set the package properties to say what it is needed for (and 
maybe make it RECOMMENDED?). See KF5Completion below.


- Alex Merry


On Feb. 18, 2016, 10:34 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127093/
> ---
> 
> (Updated Feb. 18, 2016, 10:34 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kdesignerplugin
> 
> 
> Description
> ---
> 
> Like in many other frameworks.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt bbec850 
> 
> Diff: https://git.reviewboard.kde.org/r/127093/diff/
> 
> 
> Testing
> ---
> 
> Builds with and without kdoctools.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127031: Add function to get runtime frameworks version information

2016-02-19 Thread Kevin Funk 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127031/#review92564
---




src/lib/kcoreaddons.h (line 38)


Maybe also add a hint / some code which shows how to use that uint? I.e. 
point to Qt's QT_VERSION_CHECK documentation or copy/paste it.


- Kevin Funk


On Feb. 19, 2016, 12:46 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127031/
> ---
> 
> (Updated Feb. 19, 2016, 12:46 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Adds a method similar to qVersion() that returns a string of the
> frameworks version being run. This differs from the header file which
> can only provide the version this app is compiled against.
> 
> The intended usage is in drkonqi system information.
> 
> 
> Diffs
> -
> 
>   src/lib/CMakeLists.txt a36eed26a281baf9ef1064dfb9aed3c394c52604 
>   src/lib/kcoreaddons.h PRE-CREATION 
>   src/lib/kcoreaddons.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127031/diff/
> 
> 
> Testing
> ---
> 
> See https://git.reviewboard.kde.org/r/127032/
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 278 - Fixed!

2016-02-19 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/278/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Fri, 19 Feb 2016 12:44:08 +
Build duration: 2 min 39 sec

CHANGE SET
Revision f4e541ad87761d6516e5fed99a1cc11aef5e5a81 by nowrep: (Fix crash from 
previous commit - nullptr check)
  change: edit src/plasma/private/theme_p.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 59/100 (59%)CLASSES 59/100 (59%)LINE 3420/9639 
(35%)CONDITIONAL 1631/2630 (62%)

By packages
  
autotests
FILES 18/18 (100%)CLASSES 18/18 (100%)LINE 503/518 
(97%)CONDITIONAL 328/586 (56%)
src.declarativeimports.core
FILES 8/20 (40%)CLASSES 8/20 (40%)LINE 274/1839 
(15%)CONDITIONAL 66/112 (59%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1588/3655 
(43%)CONDITIONAL 791/1220 (65%)
src.plasma.private
FILES 15/24 (63%)CLASSES 15/24 (63%)LINE 826/1644 
(50%)CONDITIONAL 345/523 (66%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/192 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 4/11 (36%)CLASSES 4/11 (36%)LINE 229/1678 
(14%)CONDITIONAL 101/189 (53%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 278 - Fixed!

2016-02-19 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/278/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Fri, 19 Feb 2016 12:44:08 +
Build duration: 2 min 39 sec

CHANGE SET
Revision f4e541ad87761d6516e5fed99a1cc11aef5e5a81 by nowrep: (Fix crash from 
previous commit - nullptr check)
  change: edit src/plasma/private/theme_p.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 59/100 (59%)CLASSES 59/100 (59%)LINE 3420/9639 
(35%)CONDITIONAL 1631/2630 (62%)

By packages
  
autotests
FILES 18/18 (100%)CLASSES 18/18 (100%)LINE 503/518 
(97%)CONDITIONAL 328/586 (56%)
src.declarativeimports.core
FILES 8/20 (40%)CLASSES 8/20 (40%)LINE 274/1839 
(15%)CONDITIONAL 66/112 (59%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1588/3655 
(43%)CONDITIONAL 791/1220 (65%)
src.plasma.private
FILES 15/24 (63%)CLASSES 15/24 (63%)LINE 826/1644 
(50%)CONDITIONAL 345/523 (66%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/192 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 4/11 (36%)CLASSES 4/11 (36%)LINE 229/1678 
(14%)CONDITIONAL 101/189 (53%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 278 - Fixed!

2016-02-19 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/278/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Fri, 19 Feb 2016 12:44:08 +
Build duration: 3 min 11 sec

CHANGE SET
Revision f4e541ad87761d6516e5fed99a1cc11aef5e5a81 by nowrep: (Fix crash from 
previous commit - nullptr check)
  change: edit src/plasma/private/theme_p.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
11 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 62/104 (60%)CLASSES 62/104 (60%)LINE 3856/10104 
(38%)CONDITIONAL 1919/3047 (63%)

By packages
  
autotests
FILES 20/20 (100%)CLASSES 20/20 (100%)LINE 548/565 
(97%)CONDITIONAL 344/618 (56%)
src.declarativeimports.core
FILES 8/20 (40%)CLASSES 8/20 (40%)LINE 364/2062 
(18%)CONDITIONAL 152/236 (64%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1595/3655 
(44%)CONDITIONAL 798/1226 (65%)
src.plasma.private
FILES 16/26 (62%)CLASSES 16/26 (62%)LINE 873/1715 
(51%)CONDITIONAL 365/553 (66%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/192 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 4/11 (36%)CLASSES 4/11 (36%)LINE 476/1802 
(26%)CONDITIONAL 260/414 (63%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 278 - Fixed!

2016-02-19 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/278/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Fri, 19 Feb 2016 12:44:08 +
Build duration: 3 min 11 sec

CHANGE SET
Revision f4e541ad87761d6516e5fed99a1cc11aef5e5a81 by nowrep: (Fix crash from 
previous commit - nullptr check)
  change: edit src/plasma/private/theme_p.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
11 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 62/104 (60%)CLASSES 62/104 (60%)LINE 3856/10104 
(38%)CONDITIONAL 1919/3047 (63%)

By packages
  
autotests
FILES 20/20 (100%)CLASSES 20/20 (100%)LINE 548/565 
(97%)CONDITIONAL 344/618 (56%)
src.declarativeimports.core
FILES 8/20 (40%)CLASSES 8/20 (40%)LINE 364/2062 
(18%)CONDITIONAL 152/236 (64%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1595/3655 
(44%)CONDITIONAL 798/1226 (65%)
src.plasma.private
FILES 16/26 (62%)CLASSES 16/26 (62%)LINE 873/1715 
(51%)CONDITIONAL 365/553 (66%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/192 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 4/11 (36%)CLASSES 4/11 (36%)LINE 476/1802 
(26%)CONDITIONAL 260/414 (63%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 271 - Fixed!

2016-02-19 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/271/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Fri, 19 Feb 2016 12:44:08 +
Build duration: 2 min 39 sec

CHANGE SET
Revision f4e541ad87761d6516e5fed99a1cc11aef5e5a81 by nowrep: (Fix crash from 
previous commit - nullptr check)
  change: edit src/plasma/private/theme_p.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
11 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 62/104 (60%)CLASSES 62/104 (60%)LINE 3849/10066 
(38%)CONDITIONAL 1919/3047 (63%)

By packages
  
autotests
FILES 20/20 (100%)CLASSES 20/20 (100%)LINE 547/564 
(97%)CONDITIONAL 344/618 (56%)
src.declarativeimports.core
FILES 8/20 (40%)CLASSES 8/20 (40%)LINE 363/2061 
(18%)CONDITIONAL 152/236 (64%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1592/3650 
(44%)CONDITIONAL 798/1226 (65%)
src.plasma.private
FILES 16/26 (62%)CLASSES 16/26 (62%)LINE 872/1708 
(51%)CONDITIONAL 365/553 (66%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/182 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 4/11 (36%)CLASSES 4/11 (36%)LINE 475/1788 
(27%)CONDITIONAL 260/414 (63%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 271 - Fixed!

2016-02-19 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/271/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Fri, 19 Feb 2016 12:44:08 +
Build duration: 2 min 39 sec

CHANGE SET
Revision f4e541ad87761d6516e5fed99a1cc11aef5e5a81 by nowrep: (Fix crash from 
previous commit - nullptr check)
  change: edit src/plasma/private/theme_p.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
11 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 62/104 (60%)CLASSES 62/104 (60%)LINE 3849/10066 
(38%)CONDITIONAL 1919/3047 (63%)

By packages
  
autotests
FILES 20/20 (100%)CLASSES 20/20 (100%)LINE 547/564 
(97%)CONDITIONAL 344/618 (56%)
src.declarativeimports.core
FILES 8/20 (40%)CLASSES 8/20 (40%)LINE 363/2061 
(18%)CONDITIONAL 152/236 (64%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1592/3650 
(44%)CONDITIONAL 798/1226 (65%)
src.plasma.private
FILES 16/26 (62%)CLASSES 16/26 (62%)LINE 872/1708 
(51%)CONDITIONAL 365/553 (66%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/182 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 4/11 (36%)CLASSES 4/11 (36%)LINE 475/1788 
(27%)CONDITIONAL 260/414 (63%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 271 - Fixed!

2016-02-19 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/271/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Fri, 19 Feb 2016 12:44:08 +
Build duration: 3 min 0 sec

CHANGE SET
Revision f4e541ad87761d6516e5fed99a1cc11aef5e5a81 by nowrep: (Fix crash from 
previous commit - nullptr check)
  change: edit src/plasma/private/theme_p.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 59/100 (59%)CLASSES 59/100 (59%)LINE 3413/9601 
(36%)CONDITIONAL 1631/2630 (62%)

By packages
  
autotests
FILES 18/18 (100%)CLASSES 18/18 (100%)LINE 502/517 
(97%)CONDITIONAL 328/586 (56%)
src.declarativeimports.core
FILES 8/20 (40%)CLASSES 8/20 (40%)LINE 273/1838 
(15%)CONDITIONAL 66/112 (59%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1585/3650 
(43%)CONDITIONAL 791/1220 (65%)
src.plasma.private
FILES 15/24 (63%)CLASSES 15/24 (63%)LINE 825/1637 
(50%)CONDITIONAL 345/523 (66%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/182 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 4/11 (36%)CLASSES 4/11 (36%)LINE 228/1664 
(14%)CONDITIONAL 101/189 (53%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 271 - Fixed!

2016-02-19 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/271/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Fri, 19 Feb 2016 12:44:08 +
Build duration: 3 min 0 sec

CHANGE SET
Revision f4e541ad87761d6516e5fed99a1cc11aef5e5a81 by nowrep: (Fix crash from 
previous commit - nullptr check)
  change: edit src/plasma/private/theme_p.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 59/100 (59%)CLASSES 59/100 (59%)LINE 3413/9601 
(36%)CONDITIONAL 1631/2630 (62%)

By packages
  
autotests
FILES 18/18 (100%)CLASSES 18/18 (100%)LINE 502/517 
(97%)CONDITIONAL 328/586 (56%)
src.declarativeimports.core
FILES 8/20 (40%)CLASSES 8/20 (40%)LINE 273/1838 
(15%)CONDITIONAL 66/112 (59%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1585/3650 
(43%)CONDITIONAL 791/1220 (65%)
src.plasma.private
FILES 15/24 (63%)CLASSES 15/24 (63%)LINE 825/1637 
(50%)CONDITIONAL 345/523 (66%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/182 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 4/11 (36%)CLASSES 4/11 (36%)LINE 228/1664 
(14%)CONDITIONAL 101/189 (53%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127031: Add function to get runtime frameworks version information

2016-02-19 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127031/#review92559
---



+1

- Aleix Pol Gonzalez


On Feb. 19, 2016, 1:46 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127031/
> ---
> 
> (Updated Feb. 19, 2016, 1:46 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Adds a method similar to qVersion() that returns a string of the
> frameworks version being run. This differs from the header file which
> can only provide the version this app is compiled against.
> 
> The intended usage is in drkonqi system information.
> 
> 
> Diffs
> -
> 
>   src/lib/CMakeLists.txt a36eed26a281baf9ef1064dfb9aed3c394c52604 
>   src/lib/kcoreaddons.h PRE-CREATION 
>   src/lib/kcoreaddons.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127031/diff/
> 
> 
> Testing
> ---
> 
> See https://git.reviewboard.kde.org/r/127032/
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127031: Add function to get runtime frameworks version information

2016-02-19 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127031/
---

(Updated Feb. 19, 2016, 12:46 p.m.)


Review request for KDE Frameworks.


Repository: kcoreaddons


Description
---

Adds a method similar to qVersion() that returns a string of the
frameworks version being run. This differs from the header file which
can only provide the version this app is compiled against.

The intended usage is in drkonqi system information.


Diffs (updated)
-

  src/lib/CMakeLists.txt a36eed26a281baf9ef1064dfb9aed3c394c52604 
  src/lib/kcoreaddons.h PRE-CREATION 
  src/lib/kcoreaddons.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127031/diff/


Testing
---

See https://git.reviewboard.kde.org/r/127032/


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 270 - Unstable!

2016-02-19 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/270/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Fri, 19 Feb 2016 12:28:08 +
Build duration: 2 min 32 sec

CHANGE SET
Revision 82e172cc9e96bb530a591310ba6d8c294dc9f597 by nowrep: (AppletQuickItem: 
Fix finding own attached layout)
  change: edit src/plasmaquick/appletquickitem.h
  change: edit src/plasmaquick/appletquickitem.cpp
  change: edit src/plasmaquick/private/appletquickitem_p.h
Revision a8e54e15e13653290ca4a49a38fae742e3825d04 by nowrep: (Reparse 
svgElementsCache instead of deleting it in discardCache)
  change: edit src/plasma/private/theme_p.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.plasma-dialogqmltestFailed: 
TestSuite.plasma-framesvgtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 51/85 (60%)CLASSES 51/85 (60%)LINE 3665/8792 
(42%)CONDITIONAL 1823/2935 (62%)

By packages
  
autotests
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 505/522 
(97%)CONDITIONAL 326/582 (56%)
src.declarativeimports.core
FILES 4/7 (57%)CLASSES 4/7 (57%)LINE 315/832 (38%)CONDITIONAL 
150/232 (65%)
src.plasma
FILES 12/19 (63%)CLASSES 12/19 (63%)LINE 1564/3648 
(43%)CONDITIONAL 757/1196 (63%)
src.plasma.private
FILES 15/26 (58%)CLASSES 15/26 (58%)LINE 842/1707 
(49%)CONDITIONAL 351/529 (66%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/182 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 4/11 (36%)CLASSES 4/11 (36%)LINE 439/1788 
(25%)CONDITIONAL 239/396 (60%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 270 - Unstable!

2016-02-19 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/270/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Fri, 19 Feb 2016 12:28:08 +
Build duration: 3 min 12 sec

CHANGE SET
Revision 82e172cc9e96bb530a591310ba6d8c294dc9f597 by nowrep: (AppletQuickItem: 
Fix finding own attached layout)
  change: edit src/plasmaquick/appletquickitem.cpp
  change: edit src/plasmaquick/appletquickitem.h
  change: edit src/plasmaquick/private/appletquickitem_p.h
Revision a8e54e15e13653290ca4a49a38fae742e3825d04 by nowrep: (Reparse 
svgElementsCache instead of deleting it in discardCache)
  change: edit src/plasma/private/theme_p.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.plasma-dialogqmltestFailed: 
TestSuite.plasma-framesvgtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/5 (80%)FILES 36/64 (56%)CLASSES 36/64 (56%)LINE 1854/6399 
(29%)CONDITIONAL 864/1416 (61%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 458/475 
(96%)CONDITIONAL 310/550 (56%)
src.declarativeimports.core
FILES 1/4 (25%)CLASSES 1/4 (25%)LINE 60/458 (13%)CONDITIONAL 
17/22 (77%)
src.plasma
FILES 10/19 (53%)CLASSES 10/19 (53%)LINE 852/3648 
(23%)CONDITIONAL 353/564 (63%)
src.plasma.private
FILES 11/24 (46%)CLASSES 11/24 (46%)LINE 484/1636 
(30%)CONDITIONAL 184/280 (66%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/182 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 277 - Unstable!

2016-02-19 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/277/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Fri, 19 Feb 2016 12:28:08 +
Build duration: 2 min 5 sec

CHANGE SET
Revision 82e172cc9e96bb530a591310ba6d8c294dc9f597 by nowrep: (AppletQuickItem: 
Fix finding own attached layout)
  change: edit src/plasmaquick/private/appletquickitem_p.h
  change: edit src/plasmaquick/appletquickitem.cpp
  change: edit src/plasmaquick/appletquickitem.h
Revision a8e54e15e13653290ca4a49a38fae742e3825d04 by nowrep: (Reparse 
svgElementsCache instead of deleting it in discardCache)
  change: edit src/plasma/private/theme_p.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.plasma-dialogqmltestFailed: 
TestSuite.plasma-framesvgtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/5 (80%)FILES 36/64 (56%)CLASSES 36/64 (56%)LINE 1855/6421 
(29%)CONDITIONAL 864/1416 (61%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 458/475 
(96%)CONDITIONAL 310/550 (56%)
src.declarativeimports.core
FILES 1/4 (25%)CLASSES 1/4 (25%)LINE 60/458 (13%)CONDITIONAL 
17/22 (77%)
src.plasma
FILES 10/19 (53%)CLASSES 10/19 (53%)LINE 853/3653 
(23%)CONDITIONAL 353/564 (63%)
src.plasma.private
FILES 11/24 (46%)CLASSES 11/24 (46%)LINE 484/1643 
(29%)CONDITIONAL 184/280 (66%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/192 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 277 - Unstable!

2016-02-19 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/277/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Fri, 19 Feb 2016 12:28:08 +
Build duration: 2 min 33 sec

CHANGE SET
Revision 82e172cc9e96bb530a591310ba6d8c294dc9f597 by nowrep: (AppletQuickItem: 
Fix finding own attached layout)
  change: edit src/plasmaquick/appletquickitem.h
  change: edit src/plasmaquick/private/appletquickitem_p.h
  change: edit src/plasmaquick/appletquickitem.cpp
Revision a8e54e15e13653290ca4a49a38fae742e3825d04 by nowrep: (Reparse 
svgElementsCache instead of deleting it in discardCache)
  change: edit src/plasma/private/theme_p.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.plasma-dialogqmltestFailed: 
TestSuite.plasma-framesvgtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 51/85 (60%)CLASSES 51/85 (60%)LINE 3672/8828 
(42%)CONDITIONAL 1824/2935 (62%)

By packages
  
autotests
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 507/522 
(97%)CONDITIONAL 326/582 (56%)
src.declarativeimports.core
FILES 4/7 (57%)CLASSES 4/7 (57%)LINE 315/832 (38%)CONDITIONAL 
150/232 (65%)
src.plasma
FILES 12/19 (63%)CLASSES 12/19 (63%)LINE 1567/3653 
(43%)CONDITIONAL 757/1196 (63%)
src.plasma.private
FILES 15/26 (58%)CLASSES 15/26 (58%)LINE 843/1714 
(49%)CONDITIONAL 352/529 (67%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/192 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 4/11 (36%)CLASSES 4/11 (36%)LINE 440/1802 
(24%)CONDITIONAL 239/396 (60%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127079: fix uninitialised var

2016-02-19 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127079/
---

(Updated Feb. 19, 2016, 11:46 a.m.)


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

Valgrind pointed this out whilst debugging something else.

(though I'm not sure what on the desktop creates an Application object)


Diffs (updated)
-

  src/declarativeimports/platformcomponents/application.cpp 
a3aecc4a13541d41136fd0b34e58b3107eda060f 

Diff: https://git.reviewboard.kde.org/r/127079/diff/


Testing
---


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel