date:20160506

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 49 - Still Unstable!

2016-05-06 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/49/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 07 May 2016 04:28:48 +
Build duration: 6 min 4 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: 
TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26426/50618 
(52%)CONDITIONAL 14507/37357 (39%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7275/7850 
(93%)CONDITIONAL 3842/8140 (47%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7668/14036 
(55%)CONDITIONAL 4145/8905 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE /7564 
(29%)CONDITIONAL 889/4399 (20%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3781 
(47%)CONDITIONAL 1258/3434 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 685/762 (90%)CONDITIONAL 
433/912 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 372/594 (63%)CONDITIONAL 
276/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 31/34 (91%)CONDITIONAL 
42/54 (78%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 220/249 (88%)CONDITIONAL 
298/378 (79%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2668/10599 
(25%)CONDITIONAL 1309/6780 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127837: oxygen_windeco: Fix potential use-after-free from improper use of QCache

2016-05-06 Thread Michael Pyne


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127837/
---

(Updated May 7, 2016, 4:24 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit b595f47f021cbcf1cee23cd0bee1df57a2e2f1b9 by Michael Pyne 
to branch master.


Repository: oxygen


Description
---

oxygen windeco: Fix use-after-free for pixmap in QCache.

Coverity identified (in CID 1336171) a usage of QPixmap after it's been
the parameter to QCache::insert.

This is unsafe since QCache gains ownership of whatever object is passed
in, and can even (at least in theory) delete the object you pass in.
Instead give the QCache its own copy of the pixmap.

To make this work without leaking our existing pixmap we need to work
with a QPixmap instead of QPixmap* in the non-cached case. This leads to
whitespace changes; use git diff -b to filter pure whitespace changes
out.


Diffs
-

  kdecoration/oxygendecohelper.cpp a7e9306 

Diff: https://git.reviewboard.kde.org/r/127837/diff/


Testing
---

The new code compiles but I'm currently unable to test since kcmshell5 
kwindecoration (and any other KCM viewer) is currently crashing for me in QML, 
due to what I'm sure is a local misconfiguration...


Thanks,

Michael Pyne

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kbookmarks master stable-kf5-qt5 » Linux,gcc - Build # 17 - Failure!

2016-05-06 Thread no-reply


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kbookmarks%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/17/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 07 May 2016 04:17:27 +
Build duration: 1 min 26 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: ktextwidgets master stable-kf5-qt5 » Linux,gcc - Build # 16 - Failure!

2016-05-06 Thread no-reply


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/ktextwidgets%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/16/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 07 May 2016 04:15:01 +
Build duration: 2 min 13 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127834: ki18n: Fix theoretically possible use-after-free in gettext when using strict ANSI compilers

2016-05-06 Thread Michael Pyne


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127834/
---

(Updated May 7, 2016, 7:12 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Localization and Translation (l10n) and 
Chusslove Illich.


Changes
---

Submitted with commit 639ab84221434d29a2055fa090e14a8b0822779f by Michael Pyne 
to branch master.


Repository: ki18n


Description
---

Coverity noted that some of code for message catalog lookup uses some pointer 
values after they are freed. Even though the use in question is a simple 
equality comparison against a different (valid) pointer, it is still undefined 
behavior according to the C (and C++) language specs and is therefore liable to 
cause miscompilation and who knows what other kinds of problems.

This code is not normally enabled, normally a code path that supports 
variable-length arrays is active, which is not susceptible to this bug.

Since VLAs are not supported even in current C++ versions, making VLA support 
mandatory is not feasible, so instead I opted to move the pointer comparisons 
to a point in the code where the comparison is valid, and then use the saved 
result later.

I have also reported the bug to GNU Gettext, since upstream still has the 
error. It is GNU Gettext bug 47847.


Diffs
-

  src/gettext.h b06fc90 

Diff: https://git.reviewboard.kde.org/r/127834/diff/


Testing
---

Code compiles and KDE applications still seem to work fine. I also tested with 
the changed code path forcibly enabled by disabling VLA support, and things 
still seemed to work.

There's not a lot of autotests to choose from, but the KLocalizedString test 
still passed.


Thanks,

Michael Pyne

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 25 - Still Unstable!

2016-05-06 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/25/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 06 May 2016 22:55:11 +
Build duration: 3 min 42 sec

CHANGE SET
Revision 0ff0f2a199292e6878d28a1f0c0866a99323a307 by David Faure: ([autotests] 
Adjust for Qt 5.6 QUrl behaviour change)
  change: edit autotests/kurltest.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 
39 test(s)Failed: TestSuite.globalcleanuptestFailed: TestSuite.kurltest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/7 (57%)FILES 160/268 (60%)CLASSES 160/268 (60%)LINE 21697/42801 
(51%)CONDITIONAL 14664/36475 (40%)

By packages
  
autotests
FILES 63/63 (100%)CLASSES 63/63 (100%)LINE 11522/11778 
(98%)CONDITIONAL 8480/16828 (50%)
src.kdecore
FILES 75/94 (80%)CLASSES 75/94 (80%)LINE 9221/16863 
(55%)CONDITIONAL 5721/11783 (49%)
src.kdeui
FILES 18/70 (26%)CLASSES 18/70 (26%)LINE 938/9831 
(10%)CONDITIONAL 460/5693 (8%)
src.kio
FILES 4/27 (15%)CLASSES 4/27 (15%)LINE 16/2396 (1%)CONDITIONAL 
3/1226 (0%)
src.kparts
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/26 (0%)CONDITIONAL 0/14 
(0%)
src.kssl
FILES 0/8 (0%)CLASSES 0/8 (0%)LINE 0/1708 (0%)CONDITIONAL 0/836 
(0%)
src.solid
FILES 0/5 (0%)CLASSES 0/5 (0%)LINE 0/199 (0%)CONDITIONAL 0/95 
(0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 28 - Fixed!

2016-05-06 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/28/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 06 May 2016 22:55:11 +
Build duration: 5 min 35 sec

CHANGE SET
Revision 0ff0f2a199292e6878d28a1f0c0866a99323a307 by David Faure: ([autotests] 
Adjust for Qt 5.6 QUrl behaviour change)
  change: edit autotests/kurltest.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 
39 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/7 (57%)FILES 161/269 (60%)CLASSES 161/269 (60%)LINE 21717/42814 
(51%)CONDITIONAL 14670/36475 (40%)

By packages
  
autotests
FILES 64/64 (100%)CLASSES 64/64 (100%)LINE 11541/11790 
(98%)CONDITIONAL 8486/16828 (50%)
src.kdecore
FILES 75/94 (80%)CLASSES 75/94 (80%)LINE 9221/16863 
(55%)CONDITIONAL 5721/11783 (49%)
src.kdeui
FILES 18/70 (26%)CLASSES 18/70 (26%)LINE 939/9832 
(10%)CONDITIONAL 460/5693 (8%)
src.kio
FILES 4/27 (15%)CLASSES 4/27 (15%)LINE 16/2396 (1%)CONDITIONAL 
3/1226 (0%)
src.kparts
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/26 (0%)CONDITIONAL 0/14 
(0%)
src.kssl
FILES 0/8 (0%)CLASSES 0/8 (0%)LINE 0/1708 (0%)CONDITIONAL 0/836 
(0%)
src.solid
FILES 0/5 (0%)CLASSES 0/5 (0%)LINE 0/199 (0%)CONDITIONAL 0/95 
(0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 28 - Fixed!

2016-05-06 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/28/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 06 May 2016 22:55:11 +
Build duration: 5 min 35 sec

CHANGE SET
Revision 0ff0f2a199292e6878d28a1f0c0866a99323a307 by David Faure: ([autotests] 
Adjust for Qt 5.6 QUrl behaviour change)
  change: edit autotests/kurltest.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 
39 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/7 (57%)FILES 161/269 (60%)CLASSES 161/269 (60%)LINE 21717/42814 
(51%)CONDITIONAL 14670/36475 (40%)

By packages
  
autotests
FILES 64/64 (100%)CLASSES 64/64 (100%)LINE 11541/11790 
(98%)CONDITIONAL 8486/16828 (50%)
src.kdecore
FILES 75/94 (80%)CLASSES 75/94 (80%)LINE 9221/16863 
(55%)CONDITIONAL 5721/11783 (49%)
src.kdeui
FILES 18/70 (26%)CLASSES 18/70 (26%)LINE 939/9832 
(10%)CONDITIONAL 460/5693 (8%)
src.kio
FILES 4/27 (15%)CLASSES 4/27 (15%)LINE 16/2396 (1%)CONDITIONAL 
3/1226 (0%)
src.kparts
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/26 (0%)CONDITIONAL 0/14 
(0%)
src.kssl
FILES 0/8 (0%)CLASSES 0/8 (0%)LINE 0/1708 (0%)CONDITIONAL 0/836 
(0%)
src.solid
FILES 0/5 (0%)CLASSES 0/5 (0%)LINE 0/199 (0%)CONDITIONAL 0/95 
(0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127829: use QUrl::fromUserInput to construct sound url

2016-05-06 Thread David Faure


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127829/#review95251
---


Ship it!




Yep, this kind of requirement is why I wrote the 3 args QUrl::fromUserInput :)

- David Faure


On May 4, 2016, 1:26 p.m., Harald Sitter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127829/
> ---
> 
> (Updated May 4, 2016, 1:26 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Klapetek.
> 
> 
> Bugs: 337276
> https://bugs.kde.org/show_bug.cgi?id=337276
> 
> 
> Repository: knotifyconfig
> 
> 
> Description
> ---
> 
> QUrl() would treats it as a parsable uri, but they aren't e.g. # in a uri
> separates segments in a local file path it simply is a #.
> This "accidentally" worked in Phonon < 4.9 as Phonon obtained string
> representations in a way that would bypass internal QUrl checks for
> fileyness and URI ambiguity. Since 4.9 Phonon expects scheme-less URLs to
> be local files, but QUrl() would most of the time not do that since it
> would honestly think the soundfilename is a random (i.e. not necessarily
> local) uri.
> 
> To fix this use QUrl::fromUserInput which behaves exactly like what we
> need to properly resolve relative names, urls, paths, full URIs.
> 
> This now works with input of the type:
> - Oxygen-Sys-Special.ogg
> - /usr/share/sounds/Oxygen-Sys-Special.ogg
> - file:///usr/share/sounds/Oxygen-Sys-Special.ogg
> - /usr/share/sounds/#KDE-Im-Cant-#Connect.ogg
> - file:///usr/share/sounds/#KDE-Im-Cant-#Connect.ogg
> - http://people.ubuntu.com/~apachelogger/sounds/sounds-3.5/KDE_Glass_Break.ogg
> (yes, we can have http notifications https://xkcd.com/1172/)
> 
> CCBUG: 337276
> 
> 
> Diffs
> -
> 
>   src/knotifyconfigactionswidget.cpp 98286c4d0e8a7deec5d35986a261222931afb60d 
> 
> Diff: https://git.reviewboard.kde.org/r/127829/diff/
> 
> 
> Testing
> ---
> 
> built and played all of the above
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127806: Q_BYTE_ORDER not defined in the kwallet backends

2016-05-06 Thread David Faure


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127806/#review95250
---



You say: since it looks like we want to keep sha1.cc and blowfish.cc "Qt-clean"

Clearly that is not the case, if they use Q_BYTE_ORDER. So if it's OK for them 
to use Q_BYTE_ORDER, it's ok for them to include qglobal.h.
I don't see any reason to do so in the cmake-generated header file.

- David Faure


On May 1, 2016, 7:50 p.m., Allen Winter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127806/
> ---
> 
> (Updated May 1, 2016, 7:50 p.m.)
> 
> 
> Review request for KDE Frameworks and Valentin Rusu.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> the kwalletd backends (blowfish and sha1) rely on Q_BYTE_ORDER being defined. 
>  Since it looks like we want to keep sha1.cc and blowfish.cc "Qt-clean" I put 
> the include for QtCore/qglobal.h into the config-kwalletbackend.h.
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/backend/config-kwalletbackend.h.cmake 4705cd1 
> 
> Diff: https://git.reviewboard.kde.org/r/127806/diff/
> 
> 
> Testing
> ---
> 
> compiles. now Q_BYTE_ORDER is defined by qglobal.h
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

2016-05-06 Thread David Faure



> On April 24, 2016, 1:57 p.m., David Faure wrote:
> > Better, but I'm still wary of the reentrancy due to the nested event loop 
> > usage.
> > 
> > I bet this leads to a complete deadlock:
> > 
> > QTimer::singleShot(0, this, SLOT(launchConversion()));
> > launchConversion();
> > 
> > where launchConversion() triggers the KUnitConversion code that this patch 
> > is about.
> > 
> > While waiting for the first conversion, the timer will fire (given the 
> > nested QEventLoop usage), and we'll enter this code again, and hit 
> > mutex.lock(), and then wait forever, since we'll never go back to the event 
> > loop to finish the first conversion and unlock the mutex.
> > 
> > Maybe the mutex can be removed, actually. All that needs to be done is for 
> > m_update to be turned into a local variable (there's no reason for it to be 
> > a member variable, right?). The QSaveFile usage fixes the case where two 
> > threads would write to m_cache at the same time, or the case where one 
> > writes and one reads. Or is the mutex needed for the if() at the top? In 
> > any case I recommend not holding the mutex while being in the event loop.
> > 
> > Sorry for not realizing this earlier.
> 
> Kai Uwe Broulik wrote:
> From what I can tell the m_update is so it updates it either on first run 
> or when the cache file is outdated/missing. I don't know the internals of 
> KUnitConversion, ie. if an instance of Currency is shared or not, and how to 
> ensure that for subsequent runs of convert() I don't needlessly probe the 
> cache file again.
> 
> The m_cache variable could also be made local to the convert() function.

I don't know much about kunitconversion either, so I had a look, and the reason 
that code leads to multithreading issue is indeed because all the instances of 
everything are shared between all threads (the entry point is the Converter 
class, and all Converter instances share the same global Private, which has 
maps to unit categories, which have maps to units. So yes, instances of 
CurrencyPrivate (which is the one that matters, not Currency) are shared 
(AFAICS).

The m_cache variable is a constant value set in the constructor, there's no 
problem with it being a member, and it doesn't need to be read with the mutex 
locked. The instance of CurrencyPrivate is created by the first thread which 
creates a Converter... hmm it's converter.cpp itself that is missing a mutex to 
protect m_categories, but that's another story.

I see the point about m_update, I was wrong about it not being useful as a 
member. Forgot the case where the cache already exists on disk, so we need to 
parse it on first run. That should however be done with the mutex locked, 
otherwise two threads might be loading the cache and setting the conversion 
factors into Units at the same time.

Anyway we're also back to: we need to handle the case of same-thread 
re-entrancy into this same code, due to the nested event loop. I don't see a 
way to wait for the download, from a nested event loop. So I see two solutions:
- starting another download and waiting for it (which requires that the mutex 
is not locked during the event loop; it has to be relocked before setting 
m_update though)
- or returning an error in this case (could be detected by keeping a list of 
QThread pointers, and adding currentThread to that list before starting the 
download). It's a corner case hopefully, but an error would certainly be better 
than a deadlock.

>From a correctness point of view the first solution seems better. It's also 
>simpler, it just means moving the use of the mutex around the data that is 
>written and read by multiple threads (as per definition of mutexes)... and 
>that's only m_update and m_unitMap, AFAICS.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127251/#review94808
---


On April 24, 2016, 1:26 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127251/
> ---
> 
> (Updated April 24, 2016, 1:26 p.m.)
> 
> 
> Review request for KDE Frameworks and Vishesh Handa.
> 
> 
> Bugs: 345750
> https://bugs.kde.org/show_bug.cgi?id=345750
> 
> 
> Repository: kunitconversion
> 
> 
> Description
> ---
> 
> QNetworkReply does not implement waitForReadyRead
> 
> Also, the code never actually created the cache dir it was trying to create a 
> file in.
> 
> 
> Diffs
> -
> 
>   src/currency.cpp ad325d8 
> 
> Diff: https://git.reviewboard.kde.org/r/127251/diff/
> 
> 
> Testing
> ---
> 
> Works now. It's downloaded once and then taken from cache file in 
> ~/.local/share/libkunitconversion/currency.xml
> 
> Given it's a Tier 2 framework doesn't

Jenkins-kde-ci: kdewebkit master kf5-qt5 » Linux,gcc - Build # 51 - Fixed!

2016-05-06 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kdewebkit%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/51/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 06 May 2016 21:17:39 +
Build duration: 45 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  ___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdewebkit master kf5-qt5 » Linux,gcc - Build # 51 - Fixed!

2016-05-06 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kdewebkit%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/51/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 06 May 2016 21:17:39 +
Build duration: 45 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  ___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: baloo master kf5-qt5 » Linux,gcc - Build # 52 - Failure!

2016-05-06 Thread no-reply


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/baloo%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/52/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 06 May 2016 21:10:26 +
Build duration: 3 min 56 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 48 - Still Unstable!

2016-05-06 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/48/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 06 May 2016 21:02:00 +
Build duration: 6 min 36 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 3 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiocore-threadtestFailed: 
TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: 
TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 259/337 (77%)CLASSES 259/337 (77%)LINE 26374/50579 
(52%)CONDITIONAL 14463/37309 (39%)

By packages
  
autotests
FILES 64/64 (100%)CLASSES 64/64 (100%)LINE 7236/7811 
(93%)CONDITIONAL 3813/8092 (47%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7658/14036 
(55%)CONDITIONAL 4136/8905 (46%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE /7564 
(29%)CONDITIONAL 889/4399 (20%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3781 
(46%)CONDITIONAL 1249/3434 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 685/762 (90%)CONDITIONAL 
433/912 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 31/34 (91%)CONDITIONAL 
42/54 (78%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 220/249 (88%)CONDITIONAL 
298/378 (79%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2668/10599 
(25%)CONDITIONAL 1308/6780 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdewebkit master kf5-qt5 » Linux,gcc - Build # 50 - Failure!

2016-05-06 Thread no-reply


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kdewebkit%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/50/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 06 May 2016 21:02:00 +
Build duration: 2 min 39 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 47 - Still Unstable!

2016-05-06 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/47/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 06 May 2016 20:53:33 +
Build duration: 7 min 10 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 3 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiocore-threadtestFailed: 
TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: 
TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 259/337 (77%)CLASSES 259/337 (77%)LINE 26402/50579 
(52%)CONDITIONAL 14482/37309 (39%)

By packages
  
autotests
FILES 64/64 (100%)CLASSES 64/64 (100%)LINE 7236/7811 
(93%)CONDITIONAL 3815/8092 (47%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7681/14036 
(55%)CONDITIONAL 4146/8905 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE /7564 
(29%)CONDITIONAL 889/4399 (20%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3781 
(46%)CONDITIONAL 1249/3434 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 685/762 (90%)CONDITIONAL 
433/912 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 382/594 (64%)CONDITIONAL 
284/580 (49%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 31/34 (91%)CONDITIONAL 
42/54 (78%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 220/249 (88%)CONDITIONAL 
298/378 (79%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2668/10599 
(25%)CONDITIONAL 1309/6780 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 44 - Still Unstable!

2016-05-06 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/44/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 06 May 2016 20:44:35 +
Build duration: 6 min 59 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26735/50599 
(53%)CONDITIONAL 14865/37333 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7518/7831 
(96%)CONDITIONAL 4165/8116 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7686/14036 
(55%)CONDITIONAL 4154/8905 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2267/7564 
(30%)CONDITIONAL 914/4399 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3781 
(47%)CONDITIONAL 1258/3434 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 685/762 (90%)CONDITIONAL 
433/912 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 31/34 (91%)CONDITIONAL 
42/54 (78%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 220/249 (88%)CONDITIONAL 
298/378 (79%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2666/10599 
(25%)CONDITIONAL 1306/6780 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2016-05-06 Thread David Faure



> On April 18, 2016, 11:05 a.m., Gleb Popov wrote:
> > Let's do something about this. I see two solutions for this:
> > 
> > - Add another macro. If we go this route, can we put it in the same .cmake 
> > file?
> > - Add a keyword parameter to the existing macro. Because macro uses 
> > `${ARGN}` it shouldn't break anything.
> 
> Kevin Funk wrote:
> @dfaure: Do you think this issue should be fixed in Qt itself?
> 
> I've just found 
> http://stackoverflow.com/questions/33874243/qprocessstartdetached-but-hide-console-window
>  which supports Patrick's remarks about "how we did it in KDE4 times".
> 
> * We use `QProcess:startDetached` in KF5, in combination with 
> "KDE_FORK_SLAVES" (=> causes console win)
> * We've been leaking QProcess and used `QProcess::start` in KDE4 times 
> for 'kdeinit4.exe' (=> no console win).
> 
> I haven't looked at the Windows implementation of QProcess yet, but maybe 
> it's feasible to extend `QProcess::startDetached`? Ideas? Opinions? 
> 
> /me wonders why noone bothered fixing this in Qt itself yet (lots of 
> discussions about the issues in forums)

Yes this sounds like a Qt bug in startDetached() then.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124905/#review94684
---


On Dec. 3, 2015, 8 a.m., Kevin Funk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124905/
> ---
> 
> (Updated Dec. 3, 2015, 8 a.m.)
> 
> 
> Review request for KDE Frameworks, Alex Merry and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Win: Hide console window for binaries in LIBEXEC
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/CMakeLists.txt 76a8e2800b84c312431cc1996ac81d1ef6fb5cfc 
>   src/ioslaves/http/kcookiejar/CMakeLists.txt 
> 7b4778d1f67c1ad9f9edcaa4692b39ee6fe3f365 
>   src/kioexec/CMakeLists.txt 91284a3a61b86770b4d1939da52d256840803608 
>   src/kioslave/CMakeLists.txt e02febd380b268c596e8ecc3b745b6f50993ab4e 
>   src/kpac/CMakeLists.txt fc5989714480ca49b5bd72e1c7b458b26bd0d9bc 
> 
> Diff: https://git.reviewboard.kde.org/r/124905/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KService/sycoca assert in tests on CI

2016-05-06 Thread David Faure

On Saturday 23 April 2016 00:51:28 Daniel Vrátil wrote:
> Hi guys,
> 
> some KDE PIM unit tests are failing on the CI due to an assert in ksycoca, 
> for 
> example here: [0]
> 
> QWARN  : TestBlogger1::testNetwork() kf5.kservice.sycoca: ERROR: KSycoca 
> database corruption!
> QWARN  : TestBlogger1::testNetwork() kf5.kservice.sycoca: ERROR: KSycoca 
> database corruption!
> QWARN  : TestBlogger1::testNetwork() kf5.kservice.sycoca: ERROR: KSycoca 
> database corruption!
> QWARN  : TestBlogger1::testNetwork() kf5.kservice.sycoca: ERROR: KSycoca 
> database corruption!
> QDEBUG : TestBlogger1::testNetwork() Recreating ksycoca file ("/home/
> jenkins/.qttest/cache/ksycoca5_C_446ImL1tUTkflcd3IPkQK3mGYhc=", version 303)
> QDEBUG : TestBlogger1::testNetwork() Menu "applications-kmenuedit.menu" not 
> found.
> QDEBUG : TestBlogger1::testNetwork() Saving
> QWARN  : TestBlogger1::testNetwork() kf5.kservice.sycoca: ERROR: KSycoca 
> database corruption!
> QFATAL : TestBlogger1::testNetwork() ASSERT: "!dirs.isEmpty()" in file /home/
> jenkins/sources/kservice/stable-kf5-qt5/src/sycoca/ksycoca.cpp, line 626
> 
> It works locally, so it's possible it's something on the CI, altought we've 
> been seeing this problem for quite a while (even before switch to Docker). 
> Any 
> ideas what's going on there? Is it a problem on the CI side, our side or 
> maybe 
> something in sycoca?

This is very likely fixed by 90e71d5 in kservice (with thanks to Jos van den 
Over for the fix).

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 46 - Still Unstable!

2016-05-06 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/46/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 06 May 2016 19:48:52 +
Build duration: 7 min 8 sec

CHANGE SET
Revision f97cc468d6c9111818677420578d8c23bc43470d by scripty: (Upgrade ECM and 
KF5 version requirements for 5.22.0 release.)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 3 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiocore-threadtestFailed: 
TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: 
TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 259/337 (77%)CLASSES 259/337 (77%)LINE 26389/50579 
(52%)CONDITIONAL 14483/37309 (39%)

By packages
  
autotests
FILES 64/64 (100%)CLASSES 64/64 (100%)LINE 7236/7811 
(93%)CONDITIONAL 3815/8092 (47%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7660/14036 
(55%)CONDITIONAL 4138/8905 (46%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE /7564 
(29%)CONDITIONAL 889/4399 (20%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3781 
(47%)CONDITIONAL 1258/3434 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 685/762 (90%)CONDITIONAL 
433/912 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 382/594 (64%)CONDITIONAL 
284/580 (49%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 31/34 (91%)CONDITIONAL 
42/54 (78%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 220/249 (88%)CONDITIONAL 
298/378 (79%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2668/10599 
(25%)CONDITIONAL 1309/6780 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 24 - Still Unstable!

2016-05-06 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/24/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 06 May 2016 20:25:13 +
Build duration: 9 min 17 sec

CHANGE SET
Revision 3cf7f8ecd337625c0fb7625d05ab7c9a550e2d03 by scripty: (Upgrade ECM and 
KF5 version requirements for 5.22.0 release.)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 
39 test(s)Failed: TestSuite.globalcleanuptest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/7 (57%)FILES 160/268 (60%)CLASSES 160/268 (60%)LINE 21704/42801 
(51%)CONDITIONAL 14671/36475 (40%)

By packages
  
autotests
FILES 63/63 (100%)CLASSES 63/63 (100%)LINE 11529/11778 
(98%)CONDITIONAL 8486/16828 (50%)
src.kdecore
FILES 75/94 (80%)CLASSES 75/94 (80%)LINE 9221/16863 
(55%)CONDITIONAL 5722/11783 (49%)
src.kdeui
FILES 18/70 (26%)CLASSES 18/70 (26%)LINE 938/9831 
(10%)CONDITIONAL 460/5693 (8%)
src.kio
FILES 4/27 (15%)CLASSES 4/27 (15%)LINE 16/2396 (1%)CONDITIONAL 
3/1226 (0%)
src.kparts
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/26 (0%)CONDITIONAL 0/14 
(0%)
src.kssl
FILES 0/8 (0%)CLASSES 0/8 (0%)LINE 0/1708 (0%)CONDITIONAL 0/836 
(0%)
src.solid
FILES 0/5 (0%)CLASSES 0/5 (0%)LINE 0/199 (0%)CONDITIONAL 0/95 
(0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 27 - Still Unstable!

2016-05-06 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/27/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 06 May 2016 20:17:32 +
Build duration: 9 min 59 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 
39 test(s)Failed: TestSuite.kurltest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/7 (57%)FILES 161/269 (60%)CLASSES 161/269 (60%)LINE 21565/42814 
(50%)CONDITIONAL 14514/36475 (40%)

By packages
  
autotests
FILES 64/64 (100%)CLASSES 64/64 (100%)LINE 11407/11790 
(97%)CONDITIONAL 8383/16828 (50%)
src.kdecore
FILES 75/94 (80%)CLASSES 75/94 (80%)LINE 9203/16863 
(55%)CONDITIONAL 5668/11783 (48%)
src.kdeui
FILES 18/70 (26%)CLASSES 18/70 (26%)LINE 939/9832 
(10%)CONDITIONAL 460/5693 (8%)
src.kio
FILES 4/27 (15%)CLASSES 4/27 (15%)LINE 16/2396 (1%)CONDITIONAL 
3/1226 (0%)
src.kparts
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/26 (0%)CONDITIONAL 0/14 
(0%)
src.kssl
FILES 0/8 (0%)CLASSES 0/8 (0%)LINE 0/1708 (0%)CONDITIONAL 0/836 
(0%)
src.solid
FILES 0/5 (0%)CLASSES 0/5 (0%)LINE 0/199 (0%)CONDITIONAL 0/95 
(0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127825: networkmanager-qt: Don't complain so much about unhandled LastSeen property

2016-05-06 Thread Allen Winter



> On May 3, 2016, 2:30 p.m., Jan Grulich wrote:
> > That doesn't make much sense to me, if you are getting that error then it 
> > means either LastSeen property was introduced in older NM version or it was 
> > backported in your distribution. I'll check that and update that 
> > NM_CHECK_VERSION accordingly.
> 
> Jan Grulich wrote:
> LastSeen property was indeed introduced in NM 1.0.6 so you shouldn't get 
> any "unhandled property LastSeen" with older NM versions. If nm-qt was build 
> previously against older NM version and then NM got updated then you need to 
> rebuild it of course.
> 
> Allen Winter wrote:
> this isn't my bug really. this is about bug 362611.  I was just trying to 
> help.  I can discard this and can you respond to bug 362611?

I will discard this.


- Allen


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127825/#review95140
---


On May 3, 2016, 2:04 p.m., Allen Winter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127825/
> ---
> 
> (Updated May 3, 2016, 2:04 p.m.)
> 
> 
> Review request for KDE Frameworks and Jan Grulich.
> 
> 
> Bugs: 362611
> http://bugs.kde.org/show_bug.cgi?id=362611
> 
> 
> Repository: networkmanager-qt
> 
> 
> Description
> ---
> 
> If compiling against NetworkManager v1.0.5 or lower you'll get zillions of 
> debug messages about "unhandled property LastSeen".
> 
> 
> Diffs
> -
> 
>   src/accesspoint.cpp 62cbc6c 
> 
> Diff: https://git.reviewboard.kde.org/r/127825/diff/
> 
> 
> Testing
> ---
> 
> none. it compiles.
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127825: networkmanager-qt: Don't complain so much about unhandled LastSeen property

2016-05-06 Thread Allen Winter


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127825/
---

(Updated May 6, 2016, 8:47 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks and Jan Grulich.


Bugs: 362611
http://bugs.kde.org/show_bug.cgi?id=362611


Repository: networkmanager-qt


Description
---

If compiling against NetworkManager v1.0.5 or lower you'll get zillions of 
debug messages about "unhandled property LastSeen".


Diffs
-

  src/accesspoint.cpp 62cbc6c 

Diff: https://git.reviewboard.kde.org/r/127825/diff/


Testing
---

none. it compiles.


Thanks,

Allen Winter

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: threadweaver master kf5-qt5 » Linux,gcc - Build # 17 - Unstable!

2016-05-06 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/threadweaver%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/17/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 06 May 2016 19:59:20 +
Build duration: 7 min 48 sec

CHANGE SET
Revision f98946ee1601e20b6a0b775dfe7eb8fac5d0bae3 by scripty: (Upgrade ECM and 
KF5 version requirements for 5.22.0 release.)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.ThreadWeaverJobTests

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 55/69 (80%)CLASSES 55/69 (80%)LINE 1482/1896 
(78%)CONDITIONAL 1155/2618 (44%)

By packages
  
autotests
FILES 11/11 (100%)CLASSES 11/11 (100%)LINE 413/413 
(100%)CONDITIONAL 493/962 (51%)
src
FILES 44/58 (76%)CLASSES 44/58 (76%)LINE 1069/1483 
(72%)CONDITIONAL 662/1656 (40%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kinit master stable-kf5-qt5 » Linux,gcc - Build # 46 - Failure!

2016-05-06 Thread no-reply


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kinit%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/46/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 06 May 2016 20:05:31 +
Build duration: 5.9 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 51 - Failure!

2016-05-06 Thread no-reply


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/51/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 06 May 2016 20:05:31 +
Build duration: 5.4 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kpty master kf5-qt5 » Linux,gcc - Build # 29 - Fixed!

2016-05-06 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kpty%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/29/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 06 May 2016 20:00:13 +
Build duration: 49 sec

CHANGE SET
Revision 90969d10402c289461d72334ea05c14521b575ef by scripty: (Upgrade ECM and 
KF5 version requirements for 5.22.0 release.)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 432/557 
(78%)CONDITIONAL 125/243 (51%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 111/111 
(100%)CONDITIONAL 38/72 (53%)
src
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 321/446 (72%)CONDITIONAL 
87/171 (51%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kpty master kf5-qt5 » Linux,gcc - Build # 29 - Fixed!

2016-05-06 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kpty%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/29/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 06 May 2016 20:00:13 +
Build duration: 49 sec

CHANGE SET
Revision 90969d10402c289461d72334ea05c14521b575ef by scripty: (Upgrade ECM and 
KF5 version requirements for 5.22.0 release.)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 432/557 
(78%)CONDITIONAL 125/243 (51%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 111/111 
(100%)CONDITIONAL 38/72 (53%)
src
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 321/446 (72%)CONDITIONAL 
87/171 (51%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 23 - Failure!

2016-05-06 Thread no-reply


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/23/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 06 May 2016 19:52:16 +
Build duration: 16 min

CHANGE SET
Revision 3cf7f8ecd337625c0fb7625d05ab7c9a550e2d03 by scripty: (Upgrade ECM and 
KF5 version requirements for 5.22.0 release.)
  change: edit CMakeLists.txt
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 32 - Unstable!

2016-05-06 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/32/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 06 May 2016 19:44:21 +
Build duration: 2 min 12 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5453/7979 
(68%)CONDITIONAL 2951/6140 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1440/1528 
(94%)CONDITIONAL 886/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1761/3042 
(58%)CONDITIONAL 757/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2036/2796 
(73%)CONDITIONAL 1223/2056 (59%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 43 - Still Unstable!

2016-05-06 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/43/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 06 May 2016 19:48:33 +
Build duration: 4 min 44 sec

CHANGE SET
Revision f97cc468d6c9111818677420578d8c23bc43470d by scripty: (Upgrade ECM and 
KF5 version requirements for 5.22.0 release.)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26712/50599 
(53%)CONDITIONAL 14855/37333 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7518/7831 
(96%)CONDITIONAL 4161/8116 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7661/14036 
(55%)CONDITIONAL 4146/8905 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2267/7564 
(30%)CONDITIONAL 914/4399 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3781 
(46%)CONDITIONAL 1249/3434 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 685/762 (90%)CONDITIONAL 
433/912 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 387/594 (65%)CONDITIONAL 
289/580 (50%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 31/34 (91%)CONDITIONAL 
42/54 (78%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 220/249 (88%)CONDITIONAL 
298/378 (79%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2666/10599 
(25%)CONDITIONAL 1306/6780 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: bluez-qt master kf5-qt5 » Linux,gcc - Build # 17 - Failure!

2016-05-06 Thread no-reply


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/bluez-qt%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/17/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 06 May 2016 19:29:54 +
Build duration: 52 sec

CHANGE SET
Revision 152e88c8c47e1e6797bf78863cf1114d71d8800f by scripty: (Upgrade ECM and 
KF5 version requirements for 5.22.0 release.)
  change: edit CMakeLists.txt
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: bluez-qt master stable-kf5-qt5 » Linux,gcc - Build # 17 - Failure!

2016-05-06 Thread no-reply


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/bluez-qt%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/17/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 06 May 2016 19:29:54 +
Build duration: 51 sec

CHANGE SET
Revision 152e88c8c47e1e6797bf78863cf1114d71d8800f by scripty: (Upgrade ECM and 
KF5 version requirements for 5.22.0 release.)
  change: edit CMakeLists.txt
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 33 - Fixed!

2016-05-06 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/33/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 06 May 2016 19:56:13 +
Build duration: 1 min 35 sec

CHANGE SET
Revision b4ff307d5abb41a4619513c7d1060b0f89c9ef50 by scripty: (Upgrade ECM and 
KF5 version requirements for 5.22.0 release.)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5453/7979 
(68%)CONDITIONAL 2949/6140 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1440/1528 
(94%)CONDITIONAL 883/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1761/3042 
(58%)CONDITIONAL 759/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2036/2796 
(73%)CONDITIONAL 1222/2056 (59%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 33 - Fixed!

2016-05-06 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/33/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 06 May 2016 19:56:13 +
Build duration: 1 min 35 sec

CHANGE SET
Revision b4ff307d5abb41a4619513c7d1060b0f89c9ef50 by scripty: (Upgrade ECM and 
KF5 version requirements for 5.22.0 release.)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5453/7979 
(68%)CONDITIONAL 2949/6140 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1440/1528 
(94%)CONDITIONAL 883/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1761/3042 
(58%)CONDITIONAL 759/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2036/2796 
(73%)CONDITIONAL 1222/2056 (59%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 26 - Still Unstable!

2016-05-06 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/26/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 06 May 2016 19:52:24 +
Build duration: 5 min 32 sec

CHANGE SET
Revision 3cf7f8ecd337625c0fb7625d05ab7c9a550e2d03 by scripty: (Upgrade ECM and 
KF5 version requirements for 5.22.0 release.)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 
39 test(s)Failed: TestSuite.kurltest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/7 (57%)FILES 161/269 (60%)CLASSES 161/269 (60%)LINE 21565/42814 
(50%)CONDITIONAL 14514/36475 (40%)

By packages
  
autotests
FILES 64/64 (100%)CLASSES 64/64 (100%)LINE 11407/11790 
(97%)CONDITIONAL 8383/16828 (50%)
src.kdecore
FILES 75/94 (80%)CLASSES 75/94 (80%)LINE 9203/16863 
(55%)CONDITIONAL 5668/11783 (48%)
src.kdeui
FILES 18/70 (26%)CLASSES 18/70 (26%)LINE 939/9832 
(10%)CONDITIONAL 460/5693 (8%)
src.kio
FILES 4/27 (15%)CLASSES 4/27 (15%)LINE 16/2396 (1%)CONDITIONAL 
3/1226 (0%)
src.kparts
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/26 (0%)CONDITIONAL 0/14 
(0%)
src.kssl
FILES 0/8 (0%)CLASSES 0/8 (0%)LINE 0/1708 (0%)CONDITIONAL 0/836 
(0%)
src.solid
FILES 0/5 (0%)CLASSES 0/5 (0%)LINE 0/199 (0%)CONDITIONAL 0/95 
(0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

2016-05-06 Thread Aleix Pol Gonzalez



> On May 6, 2016, 6:08 p.m., David Rosca wrote:
> > It will also need 
> > https://quickgit.kde.org/?p=plasma-workspace.git=commit=1b6231f2e3f1de8cb5ea2540f0b8f425f6ae43a3
> >  in Plasma/5.6

No, it's already called by `ShellCorona::loadDefaultLayout()`.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127850/#review95241
---


On May 6, 2016, 5:56 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127850/
> ---
> 
> (Updated May 6, 2016, 5:56 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and David Rosca.
> 
> 
> Bugs: 60777
> http://bugs.kde.org/show_bug.cgi?id=60777
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Iteration of: https://git.reviewboard.kde.org/r/127848/
> 
> We either load the existing layout or we load a default one.
> 
> With this, it could be removed from ShellCorona.
> 
> 
> Diffs
> -
> 
>   src/plasma/corona.cpp 1784516 
> 
> Diff: https://git.reviewboard.kde.org/r/127850/diff/
> 
> 
> Testing
> ---
> 
> Tests pass.
> PlasmaShell prints completed once both with and without configuration.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

2016-05-06 Thread David Rosca


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127850/#review95241
---



It will also need 
https://quickgit.kde.org/?p=plasma-workspace.git=commit=1b6231f2e3f1de8cb5ea2540f0b8f425f6ae43a3
 in Plasma/5.6

- David Rosca


On May 6, 2016, 3:56 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127850/
> ---
> 
> (Updated May 6, 2016, 3:56 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and David Rosca.
> 
> 
> Bugs: 60777
> http://bugs.kde.org/show_bug.cgi?id=60777
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Iteration of: https://git.reviewboard.kde.org/r/127848/
> 
> We either load the existing layout or we load a default one.
> 
> With this, it could be removed from ShellCorona.
> 
> 
> Diffs
> -
> 
>   src/plasma/corona.cpp 1784516 
> 
> Diff: https://git.reviewboard.kde.org/r/127850/diff/
> 
> 
> Testing
> ---
> 
> Tests pass.
> PlasmaShell prints completed once both with and without configuration.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

2016-05-06 Thread Kai Uwe Broulik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127850/#review95240
---




src/plasma/corona.cpp (line 181)


Braces pls


- Kai Uwe Broulik


On Mai 6, 2016, 3:56 nachm., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127850/
> ---
> 
> (Updated Mai 6, 2016, 3:56 nachm.)
> 
> 
> Review request for KDE Frameworks, Plasma and David Rosca.
> 
> 
> Bugs: 60777
> http://bugs.kde.org/show_bug.cgi?id=60777
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Iteration of: https://git.reviewboard.kde.org/r/127848/
> 
> We either load the existing layout or we load a default one.
> 
> With this, it could be removed from ShellCorona.
> 
> 
> Diffs
> -
> 
>   src/plasma/corona.cpp 1784516 
> 
> Diff: https://git.reviewboard.kde.org/r/127850/diff/
> 
> 
> Testing
> ---
> 
> Tests pass.
> PlasmaShell prints completed once both with and without configuration.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

2016-05-06 Thread David Rosca


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127850/#review95239
---




src/plasma/corona.cpp (line 181)


braces also with one line


- David Rosca


On May 6, 2016, 3:56 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127850/
> ---
> 
> (Updated May 6, 2016, 3:56 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and David Rosca.
> 
> 
> Bugs: 60777
> http://bugs.kde.org/show_bug.cgi?id=60777
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Iteration of: https://git.reviewboard.kde.org/r/127848/
> 
> We either load the existing layout or we load a default one.
> 
> With this, it could be removed from ShellCorona.
> 
> 
> Diffs
> -
> 
>   src/plasma/corona.cpp 1784516 
> 
> Diff: https://git.reviewboard.kde.org/r/127850/diff/
> 
> 
> Testing
> ---
> 
> Tests pass.
> PlasmaShell prints completed once both with and without configuration.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127850: Let Plasma::Corona load the layout on all cases.

2016-05-06 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127850/
---

Review request for KDE Frameworks, Plasma and David Rosca.


Bugs: 60777
http://bugs.kde.org/show_bug.cgi?id=60777


Repository: plasma-framework


Description
---

Iteration of: https://git.reviewboard.kde.org/r/127848/

We either load the existing layout or we load a default one.

With this, it could be removed from ShellCorona.


Diffs
-

  src/plasma/corona.cpp 1784516 

Diff: https://git.reviewboard.kde.org/r/127850/diff/


Testing
---

Tests pass.
PlasmaShell prints completed once both with and without configuration.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127837: oxygen_windeco: Fix potential use-after-free from improper use of QCache

2016-05-06 Thread Hugo Pereira Da Costa



> On May 6, 2016, 2:09 p.m., Hugo Pereira Da Costa wrote:
> > Thanks ! 
> > I tested it here. Looks fine.
> > Although the diff is hard to read, new code looks good.
> > 
> > Hugo

PS: since oxygen does a lot of caching, there actually are many other places 
also affected by the coverty report. (in liboxygen/oxygenhelper). 
I'll have a look in there at some point, but if you find time to work on it on 
your own, don't hesitate :)


- Hugo


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127837/#review95233
---


On May 5, 2016, 12:23 a.m., Michael Pyne wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127837/
> ---
> 
> (Updated May 5, 2016, 12:23 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: oxygen
> 
> 
> Description
> ---
> 
> oxygen windeco: Fix use-after-free for pixmap in QCache.
> 
> Coverity identified (in CID 1336171) a usage of QPixmap after it's been
> the parameter to QCache::insert.
> 
> This is unsafe since QCache gains ownership of whatever object is passed
> in, and can even (at least in theory) delete the object you pass in.
> Instead give the QCache its own copy of the pixmap.
> 
> To make this work without leaking our existing pixmap we need to work
> with a QPixmap instead of QPixmap* in the non-cached case. This leads to
> whitespace changes; use git diff -b to filter pure whitespace changes
> out.
> 
> 
> Diffs
> -
> 
>   kdecoration/oxygendecohelper.cpp a7e9306 
> 
> Diff: https://git.reviewboard.kde.org/r/127837/diff/
> 
> 
> Testing
> ---
> 
> The new code compiles but I'm currently unable to test since kcmshell5 
> kwindecoration (and any other KCM viewer) is currently crashing for me in 
> QML, due to what I'm sure is a local misconfiguration...
> 
> 
> Thanks,
> 
> Michael Pyne
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127837: oxygen_windeco: Fix potential use-after-free from improper use of QCache

2016-05-06 Thread Hugo Pereira Da Costa


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127837/#review95233
---


Ship it!




Thanks ! 
I tested it here. Looks fine.
Although the diff is hard to read, new code looks good.

Hugo

- Hugo Pereira Da Costa


On May 5, 2016, 12:23 a.m., Michael Pyne wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127837/
> ---
> 
> (Updated May 5, 2016, 12:23 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: oxygen
> 
> 
> Description
> ---
> 
> oxygen windeco: Fix use-after-free for pixmap in QCache.
> 
> Coverity identified (in CID 1336171) a usage of QPixmap after it's been
> the parameter to QCache::insert.
> 
> This is unsafe since QCache gains ownership of whatever object is passed
> in, and can even (at least in theory) delete the object you pass in.
> Instead give the QCache its own copy of the pixmap.
> 
> To make this work without leaking our existing pixmap we need to work
> with a QPixmap instead of QPixmap* in the non-cached case. This leads to
> whitespace changes; use git diff -b to filter pure whitespace changes
> out.
> 
> 
> Diffs
> -
> 
>   kdecoration/oxygendecohelper.cpp a7e9306 
> 
> Diff: https://git.reviewboard.kde.org/r/127837/diff/
> 
> 
> Testing
> ---
> 
> The new code compiles but I'm currently unable to test since kcmshell5 
> kwindecoration (and any other KCM viewer) is currently crashing for me in 
> QML, due to what I'm sure is a local misconfiguration...
> 
> 
> Thanks,
> 
> Michael Pyne
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127834: ki18n: Fix theoretically possible use-after-free in gettext when using strict ANSI compilers

2016-05-06 Thread Chusslove Illich


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127834/#review95232
---


Ship it!




Ship It!

- Chusslove Illich


On Мај 5, 2016, 3:07 пре п., Michael Pyne wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127834/
> ---
> 
> (Updated Мај 5, 2016, 3:07 пре п.)
> 
> 
> Review request for KDE Frameworks, Localization and Translation (l10n) and 
> Chusslove Illich.
> 
> 
> Repository: ki18n
> 
> 
> Description
> ---
> 
> Coverity noted that some of code for message catalog lookup uses some pointer 
> values after they are freed. Even though the use in question is a simple 
> equality comparison against a different (valid) pointer, it is still 
> undefined behavior according to the C (and C++) language specs and is 
> therefore liable to cause miscompilation and who knows what other kinds of 
> problems.
> 
> This code is not normally enabled, normally a code path that supports 
> variable-length arrays is active, which is not susceptible to this bug.
> 
> Since VLAs are not supported even in current C++ versions, making VLA support 
> mandatory is not feasible, so instead I opted to move the pointer comparisons 
> to a point in the code where the comparison is valid, and then use the saved 
> result later.
> 
> I have also reported the bug to GNU Gettext, since upstream still has the 
> error. It is GNU Gettext bug 47847.
> 
> 
> Diffs
> -
> 
>   src/gettext.h b06fc90 
> 
> Diff: https://git.reviewboard.kde.org/r/127834/diff/
> 
> 
> Testing
> ---
> 
> Code compiles and KDE applications still seem to work fine. I also tested 
> with the changed code path forcibly enabled by disabling VLA support, and 
> things still seemed to work.
> 
> There's not a lot of autotests to choose from, but the KLocalizedString test 
> still passed.
> 
> 
> Thanks,
> 
> Michael Pyne
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126495: Install parsetrigrams tool for cross compiling.

2016-05-06 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126495/#review95229
---




data/CMakeLists.txt (line 6)


Maybe it should be installed in `libexec`?


- Aleix Pol Gonzalez


On May 5, 2016, 9:55 p.m., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126495/
> ---
> 
> (Updated May 5, 2016, 9:55 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: sonnet
> 
> 
> Description
> ---
> 
> Add support for running host provided tool parsetrigrams when cross compiling 
> by specifing cmake variable PARSETRIGRAMS_EXECUTABLE on configure time.
> 
> 
> Diffs
> -
> 
>   data/CMakeLists.txt 023ec28b27f9190e3885cf626996aae8b68c4c80 
> 
> Diff: https://git.reviewboard.kde.org/r/126495/diff/
> 
> 
> Testing
> ---
> 
> Cross compiled package build at 
> https://build.opensuse.org/package/show/home:rhabacker:branches:windows:mingw:win32:KF516/mingw32-sonnet
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

2016-05-06 Thread Anthony Fieroni


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127809/
---

(Updated Май 6, 2016, 12:08 след обяд)


Review request for KDE Frameworks, KDE Usability and Martin Gräßlin.


Bugs: 362324
https://bugs.kde.org/show_bug.cgi?id=362324


Repository: kwindowsystem


Description
---

The api function is KWindowSystem::icon (WId win, int width=-1, int height=-1, 
bool scale=false) so caller must get best size not worst when width/height is 
not specified.


Diffs (updated)
-

  src/platforms/xcb/kwindowsystem.cpp 5b7c65a 

Diff: https://git.reviewboard.kde.org/r/127809/diff/


Testing
---


File Attachments


before
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/05/01/6d718ef6-26cf-4866-94d2-4ffbdfc906fe__Screenshot_20160426_232109.png
after
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/05/01/7dcab4ae-e451-4d43-8799-a0fcab471a3d__Screenshot_20160501_224642.png


Thanks,

Anthony Fieroni

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

2016-05-06 Thread Martin Gräßlin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127809/#review95227
---




src/platforms/xcb/kwindowsystem.cpp (lines 736 - 739)


I'm not considering this patch unless you turn it back into a readable 
if-else structure!


- Martin Gräßlin


On May 6, 2016, 9:02 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127809/
> ---
> 
> (Updated May 6, 2016, 9:02 a.m.)
> 
> 
> Review request for KDE Frameworks, KDE Usability and Martin Gräßlin.
> 
> 
> Bugs: 362324
> https://bugs.kde.org/show_bug.cgi?id=362324
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> The api function is KWindowSystem::icon (WId win, int width=-1, int 
> height=-1, bool scale=false) so caller must get best size not worst when 
> width/height is not specified.
> 
> 
> Diffs
> -
> 
>   src/platforms/xcb/kwindowsystem.cpp 5b7c65a 
> 
> Diff: https://git.reviewboard.kde.org/r/127809/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/05/01/6d718ef6-26cf-4866-94d2-4ffbdfc906fe__Screenshot_20160426_232109.png
> after
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/05/01/7dcab4ae-e451-4d43-8799-a0fcab471a3d__Screenshot_20160501_224642.png
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 23 - Fixed!

2016-05-06 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/23/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Fri, 06 May 2016 08:09:55 +
Build duration: 3 min 55 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 3/4 (75%)FILES 40/46 (87%)CLASSES 40/46 (87%)LINE 6637/8880 
(75%)CONDITIONAL 3681/6809 (54%)

By packages
  
autotests
FILES 13/13 (100%)CLASSES 13/13 (100%)LINE 2837/2896 
(98%)CONDITIONAL 1528/2909 (53%)
src
FILES 13/15 (87%)CLASSES 13/15 (87%)LINE 749/1400 
(54%)CONDITIONAL 309/692 (45%)
src.platforms.wayland
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/89 (0%)CONDITIONAL 0/2 (0%)
src.platforms.xcb
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 3051/4495 
(68%)CONDITIONAL 1844/3206 (58%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 23 - Fixed!

2016-05-06 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/23/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Fri, 06 May 2016 08:09:55 +
Build duration: 3 min 55 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 3/4 (75%)FILES 40/46 (87%)CLASSES 40/46 (87%)LINE 6637/8880 
(75%)CONDITIONAL 3681/6809 (54%)

By packages
  
autotests
FILES 13/13 (100%)CLASSES 13/13 (100%)LINE 2837/2896 
(98%)CONDITIONAL 1528/2909 (53%)
src
FILES 13/15 (87%)CLASSES 13/15 (87%)LINE 749/1400 
(54%)CONDITIONAL 309/692 (45%)
src.platforms.wayland
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/89 (0%)CONDITIONAL 0/2 (0%)
src.platforms.xcb
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 3051/4495 
(68%)CONDITIONAL 1844/3206 (58%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

2016-05-06 Thread Anthony Fieroni


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127809/
---

(Updated Май 6, 2016, 10:02 преди обяд)


Review request for KDE Frameworks, KDE Usability and Martin Gräßlin.


Bugs: 362324
https://bugs.kde.org/show_bug.cgi?id=362324


Repository: kwindowsystem


Description
---

The api function is KWindowSystem::icon (WId win, int width=-1, int height=-1, 
bool scale=false) so caller must get best size not worst when width/height is 
not specified.


Diffs (updated)
-

  src/platforms/xcb/kwindowsystem.cpp 5b7c65a 

Diff: https://git.reviewboard.kde.org/r/127809/diff/


Testing
---


File Attachments


before
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/05/01/6d718ef6-26cf-4866-94d2-4ffbdfc906fe__Screenshot_20160426_232109.png
after
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/05/01/7dcab4ae-e451-4d43-8799-a0fcab471a3d__Screenshot_20160501_224642.png


Thanks,

Anthony Fieroni

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

52 matches

Mail list logo