Re: Review Request 127911: Add a CMake option to build binary Qt resource out of icons dir.

[Gleb Popov]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127911/
---

(Updated May 17, 2016, 8:55 a.m.)


Review request for KDE Frameworks.


Changes
---

Address comments.


Repository: breeze-icons


Description
---

I copied icons into the binary dir, because i haven't found a way to generate 
rcc without polluting source dir.

Not sure if installation dir is right, too.


Diffs (updated)
-

  CMakeLists.txt 2147705 
  icons-dark/CMakeLists.txt 36d37f1 
  icons/CMakeLists.txt 5ded49c 

Diff: https://git.reviewboard.kde.org/r/127911/diff/


Testing
---


Thanks,

Gleb Popov

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127923: Add support for custom emoticon sizes

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127923/
---

(Updated May 17, 2016, 5:27 a.m.)


Review request for KDE Frameworks and David Gil Oliva.


Changes
---

Merge the first two arg()


Repository: kemoticons


Description
---

Right now KEmoticonTheme::parse always returns the emoticons
sized by the actual image file size, but there are cases where
different size is needed, for example when parsing emoticons
inline in a text area while typing.

This also allows to ship bigger emoticon images and have them
scaled down as/when needed.


Diffs (updated)
-

  autotests/kemoticontest.cpp 4e0e539 
  src/core/kemoticons.h 4718c00 
  src/core/kemoticons.cpp 9756c1f 
  src/core/kemoticonsprovider.h d259bf8 
  src/core/kemoticonsprovider.cpp 5aabd82 

Diff: https://git.reviewboard.kde.org/r/127923/diff/


Testing
---

Works as expected plus comes with a simple autotest.


Thanks,

Martin Klapetek

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 43 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/43/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 17 May 2016 01:07:47 +
Build duration: 2 min 30 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5456/7982 
(68%)CONDITIONAL 2949/6142 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1440/1528 
(94%)CONDITIONAL 883/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1761/3042 
(58%)CONDITIONAL 756/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2039/2799 
(73%)CONDITIONAL 1225/2058 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 43 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/43/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 17 May 2016 01:07:47 +
Build duration: 2 min 30 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5456/7982 
(68%)CONDITIONAL 2949/6142 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1440/1528 
(94%)CONDITIONAL 883/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1761/3042 
(58%)CONDITIONAL 756/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2039/2799 
(73%)CONDITIONAL 1225/2058 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kpty master stable-kf5-qt5 » Linux,gcc - Build # 37 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kpty%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/37/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 17 May 2016 01:06:22 +
Build duration: 51 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 432/557 
(78%)CONDITIONAL 125/243 (51%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 111/111 
(100%)CONDITIONAL 38/72 (53%)
src
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 321/446 (72%)CONDITIONAL 
87/171 (51%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kpty master stable-kf5-qt5 » Linux,gcc - Build # 37 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kpty%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/37/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 17 May 2016 01:06:22 +
Build duration: 51 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 432/557 
(78%)CONDITIONAL 125/243 (51%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 111/111 
(100%)CONDITIONAL 38/72 (53%)
src
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 321/446 (72%)CONDITIONAL 
87/171 (51%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127865: Check size of unix domain socket path before copying to it.

[Michael Pyne]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127865/
---

(Updated May 17, 2016, 12:25 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 91e72d319bf99637dadbe4db5bac5305c954aa15 by Michael Pyne 
to branch master.


Repository: kcrash


Description
---

Although we don't seem to run across this in practice, Coverity warns about 
filling in sockaddr_un::sun_path's buffer without checking the source string's 
length (CID 1175514), and the Linux unix(7) manpage notes that some 
implementations use as few as 92 bytes for this buffer.


Diffs
-

  src/kcrash.cpp 7d3b8a2 

Diff: https://git.reviewboard.kde.org/r/127865/diff/


Testing
---

Compiles w/out warnings, kcrashtest passes.


Thanks,

Michael Pyne

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127941: Kio fish: cannot process any file or diretory having a non-latin1 name

[Fabien Shum-King]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127941/
---

(Updated May 16, 2016, 10:05 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 1876df2e3d59c3d0fdee3d3084a07175fc9a00ed by Albert Astals 
Cid on behalf of Fabien Shum-King to branch Applications/16.04.


Bugs: 357870
https://bugs.kde.org/show_bug.cgi?id=357870


Repository: kio-extras


Description
---

All the commands sent to the Fish server are converted to latin1. By 
consequence, all the non-latin1 characters are replaced by questions marks, and 
therefore any command involving a file or directory with such a name fails.


Diffs
-

  fish/fish.cpp f0b3b79 

Diff: https://git.reviewboard.kde.org/r/127941/diff/


Testing
---

Created on a remote machine a file and a directory with an non-latin1 name (ex: 
??, éé).
1. Connect with fish and try to copy the file to the local machine => It fails
2. Try to enter the directory => it also fails.

With the proposed fix, both work.


Thanks,

Fabien Shum-King

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127911: Add a CMake option to build binary Qt resource out of icons dir.

[Kevin Funk]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127911/#review95520
---




CMakeLists.txt (line 24)


Rename: Use a verb -- rename to `add_binary_resource`, or 
`generate_binary_resource`

Params: `ret` -> `out`, or `outfile`



CMakeLists.txt (line 29)


This action should be deferred as well. See next comment.



CMakeLists.txt (line 32)


`cmake -E make_directory` first?


- Kevin Funk


On May 16, 2016, 6:21 a.m., Gleb Popov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127911/
> ---
> 
> (Updated May 16, 2016, 6:21 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> ---
> 
> I copied icons into the binary dir, because i haven't found a way to generate 
> rcc without polluting source dir.
> 
> Not sure if installation dir is right, too.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 2147705 
>   icons-dark/CMakeLists.txt 36d37f1 
>   icons/CMakeLists.txt 5ded49c 
> 
> Diff: https://git.reviewboard.kde.org/r/127911/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127941: Kio fish: cannot process any file or diretory having a non-latin1 name

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127941/#review95518
---


Ship it!




I wish this awful E() macro was a function, it would be much more readable and 
safer (would return a QByteArray rather than a pointer to a temporary 
buffer...), but anyhow, the fix looks clearly correct.

PS: don't click "Ship It" on your own requests :-)

- David Faure


On May 16, 2016, 7:49 p.m., Fabien Shum-King wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127941/
> ---
> 
> (Updated May 16, 2016, 7:49 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 357870
> https://bugs.kde.org/show_bug.cgi?id=357870
> 
> 
> Repository: kio-extras
> 
> 
> Description
> ---
> 
> All the commands sent to the Fish server are converted to latin1. By 
> consequence, all the non-latin1 characters are replaced by questions marks, 
> and therefore any command involving a file or directory with such a name 
> fails.
> 
> 
> Diffs
> -
> 
>   fish/fish.cpp f0b3b79 
> 
> Diff: https://git.reviewboard.kde.org/r/127941/diff/
> 
> 
> Testing
> ---
> 
> Created on a remote machine a file and a directory with an non-latin1 name 
> (ex: ??, éé).
> 1. Connect with fish and try to copy the file to the local machine => It fails
> 2. Try to enter the directory => it also fails.
> 
> With the proposed fix, both work.
> 
> 
> Thanks,
> 
> Fabien Shum-King
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127935: Call kdoctools_create_handbook only for index.docbook

[Luigi Toscano]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127935/
---

(Updated May 16, 2016, 10:26 p.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation, KDE Frameworks and Elvis Angelaccio.


Changes
---

Submitted with commit 0a90d5fc7d367d5937f3cb171f56f948f93f36ef by Luigi Toscano 
to branch master.


Bugs: 357428
https://bugs.kde.org/show_bug.cgi?id=357428


Repository: kdoctools


Description
---

When more documentation files are available in a certain directory, the 
assumption is that there should always be an index.docbook which
imports all the other docbook files in the same directory. The call to 
kdoctools_create_handbook must be created only for index.docbook;
the macro takes care of the installation of the others docbooks. 
This should make kdoctools_install work when there are multiple docbooks in the 
same directory.


Diffs
-

  KF5DocToolsMacros.cmake 54761b6 

Diff: https://git.reviewboard.kde.org/r/127935/diff/


Testing
---

Tried kdoctools_install when the (translated) documentation is made of multiple 
docbooks (like krusader), see the bug for more details.


Thanks,

Luigi Toscano

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

[René J . V . Bertin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126198/
---

(Updated May 16, 2016, 9:49 p.m.)


Review request for KDE Software on Mac OS X, KDE Frameworks, Plasma, and 
Valorie Zimmerman.


Changes
---

Diff updated for git/master, and sync with what I hope are the relevant changes 
to the code in `plasma-integration`.


Repository: frameworkintegration


Description
---

The KdePlatformTheme plugin can be enabled on OS X with a minimal patch to Qt5; 
all that is required is to include the `qgenericunixservices` and 
`qgenericunixthemes` components in the build, and to append `"kde"` to the list 
returned by `QCocoaIntegration::themeNames()` for instance under the condition 
that `KDE_SESSION_VERSION` is set to a suitable value in the environment.

This will allow KF5 and Qt5 applications to use the theme selected through KDE 
if FrameworkIntegration is installed and KDE_SESSION_VERSION is set, which 
seems like a sufficiently specific set of conditions that is easy to avoid by 
users who prefer to use the Mac native theme.

While requestion the KDE theme is also possible through `-style kde` or `env 
QT_STYLE_OVERRIDE=kde` the use of the KdePlatformTheme plugin appears to be the 
only way to get the full theme, including the font and colour selection. In my 
opinion it is above all the font customisation which is a very welcome feature 
for Qt/Mac; by default Qt applications use the default system font (Lucida 
Grande 13pt or even 14pt) throughout. This is a good UI font, but not at that 
size (and most "native" OS X applications indeed use a range of smaller sizes, 
depending on role.

It does have introduce a number of regressions, which the current patch aims to 
address. The most visible and problematic of these regressions is the loss of 
the Mac-style menu bar and thus of all menu items (actions).

The fix is straightforward : on OS X (and similarly affected platforms?), an 
instance of the native Cocoa platform theme is created through the private API, 
and used as a fallback rather than immediately falling back to the default 
implementations from `QPlatformTheme`. In addition, methods missing from (not 
overridden by) `KdePlatformTheme` are provided on OS X and call the 
corresponding methods from the native theme. It is this change which restores 
the menubar and even the Dock menu functionality.
One minor regression remains but should be easy to fix (elsewhere?): the 
Preferences menu loses its keyboard shortcut (Command-,).

Given the fallback nature of the native platform instance I have preferred to 
print a warning rather than using something like `qFatal`, above all because 
the message printed by qFatal tends to get lost on OS X. I can replace my use 
of `qWarning` with a dialog giving the choice between continuing or exiting the 
application - code that would be called in the menu methods because only there 
is it certain that the application actually needs a menubar.

In line with experience and feedback from the KDE(4)-Mac community I have 
decided to force the use of native dialogs rather than the ones from the 
KdePlatformPlugin.

In addition I set the fallback value for `ShowIconsOnPushButtons` to false in 
line with platform guidelines, and ensure that the autotests are not built as 
app bundles.


Diffs (updated)
-

  CMakeLists.txt 6ea1cba 
  src/CMakeLists.txt 1c54eb2 
  src/platformtheme/CMakeLists.txt PRE-CREATION 
  src/platformtheme/config-platformtheme.h.cmake PRE-CREATION 
  src/platformtheme/frameworksintegration-5.16-font.sh PRE-CREATION 
  src/platformtheme/frameworksintegration-5.16-font.upd PRE-CREATION 
  src/platformtheme/kdemactheme.h PRE-CREATION 
  src/platformtheme/kdemactheme.mm PRE-CREATION 
  src/platformtheme/kdeplatformfiledialogbase.cpp PRE-CREATION 
  src/platformtheme/kdeplatformfiledialogbase_p.h PRE-CREATION 
  src/platformtheme/kdeplatformfiledialoghelper.h PRE-CREATION 
  src/platformtheme/kdeplatformfiledialoghelper.cpp PRE-CREATION 
  src/platformtheme/kdeplatformsystemtrayicon.h PRE-CREATION 
  src/platformtheme/kdeplatformsystemtrayicon.cpp PRE-CREATION 
  src/platformtheme/kdeplatformtheme.h PRE-CREATION 
  src/platformtheme/kdeplatformtheme.cpp PRE-CREATION 
  src/platformtheme/kdeplatformtheme.json PRE-CREATION 
  src/platformtheme/kdirselectdialog.cpp PRE-CREATION 
  src/platformtheme/kdirselectdialog_p.h PRE-CREATION 
  src/platformtheme/kfiletreeview.cpp PRE-CREATION 
  src/platformtheme/kfiletreeview_p.h PRE-CREATION 
  src/platformtheme/kfontsettingsdata.h PRE-CREATION 
  src/platformtheme/kfontsettingsdata.cpp PRE-CREATION 
  src/platformtheme/kfontsettingsdatamac.h PRE-CREATION 
  src/platformtheme/kfontsettingsdatamac.mm PRE-CREATION 
  src/platformtheme/khintssettings.h PRE-CREATION 
  src/platformtheme/khintssettings.cpp PRE-CREATION 
  src/platformtheme/khint

Re: Review Request 127941: Kio fish: cannot process any file or diretory having a non-latin1 name

[Fabien Shum-King]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127941/
---

(Updated mai 16, 2016, 7:49 après-midi)


Review request for KDE Frameworks.


Summary (updated)
-

Kio fish: cannot process any file or diretory having a non-latin1 name


Bugs: 357870
https://bugs.kde.org/show_bug.cgi?id=357870


Repository: kio-extras


Description
---

All the commands sent to the Fish server are converted to latin1. By 
consequence, all the non-latin1 characters are replaced by questions marks, and 
therefore any command involving a file or directory with such a name fails.


Diffs
-

  fish/fish.cpp f0b3b79 

Diff: https://git.reviewboard.kde.org/r/127941/diff/


Testing
---

Created on a remote machine a file and a directory with an non-latin1 name (ex: 
??, éé).
1. Connect with fish and try to copy the file to the local machine => It fails
2. Try to enter the directory => it also fails.

With the proposed fix, both work.


Thanks,

Fabien Shum-King

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127941: bug 357870: in kio fish, cannot process any file or diretory having a non-latin1 name

[Fabien Shum-King]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127941/
---

Review request for KDE Frameworks.


Bugs: 357870
https://bugs.kde.org/show_bug.cgi?id=357870


Repository: kio-extras


Description
---

All the commands sent to the Fish server are converted to latin1. By 
consequence, all the non-latin1 characters are replaced by questions marks, and 
therefore any command involving a file or directory with such a name fails.


Diffs
-

  fish/fish.cpp f0b3b79 

Diff: https://git.reviewboard.kde.org/r/127941/diff/


Testing
---

Created on a remote machine a file and a directory with an non-latin1 name (ex: 
??, éé).
1. Connect with fish and try to copy the file to the local machine => It fails
2. Try to enter the directory => it also fails.

With the proposed fix, both work.


Thanks,

Fabien Shum-King

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127935: Call kdoctools_create_handbook only for index.docbook

[Elvis Angelaccio]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127935/#review95515
---


Ship it!




Ship It!

- Elvis Angelaccio


On May 16, 2016, 5:59 p.m., Luigi Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127935/
> ---
> 
> (Updated May 16, 2016, 5:59 p.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Elvis Angelaccio.
> 
> 
> Bugs: 357428
> https://bugs.kde.org/show_bug.cgi?id=357428
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> When more documentation files are available in a certain directory, the 
> assumption is that there should always be an index.docbook which
> imports all the other docbook files in the same directory. The call to 
> kdoctools_create_handbook must be created only for index.docbook;
> the macro takes care of the installation of the others docbooks. 
> This should make kdoctools_install work when there are multiple docbooks in 
> the same directory.
> 
> 
> Diffs
> -
> 
>   KF5DocToolsMacros.cmake 54761b6 
> 
> Diff: https://git.reviewboard.kde.org/r/127935/diff/
> 
> 
> Testing
> ---
> 
> Tried kdoctools_install when the (translated) documentation is made of 
> multiple docbooks (like krusader), see the bug for more details.
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127935: Call kdoctools_create_handbook only for index.docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127935/#review95514
---


Ship it!




Ship It!

- Burkhard Lück


On Mai 16, 2016, 5:59 nachm., Luigi Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127935/
> ---
> 
> (Updated Mai 16, 2016, 5:59 nachm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Elvis Angelaccio.
> 
> 
> Bugs: 357428
> https://bugs.kde.org/show_bug.cgi?id=357428
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> When more documentation files are available in a certain directory, the 
> assumption is that there should always be an index.docbook which
> imports all the other docbook files in the same directory. The call to 
> kdoctools_create_handbook must be created only for index.docbook;
> the macro takes care of the installation of the others docbooks. 
> This should make kdoctools_install work when there are multiple docbooks in 
> the same directory.
> 
> 
> Diffs
> -
> 
>   KF5DocToolsMacros.cmake 54761b6 
> 
> Diff: https://git.reviewboard.kde.org/r/127935/diff/
> 
> 
> Testing
> ---
> 
> Tried kdoctools_install when the (translated) documentation is made of 
> multiple docbooks (like krusader), see the bug for more details.
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127935: Call kdoctools_create_handbook only for index.docbook

[Luigi Toscano]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127935/
---

(Updated Mag. 16, 2016, 7:59 p.m.)


Review request for Documentation, KDE Frameworks and Elvis Angelaccio.


Changes
---

Really update the documentation.


Bugs: 357428
https://bugs.kde.org/show_bug.cgi?id=357428


Repository: kdoctools


Description
---

When more documentation files are available in a certain directory, the 
assumption is that there should always be an index.docbook which
imports all the other docbook files in the same directory. The call to 
kdoctools_create_handbook must be created only for index.docbook;
the macro takes care of the installation of the others docbooks. 
This should make kdoctools_install work when there are multiple docbooks in the 
same directory.


Diffs (updated)
-

  KF5DocToolsMacros.cmake 54761b6 

Diff: https://git.reviewboard.kde.org/r/127935/diff/


Testing
---

Tried kdoctools_install when the (translated) documentation is made of multiple 
docbooks (like krusader), see the bug for more details.


Thanks,

Luigi Toscano

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127935: Call kdoctools_create_handbook only for index.docbook

[Luigi Toscano]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127935/
---

(Updated Mag. 16, 2016, 7:58 p.m.)


Review request for Documentation, KDE Frameworks and Elvis Angelaccio.


Changes
---

Try to improve the documentation.


Bugs: 357428
https://bugs.kde.org/show_bug.cgi?id=357428


Repository: kdoctools


Description
---

When more documentation files are available in a certain directory, the 
assumption is that there should always be an index.docbook which
imports all the other docbook files in the same directory. The call to 
kdoctools_create_handbook must be created only for index.docbook;
the macro takes care of the installation of the others docbooks. 
This should make kdoctools_install work when there are multiple docbooks in the 
same directory.


Diffs (updated)
-

  KF5DocToolsMacros.cmake 54761b6 

Diff: https://git.reviewboard.kde.org/r/127935/diff/


Testing
---

Tried kdoctools_install when the (translated) documentation is made of multiple 
docbooks (like krusader), see the bug for more details.


Thanks,

Luigi Toscano

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127935: Call kdoctools_create_handbook only for index.docbook

[Luigi Toscano]

> On Mag. 16, 2016, 11:41 a.m., Elvis Angelaccio wrote:
> > KF5DocToolsMacros.cmake, lines 47-49
> > 
> >
> > Maybe update this sentence as well? "... index.docbook is installed 
> > using KDOCTOOLS_CREATE_HANDBOOK."
> 
> Luigi Toscano wrote:
> Makes sense.

Ups, ate my comment: I wanted to write that it is partially correct, as 
kdoctools_create_handbook installs all the other docbook files in that 
directory, but it is called only if index.docbook is available. Let me try with 
another fix to the documentation.


- Luigi


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127935/#review95503
---


On Mag. 16, 2016, 12:51 a.m., Luigi Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127935/
> ---
> 
> (Updated Mag. 16, 2016, 12:51 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Elvis Angelaccio.
> 
> 
> Bugs: 357428
> https://bugs.kde.org/show_bug.cgi?id=357428
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> When more documentation files are available in a certain directory, the 
> assumption is that there should always be an index.docbook which
> imports all the other docbook files in the same directory. The call to 
> kdoctools_create_handbook must be created only for index.docbook;
> the macro takes care of the installation of the others docbooks. 
> This should make kdoctools_install work when there are multiple docbooks in 
> the same directory.
> 
> 
> Diffs
> -
> 
>   KF5DocToolsMacros.cmake a0ed3a8 
> 
> Diff: https://git.reviewboard.kde.org/r/127935/diff/
> 
> 
> Testing
> ---
> 
> Tried kdoctools_install when the (translated) documentation is made of 
> multiple docbooks (like krusader), see the bug for more details.
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127935: Call kdoctools_create_handbook only for index.docbook

[Luigi Toscano]

> On Mag. 16, 2016, 11:41 a.m., Elvis Angelaccio wrote:
> > KF5DocToolsMacros.cmake, lines 47-49
> > 
> >
> > Maybe update this sentence as well? "... index.docbook is installed 
> > using KDOCTOOLS_CREATE_HANDBOOK."

Makes sense.


- Luigi


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127935/#review95503
---


On Mag. 16, 2016, 12:51 a.m., Luigi Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127935/
> ---
> 
> (Updated Mag. 16, 2016, 12:51 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Elvis Angelaccio.
> 
> 
> Bugs: 357428
> https://bugs.kde.org/show_bug.cgi?id=357428
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> When more documentation files are available in a certain directory, the 
> assumption is that there should always be an index.docbook which
> imports all the other docbook files in the same directory. The call to 
> kdoctools_create_handbook must be created only for index.docbook;
> the macro takes care of the installation of the others docbooks. 
> This should make kdoctools_install work when there are multiple docbooks in 
> the same directory.
> 
> 
> Diffs
> -
> 
>   KF5DocToolsMacros.cmake a0ed3a8 
> 
> Diff: https://git.reviewboard.kde.org/r/127935/diff/
> 
> 
> Testing
> ---
> 
> Tried kdoctools_install when the (translated) documentation is made of 
> multiple docbooks (like krusader), see the bug for more details.
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127843: Properly remove composed characters

[Jan Grulich]

> On Kvě. 7, 2016, 9:40 dop., Dominik Haumann wrote:
> > I can see that the patch works, since Qt's QTextLayout functions are used 
> > for cursor navigation.
> > 
> > I dislike the part that exposes the "currentTextLayout()", since it exposes 
> > more API (but ok, maybe we must), and it is not flexible. For instance, 
> > ktexteditor.git has a multicursor branch, and just getting the "current" 
> > text layout is not enough. Could you change it to textLayout(int line), 
> > along with a comment that the returned pointer is possibly a nullptr?
> > 
> > PS: KateViewInternal.cpp also has a KateWrappingCursor. A proper solution 
> > would be to expose this class so that proper text navigation is available 
> > everywhere (e.g. KTextEditor::ViewCursor, just like 
> > KTextEditor::DocumentCursor).
> 
> Jan Grulich wrote:
> I'm trying to expose KateWrappingCursor class, but problem is that it 
> requires access to KateViewInternal which we would still need to expose 
> instead of currentTextLayout(). Any idea how to solve that?
> 
> Dominik Haumann wrote:
> Hm, say we have KateViewCursor with the following constructor:
> 
> KTextEditor::KateViewCursor(KTextEditor::View * view);
> 
> Then, can't we qobject_cast this view to KTextEditor::ViewPrivate ? Then 
> we have access to our internal KateView and KateViewInternal.
> 
> We'd need a pimpl-class, i.e. a d-pointer to store the 
> qobject_cast(view) as a member variable.
> 
> In addition to this constructor, most of the API from 
> KTextEditor::DocumentCursor [1] and what the Wrapping cursor etc can do right 
> now.
> 
> Does that make sense / is that feasible?
> 
> [1] 
> http://api.kde.org/frameworks-api/frameworks5-apidocs/ktexteditor/html/classKTextEditor_1_1DocumentCursor.html
> 
> Jan Grulich wrote:
> It makes sense, there is just a problem again with accessing to 
> KateViewInternal from KTextEditor::ViewPrivate. KateViewInternal is stored 
> there as a private property, the only way would be to expose it instead of 
> currentTextLayout().
> 
> Jan Grulich wrote:
> Hmm, this is getting more complicated then I thought it will be. I 
> exposed KateViewInternal as I could't find another way to access it from 
> KTE::ViewPrivate, then I had to move KateViewInternal::cache() to public 
> functions to make it accessible in KTE::ViewCursor and now when trying to use 
> WrappingCursor in KTE::DocumentPrivate::del() it crashes in 
> KTE::ViewCursor::makeValid() due to calling KTE::ViewCursor::doc(). Not sure 
> I'm willing to give this more time to implement it the way you want as I 
> already spent a day with it. I'll back to it once I have some free time. 
> Thanks for your help.

In case you want to check what I have ? https://paste.kde.org/pgdlmdodm.


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127843/#review95257
---


On Kvě. 5, 2016, 10:53 dop., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127843/
> ---
> 
> (Updated Kvě. 5, 2016, 10:53 dop.)
> 
> 
> Review request for Kate, KDE Frameworks, Christoph Cullmann, and Dominik 
> Haumann.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> ---
> 
> When using Indic locales composed characters are not properly removed. 
> Pressing "delete" or "backspace" should remove the entire composed character 
> and not only one base character. You can see how it should behave when using 
> another text editor (e.g. libreoffice)
> 
> Can be tested with these words: ?? or ??? or 
> 
> Technical details:
> I'm not really sure whether exporting current text layout is the right way to 
> do this, I found that this is used when calling moveChar() which moves the 
> cursor exactly by one composed character so I was trying to find a way to do 
> it similarly.
> 
> 
> Diffs
> -
> 
>   src/document/katedocument.cpp 73778a1 
>   src/view/kateview.h 08db0df 
>   src/view/kateview.cpp fda6b2d 
> 
> Diff: https://git.reviewboard.kde.org/r/127843/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127843: Properly remove composed characters

[Jan Grulich]

> On Kvě. 7, 2016, 9:40 dop., Dominik Haumann wrote:
> > I can see that the patch works, since Qt's QTextLayout functions are used 
> > for cursor navigation.
> > 
> > I dislike the part that exposes the "currentTextLayout()", since it exposes 
> > more API (but ok, maybe we must), and it is not flexible. For instance, 
> > ktexteditor.git has a multicursor branch, and just getting the "current" 
> > text layout is not enough. Could you change it to textLayout(int line), 
> > along with a comment that the returned pointer is possibly a nullptr?
> > 
> > PS: KateViewInternal.cpp also has a KateWrappingCursor. A proper solution 
> > would be to expose this class so that proper text navigation is available 
> > everywhere (e.g. KTextEditor::ViewCursor, just like 
> > KTextEditor::DocumentCursor).
> 
> Jan Grulich wrote:
> I'm trying to expose KateWrappingCursor class, but problem is that it 
> requires access to KateViewInternal which we would still need to expose 
> instead of currentTextLayout(). Any idea how to solve that?
> 
> Dominik Haumann wrote:
> Hm, say we have KateViewCursor with the following constructor:
> 
> KTextEditor::KateViewCursor(KTextEditor::View * view);
> 
> Then, can't we qobject_cast this view to KTextEditor::ViewPrivate ? Then 
> we have access to our internal KateView and KateViewInternal.
> 
> We'd need a pimpl-class, i.e. a d-pointer to store the 
> qobject_cast(view) as a member variable.
> 
> In addition to this constructor, most of the API from 
> KTextEditor::DocumentCursor [1] and what the Wrapping cursor etc can do right 
> now.
> 
> Does that make sense / is that feasible?
> 
> [1] 
> http://api.kde.org/frameworks-api/frameworks5-apidocs/ktexteditor/html/classKTextEditor_1_1DocumentCursor.html
> 
> Jan Grulich wrote:
> It makes sense, there is just a problem again with accessing to 
> KateViewInternal from KTextEditor::ViewPrivate. KateViewInternal is stored 
> there as a private property, the only way would be to expose it instead of 
> currentTextLayout().

Hmm, this is getting more complicated then I thought it will be. I exposed 
KateViewInternal as I could't find another way to access it from 
KTE::ViewPrivate, then I had to move KateViewInternal::cache() to public 
functions to make it accessible in KTE::ViewCursor and now when trying to use 
WrappingCursor in KTE::DocumentPrivate::del() it crashes in 
KTE::ViewCursor::makeValid() due to calling KTE::ViewCursor::doc(). Not sure 
I'm willing to give this more time to implement it the way you want as I 
already spent a day with it. I'll back to it once I have some free time. Thanks 
for your help.


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127843/#review95257
---


On Kvě. 5, 2016, 10:53 dop., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127843/
> ---
> 
> (Updated Kvě. 5, 2016, 10:53 dop.)
> 
> 
> Review request for Kate, KDE Frameworks, Christoph Cullmann, and Dominik 
> Haumann.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> ---
> 
> When using Indic locales composed characters are not properly removed. 
> Pressing "delete" or "backspace" should remove the entire composed character 
> and not only one base character. You can see how it should behave when using 
> another text editor (e.g. libreoffice)
> 
> Can be tested with these words: ?? or ??? or 
> 
> Technical details:
> I'm not really sure whether exporting current text layout is the right way to 
> do this, I found that this is used when calling moveChar() which moves the 
> cursor exactly by one composed character so I was trying to find a way to do 
> it similarly.
> 
> 
> Diffs
> -
> 
>   src/document/katedocument.cpp 73778a1 
>   src/view/kateview.h 08db0df 
>   src/view/kateview.cpp fda6b2d 
> 
> Diff: https://git.reviewboard.kde.org/r/127843/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 37 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/37/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 16 May 2016 16:04:16 +
Build duration: 5 min 12 sec

CHANGE SET
Revision 75a55d449f2f070c5410e47a9529a984403c3297 by jjm: (K4TimeZoneWidget: 
correct path for flag images)
  change: edit src/kdeui/k4timezonewidget.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 
39 test(s)Failed: TestSuite.globalcleanuptest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/7 (57%)FILES 160/268 (60%)CLASSES 160/268 (60%)LINE 21694/42775 
(51%)CONDITIONAL 14666/36447 (40%)

By packages
  
autotests
FILES 63/63 (100%)CLASSES 63/63 (100%)LINE 11519/11768 
(98%)CONDITIONAL 8481/16820 (50%)
src.kdecore
FILES 75/94 (80%)CLASSES 75/94 (80%)LINE 9221/16863 
(55%)CONDITIONAL 5722/11783 (49%)
src.kdeui
FILES 18/70 (26%)CLASSES 18/70 (26%)LINE 938/9815 
(10%)CONDITIONAL 460/5673 (8%)
src.kio
FILES 4/27 (15%)CLASSES 4/27 (15%)LINE 16/2396 (1%)CONDITIONAL 
3/1226 (0%)
src.kparts
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/26 (0%)CONDITIONAL 0/14 
(0%)
src.kssl
FILES 0/8 (0%)CLASSES 0/8 (0%)LINE 0/1708 (0%)CONDITIONAL 0/836 
(0%)
src.solid
FILES 0/5 (0%)CLASSES 0/5 (0%)LINE 0/199 (0%)CONDITIONAL 0/95 
(0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127929: K4TimeZoneWidget: flag images not displayed because of incorrect path

[Jonathan Marten]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127929/
---

(Updated May 16, 2016, 6:03 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 75a55d449f2f070c5410e47a9529a984403c3297 by Jonathan 
Marten to branch master.


Repository: kdelibs4support


Description
---

In KDE4 this widget displayed the appropriate country flag at the start of the 
continent/city column.  This no longer happens because the path used to find 
the flag image files is incorrect: it is still using the old 
share/locale/l10n/CC/flag.png location.  In KF5 this is now 
share/kf5/locale/countries/CC/flag.png.  This change corrects the path and 
comment.


Diffs
-

  src/kdeui/k4timezonewidget.cpp 70ff79f 

Diff: https://git.reviewboard.kde.org/r/127929/diff/


Testing
---

Built kdelibs4support with this change, checked correct display of flag column 
in dialogue.


Thanks,

Jonathan Marten

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 44 - Still Unstable!

[Marco Martin]

On Monday 16 May 2016, David Faure wrote:
> On Saturday, May 14, 2016 10:52:16 AM CEST no-re...@kde.org wrote:
> > GENERAL INFO
> > 
> > BUILD UNSTABLE
> > Build URL:
> > https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/
> 
> PLATFORM=Linux,Variation=All,compiler=gcc/44/ Project:
> > PLATFORM=Linux,Variation=All,compiler=gcc
> > Date of build: Sat, 14 May 2016 10:44:59 +
> > Build duration: 6 min 19 sec
> > 
> > Total: 14 test(s)Failed: TestSuite.plasma-themetest
> 
> FAIL!  : ThemeTest::loadSvgIcon() 'm_svg->isValid()' returned FALSE. ()
>Loc: [/home/jenkins/sources/plasma-framework/kf5-qt5/autotests/
> themetest.cpp(77)]

this should fix it..
https://paste.kde.org/plgadpvs8

Harald, this is against your latest commit in kiconthemes, does this patch 
make sense to you?

-- 
Marco Martin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127940: Rename docs/plasmapkg directory to docs/plasmapkg2

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127940/
---

Review request for KDE Frameworks, Localization and Translation (l10n) and 
David Faure.


Repository: plasma-framework


Description
---

rename directory + adapt CMakeLists.txt file

this change is necessary to fetch translated manpage docs 
without hacks either in frameworks release script or in autogen.sh
into the frameworks tarball.

See also https://git.reviewboard.kde.org/r/127904/ for a detailed explanation

Together with commiting this change I'll adapt Scripty.


Diffs
-

  docs/CMakeLists.txt 2acc3f0 
  docs/plasmapkg/CMakeLists.txt a78d3bd 
  docs/plasmapkg/man-plasmapkg2.1.docbook 0952bd2 
  docs/plasmapkg2/CMakeLists.txt PRE-CREATION 
  docs/plasmapkg2/man-plasmapkg2.1.docbook PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127940/diff/


Testing
---

builds and installs the manpage to the same installdir as before


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

[René J . V . Bertin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126198/
---

(Updated May 16, 2016, 3:21 p.m.)


Review request for KDE Software on Mac OS X, KDE Frameworks, Plasma, and 
Valorie Zimmerman.


Changes
---

I'd been meaning for a while now to update this RR, since I wasn't getting any 
feedback on it.

Now that the platformtheme has been moved, what do you propose we do with the 
OS X platform theme?

I saw that one of the justifications for the move was a dependency on Plasma 
library/ies, but I don't see any such dependencies in the latest version before 
the move (commit 07548ac1fe7a7fb31a941473911e982fb623c07d).

It's a pity that this discussion fell into oblivion, I'd argue (or have argued) 
that
- there's sufficient reason to have a dedicated OS X platform theme because 
there are apparently no other feasible solutions to allow KF5 applications to 
benefit from KDE's font and colour palettes, regardless of whether that is with 
the native widget style (`"macintosh"`) or with another style. It should go 
without saying that applications designed with the automatic existence of 
specific fonts (and colour) palettes in mind will look better when they can use 
those fonts (and colours).
- applying this patch to `plasma-integration` to provide the Mac platform 
plugin via that package makes little sense because there's no Plasma (session) 
to integrate with. There *are* components in Plasma that make sense outside of 
Plasma sessions but they don't justify an interpretation where the 
`plasma-integration` package is for integrating Plasma with the host. Also, the 
package has dependencies on X11 and Wayland that would have to be removed on OS 
X.
- given the 2 above points, I'd suggest (have suggested) to keep the platform 
plugin where it is for OS X especially if the other components of the 
`framework-integration` framework are still relevant.

What bothers me a bit is that this move makes it much less trivial to maintain 
the Mac platform theme as a special version of the standard platform theme, 
subclassing its classes. Or maybe we can safely let the platform plugins 
diverge from this point? Would I have to revert all of my subclassing effort or 
would it be better to leave that aspect as is for the time being because it 
should make it easier to "sync" with the plasma platform theme?


Repository: frameworkintegration


Description
---

The KdePlatformTheme plugin can be enabled on OS X with a minimal patch to Qt5; 
all that is required is to include the `qgenericunixservices` and 
`qgenericunixthemes` components in the build, and to append `"kde"` to the list 
returned by `QCocoaIntegration::themeNames()` for instance under the condition 
that `KDE_SESSION_VERSION` is set to a suitable value in the environment.

This will allow KF5 and Qt5 applications to use the theme selected through KDE 
if FrameworkIntegration is installed and KDE_SESSION_VERSION is set, which 
seems like a sufficiently specific set of conditions that is easy to avoid by 
users who prefer to use the Mac native theme.

While requestion the KDE theme is also possible through `-style kde` or `env 
QT_STYLE_OVERRIDE=kde` the use of the KdePlatformTheme plugin appears to be the 
only way to get the full theme, including the font and colour selection. In my 
opinion it is above all the font customisation which is a very welcome feature 
for Qt/Mac; by default Qt applications use the default system font (Lucida 
Grande 13pt or even 14pt) throughout. This is a good UI font, but not at that 
size (and most "native" OS X applications indeed use a range of smaller sizes, 
depending on role.

It does have introduce a number of regressions, which the current patch aims to 
address. The most visible and problematic of these regressions is the loss of 
the Mac-style menu bar and thus of all menu items (actions).

The fix is straightforward : on OS X (and similarly affected platforms?), an 
instance of the native Cocoa platform theme is created through the private API, 
and used as a fallback rather than immediately falling back to the default 
implementations from `QPlatformTheme`. In addition, methods missing from (not 
overridden by) `KdePlatformTheme` are provided on OS X and call the 
corresponding methods from the native theme. It is this change which restores 
the menubar and even the Dock menu functionality.
One minor regression remains but should be easy to fix (elsewhere?): the 
Preferences menu loses its keyboard shortcut (Command-,).

Given the fallback nature of the native platform instance I have preferred to 
print a warning rather than using something like `qFatal`, above all because 
the message printed by qFatal tends to get lost on OS X. I can replace my use 
of `qWarning` with a dialog giving the choice between continuing or exiting the 
application - code

Review Request 127939: Move src/runtime/kwallet-query/doc/ to docs/

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127939/
---

Review request for KDE Frameworks, Localization and Translation (l10n) and 
David Faure.


Repository: kwallet


Description
---

move directory + adapt CMakeLists.txt files

this change is necessary to fetch translated kioslave docs 
without hacks either in frameworks release script or in autogen.sh
into the frameworks tarball.

See also https://git.reviewboard.kde.org/r/127904/ for a detailed explanation

Together with commiting this change I'll adapt Scripty.


Diffs
-

  CMakeLists.txt 4b19dd4 
  docs/CMakeLists.txt PRE-CREATION 
  docs/man-kwallet-query.1.docbook PRE-CREATION 
  docs/using.adoc PRE-CREATION 
  src/runtime/kwallet-query/CMakeLists.txt 9e02cde 
  src/runtime/kwallet-query/doc/CMakeLists.txt c4ef9c7 
  src/runtime/kwallet-query/doc/man-kwallet-query.1.docbook 1adc418 
  src/runtime/kwallet-query/doc/using.adoc e2e01e4 

Diff: https://git.reviewboard.kde.org/r/127939/diff/


Testing
---

builds and installs the man page to the same installdir as before


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127938: Rename docs/kross directory to docs/kf5kross

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127938/
---

Review request for KDE Frameworks, Localization and Translation (l10n) and 
David Faure.


Repository: kross


Description
---

rename directory + adapt CMakeLists.txt file

this change is necessary to fetch translated manpage docs 
without hacks either in frameworks release script or in autogen.sh
into the frameworks tarball.

See also https://git.reviewboard.kde.org/r/127904/ for a detailed explanation

Together with commiting this change I'll adapt Scripty.


Diffs
-

  docs/CMakeLists.txt 0b0b85e 
  docs/kf5kross/CMakeLists.txt PRE-CREATION 
  docs/kf5kross/man-kf5kross.1.docbook PRE-CREATION 
  docs/kross/CMakeLists.txt b95a444 
  docs/kross/man-kf5kross.1.docbook 0f50d79 

Diff: https://git.reviewboard.kde.org/r/127938/diff/


Testing
---

builds and installs the docs to the same installdir as before


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127843: Properly remove composed characters

[Jan Grulich]

> On Kvě. 7, 2016, 9:40 dop., Dominik Haumann wrote:
> > I can see that the patch works, since Qt's QTextLayout functions are used 
> > for cursor navigation.
> > 
> > I dislike the part that exposes the "currentTextLayout()", since it exposes 
> > more API (but ok, maybe we must), and it is not flexible. For instance, 
> > ktexteditor.git has a multicursor branch, and just getting the "current" 
> > text layout is not enough. Could you change it to textLayout(int line), 
> > along with a comment that the returned pointer is possibly a nullptr?
> > 
> > PS: KateViewInternal.cpp also has a KateWrappingCursor. A proper solution 
> > would be to expose this class so that proper text navigation is available 
> > everywhere (e.g. KTextEditor::ViewCursor, just like 
> > KTextEditor::DocumentCursor).
> 
> Jan Grulich wrote:
> I'm trying to expose KateWrappingCursor class, but problem is that it 
> requires access to KateViewInternal which we would still need to expose 
> instead of currentTextLayout(). Any idea how to solve that?
> 
> Dominik Haumann wrote:
> Hm, say we have KateViewCursor with the following constructor:
> 
> KTextEditor::KateViewCursor(KTextEditor::View * view);
> 
> Then, can't we qobject_cast this view to KTextEditor::ViewPrivate ? Then 
> we have access to our internal KateView and KateViewInternal.
> 
> We'd need a pimpl-class, i.e. a d-pointer to store the 
> qobject_cast(view) as a member variable.
> 
> In addition to this constructor, most of the API from 
> KTextEditor::DocumentCursor [1] and what the Wrapping cursor etc can do right 
> now.
> 
> Does that make sense / is that feasible?
> 
> [1] 
> http://api.kde.org/frameworks-api/frameworks5-apidocs/ktexteditor/html/classKTextEditor_1_1DocumentCursor.html

It makes sense, there is just a problem again with accessing to 
KateViewInternal from KTextEditor::ViewPrivate. KateViewInternal is stored 
there as a private property, the only way would be to expose it instead of 
currentTextLayout().


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127843/#review95257
---


On Kvě. 5, 2016, 10:53 dop., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127843/
> ---
> 
> (Updated Kvě. 5, 2016, 10:53 dop.)
> 
> 
> Review request for Kate, KDE Frameworks, Christoph Cullmann, and Dominik 
> Haumann.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> ---
> 
> When using Indic locales composed characters are not properly removed. 
> Pressing "delete" or "backspace" should remove the entire composed character 
> and not only one base character. You can see how it should behave when using 
> another text editor (e.g. libreoffice)
> 
> Can be tested with these words: ?? or ??? or 
> 
> Technical details:
> I'm not really sure whether exporting current text layout is the right way to 
> do this, I found that this is used when calling moveChar() which moves the 
> cursor exactly by one composed character so I was trying to find a way to do 
> it similarly.
> 
> 
> Diffs
> -
> 
>   src/document/katedocument.cpp 73778a1 
>   src/view/kateview.h 08db0df 
>   src/view/kateview.cpp fda6b2d 
> 
> Diff: https://git.reviewboard.kde.org/r/127843/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127934: Rename docs/kjsembed directory to docs/kjsembed5

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127934/
---

(Updated May 16, 2016, 11:32 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Localization and Translation (l10n) and 
David Faure.


Changes
---

Submitted with commit cdaef1ada478e465ce959039ed46e09d3975acad by Burkhard Lück 
to branch master.


Repository: kjsembed


Description
---

rename directory + adapt CMakeLists.txt file

this change is necessary to fetch translated kioslave docs 
without hacks either in frameworks release script or in autogen.sh
into the frameworks tarball.

See also https://git.reviewboard.kde.org/r/127904/ for a detailed explanation

Together with commiting this change I'll adapt Scripty.


Diffs
-

  docs/CMakeLists.txt c4df5bd 
  docs/kjscmd/CMakeLists.txt 993b2bc 
  docs/kjscmd/man-kjscmd5.1.docbook 2c8c1b6 
  docs/kjscmd5/CMakeLists.txt PRE-CREATION 
  docs/kjscmd5/man-kjscmd5.1.docbook PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127934/diff/


Testing
---

builds and installs the docs to the same installdir as before


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127933: Rename docs/kjs directory to docs/kjs5

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127933/
---

(Updated May 16, 2016, 11:26 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Localization and Translation (l10n) and 
David Faure.


Changes
---

Submitted with commit 58577a3851f7aa005dcc47215a155ce35a01458a by Burkhard Lück 
to branch master.


Repository: kjs


Description
---

rename directory + adapt CMakeLists.txt file

this change is necessary to fetch translated kioslave docs 
without hacks either in frameworks release script or in autogen.sh
into the frameworks tarball.

See also https://git.reviewboard.kde.org/r/127904/ for a detailed explanation

Together with commiting this change I'll adapt Scripty.


Diffs
-

  docs/CMakeLists.txt 0fa6c95 
  docs/kjs/CMakeLists.txt 14ed344 
  docs/kjs/man-kjs5.1.docbook f2e5d83 
  docs/kjs5/CMakeLists.txt PRE-CREATION 
  docs/kjs5/man-kjs5.1.docbook PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127933/diff/


Testing
---

builds and installs the kcm docs to the same installdir as before


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 44 - Still Unstable!

[Marco Martin]

On Monday 16 May 2016, David Faure wrote:
> 
> Can someone take a look? Can more precise checks be added before the
> QVERIFY to ease debugging when this fails?
> At least a QVERIFY2(QFile::exists(iconPath), qPrintable(iconPath)) would be
> good, right? But what if iconTheme is null? Then for sure iconPath is
> empty...

from the last version, iconTheme is there, the iconTheme is valid as well, but 
iconPath is empty

-- 
Marco Martin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 45 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/45/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 16 May 2016 10:49:08 +
Build duration: 2 min 13 sec

CHANGE SET
Revision 5405a97a708589582495a1a28ca6e7c41f087ff6 by Marco Martin: (add some 
more tests to debug what's going wrong)
  change: edit autotests/themetest.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 
13 test(s)Failed: TestSuite.plasma-themetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 8/8 (100%)FILES 74/111 (67%)CLASSES 74/111 (67%)LINE 4380/11236 
(39%)CONDITIONAL 2262/8321 (27%)

By packages
  
autotests
FILES 24/24 (100%)CLASSES 24/24 (100%)LINE 871/927 
(94%)CONDITIONAL 564/1104 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 545/1847 
(30%)CONDITIONAL 202/1132 (18%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1675/3624 
(46%)CONDITIONAL 939/2716 (35%)
src.plasma.private
FILES 15/24 (63%)CLASSES 15/24 (63%)LINE 910/1721 
(53%)CONDITIONAL 402/1006 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 37/181 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 300/1671 
(18%)CONDITIONAL 133/1277 (10%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1152 (1%)CONDITIONAL 
2/958 (0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 45 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/45/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 16 May 2016 10:49:08 +
Build duration: 2 min 40 sec

CHANGE SET
Revision 5405a97a708589582495a1a28ca6e7c41f087ff6 by Marco Martin: (add some 
more tests to debug what's going wrong)
  change: edit autotests/themetest.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 
14 test(s)Failed: TestSuite.plasma-themetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 8/8 (100%)FILES 77/115 (67%)CLASSES 77/115 (67%)LINE 4807/11703 
(41%)CONDITIONAL 2549/8671 (29%)

By packages
  
autotests
FILES 26/26 (100%)CLASSES 26/26 (100%)LINE 920/974 
(94%)CONDITIONAL 580/1136 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 635/2071 
(31%)CONDITIONAL 288/1278 (23%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1677/3624 
(46%)CONDITIONAL 944/2716 (35%)
src.plasma.private
FILES 16/26 (62%)CLASSES 16/26 (62%)LINE 954/1794 
(53%)CONDITIONAL 423/1052 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 37/181 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 542/1794 
(30%)CONDITIONAL 292/1403 (21%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1152 (1%)CONDITIONAL 
2/958 (0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 46 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/46/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 16 May 2016 10:49:08 +
Build duration: 2 min 36 sec

CHANGE SET
Revision 5405a97a708589582495a1a28ca6e7c41f087ff6 by Marco Martin: (add some 
more tests to debug what's going wrong)
  change: edit autotests/themetest.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 
13 test(s)Failed: TestSuite.plasma-themetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 8/8 (100%)FILES 74/111 (67%)CLASSES 74/111 (67%)LINE 4381/11236 
(39%)CONDITIONAL 2262/8321 (27%)

By packages
  
autotests
FILES 24/24 (100%)CLASSES 24/24 (100%)LINE 872/927 
(94%)CONDITIONAL 563/1104 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 545/1847 
(30%)CONDITIONAL 202/1132 (18%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1675/3624 
(46%)CONDITIONAL 939/2716 (35%)
src.plasma.private
FILES 15/24 (63%)CLASSES 15/24 (63%)LINE 910/1721 
(53%)CONDITIONAL 403/1006 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 37/181 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 300/1671 
(18%)CONDITIONAL 133/1277 (10%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1152 (1%)CONDITIONAL 
2/958 (0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 46 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/46/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 16 May 2016 10:49:08 +
Build duration: 2 min 36 sec

CHANGE SET
Revision 5405a97a708589582495a1a28ca6e7c41f087ff6 by Marco Martin: (add some 
more tests to debug what's going wrong)
  change: edit autotests/themetest.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 
14 test(s)Failed: TestSuite.plasma-themetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 8/8 (100%)FILES 77/115 (67%)CLASSES 77/115 (67%)LINE 4804/11703 
(41%)CONDITIONAL 2549/8671 (29%)

By packages
  
autotests
FILES 26/26 (100%)CLASSES 26/26 (100%)LINE 920/974 
(94%)CONDITIONAL 580/1136 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 635/2071 
(31%)CONDITIONAL 288/1278 (23%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1677/3624 
(46%)CONDITIONAL 944/2716 (35%)
src.plasma.private
FILES 16/26 (62%)CLASSES 16/26 (62%)LINE 954/1794 
(53%)CONDITIONAL 423/1052 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 37/181 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 539/1794 
(30%)CONDITIONAL 292/1403 (21%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1152 (1%)CONDITIONAL 
2/958 (0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 44 - Still Unstable!

[Marco Martin]

On Monday 16 May 2016, David Faure wrote:
> Can someone take a look? Can more precise checks be added before the
> QVERIFY to ease debugging when this fails?
> At least a QVERIFY2(QFile::exists(iconPath), qPrintable(iconPath)) would be
> good, right? But what if iconTheme is null? Then for sure iconPath is
> empty...

added some more tests, let's see what they say

-- 
Marco Martin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: khtml master stable-kf5-qt5 » Linux,gcc - Build # 31 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/khtml%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/31/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 16 May 2016 10:26:47 +
Build duration: 5 min 49 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 19/23 (83%)FILES 308/626 (49%)CLASSES 308/626 (49%)LINE 3032/94700 
(3%)CONDITIONAL 2863/153112 (2%)

By packages
  

FILES 2/8 (25%)CLASSES 2/8 (25%)LINE 2/593 (0%)CONDITIONAL 
4/684 (1%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 53/57 (93%)CONDITIONAL 
27/56 (48%)
src
FILES 20/31 (65%)CLASSES 20/31 (65%)LINE 931/8839 
(11%)CONDITIONAL 841/18936 (4%)
src.css
FILES 12/25 (48%)CLASSES 12/25 (48%)LINE 32/9318 
(0%)CONDITIONAL 32/15725 (0%)
src.dom
FILES 29/40 (73%)CLASSES 29/40 (73%)LINE 61/7091 
(1%)CONDITIONAL 66/4900 (1%)
src.ecma
FILES 24/50 (48%)CLASSES 24/50 (48%)LINE 27/8351 
(0%)CONDITIONAL 47/19839 (0%)
src.editing
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 20/2100 (1%)CONDITIONAL 
11/4077 (0%)
src.html
FILES 21/47 (45%)CLASSES 21/47 (45%)LINE 21/10643 
(0%)CONDITIONAL 42/16219 (0%)
src.imload
FILES 4/31 (13%)CLASSES 4/31 (13%)LINE 24/854 (3%)CONDITIONAL 
14/651 (2%)
src.imload.decoders
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 19/616 (3%)CONDITIONAL 
10/700 (1%)
src.misc
FILES 13/27 (48%)CLASSES 13/27 (48%)LINE 837/3716 
(23%)CONDITIONAL 708/5342 (13%)
src.platform
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/2 (0%)CONDITIONAL 0/0 
(100%)
src.platform.graphics
FILES 0/16 (0%)CLASSES 0/16 (0%)LINE 0/534 (0%)CONDITIONAL 
0/308 (0%)
src.platform.graphics.qt
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/248 (0%)CONDITIONAL 0/176 
(0%)
src.platform.text
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/7 (0%)CONDITIONAL 0/4 (0%)
src.rendering
FILES 48/97 (49%)CLASSES 48/97 (49%)LINE 64/23897 
(0%)CONDITIONAL 95/33152 (0%)
src.svg
FILES 72/147 (49%)CLASSES 72/147 (49%)LINE 746/5897 
(13%)CONDITIONAL 816/14593 (6%)
src.svg.graphics
FILES 7/14 (50%)CLASSES 7/14 (50%)LINE 7/283 (2%)CONDITIONAL 
14/344 (4%)
src.svg.graphics.qt
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 6/156 (4%)CONDITIONAL 
12/329 (4%)
src.ui.findbar
FILES 2/4 (50%)CLASSES 2/4 (50%)LINE 21/505 (4%)CONDITIONAL 
8/914 (1%)
src.ui.passwordbar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 28/60 (47%)CONDITIONAL 
39/106 (37%)
src.xml
FILES 20/38 (53%)CLASSES 20/38 (53%)LINE 116/9560 
(1%)CONDITIONAL 59/13299 (0%)
src.xpath
FILES 9/15 (60%)CLASSES 9/15 (60%)LINE 17/1373 (1%)CONDITIONAL 
18/2758 (1%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: khtml master stable-kf5-qt5 » Linux,gcc - Build # 31 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/khtml%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/31/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 16 May 2016 10:26:47 +
Build duration: 5 min 49 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 19/23 (83%)FILES 308/626 (49%)CLASSES 308/626 (49%)LINE 3032/94700 
(3%)CONDITIONAL 2863/153112 (2%)

By packages
  

FILES 2/8 (25%)CLASSES 2/8 (25%)LINE 2/593 (0%)CONDITIONAL 
4/684 (1%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 53/57 (93%)CONDITIONAL 
27/56 (48%)
src
FILES 20/31 (65%)CLASSES 20/31 (65%)LINE 931/8839 
(11%)CONDITIONAL 841/18936 (4%)
src.css
FILES 12/25 (48%)CLASSES 12/25 (48%)LINE 32/9318 
(0%)CONDITIONAL 32/15725 (0%)
src.dom
FILES 29/40 (73%)CLASSES 29/40 (73%)LINE 61/7091 
(1%)CONDITIONAL 66/4900 (1%)
src.ecma
FILES 24/50 (48%)CLASSES 24/50 (48%)LINE 27/8351 
(0%)CONDITIONAL 47/19839 (0%)
src.editing
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 20/2100 (1%)CONDITIONAL 
11/4077 (0%)
src.html
FILES 21/47 (45%)CLASSES 21/47 (45%)LINE 21/10643 
(0%)CONDITIONAL 42/16219 (0%)
src.imload
FILES 4/31 (13%)CLASSES 4/31 (13%)LINE 24/854 (3%)CONDITIONAL 
14/651 (2%)
src.imload.decoders
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 19/616 (3%)CONDITIONAL 
10/700 (1%)
src.misc
FILES 13/27 (48%)CLASSES 13/27 (48%)LINE 837/3716 
(23%)CONDITIONAL 708/5342 (13%)
src.platform
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/2 (0%)CONDITIONAL 0/0 
(100%)
src.platform.graphics
FILES 0/16 (0%)CLASSES 0/16 (0%)LINE 0/534 (0%)CONDITIONAL 
0/308 (0%)
src.platform.graphics.qt
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/248 (0%)CONDITIONAL 0/176 
(0%)
src.platform.text
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/7 (0%)CONDITIONAL 0/4 (0%)
src.rendering
FILES 48/97 (49%)CLASSES 48/97 (49%)LINE 64/23897 
(0%)CONDITIONAL 95/33152 (0%)
src.svg
FILES 72/147 (49%)CLASSES 72/147 (49%)LINE 746/5897 
(13%)CONDITIONAL 816/14593 (6%)
src.svg.graphics
FILES 7/14 (50%)CLASSES 7/14 (50%)LINE 7/283 (2%)CONDITIONAL 
14/344 (4%)
src.svg.graphics.qt
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 6/156 (4%)CONDITIONAL 
12/329 (4%)
src.ui.findbar
FILES 2/4 (50%)CLASSES 2/4 (50%)LINE 21/505 (4%)CONDITIONAL 
8/914 (1%)
src.ui.passwordbar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 28/60 (47%)CONDITIONAL 
39/106 (37%)
src.xml
FILES 20/38 (53%)CLASSES 20/38 (53%)LINE 116/9560 
(1%)CONDITIONAL 59/13299 (0%)
src.xpath
FILES 9/15 (60%)CLASSES 9/15 (60%)LINE 17/1373 (1%)CONDITIONAL 
18/2758 (1%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux, All, gcc - Build # 44 - Still Unstable!

[David Faure]

On Saturday, May 14, 2016 10:52:16 AM CEST no-re...@kde.org wrote:
> GENERAL INFO
> 
> BUILD UNSTABLE
> Build URL:
> https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/
PLATFORM=Linux,Variation=All,compiler=gcc/44/ Project:
> PLATFORM=Linux,Variation=All,compiler=gcc
> Date of build: Sat, 14 May 2016 10:44:59 +
> Build duration: 6 min 19 sec
> 
> Total: 14 test(s)Failed: TestSuite.plasma-themetest


FAIL!  : ThemeTest::loadSvgIcon() 'm_svg->isValid()' returned FALSE. ()
   Loc: [/home/jenkins/sources/plasma-framework/kf5-qt5/autotests/
themetest.cpp(77)]

Can someone take a look? Can more precise checks be added before the QVERIFY
to ease debugging when this fails?
At least a QVERIFY2(QFile::exists(iconPath), qPrintable(iconPath)) would be 
good, right? But what if iconTheme is null? Then for sure iconPath is empty...



void ThemeTest::loadSvgIcon()
{
const auto *iconTheme = KIconLoader::global()->theme();
QString iconPath;
if (iconTheme) {
iconPath = iconTheme->iconPath(QLatin1String("konversation.svg"), 48, 
KIconLoader::MatchBest);
}

m_svg->setImagePath(iconPath);
QVERIFY(m_svg->isValid());



-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127865: Check size of unix domain socket path before copying to it.

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127865/#review95506
---


Ship it!




Ship It!

- Albert Astals Cid


On May 8, 2016, 2:03 a.m., Michael Pyne wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127865/
> ---
> 
> (Updated May 8, 2016, 2:03 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcrash
> 
> 
> Description
> ---
> 
> Although we don't seem to run across this in practice, Coverity warns about 
> filling in sockaddr_un::sun_path's buffer without checking the source 
> string's length (CID 1175514), and the Linux unix(7) manpage notes that some 
> implementations use as few as 92 bytes for this buffer.
> 
> 
> Diffs
> -
> 
>   src/kcrash.cpp 7d3b8a2 
> 
> Diff: https://git.reviewboard.kde.org/r/127865/diff/
> 
> 
> Testing
> ---
> 
> Compiles w/out warnings, kcrashtest passes.
> 
> 
> Thanks,
> 
> Michael Pyne
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 42 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/42/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 16 May 2016 10:17:46 +
Build duration: 2 min 41 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5445/7982 
(68%)CONDITIONAL 2952/6142 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1429/1528 
(94%)CONDITIONAL 887/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1761/3042 
(58%)CONDITIONAL 756/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2039/2799 
(73%)CONDITIONAL 1224/2058 (59%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: khtml master kf5-qt5 » Linux,gcc - Build # 33 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/khtml%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/33/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 16 May 2016 10:17:11 +
Build duration: 6 min 0 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 19/23 (83%)FILES 308/626 (49%)CLASSES 308/626 (49%)LINE 3032/94700 
(3%)CONDITIONAL 2853/152334 (2%)

By packages
  

FILES 2/8 (25%)CLASSES 2/8 (25%)LINE 2/593 (0%)CONDITIONAL 
4/684 (1%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 53/57 (93%)CONDITIONAL 
27/56 (48%)
src
FILES 20/31 (65%)CLASSES 20/31 (65%)LINE 931/8839 
(11%)CONDITIONAL 832/18732 (4%)
src.css
FILES 12/25 (48%)CLASSES 12/25 (48%)LINE 32/9318 
(0%)CONDITIONAL 32/15629 (0%)
src.dom
FILES 29/40 (73%)CLASSES 29/40 (73%)LINE 61/7091 
(1%)CONDITIONAL 66/4880 (1%)
src.ecma
FILES 24/50 (48%)CLASSES 24/50 (48%)LINE 27/8351 
(0%)CONDITIONAL 47/19781 (0%)
src.editing
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 20/2100 (1%)CONDITIONAL 
11/4037 (0%)
src.html
FILES 21/47 (45%)CLASSES 21/47 (45%)LINE 21/10643 
(0%)CONDITIONAL 42/16139 (0%)
src.imload
FILES 4/31 (13%)CLASSES 4/31 (13%)LINE 24/854 (3%)CONDITIONAL 
14/641 (2%)
src.imload.decoders
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 19/616 (3%)CONDITIONAL 
10/692 (1%)
src.misc
FILES 13/27 (48%)CLASSES 13/27 (48%)LINE 837/3716 
(23%)CONDITIONAL 707/5318 (13%)
src.platform
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/2 (0%)CONDITIONAL 0/0 
(100%)
src.platform.graphics
FILES 0/16 (0%)CLASSES 0/16 (0%)LINE 0/534 (0%)CONDITIONAL 
0/308 (0%)
src.platform.graphics.qt
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/248 (0%)CONDITIONAL 0/176 
(0%)
src.platform.text
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/7 (0%)CONDITIONAL 0/4 (0%)
src.rendering
FILES 48/97 (49%)CLASSES 48/97 (49%)LINE 64/23897 
(0%)CONDITIONAL 95/32984 (0%)
src.svg
FILES 72/147 (49%)CLASSES 72/147 (49%)LINE 746/5897 
(13%)CONDITIONAL 816/14593 (6%)
src.svg.graphics
FILES 7/14 (50%)CLASSES 7/14 (50%)LINE 7/283 (2%)CONDITIONAL 
14/344 (4%)
src.svg.graphics.qt
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 6/156 (4%)CONDITIONAL 
12/329 (4%)
src.ui.findbar
FILES 2/4 (50%)CLASSES 2/4 (50%)LINE 21/505 (4%)CONDITIONAL 
8/910 (1%)
src.ui.passwordbar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 28/60 (47%)CONDITIONAL 
39/106 (37%)
src.xml
FILES 20/38 (53%)CLASSES 20/38 (53%)LINE 116/9560 
(1%)CONDITIONAL 59/13239 (0%)
src.xpath
FILES 9/15 (60%)CLASSES 9/15 (60%)LINE 17/1373 (1%)CONDITIONAL 
18/2752 (1%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: khtml master kf5-qt5 » Linux,gcc - Build # 33 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/khtml%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/33/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 16 May 2016 10:17:11 +
Build duration: 6 min 0 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 19/23 (83%)FILES 308/626 (49%)CLASSES 308/626 (49%)LINE 3032/94700 
(3%)CONDITIONAL 2853/152334 (2%)

By packages
  

FILES 2/8 (25%)CLASSES 2/8 (25%)LINE 2/593 (0%)CONDITIONAL 
4/684 (1%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 53/57 (93%)CONDITIONAL 
27/56 (48%)
src
FILES 20/31 (65%)CLASSES 20/31 (65%)LINE 931/8839 
(11%)CONDITIONAL 832/18732 (4%)
src.css
FILES 12/25 (48%)CLASSES 12/25 (48%)LINE 32/9318 
(0%)CONDITIONAL 32/15629 (0%)
src.dom
FILES 29/40 (73%)CLASSES 29/40 (73%)LINE 61/7091 
(1%)CONDITIONAL 66/4880 (1%)
src.ecma
FILES 24/50 (48%)CLASSES 24/50 (48%)LINE 27/8351 
(0%)CONDITIONAL 47/19781 (0%)
src.editing
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 20/2100 (1%)CONDITIONAL 
11/4037 (0%)
src.html
FILES 21/47 (45%)CLASSES 21/47 (45%)LINE 21/10643 
(0%)CONDITIONAL 42/16139 (0%)
src.imload
FILES 4/31 (13%)CLASSES 4/31 (13%)LINE 24/854 (3%)CONDITIONAL 
14/641 (2%)
src.imload.decoders
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 19/616 (3%)CONDITIONAL 
10/692 (1%)
src.misc
FILES 13/27 (48%)CLASSES 13/27 (48%)LINE 837/3716 
(23%)CONDITIONAL 707/5318 (13%)
src.platform
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/2 (0%)CONDITIONAL 0/0 
(100%)
src.platform.graphics
FILES 0/16 (0%)CLASSES 0/16 (0%)LINE 0/534 (0%)CONDITIONAL 
0/308 (0%)
src.platform.graphics.qt
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/248 (0%)CONDITIONAL 0/176 
(0%)
src.platform.text
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/7 (0%)CONDITIONAL 0/4 (0%)
src.rendering
FILES 48/97 (49%)CLASSES 48/97 (49%)LINE 64/23897 
(0%)CONDITIONAL 95/32984 (0%)
src.svg
FILES 72/147 (49%)CLASSES 72/147 (49%)LINE 746/5897 
(13%)CONDITIONAL 816/14593 (6%)
src.svg.graphics
FILES 7/14 (50%)CLASSES 7/14 (50%)LINE 7/283 (2%)CONDITIONAL 
14/344 (4%)
src.svg.graphics.qt
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 6/156 (4%)CONDITIONAL 
12/329 (4%)
src.ui.findbar
FILES 2/4 (50%)CLASSES 2/4 (50%)LINE 21/505 (4%)CONDITIONAL 
8/910 (1%)
src.ui.passwordbar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 28/60 (47%)CONDITIONAL 
39/106 (37%)
src.xml
FILES 20/38 (53%)CLASSES 20/38 (53%)LINE 116/9560 
(1%)CONDITIONAL 59/13239 (0%)
src.xpath
FILES 9/15 (60%)CLASSES 9/15 (60%)LINE 17/1373 (1%)CONDITIONAL 
18/2752 (1%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127929: K4TimeZoneWidget: flag images not displayed because of incorrect path

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127929/#review95505
---


Ship it!




Ship It!

- Albert Astals Cid


On May 15, 2016, 1:59 p.m., Jonathan Marten wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127929/
> ---
> 
> (Updated May 15, 2016, 1:59 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> ---
> 
> In KDE4 this widget displayed the appropriate country flag at the start of 
> the continent/city column.  This no longer happens because the path used to 
> find the flag image files is incorrect: it is still using the old 
> share/locale/l10n/CC/flag.png location.  In KF5 this is now 
> share/kf5/locale/countries/CC/flag.png.  This change corrects the path and 
> comment.
> 
> 
> Diffs
> -
> 
>   src/kdeui/k4timezonewidget.cpp 70ff79f 
> 
> Diff: https://git.reviewboard.kde.org/r/127929/diff/
> 
> 
> Testing
> ---
> 
> Built kdelibs4support with this change, checked correct display of flag 
> column in dialogue.
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127935: Call kdoctools_create_handbook only for index.docbook

[Elvis Angelaccio]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127935/#review95503
---




KF5DocToolsMacros.cmake (lines 47 - 49)


Maybe update this sentence as well? "... index.docbook is installed using 
KDOCTOOLS_CREATE_HANDBOOK."


- Elvis Angelaccio


On May 15, 2016, 10:51 p.m., Luigi Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127935/
> ---
> 
> (Updated May 15, 2016, 10:51 p.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Elvis Angelaccio.
> 
> 
> Bugs: 357428
> https://bugs.kde.org/show_bug.cgi?id=357428
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> When more documentation files are available in a certain directory, the 
> assumption is that there should always be an index.docbook which
> imports all the other docbook files in the same directory. The call to 
> kdoctools_create_handbook must be created only for index.docbook;
> the macro takes care of the installation of the others docbooks. 
> This should make kdoctools_install work when there are multiple docbooks in 
> the same directory.
> 
> 
> Diffs
> -
> 
>   KF5DocToolsMacros.cmake a0ed3a8 
> 
> Diff: https://git.reviewboard.kde.org/r/127935/diff/
> 
> 
> Testing
> ---
> 
> Tried kdoctools_install when the (translated) documentation is made of 
> multiple docbooks (like krusader), see the bug for more details.
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127897: Update documentation of kdoctools_install macro

[Elvis Angelaccio]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127897/
---

(Updated May 16, 2016, 9:26 a.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation, KDE Frameworks and Luigi Toscano.


Changes
---

Submitted with commit 27c62561ffbc36e69fb34f657b92c5d88e70dc16 by Elvis 
Angelaccio to branch master.


Repository: kdoctools


Description
---

The macro will not work if the folders structure is `//docs`, so 
its documentation should be updated to the `//docs/` 
structure instead.


Diffs
-

  KF5DocToolsMacros.cmake a0ed3a8281266dcfdc95727184df851b3455cbf1 

Diff: https://git.reviewboard.kde.org/r/127897/diff/


Testing
---


Thanks,

Elvis Angelaccio

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127875: Selected state concept for icons

[Marco Martin]

> On May 15, 2016, 7:26 p.m., David Faure wrote:
> > src/kiconloader.cpp, line 820
> > 
> >
> > Could q->theme() be NULL here in some cases?
> > See 
> > https://build.kde.org/job/khtml%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/32/testReport/(root)/TestSuite/khtml_parttest/

added a check on the pointer


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127875/#review95492
---


On May 13, 2016, 9:46 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127875/
> ---
> 
> (Updated May 13, 2016, 9:46 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> ---
> 
> QIcon has a Selected state that wasn't mapped to KIcon, use it and in case 
> for svg based icons that take colors from the palette take the 
> highlightedText color from the palette to color the icon instead of the text 
> color, making it possible for styles to have white icons and white text in 
> selected menu items (need explicit support from the style, patches in breeze 
> and the like coming)
> 
> 
> Diffs
> -
> 
>   src/kiconengine.cpp 7c72ade 
>   src/kiconloader.h cf2f58a 
>   src/kiconloader.cpp 01d0a8d 
> 
> Diff: https://git.reviewboard.kde.org/r/127875/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> menu.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/05/09/0fb9a44c-8db4-4a10-91e7-1a6a36e41f62__menu.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127843: Properly remove composed characters

[Dominik Haumann]

> On May 7, 2016, 9:40 a.m., Dominik Haumann wrote:
> > I can see that the patch works, since Qt's QTextLayout functions are used 
> > for cursor navigation.
> > 
> > I dislike the part that exposes the "currentTextLayout()", since it exposes 
> > more API (but ok, maybe we must), and it is not flexible. For instance, 
> > ktexteditor.git has a multicursor branch, and just getting the "current" 
> > text layout is not enough. Could you change it to textLayout(int line), 
> > along with a comment that the returned pointer is possibly a nullptr?
> > 
> > PS: KateViewInternal.cpp also has a KateWrappingCursor. A proper solution 
> > would be to expose this class so that proper text navigation is available 
> > everywhere (e.g. KTextEditor::ViewCursor, just like 
> > KTextEditor::DocumentCursor).
> 
> Jan Grulich wrote:
> I'm trying to expose KateWrappingCursor class, but problem is that it 
> requires access to KateViewInternal which we would still need to expose 
> instead of currentTextLayout(). Any idea how to solve that?

Hm, say we have KateViewCursor with the following constructor:

KTextEditor::KateViewCursor(KTextEditor::View * view);

Then, can't we qobject_cast this view to KTextEditor::ViewPrivate ? Then we 
have access to our internal KateView and KateViewInternal.

We'd need a pimpl-class, i.e. a d-pointer to store the 
qobject_cast(view) as a member variable.

In addition to this constructor, most of the API from 
KTextEditor::DocumentCursor [1] and what the Wrapping cursor etc can do right 
now.

Does that make sense / is that feasible?

[1] 
http://api.kde.org/frameworks-api/frameworks5-apidocs/ktexteditor/html/classKTextEditor_1_1DocumentCursor.html


- Dominik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127843/#review95257
---


On May 5, 2016, 10:53 a.m., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127843/
> ---
> 
> (Updated May 5, 2016, 10:53 a.m.)
> 
> 
> Review request for Kate, KDE Frameworks, Christoph Cullmann, and Dominik 
> Haumann.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> ---
> 
> When using Indic locales composed characters are not properly removed. 
> Pressing "delete" or "backspace" should remove the entire composed character 
> and not only one base character. You can see how it should behave when using 
> another text editor (e.g. libreoffice)
> 
> Can be tested with these words: ?? or ??? or 
> 
> Technical details:
> I'm not really sure whether exporting current text layout is the right way to 
> do this, I found that this is used when calling moveChar() which moves the 
> cursor exactly by one composed character so I was trying to find a way to do 
> it similarly.
> 
> 
> Diffs
> -
> 
>   src/document/katedocument.cpp 73778a1 
>   src/view/kateview.h 08db0df 
>   src/view/kateview.cpp fda6b2d 
> 
> Diff: https://git.reviewboard.kde.org/r/127843/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Taking over KRunner maintainership

[David Faure]

On vendredi 15 avril 2016 00:13:33 CEST Kai Uwe Broulik wrote:
> Hi all,
> 
> as was already briefly mentioned in the Plasma hangout this Monday Vishesh
> asked me to take over maintainership of KRunner and I'm willing to accept.
> 
> While I am not confident to have the skills required to really move forward
> KRunner's architecture (cf. Sprinter) I had already been the de-facto
> maintainer for the past few months and massively improved on the UX and
> fixing a share of the bug pile it has collected over the years.

Great.

I just created the frameworks-krunner bugzilla product (this was the last one 
that was missing, apart from frameworks-kapidox) and made you the default 
assignnee.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127911: Add a CMake option to build binary Qt resource out of icons dir.

[Kåre Särs]

> On May 15, 2016, 5:03 p.m., Kåre Särs wrote:
> > Looks good :) A couple of questions:
> > 
> > - If we create the .rcc do we also want to install the icons?
> > - I creates a similar solution for Kate on Windows (in a separate repo), 
> > but I needed to add a program to replace the symlinked files with aliases 
> > in the .qrc as symlinks do not work properly on windows. Are you interested 
> > in adding a similar program/script/... to do the same directly in 
> > breeze-icons.git? My application is in 
> > git://anongit.kde.org/scratch/sars/kate-windows.git (icon-rcc)
> 
> Gleb Popov wrote:
> > If we create the .rcc do we also want to install the icons?
> 
> No idea, to be honest.
> 
> > I creates a similar solution for Kate on Windows (in a separate repo), 
> but I needed to add a program to replace the symlinked files with aliases in 
> the .qrc as symlinks do not work properly on windows
> 
> Sorry, what symlinks? I saw some symlinks stuff in autotests, but didn't 
> get what it is all about.

Quite a lot of icons in breeze-icons are just symbolic links to other icons in 
the repository. On Linux/OSX/Android/... this is not a problem, but on Windows, 
where you don't have proper symbolic links, git just creates a text file with 
the path to the target file. With those text files you just don't get an icon 
:( So my solution was to create an application to modify the .qrc file add an 
alias to the target file in stead of using the symbolic link file directly.

Don't let this comment be in the way of committing this RR :)


- Kåre


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127911/#review95485
---


On May 16, 2016, 6:21 a.m., Gleb Popov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127911/
> ---
> 
> (Updated May 16, 2016, 6:21 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> ---
> 
> I copied icons into the binary dir, because i haven't found a way to generate 
> rcc without polluting source dir.
> 
> Not sure if installation dir is right, too.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 2147705 
>   icons-dark/CMakeLists.txt 36d37f1 
>   icons/CMakeLists.txt 5ded49c 
> 
> Diff: https://git.reviewboard.kde.org/r/127911/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel