date:20160519

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2016-05-19 Thread René J . V . Bertin



> On May 17, 2016, 4:37 p.m., Martin Gräßlin wrote:
> > given that Plasma integration got removed I suggest to create a dedicated 
> > osx-integration repository for it as well.
> 
> René J.V. Bertin wrote:
> I quite like the way things are, but yes, I've played with that idea. 
> 
> I guess I can simply fork `frameworkintegration`, change the project name 
> in the toplevel CMake file and strip everything except for the platformtheme.
> 
> How does this work from that point onwards?
> 
> Martin Gräßlin wrote:
> > I guess I can simply fork frameworkintegration, change the project name 
> in the toplevel CMake file and strip everything except for the platformtheme.
> 
> That's kind of how I did it for plasma-integration with git filter-tree.
> 
> > How does this work from that point onwards?
> 
> My suggestion would be to create something like an "OSX integration" 
> project in the metadata and have then all your repositories grouped there 
> including the new platform theme.

This is something I'm completely new to; what metadata are we talking about 
here?
Also, can anyone with commit access to existing repositories also create new 
ones on the server, and in what category would you suggest putting this?


- René J.V.


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126198/#review95538
---


On May 16, 2016, 9:49 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126198/
> ---
> 
> (Updated May 16, 2016, 9:49 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X, KDE Frameworks, Plasma, and 
> Valorie Zimmerman.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> The KdePlatformTheme plugin can be enabled on OS X with a minimal patch to 
> Qt5; all that is required is to include the `qgenericunixservices` and 
> `qgenericunixthemes` components in the build, and to append `"kde"` to the 
> list returned by `QCocoaIntegration::themeNames()` for instance under the 
> condition that `KDE_SESSION_VERSION` is set to a suitable value in the 
> environment.
> 
> This will allow KF5 and Qt5 applications to use the theme selected through 
> KDE if FrameworkIntegration is installed and KDE_SESSION_VERSION is set, 
> which seems like a sufficiently specific set of conditions that is easy to 
> avoid by users who prefer to use the Mac native theme.
> 
> While requestion the KDE theme is also possible through `-style kde` or `env 
> QT_STYLE_OVERRIDE=kde` the use of the KdePlatformTheme plugin appears to be 
> the only way to get the full theme, including the font and colour selection. 
> In my opinion it is above all the font customisation which is a very welcome 
> feature for Qt/Mac; by default Qt applications use the default system font 
> (Lucida Grande 13pt or even 14pt) throughout. This is a good UI font, but not 
> at that size (and most "native" OS X applications indeed use a range of 
> smaller sizes, depending on role.
> 
> It does have introduce a number of regressions, which the current patch aims 
> to address. The most visible and problematic of these regressions is the loss 
> of the Mac-style menu bar and thus of all menu items (actions).
> 
> The fix is straightforward : on OS X (and similarly affected platforms?), an 
> instance of the native Cocoa platform theme is created through the private 
> API, and used as a fallback rather than immediately falling back to the 
> default implementations from `QPlatformTheme`. In addition, methods missing 
> from (not overridden by) `KdePlatformTheme` are provided on OS X and call the 
> corresponding methods from the native theme. It is this change which restores 
> the menubar and even the Dock menu functionality.
> One minor regression remains but should be easy to fix (elsewhere?): the 
> Preferences menu loses its keyboard shortcut (Command-,).
> 
> Given the fallback nature of the native platform instance I have preferred to 
> print a warning rather than using something like `qFatal`, above all because 
> the message printed by qFatal tends to get lost on OS X. I can replace my use 
> of `qWarning` with a dialog giving the choice between continuing or exiting 
> the application - code that would be called in the menu methods because only 
> there is it certain that the application actually needs a menubar.
> 
> In line with experience and feedback from the KDE(4)-Mac community I have 
> decided to force the use of native dialogs rather than the ones from the 
> KdePlatformPlugin.
> 
> In addition I set the fallback value for `ShowIconsOnPushButtons` to false in 
> line with platform guidelines, and ensure that the autotests

Review Request 127959: Adding missing license

2016-05-19 Thread Maximiliano Curia


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127959/
---

Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.


Repository: khtml


Description
---

We are currently shipping an LGPL-2.1 copy in the COPYING.LIB file, but
some parts of the code are under a LGPL-2 only license (see:
autotests/kencodingdetectortest.cpp autotests/kencodingdetectortest.h
src/html/kopenssl.cpp src/html/kopenssl.h src/khtml_printsettings.cpp
src/khtml_printsettings.h src/kmultipart/httpfiltergzip.cpp
src/kmultipart/httpfiltergzip_p.h src/rendering/table_layout.cpp
src/rendering/table_layout.h) and the LGPL license requires shipping the
full text with the source code.


Diffs
-

  COPYING.LGPL-2 PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127959/diff/


Testing
---


Thanks,

Maximiliano Curia

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127960: Adding missing license

2016-05-19 Thread Maximiliano Curia


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127960/
---

Review request for KDE Frameworks.


Repository: kcmutils


Description
---

We are currently shipping an LGPL-2.1 copy in the COPYING.LIB file, but
some parts of the code are under a LGPL-2 only license and the LGPL
license requires shipping the full text with the source code.

The list of LGPL-2 only files is:
 src/kcmoduleinfo.cpp
 src/kcmoduleinfo.h
 src/kcmoduleloader.cpp
 src/kcmoduleloader.h
 src/kcmoduleproxy.cpp
 src/kcmoduleproxy.h
 src/kcmoduleproxy_p.h
 src/kcmoduleqml.cpp
 src/kcmoduleqml_p.h
 src/kcmultidialog_p.h
 src/kpluginselector.cpp
 src/kpluginselector.h
 src/kpluginselector_p.h
 src/ksettings/componentsdialog.cpp
 src/ksettings/componentsdialog_p.h
 src/ksettings/dialog.cpp
 src/ksettings/dialog.h
 src/ksettings/dialog_p.h
 src/ksettings/dispatcher.cpp
 src/ksettings/dispatcher.h
 src/ksettings/dispatcher_p.h
 src/ksettings/pluginpage.cpp
 src/ksettings/pluginpage.h
 src/ksettingswidgetadaptor.cpp
 src/ksettingswidgetadaptor.h


Diffs
-

  COPYING.LGPL-2 PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127960/diff/


Testing
---


Thanks,

Maximiliano Curia

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2016-05-19 Thread Boudhayan Gupta



> On May 17, 2016, 8:07 p.m., Martin Gräßlin wrote:
> > given that Plasma integration got removed I suggest to create a dedicated 
> > osx-integration repository for it as well.
> 
> René J.V. Bertin wrote:
> I quite like the way things are, but yes, I've played with that idea. 
> 
> I guess I can simply fork `frameworkintegration`, change the project name 
> in the toplevel CMake file and strip everything except for the platformtheme.
> 
> How does this work from that point onwards?
> 
> Martin Gräßlin wrote:
> > I guess I can simply fork frameworkintegration, change the project name 
> in the toplevel CMake file and strip everything except for the platformtheme.
> 
> That's kind of how I did it for plasma-integration with git filter-tree.
> 
> > How does this work from that point onwards?
> 
> My suggestion would be to create something like an "OSX integration" 
> project in the metadata and have then all your repositories grouped there 
> including the new platform theme.
> 
> René J.V. Bertin wrote:
> This is something I'm completely new to; what metadata are we talking 
> about here?
> Also, can anyone with commit access to existing repositories also create 
> new ones on the server, and in what category would you suggest putting this?

For now, start with a scratch repo. Sysadmin will take care of the rest for you.


- Boudhayan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126198/#review95538
---


On May 17, 2016, 1:19 a.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126198/
> ---
> 
> (Updated May 17, 2016, 1:19 a.m.)
> 
> 
> Review request for KDE Software on Mac OS X, KDE Frameworks, Plasma, and 
> Valorie Zimmerman.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> The KdePlatformTheme plugin can be enabled on OS X with a minimal patch to 
> Qt5; all that is required is to include the `qgenericunixservices` and 
> `qgenericunixthemes` components in the build, and to append `"kde"` to the 
> list returned by `QCocoaIntegration::themeNames()` for instance under the 
> condition that `KDE_SESSION_VERSION` is set to a suitable value in the 
> environment.
> 
> This will allow KF5 and Qt5 applications to use the theme selected through 
> KDE if FrameworkIntegration is installed and KDE_SESSION_VERSION is set, 
> which seems like a sufficiently specific set of conditions that is easy to 
> avoid by users who prefer to use the Mac native theme.
> 
> While requestion the KDE theme is also possible through `-style kde` or `env 
> QT_STYLE_OVERRIDE=kde` the use of the KdePlatformTheme plugin appears to be 
> the only way to get the full theme, including the font and colour selection. 
> In my opinion it is above all the font customisation which is a very welcome 
> feature for Qt/Mac; by default Qt applications use the default system font 
> (Lucida Grande 13pt or even 14pt) throughout. This is a good UI font, but not 
> at that size (and most "native" OS X applications indeed use a range of 
> smaller sizes, depending on role.
> 
> It does have introduce a number of regressions, which the current patch aims 
> to address. The most visible and problematic of these regressions is the loss 
> of the Mac-style menu bar and thus of all menu items (actions).
> 
> The fix is straightforward : on OS X (and similarly affected platforms?), an 
> instance of the native Cocoa platform theme is created through the private 
> API, and used as a fallback rather than immediately falling back to the 
> default implementations from `QPlatformTheme`. In addition, methods missing 
> from (not overridden by) `KdePlatformTheme` are provided on OS X and call the 
> corresponding methods from the native theme. It is this change which restores 
> the menubar and even the Dock menu functionality.
> One minor regression remains but should be easy to fix (elsewhere?): the 
> Preferences menu loses its keyboard shortcut (Command-,).
> 
> Given the fallback nature of the native platform instance I have preferred to 
> print a warning rather than using something like `qFatal`, above all because 
> the message printed by qFatal tends to get lost on OS X. I can replace my use 
> of `qWarning` with a dialog giving the choice between continuing or exiting 
> the application - code that would be called in the menu methods because only 
> there is it certain that the application actually needs a menubar.
> 
> In line with experience and feedback from the KDE(4)-Mac community I have 
> decided to force the use of native dialogs rather than the ones from the 
> KdePlatformPlugin.
> 
> In addition I s

Review Request 127961: Adding missing license

2016-05-19 Thread Maximiliano Curia


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127961/
---

Review request for KDE Frameworks.


Repository: kdelibs4support


Description
---

We are currently shipping an LGPL-2.1 copy in the COPYING.LIB file, but
some parts of the code are under a LGPL-2 only license and the LGPL
license requires shipping the full text with the source code.

The list of LGPL-2 only files is:
 autotests/globalcleanuptest.cpp
 autotests/kconfigafterkglobaltest1.cpp
 autotests/kconfigafterkglobaltest2.cpp
 autotests/kglobalsettingstest.h
 autotests/kglobaltest.cpp
 autotests/klibloadertest.cpp
 autotests/klibloadertest.h
 autotests/klibloadertest3_module.cpp
 autotests/klibloadertest3_module.h
 autotests/klibloadertest5_module.cpp
 autotests/klibloadertest5_module.h
 autotests/klocaletest.cpp
 autotests/klocaletest.h
 autotests/klockfiletest.cpp
 autotests/klockfiletest.h
 autotests/ksavefiletest.cpp
 autotests/ksavefiletest.h
 autotests/kstandarddirstest.cpp
 autotests/kstandarddirstest.h
 autotests/ktempdirtest.cpp
 autotests/kuniqueapptest.cpp
 autotests/kurltest.cpp
 autotests/kurltest.h
 src/kdecore/kcmdlineargs.cpp
 src/kdecore/kcmdlineargs.h
 src/kdecore/kcomponentdata.cpp
 src/kdecore/kcomponentdata.h
 src/kdecore/kcomponentdata_p.h
 src/kdecore/kde_file.h
 src/kdecore/kde_file_win.cpp
 src/kdecore/kglobal.cpp
 src/kdecore/kglobal.h
 src/kdecore/kkernel_mac.cpp
 src/kdecore/kkernel_mac.h
 src/kdecore/kkernel_win.cpp
 src/kdecore/kkernel_win.h
 src/kdecore/klibloader.cpp
 src/kdecore/klibloader.h
 src/kdecore/klibrary.cpp
 src/kdecore/klibrary.h
 src/kdecore/klockfile.h
 src/kdecore/klockfile_unix.cpp
 src/kdecore/klockfile_win.cpp
 src/kdecore/kmd5.cpp
 src/kdecore/kmd5.h
 src/kdecore/kmimetype.cpp
 src/kdecore/kmimetype.h
 src/kdecore/kmimetype_p.h
 src/kdecore/ksavefile.cpp
 src/kdecore/ksavefile.h
 src/kdecore/kstandarddirs.cpp
 src/kdecore/kstringhandler_deprecated.h
 src/kdecore/ktempdir.cpp
 src/kdecore/ktempdir.h
 src/kdecore/qtest_kde.cpp
 src/kdecore/qtest_kde.h
 src/kdeui/k3icon.cpp
 src/kdeui/k3icon_p.h
 src/kdeui/k4timezonewidget.cpp
 src/kdeui/k4timezonewidget.h
 src/kdeui/kaction.cpp
 src/kdeui/kaction.h
 src/kdeui/kaction_p.h
 src/kdeui/kapplication_win.cpp
 src/kdeui/karrowbutton.cpp
 src/kdeui/karrowbutton.h
 src/kdeui/kcolorchoosermode.cpp
 src/kdeui/kcolorchoosermode_p.h
 src/kdeui/kcolorhelpers.cpp
 src/kdeui/kdatetimewidget.cpp
 src/kdeui/kdatetimewidget.h
 src/kdeui/kdatewidget.cpp
 src/kdeui/kdatewidget.h
 src/kdeui/kdialog_p.h
 src/kdeui/kglobalsettings.cpp
 src/kdeui/kglobalsettings.h
 src/kdeui/khbox.cpp
 src/kdeui/khbox.h
 src/kdeui/kicon.cpp
 src/kdeui/kicon.h
 src/kdeui/klistwidget.cpp
 src/kdeui/klistwidget.h
 src/kdeui/kmenu.cpp
 src/kdeui/kmenu.h
 src/kdeui/kmessagebox_queued.cpp
 src/kdeui/kmessagebox_queued.h
 src/kdeui/kmessageboxmessagehandler.cpp
 src/kdeui/kmessageboxmessagehandler.h
 src/kdeui/kpassivepopupmessagehandler.cpp
 src/kdeui/kpassivepopupmessagehandler.h
 src/kdeui/kpixmapcache.cpp
 src/kdeui/kpixmapcache.h
 src/kdeui/kprogressdialog.cpp
 src/kdeui/kprogressdialog.h
 src/kdeui/kstringvalidator.cpp
 src/kdeui/kstringvalidator.h
 src/kdeui/ksystemtrayicon.h
 src/kdeui/kvbox.cpp
 src/kdeui/kvbox.h
 src/kio/kdevicelistitem.cpp
 src/kio/kdevicelistitem_p.h
 src/kio/kdevicelistmodel.cpp
 src/kio/kdevicelistmodel.h
 src/kio/kdirselectdialog.cpp
 src/kio/kdirselectdialog.h
 src/kio/kdiskfreespace.cpp
 src/kio/kdiskfreespace.h
 src/kio/kfilemetainfowidget.cpp
 src/kio/kfilemetainfowidget.h
 src/kio/kfileshare.cpp
 src/kio/kfileshare.h
 src/kio/kfileshare_p.h
 src/kio/kmetaprops.cpp
 src/kio/kmetaprops.h
 src/kio/kpreviewprops.cpp
 src/kio/kpreviewprops.h
 src/kio/metainfojob.cpp
 src/kio/metainfojob.h
 src/kio/passworddialog.cpp
 src/kio/passworddialog.h
 src/kioslave/metainfo/metainfo.cpp
 src/kioslave/metainfo/metainfo.h
 src/kssl/kopenssl.cpp
 src/kssl/kopenssl.h
 src/solid-networkstatus/kded/wicdcustomtypes.cpp
 src/solid-networkstatus/kded/wicdcustomtypes.h
 tests/kmessagetest.cpp
 tests/kmessagetest.h
 tests/netaccesstest.cpp


Diffs
-

  COPYING.LGPL-2 PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127961/diff/


Testing
---


Thanks,

Maximiliano Curia

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2016-05-19 Thread René J . V . Bertin



> On May 17, 2016, 4:37 p.m., Martin Gräßlin wrote:
> > given that Plasma integration got removed I suggest to create a dedicated 
> > osx-integration repository for it as well.
> 
> René J.V. Bertin wrote:
> I quite like the way things are, but yes, I've played with that idea. 
> 
> I guess I can simply fork `frameworkintegration`, change the project name 
> in the toplevel CMake file and strip everything except for the platformtheme.
> 
> How does this work from that point onwards?
> 
> Martin Gräßlin wrote:
> > I guess I can simply fork frameworkintegration, change the project name 
> in the toplevel CMake file and strip everything except for the platformtheme.
> 
> That's kind of how I did it for plasma-integration with git filter-tree.
> 
> > How does this work from that point onwards?
> 
> My suggestion would be to create something like an "OSX integration" 
> project in the metadata and have then all your repositories grouped there 
> including the new platform theme.
> 
> René J.V. Bertin wrote:
> This is something I'm completely new to; what metadata are we talking 
> about here?
> Also, can anyone with commit access to existing repositories also create 
> new ones on the server, and in what category would you suggest putting this?
> 
> Boudhayan Gupta wrote:
> For now, start with a scratch repo. Sysadmin will take care of the rest 
> for you.

As I said, creating or proposing a new KDE package/repository is completely new 
for me, even that instruction is still ambiguous. I take it you're not talking 
about a scratch repo that exists only on one of my disks, possibly not even on 
a remote mirror like github, but rather something that would alert the 
sysadmins who will then take the appropriate actions?

I guess I should look through the developer/contributor instructions again, I 
most certainly skipped this level of information when I first (and last...) 
read that documentation.


- René J.V.


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126198/#review95538
---


On May 16, 2016, 9:49 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126198/
> ---
> 
> (Updated May 16, 2016, 9:49 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X, KDE Frameworks, Plasma, and 
> Valorie Zimmerman.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> The KdePlatformTheme plugin can be enabled on OS X with a minimal patch to 
> Qt5; all that is required is to include the `qgenericunixservices` and 
> `qgenericunixthemes` components in the build, and to append `"kde"` to the 
> list returned by `QCocoaIntegration::themeNames()` for instance under the 
> condition that `KDE_SESSION_VERSION` is set to a suitable value in the 
> environment.
> 
> This will allow KF5 and Qt5 applications to use the theme selected through 
> KDE if FrameworkIntegration is installed and KDE_SESSION_VERSION is set, 
> which seems like a sufficiently specific set of conditions that is easy to 
> avoid by users who prefer to use the Mac native theme.
> 
> While requestion the KDE theme is also possible through `-style kde` or `env 
> QT_STYLE_OVERRIDE=kde` the use of the KdePlatformTheme plugin appears to be 
> the only way to get the full theme, including the font and colour selection. 
> In my opinion it is above all the font customisation which is a very welcome 
> feature for Qt/Mac; by default Qt applications use the default system font 
> (Lucida Grande 13pt or even 14pt) throughout. This is a good UI font, but not 
> at that size (and most "native" OS X applications indeed use a range of 
> smaller sizes, depending on role.
> 
> It does have introduce a number of regressions, which the current patch aims 
> to address. The most visible and problematic of these regressions is the loss 
> of the Mac-style menu bar and thus of all menu items (actions).
> 
> The fix is straightforward : on OS X (and similarly affected platforms?), an 
> instance of the native Cocoa platform theme is created through the private 
> API, and used as a fallback rather than immediately falling back to the 
> default implementations from `QPlatformTheme`. In addition, methods missing 
> from (not overridden by) `KdePlatformTheme` are provided on OS X and call the 
> corresponding methods from the native theme. It is this change which restores 
> the menubar and even the Dock menu functionality.
> One minor regression remains but should be easy to fix (elsewhere?): the 
> Preferences menu loses its keyboard shortcut (Command-,).
> 
> Given the fallback nature of the native platform instance I have preferred to

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2016-05-19 Thread Elvis Angelaccio



> On May 17, 2016, 2:37 p.m., Martin Gräßlin wrote:
> > given that Plasma integration got removed I suggest to create a dedicated 
> > osx-integration repository for it as well.
> 
> René J.V. Bertin wrote:
> I quite like the way things are, but yes, I've played with that idea. 
> 
> I guess I can simply fork `frameworkintegration`, change the project name 
> in the toplevel CMake file and strip everything except for the platformtheme.
> 
> How does this work from that point onwards?
> 
> Martin Gräßlin wrote:
> > I guess I can simply fork frameworkintegration, change the project name 
> in the toplevel CMake file and strip everything except for the platformtheme.
> 
> That's kind of how I did it for plasma-integration with git filter-tree.
> 
> > How does this work from that point onwards?
> 
> My suggestion would be to create something like an "OSX integration" 
> project in the metadata and have then all your repositories grouped there 
> including the new platform theme.
> 
> René J.V. Bertin wrote:
> This is something I'm completely new to; what metadata are we talking 
> about here?
> Also, can anyone with commit access to existing repositories also create 
> new ones on the server, and in what category would you suggest putting this?
> 
> Boudhayan Gupta wrote:
> For now, start with a scratch repo. Sysadmin will take care of the rest 
> for you.
> 
> René J.V. Bertin wrote:
> As I said, creating or proposing a new KDE package/repository is 
> completely new for me, even that instruction is still ambiguous. I take it 
> you're not talking about a scratch repo that exists only on one of my disks, 
> possibly not even on a remote mirror like github, but rather something that 
> would alert the sysadmins who will then take the appropriate actions?
> 
> I guess I should look through the developer/contributor instructions 
> again, I most certainly skipped this level of information when I first (and 
> last...) read that documentation.

Here you can find the instructions to create a scratch repo: 
https://community.kde.org/Sysadmin/GitKdeOrgManual#Personal_scratch_repositories


- Elvis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126198/#review95538
---


On May 16, 2016, 7:49 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126198/
> ---
> 
> (Updated May 16, 2016, 7:49 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X, KDE Frameworks, Plasma, and 
> Valorie Zimmerman.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> The KdePlatformTheme plugin can be enabled on OS X with a minimal patch to 
> Qt5; all that is required is to include the `qgenericunixservices` and 
> `qgenericunixthemes` components in the build, and to append `"kde"` to the 
> list returned by `QCocoaIntegration::themeNames()` for instance under the 
> condition that `KDE_SESSION_VERSION` is set to a suitable value in the 
> environment.
> 
> This will allow KF5 and Qt5 applications to use the theme selected through 
> KDE if FrameworkIntegration is installed and KDE_SESSION_VERSION is set, 
> which seems like a sufficiently specific set of conditions that is easy to 
> avoid by users who prefer to use the Mac native theme.
> 
> While requestion the KDE theme is also possible through `-style kde` or `env 
> QT_STYLE_OVERRIDE=kde` the use of the KdePlatformTheme plugin appears to be 
> the only way to get the full theme, including the font and colour selection. 
> In my opinion it is above all the font customisation which is a very welcome 
> feature for Qt/Mac; by default Qt applications use the default system font 
> (Lucida Grande 13pt or even 14pt) throughout. This is a good UI font, but not 
> at that size (and most "native" OS X applications indeed use a range of 
> smaller sizes, depending on role.
> 
> It does have introduce a number of regressions, which the current patch aims 
> to address. The most visible and problematic of these regressions is the loss 
> of the Mac-style menu bar and thus of all menu items (actions).
> 
> The fix is straightforward : on OS X (and similarly affected platforms?), an 
> instance of the native Cocoa platform theme is created through the private 
> API, and used as a fallback rather than immediately falling back to the 
> default implementations from `QPlatformTheme`. In addition, methods missing 
> from (not overridden by) `KdePlatformTheme` are provided on OS X and call the 
> corresponding methods from the native theme. It is this change which restores 
> the menubar and even the Dock menu functionality.
> One minor regression

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2016-05-19 Thread René J . V . Bertin



> On May 17, 2016, 4:37 p.m., Martin Gräßlin wrote:
> > given that Plasma integration got removed I suggest to create a dedicated 
> > osx-integration repository for it as well.
> 
> René J.V. Bertin wrote:
> I quite like the way things are, but yes, I've played with that idea. 
> 
> I guess I can simply fork `frameworkintegration`, change the project name 
> in the toplevel CMake file and strip everything except for the platformtheme.
> 
> How does this work from that point onwards?
> 
> Martin Gräßlin wrote:
> > I guess I can simply fork frameworkintegration, change the project name 
> in the toplevel CMake file and strip everything except for the platformtheme.
> 
> That's kind of how I did it for plasma-integration with git filter-tree.
> 
> > How does this work from that point onwards?
> 
> My suggestion would be to create something like an "OSX integration" 
> project in the metadata and have then all your repositories grouped there 
> including the new platform theme.
> 
> René J.V. Bertin wrote:
> This is something I'm completely new to; what metadata are we talking 
> about here?
> Also, can anyone with commit access to existing repositories also create 
> new ones on the server, and in what category would you suggest putting this?
> 
> Boudhayan Gupta wrote:
> For now, start with a scratch repo. Sysadmin will take care of the rest 
> for you.
> 
> René J.V. Bertin wrote:
> As I said, creating or proposing a new KDE package/repository is 
> completely new for me, even that instruction is still ambiguous. I take it 
> you're not talking about a scratch repo that exists only on one of my disks, 
> possibly not even on a remote mirror like github, but rather something that 
> would alert the sysadmins who will then take the appropriate actions?
> 
> I guess I should look through the developer/contributor instructions 
> again, I most certainly skipped this level of information when I first (and 
> last...) read that documentation.
> 
> Elvis Angelaccio wrote:
> Here you can find the instructions to create a scratch repo: 
> https://community.kde.org/Sysadmin/GitKdeOrgManual#Personal_scratch_repositories

ah, great, thanks. Looks exactly what I need except that it doesn't appear to 
say anything about the metadata Martin mentions. But it's a start :)


- René J.V.


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126198/#review95538
---


On May 16, 2016, 9:49 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126198/
> ---
> 
> (Updated May 16, 2016, 9:49 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X, KDE Frameworks, Plasma, and 
> Valorie Zimmerman.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> The KdePlatformTheme plugin can be enabled on OS X with a minimal patch to 
> Qt5; all that is required is to include the `qgenericunixservices` and 
> `qgenericunixthemes` components in the build, and to append `"kde"` to the 
> list returned by `QCocoaIntegration::themeNames()` for instance under the 
> condition that `KDE_SESSION_VERSION` is set to a suitable value in the 
> environment.
> 
> This will allow KF5 and Qt5 applications to use the theme selected through 
> KDE if FrameworkIntegration is installed and KDE_SESSION_VERSION is set, 
> which seems like a sufficiently specific set of conditions that is easy to 
> avoid by users who prefer to use the Mac native theme.
> 
> While requestion the KDE theme is also possible through `-style kde` or `env 
> QT_STYLE_OVERRIDE=kde` the use of the KdePlatformTheme plugin appears to be 
> the only way to get the full theme, including the font and colour selection. 
> In my opinion it is above all the font customisation which is a very welcome 
> feature for Qt/Mac; by default Qt applications use the default system font 
> (Lucida Grande 13pt or even 14pt) throughout. This is a good UI font, but not 
> at that size (and most "native" OS X applications indeed use a range of 
> smaller sizes, depending on role.
> 
> It does have introduce a number of regressions, which the current patch aims 
> to address. The most visible and problematic of these regressions is the loss 
> of the Mac-style menu bar and thus of all menu items (actions).
> 
> The fix is straightforward : on OS X (and similarly affected platforms?), an 
> instance of the native Cocoa platform theme is created through the private 
> API, and used as a fallback rather than immediately falling back to the 
> default implementations from `QPlatformTheme`. In addition, methods missing 
> from (not overridden by) `KdePlatformTheme` a

Review Request 127963: Adding missing license

2016-05-19 Thread Maximiliano Curia


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127963/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

We are currently shipping an LGPL-2.1 copy in the COPYING.LIB file, but
some parts of the code are under a LGPL-2 only license and the LGPL
license requires shipping the full text with the source code.

The list of LGPL-2 only files is:
 examples/kpart/containmentshell.cpp
 examples/kpart/containmentshell.h
 examples/kpart/main.cpp
 examples/kpart/testshellpluginloader.cpp
 examples/kpart/testshellpluginloader.h
 src/kpart/plasmakpartview.cpp
 src/kpart/scripting/rect.cpp
 src/plasma/private/package_p.h
 src/plasma/private/packagestructure_p.h
 src/plasma/private/servicejob_p.h


Diffs
-

  COPYING.LGPL-2 PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127963/diff/


Testing
---


Thanks,

Maximiliano Curia

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127469: Use QQuickWidget for QML KCMs

2016-05-19 Thread Marco Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127469/#review95608
---


Ship it!




I suggest we try it, then see if there are any reports of problems

- Marco Martin


On March 23, 2016, 10:29 a.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127469/
> ---
> 
> (Updated March 23, 2016, 10:29 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 359124
> https://bugs.kde.org/show_bug.cgi?id=359124
> 
> 
> Repository: kcmutils
> 
> 
> Description
> ---
> 
> Fix position of QtQuickControls popups.
> 
> BUG: 359124
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 60cf4bb 
>   src/CMakeLists.txt 58352f6 
>   src/kcmoduleqml.cpp c52769b 
> 
> Diff: https://git.reviewboard.kde.org/r/127469/diff/
> 
> 
> Testing
> ---
> 
> Popups are now in correct position in systemsettings and kcmshell
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127963: Adding missing license

2016-05-19 Thread Marco Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127963/#review95607
---


Ship it!




Ship It!

- Marco Martin


On May 19, 2016, 1:51 p.m., Maximiliano Curia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127963/
> ---
> 
> (Updated May 19, 2016, 1:51 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> We are currently shipping an LGPL-2.1 copy in the COPYING.LIB file, but
> some parts of the code are under a LGPL-2 only license and the LGPL
> license requires shipping the full text with the source code.
> 
> The list of LGPL-2 only files is:
>  examples/kpart/containmentshell.cpp
>  examples/kpart/containmentshell.h
>  examples/kpart/main.cpp
>  examples/kpart/testshellpluginloader.cpp
>  examples/kpart/testshellpluginloader.h
>  src/kpart/plasmakpartview.cpp
>  src/kpart/scripting/rect.cpp
>  src/plasma/private/package_p.h
>  src/plasma/private/packagestructure_p.h
>  src/plasma/private/servicejob_p.h
> 
> 
> Diffs
> -
> 
>   COPYING.LGPL-2 PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127963/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maximiliano Curia
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127795: [DataEngine] Invalidate DataEngine on unknown plugin + detailed test

2016-05-19 Thread Marco Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127795/#review95609
---


Ship it!




Ship It!

- Marco Martin


On May 4, 2016, 5:06 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127795/
> ---
> 
> (Updated May 4, 2016, 5:06 p.m.)
> 
> 
> Review request for KDE Frameworks and Marco Martin.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> ^^
> 
> 
> Diffs
> -
> 
>   autotests/pluginloadertest.h 61fc963 
>   autotests/pluginloadertest.cpp 4f96780 
>   src/plasma/dataengine.cpp f942926 
> 
> Diff: https://git.reviewboard.kde.org/r/127795/diff/
> 
> 
> Testing
> ---
> 
> Test pass.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127870: plasma-framework: AppletInterface::downloadPath()

2016-05-19 Thread Marco Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127870/#review95612
---


Ship it!




Ship It!

- Marco Martin


On May 8, 2016, 4:15 p.m., Allen Winter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127870/
> ---
> 
> (Updated May 8, 2016, 4:15 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Deprecate downloadPath(const QString &file) in favor of downloadPath() since 
> the file argument is not used.
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h 6cf71aa 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 876af2c 
> 
> Diff: https://git.reviewboard.kde.org/r/127870/diff/
> 
> 
> Testing
> ---
> 
> compiles. make test still passes.
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127870: plasma-framework: AppletInterface::downloadPath()

2016-05-19 Thread Kai Uwe Broulik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127870/#review95613
---




src/scriptengines/qml/plasmoid/appletinterface.h (line 279)


If at it, shouldn't this be const?


- Kai Uwe Broulik


On Mai 8, 2016, 4:15 nachm., Allen Winter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127870/
> ---
> 
> (Updated Mai 8, 2016, 4:15 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Deprecate downloadPath(const QString &file) in favor of downloadPath() since 
> the file argument is not used.
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h 6cf71aa 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 876af2c 
> 
> Diff: https://git.reviewboard.kde.org/r/127870/diff/
> 
> 
> Testing
> ---
> 
> compiles. make test still passes.
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127963: Adding missing license

2016-05-19 Thread Maximiliano Curia


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127963/
---

(Updated May 19, 2016, 2:37 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

We are currently shipping an LGPL-2.1 copy in the COPYING.LIB file, but
some parts of the code are under a LGPL-2 only license and the LGPL
license requires shipping the full text with the source code.

The list of LGPL-2 only files is:
 examples/kpart/containmentshell.cpp
 examples/kpart/containmentshell.h
 examples/kpart/main.cpp
 examples/kpart/testshellpluginloader.cpp
 examples/kpart/testshellpluginloader.h
 src/kpart/plasmakpartview.cpp
 src/kpart/scripting/rect.cpp
 src/plasma/private/package_p.h
 src/plasma/private/packagestructure_p.h
 src/plasma/private/servicejob_p.h


Diffs
-

  COPYING.LGPL-2 PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127963/diff/


Testing
---


Thanks,

Maximiliano Curia

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127963: Adding missing license

2016-05-19 Thread Martin Gräßlin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127963/#review95615
---



I think the approach here is wrong. Our frameworks are LGPLv2+. If we have 
files which don't match that we need to either change copyright or remove the 
files.

- Martin Gräßlin


On May 19, 2016, 4:37 p.m., Maximiliano Curia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127963/
> ---
> 
> (Updated May 19, 2016, 4:37 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> We are currently shipping an LGPL-2.1 copy in the COPYING.LIB file, but
> some parts of the code are under a LGPL-2 only license and the LGPL
> license requires shipping the full text with the source code.
> 
> The list of LGPL-2 only files is:
>  examples/kpart/containmentshell.cpp
>  examples/kpart/containmentshell.h
>  examples/kpart/main.cpp
>  examples/kpart/testshellpluginloader.cpp
>  examples/kpart/testshellpluginloader.h
>  src/kpart/plasmakpartview.cpp
>  src/kpart/scripting/rect.cpp
>  src/plasma/private/package_p.h
>  src/plasma/private/packagestructure_p.h
>  src/plasma/private/servicejob_p.h
> 
> 
> Diffs
> -
> 
>   COPYING.LGPL-2 PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127963/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maximiliano Curia
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127963: Adding missing license

2016-05-19 Thread Marco Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127963/#review95616
---



ok, let's actually fix this properly

- Marco Martin


On May 19, 2016, 2:37 p.m., Maximiliano Curia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127963/
> ---
> 
> (Updated May 19, 2016, 2:37 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> We are currently shipping an LGPL-2.1 copy in the COPYING.LIB file, but
> some parts of the code are under a LGPL-2 only license and the LGPL
> license requires shipping the full text with the source code.
> 
> The list of LGPL-2 only files is:
>  examples/kpart/containmentshell.cpp
>  examples/kpart/containmentshell.h
>  examples/kpart/main.cpp
>  examples/kpart/testshellpluginloader.cpp
>  examples/kpart/testshellpluginloader.h
>  src/kpart/plasmakpartview.cpp
>  src/kpart/scripting/rect.cpp
>  src/plasma/private/package_p.h
>  src/plasma/private/packagestructure_p.h
>  src/plasma/private/servicejob_p.h
> 
> 
> Diffs
> -
> 
>   COPYING.LGPL-2 PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127963/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maximiliano Curia
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127963: Adding missing license

2016-05-19 Thread Marco Martin



> On May 19, 2016, 3:25 p.m., Marco Martin wrote:
> > ok, let's actually fix this properly

package/packagestructure/servicejob are the ones that should be relicensed (i 
would argue they already are, as their corresponding .cpp file is lgpl 2+ 
already


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127963/#review95616
---


On May 19, 2016, 2:37 p.m., Maximiliano Curia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127963/
> ---
> 
> (Updated May 19, 2016, 2:37 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> We are currently shipping an LGPL-2.1 copy in the COPYING.LIB file, but
> some parts of the code are under a LGPL-2 only license and the LGPL
> license requires shipping the full text with the source code.
> 
> The list of LGPL-2 only files is:
>  examples/kpart/containmentshell.cpp
>  examples/kpart/containmentshell.h
>  examples/kpart/main.cpp
>  examples/kpart/testshellpluginloader.cpp
>  examples/kpart/testshellpluginloader.h
>  src/kpart/plasmakpartview.cpp
>  src/kpart/scripting/rect.cpp
>  src/plasma/private/package_p.h
>  src/plasma/private/packagestructure_p.h
>  src/plasma/private/servicejob_p.h
> 
> 
> Diffs
> -
> 
>   COPYING.LGPL-2 PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127963/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maximiliano Curia
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127963: Adding missing license

2016-05-19 Thread Marco Martin



> On May 19, 2016, 3:25 p.m., Marco Martin wrote:
> > ok, let's actually fix this properly
> 
> Marco Martin wrote:
> package/packagestructure/servicejob are the ones that should be 
> relicensed (i would argue they already are, as their corresponding .cpp file 
> is lgpl 2+ already

all the kpart stuff is not really used and i can just remove it


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127963/#review95616
---


On May 19, 2016, 2:37 p.m., Maximiliano Curia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127963/
> ---
> 
> (Updated May 19, 2016, 2:37 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> We are currently shipping an LGPL-2.1 copy in the COPYING.LIB file, but
> some parts of the code are under a LGPL-2 only license and the LGPL
> license requires shipping the full text with the source code.
> 
> The list of LGPL-2 only files is:
>  examples/kpart/containmentshell.cpp
>  examples/kpart/containmentshell.h
>  examples/kpart/main.cpp
>  examples/kpart/testshellpluginloader.cpp
>  examples/kpart/testshellpluginloader.h
>  src/kpart/plasmakpartview.cpp
>  src/kpart/scripting/rect.cpp
>  src/plasma/private/package_p.h
>  src/plasma/private/packagestructure_p.h
>  src/plasma/private/servicejob_p.h
> 
> 
> Diffs
> -
> 
>   COPYING.LGPL-2 PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127963/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maximiliano Curia
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127963: Adding missing license

2016-05-19 Thread Martin Gräßlin



> On May 19, 2016, 5:22 p.m., Martin Gräßlin wrote:
> > I think the approach here is wrong. Our frameworks are LGPLv2+. If we have 
> > files which don't match that we need to either change copyright or remove 
> > the files.

A check shows that examples/kpart and src/kpart are not built at all. They are 
dead code and could just be removed. src/plasma/private/packageFOO could easily 
be wrapped by implementing through the newer KPackage framework. servicejob_p.h 
might just be incorrectly licensed, history needs to be checked as all other 
files around it are properly or later.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127963/#review95615
---


On May 19, 2016, 4:37 p.m., Maximiliano Curia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127963/
> ---
> 
> (Updated May 19, 2016, 4:37 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> We are currently shipping an LGPL-2.1 copy in the COPYING.LIB file, but
> some parts of the code are under a LGPL-2 only license and the LGPL
> license requires shipping the full text with the source code.
> 
> The list of LGPL-2 only files is:
>  examples/kpart/containmentshell.cpp
>  examples/kpart/containmentshell.h
>  examples/kpart/main.cpp
>  examples/kpart/testshellpluginloader.cpp
>  examples/kpart/testshellpluginloader.h
>  src/kpart/plasmakpartview.cpp
>  src/kpart/scripting/rect.cpp
>  src/plasma/private/package_p.h
>  src/plasma/private/packagestructure_p.h
>  src/plasma/private/servicejob_p.h
> 
> 
> Diffs
> -
> 
>   COPYING.LGPL-2 PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127963/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maximiliano Curia
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127963: Adding missing license

2016-05-19 Thread Martin Gräßlin



> On May 19, 2016, 5:22 p.m., Martin Gräßlin wrote:
> > I think the approach here is wrong. Our frameworks are LGPLv2+. If we have 
> > files which don't match that we need to either change copyright or remove 
> > the files.
> 
> Martin Gräßlin wrote:
> A check shows that examples/kpart and src/kpart are not built at all. 
> They are dead code and could just be removed. src/plasma/private/packageFOO 
> could easily be wrapped by implementing through the newer KPackage framework. 
> servicejob_p.h might just be incorrectly licensed, history needs to be 
> checked as all other files around it are properly or later.

I just verified for servicejob_p.h, was split out from servicejob.cpp in 
89b71cd9f195da51993533f7fc2329ddc08a7de4 of kdelibs


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127963/#review95615
---


On May 19, 2016, 4:37 p.m., Maximiliano Curia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127963/
> ---
> 
> (Updated May 19, 2016, 4:37 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> We are currently shipping an LGPL-2.1 copy in the COPYING.LIB file, but
> some parts of the code are under a LGPL-2 only license and the LGPL
> license requires shipping the full text with the source code.
> 
> The list of LGPL-2 only files is:
>  examples/kpart/containmentshell.cpp
>  examples/kpart/containmentshell.h
>  examples/kpart/main.cpp
>  examples/kpart/testshellpluginloader.cpp
>  examples/kpart/testshellpluginloader.h
>  src/kpart/plasmakpartview.cpp
>  src/kpart/scripting/rect.cpp
>  src/plasma/private/package_p.h
>  src/plasma/private/packagestructure_p.h
>  src/plasma/private/servicejob_p.h
> 
> 
> Diffs
> -
> 
>   COPYING.LGPL-2 PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127963/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maximiliano Curia
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127961: Adding missing license

2016-05-19 Thread Martin Gräßlin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127961/#review95621
---



I would prefer that we properly investigate each of the cases. E.g. 
plasma-framework showed that the files are just incorrectly licensed.

- Martin Gräßlin


On May 19, 2016, 2:51 p.m., Maximiliano Curia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127961/
> ---
> 
> (Updated May 19, 2016, 2:51 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> ---
> 
> We are currently shipping an LGPL-2.1 copy in the COPYING.LIB file, but
> some parts of the code are under a LGPL-2 only license and the LGPL
> license requires shipping the full text with the source code.
> 
> The list of LGPL-2 only files is:
>  autotests/globalcleanuptest.cpp
>  autotests/kconfigafterkglobaltest1.cpp
>  autotests/kconfigafterkglobaltest2.cpp
>  autotests/kglobalsettingstest.h
>  autotests/kglobaltest.cpp
>  autotests/klibloadertest.cpp
>  autotests/klibloadertest.h
>  autotests/klibloadertest3_module.cpp
>  autotests/klibloadertest3_module.h
>  autotests/klibloadertest5_module.cpp
>  autotests/klibloadertest5_module.h
>  autotests/klocaletest.cpp
>  autotests/klocaletest.h
>  autotests/klockfiletest.cpp
>  autotests/klockfiletest.h
>  autotests/ksavefiletest.cpp
>  autotests/ksavefiletest.h
>  autotests/kstandarddirstest.cpp
>  autotests/kstandarddirstest.h
>  autotests/ktempdirtest.cpp
>  autotests/kuniqueapptest.cpp
>  autotests/kurltest.cpp
>  autotests/kurltest.h
>  src/kdecore/kcmdlineargs.cpp
>  src/kdecore/kcmdlineargs.h
>  src/kdecore/kcomponentdata.cpp
>  src/kdecore/kcomponentdata.h
>  src/kdecore/kcomponentdata_p.h
>  src/kdecore/kde_file.h
>  src/kdecore/kde_file_win.cpp
>  src/kdecore/kglobal.cpp
>  src/kdecore/kglobal.h
>  src/kdecore/kkernel_mac.cpp
>  src/kdecore/kkernel_mac.h
>  src/kdecore/kkernel_win.cpp
>  src/kdecore/kkernel_win.h
>  src/kdecore/klibloader.cpp
>  src/kdecore/klibloader.h
>  src/kdecore/klibrary.cpp
>  src/kdecore/klibrary.h
>  src/kdecore/klockfile.h
>  src/kdecore/klockfile_unix.cpp
>  src/kdecore/klockfile_win.cpp
>  src/kdecore/kmd5.cpp
>  src/kdecore/kmd5.h
>  src/kdecore/kmimetype.cpp
>  src/kdecore/kmimetype.h
>  src/kdecore/kmimetype_p.h
>  src/kdecore/ksavefile.cpp
>  src/kdecore/ksavefile.h
>  src/kdecore/kstandarddirs.cpp
>  src/kdecore/kstringhandler_deprecated.h
>  src/kdecore/ktempdir.cpp
>  src/kdecore/ktempdir.h
>  src/kdecore/qtest_kde.cpp
>  src/kdecore/qtest_kde.h
>  src/kdeui/k3icon.cpp
>  src/kdeui/k3icon_p.h
>  src/kdeui/k4timezonewidget.cpp
>  src/kdeui/k4timezonewidget.h
>  src/kdeui/kaction.cpp
>  src/kdeui/kaction.h
>  src/kdeui/kaction_p.h
>  src/kdeui/kapplication_win.cpp
>  src/kdeui/karrowbutton.cpp
>  src/kdeui/karrowbutton.h
>  src/kdeui/kcolorchoosermode.cpp
>  src/kdeui/kcolorchoosermode_p.h
>  src/kdeui/kcolorhelpers.cpp
>  src/kdeui/kdatetimewidget.cpp
>  src/kdeui/kdatetimewidget.h
>  src/kdeui/kdatewidget.cpp
>  src/kdeui/kdatewidget.h
>  src/kdeui/kdialog_p.h
>  src/kdeui/kglobalsettings.cpp
>  src/kdeui/kglobalsettings.h
>  src/kdeui/khbox.cpp
>  src/kdeui/khbox.h
>  src/kdeui/kicon.cpp
>  src/kdeui/kicon.h
>  src/kdeui/klistwidget.cpp
>  src/kdeui/klistwidget.h
>  src/kdeui/kmenu.cpp
>  src/kdeui/kmenu.h
>  src/kdeui/kmessagebox_queued.cpp
>  src/kdeui/kmessagebox_queued.h
>  src/kdeui/kmessageboxmessagehandler.cpp
>  src/kdeui/kmessageboxmessagehandler.h
>  src/kdeui/kpassivepopupmessagehandler.cpp
>  src/kdeui/kpassivepopupmessagehandler.h
>  src/kdeui/kpixmapcache.cpp
>  src/kdeui/kpixmapcache.h
>  src/kdeui/kprogressdialog.cpp
>  src/kdeui/kprogressdialog.h
>  src/kdeui/kstringvalidator.cpp
>  src/kdeui/kstringvalidator.h
>  src/kdeui/ksystemtrayicon.h
>  src/kdeui/kvbox.cpp
>  src/kdeui/kvbox.h
>  src/kio/kdevicelistitem.cpp
>  src/kio/kdevicelistitem_p.h
>  src/kio/kdevicelistmodel.cpp
>  src/kio/kdevicelistmodel.h
>  src/kio/kdirselectdialog.cpp
>  src/kio/kdirselectdialog.h
>  src/kio/kdiskfreespace.cpp
>  src/kio/kdiskfreespace.h
>  src/kio/kfilemetainfowidget.cpp
>  src/kio/kfilemetainfowidget.h
>  src/kio/kfileshare.cpp
>  src/kio/kfileshare.h
>  src/kio/kfileshare_p.h
>  src/kio/kmetaprops.cpp
>  src/kio/kmetaprops.h
>  src/kio/kpreviewprops.cpp
>  src/kio/kpreviewprops.h
>  src/kio/metainfojob.cpp
>  src/kio/metainfojob.h
>  src/kio/passworddialog.cpp
>  src/kio/passworddialog.h
>  src/kioslave/metainfo/metainfo.cpp
>  src/kioslave/metainfo/metainfo.h
>  src/kssl/kopenssl.cpp
>  src/kssl/kopenssl.h
>  src/solid-networkstatus/kded/wicdcustomtypes.cpp
>  src/solid-networkstatus/kded/wicdcustomtypes.h
>  tests/kmessagetest.cpp
>  tests/kmessagetest.h
>  tests/netaccesstest.cpp
>

Re: Review Request 127960: Adding missing license

2016-05-19 Thread Martin Gräßlin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127960/#review95622
---



I would prefer that we properly investigate each of the cases. E.g. 
plasma-framework showed that the files are just incorrectly licensed.

- Martin Gräßlin


On May 19, 2016, 2:06 p.m., Maximiliano Curia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127960/
> ---
> 
> (Updated May 19, 2016, 2:06 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcmutils
> 
> 
> Description
> ---
> 
> We are currently shipping an LGPL-2.1 copy in the COPYING.LIB file, but
> some parts of the code are under a LGPL-2 only license and the LGPL
> license requires shipping the full text with the source code.
> 
> The list of LGPL-2 only files is:
>  src/kcmoduleinfo.cpp
>  src/kcmoduleinfo.h
>  src/kcmoduleloader.cpp
>  src/kcmoduleloader.h
>  src/kcmoduleproxy.cpp
>  src/kcmoduleproxy.h
>  src/kcmoduleproxy_p.h
>  src/kcmoduleqml.cpp
>  src/kcmoduleqml_p.h
>  src/kcmultidialog_p.h
>  src/kpluginselector.cpp
>  src/kpluginselector.h
>  src/kpluginselector_p.h
>  src/ksettings/componentsdialog.cpp
>  src/ksettings/componentsdialog_p.h
>  src/ksettings/dialog.cpp
>  src/ksettings/dialog.h
>  src/ksettings/dialog_p.h
>  src/ksettings/dispatcher.cpp
>  src/ksettings/dispatcher.h
>  src/ksettings/dispatcher_p.h
>  src/ksettings/pluginpage.cpp
>  src/ksettings/pluginpage.h
>  src/ksettingswidgetadaptor.cpp
>  src/ksettingswidgetadaptor.h
> 
> 
> Diffs
> -
> 
>   COPYING.LGPL-2 PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127960/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maximiliano Curia
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127959: Adding missing license

2016-05-19 Thread Martin Gräßlin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127959/#review95623
---



I would prefer that we properly investigate each of the cases. E.g. 
plasma-framework showed that the files are just incorrectly licensed.

- Martin Gräßlin


On May 19, 2016, 1:50 p.m., Maximiliano Curia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127959/
> ---
> 
> (Updated May 19, 2016, 1:50 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: khtml
> 
> 
> Description
> ---
> 
> We are currently shipping an LGPL-2.1 copy in the COPYING.LIB file, but
> some parts of the code are under a LGPL-2 only license (see:
> autotests/kencodingdetectortest.cpp autotests/kencodingdetectortest.h
> src/html/kopenssl.cpp src/html/kopenssl.h src/khtml_printsettings.cpp
> src/khtml_printsettings.h src/kmultipart/httpfiltergzip.cpp
> src/kmultipart/httpfiltergzip_p.h src/rendering/table_layout.cpp
> src/rendering/table_layout.h) and the LGPL license requires shipping the
> full text with the source code.
> 
> 
> Diffs
> -
> 
>   COPYING.LGPL-2 PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127959/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maximiliano Curia
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127963: Adding missing license

2016-05-19 Thread Marco Martin



> On May 19, 2016, 3:22 p.m., Martin Gräßlin wrote:
> > I think the approach here is wrong. Our frameworks are LGPLv2+. If we have 
> > files which don't match that we need to either change copyright or remove 
> > the files.
> 
> Martin Gräßlin wrote:
> A check shows that examples/kpart and src/kpart are not built at all. 
> They are dead code and could just be removed. src/plasma/private/packageFOO 
> could easily be wrapped by implementing through the newer KPackage framework. 
> servicejob_p.h might just be incorrectly licensed, history needs to be 
> checked as all other files around it are properly or later.
> 
> Martin Gräßlin wrote:
> I just verified for servicejob_p.h, was split out from servicejob.cpp in 
> 89b71cd9f195da51993533f7fc2329ddc08a7de4 of kdelibs

relicensed what i could, and removed the kpart-specific stuff as wasn't built 
anyways


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127963/#review95615
---


On May 19, 2016, 2:37 p.m., Maximiliano Curia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127963/
> ---
> 
> (Updated May 19, 2016, 2:37 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> We are currently shipping an LGPL-2.1 copy in the COPYING.LIB file, but
> some parts of the code are under a LGPL-2 only license and the LGPL
> license requires shipping the full text with the source code.
> 
> The list of LGPL-2 only files is:
>  examples/kpart/containmentshell.cpp
>  examples/kpart/containmentshell.h
>  examples/kpart/main.cpp
>  examples/kpart/testshellpluginloader.cpp
>  examples/kpart/testshellpluginloader.h
>  src/kpart/plasmakpartview.cpp
>  src/kpart/scripting/rect.cpp
>  src/plasma/private/package_p.h
>  src/plasma/private/packagestructure_p.h
>  src/plasma/private/servicejob_p.h
> 
> 
> Diffs
> -
> 
>   COPYING.LGPL-2 PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127963/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maximiliano Curia
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127968: kshareddatacache: Fix invalid use of & to avoid unaligned reads

2016-05-19 Thread Fabian Vogt


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127968/
---

Review request for KDE Frameworks, David Faure and Michael Pyne.


Repository: kcoreaddons


Description
---

That the & is wrong here is obvious:
align can never be 2 inside the if condition as ```(2 & bool)``` is always 
false,
yet the switch on align contains a case for 2.
Instead it drops into the while loop for an 4-byte aligned pointer.

This doesn't change the returned values on platforms where unaligned reads
are permitted, so I didn't bump the version.


Diffs
-

  src/lib/caching/kshareddatacache.cpp 50bbf64 

Diff: https://git.reviewboard.kde.org/r/127968/diff/


Testing
---

Ran make test, all passed.


Thanks,

Fabian Vogt

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127795: [DataEngine] Invalidate DataEngine on unknown plugin + detailed test

2016-05-19 Thread Anthony Fieroni


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127795/
---

(Updated May 19, 2016, 7:46 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Marco Martin.


Changes
---

Submitted with commit 2275db4b397d66114e05f434d5a90dadc2ec14fb by Anthony 
Fieroni to branch master.


Repository: plasma-framework


Description
---

^^


Diffs
-

  autotests/pluginloadertest.h 61fc963 
  autotests/pluginloadertest.cpp 4f96780 
  src/plasma/dataengine.cpp f942926 

Diff: https://git.reviewboard.kde.org/r/127795/diff/


Testing
---

Test pass.


Thanks,

Anthony Fieroni

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 54 - Unstable!

2016-05-19 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/54/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Thu, 19 May 2016 19:46:26 +
Build duration: 2 min 14 sec

CHANGE SET
Revision 2275db4b397d66114e05f434d5a90dadc2ec14fb by bvbfan: ([dataengine]If 
the DataEngine constructor is called with an invalid)
  change: edit src/plasma/dataengine.cpp
  change: edit autotests/pluginloadertest.h
  change: edit autotests/pluginloadertest.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 
13 test(s)Failed: TestSuite.plasma-pluginloadertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 8/8 (100%)FILES 79/111 (71%)CLASSES 79/111 (71%)LINE 4488/11256 
(40%)CONDITIONAL 2327/8375 (28%)

By packages
  
autotests
FILES 24/24 (100%)CLASSES 24/24 (100%)LINE 885/937 
(94%)CONDITIONAL 578/1132 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 545/1847 
(30%)CONDITIONAL 202/1132 (18%)
src.plasma
FILES 16/20 (80%)CLASSES 16/20 (80%)LINE 1716/3628 
(47%)CONDITIONAL 966/2738 (35%)
src.plasma.private
FILES 18/24 (75%)CLASSES 18/24 (75%)LINE 963/1721 
(56%)CONDITIONAL 426/1006 (42%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 37/181 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 300/1671 
(18%)CONDITIONAL 133/1277 (10%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1158 (1%)CONDITIONAL 
2/962 (0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 55 - Unstable!

2016-05-19 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/55/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Thu, 19 May 2016 19:46:26 +
Build duration: 2 min 22 sec

CHANGE SET
Revision 2275db4b397d66114e05f434d5a90dadc2ec14fb by bvbfan: ([dataengine]If 
the DataEngine constructor is called with an invalid)
  change: edit autotests/pluginloadertest.cpp
  change: edit src/plasma/dataengine.cpp
  change: edit autotests/pluginloadertest.h


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 
13 test(s)Failed: TestSuite.plasma-pluginloadertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 8/8 (100%)FILES 79/111 (71%)CLASSES 79/111 (71%)LINE 4486/11256 
(40%)CONDITIONAL 2326/8375 (28%)

By packages
  
autotests
FILES 24/24 (100%)CLASSES 24/24 (100%)LINE 883/937 
(94%)CONDITIONAL 578/1132 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 545/1847 
(30%)CONDITIONAL 202/1132 (18%)
src.plasma
FILES 16/20 (80%)CLASSES 16/20 (80%)LINE 1716/3628 
(47%)CONDITIONAL 966/2738 (35%)
src.plasma.private
FILES 18/24 (75%)CLASSES 18/24 (75%)LINE 963/1721 
(56%)CONDITIONAL 425/1006 (42%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 37/181 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 300/1671 
(18%)CONDITIONAL 133/1277 (10%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1158 (1%)CONDITIONAL 
2/962 (0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 55 - Unstable!

2016-05-19 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/55/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Thu, 19 May 2016 19:46:26 +
Build duration: 9 min 48 sec

CHANGE SET
Revision 2275db4b397d66114e05f434d5a90dadc2ec14fb by bvbfan: ([dataengine]If 
the DataEngine constructor is called with an invalid)
  change: edit src/plasma/dataengine.cpp
  change: edit autotests/pluginloadertest.h
  change: edit autotests/pluginloadertest.cpp


JUNIT RESULTS

Name: (root) Failed: 9 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 
14 test(s)Failed: TestSuite.coronatestFailed: TestSuite.dialognativetestFailed: 
TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-framesvgtestFailed: 
TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-pluginloadertestFailed: 
TestSuite.plasma-sortfiltermodeltestFailed: TestSuite.plasma-storagetestFailed: 
TestSuite.plasma-themetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 47/94 (50%)CLASSES 47/94 (50%)LINE 2445/9867 
(25%)CONDITIONAL 1253/6981 (18%)

By packages
  
autotests
FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 272/286 
(95%)CONDITIONAL 190/382 (50%)
src.declarativeimports.core
FILES 7/18 (39%)CLASSES 7/18 (39%)LINE 209/2071 
(10%)CONDITIONAL 49/1278 (4%)
src.plasma
FILES 11/20 (55%)CLASSES 11/20 (55%)LINE 1029/3628 
(28%)CONDITIONAL 596/2738 (22%)
src.plasma.private
FILES 12/26 (46%)CLASSES 12/26 (46%)LINE 563/1794 
(31%)CONDITIONAL 223/1052 (21%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/181 (0%)CONDITIONAL 0/106 
(0%)
src.plasmaquick
FILES 5/12 (42%)CLASSES 5/12 (42%)LINE 372/1794 
(21%)CONDITIONAL 195/1403 (14%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/22 
(0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 54 - Unstable!

2016-05-19 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/54/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Thu, 19 May 2016 19:46:26 +
Build duration: 10 min

CHANGE SET
Revision 2275db4b397d66114e05f434d5a90dadc2ec14fb by bvbfan: ([dataengine]If 
the DataEngine constructor is called with an invalid)
  change: edit src/plasma/dataengine.cpp
  change: edit autotests/pluginloadertest.h
  change: edit autotests/pluginloadertest.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 
14 test(s)Failed: TestSuite.plasma-pluginloadertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 8/8 (100%)FILES 82/115 (71%)CLASSES 82/115 (71%)LINE 4934/11723 
(42%)CONDITIONAL 2620/8725 (30%)

By packages
  
autotests
FILES 26/26 (100%)CLASSES 26/26 (100%)LINE 930/984 
(95%)CONDITIONAL 594/1164 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 635/2071 
(31%)CONDITIONAL 288/1278 (23%)
src.plasma
FILES 16/20 (80%)CLASSES 16/20 (80%)LINE 1718/3628 
(47%)CONDITIONAL 971/2738 (35%)
src.plasma.private
FILES 19/26 (73%)CLASSES 19/26 (73%)LINE 1030/1794 
(57%)CONDITIONAL 453/1052 (43%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 37/181 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 542/1794 
(30%)CONDITIONAL 292/1403 (21%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1158 (1%)CONDITIONAL 
2/962 (0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127948: Avoid skipping KAuthorized check

2016-05-19 Thread David Edmundson


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127948/
---

(Updated May 19, 2016, 8:17 p.m.)


Review request for KDE Frameworks and Matthew Dawson.


Changes
---

Wrote a test. 
It fails without my fix, it passes with the fix.


Repository: kconfig


Description
---

Previously, if a .desktop file had a TryExec and a X-KDE-AuthorizeAction
entry we would skip the KAuthorized check. This is clearly wrong.


Diffs (updated)
-

  autotests/kdesktopfiletest.h f4e0c96b8751b2b116b98a52553ad6698b9d40b4 
  autotests/kdesktopfiletest.cpp a90faf3ca44b6a8f5d7d7c9de4d58d17ba360d16 
  src/core/kdesktopfile.cpp eda7c292da9aa2bc97f6066e90034767134c2e07 

Diff: https://git.reviewboard.kde.org/r/127948/diff/


Testing
---

Disabled shell_access in kde5rc.

With I was unable to open konsole from kicker.
Opening dolphin still worked as normal.


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127948: Avoid skipping KAuthorized check

2016-05-19 Thread Matthew Dawson


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127948/#review95627
---


Fix it, then Ship it!




Excellent, thanks!  Just one comment below about the name of the test.  If that 
name is good with you, feel free to change + push.


autotests/kdesktopfiletest.h (line 36)


Can you change this name to ```testTryExecWithAuthorizeAction```?  
testTryExec sound like it is testing TryExec in general, which is being tested 
above.  That name is hopefully a little more descriptive of the issue under 
test.


- Matthew Dawson


On May 19, 2016, 4:17 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127948/
> ---
> 
> (Updated May 19, 2016, 4:17 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> Previously, if a .desktop file had a TryExec and a X-KDE-AuthorizeAction
> entry we would skip the KAuthorized check. This is clearly wrong.
> 
> 
> Diffs
> -
> 
>   autotests/kdesktopfiletest.h f4e0c96b8751b2b116b98a52553ad6698b9d40b4 
>   autotests/kdesktopfiletest.cpp a90faf3ca44b6a8f5d7d7c9de4d58d17ba360d16 
>   src/core/kdesktopfile.cpp eda7c292da9aa2bc97f6066e90034767134c2e07 
> 
> Diff: https://git.reviewboard.kde.org/r/127948/diff/
> 
> 
> Testing
> ---
> 
> Disabled shell_access in kde5rc.
> 
> With I was unable to open konsole from kicker.
> Opening dolphin still worked as normal.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127948: Avoid skipping KAuthorized check

2016-05-19 Thread David Edmundson


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127948/
---

(Updated May 19, 2016, 9:19 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Matthew Dawson.


Changes
---

Submitted with commit b1c64c165eb7e498f6cfed65e2d439d86f21a116 by David 
Edmundson to branch master.


Repository: kconfig


Description
---

Previously, if a .desktop file had a TryExec and a X-KDE-AuthorizeAction
entry we would skip the KAuthorized check. This is clearly wrong.


Diffs
-

  autotests/kdesktopfiletest.h f4e0c96b8751b2b116b98a52553ad6698b9d40b4 
  autotests/kdesktopfiletest.cpp a90faf3ca44b6a8f5d7d7c9de4d58d17ba360d16 
  src/core/kdesktopfile.cpp eda7c292da9aa2bc97f6066e90034767134c2e07 

Diff: https://git.reviewboard.kde.org/r/127948/diff/


Testing
---

Disabled shell_access in kde5rc.

With I was unable to open konsole from kicker.
Opening dolphin still worked as normal.


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127971: [KToolBar] Disable toggleViewAction() when actions/options_show_toolbar is restricted

2016-05-19 Thread Kai Uwe Broulik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127971/
---

Review request for KDE Frameworks and Plasma.


Repository: kxmlgui


Description
---

While KXmlGui makes sure to prevent the user from hiding toolbars when not 
allowed, right-clicking an empty space in a QMainWindow, such as the menu bar, 
will yield a menu created by Qt, which knows nothing about Kiosk restrictions, 
listing all toolbar toggle actions of this window.


Diffs
-

  autotests/ktoolbar_unittest.cpp d6c1e05 
  src/ktoolbar.cpp 8fcb9cb 

Diff: https://git.reviewboard.kde.org/r/127971/diff/


Testing
---

Comes with a unittest.

I can no longer hide the main toolbar in Dolphin or Gwenview when this action 
is restricted by simply right-clicking the menu bar.


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127971: [KToolBar] Disable toggleViewAction() when actions/options_show_toolbar is restricted

2016-05-19 Thread David Edmundson


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127971/#review95628
---



+1


src/ktoolbar.cpp (line 815)


if you put this in Private::init() you'll only have to do it once.


- David Edmundson


On May 19, 2016, 9:26 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127971/
> ---
> 
> (Updated May 19, 2016, 9:26 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> ---
> 
> While KXmlGui makes sure to prevent the user from hiding toolbars when not 
> allowed, right-clicking an empty space in a QMainWindow, such as the menu 
> bar, will yield a menu created by Qt, which knows nothing about Kiosk 
> restrictions, listing all toolbar toggle actions of this window.
> 
> 
> Diffs
> -
> 
>   autotests/ktoolbar_unittest.cpp d6c1e05 
>   src/ktoolbar.cpp 8fcb9cb 
> 
> Diff: https://git.reviewboard.kde.org/r/127971/diff/
> 
> 
> Testing
> ---
> 
> Comes with a unittest.
> 
> I can no longer hide the main toolbar in Dolphin or Gwenview when this action 
> is restricted by simply right-clicking the menu bar.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127971: [KToolBar] Disable toggleViewAction() when actions/options_show_toolbar is restricted

2016-05-19 Thread Kai Uwe Broulik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127971/
---

(Updated Mai 19, 2016, 9:35 nachm.)


Review request for KDE Frameworks and Plasma.


Changes
---

* Added screenshot of the menu

The menu is created by QMainWindow when you right-click an empty area in the 
window. Its createPopupMenu() is virtual but we cannot subclass it in 
KMainWindow without breaking ABI


Repository: kxmlgui


Description
---

While KXmlGui makes sure to prevent the user from hiding toolbars when not 
allowed, right-clicking an empty space in a QMainWindow, such as the menu bar, 
will yield a menu created by Qt, which knows nothing about Kiosk restrictions, 
listing all toolbar toggle actions of this window.


Diffs
-

  autotests/ktoolbar_unittest.cpp d6c1e05 
  src/ktoolbar.cpp 8fcb9cb 

Diff: https://git.reviewboard.kde.org/r/127971/diff/


Testing
---

Comes with a unittest.

I can no longer hide the main toolbar in Dolphin or Gwenview when this action 
is restricted by simply right-clicking the menu bar.


File Attachments (updated)


The Menu
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/05/19/076745b4-03a2-400f-9506-46999d4ce1e1__toolbartoggle.png


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127971: [KToolBar] Disable toggleViewAction() when actions/options_show_toolbar is restricted

2016-05-19 Thread Kai Uwe Broulik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127971/
---

(Updated Mai 19, 2016, 9:37 nachm.)


Review request for KDE Frameworks and Plasma.


Changes
---

* Move KAuthorized check to the other one in Private::init


Repository: kxmlgui


Description
---

While KXmlGui makes sure to prevent the user from hiding toolbars when not 
allowed, right-clicking an empty space in a QMainWindow, such as the menu bar, 
will yield a menu created by Qt, which knows nothing about Kiosk restrictions, 
listing all toolbar toggle actions of this window.


Diffs (updated)
-

  autotests/ktoolbar_unittest.cpp d6c1e05 
  src/ktoolbar.cpp 8fcb9cb 

Diff: https://git.reviewboard.kde.org/r/127971/diff/


Testing
---

Comes with a unittest.

I can no longer hide the main toolbar in Dolphin or Gwenview when this action 
is restricted by simply right-clicking the menu bar.


File Attachments


The Menu
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/05/19/076745b4-03a2-400f-9506-46999d4ce1e1__toolbartoggle.png


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127972: Always update the Predicate parser from y/l sources

2016-05-19 Thread Pino Toscano


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127972/
---

Review request for KDE Frameworks and Lukáš Tinkl.


Repository: solid


Description
---

Turn Flex and Bison into required build dependencies, and use them to always 
regenerate at build time the Predicate parser. This ensures that the parser 
does not rot, and there is no more need to rely on autogenerated sources added 
statically among the others.

Second commit: remove old generated files of Predicate parser


Diffs
-

  CMakeLists.txt 763e09cfeeebdc9e42b68e8ab6c9e29c54d3e741 
  src/solid/CMakeLists.txt f2b43b27cb47531ed57b2eccafad8e67951b56b9 
  src/solid/devices/CMakeLists.txt 9271ae1e36b67b112be54a6ff9c6fb76a8a0a824 
  src/solid/devices/predicate_lexer.c 3b5a0b90907baf1cd2631da4de650ec153d0f642 
  src/solid/devices/predicate_parser.h 68e25070d498f5a635489af51f4b772c5f374108 
  src/solid/devices/predicate_parser.c 6d35ff25f001a43cbfecacc11e7d7591bb4808f9 

Diff: https://git.reviewboard.kde.org/r/127972/diff/


Testing
---

Builds fine with flex 2.6.0 and bison 3.0.4; `make test` passes too.


Thanks,

Pino Toscano

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127972: Always update the Predicate parser from y/l sources

2016-05-19 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127972/#review95629
---



This has been like this for years. Has any of the premises changed?

- Aleix Pol Gonzalez


On May 20, 2016, 12:19 a.m., Pino Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127972/
> ---
> 
> (Updated May 20, 2016, 12:19 a.m.)
> 
> 
> Review request for KDE Frameworks and Lukáš Tinkl.
> 
> 
> Repository: solid
> 
> 
> Description
> ---
> 
> Turn Flex and Bison into required build dependencies, and use them to always 
> regenerate at build time the Predicate parser. This ensures that the parser 
> does not rot, and there is no more need to rely on autogenerated sources 
> added statically among the others.
> 
> Second commit: remove old generated files of Predicate parser
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 763e09cfeeebdc9e42b68e8ab6c9e29c54d3e741 
>   src/solid/CMakeLists.txt f2b43b27cb47531ed57b2eccafad8e67951b56b9 
>   src/solid/devices/CMakeLists.txt 9271ae1e36b67b112be54a6ff9c6fb76a8a0a824 
>   src/solid/devices/predicate_lexer.c 
> 3b5a0b90907baf1cd2631da4de650ec153d0f642 
>   src/solid/devices/predicate_parser.h 
> 68e25070d498f5a635489af51f4b772c5f374108 
>   src/solid/devices/predicate_parser.c 
> 6d35ff25f001a43cbfecacc11e7d7591bb4808f9 
> 
> Diff: https://git.reviewboard.kde.org/r/127972/diff/
> 
> 
> Testing
> ---
> 
> Builds fine with flex 2.6.0 and bison 3.0.4; `make test` passes too.
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127968: kshareddatacache: Fix invalid use of & to avoid unaligned reads

2016-05-19 Thread Michael Pyne


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127968/#review95630
---


Ship it!




This is an error upstream in the MurmurHash 1.0 aligned implementation (which 
still contains the error, see 
https://sites.google.com/site/murmurhash/MurmurHashAligned.cpp?attredirects=0 )

In our case KSharedDataCache will never pass an unaligned block into the hash 
function so 'align' was always 0 (and boolean false) anyways. So I concur with 
not bumping the cache version and agree with your patch. Thanks for taking a 
look!

- Michael Pyne


On May 19, 2016, 6:13 p.m., Fabian Vogt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127968/
> ---
> 
> (Updated May 19, 2016, 6:13 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Michael Pyne.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> That the & is wrong here is obvious:
> align can never be 2 inside the if condition as ```(2 & bool)``` is always 
> false,
> yet the switch on align contains a case for 2.
> Instead it drops into the while loop for an 4-byte aligned pointer.
> 
> This doesn't change the returned values on platforms where unaligned reads
> are permitted, so I didn't bump the version.
> 
> 
> Diffs
> -
> 
>   src/lib/caching/kshareddatacache.cpp 50bbf64 
> 
> Diff: https://git.reviewboard.kde.org/r/127968/diff/
> 
> 
> Testing
> ---
> 
> Ran make test, all passed.
> 
> 
> Thanks,
> 
> Fabian Vogt
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127973: Fix window in which the file containing the X11 cookie has the wrong permissions

2016-05-19 Thread Albert Astals Cid


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127973/
---

Review request for KDE Frameworks and David Faure.


Repository: kinit


Description
---

if someone is very fast can watch the file between the open and the 
setPermissions


Diffs
-

  src/kdeinit/kinit.cpp 19e38b8 

Diff: https://git.reviewboard.kde.org/r/127973/diff/


Testing
---

works


Thanks,

Albert Astals Cid

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127973: Fix race in which the file containing the X11 cookie has the wrong permissions

2016-05-19 Thread Albert Astals Cid


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127973/
---

(Updated May 19, 2016, 11:38 p.m.)


Review request for KDE Frameworks and David Faure.


Summary (updated)
-

Fix race in which the file containing the X11 cookie has the wrong permissions


Repository: kinit


Description
---

if someone is very fast can watch the file between the open and the 
setPermissions


Diffs
-

  src/kdeinit/kinit.cpp 19e38b8 

Diff: https://git.reviewboard.kde.org/r/127973/diff/


Testing
---

works


Thanks,

Albert Astals Cid

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127973: Fix race in which the file containing the X11 cookie has the wrong permissions

2016-05-19 Thread Albert Astals Cid


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127973/#review95631
---



https://codereview.qt-project.org/#/c/159689/ would fix it too

- Albert Astals Cid


On May 19, 2016, 11:38 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127973/
> ---
> 
> (Updated May 19, 2016, 11:38 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kinit
> 
> 
> Description
> ---
> 
> if someone is very fast can watch the file between the open and the 
> setPermissions
> 
> 
> Diffs
> -
> 
>   src/kdeinit/kinit.cpp 19e38b8 
> 
> Diff: https://git.reviewboard.kde.org/r/127973/diff/
> 
> 
> Testing
> ---
> 
> works
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127747: Create a new script that generate the documentation for all projects following the syntax I proposed

2016-05-19 Thread Michael Pyne


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127747/#review95632
---



I've looked at the code itself and it seems reasonable, so from that 
perspective and given the length of time there's been no -1's, I think it's 
safe to commit.

However you mentioned in the description that this isn't safe to commit to 
master. I have no clue how we generate apidox for KF5 and Plasma 5 so I'm not 
sure what you mean when you say we'd affect the currents script. What is your 
plan for integrating this without breaking the scripts? Is there work needed by 
others (sysadmin, EBN, etc.) to make apidox generation work with your patch 
committed? What's the action KDE developers must take after this, if any?

- Michael Pyne


On April 25, 2016, 9:49 p.m., Olivier Churlaud wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127747/
> ---
> 
> (Updated April 25, 2016, 9:49 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Alex Merry, Aurélien 
> Gâteau, and Allen Winter.
> 
> 
> Repository: kapidox
> 
> 
> Description
> ---
> 
> Keep in mind that it should not plainly replace kgenframeworks but be used by 
> all KDE projects. So in this proposition, the Frameworks are just one project 
> in others.
> 
> The code can be tested directly by checking the branch 
> `olivier/generate_all_repos`.
> 
> This MUST NOT be merged in master, because it will break the currents scripts 
> (see commit 3643dded7cf14a5634879e8e6e34be8840143d7e).
> 
> 
> Diffs
> -
> 
>   konqi_frameworks.png PRE-CREATION 
>   metainfo.yaml 4ff17c8 
>   metainfo_syntax.md PRE-CREATION 
>   src/kapidox/data/htmlresource/default_product.png PRE-CREATION 
>   src/kapidox/data/htmlresource/kde.css b864ef5 
>   src/kapidox/data/templates/doxygen2.html PRE-CREATION 
>   src/kapidox/data/templates/frontpage.html PRE-CREATION 
>   src/kapidox/data/templates/libinfo.html PRE-CREATION 
>   src/kapidox/data/templates/maintainers.html PRE-CREATION 
>   src/kapidox/data/templates/subgroup.html PRE-CREATION 
>   src/kapidox/generator.py 5b8ae40 
>   src/newkapidox.py PRE-CREATION 
>   src/notes PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127747/diff/
> 
> 
> Testing
> ---
> 
> Tested on various scenario cases.
> 
> 
> File Attachments
> 
> 
> This is an example of what I generated. (Threadweaver is duplicated and 
> modified to test different scenarios)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/25/2e4549e4-7c17-416c-9a72-b82d3bba18b3__doc.tar.gz
> 
> 
> Thanks,
> 
> Olivier Churlaud
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127973: Fix race in which the file containing the X11 cookie has the wrong permissions

2016-05-19 Thread Michael Pyne


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127973/#review95633
---


Ship it!




I think a comment to the intent would be appropriate (e.g. 'Avoid race in 
restricting cookie file perms' or something like that) but the change looks 
correct to me.

- Michael Pyne


On May 19, 2016, 11:38 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127973/
> ---
> 
> (Updated May 19, 2016, 11:38 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kinit
> 
> 
> Description
> ---
> 
> if someone is very fast can watch the file between the open and the 
> setPermissions
> 
> 
> Diffs
> -
> 
>   src/kdeinit/kinit.cpp 19e38b8 
> 
> Diff: https://git.reviewboard.kde.org/r/127973/diff/
> 
> 
> Testing
> ---
> 
> works
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127972: Always update the Predicate parser from y/l sources

2016-05-19 Thread Michael Pyne



> On May 19, 2016, 10:30 p.m., Aleix Pol Gonzalez wrote:
> > This has been like this for years. Has any of the premises changed?

I think it's a good idea, if only to keep up with changes to the generated 
sources to account for things like undefined behavior fixes, fixes for new 
compiler warnings, etc. Some of our users will build with updated bison/flex 
(and I believe they're both required for KHTML still already) so it's best to 
limit the number of different versions of generated parsers out there, IMHO.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127972/#review95629
---


On May 19, 2016, 10:19 p.m., Pino Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127972/
> ---
> 
> (Updated May 19, 2016, 10:19 p.m.)
> 
> 
> Review request for KDE Frameworks and Lukáš Tinkl.
> 
> 
> Repository: solid
> 
> 
> Description
> ---
> 
> Turn Flex and Bison into required build dependencies, and use them to always 
> regenerate at build time the Predicate parser. This ensures that the parser 
> does not rot, and there is no more need to rely on autogenerated sources 
> added statically among the others.
> 
> Second commit: remove old generated files of Predicate parser
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 763e09cfeeebdc9e42b68e8ab6c9e29c54d3e741 
>   src/solid/CMakeLists.txt f2b43b27cb47531ed57b2eccafad8e67951b56b9 
>   src/solid/devices/CMakeLists.txt 9271ae1e36b67b112be54a6ff9c6fb76a8a0a824 
>   src/solid/devices/predicate_lexer.c 
> 3b5a0b90907baf1cd2631da4de650ec153d0f642 
>   src/solid/devices/predicate_parser.h 
> 68e25070d498f5a635489af51f4b772c5f374108 
>   src/solid/devices/predicate_parser.c 
> 6d35ff25f001a43cbfecacc11e7d7591bb4808f9 
> 
> Diff: https://git.reviewboard.kde.org/r/127972/diff/
> 
> 
> Testing
> ---
> 
> Builds fine with flex 2.6.0 and bison 3.0.4; `make test` passes too.
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127747: Create a new script that generate the documentation for all projects following the syntax I proposed

2016-05-19 Thread Olivier Churlaud



> On May 20, 2016, 3:50 a.m., Michael Pyne wrote:
> > I've looked at the code itself and it seems reasonable, so from that 
> > perspective and given the length of time there's been no -1's, I think it's 
> > safe to commit.
> > 
> > However you mentioned in the description that this isn't safe to commit to 
> > master. I have no clue how we generate apidox for KF5 and Plasma 5 so I'm 
> > not sure what you mean when you say we'd affect the currents script. What 
> > is your plan for integrating this without breaking the scripts? Is there 
> > work needed by others (sysadmin, EBN, etc.) to make apidox generation work 
> > with your patch committed? What's the action KDE developers must take after 
> > this, if any?

Thank you for the review Michel. The only need will be to update the 
metainfo.yml. I can do that for the frameworks if needed after commiting. Or I 
can even do this before so that it doesn't break.

Commit plan:
1) update frameworks metainfo (they are back-compatibles but the *new* script 
will break with the old metainfo.
2) commit in master
3) See if everything works as expected else correct.
4) Clean up the code and teach it new tricks ; Add other projects that the 
frameworks.


- Olivier


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127747/#review95632
---


On April 25, 2016, 11:49 p.m., Olivier Churlaud wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127747/
> ---
> 
> (Updated April 25, 2016, 11:49 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Alex Merry, Aurélien 
> Gâteau, and Allen Winter.
> 
> 
> Repository: kapidox
> 
> 
> Description
> ---
> 
> Keep in mind that it should not plainly replace kgenframeworks but be used by 
> all KDE projects. So in this proposition, the Frameworks are just one project 
> in others.
> 
> The code can be tested directly by checking the branch 
> `olivier/generate_all_repos`.
> 
> This MUST NOT be merged in master, because it will break the currents scripts 
> (see commit 3643dded7cf14a5634879e8e6e34be8840143d7e).
> 
> 
> Diffs
> -
> 
>   konqi_frameworks.png PRE-CREATION 
>   metainfo.yaml 4ff17c8 
>   metainfo_syntax.md PRE-CREATION 
>   src/kapidox/data/htmlresource/default_product.png PRE-CREATION 
>   src/kapidox/data/htmlresource/kde.css b864ef5 
>   src/kapidox/data/templates/doxygen2.html PRE-CREATION 
>   src/kapidox/data/templates/frontpage.html PRE-CREATION 
>   src/kapidox/data/templates/libinfo.html PRE-CREATION 
>   src/kapidox/data/templates/maintainers.html PRE-CREATION 
>   src/kapidox/data/templates/subgroup.html PRE-CREATION 
>   src/kapidox/generator.py 5b8ae40 
>   src/newkapidox.py PRE-CREATION 
>   src/notes PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127747/diff/
> 
> 
> Testing
> ---
> 
> Tested on various scenario cases.
> 
> 
> File Attachments
> 
> 
> This is an example of what I generated. (Threadweaver is duplicated and 
> modified to test different scenarios)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/25/2e4549e4-7c17-416c-9a72-b82d3bba18b3__doc.tar.gz
> 
> 
> Thanks,
> 
> Olivier Churlaud
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127747: Create a new script that generate the documentation for all projects following the syntax I proposed

2016-05-19 Thread Olivier Churlaud



> On May 20, 2016, 3:50 a.m., Michael Pyne wrote:
> > I've looked at the code itself and it seems reasonable, so from that 
> > perspective and given the length of time there's been no -1's, I think it's 
> > safe to commit.
> > 
> > However you mentioned in the description that this isn't safe to commit to 
> > master. I have no clue how we generate apidox for KF5 and Plasma 5 so I'm 
> > not sure what you mean when you say we'd affect the currents script. What 
> > is your plan for integrating this without breaking the scripts? Is there 
> > work needed by others (sysadmin, EBN, etc.) to make apidox generation work 
> > with your patch committed? What's the action KDE developers must take after 
> > this, if any?
> 
> Olivier Churlaud wrote:
> Thank you for the review Michel. The only need will be to update the 
> metainfo.yml. I can do that for the frameworks if needed after commiting. Or 
> I can even do this before so that it doesn't break.
> 
> Commit plan:
> 1) update frameworks metainfo (they are back-compatibles but the *new* 
> script will break with the old metainfo.
> 2) commit in master
> 3) See if everything works as expected else correct.
> 4) Clean up the code and teach it new tricks ; Add other projects that 
> the frameworks.

Oh and maybe the current folder containing the html pages should be removed as 
well.


- Olivier


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127747/#review95632
---


On April 25, 2016, 11:49 p.m., Olivier Churlaud wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127747/
> ---
> 
> (Updated April 25, 2016, 11:49 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Alex Merry, Aurélien 
> Gâteau, and Allen Winter.
> 
> 
> Repository: kapidox
> 
> 
> Description
> ---
> 
> Keep in mind that it should not plainly replace kgenframeworks but be used by 
> all KDE projects. So in this proposition, the Frameworks are just one project 
> in others.
> 
> The code can be tested directly by checking the branch 
> `olivier/generate_all_repos`.
> 
> This MUST NOT be merged in master, because it will break the currents scripts 
> (see commit 3643dded7cf14a5634879e8e6e34be8840143d7e).
> 
> 
> Diffs
> -
> 
>   konqi_frameworks.png PRE-CREATION 
>   metainfo.yaml 4ff17c8 
>   metainfo_syntax.md PRE-CREATION 
>   src/kapidox/data/htmlresource/default_product.png PRE-CREATION 
>   src/kapidox/data/htmlresource/kde.css b864ef5 
>   src/kapidox/data/templates/doxygen2.html PRE-CREATION 
>   src/kapidox/data/templates/frontpage.html PRE-CREATION 
>   src/kapidox/data/templates/libinfo.html PRE-CREATION 
>   src/kapidox/data/templates/maintainers.html PRE-CREATION 
>   src/kapidox/data/templates/subgroup.html PRE-CREATION 
>   src/kapidox/generator.py 5b8ae40 
>   src/newkapidox.py PRE-CREATION 
>   src/notes PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127747/diff/
> 
> 
> Testing
> ---
> 
> Tested on various scenario cases.
> 
> 
> File Attachments
> 
> 
> This is an example of what I generated. (Threadweaver is duplicated and 
> modified to test different scenarios)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/25/2e4549e4-7c17-416c-9a72-b82d3bba18b3__doc.tar.gz
> 
> 
> Thanks,
> 
> Olivier Churlaud
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127972: Always update the Predicate parser from y/l sources

2016-05-19 Thread Pino Toscano



> On May 19, 2016, 10:30 p.m., Aleix Pol Gonzalez wrote:
> > This has been like this for years. Has any of the premises changed?
> 
> Michael Pyne wrote:
> I think it's a good idea, if only to keep up with changes to the 
> generated sources to account for things like undefined behavior fixes, fixes 
> for new compiler warnings, etc. Some of our users will build with updated 
> bison/flex (and I believe they're both required for KHTML still already) so 
> it's best to limit the number of different versions of generated parsers out 
> there, IMHO.

Before this RR, I fixed with commit b3d52004b0f1af0abd0a2ca907a7c857293dce36 
the predicate grammar, which was producing a non-compiling source; also, the 
current `UpdateSolidPredicateParser` rule is broken. These led me thinking that 
nobody really run the rule in years, which is not good.

Additionally, generated sources added statically in the source tree is really a 
bad idea.


- Pino


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127972/#review95629
---


On May 19, 2016, 10:19 p.m., Pino Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127972/
> ---
> 
> (Updated May 19, 2016, 10:19 p.m.)
> 
> 
> Review request for KDE Frameworks and Lukáš Tinkl.
> 
> 
> Repository: solid
> 
> 
> Description
> ---
> 
> Turn Flex and Bison into required build dependencies, and use them to always 
> regenerate at build time the Predicate parser. This ensures that the parser 
> does not rot, and there is no more need to rely on autogenerated sources 
> added statically among the others.
> 
> Second commit: remove old generated files of Predicate parser
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 763e09cfeeebdc9e42b68e8ab6c9e29c54d3e741 
>   src/solid/CMakeLists.txt f2b43b27cb47531ed57b2eccafad8e67951b56b9 
>   src/solid/devices/CMakeLists.txt 9271ae1e36b67b112be54a6ff9c6fb76a8a0a824 
>   src/solid/devices/predicate_lexer.c 
> 3b5a0b90907baf1cd2631da4de650ec153d0f642 
>   src/solid/devices/predicate_parser.h 
> 68e25070d498f5a635489af51f4b772c5f374108 
>   src/solid/devices/predicate_parser.c 
> 6d35ff25f001a43cbfecacc11e7d7591bb4808f9 
> 
> Diff: https://git.reviewboard.kde.org/r/127972/diff/
> 
> 
> Testing
> ---
> 
> Builds fine with flex 2.6.0 and bison 3.0.4; `make test` passes too.
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

2016-05-19 Thread Martin Gräßlin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127809/#review95638
---


Ship it!




Sorry for the hard review.

- Martin Gräßlin


On May 18, 2016, 10:06 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127809/
> ---
> 
> (Updated May 18, 2016, 10:06 a.m.)
> 
> 
> Review request for KDE Frameworks, KDE Usability and Martin Gräßlin.
> 
> 
> Bugs: 362324
> https://bugs.kde.org/show_bug.cgi?id=362324
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> The api function is KWindowSystem::icon (WId win, int width=-1, int 
> height=-1, bool scale=false) so caller must get best size not worst when 
> width/height is not specified.
> 
> 
> Diffs
> -
> 
>   src/platforms/xcb/kwindowsystem.cpp 5b7c65a 
> 
> Diff: https://git.reviewboard.kde.org/r/127809/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/05/01/6d718ef6-26cf-4866-94d2-4ffbdfc906fe__Screenshot_20160426_232109.png
> after
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/05/01/7dcab4ae-e451-4d43-8799-a0fcab471a3d__Screenshot_20160501_224642.png
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2016-05-19 Thread Martin Gräßlin



> On May 17, 2016, 4:37 p.m., Martin Gräßlin wrote:
> > given that Plasma integration got removed I suggest to create a dedicated 
> > osx-integration repository for it as well.
> 
> René J.V. Bertin wrote:
> I quite like the way things are, but yes, I've played with that idea. 
> 
> I guess I can simply fork `frameworkintegration`, change the project name 
> in the toplevel CMake file and strip everything except for the platformtheme.
> 
> How does this work from that point onwards?
> 
> Martin Gräßlin wrote:
> > I guess I can simply fork frameworkintegration, change the project name 
> in the toplevel CMake file and strip everything except for the platformtheme.
> 
> That's kind of how I did it for plasma-integration with git filter-tree.
> 
> > How does this work from that point onwards?
> 
> My suggestion would be to create something like an "OSX integration" 
> project in the metadata and have then all your repositories grouped there 
> including the new platform theme.
> 
> René J.V. Bertin wrote:
> This is something I'm completely new to; what metadata are we talking 
> about here?
> Also, can anyone with commit access to existing repositories also create 
> new ones on the server, and in what category would you suggest putting this?
> 
> Boudhayan Gupta wrote:
> For now, start with a scratch repo. Sysadmin will take care of the rest 
> for you.
> 
> René J.V. Bertin wrote:
> As I said, creating or proposing a new KDE package/repository is 
> completely new for me, even that instruction is still ambiguous. I take it 
> you're not talking about a scratch repo that exists only on one of my disks, 
> possibly not even on a remote mirror like github, but rather something that 
> would alert the sysadmins who will then take the appropriate actions?
> 
> I guess I should look through the developer/contributor instructions 
> again, I most certainly skipped this level of information when I first (and 
> last...) read that documentation.
> 
> Elvis Angelaccio wrote:
> Here you can find the instructions to create a scratch repo: 
> https://community.kde.org/Sysadmin/GitKdeOrgManual#Personal_scratch_repositories
> 
> René J.V. Bertin wrote:
> ah, great, thanks. Looks exactly what I need except that it doesn't 
> appear to say anything about the metadata Martin mentions. But it's a start :)

The metadata is in kde-build-metadata.git 
(https://quickgit.kde.org/?p=kde-build-metadata.git )


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126198/#review95538
---


On May 16, 2016, 9:49 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126198/
> ---
> 
> (Updated May 16, 2016, 9:49 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X, KDE Frameworks, Plasma, and 
> Valorie Zimmerman.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> The KdePlatformTheme plugin can be enabled on OS X with a minimal patch to 
> Qt5; all that is required is to include the `qgenericunixservices` and 
> `qgenericunixthemes` components in the build, and to append `"kde"` to the 
> list returned by `QCocoaIntegration::themeNames()` for instance under the 
> condition that `KDE_SESSION_VERSION` is set to a suitable value in the 
> environment.
> 
> This will allow KF5 and Qt5 applications to use the theme selected through 
> KDE if FrameworkIntegration is installed and KDE_SESSION_VERSION is set, 
> which seems like a sufficiently specific set of conditions that is easy to 
> avoid by users who prefer to use the Mac native theme.
> 
> While requestion the KDE theme is also possible through `-style kde` or `env 
> QT_STYLE_OVERRIDE=kde` the use of the KdePlatformTheme plugin appears to be 
> the only way to get the full theme, including the font and colour selection. 
> In my opinion it is above all the font customisation which is a very welcome 
> feature for Qt/Mac; by default Qt applications use the default system font 
> (Lucida Grande 13pt or even 14pt) throughout. This is a good UI font, but not 
> at that size (and most "native" OS X applications indeed use a range of 
> smaller sizes, depending on role.
> 
> It does have introduce a number of regressions, which the current patch aims 
> to address. The most visible and problematic of these regressions is the loss 
> of the Mac-style menu bar and thus of all menu items (actions).
> 
> The fix is straightforward : on OS X (and similarly affected platforms?), an 
> instance of the native Cocoa platform theme is created through the private 
> API, and used as a fallback rather than immediately falling back to

Re: Review Request 127968: kshareddatacache: Fix invalid use of & to avoid unaligned reads

2016-05-19 Thread Fabian Vogt



> On Mai 19, 2016, 11:17 nachm., Michael Pyne wrote:
> > This is an error upstream in the MurmurHash 1.0 aligned implementation 
> > (which still contains the error, see 
> > https://sites.google.com/site/murmurhash/MurmurHashAligned.cpp?attredirects=0
> >  )
> > 
> > In our case KSharedDataCache will never pass an unaligned block into the 
> > hash function so 'align' was always 0 (and boolean false) anyways. So I 
> > concur with not bumping the cache version and agree with your patch. Thanks 
> > for taking a look!

I didn't know this aligned implementation actually had an upstream, it's 
actually fixed there, the latest source is on GitHub: 
https://github.com/aappleby/smhasher/blob/master/src/MurmurHash1.cpp#L87


- Fabian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127968/#review95630
---


On Mai 19, 2016, 6:13 nachm., Fabian Vogt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127968/
> ---
> 
> (Updated Mai 19, 2016, 6:13 nachm.)
> 
> 
> Review request for KDE Frameworks, David Faure and Michael Pyne.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> That the & is wrong here is obvious:
> align can never be 2 inside the if condition as ```(2 & bool)``` is always 
> false,
> yet the switch on align contains a case for 2.
> Instead it drops into the while loop for an 4-byte aligned pointer.
> 
> This doesn't change the returned values on platforms where unaligned reads
> are permitted, so I didn't bump the version.
> 
> 
> Diffs
> -
> 
>   src/lib/caching/kshareddatacache.cpp 50bbf64 
> 
> Diff: https://git.reviewboard.kde.org/r/127968/diff/
> 
> 
> Testing
> ---
> 
> Ran make test, all passed.
> 
> 
> Thanks,
> 
> Fabian Vogt
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

53 matches

Mail list logo