Re: Review Request 127972: Always update the Predicate parser from y/l sources
> On May 20, 2016, 11:43 p.m., Nicolás Alvarez wrote: > > Not only I approve of this change, but I also wish it was done over all > > other KDE software using flex/bison. Yup, I will take care of othe cases like this one (they are just a few, luckly). - Pino --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127972/#review95658 --- On May 20, 2016, 6:39 a.m., Pino Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127972/ > --- > > (Updated May 20, 2016, 6:39 a.m.) > > > Review request for KDE Software on Mac OS X, KDE Frameworks, kdewin, and > Lukáš Tinkl. > > > Repository: solid > > > Description > --- > > Turn Flex and Bison into required build dependencies, and use them to always > regenerate at build time the Predicate parser. This ensures that the parser > does not rot, and there is no more need to rely on autogenerated sources > added statically among the others. > > Second commit: remove old generated files of Predicate parser > > > Diffs > - > > CMakeLists.txt 763e09cfeeebdc9e42b68e8ab6c9e29c54d3e741 > src/solid/CMakeLists.txt f2b43b27cb47531ed57b2eccafad8e67951b56b9 > src/solid/devices/CMakeLists.txt 9271ae1e36b67b112be54a6ff9c6fb76a8a0a824 > src/solid/devices/predicate_lexer.c > 3b5a0b90907baf1cd2631da4de650ec153d0f642 > src/solid/devices/predicate_parser.h > 68e25070d498f5a635489af51f4b772c5f374108 > src/solid/devices/predicate_parser.c > 6d35ff25f001a43cbfecacc11e7d7591bb4808f9 > > Diff: https://git.reviewboard.kde.org/r/127972/diff/ > > > Testing > --- > > Builds fine with flex 2.6.0 and bison 3.0.4; `make test` passes too. > > > Thanks, > > Pino Toscano > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127972: Always update the Predicate parser from y/l sources
> On May 20, 2016, 11:21 p.m., René J.V. Bertin wrote: > > I've done some testing with Solid 5.20.0 .The patch applies cleanly, but > > I'm getting the error below. I'd write that down to using the older Solid > > version if it weren't for that fact I'm quite sure I've seen this kind of > > error before: > > > > ``` > > [ 30%] [BISON][SolidParser] Building parser with bison 3.0.4 > > cd > > /opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/solid-5.20.0/src/solid > > && /opt/local/bin/bison -p Solid -d -b predicate_parser -d -o > > /opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build/src/solid/predicate_parser.c > > devices/predicate_parser.y > > ... > > make[2]: Entering directory > > `/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build' > > [ 31%] Building C object > > src/solid/CMakeFiles/KF5Solid_static.dir/predicate_parser.c.o > > cd > > /opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build/src/solid > > && > > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang > > -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_MAC_USE_COCOA > > -DQT_NO_CAST_TO_ASCII -DQT_NO_DEBUG -DQT_NO_SIGNALS_SLOTS_KEYWORDS > > -DQT_NO_URL_CAST_FROM_STRING -DQT_QSP_XDG_LIB -DQT_USE_FAST_OPERATOR_PLUS > > -DQT_USE_QSTRINGBUILDER -DQT_WIDGETS_LIB -DQT_XML_LIB -D_DARWIN_C_SOURCE > > -D_LARGEFILE64_SOURCE > > -I/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build/src/solid > > > > -I/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/solid-5.20.0/src/solid > > > > -I/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/solid-5.20.0/src/solid/devices > > > > -I/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/solid-5.20.0/src/solid/devices/frontend > > -I/opt/local/var/macports/build/_ opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/solid-5.20.0/src/solid/.. -I/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build/src/solid/.. -iframework /opt/local/libexec/qt5/Library/Frameworks -isystem /opt/local/libexec/qt5/Library/Frameworks/QtCore.framework/Headers -isystem /opt/local/share/qt5/mkspecs/macx-clang -isystem /opt/local/libexec/qt5/Library/Frameworks/QtQspXDG.framework/Headers -isystem /opt/local/libexec/qt5/Library/Frameworks/QtDBus.framework/Headers -isystem /opt/local/libexec/qt5/Library/Frameworks/QtXml.framework/Headers -isystem /opt/local/libexec/qt5/Library/Frameworks/QtWidgets.framework/Headers -isystem /opt/local/libexec/qt5/Library/Frameworks/QtGui.framework/Headers -isystem /System/Library/Frameworks/OpenGL.framework/Headers -O3 -march=native -g -DNDEBUG -DQT_USE_EXTSTANDARDPATHS -DQT_EXTSTANDARDPATHS_XDG_DEFAULT=true -std=iso9899:1990 -fno-common -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-secur ity -Wno-long-long -Wpointer-arith -Wundef -Wmissing-format-attribute -Wwrite-strings -Werror=implicit-function-declaration -arch x86_64 -mmacosx-version-min=10.9 -fvisibility=hidden -DSOLID_STATIC_DEFINE=1 -fPIC -o CMakeFiles/KF5Solid_static.dir/predicate_parser.c.o -c /opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build/src/solid/predicate_parser.c > > > > /opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build/src/solid/predicate_parser.c:1206:30: > > error: too few arguments to function call, expected 2, have 1 > >yychar = yylex (); > > ~ ^ > > devices/predicate_parser.y:13:1: note: 'Solidlex' declared here > > int Solidlex( YYSTYPE *yylval, yyscan_t scanner ); > > ^ > > devices/predicate_parser.y:96:17: error: too many arguments to function > > call, expected 0, have 1 > > Solidparse( scanner ); > > ~~ ^~~ > > > > /opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build/src/solid/predicate_parser.c:1036:1: > > note: 'Solidparse' declared here > > int > > ^ > > 2 errors generated. > > make[2]: *** > > [src/solid/CMakeFiles/KF5Solid_static.dir/predicate_parser.c.o] Error 1 > > make[2]: Leaving directory > > `/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build' > > make[1]: *** [src/solid/CMakeFiles/KF5Solid_static.dir/all] Error 2 > > make[1]: Leaving directory > > `/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build' > > make: *** [all] Error 2 > > make: Leaving directory > > `/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build' > > ``` > > René J.V. Bertin wrote: > False alarm, builds fine with 5.22.0 Oh sorry, forgot to mention that you need to test the patch against
Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()
> On April 5, 2015, 5:26 p.m., David Faure wrote: > > Well, +1 for the idea. But I wonder what the apidox will look like, the > > macro+template probably don't make it work. > > > > Also missing @since 5.10. > > > > Ship it from me once the apidox issue is resolved. What apidox issue is being talked about? If it is about `KSTANDARDACTION_WITH_NEW_STYLE_CONNECT`, then i was able to make it work with some simple Doxyfile options. See `save()` overload for example: http://arrowd.name/html/namespace_k_standard_action.html#abd0ad3c1f3ee5c9d2ff068a06c8a6ac1 and http://arrowd.name/html/namespace_k_standard_action.html#a92c0df356ef011d4a7ae9a844d4a0bc7 If this is OK, i can document all new connects with `@since@` too. Can this be commited then? - Gleb --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121218/#review78527 --- On Dec. 24, 2014, 4:23 p.m., Alex Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121218/ > --- > > (Updated Dec. 24, 2014, 4:23 p.m.) > > > Review request for KDE Frameworks, David Faure and Nicolás Alvarez. > > > Repository: kconfigwidgets > > > Description > --- > > Not sure if MSVC has the necessary type_traits working, but can't test that > now since it don't have a Windows machine available. > > > Diffs > - > > autotests/kstandardactiontest.h 0008d281c0353e872feb7483c75762a0012a7b76 > autotests/kstandardactiontest.cpp 09ae35db05467d61b8baf50fac70c6228e324492 > src/kstandardaction.h d511778b7a24b1ec2e546949dab21f1ec2fea96f > src/kstandardaction.cpp e5bea7965032355501b4c238e37abcc0f883c0b7 > > Diff: https://git.reviewboard.kde.org/r/121218/diff/ > > > Testing > --- > > The newly added unit test passes > > > Thanks, > > Alex Richardson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127972: Always update the Predicate parser from y/l sources
> On May 21, 2016, 1:21 a.m., René J.V. Bertin wrote: > > I've done some testing with Solid 5.20.0 .The patch applies cleanly, but > > I'm getting the error below. I'd write that down to using the older Solid > > version if it weren't for that fact I'm quite sure I've seen this kind of > > error before: > > > > ``` > > [ 30%] [BISON][SolidParser] Building parser with bison 3.0.4 > > cd > > /opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/solid-5.20.0/src/solid > > && /opt/local/bin/bison -p Solid -d -b predicate_parser -d -o > > /opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build/src/solid/predicate_parser.c > > devices/predicate_parser.y > > ... > > make[2]: Entering directory > > `/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build' > > [ 31%] Building C object > > src/solid/CMakeFiles/KF5Solid_static.dir/predicate_parser.c.o > > cd > > /opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build/src/solid > > && > > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang > > -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_MAC_USE_COCOA > > -DQT_NO_CAST_TO_ASCII -DQT_NO_DEBUG -DQT_NO_SIGNALS_SLOTS_KEYWORDS > > -DQT_NO_URL_CAST_FROM_STRING -DQT_QSP_XDG_LIB -DQT_USE_FAST_OPERATOR_PLUS > > -DQT_USE_QSTRINGBUILDER -DQT_WIDGETS_LIB -DQT_XML_LIB -D_DARWIN_C_SOURCE > > -D_LARGEFILE64_SOURCE > > -I/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build/src/solid > > > > -I/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/solid-5.20.0/src/solid > > > > -I/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/solid-5.20.0/src/solid/devices > > > > -I/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/solid-5.20.0/src/solid/devices/frontend > > -I/opt/local/var/macports/build/_ opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/solid-5.20.0/src/solid/.. -I/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build/src/solid/.. -iframework /opt/local/libexec/qt5/Library/Frameworks -isystem /opt/local/libexec/qt5/Library/Frameworks/QtCore.framework/Headers -isystem /opt/local/share/qt5/mkspecs/macx-clang -isystem /opt/local/libexec/qt5/Library/Frameworks/QtQspXDG.framework/Headers -isystem /opt/local/libexec/qt5/Library/Frameworks/QtDBus.framework/Headers -isystem /opt/local/libexec/qt5/Library/Frameworks/QtXml.framework/Headers -isystem /opt/local/libexec/qt5/Library/Frameworks/QtWidgets.framework/Headers -isystem /opt/local/libexec/qt5/Library/Frameworks/QtGui.framework/Headers -isystem /System/Library/Frameworks/OpenGL.framework/Headers -O3 -march=native -g -DNDEBUG -DQT_USE_EXTSTANDARDPATHS -DQT_EXTSTANDARDPATHS_XDG_DEFAULT=true -std=iso9899:1990 -fno-common -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-secur ity -Wno-long-long -Wpointer-arith -Wundef -Wmissing-format-attribute -Wwrite-strings -Werror=implicit-function-declaration -arch x86_64 -mmacosx-version-min=10.9 -fvisibility=hidden -DSOLID_STATIC_DEFINE=1 -fPIC -o CMakeFiles/KF5Solid_static.dir/predicate_parser.c.o -c /opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build/src/solid/predicate_parser.c > > > > /opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build/src/solid/predicate_parser.c:1206:30: > > error: too few arguments to function call, expected 2, have 1 > >yychar = yylex (); > > ~ ^ > > devices/predicate_parser.y:13:1: note: 'Solidlex' declared here > > int Solidlex( YYSTYPE *yylval, yyscan_t scanner ); > > ^ > > devices/predicate_parser.y:96:17: error: too many arguments to function > > call, expected 0, have 1 > > Solidparse( scanner ); > > ~~ ^~~ > > > > /opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build/src/solid/predicate_parser.c:1036:1: > > note: 'Solidparse' declared here > > int > > ^ > > 2 errors generated. > > make[2]: *** > > [src/solid/CMakeFiles/KF5Solid_static.dir/predicate_parser.c.o] Error 1 > > make[2]: Leaving directory > > `/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build' > > make[1]: *** [src/solid/CMakeFiles/KF5Solid_static.dir/all] Error 2 > > make[1]: Leaving directory > > `/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build' > > make: *** [all] Error 2 > > make: Leaving directory > > `/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build' > > ``` False alarm, builds fine with 5.22.0 - René J.V. --- This is an automatically
Re: Review Request 127972: Always update the Predicate parser from y/l sources
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127972/#review95658 --- Ship it! Not only I approve of this change, but I also wish it was done over all other KDE software using flex/bison. - Nicolás Alvarez On Mayo 20, 2016, 3:39 a.m., Pino Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127972/ > --- > > (Updated Mayo 20, 2016, 3:39 a.m.) > > > Review request for KDE Software on Mac OS X, KDE Frameworks, kdewin, and > Lukáš Tinkl. > > > Repository: solid > > > Description > --- > > Turn Flex and Bison into required build dependencies, and use them to always > regenerate at build time the Predicate parser. This ensures that the parser > does not rot, and there is no more need to rely on autogenerated sources > added statically among the others. > > Second commit: remove old generated files of Predicate parser > > > Diffs > - > > CMakeLists.txt 763e09cfeeebdc9e42b68e8ab6c9e29c54d3e741 > src/solid/CMakeLists.txt f2b43b27cb47531ed57b2eccafad8e67951b56b9 > src/solid/devices/CMakeLists.txt 9271ae1e36b67b112be54a6ff9c6fb76a8a0a824 > src/solid/devices/predicate_lexer.c > 3b5a0b90907baf1cd2631da4de650ec153d0f642 > src/solid/devices/predicate_parser.h > 68e25070d498f5a635489af51f4b772c5f374108 > src/solid/devices/predicate_parser.c > 6d35ff25f001a43cbfecacc11e7d7591bb4808f9 > > Diff: https://git.reviewboard.kde.org/r/127972/diff/ > > > Testing > --- > > Builds fine with flex 2.6.0 and bison 3.0.4; `make test` passes too. > > > Thanks, > > Pino Toscano > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127972: Always update the Predicate parser from y/l sources
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127972/#review95657 --- I've done some testing with Solid 5.20.0 .The patch applies cleanly, but I'm getting the error below. I'd write that down to using the older Solid version if it weren't for that fact I'm quite sure I've seen this kind of error before: ``` [ 30%] [BISON][SolidParser] Building parser with bison 3.0.4 cd /opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/solid-5.20.0/src/solid && /opt/local/bin/bison -p Solid -d -b predicate_parser -d -o /opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build/src/solid/predicate_parser.c devices/predicate_parser.y ... make[2]: Entering directory `/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build' [ 31%] Building C object src/solid/CMakeFiles/KF5Solid_static.dir/predicate_parser.c.o cd /opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build/src/solid && /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_MAC_USE_COCOA -DQT_NO_CAST_TO_ASCII -DQT_NO_DEBUG -DQT_NO_SIGNALS_SLOTS_KEYWORDS -DQT_NO_URL_CAST_FROM_STRING -DQT_QSP_XDG_LIB -DQT_USE_FAST_OPERATOR_PLUS -DQT_USE_QSTRINGBUILDER -DQT_WIDGETS_LIB -DQT_XML_LIB -D_DARWIN_C_SOURCE -D_LARGEFILE64_SOURCE -I/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build/src/solid -I/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/solid-5.20.0/src/solid -I/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/solid-5.20.0/src/solid/devices -I/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/solid-5.20.0/src/solid/devices/frontend -I/opt/local/var/macports/build/_opt_ local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/solid-5.20.0/src/solid/.. -I/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build/src/solid/.. -iframework /opt/local/libexec/qt5/Library/Frameworks -isystem /opt/local/libexec/qt5/Library/Frameworks/QtCore.framework/Headers -isystem /opt/local/share/qt5/mkspecs/macx-clang -isystem /opt/local/libexec/qt5/Library/Frameworks/QtQspXDG.framework/Headers -isystem /opt/local/libexec/qt5/Library/Frameworks/QtDBus.framework/Headers -isystem /opt/local/libexec/qt5/Library/Frameworks/QtXml.framework/Headers -isystem /opt/local/libexec/qt5/Library/Frameworks/QtWidgets.framework/Headers -isystem /opt/local/libexec/qt5/Library/Frameworks/QtGui.framework/Headers -isystem /System/Library/Frameworks/OpenGL.framework/Headers -O3 -march=native -g -DNDEBUG -DQT_USE_EXTSTANDARDPATHS -DQT_EXTSTANDARDPATHS_XDG_DEFAULT=true -std=iso9899:1990 -fno-common -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wmissing-format-attribute -Wwrite-strings -Werror=implicit-function-declaration -arch x86_64 -mmacosx-version-min=10.9 -fvisibility=hidden -DSOLID_STATIC_DEFINE=1 -fPIC -o CMakeFiles/KF5Solid_static.dir/predicate_parser.c.o -c /opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build/src/solid/predicate_parser.c /opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build/src/solid/predicate_parser.c:1206:30: error: too few arguments to function call, expected 2, have 1 yychar = yylex (); ~ ^ devices/predicate_parser.y:13:1: note: 'Solidlex' declared here int Solidlex( YYSTYPE *yylval, yyscan_t scanner ); ^ devices/predicate_parser.y:96:17: error: too many arguments to function call, expected 0, have 1 Solidparse( scanner ); ~~ ^~~ /opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build/src/solid/predicate_parser.c:1036:1: note: 'Solidparse' declared here int ^ 2 errors generated. make[2]: *** [src/solid/CMakeFiles/KF5Solid_static.dir/predicate_parser.c.o] Error 1 make[2]: Leaving directory `/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build' make[1]: *** [src/solid/CMakeFiles/KF5Solid_static.dir/all] Error 2 make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build' make: *** [all] Error 2 make: Leaving directory `/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build' ``` - René J.V. Bertin On May 20, 2016, 8:39 a.m., Pino Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >
Re: Review Request 127747: Create a new script that generate the documentation for all projects following the syntax I proposed
> On May 20, 2016, 1:50 a.m., Michael Pyne wrote: > > I've looked at the code itself and it seems reasonable, so from that > > perspective and given the length of time there's been no -1's, I think it's > > safe to commit. > > > > However you mentioned in the description that this isn't safe to commit to > > master. I have no clue how we generate apidox for KF5 and Plasma 5 so I'm > > not sure what you mean when you say we'd affect the currents script. What > > is your plan for integrating this without breaking the scripts? Is there > > work needed by others (sysadmin, EBN, etc.) to make apidox generation work > > with your patch committed? What's the action KDE developers must take after > > this, if any? > > Olivier Churlaud wrote: > Thank you for the review Michel. The only need will be to update the > metainfo.yml. I can do that for the frameworks if needed after commiting. Or > I can even do this before so that it doesn't break. > > Commit plan: > 1) update frameworks metainfo (they are back-compatibles but the *new* > script will break with the old metainfo. > 2) commit in master > 3) See if everything works as expected else correct. > 4) Clean up the code and teach it new tricks ; Add other projects that > the frameworks. > > Olivier Churlaud wrote: > Oh and maybe the current folder containing the html pages should be > removed as well. > > Olivier Churlaud wrote: > I forgot something. The name of the script will change. So I have to > either see with a sysadmin to change the cronjob or overright the previous > one. Please ping me on IRC and I can arrange access to api.kde.org. - Ben --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127747/#review95632 --- On April 25, 2016, 9:49 p.m., Olivier Churlaud wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127747/ > --- > > (Updated April 25, 2016, 9:49 p.m.) > > > Review request for KDE Frameworks, Albert Astals Cid, Alex Merry, Aurélien > Gâteau, and Allen Winter. > > > Repository: kapidox > > > Description > --- > > Keep in mind that it should not plainly replace kgenframeworks but be used by > all KDE projects. So in this proposition, the Frameworks are just one project > in others. > > The code can be tested directly by checking the branch > `olivier/generate_all_repos`. > > This MUST NOT be merged in master, because it will break the currents scripts > (see commit 3643dded7cf14a5634879e8e6e34be8840143d7e). > > > Diffs > - > > konqi_frameworks.png PRE-CREATION > metainfo.yaml 4ff17c8 > metainfo_syntax.md PRE-CREATION > src/kapidox/data/htmlresource/default_product.png PRE-CREATION > src/kapidox/data/htmlresource/kde.css b864ef5 > src/kapidox/data/templates/doxygen2.html PRE-CREATION > src/kapidox/data/templates/frontpage.html PRE-CREATION > src/kapidox/data/templates/libinfo.html PRE-CREATION > src/kapidox/data/templates/maintainers.html PRE-CREATION > src/kapidox/data/templates/subgroup.html PRE-CREATION > src/kapidox/generator.py 5b8ae40 > src/newkapidox.py PRE-CREATION > src/notes PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/127747/diff/ > > > Testing > --- > > Tested on various scenario cases. > > > File Attachments > > > This is an example of what I generated. (Threadweaver is duplicated and > modified to test different scenarios) > > https://git.reviewboard.kde.org/media/uploaded/files/2016/04/25/2e4549e4-7c17-416c-9a72-b82d3bba18b3__doc.tar.gz > > > Thanks, > > Olivier Churlaud > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127968: kshareddatacache: Fix invalid use of & to avoid unaligned reads
> On May 19, 2016, 11:17 p.m., Michael Pyne wrote: > > This is an error upstream in the MurmurHash 1.0 aligned implementation > > (which still contains the error, see > > https://sites.google.com/site/murmurhash/MurmurHashAligned.cpp?attredirects=0 > > ) > > > > In our case KSharedDataCache will never pass an unaligned block into the > > hash function so 'align' was always 0 (and boolean false) anyways. So I > > concur with not bumping the cache version and agree with your patch. Thanks > > for taking a look! > > Fabian Vogt wrote: > I didn't know this aligned implementation actually had an upstream, it's > actually fixed there, the latest source is on GitHub: > https://github.com/aappleby/smhasher/blob/master/src/MurmurHash1.cpp#L87 Ah, great news then. I'll have to update the URL in the KSharedDataCache sources then for posterity. - Michael --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127968/#review95630 --- On May 20, 2016, 8:08 a.m., Fabian Vogt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127968/ > --- > > (Updated May 20, 2016, 8:08 a.m.) > > > Review request for KDE Frameworks, David Faure and Michael Pyne. > > > Repository: kcoreaddons > > > Description > --- > > That the & is wrong here is obvious: > align can never be 2 inside the if condition as ```(2 & bool)``` is always > false, > yet the switch on align contains a case for 2. > Instead it drops into the while loop for an 4-byte aligned pointer. > > This doesn't change the returned values on platforms where unaligned reads > are permitted, so I didn't bump the version. > > > Diffs > - > > src/lib/caching/kshareddatacache.cpp 50bbf64 > > Diff: https://git.reviewboard.kde.org/r/127968/diff/ > > > Testing > --- > > Ran make test, all passed. > > > Thanks, > > Fabian Vogt > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127896: make dbus optional on osx: kauth
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127896/ --- (Updated May 20, 2016, 9:13 p.m.) Review request for KDE Software on Mac OS X, KDE Frameworks, David Edmundson, and Martin Gräßlin. Changes --- made dbus enabling/disabling be available via cmake config option only, as asked Repository: kauth Description --- this is the first patch to make kde frameworks build (and then work) without dbus. this will allow homebrew users use precompiled vanilla Qt to build kde apps on osx. as dbus is not a common service in osx world, kde apps on osx should use native means for interprocess communication instead -- this will make them better citizens in osx ecosystem. Diffs (updated) - CMakeLists.txt 48dc2d9 autotests/BackendsManager.cpp 59675b3 autotests/CMakeLists.txt b53d760 autotests/HelperTest.cpp 8050a06 src/CMakeLists.txt 1b6930d src/ConfigureChecks.cmake d46761a Diff: https://git.reviewboard.kde.org/r/127896/diff/ Testing --- compiles fine on osx, compiles fine on linux, tests on linux still pass. Thanks, Nick Shaforostoff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127747: Create a new script that generate the documentation for all projects following the syntax I proposed
> On May 20, 2016, 3:50 a.m., Michael Pyne wrote: > > I've looked at the code itself and it seems reasonable, so from that > > perspective and given the length of time there's been no -1's, I think it's > > safe to commit. > > > > However you mentioned in the description that this isn't safe to commit to > > master. I have no clue how we generate apidox for KF5 and Plasma 5 so I'm > > not sure what you mean when you say we'd affect the currents script. What > > is your plan for integrating this without breaking the scripts? Is there > > work needed by others (sysadmin, EBN, etc.) to make apidox generation work > > with your patch committed? What's the action KDE developers must take after > > this, if any? > > Olivier Churlaud wrote: > Thank you for the review Michel. The only need will be to update the > metainfo.yml. I can do that for the frameworks if needed after commiting. Or > I can even do this before so that it doesn't break. > > Commit plan: > 1) update frameworks metainfo (they are back-compatibles but the *new* > script will break with the old metainfo. > 2) commit in master > 3) See if everything works as expected else correct. > 4) Clean up the code and teach it new tricks ; Add other projects that > the frameworks. > > Olivier Churlaud wrote: > Oh and maybe the current folder containing the html pages should be > removed as well. I forgot something. The name of the script will change. So I have to either see with a sysadmin to change the cronjob or overright the previous one. - Olivier --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127747/#review95632 --- On April 25, 2016, 11:49 p.m., Olivier Churlaud wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127747/ > --- > > (Updated April 25, 2016, 11:49 p.m.) > > > Review request for KDE Frameworks, Albert Astals Cid, Alex Merry, Aurélien > Gâteau, and Allen Winter. > > > Repository: kapidox > > > Description > --- > > Keep in mind that it should not plainly replace kgenframeworks but be used by > all KDE projects. So in this proposition, the Frameworks are just one project > in others. > > The code can be tested directly by checking the branch > `olivier/generate_all_repos`. > > This MUST NOT be merged in master, because it will break the currents scripts > (see commit 3643dded7cf14a5634879e8e6e34be8840143d7e). > > > Diffs > - > > konqi_frameworks.png PRE-CREATION > metainfo.yaml 4ff17c8 > metainfo_syntax.md PRE-CREATION > src/kapidox/data/htmlresource/default_product.png PRE-CREATION > src/kapidox/data/htmlresource/kde.css b864ef5 > src/kapidox/data/templates/doxygen2.html PRE-CREATION > src/kapidox/data/templates/frontpage.html PRE-CREATION > src/kapidox/data/templates/libinfo.html PRE-CREATION > src/kapidox/data/templates/maintainers.html PRE-CREATION > src/kapidox/data/templates/subgroup.html PRE-CREATION > src/kapidox/generator.py 5b8ae40 > src/newkapidox.py PRE-CREATION > src/notes PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/127747/diff/ > > > Testing > --- > > Tested on various scenario cases. > > > File Attachments > > > This is an example of what I generated. (Threadweaver is duplicated and > modified to test different scenarios) > > https://git.reviewboard.kde.org/media/uploaded/files/2016/04/25/2e4549e4-7c17-416c-9a72-b82d3bba18b3__doc.tar.gz > > > Thanks, > > Olivier Churlaud > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127972: Always update the Predicate parser from y/l sources
> On May 20, 2016, 8:39 a.m., René J.V. Bertin wrote: > > Looks good but I'll try to do a test-build during one of my next "lost > > moments". > > > > Is there a minimum required version for either of the parser/generators? > Is there a minimum required version for either of the parser/generators? Not that I know of. - Pino --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127972/#review95644 --- On May 20, 2016, 6:39 a.m., Pino Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127972/ > --- > > (Updated May 20, 2016, 6:39 a.m.) > > > Review request for KDE Software on Mac OS X, KDE Frameworks, kdewin, and > Lukáš Tinkl. > > > Repository: solid > > > Description > --- > > Turn Flex and Bison into required build dependencies, and use them to always > regenerate at build time the Predicate parser. This ensures that the parser > does not rot, and there is no more need to rely on autogenerated sources > added statically among the others. > > Second commit: remove old generated files of Predicate parser > > > Diffs > - > > CMakeLists.txt 763e09cfeeebdc9e42b68e8ab6c9e29c54d3e741 > src/solid/CMakeLists.txt f2b43b27cb47531ed57b2eccafad8e67951b56b9 > src/solid/devices/CMakeLists.txt 9271ae1e36b67b112be54a6ff9c6fb76a8a0a824 > src/solid/devices/predicate_lexer.c > 3b5a0b90907baf1cd2631da4de650ec153d0f642 > src/solid/devices/predicate_parser.h > 68e25070d498f5a635489af51f4b772c5f374108 > src/solid/devices/predicate_parser.c > 6d35ff25f001a43cbfecacc11e7d7591bb4808f9 > > Diff: https://git.reviewboard.kde.org/r/127972/diff/ > > > Testing > --- > > Builds fine with flex 2.6.0 and bison 3.0.4; `make test` passes too. > > > Thanks, > > Pino Toscano > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 57 - Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/57/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Fri, 20 May 2016 16:00:06 + Build duration: 3 min 11 sec CHANGE SET Revision 3530cc39d0f725b38b33ea940a8f902c01d90f6c by bvbfan: ([icon thumbnail] Request for preferred icon size) change: edit src/declarativeimports/core/windowthumbnail.cpp JUNIT RESULTS Name: (root) Failed: 12 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: TestSuite.coronatestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-framesvgtestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-packageurlinterceptortestFailed: TestSuite.plasma-pluginloadertestFailed: TestSuite.plasma-sortfiltermodeltestFailed: TestSuite.plasma-storagetestFailed: TestSuite.plasma-themetest COBERTURA RESULTS Cobertura Coverage Report By packages ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127809/ --- (Updated May 20, 2016, 6:54 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, KDE Usability and Martin Gräßlin. Changes --- Submitted with commit e8762b96ae7a9fabc6af8fc5dcf2b82a7206053f by Anthony Fieroni to branch master. Bugs: 362324 https://bugs.kde.org/show_bug.cgi?id=362324 Repository: kwindowsystem Description --- The api function is KWindowSystem::icon (WId win, int width=-1, int height=-1, bool scale=false) so caller must get best size not worst when width/height is not specified. Diffs - src/platforms/xcb/kwindowsystem.cpp 5b7c65a Diff: https://git.reviewboard.kde.org/r/127809/diff/ Testing --- File Attachments before https://git.reviewboard.kde.org/media/uploaded/files/2016/05/01/6d718ef6-26cf-4866-94d2-4ffbdfc906fe__Screenshot_20160426_232109.png after https://git.reviewboard.kde.org/media/uploaded/files/2016/05/01/7dcab4ae-e451-4d43-8799-a0fcab471a3d__Screenshot_20160501_224642.png Thanks, Anthony Fieroni ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127976: Support selected state
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127976/ --- (Updated May 20, 2016, 2:38 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit 6290b4add9a6a5bdfa37f74d2a6234123f1ae931 by Marco Martin to branch master. Repository: kdeclarative Description --- support QIcon::selected state Diffs - src/qmlcontrols/kquickcontrolsaddons/qiconitem.h 9927964 src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp 237e764 Diff: https://git.reviewboard.kde.org/r/127976/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127976: Support selected state
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127976/#review95650 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 20, 2016, 1:11 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127976/ > --- > > (Updated May 20, 2016, 1:11 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kdeclarative > > > Description > --- > > support QIcon::selected state > > > Diffs > - > > src/qmlcontrols/kquickcontrolsaddons/qiconitem.h 9927964 > src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp 237e764 > > Diff: https://git.reviewboard.kde.org/r/127976/diff/ > > > Testing > --- > > > Thanks, > > Marco Martin > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127469: Use QQuickWidget for QML KCMs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127469/ --- (Updated May 20, 2016, 3:33 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 23b6468fc2486516711ba4ce50f3492fd231d50e by David Rosca to branch master. Bugs: 359124 https://bugs.kde.org/show_bug.cgi?id=359124 Repository: kcmutils Description --- Fix position of QtQuickControls popups. BUG: 359124 Diffs - CMakeLists.txt 60cf4bb src/CMakeLists.txt 58352f6 src/kcmoduleqml.cpp c52769b Diff: https://git.reviewboard.kde.org/r/127469/diff/ Testing --- Popups are now in correct position in systemsettings and kcmshell Thanks, David Rosca ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 127976: Support selected state
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127976/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- support QIcon::selected state Diffs - src/qmlcontrols/kquickcontrolsaddons/qiconitem.h 9927964 src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp 237e764 Diff: https://git.reviewboard.kde.org/r/127976/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 56 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/56/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Fri, 20 May 2016 10:19:42 + Build duration: 3 min 21 sec CHANGE SET Revision 1d81c837792cfe4defe5932e7fe2021a58122a1f by Marco Martin: (disable the tests when no plugins are installed) change: edit autotests/pluginloadertest.h change: edit autotests/pluginloadertest.cpp JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 8/8 (100%)FILES 74/111 (67%)CLASSES 74/111 (67%)LINE 4374/11261 (39%)CONDITIONAL 2279/8377 (27%) By packages autotests FILES 24/24 (100%)CLASSES 24/24 (100%)LINE 884/942 (94%)CONDITIONAL 570/1134 (50%) src.declarativeimports.core FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 545/1847 (30%)CONDITIONAL 202/1132 (18%) src.plasma FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1666/3628 (46%)CONDITIONAL 948/2738 (35%) src.plasma.private FILES 15/24 (63%)CLASSES 15/24 (63%)LINE 900/1721 (52%)CONDITIONAL 404/1006 (40%) src.plasma.scripting FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 37/181 (20%)CONDITIONAL 14/106 (13%) src.plasmaquick FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 300/1671 (18%)CONDITIONAL 133/1277 (10%) src.plasmaquick.private FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 6/22 (27%) src.scriptengines.qml.plasmoid FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1158 (1%)CONDITIONAL 2/962 (0%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 56 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/56/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Fri, 20 May 2016 10:19:42 + Build duration: 3 min 21 sec CHANGE SET Revision 1d81c837792cfe4defe5932e7fe2021a58122a1f by Marco Martin: (disable the tests when no plugins are installed) change: edit autotests/pluginloadertest.h change: edit autotests/pluginloadertest.cpp JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 8/8 (100%)FILES 74/111 (67%)CLASSES 74/111 (67%)LINE 4374/11261 (39%)CONDITIONAL 2279/8377 (27%) By packages autotests FILES 24/24 (100%)CLASSES 24/24 (100%)LINE 884/942 (94%)CONDITIONAL 570/1134 (50%) src.declarativeimports.core FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 545/1847 (30%)CONDITIONAL 202/1132 (18%) src.plasma FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1666/3628 (46%)CONDITIONAL 948/2738 (35%) src.plasma.private FILES 15/24 (63%)CLASSES 15/24 (63%)LINE 900/1721 (52%)CONDITIONAL 404/1006 (40%) src.plasma.scripting FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 37/181 (20%)CONDITIONAL 14/106 (13%) src.plasmaquick FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 300/1671 (18%)CONDITIONAL 133/1277 (10%) src.plasmaquick.private FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 6/22 (27%) src.scriptengines.qml.plasmoid FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1158 (1%)CONDITIONAL 2/962 (0%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 55 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/55/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Fri, 20 May 2016 10:19:42 + Build duration: 2 min 57 sec CHANGE SET Revision 1d81c837792cfe4defe5932e7fe2021a58122a1f by Marco Martin: (disable the tests when no plugins are installed) change: edit autotests/pluginloadertest.cpp change: edit autotests/pluginloadertest.h JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 8/8 (100%)FILES 74/111 (67%)CLASSES 74/111 (67%)LINE 4384/11261 (39%)CONDITIONAL 2282/8377 (27%) By packages autotests FILES 24/24 (100%)CLASSES 24/24 (100%)LINE 884/942 (94%)CONDITIONAL 570/1134 (50%) src.declarativeimports.core FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 545/1847 (30%)CONDITIONAL 202/1132 (18%) src.plasma FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1666/3628 (46%)CONDITIONAL 948/2738 (35%) src.plasma.private FILES 15/24 (63%)CLASSES 15/24 (63%)LINE 910/1721 (53%)CONDITIONAL 407/1006 (40%) src.plasma.scripting FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 37/181 (20%)CONDITIONAL 14/106 (13%) src.plasmaquick FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 300/1671 (18%)CONDITIONAL 133/1277 (10%) src.plasmaquick.private FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 6/22 (27%) src.scriptengines.qml.plasmoid FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1158 (1%)CONDITIONAL 2/962 (0%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 56 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/56/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 20 May 2016 10:19:42 + Build duration: 2 min 50 sec CHANGE SET Revision 1d81c837792cfe4defe5932e7fe2021a58122a1f by Marco Martin: (disable the tests when no plugins are installed) change: edit autotests/pluginloadertest.h change: edit autotests/pluginloadertest.cpp JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 14 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 8/8 (100%)FILES 77/115 (67%)CLASSES 77/115 (67%)LINE 4794/11728 (41%)CONDITIONAL 2564/8727 (29%) By packages autotests FILES 26/26 (100%)CLASSES 26/26 (100%)LINE 929/989 (94%)CONDITIONAL 586/1166 (50%) src.declarativeimports.core FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 635/2071 (31%)CONDITIONAL 288/1278 (23%) src.plasma FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1668/3628 (46%)CONDITIONAL 953/2738 (35%) src.plasma.private FILES 16/26 (62%)CLASSES 16/26 (62%)LINE 944/1794 (53%)CONDITIONAL 423/1052 (40%) src.plasma.scripting FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 37/181 (20%)CONDITIONAL 14/106 (13%) src.plasmaquick FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 539/1794 (30%)CONDITIONAL 292/1403 (21%) src.plasmaquick.private FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 6/22 (27%) src.scriptengines.qml.plasmoid FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1158 (1%)CONDITIONAL 2/962 (0%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 56 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/56/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 20 May 2016 10:19:42 + Build duration: 2 min 50 sec CHANGE SET Revision 1d81c837792cfe4defe5932e7fe2021a58122a1f by Marco Martin: (disable the tests when no plugins are installed) change: edit autotests/pluginloadertest.h change: edit autotests/pluginloadertest.cpp JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 14 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 8/8 (100%)FILES 77/115 (67%)CLASSES 77/115 (67%)LINE 4794/11728 (41%)CONDITIONAL 2564/8727 (29%) By packages autotests FILES 26/26 (100%)CLASSES 26/26 (100%)LINE 929/989 (94%)CONDITIONAL 586/1166 (50%) src.declarativeimports.core FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 635/2071 (31%)CONDITIONAL 288/1278 (23%) src.plasma FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1668/3628 (46%)CONDITIONAL 953/2738 (35%) src.plasma.private FILES 16/26 (62%)CLASSES 16/26 (62%)LINE 944/1794 (53%)CONDITIONAL 423/1052 (40%) src.plasma.scripting FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 37/181 (20%)CONDITIONAL 14/106 (13%) src.plasmaquick FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 539/1794 (30%)CONDITIONAL 292/1403 (21%) src.plasmaquick.private FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 6/22 (27%) src.scriptengines.qml.plasmoid FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1158 (1%)CONDITIONAL 2/962 (0%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 55 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/55/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Fri, 20 May 2016 10:19:42 + Build duration: 2 min 57 sec CHANGE SET Revision 1d81c837792cfe4defe5932e7fe2021a58122a1f by Marco Martin: (disable the tests when no plugins are installed) change: edit autotests/pluginloadertest.cpp change: edit autotests/pluginloadertest.h JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 8/8 (100%)FILES 74/111 (67%)CLASSES 74/111 (67%)LINE 4384/11261 (39%)CONDITIONAL 2282/8377 (27%) By packages autotests FILES 24/24 (100%)CLASSES 24/24 (100%)LINE 884/942 (94%)CONDITIONAL 570/1134 (50%) src.declarativeimports.core FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 545/1847 (30%)CONDITIONAL 202/1132 (18%) src.plasma FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1666/3628 (46%)CONDITIONAL 948/2738 (35%) src.plasma.private FILES 15/24 (63%)CLASSES 15/24 (63%)LINE 910/1721 (53%)CONDITIONAL 407/1006 (40%) src.plasma.scripting FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 37/181 (20%)CONDITIONAL 14/106 (13%) src.plasmaquick FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 300/1671 (18%)CONDITIONAL 133/1277 (10%) src.plasmaquick.private FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 6/22 (27%) src.scriptengines.qml.plasmoid FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1158 (1%)CONDITIONAL 2/962 (0%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 55 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/55/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 20 May 2016 10:19:42 + Build duration: 2 min 38 sec CHANGE SET Revision 1d81c837792cfe4defe5932e7fe2021a58122a1f by Marco Martin: (disable the tests when no plugins are installed) change: edit autotests/pluginloadertest.h change: edit autotests/pluginloadertest.cpp JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 14 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 8/8 (100%)FILES 77/115 (67%)CLASSES 77/115 (67%)LINE 4797/11728 (41%)CONDITIONAL 2564/8727 (29%) By packages autotests FILES 26/26 (100%)CLASSES 26/26 (100%)LINE 929/989 (94%)CONDITIONAL 586/1166 (50%) src.declarativeimports.core FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 635/2071 (31%)CONDITIONAL 288/1278 (23%) src.plasma FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1668/3628 (46%)CONDITIONAL 953/2738 (35%) src.plasma.private FILES 16/26 (62%)CLASSES 16/26 (62%)LINE 944/1794 (53%)CONDITIONAL 423/1052 (40%) src.plasma.scripting FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 37/181 (20%)CONDITIONAL 14/106 (13%) src.plasmaquick FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 542/1794 (30%)CONDITIONAL 292/1403 (21%) src.plasmaquick.private FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 6/22 (27%) src.scriptengines.qml.plasmoid FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1158 (1%)CONDITIONAL 2/962 (0%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 55 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/55/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 20 May 2016 10:19:42 + Build duration: 2 min 38 sec CHANGE SET Revision 1d81c837792cfe4defe5932e7fe2021a58122a1f by Marco Martin: (disable the tests when no plugins are installed) change: edit autotests/pluginloadertest.h change: edit autotests/pluginloadertest.cpp JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 14 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 8/8 (100%)FILES 77/115 (67%)CLASSES 77/115 (67%)LINE 4797/11728 (41%)CONDITIONAL 2564/8727 (29%) By packages autotests FILES 26/26 (100%)CLASSES 26/26 (100%)LINE 929/989 (94%)CONDITIONAL 586/1166 (50%) src.declarativeimports.core FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 635/2071 (31%)CONDITIONAL 288/1278 (23%) src.plasma FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1668/3628 (46%)CONDITIONAL 953/2738 (35%) src.plasma.private FILES 16/26 (62%)CLASSES 16/26 (62%)LINE 944/1794 (53%)CONDITIONAL 423/1052 (40%) src.plasma.scripting FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 37/181 (20%)CONDITIONAL 14/106 (13%) src.plasmaquick FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 542/1794 (30%)CONDITIONAL 292/1403 (21%) src.plasmaquick.private FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 6/22 (27%) src.scriptengines.qml.plasmoid FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1158 (1%)CONDITIONAL 2/962 (0%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127972: Always update the Predicate parser from y/l sources
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127972/#review95644 --- Looks good but I'll try to do a test-build during one of my next "lost moments". Is there a minimum required version for either of the parser/generators? - René J.V. Bertin On May 20, 2016, 8:39 a.m., Pino Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127972/ > --- > > (Updated May 20, 2016, 8:39 a.m.) > > > Review request for KDE Software on Mac OS X, KDE Frameworks, kdewin, and > Lukáš Tinkl. > > > Repository: solid > > > Description > --- > > Turn Flex and Bison into required build dependencies, and use them to always > regenerate at build time the Predicate parser. This ensures that the parser > does not rot, and there is no more need to rely on autogenerated sources > added statically among the others. > > Second commit: remove old generated files of Predicate parser > > > Diffs > - > > CMakeLists.txt 763e09cfeeebdc9e42b68e8ab6c9e29c54d3e741 > src/solid/CMakeLists.txt f2b43b27cb47531ed57b2eccafad8e67951b56b9 > src/solid/devices/CMakeLists.txt 9271ae1e36b67b112be54a6ff9c6fb76a8a0a824 > src/solid/devices/predicate_lexer.c > 3b5a0b90907baf1cd2631da4de650ec153d0f642 > src/solid/devices/predicate_parser.h > 68e25070d498f5a635489af51f4b772c5f374108 > src/solid/devices/predicate_parser.c > 6d35ff25f001a43cbfecacc11e7d7591bb4808f9 > > Diff: https://git.reviewboard.kde.org/r/127972/diff/ > > > Testing > --- > > Builds fine with flex 2.6.0 and bison 3.0.4; `make test` passes too. > > > Thanks, > > Pino Toscano > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 45 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/45/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 20 May 2016 08:12:21 + Build duration: 4 min 56 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 10 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5464/7984 (68%)CONDITIONAL 2965/6144 (48%) By packages autotests FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1443/1529 (94%)CONDITIONAL 891/1768 (50%) src.kbuildsycoca FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 15/20 (75%) src.kdeinit FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 (0%) src.plugin FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 36/96 (38%) src.services FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1760/3042 (58%)CONDITIONAL 756/1888 (40%) src.sycoca FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2045/2800 (73%)CONDITIONAL 1233/2060 (60%) tests.pluginlocator FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 34/50 (68%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 45 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/45/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 20 May 2016 08:12:21 + Build duration: 4 min 56 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 10 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5464/7984 (68%)CONDITIONAL 2965/6144 (48%) By packages autotests FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1443/1529 (94%)CONDITIONAL 891/1768 (50%) src.kbuildsycoca FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 15/20 (75%) src.kdeinit FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 (0%) src.plugin FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 36/96 (38%) src.services FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1760/3042 (58%)CONDITIONAL 756/1888 (40%) src.sycoca FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2045/2800 (73%)CONDITIONAL 1233/2060 (60%) tests.pluginlocator FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 34/50 (68%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 49 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/49/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 20 May 2016 08:14:01 + Build duration: 1 min 52 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 10 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5456/7983 (68%)CONDITIONAL 2948/6142 (48%) By packages autotests FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1441/1529 (94%)CONDITIONAL 883/1768 (50%) src.kbuildsycoca FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 15/20 (75%) src.kdeinit FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 (0%) src.plugin FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 36/96 (38%) src.services FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1760/3042 (58%)CONDITIONAL 756/1888 (40%) src.sycoca FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2039/2799 (73%)CONDITIONAL 1224/2058 (59%) tests.pluginlocator FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 34/50 (68%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 49 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/49/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 20 May 2016 08:14:01 + Build duration: 1 min 52 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 10 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5456/7983 (68%)CONDITIONAL 2948/6142 (48%) By packages autotests FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1441/1529 (94%)CONDITIONAL 883/1768 (50%) src.kbuildsycoca FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 15/20 (75%) src.kdeinit FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 (0%) src.plugin FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 36/96 (38%) src.services FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1760/3042 (58%)CONDITIONAL 756/1888 (40%) src.sycoca FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2039/2799 (73%)CONDITIONAL 1224/2058 (59%) tests.pluginlocator FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 34/50 (68%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: kpty master kf5-qt5 » Linux,gcc - Build # 40 - Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kpty%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/40/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 20 May 2016 08:14:01 + Build duration: 1 min 0 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.kptyprocesstest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 2/2 (100%)FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 432/557 (78%)CONDITIONAL 125/243 (51%) By packages autotests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 111/111 (100%)CONDITIONAL 38/72 (53%) src FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 321/446 (72%)CONDITIONAL 87/171 (51%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: kpty master stable-kf5-qt5 » Linux,gcc - Build # 40 - Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kpty%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/40/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 20 May 2016 08:12:21 + Build duration: 3 min 36 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.kptyprocesstest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 2/2 (100%)FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 432/557 (78%)CONDITIONAL 125/243 (51%) By packages autotests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 111/111 (100%)CONDITIONAL 38/72 (53%) src FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 321/446 (72%)CONDITIONAL 87/171 (51%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127968: kshareddatacache: Fix invalid use of & to avoid unaligned reads
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127968/ --- (Updated May 20, 2016, 11:08 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, David Faure and Michael Pyne. Changes --- Submitted with commit 2bd185e719a83143e140758b0fad6d4e1488bc24 by Luca Beltrame on behalf of Fabian Vogt to branch master. Repository: kcoreaddons Description --- That the & is wrong here is obvious: align can never be 2 inside the if condition as ```(2 & bool)``` is always false, yet the switch on align contains a case for 2. Instead it drops into the while loop for an 4-byte aligned pointer. This doesn't change the returned values on platforms where unaligned reads are permitted, so I didn't bump the version. Diffs - src/lib/caching/kshareddatacache.cpp 50bbf64 Diff: https://git.reviewboard.kde.org/r/127968/diff/ Testing --- Ran make test, all passed. Thanks, Fabian Vogt ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127972: Always update the Predicate parser from y/l sources
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127972/#review95643 --- >From the windows side, we have flex and bison. +1 - Hannah von Reth On May 20, 2016, 6:39 a.m., Pino Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127972/ > --- > > (Updated May 20, 2016, 6:39 a.m.) > > > Review request for KDE Software on Mac OS X, KDE Frameworks, kdewin, and > Lukáš Tinkl. > > > Repository: solid > > > Description > --- > > Turn Flex and Bison into required build dependencies, and use them to always > regenerate at build time the Predicate parser. This ensures that the parser > does not rot, and there is no more need to rely on autogenerated sources > added statically among the others. > > Second commit: remove old generated files of Predicate parser > > > Diffs > - > > CMakeLists.txt 763e09cfeeebdc9e42b68e8ab6c9e29c54d3e741 > src/solid/CMakeLists.txt f2b43b27cb47531ed57b2eccafad8e67951b56b9 > src/solid/devices/CMakeLists.txt 9271ae1e36b67b112be54a6ff9c6fb76a8a0a824 > src/solid/devices/predicate_lexer.c > 3b5a0b90907baf1cd2631da4de650ec153d0f642 > src/solid/devices/predicate_parser.h > 68e25070d498f5a635489af51f4b772c5f374108 > src/solid/devices/predicate_parser.c > 6d35ff25f001a43cbfecacc11e7d7591bb4808f9 > > Diff: https://git.reviewboard.kde.org/r/127972/diff/ > > > Testing > --- > > Builds fine with flex 2.6.0 and bison 3.0.4; `make test` passes too. > > > Thanks, > > Pino Toscano > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme
> On May 17, 2016, 4:37 p.m., Martin Gräßlin wrote: > > given that Plasma integration got removed I suggest to create a dedicated > > osx-integration repository for it as well. > > René J.V. Bertin wrote: > I quite like the way things are, but yes, I've played with that idea. > > I guess I can simply fork `frameworkintegration`, change the project name > in the toplevel CMake file and strip everything except for the platformtheme. > > How does this work from that point onwards? > > Martin Gräßlin wrote: > > I guess I can simply fork frameworkintegration, change the project name > in the toplevel CMake file and strip everything except for the platformtheme. > > That's kind of how I did it for plasma-integration with git filter-tree. > > > How does this work from that point onwards? > > My suggestion would be to create something like an "OSX integration" > project in the metadata and have then all your repositories grouped there > including the new platform theme. > > René J.V. Bertin wrote: > This is something I'm completely new to; what metadata are we talking > about here? > Also, can anyone with commit access to existing repositories also create > new ones on the server, and in what category would you suggest putting this? > > Boudhayan Gupta wrote: > For now, start with a scratch repo. Sysadmin will take care of the rest > for you. > > René J.V. Bertin wrote: > As I said, creating or proposing a new KDE package/repository is > completely new for me, even that instruction is still ambiguous. I take it > you're not talking about a scratch repo that exists only on one of my disks, > possibly not even on a remote mirror like github, but rather something that > would alert the sysadmins who will then take the appropriate actions? > > I guess I should look through the developer/contributor instructions > again, I most certainly skipped this level of information when I first (and > last...) read that documentation. > > Elvis Angelaccio wrote: > Here you can find the instructions to create a scratch repo: > https://community.kde.org/Sysadmin/GitKdeOrgManual#Personal_scratch_repositories > > René J.V. Bertin wrote: > ah, great, thanks. Looks exactly what I need except that it doesn't > appear to say anything about the metadata Martin mentions. But it's a start :) > > Martin Gräßlin wrote: > The metadata is in kde-build-metadata.git > (https://quickgit.kde.org/?p=kde-build-metadata.git ) Right, that metadata :) Seems that will be among the last things to update; I don't see any project from scratch mentioned in that repo. I've begun setting up an OS X Integration project. For some reason my git install lacks the filter-tree command so I've gone the manual route copying the frameworkintegration repo with the patch from this RR. I've removed all files that shouldn't be included, changed names etc (haven't pruned the dependencies yet), and committed to `scratch/rjvbb/osx-integration`. Very much a work-in-progress; I'll have to update my own install (and "ports" tree) to 5.22 before I can check building (though I presume it *should* build against 5.20.0 if I downgrade the dependency requirement). I just realise this gives the repo a commit history that's a *lot* larger than the current code base. Is there something I should and could do about that? - René J.V. --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/#review95538 --- On May 16, 2016, 9:49 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126198/ > --- > > (Updated May 16, 2016, 9:49 p.m.) > > > Review request for KDE Software on Mac OS X, KDE Frameworks, Plasma, and > Valorie Zimmerman. > > > Repository: frameworkintegration > > > Description > --- > > The KdePlatformTheme plugin can be enabled on OS X with a minimal patch to > Qt5; all that is required is to include the `qgenericunixservices` and > `qgenericunixthemes` components in the build, and to append `"kde"` to the > list returned by `QCocoaIntegration::themeNames()` for instance under the > condition that `KDE_SESSION_VERSION` is set to a suitable value in the > environment. > > This will allow KF5 and Qt5 applications to use the theme selected through > KDE if FrameworkIntegration is installed and KDE_SESSION_VERSION is set, > which seems like a sufficiently specific set of conditions that is easy to > avoid by users who prefer to use the Mac native theme. > > While requestion the KDE theme is also possible through `-style kde` or `env > QT_STYLE_OVERRIDE=kde` the use of the
Re: Review Request 127968: kshareddatacache: Fix invalid use of & to avoid unaligned reads
> On Mai 19, 2016, 11:17 nachm., Michael Pyne wrote: > > This is an error upstream in the MurmurHash 1.0 aligned implementation > > (which still contains the error, see > > https://sites.google.com/site/murmurhash/MurmurHashAligned.cpp?attredirects=0 > > ) > > > > In our case KSharedDataCache will never pass an unaligned block into the > > hash function so 'align' was always 0 (and boolean false) anyways. So I > > concur with not bumping the cache version and agree with your patch. Thanks > > for taking a look! I didn't know this aligned implementation actually had an upstream, it's actually fixed there, the latest source is on GitHub: https://github.com/aappleby/smhasher/blob/master/src/MurmurHash1.cpp#L87 - Fabian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127968/#review95630 --- On Mai 19, 2016, 6:13 nachm., Fabian Vogt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127968/ > --- > > (Updated Mai 19, 2016, 6:13 nachm.) > > > Review request for KDE Frameworks, David Faure and Michael Pyne. > > > Repository: kcoreaddons > > > Description > --- > > That the & is wrong here is obvious: > align can never be 2 inside the if condition as ```(2 & bool)``` is always > false, > yet the switch on align contains a case for 2. > Instead it drops into the while loop for an 4-byte aligned pointer. > > This doesn't change the returned values on platforms where unaligned reads > are permitted, so I didn't bump the version. > > > Diffs > - > > src/lib/caching/kshareddatacache.cpp 50bbf64 > > Diff: https://git.reviewboard.kde.org/r/127968/diff/ > > > Testing > --- > > Ran make test, all passed. > > > Thanks, > > Fabian Vogt > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme
> On May 17, 2016, 4:37 p.m., Martin Gräßlin wrote: > > given that Plasma integration got removed I suggest to create a dedicated > > osx-integration repository for it as well. > > René J.V. Bertin wrote: > I quite like the way things are, but yes, I've played with that idea. > > I guess I can simply fork `frameworkintegration`, change the project name > in the toplevel CMake file and strip everything except for the platformtheme. > > How does this work from that point onwards? > > Martin Gräßlin wrote: > > I guess I can simply fork frameworkintegration, change the project name > in the toplevel CMake file and strip everything except for the platformtheme. > > That's kind of how I did it for plasma-integration with git filter-tree. > > > How does this work from that point onwards? > > My suggestion would be to create something like an "OSX integration" > project in the metadata and have then all your repositories grouped there > including the new platform theme. > > René J.V. Bertin wrote: > This is something I'm completely new to; what metadata are we talking > about here? > Also, can anyone with commit access to existing repositories also create > new ones on the server, and in what category would you suggest putting this? > > Boudhayan Gupta wrote: > For now, start with a scratch repo. Sysadmin will take care of the rest > for you. > > René J.V. Bertin wrote: > As I said, creating or proposing a new KDE package/repository is > completely new for me, even that instruction is still ambiguous. I take it > you're not talking about a scratch repo that exists only on one of my disks, > possibly not even on a remote mirror like github, but rather something that > would alert the sysadmins who will then take the appropriate actions? > > I guess I should look through the developer/contributor instructions > again, I most certainly skipped this level of information when I first (and > last...) read that documentation. > > Elvis Angelaccio wrote: > Here you can find the instructions to create a scratch repo: > https://community.kde.org/Sysadmin/GitKdeOrgManual#Personal_scratch_repositories > > René J.V. Bertin wrote: > ah, great, thanks. Looks exactly what I need except that it doesn't > appear to say anything about the metadata Martin mentions. But it's a start :) The metadata is in kde-build-metadata.git (https://quickgit.kde.org/?p=kde-build-metadata.git ) - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/#review95538 --- On May 16, 2016, 9:49 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126198/ > --- > > (Updated May 16, 2016, 9:49 p.m.) > > > Review request for KDE Software on Mac OS X, KDE Frameworks, Plasma, and > Valorie Zimmerman. > > > Repository: frameworkintegration > > > Description > --- > > The KdePlatformTheme plugin can be enabled on OS X with a minimal patch to > Qt5; all that is required is to include the `qgenericunixservices` and > `qgenericunixthemes` components in the build, and to append `"kde"` to the > list returned by `QCocoaIntegration::themeNames()` for instance under the > condition that `KDE_SESSION_VERSION` is set to a suitable value in the > environment. > > This will allow KF5 and Qt5 applications to use the theme selected through > KDE if FrameworkIntegration is installed and KDE_SESSION_VERSION is set, > which seems like a sufficiently specific set of conditions that is easy to > avoid by users who prefer to use the Mac native theme. > > While requestion the KDE theme is also possible through `-style kde` or `env > QT_STYLE_OVERRIDE=kde` the use of the KdePlatformTheme plugin appears to be > the only way to get the full theme, including the font and colour selection. > In my opinion it is above all the font customisation which is a very welcome > feature for Qt/Mac; by default Qt applications use the default system font > (Lucida Grande 13pt or even 14pt) throughout. This is a good UI font, but not > at that size (and most "native" OS X applications indeed use a range of > smaller sizes, depending on role. > > It does have introduce a number of regressions, which the current patch aims > to address. The most visible and problematic of these regressions is the loss > of the Mac-style menu bar and thus of all menu items (actions). > > The fix is straightforward : on OS X (and similarly affected platforms?), an > instance of the native Cocoa platform theme is created through the private > API, and used as a fallback rather than immediately falling back to
Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127809/#review95638 --- Ship it! Sorry for the hard review. - Martin Gräßlin On May 18, 2016, 10:06 a.m., Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127809/ > --- > > (Updated May 18, 2016, 10:06 a.m.) > > > Review request for KDE Frameworks, KDE Usability and Martin Gräßlin. > > > Bugs: 362324 > https://bugs.kde.org/show_bug.cgi?id=362324 > > > Repository: kwindowsystem > > > Description > --- > > The api function is KWindowSystem::icon (WId win, int width=-1, int > height=-1, bool scale=false) so caller must get best size not worst when > width/height is not specified. > > > Diffs > - > > src/platforms/xcb/kwindowsystem.cpp 5b7c65a > > Diff: https://git.reviewboard.kde.org/r/127809/diff/ > > > Testing > --- > > > File Attachments > > > before > > https://git.reviewboard.kde.org/media/uploaded/files/2016/05/01/6d718ef6-26cf-4866-94d2-4ffbdfc906fe__Screenshot_20160426_232109.png > after > > https://git.reviewboard.kde.org/media/uploaded/files/2016/05/01/7dcab4ae-e451-4d43-8799-a0fcab471a3d__Screenshot_20160501_224642.png > > > Thanks, > > Anthony Fieroni > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127972: Always update the Predicate parser from y/l sources
> On May 19, 2016, 10:30 p.m., Aleix Pol Gonzalez wrote: > > This has been like this for years. Has any of the premises changed? > > Michael Pyne wrote: > I think it's a good idea, if only to keep up with changes to the > generated sources to account for things like undefined behavior fixes, fixes > for new compiler warnings, etc. Some of our users will build with updated > bison/flex (and I believe they're both required for KHTML still already) so > it's best to limit the number of different versions of generated parsers out > there, IMHO. Before this RR, I fixed with commit b3d52004b0f1af0abd0a2ca907a7c857293dce36 the predicate grammar, which was producing a non-compiling source; also, the current `UpdateSolidPredicateParser` rule is broken. These led me thinking that nobody really run the rule in years, which is not good. Additionally, generated sources added statically in the source tree is really a bad idea. - Pino --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127972/#review95629 --- On May 19, 2016, 10:19 p.m., Pino Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127972/ > --- > > (Updated May 19, 2016, 10:19 p.m.) > > > Review request for KDE Frameworks and Lukáš Tinkl. > > > Repository: solid > > > Description > --- > > Turn Flex and Bison into required build dependencies, and use them to always > regenerate at build time the Predicate parser. This ensures that the parser > does not rot, and there is no more need to rely on autogenerated sources > added statically among the others. > > Second commit: remove old generated files of Predicate parser > > > Diffs > - > > CMakeLists.txt 763e09cfeeebdc9e42b68e8ab6c9e29c54d3e741 > src/solid/CMakeLists.txt f2b43b27cb47531ed57b2eccafad8e67951b56b9 > src/solid/devices/CMakeLists.txt 9271ae1e36b67b112be54a6ff9c6fb76a8a0a824 > src/solid/devices/predicate_lexer.c > 3b5a0b90907baf1cd2631da4de650ec153d0f642 > src/solid/devices/predicate_parser.h > 68e25070d498f5a635489af51f4b772c5f374108 > src/solid/devices/predicate_parser.c > 6d35ff25f001a43cbfecacc11e7d7591bb4808f9 > > Diff: https://git.reviewboard.kde.org/r/127972/diff/ > > > Testing > --- > > Builds fine with flex 2.6.0 and bison 3.0.4; `make test` passes too. > > > Thanks, > > Pino Toscano > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127747: Create a new script that generate the documentation for all projects following the syntax I proposed
> On May 20, 2016, 3:50 a.m., Michael Pyne wrote: > > I've looked at the code itself and it seems reasonable, so from that > > perspective and given the length of time there's been no -1's, I think it's > > safe to commit. > > > > However you mentioned in the description that this isn't safe to commit to > > master. I have no clue how we generate apidox for KF5 and Plasma 5 so I'm > > not sure what you mean when you say we'd affect the currents script. What > > is your plan for integrating this without breaking the scripts? Is there > > work needed by others (sysadmin, EBN, etc.) to make apidox generation work > > with your patch committed? What's the action KDE developers must take after > > this, if any? > > Olivier Churlaud wrote: > Thank you for the review Michel. The only need will be to update the > metainfo.yml. I can do that for the frameworks if needed after commiting. Or > I can even do this before so that it doesn't break. > > Commit plan: > 1) update frameworks metainfo (they are back-compatibles but the *new* > script will break with the old metainfo. > 2) commit in master > 3) See if everything works as expected else correct. > 4) Clean up the code and teach it new tricks ; Add other projects that > the frameworks. Oh and maybe the current folder containing the html pages should be removed as well. - Olivier --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127747/#review95632 --- On April 25, 2016, 11:49 p.m., Olivier Churlaud wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127747/ > --- > > (Updated April 25, 2016, 11:49 p.m.) > > > Review request for KDE Frameworks, Albert Astals Cid, Alex Merry, Aurélien > Gâteau, and Allen Winter. > > > Repository: kapidox > > > Description > --- > > Keep in mind that it should not plainly replace kgenframeworks but be used by > all KDE projects. So in this proposition, the Frameworks are just one project > in others. > > The code can be tested directly by checking the branch > `olivier/generate_all_repos`. > > This MUST NOT be merged in master, because it will break the currents scripts > (see commit 3643dded7cf14a5634879e8e6e34be8840143d7e). > > > Diffs > - > > konqi_frameworks.png PRE-CREATION > metainfo.yaml 4ff17c8 > metainfo_syntax.md PRE-CREATION > src/kapidox/data/htmlresource/default_product.png PRE-CREATION > src/kapidox/data/htmlresource/kde.css b864ef5 > src/kapidox/data/templates/doxygen2.html PRE-CREATION > src/kapidox/data/templates/frontpage.html PRE-CREATION > src/kapidox/data/templates/libinfo.html PRE-CREATION > src/kapidox/data/templates/maintainers.html PRE-CREATION > src/kapidox/data/templates/subgroup.html PRE-CREATION > src/kapidox/generator.py 5b8ae40 > src/newkapidox.py PRE-CREATION > src/notes PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/127747/diff/ > > > Testing > --- > > Tested on various scenario cases. > > > File Attachments > > > This is an example of what I generated. (Threadweaver is duplicated and > modified to test different scenarios) > > https://git.reviewboard.kde.org/media/uploaded/files/2016/04/25/2e4549e4-7c17-416c-9a72-b82d3bba18b3__doc.tar.gz > > > Thanks, > > Olivier Churlaud > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
