date:20160814

Re: Review Request 128680: [KCharSelect] Add ToolButton for dimming characters not available in selected font

2016-08-14 Thread Christoph Feck


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128680/
---

(Updated Aug. 15, 2016, 3:12 a.m.)


Review request for KDE Frameworks and KDE Usability.


Bugs: 97420
https://bugs.kde.org/show_bug.cgi?id=97420


Repository: kwidgetsaddons


Description
---

Adds a toolbutton to the right of the font combobox to control the "font 
merging" property of QFont. When selected, characters which are not available 
in the font are dimmed (i.e. look disabled).

Seeking feedback about:
- placement of the button
- used icon (currently "format-text-strikethrough"; it shows an S character 
which could stand for "substitution")
- action name and tooltip (see line 477 and 479)
- and code changes ;)

I was unsure if the toolbutton could have a popup menu showing three options:
1) show characters from all fonts
2) dim characters not available in font
3) hide characters not available in font

but I did not implement it, because it felt odd not being able to see _which_ 
characters are not available in the font.


Diffs
-

  src/kcharselect.cpp 45c1e99 

Diff: https://git.reviewboard.kde.org/r/128680/diff/


Testing
---


File Attachments (updated)


Character table with font substitution (default)
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/15/7220dddb-ca1b-42a2-966c-791925156baf__snapshot1.png
Character table with dimming substituted characters
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/15/67c02866-b12c-4080-b6a4-22e29006448b__snapshot2.png


Thanks,

Christoph Feck

Review Request 128680: [KCharSelect] Add ToolButton for dimming characters not available in selected font

2016-08-14 Thread Christoph Feck


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128680/
---

Review request for KDE Frameworks and KDE Usability.


Bugs: 97420
https://bugs.kde.org/show_bug.cgi?id=97420


Repository: kwidgetsaddons


Description
---

Adds a toolbutton to the right of the font combobox to control the "font 
merging" property of QFont. When selected, characters which are not available 
in the font are dimmed (i.e. look disabled).

Seeking feedback about:
- placement of the button
- used icon (currently "format-text-strikethrough"; it shows an S character 
which could stand for "substitution")
- action name and tooltip (see line 477 and 479)
- and code changes ;)

I was unsure if the toolbutton could have a popup menu showing three options:
1) show characters from all fonts
2) dim characters not available in font
3) hide characters not available in font

but I did not implement it, because it felt odd not being able to see _which_ 
characters are not available in the font.


Diffs
-

  src/kcharselect.cpp 45c1e99 

Diff: https://git.reviewboard.kde.org/r/128680/diff/


Testing
---


Thanks,

Christoph Feck

Re: Review Request 128678: Install the translated documentation

2016-08-14 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128678/#review98389
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Aug. 15, 2016, 12:41 a.m., Luigi Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128678/
> ---
> 
> (Updated Aug. 15, 2016, 12:41 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and David Faure.
> 
> 
> Repository: kjs
> 
> 
> Description
> ---
> 
> The kjs man page is translated, so install the translations if available.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 450c2b7 
> 
> Diff: https://git.reviewboard.kde.org/r/128678/diff/
> 
> 
> Testing
> ---
> 
> Compiled with and without the po/ directory as in the tarball.
> 
> Side note: we probably don't need the pattern like
>  if (IS_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/po")
>  ...
>  endif()
> 
> around ki18n_install and kdoctools_install, as they rely on a glob which, if 
> empty, simply lead to no actions.
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

Re: Review Request 128660: Add an optional reveal password button to TextField

2016-08-14 Thread David Edmundson


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128660/
---

(Updated Aug. 14, 2016, 10:48 p.m.)


Review request for KDE Frameworks and Plasma.


Changes
---

Did Kai's comments.

This patch also fixes:

margins being re-evaluated on property changes
RTL icons
Actual use of the style in QQC without use of PlasmaComponents


Repository: plasma-framework


Description
---

Similar to KPasswordWidget in kwidgetaddons


Diffs (updated)
-

  src/declarativeimports/plasmacomponents/qml/TextField.qml 
c0d9155df5bb584cd3070a66c99d98465b81a5ef 
  src/declarativeimports/plasmastyle/TextFieldStyle.qml 
05ff3d542ad0de6879ec1de832b5e5d9ed33281e 
  tests/components/textfield.qml 0a7f8886ba0552c2bb23424ee873423cc5ee0585 

Diff: https://git.reviewboard.kde.org/r/128660/diff/


Testing
---

Updated manual test. See screenshot.


File Attachments


Spectacle.B12253.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/12/b308072d-a1c2-4bd8-9405-2826fc9f4086__Spectacle.B12253.png


Thanks,

David Edmundson

Review Request 128678: Install the translated documentation

2016-08-14 Thread Luigi Toscano


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128678/
---

Review request for Documentation, KDE Frameworks and David Faure.


Repository: kjs


Description
---

The kjs man page is translated, so install the translations if available.


Diffs
-

  CMakeLists.txt 450c2b7 

Diff: https://git.reviewboard.kde.org/r/128678/diff/


Testing
---

Compiled with and without the po/ directory as in the tarball.

Side note: we probably don't need the pattern like
 if (IS_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/po")
 ...
 endif()

around ki18n_install and kdoctools_install, as they rely on a glob which, if 
empty, simply lead to no actions.


Thanks,

Luigi Toscano

Re: Review Request 128661: [KTreeWidgetsSearchLineWidget] Use placeholderText instead of separate label

2016-08-14 Thread Thomas Pfeiffer


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128661/#review98384
---



Actually, this is in violation of the current search HIG ( 
https://community.kde.org/KDE_Visual_Design_Group/HIG/SearchPattern ), but 
since the de-facto standard in our software and elsewhere is an inline hint, I 
suppose we should update the HIG.

So yes, +1, good change!

- Thomas Pfeiffer


On Aug. 12, 2016, 8:22 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128661/
> ---
> 
> (Updated Aug. 12, 2016, 8:22 a.m.)
> 
> 
> Review request for KDE Frameworks and KDE Usability.
> 
> 
> Repository: kitemviews
> 
> 
> Description
> ---
> 
> This makes the search look identical to virtually any other search box used 
> throughout the workspace.
> 
> 
> Diffs
> -
> 
>   src/ktreewidgetsearchline.cpp e40a61e 
>   src/ktreewidgetsearchlinewidget.cpp 9af4c2e 
> 
> Diff: https://git.reviewboard.kde.org/r/128661/diff/
> 
> 
> Testing
> ---
> 
> Tests still pass.
> 
> Looks good. I couldn't figure out how to just create the QLineEdit without 
> the intermediate QHBoxLayout.
> 
> 
> File Attachments
> 
> 
> Separate "Search:" label gone
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/12/c1e2e92d-2113-4d9f-9594-a2e1db0545c2__Screenshot_20160812_102022.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

Jenkins-kde-ci: sonnet master stable-kf5-qt5 » Linux,gcc - Build # 54 - Still Failing!

2016-08-14 Thread no-reply


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/sonnet%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/54/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 14 Aug 2016 18:21:21 +
Build duration: 27 sec

CHANGE SET
Revision c4f22b8bc9fc3834e0c0dd6268086a2031913adc by martin.sandsmark: (add 
license to gentrigrams)
  change: edit data/gentrigrams.cpp

Jenkins-kde-ci: sonnet master stable-kf5-qt5 » Linux,gcc - Build # 53 - Failure!

2016-08-14 Thread no-reply


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/sonnet%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/53/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 14 Aug 2016 18:16:11 +
Build duration: 1 min 49 sec

CHANGE SET
Revision 59cc2d4b5351031dace4cb04740cd8b50c7c219e by martin.sandsmark: (Add 
tool to generate trigrams)
  change: add data/gentrigrams.cpp
  change: edit data/CMakeLists.txt
Revision 8ed9a423a2237ac1b21bdd0cc8a7ba3d6ae71a92 by martin.sandsmark: (Replace 
hand-curated list of script-language mappings, use proper names)
  change: delete data/trigrams/nb
  change: delete data/trigrams/ps
  change: delete data/trigrams/ss
  change: add data/trigrams/hr_HR
  change: add data/trigrams/ky_KG
  change: delete data/trigrams/so
  change: add data/trigrams/sr_RS
  change: add data/trigrams/af_ZA
  change: delete data/trigrams/pl
  change: delete data/trigrams/th
  change: add data/trigrams/kk_KZ
  change: add data/trigrams/ko_KR
  change: add data/trigrams/fi_FI
  change: add data/trigrams/bg_BG
  change: delete data/trigrams/sl
  change: delete data/trigrams/ky
  change: add data/trigrams/pl_PL
  change: add data/trigrams/ss_ZA
  change: delete data/trigrams/nl
  change: add data/trigrams/nb_NO
  change: add data/trigrams/fr_FR
  change: add data/trigrams/cs_CZ
  change: delete data/trigrams/tl
  change: add data/trigrams/fa_IR
  change: delete data/trigrams/xh
  change: add data/trigrams/hu_HU
  change: add data/trigrams/lo_LA
  change: add data/trigrams/uz_UZ
  change: add data/trigrams/lv_LV
  change: add data/trigrams/ps_AF
  change: delete data/trigrams/ts
  change: add data/trigrams/ru_RU
  change: delete data/trigrams/et
  change: add data/trigrams/ar_EG
  change: add data/trigrams/nr_ZA
  change: delete data/trigrams/hi
  change: delete data/trigrams/id
  change: delete data/trigrams/de
  change: add data/trigrams/mn_MN
  change: add data/trigrams/ur_PK
  change: delete data/trigrams/ha
  change: delete data/trigrams/it
  change: add data/trigrams/sk_SK
  change: delete data/trigrams/en
  change: add data/trigrams/sq_AL
  change: add data/trigrams/fil_PH
  change: add data/trigrams/is_IS
  change: delete data/trigrams/fi
  change: delete data/trigrams/eu
  change: delete data/trigrams/vi
  change: delete data/trigrams/ca
  change: delete data/trigrams/mn
  change: delete data/trigrams/af
  change: delete data/trigrams/ve
  change: add data/trigrams/th_TH
  change: delete data/trigrams/sr
  change: add data/trigrams/ha_NG
  change: add data/trigrams/ja_JP
  change: add data/trigrams/ro_RO
  change: delete data/trigrams/cs
  change: add data/trigrams/vi_VN
  change: delete data/trigrams/tn
  change: add data/trigrams/so_SO
  change: edit src/core/guesslanguage.cpp
  change: add data/trigrams/sl_SI
  change: delete data/trigrams/mk
  change: add data/trigrams/cy_GB
  change: add data/trigrams/mk_MK
  change: add data/trigrams/tn_ZA
  change: delete data/trigrams/zu
  change: add data/trigrams/en_US
  change: delete data/trigrams/nr
  change: delete data/trigrams/sk
  change: add data/trigrams/es_ES
  change: add data/trigrams/ve_ZA
  change: delete data/trigrams/sv
  change: delete data/trigrams/ja
  change: delete data/trigrams/es
  change: add data/trigrams/it_IT
  change: add data/trigrams/hi_IN
  change: add data/trigrams/xh_ZA
  change: delete data/trigrams/ar
  change: delete data/trigrams/hu
  change: delete data/trigrams/fa
  change: delete data/trigrams/ko
  change: delete data/trigrams/fr
  change: delete data/trigrams/kk
  change: delete data/trigrams/ro
  change: add data/trigrams/uk_UA
  change: delete data/trigrams/pt
  change: delete data/trigrams/lv
  change: delete data/trigrams/ru
  change: add data/trigrams/zu_ZA
  change: delete data/trigrams/tr
  change: delete data/trigrams/st
  change: add data/trigrams/de_DE
  change: add data/trigrams/tr_TR
  change: add data/trigrams/st_ZA
  change: add data/trigrams/da_DK
  change: delete data/trigrams/uz
  change: delete data/trigrams/hr
  change: add data/trigrams/az_AZ
  change: delete data/trigrams/sw
  change: delete data/trigrams/bg
  change: delete data/trigrams/sq
  change: delete data/trigrams/lt
  change: delete data/trigrams/az
  change: delete data/trigrams/is
  change: add data/trigrams/ca_ES
  change: delete data/trigrams/ne
  change: add data/trigrams/ne_NP
  change: delete data/trigrams/uk
  change: add data/trigrams/nl_NL
  change: add data/trigrams/et_EE
  change: delete data/trigrams/cy
  change: add data/trigrams/sv_SE
  change: add data/trigrams/ts_ZA
  change: delete data/trigrams/la
  change: add data/trigrams/sw_TZ
  change: add data/trigrams/id_ID
  change: add data/trigrams/lt_LT
  change: delete data/trigrams/da
  change: delete data/trigrams/ur
  change: add data/trigrams/eu_ES
Revision 165f4cd0c7fe1f7a09bf83108fc333b957b960e9 by martin.sandsmark: (Handle 
dictionaries without correct names)
  change: edit src/core/guesslanguage.cpp

Re: Review Request 128618: Fix creating symlink in Folder View

2016-08-14 Thread Chinmoy Ranjan Pradhan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128618/
---

(Updated Aug. 14, 2016, 11:49 a.m.)


Review request for KDE Frameworks and David Faure.


Repository: kio


Description
---

KIO::link creates symlink when either protocol+host+port+username+password of 
the source and the link are same or the link is going to be created locally. In 
case of plasma's folder view none of the above cases are true therefore 
creating a symlink in folder view plasmoid gives an error.  
This patch aims to fix this issue.


Diffs (updated)
-

  src/core/copyjob.cpp 8d6ab05 

Diff: https://git.reviewboard.kde.org/r/128618/diff/


Testing
---

All tests pass.


File Attachments


error message
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/06/d4da6ff3-53d8-49d1-a826-0c8cf12d7aa0__symlink_folderview.png


Thanks,

Chinmoy Ranjan Pradhan

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 239 - Unstable!

2016-08-14 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/239/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 14 Aug 2016 11:23:36 +
Build duration: 16 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 
54 test(s)Failed: TestSuite.indenttest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 24/28 (86%)FILES 292/328 (89%)CLASSES 292/328 (89%)LINE 32641/49221 
(66%)CONDITIONAL 16500/32846 (50%)

By packages
  
autotests.src
FILES 46/46 (100%)CLASSES 46/46 (100%)LINE 3937/4286 
(92%)CONDITIONAL 1896/3918 (48%)
autotests.src.vimode
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 5525/5569 
(99%)CONDITIONAL 897/1658 (54%)
src.buffer
FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1602/1759 
(91%)CONDITIONAL 1245/1622 (77%)
src.completion
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 1756/3102 
(57%)CONDITIONAL 1208/2798 (43%)
src.completion.expandingtree
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 184/464 (40%)CONDITIONAL 
79/354 (22%)
src.dialogs
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/935 (0%)CONDITIONAL 0/274 
(0%)
src.document
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1776/3214 
(55%)CONDITIONAL 1450/3191 (45%)
src.export
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 106/125 (85%)CONDITIONAL 
106/152 (70%)
src.include.ktexteditor
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 203/244 
(83%)CONDITIONAL 144/228 (63%)
src.inputmode
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 172/326 (53%)CONDITIONAL 
40/85 (47%)
src.mode
FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 159/423 (38%)CONDITIONAL 
96/269 (36%)
src.printing
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/885 (0%)CONDITIONAL 0/294 
(0%)
src.render
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 914/1225 
(75%)CONDITIONAL 605/932 (65%)
src.schema
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1538 (1%)CONDITIONAL 
7/697 (1%)
src.script
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 587/1055 
(56%)CONDITIONAL 238/556 (43%)
src.search
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 1012/1389 
(73%)CONDITIONAL 565/904 (63%)
src.spellcheck
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 372/1336 (28%)CONDITIONAL 
205/820 (25%)
src.swapfile
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 119/365 (33%)CONDITIONAL 
57/195 (29%)
src.syntax
FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1592/2151 
(74%)CONDITIONAL 962/1784 (54%)
src.syntax.data
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 51/69 (74%)CONDITIONAL 
73/92 (79%)
src.undo
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 671/772 (87%)CONDITIONAL 
320/448 (71%)
src.utils
FILES 33/36 (92%)CLASSES 33/36 (92%)LINE 2559/3913 
(65%)CONDITIONAL 1318/2728 (48%)
src.variableeditor
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/668 (0%)CONDITIONAL 0/170 
(0%)
src.view
FILES 15/19 (79%)CLASSES 15/19 (79%)LINE 3293/6281 
(52%)CONDITIONAL 1487/3788 (39%)
src.vimode
FILES 34/34 (100%)CLASSES 34/34 (100%)LINE 1876/2340 
(80%)CONDITIONAL 1028/1751 (59%)
src.vimode.config
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/134 (0%)CONDITIONAL 0/90 
(0%)
src.vimode.emulatedcommandbar
FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 901/913 
(99%)CONDITIONAL 614/678 (91%)
src.vimode.modes
FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 3253/3740 
(87%)CONDITIONAL 1860/2370 (78%)

Re: Review Request 128618: Fix creating symlink in Folder View

2016-08-14 Thread David Faure


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128618/#review98382
---



Well, unittests in kio_desktop would certainly be a good idea, but at least in 
this version most of the change is tested by the kio unittest so I'm more 
confident.


src/core/copyjob.cpp (line 411)


Suggestion: store the filename here rather than the URL, it will be easier 
to read compared to the current "dest vs m_dest".


- David Faure


On Aug. 14, 2016, 11:32 a.m., Chinmoy Ranjan Pradhan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128618/
> ---
> 
> (Updated Aug. 14, 2016, 11:32 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> KIO::link creates symlink when either protocol+host+port+username+password of 
> the source and the link are same or the link is going to be created locally. 
> In case of plasma's folder view none of the above cases are true therefore 
> creating a symlink in folder view plasmoid gives an error.  
> This patch aims to fix this issue.
> 
> 
> Diffs
> -
> 
>   src/core/copyjob.cpp 8d6ab05 
> 
> Diff: https://git.reviewboard.kde.org/r/128618/diff/
> 
> 
> Testing
> ---
> 
> All tests pass.
> 
> 
> File Attachments
> 
> 
> error message
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/06/d4da6ff3-53d8-49d1-a826-0c8cf12d7aa0__symlink_folderview.png
> 
> 
> Thanks,
> 
> Chinmoy Ranjan Pradhan
> 
>

Re: Review Request 128618: Fix creating symlink in Folder View

2016-08-14 Thread Chinmoy Ranjan Pradhan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128618/
---

(Updated Aug. 14, 2016, 11:32 a.m.)


Review request for KDE Frameworks and David Faure.


Changes
---

Made the required changes :)
Do we still need unittest(s) in kio_desktop?


Repository: kio


Description
---

KIO::link creates symlink when either protocol+host+port+username+password of 
the source and the link are same or the link is going to be created locally. In 
case of plasma's folder view none of the above cases are true therefore 
creating a symlink in folder view plasmoid gives an error.  
This patch aims to fix this issue.


Diffs (updated)
-

  src/core/copyjob.cpp 8d6ab05 

Diff: https://git.reviewboard.kde.org/r/128618/diff/


Testing
---

All tests pass.


File Attachments


error message
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/06/d4da6ff3-53d8-49d1-a826-0c8cf12d7aa0__symlink_folderview.png


Thanks,

Chinmoy Ranjan Pradhan

Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 191 - Fixed!

2016-08-14 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/191/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 14 Aug 2016 11:12:56 +
Build duration: 1 min 11 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 72/205 
(35%)CONDITIONAL 34/172 (20%)

By packages
  
autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 25/27 (93%)CONDITIONAL 
5/10 (50%)
src.kstyle
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 47/178 (26%)CONDITIONAL 
29/162 (18%)

Jenkins-kde-ci: kinit master stable-kf5-qt5 » Linux,gcc - Build # 179 - Fixed!

2016-08-14 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kinit%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/179/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 14 Aug 2016 11:12:56 +
Build duration: 35 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages

Jenkins-kde-ci: kinit master stable-kf5-qt5 » Linux,gcc - Build # 179 - Fixed!

2016-08-14 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kinit%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/179/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 14 Aug 2016 11:12:56 +
Build duration: 35 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages

Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 191 - Fixed!

2016-08-14 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/191/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 14 Aug 2016 11:12:56 +
Build duration: 1 min 11 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 72/205 
(35%)CONDITIONAL 34/172 (20%)

By packages
  
autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 25/27 (93%)CONDITIONAL 
5/10 (50%)
src.kstyle
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 47/178 (26%)CONDITIONAL 
29/162 (18%)

Jenkins-kde-ci: kactivities master kf5-qt5 » Linux,gcc - Build # 191 - Failure!

2016-08-14 Thread no-reply


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kactivities%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/191/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 14 Aug 2016 11:10:51 +
Build duration: 15 sec

CHANGE SET
No changes

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 190 - Failure!

2016-08-14 Thread no-reply


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/190/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 14 Aug 2016 11:10:51 +
Build duration: 9.5 sec

CHANGE SET
No changes

Jenkins-kde-ci: knewstuff master kf5-qt5 » Linux,gcc - Build # 189 - Failure!

2016-08-14 Thread no-reply


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/knewstuff%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/189/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 14 Aug 2016 11:10:51 +
Build duration: 9 sec

CHANGE SET
No changes

Jenkins-kde-ci: kinit master kf5-qt5 » Linux,gcc - Build # 181 - Failure!

2016-08-14 Thread no-reply


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kinit%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/181/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 14 Aug 2016 11:10:51 +
Build duration: 8.5 sec

CHANGE SET
No changes

Re: Review Request 128608: Add Donate entry to KStandardShortcut

2016-08-14 Thread Elvis Angelaccio


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128608/
---

(Updated Aug. 14, 2016, 12:16 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Matthew Dawson.


Changes
---

Submitted with commit 3434b9efd0a8b77d558e4376af38e17d59ded66c by Elvis 
Angelaccio to branch master.


Repository: kconfig


Description
---

This patch adds a Donate entry, such that 
https://git.reviewboard.kde.org/r/128609/ builds.

There is no default shortcut set.


Diffs
-

  src/gui/kstandardshortcut.h a5a7c28f86094bd346abc8dc17e24a6bd365f5bd 
  src/gui/kstandardshortcut.cpp 6d749455782d55a81ed5448f35eade954c1df615 

Diff: https://git.reviewboard.kde.org/r/128608/diff/


Testing
---


Thanks,

Elvis Angelaccio

Jenkins-kde-ci: kinit master stable-kf5-qt5 » Linux,gcc - Build # 178 - Failure!

2016-08-14 Thread no-reply


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kinit%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/178/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 14 Aug 2016 10:01:52 +
Build duration: 12 sec

CHANGE SET
No changes

Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 190 - Failure!

2016-08-14 Thread no-reply


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/190/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 14 Aug 2016 10:01:52 +
Build duration: 13 sec

CHANGE SET
No changes

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 178 - Fixed!

2016-08-14 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/178/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 14 Aug 2016 09:40:41 +
Build duration: 20 min

CHANGE SET
Revision 4d43c8fc3e8398b4c3f7dfcc4897144e5a279f60 by David Faure: ([autotests] 
Add more tests for KIO::linkAs, just to be sure.)
  change: edit autotests/jobtest.h
  change: edit autotests/jobtest.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 
50 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 262/341 (77%)CLASSES 262/341 (77%)LINE 27788/51198 
(54%)CONDITIONAL 15442/37959 (41%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7704/8024 
(96%)CONDITIONAL 4308/8410 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/117 (82%)CLASSES 96/117 (82%)LINE /14123 
(55%)CONDITIONAL 4234/9051 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2313/7572 
(31%)CONDITIONAL 922/4403 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 434/832 (52%)CONDITIONAL 
326/719 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3783 
(46%)CONDITIONAL 1249/3434 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 723/1155 (63%)CONDITIONAL 
384/753 (51%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 30/65 (46%)CLASSES 30/65 (46%)LINE 3374/10888 
(31%)CONDITIONAL 1603/6902 (23%)

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 178 - Fixed!

2016-08-14 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/178/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 14 Aug 2016 09:40:41 +
Build duration: 20 min

CHANGE SET
Revision 4d43c8fc3e8398b4c3f7dfcc4897144e5a279f60 by David Faure: ([autotests] 
Add more tests for KIO::linkAs, just to be sure.)
  change: edit autotests/jobtest.h
  change: edit autotests/jobtest.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 
50 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 262/341 (77%)CLASSES 262/341 (77%)LINE 27788/51198 
(54%)CONDITIONAL 15442/37959 (41%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7704/8024 
(96%)CONDITIONAL 4308/8410 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/117 (82%)CLASSES 96/117 (82%)LINE /14123 
(55%)CONDITIONAL 4234/9051 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2313/7572 
(31%)CONDITIONAL 922/4403 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 434/832 (52%)CONDITIONAL 
326/719 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3783 
(46%)CONDITIONAL 1249/3434 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 723/1155 (63%)CONDITIONAL 
384/753 (51%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 30/65 (46%)CLASSES 30/65 (46%)LINE 3374/10888 
(31%)CONDITIONAL 1603/6902 (23%)

Re: Review Request 128595: [KUnitConversion] Add British "stone" unit of mass

2016-08-14 Thread Kai Uwe Broulik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128595/
---

(Updated Aug. 14, 2016, 9:52 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Edmundson.


Changes
---

Submitted with commit 0a72b66290dcde6cca5eea225406bd478e3d07e2 by Kai Uwe 
Broulik to branch master.


Repository: kunitconversion


Description
---

This weird unit is pretty common in the UK and equal to 6.35029318 kg.


Diffs
-

  src/mass.cpp c7bf147 
  src/unit.h e440346 

Diff: https://git.reviewboard.kde.org/r/128595/diff/


Testing
---

This is the type of stone you use to smash display windows.

https://en.wikipedia.org/wiki/Stone_(unit)

Verified that krunner spit out the same result as Google converter did.


Thanks,

Kai Uwe Broulik

Re: Review Request 128219: No longer allow installing to generic data folder because of security hole.

2016-08-14 Thread David Faure


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128219/#review98380
---


Ship it!




Looks good to me, thanks.

And since this wasn't used anywhere, there's no actual security annoucement to 
make. It was just a tool for app developers to shoot themselves in the foot, 
but they were clever enough not to use it :-)   (it == "data" resource or "/" 
as target dir)

- David Faure


On Aug. 12, 2016, 6:58 p.m., Jeremy Whiting wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128219/
> ---
> 
> (Updated Aug. 12, 2016, 6:58 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Richard Moore.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> ---
> 
> When an application uses TargetDir=/ or StandardResource=data give a warning 
> on the terminal and don't use the chosen location.
> 
> 
> Diffs
> -
> 
>   src/core/installation.cpp a027418 
> 
> Diff: https://git.reviewboard.kde.org/r/128219/diff/
> 
> 
> Testing
> ---
> 
> No testing done yet, will write a unit test of some kind if this is the right 
> direction.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

Re: Review Request 128618: Fix creating symlink in Folder View

2016-08-14 Thread David Faure

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128618/#review98379
---

Looks great. Two minor fixes and it's good to go.

I just pushed more autotests with 4d43c8f, please rebase and check they pass 
with your changes too, but they should.

src/core/copyjob.cpp (line 332)

OK, I understand and I like this approach.

In "as" mode we don't need to stat the actual dest URL, better stat the 
parent directory which is more likely to exist.

It's faster (one stat() instead of two) and simpler.

Excellent strategy.

src/core/copyjob.cpp (line 411)

How do you know that the dest file doesn't exist? Maybe it does exist...

AFAICS it all works just fine without setting destinationState, anyway. 
It's only used if !m_asMethod.

src/core/copyjob.cpp (line 412)

How can we be sure that sLocalPath ends with a '/' ? Surely the kioslave 
doesn't have to provide it in UDS_LOCAL_PATH, so we'd better add one here (if 
it doesn't already end with a slash => needs an if()).

- David Faure

On Aug. 13, 2016, 5:27 p.m., Chinmoy Ranjan Pradhan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128618/
> ---
> 
> (Updated Aug. 13, 2016, 5:27 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> KIO::link creates symlink when either protocol+host+port+username+password of 
> the source and the link are same or the link is going to be created locally. 
> In case of plasma's folder view none of the above cases are true therefore 
> creating a symlink in folder view plasmoid gives an error.  
> This patch aims to fix this issue.
> 
> 
> Diffs
> -
> 
>   src/core/copyjob.cpp 8d6ab05 
> 
> Diff: https://git.reviewboard.kde.org/r/128618/diff/
> 
> 
> Testing
> ---
> 
> All tests pass.
> 
> 
> File Attachments
> 
> 
> error message
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/06/d4da6ff3-53d8-49d1-a826-0c8cf12d7aa0__symlink_folderview.png
> 
> 
> Thanks,
> 
> Chinmoy Ranjan Pradhan
> 
>

Re: Review Request 128680: [KCharSelect] Add ToolButton for dimming characters not available in selected font

Review Request 128680: [KCharSelect] Add ToolButton for dimming characters not available in selected font

Re: Review Request 128678: Install the translated documentation

Re: Review Request 128660: Add an optional reveal password button to TextField

Review Request 128678: Install the translated documentation

Re: Review Request 128661: [KTreeWidgetsSearchLineWidget] Use placeholderText instead of separate label

Jenkins-kde-ci: sonnet master stable-kf5-qt5 » Linux,gcc - Build # 54 - Still Failing!

Jenkins-kde-ci: sonnet master stable-kf5-qt5 » Linux,gcc - Build # 53 - Failure!

Re: Review Request 128618: Fix creating symlink in Folder View

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 239 - Unstable!

Re: Review Request 128618: Fix creating symlink in Folder View

Re: Review Request 128618: Fix creating symlink in Folder View

Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 191 - Fixed!

Jenkins-kde-ci: kinit master stable-kf5-qt5 » Linux,gcc - Build # 179 - Fixed!

Jenkins-kde-ci: kinit master stable-kf5-qt5 » Linux,gcc - Build # 179 - Fixed!

Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 191 - Fixed!

Jenkins-kde-ci: kactivities master kf5-qt5 » Linux,gcc - Build # 191 - Failure!

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 190 - Failure!

Jenkins-kde-ci: knewstuff master kf5-qt5 » Linux,gcc - Build # 189 - Failure!

Jenkins-kde-ci: kinit master kf5-qt5 » Linux,gcc - Build # 181 - Failure!

Re: Review Request 128608: Add Donate entry to KStandardShortcut

Jenkins-kde-ci: kinit master stable-kf5-qt5 » Linux,gcc - Build # 178 - Failure!

Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 190 - Failure!

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 178 - Fixed!

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 178 - Fixed!

Re: Review Request 128595: [KUnitConversion] Add British "stone" unit of mass

Re: Review Request 128219: No longer allow installing to generic data folder because of security hole.

Re: Review Request 128618: Fix creating symlink in Folder View

28 matches

Site Navigation

Mail list logo

Footer information