Review Request 129057: RFC: Make sense out of Plasma plugin metadata loading

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129057/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

I've been looking into what we're actually doing nowadays when we learn about a 
plasmoid at boot. I realized that we were doing a bit of a roundabout and 
there's definitely shorter paths.

As far as I understood, what we're doing is:

1. We list all plugins and construct their KPluginMetaData
2. We get the metadata file path and send it to corona, that will create a 
KService::Ptr and then construct a KPluginInfo from it.
3. KPluginInfo in turn parses the file again. Since recently KPluginInfo is 
parsing the files twice
3.1. using KPluginMetaData
3.2. using KDesktopFileParser

This patch, tries to simplify 2 and 3 into a KPluginMetaData construction call.

Furthermore, this will allow us eventually (in a separate iteration, and 
everything works according to the plan) to load plugins from metadata.json 
which would make it possible to get rid of the internal usage of the 
desktopfileparser within kcoreaddons. (With something like this 
https://paste.kde.org/pth9wmasc)


Diffs
-

  src/plasma/applet.h 449f761 
  src/plasma/applet.cpp 5e278dc 
  src/plasma/private/applet_p.h c3fe1d2 
  src/plasma/private/applet_p.cpp 0f37fe5 
  src/plasma/scripting/appletscript.cpp 42c0395 

Diff: https://git.reviewboard.kde.org/r/129057/diff/


Testing
---

My `plasmashell` starts beautifully, `CoronaTest::startupCompletion` doesn't 
for some reason I need to investigate further, but yes it's that late.


Thanks,

Aleix Pol Gonzalez

[Differential] [Updated] D2854: New: ECMGenerateApiDox, for generating qch & tag files

[Jarosław Staniek]

staniek added a comment.


  Added myself as reviewer, let's use Reviewers field so that people can see 
what's todo on the Phab home page.

REVISION DETAIL
  https://phabricator.kde.org/D2854

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, staniek
Cc: staniek, winterz, ochurlaud, #kdevelop, #frameworks

[Differential] [Updated] D2854: New: ECMGenerateApiDox, for generating qch & tag files

[Jarosław Staniek]

staniek added a reviewer: staniek.

REVISION DETAIL
  https://phabricator.kde.org/D2854

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, staniek
Cc: staniek, winterz, ochurlaud, #kdevelop, #frameworks

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 302 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/302/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 27 Sep 2016 22:23:02 +
Build duration: 4 min 32 sec

CHANGE SET
Revision 12b028c0a8586abde06125364b4099132b608125 by kainz.a: (update 32px 
mimetype and some 64px ones)
  change: edit icons/mimetypes/64/application-x-font-bdf.svg
  change: edit icons/mimetypes/32/application-epub+zip.svg
  change: edit icons/mimetypes/64/application-x-kexi-connectiondata.svg
  change: edit icons/mimetypes/64/application-vnd.ms-publisher.svg
  change: edit icons/mimetypes/32/application-vnd.oasis.opendocument.chart.svg
  change: edit icons/mimetypes/32/application-vnd.oasis.opendocument.formula.svg
  change: edit icons/mimetypes/32/application-vnd.ms-publisher.svg
  change: edit 
icons/mimetypes/32/application-vnd.ms-excel.addin.macroenabled.12.svg
  change: edit 
icons/mimetypes/32/application-vnd.oasis.opendocument.database.svg
  change: edit icons/mimetypes/64/application-x-kexiproject-shortcut.svg
  change: edit icons/mimetypes/64/application-vnd.ms-infopath.svg
  change: edit 
icons/mimetypes/64/application-vnd.oasis.opendocument.database.svg
  change: edit 
icons/mimetypes/32/application-vnd.ms-powerpoint.addin.macroenabled.12.svg
  change: edit icons/mimetypes/32/application-vnd.ms-infopath.svg


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 
test(s)Failed: TestSuite.dupe

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 105/132 
(80%)CONDITIONAL 46/78 (59%)

By packages
  

FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 63/75 (84%)CONDITIONAL 
32/52 (62%)

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 299 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/299/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 27 Sep 2016 22:23:02 +
Build duration: 2 min 58 sec

CHANGE SET
Revision 12b028c0a8586abde06125364b4099132b608125 by kainz.a: (update 32px 
mimetype and some 64px ones)
  change: edit 
icons/mimetypes/64/application-vnd.oasis.opendocument.database.svg
  change: edit 
icons/mimetypes/32/application-vnd.oasis.opendocument.database.svg
  change: edit icons/mimetypes/32/application-vnd.ms-infopath.svg
  change: edit 
icons/mimetypes/32/application-vnd.ms-excel.addin.macroenabled.12.svg
  change: edit icons/mimetypes/64/application-vnd.ms-infopath.svg
  change: edit icons/mimetypes/64/application-x-kexiproject-shortcut.svg
  change: edit 
icons/mimetypes/32/application-vnd.ms-powerpoint.addin.macroenabled.12.svg
  change: edit icons/mimetypes/32/application-vnd.oasis.opendocument.formula.svg
  change: edit icons/mimetypes/64/application-vnd.ms-publisher.svg
  change: edit icons/mimetypes/64/application-x-kexi-connectiondata.svg
  change: edit icons/mimetypes/64/application-x-font-bdf.svg
  change: edit icons/mimetypes/32/application-vnd.ms-publisher.svg
  change: edit icons/mimetypes/32/application-vnd.oasis.opendocument.chart.svg
  change: edit icons/mimetypes/32/application-epub+zip.svg


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 
test(s)Failed: TestSuite.dupe

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 105/132 
(80%)CONDITIONAL 46/78 (59%)

By packages
  

FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 63/75 (84%)CONDITIONAL 
32/52 (62%)

Re: Scrap baloo?

[Christoph Cullmann]

Hi,

> Hi,
> 
>>> Anyway, enough rambling. I should have something in a few days.
>> sure, take your time to look at it, its nothing we need to decide in a few 
>> days.
>> 
>> Just as prove of concept that tracker can do a lot of stuff and
>> we still can keep the public API we have (perhaps beside the indexerconfig
>> stuff,
>> beside if we start to query tracker configs, too) I hacked a bit more on
>> my tracker baloo variant.
>> 
>> https://quickgit.kde.org/?p=clones%2Fbaloo%2Fcullmann%2Ftbaloo.git
>> 
>> Stuff like:
>> 
>> baloosearch "type:Audio modified<=2016-12-12" -d /home/cullmann/data
>> 
>> works now again, still missing is handling of generic properties (which then
>> need to be mapped to the matching sparql names and tags) and the filling
>> of the KFileMedaData from the tracker DB.
>> 
>> But I think I will only invest time in that after we all came to some
>> consensus what to do at all, just wanted to show that tracker stuff is 
>> feasible
>> without a great amount of work with even keeping the API intact enough
>> that we would have some transition possibility without breaking BC/SC.
>> (modulo query string conversion glitches)
> anyone had some time to take a look at Baloo and Co.?
any update?

Greetings
Christoph

-- 
- Dr.-Ing. Christoph Cullmann -
AbsInt Angewandte Informatik GmbH  Email: cullm...@absint.com
Science Park 1 Tel:   +49-681-38360-22
66123 Saarbrücken  Fax:   +49-681-38360-20
GERMANYWWW:   http://www.AbsInt.com

Geschäftsführung: Dr.-Ing. Christian Ferdinand
Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234

Re: Review Request 129002: Use QCDebug in KIdleTime

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129002/
---

(Updated Sept. 27, 2016, 6:29 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kidletime


Description
---

Also move some warnings to QCWarning() and reactivated some commented
out debug messages now that they're not on by default


Diffs
-

  src/plugins/xsync/CMakeLists.txt 46175f717672739d6f24f0b6831b119b2b86e07d 
  src/plugins/xsync/xsyncbasedpoller.cpp 
05c29eb8fb185eefd25907b7e77bd6b87e9cccb0 

Diff: https://git.reviewboard.kde.org/r/129002/diff/


Testing
---


Thanks,

David Edmundson

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 301 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/301/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 27 Sep 2016 18:12:02 +
Build duration: 7 min 16 sec

CHANGE SET
Revision 16a37f23354deff7f3643872d1a6678ed55e5e37 by alessandro.longo: (Updated 
templates and other mimetypes with new colors at 32 and 64px)
  change: edit icons/mimetypes/32/text-x-script.svg
  change: edit 
icons/mimetypes/32/application-vnd.oasis.opendocument.spreadsheet-template.svg
  change: edit icons/mimetypes/32/x-office-spreadsheet.svg
  change: edit 
icons/mimetypes/32/application-vnd.ms-excel.template.macroenabled.12.svg
  change: edit 
icons/mimetypes/32/application-vnd.ms-powerpoint.template.macroenabled.12.svg
  change: edit 
icons/mimetypes/32/application-vnd.oasis.opendocument.text-template.svg
  change: edit 
icons/mimetypes/32/application-vnd.oasis.opendocument.presentation-template.svg
  change: edit icons/mimetypes/64/application-x-pem-key.svg
  change: edit icons/mimetypes/32/text-x-markdown.svg
  change: edit 
icons/mimetypes/32/application-vnd.oasis.opendocument.web-template.svg
  change: edit icons/mimetypes/32/application-x-macbinary.svg
  change: edit icons/mimetypes/32/application-illustrator.svg
  change: edit icons/mimetypes/32/application-pgp-encrypted.svg
  change: edit icons/mimetypes/32/application-msword-template.svg
  change: edit icons/mimetypes/32/application-atom+xml.svg
  change: edit icons/mimetypes/32/application-epub+zip.svg
  change: edit icons/mimetypes/32/application-msword.svg
  change: edit icons/mimetypes/32/application-x-javascript.svg
  change: edit 
icons/mimetypes/32/application-vnd.oasis.opendocument.formula-template.svg


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 
test(s)Failed: TestSuite.dupe

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 105/132 
(80%)CONDITIONAL 46/78 (59%)

By packages
  

FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 63/75 (84%)CONDITIONAL 
32/52 (62%)

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 298 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/298/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 27 Sep 2016 18:12:02 +
Build duration: 2 min 46 sec

CHANGE SET
Revision 16a37f23354deff7f3643872d1a6678ed55e5e37 by alessandro.longo: (Updated 
templates and other mimetypes with new colors at 32 and 64px)
  change: edit 
icons/mimetypes/32/application-vnd.oasis.opendocument.web-template.svg
  change: edit icons/mimetypes/32/application-atom+xml.svg
  change: edit icons/mimetypes/32/text-x-script.svg
  change: edit icons/mimetypes/32/application-epub+zip.svg
  change: edit icons/mimetypes/32/application-x-macbinary.svg
  change: edit icons/mimetypes/32/application-x-javascript.svg
  change: edit icons/mimetypes/32/application-pgp-encrypted.svg
  change: edit icons/mimetypes/32/application-msword.svg
  change: edit 
icons/mimetypes/32/application-vnd.oasis.opendocument.presentation-template.svg
  change: edit 
icons/mimetypes/32/application-vnd.oasis.opendocument.text-template.svg
  change: edit icons/mimetypes/64/application-x-pem-key.svg
  change: edit icons/mimetypes/32/text-x-markdown.svg
  change: edit 
icons/mimetypes/32/application-vnd.ms-powerpoint.template.macroenabled.12.svg
  change: edit 
icons/mimetypes/32/application-vnd.oasis.opendocument.spreadsheet-template.svg
  change: edit icons/mimetypes/32/application-illustrator.svg
  change: edit 
icons/mimetypes/32/application-vnd.oasis.opendocument.formula-template.svg
  change: edit 
icons/mimetypes/32/application-vnd.ms-excel.template.macroenabled.12.svg
  change: edit icons/mimetypes/32/x-office-spreadsheet.svg
  change: edit icons/mimetypes/32/application-msword-template.svg


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 
test(s)Failed: TestSuite.dupe

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 105/132 
(80%)CONDITIONAL 46/78 (59%)

By packages
  

FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 63/75 (84%)CONDITIONAL 
32/52 (62%)

Re: Review Request 128951: Load user's avatar from AccountsService if it exists

[Aleix Pol Gonzalez]

> On Sept. 20, 2016, 12:03 a.m., Aleix Pol Gonzalez wrote:
> > src/lib/CMakeLists.txt, line 13
> > 
> >
> > Use CMAKE_INSTALL_FULL_LOCALSATEDIR instead of 
> > CMAKE_INSTALL_LOCALSTATEDIR.
> 
> David Edmundson wrote:
> I did that at first, but it includes the INSTALL_PREFIX for some weird 
> reason, setting mine to /opt/kde5/var
> 
> Aleix Pol Gonzalez wrote:
> having a leading `/` makes me cringe... :D
> Can we report it to upstream cmake at least? It could be interesting to 
> see how they deal with this for `/etc` which often has the same problem.
> 
> David Edmundson wrote:
> After some investigation, cmake has a "feature" whereby if you install to 
> /usr  then FULL_LOCALETSATEDIR is /var for any other prefix it's /prefix/var
> 
> I guess the logic is that if you're installing to another prefix you 
> probably don't have permissions to install files there.
> 
> I'd rather go with this because I'm always only reading, so the rule 
> above doesn't apply and I may as well make it work for all devs.
> 
> However, it also implies FULL_STATEDIR will work fine for distros, so I'm 
> ok with changing.
> 
> Pick one and I'll do that.

We're essentially already hardcoding the path, would it make sense to just 
hardcode `/var/lib/AccountsService/icons` into the cpp file? It's not like 
CMake is adding much anyway.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128951/#review99287
---


On Sept. 19, 2016, 11:56 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128951/
> ---
> 
> (Updated Sept. 19, 2016, 11:56 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Plasma's UserManager (and Gnome) both now use AccountsService to store
> user information.
> 
> AccountsService saves the account information, and more particularly the
> avatar, in /var. This is very useful for login managers that need to
> load them without having to deal with mounting remote or encrypted home
> directories.
> 
> This patch makes KUser return the avatar saved by AccountsService first
> if it exist.
> 
> 
> Diffs
> -
> 
>   src/lib/CMakeLists.txt 437c07e292d4f3e733a6609ddc4b7f8dc3649aab 
>   src/lib/util/config-accountsservice.h.cmake PRE-CREATION 
>   src/lib/util/kuser_unix.cpp 3cb1ee6070f8acba2b090f827eb99c79bf73a77f 
> 
> Diff: https://git.reviewboard.kde.org/r/128951/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

[Differential] [Updated] D2854: New: ECMGenerateApiDox, for generating qch & tag files

[kossebau (Friedrich W. H. Kossebau)]

kossebau updated the summary for this revision.

REVISION DETAIL
  https://phabricator.kde.org/D2854

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau
Cc: staniek, winterz, ochurlaud, #kdevelop, #frameworks

Re: Review Request 129042: Replace all blocking calls when initializing properties by just one blocking call to get them all

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129042/#review99570
---




src/modemdevice.cpp 


modemCapabilities is not checked in propertyChanged


- David Edmundson


On Sept. 27, 2016, 12:07 p.m., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129042/
> ---
> 
> (Updated Sept. 27, 2016, 12:07 p.m.)
> 
> 
> Review request for KDE Frameworks, Network Management, Aleix Pol Gonzalez, 
> and Lamarque Souza.
> 
> 
> Repository: networkmanager-qt
> 
> 
> Description
> ---
> 
> Uses "GetAll" method from o.f.DBus.Properties interface to get all properties 
> at once, instead of initializing them one by one, which should significantly 
> reduce number of blocking calls. Initialy I wanted to make this call 
> asynchronous as well, but delayed initialization causes problems across the 
> library so this is the easiest way how to do this.
> 
> 
> Diffs
> -
> 
>   src/accesspoint.cpp 60a284b 
>   src/activeconnection.cpp 1b66fc5 
>   src/activeconnection_p.h 60697e6 
>   src/adsldevice.cpp 8f9bbff 
>   src/bluetoothdevice.cpp eb839e0 
>   src/bonddevice.cpp 6d1899f 
>   src/bridgedevice.cpp 3c347af 
>   src/device.cpp 57538eb 
>   src/genericdevice.cpp 8f26617 
>   src/gredevice.cpp c1a59c5 
>   src/infinibanddevice.cpp 9bfa76f 
>   src/macvlandevice.cpp 9b3c75f 
>   src/manager.cpp d2f706e 
>   src/manager_p.h 50c3c34 
>   src/modemdevice.cpp 4bb4a23 
>   src/olpcmeshdevice.cpp 6f1212d 
>   src/settings.cpp 90e7267 
>   src/teamdevice.cpp d07b145 
>   src/tundevice.cpp 2a73012 
>   src/vethdevice.cpp 77b48b4 
>   src/vlandevice.cpp fdfa297 
>   src/vpnconnection.cpp 5dee6fc 
>   src/vpnconnection_p.h a8195ad 
>   src/wimaxdevice.cpp 6118f2f 
>   src/wireddevice.cpp 66bb649 
>   src/wirelessdevice.cpp 3f2972b 
> 
> Diff: https://git.reviewboard.kde.org/r/129042/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Re: Review Request 129002: Use QCDebug in KIdleTime

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129002/#review99589
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Sept. 27, 2016, 2:14 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129002/
> ---
> 
> (Updated Sept. 27, 2016, 2:14 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kidletime
> 
> 
> Description
> ---
> 
> Also move some warnings to QCWarning() and reactivated some commented
> out debug messages now that they're not on by default
> 
> 
> Diffs
> -
> 
>   src/plugins/xsync/CMakeLists.txt 46175f717672739d6f24f0b6831b119b2b86e07d 
>   src/plugins/xsync/xsyncbasedpoller.cpp 
> 05c29eb8fb185eefd25907b7e77bd6b87e9cccb0 
> 
> Diff: https://git.reviewboard.kde.org/r/129002/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

Re: Review Request 129042: Replace all blocking calls when initializing properties by just one blocking call to get them all

[Aleix Pol Gonzalez]

> On Sept. 27, 2016, 2:41 p.m., Aleix Pol Gonzalez wrote:
> > +1 definitely a step forward.

FWIW, testing it, seems to work fine.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129042/#review99587
---


On Sept. 27, 2016, 2:07 p.m., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129042/
> ---
> 
> (Updated Sept. 27, 2016, 2:07 p.m.)
> 
> 
> Review request for KDE Frameworks, Network Management, Aleix Pol Gonzalez, 
> and Lamarque Souza.
> 
> 
> Repository: networkmanager-qt
> 
> 
> Description
> ---
> 
> Uses "GetAll" method from o.f.DBus.Properties interface to get all properties 
> at once, instead of initializing them one by one, which should significantly 
> reduce number of blocking calls. Initialy I wanted to make this call 
> asynchronous as well, but delayed initialization causes problems across the 
> library so this is the easiest way how to do this.
> 
> 
> Diffs
> -
> 
>   src/accesspoint.cpp 60a284b 
>   src/activeconnection.cpp 1b66fc5 
>   src/activeconnection_p.h 60697e6 
>   src/adsldevice.cpp 8f9bbff 
>   src/bluetoothdevice.cpp eb839e0 
>   src/bonddevice.cpp 6d1899f 
>   src/bridgedevice.cpp 3c347af 
>   src/device.cpp 57538eb 
>   src/genericdevice.cpp 8f26617 
>   src/gredevice.cpp c1a59c5 
>   src/infinibanddevice.cpp 9bfa76f 
>   src/macvlandevice.cpp 9b3c75f 
>   src/manager.cpp d2f706e 
>   src/manager_p.h 50c3c34 
>   src/modemdevice.cpp 4bb4a23 
>   src/olpcmeshdevice.cpp 6f1212d 
>   src/settings.cpp 90e7267 
>   src/teamdevice.cpp d07b145 
>   src/tundevice.cpp 2a73012 
>   src/vethdevice.cpp 77b48b4 
>   src/vlandevice.cpp fdfa297 
>   src/vpnconnection.cpp 5dee6fc 
>   src/vpnconnection_p.h a8195ad 
>   src/wimaxdevice.cpp 6118f2f 
>   src/wireddevice.cpp 66bb649 
>   src/wirelessdevice.cpp 3f2972b 
> 
> Diff: https://git.reviewboard.kde.org/r/129042/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Re: Review Request 129042: Replace all blocking calls when initializing properties by just one blocking call to get them all

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129042/#review99587
---



+1 definitely a step forward.

- Aleix Pol Gonzalez


On Sept. 27, 2016, 2:07 p.m., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129042/
> ---
> 
> (Updated Sept. 27, 2016, 2:07 p.m.)
> 
> 
> Review request for KDE Frameworks, Network Management, Aleix Pol Gonzalez, 
> and Lamarque Souza.
> 
> 
> Repository: networkmanager-qt
> 
> 
> Description
> ---
> 
> Uses "GetAll" method from o.f.DBus.Properties interface to get all properties 
> at once, instead of initializing them one by one, which should significantly 
> reduce number of blocking calls. Initialy I wanted to make this call 
> asynchronous as well, but delayed initialization causes problems across the 
> library so this is the easiest way how to do this.
> 
> 
> Diffs
> -
> 
>   src/accesspoint.cpp 60a284b 
>   src/activeconnection.cpp 1b66fc5 
>   src/activeconnection_p.h 60697e6 
>   src/adsldevice.cpp 8f9bbff 
>   src/bluetoothdevice.cpp eb839e0 
>   src/bonddevice.cpp 6d1899f 
>   src/bridgedevice.cpp 3c347af 
>   src/device.cpp 57538eb 
>   src/genericdevice.cpp 8f26617 
>   src/gredevice.cpp c1a59c5 
>   src/infinibanddevice.cpp 9bfa76f 
>   src/macvlandevice.cpp 9b3c75f 
>   src/manager.cpp d2f706e 
>   src/manager_p.h 50c3c34 
>   src/modemdevice.cpp 4bb4a23 
>   src/olpcmeshdevice.cpp 6f1212d 
>   src/settings.cpp 90e7267 
>   src/teamdevice.cpp d07b145 
>   src/tundevice.cpp 2a73012 
>   src/vethdevice.cpp 77b48b4 
>   src/vlandevice.cpp fdfa297 
>   src/vpnconnection.cpp 5dee6fc 
>   src/vpnconnection_p.h a8195ad 
>   src/wimaxdevice.cpp 6118f2f 
>   src/wireddevice.cpp 66bb649 
>   src/wirelessdevice.cpp 3f2972b 
> 
> Diff: https://git.reviewboard.kde.org/r/129042/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Re: Review Request 129042: Replace all blocking calls when initializing properties by just one blocking call to get them all

[Jan Grulich]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129042/
---

(Updated Zář. 27, 2016, 12:07 odp.)


Review request for KDE Frameworks, Network Management, Aleix Pol Gonzalez, and 
Lamarque Souza.


Changes
---

Avoid code duplication


Repository: networkmanager-qt


Description
---

Uses "GetAll" method from o.f.DBus.Properties interface to get all properties 
at once, instead of initializing them one by one, which should significantly 
reduce number of blocking calls. Initialy I wanted to make this call 
asynchronous as well, but delayed initialization causes problems across the 
library so this is the easiest way how to do this.


Diffs (updated)
-

  src/accesspoint.cpp 60a284b 
  src/activeconnection.cpp 1b66fc5 
  src/activeconnection_p.h 60697e6 
  src/adsldevice.cpp 8f9bbff 
  src/bluetoothdevice.cpp eb839e0 
  src/bonddevice.cpp 6d1899f 
  src/bridgedevice.cpp 3c347af 
  src/device.cpp 57538eb 
  src/genericdevice.cpp 8f26617 
  src/gredevice.cpp c1a59c5 
  src/infinibanddevice.cpp 9bfa76f 
  src/macvlandevice.cpp 9b3c75f 
  src/manager.cpp d2f706e 
  src/manager_p.h 50c3c34 
  src/modemdevice.cpp 4bb4a23 
  src/olpcmeshdevice.cpp 6f1212d 
  src/settings.cpp 90e7267 
  src/teamdevice.cpp d07b145 
  src/tundevice.cpp 2a73012 
  src/vethdevice.cpp 77b48b4 
  src/vlandevice.cpp fdfa297 
  src/vpnconnection.cpp 5dee6fc 
  src/vpnconnection_p.h a8195ad 
  src/wimaxdevice.cpp 6118f2f 
  src/wireddevice.cpp 66bb649 
  src/wirelessdevice.cpp 3f2972b 

Diff: https://git.reviewboard.kde.org/r/129042/diff/


Testing
---


Thanks,

Jan Grulich

Re: Review Request 129042: Replace all blocking calls when initializing properties by just one blocking call to get them all

[Aleix Pol Gonzalez]

> On Sept. 27, 2016, 12:55 p.m., Anthony Fieroni wrote:
> > src/accesspoint.cpp, line 84
> > 
> >
> > Can you try to add a function to remove this annoying code duplication?

+1


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129042/#review99575
---


On Sept. 27, 2016, 9:59 a.m., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129042/
> ---
> 
> (Updated Sept. 27, 2016, 9:59 a.m.)
> 
> 
> Review request for KDE Frameworks, Network Management, Aleix Pol Gonzalez, 
> and Lamarque Souza.
> 
> 
> Repository: networkmanager-qt
> 
> 
> Description
> ---
> 
> Uses "GetAll" method from o.f.DBus.Properties interface to get all properties 
> at once, instead of initializing them one by one, which should significantly 
> reduce number of blocking calls. Initialy I wanted to make this call 
> asynchronous as well, but delayed initialization causes problems across the 
> library so this is the easiest way how to do this.
> 
> 
> Diffs
> -
> 
>   src/accesspoint.cpp 60a284b 
>   src/activeconnection.cpp 1b66fc5 
>   src/activeconnection_p.h 60697e6 
>   src/adsldevice.cpp 8f9bbff 
>   src/bluetoothdevice.cpp eb839e0 
>   src/bonddevice.cpp 6d1899f 
>   src/bridgedevice.cpp 3c347af 
>   src/device.cpp 57538eb 
>   src/genericdevice.cpp 8f26617 
>   src/gredevice.cpp c1a59c5 
>   src/infinibanddevice.cpp 9bfa76f 
>   src/macvlandevice.cpp 9b3c75f 
>   src/manager.cpp d2f706e 
>   src/modemdevice.cpp 4bb4a23 
>   src/olpcmeshdevice.cpp 6f1212d 
>   src/settings.cpp 90e7267 
>   src/teamdevice.cpp d07b145 
>   src/tundevice.cpp 2a73012 
>   src/vethdevice.cpp 77b48b4 
>   src/vlandevice.cpp fdfa297 
>   src/vpnconnection.cpp 5dee6fc 
>   src/vpnconnection_p.h a8195ad 
>   src/wimaxdevice.cpp 6118f2f 
>   src/wireddevice.cpp 66bb649 
>   src/wirelessdevice.cpp 3f2972b 
> 
> Diff: https://git.reviewboard.kde.org/r/129042/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Re: Review Request 128951: Load user's avatar from AccountsService if it exists

[David Edmundson]

> On Sept. 19, 2016, 10:03 p.m., Aleix Pol Gonzalez wrote:
> > src/lib/CMakeLists.txt, line 13
> > 
> >
> > Use CMAKE_INSTALL_FULL_LOCALSATEDIR instead of 
> > CMAKE_INSTALL_LOCALSTATEDIR.
> 
> David Edmundson wrote:
> I did that at first, but it includes the INSTALL_PREFIX for some weird 
> reason, setting mine to /opt/kde5/var
> 
> Aleix Pol Gonzalez wrote:
> having a leading `/` makes me cringe... :D
> Can we report it to upstream cmake at least? It could be interesting to 
> see how they deal with this for `/etc` which often has the same problem.

After some investigation, cmake has a "feature" whereby if you install to /usr  
then FULL_LOCALETSATEDIR is /var for any other prefix it's /prefix/var

I guess the logic is that if you're installing to another prefix you probably 
don't have permissions to install files there.

I'd rather go with this because I'm always only reading, so the rule above 
doesn't apply and I may as well make it work for all devs.

However, it also implies FULL_STATEDIR will work fine for distros, so I'm ok 
with changing.

Pick one and I'll do that.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128951/#review99287
---


On Sept. 19, 2016, 9:56 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128951/
> ---
> 
> (Updated Sept. 19, 2016, 9:56 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Plasma's UserManager (and Gnome) both now use AccountsService to store
> user information.
> 
> AccountsService saves the account information, and more particularly the
> avatar, in /var. This is very useful for login managers that need to
> load them without having to deal with mounting remote or encrypted home
> directories.
> 
> This patch makes KUser return the avatar saved by AccountsService first
> if it exist.
> 
> 
> Diffs
> -
> 
>   src/lib/CMakeLists.txt 437c07e292d4f3e733a6609ddc4b7f8dc3649aab 
>   src/lib/util/config-accountsservice.h.cmake PRE-CREATION 
>   src/lib/util/kuser_unix.cpp 3cb1ee6070f8acba2b090f827eb99c79bf73a77f 
> 
> Diff: https://git.reviewboard.kde.org/r/128951/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

Re: Review Request 129032: Don't 'inline' public functions to avoid ABI breakage.

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129032/#review99577
---


Ship it!




Ship It!

- David Faure


On Sept. 26, 2016, 9:41 p.m., José Manuel  Santamaría Lema wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129032/
> ---
> 
> (Updated Sept. 26, 2016, 9:41 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Don't 'inline' public functions to avoid ABI breakage.
> 
> 
> Diffs
> -
> 
>   src/widgets/kpropertiesdialog.h a85037a 
>   src/widgets/kpropertiesdialog.cpp 5f64478 
> 
> Diff: https://git.reviewboard.kde.org/r/129032/diff/
> 
> 
> Testing
> ---
> 
> When packaging kio for kubuntu we realized there was a couple of missing 
> symbols which are a couple of deprecated functions, these functions were 
> "inlined" (without using the 'inline' keyword). 
> This is the offending commit:
> https://quickgit.kde.org/?p=kio.git&a=commitdiff&h=b36d368f8004d949597fbe9dc83d6b70418c22f8
> 
> From the binary compatibility page "Do's and Don'ts":
> https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B#The_Do.27s_and_Don.27ts
> You cannot...
> [...]
> For existing functions of any type:
> [...]
> inline it (this includes moving a member function's body to the class 
> definition, even without the inline keyword).
> 
> The proposed patch moves the functions implementation from the .h file to the 
> .cpp file so this way the binary compatibility is kept.
> 
> 
> Thanks,
> 
> José Manuel  Santamaría Lema
> 
>

Re: Review Request 129042: Replace all blocking calls when initializing properties by just one blocking call to get them all

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129042/#review99575
---




src/accesspoint.cpp (line 69)


Can you try to add a function to remove this annoying code duplication?


- Anthony Fieroni


On Sept. 27, 2016, 10:59 a.m., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129042/
> ---
> 
> (Updated Sept. 27, 2016, 10:59 a.m.)
> 
> 
> Review request for KDE Frameworks, Network Management, Aleix Pol Gonzalez, 
> and Lamarque Souza.
> 
> 
> Repository: networkmanager-qt
> 
> 
> Description
> ---
> 
> Uses "GetAll" method from o.f.DBus.Properties interface to get all properties 
> at once, instead of initializing them one by one, which should significantly 
> reduce number of blocking calls. Initialy I wanted to make this call 
> asynchronous as well, but delayed initialization causes problems across the 
> library so this is the easiest way how to do this.
> 
> 
> Diffs
> -
> 
>   src/accesspoint.cpp 60a284b 
>   src/activeconnection.cpp 1b66fc5 
>   src/activeconnection_p.h 60697e6 
>   src/adsldevice.cpp 8f9bbff 
>   src/bluetoothdevice.cpp eb839e0 
>   src/bonddevice.cpp 6d1899f 
>   src/bridgedevice.cpp 3c347af 
>   src/device.cpp 57538eb 
>   src/genericdevice.cpp 8f26617 
>   src/gredevice.cpp c1a59c5 
>   src/infinibanddevice.cpp 9bfa76f 
>   src/macvlandevice.cpp 9b3c75f 
>   src/manager.cpp d2f706e 
>   src/modemdevice.cpp 4bb4a23 
>   src/olpcmeshdevice.cpp 6f1212d 
>   src/settings.cpp 90e7267 
>   src/teamdevice.cpp d07b145 
>   src/tundevice.cpp 2a73012 
>   src/vethdevice.cpp 77b48b4 
>   src/vlandevice.cpp fdfa297 
>   src/vpnconnection.cpp 5dee6fc 
>   src/vpnconnection_p.h a8195ad 
>   src/wimaxdevice.cpp 6118f2f 
>   src/wireddevice.cpp 66bb649 
>   src/wirelessdevice.cpp 3f2972b 
> 
> Diff: https://git.reviewboard.kde.org/r/129042/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Re: Review Request 129042: Replace all blocking calls when initializing properties by just one blocking call to get them all

[Jan Grulich]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129042/
---

(Updated Zář. 27, 2016, 7:59 dop.)


Review request for KDE Frameworks, Network Management, Aleix Pol Gonzalez, and 
Lamarque Souza.


Repository: networkmanager-qt


Description
---

Uses "GetAll" method from o.f.DBus.Properties interface to get all properties 
at once, instead of initializing them one by one, which should significantly 
reduce number of blocking calls. Initialy I wanted to make this call 
asynchronous as well, but delayed initialization causes problems across the 
library so this is the easiest way how to do this.


Diffs
-

  src/accesspoint.cpp 60a284b 
  src/activeconnection.cpp 1b66fc5 
  src/activeconnection_p.h 60697e6 
  src/adsldevice.cpp 8f9bbff 
  src/bluetoothdevice.cpp eb839e0 
  src/bonddevice.cpp 6d1899f 
  src/bridgedevice.cpp 3c347af 
  src/device.cpp 57538eb 
  src/genericdevice.cpp 8f26617 
  src/gredevice.cpp c1a59c5 
  src/infinibanddevice.cpp 9bfa76f 
  src/macvlandevice.cpp 9b3c75f 
  src/manager.cpp d2f706e 
  src/modemdevice.cpp 4bb4a23 
  src/olpcmeshdevice.cpp 6f1212d 
  src/settings.cpp 90e7267 
  src/teamdevice.cpp d07b145 
  src/tundevice.cpp 2a73012 
  src/vethdevice.cpp 77b48b4 
  src/vlandevice.cpp fdfa297 
  src/vpnconnection.cpp 5dee6fc 
  src/vpnconnection_p.h a8195ad 
  src/wimaxdevice.cpp 6118f2f 
  src/wireddevice.cpp 66bb649 
  src/wirelessdevice.cpp 3f2972b 

Diff: https://git.reviewboard.kde.org/r/129042/diff/


Testing
---


Thanks,

Jan Grulich

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 300 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/300/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 27 Sep 2016 07:50:21 +
Build duration: 3 min 0 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 
test(s)Failed: TestSuite.dupe

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 82/132 
(62%)CONDITIONAL 35/78 (45%)

By packages
  

FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 40/75 (53%)CONDITIONAL 
21/52 (40%)