date:20161104

Review Request 129335: Fix cmake warking

2016-11-04 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129335/
---

Review request for Documentation, KDE Frameworks and Luigi Toscano.


Repository: kdoctools


Description
---

Now I don't get the error anymore.

```
CMake Warning (dev) at 
/home/apol/devel/kde5/lib64/cmake/KF5DocTools/KF5DocToolsMacros.cmake:121 (if):
  Policy CMP0054 is not set: Only interpret if() arguments as variables or
  keywords when unquoted.  Run "cmake --help-policy CMP0054" for policy
  details.  Use the cmake_policy command to set the policy and suppress this
  warning.

  Quoted variables like "" will no longer be dereferenced when the policy is
  set to NEW.  Since the policy is not set the OLD behavior will be used.
Call Stack (most recent call first):
  doc/afaras/CMakeLists.txt:1 (kdoctools_create_handbook)
This warning is for project developers.  Use -Wno-dev to suppress it.
```


Diffs
-

  KF5DocToolsMacros.cmake d73201d 

Diff: https://git.reviewboard.kde.org/r/129335/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

Re: Please add consistency in naming of (noK)Syntax(-)Highlighting library

2016-11-04 Thread Volker Krause

Hi,

On Thursday 03 November 2016 11:38:21 Friedrich W. H. Kossebau wrote:
> one of the things we praise about Qt is the predictability of class names
> and methods names. Because the patterns used with them decrease the amount
> of knowledge one needs to have, as things can be derived. No need to look
> up in a dictionary, just take the base name and apply a common pattern.
> 
> When hearing about the new KDE Frameworks library for syntax highlighting, I
> expected I could derive the name of the lib as with the other KDE
> Frameworks libraries with a generic name:
> - repo ksyntaxhighlighting
> - namespace KSyntaxHighlighting

is this part of the KF5 style-guide? If so, I wasn't aware of that, sorry.

> But now I learned that I have to remember some extra rules in my mind:
> - syntax highlighting: no k-prefix
> - syntax highlighting: there is a hyphen in the repo name

Well, there's at least a dozen or so other frameworks (in particular, newer 
ones) with similar patterns. So it doesn't look like we are the odd exception 
here.

> Creating software means dealing with complex systems. Every extra
> irregularities makes things only more complex, so best are avoided if
> possible.
> If there are no pressing needs for the no-k-prefix and custom repo naming,
> please consider changing that still before the upcoming release in a few
> days. I know the extra work sucks, but it sucks even more for all the
> people running into the irregularly named library here in all the months
> and years to come.

I don't mind doing the extra work, but I need input on whether this is 
actually desired or considered "legacy style". David?

Regards,
Volker

signature.asc
Description: This is a digitally signed message part.

Re: Review Request 129314: Fix 'checkXML5 generates html files in workdir for valid docbooks'

2016-11-04 Thread Ralf Habacker


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129314/
---

(Updated Nov. 4, 2016, 1:25 p.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation, KDE Frameworks and Luigi Toscano.


Changes
---

Submitted with commit 29c0ecf99c50bb4bed62a4d90f45e5c9e3899d1c by Ralf Habacker 
to branch master.


Bugs: 371987
https://bugs.kde.org/show_bug.cgi?id=371987


Repository: kdoctools


Description
---

Fix 'checkXML5 generates html files in workdir for valid docbooks'.

BUG:371987


Diffs
-

  src/checkXML5.cpp 437296a0b582c5b3e11c72712c62188dbcef5aa7 

Diff: https://git.reviewboard.kde.org/r/129314/diff/


Testing
---

tested on opensuse 13.2


Thanks,

Ralf Habacker

Re: Review Request 129314: Fix 'checkXML5 generates html files in workdir for valid docbooks'

2016-11-04 Thread Luigi Toscano


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129314/#review100567
---


Ship it!




I can't compile it, but the code looks fine, apol's comments have been 
addressed, I trust Burkhard's testing (maybe we should add an automated test 
for this) and we have a tag tomorrow. So let's go for it.

- Luigi Toscano


On Nov. 4, 2016, 9:18 a.m., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129314/
> ---
> 
> (Updated Nov. 4, 2016, 9:18 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Bugs: 371987
> https://bugs.kde.org/show_bug.cgi?id=371987
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Fix 'checkXML5 generates html files in workdir for valid docbooks'.
> 
> BUG:371987
> 
> 
> Diffs
> -
> 
>   src/checkXML5.cpp 437296a0b582c5b3e11c72712c62188dbcef5aa7 
> 
> Diff: https://git.reviewboard.kde.org/r/129314/diff/
> 
> 
> Testing
> ---
> 
> tested on opensuse 13.2
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Review Request 129298: RFC: supporting dependencies on KPackage

2016-11-04 Thread Marco Martin



> On Oct. 31, 2016, 5:19 p.m., Marco Martin wrote:
> > autotests/data/testpackagesdep/metadata.json, line 14
> > 
> >
> > if kns ends up using ids, maybe the server should be specified as well, 
> > as the id would be server-dependent?
> 
> Aleix Pol Gonzalez wrote:
> I'm not sure, either way we need changes in the KNS API, as the current 
> search in place won't work. I'd prefer if we could use rdn-like notation on 
> kns.
> 
> I don't think it should be server-dependent. If anything, if the user 
> changes the contents server, it might not find the component.
> 
> Dan Leinir Turthra Jensen wrote:
> Hmm... a knsrc points to a providers file, which in turn can hold more 
> than one provider. The providers in the provider file have an ID, so perhaps 
> we can use that? So we'd end up with e.g. 
> kns://colors.knsrc/api.kde-look.org/1159726 instead. While the api bit 
> looks like a server address, it's just the ID as found in the providers file 
> (and might be any string, technically), and so that would be enough (just) to 
> uniquely identify the item as found on a provider which (like with the kde 
> store) might have multiple "servers".
> 
> Marco Martin wrote:
> could a content be identified like org.joe.beautifulicontheme ?
> then the server having some function to resolve 
> org.joe.beautifulicontheme to its id like 137345
> 
> Dan Leinir Turthra Jensen wrote:
> ...what server? That is just another string ID (technically the number 
> that you get in OCS is just a string, and at least one implementation 
> (MidGard) uses that fact). i really don't see how we can get away with having 
> anything less than two string IDs (server ID as defined in a providers.xml, 
> and content ID as unique to that provider) to uniquely identify a content 
> item... i also don't really see why it'd necessarily be better, in any real 
> way other than aesthetics of the link, to have anything more concise than 
> kns://knsrcfile/providerID/contentID (and possibly kns://providerID/contentID 
> in cases of using the default provider as defined by kns internally, which 
> resolves to using KDE's providers.xml).
> 
> Aleix Pol Gonzalez wrote:
> I'll come up with a patch to search-by-id, I guess everything will look 
> much more clear afterwards.
> Nevertheless, I think it's clear that passing a providerID bypasses the 
> provider abstraction.
> 
> If we want to make sure a specific package is installed, maybe it would 
> make sense to add a 3rd plugin which is `http://` or even `ocs://` that 
> assume the resource is a KPackage.

so, if the dependency is a library and whatnot (qtcurve style comes to mind) 
the dependency would be an appstream id, otherwise ocs://providerId/contentId


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129298/#review100442
---


On Oct. 31, 2016, 5:09 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129298/
> ---
> 
> (Updated Oct. 31, 2016, 5:09 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma, Dan Leinir Turthra Jensen, and 
> Marco Martin.
> 
> 
> Repository: kpackage
> 
> 
> Description
> ---
> 
> Makes it possible to specify components to be installed together with a 
> KPackage. They will be specified by a url, we'll have handlers for any kind, 
> making reasonably extensible and doesn't tie us to a technology.
> 
> In this repository I created two Proof of Concept of such handlers, one for 
> the appstream urls and one for KNS: kde:scratch/apol/kpackage-install-helpers
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 395b16e 
>   autotests/data/testpackagesdep/contents/ui/main.qml PRE-CREATION 
>   autotests/data/testpackagesdep/metadata.json PRE-CREATION 
>   autotests/data/testpackagesdep/testpackagesdep.testappdataxml PRE-CREATION 
>   src/kpackage/config-package.h.cmake 61f2f0c 
>   src/kpackage/private/packagejobthread.cpp 0a0cc01 
>   src/kpackage/private/packagejobthread_p.h 1babf0b 
> 
> Diff: https://git.reviewboard.kde.org/r/129298/diff/
> 
> 
> Testing
> ---
> 
> None. just builds. It's a proof of concept, not even the test I added was 
> tested, it was just to display what it could look like.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

Re: Review Request 129314: Fix 'checkXML5 generates html files in workdir for valid docbooks'

2016-11-04 Thread Ralf Habacker



> On Nov. 4, 2016, 9:58 vorm., Burkhard Lück wrote:
> > Using checkXML5+meinproc5 with patch on a valid docbook:
> > 
> >   $ ls *html
> >   ls: cannot access '*html': No such file or directory
> >   $ checkXML5 kdegraphics/okular/doc/index.docbook 
> >   $ ls *html
> >   ls: cannot access '*html': No such file or directory
> >   $ meinproc5 --check kdegraphics/okular/doc/index.docbook 
> >   $ ls *html
> >   advanced.html command-line-options.html  configeditor.html   
> > configperformance.html   configure.html   forms.html 
> > inverse_search.html  menugo.html menuview.html  
> > primary-menu-items.html
> >   annotations.html  configaccessibility.html   configgeneral.html  
> > configpresentation.html  credits.html index.html 
> > menubookmarks.html   menuhelp.html   navigating.html
> > settings-menu.html
> >   bookmark-management.html  configannotations.html config-pdf.html 
> > configure-backends.html  fit-window-to-page.html  introduction.html  
> > menuedit.htmlmenutools.html  presentationMode.html  use.html
> > 
> >   -> meinproc5 --check should not generate html files used with "--check"
> > 
> > Using checkXML5+meinproc5 with patch on an invalid docbook:
> > 
> >   $ rm *html
> >   $ checkXML5 kdegraphics/okular/doc/index.docbook 
> > 
> >   -> no output of errors!
> > 
> >   $ ls *html
> >   ls: cannot access '*html': No such file or directory
> >   $ meinproc5 --check kdegraphics/okular/doc/index.docbook 
> >   index.docbook:912: parser error : expected '>'
> >   
> >   ^
> >   meinproc(16611)/default main: Error: `xmllint --noout` outputted text
> > 
> > checkXML5+meinproc5 with patch are still broken
> 
> Ralf Habacker wrote:
> You probably uses revision 1 of this patch. This is fixed with patch 
> revision 2, where checkXML5 redirects meinproc5 stderr output to stderr.
> 
> Burkhard Lück wrote:
> You are right, sorry for the noise.
> checkXML5+meinproc5 work now as before

So I have a go ?


- Ralf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129314/#review100556
---


On Nov. 4, 2016, 9:18 vorm., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129314/
> ---
> 
> (Updated Nov. 4, 2016, 9:18 vorm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Bugs: 371987
> https://bugs.kde.org/show_bug.cgi?id=371987
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Fix 'checkXML5 generates html files in workdir for valid docbooks'.
> 
> BUG:371987
> 
> 
> Diffs
> -
> 
>   src/checkXML5.cpp 437296a0b582c5b3e11c72712c62188dbcef5aa7 
> 
> Diff: https://git.reviewboard.kde.org/r/129314/diff/
> 
> 
> Testing
> ---
> 
> tested on opensuse 13.2
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Review Request 129314: Fix 'checkXML5 generates html files in workdir for valid docbooks'

2016-11-04 Thread Burkhard Lück



> On Nov. 4, 2016, 8:58 vorm., Burkhard Lück wrote:
> > Using checkXML5+meinproc5 with patch on a valid docbook:
> > 
> >   $ ls *html
> >   ls: cannot access '*html': No such file or directory
> >   $ checkXML5 kdegraphics/okular/doc/index.docbook 
> >   $ ls *html
> >   ls: cannot access '*html': No such file or directory
> >   $ meinproc5 --check kdegraphics/okular/doc/index.docbook 
> >   $ ls *html
> >   advanced.html command-line-options.html  configeditor.html   
> > configperformance.html   configure.html   forms.html 
> > inverse_search.html  menugo.html menuview.html  
> > primary-menu-items.html
> >   annotations.html  configaccessibility.html   configgeneral.html  
> > configpresentation.html  credits.html index.html 
> > menubookmarks.html   menuhelp.html   navigating.html
> > settings-menu.html
> >   bookmark-management.html  configannotations.html config-pdf.html 
> > configure-backends.html  fit-window-to-page.html  introduction.html  
> > menuedit.htmlmenutools.html  presentationMode.html  use.html
> > 
> >   -> meinproc5 --check should not generate html files used with "--check"
> > 
> > Using checkXML5+meinproc5 with patch on an invalid docbook:
> > 
> >   $ rm *html
> >   $ checkXML5 kdegraphics/okular/doc/index.docbook 
> > 
> >   -> no output of errors!
> > 
> >   $ ls *html
> >   ls: cannot access '*html': No such file or directory
> >   $ meinproc5 --check kdegraphics/okular/doc/index.docbook 
> >   index.docbook:912: parser error : expected '>'
> >   
> >   ^
> >   meinproc(16611)/default main: Error: `xmllint --noout` outputted text
> > 
> > checkXML5+meinproc5 with patch are still broken
> 
> Ralf Habacker wrote:
> You probably uses revision 1 of this patch. This is fixed with patch 
> revision 2, where checkXML5 redirects meinproc5 stderr output to stderr.

You are right, sorry for the noise.
checkXML5+meinproc5 work now as before


- Burkhard


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129314/#review100556
---


On Nov. 4, 2016, 8:18 vorm., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129314/
> ---
> 
> (Updated Nov. 4, 2016, 8:18 vorm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Bugs: 371987
> https://bugs.kde.org/show_bug.cgi?id=371987
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Fix 'checkXML5 generates html files in workdir for valid docbooks'.
> 
> BUG:371987
> 
> 
> Diffs
> -
> 
>   src/checkXML5.cpp 437296a0b582c5b3e11c72712c62188dbcef5aa7 
> 
> Diff: https://git.reviewboard.kde.org/r/129314/diff/
> 
> 
> Testing
> ---
> 
> tested on opensuse 13.2
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Review Request 129327: Expose desktopFileName in KWindowInfo

2016-11-04 Thread Eike Hein


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129327/#review100558
---


Ship it!




Ship It!

- Eike Hein


On Nov. 4, 2016, 9:53 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129327/
> ---
> 
> (Updated Nov. 4, 2016, 9:53 a.m.)
> 
> 
> Review request for KDE Frameworks and Eike Hein.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> This change introduced a new method in KWindowInfo:
> QByteArray KWindowInfo::desktopFileName() const
> 
> It returns the desktop file name of the application if known on the
> given platform. So far only provided on X11 through
> NETWinInfo::desktopFileName.
> 
> 
> Diffs
> -
> 
>   autotests/kwindowinfox11test.cpp 5dfbcfa67d74244122c86433a40a7ed6923fb1ab 
>   src/kwindowinfo.h 5d9799b20d640caa1b1cf9ab4d9dc69b8cceefe3 
>   src/kwindowinfo.cpp 658a0b645797676d4e48585ede3d832333688081 
>   src/kwindowinfo_p.h 45390c06e7b5ad064ea9368ca102b2462a029c06 
>   src/platforms/xcb/kwindowinfo.cpp eca607e18a979439593e05e1da232548d0e7d139 
>   src/platforms/xcb/kwindowinfo_p_x11.h 
> 68805765fd630c2bc7cf0d77be688333b4a363f7 
> 
> Diff: https://git.reviewboard.kde.org/r/129327/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 237 - Unstable!

2016-11-04 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/237/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Fri, 04 Nov 2016 09:43:34 +
Build duration: 15 min

CHANGE SET
Revision b4f2611125f0f4c73f2ce359cd8eafefc3fba0f9 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit templates/plasma-wallpaper/plasma-wallpaper.kdevtemplate
  change: edit templates/cpp-plasmoid/cpp-plasmoid.kdevtemplate


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 
16 test(s)Failed: TestSuite.plasma-dialogstatetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 81/119 (68%)CLASSES 81/119 (68%)LINE 4897/11748 
(42%)CONDITIONAL 2639/8866 (30%)

By packages
  
autotests
FILES 28/28 (100%)CLASSES 28/28 (100%)LINE 979/1050 
(93%)CONDITIONAL 619/1238 (50%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 648/2129 
(30%)CONDITIONAL 300/1308 (23%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1660/3608 
(46%)CONDITIONAL 961/2705 (36%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 51/65 (78%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 14/24 (58%)CLASSES 14/24 (58%)LINE 928/1640 
(57%)CONDITIONAL 430/1068 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 553/1827 
(30%)CONDITIONAL 301/1419 (21%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1136 (1%)CONDITIONAL 
1/978 (0%)

Review Request 129327: Expose desktopFileName in KWindowInfo

2016-11-04 Thread Martin Gräßlin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129327/
---

Review request for KDE Frameworks and Eike Hein.


Repository: kwindowsystem


Description
---

This change introduced a new method in KWindowInfo:
QByteArray KWindowInfo::desktopFileName() const

It returns the desktop file name of the application if known on the
given platform. So far only provided on X11 through
NETWinInfo::desktopFileName.


Diffs
-

  autotests/kwindowinfox11test.cpp 5dfbcfa67d74244122c86433a40a7ed6923fb1ab 
  src/kwindowinfo.h 5d9799b20d640caa1b1cf9ab4d9dc69b8cceefe3 
  src/kwindowinfo.cpp 658a0b645797676d4e48585ede3d832333688081 
  src/kwindowinfo_p.h 45390c06e7b5ad064ea9368ca102b2462a029c06 
  src/platforms/xcb/kwindowinfo.cpp eca607e18a979439593e05e1da232548d0e7d139 
  src/platforms/xcb/kwindowinfo_p_x11.h 
68805765fd630c2bc7cf0d77be688333b4a363f7 

Diff: https://git.reviewboard.kde.org/r/129327/diff/


Testing
---


Thanks,

Martin Gräßlin

Re: Review Request 129314: Fix 'checkXML5 generates html files in workdir for valid docbooks'

2016-11-04 Thread Ralf Habacker



> On Nov. 4, 2016, 9:58 vorm., Burkhard Lück wrote:
> > Using checkXML5+meinproc5 with patch on a valid docbook:
> > 
> >   $ ls *html
> >   ls: cannot access '*html': No such file or directory
> >   $ checkXML5 kdegraphics/okular/doc/index.docbook 
> >   $ ls *html
> >   ls: cannot access '*html': No such file or directory
> >   $ meinproc5 --check kdegraphics/okular/doc/index.docbook 
> >   $ ls *html
> >   advanced.html command-line-options.html  configeditor.html   
> > configperformance.html   configure.html   forms.html 
> > inverse_search.html  menugo.html menuview.html  
> > primary-menu-items.html
> >   annotations.html  configaccessibility.html   configgeneral.html  
> > configpresentation.html  credits.html index.html 
> > menubookmarks.html   menuhelp.html   navigating.html
> > settings-menu.html
> >   bookmark-management.html  configannotations.html config-pdf.html 
> > configure-backends.html  fit-window-to-page.html  introduction.html  
> > menuedit.htmlmenutools.html  presentationMode.html  use.html
> > 
> >   -> meinproc5 --check should not generate html files used with "--check"
> > 
> > Using checkXML5+meinproc5 with patch on an invalid docbook:
> > 
> >   $ rm *html
> >   $ checkXML5 kdegraphics/okular/doc/index.docbook 
> > 
> >   -> no output of errors!
> > 
> >   $ ls *html
> >   ls: cannot access '*html': No such file or directory
> >   $ meinproc5 --check kdegraphics/okular/doc/index.docbook 
> >   index.docbook:912: parser error : expected '>'
> >   
> >   ^
> >   meinproc(16611)/default main: Error: `xmllint --noout` outputted text
> > 
> > checkXML5+meinproc5 with patch are still broken

You probably uses revision 1 of this patch. This is fixed with patch revision 
2, where checkXML5 redirects meinproc5 stderr output to stderr.


- Ralf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129314/#review100556
---


On Nov. 4, 2016, 9:18 vorm., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129314/
> ---
> 
> (Updated Nov. 4, 2016, 9:18 vorm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Bugs: 371987
> https://bugs.kde.org/show_bug.cgi?id=371987
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Fix 'checkXML5 generates html files in workdir for valid docbooks'.
> 
> BUG:371987
> 
> 
> Diffs
> -
> 
>   src/checkXML5.cpp 437296a0b582c5b3e11c72712c62188dbcef5aa7 
> 
> Diff: https://git.reviewboard.kde.org/r/129314/diff/
> 
> 
> Testing
> ---
> 
> tested on opensuse 13.2
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Review Request 129314: Fix 'checkXML5 generates html files in workdir for valid docbooks'

2016-11-04 Thread Burkhard Lück


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129314/#review100556
---



Using checkXML5+meinproc5 with patch on a valid docbook:

  $ ls *html
  ls: cannot access '*html': No such file or directory
  $ checkXML5 kdegraphics/okular/doc/index.docbook 
  $ ls *html
  ls: cannot access '*html': No such file or directory
  $ meinproc5 --check kdegraphics/okular/doc/index.docbook 
  $ ls *html
  advanced.html command-line-options.html  configeditor.html   
configperformance.html   configure.html   forms.html 
inverse_search.html  menugo.html menuview.html  
primary-menu-items.html
  annotations.html  configaccessibility.html   configgeneral.html  
configpresentation.html  credits.html index.html 
menubookmarks.html   menuhelp.html   navigating.htmlsettings-menu.html
  bookmark-management.html  configannotations.html config-pdf.html 
configure-backends.html  fit-window-to-page.html  introduction.html  
menuedit.htmlmenutools.html  presentationMode.html  use.html

  -> meinproc5 --check should not generate html files used with "--check"

Using checkXML5+meinproc5 with patch on an invalid docbook:

  $ rm *html
  $ checkXML5 kdegraphics/okular/doc/index.docbook 

  -> no output of errors!

  $ ls *html
  ls: cannot access '*html': No such file or directory
  $ meinproc5 --check kdegraphics/okular/doc/index.docbook 
  index.docbook:912: parser error : expected '>'
  
  ^
  meinproc(16611)/default main: Error: `xmllint --noout` outputted text

checkXML5+meinproc5 with patch are still broken

- Burkhard Lück


On Nov. 4, 2016, 8:18 vorm., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129314/
> ---
> 
> (Updated Nov. 4, 2016, 8:18 vorm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Bugs: 371987
> https://bugs.kde.org/show_bug.cgi?id=371987
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Fix 'checkXML5 generates html files in workdir for valid docbooks'.
> 
> BUG:371987
> 
> 
> Diffs
> -
> 
>   src/checkXML5.cpp 437296a0b582c5b3e11c72712c62188dbcef5aa7 
> 
> Diff: https://git.reviewboard.kde.org/r/129314/diff/
> 
> 
> Testing
> ---
> 
> tested on opensuse 13.2
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 257 - Still Unstable!

2016-11-04 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/257/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Nov 2016 08:23:37 +
Build duration: 16 min

CHANGE SET
Revision 6350512c0ff4c8ca15f289e769ab62e862a5ab20 by David Faure: (Add test for 
KFileWidget::getStartUrl, passes.)
  change: edit autotests/kfilewidgettest.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 
52 test(s)Failed: TestSuite.kiocore-threadtestFailed: 
TestSuite.kiofilewidgets-kfileplacesmodeltest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 270/339 (80%)CLASSES 270/339 (80%)LINE 28923/51383 
(56%)CONDITIONAL 15619/38125 (41%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7519/8105 
(93%)CONDITIONAL 4016/8514 (47%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/116 (83%)CLASSES 96/116 (83%)LINE 7775/14137 
(55%)CONDITIONAL 4245/9067 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3357/7561 
(44%)CONDITIONAL 1234/4383 (28%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 443/841 (53%)CONDITIONAL 
329/725 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1755/3783 
(46%)CONDITIONAL 1250/3434 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 723/1155 (63%)CONDITIONAL 
384/753 (51%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3614/10966 
(33%)CONDITIONAL 1734/6962 (25%)

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 255 - Still Unstable!

2016-11-04 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/255/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Nov 2016 08:23:37 +
Build duration: 4 min 58 sec

CHANGE SET
Revision 6350512c0ff4c8ca15f289e769ab62e862a5ab20 by David Faure: (Add test for 
KFileWidget::getStartUrl, passes.)
  change: edit autotests/kfilewidgettest.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 
52 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 271/340 (80%)CLASSES 271/340 (80%)LINE 28942/51418 
(56%)CONDITIONAL 15634/38147 (41%)

By packages
  
autotests
FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7554/8140 
(93%)CONDITIONAL 4030/8536 (47%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/116 (83%)CLASSES 96/116 (83%)LINE 7766/14137 
(55%)CONDITIONAL 4248/9067 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3360/7561 
(44%)CONDITIONAL 1237/4383 (28%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 443/841 (53%)CONDITIONAL 
329/725 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1763/3783 
(47%)CONDITIONAL 1259/3434 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3606/10966 
(33%)CONDITIONAL 1731/6962 (25%)

Re: Review Request 129314: Fix 'checkXML5 generates html files in workdir for valid docbooks'

2016-11-04 Thread Ralf Habacker


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129314/
---

(Updated Nov. 4, 2016, 9:18 vorm.)


Review request for Documentation, KDE Frameworks and Luigi Toscano.


Summary (updated)
-

Fix 'checkXML5 generates html files in workdir for valid docbooks'


Bugs: 371987
https://bugs.kde.org/show_bug.cgi?id=371987


Repository: kdoctools


Description
---

Fix 'checkXML5 generates html files in workdir for valid docbooks'.

BUG:371987


Diffs
-

  src/checkXML5.cpp 437296a0b582c5b3e11c72712c62188dbcef5aa7 

Diff: https://git.reviewboard.kde.org/r/129314/diff/


Testing
---

tested on opensuse 13.2


Thanks,

Ralf Habacker

Re: Review Request 129314: Fix 'checkXML5 generates html files in workdir for valid docbooks'.Setup targets for cross compiling.

2016-11-04 Thread Ralf Habacker


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129314/
---

(Updated Nov. 4, 2016, 9:16 vorm.)


Review request for Documentation, KDE Frameworks and Luigi Toscano.


Summary (updated)
-

Fix 'checkXML5 generates html files in workdir for valid docbooks'.Setup 
targets for cross compiling.


Bugs: 371987
https://bugs.kde.org/show_bug.cgi?id=371987


Repository: kdoctools


Description
---

Fix 'checkXML5 generates html files in workdir for valid docbooks'.

BUG:371987


Diffs (updated)
-

  src/checkXML5.cpp 437296a0b582c5b3e11c72712c62188dbcef5aa7 

Diff: https://git.reviewboard.kde.org/r/129314/diff/


Testing
---

tested on opensuse 13.2


Thanks,

Ralf Habacker

Re: Review Request 129314: Setup targets for cross compiling.

2016-11-04 Thread Burkhard Lück



> On Nov. 2, 2016, 8:22 nachm., Burkhard Lück wrote:
> > works for me, but let's wait for Luigi's OK

-100
I just noticed checkXML5 does not output any error on invalid xml, makes 
checkXML5 useless


- Burkhard


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129314/#review100517
---


On Nov. 2, 2016, 7:55 nachm., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129314/
> ---
> 
> (Updated Nov. 2, 2016, 7:55 nachm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Bugs: 371987
> https://bugs.kde.org/show_bug.cgi?id=371987
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Fix 'checkXML5 generates html files in workdir for valid docbooks'.
> 
> BUG:371987
> 
> 
> Diffs
> -
> 
>   KF5DocToolsMacros.cmake d73201dbecaf370898f66f807e6d8856d6f88a8d 
>   src/checkXML5.cpp 437296a0b582c5b3e11c72712c62188dbcef5aa7 
> 
> Diff: https://git.reviewboard.kde.org/r/129314/diff/
> 
> 
> Testing
> ---
> 
> tested on opensuse 13.2
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Review Request 129335: Fix cmake warking

Re: Please add consistency in naming of (noK)Syntax(-)Highlighting library

Re: Review Request 129314: Fix 'checkXML5 generates html files in workdir for valid docbooks'

Re: Review Request 129314: Fix 'checkXML5 generates html files in workdir for valid docbooks'

Re: Review Request 129298: RFC: supporting dependencies on KPackage

Re: Review Request 129314: Fix 'checkXML5 generates html files in workdir for valid docbooks'

Re: Review Request 129314: Fix 'checkXML5 generates html files in workdir for valid docbooks'

Re: Review Request 129327: Expose desktopFileName in KWindowInfo

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 237 - Unstable!

Review Request 129327: Expose desktopFileName in KWindowInfo

Re: Review Request 129314: Fix 'checkXML5 generates html files in workdir for valid docbooks'

Re: Review Request 129314: Fix 'checkXML5 generates html files in workdir for valid docbooks'

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 257 - Still Unstable!

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 255 - Still Unstable!

Re: Review Request 129314: Fix 'checkXML5 generates html files in workdir for valid docbooks'

Re: Review Request 129314: Fix 'checkXML5 generates html files in workdir for valid docbooks'.Setup targets for cross compiling.

Re: Review Request 129314: Setup targets for cross compiling.

17 matches

Site Navigation

Mail list logo

Footer information