date:20161204

Re: Review Request 129540: DropJob: emit started copy job after creation

2016-12-04 Thread Alex Bikadorov


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129540/
---

(Updated Dec. 4, 2016, 7:22 p.m.)


Review request for KDE Frameworks.


Repository: kio


Description (updated)
---

For giving an application a chance to monitor and control the subjob.


Diffs
-

  src/widgets/dropjob.h 5c9bf10ecc34282d9acb50cef93e7bc8665cb904 
  src/widgets/dropjob.cpp 1febd3397ec8e993a9786547da9c381a0f57a1f8 

Diff: https://git.reviewboard.kde.org/r/129540/diff/


Testing
---


Thanks,

Alex Bikadorov

Re: Review Request 129540: DropJob: emit started copy job after creation

2016-12-04 Thread Alex Bikadorov



> On Dec. 4, 2016, 5:50 p.m., David Faure wrote:
> > I would prefer the subjob to remain an implementation detail. Just like so 
> > many other KIO jobs which use other jobs internally.
> > 
> > Instead this code should connect the signals from the subjob to the DropJob 
> > signals. Much like FileCopyJobPrivate::connectSubjob() does.

Maybe the description was misleading. I do not only want to monitor the subjob 
but also have full control over it. I.e. I need the signals/methods

* description()
* percent()
* suspend()
* suspended()
* resume()
* resumed()
* result()
* finisned()
* warning()

Do you really want me to connect/wrap all this?

Also, I don't understand why plasma/kuiserver can have access to the subjob 
(via KIO::getJobTracker) but my application (Krusader) can't have it.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129540/#review101272
---


On Nov. 22, 2016, 9:53 p.m., Alex Bikadorov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129540/
> ---
> 
> (Updated Nov. 22, 2016, 9:53 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> For giving an application a chance to monitor the job.
> 
> 
> Diffs
> -
> 
>   src/widgets/dropjob.h 5c9bf10ecc34282d9acb50cef93e7bc8665cb904 
>   src/widgets/dropjob.cpp 1febd3397ec8e993a9786547da9c381a0f57a1f8 
> 
> Diff: https://git.reviewboard.kde.org/r/129540/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Bikadorov
> 
>

[Differential] [Commented On] D3530: Import plasma-workspace kioslaves

2016-12-04 Thread dfaure (David Faure)

dfaure added a comment.


  In https://phabricator.kde.org/D3530#65873, @mart wrote:
  
  > desktop:/ should be probably conditionally built only on Linux(but in there 
is quite core), while, may make sense to actually kill applications:/ 
altogether??
  
  
  I have no doubt it seems "core on linux" from a plasma point of view, but 
e.g. someone using KIO on embedded linux, or with a very basic desktop, would 
have no use for kio_desktop.
  
  This makes me wonder, actually... is kio_desktop usable with non-plasma 
workspaces, like gnome? Or is the desktop dir itself non-standard and the 
handling of desktop files (quite common on the desktop) different?
  
  BTW what is it that has a strong runtime dependency on kio_desktop? (sorry, 
I'm not on plasma-devel so I didn't follow the full discussion).
  
  As I said, I have no problem with kio_remote moving to kio (apart from the 
broken coding style (mixing tabs and spaces)).

REVISION DETAIL
  https://phabricator.kde.org/D3530

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, #frameworks, #plasma, dfaure
Cc: mart, aacid, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-12-04 Thread David Faure



> On Nov. 21, 2016, 8:34 a.m., David Faure wrote:
> > filenamesearch/kded/filenamesearchmodule.cpp, line 84
> > 
> >
> > Well, if dirUrl looks like 
> > "filenamesearch:?search=file=file:///path/to/file" then dirUrl.path() 
> > is empty, and this code is incorrect (it should use the query item "url", 
> > not the path). What am I missing?
> 
> Anthony Fieroni wrote:
> This is a big misunderstanding mainly by me. Emitted url should contains 
> query with new path ?
> for (const QString  : files) {
> const QUrl url(file);
> if (!url.isLocalFile()) {
> continue;
> }
> const QString urlPath = url.path();
> for (const QUrl  : m_searchUrls) {
> QUrlQuery urlQuery(dirUrl);
> QString str = urlQuery.queryItemValue(QStringLiteral("url"));
> if (urlPath.startsWith(QUrl(str).path())) {
> QUrl temp;
> temp.setScheme(QStringLiteral("filenamesearch"));
> urlQuery.removeQueryItem(QStringLiteral("url");
> urlQuery.addQueryItem(QStringLiteral('url"), url);
> temp.setQuery(urlQuery);
> fileList << temp;
> }
> }
> }
> 
> David Faure wrote:
> Maybe, but I'm still in the dark about something. How can KDirLister cope 
> with listing such URLs? It wants a directory URL and files inside that 
> directory. Such a filenamesearch URL doesn't look like it's a file inside a 
> directory, in terms of paths. Ideally I would look into the code to 
> understand what is being done but I'm short on time.
> 
> Does kio_filenamesearch really return items from listDir(), which have an 
> empty path too, just like the listed directory? I would assume this breaks 
> many things in KDirLister.
> 
> Please clarify with the dolphin people (or whoever wrote the 
> filenamesearch KIO) about the URL structure, then it will be straightforward 
> to do the URL conversions in this code.
> 
> Anthony Fieroni wrote:
> I'm invited Emmanuel, who knows? 
> https://github.com/KDE/dolphin/blob/1710304e9ba926d2aec4226d00974b826f9bcbc0/src/kitemviews/kfileitemmodel.cpp#L123
>  url("filenamesearch:?search=file=file:///path/to/file") in slot 
> https://github.com/KDE/dolphin/blob/1710304e9ba926d2aec4226d00974b826f9bcbc0/src/kitemviews/kfileitemmodel.cpp#L77
>  comes results
> 
> Emmanuel Pescosta wrote:
> Peter wrote the filenamesearch slave.
> 
> Filenamesearch URLs are only used to initiate a search. The URL contains 
> the search start-folder, the pattern used for matching and an optional 'check 
> contents' query item which can be yes or no. The filenamesearch ioslave uses 
> all this query items to perform the search. It recursively opens each folder 
> via KCoreDirLister (starting with the start-folder of the filenamesearch URL) 
> and iterates trough the item list of the directory, every matching item is 
> then listed via `listEntry` by using the UDSEntry of the matching item (see 
> 1). So kio_filenamesearch can only return items with an empty path if the 
> underlying ioslave (local, smb, ftp, ...) returns items with an empty path.
> 
> [1] 
> https://github.com/KDE/kio-extras/blob/master/filenamesearch/kio_filenamesearch.cpp#L103
> 
> Anthony Fieroni wrote:
> I and David, i guess, it's not clear how KDirlister handles url with 
> queries, i'm searching for this code, but i don't found it.
> 
> David Faure wrote:
> Ah but then KDirLister never sees that URL with a query in it, it's only 
> used for the app->slave communication (listDir).
>(don't look for handling of queries in kdirlister, there isn't any. 
> kdirlister thinks of dirs with items in them, that's it).
> 
> And to make things more confusing, I wasn't talking about the KDirLister 
> used by the slave itself (this is rather unusual and could be much more 
> optimized by using KIO::listDir directly; KDirLister is the backend for 
> views, it puts items into a cache and keeps watching them to mark them as 
> dirty so it knows to update the cache when going to that directory again... 
> all this is overkill for a kioslave who just wants to do a listDir).
> 
> But that's a separate issue. For now let's forget about those 
> KDirListers. The one that I was talking about was the one on the Dolphin 
> side, that one that triggers the listDir in filenamesearch itself in the 
> first place. I think what's happening is that it lists filenamesearch: and in 
> return gets items with UDS_NAME=".zshrc" and 
> UDS_URL="file:///home/dfaure/.zshrc" (random example), so it stores it as if 
> it was filenamesearch:/.zshrc (it's a file inside the listed directory). 
> Which opens the question about what happens if two search results have the 
> same filename.
> But if

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-12-04 Thread David Faure


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129394/#review101273
---



Sure, ship the RAM-usage fix, even if we still need to think about making all 
this actually work.

- David Faure


On Nov. 14, 2016, 11:44 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129394/
> ---
> 
> Review request for KDE Frameworks, Anthony Fieroni, David Faure, and Emmanuel 
> Pescosta.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> ---
> 
> Bug is introduced in https://git.reviewboard.kde.org/r/129297/
> When is fixed new kio-extras realease is needed for 16.08 branch.
> 
> 
> Diffs
> -
> 
>   filenamesearch/kded/filenamesearchmodule.cpp 3f9f582 
> 
> Diff: https://git.reviewboard.kde.org/r/129394/diff/
> 
> 
> Testing
> ---
> 
> No big ram usage but still not works as expected.
> 1. Perform search in Dolphin
> 2. Delete one result item
> 3. View must be update, but it's not
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Re: Review Request 129540: DropJob: emit started copy job after creation

2016-12-04 Thread David Faure


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129540/#review101272
---



I would prefer the subjob to remain an implementation detail. Just like so many 
other KIO jobs which use other jobs internally.

Instead this code should connect the signals from the subjob to the DropJob 
signals. Much like FileCopyJobPrivate::connectSubjob() does.

- David Faure


On Nov. 22, 2016, 9:53 p.m., Alex Bikadorov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129540/
> ---
> 
> (Updated Nov. 22, 2016, 9:53 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> For giving an application a chance to monitor the job.
> 
> 
> Diffs
> -
> 
>   src/widgets/dropjob.h 5c9bf10ecc34282d9acb50cef93e7bc8665cb904 
>   src/widgets/dropjob.cpp 1febd3397ec8e993a9786547da9c381a0f57a1f8 
> 
> Diff: https://git.reviewboard.kde.org/r/129540/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Bikadorov
> 
>

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-12-04 Thread Anthony Fieroni



> On Ноев. 21, 2016, 10:34 преди обяд, David Faure wrote:
> > filenamesearch/kded/filenamesearchmodule.cpp, line 84
> > 
> >
> > Well, if dirUrl looks like 
> > "filenamesearch:?search=file=file:///path/to/file" then dirUrl.path() 
> > is empty, and this code is incorrect (it should use the query item "url", 
> > not the path). What am I missing?
> 
> Anthony Fieroni wrote:
> This is a big misunderstanding mainly by me. Emitted url should contains 
> query with new path ?
> for (const QString  : files) {
> const QUrl url(file);
> if (!url.isLocalFile()) {
> continue;
> }
> const QString urlPath = url.path();
> for (const QUrl  : m_searchUrls) {
> QUrlQuery urlQuery(dirUrl);
> QString str = urlQuery.queryItemValue(QStringLiteral("url"));
> if (urlPath.startsWith(QUrl(str).path())) {
> QUrl temp;
> temp.setScheme(QStringLiteral("filenamesearch"));
> urlQuery.removeQueryItem(QStringLiteral("url");
> urlQuery.addQueryItem(QStringLiteral('url"), url);
> temp.setQuery(urlQuery);
> fileList << temp;
> }
> }
> }
> 
> David Faure wrote:
> Maybe, but I'm still in the dark about something. How can KDirLister cope 
> with listing such URLs? It wants a directory URL and files inside that 
> directory. Such a filenamesearch URL doesn't look like it's a file inside a 
> directory, in terms of paths. Ideally I would look into the code to 
> understand what is being done but I'm short on time.
> 
> Does kio_filenamesearch really return items from listDir(), which have an 
> empty path too, just like the listed directory? I would assume this breaks 
> many things in KDirLister.
> 
> Please clarify with the dolphin people (or whoever wrote the 
> filenamesearch KIO) about the URL structure, then it will be straightforward 
> to do the URL conversions in this code.
> 
> Anthony Fieroni wrote:
> I'm invited Emmanuel, who knows? 
> https://github.com/KDE/dolphin/blob/1710304e9ba926d2aec4226d00974b826f9bcbc0/src/kitemviews/kfileitemmodel.cpp#L123
>  url("filenamesearch:?search=file=file:///path/to/file") in slot 
> https://github.com/KDE/dolphin/blob/1710304e9ba926d2aec4226d00974b826f9bcbc0/src/kitemviews/kfileitemmodel.cpp#L77
>  comes results
> 
> Emmanuel Pescosta wrote:
> Peter wrote the filenamesearch slave.
> 
> Filenamesearch URLs are only used to initiate a search. The URL contains 
> the search start-folder, the pattern used for matching and an optional 'check 
> contents' query item which can be yes or no. The filenamesearch ioslave uses 
> all this query items to perform the search. It recursively opens each folder 
> via KCoreDirLister (starting with the start-folder of the filenamesearch URL) 
> and iterates trough the item list of the directory, every matching item is 
> then listed via `listEntry` by using the UDSEntry of the matching item (see 
> 1). So kio_filenamesearch can only return items with an empty path if the 
> underlying ioslave (local, smb, ftp, ...) returns items with an empty path.
> 
> [1] 
> https://github.com/KDE/kio-extras/blob/master/filenamesearch/kio_filenamesearch.cpp#L103
> 
> Anthony Fieroni wrote:
> I and David, i guess, it's not clear how KDirlister handles url with 
> queries, i'm searching for this code, but i don't found it.
> 
> David Faure wrote:
> Ah but then KDirLister never sees that URL with a query in it, it's only 
> used for the app->slave communication (listDir).
>(don't look for handling of queries in kdirlister, there isn't any. 
> kdirlister thinks of dirs with items in them, that's it).
> 
> And to make things more confusing, I wasn't talking about the KDirLister 
> used by the slave itself (this is rather unusual and could be much more 
> optimized by using KIO::listDir directly; KDirLister is the backend for 
> views, it puts items into a cache and keeps watching them to mark them as 
> dirty so it knows to update the cache when going to that directory again... 
> all this is overkill for a kioslave who just wants to do a listDir).
> 
> But that's a separate issue. For now let's forget about those 
> KDirListers. The one that I was talking about was the one on the Dolphin 
> side, that one that triggers the listDir in filenamesearch itself in the 
> first place. I think what's happening is that it lists filenamesearch: and in 
> return gets items with UDS_NAME=".zshrc" and 
> UDS_URL="file:///home/dfaure/.zshrc" (random example), so it stores it as if 
> it was filenamesearch:/.zshrc (it's a file inside the listed directory). 
> Which opens the question about what happens if two search results have the 
> same filename.
>

Re: Review Request 129611: Make Gpgme a required dependency if we build Gpgme interface.

2016-12-04 Thread Andreas Sturmlechner


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129611/#review101269
---



Is it really a possible scenario that Gpgmepp is installed, but not Gpgme? In 
the past, that call was necessary to fix build with gpgme not being in a subdir 
below /usr/include, but not anymore. I guess there would be a way to get rid of 
gpgme.h instead.

- Andreas Sturmlechner


On Dec. 4, 2016, 12:49 a.m., Sandro Knauß wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129611/
> ---
> 
> (Updated Dec. 4, 2016, 12:49 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> Acording to the README of QGpgME, we cannot expect to be gpgme.h be 
> available, so we need to search for GpgME by our own.
> 
> See 
> https://git.gnupg.org/cgi-bin/gitweb.cgi?p=gpgme.git;a=blob;f=lang/cpp/README;h=b9a48da15ce424a08d0e8c5d20846af8882da193;hb=HEAD#l31
> 
>   31 7. Complete abstraction of the C-API so "gpgme.h" should not
>   32be needed in your project using GpgME++.
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/CMakeLists.txt 
> 5092a7e77a1ca7203827e444c11310566b2cc8b5 
> 
> Diff: https://git.reviewboard.kde.org/r/129611/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

Re: Review Request 129609: utils.js: Escape backslash in i18n string

2016-12-04 Thread Dominik Haumann


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129609/#review101268
---


Ship it!




I guess this is fine. Please commit.

- Dominik Haumann


On Dez. 3, 2016, 7:38 nachm., Alexander Potashev wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129609/
> ---
> 
> (Updated Dez. 3, 2016, 7:38 nachm.)
> 
> 
> Review request for Kate and KDE Frameworks.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> ---
> 
> utils.js: Escape backslash in i18n string
> 
> 
> Diffs
> -
> 
>   src/script/data/commands/utils.js a47e2b41a3c2bb581c48b566244b108b531be71a 
> 
> Diff: https://git.reviewboard.kde.org/r/129609/diff/
> 
> 
> Testing
> ---
> 
> None!
> 
> 
> Thanks,
> 
> Alexander Potashev
> 
>

Re: Review Request 129613: Revert "If Gpgmepp is not found, try to use KF5Gpgmepp"

2016-12-04 Thread Andreas Sturmlechner


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129613/
---

(Updated Dec. 4, 2016, 12:33 p.m.)


Review request for KDE Frameworks and David Faure.


Repository: kwallet


Description (updated)
---

GpgME-1.7.0 released > 2 months ago, KF5Gpgmepp no longer maintained.
No reason to keep the fallback any longer.

Separate commits:
- This reverts commit 60ebcad53c95ecfbe822647075f79578c3420851.
- Specify minimum required GpgME++ version 1.7.0
- Drop obsolete FindGpgme.cmake
- Messages: More QGpgME -> GpgME


Diffs (updated)
-

  cmake/FindGpgme.cmake 7a092104ba0604b0606c4662750b8b32c5c3e2c6 
  src/runtime/kwalletd/CMakeLists.txt fe72f2ef50417010a9c49b9b6dfdf6465c2e23fb 
  src/runtime/kwalletd/backend/CMakeLists.txt 
0bd312688b2cdc49be14ffe278068309ac06051c 
  src/runtime/kwalletd/knewwalletdialog.cpp 
7383b1310733c208ca269bb8c1c407cb87291c13 
  src/runtime/kwalletd/kwalletwizard.cpp 
582b5e9b0e2d625e5219fc2ac48d0dd1690448ae 
  tests/kwalletd/CMakeLists.txt 1e7c4b77ba478147fae964f61c28a736e32b9ea9 

Diff: https://git.reviewboard.kde.org/r/129613/diff/


Testing
---


Thanks,

Andreas Sturmlechner

Review Request 129613: Revert "If Gpgmepp is not found, try to use KF5Gpgmepp"

2016-12-04 Thread Andreas Sturmlechner


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129613/
---

Review request for KDE Frameworks and David Faure.


Repository: kwallet


Description
---

GpgME-1.7.0 released > 2 months ago, KF5Gpgmepp no longer maintained.
No reason to keep the fallback any longer.

This reverts commit 60ebcad53c95ecfbe822647075f79578c3420851.

Specify minimum required GpgME++ version 1.7.0


Diffs
-

  src/runtime/kwalletd/CMakeLists.txt fe72f2ef50417010a9c49b9b6dfdf6465c2e23fb 
  src/runtime/kwalletd/backend/CMakeLists.txt 
0bd312688b2cdc49be14ffe278068309ac06051c 
  tests/kwalletd/CMakeLists.txt 1e7c4b77ba478147fae964f61c28a736e32b9ea9 

Diff: https://git.reviewboard.kde.org/r/129613/diff/


Testing
---


Thanks,

Andreas Sturmlechner

Re: Review Request 129341: [kwallet] boost::shared_ptr -> std::shared_ptr

2016-12-04 Thread Andreas Sturmlechner


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129341/
---

(Updated Dec. 4, 2016, 6:55 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit f4e1653eefe9e81adbb7ec7f8eda51e02cd58f7b by Andreas 
Sturmlechner to branch master.


Repository: kwallet


Description
---

Dropping implicit boost usage.
Also, rename HAVE_QGPGME to HAVE_GPGMEPP.


Diffs
-

  src/runtime/kwalletd/CMakeLists.txt 5092a7e77a1ca7203827e444c11310566b2cc8b5 
  src/runtime/kwalletd/backend/CMakeLists.txt 
2f99bc3cca89dd7a194f46cb314d2f7f90f931f3 
  src/runtime/kwalletd/backend/backendpersisthandler.h 
a6682353d62fd63e88a0de6277801c624c794c74 
  src/runtime/kwalletd/backend/backendpersisthandler.cpp 
413d4cd23ef1e15b75cd366061f07f179241af58 
  src/runtime/kwalletd/backend/kwalletbackend.h 
4811a58e942685b01ed097ef15c2838e3833865c 
  src/runtime/kwalletd/backend/kwalletbackend.cc 
43f30a545d36b64b102c794de3625621a694983e 
  src/runtime/kwalletd/knewwalletdialog.h 
ea71fbc7d59fdd05da7ce395e371dd7fdf91e49d 
  src/runtime/kwalletd/knewwalletdialog.cpp 
0d9ffb8ed469536cee9d4055ac0bd001fff115a0 
  src/runtime/kwalletd/kwalletd.cpp ca7d4ffbdff4178878b3c705921ef2b1970e0dbd 
  src/runtime/kwalletd/kwalletwizard.h 4cf8de424af800716e7c779d6d419eae4b54e426 
  src/runtime/kwalletd/kwalletwizard.cpp 
cd52e54a668554fc0e14f4ad4cb29ba6f27fd330 

Diff: https://git.reviewboard.kde.org/r/129341/diff/


Testing
---


Thanks,

Andreas Sturmlechner

Re: Review Request 129341: [kwallet] boost::shared_ptr -> std::shared_ptr

2016-12-04 Thread Andreas Sturmlechner


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129341/
---

(Updated Dec. 4, 2016, 11:55 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit f4e1653eefe9e81adbb7ec7f8eda51e02cd58f7b by Andreas 
Sturmlechner to branch master.


Repository: kwallet


Description
---

Dropping implicit boost usage.
Also, rename HAVE_QGPGME to HAVE_GPGMEPP.


Diffs
-

  src/runtime/kwalletd/CMakeLists.txt 5092a7e77a1ca7203827e444c11310566b2cc8b5 
  src/runtime/kwalletd/backend/CMakeLists.txt 
2f99bc3cca89dd7a194f46cb314d2f7f90f931f3 
  src/runtime/kwalletd/backend/backendpersisthandler.h 
a6682353d62fd63e88a0de6277801c624c794c74 
  src/runtime/kwalletd/backend/backendpersisthandler.cpp 
413d4cd23ef1e15b75cd366061f07f179241af58 
  src/runtime/kwalletd/backend/kwalletbackend.h 
4811a58e942685b01ed097ef15c2838e3833865c 
  src/runtime/kwalletd/backend/kwalletbackend.cc 
43f30a545d36b64b102c794de3625621a694983e 
  src/runtime/kwalletd/knewwalletdialog.h 
ea71fbc7d59fdd05da7ce395e371dd7fdf91e49d 
  src/runtime/kwalletd/knewwalletdialog.cpp 
0d9ffb8ed469536cee9d4055ac0bd001fff115a0 
  src/runtime/kwalletd/kwalletd.cpp ca7d4ffbdff4178878b3c705921ef2b1970e0dbd 
  src/runtime/kwalletd/kwalletwizard.h 4cf8de424af800716e7c779d6d419eae4b54e426 
  src/runtime/kwalletd/kwalletwizard.cpp 
cd52e54a668554fc0e14f4ad4cb29ba6f27fd330 

Diff: https://git.reviewboard.kde.org/r/129341/diff/


Testing
---


Thanks,

Andreas Sturmlechner

Jenkins-kde-ci: kmediaplayer master kf5-qt5 » Linux,gcc - Build # 302 - Fixed!

2016-12-04 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kmediaplayer%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/302/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 04 Dec 2016 10:31:32 +
Build duration: 1 min 19 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 183/240 
(76%)CONDITIONAL 78/148 (53%)

By packages
  
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 113/131 (86%)CONDITIONAL 
59/118 (50%)
src
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 70/109 (64%)CONDITIONAL 
19/30 (63%)

Jenkins-kde-ci: kmediaplayer master kf5-qt5 » Linux,gcc - Build # 302 - Fixed!

2016-12-04 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kmediaplayer%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/302/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 04 Dec 2016 10:31:32 +
Build duration: 1 min 19 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 183/240 
(76%)CONDITIONAL 78/148 (53%)

By packages
  
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 113/131 (86%)CONDITIONAL 
59/118 (50%)
src
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 70/109 (64%)CONDITIONAL 
19/30 (63%)

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 296 - Still Unstable!

2016-12-04 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/296/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 04 Dec 2016 09:58:58 +
Build duration: 14 min

CHANGE SET
Revision 84d5c6c71d2f0e37ef4cc9c4349531ba088e2ae6 by David Faure: (Add support 
for calling suspend() on a CopyJob before it gets started.)
  change: edit autotests/jobtest.h
  change: edit autotests/jobtest.cpp
  change: edit src/core/copyjob.h
  change: edit src/core/copyjob.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 
52 test(s)Failed: TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 271/340 (80%)CLASSES 271/340 (80%)LINE 29409/51459 
(57%)CONDITIONAL 16134/38581 (42%)

By packages
  
autotests
FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7849/8174 
(96%)CONDITIONAL 4390/8580 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/116 (83%)CLASSES 96/116 (83%)LINE 7888/14158 
(56%)CONDITIONAL 4318/9231 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3406/7559 
(45%)CONDITIONAL 1260/4381 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 443/842 (53%)CONDITIONAL 
329/745 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1755/3780 
(46%)CONDITIONAL 1252/3460 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 
607/839 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 715/1139 (63%)CONDITIONAL 
411/833 (49%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 
150/546 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 28/29 (97%)CONDITIONAL 
21/26 (81%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 
332/412 (81%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3606/10968 
(33%)CONDITIONAL 1734/7050 (25%)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 301 - Fixed!

2016-12-04 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/301/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 04 Dec 2016 09:56:43 +
Build duration: 7 min 38 sec

CHANGE SET
Revision 84d5c6c71d2f0e37ef4cc9c4349531ba088e2ae6 by David Faure: (Add support 
for calling suspend() on a CopyJob before it gets started.)
  change: edit autotests/jobtest.h
  change: edit autotests/jobtest.cpp
  change: edit src/core/copyjob.h
  change: edit src/core/copyjob.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 
52 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 271/340 (80%)CLASSES 271/340 (80%)LINE 29411/51459 
(57%)CONDITIONAL 16128/38581 (42%)

By packages
  
autotests
FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7850/8174 
(96%)CONDITIONAL 4389/8580 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/116 (83%)CLASSES 96/116 (83%)LINE 7892/14158 
(56%)CONDITIONAL 4314/9231 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3404/7559 
(45%)CONDITIONAL 1260/4381 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 443/842 (53%)CONDITIONAL 
329/745 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1763/3780 
(47%)CONDITIONAL 1261/3460 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 
607/839 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 705/1139 (62%)CONDITIONAL 
402/833 (48%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 
150/546 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 
16/26 (62%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 
332/412 (81%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3614/10968 
(33%)CONDITIONAL 1736/7050 (25%)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 301 - Fixed!

2016-12-04 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/301/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 04 Dec 2016 09:56:43 +
Build duration: 7 min 38 sec

CHANGE SET
Revision 84d5c6c71d2f0e37ef4cc9c4349531ba088e2ae6 by David Faure: (Add support 
for calling suspend() on a CopyJob before it gets started.)
  change: edit autotests/jobtest.h
  change: edit autotests/jobtest.cpp
  change: edit src/core/copyjob.h
  change: edit src/core/copyjob.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 
52 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 271/340 (80%)CLASSES 271/340 (80%)LINE 29411/51459 
(57%)CONDITIONAL 16128/38581 (42%)

By packages
  
autotests
FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7850/8174 
(96%)CONDITIONAL 4389/8580 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/116 (83%)CLASSES 96/116 (83%)LINE 7892/14158 
(56%)CONDITIONAL 4314/9231 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3404/7559 
(45%)CONDITIONAL 1260/4381 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 443/842 (53%)CONDITIONAL 
329/745 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1763/3780 
(47%)CONDITIONAL 1261/3460 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 
607/839 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 705/1139 (62%)CONDITIONAL 
402/833 (48%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 
150/546 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 
16/26 (62%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 
332/412 (81%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3614/10968 
(33%)CONDITIONAL 1736/7050 (25%)

Jenkins-kde-ci: kmediaplayer master kf5-qt5 » Linux,gcc - Build # 301 - Failure!

2016-12-04 Thread no-reply


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kmediaplayer%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/301/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 04 Dec 2016 09:58:57 +
Build duration: 3 min 46 sec

CHANGE SET
No changes

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 295 - Still Unstable!

2016-12-04 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/295/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 04 Dec 2016 09:42:36 +
Build duration: 8 min 33 sec

CHANGE SET
Revision 91fd82cc595a07549ef9da85079415497a7780ae by David Faure: (Add support 
for suspending jobs immediately, at least for SimpleJob and)
  change: edit src/core/filecopyjob.cpp
  change: edit src/core/simplejob.cpp
  change: edit autotests/jobtest.cpp
  change: edit autotests/jobtest.h


JUNIT RESULTS

Name: (root) Failed: 31 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 
52 test(s)Failed: TestSuite.kiocore-jobtestFailed: 
TestSuite.kiocore-threadtestFailed: 
TestSuite.kiofilewidgets-kdiroperatortestFailed: 
TestSuite.kiofilewidgets-kfilecopytomenutestFailed: 
TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: 
TestSuite.kiofilewidgets-kfilewidgettestFailed: 
TestSuite.kiofilewidgets-knewfilemenutestFailed: 
TestSuite.kiofilewidgets-kurlcomboboxtestFailed: 
TestSuite.kiofilewidgets-kurlnavigatortestFailed: 
TestSuite.kiofilewidgets-kurlrequestertestFailed: 
TestSuite.kiogui-favicontestFailed: 
TestSuite.kioslave-httpauthenticationtestFailed: 
TestSuite.kioslave-httpheaderdispositiontestFailed: 
TestSuite.kioslave-httpheadertokenizetestFailed: 
TestSuite.kioslave-httpobjecttestFailed: 
TestSuite.kioslave-kcookiejartestFailed: 
TestSuite.kiowidgets-accessmanagertestFailed: 
TestSuite.kiowidgets-accessmanagertest-qnamFailed: 
TestSuite.kiowidgets-clipboardupdatertestFailed: 
TestSuite.kiowidgets-dropjobtestFailed: 
TestSuite.kiowidgets-fileundomanagertestFailed: 
TestSuite.kiowidgets-jobguitestFailed: 
TestSuite.kiowidgets-kdirlistertestFailed: 
TestSuite.kiowidgets-kdirmodeltestFailed: 
TestSuite.kiowidgets-kfileitemactionstestFailed: 
TestSuite.kiowidgets-krununittestFailed: 
TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: 
TestSuite.kiowidgets-kurifiltertestFailed: 
TestSuite.kiowidgets-kurlcompletiontestFailed: 
TestSuite.kiowidgets-kurlcompletiontest-nowaitFailed: 
TestSuite.kiowidgets-pastetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 12/13 (92%)FILES 149/243 (61%)CLASSES 149/243 (61%)LINE 13367/36785 
(36%)CONDITIONAL 7106/26712 (27%)

By packages
  
autotests
FILES 34/34 (100%)CLASSES 34/34 (100%)LINE 3495/3700 
(94%)CONDITIONAL 1753/3394 (52%)
autotests.http
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 65/65 (100%)CONDITIONAL 
41/80 (51%)
src.core
FILES 88/116 (76%)CLASSES 88/116 (76%)LINE 6071/14148 
(43%)CONDITIONAL 2971/9227 (32%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 426/842 (51%)CONDITIONAL 
316/745 (42%)
src.ioslaves.http
FILES 6/8 (75%)CLASSES 6/8 (75%)LINE 1022/3775 (27%)CONDITIONAL 
637/3459 (18%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 694/1139 (61%)CONDITIONAL 
387/833 (46%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/385 (0%)CONDITIONAL 0/138 
(0%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.widgets
FILES 4/64 (6%)CLASSES 4/64 (6%)LINE 199/10967 (2%)CONDITIONAL 
122/7048 (2%)

Re: Problems managing KIO::Jobs

2016-12-04 Thread David Faure

On lundi 14 novembre 2016 15:23:01 CET A. Bikadorov wrote:
> 1. Creating and immediately suspending a job does not work as expected. E.g.
> after
> > KIO::Job job = KIO::copy(urls, dest, flags);
> > bool result = job->suspend(); // returns true
> > bool result2 = job->isSuspended(); // returns true
> 
> the file copy operation is still starting. All progress signals
> (description(), percent(), ...), are omitted until result() and finished()
> are emitted. I'm sure this is a bug and can report it but would also like
> to know a workaround to continue implementing a "job queue" (i.e. the user
> decides when a job is started).

Indeed suspend() before starting wasn't implemented. It was only used
internally for the bitburger protocol in CopyJob.

I have now at least implemented suspend()-before-start() in SimpleJob
and FileCopyJob, in 
https://commits.kde.org/kio/91fd82cc595a07549ef9da85079415497a7780ae
(this won't be in KF 5.29, it's for 5.30)

So the above would work with KIO::file_copy, at least.
KIO::copy is a different story, a CopyJob has no kioslave on its own, but 
basically manages a state machine, so suspending anywhere in there and 
resuming where we left off seems a bit tricky. The special case of suspending
before starting is easy to implement though... done:
https://commits.kde.org/kio/84d5c6c71d2f0e37ef4cc9c4349531ba088e2ae6

I'm afraid I can't provide you with any workarounds, other than not creating 
the job until it should run.

> 2. Similar to (1) DropJobs are never emitting any signals until finished().
> It must be possible somehow to monitor the progress of copy or move
> operations because the notification widget does this. But I could not
> figure out how plasma-workspace/kuiserver does this.

I suppose kuiserver gets the signals from the subjob, while you're listening 
to the DropJob itself.

It should be easy to forward the signals in 
DropJobPrivate::doCopyToDirectory().

Feel free to make a patch (or report a bug, but a patch is preferred ;) ).

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 300 - Unstable!

2016-12-04 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/300/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 04 Dec 2016 09:42:36 +
Build duration: 7 min 12 sec

CHANGE SET
Revision 91fd82cc595a07549ef9da85079415497a7780ae by David Faure: (Add support 
for suspending jobs immediately, at least for SimpleJob and)
  change: edit src/core/filecopyjob.cpp
  change: edit autotests/jobtest.h
  change: edit autotests/jobtest.cpp
  change: edit src/core/simplejob.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 
52 test(s)Failed: TestSuite.kiocore-jobtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 271/340 (80%)CLASSES 271/340 (80%)LINE 29384/51432 
(57%)CONDITIONAL 16119/38559 (42%)

By packages
  
autotests
FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7828/8157 
(96%)CONDITIONAL 4379/8562 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/116 (83%)CLASSES 96/116 (83%)LINE 7887/14148 
(56%)CONDITIONAL 4318/9227 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3404/7559 
(45%)CONDITIONAL 1260/4381 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 443/842 (53%)CONDITIONAL 
329/745 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1763/3780 
(47%)CONDITIONAL 1261/3460 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 
607/839 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 705/1139 (62%)CONDITIONAL 
402/833 (48%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 
150/546 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 
16/26 (62%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 
332/412 (81%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3614/10968 
(33%)CONDITIONAL 1735/7050 (25%)

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 294 - Still Unstable!

2016-12-04 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/294/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 04 Dec 2016 09:29:21 +
Build duration: 6 min 53 sec

CHANGE SET
Revision d31c594e7bb7a3cf83c4dff68b9263f7769deed0 by David Faure: (Use 
QLoggingCategory to enable debug output in KUriFilterPlugins)
  change: edit src/urifilters/ikws/kuriikwsfiltereng.cpp
  change: edit autotests/kurifiltertest.cpp
  change: edit src/urifilters/shorturi/kshorturifilter.cpp
  change: edit src/urifilters/ikws/kuriikwsfilter.cpp
  change: edit src/urifilters/ikws/kurisearchfilter.cpp
  change: edit src/urifilters/localdomain/localdomainurifilter.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 
52 test(s)Failed: TestSuite.kiocore-ktcpsockettest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 271/340 (80%)CLASSES 271/340 (80%)LINE 29297/51412 
(57%)CONDITIONAL 16074/38535 (42%)

By packages
  
autotests
FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7816/8141 
(96%)CONDITIONAL 4372/8542 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/116 (83%)CLASSES 96/116 (83%)LINE 7815/14144 
(55%)CONDITIONAL 4280/9223 (46%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3409/7559 
(45%)CONDITIONAL 1260/4381 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 443/842 (53%)CONDITIONAL 
329/745 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1763/3780 
(47%)CONDITIONAL 1261/3460 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 
607/839 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 705/1139 (62%)CONDITIONAL 
402/833 (48%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 
150/546 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 
16/26 (62%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 
332/412 (81%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3606/10968 
(33%)CONDITIONAL 1733/7050 (25%)

Re: Review Request 129396: Allow to read X-KDE-RunOnDiscreteGpu property from desktop file + take this option into account when starting service using KToolInvocation

2016-12-04 Thread David Faure


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129396/#review101265
---


Fix it, then Ship it!





src/services/kservice.h (line 130)


5.30 at this point


- David Faure


On Nov. 29, 2016, 9:47 a.m., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129396/
> ---
> 
> (Updated Nov. 29, 2016, 9:47 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> $SUMMARY says it all I guess, this patch allows to read 
> X-KDE-RunOnDiscreteGpu property which can be now set from KPropertiesDialog, 
> see review 129395. Also when running an application using KToolInvocation 
> (e.g. when running an app from panel or desktop) take this property into 
> account and set required variable accordingly.
> 
> 
> Diffs
> -
> 
>   src/services/kservice.h 66525b4 
>   src/services/kservice.cpp 6574367 
> 
> Diff: https://git.reviewboard.kde.org/r/129396/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Re: Review Request 129341: [kwallet] boost::shared_ptr -> std::shared_ptr

2016-12-04 Thread David Faure


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129341/#review101264
---


Ship it!




Looks OK. It would have been better to make this two separate commits though 
(one about shared_ptr and one about the #define, they are completely unrelated).

- David Faure


On Nov. 15, 2016, 8:54 p.m., Andreas Sturmlechner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129341/
> ---
> 
> (Updated Nov. 15, 2016, 8:54 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> Dropping implicit boost usage.
> Also, rename HAVE_QGPGME to HAVE_GPGMEPP.
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/CMakeLists.txt 
> 5092a7e77a1ca7203827e444c11310566b2cc8b5 
>   src/runtime/kwalletd/backend/CMakeLists.txt 
> 2f99bc3cca89dd7a194f46cb314d2f7f90f931f3 
>   src/runtime/kwalletd/backend/backendpersisthandler.h 
> a6682353d62fd63e88a0de6277801c624c794c74 
>   src/runtime/kwalletd/backend/backendpersisthandler.cpp 
> 413d4cd23ef1e15b75cd366061f07f179241af58 
>   src/runtime/kwalletd/backend/kwalletbackend.h 
> 4811a58e942685b01ed097ef15c2838e3833865c 
>   src/runtime/kwalletd/backend/kwalletbackend.cc 
> 43f30a545d36b64b102c794de3625621a694983e 
>   src/runtime/kwalletd/knewwalletdialog.h 
> ea71fbc7d59fdd05da7ce395e371dd7fdf91e49d 
>   src/runtime/kwalletd/knewwalletdialog.cpp 
> 0d9ffb8ed469536cee9d4055ac0bd001fff115a0 
>   src/runtime/kwalletd/kwalletd.cpp ca7d4ffbdff4178878b3c705921ef2b1970e0dbd 
>   src/runtime/kwalletd/kwalletwizard.h 
> 4cf8de424af800716e7c779d6d419eae4b54e426 
>   src/runtime/kwalletd/kwalletwizard.cpp 
> cd52e54a668554fc0e14f4ad4cb29ba6f27fd330 
> 
> Diff: https://git.reviewboard.kde.org/r/129341/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

Re: Review Request 129540: DropJob: emit started copy job after creation

Re: Review Request 129540: DropJob: emit started copy job after creation

[Differential] [Commented On] D3530: Import plasma-workspace kioslaves

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

Re: Review Request 129540: DropJob: emit started copy job after creation

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

Re: Review Request 129611: Make Gpgme a required dependency if we build Gpgme interface.

Re: Review Request 129609: utils.js: Escape backslash in i18n string

Re: Review Request 129613: Revert "If Gpgmepp is not found, try to use KF5Gpgmepp"

Review Request 129613: Revert "If Gpgmepp is not found, try to use KF5Gpgmepp"

Re: Review Request 129341: [kwallet] boost::shared_ptr -> std::shared_ptr

Re: Review Request 129341: [kwallet] boost::shared_ptr -> std::shared_ptr

Jenkins-kde-ci: kmediaplayer master kf5-qt5 » Linux,gcc - Build # 302 - Fixed!

Jenkins-kde-ci: kmediaplayer master kf5-qt5 » Linux,gcc - Build # 302 - Fixed!

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 296 - Still Unstable!

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 301 - Fixed!

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 301 - Fixed!

Jenkins-kde-ci: kmediaplayer master kf5-qt5 » Linux,gcc - Build # 301 - Failure!

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 295 - Still Unstable!

Re: Problems managing KIO::Jobs

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 300 - Unstable!

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 294 - Still Unstable!

Re: Review Request 129396: Allow to read X-KDE-RunOnDiscreteGpu property from desktop file + take this option into account when starting service using KToolInvocation

Re: Review Request 129341: [kwallet] boost::shared_ptr -> std::shared_ptr

25 matches

Site Navigation

Mail list logo

Footer information