[Differential] [Updated] D3586: [WIP] Fix logging category usage on Windows
kfunk added a reviewer: Frameworks. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D3586 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: vonreth, sandsmark, kfunk, leinir, #frameworks Cc: kfunk, leinir, mutlaqja
Re: Review Request 129540: DropJob: emit started copy job after creation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129540/#review101313 --- Ship it! Ship It! - Alex Bikadorov On Dec. 5, 2016, 4:37 p.m., Alex Bikadorov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129540/ > --- > > (Updated Dec. 5, 2016, 4:37 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > --- > > For giving an application a chance to monitor and control the subjob. > > > Diffs > - > > autotests/dropjobtest.cpp ad83029762e1cf2c12d4924187a49bf7221109d7 > src/widgets/dropjob.h 5c9bf10ecc34282d9acb50cef93e7bc8665cb904 > src/widgets/dropjob.cpp 5d2b6fe1668ac7a2ba39895ad3e0191d32be5545 > > Diff: https://git.reviewboard.kde.org/r/129540/diff/ > > > Testing > --- > > > Thanks, > > Alex Bikadorov > >
Re: Review Request 129540: DropJob: emit started copy job after creation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129540/ --- (Updated Dec. 6, 2016, 2:15 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 57a2022c326e5378a778c78ec2fa513beb98e31e by Alexander Bikadorov to branch master. Repository: kio Description --- For giving an application a chance to monitor and control the subjob. Diffs - autotests/dropjobtest.cpp ad83029762e1cf2c12d4924187a49bf7221109d7 src/widgets/dropjob.h 5c9bf10ecc34282d9acb50cef93e7bc8665cb904 src/widgets/dropjob.cpp 5d2b6fe1668ac7a2ba39895ad3e0191d32be5545 Diff: https://git.reviewboard.kde.org/r/129540/diff/ Testing --- Thanks, Alex Bikadorov
[Differential] [Updated] D2854: New: ECMAddQch, for generating qch & doxygen tag files
kossebau updated the summary for this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Commented On] D2854: New: ECMAddQch, for generating qch & doxygen tag files
kossebau added inline comments.
INLINE COMMENTS
> shumski wrote in KDEInstallDirs.cmake:534
> Hm, i guess i haven't checked KDEInstallDirs in a while. Somehow i remember
> KDE_INSTALL_USE_QT_SYS_PATHS was only activated by default if
> CMAKE_INSTALL_PREFIX was /usr.
>
> Ok, so the non-recognition part should not happen that often -> I'm assuming
> qch files are looked up as QLibraryInfo::DocumentationPath (so,
> QT_INSTALL_DOCS) + *qch.
>
> So with your path, they will not be found (yeah with different prefix they
> aren0t still found, but with qch/ subdir user needs one additional envar for
> KF5 qch's - imagine you need to export QT_PLUGIN_PATH for Qt plugins, and one
> more path for KF5 plugins).
> I don't see a reason to append qch subdir to installation location -> as if
> you're intentionally hiding those files ;-)
Any chance you perhaps misread the code? Because what you say does not match
what should happen at least by what I intended by the code (and what it does on
testing) :)
The qch/ subdir is used with the non-QT_INSTALL_DOCS installation directory. So
`_define_relative(QTQCHDIR DATAROOTDIR "doc/qch")` would be e.g.
"/usr/share/doc/qch" when installing to prefix /usr. Both this and
"/usr/share/doc" will never result in Qt Assistant automatically adding the QCH
file to the default help file collection. This only happens when installing
directly into QT_INSTALL_DOCS (undocumented feature, but stable for some time
:) ).
In the branch which sets up QTQCHDIR to be the Qt system dir,
`_define_absolute(QTQCHDIR ${qt_docs_dir})` will result in QTQCHDIR being equal
to QT_INSTALL_DOCS. No /qch subdir here.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D2854
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kossebau, staniek, #frameworks
Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Updated, 25 lines] D3586: [WIP] Fix logging category usage on Windows
vonreth updated this revision to Diff 8812. vonreth added a comment. Apply changes suggestd by Kevin REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3586?vs=8741&id=8812 BRANCH arcpatch-D3586_1 REVISION DETAIL https://phabricator.kde.org/D3586 AFFECTED FILES src/ioslaves/trash/CMakeLists.txt src/ioslaves/trash/discspaceutil.cpp src/ioslaves/trash/kinterprocesslock.cpp src/ioslaves/trash/kio_trash_win.cpp src/ioslaves/trash/kiotrashdebug.cpp src/ioslaves/trash/kiotrashdebug.h src/ioslaves/trash/trashimpl.cpp src/ioslaves/trash/trashimpl.h src/ioslaves/trash/trashsizecache.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: vonreth, sandsmark, kfunk, leinir, #frameworks Cc: kfunk, leinir, mutlaqja
[Differential] [Updated, 25 lines] D3586: [WIP] Fix logging category usage on Windows
vonreth updated this revision to Diff 8813. vonreth added a comment. Fix commit message REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3586?vs=8812&id=8813 BRANCH arcpatch-D3586_1 REVISION DETAIL https://phabricator.kde.org/D3586 AFFECTED FILES src/ioslaves/trash/CMakeLists.txt src/ioslaves/trash/discspaceutil.cpp src/ioslaves/trash/kinterprocesslock.cpp src/ioslaves/trash/kio_trash_win.cpp src/ioslaves/trash/kiotrashdebug.cpp src/ioslaves/trash/kiotrashdebug.h src/ioslaves/trash/trashimpl.cpp src/ioslaves/trash/trashimpl.h src/ioslaves/trash/trashsizecache.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: vonreth, sandsmark, kfunk, leinir, #frameworks Cc: kfunk, leinir, mutlaqja
[Differential] [Closed] D3586: [WIP] Fix logging category usage on Windows
This revision was automatically updated to reflect the committed changes. Closed by commit R241:d5bf2083ee2e: Fix logging category usage on Windows (authored by vonreth). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3586?vs=8813&id=8816 REVISION DETAIL https://phabricator.kde.org/D3586 AFFECTED FILES src/ioslaves/trash/CMakeLists.txt src/ioslaves/trash/discspaceutil.cpp src/ioslaves/trash/kinterprocesslock.cpp src/ioslaves/trash/kio_trash_win.cpp src/ioslaves/trash/kiotrashdebug.cpp src/ioslaves/trash/kiotrashdebug.h src/ioslaves/trash/trashimpl.cpp src/ioslaves/trash/trashimpl.h src/ioslaves/trash/trashsizecache.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: vonreth, sandsmark, kfunk, leinir, #frameworks Cc: kfunk, leinir, mutlaqja
Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 303 - Failure!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/303/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 06 Dec 2016 15:54:45 + Build duration: 1 min 23 sec CHANGE SET Revision d5bf2083ee2e6d92de14f46ccad54ed125d1fc40 by Hannah von Reth: (Fix logging category usage on Windows) change: add src/ioslaves/trash/kiotrashdebug.cpp change: edit src/ioslaves/trash/trashimpl.h change: edit src/ioslaves/trash/kinterprocesslock.cpp change: edit src/ioslaves/trash/CMakeLists.txt change: add src/ioslaves/trash/kiotrashdebug.h change: edit src/ioslaves/trash/trashsizecache.cpp change: edit src/ioslaves/trash/trashimpl.cpp change: edit src/ioslaves/trash/kio_trash_win.cpp change: edit src/ioslaves/trash/discspaceutil.cpp
Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 299 - Failure!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/299/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 06 Dec 2016 15:54:44 + Build duration: 1 min 26 sec CHANGE SET Revision d5bf2083ee2e6d92de14f46ccad54ed125d1fc40 by Hannah von Reth: (Fix logging category usage on Windows) change: add src/ioslaves/trash/kiotrashdebug.cpp change: edit src/ioslaves/trash/kinterprocesslock.cpp change: edit src/ioslaves/trash/discspaceutil.cpp change: edit src/ioslaves/trash/trashimpl.h change: edit src/ioslaves/trash/CMakeLists.txt change: edit src/ioslaves/trash/trashimpl.cpp change: add src/ioslaves/trash/kiotrashdebug.h change: edit src/ioslaves/trash/trashsizecache.cpp change: edit src/ioslaves/trash/kio_trash_win.cpp
[Differential] [Request, 38 lines] D3609: Create a QCH file with the API dox, optionally, using ECMAddQch
kossebau created this revision. kossebau added a reviewer: Frameworks. REVISION SUMMARY See https://phabricator.kde.org/D2854 for central discussion of new ECMAddQCH TEST PLAN KF5SyntaxHighlighting.qch created by this: https://share.kde.org/index.php/s/tCP48mbIHu5TTTJ REPOSITORY R216 Syntax Highlighting BRANCH addQCHBuild REVISION DETAIL https://phabricator.kde.org/D3609 AFFECTED FILES CMakeLists.txt KF5SyntaxHighlightingConfig.cmake.in src/lib/CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, #frameworks
Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 304 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/304/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 06 Dec 2016 16:39:45 + Build duration: 4 min 52 sec CHANGE SET Revision ec192ad43bb9e40fa2bf175526aefc32d37efcef by admin: (Fix build on linux (and fix test build)) change: edit src/ioslaves/trash/tests/CMakeLists.txt change: edit src/ioslaves/trash/kio_trash.cpp JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 52 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 21/21 (100%)FILES 272/341 (80%)CLASSES 272/341 (80%)LINE 29408/51470 (57%)CONDITIONAL 16138/38601 (42%) By packages autotests FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7860/8184 (96%)CONDITIONAL 4399/8600 (51%) autotests.http FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 (100%)CONDITIONAL 200/336 (60%) autotests.kcookiejar FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 60/90 (67%) src.core FILES 96/116 (83%)CLASSES 96/116 (83%)LINE 7877/14158 (56%)CONDITIONAL 4313/9231 (47%) src.core.kssl FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 3/6 (50%) src.filewidgets FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3405/7559 (45%)CONDITIONAL 1262/4381 (29%) src.gui FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 46/72 (64%) src.ioslaves.file FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 443/842 (53%)CONDITIONAL 329/745 (44%) src.ioslaves.http FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1763/3780 (47%)CONDITIONAL 1261/3460 (36%) src.ioslaves.http.kcookiejar FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 607/839 (72%) src.ioslaves.trash FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 705/1139 (62%)CONDITIONAL 402/833 (48%) src.ioslaves.trash.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 445/936 (48%) src.kioslave FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 5/10 (50%) src.kntlm FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 111/138 (80%) src.kpasswdserver FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 280/580 (48%) src.kpasswdserver.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 146/256 (57%) src.urifilters.fixhost FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 36/54 (67%) src.urifilters.ikws FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 150/546 (27%) src.urifilters.localdomain FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 16/26 (62%) src.urifilters.shorturi FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 332/412 (81%) src.widgets FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3615/10969 (33%)CONDITIONAL 1735/7050 (25%)
Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 304 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/304/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 06 Dec 2016 16:39:45 + Build duration: 4 min 52 sec CHANGE SET Revision ec192ad43bb9e40fa2bf175526aefc32d37efcef by admin: (Fix build on linux (and fix test build)) change: edit src/ioslaves/trash/tests/CMakeLists.txt change: edit src/ioslaves/trash/kio_trash.cpp JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 52 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 21/21 (100%)FILES 272/341 (80%)CLASSES 272/341 (80%)LINE 29408/51470 (57%)CONDITIONAL 16138/38601 (42%) By packages autotests FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7860/8184 (96%)CONDITIONAL 4399/8600 (51%) autotests.http FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 (100%)CONDITIONAL 200/336 (60%) autotests.kcookiejar FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 60/90 (67%) src.core FILES 96/116 (83%)CLASSES 96/116 (83%)LINE 7877/14158 (56%)CONDITIONAL 4313/9231 (47%) src.core.kssl FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 3/6 (50%) src.filewidgets FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3405/7559 (45%)CONDITIONAL 1262/4381 (29%) src.gui FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 46/72 (64%) src.ioslaves.file FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 443/842 (53%)CONDITIONAL 329/745 (44%) src.ioslaves.http FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1763/3780 (47%)CONDITIONAL 1261/3460 (36%) src.ioslaves.http.kcookiejar FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 607/839 (72%) src.ioslaves.trash FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 705/1139 (62%)CONDITIONAL 402/833 (48%) src.ioslaves.trash.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 445/936 (48%) src.kioslave FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 5/10 (50%) src.kntlm FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 111/138 (80%) src.kpasswdserver FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 280/580 (48%) src.kpasswdserver.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 146/256 (57%) src.urifilters.fixhost FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 36/54 (67%) src.urifilters.ikws FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 150/546 (27%) src.urifilters.localdomain FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 16/26 (62%) src.urifilters.shorturi FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 332/412 (81%) src.widgets FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3615/10969 (33%)CONDITIONAL 1735/7050 (25%)
Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 300 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/300/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 06 Dec 2016 16:39:45 + Build duration: 12 min CHANGE SET Revision ec192ad43bb9e40fa2bf175526aefc32d37efcef by admin: (Fix build on linux (and fix test build)) change: edit src/ioslaves/trash/tests/CMakeLists.txt change: edit src/ioslaves/trash/kio_trash.cpp JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 52 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 21/21 (100%)FILES 272/341 (80%)CLASSES 272/341 (80%)LINE 29415/51470 (57%)CONDITIONAL 16144/38601 (42%) By packages autotests FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7860/8184 (96%)CONDITIONAL 4399/8600 (51%) autotests.http FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 (100%)CONDITIONAL 200/336 (60%) autotests.kcookiejar FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 60/90 (67%) src.core FILES 96/116 (83%)CLASSES 96/116 (83%)LINE 7887/14158 (56%)CONDITIONAL 4322/9231 (47%) src.core.kssl FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 3/6 (50%) src.filewidgets FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3408/7559 (45%)CONDITIONAL 1262/4381 (29%) src.gui FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 46/72 (64%) src.ioslaves.file FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 443/842 (53%)CONDITIONAL 329/745 (44%) src.ioslaves.http FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1755/3780 (46%)CONDITIONAL 1252/3460 (36%) src.ioslaves.http.kcookiejar FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 607/839 (72%) src.ioslaves.trash FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 715/1139 (63%)CONDITIONAL 411/833 (49%) src.ioslaves.trash.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 445/936 (48%) src.kioslave FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 5/10 (50%) src.kntlm FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 111/138 (80%) src.kpasswdserver FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 280/580 (48%) src.kpasswdserver.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 144/256 (56%) src.urifilters.fixhost FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 36/54 (67%) src.urifilters.ikws FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 150/546 (27%) src.urifilters.localdomain FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 16/26 (62%) src.urifilters.shorturi FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 332/412 (81%) src.widgets FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3607/10969 (33%)CONDITIONAL 1734/7050 (25%)
Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 300 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/300/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 06 Dec 2016 16:39:45 + Build duration: 12 min CHANGE SET Revision ec192ad43bb9e40fa2bf175526aefc32d37efcef by admin: (Fix build on linux (and fix test build)) change: edit src/ioslaves/trash/tests/CMakeLists.txt change: edit src/ioslaves/trash/kio_trash.cpp JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 52 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 21/21 (100%)FILES 272/341 (80%)CLASSES 272/341 (80%)LINE 29415/51470 (57%)CONDITIONAL 16144/38601 (42%) By packages autotests FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7860/8184 (96%)CONDITIONAL 4399/8600 (51%) autotests.http FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 (100%)CONDITIONAL 200/336 (60%) autotests.kcookiejar FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 60/90 (67%) src.core FILES 96/116 (83%)CLASSES 96/116 (83%)LINE 7887/14158 (56%)CONDITIONAL 4322/9231 (47%) src.core.kssl FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 3/6 (50%) src.filewidgets FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3408/7559 (45%)CONDITIONAL 1262/4381 (29%) src.gui FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 46/72 (64%) src.ioslaves.file FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 443/842 (53%)CONDITIONAL 329/745 (44%) src.ioslaves.http FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1755/3780 (46%)CONDITIONAL 1252/3460 (36%) src.ioslaves.http.kcookiejar FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 607/839 (72%) src.ioslaves.trash FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 715/1139 (63%)CONDITIONAL 411/833 (49%) src.ioslaves.trash.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 445/936 (48%) src.kioslave FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 5/10 (50%) src.kntlm FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 111/138 (80%) src.kpasswdserver FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 280/580 (48%) src.kpasswdserver.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 144/256 (56%) src.urifilters.fixhost FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 36/54 (67%) src.urifilters.ikws FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 150/546 (27%) src.urifilters.localdomain FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 16/26 (62%) src.urifilters.shorturi FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 332/412 (81%) src.widgets FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3607/10969 (33%)CONDITIONAL 1734/7050 (25%)
Re: Review Request 129455: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129455/ --- (Updated Dec. 6, 2016, 1:04 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Chusslove Illich. Changes --- Submitted with commit 3a4ae5c6d620ebd680cb3086c380047a88da9452 by Tobias C. Berner to branch master. Repository: ki18n Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml 7f8beac45ec17f0074352bb9b23065737964c994 Diff: https://git.reviewboard.kde.org/r/129455/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129472: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129472/ --- (Updated Dec. 6, 2016, 7:06 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Alex Merry. Changes --- Submitted with commit 8a8ef69b78c158297b1242c2efd4823b18c2 by Tobias C. Berner to branch master. Repository: kimageformats Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml 51df9e4eeaef93b9c192b833bd83a5319b789abd Diff: https://git.reviewboard.kde.org/r/129472/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129474: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129474/ --- (Updated Dec. 6, 2016, 6:07 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 3c8cf7525811fe1b1334febc08d85c2849176bdc by Tobias C. Berner to branch master. Repository: knotifications Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml d8936061c95ca4ae3fb337393448a62a34f39085 Diff: https://git.reviewboard.kde.org/r/129474/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129473: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129473/ --- (Updated Dec. 6, 2016, 6:09 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 6f32901aa5bcff9d2290fa72fec5706b8d6d827e by Tobias C. Berner to branch master. Repository: kjobwidgets Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml 6a6b57861f35f6e1fd47190d1aafdde945fde94b Diff: https://git.reviewboard.kde.org/r/129473/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129477: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129477/ --- (Updated Dec. 6, 2016, 6:10 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit cea0c062f255ff948618aef1c90d2cac887696ab by Tobias C. Berner to branch master. Repository: kunitconversion Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml 5a217b6543f64c495e417c8fa7e97ed4076b7d1c Diff: https://git.reviewboard.kde.org/r/129477/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129476: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129476/ --- (Updated Dec. 6, 2016, 7:09 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit c9a9d2cd6f1a029d55f661dd20e2324ad1404d34 by Tobias C. Berner to branch master. Repository: kpty Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml 91a99dc378951b1f7deee751b723583c066d5e63 Diff: https://git.reviewboard.kde.org/r/129476/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129479: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129479/ --- (Updated Dec. 6, 2016, 6:13 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 211850fe900de4d8db9af8c6988ed19dfcd55ed4 by Tobias C. Berner to branch master. Repository: kactivities Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml 7eff57110ad1bbbf6f881b66ba6e0c3e01aeda70 Diff: https://git.reviewboard.kde.org/r/129479/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129480: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129480/ --- (Updated Dec. 6, 2016, 7:13 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit d8e0b33cc817718a0626cf3b3a6729907cfdf171 by Tobias C. Berner to branch master. Repository: kbookmarks Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml c8fab35daf23ea62277a0aa94913ac064eec4432 Diff: https://git.reviewboard.kde.org/r/129480/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129482: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129482/ --- (Updated Dec. 6, 2016, 6:14 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 1089f6d3918e7ade1aa520e69f3dc2ea40377098 by Tobias C. Berner to branch master. Repository: kconfigwidgets Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml 48f19c321b958b80a16ea1e45a7e234f63fd2e97 Diff: https://git.reviewboard.kde.org/r/129482/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129483: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129483/ --- (Updated Dec. 6, 2016, 7:14 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit fdcdddfbbfd482b114546b730c35362070b19eb5 by Tobias C. Berner to branch master. Repository: kdeclarative Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml 7e797c54752a4402b7dc9f947388f1ea853adfc3 Diff: https://git.reviewboard.kde.org/r/129483/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129484: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129484/ --- (Updated Dec. 6, 2016, 6:15 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 0f17a3178520834b2edc8f741d8580d1edd028bf by Tobias C. Berner to branch master. Repository: kded Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml fca69ed7dbb2b9548c81e87b82c0a6b73165b3e3 Diff: https://git.reviewboard.kde.org/r/129484/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129485: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129485/ --- (Updated Dec. 6, 2016, 7:15 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Alex Merry. Changes --- Submitted with commit 38d048898b91db137b47a99ac9cdb32d31366b1a by Tobias C. Berner to branch master. Repository: kdesignerplugin Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml 54bd7cbe8f6630fcbd70c2579d1f00b864e54657 Diff: https://git.reviewboard.kde.org/r/129485/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129487: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129487/ --- (Updated Dec. 6, 2016, 1:16 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit fc0b09a7eaf8bfe73446b86a4bee605b193a5d4f by Tobias C. Berner to branch master. Repository: kdewebkit Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml f0ebde916f835cb45053259221535b78527fb54f Diff: https://git.reviewboard.kde.org/r/129487/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129489: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129489/ --- (Updated Dec. 6, 2016, 7:17 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 094eefbc74f9d000b42d442acc5f7b8f0b34882a by Tobias C. Berner to branch master. Repository: kglobalaccel Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml 82d2fc324adf5e2994e3cc533cb6b95dcf5fa59f Diff: https://git.reviewboard.kde.org/r/129489/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129491: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129491/ --- (Updated Dec. 6, 2016, 6:18 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 8cee422f4081b4ea1755260e76d171e389f19c23 by Tobias C. Berner to branch master. Repository: kinit Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml 46f0dbbc08b005e8717951055299f5f3aad3e6f2 Diff: https://git.reviewboard.kde.org/r/129491/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129486: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129486/ --- (Updated Dec. 6, 2016, 7:18 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 8db59b38eb4c90c3da60cd0cad4733fc6719a6ad by Tobias C. Berner to branch master. Repository: kdesu Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml ea48a5d159e2568fc981e9774845b30002e87a8e Diff: https://git.reviewboard.kde.org/r/129486/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129481: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129481/ --- (Updated Dec. 6, 2016, 6:19 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit c5ca3ddd69e6e03801bf57f5b80b7cc3f547838b by Tobias C. Berner to branch master. Repository: kcmutils Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml 3f2de5402100d564240e059e74d68fb90bd3ca13 Diff: https://git.reviewboard.kde.org/r/129481/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129488: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129488/ --- (Updated Dec. 6, 2016, 6:19 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit ec1843feabcbb9ad12b679a29166fc3d9f9f5fe4 by Tobias C. Berner to branch master. Repository: kemoticons Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml 3130fbe99dd9a56e9f75377cb89df595b0bec501 Diff: https://git.reviewboard.kde.org/r/129488/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129494: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129494/ --- (Updated Dec. 6, 2016, 6:20 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 61acb1aa70643d448a6a9fa2214851147c24b84f by Tobias C. Berner to branch master. Repository: kparts Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml 36d951de8ba539625a725cd7c358fe7166382d6a Diff: https://git.reviewboard.kde.org/r/129494/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129493: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129493/ --- (Updated Dec. 6, 2016, 6:21 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Jeremy Whiting. Changes --- Submitted with commit bf40b75a7f8e5917178636da737de483cdc14a39 by Tobias C. Berner to branch master. Repository: knewstuff Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml c441cb317fb6a1e15801609cb694e9257247bdeb Diff: https://git.reviewboard.kde.org/r/129493/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129492: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129492/ --- (Updated Dec. 6, 2016, 6:21 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 99a63c581d41fc0b2326268a05de28a50d3219fc by Tobias C. Berner to branch master. Repository: kio Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml 1146fd87d5d8436d4a9c94b9e328bbfd9d589603 Diff: https://git.reviewboard.kde.org/r/129492/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129496: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129496/ --- (Updated Dec. 6, 2016, 7:22 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 0117892e6fea473585f03b0ec6fee5390d8c5b81 by Tobias C. Berner to branch master. Repository: krunner Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml 8f1f788c7207d05c4f3a43c85a24cf6541ae6629 Diff: https://git.reviewboard.kde.org/r/129496/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129500: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129500/ --- (Updated Dec. 6, 2016, 7:23 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit a1f166528210944962498cdbcf79d7d8452e8084 by Tobias C. Berner to branch master. Repository: kwallet Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml 8fe10f0c40e18207ff406d48318cf4a949a7eeb0 Diff: https://git.reviewboard.kde.org/r/129500/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129469: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129469/ --- (Updated Dec. 6, 2016, 6:24 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit b67a4bc02d5cf87857c8489d57fc6bdc7bafcf80 by Tobias C. Berner to branch master. Repository: kcrash Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml e448a5bc3f12064a31bf6ae850de1357e6f9dbe4 Diff: https://git.reviewboard.kde.org/r/129469/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129497: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129497/ --- (Updated Dec. 6, 2016, 6:25 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 474dad5bbb6b1fe65fe10bac9e1baa4225dc2800 by Tobias C. Berner to branch master. Repository: kservice Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml 38bf1eeaac32d3af669a72f4bb8243087d62e2ac Diff: https://git.reviewboard.kde.org/r/129497/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129501: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129501/ --- (Updated Dec. 6, 2016, 7:26 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit dcb0073bef680249234cae762bbd34a257e0d1eb by Tobias C. Berner to branch master. Repository: kxmlgui Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml 6c0c6ece2084961be57f5a8adbd854c912bd2b1e Diff: https://git.reviewboard.kde.org/r/129501/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129468: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129468/ --- (Updated Dec. 6, 2016, 6:26 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 45a822b0684d75f4aeee250d8ad185946c26cb1c by Tobias C. Berner to branch master. Repository: kcompletion Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml 476b47955e76bd51586af8065a37650e2191448f Diff: https://git.reviewboard.kde.org/r/129468/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129505: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129505/ --- (Updated Dec. 6, 2016, 7:27 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 81991e0511c474b8ea4ae71c6dfa2bb92998b489 by Tobias C. Berner to branch master. Repository: kdelibs4support Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml c53316a5d1b1c42ea39dadd9d0638838e1ed62bd Diff: https://git.reviewboard.kde.org/r/129505/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129506: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129506/ --- (Updated Dec. 6, 2016, 6:28 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. Changes --- Submitted with commit 93e97d197a843b6398135580b40e4360e3b653e7 by Tobias C. Berner to branch master. Repository: khtml Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml 03c4ff4e1cbd6581aac3694e79e89a0e2d08f2ea Diff: https://git.reviewboard.kde.org/r/129506/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129507: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129507/ --- (Updated Dec. 6, 2016, 7:28 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit e990fa735279ac4d3771e86ec2d5c810ea86c764 by Tobias C. Berner to branch master. Repository: kjs Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml 084ae58b15a645f63d6d6b16c277e798bebe2c6c Diff: https://git.reviewboard.kde.org/r/129507/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129508: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129508/ --- (Updated Dec. 6, 2016, 6:29 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 171d4518a8e73b845df6159141a16d0174a75145 by Tobias C. Berner to branch master. Repository: kjsembed Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml bbc0f724c072fdc7e24ca3693514aead60ce345d Diff: https://git.reviewboard.kde.org/r/129508/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129449: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129449/ --- (Updated Dec. 6, 2016, 6:29 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 8e0a5603642282eb386437b60ac393da229ceb5e by Tobias C. Berner to branch master. Repository: kcodecs Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml 06bd3d1f3595aa622e1aee10fb077c791b30291a Diff: https://git.reviewboard.kde.org/r/129449/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129467: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129467/ --- (Updated Dec. 6, 2016, 6:30 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 4838bf28e82dde4d8bfd09c540827de8d9663a2e by Tobias C. Berner to branch master. Repository: kauth Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml 1490a04efb89157c8657f523e5c983f2123303d9 Diff: https://git.reviewboard.kde.org/r/129467/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129452: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129452/ --- (Updated Dec. 6, 2016, 7:30 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 0dee098e158526f53bc640460b736f2e81469c05 by Tobias C. Berner to branch master. Repository: kdbusaddons Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml 76578caceb9a5df025bbfa17c7187602f6abbc57 Diff: https://git.reviewboard.kde.org/r/129452/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129509: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129509/ --- (Updated Dec. 6, 2016, 1:31 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Alex Merry. Changes --- Submitted with commit 1ecdc89e6dd37b145dd03c1dd477cf66fed97f1f by Tobias C. Berner to branch master. Repository: kmediaplayer Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml ebabf210718326a15287e7e2886982bd5d0181df Diff: https://git.reviewboard.kde.org/r/129509/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129504: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129504/ --- (Updated Dec. 6, 2016, 6:32 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit c8e4bf77022bc65caf6dec6d89f813277b601349 by Tobias C. Berner to branch master. Repository: frameworkintegration Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml 55f1d32974b7795a931819abe49cebfef5ac56ad Diff: https://git.reviewboard.kde.org/r/129504/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129456: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129456/ --- (Updated Dec. 6, 2016, 6:33 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 0ff6b51747cee91a521d2817b483981914359815 by Tobias C. Berner to branch master. Repository: kidletime Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml 163d68b25a2e6449b428dd04fc6113a4027ab324 Diff: https://git.reviewboard.kde.org/r/129456/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129454: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129454/ --- (Updated Dec. 6, 2016, 7:33 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit ebecae8dae9c2a48a5be08a1265baa3504f315e0 by Tobias C. Berner to branch master. Repository: kguiaddons Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml e1c5bb80ab933490f085c4a50e3788df8bd01f80 Diff: https://git.reviewboard.kde.org/r/129454/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129459: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129459/ --- (Updated Dec. 6, 2016, 6:34 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Christoph Feck. Changes --- Submitted with commit 5bd1d4c36dc6403012815eb14573056fb907fcb2 by Tobias C. Berner to branch master. Repository: kplotting Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml 079f303c876ad66a6ae0db4a1de16ca3bd6ff667 Diff: https://git.reviewboard.kde.org/r/129459/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129462: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129462/ --- (Updated Dec. 6, 2016, 6:35 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit e993b77c503bccf2ab68dc8a61abb633c6fcb8a0 by Tobias C. Berner to branch master. Repository: kwindowsystem Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml 99d4d431ce3a46c7cf95a348138e4172d6361af0 Diff: https://git.reviewboard.kde.org/r/129462/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129463: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129463/ --- (Updated Dec. 6, 2016, 7:36 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 045358b386e4c2553ba585ad0dbd8c4859636d1b by Tobias C. Berner to branch master. Repository: oxygen-icons5 Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml be294988765678c70b449b31795458641cf22c5c Diff: https://git.reviewboard.kde.org/r/129463/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129457: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129457/ --- (Updated Dec. 6, 2016, 1:36 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 26d5be8923775c305d5ea2db12dc73ced952f185 by Tobias C. Berner to branch master. Repository: kitemmodels Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml debaa8f178d3023c4bbcf8f595bc2369e415aac2 Diff: https://git.reviewboard.kde.org/r/129457/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129465: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129465/ --- (Updated Dec. 6, 2016, 6:37 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. Changes --- Submitted with commit f3a3314d9f0a744113a2fb138413720d51e06879 by Tobias C. Berner to branch master. Repository: sonnet Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml f3bf3e3589931e231b80c9375be470fa9179817a Diff: https://git.reviewboard.kde.org/r/129465/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129461: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129461/ --- (Updated Dec. 6, 2016, 6:38 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Christoph Feck. Changes --- Submitted with commit 53870f4efb9d07a143d625ea2e86b1f174814c6f by Tobias C. Berner to branch master. Repository: kwidgetsaddons Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml c640f6009b58f9cc70a4ac8ccdd548214ed9c345 Diff: https://git.reviewboard.kde.org/r/129461/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129458: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129458/ --- (Updated Dec. 6, 2016, 7:38 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit beccc51af2b68c6e24a3506ead6e704e5247c611 by Tobias C. Berner to branch master. Repository: kitemviews Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml b70d673ce95d75ecc52b3d5187c014347492ad3a Diff: https://git.reviewboard.kde.org/r/129458/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129464: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129464/ --- (Updated Dec. 6, 2016, 7:39 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit ed02898832518de144e9e0a6716702eb538402ec by Tobias C. Berner to branch master. Repository: solid Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml d6852b6b4e289ec49e65f65c28f69c7ed6abb747 Diff: https://git.reviewboard.kde.org/r/129464/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129466: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129466/ --- (Updated Dec. 6, 2016, 6:39 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 8bb3819bf07503095d462e484a691cefef59ebe3 by Tobias C. Berner to branch master. Repository: threadweaver Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml a12c7c8c9297b54b6d8584f27522832031a77f1f Diff: https://git.reviewboard.kde.org/r/129466/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129446: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129446/ --- (Updated Dec. 6, 2016, 7:40 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit e48843a4f317b45f2e60835d20982fdf5390dae8 by Tobias C. Berner to branch master. Repository: karchive Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml 8cdefddb9276a5384c705984b835cfb0c05db829 Diff: https://git.reviewboard.kde.org/r/129446/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129444: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129444/ --- (Updated Dec. 6, 2016, 6:40 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 620bc7a94bf9ee165e5706c67a1bb774ac30132b by Tobias C. Berner to branch master. Repository: breeze-icons Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml a64ec8b1e1a070563c8f5b962bf5587aa3ce0fa2 Diff: https://git.reviewboard.kde.org/r/129444/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129443: Add FreeBSD to metainfo.yaml.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129443/ --- (Updated Dec. 6, 2016, 7:41 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit d5dc540f63d8a12e26be09d8d2b69a48882d6e8b by Tobias C. Berner to branch master. Repository: attica Description --- Add FreeBSD to metainfo.yaml. Diffs - metainfo.yaml cba56336ad11e6d2168a87f45a57c28928ef55dc Diff: https://git.reviewboard.kde.org/r/129443/diff/ Testing --- Thanks, Tobias Berner
Re: Review Request 129281: [Konsole] Render text at primary font's baseline
> On Nov. 9, 2016, 1:22 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > looks good to me, but I think hindenburg should ack it (might want to add > > him to reviewers) > > Christoph Feck wrote: > Pretty sure "konsole" reviewers group includes the maintainer, but I > would actually prefer feedback from someone using non-Western characters in > Konsole. > > Christoph Feck wrote: > Ping? Should I just commit it to 16.12 branch so that people can give > feedback? > > Kurt Hindenburg wrote: > I'd rather not use 16.12 to test at this late time - how about master? okey, will commit it to master. - Christoph --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129281/#review100745 --- On Nov. 6, 2016, 9:40 p.m., Christoph Feck wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129281/ > --- > > (Updated Nov. 6, 2016, 9:40 p.m.) > > > Review request for KDE Frameworks and Konsole. > > > Bugs: 371687 > http://bugs.kde.org/show_bug.cgi?id=371687 > > > Repository: konsole > > > Description > --- > > When Konsole draws a line of text, it first computes the rectangle of the > line that the text covers (taking into account cells width and height), then > passes this rectangle to the drawText(QRect, flags, text) call. > > Qt detects if the selected font does not offer all characters in the text, > and substitutes individual characters with a different font. Due to designer > choices, the same font point size does not lead to same pixel height (or > ascent size) in all fonts, so the substituted characters might be larger than > the characters from the primary font. > > Using a rectangle causes Qt to position glyphs relative to the bounding box > of the text, instead of anchored to the baseline. > > This patch uses a pixel position instead of a rectangle to draw the text, > taking into account only the baseline of the primary font. > > I have added all "frameworks" developers to increase possible test coverage. > > > Diffs > - > > src/TerminalDisplay.cpp 39a8b84 > > Diff: https://git.reviewboard.kde.org/r/129281/diff/ > > > Testing > --- > > On my system, lines with substituted Unicode characters are no longer shifted > away from the baseline, and therefore do not appear cropped. > > Further testing is needed, as there are many (equivalent, similar, or > different) bug reports about font rendering on different systems, see > https://bugs.kde.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=CONFIRMED&component=font&product=konsole > > > Thanks, > > Christoph Feck > >
