Re: Minimum required cmake version
On Sat, Dec 31, 2016 at 7:16 PM, Michael Pyne wrote: > On Sat, Dec 31, 2016 at 03:47:00PM +0100, Sven Brauch wrote: >> Hey, >> >> On 27/12/16 19:30, Aleix Pol wrote: >> > +1 on changing to 3.0. >> Thanks for your opinion on the matter. I also think we should just bump >> it, 3.0 is old enough -- as said it's even easily available on CentOS 6. >> >> Question is, should I change it on _all_ frameworks or just those using >> Q_GADGET (i.e. those which actually need cmake 3)? > > If we change the CMake requirement for one framework it should be > changed for them all. They are tested, released, and supported as a > unit even though they have separate tiers and could theoretically be put > together in a piecemeal fashion. > > There might also be an easy way to change it in extra-cmake-modules but > I think some of the buildsystem devs would know more about that. > > Regards, > - Michael Pyne +1 Aleix
[Differential] [Updated] D3912: kdoctools_install: match the full path for the program
ltoscano added a reviewer: Frameworks. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D3912 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ltoscano, #documentation, #frameworks
Review Request 129741: Add renaming capability to ioslaves
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129741/ --- Review request for KDE Frameworks, David Faure and Emmanuel Pescosta. Repository: kio Description --- An ioslave protocol might support moving files but not "renaming" them (rename here means "the F2 shortcut in filemanagers"). trash:/ is a good example. The new `renaming` field defaults to `moving`, so that we don't have to add renaming=true to every protocol file out there. Diffs - src/core/kfileitemlistproperties.h 2b4a5b33166513493e6499e6479a04965a895b57 src/core/kfileitemlistproperties.cpp 5c6e6bba693f8b9bfc942ff39bee5d24f159fd7f src/core/kprotocolinfo.cpp 0290c63b37a45a22995238f9cfcc11b8334d339c src/core/kprotocolinfo_p.h 8d05bd194fdaa7b7e7552e0d1d22bf16b28ffbc1 src/core/kprotocolmanager.h 13b8c0756f8e355b1ec84cdf1c44086f41fa05c5 src/core/kprotocolmanager.cpp 9a0a96fe749a11c66a22bb3eff62d0601e3b7b36 src/ioslaves/trash/tests/testtrash.cpp 67a6130e7c86af00e596dc439125c29eb74fc99f src/ioslaves/trash/trash.json d7dc03eb073c7bfdde3c7eebfbac144ad62964fe src/protocoltojson/main.cpp 0bf3c7062d076412c779f6cae25a98e1b2c61be4 Diff: https://git.reviewboard.kde.org/r/129741/diff/ Testing --- Using the new `supportsRenaming()` api from Dolphin, F2 in Trash is now disabled. More context in https://git.reviewboard.kde.org/r/129714 Thanks, Elvis Angelaccio
Review Request 129742: Add option FORCE_ENABLE_HUNSPELL
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129742/ --- Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. Repository: sonnet Description --- HUNSPELL is optional, but its cmake module depends on updates on each future hunspell release to be found. Each time that happens, the user build is potentially silently missing a feature, because up to now it can not be reliably enabled, only disabled. This was the least disruptive solution I could come up with. Diffs - CMakeLists.txt edac12f6cdc1fddc7f6b9df0baeb519a6c6502fb src/plugins/CMakeLists.txt 58b254c670e7e57202bbc9c889c86a48041a044e Diff: https://git.reviewboard.kde.org/r/129742/diff/ Testing --- Thanks, Andreas Sturmlechner
Re: Review Request 129648: New widget: tooltip that contains another widget
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129648/ --- (Updated Jan. 1, 2017, 4:56 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Ben Cooksley, Christoph Feck, and Martin Gräßlin. Changes --- Submitted with commit d0b80687769d0b33d4ec0f3f747383f5c28bc1d6 by Elvis Angelaccio to branch master. Repository: kwidgetsaddons Description --- This new widget is based on the KToolTip code that is duplicated across multiple products: at least Dolphin, systemsettings, kinfocenter, ktp-contact-list. Rationale: with a single class in frameworks, it will be possible to apply features/fixes only once. See for example the comments in https://phabricator.kde.org/D3112 A new feature that the old code doesn't have is the delayed hide: this makes it possible to actually use the widget shown in the tooltip. Diffs - autotests/CMakeLists.txt ffcce3a046ec98b07c4677578f6bc997de1ef16b autotests/ktooltipwidgettest.h PRE-CREATION autotests/ktooltipwidgettest.cpp PRE-CREATION src/CMakeLists.txt de0a8d965f1541d5ffeec93d1aa06600b0b9c138 src/ktooltipwidget.h PRE-CREATION src/ktooltipwidget.cpp PRE-CREATION tests/CMakeLists.txt fcb348b1ae9d4270468c3f9003c5ba5f3903db84 tests/ktooltipwidget_test.h PRE-CREATION tests/ktooltipwidget_test.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/129648/diff/ Testing --- Manual test works both in X11 and Wayland. Unit tests pass. Ported Dolphin locally to this new class, everything seems to work (and this will fix bug [#352276](https://bugs.kde.org/show_bug.cgi?id=352276) and [#371223](https://bugs.kde.org/show_bug.cgi?id=371223)). Thanks, Elvis Angelaccio
Re: Review Request 129648: New widget: tooltip that contains another widget
> On Jan. 1, 2017, 3:25 p.m., Martin Gräßlin wrote: > > Looks good to me. Using the transientParent's qscreen was what I meant. Thanks, I'm going to commit then. :) - Elvis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129648/#review101699 --- On Dec. 30, 2016, 10:27 a.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129648/ > --- > > (Updated Dec. 30, 2016, 10:27 a.m.) > > > Review request for KDE Frameworks, Ben Cooksley, Christoph Feck, and Martin > Gräßlin. > > > Repository: kwidgetsaddons > > > Description > --- > > This new widget is based on the KToolTip code that is duplicated across > multiple products: at least Dolphin, systemsettings, kinfocenter, > ktp-contact-list. > > Rationale: with a single class in frameworks, it will be possible to apply > features/fixes only once. See for example the comments in > https://phabricator.kde.org/D3112 > > A new feature that the old code doesn't have is the delayed hide: this makes > it possible to actually use the widget shown in the tooltip. > > > Diffs > - > > autotests/CMakeLists.txt ffcce3a046ec98b07c4677578f6bc997de1ef16b > autotests/ktooltipwidgettest.h PRE-CREATION > autotests/ktooltipwidgettest.cpp PRE-CREATION > src/CMakeLists.txt de0a8d965f1541d5ffeec93d1aa06600b0b9c138 > src/ktooltipwidget.h PRE-CREATION > src/ktooltipwidget.cpp PRE-CREATION > tests/CMakeLists.txt fcb348b1ae9d4270468c3f9003c5ba5f3903db84 > tests/ktooltipwidget_test.h PRE-CREATION > tests/ktooltipwidget_test.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/129648/diff/ > > > Testing > --- > > Manual test works both in X11 and Wayland. Unit tests pass. > > Ported Dolphin locally to this new class, everything seems to work (and this > will fix bug [#352276](https://bugs.kde.org/show_bug.cgi?id=352276) and > [#371223](https://bugs.kde.org/show_bug.cgi?id=371223)). > > > Thanks, > > Elvis Angelaccio > >
Re: Review Request 129648: New widget: tooltip that contains another widget
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129648/#review101699 --- Looks good to me. Using the transientParent's qscreen was what I meant. - Martin Gräßlin On Dec. 30, 2016, 11:27 a.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129648/ > --- > > (Updated Dec. 30, 2016, 11:27 a.m.) > > > Review request for KDE Frameworks, Ben Cooksley, Christoph Feck, and Martin > Gräßlin. > > > Repository: kwidgetsaddons > > > Description > --- > > This new widget is based on the KToolTip code that is duplicated across > multiple products: at least Dolphin, systemsettings, kinfocenter, > ktp-contact-list. > > Rationale: with a single class in frameworks, it will be possible to apply > features/fixes only once. See for example the comments in > https://phabricator.kde.org/D3112 > > A new feature that the old code doesn't have is the delayed hide: this makes > it possible to actually use the widget shown in the tooltip. > > > Diffs > - > > autotests/CMakeLists.txt ffcce3a046ec98b07c4677578f6bc997de1ef16b > autotests/ktooltipwidgettest.h PRE-CREATION > autotests/ktooltipwidgettest.cpp PRE-CREATION > src/CMakeLists.txt de0a8d965f1541d5ffeec93d1aa06600b0b9c138 > src/ktooltipwidget.h PRE-CREATION > src/ktooltipwidget.cpp PRE-CREATION > tests/CMakeLists.txt fcb348b1ae9d4270468c3f9003c5ba5f3903db84 > tests/ktooltipwidget_test.h PRE-CREATION > tests/ktooltipwidget_test.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/129648/diff/ > > > Testing > --- > > Manual test works both in X11 and Wayland. Unit tests pass. > > Ported Dolphin locally to this new class, everything seems to work (and this > will fix bug [#352276](https://bugs.kde.org/show_bug.cgi?id=352276) and > [#371223](https://bugs.kde.org/show_bug.cgi?id=371223)). > > > Thanks, > > Elvis Angelaccio > >
Re: Review Request 129737: [kio] Error when changing target of symlink in plasma folder view
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129737/ --- (Updated Jan. 1, 2017, 12:48 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks and David Faure. Bugs: 360487 https://bugs.kde.org/show_bug.cgi?id=360487 Repository: kio Description --- Use CopyJob::link instead of KIO::symlink in kpropertiesdialog when changing target of symlink. Fixes the said error (BUG 360487). Diffs - src/widgets/kpropertiesdialog.cpp 50ae563 Diff: https://git.reviewboard.kde.org/r/129737/diff/ Testing --- File Attachments Error message https://git.reviewboard.kde.org/media/uploaded/files/2017/01/01/b32cbf34-4232-4a7e-9cd7-fe4d30e2fc75__kio_error.png Thanks, Chinmoy Ranjan Pradhan
Re: Review Request 129737: [kio] Error when changing target of symlink in plasma folder view
> On Jan. 1, 2017, 11:02 a.m., David Faure wrote: > > I'd rather fix KIO::symlink, which is advertised to support Overwrite. > > > > Unittests and fix coming up. > > Chinmoy Ranjan Pradhan wrote: > Overwrite in KIO::symlink works fine. It's the 'desktop' protocol that > causes the error, so I used KIO::link which resolves desktop: correctly. I know. It was still a bug in the handling of symlink() for kio_desktop, fixed now in https://commits.kde.org/kio/7f2abde5cb036b8b500aaff45886368ca295e24f You can discard this workaround. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129737/#review101695 --- On Jan. 1, 2017, 8:55 a.m., Chinmoy Ranjan Pradhan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129737/ > --- > > (Updated Jan. 1, 2017, 8:55 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Bugs: 360487 > https://bugs.kde.org/show_bug.cgi?id=360487 > > > Repository: kio > > > Description > --- > > Use CopyJob::link instead of KIO::symlink in kpropertiesdialog when changing > target of symlink. > Fixes the said error (BUG 360487). > > > Diffs > - > > src/widgets/kpropertiesdialog.cpp 50ae563 > > Diff: https://git.reviewboard.kde.org/r/129737/diff/ > > > Testing > --- > > > File Attachments > > > Error message > > https://git.reviewboard.kde.org/media/uploaded/files/2017/01/01/b32cbf34-4232-4a7e-9cd7-fe4d30e2fc75__kio_error.png > > > Thanks, > > Chinmoy Ranjan Pradhan > >
Re: Review Request 129737: [kio] Error when changing target of symlink in plasma folder view
> On Jan. 1, 2017, 11:02 a.m., David Faure wrote: > > I'd rather fix KIO::symlink, which is advertised to support Overwrite. > > > > Unittests and fix coming up. Overwrite in KIO::symlink works fine. It's the 'desktop' protocol that causes the error, so I used KIO::link which resolves desktop: correctly. - Chinmoy Ranjan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129737/#review101695 --- On Jan. 1, 2017, 8:55 a.m., Chinmoy Ranjan Pradhan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129737/ > --- > > (Updated Jan. 1, 2017, 8:55 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Bugs: 360487 > https://bugs.kde.org/show_bug.cgi?id=360487 > > > Repository: kio > > > Description > --- > > Use CopyJob::link instead of KIO::symlink in kpropertiesdialog when changing > target of symlink. > Fixes the said error (BUG 360487). > > > Diffs > - > > src/widgets/kpropertiesdialog.cpp 50ae563 > > Diff: https://git.reviewboard.kde.org/r/129737/diff/ > > > Testing > --- > > > File Attachments > > > Error message > > https://git.reviewboard.kde.org/media/uploaded/files/2017/01/01/b32cbf34-4232-4a7e-9cd7-fe4d30e2fc75__kio_error.png > > > Thanks, > > Chinmoy Ranjan Pradhan > >
Re: Review Request 129665: [KStatusNotifierItem] Restore mnimized window as normal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129665/#review101696 --- ping - Anthony Fieroni On Дек. 18, 2016, 9:55 след обяд, Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129665/ > --- > > (Updated Дек. 18, 2016, 9:55 след обяд) > > > Review request for KDE Frameworks and Martin Gräßlin. > > > Repository: knotifications > > > Description > --- > > I think, we want minized window to be shown as normal when it's closed in > tray. Why we could want a window to be shown as minimized ? > > > Diffs > - > > src/kstatusnotifieritem.cpp 1cd5e00 > > Diff: https://git.reviewboard.kde.org/r/129665/diff/ > > > Testing > --- > > + Remove deprecated warnings > > > Thanks, > > Anthony Fieroni > >
Re: Review Request 129737: [kio] Error when changing target of symlink in plasma folder view
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129737/#review101695 --- I'd rather fix KIO::symlink, which is advertised to support Overwrite. Unittests and fix coming up. - David Faure On Jan. 1, 2017, 8:55 a.m., Chinmoy Ranjan Pradhan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129737/ > --- > > (Updated Jan. 1, 2017, 8:55 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Bugs: 360487 > https://bugs.kde.org/show_bug.cgi?id=360487 > > > Repository: kio > > > Description > --- > > Use CopyJob::link instead of KIO::symlink in kpropertiesdialog when changing > target of symlink. > Fixes the said error (BUG 360487). > > > Diffs > - > > src/widgets/kpropertiesdialog.cpp 50ae563 > > Diff: https://git.reviewboard.kde.org/r/129737/diff/ > > > Testing > --- > > > File Attachments > > > Error message > > https://git.reviewboard.kde.org/media/uploaded/files/2017/01/01/b32cbf34-4232-4a7e-9cd7-fe4d30e2fc75__kio_error.png > > > Thanks, > > Chinmoy Ranjan Pradhan > >
Re: Review Request 129720: [ExtractorCollection] Use mimetype inheritance to return plugins
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129720/#review101693 --- ping - Anthony Fieroni On Дек. 29, 2016, 9:17 преди обяд, Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129720/ > --- > > (Updated Дек. 29, 2016, 9:17 преди обяд) > > > Review request for KDE Frameworks. > > > Repository: kfilemetadata > > > Description > --- > > startsWith is a weak precondition + guard for duplicate plugin > > > Diffs > - > > src/extractorcollection.cpp d0fbbea > > Diff: https://git.reviewboard.kde.org/r/129720/diff/ > > > Testing > --- > > > Thanks, > > Anthony Fieroni > >
Review Request 129737: [kio] Error when changing target of symlink in plasma folder view
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129737/ --- Review request for KDE Frameworks and David Faure. Bugs: 360487 https://bugs.kde.org/show_bug.cgi?id=360487 Repository: kio Description --- Use CopyJob::link instead of KIO::symlink in kpropertiesdialog when changing target of symlink. Fixes the said error (BUG 360487). Diffs - src/widgets/kpropertiesdialog.cpp 50ae563 Diff: https://git.reviewboard.kde.org/r/129737/diff/ Testing --- File Attachments Error message https://git.reviewboard.kde.org/media/uploaded/files/2017/01/01/b32cbf34-4232-4a7e-9cd7-fe4d30e2fc75__kio_error.png Thanks, Chinmoy Ranjan Pradhan
