date:20170113


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/375/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 14 Jan 2017 00:32:43 +
Build duration: 24 min

CHANGE SET
Revision 0915c1e4eda4d4f4b302000a452ec40ac4d13c77 by Albert Astals Cid: 
(Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG)
  change: edit src/widgets/kfile.h
  change: edit src/widgets/kfileitemdelegate.h


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 
53 test(s)Failed: TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 274/343 (80%)CLASSES 274/343 (80%)LINE 29571/51590 
(57%)CONDITIONAL 16232/38735 (42%)

By packages
  
autotests
FILES 67/67 (100%)CLASSES 67/67 (100%)LINE 7920/8245 
(96%)CONDITIONAL 4433/8664 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 7910/14177 
(56%)CONDITIONAL 4339/9259 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3450/7559 
(46%)CONDITIONAL 1282/4381 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 443/842 (53%)CONDITIONAL 
329/745 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1755/3780 
(46%)CONDITIONAL 1252/3460 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 
607/839 (72%)
src.ioslaves.trash
FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 715/1139 
(63%)CONDITIONAL 411/833 (49%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 
150/546 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 28/29 (97%)CONDITIONAL 
21/26 (81%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 
332/412 (81%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3631/11009 
(33%)CONDITIONAL 1746/7092 (25%)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 379 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/379/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 14 Jan 2017 00:23:03 +
Build duration: 6 min 21 sec

CHANGE SET
Revision 0915c1e4eda4d4f4b302000a452ec40ac4d13c77 by Albert Astals Cid: 
(Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG)
  change: edit src/widgets/kfileitemdelegate.h
  change: edit src/widgets/kfile.h


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 
53 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 274/343 (80%)CLASSES 274/343 (80%)LINE 29546/51590 
(57%)CONDITIONAL 16216/38735 (42%)

By packages
  
autotests
FILES 67/67 (100%)CLASSES 67/67 (100%)LINE 7918/8245 
(96%)CONDITIONAL 4430/8664 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 7884/14177 
(56%)CONDITIONAL 4328/9259 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3454/7559 
(46%)CONDITIONAL 1281/4381 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 443/842 (53%)CONDITIONAL 
329/745 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1763/3780 
(47%)CONDITIONAL 1261/3460 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 
607/839 (72%)
src.ioslaves.trash
FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 705/1139 
(62%)CONDITIONAL 402/833 (48%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 
150/546 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 
16/26 (62%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 
332/412 (81%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3639/11009 
(33%)CONDITIONAL 1748/7092 (25%)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 379 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/379/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 14 Jan 2017 00:23:03 +
Build duration: 6 min 21 sec

CHANGE SET
Revision 0915c1e4eda4d4f4b302000a452ec40ac4d13c77 by Albert Astals Cid: 
(Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG)
  change: edit src/widgets/kfileitemdelegate.h
  change: edit src/widgets/kfile.h


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 
53 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 274/343 (80%)CLASSES 274/343 (80%)LINE 29546/51590 
(57%)CONDITIONAL 16216/38735 (42%)

By packages
  
autotests
FILES 67/67 (100%)CLASSES 67/67 (100%)LINE 7918/8245 
(96%)CONDITIONAL 4430/8664 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 7884/14177 
(56%)CONDITIONAL 4328/9259 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3454/7559 
(46%)CONDITIONAL 1281/4381 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 443/842 (53%)CONDITIONAL 
329/745 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1763/3780 
(47%)CONDITIONAL 1261/3460 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 
607/839 (72%)
src.ioslaves.trash
FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 705/1139 
(62%)CONDITIONAL 402/833 (48%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 
150/546 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 
16/26 (62%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 
332/412 (81%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3639/11009 
(33%)CONDITIONAL 1748/7092 (25%)

Re: Review Request 129813: Q_ENUMS -> Q_ENUM


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129813/
---

(Updated Jan. 14, 2017, 12:34 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit a51d4bc8ea331c3798abc31d6c071a0251cf77f8 by Albert Astals 
Cid to branch master.


Repository: kactivities


Description
---

see summary


Diffs
-

  src/imports/activitymodel.h b52981f 

Diff: https://git.reviewboard.kde.org/r/129813/diff/


Testing
---


Thanks,

Albert Astals Cid

Re: Review Request 129814: Q_ENUMS -> Q_ENUM


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129814/
---

(Updated Jan. 14, 2017, 1:33 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 5f9b2ad2c82c2e1458bf2830193113b130e7f850 by Albert Astals 
Cid to branch master.


Repository: kcompletion


Description
---

See summary


Diffs
-

  src/kcompletion.h 89a37b6 

Diff: https://git.reviewboard.kde.org/r/129814/diff/


Testing
---


Thanks,

Albert Astals Cid

Re: Review Request 129815: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129815/
---

(Updated Jan. 14, 2017, 12:30 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 9c36563141e046680f09abee7d789e3fb30e72b5 by Albert Astals 
Cid to branch master.


Repository: kdeclarative


Description
---

See summary


Diffs
-

  src/qmlcontrols/kquickcontrols/private/keysequencehelper.h 323ecae 
  src/qmlcontrols/kquickcontrolsaddons/eventgenerator.h e2fe3b0 
  src/qmlcontrols/kquickcontrolsaddons/qiconitem.h 2e8c8df 
  src/qmlcontrols/kquickcontrolsaddons/qimageitem.h a36ce4a 
  src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.h db2e84d 
  src/quickaddons/configmodule.h 1b2596c 
  src/quickaddons/quickviewsharedengine.h d7bfa35 

Diff: https://git.reviewboard.kde.org/r/129815/diff/


Testing
---


Thanks,

Albert Astals Cid

Re: Review Request 129816: Q_FLAGS -> Q_FLAG


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129816/
---

(Updated Jan. 14, 2017, 12:27 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 8610d96245519807fcae0980a4aa672a6820f91f by Albert Astals 
Cid to branch master.


Repository: kdewebkit


Description
---

See summary


Diffs
-

  src/kwebpage.h 1768136 

Diff: https://git.reviewboard.kde.org/r/129816/diff/


Testing
---


Thanks,

Albert Astals Cid

Re: Review Request 129817: Q_ENUMS -> Q_ENUM, Q_FLAGS -> Q_FLAG and actually declare the flags


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129817/
---

(Updated Jan. 14, 2017, 12:25 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 92893c97798226927dce16478ea47a3a30a69f55 by Albert Astals 
Cid to branch master.


Repository: kglobalaccel


Description
---

See description


Diffs
-

  src/runtime/kglobalacceld.h 1d398cd 

Diff: https://git.reviewboard.kde.org/r/129817/diff/


Testing
---


Thanks,

Albert Astals Cid

Re: Review Request 129818: Q_ENUMS -> Q_ENUM


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129818/
---

(Updated Jan. 14, 2017, 1:23 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 43f210501d767a0950634ea146021dbcd8126ed8 by Albert Astals 
Cid to branch master.


Repository: kiconthemes


Description
---

See summary


Diffs
-

  src/kiconloader.h 255c22f 

Diff: https://git.reviewboard.kde.org/r/129818/diff/


Testing
---


Thanks,

Albert Astals Cid

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 378 - Failure!


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/378/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 14 Jan 2017 00:17:51 +
Build duration: 58 sec

CHANGE SET
No changes

Re: Review Request 129819: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129819/
---

(Updated Jan. 14, 2017, 12:21 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 0915c1e4eda4d4f4b302000a452ec40ac4d13c77 by Albert Astals 
Cid to branch master.


Repository: kio


Description
---

See summary


Diffs
-

  src/widgets/kfile.h 5d9619f 
  src/widgets/kfileitemdelegate.h 54d2823 

Diff: https://git.reviewboard.kde.org/r/129819/diff/


Testing
---


Thanks,

Albert Astals Cid

Re: Review Request 129820: Q_ENUMS -> Q_ENUM


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129820/
---

(Updated Jan. 14, 2017, 12:20 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 35cc31ae89e694e6b276251afadcef22b7bb70f4 by Albert Astals 
Cid to branch master.


Repository: knewstuff


Description
---

See summary


Diffs
-

  src/qtquick/quickitemsmodel.h 2577cd6 

Diff: https://git.reviewboard.kde.org/r/129820/diff/


Testing
---


Thanks,

Albert Astals Cid

Re: Review Request 129821: Q_ENUMS -> Q_ENUM


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129821/
---

(Updated Jan. 14, 2017, 1:18 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit e5c0c38fe142a50caa79118306131d253504907f by Albert Astals 
Cid to branch master.


Repository: knotifications


Description
---

See Summary


Diffs
-

  src/kstatusnotifieritem.h 07acb7b 

Diff: https://git.reviewboard.kde.org/r/129821/diff/


Testing
---


Thanks,

Albert Astals Cid

Re: Review Request 129822: Q_ENUMS -> Q_ENUM


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129822/
---

(Updated Jan. 14, 2017, 12:16 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit ce1c3963a1fc393d60cb95670cd66977a87567f9 by Albert Astals 
Cid to branch master.


Repository: kparts


Description
---

See summary


Diffs
-

  src/partmanager.h 0ab25b5 

Diff: https://git.reviewboard.kde.org/r/129822/diff/


Testing
---


Thanks,

Albert Astals Cid

Re: Review Request 129823: Q_ENUMS -> Q_ENUM


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129823/
---

(Updated Jan. 14, 2017, 12:14 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 3711698ad89835e0d2eab03893610998d174771c by Albert Astals 
Cid to branch master.


Repository: kpeople


Description
---

See summary


Diffs
-

  src/declarative/peopleqmlplugin.cpp 0eef804 
  src/match_p.h 3a8cba8 
  src/personsmodel.h 88c879a 

Diff: https://git.reviewboard.kde.org/r/129823/diff/


Testing
---


Thanks,

Albert Astals Cid

Jenkins-kde-ci: kxmlgui master kf5-qt5 » Linux,gcc - Build # 155 - Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kxmlgui%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/155/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 14 Jan 2017 00:10:46 +
Build duration: 1 min 33 sec

CHANGE SET
Revision 44dbfae044064e05b0a134a2c7ca586a770b3cd1 by Albert Astals Cid: 
(Q_FLAGS -> Q_FLAG)
  change: edit src/kaboutapplicationdialog.h
  change: edit src/kxmlguiwindow.h
  change: edit src/kkeysequencewidget.h


JUNIT RESULTS

Name: (root) Failed: 5 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 6 
test(s)Failed: TestSuite.kactioncategorytestFailed: 
TestSuite.kactioncollectiontestFailed: TestSuite.kmainwindow_unittestFailed: 
TestSuite.ktoolbar_unittestFailed: TestSuite.kxmlgui_unittest

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages

Re: Review Request 129824: Q_FLAGS -> Q_FLAG


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129824/
---

(Updated Jan. 14, 2017, 12:11 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit da6b5d67fcf1661c7d3e3bc472cac3edf3bd82c8 by Albert Astals 
Cid to branch master.


Repository: ktextwidgets


Description
---

See Summary


Diffs
-

  src/widgets/krichtextwidget.h cd451b5 

Diff: https://git.reviewboard.kde.org/r/129824/diff/


Testing
---


Thanks,

Albert Astals Cid

Re: Review Request 129825: Q_FLAGS -> Q_FLAG


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129825/
---

(Updated Jan. 14, 2017, 12:10 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 44dbfae044064e05b0a134a2c7ca586a770b3cd1 by Albert Astals 
Cid to branch master.


Repository: kxmlgui


Description
---

See summary


Diffs
-

  src/kaboutapplicationdialog.h fa28164 
  src/kkeysequencewidget.h aecab3f 
  src/kxmlguiwindow.h 11e8418 

Diff: https://git.reviewboard.kde.org/r/129825/diff/


Testing
---


Thanks,

Albert Astals Cid

Re: Review Request 129826: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129826/
---

(Updated Jan. 14, 2017, 12:08 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 5c46e329935e7038651fe87f2a765e6298c91bd4 by Albert Astals 
Cid to branch master.


Repository: plasma-framework


Description
---

See summary


Diffs
-

  src/declarativeimports/calendar/calendar.h e622fc5 
  src/declarativeimports/calendar/calendardata.h b8ee7b9 
  src/declarativeimports/core/framesvgitem.h dff3090 
  src/declarativeimports/plasmacomponents/enums.h c769067 
  src/plasma/framesvg.h dbb6b50 
  src/plasma/plasma.h 523e329 
  src/plasma/svg.h 9cbcc39 
  src/plasma/theme.h 5b4e849 
  src/plasmaquick/dialog.h fdb33b5 

Diff: https://git.reviewboard.kde.org/r/129826/diff/


Testing
---


Thanks,

Albert Astals Cid

Jenkins-kde-ci: baloo master stable-kf5-qt5 » Linux,gcc - Build # 402 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/baloo%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/402/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 13 Jan 2017 22:18:48 +
Build duration: 2 min 33 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 
39 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 12/12 (100%)FILES 111/144 (77%)CLASSES 111/144 (77%)LINE 5038/6911 
(73%)CONDITIONAL 2610/5176 (50%)

By packages
  
autotests.benchmarks
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 42/42 (100%)CONDITIONAL 
16/18 (89%)
autotests.integration
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 242/255 (95%)CONDITIONAL 
140/220 (64%)
autotests.unit.codecs
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 40/40 (100%)CONDITIONAL 
25/44 (57%)
autotests.unit.engine
FILES 17/17 (100%)CLASSES 17/17 (100%)LINE 723/723 
(100%)CONDITIONAL 380/722 (53%)
autotests.unit.file
FILES 11/11 (100%)CLASSES 11/11 (100%)LINE 791/809 
(98%)CONDITIONAL 441/864 (51%)
autotests.unit.lib
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 315/326 (97%)CONDITIONAL 
156/302 (52%)
src.codecs
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 120/138 (87%)CONDITIONAL 
32/42 (76%)
src.engine
FILES 38/39 (97%)CLASSES 38/39 (97%)LINE 1609/2040 
(79%)CONDITIONAL 796/1379 (58%)
src.file
FILES 17/44 (39%)CLASSES 17/44 (39%)LINE 685/1506 
(45%)CONDITIONAL 378/986 (38%)
src.file.extractor
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 20/29 (69%)CONDITIONAL 
7/12 (58%)
src.file.extractor.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 22/22 (100%)CONDITIONAL 
11/18 (61%)
src.lib
FILES 6/11 (55%)CLASSES 6/11 (55%)LINE 429/981 (44%)CONDITIONAL 
228/569 (40%)

Jenkins-kde-ci: baloo master stable-kf5-qt5 » Linux,gcc - Build # 402 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/baloo%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/402/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 13 Jan 2017 22:18:48 +
Build duration: 2 min 33 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 
39 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 12/12 (100%)FILES 111/144 (77%)CLASSES 111/144 (77%)LINE 5038/6911 
(73%)CONDITIONAL 2610/5176 (50%)

By packages
  
autotests.benchmarks
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 42/42 (100%)CONDITIONAL 
16/18 (89%)
autotests.integration
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 242/255 (95%)CONDITIONAL 
140/220 (64%)
autotests.unit.codecs
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 40/40 (100%)CONDITIONAL 
25/44 (57%)
autotests.unit.engine
FILES 17/17 (100%)CLASSES 17/17 (100%)LINE 723/723 
(100%)CONDITIONAL 380/722 (53%)
autotests.unit.file
FILES 11/11 (100%)CLASSES 11/11 (100%)LINE 791/809 
(98%)CONDITIONAL 441/864 (51%)
autotests.unit.lib
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 315/326 (97%)CONDITIONAL 
156/302 (52%)
src.codecs
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 120/138 (87%)CONDITIONAL 
32/42 (76%)
src.engine
FILES 38/39 (97%)CLASSES 38/39 (97%)LINE 1609/2040 
(79%)CONDITIONAL 796/1379 (58%)
src.file
FILES 17/44 (39%)CLASSES 17/44 (39%)LINE 685/1506 
(45%)CONDITIONAL 378/986 (38%)
src.file.extractor
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 20/29 (69%)CONDITIONAL 
7/12 (58%)
src.file.extractor.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 22/22 (100%)CONDITIONAL 
11/18 (61%)
src.lib
FILES 6/11 (55%)CLASSES 6/11 (55%)LINE 429/981 (44%)CONDITIONAL 
228/569 (40%)

Jenkins-kde-ci: baloo master stable-kf5-qt5 » Linux,gcc - Build # 401 - Failure!


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/baloo%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/401/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 13 Jan 2017 22:07:31 +
Build duration: 2 min 4 sec

CHANGE SET
No changes

Re: Review Request 129809: KFontRequester: Find the nearest match for a missing font

2017-01-13 Thread Alexander Volkov



> On Jan. 12, 2017, 9:08 p.m., Christoph Feck wrote:
> > src/kfontrequester.cpp, line 53
> > 
> >
> > Please check if it is possible to use QFont::lastResortFamily() or 
> > QFont::lastResortFont().
> 
> Alexander Volkov wrote:
> As I can see in the Qt 5 code, lastResortFamily() returns hard-coded 
> "helvetica" and lastResortFont() aborts the app by qFatal()
> 
> Christoph Feck wrote:
> ouch, that's not according to the documentation. Let's hope nobody 
> notices we are hard-coding another font name.

well, lastResortFamily() seems to be a better choice than hardcoded "fixed"


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129809/#review101970
---


On Jan. 13, 2017, 12:45 p.m., Alexander Volkov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129809/
> ---
> 
> (Updated Jan. 13, 2017, 12:45 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Bugs: 286260
> https://bugs.kde.org/show_bug.cgi?id=286260
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> If the font is missing, then try to find the nearest font
> family instead of just selecting the first family in the
> list.
> 
> BUG: 286260
> 
> 
> Diffs
> -
> 
>   src/kfontrequester.cpp 6cca672b0284265daacd428d8bca9cec08da8910 
> 
> Diff: https://git.reviewboard.kde.org/r/129809/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Volkov
> 
>

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 200 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/200/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 13 Jan 2017 20:58:40 +
Build duration: 5 min 28 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
11 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5491/8009 
(69%)CONDITIONAL 2984/6180 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1466/1554 
(94%)CONDITIONAL 900/1792 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1765/3045 
(58%)CONDITIONAL 764/1892 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2044/2797 
(73%)CONDITIONAL 1235/2068 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 200 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/200/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 13 Jan 2017 20:58:40 +
Build duration: 5 min 28 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
11 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5491/8009 
(69%)CONDITIONAL 2984/6180 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1466/1554 
(94%)CONDITIONAL 900/1792 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1765/3045 
(58%)CONDITIONAL 764/1892 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2044/2797 
(73%)CONDITIONAL 1235/2068 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

[Differential] [Request, 154 lines] D4130: Let KConfigDialogManager get a property's change signal from the metaObject

2017-01-13 Thread Friedrich W. H. Kossebau

kossebau created this revision.
kossebau added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  KConfigDialogManager was possibly designed when there was no way to
  access the change signal of properties. So maintaining the signals
  and properties to use in separate global user-accessable tables might
  have been done as there was no other option.
  
  But this has flaws:
  
  - prevents per-widget-instance settings
  - different libs & plugins might do conflicting settings
  - requires explicit setup
  
  With modern Qt metaobject API instead the change signal can be
  fetched and used automatically.
  
  For backward-compatibility in KF5 this will be only a new option,
  those global maps should be removed on next ABI breakage.

TEST PLAN
  Old and new tests do not fail.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  readChangeSignalFromMetaObject

REVISION DETAIL
  https://phabricator.kde.org/D4130

AFFECTED FILES
  autotests/kconfigdialog_unittest.cpp
  src/kconfigdialogmanager.cpp
  src/kconfigdialogmanager.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #frameworks

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 203 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/203/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 13 Jan 2017 20:18:38 +
Build duration: 1 min 53 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5483/8008 
(68%)CONDITIONAL 2967/6178 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1464/1554 
(94%)CONDITIONAL 893/1792 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1766/3045 
(58%)CONDITIONAL 761/1892 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2037/2796 
(73%)CONDITIONAL 1228/2066 (59%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 127 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/127/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Fri, 13 Jan 2017 20:06:54 +
Build duration: 1 min 58 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 
13 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/5 (80%)FILES 44/50 (88%)CLASSES 44/50 (88%)LINE 6811/9081 
(75%)CONDITIONAL 3806/7069 (54%)

By packages
  
autotests
FILES 15/15 (100%)CLASSES 15/15 (100%)LINE 2941/3011 
(98%)CONDITIONAL 1619/3115 (52%)
autotests.helper
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 7/10 (70%)CONDITIONAL 
3/6 (50%)
src
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 778/1434 
(54%)CONDITIONAL 317/710 (45%)
src.platforms.wayland
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/89 (0%)CONDITIONAL 0/2 (0%)
src.platforms.xcb
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 3085/4537 
(68%)CONDITIONAL 1867/3236 (58%)

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 127 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/127/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Fri, 13 Jan 2017 20:06:54 +
Build duration: 1 min 58 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 
13 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/5 (80%)FILES 44/50 (88%)CLASSES 44/50 (88%)LINE 6811/9081 
(75%)CONDITIONAL 3806/7069 (54%)

By packages
  
autotests
FILES 15/15 (100%)CLASSES 15/15 (100%)LINE 2941/3011 
(98%)CONDITIONAL 1619/3115 (52%)
autotests.helper
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 7/10 (70%)CONDITIONAL 
3/6 (50%)
src
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 778/1434 
(54%)CONDITIONAL 317/710 (45%)
src.platforms.wayland
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/89 (0%)CONDITIONAL 0/2 (0%)
src.platforms.xcb
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 3085/4537 
(68%)CONDITIONAL 1867/3236 (58%)

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 199 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/199/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 13 Jan 2017 20:06:48 +
Build duration: 1 min 52 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5482/8008 
(68%)CONDITIONAL 2968/6178 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1464/1554 
(94%)CONDITIONAL 895/1792 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1765/3045 
(58%)CONDITIONAL 761/1892 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2037/2796 
(73%)CONDITIONAL 1227/2066 (59%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Re: Review Request 129807: proposal: add ksvg2ico

2017-01-13 Thread René J . V . Bertin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129807/
---

(Updated Jan. 13, 2017, 9:21 p.m.)


Review request for KDE Frameworks, kdewin, Alex Merry, Christoph Feck, and 
Hannah von Reth.


Changes
---

CMake file cleanup and Description update.


Repository: kiconthemes


Description (updated)
---

Recently I committed a few changes to `ecm_add_app_icon` that make use of the 
fact that KIconThemes includes a `ksvg2icns` utility, making it possible to 
generate an application icon from an SVG file instead of from a series of PNG 
files. 

With the present patch I propose to add an updated and extensively rewritten 
version of the ageing `svg2ico` tool from the KDEWin project to KIconThemes. 
The goal is to have a proper and up-to-date tool to generate application icons 
from SVG on MS Windows too.
This new version (named `ksvg2ico` in line with `ksvg2icns`) is a standalone 
tool that combines SVG - PNG conversion with PNG - ICO conversion. More 
accurately: it renders SVG files to an internal bitmap and then saves those 
bitmaps (as BMP?) to the .ico file.

- it now handles sizes up to 256x256, in part thanks to syncing `QtIcoHandler` 
with the version from Qt 5.6 .
- for that it uses a private copy of that class, with the unused read support 
disabled. Using Qt's internal version through `QImageWriter` isn't possible 
because that class doesn't yet support writing multiple images to a single file.
- a `--rcfile` option is provided, copied from `png2ico`.
- the PNG files are still saved and are left for debugging when `--debug` is 
given.

I considered proposing it to KDEWin instead, but in the end I liked the idea 
better to provide icon conversion utilities for Mac and Windows with a 
framework, where they might also serve in a less KDE-centric context (and 
cross-platform development).


Diffs (updated)
-

  src/CMakeLists.txt efba9e6 
  src/tools/ksvg2ico/CMakeLists.txt PRE-CREATION 
  src/tools/ksvg2ico/ksvg2ico.cpp PRE-CREATION 
  src/tools/ksvg2ico/qicohandler.h PRE-CREATION 
  src/tools/ksvg2ico/qicohandler.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/129807/diff/


Testing (updated)
---

On Mac OS X 10.9 and Linux with Qt 5.7.1 and KF5 5.29.0 .


File Attachments


.ico file generated from sc-apps-calligrakarbon.svgz using ksvg2ico with 
Benkmann's png2ico
  
https://git.reviewboard.kde.org/media/uploaded/files/2017/01/11/aa0973dc-1be8-4d36-82dc-8f7baa053fee__apps-calligrakarbon.ico
.ico created by icotool from *-apps-calligrakarbon.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2017/01/12/3bbee1f5-6770-4d6e-847d-e32c7e5d3fe1__icotool-apps-calligrakarbon.png
ico file generated by the standalone ksvg2ico
  
https://git.reviewboard.kde.org/media/uploaded/files/2017/01/12/7b286997-3100-47d0-800e-acb56ee9c68f__apps-calligrakarbon.ico


Thanks,

René J.V. Bertin

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 202 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/202/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 13 Jan 2017 19:31:45 +
Build duration: 1 min 52 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5483/8008 
(68%)CONDITIONAL 2970/6178 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1464/1554 
(94%)CONDITIONAL 895/1792 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1766/3045 
(58%)CONDITIONAL 762/1892 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2037/2796 
(73%)CONDITIONAL 1228/2066 (59%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 126 - Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/126/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Fri, 13 Jan 2017 19:18:42 +
Build duration: 4 min 7 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 3 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
13 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: 
TestSuite.kwindowsystem-kwindowsystem_threadtestFailed: 
TestSuite.kwindowsystem-kwindowsystemx11test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/5 (80%)FILES 39/49 (80%)CLASSES 39/49 (80%)LINE 5651/8634 
(65%)CONDITIONAL 3071/6581 (47%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 2394/2564 
(93%)CONDITIONAL 1284/2627 (49%)
autotests.helper
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 7/10 (70%)CONDITIONAL 
3/6 (50%)
src
FILES 12/16 (75%)CLASSES 12/16 (75%)LINE 603/1434 
(42%)CONDITIONAL 289/710 (41%)
src.platforms.wayland
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/89 (0%)CONDITIONAL 0/2 (0%)
src.platforms.xcb
FILES 12/16 (75%)CLASSES 12/16 (75%)LINE 2647/4537 
(58%)CONDITIONAL 1495/3236 (46%)

Re: Review Request 129809: KFontRequester: Find the nearest match for a missing font

2017-01-13 Thread Christoph Feck



> On Jan. 12, 2017, 7:08 p.m., Christoph Feck wrote:
> > src/kfontrequester.cpp, line 53
> > 
> >
> > Please check if it is possible to use QFont::lastResortFamily() or 
> > QFont::lastResortFont().
> 
> Alexander Volkov wrote:
> As I can see in the Qt 5 code, lastResortFamily() returns hard-coded 
> "helvetica" and lastResortFont() aborts the app by qFatal()

ouch, that's not according to the documentation. Let's hope nobody notices we 
are hard-coding another font name.


- Christoph


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129809/#review101970
---


On Jan. 13, 2017, 10:45 a.m., Alexander Volkov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129809/
> ---
> 
> (Updated Jan. 13, 2017, 10:45 a.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Bugs: 286260
> https://bugs.kde.org/show_bug.cgi?id=286260
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> If the font is missing, then try to find the nearest font
> family instead of just selecting the first family in the
> list.
> 
> BUG: 286260
> 
> 
> Diffs
> -
> 
>   src/kfontrequester.cpp 6cca672b0284265daacd428d8bca9cec08da8910 
> 
> Diff: https://git.reviewboard.kde.org/r/129809/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Volkov
> 
>

Re: Review Request 129809: KFontRequester: Find the nearest match for a missing font

2017-01-13 Thread Christoph Feck


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129809/#review102000
---




src/kfontrequester.cpp (line 51)


if (...) {
}

We do not use Qt's coding style :)


- Christoph Feck


On Jan. 13, 2017, 10:45 a.m., Alexander Volkov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129809/
> ---
> 
> (Updated Jan. 13, 2017, 10:45 a.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Bugs: 286260
> https://bugs.kde.org/show_bug.cgi?id=286260
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> If the font is missing, then try to find the nearest font
> family instead of just selecting the first family in the
> list.
> 
> BUG: 286260
> 
> 
> Diffs
> -
> 
>   src/kfontrequester.cpp 6cca672b0284265daacd428d8bca9cec08da8910 
> 
> Diff: https://git.reviewboard.kde.org/r/129809/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Volkov
> 
>

Re: Review Request 129760: Fixup handling of KFontUtils::adaptFontSize's flags' default value.

2017-01-13 Thread Stephen Kelly



> On Jan. 5, 2017, 10:56 p.m., Stephen Kelly wrote:
> > I've added the change to the unit test. It already passes, so it's not 
> > clear to me what else is needed from this review request.
> 
> Shaheed Haque wrote:
> What version of SIP compiler and C++ compiler are you using? I'm on:
> 
> $ sip -V
> 4.18.1
> $ g++ --version
> g++ (Ubuntu 6.2.0-5ubuntu12) 6.2.0 20161005
> Copyright (C) 2016 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions.  There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR 
> PURPOSE.
> 
> In any case, unless the change breaks thing for you, I would prefer to 
> merge the complete change as it is definitely needed here.
> 
> Stephen Kelly wrote:
> I have
> 
> $ sip -V
> 4.17
> $ g++ --version
> g++ (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
> Copyright (C) 2015 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions.  There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR 
> PURPOSE.
> 
> $ cat /etc/issue
> Ubuntu 16.04.1 LTS \n \l
> 
> 
> Can you ensure that when you test this that you are using the clean 
> master branch of ECM and the master branch of KGuiAddons? If you have 
> 
>  https://git.reviewboard.kde.org/r/129759/
>  
> applied or any other patches, that could affect what you get when you run 
> the test.
> 
> Shaheed Haque wrote:
> As per my reviewboard markings, this change depends on '759. The point is 
> that without '759, the SIP compiler bails out before this issue can be seen. 
> So the real question is why/how you were able to manage without '759...I 
> would guess that the SIP compiler version delta explains this.

Please see https://bugs.kde.org/show_bug.cgi?id=374801 and the commits 
associated with it. 

In particular: your compiles were failing, but bindings were being created 
anyway, which mostly worked for you with the exception of this enum issue. This 
enum issue failed because it relies on being able to parse the QFlags properly. 
Your compilations were failing because you are using Qt 5.7 or later which 
requires -std=c++11 or later. That was not being added to the flags when 
parsing the headers with libclang. ECM commit 
8aa6843404f9c6faef66cb9c76358158eafc1af1 fixed the parse failure, and 
ed1b9ce2bb2a2e51410e0a1754a72c110010a6a0 fixed the logging bug.

Please verify that you can build kguiaddons master with ECM master.


- Stephen


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129760/#review101827
---


On Jan. 3, 2017, 12:47 p.m., Shaheed Haque wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129760/
> ---
> 
> (Updated Jan. 3, 2017, 12:47 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kguiaddons
> 
> 
> Description
> ---
> 
> This depends on a fix in extra-cmake-module to actually emit the
> default value for the flags parameter.
> 
> 
> Diffs
> -
> 
>   autotests/pythontest.py c93e75397f87ba4a84f834dd248d671614ac89dd 
>   cmake/rules_PyKF5.py PRE-CREATION 
>   src/CMakeLists.txt 63e7598d13fa1c4d9d67e2f99edcc13e0269920e 
> 
> Diff: https://git.reviewboard.kde.org/r/129760/diff/
> 
> 
> Testing
> ---
> 
> Without this change, once the code the depends-on review is committed, 
> kguiaddons will fail to compile as follows:
> 
> In file included from /home/.../PyKF5/KGuiAddons/unifiedKGuiAddons.cpp:1:0:
> /home/.../PyKF5/KGuiAddons/sipKGuiAddonsKFontUtils.cpp: In function 
> ‘PyObject* meth_KFontUtils_adaptFontSize(PyObject*, PyObject*)’:
> /home/...d/PyKF5/KGuiAddons/sipKGuiAddonsKFontUtils.cpp:30:50: error: 
> ‘NoFlags’ was not declared in this scope
>  KFontUtils::AdaptFontSizeOptions a6def = NoFlags;
> 
> With the change, it compiles and the tests run:
> 
> $ ctest
> Test project /home/srhaque/kdebuild/kguiaddons
> Start 1: appstreamtest
> 1/6 Test #1: appstreamtest    Passed0.02 sec
> Start 2: Py3Test
> 2/6 Test #2: Py3Test ..   Passed0.13 sec
> Start 3: Py2Test
> 3/6 Test #3: Py2Test ..   Passed0.11 sec
> Start 4: kwordwraptest
> 4/6 Test #4: kwordwraptest    Passed0.16 sec
> Start 5: kcolorutilstest
> 5/6 Test #5: kcolorutilstest ..   Passed0.53 sec
> Start 6: kiconutilstest
> 6/6 Test #6: kiconutilstest ...   Passed0.08 sec
> 
> 100% tests passed, 0 tests failed out of 6
> 
> Total Test time (real) =   1.03 sec
> 
> 
> Thanks,
> 
> Shaheed H

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 201 - Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/201/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 13 Jan 2017 18:35:40 +
Build duration: 1 min 51 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5491/8008 
(69%)CONDITIONAL 2985/6178 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1466/1554 
(94%)CONDITIONAL 903/1792 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1766/3045 
(58%)CONDITIONAL 764/1892 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2043/2796 
(73%)CONDITIONAL 1233/2066 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 198 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/198/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 13 Jan 2017 18:21:45 +
Build duration: 1 min 51 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5482/8008 
(68%)CONDITIONAL 2969/6178 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1464/1554 
(94%)CONDITIONAL 895/1792 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1765/3045 
(58%)CONDITIONAL 762/1892 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2037/2796 
(73%)CONDITIONAL 1227/2066 (59%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

[Differential] [Closed] D4121: add support for display_name in categories

This revision was automatically updated to reflect the committed changes.
Closed by commit R235:6e4d27af5a8d: add support for display_name in categories 
(authored by mart).

REPOSITORY
  R235 Attica

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4121?vs=10139&id=10147

REVISION DETAIL
  https://phabricator.kde.org/D4121

AFFECTED FILES
  src/category.cpp
  src/category.h
  src/categoryparser.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, leinir
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Closed] D4120: add support for display_name in categories

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:7407ca5b4780: add support for display_name in categories 
(authored by mart).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4120?vs=10140&id=10146

REVISION DETAIL
  https://phabricator.kde.org/D4120

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/core/engine.cpp
  src/core/engine.h
  src/core/provider.h
  src/downloadwidget.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, leinir
Cc: kossebau, plasma-devel, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D4120: add support for display_name in categories

2017-01-13 Thread Friedrich W. H. Kossebau

kossebau added a comment.


  Sounds good. While touching this, have you considered localized display names?
  
  While content description might be still English as lingua-franca, having the 
display name localized might be another step into the direction of average 
users which are not fluent in English.

REPOSITORY
  R304 KNewStuff

BRANCH
  phab/displayname

REVISION DETAIL
  https://phabricator.kde.org/D4120

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, leinir
Cc: kossebau, plasma-devel, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Accepted] D4121: add support for display_name in categories

2017-01-13 Thread Dan Leinir Turthra Jensen

leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  This being an extension of ocs, we will need to prepare a proposal of this at 
some point in the not too far distant future. However, as other things (tags 
etc) are also going to be required, perhaps that could all be done at the same 
time. OCS being implementation-driven, and attica/ocs-server being the 
reference implementations, i did think that we might be venturing into 
embrace/extend territory here, however it is more akin to how OCS has always 
been developed (just more in the public eye now, rather than behind closed 
doors). So, yup, let's do this.

REPOSITORY
  R235 Attica

BRANCH
  phab/displayname

REVISION DETAIL
  https://phabricator.kde.org/D4121

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, leinir
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Accepted] D4120: add support for display_name in categories

2017-01-13 Thread Dan Leinir Turthra Jensen

leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  We will need to consider the implications of adding functionality into ocs, 
but technically this would be fine.

REPOSITORY
  R304 KNewStuff

BRANCH
  phab/displayname

REVISION DETAIL
  https://phabricator.kde.org/D4120

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, leinir
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated, 84 lines] D4120: add support for display_name in categories

mart updated this revision to Diff 10140.
mart added a comment.


  - code style

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4120?vs=10138&id=10140

BRANCH
  phab/displayname

REVISION DETAIL
  https://phabricator.kde.org/D4120

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/core/engine.cpp
  src/core/engine.h
  src/core/provider.h
  src/downloadwidget.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, leinir
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated] D4120: add support for display_name in categories

starbuck updated the summary for this revision.
starbuck updated the test plan for this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D4120

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, leinir
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated] D4121: add support for display_name in categories

starbuck updated the summary for this revision.

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D4121

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, leinir
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated] D4121: add support for display_name in categories

starbuck updated the summary for this revision.

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D4121

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, leinir
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated] D4121: add support for display_name in categories

starbuck updated the summary for this revision.
starbuck updated the test plan for this revision.

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D4121

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, leinir
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated] D4121: add support for display_name in categories

starbuck updated the summary for this revision.
starbuck updated the test plan for this revision.

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D4121

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, leinir
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated] D4121: add support for display_name in categories

mart added a dependent revision: D4120: add support for display_name in 
categories.

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D4121

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, leinir
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated] D4120: add support for display_name in categories

mart added a dependency: D4121: add support for display_name in categories.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D4120

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, leinir
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Request, 31 lines] D4121: add support for display_name in categories

mart created this revision.
mart added reviewers: Plasma, leinir.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  categories description on ocs now supports a new tag, that is disaplay_name
  which unlike name is supposed to be user friendly and be changeable
  by the server without clients actually breaking
  
  for instance
  https://api.kde-look.org/ocs/v1/content/categories

TEST PLAN
  wallpaper ghns dialog uses display names for categories now

REPOSITORY
  R235 Attica

BRANCH
  phab/displayname

REVISION DETAIL
  https://phabricator.kde.org/D4121

AFFECTED FILES
  src/category.cpp
  src/category.h
  src/categoryparser.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, leinir
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Request, 84 lines] D4120: add support for display_name in categories

mart created this revision.
mart added reviewers: Plasma, leinir.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  categories description on ocs now supports a new tag, that is disaplay_name
  which unlike name is supposed to be user friendly and be changeable
  by the server without clients actually breaking
  
  for instance
  https://api.kde-look.org/ocs/v1/content/categories

TEST PLAN
  wallpaper ghns dialog uses display names for categories now

REPOSITORY
  R304 KNewStuff

BRANCH
  phab/displayname

REVISION DETAIL
  https://phabricator.kde.org/D4120

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/core/engine.cpp
  src/core/engine.h
  src/core/provider.h
  src/downloadwidget.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, leinir
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Request, 5 lines] D4118: if is not an archive, always copy

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  for wallpapers, some items can be an archive, some aren't
  this may be true for other types of resources as well, so
  make this more general. if the downloaded file is not an archive,
  just copy it, instead of silently fail

TEST PLAN
  different types of assets still install correctly, all wallpapers now install

REPOSITORY
  R304 KNewStuff

BRANCH
  phab/isarchive

REVISION DETAIL
  https://phabricator.kde.org/D4118

AFFECTED FILES
  src/core/installation.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated] D4118: if is not an archive, always copy

mart added a reviewer: leinir.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D4118

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, leinir
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

Re: Review Request 129807: proposal: add ksvg2ico

2017-01-13 Thread René J . V . Bertin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129807/
---

(Updated Jan. 13, 2017, 1:22 p.m.)

Review request for KDE Frameworks, kdewin, Alex Merry, Christoph Feck, and
Hannah von Reth.

Changes
---

Now using QtIcoHandler from Qt 5.6.2 which has the same LGPL 2.1 as the rest of
ksvg2ico and should be fine.

I'm investigating using `QImageWriter` though, no need to maintain extra code
if it is already available in Qt itself.

Repository: kiconthemes

Description
---

Recently I committed a few changes to `ecm_add_app_icon` that make use of the
fact that KIconThemes includes a `ksvg2icns` utility, making it possible to
generate an application icon from an SVG file instead of from a series of PNG
files.

With the present patch I propose to add an updated and extensively rewritten
version of the ageing `svg2ico` tool from the KDEWin project to KIconThemes.
The goal is to have a proper and up-to-date tool to generate application icons
from SVG on MS Windows too.
This new version (named `ksvg2ico` in line with `ksvg2icns`) is a standalone
tool that combines SVG - PNG conversion with PNG - ICO conversion. More
accurately: it renders SVG files to an internal bitmap and then saves those
bitmaps (as BMP?) to the .ico file.

- it now handles sizes up to 256x256, in part thanks to syncing `QtIcoHandler`
with the version from Qt 5.7
- for that it uses a private copy of that class, with the unused read support
disabled. (qicohandler.h isn't available on Mac and Linux so I cannot check
building against Qt's internal version).
- a `--rcfile` option is provided, copied from `png2ico`.
- the PNG files are still saved and are left for debugging when `--debug` is
given.

I considered proposing it to KDEWin instead, but in the end I liked the idea
better to provide icon conversion utilities for Mac and Windows with a
framework, where they might also serve in a less KDE-centric context (and
cross-platform development).

Diffs (updated)
-

src/CMakeLists.txt efba9e6
src/tools/ksvg2ico/CMakeLists.txt PRE-CREATION
src/tools/ksvg2ico/ksvg2ico.cpp PRE-CREATION
src/tools/ksvg2ico/qicohandler.h PRE-CREATION
src/tools/ksvg2ico/qicohandler.cpp PRE-CREATION

Diff: https://git.reviewboard.kde.org/r/129807/diff/

Testing
---

On Mac OS X 10.9 with Qt 5.7.1 and KF5 5.29.0 .

File Attachments

.ico file generated from sc-apps-calligrakarbon.svgz using ksvg2ico with
Benkmann's png2ico

https://git.reviewboard.kde.org/media/uploaded/files/2017/01/11/aa0973dc-1be8-4d36-82dc-8f7baa053fee__apps-calligrakarbon.ico
.ico created by icotool from *-apps-calligrakarbon.png

https://git.reviewboard.kde.org/media/uploaded/files/2017/01/12/3bbee1f5-6770-4d6e-847d-e32c7e5d3fe1__icotool-apps-calligrakarbon.png
ico file generated by the standalone ksvg2ico

https://git.reviewboard.kde.org/media/uploaded/files/2017/01/12/7b286997-3100-47d0-800e-acb56ee9c68f__apps-calligrakarbon.ico

Thanks,

René J.V. Bertin

Jenkins-kde-ci: kinit master kf5-qt5 » Linux,gcc - Build # 376 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kinit%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/376/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 13 Jan 2017 10:42:46 +
Build duration: 1 min 4 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/3 (67%)FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 421/1756 
(24%)CONDITIONAL 154/1191 (13%)

By packages
  
src
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/15 (0%)CONDITIONAL 0/13 
(0%)
src.kdeinit
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 342/936 (37%)CONDITIONAL 
136/587 (23%)
src.klauncher
FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 79/805 (10%)CONDITIONAL 
18/591 (3%)

Jenkins-kde-ci: kinit master kf5-qt5 » Linux,gcc - Build # 376 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kinit%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/376/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 13 Jan 2017 10:42:46 +
Build duration: 1 min 4 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/3 (67%)FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 421/1756 
(24%)CONDITIONAL 154/1191 (13%)

By packages
  
src
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/15 (0%)CONDITIONAL 0/13 
(0%)
src.kdeinit
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 342/936 (37%)CONDITIONAL 
136/587 (23%)
src.klauncher
FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 79/805 (10%)CONDITIONAL 
18/591 (3%)

Re: Review Request 129809: KFontRequester: Find the nearest match for a missing font

2017-01-13 Thread Alexander Volkov


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129809/
---

(Updated Jan. 13, 2017, 12:45 p.m.)


Review request for KDE Frameworks and Christoph Feck.


Bugs: 286260
https://bugs.kde.org/show_bug.cgi?id=286260


Repository: kwidgetsaddons


Description
---

If the font is missing, then try to find the nearest font
family instead of just selecting the first family in the
list.

BUG: 286260


Diffs (updated)
-

  src/kfontrequester.cpp 6cca672b0284265daacd428d8bca9cec08da8910 

Diff: https://git.reviewboard.kde.org/r/129809/diff/


Testing
---


Thanks,

Alexander Volkov

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 197 - Unstable!