[Differential] [Closed] D4448: Don't use tier3 frameworks in unit tests

[Sune Vuorela]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:b42483f4cbdb: Rewrite tests to not use tier3 frameworks 
(authored by svuorela).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D4448?vs=10942=11351#toc

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4448?vs=10942=11351

REVISION DETAIL
  https://phabricator.kde.org/D4448

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/scalabletest.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: svuorela, vonreth, kde-frameworks-devel, dfaure, sitter
Cc: #frameworks

[Differential] [Commented On] D4234: Change algorithm for autobrace.

[Sven Brauch]

brauch added a comment.


  In https://phabricator.kde.org/D4234#86372, @anthonyfieroni wrote:
  
  > You mean when we have 3 open when 1 is close to be inserted 2 more to 
balance counting ? It's not a good idea, about me.
  
  
  No, but if you type a closing one right before a closing one, "eat" it iff 
there's no closing one missing right now.
  
  I don't think the suggested behaviour is worse than what we have now, but 
it's also not better IMO, so I'm not in favour of changing it ...

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4234

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: cactus, #ktexteditor
Cc: anthonyfieroni, dhaumann, brauch, cullmann, kwrite-devel, #frameworks

[Differential] [Updated] D4538: [KTextEditor] consistent conversion from/to cursor to/from coordinates

[John Salatas]

jsalatas added a reviewer: KTextEditor.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4538

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #frameworks, #plasma, #ktexteditor
Cc: plasma-devel, kwrite-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Commented On] D4190: Update file type on save only if path changes

[Mikko Perttunen]

mperttunen added a comment.


  Thanks, I don't think I do. My mail address is 'cyn...@kapsi.fi'.

REVISION DETAIL
  https://phabricator.kde.org/D4190

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mperttunen, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, #frameworks

[Differential] [Updated, 254 lines] D4537: EditorConfig support

[Grzegorz Szymaszek]

gszymaszek updated this revision to Diff 11349.
gszymaszek added a comment.


  Simplified the constructor and reduced parser indentation.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4537?vs=11279=11349

REVISION DETAIL
  https://phabricator.kde.org/D4537

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/document/editorconfig.cpp
  src/document/editorconfig.h
  src/document/katedocument.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, #ktexteditor
Cc: cullmann, dhaumann, kwrite-devel, #frameworks

[Differential] [Commented On] D4234: Change algorithm for autobrace.

[Anthony Fieroni]

anthonyfieroni added a comment.


  In https://phabricator.kde.org/D4234#85804, @brauch wrote:
  
  > Sorry, I wanted to write a reply but failed. My idea was simply to have the 
algorithm always aim to make parentheses balanced when closing one.
  
  
  You mean when we have 3 open when 1 is close to be inserted 2 more to balance 
counting ? It's not a good idea, about me.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4234

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: cactus, #ktexteditor
Cc: anthonyfieroni, dhaumann, brauch, cullmann, kwrite-devel, #frameworks

[Differential] [Changed Subscribers] D4234: Change algorithm for autobrace.

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> katedocument.cpp:2920-2921
> +(isEndBracket(chars[0]) || 
> + chars[0] == QLatin1Char('\'') || 
> + chars[0] == QLatin1Char('\"'))) {
> +

Why seach a checks ?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4234

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: cactus, #ktexteditor
Cc: anthonyfieroni, dhaumann, brauch, cullmann, kwrite-devel, #frameworks

[Differential] [Commented On] D4537: EditorConfig support

[Grzegorz Szymaszek]

gszymaszek added a comment.


  Yes, it was good when actual parsing was delegated to a separate function, 
but we’ve decided to merge all parsing-related functions.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4537

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, #ktexteditor
Cc: cullmann, dhaumann, kwrite-devel, #frameworks

[Differential] [Commented On] D4537: EditorConfig support

[Christoph Cullmann]

cullmann added a comment.


  Ok, then I would opt for removing the comment.
  
  Beside that, I think in some places early outs would be preferable to 
nesting, e.g. like
  
  if (code != 0) {
  
if (code == EDITORCONFIG_PARSE_MEMORY_ERROR) {
  
  ​qCDebug(LOG_KTE) << "Failed to parse .editorconfig, memory error 
occurred";
  
else
  
  ​qCDebug(LOG_KTE) << "Failed to parse .editorconfig, unknown error";
  
return code;
  
  }
  
  then the rest non-indented

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4537

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, #ktexteditor
Cc: cullmann, dhaumann, kwrite-devel, #frameworks

[Differential] [Commented On] D4537: EditorConfig support

[Grzegorz Szymaszek]

gszymaszek added a comment.


  In https://phabricator.kde.org/D4537#86356, @cullmann wrote:
  
  > On the other side, I see no real copyrightable material beside you are 
using the editor config API.
  
  
  As I’ve written, I used Builder’s source to //learn// that (1) I have to call 
`editorconfig_handle_init` and `editorconfig_parse` at the beginning, (2) I 
have to call `editorconfig_handle_get_name_value` to read EditorConfig’s 
results (and `editorconfig_handle_get_name_value_count` to make reading easier) 
and (3) I have to call `editorconfig_handle_destroy` to “close connection”. 
Implementation details come from API docs and my imagination.
  
  Maybe it isn’t a good idea to include that comment about Builder in this 
patch — the code isn’t a “port” (or copy) of Builder’s solution to KTextEditor, 
while that’s what such comment may wrongly suggest.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4537

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, #ktexteditor
Cc: cullmann, dhaumann, kwrite-devel, #frameworks

[Differential] [Commented On] D4537: EditorConfig support

[Christoph Cullmann]

cullmann added a comment.


  The problem with
  
  // reading .editorconfig files is loosely based on gnome-builder’s
  // libide/editorconfig/editorconfig-glib.c
  
  is that that code is GPL.
  
  On the other side, I see no real copyrightable material beside you are using 
the editor config API.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4537

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, #ktexteditor
Cc: cullmann, dhaumann, kwrite-devel, #frameworks

[Differential] [Closed] D4603: Use sentence style capitalization with label texts of edit fields

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:a2bc24bd3e59: Use sentence style capitalization with label 
texts of edit fields (authored by kossebau).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4603?vs=11318=11346

REVISION DETAIL
  https://phabricator.kde.org/D4603

AFFECTED FILES
  src/dialogs/bordersappearanceconfigwidget.ui
  src/dialogs/filetypeconfigwidget.ui
  src/dialogs/opensaveconfigwidget.ui
  src/dialogs/textareaappearanceconfigwidget.ui

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #kate, cullmann
Cc: cullmann, kwrite-devel, #frameworks

[Differential] [Commented On] D4234: Change algorithm for autobrace.

[Christoph Cullmann]

cullmann added a comment.


  As I don't use this myself, my opinion won't really matter.
  Sven, is the new proposed behavior really worse than the old?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4234

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: cactus, #ktexteditor
Cc: dhaumann, brauch, cullmann, kwrite-devel, #frameworks

[Differential] [Accepted] D4603: Use sentence style capitalization with label texts of edit fields

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a reviewer: cullmann.
cullmann added a comment.
This revision is now accepted and ready to land.


  Ok with that, thanks!

REPOSITORY
  R39 KTextEditor

BRANCH
  improveLabelTexts

REVISION DETAIL
  https://phabricator.kde.org/D4603

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #kate, cullmann
Cc: cullmann, kwrite-devel, #frameworks

[Differential] [Commented On] D4190: Update file type on save only if path changes

[Christoph Cullmann]

cullmann added a comment.


  If you have no commit rights, pass me your mail address for the commit, will 
do that for you.

REVISION DETAIL
  https://phabricator.kde.org/D4190

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mperttunen, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, #frameworks

[Differential] [Abandoned] D4587: [ContainmentInterface] Ungrab mouse on context menu close

[Anthony Fieroni]

anthonyfieroni abandoned this revision.
anthonyfieroni added a comment.


  https://phabricator.kde.org/D4455

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4587

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: anthonyfieroni, #plasma
Cc: graesslin, plasma-devel, davidedmundson, mart, #frameworks, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Request, 22 lines] D4607: finish support for opening compressed packages

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  it's possible to do setPath(zipfile path) and open
  a compressed package as it was a real one, done for
  uninstalling packages passing zips as parameters
  or installing plasmoids by drag and drop
  on the desktop, but this didn't really work
  as it wasn't incomplete as tempRoot should be
  used in place of d->path for the package to work and be valid.

TEST PLAN
  autotests still work, now installing plasmoids by drag and drop
  works

REPOSITORY
  R290 KPackage

BRANCH
  phab/temproot

REVISION DETAIL
  https://phabricator.kde.org/D4607

AFFECTED FILES
  src/kpackage/package.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Updated] D4575: add a popupmenuabouttoshow version that exposes the menu

[Eike Hein]

hein added a comment.


  In the review comment you write that users of the API can use the MIME data 
to decide whether to call setApplicationActions, but in 
https://phabricator.kde.org/D4576 you end up manipulating the provided QMenu 
instance directly, including code written in awareness of KIO implementation 
details like the "Determining MIME type" phase ... this expands the API 
contract from the signal to kind of include the UI design of the popup, which 
means KIO can never visualize this differently or drop QMenu for DropJob.
  
  Humm.
  
  I understand it's because async, but can we instead somehow teach the DropJob 
API to accept actions later, and instead of passing a QMenu around work with 
the DropJob and QActions to keep it UI-agnostic and the API contract 
documentable?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D4575

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: hein, plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

Baloo and Application using it

[Matthieu Gallien]

Hello,

I am using Baloo to collect all audio files in its database. I would like to 
keep the list up to date with the Baloo database when my application is 
running.

Currently Baloo DBus interface provides two information:
* the files currently being scanned: could help discover new files ;
* a signal with a list of modified files (as far as I understand, this is for 
metadata changes only).

I am missing notifications of moved files (with same metadata) or removed 
files.

I have thought of two solutions:
* adding in my application the use of file system watchers such that I am 
notified directly about the missing changes. This would duplicate watchers set 
by Baloo;
* adding code to Baloo to send signals about file moves and file deletes. 
Baloo is already keeping track of them.

By the way, I did not yet check if Tracker provides something covering my 
needs.

What do you think ?
Any advice would be much appreciated.

Best regards

[Differential] [Updated, 88 lines] D4589: EditorConfig module

[Grzegorz Szymaszek]

gszymaszek updated this revision to Diff 11329.
gszymaszek added a comment.


  Added description.

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4589?vs=11308=11329

REVISION DETAIL
  https://phabricator.kde.org/D4589

AFFECTED FILES
  find-modules/Findeditorconfig.cmake

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, #build_system, #frameworks, alexmerry
Cc: dhaumann

[Differential] [Commented On] D4589: EditorConfig module

[Dominik Haumann]

dhaumann added inline comments.

INLINE COMMENTS

> Findeditorconfig.cmake:2
> +#
> +# Copyright (c) 2016 João Valverde 
> +# All rights reserved.

1. Please add yourself as copyright holder.

2. Could you have a look at the comments at the very top of the other find 
modules in the extra-cmake-modules? There, you can find a ".rst" header that 
contains documentation about the find module, see e.g. libgit2 again. Could you 
add this documentation as well for this find module?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D4589

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, #build_system, #frameworks, alexmerry
Cc: dhaumann

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

[Kevin Funk]

kfunk added a comment.


  I start to agree that it's probably better to revert this patch, for the 
simple reason: We might break compilation of a project using boost if boost 
decides to add code which uses alternative tokens to any of its headers. This 
is not under our control.
  
  On the other hand, alternative tokens are indeed *rarely* used (at least in 
KDE they are mostly used b/c of simple typos) and only cause harm when code is 
being ported to MSVC. I'd like to avoid running into issues like that whenever 
possible.
  
  In general It'd be better to have a compiler *warning* instead when 
alternative tokens are used, but there isn't.
  
  I'm undecided -- Apparently we've already fixed all issues in KDE land (/me 
didn't hear any more complaints so far), so we're good in that are. But 
problems from upgrading versions of dependent libraries can still be a problem 
-- though still easily fixed by stripping the flag inside CMake user code...

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D3850

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk, #frameworks, #build_system, ivan
Cc: thomasp, rakuco, elvisangelaccio

[Differential] [Updated] D4342: Use texture atlas for static icon item

[David Rosca]

drosca added a comment.


  Yes.
  
  Latest master 
https://phabricator.kde.org/R242:263f119e17df7c24f8372710c555486429b57971 - 
broken.
  Latest master 
https://phabricator.kde.org/R242:263f119e17df7c24f8372710c555486429b57971 with 
this change reverted - fixed.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4342

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: drosca, mart, plasma-devel, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Differential] [Commented On] D4342: Use texture atlas for static icon item

[David Edmundson]

davidedmundson added a comment.


  This shouldn't have any impact to it being pixelated, it just changes where 
the texture is stored, it can't make it any smaller.
  
  Are you sure it's definitely this change?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4342

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: drosca, mart, plasma-devel, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

[Differential] [Accepted] D4448: Don't use tier3 frameworks in unit tests

[Harald Sitter]

sitter accepted this revision.
sitter added a comment.


  Ah! I hadn't even thought of QSettings. Love the change.
  
  FWIW if you fancy more work: seeing as the test now has its own enums you 
could align the Context enum values' names with their string representation 
allowing `parseContext` to work like `parseType` by letting the metaobject do 
the mapping.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4448

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: svuorela, vonreth, kde-frameworks-devel, dfaure, sitter
Cc: #frameworks

[Differential] [Closed] D4564: KToolTipWidget: hide tooltip in enterEvent if hideDelay is zero

[Elvis Angelaccio]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:8ab5a291e855: KToolTipWidget: hide tooltip in enterEvent 
if hideDelay is zero (authored by elvisangelaccio).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4564?vs=11209=11326

REVISION DETAIL
  https://phabricator.kde.org/D4564

AFFECTED FILES
  src/ktooltipwidget.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, cfeck
Cc: #frameworks

[Differential] [Accepted] D3826: Detect inotify.

[Kevin Funk]

kfunk accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  inotify

REVISION DETAIL
  https://phabricator.kde.org/D3826

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: adridg, apol, arrowdodger, #build_system, #frameworks, tcberner, ervin, 
skelly, dfaure, kfunk
Cc: kfunk, #freebsd

[Differential] [Commented On] D4342: Use texture atlas for static icon item

[David Rosca]

drosca added a comment.


  This broke rendering of icons in Quicklaunch plasmoid for me (Sandy Bridge 
GPU), you can see on the screenshot that it is pixelated. Also the image 
slightly moves during the active animation, as texture atlas is used only when 
animation is not running.
  I can only see this issue in Quicklaunch, but I can't really see anything 
wrong/special it is doing.
  
  F2472100: Spectacle.J14086.png 

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4342

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: drosca, mart, plasma-devel, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol