[Differential] [Closed] D4584: KDirWatch: replace QList by std::vector to save on new/delete.
dfaure closed this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D4584 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: dfaure, aacid, mwolff, mpyne Cc: smartins, mwolff, #frameworks
[Differential] [Updated] D4584: KDirWatch: replace QList by std::vector to save on new/delete.
dfaure marked an inline comment as done. dfaure added inline comments. INLINE COMMENTS > dfaure wrote in kdirwatch.cpp:371 > Good point. Done in https://commits.kde.org/kcoreaddons/d7fb4a5ff2fdec24a922aebbcdb5901a117f56cf REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D4584 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: dfaure, aacid, mwolff, mpyne Cc: smartins, mwolff, #frameworks
Jenkins-kde-ci: kcoreaddons master kf5-qt5 » Linux,gcc - Build # 193 - Failure!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/193/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 18 Feb 2017 10:24:48 + Build duration: 28 sec CHANGE SET Revision 0c67e68721fa69eb55856926ccc54ff30e514606 by David Faure: (KDirWatch: replace QList<Client *> by std::vector<Client> to save on) change: edit src/lib/io/kdirwatch_p.h change: edit src/lib/io/kdirwatch.cpp
Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 198 - Failure!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/198/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 18 Feb 2017 10:24:47 + Build duration: 2 min 9 sec CHANGE SET Revision 0c67e68721fa69eb55856926ccc54ff30e514606 by David Faure: (KDirWatch: replace QList<Client *> by std::vector<Client> to save on) change: edit src/lib/io/kdirwatch.cpp change: edit src/lib/io/kdirwatch_p.h
Jenkins-kde-ci: kcoreaddons master kf5-qt5 » Linux,gcc - Build # 194 - Still Failing!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/194/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 18 Feb 2017 10:26:59 + Build duration: 28 sec CHANGE SET Revision d7fb4a5ff2fdec24a922aebbcdb5901a117f56cf by David Faure: (Move the isDir() outside of the loop, as spotted by Milian.) change: edit src/lib/io/kdirwatch.cpp
Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 199 - Still Failing!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/199/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 18 Feb 2017 10:27:39 + Build duration: 1 min 48 sec CHANGE SET Revision d7fb4a5ff2fdec24a922aebbcdb5901a117f56cf by David Faure: (Move the isDir() outside of the loop, as spotted by Milian.) change: edit src/lib/io/kdirwatch.cpp
[Differential] [Accepted] D4620: allow to add application actions on an open menu
dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> dropjob.cpp:330
> +}
> +//separator at last position and not needed anymore?
> +if (d->m_appActions.isEmpty() && d->m_pluginActions.isEmpty() &&
Don't worry too much about that, QMenu automatically suppresses doubled
separators or separators at begin/end of the menu.
So I bet this if block isn't necessary in practice.
> dropjob.cpp:332
> +if (d->m_appActions.isEmpty() && d->m_pluginActions.isEmpty() &&
> +menu->actions().last()->isSeparator()) {
> +menu->removeAction(menu->actions().last());
If you do keep it, maybe add a check that menu->actions() isn't empty,
otherwise last() will assert.
REPOSITORY
R241 KIO
BRANCH
phab/setActionsLater
REVISION DETAIL
https://phabricator.kde.org/D4620
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma, dfaure
Cc: dfaure, hein, plasma-devel, #frameworks, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol
Re: Review Request 129921: [kio-extras] thumbnails should be a clean image representation without "hard-coded" borders or design elements
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129921/ --- (Updated Feb. 18, 2017, 10:52 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit db7f8d0c945880b0fbb5ea9ad8ed6817d6ba0340 by David Faure on behalf of Diego Soenens to branch Applications/16.12. Repository: kio-extras Description --- This patch is part of https://git.reviewboard.kde.org/r/129918/ - see the discussion on the old patch https://git.reviewboard.kde.org/r/118961/. Many thumbnail generators currently return ThumbCreator::DrawFrame in their flags() function which causes a 90's style 1px "3d" border to be added to the thumbnail image. This causes problems when consumers of these thumbnails (like Dolphin) expect a clean image representation of the file, without hard-coded design elements. It also looks really bad when any resizing/scaling happens or when the thumbnail is shown on a tooltip. Especially now that the UI has been modernized with Breeze. Diffs - thumbnail/comiccreator.cpp d8f4473e1c7fa4595ad8defc406ad945d1ac38ac thumbnail/djvucreator.cpp 1547831bfaa875a14a59659a2bebc86a2cd7c024 thumbnail/htmlcreator.cpp 29d1902794abfa3cf8ba2ab97648e1bc2d8e7a73 thumbnail/kritacreator.cpp 3b24bc3d2fa7b22662c25da1421cbd542d7efed6 thumbnail/textcreator.cpp 7c0263c8e8cb4f88d1429b5714c51c2939d817f0 Diff: https://git.reviewboard.kde.org/r/129921/diff/ Testing --- Builds. Thanks, Diego Soenens
Jenkins-kde-ci: kcoreaddons master kf5-qt5 » Linux,gcc - Build # 195 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/195/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 18 Feb 2017 11:01:48 + Build duration: 2 min 23 sec CHANGE SET Revision d323a2d60e65989b7c9332679e0b1f3dd217ac71 by David Faure: (GIT_SILENT fix compilation (looks like I'm missing FAM locally)) change: edit src/lib/io/kdirwatch.cpp JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 25 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 10/10 (100%)FILES 79/93 (85%)CLASSES 79/93 (85%)LINE 5907/8207 (72%)CONDITIONAL 10622/25190 (42%) By packages autotests FILES 33/40 (83%)CLASSES 33/40 (83%)LINE 2545/2651 (96%)CONDITIONAL 6481/13397 (48%) src.desktoptojson FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 84/106 (79%)CONDITIONAL 146/384 (38%) src.lib FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 302/536 (56%)CONDITIONAL 192/893 (22%) src.lib.caching FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 352/787 (45%)CONDITIONAL 197/1092 (18%) src.lib.io FILES 9/10 (90%)CLASSES 9/10 (90%)LINE 740/1397 (53%)CONDITIONAL 831/3218 (26%) src.lib.jobs FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 159/304 (52%)CONDITIONAL 57/146 (39%) src.lib.plugin FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 646/748 (86%)CONDITIONAL 1035/2326 (44%) src.lib.randomness FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/98 (66%)CONDITIONAL 40/66 (61%) src.lib.text FILES 5/8 (63%)CLASSES 5/8 (63%)LINE 349/764 (46%)CONDITIONAL 829/2052 (40%) src.lib.util FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 665/816 (81%)CONDITIONAL 814/1616 (50%)
Jenkins-kde-ci: kcoreaddons master kf5-qt5 » Linux,gcc - Build # 195 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/195/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 18 Feb 2017 11:01:48 + Build duration: 2 min 23 sec CHANGE SET Revision d323a2d60e65989b7c9332679e0b1f3dd217ac71 by David Faure: (GIT_SILENT fix compilation (looks like I'm missing FAM locally)) change: edit src/lib/io/kdirwatch.cpp JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 25 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 10/10 (100%)FILES 79/93 (85%)CLASSES 79/93 (85%)LINE 5907/8207 (72%)CONDITIONAL 10622/25190 (42%) By packages autotests FILES 33/40 (83%)CLASSES 33/40 (83%)LINE 2545/2651 (96%)CONDITIONAL 6481/13397 (48%) src.desktoptojson FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 84/106 (79%)CONDITIONAL 146/384 (38%) src.lib FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 302/536 (56%)CONDITIONAL 192/893 (22%) src.lib.caching FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 352/787 (45%)CONDITIONAL 197/1092 (18%) src.lib.io FILES 9/10 (90%)CLASSES 9/10 (90%)LINE 740/1397 (53%)CONDITIONAL 831/3218 (26%) src.lib.jobs FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 159/304 (52%)CONDITIONAL 57/146 (39%) src.lib.plugin FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 646/748 (86%)CONDITIONAL 1035/2326 (44%) src.lib.randomness FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/98 (66%)CONDITIONAL 40/66 (61%) src.lib.text FILES 5/8 (63%)CLASSES 5/8 (63%)LINE 349/764 (46%)CONDITIONAL 829/2052 (40%) src.lib.util FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 665/816 (81%)CONDITIONAL 814/1616 (50%)
Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 200 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/200/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 18 Feb 2017 11:01:43 + Build duration: 5 min 34 sec CHANGE SET Revision d323a2d60e65989b7c9332679e0b1f3dd217ac71 by David Faure: (GIT_SILENT fix compilation (looks like I'm missing FAM locally)) change: edit src/lib/io/kdirwatch.cpp JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 25 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 10/10 (100%)FILES 79/93 (85%)CLASSES 79/93 (85%)LINE 5907/8207 (72%)CONDITIONAL 10717/25433 (42%) By packages autotests FILES 33/40 (83%)CLASSES 33/40 (83%)LINE 2545/2651 (96%)CONDITIONAL 6489/13413 (48%) src.desktoptojson FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 84/106 (79%)CONDITIONAL 148/392 (38%) src.lib FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 302/536 (56%)CONDITIONAL 192/905 (21%) src.lib.caching FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 352/787 (45%)CONDITIONAL 199/1102 (18%) src.lib.io FILES 9/10 (90%)CLASSES 9/10 (90%)LINE 740/1397 (53%)CONDITIONAL 839/3234 (26%) src.lib.jobs FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 159/304 (52%)CONDITIONAL 57/146 (39%) src.lib.plugin FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 646/748 (86%)CONDITIONAL 1081/2424 (45%) src.lib.randomness FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/98 (66%)CONDITIONAL 40/66 (61%) src.lib.text FILES 5/8 (63%)CLASSES 5/8 (63%)LINE 349/764 (46%)CONDITIONAL 858/2135 (40%) src.lib.util FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 665/816 (81%)CONDITIONAL 814/1616 (50%)
Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 200 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/200/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 18 Feb 2017 11:01:43 + Build duration: 5 min 34 sec CHANGE SET Revision d323a2d60e65989b7c9332679e0b1f3dd217ac71 by David Faure: (GIT_SILENT fix compilation (looks like I'm missing FAM locally)) change: edit src/lib/io/kdirwatch.cpp JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 25 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 10/10 (100%)FILES 79/93 (85%)CLASSES 79/93 (85%)LINE 5907/8207 (72%)CONDITIONAL 10717/25433 (42%) By packages autotests FILES 33/40 (83%)CLASSES 33/40 (83%)LINE 2545/2651 (96%)CONDITIONAL 6489/13413 (48%) src.desktoptojson FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 84/106 (79%)CONDITIONAL 148/392 (38%) src.lib FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 302/536 (56%)CONDITIONAL 192/905 (21%) src.lib.caching FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 352/787 (45%)CONDITIONAL 199/1102 (18%) src.lib.io FILES 9/10 (90%)CLASSES 9/10 (90%)LINE 740/1397 (53%)CONDITIONAL 839/3234 (26%) src.lib.jobs FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 159/304 (52%)CONDITIONAL 57/146 (39%) src.lib.plugin FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 646/748 (86%)CONDITIONAL 1081/2424 (45%) src.lib.randomness FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/98 (66%)CONDITIONAL 40/66 (61%) src.lib.text FILES 5/8 (63%)CLASSES 5/8 (63%)LINE 349/764 (46%)CONDITIONAL 858/2135 (40%) src.lib.util FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 665/816 (81%)CONDITIONAL 814/1616 (50%)
Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 252 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/252/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 18 Feb 2017 11:05:34 + Build duration: 2 min 6 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kservicetest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 6/7 (86%)FILES 76/85 (89%)CLASSES 76/85 (89%)LINE 5484/8010 (68%)CONDITIONAL 2983/6230 (48%) By packages autotests FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1465/1555 (94%)CONDITIONAL 895/1792 (50%) src.kbuildsycoca FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 15/20 (75%) src.kdeinit FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 (0%) src.plugin FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 36/96 (38%) src.services FILES 30/31 (97%)CLASSES 30/31 (97%)LINE 1766/3046 (58%)CONDITIONAL 765/1904 (40%) src.sycoca FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2037/2796 (73%)CONDITIONAL 1238/2106 (59%) tests.pluginlocator FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 34/50 (68%)
Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 242 - Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/242/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 18 Feb 2017 11:08:04 + Build duration: 1 min 59 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kservicetest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 6/7 (86%)FILES 76/85 (89%)CLASSES 76/85 (89%)LINE 5486/8010 (68%)CONDITIONAL 2981/6230 (48%) By packages autotests FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1465/1555 (94%)CONDITIONAL 895/1792 (50%) src.kbuildsycoca FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 15/20 (75%) src.kdeinit FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 (0%) src.plugin FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 36/96 (38%) src.services FILES 30/31 (97%)CLASSES 30/31 (97%)LINE 1768/3046 (58%)CONDITIONAL 765/1904 (40%) src.sycoca FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2037/2796 (73%)CONDITIONAL 1236/2106 (59%) tests.pluginlocator FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 34/50 (68%)
Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 253 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/253/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 18 Feb 2017 11:08:27 + Build duration: 1 min 56 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kservicetest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 6/7 (86%)FILES 76/85 (89%)CLASSES 76/85 (89%)LINE 5485/8010 (68%)CONDITIONAL 2982/6230 (48%) By packages autotests FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1465/1555 (94%)CONDITIONAL 895/1792 (50%) src.kbuildsycoca FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 15/20 (75%) src.kdeinit FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 (0%) src.plugin FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 36/96 (38%) src.services FILES 30/31 (97%)CLASSES 30/31 (97%)LINE 1767/3046 (58%)CONDITIONAL 766/1904 (40%) src.sycoca FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2037/2796 (73%)CONDITIONAL 1236/2106 (59%) tests.pluginlocator FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 34/50 (68%)
[Differential] [Accepted] D4658: [KWidgetsAddons] Fix APIDOX issues raised by clang's -Wdocumentation
aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Looks good, fix the comments and commit! INLINE COMMENTS > kpagewidget.h:143 > * This signal is emitted whenever a checkable page changes its state. > @param checked is true > - * when the @param page is checked, or false if the @param page is > unchecked. > + * when the @p page is checked, or false if the @param page is unchecked. > */ Does the other @param in this line also need to be @p ? Or even removed? > kpagewidgetmodel.h:297 > * This signal is emitted whenever a checkable page changes its state. > @param checked is true > - * when the @param page is checked, or false if the @param page is > unchecked. > + * when the @p page is checked, or false if the @param page is unchecked. > */ Same as above REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D4658 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: cfeck, #frameworks, aacid Cc: aacid
[Differential] [Commented On] D4234: Change algorithm for autobrace.
dhaumann added a comment. Ok, I see. Then I would like you to look at how Qt Creator behaves here. And agree, then the proposed patch is maybe better than thought. If you want, you can even look into the implementation of Qt Creator... REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4234 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: cactus, #ktexteditor Cc: anthonyfieroni, dhaumann, brauch, cullmann, kwrite-devel, #frameworks
[Differential] [Updated] D4663: Allow setting the timeout value.
albertvaka added a reviewer: Frameworks. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4663 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: albertvaka, #frameworks Cc: #frameworks
[Differential] [Request, 43 lines] D4663: Allow setting the timeout value.
albertvaka created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D4663 AFFECTED FILES src/knotification.cpp src/knotification.h src/notifybypopup.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: albertvaka Cc: #frameworks
[Differential] [Updated] D4663: Allow setting the timeout value.
albertvaka added a reviewer: apol. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4663 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: albertvaka, #frameworks, apol Cc: #frameworks
[Differential] [Commented On] D4663: Allow setting the timeout value.
mck182 added a comment. This was discussed couple times before and the reason this was never added is because of potential misuse of this by setting extremely high value, making the bubble virtually sticked to your screen forever. This should be handled by the server that should do the right thing(tm) like eg. Plasma does a word count and then with simple heuristic determines the display time. Regardless of Plasma however, the server should always have a sensible default that all apps should follow, therefore this option was never added and I still think it shouldn't be there today; I can't see a reason why would you want the bubble to be displayed for either very short time or very long time. For anything in between the server default should be good enough. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4663 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: albertvaka, #frameworks, apol Cc: mck182, #frameworks
[Differential] [Commandeered] D4589: EditorConfig module
cullmann commandeered this revision. cullmann added a reviewer: gszymaszek. cullmann added a comment. Hi, I think ATM only ktexteditor will need this, therefore I will add a small find module to the ktexteditor repo. If this is proven to be useful for other frameworks, too, we can move it. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D4589 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: cullmann, #build_system, #frameworks, alexmerry, gszymaszek Cc: cullmann, dhaumann
[Differential] [Closed] D4589: EditorConfig module
This revision was automatically updated to reflect the committed changes. Closed by commit R39:6fa17cdccc06: add FindEditorConfig to ktexteditor if that proves to be useful, can be moved… (authored by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4589?vs=11329&id=11485#toc REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4589?vs=11329&id=11485 REVISION DETAIL https://phabricator.kde.org/D4589 AFFECTED FILES CMakeLists.txt cmake/FindEditorConfig.cmake EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: cullmann, #build_system, #frameworks, alexmerry, gszymaszek Cc: cullmann, dhaumann
[Differential] [Requested Changes] D4537: EditorConfig support
cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Hi, please adjust your patch to the EditorConfig find module commited to ktexteditor.git. Then this can land. Do you have commit rights? If not, paste your mail address and full name and I can push your change with you as author. commit with find module: https://commits.kde.org/ktexteditor/6fa17cdccc064b68ea7cba058eff9cac6332e6b9 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4537 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: gszymaszek, #ktexteditor, cullmann Cc: cullmann, dhaumann, kwrite-devel, #frameworks
[Differential] [Commented On] D4538: [KTextEditor] consistent conversion from/to cursor to/from coordinates
cullmann added a comment. > Currently if you try to convert the cursor to coordinates and then convert these coordinates back to a cursor again, it produces an invalid cursor (-1, -1) when the original cursor is located at the end of line > Converting back to cursor coordinates that have been produced by cursorToCoordinate(view->cursorPosition()) and cursorPositionCoordinates() doesn't always produce the same results as the includeBorder option doesn't seem to be used consistently. Yeah, that seems strange > Although I cannot find a test case for this, it doen't seem to make any sense the line scrollPos(max, max.column(), calledExternally); in KateViewInternal::makeVisible function. Was it supposed to be that way (ie force when the last line is not empty and not force when it is), or is it just a typo? :\ I would appreciate any reasoning about this! Hmm, I doubt anybody can remember why that is that way ;=) Could your create some minimal unit test to ensure this stays consistent? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4538 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jsalatas, #frameworks, #plasma, #ktexteditor Cc: cullmann, plasma-devel, kwrite-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Commented On] D4663: Allow setting the timeout value.
albertvaka added a comment. I understand the potential of it being misused, even though I don't think we should treat developers as if they didn't know what they are doing. Also, if we want to have a maximum timeout, this is something that should be enforced on the server (ie: Plasma) instead of the client. There will be apps using libnotify or any other lib that can set their timeouts. The reason I added this is because in KDE Connect we show notifications when there is an incoming "pair request", and I wanted to make the notification stay there for as long as the request is valid. Since the notification is the only way to accept the pair request, I think it results in a bad user experience if the notification disappears before the user can act on it. There is an alternative solution to my use case: making the notification persistent and manually dismissing it when the request is no longer valid, but I've decided to not implement it this way because some notification servers don't support persistent notifications (eg: Ubuntu Unity). What do you think? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4663 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: albertvaka, #frameworks, apol Cc: mck182, #frameworks
[Differential] [Commented On] D4663: Allow setting the timeout value.
mck182 added a comment. I see your usecase, but I think there might be better solution overall and that would involve not actually depending on the notification. As you say, servers should enforce maximum timeout, Plasma does just that and there's no safe way to predict what other servers would do. You could simply create a StatusNotifierItem with "demands-attention" state, that would cause it to blink, pulse or do whatever the implementation does. The good thing about this is that this would be animated in the screen basically forever while not being obtrusive. In Plasma it even raises a panel that is hidden. It's also fully cross platform and in fact, it is where the persistent notifications should evolve into (where persistent is the persistence you're looking for in your usecase). This would be in addition to the regular notification, not its replacement. Clicking the SNI would result in the exact same action you'd get from the notification. Plus, KSNI lives in the KNotification lib, so no new dependency. How's that? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4663 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: albertvaka, #frameworks, apol Cc: mck182, #frameworks
[Differential] [Commented On] D4538: [KTextEditor] consistent conversion from/to cursor to/from coordinates
brauch added a comment. Looks sensible to me, but can you check that it doesn't break KDevelop's navigation widget? I think that is the most visible use case for that interface right now. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4538 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jsalatas, #frameworks, #plasma, #ktexteditor Cc: brauch, cullmann, plasma-devel, kwrite-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Updated, 256 lines] D4537: EditorConfig support
gszymaszek updated this revision to Diff 11486. gszymaszek marked 5 inline comments as done. gszymaszek added a comment. Updated to work with new `cmake/FindEditorConfig.cmake`. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4537?vs=11366&id=11486 REVISION DETAIL https://phabricator.kde.org/D4537 AFFECTED FILES src/CMakeLists.txt src/document/editorconfig.cpp src/document/editorconfig.h src/document/katedocument.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: gszymaszek, cullmann, #ktexteditor Cc: cullmann, dhaumann, kwrite-devel, #frameworks
[Differential] [Commented On] D4663: Allow setting the timeout value.
albertvaka added a comment. I don't think indicators are the future of notifications :/ If you have a look at modern systems like Android (which had the luxury of designing a notification system without having to think about legacy), they have nothing like app indicators: they use persistent notifications instead. Gnome has also taken that way [1], so if we make appindicarors a core part of kdeconnect, we will never look native on Gnome... I'm trying to find a different solution. [1] https://wiki.gnome.org/Design/OS/MessageTray/Compatibility REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4663 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: albertvaka, #frameworks, apol Cc: mck182, #frameworks
[Differential] [Commented On] D4537: EditorConfig support
gszymaszek added a comment. In https://phabricator.kde.org/D4537#87411, @cullmann wrote: > Do you have commit rights? If not, paste your mail address and full name and I can push your change with you as author. No, I don’t have. Grzegorz Szymaszek, `gszymas...@short.pl`. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4537 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: gszymaszek, cullmann, #ktexteditor Cc: cullmann, dhaumann, kwrite-devel, #frameworks
Re: Baloo and Application using it
On mardi 14 février 2017 08:17:33 CET Matthieu Gallien wrote: > Hello, > > I am using Baloo to collect all audio files in its database. I would like to > keep the list up to date with the Baloo database when my application is > running. > > Currently Baloo DBus interface provides two information: > * the files currently being scanned: could help discover new files ; > * a signal with a list of modified files (as far as I understand, this is > for metadata changes only). > > I am missing notifications of moved files (with same metadata) or removed > files. > > I have thought of two solutions: > * adding in my application the use of file system watchers such that I am > notified directly about the missing changes. This would duplicate watchers > set by Baloo; > * adding code to Baloo to send signals about file moves and file deletes. > Baloo is already keeping track of them. I don't know much (if anything) about Baloo, but from what you say it wouldn't cost much for baloo to emit these signals, since it has the information already. So it seems to me you could go ahead and write a patch for baloo to do this. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5
[Differential] [Updated, 26 lines] D4538: [KTextEditor] consistent conversion from/to cursor to/from coordinates
jsalatas updated this revision to Diff 11494.
jsalatas added a comment.
1. I abandoned the 3rd issue I mention in the summary about the line
`scrollPos(max, max.column(), calledExternally);` as I could neither verify nor
disprove if this was intended or not.
2. In `cursorToCoordinate()` I added an extra check to see if we are behind
end of line and return and invalid point (-1, -1):
if (cursor.column() > layout.lineLayout().textLength()) {
return QPoint(-1, -1);
}
as according to QT's documentation
(http://doc.qt.io/qt-5/qtextline.html#cursorToX)
> If cursorPos is not a valid cursor position, the nearest valid cursor
position will be used instead, and cursorPos will be modified to point to this
valid cursor position.
and without this extra check, the "behind end of line should give an invalid
cursor" tests in kateview_test.cpp would fail.
3. I also added the relevant tests to kateview_test.cpp, as per cullmann's
feedback.
4. KDevelop seems to work.
I have checked it and I didn't see any issues to the Navigation Widget popup
tooltips which indeed seems to extensively use coversions between cursors and
coordinates, as mentioned by brauch. Furthermore:
- cursorPositionCoordinates isn't used in kdevelop and kdevplatform, so the
2nd issue described in the summary shouldn't affect kdevelop and kdevplatform
in any way.
- 1st issue in the summary is related to cursors/positions at the end of
line, so my intuition suggests that it wouldn't be related to any context
related to kdevelop. :)
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4538?vs=11137&id=11494
REVISION DETAIL
https://phabricator.kde.org/D4538
AFFECTED FILES
autotests/src/kateview_test.cpp
src/view/kateview.cpp
src/view/kateviewinternal.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: jsalatas, #frameworks, #plasma, #ktexteditor
Cc: brauch, cullmann, plasma-devel, kwrite-devel, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol
