Jenkins-kde-ci: khtml master stable-kf5-qt5 » Linux,gcc - Build # 230 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/khtml%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/230/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 30 Mar 2017 20:05:04 +
Build duration: 13 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 19/23 (83%)FILES 308/626 (49%)CLASSES 308/626 (49%)LINE 3032/94737 
(3%)CONDITIONAL 2853/152458 (2%)

By packages
  
default>
FILES 2/8 (25%)CLASSES 2/8 (25%)LINE 2/593 (0%)CONDITIONAL 
4/683 (1%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 53/57 (93%)CONDITIONAL 
27/56 (48%)
src
FILES 20/31 (65%)CLASSES 20/31 (65%)LINE 931/8827 
(11%)CONDITIONAL 832/18736 (4%)
src.css
FILES 12/25 (48%)CLASSES 12/25 (48%)LINE 32/9368 
(0%)CONDITIONAL 32/15763 (0%)
src.dom
FILES 29/40 (73%)CLASSES 29/40 (73%)LINE 61/7091 
(1%)CONDITIONAL 66/4880 (1%)
src.ecma
FILES 24/50 (48%)CLASSES 24/50 (48%)LINE 27/8351 
(0%)CONDITIONAL 47/19781 (0%)
src.editing
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 20/2100 (1%)CONDITIONAL 
11/4037 (0%)
src.html
FILES 21/47 (45%)CLASSES 21/47 (45%)LINE 21/10643 
(0%)CONDITIONAL 42/16139 (0%)
src.imload
FILES 4/31 (13%)CLASSES 4/31 (13%)LINE 24/854 (3%)CONDITIONAL 
14/641 (2%)
src.imload.decoders
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 19/616 (3%)CONDITIONAL 
10/692 (1%)
src.misc
FILES 13/27 (48%)CLASSES 13/27 (48%)LINE 837/3716 
(23%)CONDITIONAL 707/5318 (13%)
src.platform
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/2 (0%)CONDITIONAL 0/0 
(100%)
src.platform.graphics
FILES 0/16 (0%)CLASSES 0/16 (0%)LINE 0/534 (0%)CONDITIONAL 
0/308 (0%)
src.platform.graphics.qt
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/248 (0%)CONDITIONAL 0/176 
(0%)
src.platform.text
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/7 (0%)CONDITIONAL 0/4 (0%)
src.rendering
FILES 48/97 (49%)CLASSES 48/97 (49%)LINE 64/23896 
(0%)CONDITIONAL 95/32971 (0%)
src.svg
FILES 72/147 (49%)CLASSES 72/147 (49%)LINE 746/5897 
(13%)CONDITIONAL 816/14593 (6%)
src.svg.graphics
FILES 7/14 (50%)CLASSES 7/14 (50%)LINE 7/283 (2%)CONDITIONAL 
14/344 (4%)
src.svg.graphics.qt
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 6/156 (4%)CONDITIONAL 
12/329 (4%)
src.ui.findbar
FILES 2/4 (50%)CLASSES 2/4 (50%)LINE 21/505 (4%)CONDITIONAL 
8/910 (1%)
src.ui.passwordbar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 28/60 (47%)CONDITIONAL 
39/106 (37%)
src.xml
FILES 20/38 (53%)CLASSES 20/38 (53%)LINE 116/9560 
(1%)CONDITIONAL 59/13239 (0%)
src.xpath
FILES 9/15 (60%)CLASSES 9/15 (60%)LINE 17/1373 (1%)CONDITIONAL 
18/2752 (1%)

Jenkins-kde-ci: khtml master stable-kf5-qt5 » Linux,gcc - Build # 230 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/khtml%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/230/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 30 Mar 2017 20:05:04 +
Build duration: 13 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 19/23 (83%)FILES 308/626 (49%)CLASSES 308/626 (49%)LINE 3032/94737 
(3%)CONDITIONAL 2853/152458 (2%)

By packages
  
default>
FILES 2/8 (25%)CLASSES 2/8 (25%)LINE 2/593 (0%)CONDITIONAL 
4/683 (1%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 53/57 (93%)CONDITIONAL 
27/56 (48%)
src
FILES 20/31 (65%)CLASSES 20/31 (65%)LINE 931/8827 
(11%)CONDITIONAL 832/18736 (4%)
src.css
FILES 12/25 (48%)CLASSES 12/25 (48%)LINE 32/9368 
(0%)CONDITIONAL 32/15763 (0%)
src.dom
FILES 29/40 (73%)CLASSES 29/40 (73%)LINE 61/7091 
(1%)CONDITIONAL 66/4880 (1%)
src.ecma
FILES 24/50 (48%)CLASSES 24/50 (48%)LINE 27/8351 
(0%)CONDITIONAL 47/19781 (0%)
src.editing
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 20/2100 (1%)CONDITIONAL 
11/4037 (0%)
src.html
FILES 21/47 (45%)CLASSES 21/47 (45%)LINE 21/10643 
(0%)CONDITIONAL 42/16139 (0%)
src.imload
FILES 4/31 (13%)CLASSES 4/31 (13%)LINE 24/854 (3%)CONDITIONAL 
14/641 (2%)
src.imload.decoders
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 19/616 (3%)CONDITIONAL 
10/692 (1%)
src.misc
FILES 13/27 (48%)CLASSES 13/27 (48%)LINE 837/3716 
(23%)CONDITIONAL 707/5318 (13%)
src.platform
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/2 (0%)CONDITIONAL 0/0 
(100%)
src.platform.graphics
FILES 0/16 (0%)CLASSES 0/16 (0%)LINE 0/534 (0%)CONDITIONAL 
0/308 (0%)
src.platform.graphics.qt
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/248 (0%)CONDITIONAL 0/176 
(0%)
src.platform.text
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/7 (0%)CONDITIONAL 0/4 (0%)
src.rendering
FILES 48/97 (49%)CLASSES 48/97 (49%)LINE 64/23896 
(0%)CONDITIONAL 95/32971 (0%)
src.svg
FILES 72/147 (49%)CLASSES 72/147 (49%)LINE 746/5897 
(13%)CONDITIONAL 816/14593 (6%)
src.svg.graphics
FILES 7/14 (50%)CLASSES 7/14 (50%)LINE 7/283 (2%)CONDITIONAL 
14/344 (4%)
src.svg.graphics.qt
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 6/156 (4%)CONDITIONAL 
12/329 (4%)
src.ui.findbar
FILES 2/4 (50%)CLASSES 2/4 (50%)LINE 21/505 (4%)CONDITIONAL 
8/910 (1%)
src.ui.passwordbar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 28/60 (47%)CONDITIONAL 
39/106 (37%)
src.xml
FILES 20/38 (53%)CLASSES 20/38 (53%)LINE 116/9560 
(1%)CONDITIONAL 59/13239 (0%)
src.xpath
FILES 9/15 (60%)CLASSES 9/15 (60%)LINE 17/1373 (1%)CONDITIONAL 
18/2752 (1%)

Jenkins-kde-ci: khtml master stable-kf5-qt5 » Linux,gcc - Build # 229 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/khtml%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/229/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 30 Mar 2017 19:35:07 +
Build duration: 15 min

CHANGE SET
Revision ce81d9cbf23b4ab95649a9c249290569c9def0cb by Luigi Toscano: (Error 
page, correctly load the image (with a real URL))
  change: edit src/khtml_part.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 3 
test(s)Failed: TestSuite.khtml-kencodingdetectortestFailed: 
TestSuite.khtml-parttest

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  

D5104: Error page, correctly load the image (with a real URL)

[Luigi Toscano]

This revision was automatically updated to reflect the committed changes.
Closed by commit R313:ce81d9cbf23b: Error page, correctly load the image (with 
a real URL) (authored by ltoscano).

REPOSITORY
  R313 KHtml

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5104?vs=12606=13013

REVISION DETAIL
  https://phabricator.kde.org/D5104

AFFECTED FILES
  src/khtml_part.cpp

To: ltoscano, mpyne
Cc: mpyne, #frameworks

D5178: QtCurve/Qt5 : further KF5 adaptation

[René J . V . Bertin]

rjvbb added a comment.


  In https://phabricator.kde.org/D5178#99097, @ltoscano wrote:
  
  >
  
  
  
  
  > Differential Revision: https://phabricator.kde.org/D5178
  
  I suppose it would technically be possible to support `REVIEW:` instead of 
`Differential Revision:` on a commit's last line once RB has been retired for 
good? It'd be shorter and clearer (natural language vs. rather silly Phab. 
specific jargon).

REPOSITORY
  R626 QtCurve

REVISION DETAIL
  https://phabricator.kde.org/D5178

To: rjvbb, yuyichao
Cc: ltoscano, #frameworks, yuyichao

D5178: QtCurve/Qt5 : further KF5 adaptation

[Luigi Toscano]

ltoscano set the repository for this revision to R626 QtCurve.

REPOSITORY
  R626 QtCurve

REVISION DETAIL
  https://phabricator.kde.org/D5178

To: rjvbb, yuyichao
Cc: ltoscano, #frameworks, yuyichao

D5178: QtCurve/Qt5 : further KF5 adaptation

[Luigi Toscano]

ltoscano added a comment.


  In order to properly close the review, please either use arcanist (suggested 
method) or the last line should have been:
  Differential Revision: https://phabricator.kde.org/D5178

REVISION DETAIL
  https://phabricator.kde.org/D5178

To: rjvbb, yuyichao
Cc: ltoscano, #frameworks, yuyichao

D5178: QtCurve/Qt5 : further KF5 adaptation

[René J . V . Bertin]

rjvbb closed this revision.
rjvbb added a comment.


  https://commits.kde.org/qtcurve/820a35e02cc6c31a4db9dccf40a83ba7a771dd03

REVISION DETAIL
  https://phabricator.kde.org/D5178

To: rjvbb, yuyichao
Cc: #frameworks, yuyichao

D5178: QtCurve/Qt5 : further KF5 adaptation

[René J . V . Bertin]

rjvbb added a comment.


  In https://phabricator.kde.org/D5178#99057, @yuyichao wrote:
  
  > Is this the new review platform?
  
  
  Yep.
  
  > LGTM. Hopefully I'm doing the right action here (phabricator always 
seem to have way more buttons than I need..)
  
  I think so. Phab is indeed considerably less intuitive than ReviewBoard was. 
It appears it's designed for software professionals (whatever that 
means/implies ;) ).

REVISION DETAIL
  https://phabricator.kde.org/D5178

To: rjvbb, yuyichao
Cc: #frameworks, yuyichao

D5178: QtCurve/Qt5 : further KF5 adaptation

[Yichao Yu]

yuyichao accepted this revision.
yuyichao added a comment.
This revision is now accepted and ready to land.


  Is this the new review platform?
  
  LGTM. Hopefully I'm doing the right action here (phabricator always seem 
to have way more buttons than I need..)

REVISION DETAIL
  https://phabricator.kde.org/D5178

To: rjvbb, yuyichao
Cc: #frameworks, yuyichao

D5143: Introduce fetch-translations build command

[Aleix Pol Gonzalez]

apol marked an inline comment as done.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D5143

To: apol, #frameworks, #build_system, kfunk, ltoscano, aacid
Cc: sitter

D5143: Introduce fetch-translations build command

[Aleix Pol Gonzalez]

apol updated this revision to Diff 13006.
apol added a comment.


  Few improvements
  
  Use regex to figure out the repo name
  Improve comment when fetching translations indicating what it's fetching
  Correct arguments to add_custom_target

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5143?vs=12868=13006

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5143

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake

To: apol, #frameworks, #build_system, kfunk, ltoscano, aacid
Cc: sitter

D5143: Introduce fetch-translations build command

[Aleix Pol Gonzalez]

apol added a comment.


  > This only works if you used kde:okular but not 
git://anongit.kde.org/okular.git, no?
  
  Addressed on the next interation.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D5143

To: apol, #frameworks, #build_system, kfunk, ltoscano, aacid
Cc: sitter

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

[Chinmoy Ranjan Pradhan]

> On March 22, 2017, 10:08 a.m., Elvis Angelaccio wrote:
> > src/ioslaves/file/kauth/file.actions, lines 1-5
> > 
> >
> > I don't see the advantage of using a single kauth action. This way you 
> > are generating only one "generic" polkit action that you can either enable 
> > or disable. Instead if we used one polkit action per operation (del, rmdir, 
> > etc.) we could allow a more fine-grained control. For example, a sysadmin 
> > could decide that the users can create files in write protected locations, 
> > but they cannot delete existing files.
> 
> Chinmoy Ranjan Pradhan wrote:
> Some operation may use more than one polkit action like Delete. If we use 
> one polkit action per operation then we will have to provide credentials for 
> every polkit action that operation might use. Though we can add necessary 
> code for this but it will only complicate the matter.
> 
> > we could allow a more fine-grained control
> 
> Does this involve editing the policy file directly or just writing a 
> config file? In later case we can provide control over execution of actions 
> within the ioslave. 'execWithRoot' can perform a check prior to execution of 
> the polkit action.
> 
> Elvis Angelaccio wrote:
> > Some operation may use more than one polkit action like Delete. If we 
> use one polkit action per operation then we will have to provide credentials 
> for every polkit action that operation might use.
> 
> But only if the actions are different, right? Otherwise we should be fine 
> within the 5 minutes threshold after the first authentication. Can you show 
> some concrete examples where this issue would happen?
> 
> > Does this involve editing the policy file directly or just writing a 
> config file?
> 
> Have a look at polkit rules. For example, one could write a rule that 
> says "org.kde.kio.file.copy is allowed, org.kde.kio.file.del is not." and it 
> would be very cool if we could actually support this.
> 
> Chinmoy Ranjan Pradhan wrote:
> >But only if the actions are different, right? Otherwise we should be 
> fine within the 5 minutes threshold after the first authentication. Can you 
> show some concrete examples where this issue would happen?
> 
> Delteing a non-empty directory
> In this operation 'del' and 'rmdir' actions are used. In this case we 
> will have to authenticate for both the actions. And after the first 
> authentication, doing a similar operation will show the warning dialog twice.
> 
> Copy operation can also be considered.
> This operation will consist of six actions which are file_open, sendfile, 
> read, write, file_close, chown. Although all the actions will not be used at 
> once usage of atleast two can be expected. Here also we will have to 
> authenticate ouself atleast twice just for copying a single file which is 
> very annoying.
> 
> >it would be very cool if we could actually support this.
> 
> Indeed its very cool and useful,but still, we will have all these 
> problems.
> 
> One possible solution can be using the **annotate** tag. Polkit doc 
> mentions its **used for annotating an action with a key/value pair**. If the 
> _value_ is **org.freedesktop.policykit.imply** then **the subject if 
> authorized for an action with this annotation is also authorized for any 
> action specified by the annotation**.
> So what I did is added this line ``` key="org.freedesktop.policykit.imply">org.kde.kio.file.rmdir``` 
> after the defaults tag of _del_ action. After this when I tried deleting a 
> non-empty folder I only got one auth dialog. One more thing I noticed is, 
> with this line in place, when I deleted a single file deleting an empty 
> folder afterwards only showed one warning even though the action was 
> different and was executing for this first time.
> 
> I'm still not sure about this so I might be completely wrong as well. If 
> you have any knowledge of this please let me know if I got everything or 
> anything right. And if what I have mentioned is indeed correct then we will 
> have to add the support for _annotate_ tag to kauth policy generator.
> 
> Elvis Angelaccio wrote:
> The *imply* annotation sounds very promising, might be exactly what we 
> are looking for. Unfortunately I don't know more details about it, at the 
> moment.
> 
> Another solution (possibly simpler) could be a middle ground between 
> "only one generic action" and "one action per operation". For example, we 
> could have a `org.kde.kio.file.delete` action that handles everything about 
> deletion: single file, empty folder, non-empty folder, etc.
> 
> Chinmoy Ranjan Pradhan wrote:
> Merging actions sounds good. I have updated the patch as per your 
> suggestion. We can merge some other action as well, like,
> file_open, sendfile, read, write, file_close --> to _copy_
> 

D5247: [ModelContextMenu] Silence warnings

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:edb05ef98983: [ModelContextMenu] Silence warnings 
(authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5247?vs=12985=13004

REVISION DETAIL
  https://phabricator.kde.org/D5247

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/ModelContextMenu.qml

To: broulik, #plasma, mart
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5247: [ModelContextMenu] Silence warnings

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5247

To: broulik, #plasma, mart
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol