D5443: fix duplicated symbols compilation error with mingw on Windows

[Matthieu Gallien]

mgallien added a reviewer: kfunk.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D5443

To: mgallien, kfunk
Cc: #frameworks

D5439: API dox: more info about KAboutData's orgDomain/desktopFileName properties

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> kossebau wrote in kaboutdata.h:314
> Update from irc: both @ltoscano and me could reproduce by patching 
> kpartloader or okteta that with some current KF (e.g. 5.32) the i18n calls 
> done as part of the KAboutData constructor call seem to fail when done before 
> the QApplication instance is created (yes,  
> KLocalizedString::setApplicationDomain() always called before the first 
> i18n() call).
> 
> Given that the requirement of an qapp instance is nowhere documented in 
> https://api.kde.org/frameworks/ki18n/html/prg_guide.html the question now is 
> if that is a regression or simply never has worked.
> 
> More on that another day though.

Aha! i18n() calls before the creation of QApplication instance currently fail 
(or rather: only return the untranslated string) for this reason:
gettext(), as used internally by ki18n, looks at the locale names set for the 
different locale categories (LC_*). By default at program start, those are all 
fixed to "C". Only if they are set to "" (empty string) then the environment 
variables are looked at, otherwise those are ignored for the respective 
category.
To unlock all categories for being set via the environment variables, the 
quickest way is to call `setlocale(LC_ALL, "");`. And this is what is done 
during the Q*Application instance creation, on Unix.

That is why before QApplication app(c, v); any calls to i18n will return the 
untranslated version, because internally "C" is set as value for LC_MESSAGES 
category, ignoring whatever the respective environment variables contain. Only 
after qapp sets "" as locale name for the LC_MESSAGES category via the 
mentioned call, gettext() will fall back to get the locale name from the env 
var, with the "LANGUAGE" var being the first taken into account, which is also 
the one ki18n uses to pass the locale name for which a catalog has been found.

See also
http://man7.org/linux/man-pages/man3/setlocale.3.html
https://code.woboq.org/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp.html#_ZN23QCoreApplicationPrivate10initLocaleEv
http://stackoverflow.com/questions/25661295/why-does-qcoreapplication-call-setlocalelc-all-by-default-on-unix-linux

No instant proposal myself how this could/should be fixed best.

Possibly it should be simply only documented, that code either has to delay any 
i18n calls until QApplication instance is created. And if one really needs to 
use i18n() calls without a QApp instance, to call `setlocale(LC_ALL, "");` one 
itself, and then restore any previous value perhaps even, just to stay clean.
 In any case: no i18n() in static construction code, that is racy and should be 
simply considered to not work.

So tasks seem to be:

1. change the example code to have needed order
2. write patch for ki18n docu
3. make some blog post to raise awareness

First though: device-less leisure time :)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D5439

To: kossebau, #frameworks, stikonas, mpyne, aacid, ltoscano
Cc: dfaure

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 515 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/515/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 14 Apr 2017 01:56:44 +
Build duration: 6 min 15 sec

CHANGE SET
Revision e011b901edd84107598fdd1c39c7588755edde0e by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit src/new_file_templates/linkURL.desktop
  change: edit src/widgets/konqpopupmenuplugin.desktop
  change: edit src/new_file_templates/HTMLFile.desktop
  change: edit src/kcms/kio/uasproviders/firefox520oncurrent.desktop
  change: edit src/kcms/kio/uasproviders/chrome570oncurrent.desktop
  change: edit src/kssld/kssld.json
  change: edit src/kpac/proxyscout.json
  change: edit src/new_file_templates/Directory.desktop
  change: edit src/new_file_templates/TextFile.desktop
  change: edit src/kcms/kio/smb.desktop
  change: edit src/new_file_templates/linkProgram.desktop
  change: edit src/urifilters/ikws/searchproviders/soundcloud.desktop
  change: edit src/kpasswdserver/kpasswdserver.json
  change: edit src/ioslaves/http/kcookiejar/kcookiejar.json
  change: edit src/new_file_templates/linkPath.desktop
  change: edit src/kcms/kio/useragent.desktop


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 
53 test(s)Failed: TestSuite.kiofilewidgets-kfilewidgettest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 22/22 (100%)FILES 275/344 (80%)CLASSES 275/344 (80%)LINE 29951/52022 
(58%)CONDITIONAL 16415/39075 (42%)

By packages
  
autotests
FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7971/8288 
(96%)CONDITIONAL 4448/8694 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 8088/14183 
(57%)CONDITIONAL 4437/9267 (48%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3460/7561 
(46%)CONDITIONAL 1289/4381 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 447/849 (53%)CONDITIONAL 
330/749 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1767/3780 
(47%)CONDITIONAL 1275/3460 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 
607/839 (72%)
src.ioslaves.remote
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 70/258 (27%)CONDITIONAL 
14/200 (7%)
src.ioslaves.trash
FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 727/1173 
(62%)CONDITIONAL 411/851 (48%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 707/785 (90%)CONDITIONAL 
461/970 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 372/594 (63%)CONDITIONAL 
276/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 
150/546 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 
16/26 (62%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 
332/412 (81%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3665/11070 
(33%)CONDITIONAL 1762/7138 (25%)

D5439: API dox: more info about KAboutData's orgDomain/desktopFileName properties

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> ltoscano wrote in kaboutdata.h:314
> To put it straight: I don't know (and I can't investigate properly now). But 
> if you create the KAboutData instance before the call to QApplication, part 
> of the "About " dialog is untranslated.

Update from irc: both @ltoscano and me could reproduce by patching kpartloader 
or okteta that with some current KF (e.g. 5.32) the i18n calls done as part of 
the KAboutData constructor call seem to fail when done before the QApplication 
instance is created (yes,  KLocalizedString::setApplicationDomain() always 
called before the first i18n() call).

Given that the requirement of an qapp instance is nowhere documented in 
https://api.kde.org/frameworks/ki18n/html/prg_guide.html the question now is if 
that is a regression or simply never has worked.

More on that another day though.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D5439

To: kossebau, #frameworks, stikonas, mpyne, aacid, ltoscano
Cc: dfaure

D5439: API dox: more info about KAboutData's orgDomain/desktopFileName properties

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> kossebau wrote in kaboutdata.h:314
> Why should it happen before? (sorry for being stubborn and curious here, I 
> want to make sure to understand all code, to then also write proper warnings 
> in the dox when needed, so people know they should not create it before).
> 
> The thing I understood Albert to point to yesterday was KMainWindow 
> auto-filling the translator info in the application metadata (see 
> KMainWindowPrivate::init(...), 
> https://cgit.kde.org/kxmlgui.git/tree/src/kmainwindow.cpp#n239). But we also 
> found that this actually has nothing to do with the Q*App instance vs. 
> KAboutData instance (besides KMainWindow expecting the QApp instance to exist 
> and KApplicationData::setAppData() having been called).
> The other mention was the TODO added by kf5/convert-kcmdlineargs.pl, 
> Sadly the commit which added that TODO does it only as side-effect and 
> without any reasoning: 
> https://cgit.kde.org/kde-dev-scripts.git/commit/kf5/convert-kcmdlineargs.pl?id=ac74bc07de810ef5a51a3030bfa96980f72ad8b1
> And from all code path I have seen there is nothing in the KAboutData 
> constructor which requires a QApp instance. And the related i18n calls also 
> are said nowhere said to require a QApp instance.
> @dfaure The above being your commit, do you remember (he, only 2 years ago ;) 
> ) your motivation for that TODO?

Bah, forgot to write: That TODO would only be really needed for the

  KAboutData::setApplicationData(aboutData);

as that is something that changed compared to kdelibs4, where setting the 
appdata before the qapp creation was fine. But in KF5 it now longer is. But the 
actual KAboutData itself should be fine without.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D5439

To: kossebau, #frameworks, stikonas, mpyne, aacid, ltoscano
Cc: dfaure

D5439: API dox: more info about KAboutData's orgDomain/desktopFileName properties

[Luigi Toscano]

ltoscano added inline comments.

INLINE COMMENTS

> kossebau wrote in kaboutdata.h:314
> Why should it happen before? (sorry for being stubborn and curious here, I 
> want to make sure to understand all code, to then also write proper warnings 
> in the dox when needed, so people know they should not create it before).
> 
> The thing I understood Albert to point to yesterday was KMainWindow 
> auto-filling the translator info in the application metadata (see 
> KMainWindowPrivate::init(...), 
> https://cgit.kde.org/kxmlgui.git/tree/src/kmainwindow.cpp#n239). But we also 
> found that this actually has nothing to do with the Q*App instance vs. 
> KAboutData instance (besides KMainWindow expecting the QApp instance to exist 
> and KApplicationData::setAppData() having been called).
> The other mention was the TODO added by kf5/convert-kcmdlineargs.pl, 
> Sadly the commit which added that TODO does it only as side-effect and 
> without any reasoning: 
> https://cgit.kde.org/kde-dev-scripts.git/commit/kf5/convert-kcmdlineargs.pl?id=ac74bc07de810ef5a51a3030bfa96980f72ad8b1
> And from all code path I have seen there is nothing in the KAboutData 
> constructor which requires a QApp instance. And the related i18n calls also 
> are said nowhere said to require a QApp instance.
> @dfaure The above being your commit, do you remember (he, only 2 years ago ;) 
> ) your motivation for that TODO?

To put it straight: I don't know (and I can't investigate properly now). But if 
you create the KAboutData instance before the call to QApplication, part of the 
"About " dialog is untranslated.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D5439

To: kossebau, #frameworks, stikonas, mpyne, aacid, ltoscano
Cc: dfaure

D5439: API dox: more info about KAboutData's orgDomain/desktopFileName properties

[Friedrich W. H. Kossebau]

kossebau added a subscriber: dfaure.
kossebau added inline comments.

INLINE COMMENTS

> ltoscano wrote in kaboutdata.h:314
> The QApplication instance should happen before this line, not just before 
> setApplicationData (that's what Albert was trying to explain).

Why should it happen before? (sorry for being stubborn and curious here, I want 
to make sure to understand all code, to then also write proper warnings in the 
dox when needed, so people know they should not create it before).

The thing I understood Albert to point to yesterday was KMainWindow 
auto-filling the translator info in the application metadata (see 
KMainWindowPrivate::init(...), 
https://cgit.kde.org/kxmlgui.git/tree/src/kmainwindow.cpp#n239). But we also 
found that this actually has nothing to do with the Q*App instance vs. 
KAboutData instance (besides KMainWindow expecting the QApp instance to exist 
and KApplicationData::setAppData() having been called).
The other mention was the TODO added by kf5/convert-kcmdlineargs.pl, 
Sadly the commit which added that TODO does it only as side-effect and without 
any reasoning: 
https://cgit.kde.org/kde-dev-scripts.git/commit/kf5/convert-kcmdlineargs.pl?id=ac74bc07de810ef5a51a3030bfa96980f72ad8b1
And from all code path I have seen there is nothing in the KAboutData 
constructor which requires a QApp instance. And the related i18n calls also are 
said nowhere said to require a QApp instance.
@dfaure The above being your commit, do you remember (he, only 2 years ago ;) ) 
your motivation for that TODO?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D5439

To: kossebau, #frameworks, stikonas, mpyne, aacid, ltoscano
Cc: dfaure

D5439: API dox: more info about KAboutData's orgDomain/desktopFileName properties

[Luigi Toscano]

ltoscano requested changes to this revision.
ltoscano added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kaboutdata.cpp:689
>  
>  KAboutData ::setOrganizationDomain(const QByteArray )
>  {

I would add something like
// KF6: if desktopFileName has not been explicitly set, set it to domain + 
component name

> kaboutdata.h:314
> + * // create the aboutData instance
> + * KAboutData aboutData("foo", i18n("Foo"), "0.1",
> + *  i18n("To Foo or not To Foo"),

The QApplication instance should happen before this line, not just before 
setApplicationData (that's what Albert was trying to explain).

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D5439

To: kossebau, #frameworks, stikonas, mpyne, aacid, ltoscano

D5439: API dox: more info about KAboutData's orgDomain/desktopFileName properties

[Friedrich W. H. Kossebau]

kossebau created this revision.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  Adds an example for setting the metadata of an application using KAboutData
  together with KI18n and KDBusAddons.
  Extends and improves notes about when and why to set the organizationDomain
  and the desktopFileName.

REPOSITORY
  R244 KCoreAddons

BRANCH
  improveKAboutDataAPIDox

REVISION DETAIL
  https://phabricator.kde.org/D5439

AFFECTED FILES
  src/lib/kaboutdata.cpp
  src/lib/kaboutdata.h

To: kossebau, #frameworks, stikonas, mpyne, aacid, ltoscano

D5167: Move .po and .ts files look-up to build-time

[Aleix Pol Gonzalez]

apol updated this revision to Diff 13404.
apol added a comment.


  AUTHOR_WARNING

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5167?vs=13392=13404

BRANCH
  fetchbuildtime

REVISION DETAIL
  https://phabricator.kde.org/D5167

AFFECTED FILES
  CMakeLists.txt
  cmake/KF5I18NMacros.cmake
  cmake/build-pofiles.cmake
  cmake/build-tsfiles.cmake

To: apol, #frameworks, ltoscano, ilic, sitter
Cc: aacid

D5431: New LESS syntax based on SCSS

[Yunhe Guo]

guoyunhe created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  It is a modified version of SCSS syntax. Major difference is variable start 
with @ instead of $. It performs better with LESS' nested rules and major 
language features.
  
  Customize function and some advanced usage may not look so good. But they are 
rarely used. The fall back style is still readable.

TEST PLAN
  F3683508: Screenshot_20170413_211810.png 

  
  F3683522: standard.less 

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D5431

AFFECTED FILES
  data/syntax/less.xml

To: guoyunhe, #kate
Cc: #frameworks

Re: Continuous Integration on Windows

[Kevin Funk]

On Thursday, 13 April 2017 18:25:19 CEST Matthieu Gallien wrote:
> Hello,
> 
> I am trying to use KFileMetaData on Windows with mingw-5.3 32 bits. I am
> getting compilation errors in the automatic tests and have an hard time
> getting it to works nominally.

Paste the errors please, maybe we can fix.
 
> Is there public servers currently testing KDE Frameworks 5 including
> KFileMetaData ?

Still no servers which compile KF5 master on a regular basis under Windows, 
unfortunately.

> Should I switch to Microsoft compilers ?

Not necessarily, KF5 /should/ compile fine under both MinGW & MSVC.

Cheers,
Kevin

> Thanks in advance for your help
> 
> Best regards
> 
> --
> Matthieu Gallien


-- 
Kevin Funk | kf...@kde.org | http://kfunk.org

signature.asc
Description: This is a digitally signed message part.

D5430: KDECompilerSettings: Pass -Wvla & -Wdate-time

[Kevin Funk]

kfunk added a comment.


  For -Wdate-time:
  https://lxr.kde.org/search?_filestring=&_string=__DATE__
  https://lxr.kde.org/search?_filestring=&_string=__TIME__
  
  -> Only around ~10 locations affected, mainly Krita/Digikam/Amarok stuff. The 
use of __DATE__ & __TIME__ should just be avoided.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D5430

To: kfunk
Cc: #frameworks, #build_system

D5430: KDECompilerSettings: Pass -Wvla & -Wdate-time

[Kevin Funk]

kfunk edited the summary of this revision.
kfunk edited the test plan for this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D5430

To: kfunk
Cc: #frameworks, #build_system

D5430: KDECompilerSettings: Pass -Wvla & -Wdate-time

[Kevin Funk]

kfunk created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.

REVISION SUMMARY
  -Wvla: Warn because it's non-standard feature, not supported by MSVC to date
  -Wdate-time: Warn because using __TIME__ or __DATE__ prevents
  
reproducible builds
  
  These warnings are being used for *building* Qt itself as well (cf.
  qt_common.prf in qtbase)

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5430

AFFECTED FILES
  kde-modules/KDECompilerSettings.cmake

To: kfunk
Cc: #frameworks, #build_system

Continuous Integration on Windows

[Matthieu Gallien]

Hello,

I am trying to use KFileMetaData on Windows with mingw-5.3 32 bits. I am 
getting compilation errors in the automatic tests and have an hard time 
getting it to works nominally.

Is there public servers currently testing KDE Frameworks 5 including 
KFileMetaData ?

Should I switch to Microsoft compilers ?

Thanks in advance for your help

Best regards

--
Matthieu Gallien

D5167: Move .po and .ts files look-up to build-time

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> KF5I18NMacros.cmake:136
> +function(ki18n_install_ts_files _lang)
> +message(WARNING "KI18N_INSTALL_TS_FILES is deprecated!")
> +ki18n_install(${_lang})

Please use `message(AUTHOR_WARNING ...` this warning has only relevance to a 
developer, not a user compiling an affected source tree. (neon's auto-QA for 
example ignores dev warnigns ;))

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D5167

To: apol, #frameworks, ltoscano, ilic, sitter
Cc: aacid

D5167: Move .po and .ts files look-up to build-time

[Aleix Pol Gonzalez]

apol updated this revision to Diff 13392.
apol marked 2 inline comments as done.
apol added a comment.


  Address some issues pointed at by sitter

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5167?vs=13118=13392

BRANCH
  fetchbuildtime

REVISION DETAIL
  https://phabricator.kde.org/D5167

AFFECTED FILES
  CMakeLists.txt
  cmake/KF5I18NMacros.cmake
  cmake/build-pofiles.cmake
  cmake/build-tsfiles.cmake

To: apol, #frameworks, ltoscano, ilic, sitter
Cc: aacid

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 515 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/515/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 13 Apr 2017 11:49:36 +
Build duration: 19 min

CHANGE SET
Revision 99b3a4c920aee7bdce20f7bfedadf9bb183b8f3c by David Edmundson: (Fix 
KDirlister Gui Test setting URL scheme twice)
  change: edit tests/kdirlistertest_gui.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 
53 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 22/22 (100%)FILES 275/344 (80%)CLASSES 275/344 (80%)LINE 30015/52022 
(58%)CONDITIONAL 16440/39075 (42%)

By packages
  
autotests
FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7971/8288 
(96%)CONDITIONAL 4448/8694 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 8133/14183 
(57%)CONDITIONAL 4453/9267 (48%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3464/7561 
(46%)CONDITIONAL 1293/4381 (30%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 447/849 (53%)CONDITIONAL 
330/749 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1759/3780 
(47%)CONDITIONAL 1266/3460 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 
607/839 (72%)
src.ioslaves.remote
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 70/258 (27%)CONDITIONAL 
14/200 (7%)
src.ioslaves.trash
FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 737/1173 
(63%)CONDITIONAL 420/851 (49%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 707/785 (90%)CONDITIONAL 
461/970 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 
150/546 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 
16/26 (62%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 
332/412 (81%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3673/11070 
(33%)CONDITIONAL 1765/7138 (25%)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 515 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/515/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 13 Apr 2017 11:49:36 +
Build duration: 19 min

CHANGE SET
Revision 99b3a4c920aee7bdce20f7bfedadf9bb183b8f3c by David Edmundson: (Fix 
KDirlister Gui Test setting URL scheme twice)
  change: edit tests/kdirlistertest_gui.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 
53 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 22/22 (100%)FILES 275/344 (80%)CLASSES 275/344 (80%)LINE 30015/52022 
(58%)CONDITIONAL 16440/39075 (42%)

By packages
  
autotests
FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7971/8288 
(96%)CONDITIONAL 4448/8694 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 8133/14183 
(57%)CONDITIONAL 4453/9267 (48%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3464/7561 
(46%)CONDITIONAL 1293/4381 (30%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 447/849 (53%)CONDITIONAL 
330/749 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1759/3780 
(47%)CONDITIONAL 1266/3460 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 
607/839 (72%)
src.ioslaves.remote
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 70/258 (27%)CONDITIONAL 
14/200 (7%)
src.ioslaves.trash
FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 737/1173 
(63%)CONDITIONAL 420/851 (49%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 707/785 (90%)CONDITIONAL 
461/970 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 
150/546 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 
16/26 (62%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 
332/412 (81%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3673/11070 
(33%)CONDITIONAL 1765/7138 (25%)

D5299: Fix KDirlister Gui Test setting URL scheme twice

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:99b3a4c920ae: Fix KDirlister Gui Test setting URL scheme 
twice (authored by davidedmundson).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5299?vs=13087=13384

REVISION DETAIL
  https://phabricator.kde.org/D5299

AFFECTED FILES
  tests/kdirlistertest_gui.cpp

To: davidedmundson, #frameworks, kfunk, dfaure
Cc: markg

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 399 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/399/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Thu, 13 Apr 2017 11:01:58 +
Build duration: 4 min 0 sec

CHANGE SET
Revision 1387b5efe31e330777c8ffd9029f79063cc7a7a9 by David Edmundson: (Guard 
against Applet not loading AppletInterface)
  change: edit src/scriptengines/qml/plasmoid/containmentinterface.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 
15 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 80/117 (68%)CLASSES 80/117 (68%)LINE 4623/11454 
(40%)CONDITIONAL 2468/8652 (29%)

By packages
  
autotests
FILES 26/26 (100%)CLASSES 26/26 (100%)LINE 1000/1047 
(96%)CONDITIONAL 640/1272 (50%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 618/1984 
(31%)CONDITIONAL 258/1240 (21%)
src.plasma
FILES 15/22 (68%)CLASSES 15/22 (68%)LINE 1669/3556 
(47%)CONDITIONAL 978/2673 (37%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 51/65 (78%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 13/22 (59%)CLASSES 13/22 (59%)LINE 873/1571 
(56%)CONDITIONAL 407/1018 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 7/13 (54%)CLASSES 7/13 (54%)LINE 334/1721 
(19%)CONDITIONAL 157/1307 (12%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/6 (33%)CLASSES 2/6 (33%)LINE 11/1217 (1%)CONDITIONAL 
1/992 (0%)

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 399 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/399/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Thu, 13 Apr 2017 11:01:58 +
Build duration: 4 min 0 sec

CHANGE SET
Revision 1387b5efe31e330777c8ffd9029f79063cc7a7a9 by David Edmundson: (Guard 
against Applet not loading AppletInterface)
  change: edit src/scriptengines/qml/plasmoid/containmentinterface.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 
15 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 80/117 (68%)CLASSES 80/117 (68%)LINE 4623/11454 
(40%)CONDITIONAL 2468/8652 (29%)

By packages
  
autotests
FILES 26/26 (100%)CLASSES 26/26 (100%)LINE 1000/1047 
(96%)CONDITIONAL 640/1272 (50%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 618/1984 
(31%)CONDITIONAL 258/1240 (21%)
src.plasma
FILES 15/22 (68%)CLASSES 15/22 (68%)LINE 1669/3556 
(47%)CONDITIONAL 978/2673 (37%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 51/65 (78%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 13/22 (59%)CLASSES 13/22 (59%)LINE 873/1571 
(56%)CONDITIONAL 407/1018 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 7/13 (54%)CLASSES 7/13 (54%)LINE 334/1721 
(19%)CONDITIONAL 157/1307 (12%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/6 (33%)CLASSES 2/6 (33%)LINE 11/1217 (1%)CONDITIONAL 
1/992 (0%)

D5423: Guard against Applet not loading AppletInterface

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:1387b5efe31e: Guard against Applet not loading 
AppletInterface (authored by davidedmundson).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5423?vs=13376=13381

REVISION DETAIL
  https://phabricator.kde.org/D5423

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: davidedmundson, #plasma, mart
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5405: Create desktop file name based on organization domain unless set explicitely

[Andrius Štikonas]

stikonas added a comment.


  > ! In https://phabricator.kde.org/D5405#101683, @graesslin wrote:
  >  My comment was not meant as a stop-this-effort comment. If we can improve 
here to do more sane things I'm all for it.
  
  No, it's not your comment. We were discussing this on #kde-devel and it looks 
like any improvements would require changes to the documented behaviour of 
KAboutData. And it could be that some apps are relying on it (although I think 
it's unlikely), so we didn't reach the consensus on what can be done in KF5, 
although everybody agreed things could be made saner for KF6...
  
  In any quite a few apps in 17.04 or 17.08 and extragear are now fixed and I 
also asked some 3rd party Qt apps to fix things, i.e. qbittorrent, qtox already 
merged fixes in git. I think people are just not aware enough about the various 
issues (its not unwillingness to fix them), even those mentioned in your 
blog... Actually even plasmashell hasn't fixed it's icon in wayland

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D5405

To: stikonas, mpyne, kossebau, aacid, ltoscano
Cc: nalvarez, graesslin, mak, plasma-devel, kde-frameworks-devel, #frameworks, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol

D5423: Guard against Applet not loading AppletInterface

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D5423

To: davidedmundson, #plasma, mart
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5423: Guard against Applet not loading AppletInterface

[David Edmundson]

davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  This can happen if an applet has invalid metadata, it doesn't have a
  script engine set (X-Plasma-API) so it won't load the DeclarativeAppletScripts
  Having invalid metadata could come from the applet, or from the fallback 
applet
  created in Containment::Private::createApplet.
  
  We guard against it in appletAdded but not in appletRemoved, which is
  inconsistent. We also apparently must have guards elsewhere otherwise
  we'd see the crash more.
  
  BUG: 377050

TEST PLAN
  Had corrupt applet, used to crash, now doesn't

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D5423

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol